WebKit-https.git
9 years ago<rdar://problem/7879485> Leopard: Crash after opening Software Update dialog
ggaren@apple.com [Wed, 21 Apr 2010 20:05:01 +0000 (20:05 +0000)]
<rdar://problem/7879485> Leopard: Crash after opening Software Update dialog

Reviewed by Sam Weinig.

* JSUtils.cpp:
(unprotectGlobalObject): Use the version of JSGlueAPIEntry that doesn't
call pthread_getspecific, since it's not safe to call pthread_getspecific
from a thread-specific data destructor. (<rdar://problem/7889842>
pthread_getspecific returns 0 when called from thread-specific data
destructor function)

(getThreadGlobalObject): Make sure to set the currentIdentifierTable
when first constructing our JSGlobalObject, since JSGlueAPIEntry has not
yet had an opportunity to do so.

(JSGlueAPIEntry::JSGlueAPIEntry):
* JSUtils.h: New version of JSGlueAPIEntry that doesn't call
pthread_getspecific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoErrk! tree on fire, add fwd!
barraclough@apple.com [Wed, 21 Apr 2010 19:56:50 +0000 (19:56 +0000)]
Errk! tree on fire, add fwd!

Reviewed by NOBODY (build fix).

* ForwardingHeaders/wtf/text/StringHash.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Wed, 21 Apr 2010 19:52:58 +0000 (19:52 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (windows build fix pt. 2).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: * JavaScriptCore.gypi:
barraclough@apple.com [Wed, 21 Apr 2010 19:49:35 +0000 (19:49 +0000)]
JavaScriptCore: * JavaScriptCore.gypi:
* JavaScriptCore.pro:
* wtf/qt/StringQt.cpp: Copied from WebCore/platform/text/qt/StringQt.cpp.

Reviewed by NOBODY (Qt build fix).

WebCore: * WebCore.gypi:
* WebCore.pro:
* platform/text/qt/StringQt.cpp: Removed.

Reviewed by NOBODY (Qt build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 21 Apr 2010 19:49:28 +0000 (19:49 +0000)]
2010-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        new-run-webkit-tests: fix a bug in the Chromium port where we would
        try to talk to a crashed test_shell and raise exceptions that weren't
        being caught.

        https://bugs.webkit.org/show_bug.cgi?id=37941

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 21 Apr 2010 19:41:23 +0000 (19:41 +0000)]
2010-04-21  James Robinson  <jamesr@chromium.org>

        Updating chromium expectations for tests that need new layoutTestController
        functionality.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* API/JSValueRef.cpp:
barraclough@apple.com [Wed, 21 Apr 2010 19:40:20 +0000 (19:40 +0000)]
* API/JSValueRef.cpp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
* runtime/Identifier.h:
* wtf/WTFThreadData.h:
(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):

Reviewed by NOBODY (windows build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed. Sheriffing cleanup.
ajwong@chromium.org [Wed, 21 Apr 2010 19:19:23 +0000 (19:19 +0000)]
Not reviewed. Sheriffing cleanup.

[chromium] Add bug numbers for expectations created during sheriffing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
barraclough@apple.com [Wed, 21 Apr 2010 19:13:50 +0000 (19:13 +0000)]
JavaScriptCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.

Reviewed by Oliver Hunt, Darin Adler.

JSC::UStringImpl and WebCore::StringImpl (soon to be renamed to
WTF::StringImpl) are almost identical.  Remove duplication of code by unifying
the two, move missing features from UStringImpl into StringImpl & delete the
class UStringImpl.

* API/JSClassRef.cpp:
* API/JSContextRef.cpp:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.pro:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/EvalCodeCache.h:
* bytecode/JumpTable.cpp:
* profiler/ProfileNode.cpp:
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/Identifier.h:
(JSC::Identifier::equal):
* runtime/UString.cpp:
* runtime/UString.h:
(WTF::):
* runtime/UStringImpl.cpp: Removed.
* runtime/UStringImpl.h:
* wtf/text/StringHash.h:
(WebCore::StringHash::equal):
(WebCore::CaseFoldingHash::equal):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::empty):
(WebCore::StringImpl::sharedBuffer):
(WebCore::equal):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):
(WebCore::StringImpl::cost):
(WebCore::StringImpl::isIdentifier):
(WebCore::StringImpl::setIsIdentifier):
(WebCore::StringImpl::computeHash):
(WebCore::StringImpl::copyChars):
(WebCore::StringImpl::):

JavaScriptGlue: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add forwarding header.

Reviewed by Oliver Hunt, Darin Adler.

* ForwardingHeaders/wtf/ASCIICType.h: Added.
* ForwardingHeaders/wtf/text/StringImpl.h: Added.

WebCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add include for StringHash.h.

Reviewed by Oliver Hunt, Darin Adler.

* WebCore.xcodeproj/project.pbxproj:
* bridge/c/c_class.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 21 Apr 2010 19:08:02 +0000 (19:08 +0000)]
2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        [Qt] [Symbian] Build fix.

        Work around a Qt quirk. Some versions of Symbian port Qt
        QFontDatabase::removeAllApplicationFonts symbol is not available.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed.
ap@apple.com [Wed, 21 Apr 2010 18:32:00 +0000 (18:32 +0000)]
    Unreviewed.

        https://bugs.webkit.org/show_bug.cgi?id=37933
        <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

        Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
        a real implementation may or may not be necessary for the one test that currently uses it
        to pass.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::authenticateSession):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed bug URL
mitz@apple.com [Wed, 21 Apr 2010 18:29:38 +0000 (18:29 +0000)]
Fixed bug URL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago https://bugs.webkit.org/show_bug.cgi?id=37933
ap@apple.com [Wed, 21 Apr 2010 18:14:56 +0000 (18:14 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=37933
        <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

        * platform/qt/Skipped: Skip the new test on Qt. There is nothing special about it,
        existing related tests are skipped already.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Tiger build fix.
ap@apple.com [Wed, 21 Apr 2010 18:11:28 +0000 (18:11 +0000)]
    Tiger build fix.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::createNSURLConnection): Fixed a typo, named an argument.
        (WebCore::ResourceHandle::start): Moved shouldUseCredentialStorage out of #if, since it's
        now passed to createNSURLConneciton() on all platforms (and then ignored on Tiger).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Adam Roben.
ap@apple.com [Wed, 21 Apr 2010 18:07:48 +0000 (18:07 +0000)]
    Reviewed by Adam Roben.

        Windows build fix.

        * platform/network/cf/ResourceHandleCFNet.cpp: Declare CFURLConnectionCreateWithProperties
        for now, as it's mistakenly missing from WebKitSupportLibrary headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 21 Apr 2010 17:34:04 +0000 (17:34 +0000)]
2010-04-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test.
        https://bugs.webkit.org/show_bug.cgi?id=37902

        The issue is due to MSVC creating enums as signed. The fix is to store the value
        as unsigned.

        Test: http://acid3.acidtests.org/

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags): Changed type of _insideLink to unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Brady Eidson.
ap@apple.com [Wed, 21 Apr 2010 17:33:09 +0000 (17:33 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=37933
        <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.

        Test: http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html

        This improves integration between ResourceHandle and Apple networking libraries.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::createConnectionProperties): A new helper for creating connection properties dictionary.
        (WebCore::ResourceHandle::start): Pass connection properties.
        (WebCore::WebCoreSynchronousLoader::load): Ditto.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::createNSURLConnection): Factor out OS version dependent code for creating
        NSURLConnection. Tell NSURLConnection about credential policy upfront.
        (WebCore::ResourceHandle::start): Use the new function.
        (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 21 Apr 2010 17:30:09 +0000 (17:30 +0000)]
2010-04-21  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dimitri Glazkov

        This patch fixes [chromium] RTL <select> dropdown box expands to right
        instead of left.
        https://bugs.webkit.org/show_bug.cgi?id=37232

        No automatic test is possible.

        * manual-tests/select_dropdown_box_alignment.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::layout): Adjust the x-axis of dropdown box
        for RTL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 anton muhin <antonm@google.com>
eric@webkit.org [Wed, 21 Apr 2010 17:21:36 +0000 (17:21 +0000)]
2010-04-21  anton muhin  <antonm@google.com>

        Reviewed by Adam Barth.

        [v8] Bail out if fetching of Object.prototype fails.
        https://bugs.webkit.org/show_bug.cgi?id=37661

        If for any reason we failed to fetch Object.prototype, context cannot
        be properly initialized and we bail out.

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::initContextIfNeeded): bail out if installHiddenObjectPrototype failed
        (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): bail out if failed to fetch Object.prototype
        * bindings/v8/V8DOMWindowShell.h: return false if installHiddenObjectPrototype failed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake UserContentURLPattern correctly check for subdomains and the URL
timothy@apple.com [Wed, 21 Apr 2010 16:40:03 +0000 (16:40 +0000)]
Make UserContentURLPattern correctly check for subdomains and the URL
has the same suffix as the pattern. Also improve the parsing of the host.

https://bugs.webkit.org/show_bug.cgi?id=37357

Reviewed by Darin Adler.

* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Simplify the subdomain pattern parsing to
simply check for "*" only or a "*." prefix and then do a substring.
(WebCore::UserContentURLPattern::matchesHost): Check that the host has a "." in the
position before the suffix to ensure it a subdomain and not just a suffix match.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Wed, 21 Apr 2010 16:02:12 +0000 (16:02 +0000)]
2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>

        Unreviewed.

        Skip the new fast/lists tests on Mac and Windows until these ports
        implement LayoutTestController::markerTextForListItem().

        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 21 Apr 2010 15:57:02 +0000 (15:57 +0000)]
2010-04-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Make DRT compilable in Chromium tree
        https://bugs.webkit.org/show_bug.cgi?id=37923

        We need to use different GYPs in a case of WebKit-only checkout
        and a case of whole Chromium checkout because the relative paths
        from webkit/ to WebKit/chromium/features.gypi are different in
        these cases and we can't use 'conditions' for 'includes' in GYPs.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Apr 2010 15:43:32 +0000 (15:43 +0000)]
2010-04-21  Xan Lopez  <xlopez@igalia.com>

        Try to fix compilation on GTK+ debug bots.

        * bindings/gobject/WebKitDOMBinding.cpp:
        (WebKit::createWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoList item markers are not always updated after changes in the DOM.
jwieczorek@webkit.org [Wed, 21 Apr 2010 15:41:14 +0000 (15:41 +0000)]
List item markers are not always updated after changes in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=37060

Reviewed by Darin Adler.

WebCore:

In particular, they would not be updated when adding/removing an item
that is not a direct child of the list element.

Tests: fast/lists/ol-nested-items-dynamic-insert.html
       fast/lists/ol-nested-items-dynamic-remove.html
       fast/lists/ol-nested-items.html
       fast/lists/ol-nested-list-dynamic-insert.html
       fast/lists/ol-nested-list-dynamic-remove.html
       fast/lists/ol-nested-list.html

* rendering/RenderListItem.cpp:
(WebCore::updateListMarkerNumbers): Change it to traverse the whole subtree of a list, not only siblings of an item.
* rendering/RenderListItem.h:
* rendering/RenderObject.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
(WebCore::RenderObject::addChild): Move the code updating list markers to RenderObjectChildList for consistency.
* rendering/RenderObjectChildList.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
(WebCore::RenderObjectChildList::removeChildNode): Pass the actual node being removed, not the next sibling.
(WebCore::RenderObjectChildList::appendChildNode): Pass the actual node being added, not the next sibling.
(WebCore::RenderObjectChildList::insertChildNode): Pass the actual node being added, not the next sibling.
* rendering/RenderTreeAsText.cpp:
(WebCore::markerTextForListItem):

WebKit/gtk:

* webkit/webkitprivate.h:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_marker_text_for_list_item): Add a private API to get the marker text for a list item.

WebKit/qt:

* Api/qwebelement.h: Make DumpRenderTreeSupportQt a friend class.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::markerTextForListItem): Add a private API to get the marker text for a list item.

WebKitTools:

* DumpRenderTree/LayoutTestController.cpp:
(markerTextForListItemCallback): A function that returns the marker text for a given list item.
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::markerTextForListItem): Implement it in the GTK port.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::markerTextForListItem): Add a stub.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::markerTextForListItem): Implement it in the Qt port.
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::markerTextForListItem): Add a stub.

LayoutTests:

* fast/lists/dump-list.js:
(indent):
(dumpListHelper): A recursive function to dump nested lists.
(dumpList): A function that dumps a readable plain text representation of a list.
* fast/lists/ol-nested-items-dynamic-insert-expected.txt: Added.
* fast/lists/ol-nested-items-dynamic-insert.html: Added.
* fast/lists/ol-nested-items-dynamic-remove-expected.txt: Added.
* fast/lists/ol-nested-items-dynamic-remove.html: Added.
* fast/lists/ol-nested-items-expected.txt: Added.
* fast/lists/ol-nested-items.html: Added.
* fast/lists/ol-nested-list-dynamic-insert-expected.txt: Added.
* fast/lists/ol-nested-list-dynamic-insert.html: Added.
* fast/lists/ol-nested-list-dynamic-remove-expected.txt: Added.
* fast/lists/ol-nested-list-dynamic-remove.html: Added.
* fast/lists/ol-nested-list-expected.txt: Added.
* fast/lists/ol-nested-list.html: Added.
* platform/mac/Skipped: Skip the tests until this port implements the new LayoutTestController function.
* platform/win/Skipped: Skip the tests until this port implements the new LayoutTestController function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Apr 2010 15:24:15 +0000 (15:24 +0000)]
2010-04-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Adam Barth.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Add build bits for the GObject DOM bindings.

        * GNUmakefile.am:

2010-04-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Adam Barth.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Initial version of the GObject DOM bindings.

        Only bindings for Node.idl and a few of its dependencies are
        provided, without public API to access them at the
        moment. References to the Document interfaces and to
        EventListeners in Node.idl are ignored for GObject to make the
        initial patch as small as possible, but will be enabled in a
        follow-up patch.

        * GNUmakefile.am:
        * bindings/gobject/ConvertToUTF8String.cpp: Added.
        (convertToUTF8String):
        * bindings/gobject/ConvertToUTF8String.h: Added.
        * bindings/gobject/WebKitDOMBinding.cpp: Added.
        (WebKit::domObjects):
        (WebKit::DOMObjectCache::get):
        (WebKit::DOMObjectCache::put):
        (WebKit::DOMObjectCache::forget):
        (WebKit::createWrapper):
        (WebKit::kit):
        * bindings/gobject/WebKitDOMBinding.h: Added.
        * bindings/gobject/WebKitDOMObject.cpp: Added.
        (webkit_dom_object_init):
        (webkit_dom_object_class_init):
        * bindings/gobject/WebKitDOMObject.h: Added.
        * bindings/scripts/CodeGeneratorGObject.pm: Added.
        * bindings/scripts/gobject-generate-headers.pl: Added.
        * dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Wed, 21 Apr 2010 15:18:43 +0000 (15:18 +0000)]
2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Xan Lopez.

        Wrong header being included in FontPlatformDataCairo.cpp
        https://bugs.webkit.org/show_bug.cgi?id=37829

        No behavior changes, so no new tests were added.

        * platform/graphics/cairo/FontPlatformDataCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExclude leaks in CGGradientCreateWithColorComponents from run-webkit-tests leaks...
aroben@apple.com [Wed, 21 Apr 2010 15:08:43 +0000 (15:08 +0000)]
Exclude leaks in CGGradientCreateWithColorComponents from run-webkit-tests leaks output

The leak in CG is covered by <rdar://problem/7888492>.

Fixes <http://webkit.org/b/37927>.

Reviewed by Eric Carlson.

* Scripts/old-run-webkit-tests:
(sub countAndPrintLeaks): Exclude leaks in
CGGradientCreateWithColorComponents on certain OSs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Yi Shen <yi.4.shen@nokia.com>
eric@webkit.org [Wed, 21 Apr 2010 15:08:37 +0000 (15:08 +0000)]
2010-04-21  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Check the request empty or not in ChromeClientQt::createWindow()
        https://bugs.webkit.org/show_bug.cgi?id=37821

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 21 Apr 2010 14:43:08 +0000 (14:43 +0000)]
2010-04-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Import MockSpellCheck from Chromium
        https://bugs.webkit.org/show_bug.cgi?id=37910

        Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
          Add ICU explicitly because WTFString.h includes ICU headers.
          Add MockSpellCheck.{cpp,h}.
        * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
        * DumpRenderTree/chromium/MockSpellCheck.h: Added.
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::spellCheck):
        * DumpRenderTree/chromium/WebViewHost.h:
        * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
          by wtf/text/AtomicString.h included by wtf/text/WTFString.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
aroben@apple.com [Wed, 21 Apr 2010 14:42:39 +0000 (14:42 +0000)]
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter

Fixes <http://webkit.org/b/37922>.

Reviewed by Dave Hyatt.

* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
hold the heap-allocated FilterData object, so that we won't leak it
when we bail out of this function on error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Zoltan Herczeg <zherczeg@webkit.org>
eric@webkit.org [Wed, 21 Apr 2010 14:34:42 +0000 (14:34 +0000)]
2010-04-21  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] startAnimation() is not needed to preceede nativeImageForCurrentFrame()
        https://bugs.webkit.org/show_bug.cgi?id=37844

        nativeImageForCurrentFrame() resets the m_decoder parameter under Qt,
        which is required by startAnimation() to detect frame and repetition counts.
        Hence, Image::drawTiled cannot start animations under Qt:
        <html><body background="animated.gif"></body></html> does not work

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::internalHandleCurrentImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Wed, 21 Apr 2010 14:09:49 +0000 (14:09 +0000)]
2010-04-21  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Added missing #include "Lookup.h" in LUT source files.
        https://bugs.webkit.org/show_bug.cgi?id=XXXXX

        * runtime/ArrayPrototype.cpp:
        * runtime/DatePrototype.cpp:
        * runtime/JSONObject.cpp:
        * runtime/MathObject.cpp:
        * runtime/NumberConstructor.cpp:
        * runtime/RegExpConstructor.cpp:
        * runtime/RegExpObject.cpp:
        * runtime/StringPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 21 Apr 2010 13:52:31 +0000 (13:52 +0000)]
2010-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add webkit-patch pretty-diff
        https://bugs.webkit.org/show_bug.cgi?id=37892

        This is slightly lame because it asks you whether the diff is correct,
        but it's a starting point.

        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
        * Scripts/webkitpy/tool/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] media/video-source-add-src.html was removed from tree
ossy@webkit.org [Wed, 21 Apr 2010 13:42:56 +0000 (13:42 +0000)]
[Qt] media/video-source-add-src.html was removed from tree
by r57820, so it's time to remove it from Qt Skipped list.

* platform/qt/Skipped: media/video-source-add-src.html removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 21 Apr 2010 13:42:49 +0000 (13:42 +0000)]
2010-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove mention of non-existant --no-build option
        https://bugs.webkit.org/show_bug.cgi?id=37893

        The option doesn't exist!

        * Scripts/webkitpy/tool/commands/stepsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Balazs Kelemen <kb@inf.u-szeged.hu>
eric@webkit.org [Wed, 21 Apr 2010 13:32:56 +0000 (13:32 +0000)]
2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
        https://bugs.webkit.org/show_bug.cgi?id=37198

        * QtLauncher/main.cpp:
        (LauncherWindow::toggleInterruptingJavaScriptEnabled):
        (LauncherWindow::newWindow):
        (LauncherWindow::cloneWindow):
        (LauncherWindow::createChrome):
        (main):
        * QtLauncher/webpage.cpp:
        (WebPage::WebPage):
        (WebPage::shouldInterruptJavaScript):
        * QtLauncher/webpage.h:
        (WebPage::setInterruptingJavaScriptEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Wed, 21 Apr 2010 13:17:56 +0000 (13:17 +0000)]
2010-04-21  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Expand testatkroles to test ATK_ROLE_FORM.

        * tests/testatkroles.c:
        (test_webkit_atk_get_role_form):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Shu Chang <chang.shu@nokia.com>
eric@webkit.org [Wed, 21 Apr 2010 13:08:13 +0000 (13:08 +0000)]
2010-04-21  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix Symbian build where QT_NO_SYSTEMTRAYICON is defined.
        https://bugs.webkit.org/show_bug.cgi?id=37442

        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (NotificationPresenterClientQt::show):
        * WebCoreSupport/NotificationPresenterClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Benjamin Poulain <ikipou@gmail.com>
eric@webkit.org [Wed, 21 Apr 2010 12:57:13 +0000 (12:57 +0000)]
2010-04-21  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Simon Fraser.

        Update of fixed elements is not made correctly when the page has been scrolled
        https://bugs.webkit.org/show_bug.cgi?id=36783

        * fast/repaint/fixed-child-move-after-scroll.html: Added.
        * fast/repaint/fixed-child-of-fixed-move-after-scroll.html: Added.
        * fast/repaint/fixed-child-of-transformed-move-after-scroll.html: Added.
        * fast/repaint/fixed-move-after-scroll.html: Added.
        * platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
        * platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
        * platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
        * platform/mac/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-move-after-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
2010-04-21  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Simon Fraser.

        Update of fixed elements is not made correctly when the page has been scrolled
        https://bugs.webkit.org/show_bug.cgi?id=36783

        When a fixed element was updated, the old geometry was not repainted correctly
        because the repaint rect was cached during the layout and not updated when
        scrolling.

        The rect is now updated while scrolling so the region updated correspond to the
        region of the element on the screen.

        The method RenderLayer::updateRepaintRectsAfterScroll() updates
        the repaint rect of all fixed tree after scroll.

        Tests: fast/repaint/fixed-child-move-after-scroll.html
               fast/repaint/fixed-child-of-fixed-move-after-scroll.html
               fast/repaint/fixed-child-of-transformed-move-after-scroll.html
               fast/repaint/fixed-move-after-scroll.html

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChanged):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateRepaintRectsAfterScroll):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Wed, 21 Apr 2010 12:32:36 +0000 (12:32 +0000)]
2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Adam Roben.

        Update EFL port to match recent API changes.
        http://webkit.org/b/37853

        No behavior changes, so no new tests were added.

        * platform/efl/FileSystemEfl.cpp:
        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::missingPluginText):
        (WebCore::crashedPluginText):
        * platform/efl/MIMETypeRegistryEfl.cpp:
        (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
        * platform/graphics/efl/ImageEfl.cpp:
2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Adam Roben.

        Update EFL port to match recent API changes.
        http://webkit.org/b/37853

        * efl/WebCoreSupport/EditorClientEfl.cpp:
        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
        (WebCore::FrameLoaderClientEfl::objectContentType):
        (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
        (WebCore::FrameLoaderClientEfl::canShowMIMEType):
        * efl/WebCoreSupport/FrameLoaderClientEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Avi Drissman <avi@chromium.org>
eric@webkit.org [Wed, 21 Apr 2010 12:22:57 +0000 (12:22 +0000)]
2010-04-21  Avi Drissman  <avi@chromium.org>

        Reviewed by Simon Fraser.

        JPG images fail to print in Chromium
        https://bugs.webkit.org/show_bug.cgi?id=37796

        Image sources of JPG data with final=false fail to draw into PDF contexts even if later updated (<rdar://problem/7874035>). Therefore, destroy and re-create the image source when the final data arrives.

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::setData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Wed, 21 Apr 2010 12:11:38 +0000 (12:11 +0000)]
2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Nikolas Zimmermann.

        Add missing EFL JavaScriptCore file.
        http://webkit.org/b/37854

        * wtf/efl: Added.
        * wtf/efl/MainThreadEfl.cpp: Added.
        (WTF::initializeMainThreadPlatform):
        (WTF::timeoutFired):
        (WTF::scheduleDispatchFunctionsOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 21 Apr 2010 12:00:29 +0000 (12:00 +0000)]
2010-04-21  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Nate Chapin.

        EventSource needs to be marked as an ActiveDomType.
        https://bugs.webkit.org/show_bug.cgi?id=37857
        Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/custom/V8EventSourceConstructor.cpp:
        (WebCore::V8EventSource::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 21 Apr 2010 11:14:59 +0000 (11:14 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r57963.
        http://trac.webkit.org/changeset/57963
        https://bugs.webkit.org/show_bug.cgi?id=37759

        Three tests started crashing on the Qt bot.

        * platform/qt/Skipped:
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r57963.
        http://trac.webkit.org/changeset/57963
        https://bugs.webkit.org/show_bug.cgi?id=37759

        Three tests started crashing on the Qt bot.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::isCommandEnabled):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r57963.
        http://trac.webkit.org/changeset/57963
        https://bugs.webkit.org/show_bug.cgi?id=37759

        Three tests started crashing on the Qt bot.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
eric@webkit.org [Wed, 21 Apr 2010 11:02:59 +0000 (11:02 +0000)]
2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Eric Seidel.

        Make new-run-webkit-tests work for the Qt port
        https://bugs.webkit.org/show_bug.cgi?id=37588

        * Scripts/webkitpy/layout_tests/port/qt.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
eric@webkit.org [Wed, 21 Apr 2010 10:57:15 +0000 (10:57 +0000)]
2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: try to detect alternate apache path
        https://bugs.webkit.org/show_bug.cgi?id=37587

        _check_port_build() also needs to return true in the
        base implementation to not fail the check_build step.

        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Yi Shen <yi.4.shen@nokia.com>
eric@webkit.org [Wed, 21 Apr 2010 10:54:46 +0000 (10:54 +0000)]
2010-04-21  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Unskip a bunch of now passing tests, which was skipped because of
        missing LayoutTestController::computedStyleIncludingVisitedInfo
        https://bugs.webkit.org/show_bug.cgi?id=37759

        * platform/qt/Skipped:
2010-04-21  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
        https://bugs.webkit.org/show_bug.cgi?id=37759

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-04-21  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
        https://bugs.webkit.org/show_bug.cgi?id=37759

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::computedStyleIncludingVisitedInfo):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Wed, 21 Apr 2010 10:44:25 +0000 (10:44 +0000)]
2010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Nikolas Zimmermann.

        Add missing includes to platform/posix/FileSystemPOSIX.cpp
        https://bugs.webkit.org/show_bug.cgi?id=37861

        No behavior changes, so no new tests were added.

        * platform/posix/FileSystemPOSIX.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Wed, 21 Apr 2010 10:09:48 +0000 (10:09 +0000)]
2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Fraser.

        [Qt] Fix or remove the runtime flag for accelerated compositing.

        This adds a way for a chrome client to disallow layers from becoming composited,
        even if the settings enable accelerated compositing. This is necessary for platforms
        where different views can be applied with the same settings to the same page.

        We enable an API through ChromeClient to ask the chrome-client whether or not
        it can render composited layers, which is taken into account when the compositor
        decides whether or not to start compositing.

        https://bugs.webkit.org/show_bug.cgi?id=37313

        Pages under LayoutTests/compositing now work under QWebView, even when
        QWebSettings::AcceleratedCompositingEnabled is on.

        * page/ChromeClient.h:
        (WebCore::ChromeClient::allowsAcceleratedCompositing):
        * platform/qt/QWebPageClient.h:
        (QWebPageClient::allowsAcceleratedCompositing):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::canBeComposited):
2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Fraser.

        [Qt] Fix or remove the runtime flag for accelerated compositing.
        https://bugs.webkit.org/show_bug.cgi?id=37313

        This lets the QWebPageClient "veto" the settings value for accelerated compositing.
        In this case we allow accelerated compositing only on QGraphicsWebView.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::allowsAcceleratedCompositing):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 21 Apr 2010 09:48:36 +0000 (09:48 +0000)]
2010-04-21  Eric Seidel  <eric@webkit.org>

        Unreviewed, test fix only.

        new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
        https://bugs.webkit.org/show_bug.cgi?id=37726

        This change seems to have broken a test.
        Attempting to handle the case where we don't have any
        timing information.  Dirk may have to correct this change.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNo review. Spurious whitespace was removed from project file.
rniwa@webkit.org [Wed, 21 Apr 2010 08:24:52 +0000 (08:24 +0000)]
No review. Spurious whitespace was removed from project file.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 21 Apr 2010 07:57:30 +0000 (07:57 +0000)]
2010-04-21  Alejandro G. Castro  <alex@igalia.com>

        Rubber-stamped by Xan Lopez.

        Skipping fast/frames/frame-crash-with-page-cache.html
        https://bugs.webkit.org/show_bug.cgi?id=37914

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
rniwa@webkit.org [Wed, 21 Apr 2010 07:46:30 +0000 (07:46 +0000)]
[Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=37912

Reviewed by Eric Seidel.

Replaced the ternary operator by an if statement because GCC was confused by the use of
ternary operator and producing warnings on Qt builds.

* WebCore.xcodeproj/project.pbxproj:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 21 Apr 2010 06:55:46 +0000 (06:55 +0000)]
2010-04-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests has much higher startup latency than run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=37643

        I got rid of the -expected.checksum reads during startup.
        This makes startup noticably better on my laptop.

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
         - Use image_hash() instead of .image_hash now that expected.checksum
           file reads are done lazily.
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
         - Add debug logging for this sleep call.
           In my testing I never saw this sleep() hit.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
         - Sleep a shorter interval to make websocket server
           startup more responsive.  On my machine startup was
           taking around 1 second.
         - Remove the unconditional .5s delay on startup.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Make image_hash file reads done lazily in a new image_hash() function.
         - Add a "Starting testing ..." meter update after DRT threads have
           been started, but before we get updates from the first one.
         - Rename variable "t" to a full english name to match WebKit style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 21 Apr 2010 06:41:20 +0000 (06:41 +0000)]
2010-04-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        [ES5] RegExp literals are constants that should be persistent across multiple function calls.
        https://bugs.webkit.org/show_bug.cgi?id=37908

        Dump the separate RegExp constant pool, and just use the standard JS constant pool
        in codeblock.  This allows us to drop op_new_regexp and all associated code as well.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::shrinkToFit):
        * bytecode/CodeBlock.h:
        * bytecode/Opcode.h:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitLoad):
        * bytecompiler/BytecodeGenerator.h:
        * bytecompiler/NodesCodegen.cpp:
        (JSC::RegExpNode::emitBytecode):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        * jit/JITOpcodes.cpp:
        * jit/JITStubs.cpp:
        * jit/JITStubs.h:
        (JSC::):
2010-04-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        [ES5] RegExp literals are constants that should be persistent across multiple function calls.
        https://bugs.webkit.org/show_bug.cgi?id=37908

        Add tests to ensure correct persistence of RegExp literals, and correctly avoid
        sharing "identical" regexps used in different places.

        * fast/js/regexp-literals-are-constants-expected.txt: Added.
        * fast/js/regexp-literals-are-constants.html: Added.
        * fast/js/script-tests/regexp-literals-are-constants.js: Added.
        (test1):
        (returnRegExpLiteral):
        (returnConditionalRegExpLiteral):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
rniwa@webkit.org [Wed, 21 Apr 2010 05:54:16 +0000 (05:54 +0000)]
Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
https://bugs.webkit.org/show_bug.cgi?id=19539

Reviewed by Justin Garcia.

WebCore:

Fixes a bug where two consecutive lists are not merged if they have been converted
from ordered/unordered lists inside another list.

The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
list element and its neighbors. This patch adds code to doApply so that after inserting
the list element, it updates previousList and nextList to the outermost list elements around
insertionPos under the same enclosing list. Because the next and the previous list elements
are not necessarily visually next to the newly inserted element before moveParagraph moves
the paragraph into the new list element, doApply merges lists after moveParagraph is called.

Test: editing/execCommand/insert-lists-inside-another-list.html

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Modified as described above
* editing/htmlediting.cpp:
(WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,
  which is a descendent of rootNode.
* editing/htmlediting.h:

LayoutTests:

Test to make sure InsertListCommand merges consecutive lists when converting
ordered/unordered lists to the opposite type of lists inside another list.

* editing/execCommand/insert-lists-inside-another-list-expected.txt: Added.
* editing/execCommand/insert-lists-inside-another-list.html: Added.
* editing/execCommand/script-tests/insert-lists-inside-another-list.js: Added.
(testList):
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 21 Apr 2010 05:48:31 +0000 (05:48 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Fix test result after r57913.

        * compositing/iframes/composited-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 21 Apr 2010 05:25:14 +0000 (05:25 +0000)]
2010-04-20  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed test skipping for Chromium Win.

        Skip editing/pasteboard/copy-backslash-with-euc.html for Chromium Win.
        https://bugs.webkit.org/show_bug.cgi?id=36419

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 21 Apr 2010 04:55:14 +0000 (04:55 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=37776
        <rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes

        * platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping
        for Roman letters and punctuation.

        * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation
        of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak)
        also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult
        to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes
        to their keycodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a ChangeLog entry.
hamaji@chromium.org [Wed, 21 Apr 2010 04:11:37 +0000 (04:11 +0000)]
Fix a ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 21 Apr 2010 04:09:52 +0000 (04:09 +0000)]
2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        A backslash in EUC-JP becomes to a yen sign when it is copied
        https://bugs.webkit.org/show_bug.cgi?id=36419

        Add editing/pasteboard/copy-backslash-with-euc into Gtk's skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 21 Apr 2010 03:54:47 +0000 (03:54 +0000)]
2010-04-20  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=37748

        Make Sheriffbot more inspirational.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla_unittest.py:
        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 21 Apr 2010 03:31:42 +0000 (03:31 +0000)]
2010-04-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Import Chromium image_diff as ImageDiff
        https://bugs.webkit.org/show_bug.cgi?id=37790

        ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/chromium/ImageDiff.cpp: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Apr 2010 01:13:49 +0000 (01:13 +0000)]
2010-04-20  Xan Lopez  <xlopez@igalia.com>

        Another attempt to fix the build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't paint the web page before we've blit the last update chunk to the backing store.
andersca@apple.com [Wed, 21 Apr 2010 01:13:23 +0000 (01:13 +0000)]
Don't paint the web page before we've blit the last update chunk to the backing store.

Reviewed by Sam Weinig.

* UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didReceiveMessage):
* UIProcess/win/DrawingAreaProxy.h:
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didUpdate):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 21 Apr 2010 00:54:20 +0000 (00:54 +0000)]
2010-04-20  Xan Lopez  <xlopez@igalia.com>

        Build fix?

        * autotools/webkit.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix license on create_regex_tables
oliver@apple.com [Wed, 21 Apr 2010 00:50:54 +0000 (00:50 +0000)]
Fix license on create_regex_tables

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix gtk
oliver@apple.com [Wed, 21 Apr 2010 00:47:46 +0000 (00:47 +0000)]
Fix gtk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Wed, 21 Apr 2010 00:09:00 +0000 (00:09 +0000)]
Fix build.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::receivedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 20 Apr 2010 23:51:45 +0000 (23:51 +0000)]
2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Alexey Proskuryakov.

        A backslash in EUC-JP becomes to a yen sign when it is copied
        https://bugs.webkit.org/show_bug.cgi?id=36419

        * editing/execCommand/transpose-backslash-with-euc-expected.txt: Added.
        * editing/execCommand/transpose-backslash-with-euc.html: Added.
        * editing/pasteboard/copy-backslash-with-euc-expected.txt: Added.
        * editing/pasteboard/copy-backslash-with-euc.html: Added.
        * editing/pasteboard/resources/copy-backslash-euc.html: Added.
2010-04-20  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Alexey Proskuryakov.

        A backslash in EUC-JP becomes to a yen sign when it is copied
        https://bugs.webkit.org/show_bug.cgi?id=36419

        Tests: editing/execCommand/transpose-backslash-with-euc.html
               editing/pasteboard/copy-backslash-with-euc.html

        * editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls.
        (WebCore::Editor::addToKillRing):
        * editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version
        (WebCore::TextIterator::TextIterator):
        (WebCore::TextIterator::init):
        (WebCore::TextIterator::emitText):
        (WebCore::plainTextToMallocAllocatedBuffer):
        * editing/TextIterator.h:
        (WebCore::):
        * platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call.
        (WebCore::Pasteboard::writeSelection):
        * platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
        * rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::updateNeedsTranscoding):
        (WebCore::RenderText::styleDidChange):
        (WebCore::isInlineFlowOrEmptyText):
        (WebCore::RenderText::previousCharacter):
        (WebCore::RenderText::setTextInternal):
        (WebCore::RenderText::textWithoutTranscoding):
        (WebCore::RenderText::transformText):
        * rendering/RenderText.h:
        * rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call.
        (WebCore::RenderTextControl::setInnerTextValue):
        (WebCore::RenderTextControl::finishText):
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::previousCharacter):
        * rendering/RenderTextFragment.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 20 Apr 2010 23:42:52 +0000 (23:42 +0000)]
2010-04-20  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating Chromium test_expectations for media/video-zoom.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 23:27:07 +0000 (23:27 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed. Update chromium expectations.  Also consolidate identical
        platform expectations for fast/dom/prototype-inheritance.html.

        * platform/chromium-linux/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix gtk
oliver@apple.com [Tue, 20 Apr 2010 23:22:57 +0000 (23:22 +0000)]
Fix gtk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 20 Apr 2010 23:18:52 +0000 (23:18 +0000)]
2010-04-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=37367

        Fix style violations in code generated by CodeGeneratorV8.pm.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/test/V8TestObj.cpp:
        * bindings/v8/test/V8TestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r57924.
ossy@webkit.org [Tue, 20 Apr 2010 22:57:31 +0000 (22:57 +0000)]
Unreviewed, rolling out r57924.
http://trac.webkit.org/changeset/57924
https://bugs.webkit.org/show_bug.cgi?id=37898

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-20
It broke 3-4 test on all bot (Requested by Ossy on #webkit).

WebCore:

* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::media):
* page/DOMWindow.h:
* page/DOMWindow.idl:

LayoutTests:

* fast/media/lifetime.html:
* fast/media/matchmedium-query-api.html:
* fast/media/print-restores-previous-mediatype-expected.txt:
* fast/media/print-restores-previous-mediatype.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 20 Apr 2010 22:43:51 +0000 (22:43 +0000)]
2010-04-20  Dirk Pranke <dpranke@chromium.org>

        This patch to new-run-webkit-tests adds a --log 'trace' option
        that prints out detailed info about a given test as it executes
        (where the baselines are, what the expectation is, what we got,
        how long it took).

        https://bugs.webkit.org/show_bug.cgi?id=37726

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
          - use the newly exposed TestResult class and implement
            --log trace
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
          - rename TestStats to TestResult and make it more public, resulting
            in cleaner code
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
          - add expectation_to_string() as a separate callable function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 20 Apr 2010 22:38:43 +0000 (22:38 +0000)]
2010-04-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't paint the web page before we've blit the last update chunk to the backing store
        https://bugs.webkit.org/show_bug.cgi?id=37896

        * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
        (DrawingAreaMessage::):
        * UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
        * UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
        (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
        (WebKit::DrawingAreaProxyUpdateChunk::update):
        (WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
        * WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
        (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
        (WebKit::DrawingAreaUpdateChunk::display):
        (WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
        (WebKit::DrawingAreaUpdateChunk::setSize):
        (WebKit::DrawingAreaUpdateChunk::didUpdate):
        (WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
        * WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
barraclough@apple.com [Tue, 20 Apr 2010 22:34:52 +0000 (22:34 +0000)]
JavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl

Reviewed by Oliver Hunt.

The implementation of StringImpl & UStringImpl is very similar.  Restructure
StringImpl to match UStringImpl, moving the flags and length into a base class,
so that this can be shared between both string types to increase code reuse.

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RopeImpl.h:
(JSC::RopeImpl::RopeImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::UStringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::characters):
* wtf/text/StringImplBase.h: Copied from JavaScriptCore/runtime/UStringImpl.h.
(WTF::StringImplBase::length):
(WTF::StringImplBase::operator new):
(WTF::StringImplBase::StringImplBase):

JavaScriptGlue: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

* ForwardingHeaders/wtf/text/StringImplBase.h: Added.

WebCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

* ForwardingHeaders/wtf/text/StringImplBase.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 20 Apr 2010 22:26:44 +0000 (22:26 +0000)]
2010-04-20  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix fro Chromium.

        * loader/DocumentWriter.cpp:

2010-04-20  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.

        * Api/qwebframe.cpp:
        (QWebFrame::setUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 20 Apr 2010 22:24:12 +0000 (22:24 +0000)]
2010-04-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.

        https://bugs.webkit.org/show_bug.cgi?id=37820

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback):
        (WebInspector.ScriptsPanel.prototype.editScriptLine):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._handleDoubleClick):
        (WebInspector.TextViewer.prototype._cancelEditingLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 22:24:00 +0000 (22:24 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Test fix, no review.

        Disable compositing/iframes/composited-iframe.html because compositing is
        turned off at runtime on Leopard (based on QuickTime version), so we can't
        rely on the result.

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 22:19:02 +0000 (22:19 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Reviewed by dglazkov.

        Update chromium SVG baselines for r57886
        https://bugs.webkit.org/show_bug.cgi?id=37891

        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/filters/filterRegions-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textEffect-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textEffect3-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textFeatures-expected.txt: Removed.
        * platform/chromium-mac/svg/batik/text/textProperties-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/non-opaque-filters-expected.txt: Removed.
        * platform/chromium-mac/svg/custom/visibility-override-filter-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/big-sized-filter-2-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/feMerge-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/feOffset-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/filter-on-tspan-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
        * platform/chromium-mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
        * platform/chromium-win/svg/batik/text/textProperties-expected.txt:
        * platform/chromium-win/svg/custom/empty-merge-expected.txt: Removed.
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/chromium-win/svg/custom/feDisplacementMap-01-expected.txt: Removed.
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/chromium-win/svg/custom/invalid-css-expected.txt:
        * platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
        * platform/chromium-win/svg/custom/text-filter-expected.txt:
        * platform/chromium-win/svg/custom/visibility-override-filter-expected.txt: Removed.
        * platform/chromium-win/svg/filters/big-sized-filter-2-expected.txt: Removed.
        * platform/chromium-win/svg/filters/big-sized-filter-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
        * platform/chromium-win/svg/filters/feComposite-expected.txt:
        * platform/chromium-win/svg/filters/feDisplacementMap-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feMerge-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feMerge-wrong-input-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feOffset-expected.txt: Removed.
        * platform/chromium-win/svg/filters/feTile-expected.txt: Removed.
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.txt: Removed.
        * platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
        * platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.txt: Removed.
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 20 Apr 2010 22:12:16 +0000 (22:12 +0000)]
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        This patch separates the begin/write/end cycle of decoding network
        bytes and putting them into a document from the rest of the loading
        machinery.  The code and state required to write bytes into a document
        doesn't interact very much with the rest of the loading machinery.

        No tests because there is no behavior change (hopefully!).

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::close):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::scriptCharset):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestPreload):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/DocumentWriter.cpp: Added.
        * loader/DocumentWriter.h: Added.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::init):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::setURL):
        (WebCore::FrameLoader::didBeginDocument):
        (WebCore::FrameLoader::didEndDocument):
        (WebCore::FrameLoader::willSetEncoding):
        (WebCore::FrameLoader::addData):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::writer):
        (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::replaceMediaElementTimerFired):
        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::createDocumentStructure):
        * platform/network/FormDataBuilder.cpp:
        (WebCore::FormDataBuilder::dataEncoding):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::finishedLoading):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::commitDocumentData):
        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebSearchableFormData.cpp:
        (WebCore::GetFormEncoding):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::pageEncoding):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::committedLoad):
        (WebKit::FrameLoaderClient::finishedLoading):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_encoding):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebView/WebFrame.mm:
        (-[WebFrame _canProvideDocumentSource]):
        (-[WebFrame _receivedData:textEncodingName:]):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::finishedLoading):
        (WebCore::FrameLoaderClientQt::setMainDocumentError):
        (WebCore::FrameLoaderClientQt::committedLoad):
        (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::receivedData):
2010-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor DocumentWriter out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=37175

        Update these callsites because the method moved to DocumentWriter.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::committedLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Tue, 20 Apr 2010 22:09:58 +0000 (22:09 +0000)]
Fix build.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::chooseIconForFiles):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 20 Apr 2010 22:05:43 +0000 (22:05 +0000)]
2010-04-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Autogenerate yarr character tables
        https://bugs.webkit.org/show_bug.cgi?id=37877

        Use a python script to automatically generate character tables
        for the builtin YARR character classes.  This allows us to generate
        actual tables as well, by using these tables we can both increase
        performance of the check (for complex builtins) and reduce the actual
        code size.

        4-8% win on string-unpack-code, but lots of noise on other tests so
        i'm only confident saying its a 1% win overall.

        * DerivedSources.make:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::ExtendedAddress::ExtendedAddress):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::branchTest8):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::branchTest8):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::branchTest8):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::cmpb_im):
        (JSC::X86Assembler::testb_im):
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingTool::dump):
        * create_regex_tables: Added.
        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::CharacterClassConstructor::charClass):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::matchCharacterClass):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
        (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
        * yarr/RegexPattern.h:
        (JSC::Yarr::CharacterClassTable::create):
        (JSC::Yarr::CharacterClassTable::CharacterClassTable):
        (JSC::Yarr::CharacterClass::CharacterClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename window.media to window.styleMedia
kenneth@webkit.org [Tue, 20 Apr 2010 22:04:59 +0000 (22:04 +0000)]
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Simon Fraser.

WebCore:

It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.

* page/AbstractView.idl:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
* page/DOMWindow.h:
* page/DOMWindow.idl:

LayoutTests:

Update layout tests.

* fast/media/lifetime.html:
* fast/media/matchmedium-query-api.html:
* fast/media/print-restores-previous-mediatype.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix matching of "file:///*" patterns by not trying to compare the host. The host is
timothy@apple.com [Tue, 20 Apr 2010 21:50:32 +0000 (21:50 +0000)]
Fix matching of "file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.

Also fix comparisons to be case insensitive.

https://bugs.webkit.org/show_bug.cgi?id=37889

Reviewed by Dave Hyatt.

* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Justin Schuh <jschuh@chromium.org>
japhet@chromium.org [Tue, 20 Apr 2010 21:42:20 +0000 (21:42 +0000)]
2010-04-20  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
        https://bugs.webkit.org/show_bug.cgi?id=37331

        Added a setting to enable/disable media per-page and have the SVGImage
        disable media for its dummy page. Also found and fixed a related bad
        cast in the V8 bindings (JSC had a custom wrapper for this already).

        Tests: media/svg-as-image-with-media-blocked.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut...
tonikitoo@webkit.org [Tue, 20 Apr 2010 21:32:24 +0000 (21:32 +0000)]
Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
https://bugs.webkit.org/show_bug.cgi?id=37802

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.

No behavior change, it is just a safe assignment shortcut.

* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 20 Apr 2010 21:29:54 +0000 (21:29 +0000)]
2010-04-20  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r57907.
        http://trac.webkit.org/changeset/57907
        https://bugs.webkit.org/show_bug.cgi?id=37765

        Appears to have broken MacEWS and possibly webkit-patch upload
        for svn users.  Needs further investigation.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/checkout/commitinfo.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/common/config/committers.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:
        * Scripts/webkitpy/common/net/statusserver.py:
        * Scripts/webkitpy/common/prettypatch.py:
        * Scripts/webkitpy/common/system/autoinstall.py:
        * Scripts/webkitpy/common/system/deprecated_logging.py:
        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:
        * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
        * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 21:24:10 +0000 (21:24 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Hook compositing layers together across iframes
        https://bugs.webkit.org/show_bug.cgi?id=37878

        First step: if an iframe's document goes into compositing mode, also throw the parent
        document into compositing mode (all the way up to the root). This is required both
        to preserve layering (since parent document content can obscure iframe content),
        and so that we can eventually hook the layer trees together.

        Test: compositing/iframes/composited-iframe.html

        * rendering/RenderIFrame.h:
        * rendering/RenderIFrame.cpp:
        (WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have
        a RenderLayer, so must return |true| from requiresLayer().
        (WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document
        is in compositing mode.
        (WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check
        if a renderer is an iframe.
        (WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when
        the compositing mode changes, so that the parent document can update its compositing status.
        (WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame().
        (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe
        wants to be composited.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderIFrame): Base class returns false.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify
        its parent document that a recalcStyle is required, to update compositing state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 20 Apr 2010 21:17:32 +0000 (21:17 +0000)]
2010-04-20  Nate Chapin  <japhet@chromium.org>

        Unreviewed.

        Update my irc handle in committers.py (natechapin -> japhet).

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* wtf/text/AtomicString.h:
barraclough@apple.com [Tue, 20 Apr 2010 21:13:16 +0000 (21:13 +0000)]
* wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix - missed a bit!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoworker-close.html is flaky on slow machines.
dimich@chromium.org [Tue, 20 Apr 2010 21:12:33 +0000 (21:12 +0000)]
worker-close.html is flaky on slow machines.
https://bugs.webkit.org/show_bug.cgi?id=37887

Reviewed by Adam Barth.

* fast/workers/worker-close.html: Move the start of the timer to terminate the test after an expected message is received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 21:03:43 +0000 (21:03 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed. Another round of chromium test expectation SVG updates.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* wtf/text/AtomicString.h:
barraclough@apple.com [Tue, 20 Apr 2010 20:58:03 +0000 (20:58 +0000)]
* wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Apr 2010 20:41:03 +0000 (20:41 +0000)]
2010-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        backgroundColor is oddly indented in layer tree dump
        https://bugs.webkit.org/show_bug.cgi?id=37885

        The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
        to be written twice.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::dumpProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Add missing .def file entries.
barraclough@apple.com [Tue, 20 Apr 2010 20:33:56 +0000 (20:33 +0000)]
JavaScriptCore: Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

WebCore: Speculative tiger build fix.

Reviewed by NOBODY (build fix).

* WebCore.NPAPI.exp:
* WebCore.PluginHostProcess.exp:
* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative tiger build fix.
barraclough@apple.com [Tue, 20 Apr 2010 20:23:11 +0000 (20:23 +0000)]
Speculative tiger build fix.

Reviewed by NOBODY (build fix).

* WebCore.NPAPI.exp:
* WebCore.PluginHostProcess.exp:
* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 20 Apr 2010 20:22:30 +0000 (20:22 +0000)]
2010-04-20  James Robinson  <jamesr@chromium.org>

        Unreviewed. Fix typo in chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57910 268f45cc-cd09-0410-ab3c-d52691b4dbfc