WebKit-https.git
7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 29 May 2013 13:19:34 +0000 (13:19 +0000)]
Unreviewed GTK gardening.
Adding flaky failure expectations for two perf/ layout tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 29 May 2013 12:53:56 +0000 (12:53 +0000)]
Unreviewed GTK gardening.

* platform/gtk-wk1/TestExpectations: Remove an unnecessary expectation.
* platform/gtk/TestExpectations: Add timeout expectations for tests that are currently timing out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as committer in contributors.json.
dongseong.hwang@intel.com [Wed, 29 May 2013 12:43:28 +0000 (12:43 +0000)]
Unreviewed. Add myself as committer in contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Update NEWS and Versions.m4 for 2.1.1 release.
carlosgc@webkit.org [Wed, 29 May 2013 12:19:36 +0000 (12:19 +0000)]
Unreviewed. Update NEWS and Versions.m4 for 2.1.1 release.

.:

* Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 2.1.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Wed, 29 May 2013 12:15:53 +0000 (12:15 +0000)]
Unreviewed. Fix make distcheck.

.:

* GNUmakefile.am: Add WebKitFeatures.h and WebKitFeatures.txt to
DISTCLEANFILES.

Source/WebKit2:

* GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.

Tools:

* TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
DISTCLEANFILES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: update my email address in contributors.json.
commit-queue@webkit.org [Wed, 29 May 2013 11:51:32 +0000 (11:51 +0000)]
Unreviewed: update my email address in contributors.json.

Patch by Mary Wu <mawu@blackberry.com> on 2013-05-29

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Missing files from build after r150853
commit-queue@webkit.org [Wed, 29 May 2013 11:01:20 +0000 (11:01 +0000)]
[Qt] Missing files from build after r150853
https://bugs.webkit.org/show_bug.cgi?id=116932

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogon√°c.

* Target.pri: Added missing include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the...
commit-queue@webkit.org [Wed, 29 May 2013 10:57:07 +0000 (10:57 +0000)]
[CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the scroll thumbs with the mouse
https://bugs.webkit.org/show_bug.cgi?id=113703

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-05-29
Reviewed by Darin Adler.

Source/WebCore:

The point inside a box that's inside a region has its coordinates relative to the region, not the FlowThread
that is its container in the RenderObject tree.

Previously, the coordinates were computed relatively to the FlowThread which doesn't really have a location in
the page.

Tests: fast/regions/drag-scrollbars-of-content.html
       fast/regions/hover-in-second-region.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

LayoutTests:

* fast/regions/drag-scrollbars-of-content-expected.html: Added.
* fast/regions/drag-scrollbars-of-content.html: Added.
* fast/regions/hover-in-second-region-expected.html: Added.
* fast/regions/hover-in-second-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix dumb typo in r150879.
akling@apple.com [Wed, 29 May 2013 10:20:40 +0000 (10:20 +0000)]
Fix dumb typo in r150879.

* editing/htmlediting.cpp:
(WebCore::nextLeafNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove leaf Node traversal helpers to htmlediting.cpp
akling@apple.com [Wed, 29 May 2013 08:57:42 +0000 (08:57 +0000)]
Move leaf Node traversal helpers to htmlediting.cpp
<http://webkit.org/b/116940>

Reviewed by Antti Koivisto.

Move Node::previousLeafNode() and Node::nextLeafNode() to htmlediting.cpp along with their helpers.
Fixes an 8-year old FIXME. \o/

* dom/Node.h:
* dom/Node.cpp:
* dom/Position.cpp:
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
* editing/VisibleUnits.cpp:
(WebCore::previousLeafWithSameEditability):
(WebCore::nextLeafWithSameEditability):
* editing/htmlediting.h:
* editing/htmlediting.cpp:
(WebCore::previousNodeConsideringAtomicNodes):
(WebCore::nextNodeConsideringAtomicNodes):
(WebCore::previousLeafNode):
(WebCore::nextLeafNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Missing files from build after r150853
commit-queue@webkit.org [Wed, 29 May 2013 08:56:07 +0000 (08:56 +0000)]
[Qt] Missing files from build after r150853
https://bugs.webkit.org/show_bug.cgi?id=116932

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogon√°c.

* Target.pri: Added the CFURLExtras.{cpp,h} files to the projectfile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPresentationAttributeCacheCleaner::m_hitCount is never initialized
rniwa@webkit.org [Wed, 29 May 2013 08:53:34 +0000 (08:53 +0000)]
PresentationAttributeCacheCleaner::m_hitCount is never initialized
https://bugs.webkit.org/show_bug.cgi?id=116946

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/70be7ddc41141ef6dec7795d37842c27dab2e194.

* dom/StyledElement.cpp:
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
tkent@chromium.org [Wed, 29 May 2013 08:47:46 +0000 (08:47 +0000)]
Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
https://bugs.webkit.org/show_bug.cgi?id=116796

Reviewed by Ryosuke Niwa.

Source/WebCore:

This feature was used only by Chromium port.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/html.css:
(input::-webkit-date-and-time-value):
* dom/Element.cpp:
* dom/Element.h:
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
* html/BaseChooserOnlyDateAndTimeInputType.h:
* html/BaseMultipleFieldsDateAndTimeInputType.cpp: Removed.
* html/BaseMultipleFieldsDateAndTimeInputType.h: Removed.
* html/DateInputType.cpp:
* html/DateInputType.h:
(DateInputType):
* html/DateTimeFieldsState.cpp: Removed.
* html/DateTimeFieldsState.h: Removed.
* html/DateTimeInputType.cpp:
* html/DateTimeInputType.h:
(DateTimeInputType):
* html/DateTimeLocalInputType.cpp:
* html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
* html/InputType.h:
(InputType):
* html/MonthInputType.cpp:
* html/MonthInputType.h:
(MonthInputType):
* html/TimeInputType.cpp:
* html/TimeInputType.h:
(TimeInputType):
* html/WeekInputType.cpp:
* html/WeekInputType.h:
(WeekInputType):
* html/shadow/ClearButtonElement.cpp: Removed.
* html/shadow/ClearButtonElement.h: Removed.
* html/shadow/DateTimeEditElement.cpp: Removed.
* html/shadow/DateTimeEditElement.h: Removed.
* html/shadow/DateTimeFieldElement.cpp: Removed.
* html/shadow/DateTimeFieldElement.h: Removed.
* html/shadow/DateTimeFieldElements.cpp: Removed.
* html/shadow/DateTimeFieldElements.h: Removed.
* html/shadow/DateTimeNumericFieldElement.cpp: Removed.
* html/shadow/DateTimeNumericFieldElement.h: Removed.
* html/shadow/DateTimeSymbolicFieldElement.cpp: Removed.
* html/shadow/DateTimeSymbolicFieldElement.h: Removed.
* html/shadow/PickerIndicatorElement.cpp: Removed.
* html/shadow/PickerIndicatorElement.h: Removed.
* page/ChromeClient.h:
(ChromeClient):
* platform/LocalizedStrings.h:
(WebCore):
* platform/text/PlatformLocale.cpp:
* platform/text/PlatformLocale.h:
(Locale):
* rendering/RenderDetailsMarker.cpp:
* rendering/RenderDetailsMarker.h:
* rendering/RenderObject.h:
(RenderObject):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

* wtf/FeatureDefines.h:

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-wheel-event.html: Removed.
* fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput.html: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event.html: Removed.
* fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-wheel-event.html: Removed.
* fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus-style-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-static-relayout-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-step-attribute-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-step-attribute.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Removed.
* fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove SnowLeopard expected results.
rniwa@webkit.org [Wed, 29 May 2013 08:36:19 +0000 (08:36 +0000)]
Remove SnowLeopard expected results.

Rubber-stamped by Andreas Kling.

* platform/mac-snowleopard: Removed.
* platform/mac-snowleopard/animations: Removed.
* platform/mac-snowleopard/canvas: Removed.
* platform/mac-snowleopard/canvas/philip: Removed.
* platform/mac-snowleopard/canvas/philip/tests: Removed.
* platform/mac-snowleopard/compositing: Removed.
* platform/mac-snowleopard/compositing/color-matching: Removed.
* platform/mac-snowleopard/compositing/framesets: Removed.
* platform/mac-snowleopard/compositing/geometry: Removed.
* platform/mac-snowleopard/compositing/iframes: Removed.
* platform/mac-snowleopard/compositing/images: Removed.
* platform/mac-snowleopard/compositing/layer-creation: Removed.
* platform/mac-snowleopard/compositing/masks: Removed.
* platform/mac-snowleopard/compositing/overflow: Removed.
* platform/mac-snowleopard/compositing/reflections: Removed.
* platform/mac-snowleopard/compositing/repaint: Removed.
* platform/mac-snowleopard/compositing/scaling: Removed.
* platform/mac-snowleopard/compositing/shadows: Removed.
* platform/mac-snowleopard/compositing/tiling: Removed.
* platform/mac-snowleopard/compositing/transitions: Removed.
* platform/mac-snowleopard/compositing/video: Removed.
* platform/mac-snowleopard/compositing/visibility: Removed.
* platform/mac-snowleopard/compositing/webgl: Removed.
* platform/mac-snowleopard/css1: Removed.
* platform/mac-snowleopard/css1/box_properties: Removed.
* platform/mac-snowleopard/css1/cascade: Removed.
* platform/mac-snowleopard/css1/classification: Removed.
* platform/mac-snowleopard/css1/color_and_background: Removed.
* platform/mac-snowleopard/css1/font_properties: Removed.
* platform/mac-snowleopard/css1/formatting_model: Removed.
* platform/mac-snowleopard/css1/pseudo: Removed.
* platform/mac-snowleopard/css1/text_properties: Removed.
* platform/mac-snowleopard/css1/units: Removed.
* platform/mac-snowleopard/css2.1: Removed.
* platform/mac-snowleopard/css2.1/20110323: Removed.
* platform/mac-snowleopard/css3: Removed.
* platform/mac-snowleopard/css3/filters: Removed.
* platform/mac-snowleopard/css3/flexbox: Removed.
* platform/mac-snowleopard/css3/images: Removed.
* platform/mac-snowleopard/css3/selectors3: Removed.
* platform/mac-snowleopard/css3/selectors3/html: Removed.
* platform/mac-snowleopard/css3/selectors3/xhtml: Removed.
* platform/mac-snowleopard/css3/selectors3/xml: Removed.
* platform/mac-snowleopard/editing: Removed.
* platform/mac-snowleopard/editing/input: Removed.
* platform/mac-snowleopard/editing/inserting: Removed.
* platform/mac-snowleopard/editing/pasteboard: Removed.
* platform/mac-snowleopard/editing/selection: Removed.
* platform/mac-snowleopard/editing/unsupported-content: Removed.
* platform/mac-snowleopard/fast: Removed.
* platform/mac-snowleopard/fast/backgrounds: Removed.
* platform/mac-snowleopard/fast/backgrounds/repeat: Removed.
* platform/mac-snowleopard/fast/backgrounds/size: Removed.
* platform/mac-snowleopard/fast/block: Removed.
* platform/mac-snowleopard/fast/block/basic: Removed.
* platform/mac-snowleopard/fast/block/float: Removed.
* platform/mac-snowleopard/fast/block/margin-collapse: Removed.
* platform/mac-snowleopard/fast/block/positioning: Removed.
* platform/mac-snowleopard/fast/borders: Removed.
* platform/mac-snowleopard/fast/canvas: Removed.
* platform/mac-snowleopard/fast/css: Removed.
* platform/mac-snowleopard/fast/dom: Removed.
* platform/mac-snowleopard/fast/encoding: Removed.
* platform/mac-snowleopard/fast/forms: Removed.
* platform/mac-snowleopard/fast/forms/file: Removed.
* platform/mac-snowleopard/fast/forms/range: Removed.
* platform/mac-snowleopard/fast/gradients: Removed.
* platform/mac-snowleopard/fast/images: Removed.
* platform/mac-snowleopard/fast/inline: Removed.
* platform/mac-snowleopard/fast/layers: Removed.
* platform/mac-snowleopard/fast/lists: Removed.
* platform/mac-snowleopard/fast/multicol: Removed.
* platform/mac-snowleopard/fast/multicol/span: Removed.
* platform/mac-snowleopard/fast/multicol/vertical-lr: Removed.
* platform/mac-snowleopard/fast/multicol/vertical-rl: Removed.
* platform/mac-snowleopard/fast/overflow: Removed.
* platform/mac-snowleopard/fast/parser: Removed.
* platform/mac-snowleopard/fast/preloader: Removed.
* platform/mac-snowleopard/fast/reflections: Removed.
* platform/mac-snowleopard/fast/repaint: Removed.
* platform/mac-snowleopard/fast/replaced: Removed.
* platform/mac-snowleopard/fast/ruby: Removed.
* platform/mac-snowleopard/fast/selectors: Removed.
* platform/mac-snowleopard/fast/table: Removed.
* platform/mac-snowleopard/fast/text: Removed.
* platform/mac-snowleopard/fast/text/international: Removed.
* platform/mac-snowleopard/fast/text/whitespace: Removed.
* platform/mac-snowleopard/fast/writing-mode: Removed.
* platform/mac-snowleopard/fast/xsl: Removed.
* platform/mac-snowleopard/fonts: Removed.
* platform/mac-snowleopard/fullscreen: Removed.
* platform/mac-snowleopard/http: Removed.
* platform/mac-snowleopard/http/tests: Removed.
* platform/mac-snowleopard/http/tests/inspector: Removed.
* platform/mac-snowleopard/http/tests/security: Removed.
* platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Removed.
* platform/mac-snowleopard/http/tests/xmlhttprequest: Removed.
* platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps: Removed.
* platform/mac-snowleopard/mathml: Removed.
* platform/mac-snowleopard/media: Removed.
* platform/mac-snowleopard/platform: Removed.
* platform/mac-snowleopard/platform/mac: Removed.
* platform/mac-snowleopard/platform/mac/compositing: Removed.
* platform/mac-snowleopard/platform/mac/compositing/canvas: Removed.
* platform/mac-snowleopard/platform/mac/editing: Removed.
* platform/mac-snowleopard/platform/mac/editing/selection: Removed.
* platform/mac-snowleopard/platform/mac/fast: Removed.
* platform/mac-snowleopard/platform/mac/fast/loader: Removed.
* platform/mac-snowleopard/platform/mac/fast/text: Removed.
* platform/mac-snowleopard/platform/mac/fast/text/international: Removed.
* platform/mac-snowleopard/platform/mac/scrollbars: Removed.
* platform/mac-snowleopard/plugins: Removed.
* platform/mac-snowleopard/printing: Removed.
* platform/mac-snowleopard/scrollbars: Removed.
* platform/mac-snowleopard/sputnik: Removed.
* platform/mac-snowleopard/sputnik/Unicode: Removed.
* platform/mac-snowleopard/svg: Removed.
* platform/mac-snowleopard/svg/W3C-I18N: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE: Removed.
* platform/mac-snowleopard/svg/as-background-image: Removed.
* platform/mac-snowleopard/svg/as-border-image: Removed.
* platform/mac-snowleopard/svg/as-image: Removed.
* platform/mac-snowleopard/svg/as-object: Removed.
* platform/mac-snowleopard/svg/batik: Removed.
* platform/mac-snowleopard/svg/batik/paints: Removed.
* platform/mac-snowleopard/svg/carto.net: Removed.
* platform/mac-snowleopard/svg/clip-path: Removed.
* platform/mac-snowleopard/svg/css: Removed.
* platform/mac-snowleopard/svg/custom: Removed.
* platform/mac-snowleopard/svg/dom: Removed.
* platform/mac-snowleopard/svg/dynamic-updates: Removed.
* platform/mac-snowleopard/svg/filters: Removed.
* platform/mac-snowleopard/svg/foreignObject: Removed.
* platform/mac-snowleopard/svg/hixie: Removed.
* platform/mac-snowleopard/svg/hixie/data-types: Removed.
* platform/mac-snowleopard/svg/hixie/error: Removed.
* platform/mac-snowleopard/svg/hixie/intrinsic: Removed.
* platform/mac-snowleopard/svg/hixie/mixed: Removed.
* platform/mac-snowleopard/svg/hixie/perf: Removed.
* platform/mac-snowleopard/svg/hixie/processing-model: Removed.
* platform/mac-snowleopard/svg/hixie/rendering-model: Removed.
* platform/mac-snowleopard/svg/hixie/text: Removed.
* platform/mac-snowleopard/svg/hixie/viewbox: Removed.
* platform/mac-snowleopard/svg/hixie/viewbox/preserveAspectRatio: Removed.
* platform/mac-snowleopard/svg/in-html: Removed.
* platform/mac-snowleopard/svg/overflow: Removed.
* platform/mac-snowleopard/svg/repaint: Removed.
* platform/mac-snowleopard/svg/text: Removed.
* platform/mac-snowleopard/svg/transforms: Removed.
* platform/mac-snowleopard/svg/webarchive: Removed.
* platform/mac-snowleopard/svg/wicd: Removed.
* platform/mac-snowleopard/svg/zoom: Removed.
* platform/mac-snowleopard/svg/zoom/page: Removed.
* platform/mac-snowleopard/tables: Removed.
* platform/mac-snowleopard/tables/mozilla: Removed.
* platform/mac-snowleopard/tables/mozilla/bugs: Removed.
* platform/mac-snowleopard/tables/mozilla/collapsing_borders: Removed.
* platform/mac-snowleopard/tables/mozilla/core: Removed.
* platform/mac-snowleopard/tables/mozilla/marvin: Removed.
* platform/mac-snowleopard/tables/mozilla/other: Removed.
* platform/mac-snowleopard/transforms: Removed.
* platform/mac-snowleopard/transforms/2d: Removed.
* platform/mac-snowleopard/transforms/3d: Removed.
* platform/mac-snowleopard/transforms/3d/general: Removed.
* platform/mac-snowleopard/transforms/3d/point-mapping: Removed.
* platform/mac-snowleopard/webarchive: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoadding myself to committers list
kalyan.kondapally@intel.com [Wed, 29 May 2013 08:23:10 +0000 (08:23 +0000)]
adding myself to committers list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove setFullScreenRendererSize and setFullScreenRendererBackgroundColor
rniwa@webkit.org [Wed, 29 May 2013 07:49:00 +0000 (07:49 +0000)]
Remove setFullScreenRendererSize and setFullScreenRendererBackgroundColor
https://bugs.webkit.org/show_bug.cgi?id=116914

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/508eb21a07f69ed38b9be9ff92fe75dcb907861f

* dom/Document.cpp:
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WidgetHierarchyUpdatesSuspensionScope use swap instead of copy
rniwa@webkit.org [Wed, 29 May 2013 07:46:08 +0000 (07:46 +0000)]
Make WidgetHierarchyUpdatesSuspensionScope use swap instead of copy
https://bugs.webkit.org/show_bug.cgi?id=116927

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/1d577e1fd5c5716a06e4007e04fc3d9d0a88f5e4

This is equivalent behavior code that is unambiguously better performance. swap is O(1) time and memory,
copying a hash table is at least linear with the number of elements.

* rendering/RenderWidget.cpp:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Document::nodeAbsIndex() and Document::nodeWithAbsIndex().
akling@apple.com [Wed, 29 May 2013 07:43:43 +0000 (07:43 +0000)]
Remove Document::nodeAbsIndex() and Document::nodeWithAbsIndex().

Rubber-stamped by Antti "Lucky" Koivisto.

* dom/Document.h:
* dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Clean up WebKit2 GNUmakefile.am
commit-queue@webkit.org [Wed, 29 May 2013 07:39:46 +0000 (07:39 +0000)]
[GTK] Clean up WebKit2 GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=116907

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-29
Reviewed by Martin Robinson.

Removed WebNotificationManagerProxy.messages.in after r150785.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFocusController should operate on Elements internally.
akling@apple.com [Wed, 29 May 2013 07:36:29 +0000 (07:36 +0000)]
FocusController should operate on Elements internally.
<http://webkit.org/b/116781>

Reviewed by Antti Koivisto.

Switch from Node* to Element* as much as possible inside FocusController.
Mostly mechanical, gets rid of some unnecessary isElementNode() checks and casts.

* page/FocusController.h:
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::isNonFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementRecursively):
(WebCore::FocusController::findFocusableElement):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::FocusController::setActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Mouse over an element does not trigger :hover state for parent when...
commit-queue@webkit.org [Wed, 29 May 2013 07:18:05 +0000 (07:18 +0000)]
[CSS Regions] Mouse over an element does not trigger :hover state for parent when the element is flowed in a region
https://bugs.webkit.org/show_bug.cgi?id=111749

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-29
Reviewed by Antti Koivisto.

Source/WebCore:

When searching for the hover ancestor and encountering a named flow thread,
the search will continue with the DOM ancestor of the top-most element
in the named flow thread.

Tests: fast/regions/hover-in-region-grandparent.html
       fast/regions/hover-in-region-parent-skip.html
       fast/regions/hover-in-region-parent-skip-inlines-anonymous.html
       fast/regions/hover-on-child-in-region.html
       fast/regions/hover-on-child-in-region-in-region.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::hoverAncestor):
* rendering/RenderObject.h:

LayoutTests:

* fast/regions/hover-in-region-grandparent-expected.txt: Added.
* fast/regions/hover-in-region-grandparent.html: Added.
* fast/regions/hover-in-region-parent-skip-expected.txt: Added.
* fast/regions/hover-in-region-parent-skip.html: Added.
* fast/regions/hover-in-region-parent-skip-inlines-anonymous-expected.txt: Added.
* fast/regions/hover-in-region-parent-skip-inlines-anonymous.html: Added.
* fast/regions/hover-on-child-in-region-expected.txt: Added.
* fast/regions/hover-on-child-in-region.html: Added.
* fast/regions/hover-on-child-in-region-in-region-expected.txt: Added.
* fast/regions/hover-on-child-in-region-in-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::SubresourceLoader::releaseResources when connection fails
japhet@chromium.org [Wed, 29 May 2013 05:29:54 +0000 (05:29 +0000)]
Crash in WebCore::SubresourceLoader::releaseResources when connection fails
https://bugs.webkit.org/show_bug.cgi?id=87743

Don't do anything complicated in SubresourceLoader::releaseResources(),
just clear variables. With this patch, releaseResources() will still
assert in debug builds if it is called twice, but it will safely execute
in release.

Reviewed by Darin Adler.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::cleanupForError): Pull shared cleanup code out of didFail()
    and cancel() into a helper.
(WebCore::ResourceLoader::cancel): Merge a couple variables into an enum, check for
    reentrancy from within didCancel().
* loader/ResourceLoader.h: Replace m_calledWillCancel and m_cancelled with an enum.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading): Don't call ResourceLoader::didFinishLoading(),
    put finish() in the middle of the process.
(WebCore::SubresourceLoader::didFail): Don't call ResourceLoader::didFail(), put finish()
    in the middle of the process.
(WebCore::SubresourceLoader::didCancel):
(WebCore::SubresourceLoader::notifyDone): Do the non-trivial work previous done in releaseResources(),
    most importantly calling loadDone().
(WebCore::SubresourceLoader::releaseResources): Only do simple variable clearing here.
* loader/SubresourceLoader.h:
(SubresourceLoader):
* loader/cache/CachedResource.cpp: Split stopLoading() into cancelLoad() (which notifies clients)
    and clearLoader() (which just nulls m_loader).
* loader/cache/CachedResource.h:
* loader/chromium/ResourceLoaderChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: Adding myself to committers list.
a.bah@samsung.com [Wed, 29 May 2013 05:29:54 +0000 (05:29 +0000)]
Unreviewed: Adding myself to committers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build fix after r150837
ryuan.choi@samsung.com [Wed, 29 May 2013 05:21:26 +0000 (05:21 +0000)]
[GTK] Build fix after r150837
https://bugs.webkit.org/show_bug.cgi?id=116904

Unreviewed build fix.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-28

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r150169): Images from file: URLs display after a delay even though they...
aestes@apple.com [Wed, 29 May 2013 04:56:08 +0000 (04:56 +0000)]
REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=116906
<rdar://problem/13991927>

Reviewed by Andreas Kling.

Writing a test for this is blocked on https://webkit.org/b/116199.

Some WebKit clients use JavaScript to preload images from disk so that
subsequent loads will display immediately from the memory cache. By not
caching non-HTTP sub-resources in memory, we break this common pattern.
This change restricts r150169 to only apply to cached main resources.
Sub-resources will again be cached indefinitely as they were prior to
r150169.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime): If this is a non-HTTP
main resource from a scheme that should not be cached indefinitely,
return 0 for the freshness lifetime. For other non-HTTP cached
resources, return an indefinite freshness lifetime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnimations do not restart after exiting page cache
dino@apple.com [Wed, 29 May 2013 03:14:10 +0000 (03:14 +0000)]
Animations do not restart after exiting page cache
https://bugs.webkit.org/show_bug.cgi?id=116900

Reviewed by Tim Horton.

Source/WebCore:

Animations are suspended as they enter the page cache, but
were not getting correctly resumed when exiting. The cause
was an error in r149576 which was checking a global flag for suspension
on the AnimationController and thus not trying to resume anything.

Test: animations/resume-after-page-cache.html

* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):

LayoutTests:

New test to make sure an animation will resume if it
enters and leaves the page cache.

* animations/resources/page-cache-helper.html: Added.
* animations/resume-after-page-cache-expected.txt: Added.
* animations/resume-after-page-cache.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDrag to move DOM nodes does not work
commit-queue@webkit.org [Wed, 29 May 2013 02:23:41 +0000 (02:23 +0000)]
Drag to move DOM nodes does not work
https://bugs.webkit.org/show_bug.cgi?id=116865

Do not block drag events on the WebKit 1 Web Inspector WebView.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-28
Reviewed by Timothy Hatcher.

* WebCoreSupport/WebInspectorClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Silence last crash to get bots green.
bfulgham@apple.com [Wed, 29 May 2013 00:19:51 +0000 (00:19 +0000)]
[Windows] Silence last crash to get bots green.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport multiple HRTFDatabases for different sample-rates
crogers@google.com [Tue, 28 May 2013 23:42:45 +0000 (23:42 +0000)]
Support multiple HRTFDatabases for different sample-rates
https://bugs.webkit.org/show_bug.cgi?id=116183

Reviewed by Kenneth Russell.

Adapted from Blink:
https://codereview.chromium.org/14636011/

This removes the limitation which required OfflineAudioContexts to be created at native sample-rate

* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::hrtfDatabaseLoader):
(AudioContext):
* Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
* Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore):
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
* platform/audio/HRTFDatabaseLoader.h:
(HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::loaderMap):
* platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
(WebCore::HRTFPanner::pan):
* platform/audio/HRTFPanner.h:
(HRTFPanner):
* platform/audio/Panner.cpp:
(WebCore::Panner::create):
* platform/audio/Panner.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Windows build fix.
ap@apple.com [Tue, 28 May 2013 23:35:24 +0000 (23:35 +0000)]
    Windows build fix.

        * platform/cf/KURLCFNet.cpp:
        (WebCore::KURL::createCFURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Many css2.1 tests fail on Apple's Windows port.
bfulgham@apple.com [Tue, 28 May 2013 23:27:23 +0000 (23:27 +0000)]
[Windows] Many css2.1 tests fail on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=75707

Reviewed by Darin Adler.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Export the WebCore::directoryName method for use by DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Freeze when loading a particular page on washingtonpost.com with NetworkProce...
ap@apple.com [Tue, 28 May 2013 23:26:48 +0000 (23:26 +0000)]
    Freeze when loading a particular page on washingtonpost.com with NetworkProcess enabled
        https://bugs.webkit.org/show_bug.cgi?id=116887
        <rdar://problem/12965959>

        Reviewed by Darin Adler.

        * Shared/cf/ArgumentCodersCF.cpp:
        (CoreIPC::encode):
        (CoreIPC::decode):
        Fix for the bug: use good shared WebCore code to manipulate CFURLs. Also, added
        a FIXME about empty URLs.

        * Shared/API/c/cf/WKURLCF.cpp: (WKURLCreateWithCFURL): Fixed to not use
        CFURLGetString, as that could prevent loading certain resources, like ones with
        curly braces in resource specifiers. We want KURL normalization, not CFURL one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Many css2.1 tests fail on Apple's Windows port.
bfulgham@apple.com [Tue, 28 May 2013 23:26:47 +0000 (23:26 +0000)]
[Windows] Many css2.1 tests fail on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=75707

Reviewed by Darin Adler.

* WebKit.vcproj/WebKitExports.def.in: Export the
WebCore::directoryName method for DRT use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Many CSS2.1 tests fail under NRWT.
bfulgham@apple.com [Tue, 28 May 2013 23:18:04 +0000 (23:18 +0000)]
[Windows] Many CSS2.1 tests fail under NRWT.
https://bugs.webkit.org/show_bug.cgi?id=75707

Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-28
Reviewed by Darin Adler.

* DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback): Added
(addFontFallbackIfPresent): Added
(removeFontFallbackIfPresent): Added
(runTest): Set up/remove font fallbacks when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] NRWT reports failure for 'mac' test cases.
bfulgham@apple.com [Tue, 28 May 2013 22:59:03 +0000 (22:59 +0000)]
[Windows] NRWT reports failure for 'mac' test cases.
https://bugs.webkit.org/show_bug.cgi?id=116698

Reviewed by Ryosuke Niwa.

The Windows port falls back to the Mac port for many test results,
and so adds the mac and mac-wk2 to its set of fallbacks.
Unfortunately, NRWT thinks that this means that tests in these
folders should be executed, resulting in many failures on
Windows.

This change overloads the '_tests_for_other_platforms' method
to return a subset of the result fallback list so that we do
not attempt to execute Mac tests on Windows.

* Scripts/webkitpy/port/base.py:
(Port.test_search_path): Added. Defaults to just calling the
baseline_search_path method, which is how most ports behave.
(Port._test_for_other_platforms): Modified to call the new
test_search_path method.

* Scripts/webkitpy/port/win.py:
(WinPort.test_search_path): Added custom overload. Strips
out mac-specific test paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] More attempts to make the bot green.
bfulgham@apple.com [Tue, 28 May 2013 22:57:21 +0000 (22:57 +0000)]
[Windows] More attempts to make the bot green.

* platform/win/TestExpectations: Exclude another two flaky tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
timothy_horton@apple.com [Tue, 28 May 2013 22:40:05 +0000 (22:40 +0000)]
fast/js/date-DST-time-cusps.html fails after trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895

Unreviewed, add failing test expectation.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Put correct byteCompile symbol in file. Previous version
bfulgham@apple.com [Tue, 28 May 2013 22:22:27 +0000 (22:22 +0000)]
[Windows] Put correct byteCompile symbol in file. Previous version
had an extra 'i' appended to the end.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix. Remove ?byteCompile symbol that
bfulgham@apple.com [Tue, 28 May 2013 22:07:02 +0000 (22:07 +0000)]
[Windows] Unreviewed build fix.  Remove ?byteCompile symbol that
is no longer accessible during link.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRendering suppression extension tokens shouldn't be 0, should handle overflow
timothy_horton@apple.com [Tue, 28 May 2013 21:52:21 +0000 (21:52 +0000)]
Rendering suppression extension tokens shouldn't be 0, should handle overflow
https://bugs.webkit.org/show_bug.cgi?id=116886
<rdar://problem/14004474>

Reviewed by Darin Adler.

Don't use invalid HashSet values as tokens, and ensure that
we're not already using a token before returning it.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendIncrementalRenderingSuppression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate a html/forms subdirectory and move FileIconLoader there
andersca@apple.com [Tue, 28 May 2013 21:50:46 +0000 (21:50 +0000)]
Create a html/forms subdirectory and move FileIconLoader there
https://bugs.webkit.org/show_bug.cgi?id=116880

Reviewed by Jessie Berlin.

A lot (if not the majority) of files in html/ are forms related, so it makes sense to begin splitting
them out into a separate subdirectory, html/forms.

Begin my moving FileIconLoader from platform to html/forms. It is related to HTML forms (it's only used by
the file upload element), and is not really a platform abstraction so it doesn't belong in platform.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/forms/FileIconLoader.cpp: Renamed from Source/WebCore/platform/FileIconLoader.cpp.
* html/forms/FileIconLoader.h: Renamed from Source/WebCore/platform/FileIconLoader.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: WKView is unable to set AXFocused to YES and does not handle keyboard events...
cfleizach@apple.com [Tue, 28 May 2013 21:47:35 +0000 (21:47 +0000)]
AX: WKView is unable to set AXFocused to YES and does not handle keyboard events as expected
https://bugs.webkit.org/show_bug.cgi?id=116756

Reviewed by Tim Horton.

If AXFocused is set to true, but the WebView is not the first responder, then the call will
not do anything. This change asks the Chrome to make the WebView the first responder before
trying to set focus within the page.

Was not able to make a test, it requires on interplay between areas outside the web view.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoString(new Date(2010,10,1)) is wrong in KRAT, YAKT
barraclough@apple.com [Tue, 28 May 2013 21:45:52 +0000 (21:45 +0000)]
String(new Date(2010,10,1)) is wrong in KRAT, YAKT
https://bugs.webkit.org/show_bug.cgi?id=106750

Reviewed by Darin Adler.

* runtime/JSDateMath.cpp:
(JSC::msToGregorianDateTime):
    - Additional review comment fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix after r150833
bfulgham@apple.com [Tue, 28 May 2013 21:45:06 +0000 (21:45 +0000)]
[Windows] Unreviewed build fix after r150833

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
A CR/LF combination was lost in the file, combining two symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoString(new Date(2010,10,1)) is wrong in KRAT, YAKT
barraclough@apple.com [Tue, 28 May 2013 21:33:51 +0000 (21:33 +0000)]
String(new Date(2010,10,1)) is wrong in KRAT, YAKT
https://bugs.webkit.org/show_bug.cgi?id=106750

Reviewed by Darin Adler.

First part of a fix, simplfy date handling code, instead of operating separately
on the UTC-standard and standard-DST offsets, just generate a combined UTC-local
offset (this is what we actually need, and what the OS gives us).

../JavaScriptCore:

* runtime/JSDateMath.cpp:
(JSC::getLocalTimeOffset):
    - removed getUTCOffset, converted getDSTOffset -> getLocalTimeOffset
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
    - call getLocalTimeOffset instead of getUTCOffset/getDSTOffset
* runtime/VM.cpp:
(JSC::VM::resetDateCache):
    - removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
* runtime/VM.h:
(JSC::LocalTimeOffsetCache::LocalTimeOffsetCache):
(JSC::LocalTimeOffsetCache::reset):
(LocalTimeOffsetCache):
    - removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache

../WTF:

* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
(WTF::calculateDSTOffset):
    - made static, now not called from outside of this file.
(WTF::calculateLocalTimeOffset):
    - This combines the 2038 related adjustment from calculateDSTOffset with the
      maxUnixTime adjustment from calculateDSTOffsetSimple. Then, if HAVE(TM_GMTOFF)
      just call getLocalTime, if not use calculateUTCOffset/calculateDSTOffset.
(WTF::parseDateFromNullTerminatedCharacters):
    - call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
* wtf/DateMath.h:
(WTF::LocalTimeOffset::LocalTimeOffset):
(LocalTimeOffset):
(WTF::LocalTimeOffset::operator==):
    - new struct type, a tuple of UTC-local offset & isDST flag.
    - replaced calculateUTCOffset/calculateDSTOffset with calculateLocalTimeOffset
* wtf/GregorianDateTime.cpp:
(WTF::GregorianDateTime::setToCurrentLocalTime):
    - call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agor150199 is very wrong
mhahnenberg@apple.com [Tue, 28 May 2013 21:18:44 +0000 (21:18 +0000)]
r150199 is very wrong
https://bugs.webkit.org/show_bug.cgi?id=116876

JSValue needs to protect its internal JSValueRef.

Reviewed by Darin Adler.

* API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
* API/tests/testapi.mm: Added a simple test to make sure that we protect the
underlying JavaScript value across garbage collections.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Silence a few failures to get bot green.
bfulgham@apple.com [Tue, 28 May 2013 21:04:14 +0000 (21:04 +0000)]
[Windows] Silence a few failures to get bot green.
https://bugs.webkit.org/show_bug.cgi?id=116564

* platform/win/TestExpectations: Disable some tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::reposition...
jer.noble@apple.com [Tue, 28 May 2013 20:17:47 +0000 (20:17 +0000)]
Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
https://bugs.webkit.org/show_bug.cgi?id=116882

Reviewed by Eric Carlson.

Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.

* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::repositionGenericCue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix line endings in test added in r150602
robert@webkit.org [Tue, 28 May 2013 18:55:36 +0000 (18:55 +0000)]
Fix line endings in test added in r150602

Unreviewed.

* fast/css/text-overflow-ellipsis-behind-floats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GraphicsContext: add missing definitions.
commit-queue@webkit.org [Tue, 28 May 2013 18:46:05 +0000 (18:46 +0000)]
[BlackBerry] GraphicsContext: add missing definitions.
https://bugs.webkit.org/show_bug.cgi?id=115515

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-28
Reviewed by Rob Buis.

* platform/graphics/GraphicsContext.h:
(Graphics):
Add definition for PlatformGraphicsContext.
* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
Include RoundedRect.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
anilsson@rim.com [Tue, 28 May 2013 18:40:51 +0000 (18:40 +0000)]
[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
https://bugs.webkit.org/show_bug.cgi?id=116604

Reviewed by Carlos Garcia Campos.

Source/WebCore:

PR 273550, 99638

Remove the "get" prefix from getters in the WebKit- and compositing-
thread layer classes, as well as LayerRendererSurface. Clarify which
geometry-related getters return normalized device coordinates by adding
a comment.

Also remove dead code related to LayerData::m_holePunchClipRect, which
was part of an eventually disabled fix for video clipping in iframes,
PR 99638. Since we now use AC layers for iframes, the bug is no longer
reproducible, and the dead code will never need to be enabled again.

No change in behavior, no new tests.

* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::LayerCompositingThread::transformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::sublayers): Removed "get" prefix
(LayerCompositingThread):
(WebCore::LayerCompositingThread::boundingBox): Renamed from "getDrawRect"
(WebCore::LayerCompositingThread::transformedBounds): Removed "get" prefix
(WebCore::LayerCompositingThread::transformedHolePunchRect): Removed "get" prefix
* platform/graphics/blackberry/LayerData.h:
(LayerData): Removed unused data member "m_holePunchClipRect"
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::prepareFrameRecursive):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::collect3DPreservingLayers):
(WebCore::LayerRenderer::compositeLayersRecursive):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::boundingBox):
* platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::boundingBox): Renamed from "drawRect" because that sounds like a verb, and this is a getter
* platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::sublayers): Removed "get" prefix
* platform/graphics/blackberry/VideoLayerWebKitThread.cpp:
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::boundsChanged):

Source/WebKit/blackberry:

Adapt to the removal of "get" prefix from getters in the WebKit- and
compositing-thread layer classes.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMade AudioNode an EventTarget
jer.noble@apple.com [Tue, 28 May 2013 17:54:20 +0000 (17:54 +0000)]
Made AudioNode an EventTarget
https://bugs.webkit.org/show_bug.cgi?id=116871

Source/WebCore:

Merge: https://chromium.googlesource.com/chromium/blink/+/ef37484162ddb95d677dcfdcdd778ec60590928b

Reviewed by Darin Adler.

Tests: webaudio/audionode-expected.txt:
       webaudio/audionode.html:

Add the requisite boilerplate to allow AudioNode to become an EventTarget. Remove
all that same boilerplate from ScriptProcessorNode now that it's base class
is an EventTarget.

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::interfaceName): Added boilerplate.
(WebCore::AudioNode::scriptExecutionContext): Return the AudioContext's context.
(WebCore::AudioNode::processIfNecessary): Whitespace.
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/AudioNode.idl: Make AudioNode an EventTarget.
* Modules/webaudio/ScriptProcessorNode.cpp: Remove EventTarget boilerplate.
* Modules/webaudio/ScriptProcessorNode.h: Ditto.
* Modules/webaudio/ScriptProcessorNode.idl: Ditto.
* dom/EventTarget.h: Mark AudioNode as an EventTarget.
* dom/EventTargetFactory.in: Ditto.

LayoutTests:

Reviewed by Darin Adler.

* webaudio/audionode-expected.txt:
* webaudio/audionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters
anilsson@rim.com [Tue, 28 May 2013 17:28:35 +0000 (17:28 +0000)]
[BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters
https://bugs.webkit.org/show_bug.cgi?id=116616

Reviewed by Carlos Garcia Campos.

The BlackBerry::Platform::Graphics::GraphicsContext generates geometry
with a different winding order than the accelerated compositing backend
of the BlackBerry port. So, when we switched from Skia to this new
rendering engine, we switched from glFrontFace(GL_CCW) to
glFrontFace(GL_CW), and all was well when drawing display lists.
However, we forgot to update the winding order of geometry generated
within the accelerated compositing backend, which is used for masks and
filters, so they were getting erroneously culled out when
backface-visibility: hidden was applied to them. Fixed by switching the
winding order of all geometry generated up here, which has the added
benefit of enabling us to use TransformationMatrix::mapQuad instead of
transforming point-by-point.

To further complicate matters, a right-side up transform is used when
drawing layers into surfaces, reversing the winding order and requiring
us to switch back to glFrontFace(GL_CCW) temporarily, when drawing
layers to surfaces, or the layers will get culled out inside the
surface.

Also fix spelling error, "drawed" should be "drawn".

No new tests, this is only detectable by pixel tests, which the
BlackBerry port currently doesn't support.

PR 341945.

* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WebCore::LayerCompositingThread::origin):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
(WebCore):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds):
* platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::origin):
(LayerRendererSurface):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Connection issues in repeated WebProcess crash/reloads.
lauro.neto@openbossa.org [Tue, 28 May 2013 17:12:07 +0000 (17:12 +0000)]
[GTK] Connection issues in repeated WebProcess crash/reloads.
https://bugs.webkit.org/show_bug.cgi?id=115880

Reviewed by Anders Carlsson.

When stressing the WebProcess creation/destruction, WebKitGTK can
often run into socket issues like bad file descriptor errors or
polling a socket indefinitely.

Currently WebKitGTK has three places where a socket can be
closed.

- childFinishedFunction (in ProcessLauncherGtk.cpp)
- Connection::platformInvalidate (in ConnectionUnix.cpp)
- WorkQueue EventSource destruction (in WorkQueueGtk.cpp)

To avoid these race conditions, socket closing will be handled
by the event source callback in WorkQueueGtk.cpp.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate): Do not close the socket
when the connection is invalidated, the socket event source is
unregistered in this method and the socket is closed when the
GSocket associated to the event source is destroyed.
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Do not monitor child
process to close the connection on termination. This was needed in
the past when we used DGRAM sockets, we currently use always
connection oriented sockets, so that when the other end closes
the connection we are notified and the connection is invalidated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix GTK+ CMake build
mrobinson@webkit.org [Tue, 28 May 2013 16:03:25 +0000 (16:03 +0000)]
Fix GTK+ CMake build

Source/WebKit2:

* PlatformGTK.cmake: After r150336, the name of the WebKit2
library target is simply "WebKit2."

Tools:

* MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
library target is simply "WebKit2."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove Node::dispatchChangeEvent() to HTMLFormControlElement.
akling@apple.com [Tue, 28 May 2013 14:41:11 +0000 (14:41 +0000)]
Move Node::dispatchChangeEvent() to HTMLFormControlElement.
<http://webkit.org/b/116866>

Reviewed by Anders Carlsson.

...and devirtualize it, since it had no overrides.

* dom/Node.h:
* dom/Node.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
* html/FileInputType.cpp:
(WebCore::FileInputType::setFiles):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring CSS grammar
sergio@webkit.org [Tue, 28 May 2013 14:37:34 +0000 (14:37 +0000)]
Refactoring CSS grammar
https://bugs.webkit.org/show_bug.cgi?id=116679

Reviewed by Andreas Kling.

From Blink r149948 by <serya@chromium.org>

Added "closing_parenthesis:" and "error_recovery:" to avoid code
duplication in a couple of error recovery rules. Some other rules
were also refactored which allows to reduce the the number of
shift/reduce conflicts by 2.

No new tests required as this is just a refactoring, no new
functionality added.

* css/CSSGrammar.y.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInvalid block doesn't make declaration invalid
sergio@webkit.org [Tue, 28 May 2013 14:31:11 +0000 (14:31 +0000)]
Invalid block doesn't make declaration invalid
https://bugs.webkit.org/show_bug.cgi?id=115709

Reviewed by Andreas Kling.

From Blink r149446 by <serya@chromium.org>

Source/WebCore:

Added a new rule "declaration_recovery:" which covers any kind of
"invalid_block_list maybe_space" sequence. By appending this new
rule to every rule reductable to "declaration:" we can remove some
redundant rules and improve error recovery of some others that
were only accepting exactly one error.

One of the rules being removed was preventing invalid blocks in a
declaration to invalidate the whole declaration. The rule was
reporting the syntax error but at the same time accepting the
invalid block as part of a valid declaration.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-error-recovery.html: Added 2 new test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][CoordinatedGraphics] DrawingArea's visible content area must be updated when...
marcelo.lira@openbossa.org [Tue, 28 May 2013 14:08:55 +0000 (14:08 +0000)]
[WK2][CoordinatedGraphics] DrawingArea's visible content area must be updated when contents size changes
https://bugs.webkit.org/show_bug.cgi?id=116845

Reviewed by Noam Rosenthal.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove dispatching of focus-related events from Node to Element.
akling@apple.com [Tue, 28 May 2013 14:01:20 +0000 (14:01 +0000)]
Move dispatching of focus-related events from Node to Element.
<http://webkit.org/b/116864>

Reviewed by Antti Koivisto.

...and pass around pointers to Element instead of Node.

* dom/Node.cpp:
* dom/Node.h:
* dom/Element.h:
* dom/Element.cpp:
(WebCore::Element::dispatchFocusInEvent):
(WebCore::Element::dispatchFocusOutEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):

    Moved here from Node.

* html/HTMLFormControlElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchBlurEvent):
* html/HTMLSelectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
* html/HTMLTextFormControlElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):

    Update subclass overrides and sprinkle OVERRIDE/FINAL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[webkitpy] Explicitly specify the reference file extensions
zandobersek@gmail.com [Tue, 28 May 2013 13:34:19 +0000 (13:34 +0000)]
[webkitpy] Explicitly specify the reference file extensions
https://bugs.webkit.org/show_bug.cgi?id=116333

Reviewed by Benjamin Poulain.

Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
between valid reference files required by reftests and text baselines that have the same extension as
potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
that were until this change recognized as reference files).

Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.

* Scripts/webkitpy/port/base.py:
(Port.reference_files): Iterate through the _supported_reference_extensions set.
(Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
_supported_reference_extensions set, containing the extensions allowed for reference files.
(Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
(Port._has_supported_extension): Use _supported_test_extensions.
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
Port.is_reference_html_file method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove CachedResourceRequest::initiatorElement
zandobersek@gmail.com [Tue, 28 May 2013 13:22:22 +0000 (13:22 +0000)]
Remove CachedResourceRequest::initiatorElement
https://bugs.webkit.org/show_bug.cgi?id=116862

Reviewed by Andreas Kling.

The CachedResourceRequest::initiatorElement method is not used anywhere and should be removed.

* loader/cache/CachedResourceRequest.cpp: Remove the initiatorElement method definition.
* loader/cache/CachedResourceRequest.h:
(CachedResourceRequest): Remove the initiatorElement method declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode
commit-queue@webkit.org [Tue, 28 May 2013 13:07:36 +0000 (13:07 +0000)]
[Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode
https://bugs.webkit.org/show_bug.cgi?id=116597

ScrollingCoordinatorCoordinatedGraphics is tailored specifically for
fixedLayout mode. When fixedLayout is not set, it should be turned off.

Patch by Noam Rosenthal <noam@webkit.org> on 2013-05-28
Reviewed by Allan Sandfeld Jensen.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskip now passing tests.
kadam@inf.u-szeged.hu [Tue, 28 May 2013 13:01:04 +0000 (13:01 +0000)]
[Qt] Unreviewed gardening. Unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDocument::setFocusedNode() should be setFocusedElement().
akling@apple.com [Tue, 28 May 2013 12:46:31 +0000 (12:46 +0000)]
Document::setFocusedNode() should be setFocusedElement().
<http://webkit.org/b/116857>

Reviewed by Antti Koivisto.

Source/WebCore:

Only Elements can be focused, so tighten Document's idea of what's focused.

Most of this patch is just updating call sites for the new names and removing
now-unnecessary isElementNode() checks and casts.

* WebCore.exp.in:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
* bindings/objc/DOM.mm:
(-[DOMElement isFocused]):
* dom/Document.cpp:
(WebCore::Document::dispose):
(WebCore::Document::detach):
(WebCore::Document::focusedNodeRemoved):
(WebCore::Document::removeFocusedNodeOfSubtree):
(WebCore::Document::setFocusedElement):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::eventTargetNodeForDocument):
* dom/Document.h:
(Document):
(WebCore::Document::focusedElement):
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::focus):
(WebCore::Element::blur):
(WebCore::Element::cancelFocusAppearanceUpdate):
* dom/Node.cpp:
(WebCore::Node::rendererIsEditable):
* dom/TreeScope.cpp:
(WebCore::TreeScope::focusedElement):
* dom/UserTypingGestureIndicator.cpp:
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
* editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::setFocusedElementIfNeeded):
(WebCore::FrameSelection::currentForm):
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::attach):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setValueCommon):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selectionDirection):
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::focusedFieldIndex):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
* page/EventHandler.cpp:
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::capsLockStateMayHaveChanged):
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::setFocusedElement):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
* plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement):
* plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::setFocus):
* plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isFocused):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
(BlackBerry::WebKit::WebPage::setNodeFocus):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get):
* ewk/ewk_view.cpp:
(ewk_view_input_method_state_set):

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(getFocusedNode):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView clearFocus]):
(-[WebHTMLView becomeFirstResponder]):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::hasFocus):
(QWebElement::setFocus):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::mousePressEvent):
(QWebPageAdapter::handleSoftwareInputPanel):
(QWebPageAdapter::inputMethodQuery):
(QWebPageAdapter::hasFocusedNode):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::isFocused):
* WebView.cpp:
(WebView::setInitialFocus):

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::focusPluginElement):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::setInitialFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix BlackBerry debug build after r150756.
carlosgc@webkit.org [Tue, 28 May 2013 10:43:51 +0000 (10:43 +0000)]
Unreviewed. Fix BlackBerry debug build after r150756.

* WebKitSupport/PagePopup.cpp:
(BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip now passing tests.
ossy@webkit.org [Tue, 28 May 2013 10:22:46 +0000 (10:22 +0000)]
Unskip now passing tests.

* platform/qt-arm/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip failing tests after parallel gc is enabled.
kadam@inf.u-szeged.hu [Tue, 28 May 2013 09:37:44 +0000 (09:37 +0000)]
[Qt] Unreviewed gardening. Skip failing tests after parallel gc is enabled.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Clean up duplicated include files.
gyuyoung.kim@samsung.com [Tue, 28 May 2013 09:29:02 +0000 (09:29 +0000)]
[EFL][WK2] Clean up duplicated include files.
https://bugs.webkit.org/show_bug.cgi?id=116851

Reviewed by Christophe Dumez.

Remove some of duplicated include file in ewk files.

* UIProcess/API/efl/EwkView.h:
* UIProcess/API/efl/ewk_color_picker.cpp:
* UIProcess/API/efl/ewk_context_menu.cpp:
* UIProcess/API/efl/ewk_security_origin_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Enable CSS logging
sergio@webkit.org [Tue, 28 May 2013 07:21:02 +0000 (07:21 +0000)]
Web Inspector: Enable CSS logging
https://bugs.webkit.org/show_bug.cgi?id=113401

Reviewed by Benjamin Poulain.

From Blink r149265 by <serya@chromium.org>

Source/WebCore:

CSS logging was disabled in r147028 to prevent message overflow in
the inspector console. This change restores it by modifying the
CSS grammar in order to reduce as much consecutive errors as
possible in 'declaration_list' and 'decl_list' rules.

This way, for rules like 'x { color: ### }' only the first '#'
will be reported as error (instead of 3 identical errors).

The rule 'declaration' still produces multiple errors, because it
does not eat as much errors as possible. So in order not to create
a complex risky patch we just disable logging in the parser for
that rule.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::rewriteSpecifiers):
* css/CSSParser.h:
(CSSParser):

LayoutTests:

Unskipped console-css-warnings.html now that it's working.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] pc files should have harfbuzz dependency.
ryuan.choi@samsung.com [Tue, 28 May 2013 07:18:16 +0000 (07:18 +0000)]
[EFL] pc files should have harfbuzz dependency.
https://bugs.webkit.org/show_bug.cgi?id=116852

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

* ewebkit.pc.in: Added harfbuzz as Required package.

Source/WebKit2:

* efl/ewebkit2.pc.in: Added harfbuzz as Required package.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r150730.
paroga@webkit.org [Tue, 28 May 2013 07:02:38 +0000 (07:02 +0000)]
Build fix for WinCE after r150730.

* platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r150772.
paroga@webkit.org [Tue, 28 May 2013 06:57:20 +0000 (06:57 +0000)]
Build fix for WinCE after r150772.

* platform/win/ClipboardWin.cpp:
(WebCore):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::readFilenames):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Remove unneeded WebCore namespace use in ewk
gyuyoung.kim@samsung.com [Tue, 28 May 2013 06:48:24 +0000 (06:48 +0000)]
[EFL][WK2] Remove unneeded WebCore namespace use in ewk
https://bugs.webkit.org/show_bug.cgi?id=116707

Reviewed by Christophe Dumez.

* UIProcess/API/efl/ewk_security_origin.cpp: Remove "using namespace WebCore".
* UIProcess/API/efl/ewk_text_checker.cpp: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse correct stack size on Solaris and OpenBSD
paroga@webkit.org [Tue, 28 May 2013 06:31:48 +0000 (06:31 +0000)]
Use correct stack size on Solaris and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=114978

Recommit after wrong rollout in r150621.

* wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Notifications clobber each other with multiple processes
jonlee@apple.com [Tue, 28 May 2013 00:02:46 +0000 (00:02 +0000)]
[WK2] Notifications clobber each other with multiple processes
https://bugs.webkit.org/show_bug.cgi?id=116428
<rdar://problem/13935191>

Reviewed by Darin Adler.

.:

* ManualTests/notification-in-multiple-windows.html: Added.

Source/WebKit2:

With multiple processes, the notification IDs, when passed up to the UI process, can clobber
each other. To fix this, we need to maintain a global map of notification IDs. This map is
keyed by its own unique notification ID, and maps to a pair containing the web page ID and that
web page's ID for the notification.

Now that we maintain groups of notifications based on the web page, we no longer send IPC messages
from WebNotificationManager to WebNotificationManagerProxy; instead we send messages to the
WebPageProxy. This removes the need for WebNotificationManagerProxy to be a message receiver.

When a page closes, all of the web notifications are cleared out. However, by the time the
WebPage::close() is called, the connection between WebPage and WebPageProxy is destroyed. Since
the WebPage is told to close from the UI process anyway, we clear out the notifications separately,
instead of waiting for a message from the WebPage.

* UIProcess/Notifications/WebNotificationManagerProxy.h: Update to take into account the
notification's web page. Remove inheritance of CoreIPC::MessageReceiver. Expose the original message
handlers as public functions, since they will be called from WebPageProxy. Add a new map that
associates a global ID with a notification ID that came from a web page.
    There are now two flavors of clearNotifications(). One clears out all notifications associated
with a web page. This is called when the page is closed. The other clears out a subset of
notifications associated with a web page. This is called when notifications associated with a sub-frame
is closed.
* UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Removed. All messages from
the web process go to WebPageProxy now.

* UIProcess/Notifications/WebNotificationManagerProxy.cpp: Update to take into account the
notification's web page.

(WebKit::generateGlobalNotificationID): The manager proxy now maintains its own global notification
ID generator.
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy): The proxy is no longer a
message receiver. Remove code that registers it as such.

(WebKit::WebNotificationManagerProxy::show): Refactor to differentiate between the notification ID
that came from the web process, and the global notification ID the proxy maintains. Add the mapping
from the global ID to the (web page ID, notification ID) pair.
(WebKit::WebNotificationManagerProxy::cancel): Refactor to take into consideration the web page.
(WebKit::WebNotificationManagerProxy::didDestroyNotification): Refactor to take into consideration
the web page. Fixes a leak where we did not remove the item from the maps. This function is called
from the web process, when the ScriptExecutionContext is destroyed, so we remove it from our maps
before we pass the message along to the provider.

Helper functions that evaluate when a given notification in the map matches the desired parameters.
(WebKit::pageIDsMatch): The notification is associated with the provided page.
(WebKit::pageAndNotificationIDsMatch): The notification is associated with the provided page and is
contained within the list of provided notifications.

(WebKit::WebNotificationManagerProxy::clearNotifications): Changed to only remove notifications
associated with the provided web page, and could include a specific list of notifications. This latter
situation occurs if notifications were associated with an iframe, and that iframe was removed.
There is an O(n) walk that could be make more efficient using another hash map, but that's overhead
for a map that should be small in size anyway.

(WebKit::WebNotificationManagerProxy::providerDidShowNotification): Refactor to take into
consideration the web page.
(WebKit::WebNotificationManagerProxy::providerDidClickNotification): Refactor to take into
consideration the web page.
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): Now we need to comb through
the list of global IDs and put them in buckets based on the notification's web pages. After that
is done we can send the DidCloseNotifications() to those pages' processes. There is a possible
extra optimization here where we group based on the page's process instead, to reduce the number
of messages sent to processes.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): When a web page is closed, we clear the notifications associated
with the page.
(WebKit::WebPageProxy::cancelNotification): Forward call to WebNotificationManagerProxy.
(WebKit::WebPageProxy::clearNotifications): Ditto.
(WebKit::WebPageProxy::didDestroyNotification): Ditto.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Remove extraneous include.

* CMakeLists.txt: Remove WebNotificationManagerProxy.messages.in and related files.
* DerivedSources.pri: Ditto.
* DerivedSources.make: Ditto.
* GNUmakefile.list.am: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo that broke the build.
darin@apple.com [Mon, 27 May 2013 23:55:26 +0000 (23:55 +0000)]
Fix typo that broke the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove hasNonEmptyBoundingBox from Node to HTMLAnchorElement
darin@apple.com [Mon, 27 May 2013 23:53:47 +0000 (23:53 +0000)]
Move hasNonEmptyBoundingBox from Node to HTMLAnchorElement
https://bugs.webkit.org/show_bug.cgi?id=116842

Reviewed by Antti Koivisto.

* dom/Node.cpp: Removed hasNonEmptyBoundingBox.
* dom/Node.h: Ditto.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable): Fixed #if to be more readable and
added more-explicit clearer comments. No behavior change.
(WebCore::hasNonEmptyBox): Added.  Has the same code that was in
Node::hasNonEmptyBoundingBox with some additional comments.
(WebCore::HTMLAnchorElement::isKeyboardFocusable): Call hasNonEmptyBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove isBlockFlowElement and related functions out of the Node class into editing...
darin@apple.com [Mon, 27 May 2013 23:40:38 +0000 (23:40 +0000)]
Move isBlockFlowElement and related functions out of the Node class into editing code
https://bugs.webkit.org/show_bug.cgi?id=116846

Reviewed by Antti Koivisto.

* dom/Node.cpp: Removed isBlockFlowElement, enclosingBlockFlowElement, and
inSameContainingBlockFlowElement. These are all editing functions that don't
belong in the Node class, and mostly-deprecated ones to boot.
* dom/Node.h: Ditto.

* dom/Position.cpp:
(WebCore::inSameEnclosingBlockFlowElement): Added. This editing-specific function
is used only here, so put it here.
(WebCore::Position::rendersInDifferentPosition): Updated to call new function above.
(WebCore::Position::leadingWhitespacePosition): Ditto.

* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use
deprecatedEnclosingBlockFlowElement at its new location.
(WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph): use
isBlockFlowElement at its new location.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::enclosingInline): Ditto.

* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition): Use deprecatedEnclosingBlockFlowElement
at its new location.
(WebCore::enclosingBlockFlowElement): Ditto. Also added FIXME.
* editing/VisibleSelection.cpp:
(WebCore::makeSearchRange): Ditto.

* editing/htmlediting.cpp:
(WebCore::isBlockFlowElement): Added. Same as the Node::isBlockFlowElement
function, but here because this is an editing function, not suitable as a Node member.
(WebCore::deprecatedEnclosingBlockFlowElement): Ditto. Added "deprecated" to the name
since the Node member function had a comment saying it was deprecated. Also changed so
it tolerates a 0 for an argument, which made it easier for one caller.

* editing/htmlediting.h: Added the two new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a balanced benchmark for QuerySelector
benjamin@webkit.org [Mon, 27 May 2013 22:31:02 +0000 (22:31 +0000)]
Add a balanced benchmark for QuerySelector
https://bugs.webkit.org/show_bug.cgi?id=116811

Reviewed by Sam Weinig.

The goal of this benchmark is to have an overview of querySelector as typically used
by webpages.

It uses queries similar to what is used by popular websites and applies somewhat
similar weighting for each type of query.

The tree used for the queries is intentionally kept simple to ensure we measure QuerySelector
a not purely the overhead of traversal.

* CSS/QuerySelector.html: Added.
* CSS/resources/query-selector.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Clear supression flag when caret changes aren't propogated through
commit-queue@webkit.org [Mon, 27 May 2013 21:59:52 +0000 (21:59 +0000)]
[BlackBerry] Clear supression flag when caret changes aren't propogated through
https://bugs.webkit.org/show_bug.cgi?id=116840

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-27
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR339965
We set and clear the flag upon every use. This leaves us vulnerable if
1. midway through processing the selection change event is dismissed and
2. we don't receive a TouchRelease event
One example of this is while dragging the FCC handle we start typing. To
safeguard against this, if the process change guard is set during a
selection change event, we send out to clear the flag status before returning.

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::selectionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd guard around paintForFixedRootBackground
commit-queue@webkit.org [Mon, 27 May 2013 21:11:58 +0000 (21:11 +0000)]
Add guard around paintForFixedRootBackground
https://bugs.webkit.org/show_bug.cgi?id=116754

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-27
Reviewed by Simon Fraser.

paintForFixedRootBackground is only used when ACCELERATED_COMPOSITING is enabled.

No new tests, no behavior change.

* rendering/RenderLayer.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove a leftover Pagepoup from PickerIndicatorElement.h
commit-queue@webkit.org [Mon, 27 May 2013 21:00:34 +0000 (21:00 +0000)]
Remove a leftover Pagepoup from PickerIndicatorElement.h
https://bugs.webkit.org/show_bug.cgi?id=116801

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-27
Reviewed by Anders Carlsson.

No new tests, no behavior change.

* html/shadow/PickerIndicatorElement.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS] -webkit-var prefix is case-sensitive
csaavedra@igalia.com [Mon, 27 May 2013 20:58:52 +0000 (20:58 +0000)]
[CSS] -webkit-var prefix is case-sensitive
https://bugs.webkit.org/show_bug.cgi?id=116829

Reviewed by Darin Adler.

Source/WebCore:

Tests: Added case to fast/css/variables/case-sensitive.html

* css/CSSParser.cpp:
(WebCore::isEqualToCSSCaseSensitiveIdentifier): Add variant to
IsEqualToCSSIdentifier that respects case-sensitivity.
(WebCore::CSSParser::realLex): Use the above method for CSS
variable declarations.

LayoutTests:

* fast/css/variables/case-sensitive.html: Add a
check for case-sensitiveness of the prefix of
variable declarations.
* fast/css/variables/case-sensitive-expected.html: Update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodrop-shadow filter with overflow:hidden child misbehaves.
commit-queue@webkit.org [Mon, 27 May 2013 20:07:40 +0000 (20:07 +0000)]
drop-shadow filter with overflow:hidden child misbehaves.
https://bugs.webkit.org/show_bug.cgi?id=109783

Patch by Zalan Bujtas <zalan@apple.com> on 2013-05-27
Reviewed by Simon Fraser.

Applying CSS filters only to the scrollbar rect leaves rendering
artefacts. Filters should skip such partial repaints.

Tests: Test framework uses mock theme for scrollbars. Such scrollbars do not
initiate partial repaints.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
* rendering/RenderLayer.h:
(RenderLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix take 2.
timothy_horton@apple.com [Mon, 27 May 2013 20:04:00 +0000 (20:04 +0000)]
Unreviewed build fix take 2.

* WebProcess/Plugins/PDF/PDFPlugin.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
timothy_horton@apple.com [Mon, 27 May 2013 19:58:00 +0000 (19:58 +0000)]
Unreviewed build fix.

* WebProcess/Plugins/PDF/PDFPlugin.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove Windows port off legacy clipboard.
commit-queue@webkit.org [Mon, 27 May 2013 19:51:49 +0000 (19:51 +0000)]
Move Windows port off legacy clipboard.
https://bugs.webkit.org/show_bug.cgi?id=116258

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-05-27
Reviewed by Darin Adler.

Source/WebCore:

Clipboard refactor, no new tests.

* dom/Clipboard.h:
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingClipboard): Create Clipboard instead of ClipboardWin.
* platform/Pasteboard.h:
(WebCore::Pasteboard::dataObject): Get IDataObject by Clipborad.
(WebCore::Pasteboard::writableDataObject): Get WCDataObject by Clipborad.
* platform/win/ClipboardWin.cpp:
(WebCore::Clipboard::createDragImage): Change parameter name loc to dragLocation.
(WebCore::Clipboard::declareAndWriteDragImage): Implement declareAndWriteDragImage use WCDataObject exposed by Pasteboard.
* platform/win/ClipboardWin.h: Removed.
* platform/win/EditorWin.cpp:
(WebCore::Editor::newGeneralClipboard): Create Clipboard instead of ClipboardWin.
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::createForCopyAndPaste): Create a Pasteboard.
(WebCore::Pasteboard::createPrivate): Ditto.
(WebCore::Pasteboard::createForDragAndDrop): Ditto.
(WebCore::Pasteboard::finishCreatingPasteboard): Create Pasteboard use Windows API.
(WebCore::Pasteboard::Pasteboard):
(WebCore::clipboardTypeFromMIMEType): Copied from ClipboardWin.cpp.
(WebCore::Pasteboard::clear): Ditto.
(WebCore::Pasteboard::hasData): Ditto.
(WebCore::addMimeTypesForFormat): Ditto.
(WebCore::Pasteboard::types): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::readFilenames): Ditto.
(WebCore::writeURL): Ditto.
(WebCore::Pasteboard::writeString): Ditto.
(WebCore::Pasteboard::setDragImage): Ditto.
(WebCore::Pasteboard::writeRangeToDataObject): Write range to WCDataObject.
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainTextToDataObject): Write PlainText to WCDataObject.
(WebCore::Pasteboard::writePlainText):
(WebCore::pathRemoveBadFSCharacters): Copied from ClipboardWin.cpp.
(WebCore::filesystemPathFromUrlOrTitle): Ditto.
(WebCore::writeFileToDataObject): Ditto.
(WebCore::Pasteboard::writeURLToDataObject): Write URL to WCDataObject.
(WebCore::Pasteboard::writeURL): Copied from ClipboardWin.cpp.
(WebCore::Pasteboard::writePasteboard): Copied from Pasteboard::writeClipboard.
(WebCore::Pasteboard::documentFragment): Copied from ClipboardWin.cpp.
(WebCore::Pasteboard::setExternalDataObject): Clipboard can set new IDataObject.
(WebCore::getCachedImage): Copied from ClipboardWin.cpp.
(WebCore::createGlobalImageFileDescriptor): Ditto.
(WebCore::createGlobalImageFileContent): Ditto.
(WebCore::createGlobalHDropContent): Ditto.
(WebCore::Pasteboard::writeImageToDataObject): Expose to make Clipboard implement declareAndWriteDragImage.
(WebCore::Pasteboard::writeURLToWritableDataObject): Ditto.

Source/WebKit/win:

* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::willPerformDragSourceAction): Get IDataObject from Pasteboard instead of Clipboard.
(WebDragClient::startDrag): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDFPlugin: Main-frame PDFPlugin Accessibility
timothy_horton@apple.com [Mon, 27 May 2013 19:50:48 +0000 (19:50 +0000)]
PDFPlugin: Main-frame PDFPlugin Accessibility
https://bugs.webkit.org/show_bug.cgi?id=116563
<rdar://problem/13458534>

Reviewed by Sam Weinig.

* WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Forward-declare a variety of accessibility methods.

* WebProcess/Plugins/PDF/PDFPlugin.h:
Add convertFromPDFViewToScreen, boundsOnScreen, accessibilityObject, and
storage for our accessibility wrapper.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
Add WKPDFPluginAccessibilityObject.

(-[WKPDFPluginAccessibilityObject accessibilityIsIgnored]):
We want to be included in the accessibility tree.

(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
Grab values for accessibility attributes from the relevant sources
(mostly from PDFLayerController).

(-[WKPDFPluginAccessibilityObject readingModel]): Ditto.
(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityParameterizedAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityActionNames]):
Return the set of accessibility attributes, actions, and parameterized
attributes that we support.

(-[WKPDFPluginAccessibilityObject accessibilityIsAttributeSettable:]):
(-[WKPDFPluginAccessibilityObject accessibilitySetValue:forAttribute:]):
Forward some other accessibility methods to PDFLayerController.

(-[WKPDFPluginAccessibilityObject accessibilityFocusedUIElement]):
(-[WKPDFPluginAccessibilityObject accessibilityHitTest:]):
We have no children, so if a hit test makes it to us, it's ours.

(WebKit::PDFPlugin::PDFPlugin):
Make a WKPDFPluginAccessibilityObject and hook it up.
[FIXME: this could use some de-crapifying]

(WebKit::PDFPlugin::convertFromPluginToPDFView):
Transform a point from plugin space to PDFLayerController space.

(WebKit::PDFPlugin::convertFromPDFViewToRootView):
(WebKit::PDFPlugin::convertFromPDFViewToScreen): Added.
(WebKit::PDFPlugin::boundsOnScreen):
Return the PDFPlugin's frame in screen coordinates.

(WebKit::PDFPlugin::accessibilityObject):
Return our accessibility wrapper.

* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
* WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::accessibilityObject):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::accessibilityObject):
* WebProcess/Plugins/PluginView.h:
Add accessibilityObject(), to acquire accessibility wrappers from plugins.

* WebProcess/WebPage/WebPage.h:
(WebPage): Add accessibilityObjectForMainFramePlugin();
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityRootObjectWrapper]):
If the main frame has a PluginDocument that has an accessibilityObject,
use that one instead of the WebPage's.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
Return the accessibilityObject from the main-frame PluginDocument, if
there is one.

* WebCore.exp.in: Export AffineTransform::mapRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Find-on-page should be able to convert the active match to selection...
commit-queue@webkit.org [Mon, 27 May 2013 19:27:06 +0000 (19:27 +0000)]
[BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
https://bugs.webkit.org/show_bug.cgi?id=116837

Patch by Andy Chen <andchen@blackberry.com> on 2013-05-27
Reviewed by Rob Buis.

PR 291903
Internally reviewed by Mike Fenton.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::findNextString):
* Api/WebPage.h:
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
* WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCheckbox UX update.
commit-queue@webkit.org [Mon, 27 May 2013 18:39:02 +0000 (18:39 +0000)]
Checkbox UX update.
https://bugs.webkit.org/show_bug.cgi?id=116838.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-27
Reviewed by Rob Buis.

BlackBerry PR 342302.
Internally Reviewed by Jeff Rogers.
Remove old background and change pressed checkmark image.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintCheckbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWhen the background is completely transparent we should be conservative and use the...
weinig@apple.com [Mon, 27 May 2013 18:25:21 +0000 (18:25 +0000)]
When the background is completely transparent we should be conservative and use the default scrollbar style, not the light one
https://bugs.webkit.org/show_bug.cgi?id=116836
<rdar://problem/13949905>

Reviewed by Simon Fraser.

* page/FrameView.cpp:
(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Don't use the light style when the background is completely transparent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse ICU_INCLUDE_DIRS in BlackBerry CMake files
paroga@webkit.org [Mon, 27 May 2013 18:09:51 +0000 (18:09 +0000)]
Use ICU_INCLUDE_DIRS in BlackBerry CMake files
https://bugs.webkit.org/show_bug.cgi?id=116210

Reviewed by Rob Buis.

Set and use the ICU_INCLUDE_DIRS variable to avoid
duplicated adding of the ICU include directory.

.:

* Source/cmake/OptionsBlackBerry.cmake:

Source/JavaScriptCore:

* PlatformBlackBerry.cmake:

Source/WebCore:

* PlatformBlackBerry.cmake:

Source/WebKit:

* PlatformBlackBerry.cmake:

Source/WTF:

* wtf/PlatformBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix subframe target added to new requests
efidler@rim.com [Mon, 27 May 2013 18:04:02 +0000 (18:04 +0000)]
[BlackBerry] Fix subframe target added to new requests
https://bugs.webkit.org/show_bug.cgi?id=116602

Reviewed by Rob Buis.

In some cases we might be adding TargetIsMainFrame to a subframe
request causing an isMainFrame assert.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Check we are actually loading the main frame before setting
ResourceRequest::TargetIsMainFrame target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][CoordinatedGraphics] Misuse of DrawingAreaProxy::setVisibleContentsRect() in...
marcelo.lira@openbossa.org [Mon, 27 May 2013 16:52:10 +0000 (16:52 +0000)]
[WK2][CoordinatedGraphics] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()
https://bugs.webkit.org/show_bug.cgi?id=116688

Reviewed by Noam Rosenthal.

Visible contents area passed to DrawingAreaProxy::setVisibleContentsRect()
must be calculated including the page scale factor and avoid crossing the
boundaries of the page contents size. In other words the DrawingArea
must know the actual dimensions of what it being drawn. If the
DrawingArea thinks the visible rectangle is bigger than it is, the
contents will be drawn pixelated and blurry.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::visibleContentsSize):
(WebKit):
* UIProcess/CoordinatedGraphics/WebView.h:
(WebKit::WebView::contentsSize):
(WebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] WebKitWebView child widgets are not rendered with recent GTK+
carlosgc@webkit.org [Mon, 27 May 2013 16:10:36 +0000 (16:10 +0000)]
[GTK] WebKitWebView child widgets are not rendered with recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=116794

Reviewed by Xan Lopez.

Since rev d22fd7223c75f4720ddb982c659efb0d8d7543c4 of GTK+ expose
events are not propagated to child GdkWindows anymore, and child
widgets are rendered via gtk_container_propagate_draw(). Since all
our children have its own GdkWindow (auth widget, inspector view
and windowed plugins) we don't propagate the draw signal making
them invisible with current GTK+.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw): Chain up to the parent draw(), so it's
propagated to the children. This shouldn't have any effect in
previous versions of GTK+ because gtk_container_propagate_draw()
returned early when the child widget had its own GdkWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTighten FontGlyphs::glyphDataAndPageForCharacter to take FontDescription
antti@apple.com [Mon, 27 May 2013 16:01:27 +0000 (16:01 +0000)]
Tighten FontGlyphs::glyphDataAndPageForCharacter to take FontDescription
https://bugs.webkit.org/show_bug.cgi?id=116823

Reviewed by Andreas Kling.

FontGlyphs does not need to know about Font anymore.

* platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
* platform/graphics/Font.h:
(WebCore::Font::isPlatformFont):
(WebCore::Font::glyphDataAndPageForCharacter):
(Font):
* platform/graphics/FontCache.h:
* platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
* platform/graphics/FontFallbackList.h:
(WebCore):
(WebCore::FontGlyphs::createForPlatformFont):

    Tweaked the name.

(WebCore::FontGlyphs::isForPlatformFont):

    Move knowledge about platform font to FontGlyphs as it is needed for resolving system fallback on Mac.

* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::systemFallbackForCharacters):

    More descriptive name and tighter interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Prevent unnecessary copy of LayoutRect objects
mihnea@adobe.com [Mon, 27 May 2013 15:52:00 +0000 (15:52 +0000)]
[CSSRegions] Prevent unnecessary copy of LayoutRect objects
https://bugs.webkit.org/show_bug.cgi?id=116828

Reviewed by Andreas Kling.

Use const references for parameter passing.
No functional change, no new tests.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
* rendering/RenderRegion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with...
commit-queue@webkit.org [Mon, 27 May 2013 15:51:15 +0000 (15:51 +0000)]
[BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=116724

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-27
Reviewed by Rob Buis.

Add another bool variable m_previousFrameDone to make sure we
don't start a new frame until the previous one has been done. Also
make sure we pass the animation start time to
serviceScriptedAnimations().

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_previousFrameDone and m_monotonicAnimationStartTime.
(BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
Return early if previous frame is not done. Otherwise set
m_previousFrameDone to false and save the animation start time.
(BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
serviceScriptedAnimations() passing the saved animation start time
and reset m_animationScheduled and m_previousFrameDone.
(BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
Call WebPagePrivate::serviceAnimations().
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Reveal HTTP error code for XHR even if there is no response body
leoyang@rim.com [Mon, 27 May 2013 15:45:13 +0000 (15:45 +0000)]
[BlackBerry] Reveal HTTP error code for XHR even if there is no response body
https://bugs.webkit.org/show_bug.cgi?id=116543

Reviewed by Rob Buis.
Reviewed internally by Joe Mason.

It's a regression introduced by r132556.
BlackBerry is doing friendly HTTP error handling: if there is no response body
for an HTTP error it will display an error message made by the port. But for a
XHR request, which usually does not result in displaying error messages to the
end user, HTTP error code should be revealed to let the JavaScript know what
the actual server error code is.

Covered by existing tests:
ManualTests/blackberry/head-xhr-nonexistant-file.html
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::shouldNotifyClientFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150759 268f45cc-cd09-0410-ab3c-d52691b4dbfc