WebKit-https.git
9 years ago2010-11-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 18 Nov 2010 06:32:43 +0000 (06:32 +0000)]
2010-11-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi
        https://bugs.webkit.org/show_bug.cgi?id=49400

        Move WebKit API build rules out of GNUmakefile.am. These are now in
        WebKit/gtk/GNUmakefile.am.

        * GNUmakefile.am: Remove WebKit API build rules.
2010-11-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi
        https://bugs.webkit.org/show_bug.cgi?id=49400

        Add GNUmakefile.am and include all WebKit API build rules. Make webkitenum.*
        depend on this new file, instead of the generated GNUmakefile.am.

        * GNUmakefile.am: Copied from GNUmakefile.am.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some test_expectations for failing tests
levin@chromium.org [Thu, 18 Nov 2010 05:22:54 +0000 (05:22 +0000)]
Add some test_expectations for failing tests
that need to be investigated and dealt with.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r72228.
levin@chromium.org [Thu, 18 Nov 2010 04:54:12 +0000 (04:54 +0000)]
Unreviewed, rolling out r72228.
http://trac.webkit.org/changeset/72228
https://bugs.webkit.org/show_bug.cgi?id=49712

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-17
Caused many >10 regressions on Win and Linux gpu layout test
runs. (Requested by dave_levin on #webkit).

WebCore:

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::texImage2DBase):

WebKit/chromium:

* src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::bytesPerComponent):
(WebKit::componentsPerPixel):
(WebKit::imageSizeInBytes):
(WebKit::WebGraphicsContext3DDefaultImpl::texImage2D):

LayoutTests:

* fast/canvas/webgl/uninitialized-test-expected.txt: Removed.
* fast/canvas/webgl/uninitialized-test.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some test_expectations for failing tests
levin@chromium.org [Thu, 18 Nov 2010 04:33:24 +0000 (04:33 +0000)]
Add some test_expectations for failing tests
that need to be investigated and dealt with.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r72243.
levin@chromium.org [Thu, 18 Nov 2010 04:01:57 +0000 (04:01 +0000)]
Unreviewed, rolling out r72243.
http://trac.webkit.org/changeset/72243
https://bugs.webkit.org/show_bug.cgi?id=49710

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-17
Seemed to cause a large set of Chromium layout test to start
failing. (Requested by dave_levin on #webkit).

* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Acid3 in Safari for Windows
aroben@apple.com [Thu, 18 Nov 2010 02:33:37 +0000 (02:33 +0000)]
Fix Acid3 in Safari for Windows

Reviewed by Dave Hyatt.

* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont): Initialize all our metrics to 0
if we have a font size of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't trigger Windows builds when chromium-win test results change
aroben@apple.com [Thu, 18 Nov 2010 02:30:15 +0000 (02:30 +0000)]
Don't trigger Windows builds when chromium-win test results change

Reviewed by Mark Rowe.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Changed the regular expression used to
search for directory names to only consider full directory names,
rather than matching directory names where the string we care about is
a suffix of the name.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 18 Nov 2010 02:19:32 +0000 (02:19 +0000)]
2010-11-17  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for fast/tokenizer, fast/transforms, fast/wml, fast/xsl, fonts, scrollbars, svg, transforms, and transitions for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Thu, 18 Nov 2010 02:02:37 +0000 (02:02 +0000)]
2010-11-17  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Remove a uri member from TestInput class.

        https://bugs.webkit.org/show_bug.cgi?id=49691

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate chromium results after r72125 and r72173.
levin@chromium.org [Thu, 18 Nov 2010 01:41:59 +0000 (01:41 +0000)]
Update chromium results after r72125 and r72173.

* platform/chromium-linux/fast/css/negative-leading-expected.checksum: Added.
* platform/chromium-linux/fast/css/negative-leading-expected.png: Added.
* platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
* platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
* platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
* platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counter-03-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counter-04-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counter-09-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counter-09-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counters-03-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum:
* platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png:
* platform/chromium-mac/editing/deleting/5144139-2-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/5144139-2-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.checksum: Added.
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
* platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
* platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
* platform/chromium-mac/fast/css/font-face-opentype-expected.checksum: Added.
* platform/chromium-mac/fast/css/font-face-opentype-expected.png: Added.
* platform/chromium-mac/fast/css/negative-leading-expected.checksum: Added.
* platform/chromium-mac/fast/css/negative-leading-expected.png: Added.
* platform/chromium-mac/fast/css/rtl-ordering-expected.checksum: Added.
* platform/chromium-mac/fast/css/rtl-ordering-expected.png: Added.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
* platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
* platform/chromium-mac/fast/css/text-security-expected.checksum: Added.
* platform/chromium-mac/fast/css/text-security-expected.png: Added.
* platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum: Added.
* platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png: Added.
* platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.checksum: Added.
* platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.png:
* platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum: Added.
* platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.checksum: Added.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.png: Added.
* platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
* platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
* platform/chromium-mac/fast/text/cg-fallback-bolding-expected.checksum: Added.
* platform/chromium-mac/fast/text/cg-fallback-bolding-expected.png: Added.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Added.
* platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.checksum: Added.
* platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-innertext-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-innertext-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-override-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-override-expected.png: Added.
* platform/chromium-mac/fast/text/international/danda-space-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/danda-space-expected.png: Added.
* platform/chromium-mac/fast/text/international/hindi-spacing-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/hindi-spacing-expected.png: Added.
* platform/chromium-mac/fast/text/international/hindi-whitespace-expected.checksum:
* platform/chromium-mac/fast/text/international/hindi-whitespace-expected.png:
* platform/chromium-mac/fast/text/international/plane2-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/plane2-expected.png: Added.
* platform/chromium-mac/fast/text/international/rtl-caret-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/rtl-caret-expected.png: Added.
* platform/chromium-mac/fast/text/international/thai-baht-space-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/thai-baht-space-expected.png: Added.
* platform/chromium-mac/fast/text/international/thai-baht-space-expected.txt: Added.
* platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.png: Added.
* platform/chromium-win/fast/compact/001-expected.txt:
* platform/chromium-win/fast/css/negative-leading-expected.checksum: Added.
* platform/chromium-win/fast/css/negative-leading-expected.png: Added.
* platform/chromium-win/fast/css/negative-leading-expected.txt: Added.
* platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
* platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove FindSafari's settings into a vsprops file
aroben@apple.com [Thu, 18 Nov 2010 01:30:05 +0000 (01:30 +0000)]
Move FindSafari's settings into a vsprops file

Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file

Reviewed by Steve Falkenburg.

* FindSafari/FindSafari.vcproj:
* FindSafari/FindSafariCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a minimum font size of 0 in DRT on Windows
aroben@apple.com [Thu, 18 Nov 2010 01:16:30 +0000 (01:16 +0000)]
Use a minimum font size of 0 in DRT on Windows

This is the Windows equivalent of r72164.

Rubber-stamped by Dave Hyatt.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 18 Nov 2010 01:10:23 +0000 (01:10 +0000)]
2010-11-17  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Andreas Kling.

        webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
        https://bugs.webkit.org/show_bug.cgi?id=49639

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 18 Nov 2010 00:42:24 +0000 (00:42 +0000)]
2010-11-17  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: add loupe for image diffs
        https://bugs.webkit.org/show_bug.cgi?id=49692

        Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
        enlarged area of the expected, actual and diff images side by side.

        * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 18 Nov 2010 00:24:41 +0000 (00:24 +0000)]
2010-11-17  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        WebKitLauncherWin should use vsprops for shared build settings
        https://bugs.webkit.org/show_bug.cgi?id=49696

        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix. Touch precompiled header to force rebuild.
sfalken@apple.com [Thu, 18 Nov 2010 00:21:26 +0000 (00:21 +0000)]
Unreviewed build fix. Touch precompiled header to force rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConverge means of querying a parent node into one way, which is Node::parentNode.
dglazkov@chromium.org [Thu, 18 Nov 2010 00:20:10 +0000 (00:20 +0000)]
Converge means of querying a parent node into one way, which is Node::parentNode.
https://bugs.webkit.org/show_bug.cgi?id=49686

Reviewed by Darin Adler.

WebCore:

No change in behavior, so no new tests.

* accessibility/AccessibilityObject.cpp:
(WebCore::renderListItemContainerForNode): Changed to use parentNode.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mouseButtonListener): Ditto.
(WebCore::siblingWithAriaRole): Ditto.
(WebCore::AccessibilityRenderObject::getDocumentLinks): Ditto.
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): Ditto.
* accessibility/mac/AccessibilityObjectWrapper.mm: Ditto.
(blockquoteLevel): Ditto.
* bindings/v8/V8GCController.cpp:
(WebCore::ObjectGrouperVisitor::visitDOMWrapper): Ditto.
* dom/ContainerNode.cpp: Ditto.
(WebCore::ContainerNode::insertBefore): Ditto.
(WebCore::ContainerNode::insertBeforeCommon): Ditto.
(WebCore::ContainerNode::replaceChild): Ditto.
(WebCore::ContainerNode::removeChild): Ditto.
(WebCore::ContainerNode::appendChild): Ditto.
(WebCore::ContainerNode::parserAddChild): Ditto.
* dom/DocumentType.cpp:
(WebCore::DocumentType::insertedIntoDocument): Ditto.
* dom/Element.cpp:
(WebCore::Element::computeInheritedLanguage): Ditto.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::receivedTarget): Ditto.
* dom/Position.cpp:
(WebCore::Position::isCandidate): Changed to use parentNode.
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate): Ditto.
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
* editing/ApplyStyleCommand.cpp:
(WebCore::dummySpanAncestorForNode): Ditto.
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::highestEmbeddingAncestor): Ditto.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::splitTreeToNode): Ditto.
* editing/DeleteSelectionCommand.cpp:
(WebCore::updatePositionForNodeRemoval): Ditto.
* editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection): Ditto.
* editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Ditto.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes): Ditto.
* editing/visible_units.cpp:
(WebCore::previousLinePosition): Ditto.
(WebCore::nextLinePosition): Ditto.
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement): Ditto.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterHTML): Ditto.
(WebCore::HTMLElement::insertAdjacent): Ditto.
(WebCore::HTMLElement::supportsFocus): Ditto.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
(WebCore::HTMLEmbedElement::attributeChanged): Ditto.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::insertRow): Ditto.
* html/HTMLTableRowsCollection.cpp: Ditto.
(WebCore::isInHead): Ditto.
(WebCore::isInBody): Ditto.
(WebCore::isInFoot): Ditto.
(WebCore::HTMLTableRowsCollection::rowAfter): Ditto.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addRange): Ditto.
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired): Ditto.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach): Ditto.
(WebCore::HTMLConstructionSite::findFosterSite): Ditto.
* html/parser/HTMLTreeBuilder.cpp:
* page/FocusController.cpp:
(WebCore::FocusController::findFocusableNodeInDirection): Ditto.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlElement::rendererIsNeeded): Ditto.
(WebCore::MediaControlElement::attach): Ditto.
(WebCore::MediaControlElement::updateStyle): Ditto.
(WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
(WebCore::MediaControlInputElement::attach): Ditto.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
* rendering/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::gradientElement): Ditto.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::createRenderer): Ditto.
(WebCore::SVGAElement::childShouldCreateRenderer): Ditto.
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged): Ditto.
(WebCore::SVGFELightElement::childrenChanged): Ditto.
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto.
* svg/SVGLength.cpp:
(WebCore::SVGLength::determineViewport): Ditto.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::updateRelativeLengthsInformation): Ditto.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::removeDisallowedElementsFromSubtree): Ditto.
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
* xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::sort): Ditto.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Ditto.
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xsltStylesheetPointer): Ditto.

WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::insertStyleText): Changed to use parentNode.
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): Ditto.

WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::prependOutside): Changed to use parentNode.
(QWebElement::appendOutside): Ditto.
(QWebElement::encloseContentsWith): Ditto.
(QWebElement::encloseWith): Ditto.

WebKit2:

* WebProcess/WebPage/WebPage.cpp: Changed to use parentNode.
(WebKit::WebPage::findZoomableAreaForPoint): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 18 Nov 2010 00:08:24 +0000 (00:08 +0000)]
2010-11-17  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        WinLauncher should use vsprops for shared build settings
        https://bugs.webkit.org/show_bug.cgi?id=49695

        * WinLauncher/WinLauncher.cpp:
        (_tWinMain):
        (PrintView):
        (WndProc):
        (MyEditProc):
        * WinLauncher/WinLauncher.vcproj:
        * WinLauncher/WinLauncherCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCreate Leopard-specific results for tests that differ between Leopard
aestes@apple.com [Thu, 18 Nov 2010 00:06:05 +0000 (00:06 +0000)]
Create Leopard-specific results for tests that differ between Leopard
and Snow Leopard due to r72173.

* platform/mac-leopard/platform/mac/editing: Added.
* platform/mac-leopard/platform/mac/editing/input: Added.
* platform/mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
* platform/mac-leopard/platform/mac/svg: Added.
* platform/mac-leopard/platform/mac/svg/batik: Added.
* platform/mac-leopard/platform/mac/svg/batik/text: Added.
* platform/mac-leopard/platform/mac/svg/batik/text/smallFonts-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Leopard-specific results for r72173.
aestes@apple.com [Wed, 17 Nov 2010 23:58:30 +0000 (23:58 +0000)]
Add Leopard-specific results for r72173.

* platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac-leopard/fast/text/complex-text-opacity-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 17 Nov 2010 23:57:31 +0000 (23:57 +0000)]
2010-11-17  Tony Chang  <tony@chromium.org>

        Unreviewed, add chromium-win baselines for fast/text/atsui-negative-spacing-features.html.

        * platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
        * platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png: Added.
        * platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 17 Nov 2010 23:41:36 +0000 (23:41 +0000)]
2010-11-17  Tony Chang  <tony@chromium.org>

        Unreviewed, skip atsui-negative-spacing-features.html on qt and
        gtk since the other atsui tests are skipped.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 23:37:04 +0000 (23:37 +0000)]
2010-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        ScrollView: Don't translate by scrollX/scrollY or clip when paintsEntireContents()

        This makes paint() with paintEntireContents() do exactly what it's supposed to:
        paint from 0,0 to contentsSize().

        The clipping was a no-op anyway since visibleContentRect() will return the whole
        rect in paintsEntireContents() mode.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Kenneth Rohde Christansen <kenneth@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 23:19:00 +0000 (23:19 +0000)]
2010-11-17  Kenneth Rohde Christansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        ScrollView: Update the actualVisibleContentRect after delegating a scroll.

        This lets us avoid updating the actualVisibleContentRect from the client
        after each scroll. We had to do this synchronously for WebKit2 to support
        programmatic "animated scrolling" from JS.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelete unused file unintentionally added in last change.
sfalken@apple.com [Wed, 17 Nov 2010 23:18:53 +0000 (23:18 +0000)]
Delete unused file unintentionally added in last change.

* DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDumpRenderTree on Windows should use a vsprops file for shared project settings
sfalken@apple.com [Wed, 17 Nov 2010 23:16:26 +0000 (23:16 +0000)]
DumpRenderTree on Windows should use a vsprops file for shared project settings
https://bugs.webkit.org/show_bug.cgi?id=49690

Reviewed by Adam Roben.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
* DumpRenderTree/win/ImageDiff.vcproj:
* DumpRenderTree/win/ImageDiffCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Wed, 17 Nov 2010 23:02:39 +0000 (23:02 +0000)]
2010-11-17  Hayato Ito  <hayato@chromium.org>

        Refactor TestTypeBase.compare_output().

        Introduce a TestOutput class and update compare_output() of each test
        types so that they can take both actual and expected TestOutput objects.

        https://bugs.webkit.org/show_bug.cgi?id=49431

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 22:57:43 +0000 (22:57 +0000)]
2010-11-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        ScrollView: Decouple actualVisibleContentRect from visibleContentRect

        Added actualVisibleContentRect() which will return the override provided
        by setActualVisibleContentRect() or fall back to visibleContentRect()
        if no override has been set.

        This is similar to what the iPhone does.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::visibleContentRect):
        * platform/ScrollView.h:
        (WebCore::ScrollView::actualVisibleContentRect):
        (WebCore::ScrollView::setActualVisibleContentRect): IntRect -> const IntRect&

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate Web Inspector message handeling in WebPage::didReceiveMessage.
timothy@apple.com [Wed, 17 Nov 2010 22:46:48 +0000 (22:46 +0000)]
Remove duplicate Web Inspector message handeling in WebPage::didReceiveMessage.

https://webkit.org/b/49689

Reviewed by Andreas Kling.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage): Remove duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a crash when closing the inspected page when the Web Inspector
timothy@apple.com [Wed, 17 Nov 2010 22:46:34 +0000 (22:46 +0000)]
Fix a crash when closing the inspected page when the Web Inspector
page was never created.

https://bugs.webkit.org/show_bug.cgi?id=49687

Reviewed by John Sullivan.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::sendMessageToFrontend): Null check the Inspector WebPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake each Windows Test builder use the same OS for all its slaves
aroben@apple.com [Wed, 17 Nov 2010 22:37:15 +0000 (22:37 +0000)]
Make each Windows Test builder use the same OS for all its slaves

Currently each WebKit1 Windows Test builder has one Windows XP slave
and one Windows 7 slave. Having different OSes in a single builder
meant that the builders would alternate between red and green when
there were OS-specific failures.

Fixes <http://webkit.org/b/49688> Windows Test builders alternate
between red and green because of multiple OS versions

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
"Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
(WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
builders for the two WebKit1 builders so that they would all use the
appropriate OS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 17 Nov 2010 22:33:55 +0000 (22:33 +0000)]
2010-11-17  Tony Chang  <tony@chromium.org>

        Unreviewed, adding windows baseline for
        fast/text/atsui-negative-spacing-features.html

        * platform/win/fast/text/atsui-negative-spacing-features-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 17 Nov 2010 22:16:26 +0000 (22:16 +0000)]
2010-11-17  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
        https://bugs.webkit.org/show_bug.cgi?id=49036

        No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html

        In http://codereview.chromium.org/11574, the forked chromium test
        plugin changed how it testGetIntIdentifier to work around a change
        caused by a silverlight specific plugin fix:
        http://codereview.chromium.org/11569/diff/1/2

        It's not clear to me that this change is needed anymore since
        silverlight has had multiple releases, testing without this patch
        works on a test windows build, and safari win seems to run silverlight
        without this either.  Since there's no test for this behavior, I'm
        rolling it out so we can match the upstream test.

        * bindings/v8/V8NPUtils.cpp:
        (WebCore::convertV8ObjectToNPVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 22:02:28 +0000 (22:02 +0000)]
2010-11-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        ScrollView: Let visibleContentRect() return the contentsSize() if paintsEntireContents()

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::visibleContentRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't crash when invalidating a page overlay that hasn't been installed yet
andersca@apple.com [Wed, 17 Nov 2010 21:57:32 +0000 (21:57 +0000)]
Don't crash when invalidating a page overlay that hasn't been installed yet
https://bugs.webkit.org/show_bug.cgi?id=49685

Reviewed by John Sullivan.

Null check the web page.

* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 17 Nov 2010 21:36:36 +0000 (21:36 +0000)]
2010-11-17  Tony Chang  <tony@chromium.org>

        Unreviewed, css variable support was removed in r72116.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 James Simonsen <simonjam@chromium.org>
tony@chromium.org [Wed, 17 Nov 2010 21:29:33 +0000 (21:29 +0000)]
2010-11-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Fix negative letter spacing in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=49563

        * fast/text/atsui-negative-spacing-features.html: Added.
        * platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
        * platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png: Added.
        * platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.txt: Added.
        * platform/mac/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
        * platform/mac/fast/text/atsui-negative-spacing-features-expected.png: Added.
        * platform/mac/fast/text/atsui-negative-spacing-features-expected.txt: Added.
2010-11-17  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Fix negative letter spacing in complex text on linux
        https://bugs.webkit.org/show_bug.cgi?id=49563

        Test: fast/text/atsui-negative-spacing-features.html

        * platform/graphics/chromium/FontLinux.cpp: Make spacing signed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 21:16:11 +0000 (21:16 +0000)]
2010-11-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        ScrollView: Avoid unnecessary work in setScrollPosition() when scrolling is delegated.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setScrollPosition): If delegatesScrolling(), we never use the
        newScrollPosition, so move that calculation below the delegation path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49682 - Expose "removeItemAtIndex" in WKMutab...
beidson@apple.com [Wed, 17 Nov 2010 21:02:35 +0000 (21:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49682 - Expose "removeItemAtIndex" in WKMutableArray

Reviewed by Darin Adler.

* Shared/API/c/WKMutableArray.cpp:
(WKArrayRemoveItemAtIndex):
* Shared/API/c/WKMutableArray.h:

* Shared/MutableArray.cpp:
(WebKit::MutableArray::removeItemAtIndex):
* Shared/MutableArray.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49683 - Export WKContextMenuItem and WKContex...
beidson@apple.com [Wed, 17 Nov 2010 21:01:59 +0000 (21:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49683 - Export WKContextMenuItem and WKContextMenuItemTypes as public headers

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=48537
hyatt@apple.com [Wed, 17 Nov 2010 20:55:40 +0000 (20:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48537

Reviewed by Sam Weinig.

WebCore:

Fonts with no vertical metrics should synthesize baselines when they appear
on lines that do use fonts with vertical metrics.  Basically we want to make
sure that English text behaves like vertical-align:middle, i.e., its baseline
should be treated as though it cuts through the middle of the ascent+descent.

The way this works is that each line in the line box tree is labeled as having
a baseline type that is either ideographic or alphabetic for the purposes of
vertical alignment.  A line becomes ideographic if any font with vertical tables
is either explicitly specified as the primary font or in any of the used fonts
in the text on that line.

This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
and passed to the ascent and descent methods of the fonts that are examined.
The underlying Font code selects an appropriate baseline given the type passed in.

This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
to instead carry around the cached vertical positions for RenderInlines in a new
VerticalPositionCache object.  This cache only lives for a single layout
operation, but it does cache information across all the lines built and placed during the
layout.

This matches the old behavior, since every call to layoutInlineChildren invalidated
all of the vertical positions in all of the RenderInlines anyway.

The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
positions for both alphabetic and ideographic baseline types.

The vertical-align computation has now been moved out of RenderBoxModelObject and
RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
This function has been changed to no longer be recursive when checking parents,
and it now relies on the fact that the parent vertical alignment computation result
has already been stored in the logicalTop() of that parent's line box.  By checking
the line box logicalTop() value instead of recurring, the performance of first lines
now significantly improves to no longer have O(n^2) behavior in the depth of the line
box tree on the first line.

All of the baselinePosition functions on the various RenderObjects have been amended
to take a FontBaseline as the first argument.  This patch does not attempt to fix up
MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.

The RenderTableCell baselinePosition virtual method has been made non-virtual and had
all arguments removed, since it actually had no real connection with the rest of the
baseline positioning system.  Cell baseline positioning works by calling firstLineBoxBaseline,
and that method has been patched to use the cached baselineType for the first line box
when computing the baseline of that line.

Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html.

* WebCore.xcodeproj/project.pbxproj:
* mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
* mathml/RenderMathMLFraction.h:
* mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::baselinePosition):
* mathml/RenderMathMLOperator.h:
* mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::baselinePosition):
* mathml/RenderMathMLRow.h:
* mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::baselinePosition):
* mathml/RenderMathMLSubSup.h:
* mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):
* mathml/RenderMathMLUnderOver.h:
* platform/graphics/SimpleFontData.h:
* rendering/InlineBox.h:
(WebCore::InlineBox::baselinePosition):
* rendering/InlineFlowBox.cpp:
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::baselinePosition):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::baselinePosition):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
* rendering/RenderBoxModelObject.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::baselinePosition):
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition):
* rendering/RenderListBox.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::baselinePosition):
* rendering/RenderListMarker.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition):
* rendering/RenderSlider.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition):
* rendering/RenderTableCell.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition):
* rendering/RenderTextControlMultiLine.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
* rendering/VerticalPositionCache.h: Added.
(WebCore::VerticalPositionCache::VerticalPositionCache):
(WebCore::VerticalPositionCache::get):
(WebCore::VerticalPositionCache::set):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateBoundaries):

LayoutTests:

Fonts with no vertical metrics should synthesize baselines when they appear
on lines that do use fonts with vertical metrics.  Basically we want to make
sure that English text behaves like vertical-align:middle, i.e., its baseline
should be treated as though it cuts through the middle of the ascent+descent.

The way this works is that each line in the line box tree is labeled as having
a baseline type that is either ideographic or alphabetic for the purposes of
vertical alignment.  A line becomes ideographic if any font with vertical tables
is either explicitly specified as the primary font or in any of the used fonts
in the text on that line.

This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
and passed to the ascent and descent methods of the fonts that are examined.
The underlying Font code selects an appropriate baseline given the type passed in.

This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
to instead carry around the cached vertical positions for RenderInlines in a new
VerticalPositionCache object.  This cache only lives for a single layout
operation, but it does cache information across all the lines built and placed during the
layout.

This matches the old behavior, since every call to layoutInlineChildren invalidated
all of the vertical positions in all of the RenderInlines anyway.

The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
positions for both alphabetic and ideographic baseline types.

The vertical-align computation has now been moved out of RenderBoxModelObject and
RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
This function has been changed to no longer be recursive when checking parents,
and it now relies on the fact that the parent vertical alignment computation result
has already been stored in the logicalTop() of that parent's line box.  By checking
the line box logicalTop() value instead of recurring, the performance of first lines
now significantly improves to no longer have O(n^2) behavior in the depth of the line
box tree on the first line.

All of the baselinePosition functions on the various RenderObjects have been amended
to take a FontBaseline as the first argument.  This patch does not attempt to fix up
MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.

The RenderTableCell baselinePosition virtual method has been made non-virtual and had
all arguments removed, since it actually had no real connection with the rest of the
baseline positioning system.  Cell baseline positioning works by calling firstLineBoxBaseline,
and that method has been patched to use the cached baselineType for the first line box
when computing the baseline of that line.

Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html

* fast/blockflow/vertical-align-table-baseline.html: Added.
* fast/blockflow/vertical-baseline-alignment.html: Added.
* platform/mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/mac/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
* platform/mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/mac/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
* platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed way to invalidate part of a WKOverlayRef so it will be redrawn
andersca@apple.com [Wed, 17 Nov 2010 20:52:33 +0000 (20:52 +0000)]
Need way to invalidate part of a WKOverlayRef so it will be redrawn
https://bugs.webkit.org/show_bug.cgi?id=49679
<rdar://problem/8679152>

Reviewed by Darin Adler.

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlaySetNeedsDisplay):
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
* WebProcess/WebPage/PageOverlay.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 17 Nov 2010 20:48:34 +0000 (20:48 +0000)]
2010-11-17  James Robinson  <jamesr@chromium.org>

        Reviewed by Dan Bernstein.

        [chromium] Set minimum font size to 0 for DRT
        https://bugs.webkit.org/show_bug.cgi?id=49677

        Followup for http://trac.webkit.org/changeset/72141.

        Test: http/tests/misc/acid3.html

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd stubbed out ScrollAnimator for the Mac
weinig@apple.com [Wed, 17 Nov 2010 20:47:45 +0000 (20:47 +0000)]
Add stubbed out ScrollAnimator for the Mac
https://bugs.webkit.org/show_bug.cgi?id=49678

Reviewed by Anders Carlsson.

JavaScriptCore:

* wtf/Platform.h: Enable SMOOTH_SCROLLING on the Mac, this has no
change in behavior at the moment.

WebCore:

* WebCore.xcodeproj/project.pbxproj:
Add ScrollAnimator.h/cpp.

* platform/mac/ScrollAnimatorMac.cpp: Added.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
* platform/mac/ScrollAnimatorMac.h: Added.
ScrollAnimatorMac just calls through to the base class for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 17 Nov 2010 20:31:22 +0000 (20:31 +0000)]
2010-11-17  Martin Robinson  <mrobinson@igalia.com>

        Update the skipped list to skip a newly failing geolocation test (requires
        geolocation mock support). Organize geolocation test failures a bit better.
        Add results for two new tests.

        * platform/gtk/Skipped: Update skipped list.
        * platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
        * platform/gtk/fast/css/negative-leading-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Cris Neckar <cdn@chromium.org>
inferno@chromium.org [Wed, 17 Nov 2010 20:11:56 +0000 (20:11 +0000)]
2010-11-17  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Modified codepath for object fallback content which has failed to load.
        Refactored CachedResource error handling to use more granular statuses instead of a boolean value.
        https://bugs.webkit.org/show_bug.cgi?id=46921

        Test: fast/html/object-image-nested-fallback.html

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::renderFallbackContent):
        * loader/cache/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::error):
        * loader/cache/CachedCSSStyleSheet.h:
        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::error):
        * loader/cache/CachedFont.h:
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::error):
        * loader/cache/CachedImage.h:
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::canUseCacheValidator):
        (WebCore::CachedResource::mustRevalidate):
        * loader/cache/CachedResource.h:
        (WebCore::CachedResource::error):
        (WebCore::CachedResource::httpStatusCodeError):
        (WebCore::CachedResource::errorOccurred):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::error):
        * loader/cache/CachedScript.h:
        * loader/cache/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::error):
        * loader/cache/CachedXSLStyleSheet.h:
        * loader/loader.cpp:
        (WebCore::Loader::load):
        (WebCore::Loader::didFinishLoading):
        (WebCore::Loader::didFail):
        (WebCore::Loader::didReceiveData):
2010-11-17  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Added test for multiple image objects which use the same invalid data attribute.
        https://bugs.webkit.org/show_bug.cgi?id=46921

        * fast/html/object-image-nested-fallback-expected.txt: Added.
        * fast/html/object-image-nested-fallback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProvide a way to create a WKView (WebPage) that is hidden from
timothy@apple.com [Wed, 17 Nov 2010 20:07:00 +0000 (20:07 +0000)]
Provide a way to create a WKView (WebPage) that is hidden from
the InjectedBundle. This is needed for the Web Inspector.

https://webkit.org/b/49670

Reviewed by Sam Weinig.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode): Added visibleToInjectedBundle.
(WebKit::WebPageCreationParameters::decode): Ditto.
* Shared/WebPageCreationParameters.h: Ditto.
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate): Pass VisibleToInjectedBundle to the WebView create function.
* UIProcess/API/C/win/WKViewPrivate.cpp:
(WKViewCreateForWebInspector): Added. Not used yet. Passes HiddenFromInjectedBundle
to the WebView create function.
* UIProcess/API/C/win/WKViewPrivate.h: Added WKViewCreateForWebInspector.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:]): Added hiddenFromInjectedBundle
parameter and calls WebPageProxy::setVisibleToInjectedBundle.
(-[WKView initWithFrame:pageNamespaceRef:]): Calls initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:
and passes NO for hiddenFromInjectedBundle.
(-[WKView initWithFrame:]): Cleaned up by removing the local assignment to self and just returns the result.
* UIProcess/API/mac/WKViewInternal.h: Added initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_visibleToInjectedBundle from the creation parameters.
(WebKit::WebPageProxy::creationParameters): Set visibleToInjectedBundle using m_visibleToInjectedBundle.
* UIProcess/WebPageProxy.h: Added m_visibleToInjectedBundle.
(WebKit::WebPageProxy::visibleToInjectedBundle): Added. Return m_visibleToInjectedBundle.
(WebKit::WebPageProxy::setVisibleToInjectedBundle): Added. Set m_visibleToInjectedBundle.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Added InjectedBundleVisibility parameter and calls
WebPageProxy::setVisibleToInjectedBundle.
* UIProcess/win/WebView.h: Added InjectedBundleVisibility enum.
(WebKit::WebView::create): Added InjectedBundleVisibility parameter.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create): Checks visibleToInjectedBundle before talking to the injected bundle.
(WebKit::WebPage::WebPage): Initialize m_isVisibleToInjectedBundle from the creation parameters.
(WebKit::WebPage::close): Checks m_isVisibleToInjectedBundle before talking to the injected bundle.
* WebProcess/WebPage/WebPage.h: Added m_isVisibleToInjectedBundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 17 Nov 2010 19:55:11 +0000 (19:55 +0000)]
2010-11-16  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        * src/WebGraphicsContext3DDefaultImpl.cpp: Don't deal with texture initialization at this level.
2010-11-16  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        Test: fast/canvas/webgl/uninitialized-test.html

        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed.
        (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
        * html/canvas/WebGLFramebuffer.h: Modify onAccess function signature.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter.
        (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::drawArrays): Ditto.
        (WebCore::WebGLRenderingContext::drawElements): Ditto.
        (WebCore::WebGLRenderingContext::readPixels): Ditto.
        (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
2010-11-16  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        * fast/canvas/webgl/uninitialized-test-expected.txt: Added.
        * fast/canvas/webgl/uninitialized-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Commit Queue <commit-queue@webkit.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 19:46:20 +0000 (19:46 +0000)]
2010-11-17  Commit Queue  <commit-queue@webkit.org>

        Unreviewed.  Test commit for commit-queue@webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 17 Nov 2010 19:27:36 +0000 (19:27 +0000)]
2010-11-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        Fix a typo that leads to emitting the wrong signal if it is done
        by using the signals array.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix. Don't put object files into the source tree.
sfalken@apple.com [Wed, 17 Nov 2010 19:27:06 +0000 (19:27 +0000)]
Unreviewed build fix. Don't put object files into the source tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix.
abecsi@webkit.org [Wed, 17 Nov 2010 19:24:28 +0000 (19:24 +0000)]
Unreviewed buildfix.

[Qt] D'oh! I screwed up the dependencies.

* DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
abecsi@webkit.org [Wed, 17 Nov 2010 19:15:53 +0000 (19:15 +0000)]
Unreviewed build fix.

[Qt] Add missing resource file I forgot in r72220.

* MiniBrowser/MiniBrowser.qrc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 17 Nov 2010 18:56:45 +0000 (18:56 +0000)]
2010-11-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Merge ScriptElement and ScriptElementData
        https://bugs.webkit.org/show_bug.cgi?id=49647

        Merged two classes.

        * dom/AsyncScriptRunner.cpp:
        (WebCore::AsyncScriptRunner::executeScriptSoon): Takes ScriptElement* instead of ScriptElementData*.
        (WebCore::AsyncScriptRunner::timerFired): Uses ScriptElement* instead of ScriptElementData*.
        * dom/AsyncScriptRunner.h:
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::ScriptElement): Merged with ScriptElementData::ScriptElementData.
        (WebCore::ScriptElement::~ScriptElement): Merged with ScriptElementData::~ScriptElementData.
        (WebCore::ScriptElement::insertedIntoDocument): Calls createdByParser, isAsynchronous, requestScript, and scriptContent.
        (WebCore::ScriptElement::removedFromDocument): Calls stopLoadRequest.
        (WebCore::ScriptElement::childrenChanged): Calls createdByParser and accesses m_element.
        (WebCore::ScriptElement::finishParsingChildren): Calls scriptContent.
        (WebCore::ScriptElement::handleSourceAttribute): Calls ignoresLoadRequest and requestScript.
        (WebCore::ScriptElement::requestScript): Moved from ScriptElementData; calls dispatchErrorEvent.
        (WebCore::ScriptElement::evaluateScript): Moved from ScriptElementData.
        (WebCore::ScriptElement::executeScript): Ditto.
        (WebCore::ScriptElement::stopLoadRequest): Ditto.
        (WebCore::ScriptElement::execute): Moved from ScriptElementData; calls dispatchErrorEvent and dispatchLoadEvent.
        (WebCore::ScriptElement::notifyFinished): Moved from ScriptElementData.
        (WebCore::ScriptElement::ignoresLoadRequest): Ditto.
        (WebCore::ScriptElement::shouldExecuteAsJavaScript): Moved from ScriptElementData; calls typeAttributeValue, languageAttributeValue,
        forAttributeValue, and eventAttributeValue.
        (WebCore::ScriptElement::scriptCharset): Moved from ScriptElementData.
        (WebCore::ScriptElement::scriptContent): Ditto.
        (WebCore::ScriptElement::isAsynchronous): Moved from ScriptElementData; calls sourceAttributeValue and asyncAttributeValue.
        (WebCore::ScriptElement::isDeferred): Moved from ScriptElementData; calls sourceAttributeValue, asyncAttributeValue,
        and deferAttributeValue.
        * dom/ScriptElement.h:
        (WebCore::ScriptElement::element):
        (WebCore::ScriptElement::haveFiredLoadEvent):
        (WebCore::ScriptElement::setHaveFiredLoadEvent):
        (WebCore::ScriptElement::createdByParser):
        (WebCore::ScriptElement::isEvaluated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 18:43:01 +0000 (18:43 +0000)]
2010-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        [WK2] Set paintsEntireContents for "resizes to contents" mode

        Only relevant for the tiled backing store.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setResizesToContentsUsingLayoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 17 Nov 2010 18:40:11 +0000 (18:40 +0000)]
2010-11-17  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
        https://bugs.webkit.org/show_bug.cgi?id=49627

        Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.

        * MiniBrowser/MiniBrowser.qrc: Added.
        Add it here to prevent qmake from detecting it
        since it needs to be copied to the build directory.
        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::updateUserAgentList):
        (BrowserWindow::showUserAgentDialog):
        * MiniBrowser/qt/BrowserWindow.h:
        * MiniBrowser/qt/MiniBrowser.pro:
2010-11-17  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=49627

        Copy the MiniBrowser.qrc and QtTestBrowser's useragentlist.txt file
        to the build directory of MiniBrowser because it has to be in a
        subdirectory of the resource file.
        Add a method to QWKPage to retrieve the custom user agent string.

        * DerivedSources.pro:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::customUserAgent):
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKitSystemInterfaceWin.
sfalken@apple.com [Wed, 17 Nov 2010 18:31:16 +0000 (18:31 +0000)]
Update WebKitSystemInterfaceWin.

Rubber-stamped by Adam Roben.

* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake changes to the Mac WebKit2 Skipped file trigger Windows builds
aroben@apple.com [Wed, 17 Nov 2010 18:13:50 +0000 (18:13 +0000)]
Make changes to the Mac WebKit2 Skipped file trigger Windows builds

We use that file on Windows!

Fixes <http://webkit.org/b/49643> Changes to
LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't

Reviewed by Steve Falkenburg.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added the mac-wk2 directory and make it
trigger builds on SnowLeopard and Windows.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build): Added a test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results after r72125 and r72173
aroben@apple.com [Wed, 17 Nov 2010 18:03:03 +0000 (18:03 +0000)]
Update Windows results after r72125 and r72173

* platform/win/css2.1/t1202-counter-04-b-expected.txt:
* platform/win/css2.1/t1202-counters-04-b-expected.txt:
* platform/win/fast/blockflow/border-vertical-lr-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:
* platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/win/fast/text/international/hebrew-vowels-expected.txt:
* platform/win/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Tenghui Zhu <ztenghui@google.com>
commit-queue@webkit.org [Wed, 17 Nov 2010 17:56:33 +0000 (17:56 +0000)]
2010-11-17  Tenghui Zhu  <ztenghui@google.com>

        Reviewed by Jeremy Orlow.

        profileCallback and profileEndCallback  should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
        https://bugs.webkit.org/show_bug.cgi?id=49623

        No new tests. Just a compiling error fix.

        * bindings/v8/custom/V8ConsoleCustom.cpp:
          Add the guard ENABLE_JAVA_SCRIPT_DEBUGGER to profileCallback and profileEndCallback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKit2 skipped list.
weinig@apple.com [Wed, 17 Nov 2010 17:45:47 +0000 (17:45 +0000)]
Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Satish Sampath <satish@chromium.org>
mihaip@chromium.org [Wed, 17 Nov 2010 17:39:39 +0000 (17:39 +0000)]
2010-11-17  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Clear the speech input mock explicitly before each test.
        https://bugs.webkit.org/show_bug.cgi?id=49660

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::speechInputController):
        (WebViewHost::reset): Invoke speech input mock's clearResults method.
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 17:28:34 +0000 (17:28 +0000)]
2010-11-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Introduce GeoNotifierVector typedef for increased readability
        https://bugs.webkit.org/show_bug.cgi?id=49597

        * page/Geolocation.cpp:
        (WebCore::Geolocation::Watchers::getNotifiersVector):
        (WebCore::Geolocation::sendError):
        (WebCore::Geolocation::sendPosition):
        (WebCore::Geolocation::stopTimer):
        (WebCore::Geolocation::stopTimersForOneShots):
        (WebCore::Geolocation::stopTimersForWatchers):
        (WebCore::Geolocation::cancelRequests):
        (WebCore::Geolocation::cancelAllRequests):
        (WebCore::Geolocation::handleError):
        (WebCore::Geolocation::makeSuccessCallbacks):
        * page/Geolocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 17 Nov 2010 17:25:01 +0000 (17:25 +0000)]
2010-11-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=45567
        Add stubbed-out layer-backed drawing area for Windows.

        Add implementations of LayerBackedDrawingArea and
        LayerBackedDrawingAreaProxy for Windows, and add them
        to the vcproj.

        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        * UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Added.
        (WebKit::LayerBackedDrawingAreaProxy::page):
        (WebKit::LayerBackedDrawingAreaProxy::platformSetSize):
        (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
        (WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
        (WebKit::LayerBackedDrawingAreaProxy::paint):
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::pageDidEnterAcceleratedCompositing):
        (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
        (WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
        * UIProcess/win/WebView.h:
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Added.
        (WebKit::LayerBackedDrawingArea::platformInit):
        (WebKit::LayerBackedDrawingArea::platformClear):
        (WebKit::LayerBackedDrawingArea::attachCompositingContext):
        (WebKit::LayerBackedDrawingArea::detachCompositingContext):
        (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
        (WebKit::LayerBackedDrawingArea::scheduleCompositingLayerSync):
        (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
        * win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 17:08:31 +0000 (17:08 +0000)]
2010-11-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Add a layout test to check that Geoposition timestamps are
        well-formed. See https://bugs.webkit.org/show_bug.cgi?id=48518

        * fast/dom/Geolocation/script-tests/timestamp.js: Added.
        (checkPosition):
        * fast/dom/Geolocation/timestamp-expected.txt: Added.
        * fast/dom/Geolocation/timestamp.html: Added.
2010-11-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Convert correctly between GeolocationPosition and Geoposition
        timestamp formats.
        https://bugs.webkit.org/show_bug.cgi?id=48518

        Test: fast/dom/Geolocation/timestamp.html

        * page/Geolocation.cpp:
        (WebCore::createGeoposition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Wed, 17 Nov 2010 16:48:16 +0000 (16:48 +0000)]
2010-11-17  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        [Mac] Unskip the test that is passing now.

        Test: fast/events/spatial-navigation/snav-single-select.html

        * platform/mac/Skipped:
2010-11-17  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        [Mac] Suppress single select popup menu when spatial navigation is enabled on Mac.
        This makes spatial navigation work properly for single select box.

        Test: fast/events/spatial-navigation/snav-single-select.html

        * dom/SelectElement.cpp:
        (WebCore::nextValidIndex):
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/49634> Make overflow guards in WTF::String::utf8 explicit
ddkilzer@apple.com [Wed, 17 Nov 2010 16:36:04 +0000 (16:36 +0000)]
<webkit.org/b/49634> Make overflow guards in WTF::String::utf8 explicit

Reviewed by Darin Adler.

Add an explicit overflow check prior to allocating our buffer,
rather than implicitly relying on the guard in convertUTF16ToUTF8.

* wtf/text/WTFString.cpp:
(WTF::String::utf8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, rebaselining fast/js/regexp-overflow.html
antonm@chromium.org [Wed, 17 Nov 2010 16:13:49 +0000 (16:13 +0000)]
Not reviewed, rebaselining fast/js/regexp-overflow.html

https://bugs.webkit.org/show_bug.cgi?id=49665

* platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
* platform/chromium-win/fast/js/regexp-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 17 Nov 2010 15:52:43 +0000 (15:52 +0000)]
2010-11-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72197.
        http://trac.webkit.org/changeset/72197
        https://bugs.webkit.org/show_bug.cgi?id=49661

        broke fast/regex/test1.html (Requested by stampho on #webkit).

        * runtime/JSGlobalData.h:
        * runtime/RegExp.cpp:
        (JSC::RegExpRepresentation::~RegExpRepresentation):
        (JSC::RegExp::compile):
        (JSC::RegExp::match):
        * tests/mozilla/expected.html:
        * wtf/Platform.h:
        * yarr/RegexCompiler.cpp:
        * yarr/RegexCompiler.h:
        * yarr/RegexInterpreter.cpp:
        * yarr/RegexInterpreter.h:
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::jitCompileRegex):
        * yarr/RegexJIT.h:
        (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
        (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
        (JSC::Yarr::RegexCodeBlock::getFallback):
        (JSC::Yarr::RegexCodeBlock::setFallback):
        (JSC::Yarr::executeRegex):
        * yarr/RegexParser.h:
        * yarr/RegexPattern.h:
2010-11-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72197.
        http://trac.webkit.org/changeset/72197
        https://bugs.webkit.org/show_bug.cgi?id=49661

        broke fast/regex/test1.html (Requested by stampho on #webkit).

        * fast/js/regexp-look-ahead-empty-expected.txt:
        * fast/js/regexp-overflow-expected.txt:
        * fast/js/script-tests/regexp-overflow.js:
        * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
        * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
        * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Satish Sampath <satish@chromium.org>
satish@chromium.org [Wed, 17 Nov 2010 15:17:06 +0000 (15:17 +0000)]
2010-11-17  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Clear the speech input mock explicitly before each test.
        https://bugs.webkit.org/show_bug.cgi?id=49660

        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::clearResults): Added clearResults method.
        * platform/mock/SpeechInputClientMock.h:
2010-11-17  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Clear the speech input mock explicitly before each test.
        https://bugs.webkit.org/show_bug.cgi?id=49660

        * public/WebSpeechInputControllerMock.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::clearResults): Added method to clear results.
        * src/WebSpeechInputControllerMockImpl.h:
2010-11-17  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Clear the speech input mock explicitly before each test.
        https://bugs.webkit.org/show_bug.cgi?id=49660

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::speechInputController):
        (WebViewHost::reset): Invoke speech input mock's clearResults method.
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 17 Nov 2010 14:49:29 +0000 (14:49 +0000)]
2010-11-17  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, fix Chromium-Mac build from r72189.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::getDoubleValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 17 Nov 2010 14:06:54 +0000 (14:06 +0000)]
2010-11-17  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: IDBKey::whereSyntax should impose conditions on all columns
        https://bugs.webkit.org/show_bug.cgi?id=49601

        The WHERE clause should specifiy a condition for each key column to
        make sure that the ObjectStoreData_composit index can be used when
        querying the object store based on key. Not using the index causes
        severe performance degradation for common IDB operations.

        * storage/IDBKey.cpp:
        (WebCore::IDBKey::whereSyntax):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 17 Nov 2010 14:04:20 +0000 (14:04 +0000)]
2010-11-17  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, specify IRC nickname in committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView
benjamin.poulain@nokia.com [Wed, 17 Nov 2010 13:50:16 +0000 (13:50 +0000)]
[Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView
https://bugs.webkit.org/show_bug.cgi?id=49545

Reviewed by Kenneth Rohde Christiansen.

Implement focus switching with Tab. This is now done asynchronously,
waiting for webkit to call takeFocus() and switching the widget.

Since the focus can change between the Tab press and the callback,
QGraphicsWKView::focusNextPrevChildCallback() make sure the view still has
focus before passing it to the next widget.

* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::focusNextPrevChildCallback):
(QGraphicsWKView::focusNextPrevChild):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::takeFocus):
* UIProcess/API/qt/qwkpage.h:
* UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, disabling fast/css/getFloatValueForUnit.html.
antonm@chromium.org [Wed, 17 Nov 2010 13:32:01 +0000 (13:32 +0000)]
Not reviewed, disabling fast/css/getFloatValueForUnit.html.

https://bugs.webkit.org/show_bug.cgi?id=49656

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Eric Uhrhane <ericu@chromium.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 13:30:20 +0000 (13:30 +0000)]
2010-11-17  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        [Chromium] implementation of async FileWriter for workers
        https://bugs.webkit.org/show_bug.cgi?id=47681

        Tests are in a separate changelist.

        * platform/CrossThreadCopier.h: Changed CrossThreadCopier[Base] to support PassRefPtrs
2010-11-17  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        [Chromium] implementation of async FileWriter for workers
        https://bugs.webkit.org/show_bug.cgi?id=47681

        Tests are in a separate changelist.

        Added new files.
        * WebKit.gyp:

        * src/WorkerAsyncFileSystemChromium.cpp: Added WorkerAsyncFileWriterChromium construction.
        * src/WorkerAsyncFileWriterChromium.cpp: Added.
        * src/WorkerAsyncFileWriterChromium.h: Added.

        This class bridges between the context and main threads for the WorkerAsyncFileWriterChromium.
        * src/WorkerFileWriterCallbacksBridge.cpp: Added.
        * src/WorkerFileWriterCallbacksBridge.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 17 Nov 2010 13:26:34 +0000 (13:26 +0000)]
2010-11-17  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Commenting out failing Qt inspector tests. Need to fix harness.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, now disabling for real fast/css/line-height-determined-by-primary-font...
antonm@chromium.org [Wed, 17 Nov 2010 13:24:42 +0000 (13:24 +0000)]
Not reviewed, now disabling for real fast/css/line-height-determined-by-primary-font.html.

https://bugs.webkit.org/show_bug.cgi?id=49653

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYARR JIT should fallback to YARR Interpreter instead of PCRE.
ossy@webkit.org [Wed, 17 Nov 2010 13:15:56 +0000 (13:15 +0000)]
YARR JIT should fallback to YARR Interpreter instead of PCRE.
https://bugs.webkit.org/show_bug.cgi?id=46719

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
Reviewed by Gavin Barraclough.

Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.

JavaScriptCore:

* runtime/JSGlobalData.h:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::match):
* tests/mozilla/expected.html:
* wtf/Platform.h:
* yarr/RegexCompiler.cpp:
* yarr/RegexCompiler.h:
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::byteCompileRegex):
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):
* yarr/RegexParser.h:
* yarr/RegexPattern.h:

LayoutTests:

* fast/js/regexp-look-ahead-empty-expected.txt:
* fast/js/regexp-overflow-expected.txt:
* fast/js/script-tests/regexp-overflow.js:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 John Mellor <johnme@chromium.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 13:09:59 +0000 (13:09 +0000)]
2010-11-17  John Mellor  <johnme@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Expose frame flattening setting in WebSettings.
        https://bugs.webkit.org/show_bug.cgi?id=49621

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setFrameFlatteningEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 17 Nov 2010 13:03:43 +0000 (13:03 +0000)]
2010-11-17  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, remove stale Chromium test expectations to fix build.

        * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] Make http locking similar to perl implementation
ossy@webkit.org [Wed, 17 Nov 2010 12:54:14 +0000 (12:54 +0000)]
[NRWT] Make http locking similar to perl implementation
https://bugs.webkit.org/show_bug.cgi?id=49187

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-17
Reviewed by Tony Chang.

* Scripts/webkitpy/common/system/file_lock.py: Added.
* Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
* Scripts/webkitpy/layout_tests/port/http_lock.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 17 Nov 2010 12:37:49 +0000 (12:37 +0000)]
2010-11-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Don't prohibit scrolling in tiled backing store mode.

        We delegate scrolling instead.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Jonathan Backer <backer@chromium.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 12:19:52 +0000 (12:19 +0000)]
2010-11-17  Jonathan Backer  <backer@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Resize initiated by renderer.
        https://bugs.webkit.org/show_bug.cgi?id=49617

        To address synchronization issues with resizing, make resize work like DARWIN.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 17 Nov 2010 12:06:28 +0000 (12:06 +0000)]
2010-11-17  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] r69119 modified just the gtk2 version of the
        scrolled_window_paint function but not the gtk3 version
        https://bugs.webkit.org/show_bug.cgi?id=49585

        Use gtk_paint_shadow the same as the actual code from GTK+. Avoid
        using state and use the same values we are using for gtk2 in the
        paint function.

        * platform/gtk/ScrollbarThemeGtk.cpp:
        (WebCore::ScrollbarThemeGtk::paintButton): Initialized the
        depressed attribute of the state variable to avoid using it
        without initialization.
        * platform/gtk/gtk3drawing.c:
        (moz_gtk_scrolled_window_paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 17 Nov 2010 11:41:24 +0000 (11:41 +0000)]
2010-11-17  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, GTK expectations update after r72116 and r72141.

        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
        * platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
        * platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 17 Nov 2010 11:39:59 +0000 (11:39 +0000)]
2010-11-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Simon Fraser.

        CSSPrimitiveValue.getFloatValue does not convert sizes
        https://bugs.webkit.org/show_bug.cgi?id=35770

        Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
        which allowed to get rid of a number of unnecessary baselines.

        * fast/css/CSSPrimitiveValue-exceptions-expected.txt:
        * fast/css/getFloatValueForUnit-expected.txt: Added.
        * fast/css/getFloatValueForUnit.html:
        * fast/css/resources/CSSPrimitiveValue-exceptions.js:
        * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
        * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
        * platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.
2010-11-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Simon Fraser.

        CSSPrimitiveValue.getFloatValue does not convert sizes
        https://bugs.webkit.org/show_bug.cgi?id=35770

        Implemented all same-category unit conversions (length, angle, time, frequency) and retained
        absolute-relative (cm, mm, in, pt, pc) length conversions intact.
        Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::unitCategory):
        (WebCore::conversionToCanonicalUnitsScaleFactor):
        (WebCore::CSSPrimitiveValue::getDoubleValue):
        (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
        (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
        (WebCore::CSSPrimitiveValue::getIdent):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::getFloatValue):
        (WebCore::CSSPrimitiveValue::getIntValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 11:29:42 +0000 (11:29 +0000)]
2010-11-17  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        Document::nodesFromRect() has wrong source code documentation
        https://bugs.webkit.org/show_bug.cgi?id=49610

        * dom/Document.h: fix nodesFromRect() documentation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, disabling three layout tests for Chromium.
antonm@chromium.org [Wed, 17 Nov 2010 11:21:16 +0000 (11:21 +0000)]
Not reviewed, disabling three layout tests for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=49653

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExtend YARR Interpreter with beginning character look-up optimization
ossy@webkit.org [Wed, 17 Nov 2010 11:03:40 +0000 (11:03 +0000)]
Extend YARR Interpreter with beginning character look-up optimization
https://bugs.webkit.org/show_bug.cgi?id=45751

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
Reviewed by Gavin Barraclough.

Add beginning character look-up optimization which sets the start
index to the first possible successful pattern match.
Extend YARR Interpreter with lookupForBeginChars function which
implements the beginning character look-up optimization.

* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readPair):
(JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
(JSC::Yarr::Interpreter::lookupForBeginChars):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
* yarr/RegexInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Improve painting performance on 16-bit displays
hausmann@webkit.org [Wed, 17 Nov 2010 11:01:52 +0000 (11:01 +0000)]
[Qt] Improve painting performance on 16-bit displays

Reviewed by Kenneth Christiansen.

When the default pixmap depth is 16-bit, then use RGB16 instead of
RGB32 for the chunks, to avoid unnecessary conversions and reduce
chunk size. The conversions happen as images as QPixmaps have 16-bit
depth and the tiles on the ui process are also backed by QPixmaps.

* Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::size):
(WebKit::UpdateChunk::createImage):
* Shared/qt/UpdateChunk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add support for use GStreamer with the Qt build
hausmann@webkit.org [Wed, 17 Nov 2010 10:54:59 +0000 (10:54 +0000)]
[Qt] Add support for use GStreamer with the Qt build

Reviewed by Kenneth Christiansen, Tor Arne Vestbø.

JavaScriptCore:

Enable the build/inclusion of the wtf/QObject convenience classes.

* JavaScriptCore.pri:
* wtf/wtf.pri:

WebCore:

Make it possible to use gstreamer with the Qt build via the USE_GSTREAMER macro. The
integration is rather basic at this point, allowing for software based rendering
only at the moment. AC integration and fullscreen playback is still missing.

* WebCore.pro: Added a bunch of gstreamer files to the build and guard it as a
build option with the USE_GSTREAMER macro.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Don't use the generic media player registration
when using GStreamer. These #ifdefs should be removed, but the gstreamer folks want
to be able to build with gstreamer _and_ another backend simultaenously.
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerQt.cpp: Added.
(ImageGStreamer::createImage):
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Added.
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: Added.
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(PlatformVideoWindow::PlatformVideoWindow):
(PlatformVideoWindow::~PlatformVideoWindow):
(PlatformVideoWindow::prepareForOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 17 Nov 2010 10:49:32 +0000 (10:49 +0000)]
2010-11-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium][DRT] EventSender.contextClick() should aware spellchecking
        https://bugs.webkit.org/show_bug.cgi?id=49366

        - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
          according to the spellchecker suggestion
        - MockSpellCheck: add fillSuggestionList to provide fake suggestions.

        test_expectations.txt will be changed after this change is ported to test_shell.

        * DumpRenderTree/chromium/EventSender.cpp:
        (makeMenuItemStringsFor):
        (EventSender::contextClick):
        * DumpRenderTree/chromium/MockSpellCheck.cpp:
        (MockSpellCheck::fillSuggestionList):
        (MockSpellCheck::initializeIfNeeded):
        * DumpRenderTree/chromium/MockSpellCheck.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::mockSpellCheck):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 17 Nov 2010 10:48:08 +0000 (10:48 +0000)]
2010-11-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
        https://bugs.webkit.org/show_bug.cgi?id=49602

        * inspector/styles-new-API-expected.txt:
        * inspector/styles-new-API.html:
2010-11-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
        https://bugs.webkit.org/show_bug.cgi?id=49602

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::setPropertyText):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.get name):
        (WebInspector.StylePropertyTreeElement.prototype.get priority):
        (WebInspector.StylePropertyTreeElement.prototype.get value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Stuart Morgan <stuartmorgan@chromium.org>
commit-queue@webkit.org [Wed, 17 Nov 2010 10:02:17 +0000 (10:02 +0000)]
2010-11-17  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix click count for mouse-up events.
        - clickCount for mouse up was lost in conversion from NSEvent
        - clickCount was also lost when disptaching events through the
        plugin mouse capture event codepath.

        https://bugs.webkit.org/show_bug.cgi?id=49290

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleInputEvent):
        * src/mac/WebInputEventFactory.mm:
        (WebKit::WebInputEventFactory::mouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Peter Varga <pvarga@inf.u-szeged.hu>
commit-queue@webkit.org [Wed, 17 Nov 2010 09:42:41 +0000 (09:42 +0000)]
2010-11-17  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Collect the beginning characters in a RegExp pattern for look-up
        optimization
        https://bugs.webkit.org/show_bug.cgi?id=45748

        Extend the YARR's parser with an algorithm which collects the potential
        beginning characters from a RegExp pattern for later look-up optimization.

        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::BeginCharHelper::BeginCharHelper):
        (JSC::Yarr::BeginCharHelper::addBeginChar):
        (JSC::Yarr::BeginCharHelper::merge):
        (JSC::Yarr::BeginCharHelper::addCharacter):
        (JSC::Yarr::BeginCharHelper::linkHotTerms):
        (JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor):
        (JSC::Yarr::RegexPatternConstructor::addBeginTerm):
        (JSC::Yarr::RegexPatternConstructor::setupDisjunctionBeginTerms):
        (JSC::Yarr::RegexPatternConstructor::setupAlternativeBeginTerms):
        (JSC::Yarr::RegexPatternConstructor::setupBeginChars):
        (JSC::Yarr::compileRegex):
        * yarr/RegexPattern.h:
        (JSC::Yarr::TermChain::TermChain):
        (JSC::Yarr::BeginChar::BeginChar):
        (JSC::Yarr::RegexPattern::RegexPattern):
        (JSC::Yarr::RegexPattern::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTwo more tests needing new results after r72173.
aestes@apple.com [Wed, 17 Nov 2010 09:24:35 +0000 (09:24 +0000)]
Two more tests needing new results after r72173.

* platform/mac/editing/selection/caret-rtl-expected.txt:
* platform/mac/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore results needing new results after r72173.
aestes@apple.com [Wed, 17 Nov 2010 08:45:12 +0000 (08:45 +0000)]
More results needing new results after r72173.

* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe following results needed new results after r72173.
aestes@apple.com [Wed, 17 Nov 2010 08:37:00 +0000 (08:37 +0000)]
The following results needed new results after r72173.

* editing/selection/extend-selection-bidi-expected.txt:
* platform/mac/editing/deleting/5144139-2-expected.checksum:
* platform/mac/editing/deleting/5144139-2-expected.png:
* platform/mac/editing/deleting/5144139-2-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-expected.checksum:
* platform/mac/editing/selection/caret-rtl-2-expected.png:
* platform/mac/editing/selection/caret-rtl-2-expected.txt:
* platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
* platform/mac/editing/selection/extend-selection-bidi-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 17 Nov 2010 08:05:39 +0000 (08:05 +0000)]
2010-11-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72160.
        http://trac.webkit.org/changeset/72160
        https://bugs.webkit.org/show_bug.cgi?id=49646

        Broke lots of fast/profiler tests, among others (Requested by
        aroben on #webkit).

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::functionRegisterForBytecodeOffset):
        (JSC::CodeBlock::shrinkToFit):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addFunctionRegisterInfo):
        * bytecode/Opcode.h:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::emitCall):
        (JSC::BytecodeGenerator::emitCallVarargs):
        (JSC::BytecodeGenerator::emitReturn):
        (JSC::BytecodeGenerator::emitConstruct):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::CallArguments::profileHookRegister):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::CallArguments::CallArguments):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::unwindCallFrame):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct):
        (JSC::Interpreter::privateExecute):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_profile_will_call):
        (JSC::JIT::emit_op_profile_did_call):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_profile_will_call):
        (JSC::JIT::emit_op_profile_did_call):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        * profiler/Profile.cpp:
        (JSC::Profile::Profile):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::addParentForConsoleStart):
        (JSC::ProfileGenerator::willExecute):
        (JSC::ProfileGenerator::didExecute):
        (JSC::ProfileGenerator::stopProfiling):
        * profiler/ProfileGenerator.h:
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::ProfileNode):
        (JSC::ProfileNode::willExecute):
        * profiler/ProfileNode.h:
        (JSC::ProfileNode::create):
        (JSC::ProfileNode::operator==):
        * profiler/Profiler.cpp:
        (JSC::dispatchFunctionToProfiles):
        (JSC::Profiler::willExecute):
        (JSC::Profiler::didExecute):
        * profiler/Profiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72176 268f45cc-cd09-0410-ab3c-d52691b4dbfc