WebKit-https.git
9 years ago2011-06-13 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 13 Jun 2011 22:50:53 +0000 (22:50 +0000)]
2011-06-13  Chris Rogers  <crogers@google.com>

        Reviewed by Dirk Pranke.

        Add Web Audio support to chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=62306

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        (LayoutTestController::setEncodedAudioData):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::encodedAudioData):
        (LayoutTestController::shouldDumpAsAudio):
        (LayoutTestController::setShouldDumpAsAudio):
        * DumpRenderTree/chromium/TestEventPrinter.cpp:
        (DRTPrinter::handleAudioHeader):
        (TestShellPrinter::handleAudioHeader):
        * DumpRenderTree/chromium/TestEventPrinter.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Michal Pakula vel Rutka <m.pakula@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:47:37 +0000 (22:47 +0000)]
2011-06-13  Michal Pakula vel Rutka  <m.pakula@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Input method hints not updated while clicking non-input field editable area
        https://bugs.webkit.org/show_bug.cgi?id=62539

        This fixes a minor bug when input method hints are not updated while focus is
        changed from editable area with input tags to other which are does not have input
        tag i.e. textarea.

        * ewk/ewk_view.cpp:
        (ewk_view_input_method_state_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 13 Jun 2011 22:46:21 +0000 (22:46 +0000)]
2011-06-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Fix llocp and lvalp names in the lexer to something more meaningful
        https://bugs.webkit.org/show_bug.cgi?id=62605

        A simple rename

        * parser/Lexer.cpp:
        (JSC::Lexer::parseIdentifier):
        (JSC::Lexer::parseString):
        (JSC::Lexer::lex):
        * parser/Lexer.h:
        (JSC::Lexer::lexExpectIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:45:23 +0000 (22:45 +0000)]
2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Supports to execute "redo" command.
        https://bugs.webkit.org/show_bug.cgi?id=62536

        Implements basic functions for "redo" command.

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::registerCommandForUndo):
        (WebCore::EditorClientEfl::registerCommandForRedo):
        (WebCore::EditorClientEfl::clearUndoRedoOperations):
        (WebCore::EditorClientEfl::canRedo):
        (WebCore::EditorClientEfl::redo):
        * WebCoreSupport/EditorClientEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:44:59 +0000 (22:44 +0000)]
2011-06-13  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL][WK2] Add dummy files at below of WebProcess.
        https://bugs.webkit.org/show_bug.cgi?id=62445

        Add Efl related directory and files in WebKit2/WebProcess/.

        * WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added.
        (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
        (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
        * WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
        (WebKit::InjectedBundle::load):
        (WebKit::InjectedBundle::activateMacFontAscentHack):
        * WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added.
        (WebKit::WebInspector::localizedStringsURL):
        * WebProcess/WebPage/efl/WebPageEfl.cpp: Added.
        (WebKit::WebPage::platformInitialize):
        (WebKit::WebPage::platformPreferencesDidChange):
        (WebKit::scroll):
        (WebKit::WebPage::performDefaultBehaviorForKeyEvent):
        (WebKit::WebPage::platformHasLocalDataForURL):
        (WebKit::WebPage::cachedResponseMIMETypeForURL):
        (WebKit::WebPage::platformCanHandleRequest):
        (WebKit::WebPage::cachedSuggestedFilenameForURL):
        (WebKit::WebPage::cachedResponseDataForURL):
        * WebProcess/efl/WebProcessEfl.cpp: Added.
        (WebKit::WebProcess::platformSetCacheModel):
        (WebKit::WebProcess::platformClearResourceCaches):
        (WebKit::WebProcess::platformInitializeWebProcess):
        (WebKit::WebProcess::platformTerminate):
        * WebProcess/efl/WebProcessMainEfl.cpp: Added.
        (WebKit::WebProcessMainEfl):
        * WebProcess/efl/WebProcessMainEfl.h: Added.
        * efl/MainEfl.cpp: Added.
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jun 2011 22:39:32 +0000 (22:39 +0000)]
2011-06-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r88704.
        http://trac.webkit.org/changeset/88704
        https://bugs.webkit.org/show_bug.cgi?id=62466

        Caused layout test failures on Chromium Mac.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::declareAndWriteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Mon, 13 Jun 2011 22:39:28 +0000 (22:39 +0000)]
2011-06-13  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Need to report whether touch icon loading is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62532

        It needs to report whether touch icon loading is enabled.

        * configure.ac: Updated option parsing code for loading touch icons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 13 Jun 2011 22:38:22 +0000 (22:38 +0000)]
2011-06-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make it possible to inline the common case of identifier lexing
        https://bugs.webkit.org/show_bug.cgi?id=62600

        Add a lexing function that expects to lex an "normal" alpha numeric
        identifier (that ignores keywords) so it's possible to inline the
        common parsing cases.  This comes out as a reasonable parsing speed
        boost.

        * parser/JSParser.cpp:
        (JSC::JSParser::nextExpectIdentifier):
        (JSC::JSParser::parseProperty):
        (JSC::JSParser::parseMemberExpression):
        * parser/Lexer.cpp:
        * parser/Lexer.h:
        (JSC::Lexer::makeIdentifier):
        (JSC::Lexer::lexExpectIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrame::visiblePositionForPoint returns null position if the point is over an imagemap.
enrica@apple.com [Mon, 13 Jun 2011 22:38:03 +0000 (22:38 +0000)]
Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
https://bugs.webkit.org/show_bug.cgi?id=62562
<rdar://problem/9313885>

Patch by Morgan Winer <mwiner@apple.com> on 2011-06-13
Reviewed by Enrica Casucci.

The innerNode() of an imageMap is an area, and doesn't have a renderer and
therefore can't report a position.
Every result's innerNonSharedNode() should be the same as the innerNode(),
except for imageMaps, which will have the actual image as its innerNonSharedNode(),
and will therefore have a renderer and can report a position.

There are no layout tests for this, since it can be tested only at API level.

* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Wyatt Carss <wcarss@google.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:37:16 +0000 (22:37 +0000)]
2011-06-13  Wyatt Carss  <wcarss@google.com>

        Reviewed by Ryosuke Niwa.

        dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
        https://bugs.webkit.org/show_bug.cgi?id=58159

        Converted to dump the key part of page as text. The platform-dependent files are
        copied from the previous setup of this test, as mac appears to do something different
        in its delegate info -- 'insertText' instead of 'insertNode', and some differences
        in how it counts indices. Note that chromium-mac works the same as chromium-win, but
        would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
        a bit accordingly.

        * editing/pasteboard/paste-xml.xhtml:
        * platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
        * platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-xml-expected.txt:
        * platform/win/editing/pasteboard/paste-xml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:36:45 +0000 (22:36 +0000)]
2011-06-13  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        [CMAKE] Conditionally generate DerivedSources
        https://bugs.webkit.org/show_bug.cgi?id=62277

        Speedup build by not generating DerivedSources of features that are
        disabled. This was already been done for some features like ENABLE_SVG
        and now it's extended the following features: ENABLE_DATABASE,
        ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
        ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
        ENABLE_DATA_TRANSFER_ITEMS.

        * Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
2011-06-13  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        [CMAKE] Conditionally generate DerivedSources
        https://bugs.webkit.org/show_bug.cgi?id=62277

        Speedup build by not generating DerivedSources of features that are
        disabled. This was already been done for some features like ENABLE_SVG
        and now it's extended the following features: ENABLE_DATABASE,
        ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
        ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
        ENABLE_DATA_TRANSFER_ITEMS.

        No change in functionality so no new tests.

        * CMakeLists.txt: move .idl files to be conditionally generated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:32:47 +0000 (22:32 +0000)]
2011-06-13  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Eric Seidel.

        IndexedDB test: Infinity as key
        https://bugs.webkit.org/show_bug.cgi?id=62285

        * storage/indexeddb/key-type-infinity-expected.txt: Added.
        * storage/indexeddb/key-type-infinity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:30:02 +0000 (22:30 +0000)]
2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Add load error handler to EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=62347

        Add a handler function of "load,error" to EWebLauncher.
        EWebLauncher now displays a simple error page on load errors.

        * EWebLauncher/main.c:
        (on_load_error):
        (browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:29:50 +0000 (22:29 +0000)]
2011-06-13  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Eric Seidel.

        IndexedDB test: odd database names
        https://bugs.webkit.org/show_bug.cgi?id=62322

        * storage/indexeddb/database-odd-names-expected.txt: Added.
        * storage/indexeddb/database-odd-names.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:25:34 +0000 (22:25 +0000)]
2011-06-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
        https://bugs.webkit.org/show_bug.cgi?id=62385

        Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
        since the TestPlugin no longer prints this event.

        * platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.
2011-06-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
        https://bugs.webkit.org/show_bug.cgi?id=62385

        Remove duplicate TestNetscapePlugIn implementation. Having two copies
        of this code makes keeping it in sync much more difficult. The files are
        almost identical and this change ports the X11 changes to main.cpp.

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New): Do not set the plugin as windowless always. Doing this breaks
        some results on Qt and this seems to be unnecessary for the moment.
        (keyEventToChar): Added this helper which converts a X11 keycode into a char.
        (handleEventX11): Use the handler to properly convert the keycode. Do not print
        adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
        it should not be in the results.
        (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
        XP_UNIX block is first by guarding against using a null instance.
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
        the XP_UNIX define for Linux.
        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
        * GNUmakefile.am: Update source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Leandro Pereira <leandro@profusion.mobi>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:23:20 +0000 (22:23 +0000)]
2011-06-13  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Eric Seidel.

        [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
        without plugin support
        https://bugs.webkit.org/show_bug.cgi?id=62394

        No behaviour changes, so no new tests.

        * CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and
        Plugin{Package,View}None.cpp and move them to CMakeListWinCE and
        CMakeListsEfl, respectively.
        * CMakeListsEfl.txt:
        * CMakeListsWinCE.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:22:48 +0000 (22:22 +0000)]
2011-06-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
        https://bugs.webkit.org/show_bug.cgi?id=62365

        These functions do not exist in any public headers and
        they are not used internally.
        Moreover ewk_view has the same functionality added
        https://bugs.webkit.org/show_bug.cgi?id=60435

        * ewk/ewk_frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 13 Jun 2011 22:22:16 +0000 (22:22 +0000)]
2011-06-13  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Rewrite a bunch of XHR-based tests to use waitUntilDone()/notifyDone().
        https://bugs.webkit.org/show_bug.cgi?id=62066

        * fast/xmlhttprequest/xmlhttprequest-gc.html:
        * fast/xmlhttprequest/xmlhttprequest-get.xhtml:
        * fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html:
        * html5lib/runner.html:
        * html5lib/webkit-resumer.html:
        * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html:
        * http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html:
        * http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html:
        * http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html:
        * http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:
        * http/tests/xmlhttprequest/cross-origin-preflight-get.html:
        * http/tests/xmlhttprequest/event-listener-gc.html:
        * http/tests/xmlhttprequest/interactive-state.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html:
        * http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html:
        * http/tests/xmlhttprequest/response-encoding.html:
        * http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-004.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-005.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-006.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-007.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-008.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-009.html:
        * http/tests/xmlhttprequest/uri-resolution-opera-open-010.html:
        * http/tests/xmlhttprequest/web-apps/001.html:
        * http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html:
        * http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html:
        * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
        * http/tests/xmlhttprequest/zero-length-response.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:17:57 +0000 (22:17 +0000)]
2011-06-13  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Eric Seidel.

        IndexedDB test: readonly properties
        https://bugs.webkit.org/show_bug.cgi?id=62392

        * storage/indexeddb/readonly-expected.txt: Added.
        * storage/indexeddb/readonly.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:16:15 +0000 (22:16 +0000)]
2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Eric Seidel.

        [EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
        https://bugs.webkit.org/show_bug.cgi?id=62524

        * UIProcess/efl/WebInspectorEfl.cpp: Added.
        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
        (WebKit::WebInspectorProxy::platformOpen):
        (WebKit::WebInspectorProxy::platformDidClose):
        (WebKit::WebInspectorProxy::platformBringToFront):
        (WebKit::WebInspectorProxy::platformInspectedURLChanged):
        (WebKit::WebInspectorProxy::inspectorPageURL):
        (WebKit::WebInspectorProxy::platformAttach):
        (WebKit::WebInspectorProxy::platformDetach):
        (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:14:48 +0000 (22:14 +0000)]
2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Eric Seidel.

        [EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
        https://bugs.webkit.org/show_bug.cgi?id=62438

        * UIProcess/efl/TextCheckerEfl.cpp: Added.
        (WebKit::TextChecker::state):
        (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
        (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
        (WebKit::TextChecker::setGrammarCheckingEnabled):
        (WebKit::TextChecker::uniqueSpellDocumentTag):
        (WebKit::TextChecker::closeSpellDocumentWithTag):
        (WebKit::TextChecker::checkSpellingOfString):
        (WebKit::TextChecker::checkGrammarOfString):
        (WebKit::TextChecker::spellingUIIsShowing):
        (WebKit::TextChecker::toggleSpellingUIIsShowing):
        (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
        (WebKit::TextChecker::updateSpellingUIWithGrammarString):
        (WebKit::TextChecker::getGuessesForWord):
        (WebKit::TextChecker::learnWord):
        (WebKit::TextChecker::ignoreWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 13 Jun 2011 22:09:46 +0000 (22:09 +0000)]
2011-06-13  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Eric Seidel.

        Web Inspector: [refactoring] remove dead code from NetworkPanel
        https://bugs.webkit.org/show_bug.cgi?id=62481

        * inspector/front-end/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Mon, 13 Jun 2011 22:06:18 +0000 (22:06 +0000)]
2011-06-13  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Dragging images to Mail.app results in broken attachments
        https://bugs.webkit.org/show_bug.cgi?id=62466

        No new tests.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::declareAndWriteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 22:00:13 +0000 (22:00 +0000)]
2011-06-13  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Dimitri Glazkov.

        Add accessors for selectionStart and selectionEnd.
        https://bugs.webkit.org/show_bug.cgi?id=62596

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::selectionEnd):
        (WebKit::WebAccessibilityObject::selectionStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Sangyong Park <sy302.park@gmail.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 21:58:20 +0000 (21:58 +0000)]
2011-06-13  Sangyong Park  <sy302.park@gmail.com>

        Reviewed by Eric Seidel.

        implement to handle wheel event of plugin on x11
        https://bugs.webkit.org/show_bug.cgi?id=62522

        Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
        for to handle wheel event on plugins

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        (WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent
        (WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent
        (WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 21:51:43 +0000 (21:51 +0000)]
2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Eric Seidel.

        [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
        https://bugs.webkit.org/show_bug.cgi?id=62523

        * UIProcess/efl/WebContextEfl.cpp: Added.
        (WebKit::WebContext::applicationCacheDirectory):
        (WebKit::WebContext::platformInitializeWebProcess):
        (WebKit::WebContext::platformInvalidateContext):
        (WebKit::WebContext::platformDefaultDatabaseDirectory):
        (WebKit::WebContext::platformDefaultIconDatabasePath):
        (WebKit::WebContext::platformDefaultLocalStorageDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Raphael Kubo da Costa <kubo@profusion.mobi>
commit-queue@webkit.org [Mon, 13 Jun 2011 21:44:48 +0000 (21:44 +0000)]
2011-06-13  Raphael Kubo da Costa  <kubo@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [efl] Disable tiled backing store debug messages by default.
        https://bugs.webkit.org/show_bug.cgi?id=61745

        These messages pollute the output and are only useful to people
        working on TBS itself. It makes more sense to have them disabled by
        default.

        * ewk/ewk_tiled_backing_store.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 21:36:59 +0000 (21:36 +0000)]
2011-06-13  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert editing/execCommand/outdent-selection.html to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=62582

        Convert the test to dump as markup and clean up the HTML.

        * editing/execCommand/outdent-selection-expected.txt: Added.
        * editing/execCommand/outdent-selection.html:
        * platform/chromium-linux/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/chromium-mac/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/outdent-selection-expected.txt: Removed.
        * platform/gtk/editing/execCommand/outdent-selection-expected.txt: Removed.
        * platform/mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/mac/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/mac/editing/execCommand/outdent-selection-expected.txt: Removed.
        * platform/qt/editing/execCommand/outdent-selection-expected.png: Removed.
        * platform/qt/editing/execCommand/outdent-selection-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 13 Jun 2011 21:33:13 +0000 (21:33 +0000)]
2011-06-13  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Overlap test needs to consider children of composited layers
        https://bugs.webkit.org/show_bug.cgi?id=62465

        * compositing/layer-creation/overlap-child-layer-expected.png: Added.
        * compositing/layer-creation/overlap-child-layer-expected.txt: Added.
        * compositing/layer-creation/overlap-child-layer.html: Added.
2011-06-13  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Overlap test needs to consider children of composited layers
        https://bugs.webkit.org/show_bug.cgi?id=62465

        Any child layer with a compositing ancestor will be put into a
        composited layer even though they themselves don't need compositing.
        As layer bounds aren't hierarchical, these layer bounds themselves
        need to be put into the overlap map because the composited layer
        itself is not sufficient.

        Test: compositing/layer-creation/overlap-animated-layer.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jun 2011 21:29:25 +0000 (21:29 +0000)]
2011-06-13  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Correctly classify the test as failing.

        * platform/chromium/test_expectations.txt: It's failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 13 Jun 2011 21:23:29 +0000 (21:23 +0000)]
2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        Touch this to try to fix the build...

        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::~Widget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jun 2011 21:22:05 +0000 (21:22 +0000)]
2011-06-13  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Record more flakiness...

        * platform/chromium/test_expectations.txt: Added expectation of flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows Tests] EventSender.contextClick() needs to return a JS array of the context...
jberlin@webkit.org [Mon, 13 Jun 2011 21:20:00 +0000 (21:20 +0000)]
[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
items.
https://bugs.webkit.org/show_bug.cgi?id=62597

Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
it depends on getting a list of the context menu items.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 13 Jun 2011 21:14:49 +0000 (21:14 +0000)]
2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Try to fix GTK+ build.

        * GNUmakefile.list.am: remove CredentialStorage.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 13 Jun 2011 21:10:35 +0000 (21:10 +0000)]
2011-06-13  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        Improve GPU canvas startup time on the SkiaGPU path.
        https://bugs.webkit.org/show_bug.cgi?id=62594

        Fixed by skipping creation of shaders used only by the legacy path.

        Covered by existing canvas tests.

        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Mon, 13 Jun 2011 21:08:34 +0000 (21:08 +0000)]
2011-06-13  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Additional FontCache::FontCachePurgePreventer instances needed
        https://bugs.webkit.org/show_bug.cgi?id=62498

        Added some needed and speculative FontCachePurgePreventer objects.
        Built and ran Safari with debug version of webkit that purges all
        purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
        to find system fallback fonts access via code paths that aren't
        protected with FontCachePurgePreventer objects.  Also examined
        platform specific code that calls either Font::drawText() or
        Canvas::drawText().  For those methods that may be called from currently
        unprotected paths, added FontCachePurgePreventer objects.

        No new functionality so no new tests.

        * inspector/DOMNodeHighlighter.cpp:
        * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
        (PlatformCALayerWinInternal::displayCallback):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::drawHudContents):
        * platform/mac/DragImageMac.mm:
        (WebCore::widthWithFont):
        (WebCore::drawAtPoint):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateOptionsWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 13 Jun 2011 20:59:26 +0000 (20:59 +0000)]
2011-06-13  Ryosuke Niwa  <rniwa@webkit.org>

        Windows rebaseline after r62565. The failure is tracked by the bug 62565.

        * platform/win/fast/harness/results-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 13 Jun 2011 20:58:02 +0000 (20:58 +0000)]
2011-06-13  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Unreviewed fix - removed parts of r88659 that were committed by mistake.

        The patch accidentally included parts that weren't supposed to be there, namely the whole
        code was duplicated. This patch rectifies that and brings it to the original reviewed code.

        * WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
        * WebProcess/WebCoreSupport/WebGraphicsLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTest fix for Windows.
levin@chromium.org [Mon, 13 Jun 2011 20:56:20 +0000 (20:56 +0000)]
Test fix for Windows.

[Windows] Web Worker test causes script error on Windows platform alone.
https://bugs.webkit.org/show_bug.cgi?id=62595

* platform/win/Skipped: Skipped the test with the problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 13 Jun 2011 20:46:24 +0000 (20:46 +0000)]
2011-06-13  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dan Bernstein.

        REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
        https://bugs.webkit.org/show_bug.cgi?id=62544

        Fixed the crash by adding null pointer checks.

        No new tests since there's no way to open dictionary panel.

        * dom/Position.cpp:
        (WebCore::Position::parentAnchoredEquivalent):
        * editing/VisiblePosition.cpp:
        (WebCore::makeRange):
        * page/Frame.cpp:
        (WebCore::Frame::rangeForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
jberlin@webkit.org [Mon, 13 Jun 2011 20:41:39 +0000 (20:41 +0000)]
plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
https://bugs.webkit.org/show_bug.cgi?id=33973

Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
getting fired on the plugin, but not the getFocusEvent in order to get the bots green.

* platform/win/plugins/mouse-events-expected.txt:
* platform/win/plugins/mouse-events-fixedpos-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 13 Jun 2011 20:39:05 +0000 (20:39 +0000)]
2011-06-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Update the list of ignored GTK+ header files for the documentation
        generation.

        * docs/GNUmakefile.am: Update ignored header list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 20:36:03 +0000 (20:36 +0000)]
2011-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Nate Chapin.

        Factor IconController out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62509

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::iconURLs):
2011-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Nate Chapin.

        Factor IconController out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62509

        This new class contains all the icon-related logic from FrameLoader.
        The icon-related logic and state has almost zero interaction with the
        rest of FrameLoader and is better handled as a separate concern.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        (WebCore::Document::setIconURL):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::iconLoadDecisionAvailable):
        (WebCore::DocumentLoader::continueIconLoadWithDecision):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::stop):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::icon):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading):
        (WebCore::IconLoader::finishLoading):
        * loader/icon/IconLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 13 Jun 2011 20:25:41 +0000 (20:25 +0000)]
2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Update NEWS for 1.5.1 release.

        * NEWS: update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
dpranke@chromium.org [Mon, 13 Jun 2011 20:20:05 +0000 (20:20 +0000)]
2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88671.
        http://trac.webkit.org/changeset/88671
        https://bugs.webkit.org/show_bug.cgi?id=62591

        "didn't work" (Requested by dpranke on #webkit).

        * Scripts/new-run-webkit-httpd:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 13 Jun 2011 20:19:07 +0000 (20:19 +0000)]
2011-06-13  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
        mostly written by Kelly Norton (knorton@google.com).

        * plugins/npruntime/embed-property-equality-expected.txt: Added.
        * plugins/npruntime/embed-property-equality.html: Added.
2011-06-13  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Cache V8NPObjects so that we don't create multiple
        NPObjects for the same v8::Object.
        https://bugs.webkit.org/show_bug.cgi?id=61482

        Test: plugins/npruntime/embed-property-equality.html

        * bindings/v8/NPV8Object.cpp:
        (WebCore::freeV8NPObject):
        (WebCore::npCreateV8ScriptObject):
2011-06-13  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Mon, 13 Jun 2011 20:16:20 +0000 (20:16 +0000)]
2011-06-13  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Alexey Proskuryakov.

        chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
        https://bugs.webkit.org/show_bug.cgi?id=49316

        The bug got fixed, thus just landing the test case. Including another test case from
        http://code.google.com/p/chromium/issues/detail?id=61562
        which should have the same root cause.

        * fast/html/crash-style-first-letter-expected.txt: Added.
        * fast/html/crash-style-first-letter.html: Added.
        * svg/custom/svg-use-style-float-crash-expected.txt: Added.
        * svg/custom/svg-use-style-float-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 13 Jun 2011 20:07:53 +0000 (20:07 +0000)]
2011-06-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        BankID plug-in isn't instantiated correctly
        https://bugs.webkit.org/show_bug.cgi?id=62588
        <rdar://problem/9586600>

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::NetscapePluginModule::determineQuirks):
        The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can
        use the half-baked QuickDraw support.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::defaultSyncMessageTimeout):
        Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events
        and we don't want the plug-in to die while it's waiting for a reply.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 13 Jun 2011 20:03:06 +0000 (20:03 +0000)]
2011-06-13  James Robinson  <jamesr@chromium.org>

        [chromium] Fix up a boo-boo in GPU test expectations

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTest run fix.
levin@chromium.org [Mon, 13 Jun 2011 20:01:30 +0000 (20:01 +0000)]
Test run fix.

[GTK] DumpRenderTree doesn't block external requests.
https://bugs.webkit.org/show_bug.cgi?id=62585

* platform/gtk/Skipped: Skipping a test which depends on this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore:
xan@webkit.org [Mon, 13 Jun 2011 19:47:09 +0000 (19:47 +0000)]
Source/WebCore:

2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Distcheck fixes.

        * GNUmakefile.am:
        * GNUmakefile.list.am:

Source/WebKit/gtk:

2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Distcheck fixes.

        * GNUmakefile.am:

Source/JavaScriptCore:

2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Distcheck fixes.

        * GNUmakefile.am:
        * GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 13 Jun 2011 19:37:49 +0000 (19:37 +0000)]
2011-06-13  Robert Hogan  <robert@webkit.org>

        Unreviewed, cleanup r87611.

        [Qt]Unskip fast/events/backspace-navigates-back.html

        This should have been unskipped by http://trac.webkit.org/changeset/87611

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an extra space in the Windows-specific failing expected results to ge the...
jberlin@webkit.org [Mon, 13 Jun 2011 19:33:52 +0000 (19:33 +0000)]
Remove an extra space in the Windows-specific failing expected results to ge the bots
green.

* platform/win/printing/page-count-relayout-shrink-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 13 Jun 2011 19:15:27 +0000 (19:15 +0000)]
2011-06-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
        https://bugs.webkit.org/show_bug.cgi?id=62251

        shut_down_http_server() was a total hack that was only used by
        new-run-webkit-httpd, so I've moved the code there and switched
        to using executive.kill_process() for the common case. The
        method itself will be removed in the patch on bug 59993.

        * Scripts/new-run-webkit-httpd:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 13 Jun 2011 19:12:04 +0000 (19:12 +0000)]
2011-06-13  Dirk Schulze  <krit@webkit.org>

        Reviewed build fix of mac.

        SVGAnimation should use direct unit animation for SVGLength
        https://bugs.webkit.org/show_bug.cgi?id=61368

        Forgot to add SVGAnimatedLength.cpp.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agokAXTextMarkerForPositionParametrizedAttribute does not work correctly in WK2
cfleizach@apple.com [Mon, 13 Jun 2011 19:10:16 +0000 (19:10 +0000)]
kAXTextMarkerForPositionParametrizedAttribute does not work correctly in WK2
https://bugs.webkit.org/show_bug.cgi?id=62547

Reviewed by Darin Adler.

Implement the missing screenToWindow method for WK2.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::screenToWindow):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::screenToWindow):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::screenToWindow):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::screenToWindow):
* UIProcess/win/WebView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::screenToWindow):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::screenToWindow):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 13 Jun 2011 19:09:32 +0000 (19:09 +0000)]
2011-06-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Simon Fraser.

        Make it possible to inline Identifier::equal
        https://bugs.webkit.org/show_bug.cgi?id=62584

        Move Identifier::equal to the Identifier header file.

        * runtime/Identifier.cpp:
        * runtime/Identifier.h:
        (JSC::Identifier::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn...
weinig@apple.com [Mon, 13 Jun 2011 18:59:45 +0000 (18:59 +0000)]
REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
<rdar://problem/9580237>

Reviewed by Darin Adler.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::shouldUseSelection):
Return early if the selection we are using is not a range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 13 Jun 2011 18:58:25 +0000 (18:58 +0000)]
2011-06-13  James Robinson  <jamesr@chromium.org>

        [chromium] Clean up GPU test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 18:53:30 +0000 (18:53 +0000)]
2011-06-13  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB test: complex keyPaths
        https://bugs.webkit.org/show_bug.cgi?id=62468

        * storage/indexeddb/keyPath-expected.txt: Added.
        * storage/indexeddb/keyPath.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 13 Jun 2011 18:50:55 +0000 (18:50 +0000)]
2011-06-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        Print out bounds origin in layer dump
        https://bugs.webkit.org/show_bug.cgi?id=62583

        Include m_boundsOrigin in the layer dump, which is used by layerTreeAsText().

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::dumpProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 13 Jun 2011 18:48:36 +0000 (18:48 +0000)]
2011-06-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimation should use direct unit animation for SVGLength
        https://bugs.webkit.org/show_bug.cgi?id=61368

        Added new tests to check correct behavior of SVGLength animations.

        * svg/animations/script-tests/svglength-animation-LengthModeHeight.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-LengthModeOther.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-LengthModeWidth.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-invalid-value-1.js: Added.
        (sample1):
        (sample2):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-invalid-value-2.js: Added.
        (sample1):
        (sample2):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-invalid-value-3.js: Added.
        (sample1):
        (sample2):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-number-to-number.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-cm.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-ems.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-exs.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-in.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-number.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-pc.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-percentage.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-pt.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-px-to-px.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglength-animation-values.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (sample4):
        (sample5):
        (executeTest):
        * svg/animations/svglength-animation-LengthModeHeight-expected.txt: Added.
        * svg/animations/svglength-animation-LengthModeHeight.html: Added.
        * svg/animations/svglength-animation-LengthModeOther-expected.txt: Added.
        * svg/animations/svglength-animation-LengthModeOther.html: Added.
        * svg/animations/svglength-animation-LengthModeWidth-expected.txt: Added.
        * svg/animations/svglength-animation-LengthModeWidth.html: Added.
        * svg/animations/svglength-animation-invalid-value-1-expected.txt: Added.
        * svg/animations/svglength-animation-invalid-value-1.html: Added.
        * svg/animations/svglength-animation-invalid-value-2-expected.txt: Added.
        * svg/animations/svglength-animation-invalid-value-2.html: Added.
        * svg/animations/svglength-animation-invalid-value-3-expected.txt: Added.
        * svg/animations/svglength-animation-invalid-value-3.html: Added.
        * svg/animations/svglength-animation-number-to-number-expected.txt: Added.
        * svg/animations/svglength-animation-number-to-number.html: Added.
        * svg/animations/svglength-animation-px-to-cm-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-cm.html: Added.
        * svg/animations/svglength-animation-px-to-ems-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-ems.html: Added.
        * svg/animations/svglength-animation-px-to-exs-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-exs.html: Added.
        * svg/animations/svglength-animation-px-to-in-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-in.html: Added.
        * svg/animations/svglength-animation-px-to-number-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-number.html: Added.
        * svg/animations/svglength-animation-px-to-pc-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-pc.html: Added.
        * svg/animations/svglength-animation-px-to-percentage-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-percentage.html: Added.
        * svg/animations/svglength-animation-px-to-pt-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-pt.html: Added.
        * svg/animations/svglength-animation-px-to-px-expected.txt: Added.
        * svg/animations/svglength-animation-px-to-px.html: Added.
        * svg/animations/svglength-animation-values-expected.txt: Added.
        * svg/animations/svglength-animation-values.html: Added.
2011-06-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimation should use direct unit animation for SVGLength
        https://bugs.webkit.org/show_bug.cgi?id=61368

        When running SMIL animations  within SVG, we unnecessarily transform the underlying SVG primitive datatype to strings, number+units, and back. As first step the target element
        gets asked for its current value. This value gets transformed to a string. In SVGAnimateElement we try to parse this string again and
        split it into a number and its unit. In the further steps we just animate the number. This number gets transformed back to a string
        together with the parsed unit. The string gets passed back to the target element, which is responsible for parsing the passed string back
        to a value as a SVG primitive datatype (like SVGLength, SVGNumber, SVGAngle, SVGColor, ...), relayout and rerendering.

        In short: SVG primitive datatype -> string -> number + unit animation -> string -> SVG primitive datatype.

        This patch does not attempt to change the string transformations, but addresses the parsing of the string back to a number and unit in the
        SVG animation code. There's no need to write a new parser in SVGAnimateElement to parse SVG primitive datatypes, we can instead reuse the existing ones.
        Also the current parser of SVGAnimateElement does not handle most unit types, nor is it possible to animate lists like SVGLengthList with the
        parsed content. An animation of values with different unit types is not possible:

        <rect width="20" height="20">
            <animate animateAttribute="width" from="20px" to="10%" dur="4s"/>
        </rect>

        For the example above we would animate the rect width from 20px to 10px in 4 seconds and jump to the 10% of the viewport at the end of the
        animation.
        With using the parsers of SVG primitive datatypes we will also use the SVG primitive datatypes in the animation code itself. And that makes
        it possible to do such animations.

        In short: SVG primitive datatype -> string -> SVG primitive datatype animation -> string -> SVG primitive datatype.

        It will be easier to avoid the string transformation once all SVG primitive datatypes are supported.

        To hide the complexity of the animation code, the actual calculations of SVG animation specific values was moved to the corresponding
        SVGAnimated* files (SVGAnimatedLength.cpp for SVGLength). SVGAnimateElement itself just works with the new added generic datatype SVGAnimationType.
        SVGAnimatorFactory creates the SVG primitive datatype specific animators. This makes the main animation code a lot more readable and
        maintainable.

        With this patch I add the SVGAnimatorFactory and convert SVGLength animation to the new concept.

        Tests: svg/animations/svglength-animation-LengthModeHeight.html
               svg/animations/svglength-animation-LengthModeOther.html
               svg/animations/svglength-animation-LengthModeWidth.html
               svg/animations/svglength-animation-invalid-value-1.html
               svg/animations/svglength-animation-invalid-value-2.html
               svg/animations/svglength-animation-invalid-value-3.html
               svg/animations/svglength-animation-number-to-number.html
               svg/animations/svglength-animation-px-to-cm.html
               svg/animations/svglength-animation-px-to-ems.html
               svg/animations/svglength-animation-px-to-exs.html
               svg/animations/svglength-animation-px-to-in.html
               svg/animations/svglength-animation-px-to-number.html
               svg/animations/svglength-animation-px-to-pc.html
               svg/animations/svglength-animation-px-to-percentage.html
               svg/animations/svglength-animation-px-to-pt.html
               svg/animations/svglength-animation-px-to-px.html
               svg/animations/svglength-animation-values.html

        * CMakeLists.txt: Added new files to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Added SVGAnimatedLength.cpp for Win and other build systems.
        * svg/SVGAnimateElement.cpp:
        (WebCore::parseNumberValueAndUnit): Remove parsing code for SVGLength. Use SVGLength parser directly.
        (WebCore::SVGAnimateElement::adjustForCurrentColor): Made adjustForCurrentColor public as preperation for SVGAnimatedColor.
        (WebCore::getPropertyValue): Inline function to get computedStyle of CSS property.
        (WebCore::SVGAnimateElement::adjustForInheritance): Made adjustForInheritance as preperation for SVGAnimated* files.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType): SVGLength need special handling via SVGAnimator now.
        (WebCore::SVGAnimateElement::calculateAnimatedValue): Cleanup. Make use of SVGAnimator for SVGLength.
        (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto.
        (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
        (WebCore::SVGAnimateElement::resetToBaseValue): Ditto.
        (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto.
        (WebCore::SVGAnimateElement::calculateDistance): Ditto.
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimatedLength.cpp: Added.
        (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator):
        (WebCore::sharedSVGLength):
        (WebCore::SVGAnimatedLengthAnimator::constructFromString):
        (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
        * svg/SVGAnimatedLength.h: Added new class SVGAnimatedLengthAnimator which is responsible for the actual animation.
        (WebCore::SVGAnimatedLengthAnimator::~SVGAnimatedLengthAnimator):
        * svg/SVGAnimatedType.h: Added. Generic SVG unit type for animations in SVGAnimateElement.
        (WebCore::SVGAnimatedType::createLength):
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::type):
        (WebCore::SVGAnimatedType::length):
        (WebCore::SVGAnimatedType::SVGAnimatedType):
        * svg/SVGAnimatedTypeAnimator.h: Added. Base class for SVGAnimatedLengthAnimator and future SVG unit animators.
        (WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator):
        (WebCore::SVGAnimatedTypeAnimator::setContextElement):
        (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::parseMappedAttribute): We do not use parseNumberValueAndUnit for SVGLength now. Have to strip white spaces here. Whitespaces shouldn't
          be stripped on the following attributes: 'from', 'to' and 'by'. This is not the case for SVGLength anymore. Added new tests to check this behavior.
        (WebCore::SVGAnimationElement::animationMode): Enum is accessible in WebCore namespace now.
        (WebCore::SVGAnimationElement::calcMode): Ditto.
        * svg/SVGAnimationElement.h:
        * svg/SVGAnimatorFactory.h: Added.
        (WebCore::SVGAnimatorFactory::create):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::setValueAsString): New setter with string and SVGLengthMode.
        (WebCore::SVGLength::lengthModeForAnimatedLengthAttribute): Get LengthMode for SVGLength depending on the attribute name.
        * svg/SVGLength.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 18:37:35 +0000 (18:37 +0000)]
2011-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        r87539 broke HTMLMediaElement url logging
        https://bugs.webkit.org/show_bug.cgi?id=62551

        Returning pointers to temporaries is bad times!

        * html/HTMLMediaElement.cpp:
        (WebCore::urlForLogging):
        (WebCore::HTMLMediaElement::loadResource):
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
        (WebCore::HTMLMediaElement::selectNextSourceChild):
        (WebCore::HTMLMediaElement::sourceWasAdded):
        (WebCore::HTMLMediaElement::sourceWillBeRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 13 Jun 2011 18:36:21 +0000 (18:36 +0000)]
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62578

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62578

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62578

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62578

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62578

        * Scripts/build-webkit:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62578

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 18:29:05 +0000 (18:29 +0000)]
2011-06-13  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: setVersion() version argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62401

        * storage/indexeddb/setVersion-undefined-expected.txt: Added.
        * storage/indexeddb/setVersion-undefined.html: Added.
2011-06-13  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: setVersion() version argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62401

        Test: storage/indexeddb/setVersion-undefined.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::setVersion): check for null version
        * storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 13 Jun 2011 18:22:24 +0000 (18:22 +0000)]
2011-06-13  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement accelerated compositing on WK2 Qt port
        https://bugs.webkit.org/show_bug.cgi?id=56935

        Added WebGraphicsLayer, a subclass of WebCore::GraphicsLayer that serializes the state of the layer
        tree to the UI process WebLayerTreeInfo.
        For now this patch doesn't serialize the animation information, a feature that will be upstreamed later on.

        Together with Viatcheslav Ostapenko.

        * WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: Added.
        * WebProcess/WebCoreSupport/WebGraphicsLayer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jun 2011 18:20:10 +0000 (18:20 +0000)]
2011-06-13  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Clean up test expectations, add a flake.

        * platform/chromium/test_expectations.txt: Cleaned up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 13 Jun 2011 18:18:12 +0000 (18:18 +0000)]
2011-06-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        Add utility method to report whether a RenderLayer has any scrollbars
        https://bugs.webkit.org/show_bug.cgi?id=62579

        New method that returns true with either scrollbar is present.

        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::hasScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 13 Jun 2011 18:09:45 +0000 (18:09 +0000)]
2011-06-13  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement accelerated compositing on WK2 Qt port
        https://bugs.webkit.org/show_bug.cgi?id=56935

        Added WebLayerTreeInfo: a set of structures that can serialize a tree of GraphicsLayers
        across to the UI process.

        Together with Viatcheslav Ostapenko.

        * Scripts/webkit2/messages.py:
        * Shared/WebLayerTreeInfo.cpp: Added.
        * Shared/WebLayerTreeInfo.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-11 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 13 Jun 2011 18:05:09 +0000 (18:05 +0000)]
2011-06-11  Jer Noble  <jer.noble@apple.com>

        Reviewed by Anders Carlsson.

        Avoid flashing when exiting full-screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=62338

        No new tests; covered by the existing full-screen tests.

        Now that we are forcing a repaint inside of setRootFullScreenLayer() instead of during
        the next run loop, make sure that we have disabled animation before calling
        setRootFullScreenLayer() so that the RenderFullScreen renderer and its contents are
        painted.

        * dom/Document.cpp:
        (WebCore::Document::webkitDidEnterFullScreenForElement):
2011-06-11  Jer Noble  <jer.noble@apple.com>

        Reviewed by Anders Carlsson.

        Avoid flashing when exiting full-screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=62338

        Instead of making a round-trip between processes by calling forceRepaint
        and waiting for a callback, instead make a WebProcess-side call to
        forceRepaintWithoutCallback before sending the ExitAcceleratedCompositingMode
        message to the WebFullScreenControllerProxy. This also means we can get rid of
        the dragImage creation and display.

        Because this redraw will happen during the current run-loop instead of a future
        one, make sure the background color has been set before the redraw in
        didEnterFullScreen().

        Wait to hide the full-screen window until after we have received the
        ExitAcceleratedCompositingMode message.  By this time, repaint will have already
        completed.

        * UIProcess/mac/WKFullScreenWindowController.h:
        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Disable
            screen updates, to be re-enabled during exitAcceleratedCompositingMode.
        (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Don't hide
            the full-screen window here; wait for exitAcceleratedCompositing instead.
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Collapse
            the redrawCompleted method into this one.
        (-[WKFullScreenWindowController close]): Remove the reference to
            exitCompositedModeRepaintCompleted.
        * WebProcess/FullScreen/WebFullScreenManager.cpp:
        (WebKit::WebFullScreenManager::didEnterFullScreen): Set the full screen
            background color first.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Repaint before
            sending the ExitAcceleratedCompositingMode message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-10 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 13 Jun 2011 18:02:13 +0000 (18:02 +0000)]
2011-06-10  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen
        https://bugs.webkit.org/show_bug.cgi?id=62491
        <rdar://problem/9584427>

        No new tests; should be covered by existing fullscreen pixel tests.

        On certain displays, when a RenderFullScreen renderer is created, it is large enough to trigger the
        creation of a tiled CALayer (instead of a normal CALayer).  Painting in these layers necessarily
        happens asynchronously, so the flash is occurring because of the async painting of the RenderFullScreen
        renderer's background color.  Since we know the RenderFullScreen does not otherwise paint its contents,
        we can add a special case in the RenderLayerBacking to set the GraphicsLayer contents to be the
        renderer's background color.  Fill in support for creating a contentLayer to contain the background
        color inside GraphicsLayerCA.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::setContentsToBackgroundColor): Renamed from setContentsBackgroundColor to match
            the other setContentsTo... functions.
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setContentsToBackgroundColor): Added. Creates a contentsLayer to host the
            background color.
        (WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Removed a comment only.
        * platform/graphics/ca/GraphicsLayerCA.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Special case the RenderFullScreen
            renderer to call updateBackgroundColor.
        (WebCore::RenderLayerBacking::updateBackgroundColor): Added.
        (WebCore::RenderLayerBacking::containsPaintedContent): Tell the backing that the RenderFullScreen
            renderer does not paint its contents.
        * rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Tim Horton <timothy_horton@apple.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 17:59:28 +0000 (17:59 +0000)]
2011-06-13  Tim Horton  <timothy_horton@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION(87152): Crash on page with svg fonts
        https://bugs.webkit.org/show_bug.cgi?id=61556

        We can't assume that the parent of a SVG-font-styled
        text node won't be an anonymous block.

        Test: svg/text/text-font-anonymous-parent.xhtml

        * rendering/svg/SVGTextRunRenderingContext.cpp:
        (WebCore::firstParentRendererForNonTextNode):
        (WebCore::SVGTextRunWalker::walk):
        (WebCore::floatWidthOfSubStringUsingSVGFont):
        (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 13 Jun 2011 17:49:03 +0000 (17:49 +0000)]
2011-06-13  Dirk Schulze  <krit@webkit.org>

        Rubber-stamped by Rob Buis.

        SVG patternTransform not animatable
        https://bugs.webkit.org/show_bug.cgi?id=62538

        Removing 'transform' animation test. It was added as an example for animateTransform tests but fails on some platforms.
        Also it is not part of the fix for 'patternTransform' animation. The test for 'patternTransform' works.
        Adding animateTransform-pattern-transform to the skip list of Mac WebKit2, like all other animation or dynamic-update tests.

        * platform/mac-wk2/Skipped:
        * svg/animations/animateTransform-transformable-transform-expected.txt: Removed.
        * svg/animations/animateTransform-transformable-transform.html: Removed.
        * svg/animations/script-tests/animateTransform-transformable-transform.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd radar number.
andersca@apple.com [Mon, 13 Jun 2011 17:47:01 +0000 (17:47 +0000)]
Add radar number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 13 Jun 2011 17:32:10 +0000 (17:32 +0000)]
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62545

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62545

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62545

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62545

        * Configurations/FeatureDefines.xcconfig:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62545

        * Scripts/build-webkit:
2011-06-13  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
        https://bugs.webkit.org/show_bug.cgi?id=62545

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 13 Jun 2011 17:25:27 +0000 (17:25 +0000)]
2011-06-13  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Updated Leopard pixel baselines.

        * platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
        * platform/chromium-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
        * platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png: Added.
        * platform/chromium-mac-leopard/fast/borders/outline-alpha-inline-expected.png: Added.
        * platform/chromium-mac-leopard/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 13 Jun 2011 17:24:10 +0000 (17:24 +0000)]
2011-06-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Don't access freed memory in the UI process when a plug-in process crashes
        https://bugs.webkit.org/show_bug.cgi?id=62548

        Call pluginProcessCrashedOrFailedToLaunch after sending messages to all processes about the plug-in crash,
        otherwise we'll try to dereference m_pluginInfo.path after the PluginProcessProxy object has been deleted.

        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 13 Jun 2011 17:14:36 +0000 (17:14 +0000)]
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix a crash when drawing area has been deleted
        https://bugs.webkit.org/show_bug.cgi?id=62541

        Check whether WebPageProxy::drawingArea() returns a valid pointer
        before using it, it might be null, for example, when the web
        process crashes.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (callDrawingAreaPaintMethod):
        (webkitWebViewBaseSizeAllocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 13 Jun 2011 17:12:36 +0000 (17:12 +0000)]
2011-06-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Some distcheck fixes. Still broken, but this is moves us closer to
        the target.

        * GNUmakefile.am: fix vpath syntax and add missing files to
        EXTRA_DIST.
        * GNUmakefile.list.am: add missing files and remove dead files.
        * bindings/gobject/GNUmakefile.am: fix comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 13 Jun 2011 16:54:54 +0000 (16:54 +0000)]
2011-06-13  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Update test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 13 Jun 2011 16:16:55 +0000 (16:16 +0000)]
2011-06-13  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add layer factory to GraphicsLayer for creating non-default layer type.
        https://bugs.webkit.org/show_bug.cgi?id=61925

        Use the new factory function in TextureMapper.

        No new functionality so no new tests.

        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        (WebCore::GraphicsLayer::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 13 Jun 2011 15:48:20 +0000 (15:48 +0000)]
2011-06-13  Vitaly Repeshko  <vitalyr@chromium.org>

Unreviewed.

        [chromium] Update test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Mon, 13 Jun 2011 15:36:13 +0000 (15:36 +0000)]
2011-06-13  Young Han Lee  <joybro@company100.net>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
        https://bugs.webkit.org/show_bug.cgi?id=62281

        syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

        * animations/animation-direction-normal-expected.png: Added.
        * animations/animation-direction-normal-expected.txt: Added.
        * animations/animation-direction-normal.html: Added.
2011-06-13  Young Han Lee  <joybro@company100.net>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
        https://bugs.webkit.org/show_bug.cgi?id=62281

        syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

        Test: animations/animation-direction-normal.html

        * platform/graphics/texmap/TextureMapperNode.cpp:
        (WebCore::TextureMapperNode::syncAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 15:28:56 +0000 (15:28 +0000)]
2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
        https://bugs.webkit.org/show_bug.cgi?id=62429

        * UIProcess/API/efl/PageClientImpl.cpp:
        (WebKit::PageClientImpl::scrollView):
        (WebKit::PageClientImpl::setCursor):
        (WebKit::PageClientImpl::windowToScreen):
        (WebKit::PageClientImpl::doneWithKeyEvent):
        (WebKit::PageClientImpl::setFindIndicator):
        (WebKit::PageClientImpl::didCommitLoadForMainFrame):
        (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
        (WebKit::PageClientImpl::findStringInCustomRepresentation):
        (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
        * UIProcess/API/efl/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 KwangHyuk Kim <hyuki.kim@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 15:09:59 +0000 (15:09 +0000)]
2011-06-13  KwangHyuk Kim  <hyuki.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
        https://bugs.webkit.org/show_bug.cgi?id=62448

        Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
        from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter

        * ewk/ewk_tiled_model.c:
        (ewk_tile_new):
        * ewk/ewk_view_single.c:
        (_ewk_view_single_smart_repaints_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
commit-queue@webkit.org [Mon, 13 Jun 2011 14:58:05 +0000 (14:58 +0000)]
2011-06-13  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL][WK2] Add initial WebPreferencesEfl.cpp for webkit2 efl port
        https://bugs.webkit.org/show_bug.cgi?id=62525

        * UIProcess/efl/WebPreferencesEfl.cpp: Added.
        (WebKit::WebPreferences::platformInitializeStore):
        (WebKit::WebPreferences::platformUpdateStringValueForKey):
        (WebKit::WebPreferences::platformUpdateBoolValueForKey):
        (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
        (WebKit::WebPreferences::platformUpdateDoubleValueForKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 13 Jun 2011 14:28:31 +0000 (14:28 +0000)]
2011-06-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Rob Buis.

        SVG patternTransform not animatable
        https://bugs.webkit.org/show_bug.cgi?id=62538

        SVG animation did not take attribute 'patternTransform' into account. Added support for combination of
        SVGPatternElement and attribute 'patternTransform' to SVGAnimateTransformElement.

        Tests: svg/animations/animateTransform-pattern-transform.html
               svg/animations/animateTransform-transformable-transform.html

        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::transformListFor):
        (WebCore::SVGAnimateTransformElement::resetToBaseValue):
        (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
2011-06-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Rob Buis.

        SVG patternTransform not animatable
        https://bugs.webkit.org/show_bug.cgi?id=62538

        Test SVG animateTransform for attributes 'transform' and 'patternTransform'.

        * svg/animations/animateTransform-pattern-transform-expected.txt: Added.
        * svg/animations/animateTransform-pattern-transform.html: Added.
        * svg/animations/animateTransform-transformable-transform-expected.txt: Added.
        * svg/animations/animateTransform-transformable-transform.html: Added.
        * svg/animations/script-tests/animateTransform-pattern-transform.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/animateTransform-transformable-transform.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 13 Jun 2011 14:12:45 +0000 (14:12 +0000)]
2011-06-13  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Update test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Mon, 13 Jun 2011 13:41:44 +0000 (13:41 +0000)]
2011-06-13  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] JSC Bridge: convert QtConnectionObject to use JSC API
        https://bugs.webkit.org/show_bug.cgi?id=62330

        This patch is based on the draft patch by Noam Rosenthal in bug 60842.
        Qt API autotests cover the bridge behavior and pass after this patch.

        * bridge/qt/qt_runtime.h: Change QtConnectionObject to use JSC API types. In
        particular, we got rid of Strong<JSObject> members. Renamed some members and
        arguments to follow existing naming in QObject::connect().

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeConnectionMethod::call): Use a new helper function
        to create a connection, passing the ExecState* that will be used when the
        connection is activated (signal emitted). Use JSC API types when looking up
        the matching signal to disconnect.

        (JSC::Bindings::QtConnectionObject::QtConnectionObject): Use JSC API to
        protect the receiver and receiverFunction from being garbage
        collected. Removed the ASSERT() since we don't hold ProtectedPtrs (in current
        code were Strong<>) anymore.

        (JSC::Bindings::QtConnectionObject::~QtConnectionObject): Explain why is safe
        to use m_originalSender here. Unprotect values that we protected in constructor.

        (JSC::Bindings::isJavaScriptFunction): Helper function to identify whether a
        JSObjectRef is a JS function (in contrast to a native function exposed to JS).

        (JSC::Bindings::QtConnectionObject::execute):
        (JSC::Bindings::QtConnectionObject::match):
        Both updated to use JSC API when appliable. Note that convertQVariantToValue
        still returns JSC internal types, will be handled in a different patch.

        (JSC::Bindings::QtConnectionObject::createWithInternalJSC):
        Convenince for the existing caller until it is converted to JSC as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 13 Jun 2011 09:35:30 +0000 (09:35 +0000)]
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add context menu support for Webkit2
        https://bugs.webkit.org/show_bug.cgi?id=54827

        * platform/ContextMenuItem.h: Add gtkAction().
        * platform/gtk/ContextMenuGtk.cpp:
        (WebCore::ContextMenu::ContextMenu): Implement constructor that
        receives a platform menu.
        (WebCore::ContextMenu::setPlatformDescription): Make sure we don't
        destroy the menu if the new context menu is the current one.
        (WebCore::contextMenuItemVector): Implement this method to return
        the list of menu items in the given context menu, required by WebKit2.
        (WebCore::platformMenuDescription): Implement this method to
        return a platform menu for the given menu items.
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::createPlatformMenuItemDescription): Helper function to
        create a platform context menu item.
        (WebCore::ContextMenuItem::ContextMenuItem): Use
        createPlatformMenuItemDescription().
        (WebCore::ContextMenuItem::title): Convert the title from UTF-8.
        (WebCore::ContextMenuItem::setTitle): Use gtkAction().
        (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu()
        that receives a list of items.
        (WebCore::ContextMenuItem::setChecked): Use gtkAction().
        (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2.
        (WebCore::ContextMenuItem::enabled): Ditto.
        (WebCore::ContextMenuItem::setEnabled): Use gtkAction().
        (WebCore::ContextMenuItem::gtkAction): Return the GtkAction
        associated to the context menu item.
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add context menu support for Webkit2
        https://bugs.webkit.org/show_bug.cgi?id=54827

        * GNUmakefile.am: Add new files to compilation.
        * UIProcess/API/gtk/PageClientImpl.cpp:
        (WebKit::PageClientImpl::createContextMenuProxy): Create a context
        menu proxy.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (globalPointForClientPoint): Function copied from webkit1 to
        convert a point in widget coordinates to global coordinates.
        (popupMenuPositionFunction):
        (webkitWebViewBaseShowContextMenu): Show the given context menu at
        the given position.
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
        * UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added.
        (WebKit::contextMenuItemActivatedCallback):
        (WebKit::WebContextMenuProxyGtk::createGtkMenu):
        (WebKit::WebContextMenuProxyGtk::showContextMenu):
        (WebKit::WebContextMenuProxyGtk::hideContextMenu):
        (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
        (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
        * UIProcess/gtk/WebContextMenuProxyGtk.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h.
        (WebKit::WebContextMenuProxyGtk::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>
keishi@webkit.org [Mon, 13 Jun 2011 09:03:15 +0000 (09:03 +0000)]
2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>

    Fix mistake I made in 88632

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Keishi Hattori <keishi@webkit.org>
keishi@webkit.org [Mon, 13 Jun 2011 09:00:32 +0000 (09:00 +0000)]
2011-06-13  Keishi Hattori  <keishi@webkit.org>

    Sort WebCore.xcodeproj

    Accomplished using sort-Xcode-project-file.

    * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 13 Jun 2011 08:56:53 +0000 (08:56 +0000)]
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        * GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
        * webkit/webkitwebview.h: Move declarations common to WebKit2 to
        webkitwebviewcommon.h.
        * webkit/webkitwebviewcommon.h: Added.
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        Add first implementation of WebKitWebView, a class with the same
        API than webkit1, that wraps the C API to provide a high level
        WebKit2 API for GTK port.

        * GNUmakefile.am: Add new files to compilation.
        * UIProcess/API/gtk/WebKitWebView.cpp: Added.
        (webkit_web_view_init):
        (webkit_web_view_class_init):
        (webkit_web_view_new):
        (webkit_web_view_load_uri):
        (webkit_web_view_go_back):
        (webkit_web_view_go_forward):
        * UIProcess/API/gtk/WebKitWebView.h: Added.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseCreate):
        (webkitWebViewBaseCreateWebPage):
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
        * UIProcess/API/gtk/webkit/webkit.h: Added.
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
        code, but linking to libwebkit2gtk.

        * GNUmakefile.am:
        * GtkLauncher/main.c:
        (createBrowser):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 13 Jun 2011 06:38:38 +0000 (06:38 +0000)]
2011-06-12  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r88625.
        http://trac.webkit.org/changeset/88625
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Breaks SL Webkit2 Tests

        * platform/mac-wk2/Skipped:
2011-06-12  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r88625.
        http://trac.webkit.org/changeset/88625
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Breaks SL Webkit2 Tests

        * WebKit.vcproj/WebKit.sln:
2011-06-12  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r88625.
        http://trac.webkit.org/changeset/88625
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Breaks SL Webkit2 Tests

        * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame):
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 13 Jun 2011 06:20:45 +0000 (06:20 +0000)]
2011-06-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
        https://bugs.webkit.org/show_bug.cgi?id=62507

        No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
        webkitWillExitFullScreenForElement() to be able to test this.

        If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
        fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
        containsFullScreenElement property removed.  To protect against this, reset the property by calling
        setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

        * dom/Document.cpp:
        (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 05:15:19 +0000 (05:15 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::interruptedForPolicyChangeError):
        (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/MainResourceLoader.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
        * src/FrameLoaderClientImpl.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::interruptedForPolicyChangeError):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebFrame.cpp:
        (WebFrame::interruptedForPolicyChangeError):
        * WebFrame.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebProcess/WebCoreSupport/WebErrors.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
        * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
        (WebKit::interruptedForPolicyChangeError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 Hironori Bono <hbono@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 04:55:42 +0000 (04:55 +0000)]
2011-06-12  Hironori Bono  <hbono@chromium.org>

        Reviewed by Hajime Morita.

        Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
        https://bugs.webkit.org/show_bug.cgi?id=62526

        This change adds null checks to the following function to prevent crashes
        when calling removeSpellcheckRange() with null:
        HTMLTextAreaElement::removeSpellcheckRange(),
        HTMLInputElement::removeSpellcheckRange(), and
        HTMLDivElement::removeSpellcheckRange().

        * editing/spelling/spellcheck-api-crash-expected.txt: Added.
        * editing/spelling/spellcheck-api-crash.html: Added.
2011-06-12  Hironori Bono  <hbono@chromium.org>

        Reviewed by Hajime Morita.

        Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
        https://bugs.webkit.org/show_bug.cgi?id=62526

        This change adds null checks to the following function to prevent crashes
        when calling removeSpellcheckRange() with null:
        HTMLTextAreaElement::removeSpellcheckRange(),
        HTMLInputElement::removeSpellcheckRange(), and
        HTMLDivElement::removeSpellcheckRange().

        Test: editing/spelling/spellcheck-api-crash.html

        * html/HTMLDivElement.cpp:
        (WebCore::HTMLDivElement::removeSpellcheckRange):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::removeSpellcheckRange):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::removeSpellcheckRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
mahesh.kulkarni@nokia.com [Mon, 13 Jun 2011 04:13:16 +0000 (04:13 +0000)]
2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] LayoutTestController needs setTextDirection implementation
        https://bugs.webkit.org/show_bug.cgi?id=62442

        Implements LayoutController.setTextDirection.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setTextDirection):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] LayoutTestController needs setTextDirection implementation
        https://bugs.webkit.org/show_bug.cgi?id=62442

        Unskipping fast/html/set-text-direction.html.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Mon, 13 Jun 2011 03:05:02 +0000 (03:05 +0000)]
2011-06-12  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Hajime Morita.

        Add window.internals to WebKit2's WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=61073

        * platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html
2011-06-12  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Hajime Morita.

        Add window.internals to WebKit2's WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=61073

        * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-12  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Hajime Morita.

        Add window.internals to WebKit2's WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Test: fast/harness/internals-object.html

        * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 02:17:23 +0000 (02:17 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtPrintFrameUserGestureStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88624 268f45cc-cd09-0410-ab3c-d52691b4dbfc