WebKit-https.git
9 years agoUnreviewed build fix.
bfulgham@webkit.org [Wed, 5 Jan 2011 19:23:24 +0000 (19:23 +0000)]
Unreviewed build fix.

* wtf/Encoder.h: Add <stdint.h> include for systems that
do not natively know about uint8_t, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 5 Jan 2011 19:09:53 +0000 (19:09 +0000)]
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Update FIXME comment to sound better. Also initialize the block to fix compile.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand failing Windows results after r75031. Fixing the tests is being tracked by
bweinstein@apple.com [Wed, 5 Jan 2011 19:03:04 +0000 (19:03 +0000)]
Land failing Windows results after r75031. Fixing the tests is being tracked by
https://bugs.webkit.org/show_bug.cgi?id=51912.

* platform/win/accessibility/document-role-expected.txt:
* platform/win/accessibility/selection-and-focus-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 5 Jan 2011 18:58:06 +0000 (18:58 +0000)]
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Do not merge anonymous blocks when one of them is the one getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        Test: fast/block/merge-anonymous-block-remove-child-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when trying to merge two anonymous blocks,
        one of which is getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        * fast/block/merge-anonymous-block-remove-child-crash-expected.txt: Added.
        * fast/block/merge-anonymous-block-remove-child-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 5 Jan 2011 18:48:57 +0000 (18:48 +0000)]
2011-01-05  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha.

        Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
        GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
        so this call is unnecessary.

        * WebCoreSupport/FullscreenVideoController.cpp:
        (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 5 Jan 2011 18:32:50 +0000 (18:32 +0000)]
2011-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
        https://bugs.webkit.org/show_bug.cgi?id=50641

        Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
        Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
        The font size delta is now stored as a member variable of EditingStyle as supposed to a property
        in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.

        No new tests are added since this is a refactoring.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange.
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta.
        (WebCore::EditingStyle::init): Ditto.
        (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange.
        (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta.
        (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta.
        (WebCore::EditingStyle::overrideWithStyle): Ditto.
        (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta.
        (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
        * editing/EditingStyle.h:
        (WebCore::EditingStyle::fontSizeDelta): Added.
        (WebCore::EditingStyle::hasFontSizeDelta): Added.
        * editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Jan 2011 18:28:29 +0000 (18:28 +0000)]
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Keep track of active text substitution preferences
        https://bugs.webkit.org/show_bug.cgi?id=51931

        * Shared/TextCheckerState.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle new selectors, mostly copied from WebKit1 code.

        (-[WKView orderFrontSubstitutionsPanel:]):
        Open the substitution panel.

        (-[WKView isAutomaticQuoteSubstitutionEnabled]):
        (-[WKView setAutomaticQuoteSubstitutionEnabled:]):
        (-[WKView toggleAutomaticQuoteSubstitution:]):
        (-[WKView isAutomaticDashSubstitutionEnabled]):
        (-[WKView setAutomaticDashSubstitutionEnabled:]):
        (-[WKView toggleAutomaticDashSubstitution:]):
        (-[WKView isAutomaticLinkDetectionEnabled]):
        (-[WKView setAutomaticLinkDetectionEnabled:]):
        (-[WKView toggleAutomaticLinkDetection:]):
        (-[WKView isAutomaticTextReplacementEnabled]):
        (-[WKView setAutomaticTextReplacementEnabled:]):
        (-[WKView toggleAutomaticTextReplacement:]):
        Call the text checker, and update the state in the web process if needed.

        * UIProcess/TextChecker.h:
        Add new flags.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::initializeState):
        Initialize flags from user defaults.

        (WebKit::TextChecker::setAutomaticQuoteSubstitutionEnabled):
        (WebKit::TextChecker::setAutomaticDashSubstitutionEnabled):
        (WebKit::TextChecker::setAutomaticLinkDetectionEnabled):
        (WebKit::TextChecker::setAutomaticTextReplacementEnabled):
        Update and save the flags.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
        (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
        (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
        (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
        Get the text checker state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 18:16:37 +0000 (18:16 +0000)]
2011-01-05  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Sync qwebkitplatformplugin.h in the plugin example
        https://bugs.webkit.org/show_bug.cgi?id=51882

        Make examples/platformplugin/qwebkitplatformplugin.h exactly the same
        as the one in the Api folder.

        * examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus...
mitz@apple.com [Wed, 5 Jan 2011 18:03:09 +0000 (18:03 +0000)]
<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
https://bugs.webkit.org/show_bug.cgi?id=51915

Reviewed by Darin Adler.

WebCore:

This changes the results of existing tests in fast/text.

* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added.
* rendering/style/RenderStyle.cpp:
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.

LayoutTests:

* platform/mac/fast/text/basic/014-expected.checksum:
* platform/mac/fast/text/basic/014-expected.png:
* platform/mac/fast/text/basic/014-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.checksum:
* platform/mac/fast/text/capitalize-boundaries-expected.png:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 5 Jan 2011 17:55:09 +0000 (17:55 +0000)]
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
        https://bugs.webkit.org/show_bug.cgi?id=51888

        Overrule Qt's default from qconfig.pri for non-production builds so
        that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.

        No new tests as there is no new functionality.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleaned up com.apple.WebProcess.sb
mitz@apple.com [Wed, 5 Jan 2011 17:50:20 +0000 (17:50 +0000)]
Cleaned up com.apple.WebProcess.sb

Rubber-stamped by Darin Adler.

* WebProcess/com.apple.WebProcess.sb: Moved the closing parentheses of multi-line blocks to
their own lines. Changed to use WebKit-standard 4-space indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Kundu Suchismita <suchi.kundu@nokia.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 17:37:33 +0000 (17:37 +0000)]
2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>

        Reviewed by Andreas Kling.

        [Qt]Add local storage settings to QtTestBrowser command line arguments
        https://bugs.webkit.org/show_bug.cgi?id=51750

        * QtTestBrowser/main.cpp:
        (LauncherApplication::handleUserOptions):
         Local storage settings can be enable form command line arguments for
         QtTestBrowser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 17:33:44 +0000 (17:33 +0000)]
2011-01-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74778.
        http://trac.webkit.org/changeset/74778
        https://bugs.webkit.org/show_bug.cgi?id=51930

        Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
        (Requested by bbandix on #webkit).

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::setContext):
        * bindings/v8/V8DOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK: AX: DRT needs to use correct root object method.
cfleizach@apple.com [Wed, 5 Jan 2011 17:31:07 +0000 (17:31 +0000)]
GTK: AX: DRT needs to use correct root object method.
https://bugs.webkit.org/show_bug.cgi?id=51911

Reviewed by Martin Robinson.

Tools:

* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::rootElement):

WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getRootAccessibleElement):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 17:27:03 +0000 (17:27 +0000)]
2011-01-05  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Animated GIF images does not animate 10x as expected by default.
        https://bugs.webkit.org/show_bug.cgi?id=36818

        Add a test animated GIF which should be displayed 2 times and stop.

        * manual-tests/animated-gif-looping.html:
        * manual-tests/resources/animated-2x.gif: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 5 Jan 2011 17:23:39 +0000 (17:23 +0000)]
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
        https://bugs.webkit.org/show_bug.cgi?id=51923

        Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
        ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.

        No new tests. This should not change functionality.

        * GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
        * platform/gtk/ScrollbarThemeGtk.cpp:
        (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
        * platform/gtk/ScrollbarThemeGtk.h:
        * platform/gtk/ScrollbarThemeGtk2.cpp: Added.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties):
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):
        * platform/gtk/ScrollbarThemeGtk3.cpp: Added.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties):
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 5 Jan 2011 16:55:13 +0000 (16:55 +0000)]
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * Source/cmake/WebKitMacros.cmake:
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * CMakeLists.txt:
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 5 Jan 2011 16:37:10 +0000 (16:37 +0000)]
2011-01-05  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build after recent changes.

        * pcre/pcre.pri: Correct the path after Source was introduced.
2011-01-05  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build after recent changes.

        No new tests needed.

        * WebCore.pro: Add missing files, and remove obsolete ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 5 Jan 2011 16:28:30 +0000 (16:28 +0000)]
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [WINCE] Remove CMake warning
        https://bugs.webkit.org/show_bug.cgi?id=51921

        * Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 15:51:37 +0000 (15:51 +0000)]
2011-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Adam Barth.

        Suspend HTMLParserScheduler when page load is deferred to
        avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
        from an external script or by events, and is blocked by a modal dialog,
        WebKit can parse more HTML source and also start another JS execution.

        https://bugs.webkit.org/show_bug.cgi?id=48077

        Test case: WebCore/manual-tests/bugzilla-48077.html.

        * dom/DocumentParser.cpp:
        (WebCore::DocumentParser::suspendScheduledTasks):
        (WebCore::DocumentParser::resumeScheduledTasks):
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::suspendScheduledTasks):
        (WebCore::HTMLDocumentParser::resumeScheduledTasks):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        (WebCore::HTMLParserScheduler::suspend):
        (WebCore::HTMLParserScheduler::resume):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
hausmann@webkit.org [Wed, 5 Jan 2011 15:48:50 +0000 (15:48 +0000)]
[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
https://bugs.webkit.org/show_bug.cgi?id=51926

Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva

Work around potential upstream bug: Querying a GstBin for the duration,
will forward the query to all sink children. Our WebKitWebSrc however
is a bin with only source children, therefore the query fails. Until
this is changed upstream, this patch works around it as follows,
based on suggestion by Philippe Normand and Sebastian Dröge:

When the initial query fails, attempt the same query on all source
pads and take the maximum length reported.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 5 Jan 2011 15:24:21 +0000 (15:24 +0000)]
2011-01-05  Hans Wennborg  <hans@chromium.org>

        Reviewed by David Levin.

        [Chromium] WebIDBKey clean-up
        https://bugs.webkit.org/show_bug.cgi?id=51925

        Remove constructors that are no longer used since the
        Chromium side has been updated.

        * public/WebIDBKey.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBased on idea from Péter Gál.
ossy@webkit.org [Wed, 5 Jan 2011 14:11:40 +0000 (14:11 +0000)]
Based on idea from Péter Gál.

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2011-01-05
Rubber-stamped by Csaba Osztrogonác.

* Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosheriff-bot should be able to do multi-revision rollouts
ossy@webkit.org [Wed, 5 Jan 2011 13:25:53 +0000 (13:25 +0000)]
sheriff-bot should be able to do multi-revision rollouts
https://bugs.webkit.org/show_bug.cgi?id=51176

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2011-01-05
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 5 Jan 2011 13:04:09 +0000 (13:04 +0000)]
2011-01-05  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Eric Seidel.

        [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
        https://bugs.webkit.org/show_bug.cgi?id=51810

        Based on a patch by Mart Raudsepp.

        No new tests, build fix only.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
        API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
        introduced in same version as the xoverlay API change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 5 Jan 2011 12:39:37 +0000 (12:39 +0000)]
2011-01-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org should have per-bot status pages
        https://bugs.webkit.org/show_bug.cgi?id=51906

        Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
        statuses from a single queue.  Now that we have many bots servicing
        some queues (commit-queue, win-ews, etc.) its easy to have the messages
        you care about scroll off the end of the 15-message limit on the main page.

        Eventually we should probably rename /queue-status to /queue or /queues,
        but that's fodder for another patch.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/index.yaml:
        * QueueStatusServer/main.py:
        * QueueStatusServer/templates/includes/singlequeuestatus.html:
         - This probably should use a custom filter instead of hard-coding
           the URL scheme here, but I couldn't figure out how to easily
           create such a filter.  Most filters work with "strings" so we can't
           pass the status object.  We could add a method to the status
           object and call that, but that seemed a bit strange too.
        * QueueStatusServer/templates/queuestatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Wed, 5 Jan 2011 12:11:15 +0000 (12:11 +0000)]
2011-01-05  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Malformed SVG causes crash in updateContainerOffset
        https://bugs.webkit.org/show_bug.cgi?id=44610

        Test case for recursive svg <use>.
        This test case passes if no crash occurs.

        * svg/custom/recursive-use-expected.txt: Added.
        * svg/custom/recursive-use.svg: Added.
2011-01-05  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Malformed SVG causes crash in updateContainerOffset
        https://bugs.webkit.org/show_bug.cgi?id=44610

        We should check recursive <use> at the begining of
        WebCore::SVGUseElement::buildInstanceTree instead
        of at the end of it because the target element's
        children may cause infinite recursive <use>.

        Test: svg/custom/recursive-use.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):
        (WebCore::SVGUseElement::hasCycleUseReferencing):
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=51907
antti@apple.com [Wed, 5 Jan 2011 12:03:55 +0000 (12:03 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51907
Style selector should only be recalculated when the pending sheet count goes to zero

Reviewed by Dan Bernstein.

Shark says this is a significant performance improvement on some sites with lots of stylesheets.

* dom/Document.cpp:
(WebCore::Document::removePendingSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
antti@apple.com [Wed, 5 Jan 2011 11:52:34 +0000 (11:52 +0000)]
Not reviewed.

Update a pixel test result for https://bugs.webkit.org/show_bug.cgi?id=8852.

* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 5 Jan 2011 10:45:01 +0000 (10:45 +0000)]
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use GtkStyleContext to get platform colors
        https://bugs.webkit.org/show_bug.cgi?id=51830

        Use GtkStyleContext API to get platform colors when building with
        GTK+ 3.x.

        No new tests. This should not change functionality.

        * platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
        * platform/graphics/gtk/ColorGtk.cpp:
        (WebCore::Color::Color):
        (WebCore::Color::operator GdkRGBA):
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
        (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor):
        (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor):
        (WebCore::RenderThemeGtk::systemColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 5 Jan 2011 10:18:43 +0000 (10:18 +0000)]
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Build fix for GTK when using gtk+-3 after r75009.

        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of
        adoptGRefPtr which doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Wed, 5 Jan 2011 09:32:57 +0000 (09:32 +0000)]
2011-01-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=51903
        Tell UI process which subframe is largest

        * WebCore.exp.in: Exported FrameView::contentsSize().
2011-01-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=51903
        Tell UI process which subframe is largest

        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::frameSetLargestFrame):
        Remember largest frame in frameset pages.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::frameDidBecomeFrameSet): Reset stored largest frame if main frame
        changes to a frameset or back.
        (WebKit::WebPageProxy::frameSetLargestFrameChanged): Store a new largest frame when notified
        of a change.

        * UIProcess/WebPageProxy.messages.in: Added FrameSetLargestFrameChanged.

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::area): Calculate area of a frame.
        (WebKit::findLargestFrameInFrameSet): Find largest first-level subframe in a frameset page.
        (WebKit::WebChromeClient::contentsSizeChanged): Recalculate largest frame, and notify UI
        process if it changed.

        * WebProcess/WebCoreSupport/WebChromeClient.h: Store the latest largest frame.

        * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::size):
        * WebProcess/WebPage/WebFrame.h:
        Expose frame size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 5 Jan 2011 09:12:59 +0000 (09:12 +0000)]
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Adding myself to the list of committers.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Wed, 5 Jan 2011 07:45:59 +0000 (07:45 +0000)]
2011-01-04  Chris Fleizach  <cfleizach@apple.com>

        Unreviewed. GTK build fix.

        WK2: Support Accessibility
        https://bugs.webkit.org/show_bug.cgi?id=51859

        * page/FrameView.cpp:
        (WebCore::FrameView::axObjectCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix. Update path to FindSafari after source code reorganization.
sfalken@apple.com [Wed, 5 Jan 2011 07:37:32 +0000 (07:37 +0000)]
Build fix. Update path to FindSafari after source code reorganization.

* JavaScriptCore.vcproj/JavaScriptCore.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Koan-Sin Tan <koansin.tan@gmail.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 07:33:00 +0000 (07:33 +0000)]
2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by David Levin.

        check-webkit-style treated some macros with parentheses after #elif as function calls
        https://bugs.webkit.org/show_bug.cgi?id=51695

        Ingore function call space checking in any preprocessor directives
        (things starting with #). Change search() to match() because
        preprocessor directives are supposed to be in the beginning of lines.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 5 Jan 2011 07:24:04 +0000 (07:24 +0000)]
2011-01-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        insecure-css-in-main-frame.html is flaky on Chromium-linux too.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
tkent@chromium.org [Wed, 5 Jan 2011 07:21:33 +0000 (07:21 +0000)]
2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74992.
        http://trac.webkit.org/changeset/74992
        https://bugs.webkit.org/show_bug.cgi?id=51917

        Crash in HTMLDocumentParser::suspendScheduledTasks()
        (Requested by tkent on #webkit).

        * dom/DocumentParser.cpp:
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        * html/parser/HTMLDocumentParser.h:
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Wed, 5 Jan 2011 06:24:55 +0000 (06:24 +0000)]
2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Add support for non-trivial context menu action
        https://bugs.webkit.org/show_bug.cgi?id=51902

        Fix the preprocessor guard for ContextMenuItemTagSelectAll in
        the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
        inconsistent with what is defined in ContextMenuItem.h.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Add support for non-trivial context menu action
        https://bugs.webkit.org/show_bug.cgi?id=51902

        Implement a call back from the QAction triggered in the UIProcess to the
        action in WebProcess.

        A few basic actions have been implemented based on this feature.

        * UIProcess/API/qt/qwkpage.cpp:
        (contextMenuActionForWebAction):
        (QWKPage::triggerAction):
        (QWKPage::action):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/qt/WebContextMenuProxyQt.cpp:
        (WebKit::webActionForContextMenuAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Siddharth Mathur <siddharth.mathur@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 5 Jan 2011 05:48:18 +0000 (05:48 +0000)]
2011-01-04  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        Include unistd.h for sleep() for non-Windows builds.

        * WebProcess/WebProcess.cpp:
        * WebProcess/qt/WebProcessMainQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 5 Jan 2011 05:30:02 +0000 (05:30 +0000)]
2011-01-04  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Ryosuke Niwa.

        Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
        https://bugs.webkit.org/show_bug.cgi?id=51723

        ScriptElement should also be able to keep its Element+CachedScript in
        a PendingScript, and then executeScriptSoon can accept a PendingScript.
        Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
        PendingScripts, then generic request and execute which operate on
        PendingScripts can be factored out to avoid code duplicate that we have.

        No new tests because no new functionality.

        * dom/AsyncScriptRunner.cpp:
        (WebCore::AsyncScriptRunner::~AsyncScriptRunner):
        (WebCore::AsyncScriptRunner::executeScriptSoon):
        (WebCore::AsyncScriptRunner::timerFired):
        * dom/AsyncScriptRunner.h:
        * dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
        * dom/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::requestPendingScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix. Change the inline type of consumePermanently.
bweinstein@apple.com [Wed, 5 Jan 2011 04:07:39 +0000 (04:07 +0000)]
Windows build fix. Change the inline type of consumePermanently.

* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 5 Jan 2011 03:30:40 +0000 (03:30 +0000)]
2011-01-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update

        - slow-loading-image-in-pattern.html had a wrong expectation for Chromium-win.
        - insecure-css-in-main-frame.html is flaky on Chromium-win?

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8821203> Sandbox violations trying to access the Safari cache
andersca@apple.com [Wed, 5 Jan 2011 03:10:45 +0000 (03:10 +0000)]
<rdar://problem/8821203> Sandbox violations trying to access the Safari cache

Reviewed by Dan Bernstein.

* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):
New function which consumes a sandbox extension and destroys it, making it impossible
to later revoke it.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the path extension handle.

* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::createHandle):
Standardize the path before creating the handle.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Create a sandbox extension for the cache path.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Consume the sandbox extension.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Wed, 5 Jan 2011 03:08:40 +0000 (03:08 +0000)]
Fix build.

* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::getGuessesForWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Jeff Miller <jeffm@apple.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 03:08:06 +0000 (03:08 +0000)]
2011-01-04  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Member variable and method naming cleanup to be consistent with WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=51228

        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::eventActivatedView):
        Rename activatedWebView() to didActivateWebView().

        * platform/PlatformMouseEvent.h:
        Rename m_activatedWebView to m_didActivateWebView.

        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        Initialize platform-specific member variables in PlatformMouseEvent constructors.

        (WebCore::PlatformMouseEvent::didActivateWebView):
        Rename activatedWebView() to didActivateWebView().

        * platform/win/PlatformMouseEventWin.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        Rename m_activatedWebView to m_didActivateWebView.
2011-01-04  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Mouse events in WebKit2 on Windows need to know whether the click activated the WebView to match WebKit1 behavior.
        https://bugs.webkit.org/show_bug.cgi?id=51228

        * Shared/WebEvent.h:
        (WebKit::WebMouseEvent::didActivateWebView):
        Add m_didActivateWebView to WebMouseEvent on Windows.

        * Shared/WebEventConversion.cpp:
        (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
        Propagate whether the click activated the WebView when converting to a PlatformMouseEvent.

        * Shared/WebMouseEvent.cpp:
        (WebKit::WebMouseEvent::WebMouseEvent):
        Add m_didActivateWebView to WebMouseEvent on Windows.

        (WebKit::WebMouseEvent::encode):
        (WebKit::WebMouseEvent::decode):
        Encode and decode new m_didActivateWebView member variable.

        * Shared/win/WebEventFactory.cpp:
        (WebKit::WebEventFactory::createWebMouseEvent):
        * Shared/win/WebEventFactory.h:
        Add didActivateWebView parameter to createWebMouseEvent().

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::wndProc):
        (WebKit::WebView::WebView):
        (WebKit::WebView::onMouseEvent):
        * UIProcess/win/WebView.h:
        (WebKit::WebView::setWasActivatedByMouseEvent):
        Keep track of whether the click activated the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Wed, 5 Jan 2011 02:21:00 +0000 (02:21 +0000)]
2011-01-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        CSS3 :nth-child selector and valid whitespace test fails
        https://bugs.webkit.org/show_bug.cgi?id=36279

        * fast/css/css3-nth-space-expected.txt: Added.
        * fast/css/css3-nth-space.html: Added.
2011-01-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        CSS3 :nth-child selector and valid whitespace test fails
        https://bugs.webkit.org/show_bug.cgi?id=36279

        Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.

        Test: fast/css/css3-nth-space.html

        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed and landed by Anders Carlsson.
andersca@apple.com [Wed, 5 Jan 2011 02:16:39 +0000 (02:16 +0000)]
Reviewed and landed by Anders Carlsson.

Patch by Ivan Krstić <ike@apple.com> on 2011-01-04
<rdar://problem/8602585>
<rdar://problem/8711641>

* WebProcess/com.apple.WebProcess.sb:
Fix a misplaced right parenthesis and add a new system path regex.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Jan 2011 02:13:12 +0000 (02:13 +0000)]
2011-01-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on spelling and grammar
        https://bugs.webkit.org/show_bug.cgi?id=51910

        * Scripts/webkit2/messages.py:
        Add special case for WebCore::TextCheckingResult.

        * Shared/NotImplemented.h:
        Fix macro so that defining DISABLE_NOT_IMPLEMENTED_WARNINGS to 0 will enable the warnings.

        * Shared/WebCoreArgumentCoders.h:
        Add argument coders for WebCore::GrammarDetail and WebCore::TextCheckingResult.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView checkSpelling:]):
        Call advanceToNextMisspelling.

        * UIProcess/TextChecker.h:
        Add new NSSpellChecker wrappers.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize the new member variables.

        (WebKit::WebPageProxy::~WebPageProxy):
        Call TextChecker::closeSpellDocumentWithTag.

        (WebKit::WebPageProxy::advanceToNextMisspelling):
        Send the AdvanceToNextMisspelling message.

        (WebKit::WebPageProxy::spellDocumentTag):
        Create a spell document tag if necessary.

        (WebKit::WebPageProxy::checkTextOfParagraph):
        (WebKit::WebPageProxy::updateSpellingUIWithMisspelledWord):
        (WebKit::WebPageProxy::getGuessesForWord):
        Call the TextChecker.

        * UIProcess/WebPageProxy.messages.in:
        Add new messages.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::uniqueSpellDocumentTag):
        (WebKit::TextChecker::closeSpellDocumentWithTag):
        (WebKit::TextChecker::checkTextOfParagraph):
        (WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
        (WebKit::TextChecker::getGuessesForWord):
        Add NSSpellChecker wrappers.

        * UIProcess/qt/TextCheckerQt.cpp:
        * UIProcess/win/TextCheckerWin.cpp:
        Add stubs.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::isContinuousSpellCheckingEnabled):
        (WebKit::WebEditorClient::isGrammarCheckingEnabled):
        Get the text checking state from the web process.

        (WebKit::WebEditorClient::updateSpellingUIWithMisspelledWord):
        (WebKit::WebEditorClient::getGuessesForWord):
        Proxy calls to the UI process.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):

        (WebKit::WebEditorClient::checkTextOfParagraph):
        Proxy calls to the UI process.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::advanceToNextMisspelling):
        Call the frame.

        * WebProcess/WebPage/WebPage.messages.in:
        Add AdvanceToNextMisspelling message.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initializeWebProcess):
        Set the text checker state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Søren Gjesse <sgjesse@chromium.org>
commit-queue@webkit.org [Wed, 5 Jan 2011 02:09:32 +0000 (02:09 +0000)]
2011-01-04  Søren Gjesse  <sgjesse@chromium.org>

        Reviewed by Tony Chang.

        Change the --multi-load test option to --stress-opt
        https://bugs.webkit.org/show_bug.cgi?id=50751

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (runTest):
        (main):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::stressOpt):
        (TestShell::setStressOpt):
        (TestShell::stressDeopt):
        (TestShell::setStressDeopt):
        (TestShell::javaScriptFlags):
        (TestShell::setJavaScriptFlags):
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 5 Jan 2011 01:45:48 +0000 (01:45 +0000)]
2011-01-04  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed expectations update.

        Fix text metrics for "You should not see this at all" message
        https://bugs.webkit.org/show_bug.cgi?id=51909

        * http/tests/misc/acid3-expected.checksum:
        * http/tests/misc/acid3-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Build fix.
cfleizach@apple.com [Wed, 5 Jan 2011 01:36:57 +0000 (01:36 +0000)]
Unreviewed. Build fix.

WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

WebCore:

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(fallbackObject):

WebKit2:

* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Build fix.
cfleizach@apple.com [Wed, 5 Jan 2011 01:21:51 +0000 (01:21 +0000)]
Unreviewed. Build fix.

WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Wed, 5 Jan 2011 01:14:53 +0000 (01:14 +0000)]
2011-01-04  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] PNG compression settings optimized for speed
        https://bugs.webkit.org/show_bug.cgi?id=51719

        Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
        it is also the slowest, by a wide margin, on easy-to-compress images.
        Use a more balanced configuration, based on the libpng compression defaults,
        but with a faster compression level (3 instead of 6), and a faster filter
        ("sub" instead of "all").

        No change in behaviour, so no new tests.

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWK2: Support Accessibility
cfleizach@apple.com [Wed, 5 Jan 2011 01:07:44 +0000 (01:07 +0000)]
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

Reviewed by Sam Weinig.

Tools:

Use rootObject() method to get top of accessibility tree.

* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):

WebCore:

WK2 doesn't use platform scroll views anymore. Accessibility code
needs to have its own scroll views.

Test: platform/mac/accessibility/webkit-scrollarea.html

* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleScrollbarUpdate):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::handleScrollbarUpdate):
* accessibility/AccessibilityARIAGrid.h:
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityImageMapLink.cpp:
* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityListBoxOption.cpp:
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::focusedUIElement):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityScrollView):
(WebCore::AccessibilityObject::isScrollView):
(WebCore::AccessibilityObject::canSetNumericValue):
(WebCore::AccessibilityObject::scrollBar):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::setValue):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp: Added.
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::create):
(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::children):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::removeChildScrollbar):
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::addChildren):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::document):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::parentObject):
* accessibility/AccessibilityScrollView.h: Added.
(WebCore::AccessibilityScrollView::roleValue):
(WebCore::AccessibilityScrollView::scrollView):
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::isAccessibilityScrollView):
(WebCore::toAccessibilityScrollView):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::document):
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
(WebCore::AccessibilityScrollbar::valueForRange):
(WebCore::AccessibilityScrollbar::setValue):
* accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::setParent):
(WebCore::AccessibilityScrollbar::canSetValueAttribute):
(WebCore::AccessibilityScrollbar::canSetNumericValue):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::parentObject):
(WebCore::AccessibilityScrollbar::roleValue):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper scrollViewParent]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
* dom/Document.cpp:
(WebCore::Document::axObjectCache):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
* loader/FrameLoaderClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::axObjectCache):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::axObjectCache):
* platform/Scrollbar.h:
* platform/Widget.h:
(WebCore::Widget::axObjectCache):

WebKit/gtk:

Use rootObject() method to get top of ax tree.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
* webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible):

WebKit/mac:

Use rootObject() method to get top of AX tree.

* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient::accessibilityRemoteObject):
* WebView/WebFrame.mm:
(-[WebFrame setAccessibleName:]):
(-[WebFrame accessibilityRoot]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView accessibilityFocusedUIElement]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _accessibilityParentForSubview:]):

WebKit/win:

Use rootObject() method to get the top of the AX tree.

* AccessibleDocument.cpp:
(AccessibleDocument::AccessibleDocument):

WebKit2:

Implement remote accessibility API to support cross process accessibility
on the Mac platform.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::accessibilityChildTokenReceived):
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView accessibilityIsIgnored]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
(WebKit::WebPageProxy::sendAccessibilityPresenterToken):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::accessibilityRemoteObject):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::accessibilityPosition):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.
(-[AccessibilityWebPageObject setWebPage:]):
(-[AccessibilityWebPageObject setRemoteParent:]):
(-[AccessibilityWebPageObject dealloc]):
(-[AccessibilityWebPageObject accessibilityIsIgnored]):
(-[AccessibilityWebPageObject accessibilityAttributeNames]):
(-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[AccessibilityWebPageObject accessibilityActionNames]):
(-[AccessibilityWebPageObject accessibilityChildren]):
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):
(-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[AccessibilityWebPageObject accessibilityHitTest:]):
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::sendAccessibilityPresenterToken):
(WebKit::WebPage::accessibilityRemoteObject):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::presenterApplicationPid):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

LayoutTests:

* platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
* platform/mac/accessibility/webkit-scrollarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Wed, 5 Jan 2011 00:53:48 +0000 (00:53 +0000)]
2011-01-04  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add support to compositor to composite to offscreen texture.
        https://bugs.webkit.org/show_bug.cgi?id=50833

        A patch to extend compositor to be able to composite into an offscreen texture instead
        of just directly to the display buffer. Builds on RenderSurfaceChromium support.
        Explicitly resets alpha channel before rendering to display.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::setCompositeOffscreen):
        (WebCore::LayerRendererChromium::useRenderSurface):
        (WebCore::LayerRendererChromium::setScissorToRect):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::isCompositingOffscreen):
        (WebCore::LayerRendererChromium::getOffscreenLayerTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 5 Jan 2011 00:50:30 +0000 (00:50 +0000)]
2011-01-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Add home-end-expected.txt for Chromium-win again.  It's a
        platform-dependent text test.

        * platform/chromium-win/editing/selection/home-end-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 5 Jan 2011 00:23:46 +0000 (00:23 +0000)]
2011-01-04  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        Update README file with a description of the WEBKIT_API macro and
        guidelines for its usage.  Also document the various WEBKIT_USING_*
        macros.

        https://bugs.webkit.org/show_bug.cgi?id=51880

        * README:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 5 Jan 2011 00:17:45 +0000 (00:17 +0000)]
2011-01-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt: Fix a syntax error in the previous change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 5 Jan 2011 00:09:53 +0000 (00:09 +0000)]
2011-01-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium-win/editing/selection/home-end-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 5 Jan 2011 00:06:26 +0000 (00:06 +0000)]
2011-01-04  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] depend on harfbuzz explicitly
        https://bugs.webkit.org/show_bug.cgi?id=51895

        platform/graphics/chromium uses Harfbuzz directly.  Rather than
        expecting Skia to adjust the include paths, be explicit about
        the dependency.

        * WebCore.gyp/WebCore.gyp:
2011-01-04  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] depend on harfbuzz explicitly
        https://bugs.webkit.org/show_bug.cgi?id=51895

        Update Chromium DEPS to pick up newer Chromium version
        that simplifies expressing the Harfbuzz dependency.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of an extra copy in the back/forward item IPC message by using a DataReference.
beidson@apple.com [Tue, 4 Jan 2011 23:57:08 +0000 (23:57 +0000)]
Get rid of an extra copy in the back/forward item IPC message by using a DataReference.

Reviewed by Darin Adler.

* UIProcess/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setBackForwardData):
* UIProcess/WebBackForwardListItem.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dataCallback): Get rid of no-longer-needed check for size 0.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
* UIProcess/WebProcessProxy.h:

* UIProcess/WebProcessProxy.messages.in:

* WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::data):
* WebProcess/WebPage/EncoderAdapter.h:

* WebProcess/WebPage/WebBackForwardListProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStore more data per history entry in the session state blob.
beidson@apple.com [Tue, 4 Jan 2011 23:35:06 +0000 (23:35 +0000)]
Store more data per history entry in the session state blob.

Reviewed by Darin Adler.

* UIProcess/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
* UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

* UIProcess/cf/WebPageProxyCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Jan 2011 23:28:59 +0000 (23:28 +0000)]
2011-01-04  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        Add back/forward encoding and decoding to WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51901

        * WebCore.exp.in: Export functions used in WebKit2.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers.
        (WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto.
        (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
        * history/HistoryItem.h: Ditto.
        * platform/network/FormData.cpp:
        (WebCore::encode): Ditto.
        (WebCore::decode): Ditto.
        (WebCore::FormData::encodeForBackForward): Ditto.
        (WebCore::FormData::decodeForBackForward): Ditto.
        * platform/network/FormData.h: Ditto.
2011-01-04  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        Add back/forward encoding and decoding to WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51901

        * GNUmakefile.am: Added new source files.
        * WebKit2.pro: Ditto.
        * WebKit2.xcodeproj/project.pbxproj: Ditto.
        * win/WebKit2.vcproj: Ditto.

        * WebProcess/WebPage/DecoderAdapter.cpp: Added.
        * WebProcess/WebPage/DecoderAdapter.h: Added.
        * WebProcess/WebPage/EncoderAdapter.cpp: Added.
        * WebProcess/WebPage/EncoderAdapter.h: Added.

        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::updateBackForwardItem): Added code to encode the back/forward
        tree and send it along. The code to decode needs to wait on Brady's
        current project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 4 Jan 2011 23:17:18 +0000 (23:17 +0000)]
2011-01-04  Daniel Bates  <dbates@rim.com>

        Fix the Android build after changeset 74975 <http://trac.webkit.org/changeset/74975>
        (https://bugs.webkit.org/show_bug.cgi?id=51855).

        * wtf/ThreadingPthreads.cpp: Add include of PassOwnPtr.h.
        (WTF::runThreadWithRegistration): Use -> instead of . to dereference pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 4 Jan 2011 23:05:18 +0000 (23:05 +0000)]
2011-01-04  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Implement sel.modify('move', 'left'/'right', 'lineBoundary').
        https://bugs.webkit.org/show_bug.cgi?id=33435

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyMovingRight):
        (WebCore::SelectionController::modifyMovingLeft):
        * editing/visible_units.cpp:
        (WebCore::logicalStartOfLine):
        (WebCore::logicalEndOfLine):
        (WebCore::leftBoundaryOfLine):
        (WebCore::rightBoundaryOfLine):
        * editing/visible_units.h:
2011-01-04  Xiaomei Ji  <xji@chromium.org>

        Implement sel.modify('move', 'left'/'right', 'lineBoundary').
        https://bugs.webkit.org/show_bug.cgi?id=33435

        * editing/selection/home-end-expected.txt:
        * editing/selection/home-end.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 4 Jan 2011 23:04:48 +0000 (23:04 +0000)]
2011-01-04  Martin Robinson  <mrobinson@igalia.com>

        Try to fix the EFL build.

        * wtf/CMakeLists.txt: Remove PlatformRefPtr from the CMake source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 4 Jan 2011 22:58:45 +0000 (22:58 +0000)]
2011-01-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Use the default CSS text input control border width of relying on the GTK+ theme
        https://bugs.webkit.org/show_bug.cgi?id=51887

        Update all results that use text areas. These controls now have a 1 pixel
        border (the default in html.css) instead of using the border size from the
        GTK+ theme.

        * platform/gtk/fast/forms/basic-textareas-expected.txt:
        * platform/gtk/fast/forms/form-element-geometry-expected.txt:
        * platform/gtk/fast/forms/onselect-textarea-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
        * platform/gtk/fast/forms/textarea-align-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
        * platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
        * platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
        * platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
        * platform/gtk/fast/forms/textarea-width-expected.txt:
2011-01-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Use the default CSS text input control border width of relying on the GTK+ theme
        https://bugs.webkit.org/show_bug.cgi?id=51887

        Do not rely on the GTK+ theme to determine text control borders. This simplifies
        the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
        doesn't break the rendering of any theme that I've encountered.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but
        still disable any border radius.
        * platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the
        default style of text areas and text input controls.
        * platform/gtk/RenderThemeGtk2.cpp: Ditto.
        * platform/gtk/RenderThemeGtk3.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8766999> WebKit2: Sandboxing causes certificate error on access to...
andersca@apple.com [Tue, 4 Jan 2011 22:58:08 +0000 (22:58 +0000)]
<rdar://problem/8766999> WebKit2: Sandboxing causes certificate error on access to any HTTPS URL

Reviewed by Sam Weinig.

Allow read access to /Library/Preferences/com.apple.security.plist.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fixes.
andersca@apple.com [Tue, 4 Jan 2011 22:56:06 +0000 (22:56 +0000)]
Build fixes.

* UIProcess/qt/TextCheckerQt.cpp:
* UIProcess/win/TextCheckerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use macros for the key names.
andersca@apple.com [Tue, 4 Jan 2011 22:49:35 +0000 (22:49 +0000)]
Don't use macros for the key names.

Reviewed by Darin Adler.

* UIProcess/mac/TextCheckerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Tue, 4 Jan 2011 22:47:47 +0000 (22:47 +0000)]
2011-01-04  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC)
        https://bugs.webkit.org/show_bug.cgi?id=51881

        The StackBounds class is only used by JavaScriptCore.

        * wtf/WTFThreadData.cpp:
        (WTF::WTFThreadData::WTFThreadData):
        * wtf/WTFThreadData.h:
        (WTF::WTFThreadData::resetCurrentIdentifierTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 4 Jan 2011 22:41:52 +0000 (22:41 +0000)]
2011-01-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Send over text checker state to the web process
        https://bugs.webkit.org/show_bug.cgi?id=51896

        * Platform/CoreIPC/Arguments.h:
        Remove 'const' from the argument, this matches all the other Arguments classes.

        * Shared/TextCheckerState.h: Added.
        New class with text checker state.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        Add textCheckerState.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        (-[WKView toggleContinuousSpellChecking:]):
        (-[WKView toggleGrammarChecking:]):
        (-[WKView toggleAutomaticSpellingCorrection:]):
        Get the needed flags from the text checker state.

        * UIProcess/TextChecker.h:
        Add state() function, remove getters.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::ensureWebProcess):
        Initialize the text checker state.

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::updateTextCheckerState):
        Send the SetTextCheckerState message to the web process.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::initializeState):
        Initialize the state from the user defaults.

        (WebKit::TextChecker::state):
        Return the state.

        (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
        (WebKit::TextChecker::setGrammarCheckingEnabled):
        (WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled):
        Make sure to write the new state.

        * UIProcess/qt/TextCheckerQt.cpp:
        (WebKit::TextChecker::state):
        * UIProcess/win/TextCheckerWin.cpp:
        (WebKit::TextChecker::state):
        Add stubs.

        * WebKit2.xcodeproj/project.pbxproj:
        Add TextCheckerState.h.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        Initialize m_textCheckerState.

        (WebKit::WebProcess::setTextCheckerState):
        Update.

        * WebProcess/WebProcess.messages.in:
        Add SetTextCheckerState message.

        * win/WebKit2.vcproj:
        Add TextCheckerState.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-03 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 4 Jan 2011 22:29:48 +0000 (22:29 +0000)]
2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        * GNUmakefile.am: Remove PlatformRefPtr.h from the sources list.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
        * jit/ExecutableAllocator.h: Change references to PlatformRefPtr to RefPtr.
        (JSC::ExecutableAllocator::cacheFlush): Ditto.
        * wtf/PlatformRefPtr.h: Removed.
        * wtf/RandomNumber.cpp: Change references to PlatformRefPtr to RefPtr.
        (WTF::randomNumber): Ditto.
        * wtf/brew/RefPtrBrew.h: Ditto.
        (WTF::refIfNotNull): Added.
        (WTF::derefIfNotNull): Added.
        * wtf/brew/ShellBrew.h: Change references to PlatformRefPtr to RefPtr.
        (WTF::createRefPtrInstance): Modified to return a RefPtr.
        * wtf/gobject/GRefPtr.cpp:
        (WTF::refGPtr): Moved from PlatformRefPtr here.
        (WTF::derefGPtr): Ditto.
        * wtf/gobject/GRefPtr.h: Ditto.
        (WTF::GRefPtr::GRefPtr): Ditto.
        (WTF::GRefPtr::~GRefPtr): Ditto.
        (WTF::GRefPtr::clear): Ditto.
        (WTF::GRefPtr::isHashTableDeletedValue): Ditto.
        (WTF::GRefPtr::get): Ditto.
        (WTF::GRefPtr::operator*): Ditto.
        (WTF::GRefPtr::operator->): Ditto.
        (WTF::GRefPtr::operator!): Ditto.
        (WTF::GRefPtr::operator UnspecifiedBoolType): Ditto.
        (WTF::GRefPtr::hashTableDeletedValue): Ditto.
        (WTF::::operator): Ditto.
        (WTF::::swap): Ditto.
        (WTF::swap): Ditto.
        (WTF::operator==): Ditto.
        (WTF::operator!=): Ditto.
        (WTF::static_pointer_cast): Ditto.
        (WTF::const_pointer_cast): Ditto.
        (WTF::getPtr): Ditto.
        (WTF::adoptGRef): Ditto.
        (WTF::refGPtr): Ditto.
        (WTF::derefGPtr): Ditto.
2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
        back to GRefPtr.
2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        No new tests. This should not introduce any functional changes.

        Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
        all references to PlatformRefPtr in Brew code to RefPtr.
2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        Changed all references to PlatformRefPtr in GTK+ code to GRefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network
ddkilzer@apple.com [Tue, 4 Jan 2011 22:07:17 +0000 (22:07 +0000)]
<webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network

Reviewed by Antti Koivisto.

This is needed to prevent a WebCore/platform policy violation in
my next patch.

* WebCore.gypi: Updated for moved header.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 4 Jan 2011 22:04:37 +0000 (22:04 +0000)]
2011-01-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by David Levin.

        .gitignore should be updated to reflect Sources rename to Source
        https://bugs.webkit.org/show_bug.cgi?id=51893

        * .gitignore: Change all paths that reference the "Sources" directory to say "Source".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 4 Jan 2011 21:56:05 +0000 (21:56 +0000)]
2011-01-04  Ojan Vafai  <ojan@chromium.org>

        Increment version number to avoid getting the cached JS file.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-15 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 4 Jan 2011 21:52:49 +0000 (21:52 +0000)]
2010-12-15  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height
        https://bugs.webkit.org/show_bug.cgi?id=51162

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* storage/StorageMap.h: mesured? Really?
beidson@apple.com [Tue, 4 Jan 2011 21:35:07 +0000 (21:35 +0000)]
* storage/StorageMap.h: mesured?  Really?

Reviewed by a spell checker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Zhe Su <suzhe@chromium.org>
commit-queue@webkit.org [Tue, 4 Jan 2011 21:27:04 +0000 (21:27 +0000)]
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        1. Remove entry for editing/input/ime-composition-clearpreedit.html test.
        2. Improve fast/events/ime-composition-events-001.html to cover more
           cases. And fix test expectations of chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=51693

        * fast/events/ime-composition-events-001-expected.txt:
        * fast/events/ime-composition-events-001.html:
        * platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
        * platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
        * platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Fix insertText, setMarkedText and unmarkText methods of
        TextInputController to call corresponding methods of WebKit::WebView
        rather than WebKit::WebFrame. This change matches the behavior of
        chromium browser.
        insertText corresponds to WebView::confirmComposition(text)
        setMarkedText corresponds to WebView::setComposition(...)
        unmarkText corresponds to WebView::confirmComposition()
        https://bugs.webkit.org/show_bug.cgi?id=51693

        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::insertText):
        (TextInputController::setMarkedText):
        (TextInputController::unmarkText):
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Changes:
        1. Add WebKit::WebWidget::confirmComposition(const WebString& text)
           This new method corresponds to Editor::confirmComposition(text) and
           Editor::insertText(text). It'll be used by both DumpRenderTree's
           TextInputController and chromium browser.
        2. Fix WebFrameImpl::insertText
           It should call Editor::confirmComposition(text) rather than
           Editor::insertText(text) if there is an ongoing composition.
           It matches the behavior of WebKit Mac port.
        3. Fix WebFrameImpl::setMarkedText
           Editor::confirmComposition(text) shouldn't be called in this
           method, which incorrectly inserts the text.

        https://bugs.webkit.org/show_bug.cgi?id=51693

        * public/WebWidget.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::insertText):
        (WebKit::WebFrameImpl::setMarkedText):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::confirmComposition):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::confirmComposition):
        * src/WebViewImpl.h:
        * tests/PopupMenuTest.cpp:
        (WebKit::TestWebWidget::confirmComposition):
2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Fix test LayoutTests/fast/events/ime-composition-events-001.html.

        https://bugs.webkit.org/show_bug.cgi?id=51693

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to
        insert the commit string when no composition text is available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttach a radar # to this FIXME:
beidson@apple.com [Tue, 4 Jan 2011 21:23:20 +0000 (21:23 +0000)]
Attach a radar # to this FIXME:
* WebProcess/WebPage/WebBackForwardListProxy.cpp:

Rubberstamped by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 4 Jan 2011 21:12:53 +0000 (21:12 +0000)]
2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [Symbian] Build system cleanup

        After r74811 special handling for the Symbian build is no longer needed.
        This patch reverts r58756.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinso...
commit-queue@webkit.org [Tue, 4 Jan 2011 21:09:23 +0000 (21:09 +0000)]
2011-01-04  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Port stock icon painting to GtkStyleContext
        https://bugs.webkit.org/show_bug.cgi?id=51764

        Port stock icon painting for media and search input elements to
        GtkStyleContext. Also create the initial machinery for accessing
        style contexts for all GTK+ 3.x based widgets.

        No new tests. This should not change functionality.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintGdkPixbuf):
        (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
        (WebCore::RenderThemeGtk::paintMediaButton):
        * platform/gtk/RenderThemeGtk.h:
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::getStockIcon):
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::gtkStyleChangedCallback):
        (WebCore::styleContextMap):
        (WebCore::getStyleContext):
        (WebCore::RenderThemeGtk::paintMenuList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin()...
ddkilzer@apple.com [Tue, 4 Jan 2011 20:47:06 +0000 (20:47 +0000)]
<webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name

Reviewed by Eric Carlson.

This originally broke in r61581.  It is inside an
ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
build then.

* WebCoreSupport/WebFrameLoaderClient.mm: Call
(WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
use WebCore::PluginInfo.name instead of
-[WebBasePluginPackage name].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Scripts should not be executed before preceding stylesheets are loaded
antti@apple.com [Tue, 4 Jan 2011 20:46:01 +0000 (20:46 +0000)]
WebCore: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852

Reviewed by Dave Hyatt.

Block inline script execution on pending stylesheet loads. This matches
other browsers and HTML5.

Tests: fast/tokenizer/inline-script-stylesheet-write.html
       fast/tokenizer/inline-script-stylesheet.html

* dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
* dom/PendingScript.h:
(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):

This fixes an unrelated bug with beforeload events that was exposed by the other
changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).

* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::sourceFromPendingScript):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852

Reviewed by Dave Hyatt.

New tests plus a few test with slightly changed output due to different load serialization behavior.

* fast/tokenizer/inline-script-stylesheet-expected.txt: Added.
* fast/tokenizer/inline-script-stylesheet-write-expected.txt: Added.
* fast/tokenizer/inline-script-stylesheet-write.html: Added.
* fast/tokenizer/inline-script-stylesheet.html: Added.
* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Xianzhu Wang <wangxianzhu@google.com>
commit-queue@webkit.org [Tue, 4 Jan 2011 20:43:52 +0000 (20:43 +0000)]
2011-01-04  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Darin Adler.

        Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
        ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
        on ARM.
        https://bugs.webkit.org/show_bug.cgi?id=51861

        By the way, changed other getIntXX() and setIntXX() methods to use
        more precise integer types.

        * bindings/js/JSDataViewCustom.cpp:
        (WebCore::setDataViewMember):
        * bindings/v8/custom/V8DataViewCustom.cpp:
        (WebCore::V8DataView::getInt8Callback):
        (WebCore::V8DataView::setInt8Callback):
        * html/canvas/DataView.cpp:
        (WebCore::DataView::getInt8):
        (WebCore::DataView::setInt8):
        * html/canvas/DataView.h:
        * html/canvas/DataView.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed trivial fix after r74976.
ossy@webkit.org [Tue, 4 Jan 2011 20:34:49 +0000 (20:34 +0000)]
Unreviewed trivial fix after r74976.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Tue, 4 Jan 2011 20:20:29 +0000 (20:20 +0000)]
2011-01-04  Yong Li  <yoli@rim.com>

        Reviewed by Adam Barth.

        Suspend HTMLParserScheduler when page load is deferred to
        avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
        from an external script or by events, and is blocked by a modal dialog,
        WebKit can parse more HTML source and also start another JS execution.

        https://bugs.webkit.org/show_bug.cgi?id=48077

        Test case: WebCore/manual-tests/bugzilla-48077.html.

        * dom/DocumentParser.cpp:
        (WebCore::DocumentParser::suspendScheduledTasks):
        (WebCore::DocumentParser::resumeScheduledTasks):
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::suspendScheduledTasks):
        (WebCore::HTMLDocumentParser::resumeScheduledTasks):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        (WebCore::HTMLParserScheduler::suspend):
        (WebCore::HTMLParserScheduler::resume):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 4 Jan 2011 19:49:18 +0000 (19:49 +0000)]
2011-01-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Add more spelling/grammar related methods
        https://bugs.webkit.org/show_bug.cgi?id=51886

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle more selectors.

        (-[WKView showGuessPanel:]):
        Add stub.

        (-[WKView checkSpelling:]):
        Ditto.

        (-[WKView toggleAutomaticSpellingCorrection:]):
        Toggle automatic spelling correction.

        * UIProcess/TextChecker.h:
        Add setAutomaticSpellingCorrectionEnabled and isAutomaticSpellingCorrectionEnabled.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled):
        (WebKit::TextChecker::isAutomaticSpellingCorrectionEnabled):
        Update the toggle.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
        Add a Radar URL for the localization FIXMEs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
bfulgham@webkit.org [Tue, 4 Jan 2011 19:40:29 +0000 (19:40 +0000)]
Unreviewed build fix.

* win/WebKit2.vcproj: Correct the missing $(WebKitVSPropsRedirectionDir)
variables that Visual Studio helpfully removes when making changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 4 Jan 2011 19:33:02 +0000 (19:33 +0000)]
2011-01-04  Daniel Bates  <dbates@rim.com>

        Fix the date recorded in the change log entry for changeset 74973 <http://trac.webkit.org/changeset/74973>.
        It was recorded as "2011-01-03". Instead, it should be "2011-01-04" to correspond
        with the date this changeset was committed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 4 Jan 2011 19:29:19 +0000 (19:29 +0000)]
2011-01-04  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails
        https://bugs.webkit.org/show_bug.cgi?id=51860

        * wtf/ThreadingWin.cpp:
        (WTF::createThreadInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
bfulgham@webkit.org [Tue, 4 Jan 2011 19:21:44 +0000 (19:21 +0000)]
Unreviewed build fix.

* win/WebKit2.vcproj: Disable CG-specific WKImageCG.cpp from
Debug_Cairo_CFLite/Release_Cario_CFLite builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 4 Jan 2011 19:16:38 +0000 (19:16 +0000)]
2011-01-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31273

        On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
        are included before platform headers. On all other platforms continue to use
        INCLUDEPATH (as before). This is a continuation of r65877.

        No new tests as there is no new functionality.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
darin@apple.com [Tue, 4 Jan 2011 19:11:22 +0000 (19:11 +0000)]
Try to fix Windows build.

* wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing
of conditional includes.
(WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer.
(WTF::createThreadInternal): Tweaked #if to not need separate macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 4 Jan 2011 19:04:07 +0000 (19:04 +0000)]
2011-01-04  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Added editing/selection/caret-bidi-first-and-last-letters.html to Qt's skipped list.
        The tracking bug 51884 (https://bugs.webkit.org/show_bug.cgi?id=51884) has been filed.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 4 Jan 2011 18:56:18 +0000 (18:56 +0000)]
2011-01-04  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android
        https://bugs.webkit.org/show_bug.cgi?id=51855

        Both the Apple Windows and Android ports implement a similar adapter structure,
        called ThreadFunctionInvocation and ThreadData respectively, as part of
        their thread creation process. Instead, we should share such an adapter
        structure and remove duplicate code.

        * JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h.
        * wtf/ThreadFunctionInvocation.h: Added.
        (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):
        * wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation.
        (WTF::runThreadWithRegistration):
        (WTF::createThreadInternal):
        * wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that
        it can be shared with the Android implementation of createThreadInternal().
        (WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 4 Jan 2011 18:53:35 +0000 (18:53 +0000)]
2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [Symbian] Do not remove 0 byte sized files from productDir

        On Symbian productDir points to the source directory. Removing all the
        empty files from the productDir directory corrupts the svn repository.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-03 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 4 Jan 2011 17:44:12 +0000 (17:44 +0000)]
2011-01-03  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Use __builtin_expect when compiling using RVCT in GNU mode
        https://bugs.webkit.org/show_bug.cgi?id=51866

        Derived from a patch by Dave Tapuska.

        * wtf/AlwaysInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-04 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 4 Jan 2011 17:29:48 +0000 (17:29 +0000)]
2011-01-04  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Include glib-object.h for GObject
        https://bugs.webkit.org/show_bug.cgi?id=51876

        * bindings/gobject/DOMObjectCache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74972 268f45cc-cd09-0410-ab3c-d52691b4dbfc