WebKit-https.git
8 years ago2011-04-28 Dominic Cooney <dominicc@chromium.org>
dglazkov@chromium.org [Thu, 28 Apr 2011 18:43:54 +0000 (18:43 +0000)]
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Geoffrey Garen.

        Walk shadow hosts as well as parent nodes when finding opaque roots.
        https://bugs.webkit.org/show_bug.cgi?id=59571

        Remove expectation of failure.

        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Removed.
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Geoffrey Garen.

        Walk shadow hosts as well as parent nodes when finding opaque roots.
        https://bugs.webkit.org/show_bug.cgi?id=59571

        Test: fast/dom/shadow/gc-shadow.html

        * bindings/js/JSDOMBinding.h:
        (WebCore::root):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 28 Apr 2011 18:39:20 +0000 (18:39 +0000)]
2011-04-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Added the test results, missed in r85209.

        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 28 Apr 2011 18:37:33 +0000 (18:37 +0000)]
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
        into WebCore so that WebKit1 and WebKit2 can share the code.

        No new tests. This is covered by fast/events/click-count.html.

        * GNUmakefile.list.am: Added new files.
        * platform/gtk/GtkClickCounter.cpp: Added.
        (WebCore::GtkClickCounter::GtkClickCounter): Added.
        (WebCore::GtkClickCounter::reset): Added.
        (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
        (WebCore::getEventTime): Added.
        (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
        * platform/gtk/GtkClickCounter.h: Added.
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Switch WebKit1 to use the new GtkClickCounter for counting > 3 clicks in a row.
        This allows the code to be shared between WebKit1 and WebKit2.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Call GtkClickCounter::reset instead of fiddling
        the WebView private data directly.
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Ditto.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Call into GtkClickCounter now.
        (webkit_web_view_init): Remove private member intialization.
        * webkit/webkitwebviewprivate.h: Remove unneeded private members.
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Use the GtkClickCounter instead of doing click counting manually. This means that
        the code will now be shared between WebKit1 and WebKit2.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkit_web_view_base_init): Remove private member initialization.
        (webViewButtonPressEvent): Call into GtkClickCounter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
mitz@apple.com [Thu, 28 Apr 2011 18:13:21 +0000 (18:13 +0000)]
Build fix.

* css/CSSParser.cpp:
(WebCore::cssPropertyID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow specifying CSS property aliases in CSSPropertyNames.in files
mitz@apple.com [Thu, 28 Apr 2011 18:08:39 +0000 (18:08 +0000)]
Allow specifying CSS property aliases in CSSPropertyNames.in files
https://bugs.webkit.org/show_bug.cgi?id=59712

Reviewed by Simon Fraser.

* css/CSSParser.cpp:
(WebCore::cssPropertyID): Removed code to handle some aliases
* css/CSSPropertyNames.in: Added aliases no longer handled in code.
* css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
defining an alias, and add an appropriate entry to the gperf file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 28 Apr 2011 17:57:30 +0000 (17:57 +0000)]
2011-04-28  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Brian Weinstein.

        Push canvas tests' expected results down from platform/mac and into platform/mac-snowleopard
        https://bugs.webkit.org/show_bug.cgi?id=59654

        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 17:55:03 +0000 (17:55 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        link to tests at a specific revision in the results.html file
        https://bugs.webkit.org/show_bug.cgi?id=59711

        This matches old-run-webkit-tests.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:
        * fast/harness/results.html:
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        link to tests at a specific revision in the results.html file
        https://bugs.webkit.org/show_bug.cgi?id=59711

        * Scripts/webkitpy/common/checkout/scm.py:
        Add a method to get the head svn revision.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        Include the svn revision in the results json.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Dominic Cooney <dominicc@chromium.org>
dglazkov@chromium.org [Thu, 28 Apr 2011 17:52:15 +0000 (17:52 +0000)]
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Unskip fast/dom/shadow/gc-shadow.html on Mac with expected failure
        https://bugs.webkit.org/show_bug.cgi?id=59647

        * fast/dom/shadow/gc-shadow.html: Actually GC the shadow roots now.
        * fast/dom/shadow/gc-shadow-expected.txt: Updated.
        * platform/mac/Skipped: Unskip gc-shadow.html.
        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 28 Apr 2011 17:49:31 +0000 (17:49 +0000)]
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Build fix after r85197.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webViewExpose): Use cr.get() here.
        (webViewDraw): Small clean up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Arno Renevier <arno@renevier.net>
commit-queue@webkit.org [Thu, 28 Apr 2011 17:49:20 +0000 (17:49 +0000)]
2011-04-28  Arno Renevier  <arno@renevier.net>

        Reviewed by Gustavo Noronha Silva.

        [Soup] does not load css stylesheets without content-type
        https://bugs.webkit.org/show_bug.cgi?id=59697

        * platform/gtk/Skipped: Enable now passing tests:
         - http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html
         - http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
2011-04-28  Arno Renevier  <arno@renevier.net>

        Reviewed by Gustavo Noronha Silva.

        [Soup] does not load css stylesheets without content-type
        https://bugs.webkit.org/show_bug.cgi?id=59697

        When sniffing content type, do not replace http Content-Type header in
        soup message anymore, but keep sniffed content type in a separate
        variable.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::contentSniffedCallback):
        * platform/network/soup/ResourceResponse.h:
        (WebCore::ResourceResponse::sniffedContentType):
        (WebCore::ResourceResponse::setSniffedContentType):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Thu, 28 Apr 2011 17:40:10 +0000 (17:40 +0000)]
2011-04-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
        https://bugs.webkit.org/show_bug.cgi?id=59704

        No new tests, just code cleanup.

        * WebCore.pri:
2011-04-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
        https://bugs.webkit.org/show_bug.cgi?id=59704

        * WebCoreSupport/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopup::show):
        * WebCoreSupport/QtFallbackWebPopup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate expected results for a hyphenation test
aroben@apple.com [Thu, 28 Apr 2011 17:31:13 +0000 (17:31 +0000)]
Update expected results for a hyphenation test

* platform/mac/fast/text/hyphenate-limit-before-after-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 28 Apr 2011 17:20:47 +0000 (17:20 +0000)]
2011-04-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove "Pretty print" source frame context menu item.
        https://bugs.webkit.org/show_bug.cgi?id=59709

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd failing test to Leopard skipped list.
weinig@apple.com [Thu, 28 Apr 2011 17:14:09 +0000 (17:14 +0000)]
Add failing test to Leopard skipped list.
Will track using https://bugs.webkit.org/show_bug.cgi?id=51807

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip another crashing shadow DOM test
aroben@apple.com [Thu, 28 Apr 2011 17:07:57 +0000 (17:07 +0000)]
Skip another crashing shadow DOM test

<http://webkit.org/b/59708> tracks the failure. Maybe it will eventually be duped to
<http://webkit.org/b/59571>.

* platform/mac/Skipped: Added fast/dom/shadow/nodetype.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 17:01:31 +0000 (17:01 +0000)]
2011-04-28  Leon Scroggins  <scroggo@google.com>

        Reviewed by Steve Block.

        Rebaseline tests which look different due to a change in skia gradient calculations.
        https://bugs.webkit.org/show_bug.cgi?id=59132

        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
        * platform/chromium-linux/fast/gradients/background-clipped-expected.png:
        * platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
        * platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
        * platform/chromium-linux/fast/gradients/radial-centered-expected.png:
        * platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
        * platform/chromium-win/fast/gradients/background-clipped-expected.png:
        * platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
        * platform/chromium-win/fast/gradients/generated-gradients-expected.png:
        * platform/chromium-win/fast/gradients/radial-centered-expected.png:
        * platform/chromium-win/fast/gradients/simple-gradients-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:56:55 +0000 (16:56 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Sam Weinig.

        [GTK] Remove WKURLCreateWithURL()
        https://bugs.webkit.org/show_bug.cgi?id=59691

        The name is a bit confusing and there's already
        WKURLCreateWithUTF8CString() in the C API.

        * UIProcess/API/C/gtk/WKView.cpp:
        * UIProcess/API/C/gtk/WKView.h:
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Sam Weinig.

        [GTK] Remove WKURLCreateWithURL()
        https://bugs.webkit.org/show_bug.cgi?id=59691

        Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().

        * MiniBrowser/gtk/main.c:
        (activateUriEntryCallback):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:53:04 +0000 (16:53 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make WebKitWebViewBase public in the API
        https://bugs.webkit.org/show_bug.cgi?id=59689

        Add WebKitWebViewBasePrivate.h and move WebKitWebViewBase inernal
        methods to it. Rename get_type() method, since it's part of the
        public API and should follow gtk coding style.

        * GNUmakefile.am: Add WebKitWebViewBasePrivate.h.
        * UIProcess/API/C/gtk/WKView.cpp: Use WebKitWebViewBasePrivate.h.
        * UIProcess/API/gtk/PageClientImpl.cpp: Ditto.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseFinalize):
        (webkit_web_view_base_init):
        (webViewSizeAllocate):
        (webViewFocusInEvent):
        (webViewFocusOutEvent):
        (webViewKeyPressEvent):
        (webViewKeyReleaseEvent):
        (webkit_web_view_base_class_init):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Copied from Source/WebKit2/UIProcess/API/C/gtk/WKView.cpp.
        * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Use WebKitWebViewBasePrivate.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:48:46 +0000 (16:48 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Move WebView to UIProcess/API/gtk
        https://bugs.webkit.org/show_bug.cgi?id=59686

        And rename it as PageClientImpl, since it's a page client
        implementation, not a web view.

        * GNUmakefile.am:
        * UIProcess/API/C/gtk/WKView.cpp:
        * UIProcess/API/gtk/PageClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebView.cpp.
        (WebKit::backspaceCallback):
        (WebKit::selectAllCallback):
        (WebKit::cutClipboardCallback):
        (WebKit::copyClipboardCallback):
        (WebKit::pasteClipboardCallback):
        (WebKit::toggleOverwriteCallback):
        (WebKit::popupMenuCallback):
        (WebKit::showHelpCallback):
        (WebKit::deleteFromCursorCallback):
        (WebKit::moveCursorCallback):
        (WebKit::PageClientImpl::PageClientImpl):
        (WebKit::PageClientImpl::~PageClientImpl):
        (WebKit::PageClientImpl::getEditorCommandsForKeyEvent):
        (WebKit::PageClientImpl::createDrawingAreaProxy):
        (WebKit::PageClientImpl::setViewNeedsDisplay):
        (WebKit::PageClientImpl::displayView):
        (WebKit::PageClientImpl::scrollView):
        (WebKit::PageClientImpl::viewSize):
        (WebKit::PageClientImpl::isViewWindowActive):
        (WebKit::PageClientImpl::isViewFocused):
        (WebKit::PageClientImpl::isViewVisible):
        (WebKit::PageClientImpl::isViewInWindow):
        (WebKit::PageClientImpl::PageClientImpl::processDidCrash):
        (WebKit::PageClientImpl::didRelaunchProcess):
        (WebKit::PageClientImpl::takeFocus):
        (WebKit::PageClientImpl::toolTipChanged):
        (WebKit::PageClientImpl::setCursor):
        (WebKit::PageClientImpl::setViewportArguments):
        (WebKit::PageClientImpl::registerEditCommand):
        (WebKit::PageClientImpl::clearAllEditCommands):
        (WebKit::PageClientImpl::canUndoRedo):
        (WebKit::PageClientImpl::executeUndoRedo):
        (WebKit::PageClientImpl::convertToDeviceSpace):
        (WebKit::PageClientImpl::convertToUserSpace):
        (WebKit::PageClientImpl::windowToScreen):
        (WebKit::PageClientImpl::doneWithKeyEvent):
        (WebKit::PageClientImpl::didNotHandleKeyEvent):
        (WebKit::PageClientImpl::createPopupMenuProxy):
        (WebKit::PageClientImpl::createContextMenuProxy):
        (WebKit::PageClientImpl::setFindIndicator):
        (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing):
        (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
        (WebKit::PageClientImpl::didCommitLoadForMainFrame):
        (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
        (WebKit::PageClientImpl::customRepresentationZoomFactor):
        (WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
        (WebKit::PageClientImpl::pageClosed):
        (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
        (WebKit::PageClientImpl::flashBackingStoreUpdates):
        (WebKit::PageClientImpl::findStringInCustomRepresentation):
        (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
        * UIProcess/API/gtk/PageClientImpl.h: Renamed from Source/WebKit2/UIProcess/gtk/WebView.h.
        (WebKit::PageClientImpl::create):
        (WebKit::PageClientImpl::addPendingEditorCommand):
        (WebKit::PageClientImpl::userSpaceScaleFactor):
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseInit):
        (webkitWebViewBaseCreate):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:44:34 +0000 (16:44 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use the WebPage object in WebKitWebViewBase
        https://bugs.webkit.org/show_bug.cgi?id=59683

        It simplifies the implementation of the event callbacks. Remove
        also all the methods from the page client that are no longer
        needed.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseInit):
        (webViewExpose):
        (webViewDraw):
        (webViewSizeAllocate):
        (webViewFocusInEvent):
        (webViewFocusOutEvent):
        (webViewKeyPressEvent):
        (webViewKeyReleaseEvent):
        (webViewButtonPressEvent):
        (webViewButtonReleaseEvent):
        (webViewScrollEvent):
        (webViewMotionNotifyEvent):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::WebView):
        (WebKit::WebView::createDrawingAreaProxy):
        * UIProcess/gtk/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:39:18 +0000 (16:39 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Create the page client in the view widget
        https://bugs.webkit.org/show_bug.cgi?id=59679

        * UIProcess/API/C/gtk/WKView.cpp:
        (WKViewCreate): Simply create a new view widget and return it.
        (WKViewGetPage): Use webkitWebViewBaseGetPage().
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseFinalize): Use finalize instead of dispose to
        make sure it's called only once, and release the private struct too.
        (webkitWebViewBaseInit): Create the page client.
        (webkitWebViewBaseClassInit): Don't use GObject private data structure.
        (webkitWebViewBaseCreate): New method to create a
        WebKitWebViewBase for a given context and page group.
        (webkitWebViewBaseGetWebViewInstance):
        (webkitWebViewBaseGetPage):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::page): Get the page from the view widget.
        (WebKit::WebView::handleFocusInEvent): Ditto.
        (WebKit::WebView::handleFocusOutEvent): Ditto.
        (WebKit::WebView::WebView): Page client is now created with a view widget.
        (WebKit::WebView::paint): Get the page from the view widget.
        (WebKit::WebView::setSize): Ditto.
        (WebKit::WebView::handleKeyboardEvent): Ditto.
        (WebKit::WebView::handleMouseEvent): Ditto.
        (WebKit::WebView::handleWheelEvent): Ditto.
        (WebKit::WebView::close): Ditto.
        (WebKit::WebView::createDrawingAreaProxy): Ditto.
        * UIProcess/gtk/WebView.h:
        (WebKit::WebView::create): The page client will be created as
        private by the view widget, so it doesn't need to be ref counted,
        use PassOwnPtr instead of PassRefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time...
ddkilzer@apple.com [Thu, 28 Apr 2011 16:38:55 +0000 (16:38 +0000)]
<webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called

Reviewed by Simon Fraser.

* wtf/mac/MainThreadMac.mm:
(WTF::postTimer): Use RetainPtr to plug the leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 28 Apr 2011 16:37:26 +0000 (16:37 +0000)]
2011-04-28  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: skipping new inspector tests on Mac while I'm looking into it.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:32:35 +0000 (16:32 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] PlatformWebView should be the view widget
        https://bugs.webkit.org/show_bug.cgi?id=59676

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseGetPage): Return the page of the view.
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h: Map PlatformWebView
        to WebKitWebViewBase instead of the page client.
        * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::page): Use the view widget
        directly.
        (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): Ditto.
        (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Ditto.
        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::createDrawingAreaProxy): Pass the view widget to
        the DrawingAreaProxy constructor instead of the page client.
        * UIProcess/gtk/WebView.h: Remove getWebViewWindow() which is no
        longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:28:49 +0000 (16:28 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] WKView should be a GtkWidget
        https://bugs.webkit.org/show_bug.cgi?id=59603

        * UIProcess/API/C/gtk/WKAPICastGtk.h: Map WKViewRef to
        WebKitWebViewBase instead of WebView.
        * UIProcess/API/C/gtk/WKView.h: Remove WKViewGetWindow().
        * UIProcess/API/C/gtk/WKView.cpp:
        (WKViewCreate): Return the view instead of the page client.
        (WKViewGetPage): Use WebKitWebViewBase API to get the page client
        containing the page.
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] WKView should be a GtkWidget
        https://bugs.webkit.org/show_bug.cgi?id=59603

        Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.

        * MiniBrowser/gtk/main.c:
        (createWindow):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Satish Sampath <satish@chromium.org>
pfeldman@chromium.org [Thu, 28 Apr 2011 16:18:49 +0000 (16:18 +0000)]
2011-04-28  Satish Sampath  <satish@chromium.org>

        Reviewed by Tony Gentilcore.

        Speech input button layout issues with padding and border.
        https://bugs.webkit.org/show_bug.cgi?id=59613

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        (WebCore::RenderTextControlSingleLine::forwardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Satish Sampath <satish@chromium.org>
satish@chromium.org [Thu, 28 Apr 2011 16:12:14 +0000 (16:12 +0000)]
2011-04-28  Satish Sampath  <satish@chromium.org>

        Reviewed by Tony Gentilcore.

        Speech input button layout issues with padding and border.
        https://bugs.webkit.org/show_bug.cgi?id=59613

        * fast/speech/input-text-speechbutton-expected.txt:
        * fast/speech/input-text-speechbutton.html: Updated to test with padding.
2011-04-28  Satish Sampath  <satish@chromium.org>

        Reviewed by Tony Gentilcore.

        Speech input button layout issues with padding and border.
        https://bugs.webkit.org/show_bug.cgi?id=59613

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        (WebCore::RenderTextControlSingleLine::forwardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 28 Apr 2011 16:07:15 +0000 (16:07 +0000)]
2011-04-27  Sam Weinig  <sam@webkit.org>

        Reviewed by David Kilzer.

        Add way to install testapi in production builds
        https://bugs.webkit.org/show_bug.cgi?id=59674

        * Configurations/TestAPI.xcconfig: Copied from Configurations/JavaScriptCore.xcconfig.
        Add configuration file for TestAPI. In addition to name, we now specify an install path
        and allow SKIP_INSTALL to be overridden by setting FORCE_TOOL_INSTALL.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        Remove in-project build settings and add missing configuration files. Added missing CompilerVersion.xcconfig
        file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:04:08 +0000 (16:04 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Check whether to use native scrollbars at run time
        https://bugs.webkit.org/show_bug.cgi?id=59694

        It's currently decided at build time depending on whether webkit2
        build is enabled or not. That makes imposible to build both
        webkit1 and webkit2 using the same libWebCore.

        * GNUmakefile.am:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::createScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed. Add new expected results for GTK platform.
cfleizach@apple.com [Thu, 28 Apr 2011 15:56:14 +0000 (15:56 +0000)]
Not reviewed. Add new expected results for GTK platform.

ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648

* platform/gtk/accessibility/aria-fallback-roles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 28 Apr 2011 15:45:33 +0000 (15:45 +0000)]
2011-04-28  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: unflake new inspector tests.

        * http/tests/inspector/resource-tree/resource-tree-reload.html:
        * http/tests/inspector/resource-tree/resource-tree-test.js:
        (initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoaccessibility/aria-fallback-roles.html failing on Windows since introduction in r85157.
jberlin@webkit.org [Thu, 28 Apr 2011 15:38:18 +0000 (15:38 +0000)]
accessibility/aria-fallback-roles.html failing on Windows since introduction in r85157.
https://bugs.webkit.org/show_bug.cgi?id=59701

Add Windows-specific results to get the bots green.

* platform/win/accessibility/aria-fallback-roles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 28 Apr 2011 15:08:24 +0000 (15:08 +0000)]
2011-04-28  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add ResourceTreeModel tests.
        https://bugs.webkit.org/show_bug.cgi?id=59616

        * http/tests/inspector/resource-tree-model-expected.txt: Removed.
        * http/tests/inspector/resource-tree-model.html: Removed.
        * http/tests/inspector/resource-tree/resource-tree-document-url-expected.txt: Added.
        * http/tests/inspector/resource-tree/resource-tree-document-url.html: Added.
        * http/tests/inspector/resource-tree/resource-tree-frame-navigate-expected.txt: Added.
        * http/tests/inspector/resource-tree/resource-tree-frame-navigate.html: Added.
        * http/tests/inspector/resource-tree/resource-tree-reload-expected.txt: Added.
        * http/tests/inspector/resource-tree/resource-tree-reload.html: Added.
        * http/tests/inspector/resource-tree/resource-tree-test.js: Added.
        (initialize_ResourceTreeTest.InspectorTest.dumpResources):
        (initialize_ResourceTreeTest.InspectorTest.dumpResources.comparator):
        (initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap):
        (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
        (initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreLoaded.callbackWrapper):
        (initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreLoaded):
        (initialize_ResourceTreeTest.InspectorTest.dumpResourceTreeEverything):
        (initialize_ResourceTreeTest):
        * http/tests/inspector/resource-tree/resources/dummy-iframe.html: Added.
        * http/tests/inspector/resource-tree/resources/resource-tree-frame-navigate-iframe-after.html: Added.
        * http/tests/inspector/resource-tree/resources/resource-tree-frame-navigate-iframe-before.html: Added.
        * http/tests/inspector/resource-tree/resources/resource-tree-reload-iframe.html: Added.
        * http/tests/inspector/resource-tree/resources/script-initial.js: Added.
        (foo):
        * http/tests/inspector/resource-tree/resources/script-navigated.js: Added.
        (foo):
        * http/tests/inspector/resource-tree/resources/styles-initial-2.css: Added.
        (html):
        * http/tests/inspector/resource-tree/resources/styles-initial.css: Added.
        (html):
        * http/tests/inspector/resource-tree/resources/styles-navigated.css: Added.
        (html):
        * platform/win/Skipped:
2011-04-28  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add ResourceTreeModel tests.
        https://bugs.webkit.org/show_bug.cgi?id=59616

        Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
               http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
               http/tests/inspector/resource-tree/resource-tree-reload.html

        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype.frontendReused):
        (WebInspector.ResourceTreeModel.prototype._addFrame):
        (WebInspector.ResourceTreeModel.prototype._frameNavigated):
        (WebInspector.ResourceTreeModel.prototype._frameDetached):
        (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
        (WebInspector.ResourceTreeModel.prototype.forAllResources):
        (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
        (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._populateResourceTree):
        (WebInspector.ResourcesPanel.prototype._frameAdded):
        (WebInspector.ResourcesPanel.prototype._frameDetached):
        (WebInspector.ResourcesPanel.prototype._frameNavigated):
        (WebInspector.FrameTreeElement):
        (WebInspector.FrameTreeElement.prototype.frameNavigated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 28 Apr 2011 14:59:26 +0000 (14:59 +0000)]
2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=59592

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
        (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
        (WebInspector.DetailedHeapshotView.prototype.changeView):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
        (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
        (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
        (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
        (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
        * inspector/front-end/heapProfiler.css:
        (div.retaining-paths-view td.path-column div:hover):

2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=59592

        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 28 Apr 2011 14:53:45 +0000 (14:53 +0000)]
2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
        https://bugs.webkit.org/show_bug.cgi?id=59454

        Test: inspector/profiler/heap-snapshot-loader.html

        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotLoader):
        (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
        (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
        (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
        (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
        (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):

2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
        https://bugs.webkit.org/show_bug.cgi?id=59454

        * inspector/profiler/heap-snapshot-loader-expected.txt: Added.
        * inspector/profiler/heap-snapshot-loader.html: Added.
        * inspector/profiler/heap-snapshot-test.js:
        (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
        (initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 ojab <ojab@ojab.ru>
commit-queue@webkit.org [Thu, 28 Apr 2011 14:23:06 +0000 (14:23 +0000)]
2011-04-28  ojab  <ojab@ojab.ru>

        Reviewed by David Levin.

        Fix build with libpng-1.5.1
        https://bugs.webkit.org/show_bug.cgi?id=59607

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::readColorProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimizing gaussian blur filter to ARM-neon SIMD instruction set
zherczeg@webkit.org [Thu, 28 Apr 2011 14:18:56 +0000 (14:18 +0000)]
Optimizing gaussian blur filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=59447

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-04-28
Reviewed by Nikolas Zimmermann.

This patch contains two sub-routines, one for speeding up
alpha channel only gaussian blur (by 2.5 times) and one
for speeding up all channel blur (by 4 times).

The common code is also redesigned to better fit for platform
specific code. This means large chunks of code was moved to
different files, and all platform specific files are added to
all build systems.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::apply):
* platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::kernelPosition):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
(WebCore::FELighting::drawLighting):
* platform/graphics/filters/FELighting.h:
(WebCore::FELighting::platformApply):
* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
(WebCore::WTF_ALIGNED):
(WebCore::feGaussianBlurConstantsForNeon):
* platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
(WebCore::FEGaussianBlur::platformApplyNeon):
* platform/graphics/filters/arm/FELightingNEON.cpp:
(WebCore::WTF_ALIGNED):
(WebCore::FELighting::getPowerCoefficients):
* platform/graphics/filters/arm/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 28 Apr 2011 13:03:19 +0000 (13:03 +0000)]
2011-04-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide a hotkey for script pause
        https://bugs.webkit.org/show_bug.cgi?id=59593

        In fact, F8 works as a hotkey, but this fact was not reflected
        in the shortcut help popup.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 12:58:25 +0000 (12:58 +0000)]
2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: readonly and read/write transactions
        https://bugs.webkit.org/show_bug.cgi?id=59465

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/readonly-transactions-expected.txt: Added.
        * storage/indexeddb/mozilla/readonly-transactions.html: Added.
        * storage/indexeddb/mozilla/readwrite-transactions-expected.txt: Added.
        * storage/indexeddb/mozilla/readwrite-transactions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Gabor Rapcsanyi <rgabor@webkit.org>
rgabor@webkit.org [Thu, 28 Apr 2011 11:42:27 +0000 (11:42 +0000)]
2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] Add ARM specific Skipped list
        https://bugs.webkit.org/show_bug.cgi?id=59680

        * platform/qt-arm/Skipped: Added.
2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] Add ARM specific Skipped list
        https://bugs.webkit.org/show_bug.cgi?id=59680

        * Scripts/old-run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 11:14:30 +0000 (11:14 +0000)]
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        PluginStream should play nice with strict OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59675

        These failures appear when enabling strict OwnPtr on Qt.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::PluginStream):
        (WebCore::PluginStream::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-26 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 28 Apr 2011 09:06:58 +0000 (09:06 +0000)]
2011-04-26  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
        https://bugs.webkit.org/show_bug.cgi?id=59326

        Concrete CachedResource successors for stylesheets and scripts
        can decode their content better than the generic approach we use.

        * inspector/InspectorPageAgent.cpp:
        (WebCore::decodeSharedBuffer):
        (WebCore::prepareCachedResourceBuffer):
        (WebCore::cachedResourceDecoded):
        (WebCore::InspectorPageAgent::resourceContent):
        (WebCore::InspectorPageAgent::resourceData):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::originalStyleSheetText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-28 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 07:48:47 +0000 (07:48 +0000)]
2011-04-28  Jon Lee  <jonlee@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION: white overlay scrollbars on apple.com/startpage
        https://bugs.webkit.org/show_bug.cgi?id=59540
        <rdar://problem/9338653>

        Now we look at the document background in addition to the <body> element,
        and blend those colors in with the base background of the frame view to
        arrive at our aggregate color. This provides a better result to determine
        overlay scrollbar style.

        * page/Frame.cpp:
        (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
        * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based...
ossy@webkit.org [Thu, 28 Apr 2011 07:06:46 +0000 (07:06 +0000)]
Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59369

[Qt] Qt specific expected result is unnecessary after r85163.

* platform/qt/fast/events/mouseout-dead-node-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 06:56:36 +0000 (06:56 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Fix OwnPtr issues in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=59656

        This patch is an attempt to fix the clang build.  Clang can't seem to
        cope with OwnPtrs to classes declared in an anonymous namespace because
        OwnPtr's copy constructor isn't defined (but would need to be defined
        in this translation unit).

        * platform/leveldb/LevelDBDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 06:46:04 +0000 (06:46 +0000)]
2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Change cursor to LAZY_NATIVE_CURSOR
        https://bugs.webkit.org/show_bug.cgi?id=59411

        Enable LAZY_NATIVE_CURSOR on EFL build.

        No test added because functionality is unchanged.

        * CMakeListsEfl.txt: Add Cursor.cpp
        * platform/Cursor.h:
        (WebCore::Cursor::Cursor):
        * platform/efl/CursorEfl.cpp:
        (WebCore::Cursor::Cursor):
        (WebCore::Cursor::~Cursor):
        (WebCore::getCursorString):
        (WebCore::Cursor::ensurePlatformCursor):
        * platform/efl/WidgetEfl.cpp:
        (WebCore::Widget::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 06:35:44 +0000 (06:35 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Enable strict OwnPtrs for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=59666

        * wtf/OwnPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 06:23:59 +0000 (06:23 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Build fix from the future.  Another trival strict OwnPtr fixes.  This
        is the last futuristic build fix I can detect with my time traveling
        abilities.

        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::initializeNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Dmitry Lomov <dslomov@google.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 06:21:34 +0000 (06:21 +0000)]
2011-04-27  Dmitry Lomov  <dslomov@google.com>

        Reviewed by David Levin.

        CrossThreadCopier should not have a default specialization for raw pointers
        https://bugs.webkit.org/show_bug.cgi?id=59234
        Removed the ablity to pass raw pointers cross-thread
        Added and applied annotations for doing that

        * fileapi/FileReader.cpp:
        (WebCore::FileReader::readInternal):
        (WebCore::FileReader::abort):
        * fileapi/FileStreamProxy.cpp:
        (WebCore::FileStreamProxy::startOnFileThread):
        (WebCore::FileStreamProxy::stopOnFileThread):
        (WebCore::FileStreamProxy::getSize):
        (WebCore::FileStreamProxy::getSizeOnFileThread):
        (WebCore::FileStreamProxy::openForRead):
        (WebCore::FileStreamProxy::openForReadOnFileThread):
        (WebCore::FileStreamProxy::openForWrite):
        (WebCore::FileStreamProxy::openForWriteOnFileThread):
        (WebCore::FileStreamProxy::close):
        (WebCore::FileStreamProxy::read):
        (WebCore::FileStreamProxy::readOnFileThread):
        (WebCore::FileStreamProxy::write):
        (WebCore::FileStreamProxy::writeOnFileThread):
        (WebCore::FileStreamProxy::truncate):
        (WebCore::FileStreamProxy::truncateOnFileThread):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
        * page/GeolocationPositionCache.cpp:
        (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
        (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
        * platform/CrossThreadCopier.h:
        (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
        (WebCore::AllowCrossThreadAccessWrapper::value):
        (WebCore::AllowCrossThreadAccess):
        (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
        (WebCore::AllowExtendedLifetimeWrapper::value):
        (WebCore::AllowExtendedLifetime):
        * platform/graphics/chromium/cc/CCCompletionEvent.h:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::get):
        (WebCore::IDBObjectStoreBackendImpl::put):
        (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
        (WebCore::IDBObjectStoreBackendImpl::clear):
        (WebCore::IDBObjectStoreBackendImpl::createIndex):
        (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
        (WebCore::IDBObjectStoreBackendImpl::openCursor):
        * storage/SQLCallbackWrapper.h:
        (WebCore::SQLCallbackWrapper::clear):
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
2011-04-27  Dmitry Lomov  <dslomov@google.com>

        Reviewed by David Levin.

        CrossThreadCopier should not have a default specialization for raw pointers
        https://bugs.webkit.org/show_bug.cgi?id=59234
        Removed the ablity to pass raw pointers cross-thread
        Added and applied annotations for doing that

        * src/WebSharedWorkerImpl.cpp:
        (WebKit::WebSharedWorkerImpl::connect):
        (WebKit::WebSharedWorkerImpl::connectTask):
        * src/WebSharedWorkerImpl.h:
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::postMessageToWorkerObject):
        (WebKit::WebWorkerBase::postExceptionToWorkerObject):
        (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
        (WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
        (WebKit::WebWorkerBase::reportPendingActivity):
        (WebKit::WebWorkerBase::workerContextClosed):
        (WebKit::WebWorkerBase::workerContextDestroyed):
        * src/WebWorkerClientImpl.cpp:
        (WebKit::WebWorkerClientImpl::startWorkerContext):
        (WebKit::WebWorkerClientImpl::terminateWorkerContext):
        (WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
        (WebKit::WebWorkerClientImpl::workerObjectDestroyed):
        (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
        (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
        (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
        (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
        (WebKit::WebWorkerClientImpl::reportPendingActivity):
        * src/WebWorkerImpl.cpp:
        (WebKit::WebWorkerImpl::postMessageToWorkerContext):
        * src/WorkerFileSystemCallbacksBridge.cpp:
        (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postMoveToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postCopyToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postRemoveToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postReadMetadataToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postCreateFileToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postCreateDirectoryToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postFileExistsToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postDirectoryExistsToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::postReadDirectoryToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didFailOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
        * src/WorkerFileWriterCallbacksBridge.cpp:
        (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::didWrite):
        (WebKit::WorkerFileWriterCallbacksBridge::didFail):
        (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
        (WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
        (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
        * tests/CCThreadTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 06:16:46 +0000 (06:16 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Two build fixes from the future.  (Trivial strict OwnPtr fixes.)

        * page/Frame.cpp:
        (WebCore::Frame::setTiledBackingStoreEnabled):
        * platform/audio/ReverbConvolver.cpp:
        (WebCore::ReverbConvolver::ReverbConvolver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 06:15:45 +0000 (06:15 +0000)]
2011-04-27  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test
        https://bugs.webkit.org/show_bug.cgi?id=59369

        * fast/events/mouseout-dead-node-expected.txt: Added.
        * fast/events/mouseout-dead-node.html: Change to use dumpAsText.
        * platform/chromium-linux/fast/events/mouseout-dead-node-expected.png: Removed.
        * platform/chromium-win/fast/events/mouseout-dead-node-expected.png: Removed.
        * platform/chromium-win/fast/events/mouseout-dead-node-expected.txt: Removed.
        * platform/gtk/fast/events/mouseout-dead-node-expected.txt: Removed.
        * platform/mac-leopard/fast/events/mouseout-dead-node-expected.png: Removed.
        * platform/mac/fast/events/mouseout-dead-node-expected.png: Removed.
        * platform/mac/fast/events/mouseout-dead-node-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 06:08:16 +0000 (06:08 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix five strict PassOwnPtr violations in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=59640

        * css/MediaList.cpp:
        (WebCore::MediaList::deleteMedium):
        (WebCore::MediaList::setMediaText):
        (WebCore::MediaList::appendMedium):
        * css/MediaQuery.h:
        * dom/MessagePort.cpp:
        (WebCore::MessagePort::disentanglePorts):
        (WebCore::MessagePort::entanglePorts):
        * inspector/InspectorStyleSheet.cpp:
        (ParsedStyleSheet::setText):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::adjustMeterStyle):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustMenuListStyle):
        (WebCore::RenderThemeMac::adjustSliderTrackStyle):
        (WebCore::RenderThemeMac::adjustSliderThumbStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 05:59:58 +0000 (05:59 +0000)]
2011-04-27  Kenneth Russell  <kbr@google.com>

        Chromium test failures after r85142
        https://bugs.webkit.org/show_bug.cgi?id=59673

        Unreviewed. Temporarily suppress test failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 28 Apr 2011 05:53:01 +0000 (05:53 +0000)]
2011-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        Log more information when http/tests/xmlhttprequest/basic-auth.html fails
        https://bugs.webkit.org/show_bug.cgi?id=59651

        Very basic, but it's better than nothing.

        * http/tests/xmlhttprequest/basic-auth.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Thu, 28 Apr 2011 05:43:12 +0000 (05:43 +0000)]
2011-04-27  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
        https://bugs.webkit.org/show_bug.cgi?id=59648

        * accessibility/aria-fallback-roles.html: Added.
        * platform/mac/accessibility/aria-fallback-roles-expected.txt: Added.
2011-04-27  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
        https://bugs.webkit.org/show_bug.cgi?id=59648

        Test: accessibility/aria-fallback-roles.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 28 Apr 2011 05:38:00 +0000 (05:38 +0000)]
2011-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        error_log.txt should include PHP errors
        https://bugs.webkit.org/show_bug.cgi?id=59643

        Turns out this was really easy after I finally learned
        enough about PHP to do it...

        I'm adding this in hopes of better tracking down
        our random http failures.

        * Scripts/webkitperl/httpd.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 05:19:55 +0000 (05:19 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: creating unique index and updating indexNames
        https://bugs.webkit.org/show_bug.cgi?id=59631

        * storage/indexeddb/mozilla/create-index-unique-expected.txt: Added.
        * storage/indexeddb/mozilla/create-index-unique.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 05:18:38 +0000 (05:18 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Should call done() from unexpectedErrorCallback so failing IndexedDB tests don't time out
        https://bugs.webkit.org/show_bug.cgi?id=59569

        * storage/indexeddb/exception-in-event-aborts-expected.txt:
        * storage/indexeddb/exception-in-event-aborts.html:
        * storage/indexeddb/resources/shared.js:
        (unexpectedSuccessCallback):
        (unexpectedErrorCallback):
        (unexpectedAbortCallback):
        (unexpectedCompleteCallback):
        (unexpectedBlockedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 05:03:55 +0000 (05:03 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: creating and deleting indexes
        https://bugs.webkit.org/show_bug.cgi?id=59635

        * storage/indexeddb/mozilla/remove-index-expected.txt: Added.
        * storage/indexeddb/mozilla/remove-index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 04:59:27 +0000 (04:59 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: get() and put() basics
        https://bugs.webkit.org/show_bug.cgi?id=59468

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/put-get-values-expected.txt: Added.
        * storage/indexeddb/mozilla/put-get-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 04:55:55 +0000 (04:55 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: index cursors
        https://bugs.webkit.org/show_bug.cgi?id=59472

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/object-cursors-expected.txt: Added.
        * storage/indexeddb/mozilla/object-cursors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 04:40:45 +0000 (04:40 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: event.target.source in success callbacks
        https://bugs.webkit.org/show_bug.cgi?id=59632

        * storage/indexeddb/mozilla/event-source-expected.txt: Added.
        * storage/indexeddb/mozilla/event-source.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 04:37:32 +0000 (04:37 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: event.target.result after add() and put()
        https://bugs.webkit.org/show_bug.cgi?id=59634

        * storage/indexeddb/mozilla/key-requirements-expected.txt: Added.
        * storage/indexeddb/mozilla/key-requirements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=59671
bdakin@apple.com [Thu, 28 Apr 2011 04:32:25 +0000 (04:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59671
Race condition with scrollbar animations and closing a page can cause a crash in
WebCore::FrameView::setVisibleScrollerThumbRect + 15
-and corresponding-
<rdar://problem/9329253>

Reviewed by Dan Bernstein.

It is definitely possible for Page to be null here. So we should null-check it!
And we should not ASSERT.
* page/FrameView.cpp:
(WebCore::FrameView::didCompleteRubberBand):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::setVisibleScrollerThumbRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 28 Apr 2011 04:27:56 +0000 (04:27 +0000)]
2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>

        WinCE build fix after r85143.

        * platform/graphics/wince/FontWinCE.cpp:
        (WebCore::TextRunComponent::TextRunComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 04:11:58 +0000 (04:11 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB object store deleting entry should fail if key is null
        https://bugs.webkit.org/show_bug.cgi?id=58614

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt: Added.
        * storage/indexeddb/mozilla/key-requirements-delete-null-key.html: Added.
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB object store delete should fail if key is null
        https://bugs.webkit.org/show_bug.cgi?id=58614

        Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html

        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::deleteFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 28 Apr 2011 03:35:21 +0000 (03:35 +0000)]
2011-04-27  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        audio-no-installed-engines.html media test has unnecessary pixel results
        https://bugs.webkit.org/show_bug.cgi?id=59456

        Convert audio-no-installed-engines.html results from pixel to text.

        * media/audio-no-installed-engines-expected.txt: Added.
        * media/audio-no-installed-engines.html:
        * platform/chromium-linux/media/audio-no-installed-engines-expected.png: Removed.
        * platform/chromium-win/media/audio-no-installed-engines-expected.png: Removed.
        * platform/chromium-win/media/audio-no-installed-engines-expected.txt: Removed.
        * platform/gtk/media/audio-no-installed-engines-expected.txt: Removed.
        * platform/mac-leopard/media/audio-no-installed-engines-expected.png: Removed.
        * platform/mac/media/audio-no-installed-engines-expected.png: Removed.
        * platform/mac/media/audio-no-installed-engines-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 28 Apr 2011 03:20:54 +0000 (03:20 +0000)]
2011-04-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Should have an easy way to construct starting BidiStatus for a paragraph root
        https://bugs.webkit.org/show_bug.cgi?id=59226

        Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
        I've made this a constructor for BidiStatus instead.

        As part of this effort I added a direction() accessor for TextRun and got
        rid of the old m_rtl bool.  This is part of the generic effort in the
        Bidi code to replace old bool usage with the superior TextDirection enum
        (this generally makes the code cleaner).

        As part of this replacement effort I found several places which were
        assuming LTR (by passing rtl=false) when they probably want to use
        the current text direction.  I suspect that LTR vs. RTL may affect
        string width in the case of ligatures.  It's unclear.

        This is almost entirely a mechanical change.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawBidiText):
        * platform/graphics/TextRun.h:
        (WebCore::TextRun::TextRun):
        (WebCore::TextRun::direction):
        (WebCore::TextRun::rtl):
        (WebCore::TextRun::ltr):
        (WebCore::TextRun::setDirection):
        * platform/text/BidiResolver.h:
        (WebCore::BidiStatus::BidiStatus):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::selectionRect):
        (WebCore::EllipsisBox::paintSelection):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintCompositionBackground):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::determineStartPosition):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::paintItemForeground):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::getAvgCharWidth):
        (WebCore::RenderTextControl::paintPlaceholder):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::constructTextRun):
        * rendering/svg/SVGTextMetrics.cpp:
        (WebCore::constructTextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 28 Apr 2011 03:18:18 +0000 (03:18 +0000)]
2011-04-27  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        Allow shadowing of history object
        https://bugs.webkit.org/show_bug.cgi?id=55965

        * fast/dom/Window/get-set-properties-expected.txt:
        * fast/dom/Window/get-set-properties.html:
        * fast/dom/Window/window-property-shadowing-expected.txt:
        * fast/dom/Window/window-property-shadowing.html:
        * fast/js/var-declarations-shadowing-expected.txt:
        * fast/js/var-declarations-shadowing.html:
        * http/tests/history/cross-origin-replace-history-object-child-expected.txt: Added.
        * http/tests/history/cross-origin-replace-history-object-child.html: Added.
        * http/tests/history/cross-origin-replace-history-object-expected.txt: Added.
        * http/tests/history/cross-origin-replace-history-object.html: Added.
        * http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html: Added.
        * http/tests/history/resources/cross-origin-replaces-history-object-iframe.html: Added.
        * http/tests/security/cross-frame-access-put-expected.txt: Note that a window property with
          the DoNotCheckDomainSecurityOnGet attribute generates two cross-origin JS warnings. Amended
          expected results to include the additional extra warning for the history object.
2011-04-27  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        Allow shadowing of history object
        https://bugs.webkit.org/show_bug.cgi?id=55965

        Tests: http/tests/history/cross-origin-replace-history-object-child.html
               http/tests/history/cross-origin-replace-history-object.html

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 28 Apr 2011 03:07:29 +0000 (03:07 +0000)]
2011-04-27  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Fix some
        Chromium Mac Leopard failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 28 Apr 2011 02:45:34 +0000 (02:45 +0000)]
2011-04-27  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Fix Chromium Mac SL Debug
        expectations, few miscellaneous other expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 02:02:42 +0000 (02:02 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: clear()
        https://bugs.webkit.org/show_bug.cgi?id=59498

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/clear-expected.txt: Added.
        * storage/indexeddb/mozilla/clear.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style should flags spacing errors for braces on the same line.
levin@chromium.org [Thu, 28 Apr 2011 01:54:40 +0000 (01:54 +0000)]
check-webkit-style should flags spacing errors for braces on the same line.
https://bugs.webkit.org/show_bug.cgi?id=59665

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checkers/cpp.py: Added the check.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
  and fixed some test cases to not trigger this error since it isn't what they are verifying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style error for spaces after periods in a comment has a bad error
levin@chromium.org [Thu, 28 Apr 2011 01:49:03 +0000 (01:49 +0000)]
check-webkit-style error for spaces after periods in a comment has a bad error
message and warns about end of line spaces.
https://bugs.webkit.org/show_bug.cgi?id=59663

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
and changed the error messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 28 Apr 2011 01:43:52 +0000 (01:43 +0000)]
2011-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Ensure compositing layers are up to date before entering doComposite
        https://bugs.webkit.org/show_bug.cgi?id=59159

        Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
        GraphicsLayerClient::paintContents() implementations).

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
          Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
2011-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Ensure compositing layers are up to date before entering doComposite
        https://bugs.webkit.org/show_bug.cgi?id=59159

        Explicitly update and sync the compositing layer data structures for all frames in the tree before entering the
        composite operation so that lazily updated state doesn't mutate the GraphicsLayer tree while compositing.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 28 Apr 2011 01:42:20 +0000 (01:42 +0000)]
2011-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix OwnPtr strict issues in chromium linux build
        https://bugs.webkit.org/show_bug.cgi?id=59664

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::getNormalizedTextRun):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::PlatformContextSkia):
2011-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix OwnPtr strict issues in chromium linux build
        https://bugs.webkit.org/show_bug.cgi?id=59664

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::getFrameAtIndex):
        * src/WebImageSkia.cpp:
        (WebKit::WebImage::fromData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 01:31:29 +0000 (01:31 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: add twice failure
        https://bugs.webkit.org/show_bug.cgi?id=59492

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/add-twice-failure-expected.txt: Added.
        * storage/indexeddb/mozilla/add-twice-failure.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Chris Rogers <crogers@google.com>
crogers@google.com [Thu, 28 Apr 2011 01:22:54 +0000 (01:22 +0000)]
2011-04-27  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
        https://bugs.webkit.org/show_bug.cgi?id=59641

        No new tests since audio API is not yet implemented.

        * platform/audio/AudioBus.cpp:
        (WebCore::AudioBus::createBySampleRateConverting):
        (WebCore::AudioBus::createByMixingToMono):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 01:07:18 +0000 (01:07 +0000)]
2011-04-27  Kenneth Russell  <kbr@google.com>

        Unreviewed. Fixed more breakage in test_expectations.txt caused by
        my previous checkin, caught with --lint-test-files thanks to dpranke.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMotivated by Alexey Proskuryakov.
ggaren@apple.com [Thu, 28 Apr 2011 01:01:23 +0000 (01:01 +0000)]
Motivated by Alexey Proskuryakov.

* bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
informative, since it confused Alexey and me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 28 Apr 2011 00:59:18 +0000 (00:59 +0000)]
2011-04-27  Andy Estes  <aestes@apple.com>

        Skip fast/blockflow/broken-ideographic-font.html on Leopard.

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 00:57:09 +0000 (00:57 +0000)]
2011-04-27  Kenneth Russell  <kbr@google.com>

        Unreviewed, test expectation updates.
          - Marked media/video-controls-transformed.html as failing generally.
          - Fixed malformed bug ID in last update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 00:31:43 +0000 (00:31 +0000)]
2011-04-27  Kenneth Russell  <kbr@google.com>

        Unreviewed, test expectation updates.
          - Added a couple of flaky tests.
          - Filed bugs for a preexisting and a new failure.
          - Rebaselined fast/lists/003-vertical.html on Mac.

        * platform/chromium-mac/fast/lists/003-vertical-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 28 Apr 2011 00:19:50 +0000 (00:19 +0000)]
2011-04-27  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
        https://bugs.webkit.org/show_bug.cgi?id=59646

        Made the cssValueRoots map per-world, instead of a global. When we deallocate
        a world, we need to clear all entries in the map for that world, since
        the finalizers that would otherwise clear those entries don't run. The
        simplest way to do this is just to make the world own the map.

        * bindings/js/DOMWrapperWorld.h:
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
        (WebCore::JSCSSValueOwner::finalize):
        * bindings/js/JSDOMBinding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 00:17:30 +0000 (00:17 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Make GraphicsContext3DChromium play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59659

        Attempt #2.  Hopefully this time I won't make everything crash.

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 00:05:45 +0000 (00:05 +0000)]
2011-04-27  Ojan Vafai  <ojan@chromium.org>

        remove assertion now that platform/mac-tiger no longer exists
        https://bugs.webkit.org/show_bug.cgi?id=59660

        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 28 Apr 2011 00:04:32 +0000 (00:04 +0000)]
2011-04-27  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, update w/ failing tests and remove a bunch of
        passing mac tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 00:00:43 +0000 (00:00 +0000)]
2011-04-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        remove test that didn't make sense
        https://bugs.webkit.org/show_bug.cgi?id=59658

        It was artifically saying the test wasn't expected to pass,
        but the expectations string was empty. The case of unexpected
        passes with a real expectations string is tested later in the
        same test.

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 27 Apr 2011 23:52:09 +0000 (23:52 +0000)]
2011-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix OwnPtr issues in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=59656

        I didn't do an exhaustive review of this code, but I fixed the problems
        caught by turning on strict OwnPtr and all their antecedents.  This
        patch is entirely tighter bookkeeping.  There shouldn't be any actual
        behavior change.

        * platform/leveldb/LevelDBDatabase.cpp:
        (WebCore::LevelDBDatabase::LevelDBDatabase):
        (WebCore::LevelDBDatabase::open):
        (WebCore::LevelDBDatabase::createIterator):
        * platform/leveldb/LevelDBDatabase.h:
        * platform/leveldb/LevelDBIterator.cpp:
        (WebCore::LevelDBIterator::LevelDBIterator):
        * platform/leveldb/LevelDBIterator.h:
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
        (WebCore::IDBLevelDBBackingStore::open):
        (WebCore::getNewDatabaseId):
        (WebCore::IDBLevelDBBackingStore::getObjectStores):
        (WebCore::getNewObjectStoreId):
        (WebCore::deleteRange):
        (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
        (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
        (WebCore::IDBLevelDBBackingStore::getIndexes):
        (WebCore::getNewIndexId):
        (WebCore::findGreatestKeyLessThan):
        (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
        (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
        (WebCore::findLastIndexKeyEqualTo):
        * storage/IDBLevelDBBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 27 Apr 2011 23:48:16 +0000 (23:48 +0000)]
2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: bad keypath
        https://bugs.webkit.org/show_bug.cgi?id=59497

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/bad-keypath-expected.txt: Added.
        * storage/indexeddb/mozilla/bad-keypath.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 27 Apr 2011 23:45:37 +0000 (23:45 +0000)]
2011-04-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        WebKit2 needs to notify the client when a plugin fails to initialize
        https://bugs.webkit.org/show_bug.cgi?id=59657

        Add didFailToInitializePlugin client function and call it when a plugin
        fails to initialize.

        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebLoaderClient.cpp:
        (WebKit::WebLoaderClient::didFailToInitializePlugin):
        * UIProcess/WebLoaderClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didFailToInitializePlugin):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::initializePlugin):
2011-04-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        WebKit2 needs to notify the client when a plugin fails to initialize
        https://bugs.webkit.org/show_bug.cgi?id=59657

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize):
        Add stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 27 Apr 2011 23:17:43 +0000 (23:17 +0000)]
2011-04-26  Sam Weinig  <sam@webkit.org>

        Reviewed by David Levin.

        Add a few more missing options to new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=59567

        Add support for:
            --threaded
            --gc-between-tests
            --complex-text

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-19 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 27 Apr 2011 23:09:01 +0000 (23:09 +0000)]
2011-04-19  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
        https://bugs.webkit.org/show_bug.cgi?id=58113

        * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
        * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
        * Now MarkerMapVectorPair is no longer used.

        No new tests, No behavior change.

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DocumentMarker.h:
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::addMarker):
        (WebCore::DocumentMarkerController::copyMarkers):
        (WebCore::DocumentMarkerController::removeMarkers):
        (WebCore::DocumentMarkerController::markerContainingPoint):
        (WebCore::DocumentMarkerController::markersForNode):
        (WebCore::DocumentMarkerController::renderedRectsForMarkers):
        (WebCore::DocumentMarkerController::removeMarkersFromList):
        (WebCore::DocumentMarkerController::repaintMarkers):
        (WebCore::DocumentMarkerController::setRenderedRectForMarker):
        (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
        (WebCore::DocumentMarkerController::shiftMarkers):
        (WebCore::DocumentMarkerController::setMarkersActive):
        (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
        (WebCore::DocumentMarkerController::showMarkers):
        * dom/DocumentMarkerController.h:
        * dom/RenderedDocumentMarker.h: Added.
        (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
        (WebCore::RenderedDocumentMarker::isRendered):
        (WebCore::RenderedDocumentMarker::contains):
        (WebCore::RenderedDocumentMarker::setRenderedRect):
        (WebCore::RenderedDocumentMarker::renderedRect):
        (WebCore::RenderedDocumentMarker::invalidate):
        (WebCore::RenderedDocumentMarker::invalidMarkerRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 27 Apr 2011 23:06:42 +0000 (23:06 +0000)]
2011-04-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Add ability to remove keys from weakmap API
        https://bugs.webkit.org/show_bug.cgi?id=59645

        Add JSWeakObjectMapRemove API

        * API/JSWeakObjectMapRefPrivate.cpp:
        * API/JSWeakObjectMapRefPrivate.h:
        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 27 Apr 2011 23:01:48 +0000 (23:01 +0000)]
2011-04-27  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r85112.
        http://trac.webkit.org/changeset/85112
        https://bugs.webkit.org/show_bug.cgi?id=59159

        Broke mac compile

        * page/FrameView.cpp:
        (WebCore::FrameView::updateCompositingLayers):
        * page/FrameView.h:
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
mrowe@apple.com [Wed, 27 Apr 2011 22:57:08 +0000 (22:57 +0000)]
Build fix.

Fix an OwnPtr-related issue that was missed before the strictness was turned on.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
mrowe@apple.com [Wed, 27 Apr 2011 22:53:46 +0000 (22:53 +0000)]
Build fix.

* WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
psolanki@apple.com [Wed, 27 Apr 2011 22:50:18 +0000 (22:50 +0000)]
Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).

* platform/network/ResourceHandleClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 27 Apr 2011 22:41:31 +0000 (22:41 +0000)]
2011-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Ensure compositing layers are up to date before entering doComposite
        https://bugs.webkit.org/show_bug.cgi?id=59159

        Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
        GraphicsLayerClient::paintContents() implementations).

        * page/FrameView.cpp:
        (WebCore::FrameView::updateCompositingLayers):
            Add an optional CompositingUpdateType parameter.
        * page/FrameView.h:
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
          Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::dirtyZOrderLists):
        (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        * rendering/RenderLayerCompositor.h:
          Fix a typo in CompositingUpdateType Pait->Paint

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 27 Apr 2011 22:39:09 +0000 (22:39 +0000)]
2011-04-27  Ojan Vafai  <ojan@chromium.org>

        Forgot to upload the new times_ms.json file after splitting
        it out from full_results.json.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85111 268f45cc-cd09-0410-ab3c-d52691b4dbfc