13 years ago2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
bdash [Wed, 27 Jun 2007 05:44:33 +0000 (05:44 +0000)]
2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Maciej.

        Gdk font backend cleanup

        * platform/FontData.h: Remove obsolete function.
        * platform/gdk/FontDataGdk.cpp:
        (WebCore::FontData::containsCharacters): Lock/unlock only once.
        (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
        * platform/gdk/FontPlatformData.h: Remove obsolete function.
        * platform/gdk/FontPlatformDataGdk.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
        not the pixel size.
        (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
        * platform/gdk/GlyphPageTreeNodeGdk.cpp:
        (WebCore::GlyphPage::fill): Lock/unlock only once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-26 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 27 Jun 2007 05:33:32 +0000 (05:33 +0000)]
2007-06-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14406
          <colgroup>'s borders are ignored when it has <col> children

        Covered by existing tests.

        * rendering/RenderTableCell.cpp:

2007-06-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=14406
          <colgroup>'s borders are ignored when it has <col> children

        * tables/mozilla/core/table_rules-expected.checksum: Added.
        * tables/mozilla/core/table_rules-expected.png: Added.
        * tables/mozilla/core/table_rules-expected.txt: Added.
        * tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
        * tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
        * tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
        * tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
        * tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
        * tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
        * tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
        * tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
        * tables/mozilla_expected_failures/core/table_rules.html: Removed.
        * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
        * tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-26 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 27 Jun 2007 04:46:07 +0000 (04:46 +0000)]
2007-06-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14329
          REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/

        Test: fast/repaint/text-selection-rect-in-overflow-2.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
        for overflow scroll and columns.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::selectionRect): Adjust for columns only in the
        non-clipped case, since RenderObject::absolutePosition() does not.

2007-06-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=14329
          REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/

        * fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
        * fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
        * fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
        * fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
        * fast/repaint/text-selection-rect-in-overflow-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-26 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 27 Jun 2007 04:43:27 +0000 (04:43 +0000)]
2007-06-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Sam.

        - http://bugs.webkit.org/show_bug.cgi?id=14415
          Remove the unused method RenderObject::setTable()

        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTouching config.h to force WebCore to rebuild after r23806
aroben [Wed, 27 Jun 2007 04:07:35 +0000 (04:07 +0000)]
Touching config.h to force WebCore to rebuild after r23806

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-26 MorganL <morganl.webkit@yahoo.com>
bdash [Wed, 27 Jun 2007 03:16:23 +0000 (03:16 +0000)]
2007-06-26  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej.

        Implement http://bugs.webkit.org/show_bug.cgi?id=14225
        Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs

        This change moves the bulk of ResourceRequest into a base class named
        ResourceRequestBase with all platform-specific bits pushed into
        ResourceRequest.  This allows ports to easily add new members to a
        ResourceRequest without having to #ifdef the code that is shared
        between ports.

        * WebCore.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/ResourceRequest.cpp: Removed.
        * platform/network/ResourceRequest.h: Removed.
        * platform/network/ResourceRequestBase.cpp: Added.
        * platform/network/ResourceRequestBase.h: Added.
        * platform/network/cf/ResourceRequest.h: Added.
        * platform/network/curl/ResourceRequest.h: Added.
        * platform/network/mac/ResourceRequest.h: Added.
        * platform/network/qt/ResourceRequest.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-26 Jim Correia <jim.correia@pobox.com>
bdash [Wed, 27 Jun 2007 03:13:26 +0000 (03:13 +0000)]
2007-06-26  Jim Correia  <jim.correia@pobox.com>

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14411
        Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.

        * Plugins/WebNetscapePluginPackage.m:
        (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to
        lazy initialize, and only set CurApRefNum to the system file if
        CurApRefNum is still -1 after that forced lazy initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd ChangeLog entries from the Windows merge.
aroben [Wed, 27 Jun 2007 02:13:36 +0000 (02:13 +0000)]
Add ChangeLog entries from the Windows merge.

Reviewed by Maciej.

* ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Wed, 27 Jun 2007 01:44:54 +0000 (01:44 +0000)]

        Reviewed by Maciej.

        Make sure not to enumerate the toString() function.

        * fast/dom/Window/window-appendages-cleared-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/toString-dontEnum-expected.txt: Added.
        * fast/js/toString-dontEnum.html: Added.


        Reviewed by Maciej.

        Make sure not to enumerate the toString() function.

        * bindings/js/kjs_window.cpp:
        * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
        * html/HTMLAnchorElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej Stachowiak.
ggaren [Tue, 26 Jun 2007 23:26:17 +0000 (23:26 +0000)]
    Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/5296627> JSGarbageCollect headerdoc suggests that
        using JavaScriptCore requires leaking memory

        * API/JSBase.h: Changed documentation to explain that you can pass NULL
        to JSGarbageCollect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz, landed by Anders.
andersca [Tue, 26 Jun 2007 23:07:33 +0000 (23:07 +0000)]
    Reviewed by Mitz, landed by Anders.

        Implement GraphicsContext::clearRect()

        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and landed by Anders.
andersca [Tue, 26 Jun 2007 23:05:06 +0000 (23:05 +0000)]
    Reviewed and landed by Anders.

        Content does not render fully in some cases

        Fix mismatched calls to cairo_save/restore due to an early method return.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
tristan [Tue, 26 Jun 2007 21:31:10 +0000 (21:31 +0000)]
    Reviewed by John Sullivan.

        Added two accessor functions for <rdar://problem/4119138>

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _isEdited]):
        (-[DOMHTMLTextAreaElement _isEdited]):
        Added an accessor to the isEdited value of a DOM node's render object

        * bindings/objc/DOMPrivate.h:
        Added header definitions for _isEdited

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Win32 build.
weinig [Tue, 26 Jun 2007 20:07:58 +0000 (20:07 +0000)]
    Fix Win32 build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Qt and Gdk builds.
weinig [Tue, 26 Jun 2007 20:05:47 +0000 (20:05 +0000)]
    Fix Qt and Gdk builds.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 26 Jun 2007 19:55:22 +0000 (19:55 +0000)]

        Reviewed by Geoff.

        Update tests for http://bugs.webkit.org/show_bug.cgi?id=14111
        Autogenerate Event JS binding

        * fast/dom/prototype-chain-expected.txt: DOMEventPrototype is no longer
        in the prototype chain.
        * fast/dom/xmlhttprequest-get-expected.txt:


        Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
        Autogenerate Event JS binding

        - Moves the dataTransfer method into MouseEvent where it should be.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp: Added.
        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_events.h:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Event.h:
        * dom/Event.idl:
        * dom/MouseEvent.h:
        * dom/MouseEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMissed checking in this file when checking in icon database patch from Adam Treat...
staikos [Tue, 26 Jun 2007 14:40:27 +0000 (14:40 +0000)]
Missed checking in this file when checking in icon database patch from Adam Treat.  Unused on all platforms presently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
thatcher [Tue, 26 Jun 2007 12:28:26 +0000 (12:28 +0000)]
    Reviewed by Mark Rowe.

        Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties

        Correctly remember the "Show implicit properties" setting as you switch nodes.

        * page/inspector/ResourcePanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 26 Jun 2007 06:52:15 +0000 (06:52 +0000)]

        Reviewed by John.

        <rdar://problem/5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field

        Demonstrates the bug:
        * editing/deleting/5290534-expected.txt: Added.
        * editing/deleting/5290534.html: Added.

        Fixed a bug (an extra br was inserted) and removed a FIXME:
        * editing/deleting/4845371-expected.checksum:
        * editing/deleting/4845371-expected.png:
        * editing/deleting/4845371-expected.txt:
        * editing/deleting/4845371.html:

        Removed an unrendered br that was being incorrectly inserted:
        * editing/deleting/5126166-expected.txt:


        Reviewed by John.

        <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field

        Editing removed a node that was part of a search field's internal
        structure that should not be removed.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
        selection to delete ends at [container, x], where x is the number
        of children in container, don't remove container.  Special case
        code elsewhere in this function will remove it if necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 26 Jun 2007 06:34:38 +0000 (06:34 +0000)]

        Reviewed by Maciej.

        Test for http://bugs.webkit.org/show_bug.cgi?id=11315
        Mutating document.constructor.prototype mutates Object.prototype

        * fast/js/constructor-expected.txt: Added.
        * fast/js/constructor.html: Added.
        * fast/js/resources/constructor.js: Added.


        Reviewed by Maciej.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
        Mutating document.constructor.prototype mutates Object.prototype

        Test: fast/js/constructor.html

        * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
        classes with constructors.  It is an non-enumeratable, non-deletable,
        readonly attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRepair the OS X build.
staikos [Tue, 26 Jun 2007 05:23:00 +0000 (05:23 +0000)]
Repair the OS X build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Really remove LayoutTestResults.
aroben [Tue, 26 Jun 2007 05:12:03 +0000 (05:12 +0000)]
    Really remove LayoutTestResults.

        * LayoutTestResults: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
aroben [Tue, 26 Jun 2007 05:00:17 +0000 (05:00 +0000)]
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

Top Level:

        Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

        Reviewed by Anders.

        * LayoutTestResults: Removed.


        Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

        Reviewed by Anders.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPatch from Adam Treat to make the SQLite icon database optional.
staikos [Tue, 26 Jun 2007 04:56:54 +0000 (04:56 +0000)]
Patch from Adam Treat to make the SQLite icon database optional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEnable running the regression tests on Windows.
aroben [Tue, 26 Jun 2007 04:38:00 +0000 (04:38 +0000)]
Enable running the regression tests on Windows.

These changes were developed alongside the Windows WebKit port and
have been well tested.

Rubberstamped by Sam.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Tue, 26 Jun 2007 04:18:26 +0000 (04:18 +0000)]
    Reviewed by Adam Roben.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
        HTML syntax highlighting colors and DOM tree colors should be the same

        * css/view-source.css:
        * page/inspector/ResourcePanel.js:
        * page/inspector/inspector.css:
        * page/inspector/inspector.js:
        * page/inspector/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple...
aroben [Tue, 26 Jun 2007 03:18:32 +0000 (03:18 +0000)]
Fix Bug 14402: Main resource of apple.com/safari/ is called "www.apple.com" instead of "safari"

The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.

Reviewed by Oliver.

* platform/KURL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
aroben [Tue, 26 Jun 2007 03:09:51 +0000 (03:09 +0000)]
Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff

Reviewed by Mark Rowe.

* Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.
(sub createPatchCommand): Generate a correct diff in the $gitCommit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
kdecker [Tue, 26 Jun 2007 00:56:18 +0000 (00:56 +0000)]
    Reviewed by Darin.

        <rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil

        * WebView/WebView.mm:
        (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because
        our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified
        the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Tue, 26 Jun 2007 00:51:43 +0000 (00:51 +0000)]
    Reviewed by Adam Roben.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
        Web Inspector lists favicon.ico as "other" instead of "image"

        * page/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand pdevenv and supporting scripts/programs
aroben [Tue, 26 Jun 2007 00:43:56 +0000 (00:43 +0000)]
Land pdevenv and supporting scripts/programs

pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:

CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.

parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.

MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.

Rubberstamped by Sam.

* CLWrapper/CLWrapper.cpp: Added.
* CLWrapper/CLWrapper.sln: Added.
* CLWrapper/CLWrapper.vcproj: Added.
* MIDLWrapper/MIDLWrapper.cpp: Added.
* MIDLWrapper/MIDLWrapper.sln: Added.
* MIDLWrapper/MIDLWrapper.vcproj: Added.
* Scripts/parallelcl: Added.
* Scripts/pdevenv: Added.
* vcbin/cl.exe: Added.
* vcbin/midl.exe: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Tue, 26 Jun 2007 00:30:29 +0000 (00:30 +0000)]
    Reviewed by Darin

        - WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs

        * WebView/WebDocumentInternal.h:
        Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
        * WebView/WebHTMLViewPrivate.h:
        Removed declarations for the methods that are now in WebMultipleTextMatches protocol

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
        moved this method into the WebDocumentInternalProtocols portion of the file
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
        (-[WebHTMLView markedTextMatchesAreHighlighted]):
        (-[WebHTMLView unmarkAllTextMatches]):
        (-[WebHTMLView rectsForTextMatches]):

        * WebView/WebView.mm:
        (-[WebView canMarkAllTextMatches]):
        new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
        check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class
        (-[WebView unmarkAllTextMatches]):
        (-[WebView rectsForTextMatches]):

        * WebView/WebViewPrivate.h:
        declared new method canMarkAllTextMatches

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Tue, 26 Jun 2007 00:07:25 +0000 (00:07 +0000)]

        Reviewed by Hyatt.

        Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"

        * fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
        * fast/overflow/hidden-scrollbar-resize-expected.png: Added.
        * fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
        * fast/overflow/hidden-scrollbar-resize.html: Added.


        Reviewed by Hyatt.

        Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"

        Test: fast/overflow/hidden-scrollbar-resize.html

        * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
        Updated our shouldPaint check to consider visibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
oliver [Mon, 25 Jun 2007 22:59:19 +0000 (22:59 +0000)]
    Reviewed by Darin.

        <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info

        Fixing logic error in DragController

        * manual-tests/drop-text-acquires-style.html: Added.
        * page/DragController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Mon, 25 Jun 2007 21:36:46 +0000 (21:36 +0000)]
    Reviewed by Adam Roben.

        Annotate prototypes by adding "Prototype" subtitle.

        * page/inspector/ResourcePanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Mon, 25 Jun 2007 21:29:13 +0000 (21:29 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSome work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
staikos [Mon, 25 Jun 2007 18:20:57 +0000 (18:20 +0000)]
Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Mon, 25 Jun 2007 17:48:13 +0000 (17:48 +0000)]
    Reviewed by Darin

        Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe

        * WebView/WebView.mm:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
        We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of
        that test. That's a bad idea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
aroben [Mon, 25 Jun 2007 16:04:06 +0000 (16:04 +0000)]
 Reviewed by Adam Roben.

        Gdk build fix

        * WebCore.pro: Fix gtk/gdk typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
thatcher [Mon, 25 Jun 2007 14:51:02 +0000 (14:51 +0000)]
    Reviewed by Anders.

        Bug 14385: Web Inspector's computed style doesn't show implicitly set properties

        Add a toggle to show implict computed properties.

        * page/inspector/ResourcePanel.js:
        * page/inspector/inspector.css:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
bdash [Mon, 25 Jun 2007 12:57:31 +0000 (12:57 +0000)]
2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark.

        Use system-provided libjpeg and libpng

        * WebKit.pri: Link against external libjpeg and libpng.

2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark.

        Use system-provided libjpeg and libpng

        * WebCore.pro: Remove bundled libjpeg and libpng sources.
        * platform/image-decoders/jpeg: Remove sources.
        * platform/image-decoders/png: Remove sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-25 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 25 Jun 2007 10:31:54 +0000 (10:31 +0000)]
2007-06-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14202
          Table caption renders too narrow sometimes

        Test: fast/table/caption-relayout.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Mark the caption for layout if the table
        width changed.

2007-06-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14202
          Table caption renders too narrow sometimes

        * fast/table/caption-relayout-expected.checksum: Added.
        * fast/table/caption-relayout-expected.png: Added.
        * fast/table/caption-relayout-expected.txt: Added.
        * fast/table/caption-relayout.html: Added.
        * tables/mozilla/marvin/x_caption_class-expected.checksum:
        * tables/mozilla/marvin/x_caption_class-expected.png:
        * tables/mozilla/marvin/x_caption_class-expected.txt:
        * tables/mozilla/marvin/x_caption_id-expected.checksum:
        * tables/mozilla/marvin/x_caption_id-expected.png:
        * tables/mozilla/marvin/x_caption_id-expected.txt:
        * tables/mozilla/marvin/x_caption_style-expected.checksum:
        * tables/mozilla/marvin/x_caption_style-expected.png:
        * tables/mozilla/marvin/x_caption_style-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
        * tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
        * tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
        * tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
        * tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-25 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 25 Jun 2007 10:29:03 +0000 (10:29 +0000)]
2007-06-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14245
          Underline painted under <br>, not repainted properly

        Test: fast/inline/br-text-decoration.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
        is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
        than their thickness paint correctly.

2007-06-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=14245
          Underline painted under <br>, not repainted properly

        * fast/inline/br-text-decoration-expected.checksum: Added.
        * fast/inline/br-text-decoration-expected.png: Added.
        * fast/inline/br-text-decoration-expected.txt: Added.
        * fast/inline/br-text-decoration.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-25 Matt Perry <mpComplete@gmail.com>
bdash [Mon, 25 Jun 2007 10:27:00 +0000 (10:27 +0000)]
2007-06-25  Matt Perry  <mpComplete@gmail.com>

        Reviewed by Sam Weinig.

        Modify test to wait until the second frame loads, and update its expected output to match.

        * fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
        * fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
        * fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
        * fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-25 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 25 Jun 2007 10:23:33 +0000 (10:23 +0000)]
2007-06-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14341
          rules="none" ignored in certain cases

        Covered by existing tests.

        * html/HTMLTableElement.cpp:

2007-06-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=14341
          rules="none" ignored in certain cases

        * tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
        * tables/mozilla/marvin/table_rules_none-expected.png: Added.
        * tables/mozilla/marvin/table_rules_none-expected.txt: Added.
        * tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
        * tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
        * tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
        * tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
        * tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
        * tables/mozilla_expected_failures/core/table_rules-expected.checksum:
        * tables/mozilla_expected_failures/core/table_rules-expected.png:
        * tables/mozilla_expected_failures/core/table_rules-expected.txt:
        * tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
        * tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
        * tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
        * tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
        * tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Mon, 25 Jun 2007 07:10:13 +0000 (07:10 +0000)]
    Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
        Anchor elements show up as their href in the properties pane, not HTMLAnchorElement

        * page/inspector/ResourcePanel.js: make sure not to call an overriden
        toString() by using Object.prototype.toString.call().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix http://bugs.webkit.org/show_bug.cgi?id=14374
aroben [Mon, 25 Jun 2007 05:09:06 +0000 (05:09 +0000)]
Fix http://bugs.webkit.org/show_bug.cgi?id=14374
Bug 14374: Computed Style section should be expanded by default

Reviewed by Sam.

No regression test possible.

* page/inspector/ResourcePanel.js: Expand all style sections.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnify the style of enums in the Inspector JS
aroben [Mon, 25 Jun 2007 00:28:13 +0000 (00:28 +0000)]
Unify the style of enums in the Inspector JS

All our enums are now represented by an object with a property for
each enum value.

Reviewed by Sam.

No regression test possible.

* page/inspector/ConsolePanel.js:
* page/inspector/Resource.js:
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
weinig [Sun, 24 Jun 2007 20:59:01 +0000 (20:59 +0000)]
    Reviewed by Adam Roben.

        Fix broken link.

        * building/build.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Sun, 24 Jun 2007 20:53:07 +0000 (20:53 +0000)]

        Reviewed by Mitz.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=14321
        getComputedStyle(...).zIndex returns string "normal"

        * fast/css/computed-style-expected.txt:
        * fast/css/getComputedStyle-zIndex-auto-expected.txt: Added.
        * fast/css/getComputedStyle-zIndex-auto.html: Added.


        Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
        getComputedStyle(...).zIndex returns string "normal"

        Test: fast/css/getComputedStyle-zIndex-auto.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
pewtermoose [Sun, 24 Jun 2007 19:22:55 +0000 (19:22 +0000)]
    Reviewed by Tim Hatcher.

        Bug 14265: Cannot resize columns in webinspector

        * page/inspector/inspector.css:
        * page/inspector/inspector.html:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded Bugzilla bug number for revision 23727.
ddkilzer [Sun, 24 Jun 2007 18:51:58 +0000 (18:51 +0000)]
Added Bugzilla bug number for revision 23727.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-23 Mark Rowe <mrowe@apple.com>
bdash [Sun, 24 Jun 2007 00:37:48 +0000 (00:37 +0000)]
2007-06-23  Mark Rowe  <mrowe@apple.com>

        Not reviewed.

        * building/checkout.html: Update link to bypass caching proxy as it has a habit of breaking huge downloads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Uploading the correct expected results -- the ones checked in expected
ggaren [Sat, 23 Jun 2007 19:23:44 +0000 (19:23 +0000)]
    Uploading the correct expected results -- the ones checked in expected
        an "unkown" callback, which was incorrect behavior.

        * fast/loader/user-style-sheet-resource-load-callbacks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the "num-cpus not found" warning the Windows WebCore build emits
aroben [Sat, 23 Jun 2007 18:35:50 +0000 (18:35 +0000)]
Fix the "num-cpus not found" warning the Windows WebCore build emits


        Silence a build warning about not finding `num-cpus`

        Reviewed by Mark Rowe.

        * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new


        Land num-cpus for the Windows build.

        Reviewed by Mark Rowe.

        * Scripts/num-cpus: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded support for populating ChangeLog entries from given git commits
hausmann [Sat, 23 Jun 2007 08:49:16 +0000 (08:49 +0000)]
Added support for populating ChangeLog entries from given git commits
using --git-commit=<commitish> and --git-reviewer=<name>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff and Darin.
adele [Fri, 22 Jun 2007 23:06:30 +0000 (23:06 +0000)]
    Reviewed by Geoff and Darin.

        Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name

        * Misc/WebNSURLExtras.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Fri, 22 Jun 2007 22:19:09 +0000 (22:19 +0000)]
    Reviewed by Darin.

        * plugins/win/PluginStreamWin.cpp:
        No need to fetch the size from resourceData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Fri, 22 Jun 2007 22:16:26 +0000 (22:16 +0000)]
    Reviewed by Darin.

        Crash playing a very large QuickTime movie inside Safari.

        Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for
        plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.

        * plugins/win/PluginStreamWin.cpp:
        * plugins/win/PluginStreamWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
bdakin [Fri, 22 Jun 2007 22:03:56 +0000 (22:03 +0000)]

        Reviewed by Oliver and Darin.

        Tests for <rdar://problem/5266999> Loading page from MangleMe fuzz
        tester crashes in RenderTableRow::addChild (giant ROWSPAN)

        The results of this test have changed because we now clamp rowspan
        at 8190 to match Firefox.
        * fast/table/giantRowspan-expected.checksum:
        * fast/table/giantRowspan-expected.png:
        * fast/table/giantRowspan-expected.txt:

        A new test that crashes our old heuristic for too-large rowspan,
        but succeeds with the new one.
        * fast/table/giantRowspan2-expected.checksum: Added.
        * fast/table/giantRowspan2-expected.png: Added.
        * fast/table/giantRowspan2-expected.txt: Added.
        * fast/table/giantRowspan2.html: Added.


        Reviewed by Oliver and Darin.

        Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz
        tester crashes in RenderTableRow::addChild (giant ROWSPAN)

        We already have code that tries to prevent allocating too-large
        rowspans. The rowspan in this test, however, was small enough that
        we thought it was okay in that code, even though clearly it was
        still too large. I did a bunch of testing in Firefox, and it seems
        that they set a hard limit on the maximum rowspan right in the DOM
        -- 8k. So that is what this patch implements.

        * html/HTMLTableCellElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Fri, 22 Jun 2007 21:57:24 +0000 (21:57 +0000)]

        Reviewed by Darin.

        <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines when pressing return

        Demonstrates bug:
        * editing/deleting/5272440-expected.checksum: Added.
        * editing/deleting/5272440-expected.png: Added.
        * editing/deleting/5272440-expected.txt: Added.
        * editing/deleting/5272440.html: Added.

        upstream() now works for the positions visually equivalent to [span, 0]
        where span is an inline root editable element:
        * editing/deleting/delete-mixed-editable-content-001-expected.txt:


        Reviewed by Darin.

        <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete

        Deletion inserts a placeholder after it removes full paragraphs if
        one doesn't already exist.  The code that looked for a pre-existing
        placeholder didn't work because of a bug in enclosingNodeOfType.

        * editing/htmlediting.cpp:
        (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
        but don't go above an editing root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add result.
andersca [Fri, 22 Jun 2007 19:47:00 +0000 (19:47 +0000)]
    Add result.

        * fast/loader/user-style-sheet-resource-load-callbacks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
andersca [Fri, 22 Jun 2007 19:04:58 +0000 (19:04 +0000)]

        Reviewed by Geoff.

        WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)

        * fast/loader/resources/user-style-sheet.css: Added.
        * fast/loader/user-style-sheet-resource-load-callbacks.html: Added.


        Reviewed by Maciej and Geoff.

        WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)

        Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
        loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks
        argument to a bunch of classes).

        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * loader/MainResourceLoader.cpp:
        * loader/Request.cpp:
        * loader/Request.h:
        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        * loader/SubresourceLoader.h:
        * loader/loader.cpp:
        * loader/loader.h:
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
thatcher [Fri, 22 Jun 2007 18:27:02 +0000 (18:27 +0000)]

        Reviewed by Anders.

        <rdar://problem/5228168> Leopard regression test failures: fast/applescript

        New results to match the DumpRenderTree changes.

        * fast/AppleScript/001-expected.txt:
        * fast/AppleScript/array-expected.txt:
        * fast/AppleScript/date-expected.txt:


        Reviewed by Anders.

        <rdar://problem/5228168> Leopard regression test failures: fast/applescript

        There were some changes in Leopard that made our test output inconsistent with Tiger.

        NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
        on Leopard, so output our own readable string for typeType descriptors.

        NSArray's description also changed on Leopard to output more whitespace, so
        make our own string representation for typeAEList descriptors. This requires
        a special case typeUnicodeText too, so the output is a quoted string.

        * DumpRenderTree/AppleScriptController.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
thatcher [Fri, 22 Jun 2007 16:56:00 +0000 (16:56 +0000)]
    Reviewed by Tim Hatcher.

        Bug 14305: Web Inspector marks local files with server-side compression tip

        * page/inspector/Resource.js:
        (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
        from being given to local files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-06-21 Mark Rowe <mrowe@apple.com>
bdash [Fri, 22 Jun 2007 07:00:51 +0000 (07:00 +0000)]
2007-06-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
        a length of zero when the string is collapsed to empty by whitespace simplification.

2007-06-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin.

        Test for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading

        * fast/frames/frame-set-whitespace-attributes-expected.txt: Added.
        * fast/frames/frame-set-whitespace-attributes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix large font size crash on Windows.
hyatt [Fri, 22 Jun 2007 06:05:41 +0000 (06:05 +0000)]
Fix large font size crash on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Timothy.
andrew [Fri, 22 Jun 2007 05:01:54 +0000 (05:01 +0000)]
    Reviewed by Timothy.

        Stop shift+scroll wheel performing a horizontal scroll in Web Inspector

        * page/inspector/inspector.css: Set body margin to 0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove some empty directories.
thatcher [Fri, 22 Jun 2007 04:11:53 +0000 (04:11 +0000)]
Remove some empty directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPatch from Adam Treat to implement default icons / resources for Qt. Also does
staikos [Fri, 22 Jun 2007 03:29:41 +0000 (03:29 +0000)]
Patch from Adam Treat to implement default icons / resources for Qt.  Also does
a small cleanup to QWebPage::icon.  This is a great example of how QWebSettings
is not ideal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
oliver [Fri, 22 Jun 2007 01:40:19 +0000 (01:40 +0000)]
    Reviewed by Darin.

        Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
        and makes reference handling simpler in advance of IME refactoring.

        * WebCore.xcodeproj/project.pbxproj:
        * page/mac/EventHandlerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Antti.
weinig [Fri, 22 Jun 2007 00:41:29 +0000 (00:41 +0000)]
    Reviewed by Antti.

        Remove empty directories

        * WebInspector/webInspector: directory removed.
        * WebInspector/webInspector/Images: directory removed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd rendered and stylable scrollbars for Qt
staikos [Fri, 22 Jun 2007 00:26:00 +0000 (00:26 +0000)]
Add rendered and stylable scrollbars for Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 21 Jun 2007 23:05:08 +0000 (23:05 +0000)]

        Reviewed by Dave Hyatt.

        Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
        REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
        effects when clicking on its links (12646)

        Added layout test for this bug:

        * fast/invalid/nestedh3s-rapidweaver-expected.txt: Added.
        * fast/invalid/nestedh3s-rapidweaver.html: Added.

        Reversed the expected results for this test because I rolled out r7703:

        * fast/invalid/nestedh3s-expected.checksum:
        * fast/invalid/nestedh3s-expected.png:
        * fast/invalid/nestedh3s-expected.txt:
        * fast/invalid/nestedh3s.html:


        Reviewed by Dave Hyatt.

        Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
        REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
        effects when clicking on its links (12646)

        I'm rolling our r7703 for these reasons:

        1. It broke RapidWeaver.

        2. WebKit is now orders of magnitude faster when handling deep nesting
        (5 seconds vs 3 minutes on my MBP in this particular case).

        3. Firefox, IE, and HTML5 all allow nested heading tags.

        4. Hyatt said so.

        * html/HTMLParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
weinig [Thu, 21 Jun 2007 22:34:56 +0000 (22:34 +0000)]
    Reviewed by Tim Hatcher.

        Remove assert for now as it is causing the back button to not
        work in debug builds.

        * page/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim.
justing [Thu, 21 Jun 2007 21:45:49 +0000 (21:45 +0000)]
    Reviewed by Tim.

        REGRESSION: Keyboard commands don't work in a message window until you click inside the message

        When you open a message in its own window, Mail creates an empty
        WebView, makes that WebView firstResponder and then sets off a
        load inside that WebView.

        When we're asked to create the empty WebView, we put an empty
        WebHTMLView inside it (in r21367 we began creating a document
        for empty frames).  When Mail makes the WebView first responder
        we make that empty WebHTMLView firstResponder.  Then when the
        load finishes we create a new WebHTMLView and set it as the
        document view.

        Inside _setDocumentView, if the old document view or one of its
        descendants was the first responder, we'd makeFirstResponder:nil
        so that the window wouldn't be left with a firstResponder that
        was no longer inside of it.  This change fixes the bug by instead
        transferring firstResponder status to the new document view.

        We could also fix this by not allowing the WebHTMLView to become
        firstResponder when it's in the provisional state mentioned above.

        * WebView/WebFrameView.mm:
        (-[WebFrameView _setDocumentView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning
thatcher [Thu, 21 Jun 2007 21:26:32 +0000 (21:26 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
andersca [Thu, 21 Jun 2007 21:14:12 +0000 (21:14 +0000)]

        Reviewed by Geoff.

        Update test results.

        * http/tests/loading/bad-scheme-subframe-expected.txt:
        * http/tests/loading/bad-server-subframe-expected.txt:
        * http/tests/loading/basic-expected.txt:
        * http/tests/loading/empty-subframe-expected.txt:
        * http/tests/loading/simple-subframe-expected.txt:
        * webarchive/loading/test-loading-archive-expected.txt:


        Reviewed by Geoff.

        Don't dump didFirstLayout callbacks, they happen intermittently.

        * DumpRenderTree/FrameLoadDelegate.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove some debug output.
lars [Thu, 21 Jun 2007 20:30:39 +0000 (20:30 +0000)]
Remove some debug output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Thu, 21 Jun 2007 20:21:59 +0000 (20:21 +0000)]
    Reviewed by Geoff.

        Update test result.

        * fast/dom/xmlhttprequest-invalid-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt Mac OS X build
staikos [Thu, 21 Jun 2007 19:28:51 +0000 (19:28 +0000)]
Fix the Qt Mac OS X build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoupdate test results after my font refactoring.
lars [Thu, 21 Jun 2007 19:19:30 +0000 (19:19 +0000)]
update test results after my font refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
ap [Thu, 21 Jun 2007 19:01:30 +0000 (19:01 +0000)]
    Reviewed by Anders.

        REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding

        Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
        (regardless of the actual response MIME type). This was corrected a while ago to match other
        browsers and the draft XHR spec.

        Now restoring this functionality for "text/html", with spec editor's blessing.

        * xml/xmlhttprequest.cpp:
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele
sullivan [Thu, 21 Jun 2007 18:15:19 +0000 (18:15 +0000)]
    Reviewed by Adele

        - fixed <rdar://problem/5268673> REGRESSION: Context menu missing for PDF in frame when there's no selection

        This was surprisingly interesting. It turns out that at least for Safari, the method [WebDefaultUIDelegate
        webView:contextMenuItemsForElement:defaultMenuItems:] is only exercised from WebPDFView these days. It mimics
        some of the code that was moved to WebCore as part of the Great Context Menu Refactoring of 2006, but is
        independent of that code. And it was partly broken/incomplete, probably as a result of said refactoring.

        * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
        deleted this function since I removed all callers
        (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
        Handle WebMenuItemTagOpenFrameInNewWindow tag, since code later in this file was relying on it. Added
        ASSERT_NOT_REACHED to the default case, since returning nil from this method is bad.
        Also, use WebKit versions of menu title strings rather than AppKit versions. We added these strings to WebKit
        a while back so we don't need to sneakily find them in AppKit anymore.
        (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
        make the WebView be the target of the Open Frame in New Window item; previously it was self, but that was
        just silly (probably a leftover from some code shuffling when context menus were reimplemented)

        * WebView/WebView.mm:
        (-[WebView _openFrameInNewWindowFromMenu:]):
        new method, used by Open Frame in New Window menu item.

        * WebView/WebViewInternal.h:
        Declare new method used by menu item. This isn't necessary for compilation, but could prevent the accidental
        deletion of the method implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Mac build fix.
andrew [Thu, 21 Jun 2007 14:09:27 +0000 (14:09 +0000)]
    Mac build fix.

        * platform/Font.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoanother small fix for letter spacing
lars [Thu, 21 Jun 2007 11:02:04 +0000 (11:02 +0000)]
another small fix for letter spacing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix word-spacing
lars [Thu, 21 Jun 2007 11:01:49 +0000 (11:01 +0000)]
fix word-spacing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix letterspacing and small caps.
lars [Thu, 21 Jun 2007 11:01:35 +0000 (11:01 +0000)]
fix letterspacing and small caps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agostore the metrics and space width in the Font object
lars [Thu, 21 Jun 2007 11:01:21 +0000 (11:01 +0000)]
store the metrics and space width in the Font object

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agosimplify some codepaths
lars [Thu, 21 Jun 2007 11:01:08 +0000 (11:01 +0000)]
simplify some codepaths

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix copyright header
lars [Thu, 21 Jun 2007 11:00:53 +0000 (11:00 +0000)]
fix copyright header

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agocorrectly load fonts when a list of font families is given
lars [Thu, 21 Jun 2007 11:00:39 +0000 (11:00 +0000)]
correctly load fonts when a list of font families is given

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix some more of the font support
lars [Thu, 21 Jun 2007 11:00:20 +0000 (11:00 +0000)]
fix some more of the font support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agolook for the Qt library in the installed location
lars [Thu, 21 Jun 2007 11:00:08 +0000 (11:00 +0000)]
look for the Qt library in the installed location

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCompile fixes
lars [Thu, 21 Jun 2007 10:59:57 +0000 (10:59 +0000)]
Compile fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSome more work on the implementation of FontQt.
lars [Thu, 21 Jun 2007 10:59:45 +0000 (10:59 +0000)]
Some more work on the implementation of FontQt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoStarted work on the new font infrastructure for the Qt port.
lars [Thu, 21 Jun 2007 10:59:21 +0000 (10:59 +0000)]
Started work on the new font infrastructure for the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMore Gdk build fixes.
aroben [Thu, 21 Jun 2007 07:49:18 +0000 (07:49 +0000)]
More Gdk build fixes.

* page/gdk/ContextMenuClientGdk.cpp:
* page/gdk/ContextMenuClientGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeculative Gdk build fix.
aroben [Thu, 21 Jun 2007 07:25:17 +0000 (07:25 +0000)]
Speculative Gdk build fix.

* page/InspectorController.h: Only include the JS headers we really
need to avoid pulling in ones like JSStringRefCF.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Simon Hausmann.
aroben [Thu, 21 Jun 2007 07:00:09 +0000 (07:00 +0000)]
Reviewed by Simon Hausmann.

More Gdk build fixing.

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23699 268f45cc-cd09-0410-ab3c-d52691b4dbfc