WebKit-https.git
9 years ago2011-04-20 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Wed, 20 Apr 2011 21:57:07 +0000 (21:57 +0000)]
2011-04-20  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dirk Schulze.

        Tests for crash when copying a filter effect after applying tranforms.
        https://bugs.webkit.org/show_bug.cgi?id=57885

        * svg/filters/svg-transform-blur-crash-expected.txt: Added.
        * svg/filters/svg-transform-blur-crash.xhtml: Added.
2011-04-20  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dirk Schulze.

        Return early when the paint rect and the source rect do not overlap as no bytes need to be copied.
        https://bugs.webkit.org/show_bug.cgi?id=57885

        Test: svg/filters/svg-transform-blur-crash.xhtml

        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::copyImageBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
ossy@webkit.org [Wed, 20 Apr 2011 21:48:08 +0000 (21:48 +0000)]
2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        Add the default template for builder page.

        https://bugs.webkit.org/show_bug.cgi?id=59008

        * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 20 Apr 2011 21:45:30 +0000 (21:45 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        move page generation into a single function
        https://bugs.webkit.org/show_bug.cgi?id=59027

        Now executing the script doesn't create any state. We should then
        be able to write tests for this by setting custom results data.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 20 Apr 2011 21:39:16 +0000 (21:39 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        move global state into a shared object
        https://bugs.webkit.org/show_bug.cgi?id=59023

        This makes the code more testable.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport DataView in workers
jianli@chromium.org [Wed, 20 Apr 2011 21:38:02 +0000 (21:38 +0000)]
Support DataView in workers
https://bugs.webkit.org/show_bug.cgi?id=59014

Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/worker-data-view-test.html

* workers/WorkerContext.idl: Expose DataView constructor.

LayoutTests:

* fast/canvas/webgl/resources/worker-data-view-test.js: Added.
* fast/canvas/webgl/worker-data-view-test-expected.txt: Added.
* fast/canvas/webgl/worker-data-view-test.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 21:33:46 +0000 (21:33 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Cleanup .checksum files that don't have .png files.

        If the test is marked as failing, just delete the .checksum file.
        If the test is marked as passing, put it in test_expectations.txt so
        the bots will generate results.

        * platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/positioned-document-element-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/text/basic/014-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum: Removed.
        * platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Removed.
        * platform/chromium-mac/tables/mozilla/core/misc-expected.checksum: Removed.
        * platform/chromium-win/fast/forms/searchfield-heights-expected.checksum: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 20 Apr 2011 21:09:00 +0000 (21:09 +0000)]
2011-04-20  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
        https://bugs.webkit.org/show_bug.cgi?id=57868

        Running CACFAnimations aren't remembered when layer tree is unparented and
        then reparented. Added a new ensureAnimationsSubmitted function to
        PlatformCALayer to traverse the tree and resubmit animations, setting the
        beginTime to the original start time of the animation. This is called in WK2
        when layer tree is newly parented.

        I also consolidated currentTimeToMediaTime into PlatformCALayer so it can be shared
        between PlatformCALayer and GraphicsLayerCA.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        * platform/graphics/ca/PlatformCAAnimation.h:
            Remember actual animation start time in CACFAnimation beginTime property
        * platform/graphics/ca/PlatformCALayer.h:
            New ensureAnimationsSubmitted function which traverses layers and resubmits all animations
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        * platform/graphics/ca/win/PlatformCALayerWin.cpp:

2011-04-20  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
        https://bugs.webkit.org/show_bug.cgi?id=57868

        Subclassed setRootCompositingLayer so it can call ensureAnimationsSubmitted on Win.

        * WebProcess/WebPage/ca/LayerTreeHostCA.h:
            Make setRootCompositingLayer protected so it can be called from subclass
        * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
            Override setRootCompositingLayer to add call to root layer's
            PlatformCALayer::ensureAnimationsSubmitted method
        * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 20 Apr 2011 21:02:48 +0000 (21:02 +0000)]
2011-04-20  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>
        https://bugs.webkit.org/show_bug.cgi?id=58795

        Not possible to test automatically, verified manually.

        * WebCore.exp.in: Export new media download cache functions.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register cache management functions.
        (WebCore::MediaPlayerPrivateQTKit::getSitesInMediaCache): New, return cache origins.
        (WebCore::MediaPlayerPrivateQTKit::clearMediaCache): New, empty the media cache.
        (WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite): New, delete files in the media
            cache for one origin.

        * platform/mac/WebCoreSystemInterface.h: Add new WKSI functions.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2011-04-20  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>
        https://bugs.webkit.org/show_bug.cgi?id=58795

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:

2011-04-20  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Initialize new functions.

2011-04-18  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Initialize new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 21:00:10 +0000 (21:00 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, fix duplicate expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59022 - DFG JIT - Optimize branch-on-relational-compare
barraclough@apple.com [Wed, 20 Apr 2011 20:47:53 +0000 (20:47 +0000)]
Bug 59022 - DFG JIT - Optimize branch-on-relational-compare

Reviewed by Oliver Hunt.

If a relational compare (< or <=) is immediately followed by a branch,
we can combine the two, avoiding generation of a boolean into a register.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::invert):
(JSC::MacroAssemblerX86Common::commute):
* dfg/DFGNode.h:
(JSC::DFG::Node::adjustedRefCount):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isJSConstantWithInt32Value):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 20:47:31 +0000 (20:47 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 20 Apr 2011 20:28:49 +0000 (20:28 +0000)]
2011-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] DRT sideeffect revealed by r63657 and r75305
        https://bugs.webkit.org/show_bug.cgi?id=42578

        Unskip tests passing since r76958

        The NetworkAccessManager's authentication cache is getting
        cleared now on every page load, so these no longer leak
        credentials between tests.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 20 Apr 2011 20:05:27 +0000 (20:05 +0000)]
2011-04-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Simon Fraser.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        Support different radii for horizontal and vertical blurring in ShadowBlur. This is a preperation for feDropShadow.
        feDropShadow is a new shorthand filter effect for the up-comming Filter 1.0 specification and will use ShadowBlur.
        feGaussianBlur might make use of ShadowBlur as well later (on SourceAlpha input).
        Added ShadowBlur to remaining platforms.

        The changes can't be tested before the changes in feGaussianBlur or feDropShadow. Current behavior is not affected.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.pro:
        * platform/graphics/FloatSize.h:
        (WebCore::FloatSize::scale):
        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ScratchBuffer::ScratchBuffer):
        (WebCore::ScratchBuffer::setLastShadowValues):
        (WebCore::ScratchBuffer::setLastInsetShadowValues):
        (WebCore::ScratchBuffer::matchesLastShadow):
        (WebCore::ScratchBuffer::matchesLastInsetShadow):
        (WebCore::ScratchBuffer::clearScratchBuffer):
        (WebCore::ShadowBlur::ShadowBlur):
        (WebCore::calculateLobes):
        (WebCore::ShadowBlur::blurLayerImage):
        (WebCore::ShadowBlur::adjustBlurRadius):
        (WebCore::ShadowBlur::calculateLayerBoundingRect):
        (WebCore::computeSliceSizesFromRadii):
        (WebCore::ShadowBlur::templateSize):
        (WebCore::ShadowBlur::drawInsetShadowWithTiling):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):
        (WebCore::ShadowBlur::drawLayerPieces):
        * platform/graphics/ShadowBlur.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::fillRectWithRoundedHole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-07 Victoria Kirst <vrk@google.com>
vrk@chromium.org [Wed, 20 Apr 2011 19:56:52 +0000 (19:56 +0000)]
2011-03-07  Victoria Kirst  <vrk@google.com>

        Reviewed by Mihai Parparita.

        Make LayoutTests robust to latency btwn playing event and frame rendering
        https://bugs.webkit.org/show_bug.cgi?id=55918

        * media/controls-after-reload.html:
        * media/controls-without-preload.html:
        * media/video-paint-test.js:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Taiju TSUIKI <tzik@google.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 19:54:08 +0000 (19:54 +0000)]
2011-04-20  Taiju TSUIKI  <tzik@google.com>

        Reviewed by David Levin.

        Add overwrite copy/move tests for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=58864

        * fast/filesystem/op-copy-expected.txt:
        * fast/filesystem/op-move-expected.txt:
        * fast/filesystem/resources/op-copy.js:
        * fast/filesystem/resources/op-move.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding myself to committer list
mahesh.kulkarni@nokia.com [Wed, 20 Apr 2011 19:48:17 +0000 (19:48 +0000)]
Adding myself to committer list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 19:38:49 +0000 (19:38 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/chromium-linux*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 20 Apr 2011 19:21:59 +0000 (19:21 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        add expandAll/collapseAll links
        https://bugs.webkit.org/show_bug.cgi?id=59011

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
yael.aharon@nokia.com [Wed, 20 Apr 2011 19:18:32 +0000 (19:18 +0000)]
Unreviewed.

Adjust Windows results after r84398.

* platform/win/fast/borders: Added.
* platform/win/fast/borders/bidi-012-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 19:13:12 +0000 (19:13 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/chromium-win*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoARMv7 build fix II.
barraclough@apple.com [Wed, 20 Apr 2011 19:09:51 +0000 (19:09 +0000)]
ARMv7 build fix II.

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoARMv7 build fix.
barraclough@apple.com [Wed, 20 Apr 2011 19:02:01 +0000 (19:02 +0000)]
ARMv7 build fix.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::test8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 20 Apr 2011 18:54:13 +0000 (18:54 +0000)]
2011-04-20  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] expose title text direction on WebDataSource
        https://bugs.webkit.org/show_bug.cgi?id=59010

        * public/WebDataSource.h:
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::pageTitle):
        (WebKit::WebDataSourceImpl::pageTitleDirection):
        * src/WebDataSourceImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRationalize MacroAssembler branch methods
barraclough@apple.com [Wed, 20 Apr 2011 18:44:35 +0000 (18:44 +0000)]
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950

Reviewed by Oliver Hunt.

The MacroAssembler currently exposes x86's weird behaviour that the 'setcc'
instruction only sets the low 8 bits of a register. Stop that.

Having done so, to clarify remove the 'set32' prefix from test & compare
instructions - these methods all now set a full 32/64 bit register (Ptr size).
The size in the function name should indicate the amount of data being compared.

Also split out the 'Condition' enum into 'RelationalCondition' and
'ResultCondition'. The former is used in binary comparison, the latter is a unary
condition check on the result of an operation.

* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branch16):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::comparePtr):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::branchTest8):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARM::branch16):
(JSC::MacroAssemblerARM::branchTest8):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::branchNeg32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::test8):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ARMCondition):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branch32):
(JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest32):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::branchAdd32):
(JSC::MacroAssemblerARMv7::branchMul32):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::branchSub32):
(JSC::MacroAssemblerARMv7::compare32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::test8):
(JSC::MacroAssemblerARMv7::branchPtrWithPatch):
(JSC::MacroAssemblerARMv7::makeBranch):
(JSC::MacroAssemblerARMv7::armV7Condition):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::branch16):
(JSC::MacroAssemblerMIPS::branchTest32):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchOr32):
(JSC::MacroAssemblerMIPS::compare32):
(JSC::MacroAssemblerMIPS::test8):
(JSC::MacroAssemblerMIPS::test32):
(JSC::MacroAssemblerMIPS::branchPtrWithPatch):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branch32):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch8):
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
(JSC::MacroAssemblerX86Common::branchNeg32):
(JSC::MacroAssemblerX86Common::branchOr32):
(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::x86Condition):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::comparePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr):
(JSC::MacroAssemblerX86_64::branchSubPtr):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::branchTest8):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace bidi-004.html with its new version.
yael.aharon@nokia.com [Wed, 20 Apr 2011 18:15:04 +0000 (18:15 +0000)]
Replace bidi-004.html with its new version.
https://bugs.webkit.org/show_bug.cgi?id=58984

Reviewed by Eric Seidel.

* fast/borders/bidi-004.html: Removed.
* fast/borders/bidi-012.html: Added.
* platform/chromium-linux/fast/borders/bidi-004-expected.png: Removed.
* platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Removed.
* platform/chromium-win/fast/borders/bidi-004-expected.png: Removed.
* platform/chromium-win/fast/borders/bidi-004-expected.txt: Removed.
* platform/gtk/fast/borders/bidi-004-expected.checksum: Removed.
* platform/gtk/fast/borders/bidi-004-expected.png: Removed.
* platform/gtk/fast/borders/bidi-004-expected.txt: Removed.
* platform/mac/fast/borders/bidi-004-expected.checksum: Removed.
* platform/mac/fast/borders/bidi-004-expected.png: Removed.
* platform/mac/fast/borders/bidi-004-expected.txt: Removed.
* platform/mac/fast/borders/bidi-012-expected.checksum: Added.
* platform/mac/fast/borders/bidi-012-expected.png: Added.
* platform/mac/fast/borders/bidi-012-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed typo fix.
ossy@webkit.org [Wed, 20 Apr 2011 18:09:37 +0000 (18:09 +0000)]
Unreviewed typo fix.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
kevino@webkit.org [Wed, 20 Apr 2011 17:57:58 +0000 (17:57 +0000)]
[wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 17:46:28 +0000 (17:46 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/google*,
        platform/chromium-gpu*, platform/chromium-mac*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 20 Apr 2011 17:25:33 +0000 (17:25 +0000)]
2011-04-19  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
        https://bugs.webkit.org/show_bug.cgi?id=52963

        .) Change base class of ShadowRoot from DocumentFragment to TreeScope.
        .) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
        .) Merged setTreeScope() with setTreeScopeRecursively()
        .) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
        .) Adapt JavaScript Node wrappers (temporary code - see https://bugs.webkit.org/show_bug.cgi?id=58704).

        No new tests. (refactoring)

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::toV8Slow):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::takeAllChildrenFrom):
        (WebCore::ContainerNode::removeBetween):
        (WebCore::ContainerNode::removeChildren):
        (WebCore::ContainerNode::parserAddChild):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::setDocType):
        * dom/Element.h:
        * dom/Node.cpp:
        (WebCore::Node::treeScope):
        (WebCore::Node::setTreeScopeRecursively):
        * dom/Node.h:
        (WebCore::Node::document):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::ShadowRoot):
        (WebCore::ShadowRoot::~ShadowRoot):
        (WebCore::ShadowRoot::nodeType):
        (WebCore::ShadowRoot::cloneNode):
        (WebCore::ShadowRoot::childTypeAllowed):
        * dom/ShadowRoot.h:
        (WebCore::toShadowRoot):
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::setParentTreeScope):
        * dom/TreeScope.h:
        * rendering/RenderSlider.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 17:24:37 +0000 (17:24 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/mac-*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] WebProcess crashes intermittently: "FAIL: TestControllerRunLoop timed out."
ossy@webkit.org [Wed, 20 Apr 2011 17:16:09 +0000 (17:16 +0000)]
[Qt][WK2] WebProcess crashes intermittently: "FAIL: TestControllerRunLoop timed out."

* platform/qt-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/media-src-blocked.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Skip new failing tests.
ossy@webkit.org [Wed, 20 Apr 2011 17:09:34 +0000 (17:09 +0000)]
[Qt][WK2] Skip new failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 20 Apr 2011 17:06:57 +0000 (17:06 +0000)]
2011-04-20  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Dan Bernstein.

        Update fast/canvas/font-update.html to use dumpAsText.
        https://bugs.webkit.org/show_bug.cgi?id=59003

        * fast/canvas/font-update-expected.txt:
        * fast/canvas/font-update.html: This test is only useful as a pixel test. Dumping the render tree will always show the same thing regardless of what's done on the canvas in the test. However, with new render tree schemes (canvases in layers and such) the render trees will even look different but not actually failing what the test tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 17:00:09 +0000 (17:00 +0000)]
2011-04-20  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Update front-end files list in WebCore.vcproj
        https://bugs.webkit.org/show_bug.cgi?id=58896

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Mike Reed <reed@google.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 16:55:47 +0000 (16:55 +0000)]
2011-04-20  Mike Reed  <reed@google.com>

        Reviewed by Steve Block.

        prepare tests for rebaselining
        https://bugs.webkit.org/show_bug.cgi?id=58989

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 16:47:14 +0000 (16:47 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Fixed lint errors in test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 20 Apr 2011 16:46:31 +0000 (16:46 +0000)]
2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Qt build fix after r84380.

        * css/CSSPrimitiveValueMappings.h: Moved EBorderCollapse-related casts from under ENABLE(SVG) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 16:41:20 +0000 (16:41 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Remove crash expectation for http/tests/local/formdata/send-form-data-with-sliced-file.html
        https://bugs.webkit.org/show_bug.cgi?id=59004

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 20 Apr 2011 16:39:45 +0000 (16:39 +0000)]
2011-04-20  Alejandro G. Castro  <alex@igalia.com>

        Fixed GTK+ compilation after r84206.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 16:24:25 +0000 (16:24 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Adjust test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=59002

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 20 Apr 2011 16:21:24 +0000 (16:21 +0000)]
2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Build libWebCore with the gtk sources too
        https://bugs.webkit.org/show_bug.cgi?id=58968

        In some cases webcore files are compiled twice, so it improves the
        build time.

        * GNUmakefile.am: Add webcore gtk sources to libWebCore sources.
2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Build libWebCore with the gtk sources too
        https://bugs.webkit.org/show_bug.cgi?id=58968

        In some cases webcore files are compiled twice, so it improves the
        build time.

        * GNUmakefile.am: Remove webcore gtk sources from libwebkitgtk
        sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 16:14:37 +0000 (16:14 +0000)]
2011-04-20  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.
        https://bugs.webkit.org/show_bug.cgi?id=58964

        No new tests as no new functionality added.

        * css/CSSPrimitiveValueMappings.h:
        Support casting to/from EBorderCollapse.
        * css/CSSStyleSelector.cpp:
        Use new casting ability to simplify code.
        * rendering/style/RenderStyle.h:
        Use EBorderCollapse instead of a bool for representing border collapse member variable.
        * rendering/style/RenderStyleConstants.h:
        Added EBorderCollapse enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows 7 SP1 baselines for some SVG tests that progressed in SP1
aroben@apple.com [Wed, 20 Apr 2011 16:11:45 +0000 (16:11 +0000)]
Add Windows 7 SP1 baselines for some SVG tests that progressed in SP1

These baselines were previously thought to be WebKit2-specific. However, it turned out that
the WebKit2 bots had Windows 7 SP1 installed, while the WebKit1 bots just had Windows 7
installed, and that was the crucial difference. So this patch reclassifies the new baselines
as being SP1 vs. not-SP1, rather than WK2 vs. WK1. I also added pixel results.

Fixes <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
differences from Windows 7 "SP0"

* platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
* platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/win-7sp0/svg/text/bidi-text-query-expected.checksum:
* platform/win-7sp0/svg/text/bidi-text-query-expected.png:
* platform/win-7sp0/svg/text/bidi-text-query-expected.txt:
Copied these results from platform/win.

* platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/win-wk2/svg/text/bidi-text-query-expected.txt:
Moved these results to platform/win.

* platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
* platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
* platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/win/svg/text/bidi-text-query-expected.checksum:
* platform/win/svg/text/bidi-text-query-expected.png:
* platform/win/svg/text/bidi-text-query-expected.txt:
The .txt files came from platform/win-wk2, and the .png/.checksum files were
newly-generated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 20 Apr 2011 16:05:56 +0000 (16:05 +0000)]
2011-04-20  Martin Robinson  <mrobinson@igalia.com>

        platform/gtk/fast/dom/gc-10-expected.png is corrupt
        https://bugs.webkit.org/show_bug.cgi?id=58940

        Remove expected results for fast/dom/gc-10.html since it is crashing on GTK+.

        * platform/gtk/fast/dom/gc-10-expected.checksum: Removed.
        * platform/gtk/fast/dom/gc-10-expected.png: Removed.
        * platform/gtk/fast/dom/gc-10-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace old-run-webkit-tests's win-7 platform with win-7sp0
aroben@apple.com [Wed, 20 Apr 2011 16:05:36 +0000 (16:05 +0000)]
Replace old-run-webkit-tests's win-7 platform with win-7sp0

It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
version of Windows we cared about, so its results should just go in win. But now that
Windows 7 SP1 exists (and has different results for some tests), we need a place to store
results for Windows 7 without SP1 (and older versions of Windows).

Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
differences from Windows 7 "SP0"

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
will just use "win".

* Scripts/webkitdirs.pm:
(isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 15:44:15 +0000 (15:44 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark css2.1/t140201-c533-bgimage-00-a.html as crash on Linux, Win Debug
        https://bugs.webkit.org/show_bug.cgi?id=58995

Accidentally indicated MAC instead of WIN.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 15:39:55 +0000 (15:39 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark css2.1/t140201-c533-bgimage-00-a.html as crash on Linux, Win Debug
        https://bugs.webkit.org/show_bug.cgi?id=58995

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 20 Apr 2011 14:54:25 +0000 (14:54 +0000)]
2011-04-19  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Move and rename GLES2Canvas.
        https://bugs.webkit.org/show_bug.cgi?id=58927

        Move GLES2Canvas to platform/graphcs/gpu, where all the other
        gpu-related files live, and rename it to GraphicsContextGPU to better
        reflect its purpose.

        Covered by existing tests.

        * WebCore.gypi:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::drawBitmapGLES2):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
        * platform/graphics/skia/PlatformContextSkia.h:
        (WebCore::PlatformContextSkia::gpuCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Clean the style of our cookie methods
benjamin.poulain@nokia.com [Wed, 20 Apr 2011 14:46:52 +0000 (14:46 +0000)]
[Qt] Clean the style of our cookie methods
https://bugs.webkit.org/show_bug.cgi?id=58987

Reviewed by Andreas Kling.

Got rid of the variables named "u" in favor just converting the url when needed.

* platform/qt/CookieJarQt.cpp:
(WebCore::setCookies): The variable p was unused.
The ::toAscii() depends on the default codec, use toLatin1() instead.
(WebCore::cookies): foreach() should use const reference.
(WebCore::cookieRequestHeaderFieldValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach webkitdirs::winVersion about build numbers
aroben@apple.com [Wed, 20 Apr 2011 14:44:05 +0000 (14:44 +0000)]
Teach webkitdirs::winVersion about build numbers

The build number isn't currently used, but soon will be.

As a bonus, winVersion now works on non-Cygwin variants of Perl!

Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
SP1

Reviewed by Anders Carlsson.

* Scripts/webkitdirs.pm:
(isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
(determineWinVersion): Use `cmd /c ver` to get the version number, including the build
number. Parse the version number into a hash, similar to how osXVersion() works.

(isWindows7):
(isWindowsVista):
(isWindowsXP):
Updated for changes to winVersion().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 20 Apr 2011 14:40:02 +0000 (14:40 +0000)]
2011-04-19  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        ScriptController.h is included in too many places
        https://bugs.webkit.org/show_bug.cgi?id=58963

        Remove ScriptController.h #includes from a bunch of .cpp files where it
        doesn't appear to be necessary.

        * bindings/js/JSCustomPositionCallback.cpp:
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowShell.cpp:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/ScriptDebugServer.cpp:
        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/ScriptCachedFrameData.cpp:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8IsolatedContext.cpp:
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * dom/Node.cpp:
        * dom/ScriptElement.cpp:
        * dom/XMLDocumentParser.cpp:
        * dom/XMLDocumentParserQt.cpp:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/HTMLPlugInElement.cpp:
        * html/parser/HTMLConstructionSite.cpp:
        * html/parser/HTMLTreeBuilder.cpp:
        * inspector/InspectorProfilerAgent.cpp:
        * loader/icon/IconDatabase.cpp:
        * page/Chrome.cpp:
        * page/Navigator.cpp:
        * page/Page.cpp:
        * plugins/PluginView.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/qt/PluginViewQt.cpp:
        * plugins/symbian/PluginViewSymbian.cpp:
        * plugins/win/PluginViewWin.cpp:
        * svg/SVGDocumentExtensions.cpp:
        * xml/XMLTreeViewer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some unnecessary VS junk related to NativeWebMouseEventWin.cpp
aroben@apple.com [Wed, 20 Apr 2011 14:23:13 +0000 (14:23 +0000)]
Remove some unnecessary VS junk related to NativeWebMouseEventWin.cpp

* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Snow Leopard Intel WebKit2 Release Tests] editing/execCommand/convert-style-elements...
jberlin@webkit.org [Wed, 20 Apr 2011 14:21:05 +0000 (14:21 +0000)]
[Snow Leopard Intel WebKit2 Release Tests] editing/execCommand/convert-style-elements-to-spans.html
flakey.
https://bugs.webkit.org/show_bug.cgi?id=58183

Skip the flakey test in order to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 14:17:30 +0000 (14:17 +0000)]
2011-04-20  Leon Scroggins  <scroggo@google.com>

        Reviewed by Kenneth Russell.

        Mark tests as failing for rebaselining.
        https://bugs.webkit.org/show_bug.cgi?id=58839

        We are making a change to the way gradients
        are calculated, so disable tests for now.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 20 Apr 2011 14:11:20 +0000 (14:11 +0000)]
2011-04-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip GTK crashing test
        storage/open-database-set-empty-version.html.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 needs layoutTestController.overridePreference
jberlin@webkit.org [Wed, 20 Apr 2011 14:04:39 +0000 (14:04 +0000)]
WebKit2 needs layoutTestController.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=42197

Add another test that uses layoutTestController.overridePreference
(fast/loader/scroll-position-restored-on-back.html) to the Skipped list to get the bots
green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 20 Apr 2011 13:49:02 +0000 (13:49 +0000)]
2011-04-20  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add Save As to the Resources panel context menu.
        https://bugs.webkit.org/show_bug.cgi?id=58983

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype.onattach):
        (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent.save):
        (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
        (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save):
        (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Wed, 20 Apr 2011 13:46:45 +0000 (13:46 +0000)]
2011-04-20  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Cleanup includepath adjustment for generated files
        https://bugs.webkit.org/show_bug.cgi?id=58869

        * JavaScriptCore.pri:  Add the directory of generated files to the include
        path with absolute path to make it valid in the final build step.
2011-04-20  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Cleanup includepath adjustment for generated files
        https://bugs.webkit.org/show_bug.cgi?id=58869

        Build cleanup, no new tests.

        * WebCore.pri: Add the directory of generated files to the include path
        with absolute path to make it valid in the final build step. Remove
        unnecessary logic.
2011-04-20  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Cleanup includepath adjustment for generated files
        https://bugs.webkit.org/show_bug.cgi?id=58869

        * QtWebKit.pro: Revert the hacky fix in r84174. Remove
        unnecessary logic.
2011-04-20  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Cleanup includepath adjustment for generated files
        https://bugs.webkit.org/show_bug.cgi?id=58869

        * WebKit2.pri: Add the directory of generated files to the include
        path with absolute path to make it valid in the final build step.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 13:42:37 +0000 (13:42 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Rebaseline some border-related tests on Mac
        https://bugs.webkit.org/show_bug.cgi?id=58985

Most likely related to http://trac.webkit.org/changeset/84341/
"background color of elements with border-radius shows around outer edge of border at corners"

        * platform/chromium-mac-leopard/fast/forms/menulist-clip-expected.png:
        * platform/chromium-mac-leopard/fast/forms/menulist-narrow-width-expected.png:
        * platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
        * platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
        * platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-mac/fast/forms/menulist-clip-expected.png: Removed.
        * platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Removed.
        * platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
        * platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
        * platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Removed.
        * platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
        * platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Mariusz Grzegorczyk <mariusz.g@samsung.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 13:20:31 +0000 (13:20 +0000)]
2011-04-20  Mariusz Grzegorczyk  <mariusz.g@samsung.com>

        Reviewed by Andreas Kling.

        [EFL] Initializing m_window member field in PluginView.cpp for efl port
        https://bugs.webkit.org/show_bug.cgi?id=58311

        No new tests needed: only initializing class member.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 W. James MacLean <wjmaclean@chromium.org>
wjmaclean@chromium.org [Wed, 20 Apr 2011 13:17:01 +0000 (13:17 +0000)]
2011-04-20  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        Add support for composite-to-texture to DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=58675

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::resetWebSettings):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::setCompositeToTexture):
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):
        (WebPreferences::applyTo):
        * DumpRenderTree/chromium/WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 20 Apr 2011 12:45:31 +0000 (12:45 +0000)]
2011-04-20  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Tony Gentilcore.

        http/tests/misc/unloadable-script.html fails if <script> error event doesn't bubble
        https://bugs.webkit.org/show_bug.cgi?id=58981

        * http/tests/misc/unloadable-script.html: canged the test so that it uses <script onerror> instead
        od <body onerror>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 20 Apr 2011 12:40:11 +0000 (12:40 +0000)]
2011-04-20  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix Leopard compile.

        * inspector/InspectorFrontendClient.h:
        * inspector/InspectorFrontendClientLocal.h:
        (WebCore::InspectorFrontendClientLocal::saveAs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 20 Apr 2011 12:27:15 +0000 (12:27 +0000)]
2011-04-20  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add saveAs into the InspectorFrontendHost binding.
        https://bugs.webkit.org/show_bug.cgi?id=58979

        * English.lproj/localizedStrings.js:
        * inspector/InspectorFrontendClient.h:
        (WebCore::InspectorFrontendClient::saveAs):
        (WebCore::InspectorFrontendClient::saveSessionSetting):
        (WebCore::InspectorFrontendClient::loadSessionSetting):
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::saveAs):
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.saveAs.fr.onload):
        (.WebInspector.InspectorFrontendHostStub.prototype.saveAs):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._contextMenu):
        (WebInspector.NetworkPanel.prototype._copyAll):
        (WebInspector.NetworkPanel.prototype._copyResource):
        (WebInspector.NetworkPanel.prototype._exportAll):
        (WebInspector.NetworkPanel.prototype._exportResource):
        * inspector/front-end/Settings.js:
        * inspector/front-end/utilities.js:
        ():
2011-04-20  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add saveAs into the InspectorFrontendHost binding.
        https://bugs.webkit.org/show_bug.cgi?id=58979

        * public/WebDevToolsFrontendClient.h:
        (WebKit::WebDevToolsFrontendClient::saveAs):
        * src/InspectorFrontendClientImpl.cpp:
        (WebKit::InspectorFrontendClientImpl::saveAs):
        * src/InspectorFrontendClientImpl.h:
        * src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 20 Apr 2011 11:52:04 +0000 (11:52 +0000)]
2011-04-20  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Tony Gentilcore.

        Error event in <script> element shouldn't bubble
        https://bugs.webkit.org/show_bug.cgi?id=51040

        * fast/events/onerror-bubbling-expected.txt:
        * fast/events/onerror-bubbling.html:
        * svg/dom/SVGScriptElement/script-load-and-error-events.svg: error event is dispatched on the
        corresponding SVGScriptElement and shouldn't bubble, so the global error handler should
        never be invoked for script load errors. This behaviour is consistent with HTMLScriptElement element.
        * svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt: Added.
        * svg/dom/SVGScriptElement/script-onerror-bubbling.svg: Added.
2011-04-20  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Tony Gentilcore.

        Error event in <script> element shouldn't bubble
        https://bugs.webkit.org/show_bug.cgi?id=51040

        Test: svg/dom/SVGScriptElement/script-onerror-bubbling.svg

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::dispatchErrorEvent): the method now has same implementation for all script
        elements, script load error event doesn' bubble.
        * dom/ScriptElement.h:
        * html/HTMLScriptElement.cpp:
        * html/HTMLScriptElement.h:
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::parseMappedAttribute): SVG script element now supports onerror
        hanlder which behaves the same way as onerror in HTML script element: it's invoked when
        script loading fails and the event doesn't bubble.
        * svg/SVGScriptElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 11:10:59 +0000 (11:10 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Rebaseline fast/repaint/trailing-floats-root-line-box-overflow fast/canvas/webgl/css-webkit-canvas fast/canvas/webgl/css-webkit-canvas-repaint
        https://bugs.webkit.org/show_bug.cgi?id=58978

Windows bots are now generating baselines, so include them.
fast/repaint/trailing-floats-root-line-box-overflow looks like correct output.

        * platform/chromium-mac/fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
        * platform/chromium-win/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
        * platform/chromium-win/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forwar...
ossy@webkit.org [Wed, 20 Apr 2011 10:57:51 +0000 (10:57 +0000)]
[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=58977

* platform/qt/Skipped: Add platform/qt/fast/history/back-to-unreachable-url-then-forward.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 20 Apr 2011 10:00:35 +0000 (10:00 +0000)]
2011-04-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test on GTK.

        [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=58976

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 20 Apr 2011 09:44:58 +0000 (09:44 +0000)]
2011-04-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, new GTK baselines for tests added in r84273.
        Also skip a couple of failing tests.

        * platform/gtk/Skipped:
        * platform/gtk/fast/backgrounds/background-leakage-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/background-leakage-expected.png: Added.
        * platform/gtk/fast/backgrounds/background-leakage-expected.txt: Added.
        * platform/gtk/fast/backgrounds/background-leakage-transforms-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/background-leakage-transforms-expected.png: Added.
        * platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
        * platform/gtk/fast/backgrounds/border-radius-split-background-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/border-radius-split-background-expected.png: Added.
        * platform/gtk/fast/backgrounds/border-radius-split-background-expected.txt: Added.
        * platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
        * platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.txt: Added.
        * platform/gtk/fast/borders/border-radius-different-width-001-expected.checksum: Added.
        * platform/gtk/fast/borders/border-radius-different-width-001-expected.png: Added.
        * platform/gtk/fast/borders/border-radius-different-width-001-expected.txt: Added.
        * platform/gtk/fast/borders/border-radius-inset-outset-expected.checksum: Added.
        * platform/gtk/fast/borders/border-radius-inset-outset-expected.png: Added.
        * platform/gtk/fast/borders/border-radius-inset-outset-expected.txt: Added.
        * platform/gtk/fast/borders/table-borders-expected.checksum: Added.
        * platform/gtk/fast/borders/table-borders-expected.png: Added.
        * platform/gtk/fast/borders/table-borders-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.txt:
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.txt:
        * platform/gtk/fast/borders/border-styles-split-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 09:35:48 +0000 (09:35 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Rebaseline overhanging-tall-block
        https://bugs.webkit.org/show_bug.cgi?id=58974

        * platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png: Added.
        * platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 20 Apr 2011 09:21:36 +0000 (09:21 +0000)]
2011-04-20  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: minor protocol cleanups (refined types).
        https://bugs.webkit.org/show_bug.cgi?id=58970

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Wed, 20 Apr 2011 08:16:00 +0000 (08:16 +0000)]
2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Eric Seidel.

        Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement seen on SnowLeopard Intel Leaks
        https://bugs.webkit.org/show_bug.cgi?id=56672

        ~RenderSVGShadowTreeRootContainer() cleared shadow host only if
        the shadow root is attached. This is wrong because it will
        leak shadow root when the root is not attached. For example, it
        leaks shadow root of <use> element which is pending on resource.

        This patch is clearing shadow host if m_shadowRoot is valid to
        prevent leaking.

        Fixing leaking, no new tests.

        * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
        (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 20 Apr 2011 07:39:36 +0000 (07:39 +0000)]
2011-04-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Antti Koivisto.

        Reproducible crash two-finger zooming at multiple sites in WebCore::RenderLayer::isTransparent
        https://bugs.webkit.org/show_bug.cgi?id=58868

        I could not figure out how to make a test.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer): Check for existence of a
        parent before calling a method on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 20 Apr 2011 07:18:56 +0000 (07:18 +0000)]
2011-04-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Daniel Bates.

        [EFL] Add current time to media control panel.
        https://bugs.webkit.org/show_bug.cgi?id=58866

        Implement paintMediaCurrentTime() to show playing time of media content.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::RenderThemeEfl):
        (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
        (WebCore::RenderThemeEfl::paintMediaCurrentTime):
        * platform/efl/RenderThemeEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 06:24:15 +0000 (06:24 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Wed, 20 Apr 2011 06:02:30 +0000 (06:02 +0000)]
2011-04-19  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Adam Barth

        Update the list of Unicode blocks to treat as complex scripts
        per Unicode 6.0. Also, make [U+02E5..U+02E9] (IPA tone marks)
        go through the complex script code path.

        Test: fast/text/ipa-tone-letters.html

        http://bugs.webkit.org/show_bug.cgi?id=39799

        * platform/graphics/Font.cpp:
        (WebCore::Font::codePath):

2011-04-19  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Adam Barth

        Add a test to test sequences of IPA tone letters are
        ligated regardless of text-rendering mode (fast codepath or not).
        The test explicitly specifies Arial because it's one of a few fonts
        to have layout table entries to support the ligation of IPA tone
        letters.

        http://bugs.webkit.org/show_bug.cgi?id=39799

        * fast/text/ipa-tone-letters.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 06:01:31 +0000 (06:01 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Add chromium suppressions resulting from r84341 - 84344.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926
psolanki@apple.com [Wed, 20 Apr 2011 05:45:59 +0000 (05:45 +0000)]
Follow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926

Reviewed by Simon Fraser.

Move the assert from Image::drawPattern() to Image::drawTiled() so we don't hit it when
trying to paint GeneratedImages.

* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 20 Apr 2011 05:32:56 +0000 (05:32 +0000)]
2011-04-19  Simon Fraser  <simon.fraser@apple.com>

        Fix 32-bit builds.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::determineBackgroundBleedAvoidance):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 05:16:35 +0000 (05:16 +0000)]
2011-04-19  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium]UI polishes and tweaks to Autofill dropdown menu.
        https://bugs.webkit.org/show_bug.cgi?id=58505
        http://code.google.com/p/chromium/issues/detail?id=51077

        No new tests. Because this is autofill looking problem in Chromium.
        Add m_menuType as PopupMenuStyle to change popup style change.
        Put kLinePaddingHeight at the top and bottom of each line if m_menuType is AutofillPopup.
        Change separator color to #dcdcdc and remove sparatorPadding at the edge if m_menuType is AutofillPopup.
        Change the line height of separator as only the piece if m_menuType is AutofillPopup.
        Change the label font size 0.9 time smaller than regular font size if m_menuType is AutofillPopup.

        * platform/PopupMenuStyle.h: Add enum PopupMenuType;
        (WebCore::PopupMenuStyle::PopupMenuStyle): Add m_menuType.
        (WebCore::PopupMenuStyle::menuType): Add to change the style according to the return value.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::paintRow):Change the separator color to #dcdcdc.
        Change the edge padding according to menuStyle().
        (WebCore::PopupListBox::getRowHeight): Add kLineHeightMargin*2 for each line height.
2011-04-19  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium]UI polishes and tweaks to Autofill dropdown menu.
        https://bugs.webkit.org/show_bug.cgi?id=58505

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::initialize): Set AutofillPopup for menuStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 20 Apr 2011 05:13:32 +0000 (05:13 +0000)]
2011-04-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        background color of elements with border-radius shows around outer edge of border at corners
        https://bugs.webkit.org/show_bug.cgi?id=21819

        When drawing a background followed by a border with the same rounded
        clip, some border color leaks out because of antialiasing.

        Fix this by using two different strategies depending on the colors.
        If the border is opaque on all sides, we can inset the background by
        a device pixel. If not, then we have to draw the unclipped background
        and border into a transparency layer, and then clip that.

        A futher possible solution is mentioned in a comment in
        determineBackgroundBleedAvoidance() but not yet implemented.

        Also don't try to paint shadows with zero offset, spread and blur.

        Test: fast/backgrounds/background-leakage.html,
              fast/backgrounds/background-leakage-transforms.html

        * rendering/RenderBoxModelObject.h:
        Add a BackgroundBleedAvoidance enum with a value for each
        strategy.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        Pass BackgroundBleedAvoidance, bail early if the border rect is empty.
        If using the transparency layer solution, don't bother to clip
        to the rounded rect for the background. If the strategy is to
        shrink the background, do that.
        (WebCore::BorderEdge::BorderEdge):
        (WebCore::BorderEdge::obscuresBackgroundEdge):
        Helper method to determine if this border side will totally
        obscured by the border edge, allowing us to inset it.
        (WebCore::RenderBoxModelObject::paintOneBorderSide):
        Pass BackgroundBleedAvoidance through.
        (WebCore::RenderBoxModelObject::paintBorderSides):
        Ditto.
        (WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
        Ditto.
        (WebCore::RenderBoxModelObject::paintBorder):
        Fill BorderEdges using getBorderEdgeInfo now.
        Don't clip to the rounded border if we are using the
        transparency layer solution.
        (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
        Pass bleedAvoidance through, and use it for double borders.
        (WebCore::RenderBoxModelObject::getBorderEdgeInfo):
        Helper to fill in the BorderEdge array.
        (WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
        Used to determine if we can use the background shrinkage solution.
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        Don't paint shadows that should not be visible.

        * rendering/RenderBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintRootBoxFillLayers):
        Pass BackgroundBleedNone for the root box.

        (WebCore::RenderBox::determineBackgroundBleedAvoidance):
        Determine which bleed strategy we can use.

        (WebCore::RenderBox::paintBoxDecorationsWithSize):
        Based on the bleedAvoidance, make a transparency layer
        which will be clipped to the rounded border outside edge,
        and pass bleedAvoidance to the background and border-painting
        methods.
        (WebCore::RenderBox::paintMaskImages):
        Use BackgroundBleedNone.
        (WebCore::RenderBox::paintFillLayers):
        (WebCore::RenderBox::paintFillLayer):
        Pass bleedAvoidance through.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayer):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        Pass BackgroundBleedNone. At some point we may want to do the right
        thing for split inlines.

        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        Pass BackgroundBleedNone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 20 Apr 2011 04:51:11 +0000 (04:51 +0000)]
2011-04-19  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket: Add assertion for SocketStreamError::failingURL.
        https://bugs.webkit.org/show_bug.cgi?id=58765

        No new tests, because an existing test http/tests/inspector/console-websocket-error.html should cover this.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didFail): If error.failingURL() is provided, it must be the same as
        m_handshake.url(). failingURL may be null if SocketStreamHandle has created a SocketStreamError
        using zero- or one-argument constructor (which is old version but some ports are still using it).
        In that case, m_handshake.url() is passed to addMessage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 04:33:18 +0000 (04:33 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 04:15:19 +0000 (04:15 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 04:11:15 +0000 (04:11 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 20 Apr 2011 04:04:16 +0000 (04:04 +0000)]
2011-04-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dimitri Glazkov.

        Media controls status display should not be hidden for live streams
        https://bugs.webkit.org/show_bug.cgi?id=58952

        Tested manually because we don't have any live streams to test in DRT.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlStatusDisplayElement::update): Set the status to "Loading" only until
            there is something to display (readyState exceeds HAVE_METADATA).
        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::loadedMetadata): Don't hide the status display for
            live streams.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Wed, 20 Apr 2011 03:35:19 +0000 (03:35 +0000)]
2011-04-19  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Levin.

        new-run-webkit-tests: remove formerly flakey tests form test_expectations.
        https://bugs.webkit.org/show_bug.cgi?id=57678

        Tests fixed by http://trac.webkit.org/changeset/83900

        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Wed, 20 Apr 2011 03:21:09 +0000 (03:21 +0000)]
2011-04-19  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
        https://bugs.webkit.org/show_bug.cgi?id=57254

        Skip test for setPalette() which doesn't work
        when WTF_USE_QT_MOBILE_THEME is defined.

        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        * tests/qwebview/tst_qwebview.cpp:
        * tests/tests.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 Apr 2011 03:17:20 +0000 (03:17 +0000)]
2011-04-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        The commit-queue is confused when non-layout tests fail
        https://bugs.webkit.org/show_bug.cgi?id=58955

        As seen in http://queues.webkit.org/results/8474435

        It fails to create an archive of the layout test results
        and then throws an exception.

        I've fixed this by making it catch the exception as well
        as made it so it never calls that path in the common case.

        I've updated MockFileSystem to understand rmtree's affect on
        directories as well as files.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Wed, 20 Apr 2011 02:56:16 +0000 (02:56 +0000)]
2011-04-19  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
        https://bugs.webkit.org/show_bug.cgi?id=58044

        Fixing this test by disabling the scrollbars on the graphics view
        since QtWebKit handles scrolling and scrollbar automatically and correctly.

        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::widgetsRenderingThroughCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 02:31:17 +0000 (02:31 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 02:21:47 +0000 (02:21 +0000)]
2011-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, attempting build fix.

        Disable leveldb to work around
        http://code.google.com/p/leveldb/issues/detail?id=1.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 02:13:22 +0000 (02:13 +0000)]
2011-04-19  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=45425
        HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

        Test case by Bijan Amirzada <bijana@codeaurora.org>.

        * fast/dom/HTMLLinkElement/disabled-attribute-expected.txt: Added.
        * fast/dom/HTMLLinkElement/disabled-attribute.html: Added.
        Test that the properties are properly forwarded to the stylesheet.

        * fast/dom/boolean-attribute-reflection-expected.txt:
        * fast/dom/script-tests/boolean-attribute-reflection.js: Removed link:disabled as it is
        not reflected anymore.
2011-04-19  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=45425
        HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

        Test: fast/html/htmllink-disable.html
        Test: fast/dom/HTMLLinkElement/disabled-attribute.html

        Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet.

        Based on previous work by Bijan Amirzada <bijana@codeaurora.org>.

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or
        false if we don't have a stylesheet.
        (WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or
        ignore the call if we don't have a stylesheet.
        * html/HTMLLinkElement.h:
        * html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5.
        This matches the way FF4, Opera and IE9 handle the attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Dominic Cooney <dominicc@chromium.org>
rolandsteiner@chromium.org [Wed, 20 Apr 2011 02:12:51 +0000 (02:12 +0000)]
2011-04-19  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Check the type of the wrapper when unwrapping NPObjects to native
        Ranges and Elements
        https://bugs.webkit.org/show_bug.cgi?id=58957

        * src/WebBindings.cpp:
        (WebKit::getRangeImpl): check HasInstance
        (WebKit::getElementImpl): check HasInstance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 20 Apr 2011 01:56:48 +0000 (01:56 +0000)]
2011-04-19  Simon Fraser  <simon.fraser@apple.com>

        Rebaseline image results with diffs below the default tolerance,
        after earlier border drawing changes.

        * platform/mac/fast/backgrounds/background-leakage-expected.checksum:
        * platform/mac/fast/backgrounds/background-leakage-expected.png:
        * platform/mac/fast/backgrounds/border-radius-split-background-expected.checksum:
        * platform/mac/fast/backgrounds/border-radius-split-background-expected.png:
        * platform/mac/fast/backgrounds/border-radius-split-background-image-expected.checksum:
        * platform/mac/fast/backgrounds/border-radius-split-background-image-expected.png:
        * platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
        * platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
        * platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
        * platform/mac/fast/blockflow/border-vertical-lr-expected.png:
        * platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
        * platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
        * platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
        * platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
        * platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
        * platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
        * platform/mac/fast/box-shadow/basic-shadows-expected.checksum:
        * platform/mac/fast/box-shadow/basic-shadows-expected.png:
        * platform/mac/fast/box-shadow/inset-box-shadows-expected.checksum:
        * platform/mac/fast/box-shadow/inset-box-shadows-expected.png:
        * platform/mac/fast/box-shadow/inset-expected.checksum:
        * platform/mac/fast/box-shadow/inset-expected.png:
        * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum:
        * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/mac/fast/css/nested-rounded-corners-expected.checksum:
        * platform/mac/fast/css/nested-rounded-corners-expected.png:
        * platform/mac/fast/forms/001-expected.checksum:
        * platform/mac/fast/forms/001-expected.png:
        * platform/mac/fast/forms/basic-selects-expected.checksum:
        * platform/mac/fast/forms/basic-selects-expected.png:
        * platform/mac/fast/forms/menulist-clip-expected.checksum:
        * platform/mac/fast/forms/menulist-clip-expected.png:
        * platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
        * platform/mac/fast/forms/menulist-narrow-width-expected.png:
        * platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
        * platform/mac/fast/forms/menulist-option-wrap-expected.png:
        * platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/mac/fast/forms/menulist-separator-painting-expected.checksum:
        * platform/mac/fast/forms/menulist-separator-painting-expected.png:
        * platform/mac/fast/forms/menulist-style-color-expected.checksum:
        * platform/mac/fast/forms/menulist-style-color-expected.png:
        * platform/mac/fast/forms/select-background-none-expected.checksum:
        * platform/mac/fast/forms/select-background-none-expected.png:
        * platform/mac/fast/forms/select-baseline-expected.checksum:
        * platform/mac/fast/forms/select-baseline-expected.png:
        * platform/mac/fast/forms/select-empty-option-height-expected.checksum:
        * platform/mac/fast/forms/select-empty-option-height-expected.png:
        * platform/mac/fast/forms/select-style-expected.checksum:
        * platform/mac/fast/forms/select-style-expected.png:
        * platform/mac/fast/forms/validation-message-appearance-expected.checksum:
        * platform/mac/fast/forms/validation-message-appearance-expected.png:
        * platform/mac/fast/overflow/border-radius-clipping-expected.checksum:
        * platform/mac/fast/overflow/border-radius-clipping-expected.png:
        * platform/mac/fast/repaint/border-radius-repaint-expected.checksum:
        * platform/mac/fast/repaint/border-radius-repaint-expected.png:
        * platform/mac/fast/repaint/control-clip-expected.checksum:
        * platform/mac/fast/repaint/control-clip-expected.png:
        * platform/mac/fast/repaint/selection-after-remove-expected.checksum:
        * platform/mac/fast/repaint/selection-after-remove-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 20 Apr 2011 01:18:03 +0000 (01:18 +0000)]
2011-04-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Remove calls to deprecatedOffset and deprecatedNode in TypingCommand
        https://bugs.webkit.org/show_bug.cgi?id=58569

        Removed all calls to deprecatedOffset and deprecatedNode.

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 20 Apr 2011 01:17:08 +0000 (01:17 +0000)]
2011-04-19  Chris Rogers  <crogers@google.com>

        Unreviewed.

        Rebaseline some tests and update test_expectations.txt
        https://bugs.webkit.org/show_bug.cgi?id=58954

        * platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Removed.
        * platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/fast/text/justification-padding-mid-word-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 20 Apr 2011 01:01:44 +0000 (01:01 +0000)]
2011-04-19  James Robinson  <jamesr@chromium.org>

        [win] New test compositing/iframes/invisible-nested-iframe-show.html fails on windows
        https://bugs.webkit.org/show_bug.cgi?id=58951

        Add a failing expectation for this test on windows.

        * platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 20 Apr 2011 00:51:39 +0000 (00:51 +0000)]
2011-04-19  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Initialize depth mask to known value before getBooleanv call
        https://bugs.webkit.org/show_bug.cgi?id=58948

        This trips an assert in the GPU command buffer client code if the
        pointed-to value is not initialized to 0 or -1.

        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clearFramebuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 20 Apr 2011 00:50:04 +0000 (00:50 +0000)]
2011-04-19  Simon Fraser  <simon.fraser@apple.com>

        Add missing results for fast/borders/table-borders.html, and
        a new test that shows the background color leaking out through the
        border (to facilitate image diffs for an upcoming change).

        * fast/backgrounds/background-leakage.html: Added.
        * platform/mac/compositing/reflections/backface-hidden-reflection-expected.txt: Added.
        * platform/mac/fast/backgrounds/background-leakage-expected.checksum: Added.
        * platform/mac/fast/backgrounds/background-leakage-expected.png: Added.
        * platform/mac/fast/backgrounds/background-leakage-expected.txt: Added.
        * platform/mac/fast/borders/table-borders-expected.checksum: Added.
        * platform/mac/fast/borders/table-borders-expected.png: Added.
        * platform/mac/fast/borders/table-borders-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84322 268f45cc-cd09-0410-ab3c-d52691b4dbfc