WebKit-https.git
9 years ago2010-06-10 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Fri, 11 Jun 2010 05:51:38 +0000 (05:51 +0000)]
2010-06-10  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page
        https://bugs.webkit.org/show_bug.cgi?id=40452

        * platform/chromium/test_expectations.txt:
        * platform/mac/printing/page-rule-in-media-query-expected.checksum: Added.
        * platform/mac/printing/page-rule-in-media-query-expected.png: Added.
        * platform/mac/printing/page-rule-in-media-query-expected.txt: Added.
        * printing/page-rule-in-media-query.html: Added.
2010-06-10  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page
        https://bugs.webkit.org/show_bug.cgi?id=40452

        Test: printing/page-rule-in-media-query.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::addRulesFromSheet):
        (WebCore::CSSRuleSet::addStyleRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 11 Jun 2010 05:47:52 +0000 (05:47 +0000)]
2010-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60989.
        http://trac.webkit.org/changeset/60989
        https://bugs.webkit.org/show_bug.cgi?id=40462

        It makes things crash (Requested by abarth on #webkit).

        * dom/Tokenizer.h:
        (WebCore::Tokenizer::isHTMLTokenizer):
        * html/HTML5Tokenizer.cpp:
        * html/HTML5Tokenizer.h:
        * html/HTML5TreeBuilder.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::removedFromTree):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::isHTMLTokenizer):
        (WebCore::HTMLTokenizer::htmlParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 11 Jun 2010 05:36:40 +0000 (05:36 +0000)]
2010-06-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Math Javascript Bug on Safari 5 (webkit 533.16) under "32bit" mode
        https://bugs.webkit.org/show_bug.cgi?id=40367

        If we're in the slow case of right shift we must write the type tag as
        the only reason we hit this code path is because we know we're working
        with a double.  eg. we are guaranteed that the tag cannot be reused.

        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emitRightShiftSlowCase):
2010-06-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Math Javascript Bug on Safari 5 (webkit 533.16) under "32bit" mode
        https://bugs.webkit.org/show_bug.cgi?id=40367

        Add some tests to ensure correct behaviour of right shift.

        * fast/js/bitops-type-tag.html: Added.
        * fast/js/script-tests/bitops-type-tag.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Fri, 11 Jun 2010 05:28:50 +0000 (05:28 +0000)]
2010-06-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
        https://bugs.webkit.org/show_bug.cgi?id=40454

        This required exposing the HTMLParser which we definitely don't want to
        do, but the good news is that it can go away when the HTMLParser goes
        away.

        No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.

        * dom/Tokenizer.h:
        (WebCore::Tokenizer::htmlParser):
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::htmlParser):
        * html/HTML5Tokenizer.h:
        * html/HTML5TreeBuilder.h:
        (WebCore::HTML5TreeBuilder::htmlParser):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::removedFromTree):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::htmlParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
bweinstein@apple.com [Fri, 11 Jun 2010 04:58:19 +0000 (04:58 +0000)]
Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.

Reviewed by Darin Adler.

Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
WEXITSTATUS on $result instead of just comparing $result to 0.

* Scripts/update-webkit-auxiliary-libs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[DRT/Chromium] Support plugin tests
tkent@chromium.org [Fri, 11 Jun 2010 04:05:56 +0000 (04:05 +0000)]
[DRT/Chromium] Support plugin tests
https://bugs.webkit.org/show_bug.cgi?id=40413

Reviewed by Dimitri Glazkov.

* DEPS:
 Bump the Chromium revision to r49376 to have a npapi_layout_test_plugin
 change and Linux <progress> resources.
 Add third_party/mesa because app/ depends on them
 since r49332.
* WebKit.gyp:
  Copy a plugin binary for DRT to recognize it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Fri, 11 Jun 2010 01:40:14 +0000 (01:40 +0000)]
2010-06-10  James Hawkins  <jhawkins@chromium.org>

        Not reviwed.

        Build fix for Chromium Mac Release.

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::getSuggestion):
        (WebKit::AutoFillPopupMenuClient::valueChanged):
        (WebKit::AutoFillPopupMenuClient::selectionChanged):
        (WebKit::AutoFillPopupMenuClient::itemIsSeparator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Fri, 11 Jun 2010 00:51:36 +0000 (00:51 +0000)]
2010-06-09  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add the ability to specify a separator in
        AutoFillPopupMenuClient.

        https://bugs.webkit.org/show_bug.cgi?id=40397

        * public/WebViewClient.h:
        (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::getSuggestionsCount):
        (WebKit::AutoFillPopupMenuClient::getSuggestion):
        (WebKit::AutoFillPopupMenuClient::valueChanged):
        (WebKit::AutoFillPopupMenuClient::selectionChanged):
        (WebKit::AutoFillPopupMenuClient::itemIsSeparator):
        (WebKit::AutoFillPopupMenuClient::initialize):
        (WebKit::AutoFillPopupMenuClient::setSuggestions):
        * src/AutoFillPopupMenuClient.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::applyAutoFillSuggestions):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 11 Jun 2010 00:49:10 +0000 (00:49 +0000)]
2010-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        crash when focus is changed while trying to focus next element
        https://bugs.webkit.org/show_bug.cgi?id=40407

        * fast/events/focus-change-crash-expected.txt: Added.
        * fast/events/focus-change-crash.html: Added.
2010-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        crash when focus is changed while trying to focus next element
        https://bugs.webkit.org/show_bug.cgi?id=40407

        Test: fast/events/focus-change-crash.html

        * dom/Element.cpp:
        (WebCore::Element::focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Rubber-stamped by Sam Weinig.
ap@apple.com [Fri, 11 Jun 2010 00:45:36 +0000 (00:45 +0000)]
    Rubber-stamped by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18830
        Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg

        This doesn't happen any more, the code has changed a lot since 2008. Re-enabling the test.

        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled.
        * svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Jun 2010 00:27:05 +0000 (00:27 +0000)]
2010-06-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Alexey Proskuryakov.

        don't use Exception.message as it's deprecated in python 2.6+
        https://bugs.webkit.org/show_bug.cgi?id=40449

        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Support for loading notification icons
yael.aharon@nokia.com [Thu, 10 Jun 2010 23:05:26 +0000 (23:05 +0000)]
[Qt] Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40004

Reviewed by Kenneth Rohde Christiansen.

Take into use the icon that was loaded for the notification.

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
kbr@google.com [Thu, 10 Jun 2010 23:05:23 +0000 (23:05 +0000)]
2010-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60979.
        http://trac.webkit.org/changeset/60979
        https://bugs.webkit.org/show_bug.cgi?id=40450

        Broke build on Leopard (Requested by kbr_google on #webkit).

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::bufferData):
        (WebCore::JSWebGLRenderingContext::bufferSubData):
        (WebCore::JSWebGLRenderingContext::texImage2D):
        (WebCore::JSWebGLRenderingContext::texSubImage2D):
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLCanvasElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLVideoElement.idl:
        * html/canvas/WebGLRenderingContext.idl:
2010-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60979.
        http://trac.webkit.org/changeset/60979
        https://bugs.webkit.org/show_bug.cgi?id=40450

        Broke build on Leopard (Requested by kbr_google on #webkit).

        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/texImageTest-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 10 Jun 2010 22:44:46 +0000 (22:44 +0000)]
2010-06-10  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=40443

        Deleted custom JSC bindings for bufferData, texImage2D and
        texSubImage2D and fixed minor associated issues in code generator
        and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
        which now runs as intended. Ran all layout tests, including WebGL
        tests, in Safari.

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
         - Deleted custom bindings.
        * bindings/scripts/CodeGeneratorJS.pm:
         - Made overload helper functions static to fix compiler warnings.
         - Added needed isObject check for overloads between object and non-object arguments.
        * html/HTMLCanvasElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLVideoElement.idl:
         - Added GenerateNativeConverter extended attribute.
        * html/canvas/WebGLRenderingContext.idl:
         - Deleted #ifdefs for custom JSC bindings.
2010-06-10  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=40443

        Deleted custom JSC bindings for bufferData, texImage2D and
        texSubImage2D and fixed minor associated issues in code generator
        and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
        which now runs as intended. Ran all layout tests, including WebGL
        tests, in Safari.

        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/texImageTest-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKitSystemInterface to fix build.
hyatt@apple.com [Thu, 10 Jun 2010 22:03:51 +0000 (22:03 +0000)]
Update WebKitSystemInterface to fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, Chromium build fix from Abhishek Arya.
dimich@chromium.org [Thu, 10 Jun 2010 21:56:14 +0000 (21:56 +0000)]
Not reviewed, Chromium build fix from Abhishek Arya.

* src/WebImageCG.cpp:
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 10 Jun 2010 21:55:34 +0000 (21:55 +0000)]
2010-06-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix handle_script_error in rietveld upload queue and add testing for handle_script_error
        https://bugs.webkit.org/show_bug.cgi?id=40436

        * Scripts/webkitpy/common/system/outputcapture.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReset layout test results for continuous wheeling.
hyatt@apple.com [Thu, 10 Jun 2010 21:40:08 +0000 (21:40 +0000)]
Reset layout test results for continuous wheeling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601...
hyatt@apple.com [Thu, 10 Jun 2010 21:31:30 +0000 (21:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
wheel delta values.

Reviewed by John Sullivan.

WebCore:

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/mac:

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Abhishek Arya <inferno@chromium.org>
hamaji@chromium.org [Thu, 10 Jun 2010 21:29:23 +0000 (21:29 +0000)]
2010-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add null pointer checks for nativeImageForCurrentFrame
        function calls.
        https://bugs.webkit.org/show_bug.cgi?id=39797

        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeImage):
2010-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add null pointer checks for nativeImageForCurrentFrame
        function calls.
        https://bugs.webkit.org/show_bug.cgi?id=39797

        * src/WebImageCG.cpp:
        (WebKit::WebImage::WebImage):
        (WebKit::WebImage::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* mac/WebKit2.exp:
sullivan@apple.com [Thu, 10 Jun 2010 21:01:33 +0000 (21:01 +0000)]
* mac/WebKit2.exp:
Added another symbol needed by Mac clients.

Reviewed by Dan Bernstein.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 10 Jun 2010 20:41:25 +0000 (20:41 +0000)]
2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] *All* WebGL layout tests fail!
        https://bugs.webkit.org/show_bug.cgi?id=40296

        Added test for WebKitWebGLEnabled to
        LayoutTestController::overridePreference().

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::overridePreference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Robert Hogan <robert@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 19:34:37 +0000 (19:34 +0000)]
2010-06-10  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix Qt-specific event-sender-keydown-frame.html test

        It looks like this test was added without elements required for it work.

        http://bugs.webkit.org/show_bug.cgi?id=20303

        * platform/qt/Skipped:
        * platform/qt/fast/events/event-sender-keydown-frame.html:
        * platform/qt/fast/events/resources/divs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Thu, 10 Jun 2010 19:13:46 +0000 (19:13 +0000)]
Fix build.

* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
* NetscapeCocoaPlugin/main.m:
(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update Chromium test expectations.
dimich@chromium.org [Thu, 10 Jun 2010 18:57:31 +0000 (18:57 +0000)]
Unreviewed, update Chromium test expectations.

* platform/chromium/test_expectations.txt:
Disable fast/text/international/khmer-selection.html on Windows regressed by http://trac.webkit.org/changeset/60953
Skip fast/dom/Window/window-properties-geolocation.html unnecessarily enabled by http://trac.webkit.org/changeset/60956

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 10 Jun 2010 18:53:20 +0000 (18:53 +0000)]
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Implement TypedArray BYTES_PER_ELEMENT
        https://bugs.webkit.org/show_bug.cgi?id=39100

        Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses.
        Required bug fixes to JSC bindings' custom constructors. Updated
        fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL
        layout tests in Safari and Chromium.

        * bindings/js/JSFloat32ArrayConstructor.cpp:
        (WebCore::JSFloat32ArrayConstructor::JSFloat32ArrayConstructor):
        (WebCore::JSFloat32ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSFloat32ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSFloat32ArrayConstructor.h:
        (WebCore::JSFloat32ArrayConstructor::createStructure):
        * bindings/js/JSInt16ArrayConstructor.cpp:
        (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor):
        (WebCore::JSInt16ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSInt16ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSInt16ArrayConstructor.h:
        (WebCore::JSInt16ArrayConstructor::createStructure):
        * bindings/js/JSInt32ArrayConstructor.cpp:
        (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor):
        (WebCore::JSInt32ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSInt32ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSInt32ArrayConstructor.h:
        (WebCore::JSInt32ArrayConstructor::createStructure):
        * bindings/js/JSInt8ArrayConstructor.cpp:
        (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor):
        (WebCore::JSInt8ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSInt8ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSInt8ArrayConstructor.h:
        (WebCore::JSInt8ArrayConstructor::createStructure):
        * bindings/js/JSUint16ArrayConstructor.cpp:
        (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor):
        (WebCore::JSUint16ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSUint16ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSUint16ArrayConstructor.h:
        (WebCore::JSUint16ArrayConstructor::createStructure):
        * bindings/js/JSUint32ArrayConstructor.cpp:
        (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor):
        (WebCore::JSUint32ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSUint32ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSUint32ArrayConstructor.h:
        (WebCore::JSUint32ArrayConstructor::createStructure):
        * bindings/js/JSUint8ArrayConstructor.cpp:
        (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor):
        (WebCore::JSUint8ArrayConstructor::getOwnPropertySlot):
        (WebCore::JSUint8ArrayConstructor::getOwnPropertyDescriptor):
        * bindings/js/JSUint8ArrayConstructor.h:
        (WebCore::JSUint8ArrayConstructor::createStructure):
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.idl:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.idl:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Implement TypedArray BYTES_PER_ELEMENT
        https://bugs.webkit.org/show_bug.cgi?id=39100

        Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses.
        Required bug fixes to JSC bindings' custom constructors. Updated
        fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL
        layout tests in Safari and Chromium.

        * fast/canvas/webgl/array-unit-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Thu, 10 Jun 2010 18:17:51 +0000 (18:17 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5 Parser should continue parsing after script execution
        https://bugs.webkit.org/show_bug.cgi?id=40416

        The previous code was just wrong.  We were always blocking
        the parser after any script execution.  Now we correctly continue
        parsing after a successful script execution and only block the
        parser when we weren't able to execute the script immediately.

        Added a new haveParsingBlockingScript() function to HTML5ScriptRunner
        to make some of the code more self-documenting.

       Test: fast/tokenizer/write-multiple-scripts.html
             fast/js/implicit-call-with-global-reentry.html

        * html/HTML5ScriptRunner.cpp:
        (WebCore::HTML5ScriptRunner::execute):
         - Remove some old (now bogus) FIXMEs and notImplemented() calls.
         - Fix the logic to match the HTML5 spec by continuing parsing
           after script execution and only blocking the parser when the
           script wasn't able to immediately run.
        (WebCore::HTML5ScriptRunner::haveParsingBlockingScript):
         - New function to make some of the code read better.
        (WebCore::HTML5ScriptRunner::executeParsingBlockingScripts):
         - Use haveParsingBlockingScript().
        (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):
         - Use haveParsingBlockingScript().
        (WebCore::HTML5ScriptRunner::runScript):
         - Use haveParsingBlockingScript().
        * html/HTML5ScriptRunner.h:
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5 Parser should continue parsing after script execution
        https://bugs.webkit.org/show_bug.cgi?id=40416

        Test the ordering of script execution with multiple calls to
        document.write().

        * fast/tokenizer/write-multiple-scripts-expected.txt: Added.
        * fast/tokenizer/write-multiple-scripts.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 10 Jun 2010 17:59:59 +0000 (17:59 +0000)]
2010-06-10  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: to reduce the front end start up time don't push script
        sources to frontend if debugger is always enabled, instead request
        script content lazily at the moment it should be displyed. It is critical for
        always enabled debugger because in that case lots of script may have
        already been parsed when the front end is opening and pushing all
        of them at once may slow things down(even though the script sources will never
        be used if scripts panel isn't open).
        https://bugs.webkit.org/show_bug.cgi?id=40364

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getScriptSource):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::getScriptSource):
        (WebCore::InspectorController::didParseSource):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didGetScriptSource):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.editScriptSource):
        (.WebInspector.InspectorBackendStub.prototype.getScriptSource):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        (WebInspector.ScriptView.prototype._didGetScriptSource):
        (WebInspector.ScriptView.prototype._sourceFrameSetupFinished):
2010-06-10  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: to reduce the front end start up time don't push script
        sources to frontend if debugger is always enabled, instead request
        script content lazily at the moment it should be displyed. It is critical for
        always enabled debugger because in that case lots of script may have
        already been parsed when the front end is opening and pushing all
        of them at once may slow things down(even though the script sources will never
        be used if scripts panel isn't open).
        https://bugs.webkit.org/show_bug.cgi?id=40364

        * src/js/DevTools.js:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):
        (.devtools.InspectorBackendImpl.prototype.getScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Jun 2010 17:39:59 +0000 (17:39 +0000)]
2010-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Use allowRequestIfNoIllegalURICharacters instead of context for XSSAuditor::canLoadExternalScriptFromSrc
        https://bugs.webkit.org/show_bug.cgi?id=40404

        We originally added the context parameter to
        canLoadExternalScriptFromSrc to work around some false positives caused
        by folks checking external script URLs on the server.  Our thought was
        that we could tell these were not real XSS attacks because the
        surrounding context wouldn't match in the URL and the document.

        Implementing this feature in the HTML5 parser is hard because it
        pierces a layer of abstraction (the token abstraction of the input
        stream).  We could hack this into the new parser, but instead I think
        it's better to switch to using the allowRequestIfNoIllegalURICharacters
        heuristic.

        We designed the allowRequestIfNoIllegalURICharacters after the context
        heuristic to deal with other cases where the server was validating
        input before echoing it.  However, we never tried applying it to
        canLoadExternalScriptFromSrc.

        It's possible that this will cause false positives and will need to be
        reverted, which is why I've left in some of the infrustructure for
        computing context.  We don't have a good way to know if that will
        happen except to try.  We do know, however, that this heuristic will
        work for the original false positives we saw.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::shouldLoadExternalScriptFromSrc):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        * page/XSSAuditor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
eric@webkit.org [Thu, 10 Jun 2010 17:24:37 +0000 (17:24 +0000)]
2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Memory leak in qwebpage unit test cases
        https://bugs.webkit.org/show_bug.cgi?id=40405

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::infiniteLoopJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 10 Jun 2010 17:10:12 +0000 (17:10 +0000)]
2010-06-10  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        Add ENABLE(DATABASE) guard for DatabaseAuthorizer.cpp
        https://bugs.webkit.org/show_bug.cgi?id=40399

        Build fix for ENABLE(DATABASE)=0.

        * storage/DatabaseAuthorizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Chang Shu <chang.shu@nokia.com>
eric@webkit.org [Thu, 10 Jun 2010 16:49:07 +0000 (16:49 +0000)]
2010-06-10  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Unskip canvas/philip/tests/2d.shadow.enable.blur.html.

        * platform/qt/Skipped:
2010-06-10  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Change the type of ShadowBlur from int to float in GraphicsContext.
        Using int for ShadowBlur loses precision and fails the test.
        Note: This code change fixes Qt port but Mac is still failing due to
        platform issue. Function CGContextSetShadowWithColor() does not take
        a blur value less than 0.5.

        https://bugs.webkit.org/show_bug.cgi?id=40370

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setShadow):
        (WebCore::GraphicsContext::getShadow):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::calculateShadowBufferDimensions):
        (WebCore::drawPathShadow):
        (WebCore::drawBorderlessRectShadow):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::Font::drawComplexText):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawComplexText):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::drawFilledShadowPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::drawBorderlessRectShadow):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleDrawTextShadow):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):
        (WebCore::Font::drawGlyphs):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::drawText):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Thu, 10 Jun 2010 16:32:09 +0000 (16:32 +0000)]
2010-06-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Support for loading notification icons
        https://bugs.webkit.org/show_bug.cgi?id=40396

        * http/tests/notifications: Added.
        * http/tests/notifications/icon-does-not-exist-expected.txt: Added.
        * http/tests/notifications/icon-does-not-exist.html: Added.
        * http/tests/notifications/icon-exists-cancel-expected.txt: Added.
        * http/tests/notifications/icon-exists-cancel.html: Added.
        * http/tests/notifications/icon-exists-expected.txt: Added.
        * http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Added.
        * http/tests/notifications/icon-exists-show-alert-during-load.html: Added.
        * http/tests/notifications/icon-exists.html: Added.
        * http/tests/notifications/icon-requires-auth-expected.txt: Added.
        * http/tests/notifications/icon-requires-auth.html: Added.
        * http/tests/notifications/resources: Added.
        * http/tests/notifications/resources/icon-exists.png: Added.
        * http/tests/notifications/resources/icon-requires-auth.php: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:
2010-06-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Support for loading notification icons
        https://bugs.webkit.org/show_bug.cgi?id=40396

        Make notification objects download the icon needed for displaying the
        notification before calling the NotificationPresenter to display the
        notification.

        An error during the download would cause the notification to be displayed
        without an icon.

        If a notification is in the process of download, and a new notification
        is created with the same ReplaceId, the download is not cancelled
        immediately and the notification is removed only after the download is
        complete.

        Tests: http/tests/notifications/icon-does-not-exist.html
               http/tests/notifications/icon-exists-cancel.html
               http/tests/notifications/icon-exists-show-alert-during-load.html
               http/tests/notifications/icon-exists.html
               http/tests/notifications/icon-requires-auth.html

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):
        (WebCore::Notification::~Notification):
        (WebCore::Notification::show):
        (WebCore::Notification::cancel):
        (WebCore::Notification::startLoading):
        (WebCore::Notification::stopLoading):
        (WebCore::Notification::didReceiveResponse):
        (WebCore::Notification::didReceiveData):
        (WebCore::Notification::didFinishLoading):
        (WebCore::Notification::didFail):
        (WebCore::Notification::didFailRedirectCheck):
        (WebCore::Notification::didReceiveAuthenticationCancellation):
        (WebCore::Notification::finishLoading):
        * notifications/Notification.h:
        (WebCore::Notification::iconData):
        (WebCore::Notification::releaseIconData):
        (WebCore::Notification::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Diego Gonzalez <diegohcg@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 15:45:48 +0000 (15:45 +0000)]
2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT EventSender support to graphics mouse events activation
        https://bugs.webkit.org/show_bug.cgi?id=40017

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        (EventSender::mouseMoveTo):
        (EventSender::keyDown):
        (EventSender::contextClick):
        (EventSender::sendTouchEvent):
        (EventSender::sendOrQueueEvent):
        (EventSender::eventFilter):
        (EventSender::createGraphicsSceneMouseEvent):
        (EventSender::sendEvent):
        * DumpRenderTree/qt/EventSenderQt.h:
        (EventSender::isGraphicsBased):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Raine Makelainen <raine.makelainen@nokia.com>
eric@webkit.org [Thu, 10 Jun 2010 15:34:05 +0000 (15:34 +0000)]
2010-06-10  Raine Makelainen  <raine.makelainen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Impossible to set input method hints based HTML5 input types
        https://bugs.webkit.org/show_bug.cgi?id=40107

        Helper methods for checking "tel", "number", "email",
        and "url" input element types.

        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isTelephoneField):
        (WebCore::HTMLInputElement::isNumberField):
        (WebCore::HTMLInputElement::isEmailField):
        (WebCore::HTMLInputElement::isUrlField):
2010-06-10  Raine Makelainen  <raine.makelainen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Impossible to set input method hints based HTML5 input types
        https://bugs.webkit.org/show_bug.cgi?id=40107

        EditorClientQt to set input method hints for "number", "tel",
        "email", and "url" HTML input elements.

        Tests for HTML input elements and input method hints added for
        QGraphicsWebView and QWebView.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::setInputMethodState):
        * tests/qgraphicswebview/resources/input_types.html: Added.
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (GraphicsWebView::GraphicsWebView):
        (GraphicsWebView::fireMouseClick):
        (tst_QGraphicsWebView::focusInputTypes):
        * tests/qgraphicswebview/tst_qgraphicswebview.qrc: Added.
        * tests/qwebview/resources/input_types.html: Added.
        * tests/qwebview/tst_qwebview.cpp:
        (WebView::fireMouseClick):
        (tst_QWebView::focusInputTypes):
        * tests/qwebview/tst_qwebview.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Daniel Cheng <dcheng@chromium.org>
eric@webkit.org [Thu, 10 Jun 2010 14:31:34 +0000 (14:31 +0000)]
2010-06-10  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        Don't convert filenames to URLs in edit drags.
        https://bugs.webkit.org/show_bug.cgi?id=38826

        For security reasons, we don't want to expose file system paths to web
        content, so we filter them out of edit drags.

        * editing/pasteboard/file-drag-to-editable-expected.txt: Added.
        * editing/pasteboard/file-drag-to-editable.html: Added.
        * editing/pasteboard/script-tests/file-drag-to-editable.js: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-06-10  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        Don't convert filenames to URLs in edit drags.
        https://bugs.webkit.org/show_bug.cgi?id=38826

        For security reasons, we don't want to expose file system paths to web
        content, so we filter them out of edit drags.

        Test: editing/pasteboard/file-drag-to-editable.html

        * page/DragController.cpp:
        (WebCore::documentFragmentFromDragData):
        * platform/DragData.h:
        (WebCore::DragData::):
        * platform/android/DragDataAndroid.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/efl/DragDataEfl.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/gtk/DragDataGtk.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/haiku/DragDataHaiku.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/mac/DragDataMac.mm:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/qt/DragDataQt.cpp:
        (WebCore::DragData::asPlainText):
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::getURL):
        (WebCore::getPlainText):
        * platform/win/ClipboardUtilitiesWin.h:
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::getData):
        * platform/win/DragDataWin.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/wince/DragDataWince.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):
        * platform/wx/DragDataWx.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Marcus Bulach <bulach@google.com>
eric@webkit.org [Thu, 10 Jun 2010 14:16:48 +0000 (14:16 +0000)]
2010-06-10  Marcus Bulach  <bulach@google.com>

        Reviewed by Jeremy Orlow.

        [chromium] Upstream layout tests expectations for Geolocation.
        Rebaseline fast/dom/Geolocation/callback-exception-expected.html due to JSC x V8 messages.
        https://bugs.webkit.org/show_bug.cgi?id=39721

        * platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Mike Belshe <mbelshe@chromium.org>
eric@webkit.org [Thu, 10 Jun 2010 13:56:16 +0000 (13:56 +0000)]
2010-06-10  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by David Levin

        Track whether a resource is loaded via a proxy.

        https://bugs.webkit.org/show_bug.cgi?id=40312

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::wasFetchedViaProxy):
        (WebCore::ResourceResponse::setWasFetchedViaProxy):
2010-06-10  Mike Belshe  <mbelshe@google.com>

        Reviewed by David Levin

        Track whether a resource is loaded via a proxy.

        https://bugs.webkit.org/show_bug.cgi?id=40312

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasFetchedViaProxy):
        (WebKit::WebURLResponse::setWasFetchedViaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Thu, 10 Jun 2010 13:44:36 +0000 (13:44 +0000)]
2010-06-10  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Adding the ANGLE project to the DEPS file as it's required
        by the gpu-accelerated compositor.
        https://bugs.webkit.org/show_bug.cgi?id=40379

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Jungshik Shin <jshin@chromium.org>
eric@webkit.org [Thu, 10 Jun 2010 13:31:06 +0000 (13:31 +0000)]
2010-06-10  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Kent Tamura

        Bug 38224 - [chromium] Enable rendering of Ethiopic, Lao, Tibetan
                    and a few other scripts on Win XP

        https://bugs.webkit.org/show_bug.cgi?id=38224

        Make it possible to specify a list of fonts for per-script
        fallback instead of a single font per script. This is
        necessary for Malayalam (for which Windows font doesn't
        support Unicode 5.x fully on Vista or earlier), Ethiopic
        (we want to support on XP with a 3rd party font because XP
        doesn't have any Ethiopic font out of the box) and some other
        scripts. This is a short-term 'fix' until we have per-script
        font preferences.

        No layout test is added because the test results would be
        dependent on which fonts are present.

        * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
        (WebCore::):
        (WebCore::FontMap::ScriptToFontFamilies::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 10 Jun 2010 11:23:13 +0000 (11:23 +0000)]
2010-06-09  Andrei Popescu  <andreip@google.com>

        Reviewed by Adam Barth.

        CodeGeneratorJS.pm incorrectly increments $paramIndex when a method is declared with [CallWith]
        https://bugs.webkit.org/show_bug.cgi?id=40372

        Use two variables to keep track of the number of arguments passed from JavaScript vs the number
        of arguments passed to the corresponding C++ method. These numbers can be different since
        the parameter declared via [CallWith] is generated in the bindings instead of being passed
        from JavaScript.

        The layout tests added here test both that the parameters are read correctly as well as
        tests some basic indexed database functionality. There are also bindings specific
        tests added in TestObj.idl.

        * storage/indexeddb/idb-objectstore-request-expected.txt: Added.
        * storage/indexeddb/idb-objectstore-request.html: Added.
        * storage/indexeddb/script-tests/idb-objectstore-request.js: Added.
        (openSuccess):
        (createSuccess):
        (createObjectStore):
        (doCreateOrOpen):
        (test):
2010-06-09  Andrei Popescu  <andreip@google.com>

        Reviewed by Adam Barth.

        CodeGeneratorJS.pm incorrectly increments $paramIndex when a method is declared with [CallWith]
        https://bugs.webkit.org/show_bug.cgi?id=40372

        Use two variables to keep track of the number of arguments passed from JavaScript vs the number
        of arguments passed to the corresponding C++ method. These numbers can be different since
        the parameter declared via [CallWith] is generated in the bindings instead of being passed
        from JavaScript.

        Test: storage/indexeddb/idb-objectstore-request.html

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
        (WebDOMTestObj::withScriptExecutionContext):
        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 10 Jun 2010 10:34:53 +0000 (10:34 +0000)]
2010-06-09  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        Refactoring: Simple shadow elements should be factored out .
        https://bugs.webkit.org/show_bug.cgi?id=40400

        Pulled ShadowElement class up from SliderThumbElement,
        ProgressValueElement, ShadowInputElement.
        And renamed ProgressValueElement to ShadowBlockElement.

        No new tests. Because there is no functional change.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderFileUploadControl.cpp:
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::updateValuePartState):
        * rendering/RenderProgress.h:
        * rendering/RenderSlider.cpp:
        (WebCore::SliderThumbElement::SliderThumbElement):
        (WebCore::SliderThumbElement::defaultEventHandler):
        (WebCore::SliderThumbElement::detach):
        * rendering/ShadowElement.cpp: Added.
        (WebCore::ShadowBlockElement::create):
        (WebCore::ShadowBlockElement::ShadowBlockElement):
        (WebCore::ShadowInputElement::create):
        (WebCore::ShadowInputElement::ShadowInputElement):
        * rendering/ShadowElement.h: Added.
        (WebCore::ShadowElement::ShadowElement):
        (WebCore::ShadowElement::isShadowNode):
        (WebCore::ShadowElement::shadowParentNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 09:31:47 +0000 (09:31 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        Another fix for Windows.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 09:21:40 +0000 (09:21 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        * Api/qwebframe.cpp:
         - Include RenderLayer.h since it's used in this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 09:14:24 +0000 (09:14 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        Another fix for Qt.

        * page/Frame.h:
         - Include CSSMutableStyleDeclaration.h since it's used by m_typingStyle = 0;

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 09:06:08 +0000 (09:06 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        More attempted build fixes for Tiger and Qt.

        * page/Frame.cpp:
        * page/Frame.h:
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        * webkit/webkitwebinspector.cpp:
         - Include RenderLayer.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 08:58:33 +0000 (08:58 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        Add a few more RenderLayer.h includes to fix non-mac builds.

        * page/FrameView.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 10 Jun 2010 08:49:45 +0000 (08:49 +0000)]
2010-06-10  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Remove weakRandomNumber
        https://bugs.webkit.org/show_bug.cgi?id=40291

        weakRandomNumber is used nowhere. Currently, WeakRandom is used instead.

        * wtf/RandomNumber.cpp:
        * wtf/RandomNumber.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Jun 2010 08:35:13 +0000 (08:35 +0000)]
2010-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
        https://bugs.webkit.org/show_bug.cgi?id=40262

        See comment in opacity-change-on-overflow-float.html to understand why
        we made this goofy change.

        * fast/repaint/opacity-change-on-overflow-float.html:
        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
        * platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 08:33:22 +0000 (08:33 +0000)]
2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times
        https://bugs.webkit.org/show_bug.cgi?id=40408

        Cleaned up FrameView.h includes and then propagated the
        cascade of includes to the necessary .cpp files.
        This should reduce the set of files rebuilt every
        time FrameView.h changes, and should also reduce the size
        of some .o files.

        No functional changes, thus no tests.

        * accessibility/AccessibilityRenderObject.cpp:
        * dom/ContainerNode.cpp:
        * dom/Document.cpp:
        * dom/Element.cpp:
        * dom/EventTarget.h:
        * dom/Node.cpp:
        * editing/EditorCommand.cpp:
        * editing/SelectionController.cpp:
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::script):
         - No need for this to be inline.  Being inline required
           Frame.h in the header, which causes huge include cascade.
        * html/HTML5Tokenizer.h:
        * page/DragController.cpp:
        * page/EventHandler.cpp:
        * page/Frame.h:
        * page/FrameView.h:
        * page/PrintContext.cpp:
        * page/SpatialNavigation.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlockLineLayout.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderInline.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderTextControlSingleLine.cpp:
        * rendering/RenderWidget.cpp:
        * rendering/SVGRenderSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: [Qt] When dragging onto a page that handles the drag in Javascript it...
hausmann@webkit.org [Thu, 10 Jun 2010 07:59:09 +0000 (07:59 +0000)]
REGRESSION: [Qt] When dragging onto a page that handles the drag in Javascript it will be a move and not a copy by default
https://bugs.webkit.org/show_bug.cgi?id=40401

Patch by Andy Shaw <andy.shaw@nokia.com> on 2010-06-10
Reviewed by Simon Hausmann.

The correct pattern in Qt for Dnd events is to use acceptProposedAction() instead
of accept().

* Api/qwebpage.cpp:
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Jun 2010 07:48:54 +0000 (07:48 +0000)]
2010-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move HTML5 entity parser to its own file
        https://bugs.webkit.org/show_bug.cgi?id=40406

        Moving this algorithm to its own file better encapsulates its
        dependencies and makes it callable from other parts of WebCore.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTML5EntityParser.cpp: Copied from WebCore/html/HTML5Lexer.cpp.
        (WebCore::):
        (WebCore::consumeHTML5Entity):
        * html/HTML5EntityParser.h: Copied from WebCore/html/HTML5Lexer.h.
        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::processEntity):
        (WebCore::HTML5Lexer::nextToken):
        * html/HTML5Lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Thu, 10 Jun 2010 06:34:46 +0000 (06:34 +0000)]
2010-06-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        HTML5 Parser: Fix fast/profiler tests that depend on event handler line numbers
        https://bugs.webkit.org/show_bug.cgi?id=40393

        This emulated the old behavior in HTMLTokenizer:processToken()

        No new tests because covered by:
         - fast/profiler/dead-time.html
         - fast/profiler/inline-event-handler.html
         - fast/profiler/stop-profiling-after-setTimeout.html
         - fast/profiler/throw-exception-from-eval.html

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::pumpLexer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Undo an accidentally committed change.
ap@apple.com [Thu, 10 Jun 2010 06:19:20 +0000 (06:19 +0000)]
    Undo an accidentally committed change.

        * fast/events/pageshow-pagehide-on-back-cached.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 10 Jun 2010 05:38:32 +0000 (05:38 +0000)]
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Ojan Vafai.

        webkit-patch upload fails for security bugs because there's no rietveld flag
        https://bugs.webkit.org/show_bug.cgi?id=40309

        There's probably a more elegant way of seeing whether the form control
        exists, but this seems to work.

        * Scripts/webkitpy/common/net/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Dan Bernstein.
ap@apple.com [Thu, 10 Jun 2010 05:33:00 +0000 (05:33 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=9504
        img tag rewritten by innerHTML doesn't use image map

        Test: fast/dom/replaced-image-map.html

        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::~HTMLMapElement): Destructor is not a good place to make changes
        that affect page behavior, because destructors are called by garbage collector. Don't
        undregister the image map from here.
        (WebCore::HTMLMapElement::parseMappedAttribute): Only tell document about the map if it's
        actually in document. A map in a detached subtree isn't used by Firefox at least.
        (WebCore::HTMLMapElement::insertedIntoDocument): Register the map.
        (WebCore::HTMLMapElement::removedFromDocument): Unregister the map.

        * html/HTMLMapElement.h: Added insertedIntoDocument/removedFromDocument overrides.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 35632 - htmlediting.cpp : isEmptyTableCell() is incomplete
rolandsteiner@chromium.org [Thu, 10 Jun 2010 05:22:41 +0000 (05:22 +0000)]
Bug 35632 -  htmlediting.cpp : isEmptyTableCell() is incomplete
https://bugs.webkit.org/show_bug.cgi?id=35632

Reviewed by Ojan Vafai.

WebCore:

Correct isEmptyTableCell to check for the presence of other renderer
children.

Test: editing/deleting/delete-br-in-last-table-cell.html

* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell):

LayoutTests:

Correct isEmptyTableCell to check for the presence of other renderer
children.

Layout test checks that deleting a <br> within the last table cell works.

* editing/deleting/delete-br-in-last-table-cell-expected.txt: Added.
* editing/deleting/delete-br-in-last-table-cell.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Pierre Rossi <pierre.rossi@nokia.com>
eric@webkit.org [Thu, 10 Jun 2010 04:39:40 +0000 (04:39 +0000)]
2010-06-09  Pierre Rossi  <pierre.rossi@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        QWebPage::findText() does not clear selection when passed empty string
        https://bugs.webkit.org/show_bug.cgi?id=31779

        * Api/qwebpage.cpp:
        (QWebPage::findText):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::findText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Bo Liu <boliu@chromium.org>
eric@webkit.org [Thu, 10 Jun 2010 04:26:30 +0000 (04:26 +0000)]
2010-06-09  Bo Liu  <boliu@chromium.org>

        Reviewed by David Levin.

        [Chromium] Pass <video> full screen calls to Chromium port client
        https://bugs.webkit.org/show_bug.cgi?id=40317

        * public/WebViewClient.h:
        (WebKit::WebViewClient::supportsFullscreen):
        (WebKit::WebViewClient::enterFullscreenForNode):
        (WebKit::WebViewClient::exitFullscreenForNode):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullscreenForNode):
        (WebKit::ChromeClientImpl::enterFullscreenForNode):
        (WebKit::ChromeClientImpl::exitFullscreenForNode):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Qi Zhang <qi.2.zhang@nokia.com>
eric@webkit.org [Thu, 10 Jun 2010 03:47:50 +0000 (03:47 +0000)]
2010-06-09  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.transformation.html
        https://bugs.webkit.org/show_bug.cgi?id=38598

        Remove canvas/philip/tests/2d.path.arcTo.scale.html, canvas/philip/tests/2d.path.arcTo.transformation.html
        and canvas/philip/tests/2d.path.transformation.changing.html from Skipped.

        * platform/qt/Skipped:
2010-06-09  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.transformation.html
        https://bugs.webkit.org/show_bug.cgi?id=38598

        In path transform function handle path only have moveElement case.

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 10 Jun 2010 03:01:40 +0000 (03:01 +0000)]
2010-06-09  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] First phase of switching to new named property query API
        https://bugs.webkit.org/show_bug.cgi?id=40303

        To allow better management of attributes of intercepted properties,
        we're starting to switch to new named property query API which
        now could return attributes instead of simple property present/absent
        flag.  The next step would remove USE_NEW_QUERY_CALLBACK, then
        v8 would have them enabled by default.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/ScriptArray.cpp:
        * bindings/v8/ScriptCallStack.cpp:
        * bindings/v8/SerializedScriptValue.cpp:
        * bindings/v8/V8Binding.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8GCController.cpp:
        * bindings/v8/V8IsolatedContext.cpp:
        * bindings/v8/V8NPObject.cpp:
        (WebCore::npObjectQueryProperty):
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/custom/V8PopStateEventCustom.cpp:
        * bindings/v8/custom/V8StorageCustom.cpp:
        (WebCore::V8Storage::namedPropertyQuery):
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 10 Jun 2010 02:40:54 +0000 (02:40 +0000)]
2010-06-09  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Need to include V8Proxy.h in V8 generated bindings for toV8Context()
        https://bugs.webkit.org/show_bug.cgi?id=40290

        No new tests, build fix only.

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 10 Jun 2010 02:29:00 +0000 (02:29 +0000)]
2010-06-09  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        WebGL rendering context does not activate unless accelerated
        compositing is enabled from settings.
        https://bugs.webkit.org/show_bug.cgi?id=37772

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 10 Jun 2010 02:13:31 +0000 (02:13 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] PageClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40257

        * WebCoreSupport/PageClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 10 Jun 2010 02:00:49 +0000 (02:00 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] InspectorClientQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40255

        * WebCoreSupport/InspectorClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Yong Li <yoli@rim.com>
eric@webkit.org [Thu, 10 Jun 2010 01:48:02 +0000 (01:48 +0000)]
2010-06-09  Yong Li  <yoli@rim.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=40252
        Make image down-sampling threshold runtime adjustable.

        No new test needed.

        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::setData):
        * platform/graphics/ImageSource.h:
        (WebCore::ImageSource::maxPixelsPerDecodedImage):
        (WebCore::ImageSource::setMaxPixelsPerDecodedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 10 Jun 2010 00:49:25 +0000 (00:49 +0000)]
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix handling of bytes received from the network while in document.write
        https://bugs.webkit.org/show_bug.cgi?id=40356

        The old tokenizer has specially logic for handling the case of
        receiving bytes from the network while in a nested call to
        document.write.  This patch implements similar logic for the HTML5
        tokenizer.  Also, this patch abstracts the tricky shuffling of
        SegmentedStrings behind a simple API.

        I'm not sure how to trigger this case.  My guess is we can trigger it
        using a nested event loop, e.g., via alert(), but I'm not sure how to
        test that in a LayoutTest.  There don't appear to be any LayoutTests
        that currently test this behavior despite it being present in the old
        tokenizer.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::pumpLexer):
        (WebCore::HTML5Tokenizer::write):
            - Added a branch for the |append| argument.
        (WebCore::HTML5Tokenizer::end):
        (WebCore::HTML5Tokenizer::finish):
        (WebCore::HTML5Tokenizer::executeScript):
            - Switch over to using a RAII pattern for recording and restoring
              insertion points.
        * html/HTML5Tokenizer.h:
        (WebCore::HTML5Tokenizer::InputStream::InputStream):
        (WebCore::HTML5Tokenizer::InputStream::appendToEnd):
        (WebCore::HTML5Tokenizer::InputStream::insertAtCurrentInsertionPoint):
        (WebCore::HTML5Tokenizer::InputStream::close):
            - Putting the close() method on InputStream makes it much easier to
              handle EOF.  We now just close the last buffer in the stream when
              the network says it's done.
        (WebCore::HTML5Tokenizer::InputStream::current):
            - This class could be moved to its own file, but it shouldn't be
              used outside of the tokenizer.
        (WebCore::HTML5Tokenizer::InsertionPointRecord::InsertionPointRecord):
        (WebCore::HTML5Tokenizer::InsertionPointRecord::~InsertionPointRecord):
            - A simple RAII class for managing saved insertion points.
        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::operator=):
            - Fix a related bug where m_closed was not being copied properly in
              the assignment operator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 10 Jun 2010 00:30:41 +0000 (00:30 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] FrameLoaderClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40251

        * WebCoreSupport/FrameLoaderClientQt.h:
        (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 10 Jun 2010 00:28:03 +0000 (00:28 +0000)]
2010-06-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        make rietveld upload faster and avoid posting to bug on errors
        https://bugs.webkit.org/show_bug.cgi?id=40389

        Only grab the first item of the upload queue instead of trying
        to compute the whole list upfront (which is O(n) bugzilla lookups!).

        Also, don't post comments to the bug when uploading fails.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/stepsequence.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 23:25:49 +0000 (23:25 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] EditorClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40249

        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add myself to the committer list.
zmo@google.com [Wed, 9 Jun 2010 23:18:42 +0000 (23:18 +0000)]
Unreviewed.  Add myself to the committer list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 22:55:11 +0000 (22:55 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] EditCommandQt.cpp/h have coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40248

        * WebCoreSupport/EditCommandQt.cpp:
        (EditCommandQt::EditCommandQt):
        (EditCommandQt::~EditCommandQt):
        (EditCommandQt::redo):
        (EditCommandQt::undo):
        * WebCoreSupport/EditCommandQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 22:45:42 +0000 (22:45 +0000)]
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix typo in fast/lists/ordered-list-with-no-ol-tag.html
        https://bugs.webkit.org/show_bug.cgi?id=40391

        This test contains an untermianted end tag, which parses differently in
        the HTML5 parser than in the legacy parser.  Having read the bug that
        caused this test to be added, making the text valid HTML seems to
        respect the intent of the test (which is about numbering).

        As discussed in other patches, we have the parsing behavior covered in
        parsing tests.

        * fast/lists/ordered-list-with-no-ol-tag.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 22:43:44 +0000 (22:43 +0000)]
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make invalid comment in fast/css/word-space-extra.html really invalid
        https://bugs.webkit.org/show_bug.cgi?id=40388

        This test tries to have a comment inside a comment.  To make that work
        in the old parser, the author added a space between the -- and the >.
        However, that's a valid end-of-comment in the new parser.  I've change
        the space to a * to really make it not a valid end of comment.

        * fast/css/word-space-extra.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Brady Eidson.
ap@apple.com [Wed, 9 Jun 2010 22:30:49 +0000 (22:30 +0000)]
    Reviewed by Brady Eidson.

        Export StringImpl::ascii(). It might be not very useful, but it's a public function.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 22:07:03 +0000 (22:07 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] DumpRenderTreeSupportQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40247

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::firstRectForCharacterRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Wed, 9 Jun 2010 22:05:20 +0000 (22:05 +0000)]
2010-06-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix fast/parser/hex-entities-length.html for HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=40385

        Stripping surrogate pair values appears to be a problem with the spec
        in "Preprocessing the input stream." Minefield doesn't appear to
        implement the part in question. So this patch removes that guard and
        adds a FIXME to track the issue.

        No new tests because covered by fast/parser/hex-entities-length.html

        * html/HTML5Lexer.h:
        (WebCore::HTML5Lexer::InputStreamPreprocessor::peek):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 21:51:49 +0000 (21:51 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] DragClientQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40246

        * WebCoreSupport/DragClientQt.cpp:
        (WebCore::DragClientQt::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 9 Jun 2010 21:39:42 +0000 (21:39 +0000)]
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Update readPixels to take ArrayBufferView rather than returning it
        https://bugs.webkit.org/show_bug.cgi?id=40322

        No new tests; covered by existing tests, which have been modified.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::readPixels):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Test how XML directives get attached to the DOM
        https://bugs.webkit.org/show_bug.cgi?id=40384

        In the old parser, the XML directive doesn't get added to the DOM.  In
        new parser (and in Minefield), it gets added as a comment, which shows
        up in this test.

        This behavior was tested more obliquely by
        fast/css-generated-content/hover-style-change.html in some
        DumpRenderTree output.  I've removed that coverage from the CSS test
        and moved it to a new parser test that can actually be run in other
        browsers.

        * fast/css-generated-content/hover-style-change.html:
            - Remove XML directive that was causing this test to depend on
              out-of-spec parser behavior w.r.t. whether to attach the XML
              directive to the DOM.
        * fast/parser/xml-directive-in-dom-expected.txt: Added.
        * fast/parser/xml-directive-in-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 21:19:51 +0000 (21:19 +0000)]
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Test how XML directives get attached to the DOM
        https://bugs.webkit.org/show_bug.cgi?id=40384

        In the old parser, the XML directive doesn't get added to the DOM.  In
        new parser (and in Minefield), it gets added as a comment, which shows
        up in this test.

        This behavior was tested more obliquely by
        fast/css-generated-content/hover-style-change.html in some
        DumpRenderTree output.  I've removed that coverage from the CSS test
        and moved it to a new parser test that can actually be run in other
        browsers.

        * fast/css-generated-content/hover-style-change.html:
            - Remove XML directive that was causing this test to depend on
              out-of-spec parser behavior w.r.t. whether to attach the XML
              directive to the DOM.
        * fast/parser/xml-directive-in-dom-expected.txt: Added.
        * fast/parser/xml-directive-in-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 21:07:15 +0000 (21:07 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Laszlo Gombos.

        [Qt] ContextMenuClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40242

        * WebCoreSupport/ContextMenuClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Fix drawing zero-sized gradients on Canvas.
jchaffraix@webkit.org [Wed, 9 Jun 2010 21:02:47 +0000 (21:02 +0000)]
WebCore: Fix drawing zero-sized gradients on Canvas.
https://bugs.webkit.org/show_bug.cgi?id=40340

Patch by Enrico Ros <eros@codeaurora.org> on 2010-06-09
Reviewed by Ariya Hidayat.

HTML5 draft says that nothing must be painted if the gradient start
point equals the stop point.

This commit fixes the following canvas test:
http://philip.html5.org/tests/canvas/suite/tests/2d.gradient.interpolate.zerosize.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect): skip zero-sized linear gradients
* platform/graphics/Gradient.h:
(WebCore::Gradient::isRadial): made public
(WebCore::Gradient::isZeroSize): true if start == stop

LayoutTests: Fixed zero-sized gradients on canvas.
https://bugs.webkit.org/show_bug.cgi?id=40340

Patch by Enrico Ros <eros@codeaurora.org> on 2010-06-09
Reviewed by Ariya Hidayat.

* platform/mac/Skipped: Unskip the test that is passing now.
* platform/qt/Skipped: Unskip the test that is passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 20:53:30 +0000 (20:53 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] ChromeClientQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40240

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::pageRect):
        (WebCore::ChromeClientQt::createWindow):
        (WebCore::ChromeClientQt::runJavaScriptAlert):
        (WebCore::ChromeClientQt::runJavaScriptConfirm):
        (WebCore::ChromeClientQt::runJavaScriptPrompt):
        (WebCore::ChromeClientQt::print):
        (WebCore::ChromeClientQt::attachRootGraphicsLayer):
        (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Wed, 9 Jun 2010 20:31:37 +0000 (20:31 +0000)]
2010-06-09  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Adam Treat.

        [EFL] Allow building core libraries as shared objects to speed up
        linking time on machines with small amounts of memory.
        http://webkit.org/b/39899

        * CMakeLists.txt: Add SHARED_CORE option.
        * cmake/FindGlib.cmake: Add GObject to the list of GLib libraries to
        search.
        * cmake/OptionsEfl.cmake: Remove default library type definitions.
        * cmake/WebKitHelpers.cmake: -fvisibility=hidden did not behave well
        when SHARED_CORE is used.
2010-06-09  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Adam Treat.

        [EFL] Allow building core libraries as shared objects to speed up
        linking time on machines with small amounts of memory.
        http://webkit.org/b/39899

        * CMakeLists.txt: If building with shared core, install the lib.
        * jsc/CMakeListsEfl.txt: Needs Glib and Ecore to link dynamically.
        * wtf/CMakeLists.txt: If building with shared core, install the lib.
2010-06-09  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Adam Treat.

        [EFL] Allow building core libraries as shared objects to speed up
        linking time on machines with small amounts of memory.
        http://webkit.org/b/39899

        * CMakeLists.txt: If building with shared core, install the lib.
        Remove npapi.cpp (causes conflicts when linking dynamically).
        * CMakeListsEfl.txt: EFL libraries are needed to link dynamically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8070662> REGRESSION (r51629): WebBackForwardList created via -init...
mrowe@apple.com [Wed, 9 Jun 2010 20:03:37 +0000 (20:03 +0000)]
<rdar://problem/8070662> REGRESSION (r51629): WebBackForwardList created via -init crashes when -addItem: is called.

Reviewed by Adele Peterson.

A WebBackForwardList created via -init results in a BackForwardList being created with a null m_page.
BackForwardList needs to be careful not to dereference m_page without first ensuring it's not null.

* history/BackForwardList.cpp:
(WebCore::BackForwardList::addItem): Null-check m_page.
(WebCore::BackForwardList::goBack): Ditto.
(WebCore::BackForwardList::goForward): Ditto.
(WebCore::BackForwardList::goToItem): Ditto.
(WebCore::BackForwardList::setCapacity): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 9 Jun 2010 19:37:42 +0000 (19:37 +0000)]
2010-06-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add dummy Context Menu implementation
        https://bugs.webkit.org/show_bug.cgi?id=40223

        Brew MP does not use Context Menu. Add dummy implementation.

        * platform/brew/ContextMenuBrew.cpp: Added.
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::~ContextMenu):
        (WebCore::ContextMenu::itemCount):
        (WebCore::ContextMenu::insertItem):
        (WebCore::ContextMenu::appendItem):
        (WebCore::ContextMenu::itemWithAction):
        (WebCore::ContextMenu::itemAtIndex):
        (WebCore::ContextMenu::setPlatformDescription):
        (WebCore::ContextMenu::platformDescription):
        (WebCore::ContextMenu::releasePlatformDescription):
        * platform/brew/ContextMenuItemBrew.cpp: Added.
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::~ContextMenuItem):
        (WebCore::ContextMenuItem::releasePlatformDescription):
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::action):
        (WebCore::ContextMenuItem::title):
        (WebCore::ContextMenuItem::platformSubMenu):
        (WebCore::ContextMenuItem::setType):
        (WebCore::ContextMenuItem::setAction):
        (WebCore::ContextMenuItem::setTitle):
        (WebCore::ContextMenuItem::setSubMenu):
        (WebCore::ContextMenuItem::setChecked):
        (WebCore::ContextMenuItem::setEnabled):
        (WebCore::ContextMenuItem::enabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 9 Jun 2010 19:25:25 +0000 (19:25 +0000)]
2010-06-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Port Clipboard
        https://bugs.webkit.org/show_bug.cgi?id=35734

        Add dummy Clipboard.

        * platform/brew/ClipboardBrew.cpp: Added.
        (WebCore::ClipboardBrew::ClipboardBrew):
        (WebCore::ClipboardBrew::~ClipboardBrew):
        (WebCore::ClipboardBrew::clearData):
        (WebCore::ClipboardBrew::clearAllData):
        (WebCore::ClipboardBrew::getData):
        (WebCore::ClipboardBrew::setData):
        (WebCore::ClipboardBrew::types):
        (WebCore::ClipboardBrew::files):
        (WebCore::ClipboardBrew::setDragImage):
        (WebCore::ClipboardBrew::setDragImageElement):
        (WebCore::ClipboardBrew::createDragImage):
        (WebCore::ClipboardBrew::declareAndWriteDragImage):
        (WebCore::ClipboardBrew::writeURL):
        (WebCore::ClipboardBrew::writeRange):
        (WebCore::ClipboardBrew::writePlainText):
        (WebCore::ClipboardBrew::hasData):
        * platform/brew/ClipboardBrew.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 19:12:56 +0000 (19:12 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] ClipboardQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39781

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBugzilla: Don't send mail for cancel/deny/granted for in-rietveld.
jparent@chromium.org [Wed, 9 Jun 2010 19:06:04 +0000 (19:06 +0000)]
Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=40345

* Bugzilla/Flag.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 9 Jun 2010 18:32:27 +0000 (18:32 +0000)]
2010-06-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Rietveld upload queue fails when setting in-rietveld flag
        https://bugs.webkit.org/show_bug.cgi?id=40371

        Make the comment arguments to set_flag_on_attachment optional
        and add it to the MockBugzilla.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 9 Jun 2010 18:24:10 +0000 (18:24 +0000)]
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * src/GraphicsContext3D.cpp:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::float32ArrayEnabled):
        * bindings/js/JSArrayBufferViewCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::float32Array):
        (WebCore::JSDOMWindow::webGLFloatArray):
        * bindings/js/JSFloat32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSFloatArrayConstructor.cpp.
        (WebCore::):
        (WebCore::JSFloat32ArrayConstructor::JSFloat32ArrayConstructor):
        (WebCore::constructCanvasFloatArray):
        (WebCore::JSFloat32ArrayConstructor::getConstructData):
        * bindings/js/JSFloat32ArrayConstructor.h: Copied from WebCore/bindings/js/JSFloatArrayConstructor.h.
        * bindings/js/JSFloat32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSFloatArrayCustom.cpp.
        (WebCore::JSFloat32Array::indexSetter):
        (WebCore::toJS):
        (WebCore::JSFloat32Array::set):
        * bindings/js/JSFloatArrayConstructor.cpp: Removed.
        * bindings/js/JSFloatArrayConstructor.h: Removed.
        * bindings/js/JSFloatArrayCustom.cpp: Removed.
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::dataFunctionf):
        (WebCore::dataFunctionMatrix):
        * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
        * bindings/v8/custom/V8Float32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8FloatArrayCustom.cpp.
        (WebCore::V8Float32Array::constructorCallback):
        (WebCore::V8Float32Array::setCallback):
        (WebCore::toV8):
        * bindings/v8/custom/V8FloatArrayCustom.cpp: Removed.
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::vertexAttribAndUniformHelperf):
        (WebCore::uniformMatrixHelper):
        * html/canvas/Float32Array.cpp: Copied from WebCore/html/canvas/FloatArray.cpp.
        (WebCore::Float32Array::create):
        (WebCore::Float32Array::Float32Array):
        (WebCore::Float32Array::slice):
        * html/canvas/Float32Array.h: Copied from WebCore/html/canvas/FloatArray.h.
        * html/canvas/Float32Array.idl: Copied from WebCore/html/canvas/FloatArray.idl.
        * html/canvas/FloatArray.cpp: Removed.
        * html/canvas/FloatArray.h: Removed.
        * html/canvas/FloatArray.idl: Removed.
        * html/canvas/WebGLGetInfo.cpp:
        (WebCore::WebGLGetInfo::WebGLGetInfo):
        (WebCore::WebGLGetInfo::getWebGLFloatArray):
        * html/canvas/WebGLGetInfo.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getUniform):
        (WebCore::WebGLRenderingContext::getVertexAttrib):
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):
        (WebCore::WebGLRenderingContext::vertexAttrib1fv):
        (WebCore::WebGLRenderingContext::vertexAttrib2fv):
        (WebCore::WebGLRenderingContext::vertexAttrib3fv):
        (WebCore::WebGLRenderingContext::vertexAttrib4fv):
        (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
        * page/DOMWindow.idl:
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/constructed-objects-prototypes.js:
        (constructorPropertiesOnWindow):
        * fast/dom/script-tests/prototype-inheritance-2.js:
        (constructorNamesForWindow):
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/js/script-tests/global-constructors.js:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * Scripts/do-webcore-rename:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some unused variable warnings from JITOpcodes
loki@webkit.org [Wed, 9 Jun 2010 18:12:01 +0000 (18:12 +0000)]
Remove some unused variable warnings from JITOpcodes
https://bugs.webkit.org/show_bug.cgi?id=40298

Reviewed by David Levin.

* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:49:48 +0000 (17:49 +0000)]
2010-06-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        video-timeupdate-duringplayback.html missing closing angle
        https://bugs.webkit.org/show_bug.cgi?id=40311

        This patch removes invalid markup from video-timeupdate-during-playback.html
        because that is not the point of that test. It adds a new test with
        the same markup to webkit01.dat. New test fails with --html5-parser.

        * html5lib/resources/webkit01.dat:
        * media/video-timeupdate-during-playback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:12:01 +0000 (17:12 +0000)]
2010-06-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        LayoutTests needlessly depend on old parser quirks covered by other tests
        https://bugs.webkit.org/show_bug.cgi?id=40354

        There are two quirks of the old HTMLTokenizer which I'm removing
        from various tests in this change.
         - <tag<tag> parsing is a quirk unique to WebKit's old tokenizer
           and is already tested by fast/invalid/016.html and
           html5lib/runner.html.
         - <script/> is another quirk unique to WebKit's old tokenizer and
           is covered by fast/parser/script-tag-with-trailing-slash.html

        * fast/block/float/4145535Crash.html:
         - The test tests a CSS crasher.  Changed the html to
           be explicit about how it should be parsed instead of
           depending on the <tag<tag> quirk of the old parser.
        * fast/dom/HTMLScriptElement/script-load-events.html:
         - Remove testing of <script/> since that's already covered
           by fast/parser/script-tag-with-trailing-slash.html
        * fast/dom/HTMLScriptElement/script-set-src-expected.txt:
         - Same as above.
        * fast/dom/HTMLScriptElement/script-set-src.html:
         - Same as above.
        * fast/events/pageshow-pagehide.html:
         - Remove dependence on <tag<tag> quirk.
        * fast/events/resources/pageshow-pagehide-subframe-cachable.html:
         - <tag<tag> quirk.
        * fast/events/resources/pageshow-pagehide-subframe.html:
         - <tag<tag> quirk.
        * fast/frames/sandboxed-iframe-navigation-parent.html:
         - <tag<tag> quirk.
        * fast/lists/w3-css3-list-styles-alphabetic.html:
         - <tag<tag> quirk.
        * fast/multicol/negativeColumnWidth.html:
         - <tag<tag> quirk.
        * fast/ruby/ruby-illegal-2.html:
         - The original fix (https://trac.webkit.org/changeset/53525) was
           a fix to rendering code.  I've simply corrected the test to be
           explicit about how it should be parsed so that it can test the
           rendering code path without depending on the <tag<tag> quirk
           of the old HTMLTokenizer.
        * fast/ruby/ruby-illegal-3.html:
         - Same as above.
        * http/tests/misc/generated-content-inside-table.html:
         - Remove dependence on the <script/> quirk.
        * svg/custom/svg-fonts-in-html-linebreaks.html:
         - <tag<tag> quirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:09:03 +0000 (17:09 +0000)]
2010-06-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5 Parser needs to integrate with the XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=40287

        This fixes most of the XSSAuditor tests, except for the ones
        which rely on the srcValue "context".  The previous HTMLTokenizer
        implementation was both Lexer and ScriptRunner and thus could
        provide the XSSAuditor with the un-modified attribute source.
        This naive implementation will fail the context-sensitive tests
        but Adam Barth says he'll just have to find a new way to provide
        the required information to the XSSAuditor in a later patch.

        Covered by numerous http/tests/security/xssAuditor tests.

        * html/HTML5ScriptRunner.cpp:
        (WebCore::HTML5ScriptRunner::requestScript):
         - Ask the HTML5ScriptRunner host before running any scripts.
        * html/HTML5ScriptRunnerHost.h:
         - Add a shouldLoadExternalScriptFromSrc declaration.
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::shouldLoadExternalScriptFromSrc):
         - Ask the XSSAuditor if we're allowed to run the passed script.
        * html/HTML5Tokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:05:17 +0000 (17:05 +0000)]
2010-06-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix script-after-frameset test in HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=40274

        The old HTMLTokenizer enforced this in scriptHandler(). We don't use
        that code anymore, so it needs to be implemented. The spec does this
        as a part of "insertion mode"->"after frameset", so this adds an
        InsertionMode enum instead of a one-off boolean.

        No new tests because covered by fast/tokenizer/script-after-frameset.html

        * html/HTML5TreeBuilder.cpp:
        (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
        (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
        * html/HTML5TreeBuilder.h:
        (WebCore::HTML5TreeBuilder::):
        (WebCore::HTML5TreeBuilder::setInsertionMode):
        (WebCore::HTML5TreeBuilder::insertionMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 9 Jun 2010 16:58:57 +0000 (16:58 +0000)]
2010-06-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add EventLoop
        https://bugs.webkit.org/show_bug.cgi?id=39401

        BREW MP does not have an explicit event loop. Add dummy EventLoop::cycle.

        * platform/brew/EventLoopBrew.cpp: Added.
        (WebCore::EventLoop::cycle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Wed, 9 Jun 2010 16:01:01 +0000 (16:01 +0000)]
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * inspector/InspectorClient.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::InspectorFrontend):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::frontendLoaded):
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorObject::writeJSON):
        * inspector/front-end/inspector.js:
        * loader/EmptyClients.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * efl/WebCoreSupport/InspectorClientEfl.cpp:
        * efl/WebCoreSupport/InspectorClientEfl.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/WebInspectorClientCF.cpp:
        (WebInspectorClient::storeSetting):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * src/InspectorClientImpl.cpp:
        * src/InspectorClientImpl.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::InspectorClient):
        (WebKit::InspectorClient::openInspectorFrontend):
        (WebKit::InspectorFrontendClient::InspectorFrontendClient):
        (WebKit::InspectorFrontendClient::destroyInspectorWindow):
        * WebCoreSupport/InspectorClientGtk.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/InspectorClientHaiku.cpp:
        * WebCoreSupport/InspectorClientHaiku.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::openInspectorFrontend):
        (-[WebInspectorWindowController destroyInspectorView]):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::InspectorClientQt):
        (WebCore::InspectorClientQt::openInspectorFrontend):
        (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
        (WebCore::InspectorFrontendClientQt::closeWindow):
        * WebCoreSupport/InspectorClientQt.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::~WebInspectorClient):
        (WebInspectorClient::openInspectorFrontend):
        * WebCoreSupport/WebInspectorClient.h:
        (WebInspectorClient::frontendClosing):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebKitSupport/InspectorClientWx.cpp:
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 9 Jun 2010 15:51:58 +0000 (15:51 +0000)]
2010-06-09  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Carlson.

        [Windows] Build fix on Japanese Windows
        https://bugs.webkit.org/show_bug.cgi?id=40358

        cl.exe on Japanese Windows assumes files with invalid CP932
        sequences broken and doesn't build them at all.

        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Remove non-ASCII characters
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: ditto.
        * platform/graphics/win/WKCAImageQueue.cpp: ditto.
        * platform/graphics/win/WKCAImageQueue.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Pavel Podivilov <podivilov@chromium.org>
yurys@chromium.org [Wed, 9 Jun 2010 15:00:30 +0000 (15:00 +0000)]
2010-06-09  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Add isDebuggerAlwaysEnabled method to ScriptDebugServer.
        This method returns true if debugger should always be enabled when
        frontend is attached.
        https://bugs.webkit.org/show_bug.cgi?id=40289

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontend):
2010-06-09  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: retreive debugger script source synchronously when
        frontend is attached. We need this to be able to stop on top-level
        breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=40289

        * WebKit.gypi:
        * src/DebuggerAgent.h:
        * src/DebuggerAgentImpl.cpp:
        * src/DebuggerAgentImpl.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
        * src/js/DebuggerScript.js:
        * src/js/DevTools.js:
        (WebInspector.loaded):
        * src/js/DevToolsHostStub.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60893 268f45cc-cd09-0410-ab3c-d52691b4dbfc