WebKit-https.git
9 years agoAdd standalone script that filters the output of build-webkit to be more human-readable
mdelaney@apple.com [Thu, 8 Sep 2011 07:05:15 +0000 (07:05 +0000)]
Add standalone script that filters the output of build-webkit to be more human-readable
https://bugs.webkit.org/show_bug.cgi?id=44081

Reviewed by Daniel Bates.

* Scripts/filter-build-webkit: Added. Just need to feed it the output of
a build script (e.g. build-webkit) and it spits out a prettier version.
* Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
* Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd myself to committers.py
noel.gordon@gmail.com [Thu, 8 Sep 2011 04:31:48 +0000 (04:31 +0000)]
Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=67696

Reviewed by Kent Tamura.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo in test_expectations introduced with r94725
rniwa@webkit.org [Thu, 8 Sep 2011 04:03:13 +0000 (04:03 +0000)]
Fix typo in test_expectations introduced with r94725
https://bugs.webkit.org/show_bug.cgi?id=67758

image-makering.html -> image-color-matching.html

Patch by Ben Wells <benwells@chromium.org> on 2011-09-07
Reviewed by Ryosuke Niwa.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Snow Leopard results for this new test.
mitz@apple.com [Thu, 8 Sep 2011 03:39:35 +0000 (03:39 +0000)]
Added Snow Leopard results for this new test.

* platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94674 and r94689.
commit-queue@webkit.org [Thu, 8 Sep 2011 03:00:31 +0000 (03:00 +0000)]
Unreviewed, rolling out r94674 and r94689.
http://trac.webkit.org/changeset/94674
http://trac.webkit.org/changeset/94689
https://bugs.webkit.org/show_bug.cgi?id=67754

Broke inspector/debugger/script-formatter.html (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt: Removed.
* inspector/debugger/raw-source-code.html: Removed.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agooffsetFromRoot optimization is disabled after r93837
jchaffraix@webkit.org [Thu, 8 Sep 2011 01:38:22 +0000 (01:38 +0000)]
offsetFromRoot optimization is disabled after r93837
https://bugs.webkit.org/show_bug.cgi?id=67677

Reviewed by Simon Fraser.

Unfortunately not covered by any test as it does not change updateLayerPosition complexity (it is still O(n^2)
because of clippedOverflowRectForRepaint). However it is a noticeable slowdown on some use cases but we don't
have a good test harness to cover such slowdown.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Pass offsetFromRoot as not doing so means that we miss
the optimization altogether.

(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
* rendering/RenderLayer.h:
Renamed |cachedOffset| to |offsetFromRoot| to be consistent with our latest renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix my commit per darin's suggestion.
rniwa@webkit.org [Thu, 8 Sep 2011 01:31:26 +0000 (01:31 +0000)]
Fix my commit per darin's suggestion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r94737.
rniwa@webkit.org [Thu, 8 Sep 2011 01:27:06 +0000 (01:27 +0000)]
Windows build fix after r94737.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved hyphenation function implementations for an usupported build configuration.
mitz@apple.com [Thu, 8 Sep 2011 00:55:20 +0000 (00:55 +0000)]
Removed hyphenation function implementations for an usupported build configuration.

Reviewed by Sam Weinig.

* platform/text/cf/HyphenationCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=67739
hyatt@apple.com [Thu, 8 Sep 2011 00:50:24 +0000 (00:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67739

adjustRectForColumns is O(# of columns) when it can be O(1). Fix the slow performance of this
function by removing the loop and just computing the start and end column for a repaint rect
and uniting everything in between.

Reviewed by Dan Bernstein.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate baselines for svg/as-background-image. These results all appear
abarth@webkit.org [Thu, 8 Sep 2011 00:26:51 +0000 (00:26 +0000)]
Update baselines for svg/as-background-image.  These results all appear
correct and test_expectations indicates that they just need new
baselines.

* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-win-vista/svg/as-background-image: Added.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* svg/as-background-image/animated-svg-as-background-expected.txt: Added.
* svg/as-background-image/svg-as-background-1-expected.txt: Added.
* svg/as-background-image/svg-as-background-3-expected.txt: Added.
* svg/as-background-image/svg-as-background-5-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThese tests just differ in how JSC and V8 report error messages.
abarth@webkit.org [Thu, 8 Sep 2011 00:18:52 +0000 (00:18 +0000)]
These tests just differ in how JSC and V8 report error messages.

* platform/chromium-cg-mac-leopard/http/tests/security: Added.
* platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
* platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
* platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOur results here reflect an intentional difference between GURL and
abarth@webkit.org [Thu, 8 Sep 2011 00:13:28 +0000 (00:13 +0000)]
Our results here reflect an intentional difference between GURL and
KURL.  KURL doesn't handle non-ASCII characters in the fragment in the
same was as IE whereas GURL does.

* platform/chromium/http/tests/uri: Added.
* platform/chromium/http/tests/uri/resolve-encoding-relative-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOur behavior is correct with respect to the new cookie RFC. I'm told
abarth@webkit.org [Thu, 8 Sep 2011 00:01:47 +0000 (00:01 +0000)]
Our behavior is correct with respect to the new cookie RFC.  I'm told
that CFNetwork is going to change this behavior to match every other
browser.

* platform/chromium/http/tests/cookies: Added.
* platform/chromium/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94714 and r94723.
commit-queue@webkit.org [Wed, 7 Sep 2011 23:51:15 +0000 (23:51 +0000)]
Unreviewed, rolling out r94714 and r94723.
http://trac.webkit.org/changeset/94714
http://trac.webkit.org/changeset/94723
https://bugs.webkit.org/show_bug.cgi?id=67746

breaks gtk-linux tests with assertion failure (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::inTransparencyLayer):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::getWindowsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
* rendering/RenderThemeWin.cpp:
(WebCore::drawControl):

LayoutTests:

* platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Removed.
* platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Removed.
* platform/chromium-win/svg/custom/simple-text-double-shadow.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* svg/custom/simple-text-double-shadow.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPPC build fix.
fpizlo@apple.com [Wed, 7 Sep 2011 23:48:54 +0000 (23:48 +0000)]
PPC build fix.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate results. The actual results are only off by a fraction of a
abarth@webkit.org [Wed, 7 Sep 2011 23:48:13 +0000 (23:48 +0000)]
Update results.  The actual results are only off by a fraction of a
pixel around the curve in the zero.

* platform/chromium-cg-mac/media/audio-repaint-expected.txt: Removed.
* platform/chromium-mac/media/audio-repaint-expected.txt: Removed.
* platform/chromium-win-xp/media: Removed.
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium/media/audio-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThese results are also off by just factional pixels.
abarth@webkit.org [Wed, 7 Sep 2011 23:43:25 +0000 (23:43 +0000)]
These results are also off by just factional pixels.

* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThese results all differ only in less than one pixel border or text rendering.
abarth@webkit.org [Wed, 7 Sep 2011 23:38:03 +0000 (23:38 +0000)]
These results all differ only in less than one pixel border or text rendering.

* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2886-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug6674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2886-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug6674-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Mac baseline for the test added by r94331.
rniwa@webkit.org [Wed, 7 Sep 2011 23:35:07 +0000 (23:35 +0000)]
Add Mac baseline for the test added by r94331.

* platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline for r94710.
rniwa@webkit.org [Wed, 7 Sep 2011 23:26:58 +0000 (23:26 +0000)]
Rebaseline for r94710.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 23:25:28 +0000 (23:25 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium svg/ rebaselines.

        * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-cg-mac-leopard/svg/batik/filters/feTile-expected.png:
        * platform/chromium-cg-mac-leopard/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-cg-mac-leopard/svg/filters/filterRes-expected.png:
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-cg-mac/svg/batik/filters/feTile-expected.png:
        * platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-cg-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-cg-mac/svg/filters/filterRes-expected.png:
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-win-vista/svg/filters: Removed.
        * platform/chromium-win-xp/svg/css: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-win/svg/filters/filterRes-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocss2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
rniwa@webkit.org [Wed, 7 Sep 2011 23:16:08 +0000 (23:16 +0000)]
css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by Dan Bernstein.

Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
replace line-after-floating-div.html by the fixed version.

Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.

* css2.1/t090204-display-change-01-b-ao.html:
* fast/css/line-after-floating-div-expected.png: Removed.
* fast/css/line-after-floating-div-expected.txt: Removed.
* fast/css/line-after-floating-div.html:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
* platform/mac/fast/css/line-after-floating-div-expected.png: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.png.
* platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, Chromium baselines for svg/custom/simple-text-double-shadow
timothy_horton@apple.com [Wed, 7 Sep 2011 23:10:21 +0000 (23:10 +0000)]
Unreviewed, Chromium baselines for svg/custom/simple-text-double-shadow

* platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Added.
* platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Added.
* platform/chromium-win/svg/custom/simple-text-double-shadow.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorebaseline button in garden-o-matic details view should work
abarth@webkit.org [Wed, 7 Sep 2011 23:08:18 +0000 (23:08 +0000)]
rebaseline button in garden-o-matic details view should work
https://bugs.webkit.org/show_bug.cgi?id=67738

Reviewed by Dimitri Glazkov.

This patch wires up the rebaseline button in garden-o-matic results
details view.  The button is current per-test, so there isn't a way to
rebaseline individual bots.  This is a place to start.  If we decide we
want per-bot rebaselining, we'll need to think of some better UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader...
abarth@webkit.org [Wed, 7 Sep 2011 22:54:48 +0000 (22:54 +0000)]
FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810

Reviewed by Eric Seidel.

Fix this crash as suggested by Darin Fisher in
https://bugs.webkit.org/show_bug.cgi?id=61810#c21.  This patch does not
include the test requested by Alexey Proskuryakov in
https://bugs.webkit.org/show_bug.cgi?id=61810#c6.  I would really much
rather include a test with this patch, but my attempts to write a test
have failed.  :(

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 22:49:37 +0000 (22:49 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium fast/css/ rebaslines.

        * platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
        * platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Added.
        * platform/chromium-linux/fast/css/getComputedStyle: Removed.
        * platform/chromium-linux/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
        * platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-win/fast/css/line-after-floating-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 22:23:19 +0000 (22:23 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, patch up some chromium gpu expectations
        that are failing on the cg mac builds.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach the PortFactory object how to pass along executive/user/filesystem to port...
eric@webkit.org [Wed, 7 Sep 2011 22:19:14 +0000 (22:19 +0000)]
Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
https://bugs.webkit.org/show_bug.cgi?id=67737

Reviewed by Adam Barth.

I got a little over-eager when deprecating host.port_factory in the previous commit.
Turns out that Host.port_factory was already the "modern" port/factory.py
it was just the Module object.  I un-deprecated the variable, and changed it from
being the module to being an actual PortFactory, passing it a host object.
I also taught PortFactory how to set user/executive/filesystem in the kwargs
when instantiating a new Port object.
This magically fixed the test_rebaseline test, since its now no longer talking
to the real filesystem.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a new PortFactory class for creating new-style ports and deprecate the old PortFa...
eric@webkit.org [Wed, 7 Sep 2011 21:44:49 +0000 (21:44 +0000)]
Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
https://bugs.webkit.org/show_bug.cgi?id=67734

Reviewed by Adam Barth.

Right now every place that creates a Port object has to be very careful
to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
The correct fix is for port/factory.py (which creates most port objects)
to know how to pass these in automatically.  However, currently all port/factory.py
functions are free functions instead of being on an object.  This patch
adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.

In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
pass along the proper scm/user/filesystem to the Port object.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanges to aria-hidden don't change VO navigation
cfleizach@apple.com [Wed, 7 Sep 2011 21:42:02 +0000 (21:42 +0000)]
Changes to aria-hidden don't change VO navigation
https://bugs.webkit.org/show_bug.cgi?id=67722

Reviewed by Darin Adler.

Source/WebCore:

When altering aria-hidden, WebCore needs to update the children caches of
affected elements. However, for elements that were children, but ignored, their
caches did not get updated, and stale information would be propagated.

The fix is to always clearChildren() when a parent is asking for children. This
ensures information is always up to date when the parent itself is asking for new data.

Test: accessibility/aria-hidden-updates-alldescendants.html

* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

* accessibility/aria-hidden-updates-alldescendants-expected.txt: Added.
* accessibility/aria-hidden-updates-alldescendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 21:39:32 +0000 (21:39 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, upstream some chromium expected failure after skia roll,
        and rebaseline 2 tests for leopard cg.

        * platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoText rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has...
timothy_horton@apple.com [Wed, 7 Sep 2011 21:35:03 +0000 (21:35 +0000)]
Text rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has a double shadow
https://bugs.webkit.org/show_bug.cgi?id=67543
<rdar://problem/10070536>

Reviewed by Simon Fraser.

Generalize (begin|end)TransparencyLayer, which now forward
through to (begin|end)PlatformTransparencyLayer, so that
isInTransparencyLayer can exist on every platform.

Make use of isInTransparencyLayer in FontMac to disable
"simple" shadow drawing when the text is being rendered
into a transparency layer.

Test: svg/custom/simple-text-double-shadow.svg

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::isInTransparencyLayer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::isInTransparencyLayer):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/win/ScrollbarThemeWin.cpp:
* plugins/win/PluginViewWin.cpp:
* rendering/RenderThemeWin.cpp:

Add a test ensuring that text with 0px blur CSS shadow doesn't get rendered
with a second shadow when inside a transparency layer.

* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Added.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
* svg/custom/simple-text-double-shadow.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 21:04:47 +0000 (21:04 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.
        Make the WONTFIX WIN LINUX for platform/chromium/rubberbanding/
        FAIL instead of IMAGE, so it's less likely to flake out.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd the forgotten expected results for r94696.
rniwa@webkit.org [Wed, 7 Sep 2011 21:01:11 +0000 (21:01 +0000)]
Add the forgotten expected results for r94696.

* fast/css/line-after-floating-div-expected.png: Added.
* fast/css/line-after-floating-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8881922> Support the hyphenate-limit-lines property
mitz@apple.com [Wed, 7 Sep 2011 20:59:39 +0000 (20:59 +0000)]
<rdar://problem/8881922> Support the hyphenate-limit-lines property
https://bugs.webkit.org/show_bug.cgi?id=67730

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit-lines.html
       fast/text/hyphenate-limit-lines.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added hyphenate-limit-lines.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Ditto. Valid values are non-negative integers and the keyword
"no-limit".
* css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-lines.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Added hyphenate-limit-lines.
* css/CSSValueKeywords.in: Added the "no-limit" value keyword.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats): Count the number of consecutive hyphenated lines
before the start line and pass it to layoutRunsAndFloatsInRange().
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Keep track of the number of consecutive
hyphenated lines before the current line and pass it to LineBreaker::nextLineBreak().
(WebCore::tryHyphenating): Added parameters for the number of consecutive hyphenated lines before
the current line and the limit on consecutive hyphenated lines, and an early return if the limit
has been reached.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Added a parameter for the number of consecutive
hyphenated lines before the current line, which is passed through to tryHyphenating, along with
the value of hyphenate-limit-lines.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::isHyphenated): Added. Returns true if the line was hyphenated.
* rendering/RootInlineBox.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hyphenationLimitLines): Added this getter.
(WebCore::InheritedFlags::setHyphenationLimitLines): Added this setter.
(WebCore::InheritedFlags::initialHyphenationLimitLines): Added. The initial value is -1,
corresponding to "no-limit".
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize new member variable.
(WebCore::StyleRareInheritedData::operator==): Compare new member variable.
* rendering/style/StyleRareInheritedData.h:

LayoutTests:

* fast/css/parsing-hyphenate-limit-lines-expected.txt: Added.
* fast/css/parsing-hyphenate-limit-lines.html: Added.
* fast/text/hyphenate-limit-lines.html: Added.
* platform/mac/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/mac/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r94697.
ossy@webkit.org [Wed, 7 Sep 2011 20:58:49 +0000 (20:58 +0000)]
[Qt] Unreviewed gardening after r94697.

* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 20:56:32 +0000 (20:56 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.

        * platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-win-xp/svg/transforms: Removed.
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94441.
commit-queue@webkit.org [Wed, 7 Sep 2011 20:56:05 +0000 (20:56 +0000)]
Unreviewed, rolling out r94441.
http://trac.webkit.org/changeset/94441
https://bugs.webkit.org/show_bug.cgi?id=67731

"MacEWSes are backed up due to new machines not able to reach
git.webkit.org.  Disabling tests for now" (Requested by
eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosplit overrideSize into overrideHeight and overrideWidth
ojan@chromium.org [Wed, 7 Sep 2011 20:18:14 +0000 (20:18 +0000)]
split overrideSize into overrideHeight and overrideWidth
https://bugs.webkit.org/show_bug.cgi?id=67550

Reviewed by Sam Weinig.

All uses of overrideSize only set one of the width or the height.
This change removes a bool from RenderObject and removes some
flexbox specific logic from RenderBox.

The only downside is that we have two global maps where we used
to have one.

No functional changes so existing tests are sufficient.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::hasOverrideHeight):
(WebCore::RenderBox::hasOverrideWidth):
(WebCore::RenderBox::setOverrideHeight):
(WebCore::RenderBox::setOverrideWidth):
(WebCore::RenderBox::clearOverrideSize):
(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
* rendering/RenderBox.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* rendering/RenderObject.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd test infrastructure to test rubber-banding overhang drawing along with layout...
commit-queue@webkit.org [Wed, 7 Sep 2011 20:13:34 +0000 (20:13 +0000)]
Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
https://bugs.webkit.org/show_bug.cgi?id=67511

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-07
Reviewed by Dimitri Glazkov.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Tests: platform/chromium-mac/rubberbanding/overhang-e.html
       platform/chromium-mac/rubberbanding/overhang-n.html
       platform/chromium-mac/rubberbanding/overhang-ne.html
       platform/chromium-mac/rubberbanding/overhang-nw.html
       platform/chromium-mac/rubberbanding/overhang-s.html
       platform/chromium-mac/rubberbanding/overhang-se.html
       platform/chromium-mac/rubberbanding/overhang-sw.html
       platform/chromium-mac/rubberbanding/overhang-w.html

* WebCore.exp.in:
* platform/ScrollableArea.h:
* testing/Internals.cpp:
(WebCore::Internals::setScrollViewPosition):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* platform/chromium-mac/rubberbanding: Added.
* platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-e.html: Added.
* platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-n.html: Added.
* platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
* platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
* platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-s.html: Added.
* platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-se.html: Added.
* platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
* platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
* platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
* platform/chromium-mac/rubberbanding/overhang-w.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRelease mode build fix.
oliver@apple.com [Wed, 7 Sep 2011 20:06:12 +0000 (20:06 +0000)]
Release mode build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Render surface anti-aliasing.
commit-queue@webkit.org [Wed, 7 Sep 2011 20:00:58 +0000 (20:00 +0000)]
[Chromium] Render surface anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=66437

Patch by David Reveman <reveman@chromium.org> on 2011-09-07
Reviewed by James Robinson.

Source/WebCore:

Add CCLayerQuad class and CCLayerQuad::Edge subclass to allow
edge computations to be shared between tiled layers and render
surfaces. Move isCCW utility function to FloatQuad class and
add to2dTransform method to TransformationMatrix class. Add
necessary anti-aliasing shaders for render surfaces and use them
to avoid aliased edges.

Tests: compositing/reflections/nested-reflection-transformed.html (existing)

* WebCore.gypi:
* platform/graphics/FloatQuad.cpp:
(WebCore::FloatQuad::isCounterclockwise):
* platform/graphics/FloatQuad.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::drawTexturedQuad):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgramAA):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::sharedGeometryQuad):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaAA::FragmentShaderRGBATexAlphaAA):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentTexClampAlphaAABinding::FragmentTexClampAlphaAABinding):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::pointLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::edgeLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskSamplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::edgeLocation):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerQuad.cpp: Added.
(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::floatQuad):
(WebCore::CCLayerQuad::toFloatArray):
* platform/graphics/chromium/cc/CCLayerQuad.h: Added.
(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::Edge::x):
(WebCore::CCLayerQuad::Edge::y):
(WebCore::CCLayerQuad::Edge::z):
(WebCore::CCLayerQuad::Edge::setX):
(WebCore::CCLayerQuad::Edge::setY):
(WebCore::CCLayerQuad::Edge::setZ):
(WebCore::CCLayerQuad::Edge::set):
(WebCore::CCLayerQuad::Edge::moveX):
(WebCore::CCLayerQuad::Edge::moveY):
(WebCore::CCLayerQuad::Edge::moveZ):
(WebCore::CCLayerQuad::Edge::move):
(WebCore::CCLayerQuad::Edge::scaleX):
(WebCore::CCLayerQuad::Edge::scaleY):
(WebCore::CCLayerQuad::Edge::scaleZ):
(WebCore::CCLayerQuad::Edge::scale):
(WebCore::CCLayerQuad::Edge::intersect):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::left):
(WebCore::CCLayerQuad::top):
(WebCore::CCLayerQuad::right):
(WebCore::CCLayerQuad::bottom):
(WebCore::CCLayerQuad::inflateX):
(WebCore::CCLayerQuad::inflateY):
(WebCore::CCLayerQuad::inflate):
(WebCore::CCLayerQuad::inflateAntiAliasingDistance):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::to2dTransform):
* platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

* platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
* platform/chromium-gpu-linux/media/video-transformed-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline after r93935.
xji@chromium.org [Wed, 7 Sep 2011 19:51:24 +0000 (19:51 +0000)]
Rebaseline after r93935.

* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove JSObjectWithGlobalObject
oliver@apple.com [Wed, 7 Sep 2011 19:40:41 +0000 (19:40 +0000)]
Remove JSObjectWithGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=67689

Reviewed by Geoff Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Remove JSObjectWithGlobalObject, and update code to stop using anonymous
storage to access the global object that a JSObject comes from.  Largely
mechanical change to remove the use of anonymous storage and JSObjectWithGlobalObject.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.cpp:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
(JSC::::staticFunctionGetter):
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
* API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
* API/JSWeakObjectMapRefPrivate.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSFunction):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/DatePrototype.cpp:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
* runtime/JSONObject.h:
* runtime/JSObject.h:
(JSC::JSObject::globalObject):
* runtime/JSObjectWithGlobalObject.cpp: Removed.
* runtime/JSObjectWithGlobalObject.h: Removed.
* runtime/JSValue.cpp:
(JSC::JSValue::isValidCallee):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
* runtime/MathObject.h:
* runtime/NumberPrototype.cpp:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
* runtime/RegExpObject.h:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::globalObject):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Remove use of anonymous storage and JSObjectWithGlobalObject for
accessing a JSObject's global object now that they're available
on the object's structure.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
* bridge/runtime_object.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebKit2:

Remove JSObjectWithGlobalObject usage.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTools: filter test_expectations properly for chromium-mac vs chromium-cg-mac
commit-queue@webkit.org [Wed, 7 Sep 2011 19:31:48 +0000 (19:31 +0000)]
Tools: filter test_expectations properly for chromium-mac vs chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:

LayoutTests: now that layout tests distinguish between Core Graphics and Skia
expectations, update test_expectations accordingly.
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix after r94694.
rniwa@webkit.org [Wed, 7 Sep 2011 19:29:30 +0000 (19:29 +0000)]
Mac build fix after r94694.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFELighting is using width instead of height to determine skip for parallel(n>2) case
timothy_horton@apple.com [Wed, 7 Sep 2011 19:27:36 +0000 (19:27 +0000)]
FELighting is using width instead of height to determine skip for parallel(n>2) case
https://bugs.webkit.org/show_bug.cgi?id=67719
<rdar://problem/10086178>

Reviewed by Dirk Schulze.

No new tests, because the bug only exhibits under conditions which are currently
impossible by default (using more than 2 cores) on some platforms.

* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate motion jitter in animated, blurred SVG image
wjmaclean@chromium.org [Wed, 7 Sep 2011 19:20:13 +0000 (19:20 +0000)]
Eliminate motion jitter in animated, blurred SVG image
https://bugs.webkit.org/show_bug.cgi?id=67503

Fixes filter shear-free transform applied to SVG images.

Source/WebCore:

In applyResource() the shearFreeAbsoluteTransform is applied to the drawing region,
which is based on the object bounding box (which doesn't move). For a rotation
around the centre of the box, this should really just be the identity matrix,
since the BB should neither change size nor location. So really, we're just interested
in the scale change of the BB here, and not in moving it.

This impacts how slices are extracted, and affects the {x|y}Mid and {x|y}Max extractions
for vertical and horizontal slices, so the test verifies these.

Reviewed by Dirk Schulze.

Test: svg/W3C-SVG-1.1-SE/filters-image-05-f.svg

* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

Reviewed by Dirk Schulze.

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
* platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-linux/svg/filters/filterRes-expected.png:
* platform/chromium-linux/svg/filters/filterRes-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/filters-image-05-f.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocss2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
rniwa@webkit.org [Wed, 7 Sep 2011 19:14:30 +0000 (19:14 +0000)]
css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by David Hyatt.

Fixed the test to properly attach load event listener on window instead of document.

Since this broken test also caught a bug fixed in r94693, I made a copy of this version in fast/css.

* css2.1/t090204-display-change-01-b-ao.html:
* fast/css/line-after-floating-div.html: Copied from LayoutTests/css2.1/t090204-display-change-01-b-ao.html.
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElements with position:absolute don't move to correct position after images load
robert@webkit.org [Wed, 7 Sep 2011 18:59:55 +0000 (18:59 +0000)]
Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/positioning/absolute-layout-after-image-load.html
      fast/block/positioning/positioned-float-layout-after-image-load.html

In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check. Do the same
for positioned floats in RenderBlock::positionedFloatsNeedRelayout(), although currently layoutPositionedObjects()
takes care of it this at least ensures no regression in future.

Note: Although the issue is encountered only on first load without a fragment identifier, it
happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
because scrolling to the fragment always happens before the image has loaded, rendering the page
and clearing the initial dirty bits in the positioned element's renderer. When the image finally
loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
re-rendered.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when
                                                 deciding whether to mark children for layout
(WebCore::RenderBlock::positionedFloatsNeedRelayout): ditto

LayoutTests:

* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
* fast/block/positioning/absolute-layout-after-image-load.html: Added.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
* fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Added.
* fast/block/positioning/positioned-float-layout-after-image-load.html: Added.
* fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoving platform/track to html/track to avoid layering violation.
commit-queue@webkit.org [Wed, 7 Sep 2011 18:50:35 +0000 (18:50 +0000)]
Moving platform/track to html/track to avoid layering violation.
https://bugs.webkit.org/show_bug.cgi?id=67680

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-07
Reviewed by Adam Barth.

No new tests. No new functionality.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* html/track/CueParser.cpp: Renamed from Source/WebCore/platform/track/CueParser.cpp.
* html/track/CueParser.h: Renamed from Source/WebCore/platform/track/CueParser.h.
* html/track/CueParserPrivate.h: Renamed from Source/WebCore/platform/track/CueParserPrivate.h.
* html/track/WebVTTParser.cpp: Renamed from Source/WebCore/platform/track/WebVTTParser.cpp.
* html/track/WebVTTParser.h: Renamed from Source/WebCore/platform/track/WebVTTParser.h.
* html/track/WebVTTToken.h: Renamed from Source/WebCore/platform/track/WebVTTToken.h.
* html/track/WebVTTTokenizer.cpp: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.cpp.
* html/track/WebVTTTokenizer.h: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=67286
hyatt@apple.com [Wed, 7 Sep 2011 18:48:07 +0000 (18:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67286

REGRESSION: css2.1/t090204-display-change-01-b-ao.html fails after r94084.

Make sure that the trailing floats line box explicitly sets the line top with leading and line bottom with
leading to just be the block height.

Reviewed by Dan Bernstein.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::linkToEndLineIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
abarth@webkit.org [Wed, 7 Sep 2011 18:32:35 +0000 (18:32 +0000)]
[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Patch by Eric Boren <borenet@gmail.com> on 2011-09-07
Reviewed by Darin Fisher.

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
* public/WebTouchPoint.h:
(WebKit::WebTouchPoint::WebTouchPoint):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
* src/WebInputEventConversion.h:

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::sendCurrentTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNull owningRenderer crash in RenderScrollbar::updateScrollbarParts.
inferno@chromium.org [Wed, 7 Sep 2011 18:15:12 +0000 (18:15 +0000)]
Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
https://bugs.webkit.org/show_bug.cgi?id=67669

Reviewed by James Robinson.

Owning renderer can be cleared for custom scrollbars in clearOwningRenderer()
call. We need a null check in updateScrollbarParts, so that we do not crash.

No tests since issue seen in crash reports only and I donot know a way to
reproduce.

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 7 Sep 2011 18:14:50 +0000 (18:14 +0000)]
2011-09-07  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, build fix after r94674.

        * inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor JIT checks for ObjectType into helper functions.
barraclough@apple.com [Wed, 7 Sep 2011 17:55:50 +0000 (17:55 +0000)]
Refactor JIT checks for ObjectType into helper functions.

Rubber stamped by Sam Weinig.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.h:
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip media/media-controls-invalid-url.html on Mac for now because it has been failing.
rniwa@webkit.org [Wed, 7 Sep 2011 17:55:18 +0000 (17:55 +0000)]
Skip media/media-controls-invalid-url.html on Mac for now because it has been failing.
The failure is tracked by the bug 67716.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFinally, Mac rebaseline for r93237.
rniwa@webkit.org [Wed, 7 Sep 2011 17:41:46 +0000 (17:41 +0000)]
Finally, Mac rebaseline for r93237.

* platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Copied from
LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport...
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 17:35:21 +0000 (17:35 +0000)]
[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport is panned to.
https://bugs.webkit.org/show_bug.cgi?id=67606

Source/WebCore:

Reviewed by Noam Rosenthal.

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setKeepAndCoverAreaMultipliers):
(WebCore::TiledBackingStore::setCoverAreaFocusVector):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::calculateKeepRect):
(WebCore::TiledBackingStore::calculateCoverRect):
* platform/graphics/TiledBackingStore.h:
(WebCore::TiledBackingStore::getKeepAndCoverAreaMultipliers):

Source/WebKit/qt:

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):

Source/WebKit2:

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportMotionVectorChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::setVisibleContentRectMotionVector):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/ViewportInteractionEngine.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::setVisibleContentRectMotionVector):
* UIProcess/qt/qtouchwebpageproxy.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setVisibleContentRectMotionVector):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::setVisibleContentRectMotionVector):
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix my accidental svn mv (instead of cp) in r94680.
rniwa@webkit.org [Wed, 7 Sep 2011 17:34:28 +0000 (17:34 +0000)]
Fix my accidental svn mv (instead of cp) in r94680.

* fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from
LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] TiledBackingStore: Import the resizeEdgeTiles logic from TiledDrawindAreaProxy.
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 17:19:36 +0000 (17:19 +0000)]
[Qt] TiledBackingStore: Import the resizeEdgeTiles logic from TiledDrawindAreaProxy.
https://bugs.webkit.org/show_bug.cgi?id=67416

Reviewed by Kenneth Rohde Christiansen.

Original code by Antti Koivisto.
With the current code, when the page is layouted during load, edge tiles will
get removed instead of continuing to show their front buffer while the tile
is being rendered for the new size.

Source/WebCore:

* platform/graphics/Tile.h:
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::resizeEdgeTiles):
* platform/graphics/TiledBackingStore.h:
* platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::resize):
* platform/graphics/qt/TileQt.h:

Source/WebKit2:

* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::resize):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK+ rebaseline after r94357. GTK+ port apparently implements PeerConnection.
rniwa@webkit.org [Wed, 7 Sep 2011 17:17:38 +0000 (17:17 +0000)]
GTK+ rebaseline after r94357. GTK+ port apparently implements PeerConnection.

* fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from
LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTran...
timothy_horton@apple.com [Wed, 7 Sep 2011 17:17:21 +0000 (17:17 +0000)]
Don't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTransform2DRotation
https://bugs.webkit.org/show_bug.cgi?id=67242
<rdar://problem/10069770>

Reviewed by Dirk Schulze.

No new tests, minor performance improvement.

* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::blend):
(WebCore::AffineTransform::decompose):
(WebCore::AffineTransform::recompose):
* platform/graphics/transforms/AffineTransform.h:
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clear2DRotation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiledDrawingArea: Fix issues where the tiles of the previous scale would be removed...
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 17:07:38 +0000 (17:07 +0000)]
TiledDrawingArea: Fix issues where the tiles of the previous scale would be removed too early.
https://bugs.webkit.org/show_bug.cgi?id=67390

Reviewed by Tor Arne Vestbø.

The two issues addresssed are:
- The previous instance of the tile backing store would be destroyed in createTile which
  would send removeTile messages for all its tiles before the DidRenderFrame message is sent for the new tiles.
- When quickly changing the scale a second time after a scale change, the previous tile set would
  be replaced by the current incomplete tile set which may contain no tiles at all.
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::createTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip accessibility/textbox-role-reports-selection.html on GTK+ bots because it has...
rniwa@webkit.org [Wed, 7 Sep 2011 17:05:41 +0000 (17:05 +0000)]
Skip accessibility/textbox-role-reports-selection.html on GTK+ bots because it has been failing.
The failure is tracked by the bug 67713.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResou...
ossy@webkit.org [Wed, 7 Sep 2011 17:04:22 +0000 (17:04 +0000)]
[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-07
Reviewed by Csaba Osztrogonác.

Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::pathToLocalResource):
(LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] The scene graph is rendered continuously even when the page is idle.
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 16:43:19 +0000 (16:43 +0000)]
[Qt][WK2] The scene graph is rendered continuously even when the page is idle.
https://bugs.webkit.org/show_bug.cgi?id=67195

Reviewed by Tor Arne Vestbø.

Since tiledBackingStorePaintEnd is called even when no tile is dirty, the TiledDrawingArea
and its proxy are looping over DidRenderFrame and RenderNextFrame messages.
This causes QSGItem::update() to be called and consumes a lot of useless CPU cycles on the UI process.

Introduce a bool to send DidRenderFrame only when dirty content was rendered.

* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
podivilov@chromium.org [Wed, 7 Sep 2011 16:42:00 +0000 (16:42 +0000)]
Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647

1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
2) Add RawSourceCode unit tests.
3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/raw-source-code.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt: Added.
* inspector/debugger/raw-source-code.html: Added.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Make sure that the visible content rect and the content scale get to the...
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 16:40:36 +0000 (16:40 +0000)]
[Qt][WK2] Make sure that the visible content rect and the content scale get to the web process in one single message.
https://bugs.webkit.org/show_bug.cgi?id=67189

Reviewed by Kenneth Rohde Christiansen.

The TiledBackingStore needs to know the screen size of the viewport to know how many tiles to
create, and since the visible content rect is given in page coordinates, the contents scale is
necessary to calculate the viewport size.
Both the rect and the scale then need to arrive to the web process at the same time to prevent
picking the new visible rect with the old scale or vice-versa which can produce a huge viewport size
and create/render an insane amount of tiles.

Things this patch does:
- Merge the visible contents rect and content scale handling together.
- Make QTouchWebView responsible for telling those viewport values to the web process instead of QTouchWebPage.
- Prevent updating the viewport in ViewportInteractionEngine while a pinch is in progress and update the viewport at the end.

* UIProcess/API/qt/qtouchwebpage.cpp:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebView::geometryChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::setVisibleContentRectAndScale):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::~ViewportInteractionEngine): Allows OwnPtr with the forward declaration of ViewportUpdateGuard.
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentViewportChanged):
* UIProcess/qt/ViewportInteractionEngine.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::setVisibleContentRectAndScale):
* UIProcess/qt/qtouchwebpageproxy.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setVisibleContentRectAndScale):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Rename SGAgent to SGUpdateQueue to sharpen it's responsability.
jocelyn.turcotte@nokia.com [Wed, 7 Sep 2011 15:54:33 +0000 (15:54 +0000)]
[Qt][WK2] Rename SGAgent to SGUpdateQueue to sharpen it's responsability.
https://bugs.webkit.org/show_bug.cgi?id=67122

Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::updatePaintNode):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/qt/SGUpdateQueue.cpp: Renamed from Source/WebKit2/UIProcess/qt/SGAgent.cpp.
(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::SGUpdateQueue::SGUpdateQueue):
(WebKit::SGUpdateQueue::createTileNode):
(WebKit::SGUpdateQueue::removeTileNode):
(WebKit::SGUpdateQueue::setNodeBackBuffer):
(WebKit::SGUpdateQueue::swapTileBuffers):
(WebKit::SGUpdateQueue::applyUpdates):
(WebKit::SGUpdateQueue::getScaleNode):
* UIProcess/qt/SGUpdateQueue.h: Renamed from Source/WebKit2/UIProcess/qt/SGAgent.h.
(WebKit::SGUpdateQueue::isSwapPending):
(WebKit::NodeUpdate::NodeUpdate):
(WebKit::NodeUpdate::~NodeUpdate):
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
(WebKit::TiledDrawingAreaProxy::updateWebView):
(WebKit::TiledDrawingAreaProxy::createTile):
(WebKit::TiledDrawingAreaProxy::updateTile):
(WebKit::TiledDrawingAreaProxy::didRenderFrame):
(WebKit::TiledDrawingAreaProxy::removeTile):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::sceneGraphUpdateQueue):
* UIProcess/qt/TouchViewInterface.h:
* WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Implement circular tabbing through the Styles sidebar pane contents
apavlov@chromium.org [Wed, 7 Sep 2011 15:15:44 +0000 (15:15 +0000)]
Web Inspector: Implement circular tabbing through the Styles sidebar pane contents
https://bugs.webkit.org/show_bug.cgi?id=67127

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/Section.js:
(WebInspector.Section.prototype.get firstSibling):
(WebInspector.Section.prototype.get lastSibling):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.nextEditableSibling):
(WebInspector.StylePropertiesSection.prototype.previousEditableSibling):
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertiesSection.prototype._moveEditorFromSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):

LayoutTests:

* inspector/styles/styles-commit-editing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 7 Sep 2011 15:09:44 +0000 (15:09 +0000)]
2011-09-07  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed test fix (removed a call to console.trace() to avoid having platform-specific expectations).

        * inspector/extensions/extensions-console-expected.txt:
        * inspector/extensions/extensions-console.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; new baselines (Skia on Mac, next chunk of files)
caryclark@google.com [Wed, 7 Sep 2011 14:12:16 +0000 (14:12 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

* platform/chromium-mac/media/media/video-defaultmuted-expected.txt: Removed.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed suppression of an unnecessary debug output.
alexis.menard@openbossa.org [Wed, 7 Sep 2011 13:33:30 +0000 (13:33 +0000)]
[Qt] Unreviewed suppression of an unnecessary debug output.

* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r94288) build-webkit doesn't work on Symbian
ossy@webkit.org [Wed, 7 Sep 2011 13:30:35 +0000 (13:30 +0000)]
REGRESSION(r94288) build-webkit doesn't work on Symbian
https://bugs.webkit.org/show_bug.cgi?id=67706

* Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-02 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 7 Sep 2011 13:12:23 +0000 (13:12 +0000)]
2011-09-02  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] expose console API
        https://bugs.webkit.org/show_bug.cgi?id=67506

        Reviewed by Pavel Feldman.

        Test: inspector/extensions/extensions-console.html

        * inspector/front-end/ConsoleMessage.js:
        (WebInspector.ConsoleMessage.prototype.get text):
        (WebInspector.ConsoleMessage.prototype.get parameters):
        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.Console.prototype.getMessages):
        (WebInspector.injectedExtensionAPI.Console.prototype.addMessage):
        (WebInspector.injectedExtensionAPI.Console.prototype.get MessageLevel):
        (WebInspector.injectedExtensionAPI.Network.dispatchRequestEvent):
        (WebInspector.injectedExtensionAPI.Network):
        (WebInspector.injectedExtensionAPI.AuditCategoryImpl.dispatchAuditEvent):
        (WebInspector.injectedExtensionAPI.AuditCategoryImpl):
        (WebInspector.injectedExtensionAPI.InspectedWindow.dispatchResourceEvent):
        (WebInspector.injectedExtensionAPI.InspectedWindow.dispatchResourceContentEvent):
        (WebInspector.injectedExtensionAPI.InspectedWindow):
        * inspector/front-end/ExtensionCommon.js:
        (WebInspector.commonExtensionSymbols):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._notifyConsoleMessageAdded):
        (WebInspector.ExtensionServer.prototype._onGetConsoleMessages):
        (WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
        (WebInspector.ExtensionServer.prototype._makeConsoleMessage):
        (WebInspector.ExtensionServer.prototype._makeConsoleMessage.convertParameter):
        (WebInspector.ExtensionServer.prototype._dispatchCallback):
        (WebInspector.ExtensionServer.prototype.initExtensions):

2011-09-02  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] expose console API
        https://bugs.webkit.org/show_bug.cgi?id=67506

        Reviewed by Pavel Feldman.

        * http/tests/inspector/resources/extension-main.js:
        * inspector/extensions/extensions-api-expected.txt:
        * inspector/extensions/extensions-console-expected.txt: Added.
        * inspector/extensions/extensions-console.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-05 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 7 Sep 2011 12:31:11 +0000 (12:31 +0000)]
2011-09-05  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: disable popover when a mouse button is pressed
        https://bugs.webkit.org/show_bug.cgi?id=67610

        Reviewed by Pavel Feldman.

        - disable popover when a mouse button is pressed
        - disable popover in a SourceFrame when the source is being edited

        * inspector/front-end/Popover.js:
        (WebInspector.PopoverHelper):
        (WebInspector.PopoverHelper.prototype._mouseUp):
        (WebInspector.PopoverHelper.prototype._mouseDown):
        (WebInspector.PopoverHelper.prototype._handleMouseAction):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._onHidePopover):
        (WebInspector.SourceFrame.prototype.doubleClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate LayoutTests/platform/qt-arm/fast/dom/Window/window-property-descriptors-expect...
kbalazs@webkit.org [Wed, 7 Sep 2011 12:31:02 +0000 (12:31 +0000)]
Update LayoutTests/platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-07

* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r94288) build-webkit doesn't work on Windows
ossy@webkit.org [Wed, 7 Sep 2011 12:26:33 +0000 (12:26 +0000)]
REGRESSION(r94288) build-webkit doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=67646

Roll back r94655 with a small fix.

* Scripts/webkitdirs.pm:
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] evetSender.keyDown is unimplemented
kbalazs@webkit.org [Wed, 7 Sep 2011 11:10:48 +0000 (11:10 +0000)]
[WK2] evetSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening, skip dependent new test.

* platform/wk2/Skipped: Skip fast/forms/number-input-changeevent.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94635.
loislo@chromium.org [Wed, 7 Sep 2011 10:36:57 +0000 (10:36 +0000)]
Unreviewed, rolling out r94635.
http://trac.webkit.org/changeset/94635
https://bugs.webkit.org/show_bug.cgi?id=67704

Linux Touch build is failing to compile this change.
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
* public/WebTouchPoint.h:
(WebKit::WebTouchPoint::WebTouchPoint):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
* src/WebInputEventConversion.h:

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::sendCurrentTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94655.
ossy@webkit.org [Wed, 7 Sep 2011 10:28:47 +0000 (10:28 +0000)]
Unreviewed, rolling out r94655.
http://trac.webkit.org/changeset/94655
https://bugs.webkit.org/show_bug.cgi?id=67703

It broke Leopard debug bot (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=67634
antti@apple.com [Wed, 7 Sep 2011 10:16:26 +0000 (10:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67634
De-virtualize styleForRenderer()

Reviewed by Sam Weinig.

This has performance and code clarity benefits.

- move styleForRenderer from Node to Element
- get rid of the now unnecessary NodeRenderingContext parameter
- de-virtualize, add virtual customStyleForRenderer()

* dom/Element.cpp:
(WebCore::Element::customStyleForRenderer):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
* dom/Element.h:
* dom/Node.cpp:
* dom/Node.h:
(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):
(WebCore::Node::hasCustomStyleForRenderer):
(WebCore::Node::setHasCustomStyleForRenderer):

    Move styleForRenderer, add customStyleForRenderer, add a bit.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererAndStyle):

    Handle non-element case separately since styleForRenderer was moved from Node to Element.

* html/HTMLNoScriptElement.cpp:
(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::customStyleForRenderer):
* html/HTMLNoScriptElement.h:

    Move a strange XHTMLMP special case to where it belongs.

* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::attach):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::attach):
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::textWithDirection):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
* html/shadow/TextControlInnerElements.h:
* rendering/svg/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeContainerElement::customStyleForRenderer):
* rendering/svg/SVGShadowTreeElements.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::customStyleForRenderer):
* svg/SVGElement.h:

    Adopt customStyleForRenderer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange event is not fired for input[type=number] when the user reverts a change made...
rniwa@webkit.org [Wed, 7 Sep 2011 10:07:10 +0000 (10:07 +0000)]
Change event is not fired for input[type=number] when the user reverts a change made by script
https://bugs.webkit.org/show_bug.cgi?id=67697

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue not calling setTextAsOfLastFormControlChangeEvent
for text fields other than type=text.

Also fixed a that stepUpFromRenderer does not call setTextAsOfLastFormControlChangeEvent at appropriate
timing due to setValueAsNumber always passing sendChangeEvent=false to setValue by propagating values
through setValueAsNumber and applyStep. This refactoring allows us to remove calls to dispatch* in
stepUpFromRenderer because they're now called in setValueAsNumber or applyStep.

Test: fast/forms/number-input-changeevent.html

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::setValueAsNumber):
* html/BaseDateAndTimeInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::setValueAsNumber):
* html/InputType.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::setValueAsNumber):
* html/NumberInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):
* html/RangeInputType.h:

LayoutTests:

Add a regression test to ensure WebKit fires change event when the user reverts a change made by script.

* fast/forms/number-input-changeevent-expected.txt: Added.
* fast/forms/number-input-changeevent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Qt build by moving the Qt specific include (which is not really allowed...
antti@apple.com [Wed, 7 Sep 2011 09:52:28 +0000 (09:52 +0000)]
Try to fix Qt build by moving the Qt specific include (which is not really allowed here!).

Not reviewed.

* css/CSSStyleSelector.cpp:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::determineLinkStateSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove SelectorChecker out from CSSStyleSelector scope
antti@apple.com [Wed, 7 Sep 2011 09:36:22 +0000 (09:36 +0000)]
Move SelectorChecker out from CSSStyleSelector scope
https://bugs.webkit.org/show_bug.cgi?id=67648

Reviewed by Sam Weinig.

- Move SelectorChecker to SelectorChecker.h/cpp
- Make private functions private
- Make members private, add accessors
- Move m_sameOriginOnly to CSSStyleSelector as it is not used by SelectorChecker

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::style):
(WebCore::CSSStyleSelector::parentStyle):
(WebCore::CSSStyleSelector::rootElementStyle):
(WebCore::CSSStyleSelector::element):
(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):
(WebCore::CSSStyleSelector::setZoom):
(WebCore::CSSStyleSelector::setEffectiveZoom):
(WebCore::CSSStyleSelector::setTextSizeAdjust):
(WebCore::CSSStyleSelector::setStyle):
(WebCore::CSSStyleSelector::fontSelector):
(WebCore::CSSStyleSelector::allVisitedStateChanged):
(WebCore::CSSStyleSelector::visitedStateChanged):
(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::isRightPage):
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
(WebCore::CSSStyleSelector::styleNotYetAvailable):
* css/SelectorChecker.cpp: Added.
(WebCore::SelectorChecker::SelectorChecker):
(WebCore::linkAttribute):
(WebCore::SelectorChecker::determineLinkStateSlowCase):
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::addLocalNameToSet):
(WebCore::createHtmlCaseInsensitiveAttributesSet):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::attributeQualifiedNameMatches):
(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::allVisitedStateChanged):
(WebCore::SelectorChecker::visitedStateChanged):
* css/SelectorChecker.h: Added.
(WebCore::SelectorChecker::document):
(WebCore::SelectorChecker::strictParsing):
(WebCore::SelectorChecker::isCollectingRulesOnly):
(WebCore::SelectorChecker::setCollectingRulesOnly):
(WebCore::SelectorChecker::isMatchingVisitedPseudoClass):
(WebCore::SelectorChecker::setMatchingVisitedPseudoClass):
(WebCore::SelectorChecker::pseudoStyle):
(WebCore::SelectorChecker::setPseudoStyle):
(WebCore::SelectorChecker::hasUnknownPseudoElements):
(WebCore::SelectorChecker::clearHasUnknownPseudoElements):
(WebCore::SelectorChecker::determineLinkState):
* dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector):
* dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::SelectorQuery):
* dom/SelectorQuery.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r94288) build-webkit doesn't work on Windows
ossy@webkit.org [Wed, 7 Sep 2011 09:28:31 +0000 (09:28 +0000)]
REGRESSION(r94288) build-webkit doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=67646

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-07
Reviewed by Csaba Osztrogonác.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening after r94646.
ossy@webkit.org [Wed, 7 Sep 2011 09:24:28 +0000 (09:24 +0000)]
[Qt][Mac] Unreviewed gardening after r94646.

* platform/qt-mac/Skipped: Paint the Qt-Mac bot green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 7 Sep 2011 09:23:13 +0000 (09:23 +0000)]
2011-09-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Revert expectation that was wrongly generated for textStyles.svg.

        * platform/chromium-linux/svg/batik/text/textStyles-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Windows rebaselines.
rniwa@webkit.org [Wed, 7 Sep 2011 09:21:49 +0000 (09:21 +0000)]
Unreviewed Windows rebaselines.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOne last GTK+ rebaseline for r94614.
rniwa@webkit.org [Wed, 7 Sep 2011 09:17:49 +0000 (09:17 +0000)]
One last GTK+ rebaseline for r94614.

* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK+ rebaselines after r94614.
rniwa@webkit.org [Wed, 7 Sep 2011 09:11:12 +0000 (09:11 +0000)]
GTK+ rebaselines after r94614.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 7 Sep 2011 09:06:40 +0000 (09:06 +0000)]
2011-09-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Rebaseline expectations after r94593

        * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
        * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
        * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/dom/replaceChild.html may not test what it's supposed to test and may sometimes...
commit-queue@webkit.org [Wed, 7 Sep 2011 07:55:30 +0000 (07:55 +0000)]
fast/dom/replaceChild.html may not test what it's supposed to test and may sometimes be flaky
https://bugs.webkit.org/show_bug.cgi?id=67629

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-07
Reviewed by Darin Adler.

The test is supposed to test Node.replaceChild() called from a frame.
However, in most cases, it's not executed because the test finishes before
the iframe's onload event handler. For now, the expected result is just
the original render tree before replaceChild(). In chance that iframe's
onload is executed earlier, the actual result might be different from
expected (that is, replaceChild() is executed and the DOM is actually changed.)

Use waitUntilDone() and notifyDone() to ensure the frame's onload handler
is called.

BTW changed it to a pure text test to avoid platform branches.

* fast/dom/replaceChild.html:
* fast/dom/replaceChild-expected.txt: Added.
* fast/dom/resources/replaceChildHelper.html:
* platform/chromium-linux/fast/dom/replaceChild-expected.png: Removed.
* platform/chromium-mac/fast/dom/replaceChild-expected.png: Removed.
* platform/chromium-win/fast/dom/replaceChild-expected.png: Removed.
* platform/chromium-win/fast/dom/replaceChild-expected.txt: Removed.
* platform/gtk/fast/dom/replaceChild-expected.png: Removed.
* platform/gtk/fast/dom/replaceChild-expected.txt: Removed.
* platform/mac-leopard/fast/dom/replaceChild-expected.png: Removed.
* platform/mac/fast/dom/replaceChild-expected.png: Removed.
* platform/mac/fast/dom/replaceChild-expected.txt: Removed.
* platform/qt/fast/dom/replaceChild-expected.png: Removed.
* platform/qt/fast/dom/replaceChild-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=67413
dslomov@google.com [Wed, 7 Sep 2011 07:50:23 +0000 (07:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67413
[Chromium]Web Inspector: inspected page with dedicated worker crashes on refresh.
This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController.

Reviewed by Yury Semikhatsky.

* workers/WorkerContext.cpp:
(WebCore::WorkerContext::clearInspector):
* workers/WorkerContext.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Add platform specific expected results for new passing...
ossy@webkit.org [Wed, 7 Sep 2011 07:45:04 +0000 (07:45 +0000)]
[Qt] Unreviewed gardening. Add platform specific expected results for new passing tests.

* platform/qt/fast/borders/border-image-longhand-expected.png: Added.
* platform/qt/fast/borders/border-image-longhand-expected.txt: Added.
* platform/qt/fast/borders/border-image-scaled-expected.png: Added.
* platform/qt/fast/borders/border-image-scaled-expected.txt: Added.
* platform/qt/fast/borders/border-image-side-reduction-expected.png: Added.
* platform/qt/fast/borders/border-image-side-reduction-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 7 Sep 2011 07:12:57 +0000 (07:12 +0000)]
2011-09-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Rebaseline expectations for svg/batik/text/textStyles.svg after r94624.

        * platform/chromium-linux/svg/batik/text/textStyles-expected.png:
        * platform/chromium-win/svg/batik/text/textStyles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r94627 and r94632.
ossy@webkit.org [Wed, 7 Sep 2011 07:01:29 +0000 (07:01 +0000)]
Unreviewed, rolling out r94627 and r94632.
http://trac.webkit.org/changeset/94627
http://trac.webkit.org/changeset/94632
https://bugs.webkit.org/show_bug.cgi?id=67698

It broke tests on GTK and Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/JavaScriptCore:

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::create):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
* API/JSCallbackFunction.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::create):
* debugger/DebuggerActivation.h:
* jsc.cpp:
(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::create):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
(JSC::BooleanObject::create):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
(JSC::DateInstance::create):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
(JSC::JSONObject::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSString.cpp:
(JSC::StringObject::create):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
(JSC::NumberObject::create):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::create):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
(JSC::StringObject::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:

Source/JavaScriptGlue:

* JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::create):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::JSTestInterface):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::JSTestObj):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
* bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
* bridge/c/CRuntimeObject.h:
* bridge/jni/jsc/JavaRuntimeObject.cpp:
(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
* bridge/jni/jsc/JavaRuntimeObject.h:
* bridge/objc/ObjCRuntimeObject.h:
* bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::create):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
* bridge/runtime_array.h:
(JSC::RuntimeArray::create):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
* bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::create):

Source/WebKit/mac:

* Plugins/Hosted/ProxyRuntimeObject.h:
* Plugins/Hosted/ProxyRuntimeObject.mm:
(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/workers/worker-script-error.html fails on Chromium after r94061
yurys@chromium.org [Wed, 7 Sep 2011 06:53:14 +0000 (06:53 +0000)]
fast/workers/worker-script-error.html fails on Chromium after r94061
https://bugs.webkit.org/show_bug.cgi?id=67206

Source/WebCore:

Default action should be prevented if window.onerror returned true and stay
not prevented otherwise.

Reviewed by Dmitry Titov.

Tests: fast/events/window-onerror14.html
       fast/events/window-onerror15.html
       fast/events/window-onerror16.html

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
(WebCore::V8AbstractEventListener::shouldPreventDefault): allow specific
event listeners to decide when to prevent default action based on the handler
return value.
* bindings/v8/V8AbstractEventListener.h:
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
(WebCore::V8WindowErrorHandler::shouldPreventDefault):
* bindings/v8/V8WindowErrorHandler.h:
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
(WebCore::V8WorkerContextErrorHandler::shouldPreventDefault):
* bindings/v8/V8WorkerContextErrorHandler.h:

LayoutTests:

Add a couple more tests for window.onerror handler that check whether
error message is printed to the console pending on the handler return
value.

Reviewed by Dmitry Titov.

* fast/events/window-onerror14-expected.txt: Added.
* fast/events/window-onerror14.html: Added.
* fast/events/window-onerror15-expected.txt: Added.
* fast/events/window-onerror15.html: Added.
* fast/events/window-onerror16-expected.txt: Added.
* fast/events/window-onerror16.html: Added.
* platform/chromium/fast/events/window-onerror16-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94643 268f45cc-cd09-0410-ab3c-d52691b4dbfc