WebKit-https.git
7 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78256
hyatt@apple.com [Thu, 9 Feb 2012 21:59:07 +0000 (21:59 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78256

Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.

Reviewed by Dan Bernstein.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineSnap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSnapAdjustment):
* rendering/RootInlineBox.h:
(RootInlineBox):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78256

Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.

Reviewed by Dan Bernstein.

* fast/line-grid/line-grid-contains-value.html:
* fast/line-grid/line-grid-floating.html:
* fast/line-grid/line-grid-inside-columns.html:
* fast/line-grid/line-grid-into-columns.html:
* fast/line-grid/line-grid-into-floats.html:
* fast/line-grid/line-grid-nested.html:
* fast/line-grid/line-grid-positioned.html:
* fast/line-grid/line-grid-snap-parsing.html: Removed.
* fast/line-grid/line-snap-parsing-expected.txt: Added.
* fast/line-grid/line-snap-parsing.html: Added.
* fast/line-grid/script-tests/line-grid-snap-parsing.js: Removed.
* fast/line-grid/script-tests/line-snap-parsing.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe localization of htmlSelectMultipleItems() needs better support of pluralization
benjamin@webkit.org [Thu, 9 Feb 2012 21:47:58 +0000 (21:47 +0000)]
The localization of htmlSelectMultipleItems() needs better support of pluralization
https://bugs.webkit.org/show_bug.cgi?id=78197

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-09
Reviewed by Joseph Pecoraro.

For translation, the localization of 0 and 1 depends on the language.

* English.lproj/Localizable.strings:
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Plumb setNeedsRedraw.
commit-queue@webkit.org [Thu, 9 Feb 2012 21:40:03 +0000 (21:40 +0000)]
[chromium] Plumb setNeedsRedraw.
https://bugs.webkit.org/show_bug.cgi?id=78248

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.

* public/platform/WebLayerTreeView.h:
(WebLayerTreeView):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove extraneous line in previous patch. I forgot to remove this
abarth@webkit.org [Thu, 9 Feb 2012 21:37:09 +0000 (21:37 +0000)]
Remove extraneous line in previous patch.  I forgot to remove this
before landing.

* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrollingTreeNodeMac should implement ScrollElasticityController
andersca@apple.com [Thu, 9 Feb 2012 21:31:33 +0000 (21:31 +0000)]
ScrollingTreeNodeMac should implement ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=78277

Reviewed by Andreas Kling.

Add stubbed out implementations of the ScrollElasticityController member functions.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests should have an option to pause before running tests so we can attach...
abarth@webkit.org [Thu, 9 Feb 2012 21:26:34 +0000 (21:26 +0000)]
run-perf-tests should have an option to pause before running tests so we can attach Instruments
https://bugs.webkit.org/show_bug.cgi?id=78271

Reviewed by Ryosuke Niwa.

This lets me attach instruments to profile the performance of the test.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.start):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.start):
(DriverProxy.start):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.start):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.start):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.start):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_tests_run.RecordingTestDriver.start):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._run_tests_set):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(start):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Correct potential double reserveTextures() in CCLayerTreeHost
enne@google.com [Thu, 9 Feb 2012 21:20:49 +0000 (21:20 +0000)]
[chromium] Correct potential double reserveTextures() in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78258

Reviewed by James Robinson.

This isn't a problem currently, because scrollbar layers don't create
render surfaces. However, if this ever got used for other layers, we
could call reserve on them twice needlessly. It's also just bad form
to have an iterator doing the wrong thing.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::reserveTextures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline, yet another small font difference.
jchaffraix@webkit.org [Thu, 9 Feb 2012 21:07:29 +0000 (21:07 +0000)]
Unreviewed rebaseline, yet another small font difference.

* platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Added.
* platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Allow reading some debug-only preference files
ap@apple.com [Thu, 9 Feb 2012 21:02:23 +0000 (21:02 +0000)]
[WK2] Allow reading some debug-only preference files
https://bugs.webkit.org/show_bug.cgi?id=78255
<rdar://problem/9382382>
<rdar://problem/10830558>

Reviewed by Dan Bernstein.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r107261.
jchaffraix@webkit.org [Thu, 9 Feb 2012 21:01:44 +0000 (21:01 +0000)]
Unreviewed, rolling out r107261.
http://trac.webkit.org/changeset/107261
https://bugs.webkit.org/show_bug.cgi?id=78274

It has regressed svg/W3C-SVG-1.1/styling-css-05-b.svg (using
lang() selectors) (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-09

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
jsbell@chromium.org [Thu, 9 Feb 2012 20:49:34 +0000 (20:49 +0000)]
[Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=78167

Source/WebCore:

Add ActiveDOMObject annotation to IDBVersionChangeRequest.idl; it is not
automagically inherited from IDBRequest.idl.

Reviewed by Adam Barth.

Test: storage/indexeddb/versionchangerequest-activedomobject.html

* storage/IDBVersionChangeRequest.idl:

LayoutTests:

Reviewed by Adam Barth.

* storage/indexeddb/versionchangerequest-activedomobject-expected.txt: Added.
* storage/indexeddb/versionchangerequest-activedomobject.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe scrolling tree should know more about the scrollbar state
andersca@apple.com [Thu, 9 Feb 2012 20:44:05 +0000 (20:44 +0000)]
The scrolling tree should know more about the scrollbar state
https://bugs.webkit.org/show_bug.cgi?id=78268

Reviewed by Andreas Kling.

With this change, the scroll tree now keeps track of the horizontal scroll elasticity,
the vertical scroll elasticity and whether the page has enabled scrollbars.

This is needed in order to make rubber-banding work correctly when doing fast scrolling.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):
* page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setHorizontalScrollElasticity):
(WebCore):
(WebCore::ScrollingTreeState::setVerticalScrollElasticity):
(WebCore::ScrollingTreeState::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeState::setHasEnabledVerticalScrollbar):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::horizontalScrollElasticity):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::verticalScrollElasticity):
(WebCore::ScrollingTreeState::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeState::hasEnabledVerticalScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests --chromium should run the chromium port
abarth@webkit.org [Thu, 9 Feb 2012 20:21:24 +0000 (20:21 +0000)]
run-perf-tests --chromium should run the chromium port
https://bugs.webkit.org/show_bug.cgi?id=78266

Reviewed by Ryosuke Niwa.

This patch makes run-perf-tests work more like run-webkit-tests.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerf-o-matic should update memcache in taskqueue
rniwa@webkit.org [Thu, 9 Feb 2012 20:20:41 +0000 (20:20 +0000)]
Perf-o-matic should update memcache in taskqueue
https://bugs.webkit.org/show_bug.cgi?id=78209

Reviewed by Adam Barth.

Update dashboard, manifest, and runs memcaches in taskqueue.
Also centralized the management of caches in controller.py.

* Websites/webkit-perf.appspot.com/app.yaml:
* Websites/webkit-perf.appspot.com/controller.py: Added.
(cache_manifest):
(schedule_manifest_update):
(CachedManifestHandler):
(CachedManifestHandler.get):
(cache_dashboard):
(schedule_dashboard_update):
(CachedDashboardHandler):
(CachedDashboardHandler.get):
(cache_runs):
(schedule_runs_update):
(CachedRunsHandler):
(CachedRunsHandler.get):
* Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler.post):
* Websites/webkit-perf.appspot.com/dashboard_handler.py:
(DashboardHandler.post):
* Websites/webkit-perf.appspot.com/main.py:
* Websites/webkit-perf.appspot.com/manifest_handler.py:
(ManifestHandler.post):
* Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.post):
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
commit-queue@webkit.org [Thu, 9 Feb 2012 20:18:48 +0000 (20:18 +0000)]
[Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
https://bugs.webkit.org/show_bug.cgi?id=77466

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-09
Reviewed by Dirk Pranke.

Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
is set or if we should raise an error. A unit test was added.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.operating_system):
(QtPort):
(QtPort.check_sys_deps):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_operating_system):
(QtPortTest):
(QtPortTest.test_check_sys_deps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
eric@webkit.org [Thu, 9 Feb 2012 20:11:06 +0000 (20:11 +0000)]
Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
https://bugs.webkit.org/show_bug.cgi?id=78263

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort):
(DeprecatedPort.name):
(DeprecatedPort.flag):
(DeprecatedPort.script_path):
(DeprecatedPort.script_shell_command):
(DeprecatedPort.port):
(DeprecatedPort.makeArgs):
(DeprecatedPort.update_webkit_command):
(DeprecatedPort.check_webkit_style_command):
(DeprecatedPort.prepare_changelog_command):
(DeprecatedPort.build_webkit_command):
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort.run_webkit_unit_tests_command):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_perl_unittests_command):
(DeprecatedPort.layout_tests_results_path):
(MacPort):
(WinPort):
(GtkPort):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(QtPort):
(QtPort.build_webkit_command):
(EflPort):
(EflPort.build_webkit_command):
(ChromiumPort):
(ChromiumPort.update_webkit_command):
(ChromiumPort.build_webkit_command):
(ChromiumPort.run_webkit_tests_command):
(ChromiumPort.run_javascriptcore_tests_command):
(ChromiumXVFBPort):
(ChromiumXVFBPort.run_webkit_tests_command):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest):
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_chromium_port):
(DeprecatedPortTest.test_chromium_xvfb_port):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.__init__):
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/main.py:
(WebKitPatch):
(WebKitPatch.handle_global_options):
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnnecessary and incorrect invalidation about composited fixed-position layers
wangxianzhu@chromium.org [Thu, 9 Feb 2012 20:04:02 +0000 (20:04 +0000)]
Unnecessary and incorrect invalidation about composited fixed-position layers
https://bugs.webkit.org/show_bug.cgi?id=75638

When a FrameView scrolls, composited fixed-position layers should
not contribute to the invalidation rect of the root layer.

Reviewed by Simon Fraser.

No new tests. Haven't found a good way to test this programatically.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Thu, 9 Feb 2012 19:44:31 +0000 (19:44 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Mark fast/workers/storage/interrupt-database.html as slow to see if it helps with the flakiness.
Mark a new animation test as flaky (already know issue in the animation testing framework).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHiDPI: WebKit2's link-dragging images are blurry
mdelaney@apple.com [Thu, 9 Feb 2012 19:35:18 +0000 (19:35 +0000)]
HiDPI: WebKit2's link-dragging images are blurry
https://bugs.webkit.org/show_bug.cgi?id=67779

Reviewed by Beth Dakin.

Teach startDrag about the deviceScaleFactor so that it creates
an appropriately scaled bitmap image to ship over.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
(WebKit::convertImageToBitmap):

Have setDragImage assume that it's receiving a bitmap image scaled
up by the deviceScaleFactor that it sees.
* UIProcess/API/mac/WKView.mm:
(-[WKView _setDragImage:at:linkDrag:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r107035.
commit-queue@webkit.org [Thu, 9 Feb 2012 19:16:03 +0000 (19:16 +0000)]
Unreviewed, rolling out r107035.
http://trac.webkit.org/changeset/107035
https://bugs.webkit.org/show_bug.cgi?id=78253

Regressed DOMDivWalk (Requested by arv on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-09

Source/WebCore:

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother unreviewed svg rebaselining after r107207.
jchaffraix@webkit.org [Thu, 9 Feb 2012 19:12:07 +0000 (19:12 +0000)]
Another unreviewed svg rebaselining after r107207.

* platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Removed.
* platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-late-clipPath-creation-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-content-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-inner-svg-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-use-on-symbol-expected.png:
* platform/chromium-mac-leopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
* platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/chromium-mac-leopard/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-disappears-after-style-update-expected.png: Removed.
* platform/chromium-mac-leopard/svg/custom/use-elementInstance-methods-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-event-handler-on-use-element-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMathML internals for bug 52444 fix - type checking, PassRefPtr
commit-queue@webkit.org [Thu, 9 Feb 2012 19:11:57 +0000 (19:11 +0000)]
MathML internals for bug 52444 fix - type checking, PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=78180

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-09
Reviewed by Eric Seidel.

static_cast<Element*>(node()) is done in methods in RenderMathMLFenced.cpp and a few
other files. It is more type-safe if the RenderMathMLFenced() or other constructor only
accepts an Element*, not a Node*. Also a couple functions were changed to return a
PassRefPtr instead of a RefPtr.

No new tests.

* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::makeOperatorStyle):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
* rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::RenderMathMLFraction):
* rendering/mathml/RenderMathMLFraction.h:
(RenderMathMLFraction):
* rendering/mathml/RenderMathMLMath.cpp:
(WebCore::RenderMathMLMath::RenderMathMLMath):
* rendering/mathml/RenderMathMLMath.h:
(RenderMathMLMath):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createStackableStyle):
(WebCore::RenderMathMLOperator::createGlyph):
* rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::layout):
* rendering/mathml/RenderMathMLRoot.h:
(RenderMathMLRoot):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
* rendering/mathml/RenderMathMLSquareRoot.h:
(RenderMathMLSquareRoot):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
* rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
* rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Thu, 9 Feb 2012 19:01:07 +0000 (19:01 +0000)]
Unreviewed gardening.

* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Added.
New baseline (font issue).

* platform/chromium/test_expectations.txt:
Added 2 tests that started asserting on one bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid unnecessary work when evaluating style sharing candidates.
kling@webkit.org [Thu, 9 Feb 2012 18:56:40 +0000 (18:56 +0000)]
Avoid unnecessary work when evaluating style sharing candidates.
<http://webkit.org/b/78220>

Reviewed by Antti Koivisto.

Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding,
lang and xml:lang.) Moved comparison of "type" and "readonly" attributes into the more
specific canShareStyleWithControl() since they are only relevant for input elements.
Don't bother calling isFormControlElement() on both elements since we already know they
have the same tagQName().

Altogether this knocks off 8-9ms worth of samples per cycle of the "Moz" page cycler test.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Introducing functions to set local storage db path and clear
commit-queue@webkit.org [Thu, 9 Feb 2012 18:38:06 +0000 (18:38 +0000)]
[EFL] Introducing functions to set local storage db path and clear
those dbs.
https://bugs.webkit.org/show_bug.cgi?id=77107

This patch exposes the web local storage tracker database path
setting cabability, introduced on bug 77006, to the EFL port of
WebKit. Particularly, we have our own storage tracker client
object, to initialize the storage tracker backend on ewk_init().

Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-09
Reviewed by Kenneth Rohde Christiansen.

* CMakeListsEfl.txt:
* WebCoreSupport/StorageTrackerClientEfl.cpp: Added.
(WebCore):
(WebCore::StorageTrackerClientEfl::dispatchDidModifyOrigin):
(WebCore::StorageTrackerClientEfl::didFinishLoadingOrigins):
* WebCoreSupport/StorageTrackerClientEfl.h: Added.
(WebCore):
(StorageTrackerClientEfl):
* ewk/ewk_main.cpp:
(trackerClient):
(_ewk_init_body):
* ewk/ewk_settings.cpp:
(ewk_settings_local_storage_path_set):
(ewk_settings_local_storage_path_get):
(ewk_settings_local_storage_database_clear):
(ewk_settings_local_storage_database_origin_clear):
* ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS3 calc() - remove mod
mikelawther@chromium.org [Thu, 9 Feb 2012 18:27:06 +0000 (18:27 +0000)]
CSS3 calc() - remove mod
https://bugs.webkit.org/show_bug.cgi?id=78226

Source/WebCore:

mod has been removed from the spec for calc().

Reviewed by Ojan Vafai.

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
* css/CSSGrammar.y:
* platform/CalculationValue.h:

LayoutTests:

Reviewed by Ojan Vafai.

* css3/calc/simple-calcs-expected.txt:
* css3/calc/simple-calcs.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing file for fast/events/scroll-event-during-modal-dialog.html
jochen@chromium.org [Thu, 9 Feb 2012 17:42:25 +0000 (17:42 +0000)]
Add missing file for fast/events/scroll-event-during-modal-dialog.html
https://bugs.webkit.org/show_bug.cgi?id=78234

Reviewed by Mihai Parparita.

* fast/events/resources/scroll-event-modal-dialog.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: rename DOMEditor to DOMPatchSupport, move undoable actions from
pfeldman@chromium.org [Thu, 9 Feb 2012 17:42:09 +0000 (17:42 +0000)]
Web Inspector: rename DOMEditor to DOMPatchSupport, move undoable actions from
InspectorDOMAgent to the new DOMEditor.
https://bugs.webkit.org/show_bug.cgi?id=78245

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/DOMEditor.cpp:
(DOMEditor::DOMAction):
(WebCore::DOMEditor::DOMAction::DOMAction):
(WebCore::DOMEditor::DOMAction::perform):
(WebCore::DOMEditor::DOMAction::undo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::undo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::perform):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::undo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(WebCore::DOMEditor::SetOuterHTMLAction::newNode):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::undo):
(WebCore::DOMEditor::DOMEditor):
(WebCore):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):
* inspector/DOMEditor.h:
(WebCore):
(DOMEditor):
* inspector/DOMPatchSupport.cpp: Copied from Source/WebCore/inspector/DOMEditor.cpp.
(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::~DOMPatchSupport):
(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::createDigest):
(WebCore::DOMPatchSupport::insertBefore):
(WebCore::DOMPatchSupport::removeChild):
(WebCore::DOMPatchSupport::markNodeAsUsed):
(WebCore::DOMPatchSupport::dumpMap):
* inspector/DOMPatchSupport.h: Copied from Source/WebCore/inspector/DOMEditor.h.
(DOMPatchSupport):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
* inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r104746): iframes load PDFs as media documents
mrowe@apple.com [Thu, 9 Feb 2012 17:31:07 +0000 (17:31 +0000)]
REGRESSION (r104746): iframes load PDFs as media documents
<http://webkit.org/b/77079> / <rdar://problem/10757933>

Roll out r104746 since it completely broke support for loading PDF documents in subframes.

Reviewed by Adam Treat.

* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] always initialize makeArgs in buildChromiumNinja
jochen@chromium.org [Thu, 9 Feb 2012 17:25:53 +0000 (17:25 +0000)]
[chromium] always initialize makeArgs in buildChromiumNinja
https://bugs.webkit.org/show_bug.cgi?id=78231

Reviewed by Tony Gentilcore.

* Scripts/webkitdirs.pm:
(buildChromiumNinja):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Show url of current hovered link in MiniBrowser
carlosgc@webkit.org [Thu, 9 Feb 2012 17:18:06 +0000 (17:18 +0000)]
[GTK] Show url of current hovered link in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78098

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewMouseTargetChanged): Check whether hit test result is a
link and use the url to update the status bar text.
(browserWindowConstructed): Connect to
WebKitWebView::mouse-target-changed signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 9 Feb 2012 17:11:06 +0000 (17:11 +0000)]
2012-02-09  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, gardening, more svg fixes.

        Mark svg/custom/absolute-sized-content-with-resources.xhtml as IMAGE+TEXT and
        rebaseline svg/carto.net/slider-expected.png.

        * platform/chromium-linux/svg/carto.net/slider-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for GTK+ 2.x after my previous commit.
mrobinson@webkit.org [Thu, 9 Feb 2012 17:09:44 +0000 (17:09 +0000)]
Build fix for GTK+ 2.x after my previous commit.

* webkit/webkitwebview.cpp:
(webkit_web_view_expose_event): The name of the event is expose_event and not expose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [refactoring] take _showShortEvents out of timeline calculator
caseq@chromium.org [Thu, 9 Feb 2012 16:53:55 +0000 (16:53 +0000)]
Web Inspector: [refactoring] take _showShortEvents out of timeline calculator
https://bugs.webkit.org/show_bug.cgi?id=78230

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._addToRecordsWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitWebView::mouse-target-changed signal to WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 9 Feb 2012 16:51:04 +0000 (16:51 +0000)]
[GTK] Add WebKitWebView::mouse-target-changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=78097

Reviewed by Martin Robinson.

.:

* Source/autotools/symbols.filter: Add freeOwnedGPtr<_GdkEvent>
symbol to be able to use GOwnPtr<GdkEvent> in WebKit2 GTK+ unit
tests.

Source/WebKit2:

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitHitTestResult.cpp: Added.
(webkitHitTestResultFinalize):
(webkitHitTestResultGetProperty):
(webkitHitTestResultSetProperty):
(webkit_hit_test_result_init):
(webkit_hit_test_result_class_init):
(webkitHitTestResultCreate): Create a new WebKitHitTestResult for
the given WKHitTestResult.
(stringIsEqualToCString): Helper function to compare String and
CString considering String::isEmpty() == CString.isNull().
(webkitHitTestResultCompare): Helper function to check whether a
WebKitHitTestResult contains the same information than the given
WKHitTestResult.
(webkit_hit_test_result_get_context):
(webkit_hit_test_result_context_is_link):
(webkit_hit_test_result_context_is_image):
(webkit_hit_test_result_context_is_media):
(webkit_hit_test_result_get_link_uri):
(webkit_hit_test_result_get_link_title):
(webkit_hit_test_result_get_link_label):
(webkit_hit_test_result_get_image_uri):
(webkit_hit_test_result_get_media_uri):
* UIProcess/API/gtk/WebKitHitTestResult.h: Added.
* UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
* UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
(webkitNavigationPolicyDecisionCreate): Use
wkEventModifiersToGdkModifiers.
* UIProcess/API/gtk/WebKitPrivate.cpp:
(wkEventModifiersToGdkModifiers): Moved from
WebKitNavigationPolicyDecision and renamed to wkEventModifiersToGdkModifiers.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitUIClient.cpp:
(mouseDidMoveOverElement): UI client callback that calls
webkitWebViewMouseTargetChanged().
(attachUIClientToView): Add implementation for callback
mouseDidMoveOverElement.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add
WebKitWebView::mouse-target-changed signal.
(webkitWebViewMouseTargetChanged): Emit
WebKitWebView::mouse-target-changed signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitHitTestResult.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest):
(WebViewTest::~WebViewTest):
(parentWindowMapped):
(WebViewTest::showInWindowAndWaitUntilMapped): Method to add the
view into a popup window and show it running the main loop until
the window is mapped.
(WebViewTest::mouseMoveTo): Method to synthesize a
GDK_MOTION_EVENT on the given coordinates and using the given
modifiers.
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2.h: Include WebKitHitTestResult.h.
* UIProcess/API/gtk/webkit2marshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Embedded GtkWidgets are not drawn
mrobinson@webkit.org [Thu, 9 Feb 2012 16:38:52 +0000 (16:38 +0000)]
[GTK] Embedded GtkWidgets are not drawn
https://bugs.webkit.org/show_bug.cgi?id=63451

Source/WebCore:

Remove widget from it's parent container when GtkPluginWidget is destroyed.
Remove paint() method because real expose even is used for drawing child widgets now.

Patch by Dan Vrátil  <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com> on 2012-02-08
Reviewed by Martin Robinson.

* platform/gtk/GtkPluginWidget.cpp:
(WebCore::GtkPluginWidget::~GtkPluginWidget):
(WebCore):
* platform/gtk/GtkPluginWidget.h:
(GtkPluginWidget):

Source/WebKit/gtk:

Insert plugin widgets to WebKitWebView container as it's children.
Chain up to parent in webkit_web_view_draw() to ensure the child widgets are drawn.

Patch by Dan Vrátil  <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com> on 2012-02-08
Reviewed by Martin Robinson.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createPlugin):
* webkit/webkitwebview.cpp:
(webkit_web_view_draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 9 Feb 2012 16:25:44 +0000 (16:25 +0000)]
2012-02-09  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update chromium svg expectations after r107207.

        * platform/chromium-linux-x86/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
        * platform/chromium-linux/svg/custom/animate-target-id-changed-expected.png: Added.
        * platform/chromium-linux/svg/custom/animate-target-id-changed-expected.txt: Added.
        * platform/chromium-linux/svg/custom/clip-path-href-changes-expected.png: Added.
        * platform/chromium-linux/svg/custom/clip-path-href-changes-expected.txt: Added.
        * platform/chromium-linux/svg/custom/fill-opacity-update-expected.txt: Added.
        * platform/chromium-linux/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
        * platform/chromium-linux/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
        * platform/chromium-linux/svg/custom/glyph-selection-non-bmp-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png.
        * platform/chromium-linux/svg/custom/hit-test-with-br-expected.png:
        * platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
        * platform/chromium-linux/svg/custom/js-update-container-expected.txt: Added.
        * platform/chromium-linux/svg/custom/js-update-gradient-expected.txt: Added.
        * platform/chromium-linux/svg/custom/js-update-style-expected.txt: Added.
        * platform/chromium-linux/svg/custom/marker-child-changes-expected.txt: Added.
        * platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
        * platform/chromium-linux/svg/custom/prevent-default-expected.png: Added.
        * platform/chromium-linux/svg/custom/prevent-default-expected.txt: Added.
        * platform/chromium-linux/svg/custom/repaint-on-constant-size-change-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png.
        * platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png:
        * platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
        * platform/chromium-linux/svg/custom/stroke-opacity-update-expected.txt: Added.
        * platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
        * platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.txt: Added.
        * platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/custom/clip-path-href-changes-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/fill-opacity-update-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png:
        * platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
        * platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png:
        * platform/chromium-mac-leopard/svg/custom/hit-test-with-br-expected.png:
        * platform/chromium-mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/js-update-container-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/js-update-gradient-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/js-update-style-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/marker-child-changes-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/prevent-default-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/stroke-opacity-update-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png:
        * platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.png: Removed.
        * platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png:
        * platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
        * platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
        * platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png:
        * platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
        * platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png:
        * platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
        * platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png:
        * platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
        * platform/chromium-win/svg/custom/hit-test-with-br-expected.png:
        * platform/chromium-win/svg/custom/hit-test-with-br-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream DumpRenderTreeBlackBerry
rwlbuis@webkit.org [Thu, 9 Feb 2012 16:12:46 +0000 (16:12 +0000)]
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream final part of our DRT implementation.

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
* DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 9 Feb 2012 16:00:14 +0000 (16:00 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/fast/images/embed-image-expected.txt: Add after Qt5 update.
* platform/qt-wk2/ [...] .png: Remove obsolete png files.
* platform/qt/Skipped: Skip new tests without expected files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoupdate CSS3 calc() color tests to use pre/post js
mikelawther@chromium.org [Thu, 9 Feb 2012 15:53:48 +0000 (15:53 +0000)]
update CSS3 calc() color tests to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=77596

Note that these tests are intended to 'fail' as calc() functionality
had not yet landed (see http://webkit.org/b/16662)

Reviewed by Kent Tamura.

* css3/calc/color-hsl-expected.txt:
* css3/calc/color-hsl.html:
* css3/calc/color-rgb-expected.txt:
* css3/calc/color-rgb.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSetting media element 'src' attribute to "" should trigger load
commit-queue@webkit.org [Thu, 9 Feb 2012 15:49:13 +0000 (15:49 +0000)]
Setting media element 'src' attribute to "" should trigger load
https://bugs.webkit.org/show_bug.cgi?id=47907

Patch by Arun Patole <arun.patole@motorola.com> on 2012-02-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-src-empty.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):Trigger a load, as long as the 'src' attribute is present.

LayoutTests:

* media/video-src-empty-expected.txt: Added, test for <video> with empty src.
* media/video-src-empty.html: Added.
* media/video-src-none-expected.txt:
* media/video-src-none.html: removed "empty src" test as it is handled in separate test: video-src-empty.html.
* platform/chromium/test_expectations.txt: media/video-empty-source.html needs a rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add setNeedsRedraw to WebWidget
commit-queue@webkit.org [Thu, 9 Feb 2012 15:40:32 +0000 (15:40 +0000)]
[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setFullRootLayerDamageOnImplThread):
(WebCore):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix setOuterHTML for the case that adds / removes duplicate.
pfeldman@chromium.org [Thu, 9 Feb 2012 15:26:58 +0000 (15:26 +0000)]
Web Inspector: fix setOuterHTML for the case that adds / removes duplicate.
https://bugs.webkit.org/show_bug.cgi?id=78235

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore):
(WebCore::nodeName):
(WebCore::DOMEditor::dumpMap):
* inspector/DOMEditor.h:
(DOMEditor):

LayoutTests:

* inspector/elements/set-outer-html-2-expected.txt:
* inspector/elements/set-outer-html-2.html:
* inspector/elements/set-outer-html-expected.txt:
* inspector/elements/set-outer-html.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 9 Feb 2012 15:23:16 +0000 (15:23 +0000)]
2012-02-09  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, update chromium svg expectations after r107207.

        * 400 platform/chromium*/svg/custom/* files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Skip new failing tests to paint the bot green.
ossy@webkit.org [Thu, 9 Feb 2012 15:05:04 +0000 (15:05 +0000)]
[Qt][Mac] Skip new failing tests to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Ensure timers and other active DOM objects do not fire in suspended...
commit-queue@webkit.org [Thu, 9 Feb 2012 14:49:21 +0000 (14:49 +0000)]
Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-09
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

* Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::create):
* bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
* dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):
* dom/ActiveDOMObject.h:
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::DocumentEventQueue):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::create):
* fileapi/FileReader.cpp:
(WebCore::FileReader::create):
* fileapi/FileReader.h:
* fileapi/FileWriter.cpp:
(WebCore::FileWriter::create):
* fileapi/FileWriter.h:
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::create):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::create):
* notifications/Notification.cpp:
(WebCore::Notification::create):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::create):
* notifications/NotificationCenter.h:
* page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
* page/EventSource.cpp:
(WebCore::EventSource::create):
* page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
* storage/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::create):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
(WebCore::AudioContext::createOfflineContext):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
* websockets/WebSocket.h:
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/Worker.cpp:
(WebCore::Worker::create):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-09
Reviewed by Mihai Parparita.

* fast/events/resources/suspend-subframe-1.html: Added.
* fast/events/resources/suspend-subframe-2.html: Added.
* fast/events/suspend-timers-expected.txt: Added.
* fast/events/suspend-timers.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed followup for r107235.
vsevik@chromium.org [Thu, 9 Feb 2012 14:45:23 +0000 (14:45 +0000)]
Unreviewed followup for r107235.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each...
jocelyn.turcotte@nokia.com [Thu, 9 Feb 2012 14:40:47 +0000 (14:40 +0000)]
[Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each layer.
https://bugs.webkit.org/show_bug.cgi?id=78009

Reviewed by Noam Rosenthal.

Since WebGraphicsLayers are now accessed directly from LayerTreeHost, they don't
need to keep the visible rect to pass it down their child layers anymore.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::registerLayer):
(WebKit::LayerTreeHostQt::visibleContentsRect):
(WebKit):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer.
jocelyn.turcotte@nokia.com [Thu, 9 Feb 2012 14:38:44 +0000 (14:38 +0000)]
[Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=78005

Reviewed by Noam Rosenthal.

This makes sure that no empty tiles are generated for layers without contents and that
no interaction is made with the TiledBackingStore until we got a WebGraphicsLayerClient.

- Create the main TiledBackingStore only when the layer has drawsContent and has no
  directly composited image
- Removed recreateBackingStoreIfNeeded and do the (re)creation of the backing stores
  in updateContentBuffers
- Call purgeBackingStores on registered layers instead of passing it down the layer tree

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit):
(WebKit::LayerTreeHostQt::purgeBackingStores):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Support hiding scripts panel debug sidebar.
vsevik@chromium.org [Thu, 9 Feb 2012 14:37:12 +0000 (14:37 +0000)]
Web Inspector: Support hiding scripts panel debug sidebar.
https://bugs.webkit.org/show_bug.cgi?id=77543

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Dialog.js:
(WebInspector.Dialog):
(WebInspector.DialogDelegate.prototype.show):
* inspector/front-end/Images/navigatorPinButton.png: Added.
* inspector/front-end/Images/navigatorShowHideButton.png: Added.
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get view):
(WebInspector.ScriptsNavigator.prototype.get element):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype.focus):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createNavigatorControls):
(WebInspector.ScriptsPanel.prototype._createNavigatorControlButton):
(WebInspector.ScriptsPanel.prototype._toggleNavigator):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):
* inspector/front-end/SidebarOverlay.js: Added.
* inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype.get resizable):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.hideSidebarElement):
(WebInspector.SplitView.prototype.showSidebarElement):
(WebInspector.SplitView.prototype._resizerDragging):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.get element):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/dialog.css:
* inspector/front-end/inspector.html:
* inspector/front-end/scriptsPanel.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove WebGraphicsLayer::updateTileBuffersRecursively
jocelyn.turcotte@nokia.com [Thu, 9 Feb 2012 14:35:14 +0000 (14:35 +0000)]
[Qt] Remove WebGraphicsLayer::updateTileBuffersRecursively
https://bugs.webkit.org/show_bug.cgi?id=78105

Reviewed by Kenneth Rohde Christiansen.

The method is unused.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Register individual WebGraphicsLayers to LayerTreeHost instead of handling the...
jocelyn.turcotte@nokia.com [Thu, 9 Feb 2012 14:33:33 +0000 (14:33 +0000)]
[Qt] Register individual WebGraphicsLayers to LayerTreeHost instead of handling the tree as a whole.
https://bugs.webkit.org/show_bug.cgi?id=77976

Reviewed by Kenneth Rohde Christiansen.

The LayerTreeHost association had to be maintained between re-parented layers and it would be
impossible to know if the layer would be disconnected from the LayerTreeHost only for reparenting
or disconnected for good (in other words, that the LayerTreeHost could be deleted meanwhile).

Instead, this patch assumes that graphics layers will only be in contact with one instance of
LayerTreeHost, and that this association can be kept until either the graphics layer or the layer
tree host gets deleted.

The registered layers are kept in a set and the visible rect and scales are passed directly
to layers instead of down the tree, through the root layer.

This also fixes the !m_layerInfo.imageBackingStoreID ASSERT that was popping in unit tests.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectAndScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebCore):
(WebGraphicsLayerClient):
(WebGraphicsLayer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::attachLayer):
(WebKit):
(WebKit::LayerTreeHostQt::detachLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] WebView should use Flickable instead of QScroller to handle positioning
abecsi@webkit.org [Thu, 9 Feb 2012 14:31:44 +0000 (14:31 +0000)]
[Qt][WK2] WebView should use Flickable instead of QScroller to handle positioning
https://bugs.webkit.org/show_bug.cgi?id=76275

Reviewed by Simon Hausmann and Kenneth Rohde Christiansen.

The current WebView implementation uses QScroller to manage positioning but other
similar items in QML (ie. ListView, GridView) use Flickable as their base class.
Since QScroller will be dropped from Qt5 this patch removes the QScroller code
and redirects pan gestures to a dynamically created encapsulated Flickable instance
(QtFlickProvider) which handles the positioning.

This implementation only uses public QML API and does not depend on declarative-private.
It propagates a small subset of the Flickable API as the public API of the WebView.
This minimalistic API is accessible via the experimental extension and makes it possible
in QML to place additional items (such as toolbars, scroll indicators and floating menus)
aroud the page.
These items can use anchoring and binding for positioning on the flickable contentItem.

The patch depends however on the automatic touch->mouse event synthetization of Qt5.
The touch events sent to the flickProvider are translated to mouse events automatically
as long as the Flickable does not handle touch events directly.

After this change QtWebKit2 does no longer depend on QtWidgets and this dependency can be
removed in a follow-up patch.

* Target.pri: Added QtFlickProvider source.
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::flickableData):
(QQuickWebViewExperimental::contentItem):
(QQuickWebViewExperimental::contentWidth):
(QQuickWebViewExperimental::setContentWidth):
(QQuickWebViewExperimental::contentHeight):
(QQuickWebViewExperimental::setContentHeight):
(QQuickWebViewExperimental::contentX):
(QQuickWebViewExperimental::setContentX):
(QQuickWebViewExperimental::contentY):
(QQuickWebViewExperimental::setContentY):
(QQuickWebView::pageItemPos):
(QQuickWebView::updateContentsSize):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):
* UIProcess/qt/QtFlickProvider.cpp: Added.
(QtFlickProvider::QtFlickProvider):
(QtFlickProvider::handleTouchFlickEvent):
(QtFlickProvider::contentItem):
(QtFlickProvider::flickableData):
(QtFlickProvider::contentPos):
(QtFlickProvider::setContentPos):
(QtFlickProvider::viewportSize):
(QtFlickProvider::setViewportSize):
(QtFlickProvider::returnToBounds):
(QtFlickProvider::cancelFlick):
(QtFlickProvider::isMoving):
(QtFlickProvider::isDragging):
(QtFlickProvider::isFlicking):
(QtFlickProvider::contentWidth):
(QtFlickProvider::setContentWidth):
(QtFlickProvider::contentHeight):
(QtFlickProvider::setContentHeight):
(QtFlickProvider::contentX):
(QtFlickProvider::setContentX):
(QtFlickProvider::contentY):
(QtFlickProvider::setContentY):
* UIProcess/qt/QtFlickProvider.h: Added.
(QtFlickProvider):
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtPanGestureRecognizer.h:
(QtPanGestureRecognizer):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::scrollStateChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::doneWithTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 14:26:22 +0000 (14:26 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Update expectations. svg/custom/nested-embedded-svg-size-changes.html no longer timeouts.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 13:58:49 +0000 (13:58 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Make the hit-test-with-br.xhtml work on non-Mac platforms.
        it was skipped on Chromium Win/Linux before, as the click on the <rect> never suceeeded.
        On  Mac the coordinate 10x70, was the upper left corner of the rectangle, so if the font
        size is just slightly larger, or the size of the <br/>, then we failed to fire the click
        event - so just click at 50x80, to be on the safe side.

        * svg/custom/hit-test-with-br.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
zimmermann@webkit.org [Thu, 9 Feb 2012 13:39:46 +0000 (13:39 +0000)]
[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Reviewed by Zoltan Herczeg.

Another attempt at fixing svg/as-object/nested-embedded-svg-size-changes.html,
by guessing from the JS trace, where it might happened.

* svg/as-object/nested-embedded-svg-size-changes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTests/fast/harness/resources/modal-dialog.html is missing the opening html tag
commit-queue@webkit.org [Thu, 9 Feb 2012 13:37:12 +0000 (13:37 +0000)]
LayoutTests/fast/harness/resources/modal-dialog.html is missing the opening html tag
https://bugs.webkit.org/show_bug.cgi?id=78217

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Andreas Kling.

Add the missing opening <html> tag.

* fast/harness/resources/modal-dialog.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: Show percentage by default in heap profiler.
commit-queue@webkit.org [Thu, 9 Feb 2012 13:23:58 +0000 (13:23 +0000)]
Source/WebCore: Web Inspector: Show percentage by default in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78103

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._updateFilterOptions):
* inspector/front-end/UIUtils.js:
(Number.withThousandsSeparator):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid span.percent-column):

LayoutTests: WebInspector: Show percentage by default in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78103

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.

* inspector/profiler/detailed-heapshots-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] SVG animation pause API missing
ossy@webkit.org [Thu, 9 Feb 2012 13:14:43 +0000 (13:14 +0000)]
[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Unreviewed gardening, skip svg/animations/animate-color-fill-from-by.html because of this bug.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Timeline memory graph would have been more useful if it had used minUs...
loislo@chromium.org [Thu, 9 Feb 2012 13:04:13 +0000 (13:04 +0000)]
Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
https://bugs.webkit.org/show_bug.cgi?id=78222

Reviewed by Pavel Feldman.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):
* inspector/front-end/timelinePanel.css:
(.memory-graph-label):
(.max.memory-graph-label):
(.min.memory-graph-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:55:42 +0000 (12:55 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Move platform dependant results where they belong, and add Qt specific ones.

        * platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.png.
        * platform/mac/svg/custom/glyph-selection-arabic-forms-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.txt.
        * platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.png.
        * platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.txt.
        * platform/mac/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.png.
        * platform/mac/svg/custom/glyph-selection-non-bmp-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.txt.
        * platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
        * platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
        * platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix compilation with newer Qt5
ossy@webkit.org [Thu, 9 Feb 2012 12:50:46 +0000 (12:50 +0000)]
[Qt] Fix compilation with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=77653

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-09
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp: Removed unnecessary inclusion of removed header file.
* declarative/public.pri: Use quick1 instead of qtquick1. It's mandator with Qt 5.
* tests/tests.pri: Ditto.
* declarative/qdeclarativewebview_p.h: Fix includes, just use the module-less
version that works with all Qt versions.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Update protocol and UI to follow bug 77204 (Kill per-Attribute style...
apavlov@chromium.org [Thu, 9 Feb 2012 12:41:37 +0000 (12:41 +0000)]
Web Inspector: Update protocol and UI to follow bug 77204 (Kill per-Attribute style declarations)
https://bugs.webkit.org/show_bug.cgi?id=77962

Reviewed by Pavel Feldman.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-new-API-expected.txt:
* inspector/styles/styles-new-API.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:33:44 +0000 (12:33 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing Mac/Lion result.

        * platform/mac/svg/carto.net/scrollbar-expected.png: Added.
        * svg/custom/glyph-selection-bidi-mirror-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:26:17 +0000 (12:26 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Switch svg/custom tests to repaint harness
        https://bugs.webkit.org/show_bug.cgi?id=78115

        Not reviewed. Fix last minute typo, in nested-embedded-svg-size-changes.html, that may lead to flakiness.

        * svg/as-object/nested-embedded-svg-size-changes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up...
pfeldman@chromium.org [Thu, 9 Feb 2012 12:24:27 +0000 (12:24 +0000)]
Web Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up / Down.
https://bugs.webkit.org/show_bug.cgi?id=78123

Reviewed by Yury Semikhatsky.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._registerShortcuts):
(WebInspector.ElementsPanel.prototype.handleShortcut):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondragstart):
(WebInspector.ElementsTreeOutline.prototype._ondragover):
(WebInspector.ElementsTreeOutline.prototype._doMove):
(WebInspector.ElementsTreeOutline.prototype._ondragend):
(WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
(WebInspector.ElementsTreeOutline.prototype._toggleEditAsHTML):
(WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
* inspector/front-end/UIUtils.js:

LayoutTests:

* inspector/elements/move-node.html:
* inspector/elements/undo-dom-edits-expected.txt:
* inspector/elements/undo-dom-edits.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 12:02:56 +0000 (12:02 +0000)]
2012-02-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline some Qt svg results.

        * platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
        * platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
        * platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
        * platform/qt/svg/custom/js-update-bounce-expected.txt:
        * platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
        * platform/qt/svg/custom/js-update-style-expected.txt:
        * platform/qt/svg/custom/mask-invalidation-expected.txt:
        * platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
        * platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
        * platform/qt/svg/custom/use-clipped-hit-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectation update.
bashi@chromium.org [Thu, 9 Feb 2012 11:58:27 +0000 (11:58 +0000)]
Unreviewed test expectation update.

* platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium/platform/chromium/compositing/layout-width-change-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 9 Feb 2012 11:56:43 +0000 (11:56 +0000)]
2012-02-09  Roland Steiner  <rolandsteiner@chromium.org>

        SelectorChecker::checkSelector: move parameters into a struct
        https://bugs.webkit.org/show_bug.cgi?id=77525

        Added 'SelectorCheckingContext' struct to hold parameters for the function.
        Adapted calling sites.
        (fixing change log after the commit message got bungled up).

        Reviewed by Antti Koivisto.

        No new tests. (refactoring)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        * css/SelectorChecker.cpp:
        (WebCore::SelectorChecker::checkSelector):
        (WebCore):
        (WebCore::SelectorChecker::checkOneSelector):
        * css/SelectorChecker.h:
        (SelectorCheckingContext):
        (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
        (SelectorChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes...
zimmermann@webkit.org [Thu, 9 Feb 2012 11:44:55 +0000 (11:44 +0000)]
[Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78026

[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Reviewed by Andreas Kling.

Rework testcases, to wait for the embedded SVG of the embedded HTML that we're loading.
Should fix the flakiness for both Qt/Chromium.

* platform/qt/Skipped: Unskip test.
* svg/as-object/nested-embedded-svg-size-changes.html: Wait for the embedded SVG to load, before trying to access it.
* svg/as-object/resources/nested-embedded-svg-size-changes-target.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix mirroring with SVG fonts
rolandsteiner@chromium.org [Thu, 9 Feb 2012 11:44:28 +0000 (11:44 +0000)]
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Patch by Philip Rogers <pdr@google.com> on 2012-02-09
Reviewed by Nikolas Zimmermann.

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg
       svg/custom/glyph-selection-bidi-mirror.svg
       svg/custom/glyph-selection-non-bmp.svg

* platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):
* svg/SVGFontData.h:
(SVGFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Philip Rogers <pdr@google.com>
zimmermann@webkit.org [Thu, 9 Feb 2012 11:40:53 +0000 (11:40 +0000)]
2012-02-09  Philip Rogers  <pdr@google.com>

        Fix mirroring with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=77067

        Reviewed by Nikolas Zimmermann.

        SVG fonts were incorrectly handling mirrored characters in bidi text.
        In this change I added the function createStringWithMirroredCharacters
        which handles mirroring the characters when selecting glyphs for SVG
        fonts. I also made a small cosmetic change in the function
        charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
        which better reflects what it actually does.

        Several new tests were added to test mirroring with SVG fonts in the
        presence of Arabic forms and non-BMP characters.

        * platform/gtk/test_expectations.txt:
        * platform/win/test_expectations.txt:
        * svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
        * svg/custom/glyph-selection-arabic-forms.svg: Added.
        * svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
        * svg/custom/glyph-selection-bidi-mirror.svg: Added.
        * svg/custom/glyph-selection-non-bmp-expected.png: Added.
        * svg/custom/glyph-selection-non-bmp-expected.txt: Added.
        * svg/custom/glyph-selection-non-bmp.svg: Added.

2012-02-09  Philip Rogers  <pdr@google.com>

        Fix mirroring with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=77067

        Reviewed by Nikolas Zimmermann.

        SVG fonts were incorrectly handling mirrored characters in bidi text.
        In this change I added the function createStringWithMirroredCharacters
        which handles mirroring the characters when selecting glyphs for SVG
        fonts. I also made a small cosmetic change in the function
        charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
        which better reflects what it actually does.

        Several new tests were added to test mirroring with SVG fonts in the
        presence of Arabic forms and non-BMP characters.

        Tests: svg/custom/glyph-selection-arabic-forms.svg
               svg/custom/glyph-selection-bidi-mirror.svg
               svg/custom/glyph-selection-non-bmp.svg

        * platform/graphics/SVGGlyph.cpp:
        (WebCore::charactersWithArabicForm):
        * svg/SVGFontData.cpp:
        (WebCore::SVGFontData::applySVGGlyphSelection):
        (WebCore::SVGFontData::createStringWithMirroredCharacters):
        * svg/SVGFontData.h:
        (SVGFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r107207.
philn@webkit.org [Thu, 9 Feb 2012 11:37:16 +0000 (11:37 +0000)]
Unreviewed, GTK rebaseline after r107207.

* platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/gtk/svg/custom/foreignObject-crash-on-hover-expected.txt:
* platform/gtk/svg/custom/hit-test-unclosed-subpaths-expected.txt:
* platform/gtk/svg/custom/js-update-bounce-expected.txt:
* platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
* platform/gtk/svg/custom/js-update-style-expected.txt:
* platform/gtk/svg/custom/mask-invalidation-expected.txt:
* platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/gtk/svg/custom/text-repaint-including-stroke-expected.txt:
* platform/gtk/svg/custom/use-clipped-hit-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Scripts navigator fails to reopen previously closed script.
vsevik@chromium.org [Thu, 9 Feb 2012 11:28:57 +0000 (11:28 +0000)]
Web Inspector: Scripts navigator fails to reopen previously closed script.
https://bugs.webkit.org/show_bug.cgi?id=78212

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._editorClosed):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT_NO_EXCEPTION should be initialized with non-zero value.
commit-queue@webkit.org [Thu, 9 Feb 2012 11:21:46 +0000 (11:21 +0000)]
ASSERT_NO_EXCEPTION should be initialized with non-zero value.
https://bugs.webkit.org/show_bug.cgi?id=78194

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.

ExceptionCode should not be checked without initializing it.
However, we encountered a bug that breaks this rule.
It was missed until now because ExceptionCode is sometimes set to 0 even if it is not initialized.
This patch ensures it is initialized as non-zero value.

No new tests, no change in behavior.

* dom/ExceptionCodePlaceholder.cpp:
(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):
* dom/ExceptionCodePlaceholder.h:
(NoExceptionAssertionChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch svg/custom tests to repaint harness
zimmermann@webkit.org [Thu, 9 Feb 2012 11:21:42 +0000 (11:21 +0000)]
Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Reviewed by Andreas Kling.

Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/mac/svg/custom/animate-path-discrete-expected.png:
* platform/mac/svg/custom/animate-path-morphing-expected.png:
* platform/mac/svg/custom/animate-target-id-changed-expected.png:
* platform/mac/svg/custom/animate-target-removed-from-document-expected.png:
* platform/mac/svg/custom/circle-move-invalidation-expected.png:
* platform/mac/svg/custom/clip-path-child-changes-expected.png:
* platform/mac/svg/custom/clip-path-href-changes-expected.png:
* platform/mac/svg/custom/clip-path-id-changes-expected.png:
* platform/mac/svg/custom/clip-path-units-changes-expected.png:
* platform/mac/svg/custom/deep-dynamic-updates-expected.png:
* platform/mac/svg/custom/fill-opacity-update-expected.png:
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png:
* platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
* platform/mac/svg/custom/gradient-add-stops-expected.png:
* platform/mac/svg/custom/gradient-stop-style-change-expected.png:
* platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
* platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.txt:
* platform/mac/svg/custom/hit-test-with-br-expected.png:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-creation-expected.png:
* platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-marker-creation-expected.png:
* platform/mac/svg/custom/js-late-mask-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-mask-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-creation-expected.png:
* platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
* platform/mac/svg/custom/js-update-bounce-expected.png:
* platform/mac/svg/custom/js-update-bounce-expected.txt:
* platform/mac/svg/custom/js-update-container-expected.png:
* platform/mac/svg/custom/js-update-container2-expected.png:
* platform/mac/svg/custom/js-update-gradient-expected.png:
* platform/mac/svg/custom/js-update-image-expected.png:
* platform/mac/svg/custom/js-update-path-changes-expected.png:
* platform/mac/svg/custom/js-update-path-removal-expected.png:
* platform/mac/svg/custom/js-update-pattern-child-expected.png:
* platform/mac/svg/custom/js-update-pattern-expected.png:
* platform/mac/svg/custom/js-update-polygon-changes-expected.png:
* platform/mac/svg/custom/js-update-polygon-removal-expected.png:
* platform/mac/svg/custom/js-update-stop-expected.png:
* platform/mac/svg/custom/js-update-stop-linked-gradient-expected.png:
* platform/mac/svg/custom/js-update-stop-linked-gradient-expected.txt:
* platform/mac/svg/custom/js-update-style-expected.png:
* platform/mac/svg/custom/js-update-style-expected.txt:
* platform/mac/svg/custom/js-update-transform-addition-expected.png:
* platform/mac/svg/custom/js-update-transform-changes-expected.png:
* platform/mac/svg/custom/marker-child-changes-css-expected.png:
* platform/mac/svg/custom/marker-child-changes-expected.png:
* platform/mac/svg/custom/marker-strokeWidth-changes-expected.png:
* platform/mac/svg/custom/marker-viewBox-changes-expected.png:
* platform/mac/svg/custom/mask-child-changes-expected.png:
* platform/mac/svg/custom/mask-invalidation-expected.png:
* platform/mac/svg/custom/mask-invalidation-expected.txt:
* platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png:
* platform/mac/svg/custom/prevent-default-expected.png:
* platform/mac/svg/custom/relative-sized-content-expected.png:
* platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
* platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
* platform/mac/svg/custom/relative-sized-image-expected.png:
* platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
* platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png:
* platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
* platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
* platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
* platform/mac/svg/custom/repaint-moving-svg-and-div-expected.png:
* platform/mac/svg/custom/repaint-on-image-bounds-change-expected.png:
* platform/mac/svg/custom/resource-client-removal-expected.png:
* platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
* platform/mac/svg/custom/scroll-hit-test-expected.png:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/mac/svg/custom/stroke-opacity-update-expected.png:
* platform/mac/svg/custom/svg-absolute-children-expected.png:
* platform/mac/svg/custom/text-dom-removal-expected.png:
* platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
* platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
* platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/mac/svg/custom/use-clipped-hit-expected.png:
* platform/mac/svg/custom/use-clipped-hit-expected.txt:
* platform/mac/svg/custom/use-detach-expected.png:
* platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
* platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
* platform/mac/svg/custom/use-elementInstance-methods-expected.png:
* platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.png:
* platform/mac/svg/custom/use-event-handler-on-use-element-expected.png:
* platform/mac/svg/custom/use-inherit-style-expected.png:
* platform/mac/svg/custom/use-instanceRoot-as-event-target-expected.png: Removed.
* platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
* platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
* platform/mac/svg/custom/use-setAttribute-crash-expected.png:
* svg/custom/absolute-sized-content-with-resources.xhtml:
* svg/custom/animate-path-discrete.svg:
* svg/custom/animate-path-morphing.svg:
* svg/custom/animate-target-id-changed.svg:
* svg/custom/animate-target-removed-from-document.svg:
* svg/custom/circle-move-invalidation.svg:
* svg/custom/clip-path-child-changes.svg:
* svg/custom/clip-path-href-changes.svg:
* svg/custom/clip-path-id-changes.svg:
* svg/custom/clip-path-units-changes.svg:
* svg/custom/deep-dynamic-updates.svg:
* svg/custom/fill-opacity-update.svg:
* svg/custom/foreignObject-crash-on-hover.xml:
* svg/custom/gradient-add-stops.svg:
* svg/custom/gradient-stop-style-change.svg:
* svg/custom/hit-test-path-stroke.svg:
* svg/custom/hit-test-path.svg:
* svg/custom/hit-test-unclosed-subpaths.svg:
* svg/custom/hit-test-with-br.xhtml:
* svg/custom/js-late-clipPath-and-object-creation.svg:
* svg/custom/js-late-clipPath-creation.svg:
* svg/custom/js-late-gradient-and-object-creation.svg:
* svg/custom/js-late-gradient-creation.svg:
* svg/custom/js-late-marker-and-object-creation.svg:
* svg/custom/js-late-marker-creation.svg:
* svg/custom/js-late-mask-and-object-creation.svg:
* svg/custom/js-late-mask-creation.svg:
* svg/custom/js-late-pattern-and-object-creation.svg:
* svg/custom/js-late-pattern-creation.svg:
* svg/custom/js-repaint-rect-on-path-with-stroke.svg:
* svg/custom/js-update-bounce.svg:
* svg/custom/js-update-container.svg:
* svg/custom/js-update-container2.svg:
* svg/custom/js-update-gradient.svg:
* svg/custom/js-update-image.svg:
* svg/custom/js-update-path-changes.svg:
* svg/custom/js-update-path-removal.svg:
* svg/custom/js-update-pattern-child.svg:
* svg/custom/js-update-pattern.svg:
* svg/custom/js-update-polygon-changes.svg:
* svg/custom/js-update-polygon-removal.svg:
* svg/custom/js-update-stop-linked-gradient.svg:
* svg/custom/js-update-stop.svg:
* svg/custom/js-update-style.svg:
* svg/custom/js-update-transform-addition.svg:
* svg/custom/js-update-transform-changes.svg:
* svg/custom/linking-a-03-b-all.svg:
* svg/custom/linking-a-03-b-preserveAspectRatio.svg:
* svg/custom/linking-a-03-b-transform.svg:
* svg/custom/linking-a-03-b-viewBox-transform.svg:
* svg/custom/linking-a-03-b-viewBox.svg:
* svg/custom/linking-a-03-b-viewTarget.svg:
* svg/custom/linking-a-03-b-zoomAndPan.svg:
* svg/custom/marker-child-changes-css.svg:
* svg/custom/marker-child-changes.svg:
* svg/custom/marker-strokeWidth-changes.svg:
* svg/custom/marker-viewBox-changes.svg:
* svg/custom/mask-child-changes.svg:
* svg/custom/mask-invalidation.svg:
* svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml:
* svg/custom/pending-resource-after-removal-expected.png:
* svg/custom/pending-resource-after-removal.xhtml:
* svg/custom/pending-resource-leak-2.svg:
* svg/custom/pending-resource-leak-3.svg:
* svg/custom/prevent-default.svg:
* svg/custom/relative-sized-content-with-resources.xhtml:
* svg/custom/relative-sized-content.xhtml:
* svg/custom/relative-sized-deep-shadow-tree-content.xhtml:
* svg/custom/relative-sized-image.xhtml:
* svg/custom/relative-sized-inner-svg.xhtml:
* svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
* svg/custom/relative-sized-shadow-tree-content.xhtml:
* svg/custom/relative-sized-use-on-symbol.xhtml:
* svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml:
* svg/custom/repaint-moving-svg-and-div.xhtml:
* svg/custom/repaint-on-constant-size-change.svg:
* svg/custom/repaint-on-image-bounds-change.svg:
* svg/custom/repaint-shadow.svg:
* svg/custom/repaint-stroke-width-changes.svg:
* svg/custom/resource-client-removal.svg:
* svg/custom/resource-invalidate-on-target-update.svg:
* svg/custom/resources/use-instanceRoot-event-bubbling.js:
(repaintTest):
* svg/custom/resources/use-instanceRoot-event-listeners.js:
(repaintTest):
* svg/custom/scroll-hit-test.xhtml:
* svg/custom/scroll-to-anchor-in-symbol.svg:
* svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html:
* svg/custom/stroke-opacity-update.svg:
* svg/custom/svg-absolute-children.svg:
* svg/custom/svg-disallowed-in-dashboard-object.html:
* svg/custom/svg-fonts-in-html-linebreaks.html:
* svg/custom/text-dom-removal.svg:
* svg/custom/text-repaint-including-stroke.svg:
* svg/custom/text-xy-updates-SVGList.xhtml:
* svg/custom/use-animation-in-fill.html:
* svg/custom/use-clipped-hit.svg:
* svg/custom/use-crash-in-non-wellformed-document.svg:
* svg/custom/use-crash-when-href-change.svg:
* svg/custom/use-detach.svg:
* svg/custom/use-disappears-after-style-update.svg:
* svg/custom/use-elementInstance-event-target.svg:
* svg/custom/use-elementInstance-methods.svg:
* svg/custom/use-event-handler-on-referenced-element.svg:
* svg/custom/use-event-handler-on-use-element.svg:
* svg/custom/use-inherit-style.svg:
* svg/custom/use-instanceRoot-as-event-target.xhtml:
* svg/custom/use-instanceRoot-event-bubbling.xhtml:
* svg/custom/use-instanceRoot-event-listeners.xhtml:
* svg/custom/use-multiple-on-nested-disallowed-font.html:
* svg/custom/use-setAttribute-crash.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Thu, 9 Feb 2012 10:28:29 +0000 (10:28 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
* platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Added.
* platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Added.
* platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Added.
* platform/gtk/svg/filters/feImage-late-indirect-update-expected.txt: Added.
* platform/gtk/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-position-expected.txt: Added.
* platform/gtk/svg/filters/feImage-remove-target-expected.txt: Added.
* platform/gtk/svg/filters/feImage-subregions-expected.txt: Added.
* platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
* platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-add-to-document-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-attribute-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-changes-id-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-id-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-property-change-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
* platform/gtk/svg/filters/feImage-target-style-change-expected.txt: Added.
* platform/gtk/svg/filters/filter-placement-issue-expected.txt: Added.
* platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r107197.
rolandsteiner@chromium.org [Thu, 9 Feb 2012 10:21:42 +0000 (10:21 +0000)]
Unreviewed, rolling out r107197.
http://trac.webkit.org/changeset/107197
https://bugs.webkit.org/show_bug.cgi?id=77525

broke Chromium Linux

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
(WebCore):
(WebCore::SelectorChecker::checkOneSelector):
* css/SelectorChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r107182, r107186, r107189, r107191,
haraken@chromium.org [Thu, 9 Feb 2012 10:00:39 +0000 (10:00 +0000)]
Unreviewed, rolling out r107182, r107186, r107189, r107191,
and r107199.
http://trac.webkit.org/changeset/107182
http://trac.webkit.org/changeset/107186
http://trac.webkit.org/changeset/107189
http://trac.webkit.org/changeset/107191
http://trac.webkit.org/changeset/107199
https://bugs.webkit.org/show_bug.cgi?id=78200

Layout tests of JSC-related port are crashing

* Modules/gamepad/GamepadList.idl:
* Modules/intents/Intent.idl:
* bindings/js/JSDOMBinding.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateParametersCheck):
(NativeToJSValue):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
(GenerateImplementationIndexer):
(RequiresCustomSignature):
(NativeToJSValue):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestNamedConstructor.idl:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayInternal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerInternal::methodCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/V8Binding.h:
* bindings/v8/custom/V8BindingMacros.h:
* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSMediaRule.idl:
* css/CSSPageRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSStyleSheet.idl:
* css/CSSValue.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/ClientRectList.idl:
* dom/Clipboard.idl:
* dom/CompositionEvent.idl:
* dom/CustomEvent.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItem.idl:
* dom/DataTransferItemList.idl:
* dom/DeviceMotionEvent.idl:
* dom/DeviceOrientationEvent.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/Event.idl:
* dom/HashChangeEvent.idl:
* dom/KeyboardEvent.idl:
* dom/MessageEvent.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/MutationRecord.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeList.idl:
* dom/Notation.idl:
* dom/OverflowEvent.idl:
* dom/ProcessingInstruction.idl:
* dom/Range.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* dom/TextEvent.idl:
* dom/TouchEvent.idl:
* dom/UIEvent.idl:
* dom/WheelEvent.idl:
* html/DOMFormData.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAudioElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/TextTrackCue.idl:
* html/canvas/CanvasGradient.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/IDBDatabase.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* svg/ElementTimeControl.idl:
* svg/SVGDocument.idl:
* svg/SVGElementInstanceList.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGLocatable.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStylable.idl:
* svg/SVGTests.idl:
* svg/SVGTextContentElement.idl:
* webaudio/AudioNode.idl:
* websockets/WebSocket.idl:
* workers/SharedWorker.idl:
* workers/WorkerContext.idl:
* xml/DOMParser.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, add chromium expectations for new tests added in r107160.
podivilov@chromium.org [Thu, 9 Feb 2012 09:55:51 +0000 (09:55 +0000)]
Unreviewed, add chromium expectations for new tests added in r107160.

* platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable adding a shadow root to elements having a dynamic built-in shadow root.
commit-queue@webkit.org [Thu, 9 Feb 2012 09:54:04 +0000 (09:54 +0000)]
Disable adding a shadow root to elements having a dynamic built-in shadow root.
https://bugs.webkit.org/show_bug.cgi?id=77935

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.

Source/WebCore:

We temporarily disable adding a shadow root in elements having a dynamic user agent shadow root.
These shadow roots are currently created using Element::ensureShadowRoot.
So we don't check the condition if a shadow root is created eaither using Element::ensureShadowRoot
or ShadowRoot::CreatingUserAgentShadowRoot is specified for ShadowRoot::create.

Test: fast/dom/shadow/shadow-disable.html

* dom/Element.cpp:
(WebCore::Element::ensureShadowRoot):
* dom/ShadowRoot.cpp:
(WebCore::allowsUserShadowRoot):
(WebCore):
(WebCore::ShadowRoot::create):
* dom/ShadowRoot.h:
(ShadowRoot):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
  ShadowRoot::CreatingUserAgentShadowRoot is specified.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): ditto.
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree): ditto.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree): ditto.
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree): ditto.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree): ditto.

LayoutTests:

* fast/dom/shadow/shadow-disable-expected.txt: Added.
* fast/dom/shadow/shadow-disable.html: Added.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: hovering over element with :hover style halts inspector
apavlov@chromium.org [Thu, 9 Feb 2012 09:51:29 +0000 (09:51 +0000)]
Web Inspector: hovering over element with :hover style halts inspector
https://bugs.webkit.org/show_bug.cgi?id=78086

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-throttled.html

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

* inspector/styles/updates-throttled-expected.txt: Added.
* inspector/styles/updates-throttled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove http-equiv content-language parsing
commit-queue@webkit.org [Thu, 9 Feb 2012 09:50:06 +0000 (09:50 +0000)]
Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-09
Reviewed by Alexey Proskuryakov.

Add tests for mapping http-equiv content-language to -webkit-locale to cover dynamic changes to the meta
element and a comma-separated list of languages. The desired behavior of some of these is not yet decided, so
some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

* fast/text/content-language-comma-separated-list-expected.txt: Added.
* fast/text/content-language-comma-separated-list.html: Added.
* fast/text/content-language-dynamically-added-expected.txt: Added.
* fast/text/content-language-dynamically-added.html: Added.
* fast/text/content-language-dynamically-changed-expected.txt: Added.
* fast/text/content-language-dynamically-changed.html: Added.
* fast/text/content-language-dynamically-removed-expected.txt: Added.
* fast/text/content-language-dynamically-removed.html: Added.
* fast/text/content-language-multiple.html: Fix to actually test http-equiv content-language.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix build failure caused by r107191.
haraken@chromium.org [Thu, 9 Feb 2012 09:46:17 +0000 (09:46 +0000)]
Unreviewed. Fix build failure caused by r107191.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 9 Feb 2012 09:42:47 +0000 (09:42 +0000)]
2012-02-09  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, gardening, remove stale chromium expectations for synthetic-bold-transformed.

        * platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Removed.
        * platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-09 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 9 Feb 2012 09:36:24 +0000 (09:36 +0000)]
2012-02-09  Roland Steiner  <rolandsteiner@chromium.org>

        SelectorChecker::checkSelector: move parameters into a struct
        https://bugs.webkit.org/show_bug.cgi?id=77525

        Added 'SelectorCheckingContext' struct to hold parameters for the function.
        Adapted calling sites.

        Reviewed by Antti Koivisto.

        No new tests. (refactoring)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        * css/SelectorChecker.cpp:
        (WebCore::SelectorChecker::checkSelector):
        (WebCore):
        (WebCore::SelectorChecker::checkOneSelector):
        * css/SelectorChecker.h:
        (SelectorCheckingContext):
        (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
        (SelectorChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo not localize numbers in scientific notation
tkent@chromium.org [Thu, 9 Feb 2012 09:33:54 +0000 (09:33 +0000)]
Do not localize numbers in scientific notation
https://bugs.webkit.org/show_bug.cgi?id=78208

Reviewed by Hajime Morita.

.:

* ManualTests/input-number-localization.html: Updated for scientific notation.

Source/WebCore:

For a preparation of fixing http://wkb.ug/62939, we stop supporting
localized numbers in scientific notation in <input type=number>.

We're going to change number localization processing so that it replaces
letters one by one. It will be very hard to support scientific notation.

* html/NumberInputType.cpp:
(WebCore::isE): A helper functio for String::find() to detect scientific notation.
(WebCore::NumberInputType::visibleValue): Avoid localization for scientific notation.
(WebCore::NumberInputType::convertFromVisibleValue): ditto.
(WebCore::NumberInputType::isAcceptableValue):
Use convertFromVisibleValue, also stop accepting a standard format as a fallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agokill-old-processes should kill gcc and clang
rniwa@webkit.org [Thu, 9 Feb 2012 09:18:37 +0000 (09:18 +0000)]
kill-old-processes should kill gcc and clang
https://bugs.webkit.org/show_bug.cgi?id=78189

Reviewed by Eric Seidel.

Added a bunch of processes names of gcc and clang to the list.

* BuildSlaveSupport/kill-old-processes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEntryBase.cpp is missing in CMake build system when turning on ENABLE_FILE_SYSTEM
leo.yang@torchmobile.com.cn [Thu, 9 Feb 2012 09:05:44 +0000 (09:05 +0000)]
EntryBase.cpp is missing in CMake build system when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78190

Reviewed by Antonio Gomes.

EntryBase.cpp is not in the CMake build system, which causes build failure (undefined
symbols to EntryBase) when turning on ENABLE_FILE_SYSTEM.

Build system fix, no new tests.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r53878): Input elements don't share their styles if the document contains...
kling@webkit.org [Thu, 9 Feb 2012 09:03:38 +0000 (09:03 +0000)]
REGRESSION(r53878): Input elements don't share their styles if the document contains no validity style rules.
<http://webkit.org/b/69400>

Reviewed by Kent Tamura.

Don't reject style sharing candidates prematurely just because the document doesn't
have any :valid or :invalid selectors.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test_expectations change.
mikelawther@chromium.org [Thu, 9 Feb 2012 09:03:31 +0000 (09:03 +0000)]
Unreviewed test_expectations change.

[chromium] remove expectation for css3/calc/block-mask-overlay-image-outset.html
https://bugs.webkit.org/show_bug.cgi?id=78183

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Fblock-mask-overlay
shows this test has not failed as far back as its history is recorded.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixed typo in the following files. [TreatUndefinedAs] => [TreatAsUndefined].
haraken@chromium.org [Thu, 9 Feb 2012 08:55:51 +0000 (08:55 +0000)]
Unreviewed. Fixed typo in the following files. [TreatUndefinedAs] => [TreatAsUndefined].

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):

* bindings/scripts/test/TestObj.idl:

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalIsUndefinedString):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_optional_is_undefined_string):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionConvert5):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithOptionalIsUndefinedString:]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithOptionalIsUndefinedStringCallback):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Change lowercase variable with uppercase's.
gyuyoung.kim@samsung.com [Thu, 9 Feb 2012 08:50:46 +0000 (08:50 +0000)]
[CMAKE] Change lowercase variable with uppercase's.
https://bugs.webkit.org/show_bug.cgi?id=78198

Reviewed by Daniel Bates.

CMake variable is only written by uppercase.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixed typo in the following files. [TreatReturnedNullStringTo=] => [Treat...
haraken@chromium.org [Thu, 9 Feb 2012 08:16:25 +0000 (08:16 +0000)]
Unreviewed. Fixed typo in the following files. [TreatReturnedNullStringTo=] => [TreatReturnedNullStringAs=].

* bindings/scripts/test/TestObj.idl:
* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframesRule.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Clipboard.idl:
* dom/DOMStringList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/MutationRecord.idl:
* dom/Node.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/DOMWindow.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* websockets/WebSocket.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathNSResolver.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline.
philn@webkit.org [Thu, 9 Feb 2012 07:58:09 +0000 (07:58 +0000)]
Unreviewed, GTK rebaseline.

* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/gtk/fast/forms/select-overflow-scroll-expected.txt:
* platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt:
* platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a typo for r107125
commit-queue@webkit.org [Thu, 9 Feb 2012 07:52:38 +0000 (07:52 +0000)]
Fix a typo for r107125
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by James Robinson.

* tests/WebCompositorInputHandlerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
haraken@chromium.org [Thu, 9 Feb 2012 07:20:19 +0000 (07:20 +0000)]
Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108

Reviewed by Adam Barth.

[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer):
(NativeToJSValue):

* bindings/scripts/test/TestObj.idl: No change in run-bindings-tests results.

* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframesRule.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Clipboard.idl:
* dom/DOMStringList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/MutationRecord.idl:
* dom/Node.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* page/DOMWindow.idl:
* storage/IDBObjectStore.idl:
* storage/IDBRequest.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* websockets/WebSocket.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathNSResolver.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify ownership of StyledElement::additionalAttributeStyles().
kling@webkit.org [Thu, 9 Feb 2012 07:14:55 +0000 (07:14 +0000)]
Simplify ownership of StyledElement::additionalAttributeStyles().
<http://webkit.org/b/78204>

Reviewed by Anders Carlsson.

Change additionalAttributeStyle() to return a raw pointer rather than a PassRefPtr.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
* dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
* html/HTMLTableCellElement.h:
(HTMLTableCellElement):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
* html/HTMLTableColElement.h:
(HTMLTableColElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
* html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timin...
commit-queue@webkit.org [Thu, 9 Feb 2012 07:14:24 +0000 (07:14 +0000)]
[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
https://bugs.webkit.org/show_bug.cgi?id=78174

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Pulled back removed files.

* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
* Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry...
commit-queue@webkit.org [Thu, 9 Feb 2012 07:02:04 +0000 (07:02 +0000)]
[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=78049

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.h: Added.
* blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107183 268f45cc-cd09-0410-ab3c-d52691b4dbfc