WebKit-https.git
9 months agowebkitpy: Print abbreviated baseline search path that includes only folders that...
jbedard@apple.com [Fri, 11 Jan 2019 22:25:33 +0000 (22:25 +0000)]
webkitpy: Print abbreviated baseline search path that includes only folders that exist
https://bugs.webkit.org/show_bug.cgi?id=193352
<rdar://problem/47210736>

Reviewed by Lucas Forschler.

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_config): Print list on only baseline search paths which exist.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread...
said@apple.com [Fri, 11 Jan 2019 22:01:07 +0000 (22:01 +0000)]
WorkQueue::concurrentApply() passes a raw pointer to a temporary String to Thread::create().
https://bugs.webkit.org/show_bug.cgi?id=191350

Reviewed by Brent Fulgham.

The non COCOA version of WorkQueue::concurrentApply() creates a temporary
String for the threadName and passes the raw pointer of this String to
Thread::create(). After freeing this String, Thread::entryPoint() uses
the raw char pointer to internally initialize the thread.

The fix is to use a single literal string for all the threads' names since
they are created for a thread-pool.

* wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix an assertion in UniqueIDBDatabase
sihui_liu@apple.com [Fri, 11 Jan 2019 21:57:46 +0000 (21:57 +0000)]
Fix an assertion in UniqueIDBDatabase
https://bugs.webkit.org/show_bug.cgi?id=193096

Reviewed by Brady Eidson.

m_objectStoreTransactionCounts.count(objectStore) == 1 in UniqueIDBDatabase::operationAndTransactionTimerFired()
is not necessarily true because m_objectStoreTransactionCounts may be cleared in immediateCloseForUserDelete.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoCleanup possible WK*Copy/Create leaks in WebKitTestRunner
commit-queue@webkit.org [Fri, 11 Jan 2019 21:04:09 +0000 (21:04 +0000)]
Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=193340

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-01-11
Reviewed by David Kilzer.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
Pull the strings out into a WKRetainPtr.

* WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::closeWebNotification):
Adopt the created value into the WKRetainPtr.

* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::generateWhitelist):
Immediately adopt a created value to avoid potential mistakes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: REGRESSION: deleting an audit puts selection in a selected but invisib...
mattbaker@apple.com [Fri, 11 Jan 2019 21:02:28 +0000 (21:02 +0000)]
Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state
https://bugs.webkit.org/show_bug.cgi?id=192917
<rdar://problem/46875285>

Reviewed by Devin Rousso.

SelectionController should not be notified of removed children until the
child items have been removed from the TreeOutline. Doing so at this stage
is unsafe, since this method checks `this.selectedTreeElement`, which could
return the adjusted index from the SelectionController before anything has
actually been removed from the TreeOutline.

The number of calls to SelectionController.prototype.didRemoveItems is also
reduced somewhat, since we're no longer calling it for every TreeElement.

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.removeChildAtIndex):
(WI.TreeOutline.prototype.removeChildren):
(WI.TreeOutline.prototype._forgetTreeElement):
(WI.TreeOutline.prototype._indexesForSubtree): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[GTK] Garbled rendering on Youtube while scrolling under X11.
magomez@igalia.com [Fri, 11 Jan 2019 21:01:47 +0000 (21:01 +0000)]
[GTK] Garbled rendering on Youtube while scrolling under X11.
https://bugs.webkit.org/show_bug.cgi?id=192982

Reviewed by Carlos Garcia Campos.

When creating a GLX window context, try to get a GLXFBConfig that has depth and stencil buffers for
the default framebuffer.

* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::compatibleVisuals):
(WebCore::GLContextGLX::createWindowContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoEnable DFG on ARM/Linux again
dinfuehr@igalia.com [Fri, 11 Jan 2019 20:41:42 +0000 (20:41 +0000)]
Enable DFG on ARM/Linux again
https://bugs.webkit.org/show_bug.cgi?id=192496

Reviewed by Yusuke Suzuki.

JSTests:

Test wasn't really skipped before moving the line with skip
to the top.

* stress/regress-192717.js:

Source/JavaScriptCore:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Do not use register
r11 in compiled DFG mode since it is already used in LLInt as metadataTable
register. Also clean up code since ARM traditional isn't supported anymore.

* dfg/DFGOSRExit.cpp:
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
* jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::CallFrameShuffler):
* jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
* llint/LowLevelInterpreter32_64.asm:
* offlineasm/arm.rb:

Source/WTF:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux.

* wtf/Platform.h:

Tools:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
on ARM by default.

* Scripts/run-jsc-stress-tests:

LayoutTests:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Disable tests that
run out of executable memory with LLInt disabled.

* js/script-tests/dfg-float32array.js:
* js/script-tests/dfg-float64array.js:
* js/script-tests/dfg-int16array.js:
* js/script-tests/dfg-int32array-overflow-values.js:
* js/script-tests/dfg-int32array.js:
* js/script-tests/dfg-int8array.js:
* js/script-tests/dfg-uint16array.js:
* js/script-tests/dfg-uint32array.js:
* js/script-tests/dfg-uint8array.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, fix #ifdef in API test added in r239851.
timothy@apple.com [Fri, 11 Jan 2019 20:37:48 +0000 (20:37 +0000)]
Unreviewed, fix #ifdef in API test added in r239851.
https://bugs.webkit.org/show_bug.cgi?id=193327
rdar://problem/47093222

* TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoIndexedDB: leak IDBTransaction, TransactionOperation and IDBRequest in layout tests
sihui_liu@apple.com [Fri, 11 Jan 2019 20:21:08 +0000 (20:21 +0000)]
IndexedDB: leak IDBTransaction, TransactionOperation and IDBRequest in layout tests
https://bugs.webkit.org/show_bug.cgi?id=193167
<rdar://problem/46891688>

Reviewed by Geoffrey Garen.

Do some cleanup to break retain cycle when context is stopped.

* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::cancelForStop):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::abortOnServerAndCancelRequests):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::removeRequest):
* Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::doComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoIntroduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
wenson_hsieh@apple.com [Fri, 11 Jan 2019 18:28:06 +0000 (18:28 +0000)]
Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=193109
<rdar://problem/44807048>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds new IDL files and stubs for UndoManager and UndoItem. This is an experimental DOM API that (in the near
future) is intended only for use in internal WebKit text editing clients. This API allows the page to
participate in the processes of undoing and redoing by defining custom undo and redo handlers, to be executed
when undo or redo is triggered.

Tests: editing/undo-manager/undo-manager-interfaces.html
       editing/undo-manager/undo-manager-keeps-wrapper-alive.html

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Sources.txt:
* UnifiedSources-input.xcfilelist:
* WebCore.xcodeproj/project.pbxproj:

Add new source files.

* bindings/js/WebCoreBuiltinNames.h:

Add "UndoManager" and "UndoItem" names.

* dom/Document.cpp:
(WebCore::m_undoManager):

Have the document own a UndoManager.

* dom/Document.h:
(WebCore::Document::undoManager const):
* dom/Document.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setUndoManagerAPIEnabled):
(WebCore::RuntimeEnabledFeatures::undoManagerAPIEnabled const):

Guard the new bindings behind a runtime-enabled feature flag.

* page/UndoItem.h: Added.
(WebCore::UndoItem::create):
(WebCore::UndoItem::label const):
(WebCore::UndoItem::undoHandler const):
(WebCore::UndoItem::redoHandler const):
(WebCore::UndoItem::UndoItem):
* page/UndoItem.idl: Added.
* page/UndoManager.cpp: Added.
(WebCore::UndoManager::addItem):
* page/UndoManager.h: Added.
(WebCore::UndoManager::create):
(WebCore::UndoManager::document):
(WebCore::UndoManager::UndoManager):
* page/UndoManager.idl: Added.
* page/mac/WheelEventDeltaFilterMac.h:

Necessary (albeit unrelated) build fix to appease unified sources.

Source/WebKit:

Add a new SPI configuration flag to enable the UndoManager API. This is off by default.

* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setUndoManagerAPIEnabled:]):
(-[WKWebViewConfiguration _undoManagerAPIEnabled]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Tools:

Introduce and respect a test option to enable the UndoManager API.

* WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):

LayoutTests:

Add UndoManager tests to exercise new bindings, and verify that the JS wrapper for Document's UndoManager
survives garbage collection.

* TestExpectations:
* editing/undo-manager/undo-manager-interfaces-expected.txt: Added.
* editing/undo-manager/undo-manager-interfaces.html: Added.
* editing/undo-manager/undo-manager-keeps-wrapper-alive-expected.txt: Added.
* editing/undo-manager/undo-manager-keeps-wrapper-alive.html: Added.
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
zalan@apple.com [Fri, 11 Jan 2019 16:19:41 +0000 (16:19 +0000)]
[LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
https://bugs.webkit.org/show_bug.cgi?id=193346

Reviewed by Antti Koivisto.

Source/WebCore:

If the top and bottom margins of a box are adjoining, then it is possible for margins to collapse through it.
In this case, the position of the element depends on its relationship with the other elements whose margins are being collapsed.

1. If the element's margins are collapsed with its parent's top margin, the top border edge of the box is defined to be the same as the parent's.
2. Otherwise, either the element's parent is not taking part in the margin collapsing, or only the parent's bottom margin is involved.
   The position of the element's top border edge is the same as it would have been if the element had a non-zero bottom border.

Test: fast/block/block-only/collapsed-through-with-parent.html

* layout/MarginTypes.h:
(WebCore::Layout::EstimatedMarginBefore::usedValue const):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):
* layout/blockformatting/BlockFormattingContext.h:
* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeIgnoringCollapsingThrough):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/block-only/collapsed-through-with-parent-expected.txt: Added.
* fast/block/block-only/collapsed-through-with-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed GTK gardening. Rebaseline several tests after r239822.
carlosgc@webkit.org [Fri, 11 Jan 2019 13:17:29 +0000 (13:17 +0000)]
Unreviewed GTK gardening. Rebaseline several tests after r239822.

* platform/gtk/css2.1/t1202-counter-04-b-expected.png:
* platform/gtk/css2.1/t1202-counter-04-b-expected.txt:
* platform/gtk/css2.1/t1202-counters-04-b-expected.png:
* platform/gtk/css2.1/t1202-counters-04-b-expected.txt:
* platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:
* platform/gtk/fast/text/fallback-traits-fixup-expected.png:
* platform/gtk/fast/text/fallback-traits-fixup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WHLSL] Include the standard library
mmaxfield@apple.com [Fri, 11 Jan 2019 07:47:07 +0000 (07:47 +0000)]
[WHLSL] Include the standard library
https://bugs.webkit.org/show_bug.cgi?id=192994

Reviewed by Jon Lee.

A small section of the standard library is present in WHLSLStandardLibrary.txt. This gets turned into a header file containing
its raw data at build time by invoking our xxd.pl script (which WebCore already uses for other purposes). The standard
library is generated by running a JavaScript script, but currently there is no way to invoke JavaScript from our build
process, so this patch includes in the standard library's raw text instead. Once the parser is faster, we can include the
entire standard library.

No new tests because it isn't hooked up yet.

* DerivedSources.make:
* Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt: Added.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, fix typo that breaks dashboard link.
ryanhaddad@apple.com [Fri, 11 Jan 2019 06:23:47 +0000 (06:23 +0000)]
Unreviewed, fix typo that breaks dashboard link.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUpdate macOS queue configurations
ryanhaddad@apple.com [Fri, 11 Jan 2019 06:07:26 +0000 (06:07 +0000)]
Update macOS queue configurations
https://bugs.webkit.org/show_bug.cgi?id=193329

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Audit: allow audits to be enabled/disabled
drousso@apple.com [Fri, 11 Jan 2019 05:54:54 +0000 (05:54 +0000)]
Web Inspector: Audit: allow audits to be enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=192210
<rdar://problem/46423583>

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.get editing): Added.
(WI.AuditManager.prototype.set editing): Added.
(WI.AuditManager.prototype.stop):
(WI.AuditManager.prototype.addDefaultTestsIfNeeded):
Since default audits aren't stored, keep a list of disabled default tests in a `WI.Setting`.

* UserInterface/Models/AuditTestBase.js:
(WI.AuditTestBase):
(WI.AuditTestBase.prototype.get disabled): Added.
(WI.AuditTestBase.prototype.set disabled): Added.
(WI.AuditTestBase.prototype.async start):
(WI.AuditTestBase.prototype.stop):
(WI.AuditTestBase.toJSON):

* UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase):
(WI.AuditTestCase.async fromPayload):
(WI.AuditTestCase.prototype.toJSON):

* UserInterface/Models/AuditTestGroup.js:
(WI.AuditTestGroup):
(WI.AuditTestGroup.async fromPayload):
(WI.AuditTestGroup.prototype.get disabled): Added.
(WI.AuditTestGroup.prototype.set disabled): Added.
(WI.AuditTestGroup.prototype.toJSON):
(WI.AuditTestGroup.prototype.async run):
(WI.AuditTestGroup.prototype._handleTestDisabledChanged): Added.
(WI.AuditTestGroup.prototype._handleTestProgress):
Propagate `disabled` changes to all sub-tests, unless the change was caused by one of the
sub-tests, in which case we are now in an intermediate state.

* UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel):
(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype.hasCustomFilters): Added.
(WI.AuditNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters): Added.
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype._updateStartStopButtonNavigationItemState):
(WI.AuditNavigationSidebarPanel.prototype._updateEditButtonNavigationItemState): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditManagerEditingChanged): Added.
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestScheduled):
(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
(WI.AuditNavigationSidebarPanel.prototype._handleEditButtonNavigationItemClicked): Added.
* UserInterface/Views/AuditNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.audit > .content):
(.sidebar > .panel.navigation.audit > .content > .tree-outline): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled):active): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits:not(.disabled).activated:active): Added.
(.sidebar > .panel.navigation.audit > .content .edit-audits.disabled): Added.
(.finish-editing-audits-placeholder.message-text-view .navigation-item-help .navigation-bar): Added.
Leverage custom filters to ensure that disabled audits arent shown when not editing and that
result tree elements aren't shown while editing.

* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.shown):

* UserInterface/Views/AuditTreeElement.js:
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.canSelectOnMouseDown): Added.
(WI.AuditTreeElement.prototype._updateTestGroupDisabled): Added.
(WI.AuditTreeElement.prototype._handleTestDisabledChanged): Added.
(WI.AuditTreeElement.prototype._handleManagerEditingChanged): Added.
* UserInterface/Views/AuditTreeElement.css:
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits) > .status:not(:hover)): Added.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded:not(.editing-audits) > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Added.
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:not(:hover)): Deleted.
(.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Deleted.
Prevent selection and running when editing.

* UserInterface/Views/TreeOutline.css:
(.tree-outline .children.expanded:not([hidden])): Added.
(.tree-outline .children.expanded): Deleted.

* UserInterface/Base/ObjectStore.js:
(WI.ObjectStore._open):
Batch operations together to help avoid multiple simultaneous `indexedDB.open` calls. This
should also help preserve the order of operations, as once the database is open, operations
are executed in the order they were enqueued.

(WI.ObjectStore.prototype.async.addObject):
Pass a unique `Symbol` to the `toJSON` call on the given object so that the object can save
additional values that wouldn't normally be saved. This doesn't conflict with normal usage
of `toJSON` (e.g. `JSON.stringify`) because that case also passes in a value:
 - `undefined`, if it was called directly on the object
 - the key for this object in the containing object
 - the index of this object in the containing array
In any case, the value can never equal the unique `Symbol`, so it's guaranteed that the code
will only run for `WI.ObjectStore` operations.

(WI.ObjectStore.prototype.async.clear): Added.

* Localizations/en.lproj/localizedStrings.js:

LayoutTests:

* inspector/unit-tests/objectStore/clear.html: Added.
* inspector/unit-tests/objectStore/clear-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago<video> elements do not enter 'paused' state when playing to end over AirPlay
jer.noble@apple.com [Fri, 11 Jan 2019 04:46:23 +0000 (04:46 +0000)]
<video> elements do not enter 'paused' state when playing to end over AirPlay
https://bugs.webkit.org/show_bug.cgi?id=193295
<rdar://problem/46708670>

Reviewed by Eric Carlson.

Adopt the -[AVPlayer timeControlStatus] API, which reports whether the AVPlayer is paused, playing, or blocked waiting
for more data before playing. AirPlay devices report this state back from the remote device, and this allows the
MediaPlayerPrivateAVFoundationObjC to differentiate between user-generated pauses and simple stalling.

Adopting this API allows us to remove the heuristic from rateChanged() which inteprets a rate change when the
readyState > HAVE_ENOUGH as an intentional pause.

Drive-by fix: MediaPlayerPrivateAVFoundation had some code to delay calling platformPlay()
until the first frame became available. But this code was entirely undermined by the previous
behavior of setRate(). Fixing setRate()/setRateDouble() to only start playback if playback was
actually requested started making this code work for the first time, and broke some API tests.
Thus, we're removing this previously dead code.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::play):
(WebCore::MediaPlayerPrivateAVFoundation::pause):
(WebCore::MediaPlayerPrivateAVFoundation::rateChanged):
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didEnd):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setRateDouble):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldObserveTimeControlStatus):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMiniBrowser should be able to navigate to about:blank
commit-queue@webkit.org [Fri, 11 Jan 2019 04:39:23 +0000 (04:39 +0000)]
MiniBrowser should be able to navigate to about:blank
https://bugs.webkit.org/show_bug.cgi?id=193345

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-01-10
Reviewed by Simon Fraser.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController addProtocolIfNecessary:]):
Don't prepend "http://" to "about:" prefixed URLs like "about:blank".

* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController fetch:]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController fetch:]):
Clean up the code that uses this to match style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRemove MiniBrowser custom "Process Swap" menu item which does not work
commit-queue@webkit.org [Fri, 11 Jan 2019 04:38:04 +0000 (04:38 +0000)]
Remove MiniBrowser custom "Process Swap" menu item which does not work
https://bugs.webkit.org/show_bug.cgi?id=193344

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-01-10
Reviewed by Simon Fraser.

There is a menu item under the Experimental menu that does work.

* MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController processSwapOnNavigationEnabled]): Deleted.
(-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix the build after r239844
mmaxfield@apple.com [Fri, 11 Jan 2019 03:54:43 +0000 (03:54 +0000)]
Fix the build after r239844
https://bugs.webkit.org/show_bug.cgi?id=192991

Unreviewed.

* Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableForShaderItemDirection const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WebGPU] WebGPUBindGroup and device::createBindGroup prototype
justin_fan@apple.com [Fri, 11 Jan 2019 02:12:57 +0000 (02:12 +0000)]
[WebGPU] WebGPUBindGroup and device::createBindGroup prototype
https://bugs.webkit.org/show_bug.cgi?id=193341

Reviewed by Myles C. Maxfield.

Source/WebCore:

Add *GPUBindGroup class stubs and the ability to create WebGPUBindGroups via the API.

Test: bind-groups.html

* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:

* Modules/webgpu/WebGPUBindGroup.cpp:
(WebCore::WebGPUBindGroup::create):
(WebCore::WebGPUBindGroup::WebGPUBindGroup):
* Modules/webgpu/WebGPUBindGroup.h:
* Modules/webgpu/WebGPUBindGroup.idl: Enable createBindGroup().
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::BindingResourceVisitor::operator() const): Added. Validate and convert WebGPUBindGroupDescriptor to GPU* version.
(WebCore::WebGPUDevice::createBindGroup const): Added.
* Modules/webgpu/WebGPUDevice.h:
* platform/graphics/gpu/GPUBindGroup.cpp:
(WebCore::GPUBindGroup::create):
(WebCore::GPUBindGroup::GPUBindGroup):
* platform/graphics/gpu/GPUBindGroup.h:
* platform/graphics/gpu/GPUBufferBinding.h:
* platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
(WebCore::appendArgumentToArray): Pass RetainPtr by reference to actually update descriptor.

LayoutTests:

Small test that creates a WebGPUBindGroup.

* webgpu/bind-groups-expected.txt: Added.
* webgpu/bind-groups.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WebAuthN] Change the nonce in the CTAP kInit command to weak random values
jiewen_tan@apple.com [Fri, 11 Jan 2019 01:42:34 +0000 (01:42 +0000)]
[WebAuthN] Change the nonce in the CTAP kInit command to weak random values
https://bugs.webkit.org/show_bug.cgi?id=192061
<rdar://problem/46471091>

Reviewed by Chris Dumez.

Change the nonce in the CTAP kInit command to weak random values as the nonce is mainly
for being a probabilistically unique global identifier for hand shakes, instead of
preventing replay attacks. Otherwise, it might exhaust system entropy unnecessarily.

The patch also removes all logging when debugging the test case flakiness.

* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):
* UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::deviceAdded):
* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
(WebKit::MockAuthenticatorManager::respondReceivedInternal):
* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::send):
* UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:
(WebKit::CtapHidAuthenticator::makeCredential):
(WebKit::CtapHidAuthenticator::getAssertion):
* UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
(WebKit::CtapHidDriver::Worker::write):
(WebKit::CtapHidDriver::Worker::read):
(WebKit::CtapHidDriver::Worker::returnMessage):
(WebKit::CtapHidDriver::transact):
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
(WebKit::CtapHidDriver::continueAfterResponseReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoAdd WKBundlePage SPI to temporarily force light or dark appearance on a page.
timothy@apple.com [Fri, 11 Jan 2019 01:11:57 +0000 (01:11 +0000)]
Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
https://bugs.webkit.org/show_bug.cgi?id=193327
rdar://problem/47093222

Reviewed by Tim Horton.

Source/WebKit:

Tests: WebKit.ForceLightAppearanceInBundle API Test

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetUseDarkAppearance): Added.
(WKBundlePageIsUsingDarkAppearance): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
(TestWebKitAPI::didFinishNavigation):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
(TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
(TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
(TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
* TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoDeviceID hash salt manager can be NULL
eric.carlson@apple.com [Fri, 11 Jan 2019 00:49:23 +0000 (00:49 +0000)]
DeviceID hash salt manager can be NULL
https://bugs.webkit.org/show_bug.cgi?id=193334
<rdar://problem/47179650>

Reviewed by Youenn Fablet.

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): No need to
NULL-check websiteDataStore.deviceIdHashSaltStorage, it is a Ref.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore): m_deviceIdHashSaltStorage is a Ref.
(WebKit::WebsiteDataStore::fetchDataAndApply): Ditto.
(WebKit::WebsiteDataStore::removeData): Ditto.
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::deviceIdHashSaltStorage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoLeak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent...
commit-queue@webkit.org [Thu, 10 Jan 2019 23:03:47 +0000 (23:03 +0000)]
Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
https://bugs.webkit.org/show_bug.cgi?id=193338
<rdar://problem/46664774>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-01-10
Reviewed by David Kilzer.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix rare crash under ScrollbarThemeMac::paintScrollCorner()
simon.fraser@apple.com [Thu, 10 Jan 2019 22:50:13 +0000 (22:50 +0000)]
Fix rare crash under ScrollbarThemeMac::paintScrollCorner()
https://bugs.webkit.org/show_bug.cgi?id=193337
rdar://problem/47179993

Reviewed by Zalan Bujtas.

Async image decoding can trigger a FrameView::traverseForPaintInvalidation() fake paint,
which creates a GraphicsContext with no platform context. However, we could hit ScrollView::paintScrollbars()
which tried to get at the platform context, and then crashed.

So protect two functions in ScrollbarThemeMac with if (context.paintingDisabled()) checks. I verified
that other scrollbar-related painting code paths were already protected.

Hard to test because it depends on async image decoding timing.

* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
(WebCore::ScrollbarThemeMac::paintScrollCorner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: incorrect type signature used for protocol enums in async command...
bburg@apple.com [Thu, 10 Jan 2019 22:36:56 +0000 (22:36 +0000)]
Web Inspector: incorrect type signature used for protocol enums in async command results
https://bugs.webkit.org/show_bug.cgi?id=193331

Reviewed by Devin Rousso.

When an enum is returned by an async command, the type signature should be that of the
Inspector::Protocol::* generated enum, rather than the underlying primitive type (i.e., String).

* inspector/scripts/codegen/cpp_generator.py:
(CppGenerator.cpp_type_for_formal_async_parameter):
* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
Rebaseline generator test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[macOS] Add name of IORegistry key in sandbox.
pvollan@apple.com [Thu, 10 Jan 2019 22:31:10 +0000 (22:31 +0000)]
[macOS] Add name of IORegistry key in sandbox.
https://bugs.webkit.org/show_bug.cgi?id=193335
<rdar://problem/47184951>

Reviewed by Alexey Proskuryakov.

The property IOGVAHEVCDecodeCapabilities was added in https://bugs.webkit.org/show_bug.cgi?id=193324.
Also, the property IOGVAHEVCEncodeCapabilities needs to be added.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WHLSL] Implement parser AST nodes
mmaxfield@apple.com [Thu, 10 Jan 2019 22:17:58 +0000 (22:17 +0000)]
[WHLSL] Implement parser AST nodes
https://bugs.webkit.org/show_bug.cgi?id=192991

Reviewed by Alex Christensen.

This patch creates all the AST nodes which will be the result of running the parser.
This patch used to be a part of the "create a WHLSL parser" patch but I split them
out in order to aid reviewing.

The classes were mechanically created to match the result of the parser. There are
nodes for things like ForLoops, LogicalNotExpressions, DereferenceExpressions,
StructureDefinitions, and things like that. The classes don't actually have any logic
in them - they are currently just containers to hold the structure of the parsed
program. Some of these nodes (like constexprs) are just Variants of the various things
they can in the form of.

No new tests because the parser doesn't exist to create the new AST nodes yet.

* Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h: Added.
(WebCore::WHLSL::AST::ArrayReferenceType::ArrayReferenceType):
* Modules/webgpu/WHLSL/AST/WHLSLArrayType.h: Added.
(WebCore::WHLSL::AST::ArrayType::ArrayType):
(WebCore::WHLSL::AST::ArrayType::type const):
(WebCore::WHLSL::AST::ArrayType::type):
(WebCore::WHLSL::AST::ArrayType::numElements const):
* Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h: Added.
(WebCore::WHLSL::AST::AssignmentExpression::AssignmentExpression):
(WebCore::WHLSL::AST::AssignmentExpression::left):
(WebCore::WHLSL::AST::AssignmentExpression::right):
* Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h: Added.
(WebCore::WHLSL::AST::BaseFunctionAttribute::BaseFunctionAttribute):
* Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h: Added.
(WebCore::WHLSL::AST::BaseSemantic::BaseSemantic):
* Modules/webgpu/WHLSL/AST/WHLSLBlock.h: Added.
(WebCore::WHLSL::AST::Block::Block):
(WebCore::WHLSL::AST::Block::statements):
* Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h: Added.
(WebCore::WHLSL::AST::BooleanLiteral::BooleanLiteral):
(WebCore::WHLSL::AST::BooleanLiteral::value const):
(WebCore::WHLSL::AST::BooleanLiteral::clone const):
* Modules/webgpu/WHLSL/AST/WHLSLBreak.h: Added.
(WebCore::WHLSL::AST::Break::Break):
* Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp: Added.
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::BuiltInSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h: Added.
(WebCore::WHLSL::AST::BuiltInSemantic::BuiltInSemantic):
(WebCore::WHLSL::AST::BuiltInSemantic::variable const):
(WebCore::WHLSL::AST::BuiltInSemantic::operator== const):
(WebCore::WHLSL::AST::BuiltInSemantic::operator!= const):
* Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h: Added.
(WebCore::WHLSL::AST::CallExpression::CallExpression):
(WebCore::WHLSL::AST::CallExpression::arguments):
(WebCore::WHLSL::AST::CallExpression::name):
(WebCore::WHLSL::AST::CallExpression::setCastData):
(WebCore::WHLSL::AST::CallExpression::isCast):
(WebCore::WHLSL::AST::CallExpression::castReturnType):
(WebCore::WHLSL::AST::CallExpression::hasOverloads const):
(WebCore::WHLSL::AST::CallExpression::overloads):
(WebCore::WHLSL::AST::CallExpression::setOverloads):
(WebCore::WHLSL::AST::CallExpression::setFunction):
* Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h: Added.
(WebCore::WHLSL::AST::CommaExpression::CommaExpression):
(WebCore::WHLSL::AST::CommaExpression::list):
* Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h: Added.
(WebCore::WHLSL::AST::ConstantExpression::ConstantExpression):
(WebCore::WHLSL::AST::ConstantExpression::integerLiteral):
(WebCore::WHLSL::AST::ConstantExpression::visit):
(WebCore::WHLSL::AST::ConstantExpression::visit const):
(WebCore::WHLSL::AST::ConstantExpression::clone const):
(WebCore::WHLSL::AST::ConstantExpression::matches const):
* Modules/webgpu/WHLSL/AST/WHLSLConstantExpressionEnumerationMemberReference.h: Added.
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::ConstantExpressionEnumerationMemberReference):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::left const):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::right const):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::clone const):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::enumerationDefinition):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::enumerationDefinition const):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::enumerationMember):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::enumerationMember const):
(WebCore::WHLSL::AST::ConstantExpressionEnumerationMemberReference::setEnumerationMember):
* Modules/webgpu/WHLSL/AST/WHLSLContinue.h: Added.
(WebCore::WHLSL::AST::Continue::Continue):
* Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h: Added.
(WebCore::WHLSL::AST::DereferenceExpression::DereferenceExpression):
(WebCore::WHLSL::AST::DereferenceExpression::pointer):
* Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h: Added.
(WebCore::WHLSL::AST::DoWhileLoop::DoWhileLoop):
(WebCore::WHLSL::AST::DoWhileLoop::body):
(WebCore::WHLSL::AST::DoWhileLoop::conditional):
* Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h: Added.
(WebCore::WHLSL::AST::DotExpression::DotExpression):
(WebCore::WHLSL::AST::DotExpression::fieldName):
* Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h: Added.
(WebCore::WHLSL::AST::EffectfulExpressionStatement::EffectfulExpressionStatement):
(WebCore::WHLSL::AST::EffectfulExpressionStatement::effectfulExpression):
* Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h: Added.
(WebCore::WHLSL::AST::EnumerationDefinition::EnumerationDefinition):
(WebCore::WHLSL::AST::EnumerationDefinition::type):
(WebCore::WHLSL::AST::EnumerationDefinition::add):
(WebCore::WHLSL::AST::EnumerationDefinition::memberByName):
(WebCore::WHLSL::AST::EnumerationDefinition::enumerationMembers):
* Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h: Added.
(WebCore::WHLSL::AST::EnumerationMember::EnumerationMember):
(WebCore::WHLSL::AST::EnumerationMember::origin const):
(WebCore::WHLSL::AST::EnumerationMember::name):
(WebCore::WHLSL::AST::EnumerationMember::value):
(WebCore::WHLSL::AST::EnumerationMember::setValue):
* Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h: Added.
(WebCore::WHLSL::AST::EnumerationMemberLiteral::EnumerationMemberLiteral):
(WebCore::WHLSL::AST::EnumerationMemberLiteral::enumerationMember):
* Modules/webgpu/WHLSL/AST/WHLSLExpression.h: Added.
(WebCore::WHLSL::AST::Expression::Expression):
(WebCore::WHLSL::AST::Expression::origin const):
(WebCore::WHLSL::AST::Expression::isAssignmentExpression const):
(WebCore::WHLSL::AST::Expression::isBooleanLiteral const):
(WebCore::WHLSL::AST::Expression::isCallExpression const):
(WebCore::WHLSL::AST::Expression::isCommaExpression const):
(WebCore::WHLSL::AST::Expression::isDereferenceExpression const):
(WebCore::WHLSL::AST::Expression::isDotExpression const):
(WebCore::WHLSL::AST::Expression::isFloatLiteral const):
(WebCore::WHLSL::AST::Expression::isIndexExpression const):
(WebCore::WHLSL::AST::Expression::isIntegerLiteral const):
(WebCore::WHLSL::AST::Expression::isLogicalExpression const):
(WebCore::WHLSL::AST::Expression::isLogicalNotExpression const):
(WebCore::WHLSL::AST::Expression::isMakeArrayReferenceExpression const):
(WebCore::WHLSL::AST::Expression::isMakePointerExpression const):
(WebCore::WHLSL::AST::Expression::isNullLiteral const):
(WebCore::WHLSL::AST::Expression::isPropertyAccessExpression const):
(WebCore::WHLSL::AST::Expression::isReadModifyWriteExpression const):
(WebCore::WHLSL::AST::Expression::isTernaryExpression const):
(WebCore::WHLSL::AST::Expression::isUnsignedIntegerLiteral const):
(WebCore::WHLSL::AST::Expression::isVariableReference const):
(WebCore::WHLSL::AST::Expression::isEnumerationMemberLiteral const):
* Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h: Added.
(WebCore::WHLSL::AST::Fallthrough::Fallthrough):
* Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h: Added.
(WebCore::WHLSL::AST::FloatLiteral::FloatLiteral):
(WebCore::WHLSL::AST::FloatLiteral::type):
(WebCore::WHLSL::AST::FloatLiteral::value const):
(WebCore::WHLSL::AST::FloatLiteral::clone const):
* Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp: Added.
(WebCore::WHLSL::AST::FloatLiteralType::FloatLiteralType):
(WebCore::WHLSL::AST::FloatLiteralType::canResolve const):
(WebCore::WHLSL::AST::FloatLiteralType::conversionCost const):
* Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h: Added.
(WebCore::WHLSL::AST::FloatLiteralType::preferredType):
* Modules/webgpu/WHLSL/AST/WHLSLForLoop.h: Added.
(WebCore::WHLSL::AST::ForLoop::ForLoop):
(WebCore::WHLSL::AST::ForLoop::~ForLoop):
(WebCore::WHLSL::AST::ForLoop::initialization):
(WebCore::WHLSL::AST::ForLoop::condition):
(WebCore::WHLSL::AST::ForLoop::increment):
(WebCore::WHLSL::AST::ForLoop::body):
* Modules/webgpu/WHLSL/AST/WHLSLFunctionAttribute.h: Added.
* Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h: Added.
(WebCore::WHLSL::AST::FunctionDeclaration::FunctionDeclaration):
(WebCore::WHLSL::AST::FunctionDeclaration::isFunctionDefinition const):
(WebCore::WHLSL::AST::FunctionDeclaration::isNativeFunctionDeclaration const):
(WebCore::WHLSL::AST::FunctionDeclaration::attributeBlock):
(WebCore::WHLSL::AST::FunctionDeclaration::entryPointType const):
(WebCore::WHLSL::AST::FunctionDeclaration::type const):
(WebCore::WHLSL::AST::FunctionDeclaration::type):
(WebCore::WHLSL::AST::FunctionDeclaration::name const):
(WebCore::WHLSL::AST::FunctionDeclaration::isCast const):
(WebCore::WHLSL::AST::FunctionDeclaration::parameters const):
(WebCore::WHLSL::AST::FunctionDeclaration::parameters):
(WebCore::WHLSL::AST::FunctionDeclaration::semantic):
(WebCore::WHLSL::AST::FunctionDeclaration::isOperator const):
* Modules/webgpu/WHLSL/AST/WHLSLFunctionDefinition.h: Added.
(WebCore::WHLSL::AST::FunctionDefinition::FunctionDefinition):
(WebCore::WHLSL::AST::FunctionDefinition::block):
(WebCore::WHLSL::AST::FunctionDefinition::restricted const):
* Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h: Added.
(WebCore::WHLSL::AST::IfStatement::IfStatement):
(WebCore::WHLSL::AST::IfStatement::conditional):
(WebCore::WHLSL::AST::IfStatement::body):
(WebCore::WHLSL::AST::IfStatement::elseBody):
* Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h: Added.
(WebCore::WHLSL::AST::IndexExpression::IndexExpression):
(WebCore::WHLSL::AST::IndexExpression::indexExpression):
* Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.cpp: Added.
(WebCore::WHLSL::AST::IntegerLiteral::valueForSelectedType const):
* Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h: Added.
(WebCore::WHLSL::AST::IntegerLiteral::IntegerLiteral):
(WebCore::WHLSL::AST::IntegerLiteral::type):
(WebCore::WHLSL::AST::IntegerLiteral::value const):
(WebCore::WHLSL::AST::IntegerLiteral::clone const):
* Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp: Added.
(WebCore::WHLSL::AST::IntegerLiteralType::IntegerLiteralType):
(WebCore::WHLSL::AST::IntegerLiteralType::canResolve const):
(WebCore::WHLSL::AST::IntegerLiteralType::conversionCost const):
* Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h: Added.
(WebCore::WHLSL::AST::IntegerLiteralType::preferredType):
* Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h: Added.
(WebCore::WHLSL::AST::LogicalExpression::LogicalExpression):
(WebCore::WHLSL::AST::LogicalExpression::type const):
(WebCore::WHLSL::AST::LogicalExpression::left):
(WebCore::WHLSL::AST::LogicalExpression::right):
* Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h: Added.
(WebCore::WHLSL::AST::LogicalNotExpression::LogicalNotExpression):
(WebCore::WHLSL::AST::LogicalNotExpression::operand):
* Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h: Added.
(WebCore::WHLSL::AST::MakeArrayReferenceExpression::MakeArrayReferenceExpression):
(WebCore::WHLSL::AST::MakeArrayReferenceExpression::lValue):
* Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h: Added.
(WebCore::WHLSL::AST::MakePointerExpression::MakePointerExpression):
(WebCore::WHLSL::AST::MakePointerExpression::lValue):
* Modules/webgpu/WHLSL/AST/WHLSLNamedType.h: Added.
(WebCore::WHLSL::AST::NamedType::NamedType):
(WebCore::WHLSL::AST::NamedType::origin const):
(WebCore::WHLSL::AST::NamedType::name):
(WebCore::WHLSL::AST::NamedType::isTypeDefinition const):
(WebCore::WHLSL::AST::NamedType::isStructureDefinition const):
(WebCore::WHLSL::AST::NamedType::isEnumerationDefinition const):
(WebCore::WHLSL::AST::NamedType::isNativeTypeDeclaration const):
(WebCore::WHLSL::AST::NamedType::unifyNode const):
(WebCore::WHLSL::AST::NamedType::unifyNode):
* Modules/webgpu/WHLSL/AST/WHLSLNativeFunctionDeclaration.h: Added.
(WebCore::WHLSL::AST::NativeFunctionDeclaration::NativeFunctionDeclaration):
(WebCore::WHLSL::AST::NativeFunctionDeclaration::restricted const):
* Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h: Added.
(WebCore::WHLSL::AST::NativeTypeDeclaration::NativeTypeDeclaration):
(WebCore::WHLSL::AST::NativeTypeDeclaration::name const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::name):
(WebCore::WHLSL::AST::NativeTypeDeclaration::typeArguments):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isInt const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isNumber const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isFloating const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isVector const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isMatrix const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isTexture const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::isSigned const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::std::function<bool const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::std::function<int64_t const):
(WebCore::WHLSL::AST::NativeTypeDeclaration::iterateAllValues):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsInt):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsNumber):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsFloating):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsVector):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsMatrix):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsTexture):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIsSigned):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setCanRepresentInteger):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setCanRepresentUnsignedInteger):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setCanRepresentFloat):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setSuccessor):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setFormatValueFromInteger):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setFormatValueFromUnsignedInteger):
(WebCore::WHLSL::AST::NativeTypeDeclaration::setIterateAllValues):
* Modules/webgpu/WHLSL/AST/WHLSLNode.h: Added.
* Modules/webgpu/WHLSL/AST/WHLSLNullLiteral.h: Added.
(WebCore::WHLSL::AST::NullLiteral::NullLiteral):
(WebCore::WHLSL::AST::NullLiteral::type):
(WebCore::WHLSL::AST::NullLiteral::clone const):
* Modules/webgpu/WHLSL/AST/WHLSLNullLiteralType.cpp: Added.
(WebCore::WHLSL::AST::NullLiteralType::canResolve const):
(WebCore::WHLSL::AST::NullLiteralType::conversionCost const):
* Modules/webgpu/WHLSL/AST/WHLSLNullLiteralType.h: Added.
* Modules/webgpu/WHLSL/AST/WHLSLNumThreadsFunctionAttribute.h: Added.
(WebCore::WHLSL::AST::NumThreadsFunctionAttribute::NumThreadsFunctionAttribute):
(WebCore::WHLSL::AST::NumThreadsFunctionAttribute::width const):
(WebCore::WHLSL::AST::NumThreadsFunctionAttribute::height const):
(WebCore::WHLSL::AST::NumThreadsFunctionAttribute::depth const):
* Modules/webgpu/WHLSL/AST/WHLSLPointerType.h: Added.
(WebCore::WHLSL::AST::PointerType::PointerType):
* Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h: Added.
(WebCore::WHLSL::AST::PropertyAccessExpression::PropertyAccessExpression):
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleGetOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleSetOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleAndOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleGetOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleSetOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleAndOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::base):
* Modules/webgpu/WHLSL/AST/WHLSLQualifier.h: Added.
* Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h: Added.
(WebCore::WHLSL::AST::ReadModifyWriteExpression::create):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::setNewValueExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::setResultExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::oldVariableReference):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::newVariableReference):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::lValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::oldValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::newValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::newValueExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::resultExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::ReadModifyWriteExpression):
* Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h: Added.
(WebCore::WHLSL::AST::ReferenceType::ReferenceType):
(WebCore::WHLSL::AST::ReferenceType::addressSpace const):
(WebCore::WHLSL::AST::ReferenceType::elementType const):
(WebCore::WHLSL::AST::ReferenceType::elementType):
* Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h: Added.
(WebCore::WHLSL::AST::ResolvableType::isFloatLiteralType const):
(WebCore::WHLSL::AST::ResolvableType::isIntegerLiteralType const):
(WebCore::WHLSL::AST::ResolvableType::isNullLiteralType const):
(WebCore::WHLSL::AST::ResolvableType::isUnsignedIntegerLiteralType const):
(WebCore::WHLSL::AST::ResolvableType::resolvedType const):
(WebCore::WHLSL::AST::ResolvableType::resolvedType):
(WebCore::WHLSL::AST::ResolvableType::resolve):
* Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp: Added.
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h: Added.
(WebCore::WHLSL::AST::ResourceSemantic::ResourceSemantic):
(WebCore::WHLSL::AST::ResourceSemantic::mode const):
(WebCore::WHLSL::AST::ResourceSemantic::index const):
(WebCore::WHLSL::AST::ResourceSemantic::space const):
(WebCore::WHLSL::AST::ResourceSemantic::operator== const):
(WebCore::WHLSL::AST::ResourceSemantic::operator!= const):
* Modules/webgpu/WHLSL/AST/WHLSLReturn.h: Added.
(WebCore::WHLSL::AST::Return::Return):
(WebCore::WHLSL::AST::Return::value):
(WebCore::WHLSL::AST::Return::function):
(WebCore::WHLSL::AST::Return::setFunction):
* Modules/webgpu/WHLSL/AST/WHLSLSemantic.h: Added.
* Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp: Added.
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h: Added.
(WebCore::WHLSL::AST::SpecializationConstantSemantic::SpecializationConstantSemantic):
(WebCore::WHLSL::AST::SpecializationConstantSemantic::operator== const):
(WebCore::WHLSL::AST::SpecializationConstantSemantic::operator!= const):
* Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp: Added.
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableType const):
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableForShaderItemDirection const):
* Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h: Added.
(WebCore::WHLSL::AST::StageInOutSemantic::StageInOutSemantic):
(WebCore::WHLSL::AST::StageInOutSemantic::index const):
(WebCore::WHLSL::AST::StageInOutSemantic::operator== const):
(WebCore::WHLSL::AST::StageInOutSemantic::operator!= const):
* Modules/webgpu/WHLSL/AST/WHLSLStatement.h: Added.
(WebCore::WHLSL::AST::Statement::Statement):
(WebCore::WHLSL::AST::Statement::isBlock const):
(WebCore::WHLSL::AST::Statement::isBreak const):
(WebCore::WHLSL::AST::Statement::isContinue const):
(WebCore::WHLSL::AST::Statement::isDoWhileLoop const):
(WebCore::WHLSL::AST::Statement::isEffectfulExpressionStatement const):
(WebCore::WHLSL::AST::Statement::isFallthrough const):
(WebCore::WHLSL::AST::Statement::isForLoop const):
(WebCore::WHLSL::AST::Statement::isIfStatement const):
(WebCore::WHLSL::AST::Statement::isReturn const):
(WebCore::WHLSL::AST::Statement::isSwitchCase const):
(WebCore::WHLSL::AST::Statement::isSwitchStatement const):
(WebCore::WHLSL::AST::Statement::isTrap const):
(WebCore::WHLSL::AST::Statement::isVariableDeclarationsStatement const):
(WebCore::WHLSL::AST::Statement::isWhileLoop const):
* Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h: Added.
(WebCore::WHLSL::AST::StructureDefinition::StructureDefinition):
(WebCore::WHLSL::AST::StructureDefinition::structureElements):
* Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h: Added.
(WebCore::WHLSL::AST::StructureElement::StructureElement):
(WebCore::WHLSL::AST::StructureElement::origin const):
(WebCore::WHLSL::AST::StructureElement::type):
(WebCore::WHLSL::AST::StructureElement::name):
(WebCore::WHLSL::AST::StructureElement::semantic):
* Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h: Added.
(WebCore::WHLSL::AST::SwitchCase::SwitchCase):
(WebCore::WHLSL::AST::SwitchCase::value):
(WebCore::WHLSL::AST::SwitchCase::block):
* Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h: Added.
(WebCore::WHLSL::AST::SwitchStatement::SwitchStatement):
(WebCore::WHLSL::AST::SwitchStatement::value):
(WebCore::WHLSL::AST::SwitchStatement::switchCases):
* Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h: Added.
(WebCore::WHLSL::AST::TernaryExpression::TernaryExpression):
(WebCore::WHLSL::AST::TernaryExpression::predicate):
(WebCore::WHLSL::AST::TernaryExpression::bodyExpression):
(WebCore::WHLSL::AST::TernaryExpression::elseExpression):
* Modules/webgpu/WHLSL/AST/WHLSLTrap.h: Added.
(WebCore::WHLSL::AST::Trap::Trap):
* Modules/webgpu/WHLSL/AST/WHLSLType.h: Added.
(WebCore::WHLSL::AST::Type::isNamedType const):
(WebCore::WHLSL::AST::Type::isUnnamedType const):
(WebCore::WHLSL::AST::Type::isResolvableType const):
* Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.cpp: Added.
(WebCore::WHLSL::AST::clone):
* Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.h: Added.
* Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h: Added.
(WebCore::WHLSL::AST::TypeDefinition::TypeDefinition):
(WebCore::WHLSL::AST::TypeDefinition::type):
* Modules/webgpu/WHLSL/AST/WHLSLTypeReference.cpp: Added.
(WebCore::WHLSL::AST::TypeReference::wrap):
* Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h: Added.
(WebCore::WHLSL::AST::TypeReference::TypeReference):
(WebCore::WHLSL::AST::TypeReference::name):
(WebCore::WHLSL::AST::TypeReference::typeArguments):
(WebCore::WHLSL::AST::TypeReference::resolvedType const):
(WebCore::WHLSL::AST::TypeReference::setResolvedType):
(WebCore::WHLSL::AST::TypeReference::cloneTypeReference const):
* Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h: Added.
(WebCore::WHLSL::AST::UnnamedType::UnnamedType):
(WebCore::WHLSL::AST::UnnamedType::isTypeReference const):
(WebCore::WHLSL::AST::UnnamedType::isPointerType const):
(WebCore::WHLSL::AST::UnnamedType::isArrayReferenceType const):
(WebCore::WHLSL::AST::UnnamedType::isArrayType const):
(WebCore::WHLSL::AST::UnnamedType::isReferenceType const):
(WebCore::WHLSL::AST::UnnamedType::unifyNode const):
(WebCore::WHLSL::AST::UnnamedType::unifyNode):
(WebCore::WHLSL::AST::UnnamedType::origin const):
* Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.cpp: Added.
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::valueForSelectedType const):
* Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h: Added.
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::UnsignedIntegerLiteral):
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::type):
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::value const):
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::clone const):
* Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp: Added.
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::UnsignedIntegerLiteralType):
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::canResolve const):
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::conversionCost const):
* Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h: Added.
(WebCore::WHLSL::AST::UnsignedIntegerLiteralType::preferredType):
* Modules/webgpu/WHLSL/AST/WHLSLValue.h: Added.
(WebCore::WHLSL::AST::Value::Value):
* Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h: Added.
(WebCore::WHLSL::AST::VariableDeclaration::VariableDeclaration):
(WebCore::WHLSL::AST::VariableDeclaration::origin const):
(WebCore::WHLSL::AST::VariableDeclaration::name):
(WebCore::WHLSL::AST::VariableDeclaration::type const):
(WebCore::WHLSL::AST::VariableDeclaration::type):
(WebCore::WHLSL::AST::VariableDeclaration::semantic):
(WebCore::WHLSL::AST::VariableDeclaration::initializer):
* Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h: Added.
(WebCore::WHLSL::AST::VariableDeclarationsStatement::VariableDeclarationsStatement):
(WebCore::WHLSL::AST::VariableDeclarationsStatement::variableDeclarations):
* Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h: Added.
(WebCore::WHLSL::AST::VariableReference::VariableReference):
(WebCore::WHLSL::AST::VariableReference::wrap):
(WebCore::WHLSL::AST::VariableReference::name):
(WebCore::WHLSL::AST::VariableReference::variable):
(WebCore::WHLSL::AST::VariableReference::setVariable):
* Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h: Added.
(WebCore::WHLSL::AST::WhileLoop::WhileLoop):
(WebCore::WHLSL::AST::WhileLoop::conditional):
(WebCore::WHLSL::AST::WhileLoop::body):
* Modules/webgpu/WHLSL/WHLSLLexer.cpp:
* Modules/webgpu/WHLSL/WHLSLParser.cpp: Added.
* Modules/webgpu/WHLSL/WHLSLParser.h: Added.
* Modules/webgpu/WHLSL/WHLSLProgram.h: Added.
(WebCore::WHLSL::Program::append):
(WebCore::WHLSL::Program::nameContext):
(WebCore::WHLSL::Program::intrinsics):
(WebCore::WHLSL::Program::typeDefinitions):
(WebCore::WHLSL::Program::structureDefinitions):
(WebCore::WHLSL::Program::enumerationDefinitions):
(WebCore::WHLSL::Program::functionDefinitions const):
(WebCore::WHLSL::Program::functionDefinitions):
(WebCore::WHLSL::Program::nativeFunctionDeclarations const):
(WebCore::WHLSL::Program::nativeFunctionDeclarations):
(WebCore::WHLSL::Program::nativeTypeDeclarations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoREGRESSION (r237658): Tap highlight limits cause the highlight to no longer show...
zalan@apple.com [Thu, 10 Jan 2019 21:50:42 +0000 (21:50 +0000)]
REGRESSION (r237658): Tap highlight limits cause the highlight to no longer show with legitimate button sizes
https://bugs.webkit.org/show_bug.cgi?id=193294
<rdar://problem/46006678>

Reviewed by Simon Fraser.

Input type elements should always paint tap highlight (ignore size heuristic).

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didGetTapHighlightGeometries):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlight]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): Deleted.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoBindings generator emits incorrect code when using VoidCallback as an IDL dictionary...
wenson_hsieh@apple.com [Thu, 10 Jan 2019 21:46:30 +0000 (21:46 +0000)]
Bindings generator emits incorrect code when using VoidCallback as an IDL dictionary attribute
https://bugs.webkit.org/show_bug.cgi?id=193328

Reviewed by Chris Dumez.

Currently, when generating the function body of `convertDictionary`, our bindings generator does not pass in an
argument to use as the `$globalObjectReference` in `JSValueToNative`, when generating code to convert a wrapped
attribute value to the native value. As a result, if the generated IDL type returns `true` from
`JSValueToNativeDOMConvertNeedsGlobalObject` (i.e. for callback function types), we will end up using the empty
string as the generated expression for the global object. This emits syntactically incorrect code:

    `convert<IDLCallbackFunction<JSVoidCallback>>(state, someValue, );`

To fix this, we pass in a string to use as the global object, which uses the given ExecState to grab the global
object. Tested by augmenting TestStandaloneDictionary.idl and its generated expectation.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent):
* bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
(WebCore::convertDictionary<DictionaryImplName>):
* bindings/scripts/test/TestStandaloneDictionary.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRemove unneeded XPCService variant for plugin service
ap@apple.com [Thu, 10 Jan 2019 21:23:00 +0000 (21:23 +0000)]
Remove unneeded XPCService variant for plugin service
https://bugs.webkit.org/show_bug.cgi?id=193326

Reviewed by Tim Horton.

* Configurations/PluginService.32.xcconfig: Removed.
* Configurations/PluginService.64.xcconfig:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Removed.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64.Info.plist: Copied from Source/WebKit/PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist.
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoDefine page media state flags for display capture.
eric.carlson@apple.com [Thu, 10 Jan 2019 20:48:49 +0000 (20:48 +0000)]
Define page media state flags for display capture.
https://bugs.webkit.org/show_bug.cgi?id=193230
<rdar://problem/47095142>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/get-display-media-muted.html

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::mediaState const):
* page/MediaProducer.h:
* platform/mediastream/RealtimeIncomingVideoSource.cpp:
(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/mac/AVVideoCaptureSource.h:
* platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
* platform/mediastream/mac/WindowDisplayCaptureSourceMac.h:
* platform/mock/MockRealtimeAudioSource.h:
* platform/mock/MockRealtimeVideoSource.h:
* testing/Internals.cpp:
(WebCore::Internals::pageMediaState):

Source/WebKit:

* UIProcess/API/C/WKPage.cpp:
(WKPageGetMediaState):
* UIProcess/API/C/WKPagePrivate.h:
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::createCaptureSource):

LayoutTests:

* fast/mediastream/get-display-media-muted-expected.txt: Added.
* fast/mediastream/get-display-media-muted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRebaseline inspector generator test results after recent changes.
bburg@apple.com [Thu, 10 Jan 2019 20:22:32 +0000 (20:22 +0000)]
Rebaseline inspector generator test results after recent changes.

Unreviewed test gardening.

* inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, rolling out r239825.
commit-queue@webkit.org [Thu, 10 Jan 2019 20:04:32 +0000 (20:04 +0000)]
Unreviewed, rolling out r239825.
https://bugs.webkit.org/show_bug.cgi?id=193330

Broke tests on armv7/linux bots (Requested by guijemont on
#webkit).

Reverted changeset:

"Enable DFG on ARM/Linux again"
https://bugs.webkit.org/show_bug.cgi?id=192496
https://trac.webkit.org/changeset/239825

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSource/WebCore:
justin_fan@apple.com [Thu, 10 Jan 2019 19:59:15 +0000 (19:59 +0000)]
Source/WebCore:
[WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API
https://bugs.webkit.org/show_bug.cgi?id=193298

Reviewed by Dean Jackson.

No new tests. No change in behavior.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/webgpu/WebGPUBindGroupBinding.h: Added.
* Modules/webgpu/WebGPUBindGroupBinding.idl: Added.
* Modules/webgpu/WebGPUBindGroupDescriptor.h: Added.
* Modules/webgpu/WebGPUBindGroupDescriptor.idl: Added.
* Modules/webgpu/WebGPUBufferBinding.h: Added.
* Modules/webgpu/WebGPUBufferBinding.idl: Added.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/gpu/GPUBindGroupBinding.h: Added.
* platform/graphics/gpu/GPUBindGroupDescriptor.h: Added.
* platform/graphics/gpu/GPUBufferBinding.h: Added.

LayoutTests:
[WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
https://bugs.webkit.org/show_bug.cgi?id=193289

Reviewed by Dean Jackson.

Fix broken test after pipeline layouts were added.

* webgpu/js/webgpu-functions.js:
(createBasicPipeline): Ensure pipeline layout is actually optional.
* webgpu/vertex-buffer-triangle-strip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoDisable the run-jsc-stress-test remote host key check.
commit-queue@webkit.org [Thu, 10 Jan 2019 19:36:25 +0000 (19:36 +0000)]
Disable the run-jsc-stress-test remote host key check.
https://bugs.webkit.org/show_bug.cgi?id=192988

Patch by Zhifei Fang <zhifei_fang@apple.com> on 2019-01-10
Reviewed by Alexey Proskuryakov.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoREGRESSION(r239815) http/tests/workers/service/serviceworker-private-browsing.https...
commit-queue@webkit.org [Thu, 10 Jan 2019 19:11:33 +0000 (19:11 +0000)]
REGRESSION(r239815) http/tests/workers/service/serviceworker-private-browsing.https.html test times out
https://bugs.webkit.org/show_bug.cgi?id=193325

Patch by Alex Christensen <achristensen@webkit.org> on 2019-01-10
Reviewed by Joseph Pecoraro.

InjectedBundle::setPrivateBrowsingEnabled effectively didn't do anything when enabled was false.
I made it destroy the legacy private browsing session in the NetworkProcess, which caused a test to time out.
This functionality is only used for testing, so it's no big deal to revert that part of the patch.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::destroyLegacyPrivateBrowsingSession): Deleted.
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::destroyLegacyPrivateBrowsingSessionInNetworkProcess): Deleted.
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[macOS] Add name of IORegistry key in sandbox.
pvollan@apple.com [Thu, 10 Jan 2019 18:47:39 +0000 (18:47 +0000)]
[macOS] Add name of IORegistry key in sandbox.
https://bugs.webkit.org/show_bug.cgi?id=193324

Reviewed by Brent Fulgham.

IOGVAVTCapabilities key has been changed to IOGVAHEVCDecodeCapabilities.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoSafari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateB...
dino@apple.com [Thu, 10 Jan 2019 18:08:23 +0000 (18:08 +0000)]
Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters
https://bugs.webkit.org/show_bug.cgi?id=193309
<rdar://problem/45279224>

Reviewed by Antoine Quint.

A speculative fix for a CheckedArithmetic crash triggered in updateBackdropFilters.

The crash log indicates we crash in a Checked<> class that is not recording
overflow i.e. it is crashing due to an overflow. The only place in this function
where that could happen is when we convert the FloatRect for the backdrop
region into a Checked<unsigned> for width and height. This suggests that either
the width or height are negative, or the float values are too large for integers,
or the product of the two overflows.

Avoid this by using RecordOverflow, but also changing the code a little to
bail if the rectangle is incorrect.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackdropFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoOverride the session configuration for cookieAcceptPolicy
ryanhaddad@apple.com [Thu, 10 Jan 2019 17:57:22 +0000 (17:57 +0000)]
Override the session configuration for cookieAcceptPolicy
https://bugs.webkit.org/show_bug.cgi?id=190925
<rdar://problem/45497382>

Patch by John Wilander <wilander@apple.com> on 2019-01-10
Reviewed by Alexey Proskuryakov and Alex Christensen.

Source/WebCore/PAL:

* pal/spi/cf/CFNetworkSPI.h:
    Declaration of _overrideSessionCookieAcceptPolicy on NSHTTPCookieStorage.

Source/WebKit:

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
    Now sets cookieStorage._overrideSessionCookieAcceptPolicy to YES.

Source/WTF:

* wtf/Platform.h:
    Definition of HAVE_CFNETWORK_OVERRIDE_SESSION_COOKIE_ACCEPT_POLICY.

Tools:

Test infrastructure for setting a first-party-only cookie policy.

* DumpRenderTree/TestRunner.cpp:
(setOnlyAcceptFirstPartyCookiesCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setOnlyAcceptFirstPartyCookies):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setOnlyAcceptFirstPartyCookies):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

* TestExpectations:
    Skipped since this cookie policy is only supported on Cocoa platforms.
* http/tests/cookies/only-accept-first-party-cookies-expected.txt: Added.
* http/tests/cookies/only-accept-first-party-cookies.html: Added.
* http/tests/cookies/resources/reset-cookies.html: Added.
    To support reset of third-party cookies in an iframe.
* http/tests/cookies/resources/set-cookie-and-redirect-back.php: Added.
    A simple bounce to set a cookie.
* platform/ios/TestExpectations:
    Skipped for now. Will be fixed in <rdar://problem/47165939>.
* platform/mac/TestExpectations:
    Skipped for now. Will be fixed in <rdar://problem/47165939>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[css-grid] Let abspos items reference implicit grid lines
commit-queue@webkit.org [Thu, 10 Jan 2019 17:32:24 +0000 (17:32 +0000)]
[css-grid] Let abspos items reference implicit grid lines
https://bugs.webkit.org/show_bug.cgi?id=193313

Patch by Oriol Brufau <obrufau@igalia.com> on 2019-01-10
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import test changes from WPT.

* web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html:

Source/WebCore:

While they can't create new implicit grid lines, abspos items
can reference existing ones as clarified in
https://github.com/w3c/csswg-drafts/commit/511bb63

This patch makes WebKit match Blink, Firefox and Edge.

Tests: web-platform-tests/css/css-grid/abspos/grid-positioned-items-padding-001.html
       web-platform-tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid const):
Remove argument from spanSizeForAutoPlacedItem call.
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
Don't treat implicit grid lines as 'auto'.
* rendering/RenderGrid.h:
Remove unused gridPositionIsAutoForOutOfFlow.
* rendering/style/GridPositionsResolver.cpp:
(WebCore::adjustGridPositionsFromStyle):
Don't treat implicit grid lines as 'auto'.
Remove unused gridContainerStyle parameter.
(WebCore::GridPositionsResolver::spanSizeForAutoPlacedItem):
Remove argument from adjustGridPositionsFromStyle call.
Remove unused gridContainerStyle parameter.
(WebCore::resolveGridPositionFromStyle):
Remove unnecessary assert that uses isValidNamedLineOrArea.
(WebCore::GridPositionsResolver::resolveGridPositionsFromStyle):
Remove argument from adjustGridPositionsFromStyle call.
* rendering/style/GridPositionsResolver.h:
Remove unused isValidNamedLineOrArea.
Remove unused parameter from spanSizeForAutoPlacedItem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoPut per-document autoplay behavior behind runtime website policies quirk instead...
mrajca@apple.com [Thu, 10 Jan 2019 17:31:27 +0000 (17:31 +0000)]
Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
https://bugs.webkit.org/show_bug.cgi?id=193301

Reviewed by Jer Noble.
Source/WebCore:

Instead of unconditionally enabling this with a compile-time flag, let clients
enable the quirk on a per-load basis.

Tests: added API tests in favor of the current layout test as this behavior is no
       longer on by default unless a client opts in.

* html/MediaElementSession.cpp:
(WebCore::needsPerDocumentAutoplayBehaviorQuirk):
(WebCore::MediaElementSession::playbackPermitted const):
* loader/DocumentLoader.h:

Source/WebKit:

Register a new quirk that can be configured per-load for per-document media
autoplay behaviors.

* Shared/WebsiteAutoplayQuirk.h:
* Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
* UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesSetAllowedAutoplayQuirks):
(WKWebsitePoliciesGetAllowedAutoplayQuirks):
* UIProcess/API/C/WKWebsitePolicies.h:
* UIProcess/API/Cocoa/_WKWebsitePolicies.h:
* UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setAllowedAutoplayQuirks:]):
(-[_WKWebsitePolicies allowedAutoplayQuirks]):

Tools:

Added API tests.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoVPModuleInitialize should be called when VCP is enabled
youenn@apple.com [Thu, 10 Jan 2019 16:45:51 +0000 (16:45 +0000)]
VPModuleInitialize should be called when VCP is enabled
https://bugs.webkit.org/show_bug.cgi?id=193299

Reviewed by Eric Carlson.

Add the necessary include to make sure ENABLE_VCP_ENCODER is defined appropriately.

* Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed GTK+ gardening after r239824.
magomez@igalia.com [Thu, 10 Jan 2019 15:46:35 +0000 (15:46 +0000)]
Unreviewed GTK+ gardening after r239824.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when comput...
zalan@apple.com [Thu, 10 Jan 2019 15:42:18 +0000 (15:42 +0000)]
[LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
https://bugs.webkit.org/show_bug.cgi?id=193310

Reviewed by Antti Koivisto.

Source/WebCore:

If the block inflow element has previous siblings with collapsed through vertical margins,
then this box's before margin could _indirectly_ collapse with the parent. Use the previous siblings
to check for margin collapsing.

Test: fast/block/block-only/collapsed-through-siblings.html

* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):
* page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/margin-collapse/collapsed-through-siblings-expected.txt: Added.
* fast/block/margin-collapse/collapsed-through-siblings.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer()
aboya@igalia.com [Thu, 10 Jan 2019 12:46:18 +0000 (12:46 +0000)]
[MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer()
https://bugs.webkit.org/show_bug.cgi?id=192934

Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::pushNewBuffer):
* platform/graphics/gstreamer/mse/AppendPipeline.h:
* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
(WebCore::MediaSourceClientGStreamerMSE::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoEnable DFG on ARM/Linux again
dinfuehr@igalia.com [Thu, 10 Jan 2019 11:55:51 +0000 (11:55 +0000)]
Enable DFG on ARM/Linux again
https://bugs.webkit.org/show_bug.cgi?id=192496

Reviewed by Yusuke Suzuki.

JSTests:

Test wasn't really skipped before moving the line with skip
to the top.

* stress/regress-192717.js:

Source/JavaScriptCore:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Do not use register
r11 in compiled DFG mode since it is already used in LLInt as metadataTable
register. Also clean up code since ARM traditional isn't supported anymore.

* dfg/DFGOSRExit.cpp:
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
* jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::CallFrameShuffler):
* jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
* llint/LowLevelInterpreter32_64.asm:
* offlineasm/arm.rb:

Source/WTF:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux.

* wtf/Platform.h:

Tools:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
on ARM by default.

* Scripts/run-jsc-stress-tests:

LayoutTests:

After changing the bytecode format DFG was disabled on all 32-bit
architectures. Enable DFG now again on ARM/Linux. Disable tests that
run out of executable memory with LLInt disabled.

* js/script-tests/dfg-float32array.js:
* js/script-tests/dfg-float64array.js:
* js/script-tests/dfg-int16array.js:
* js/script-tests/dfg-int32array-overflow-values.js:
* js/script-tests/dfg-int32array.js:
* js/script-tests/dfg-int8array.js:
* js/script-tests/dfg-uint16array.js:
* js/script-tests/dfg-uint32array.js:
* js/script-tests/dfg-uint8array.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed gardening. Mark user prompts tests in take screenshot commands as failure
carlosgc@webkit.org [Thu, 10 Jan 2019 11:08:29 +0000 (11:08 +0000)]
Unreviewed gardening. Mark user prompts tests in take screenshot commands as failure

Tests don't expect user prompts to be handled in take screenshot commands, but that's going to change in the
spec soon, see https://github.com/w3c/webdriver/issues/1359.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed GTK+ gardening. Rebaseline two css tests.
carlosgc@webkit.org [Thu, 10 Jan 2019 11:01:18 +0000 (11:01 +0000)]
Unreviewed GTK+ gardening. Rebaseline two css tests.

I think I missed these in previous rebaselines.

* platform/gtk/css1/font_properties/font-expected.png:
* platform/gtk/css1/font_properties/font-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-06-b-expected.png:
* platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[FreeType] Color emoji not properly supported
carlosgc@webkit.org [Thu, 10 Jan 2019 10:03:53 +0000 (10:03 +0000)]
[FreeType] Color emoji not properly supported
https://bugs.webkit.org/show_bug.cgi?id=191976

Reviewed by Michael Catanzaro.

Source/WebCore:

Always try to fallback to a colored font for emojis.

Test: platform/gtk/fonts/font-emoji-system-fallback.html

* platform/graphics/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence): Group regional indicators in pairs.
* platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::Font::systemFallbackFontForCharacter const): Pass PreferColoredFont::No to FontCache::systemFallbackForCharacters.
* platform/graphics/Font.h: Add IsForPlatformFont enum to replace the bool parameter in systemFallbackFontForCharacter().
* platform/graphics/FontCache.h:
* platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForSystemFallback):
* platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::characterSequenceIsEmoji): Check whether the character sequence is an emoji.
(WebCore::FontCascade::fontForCombiningCharacterSequence const): In case of emojis try to fallback to a colored
font even if base font can render the emoji in black and white.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Add PreferColoredFont parameter that is ignored.
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Add PreferColoredFont parameter.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::variantCapsSupportsCharacterForSynthesis const): Moved from cross-platform file.
(WebCore::Font::platformSupportsCodePoint const): Add freetype implementation.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Add PreferColoredFont parameter that is ignored.
* platform/text/CharacterProperties.h:
(WebCore::isEmojiKeycapBase):
(WebCore::isEmojiRegionalIndicator):
(WebCore::isEmojiWithPresentationByDefault):
(WebCore::isEmojiModifierBase):

Source/WTF:

Add a name for combining enclosing keycap character.

* wtf/unicode/CharacterNames.h:

LayoutTests:

Add new test to ensure we fallback to noto color emoji for emojis.

* platform/gtk/fonts/font-emoji-system-fallback-expected.html: Added.
* platform/gtk/fonts/font-emoji-system-fallback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoImport css-lists testcases from WPT.
commit-queue@webkit.org [Thu, 10 Jan 2019 10:01:14 +0000 (10:01 +0000)]
Import css-lists testcases from WPT.
https://bugs.webkit.org/show_bug.cgi?id=193273

Patch by cathie chen <cathiechen@igalia.com> on 2019-01-10
Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* resources/resource-files.json:
* web-platform-tests/css/css-lists/META.yml: Added.
* web-platform-tests/css/css-lists/add-inline-child-after-marker-001-expected.html: Added.
* web-platform-tests/css/css-lists/add-inline-child-after-marker-001.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-armenian.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-circle-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-circle.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal-leading-zero-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal-leading-zero.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-decimal.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-disc-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-disc.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-georgian-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-georgian.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-roman-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-roman.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-square-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-square.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-latin-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-latin.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-roman-expected.html: Added.
* web-platform-tests/css/css-lists/content-property/marker-text-matches-upper-roman.html: Added.
* web-platform-tests/css/css-lists/content-property/w3c-import.log: Added.
* web-platform-tests/css/css-lists/counter-increment-inside-display-contents-expected.html: Added.
* web-platform-tests/css/css-lists/counter-increment-inside-display-contents.html: Added.
* web-platform-tests/css/css-lists/counter-invalid-expected.html: Added.
* web-platform-tests/css/css-lists/counter-invalid.htm: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-contents-expected.html: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-contents.html: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-none-expected.html: Added.
* web-platform-tests/css/css-lists/counter-reset-increment-display-none.html: Added.
* web-platform-tests/css/css-lists/counter-reset-inside-display-contents-expected.html: Added.
* web-platform-tests/css/css-lists/counter-reset-inside-display-contents.html: Added.
* web-platform-tests/css/css-lists/inheritance-expected.txt: Added.
* web-platform-tests/css/css-lists/inheritance.html: Added.
* web-platform-tests/css/css-lists/li-with-height-001-expected.html: Added.
* web-platform-tests/css/css-lists/li-with-height-001.html: Added.
* web-platform-tests/css/css-lists/li-with-overflow-hidden-change-list-style-position-001-expected.html: Added.
* web-platform-tests/css/css-lists/li-with-overflow-hidden-change-list-style-position-001.html: Added.
* web-platform-tests/css/css-lists/list-and-block-textarea-001-expected.txt: Added.
* web-platform-tests/css/css-lists/list-and-block-textarea-001.html: Added.
* web-platform-tests/css/css-lists/list-and-flex-001-expected.html: Added.
* web-platform-tests/css/css-lists/list-and-flex-001.html: Added.
* web-platform-tests/css/css-lists/list-and-grid-001-expected.html: Added.
* web-platform-tests/css/css-lists/list-and-grid-001.html: Added.
* web-platform-tests/css/css-lists/list-and-margin-collapse-001-expected.txt: Added.
* web-platform-tests/css/css-lists/list-and-margin-collapse-001.html: Added.
* web-platform-tests/css/css-lists/list-and-writing-mode-001-expected.txt: Added.
* web-platform-tests/css/css-lists/list-and-writing-mode-001.html: Added.
* web-platform-tests/css/css-lists/list-marker-with-lineheight-and-overflow-hidden-001-expected.html: Added.
* web-platform-tests/css/css-lists/list-marker-with-lineheight-and-overflow-hidden-001.html: Added.
* web-platform-tests/css/css-lists/list-style-type-armenian-002.xht: Added.
* web-platform-tests/css/css-lists/list-style-type-armenian-003.xht: Added.
* web-platform-tests/css/css-lists/list-with-image-display-changed-001-expected.html: Added.
* web-platform-tests/css/css-lists/list-with-image-display-changed-001.html: Added.
* web-platform-tests/css/css-lists/resources/w3c-import.log: Added.
* web-platform-tests/css/css-lists/resources/white.gif: Added.
* web-platform-tests/css/css-lists/w3c-import.log: Added.

LayoutTests:

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-simulator/TestExpectations:
* platform/ios-simulator/imported/w3c/web-platform-tests/css/css-lists/list-and-writing-mode-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Web Animations] Audit Web Animations classes for memory reduction
graouts@webkit.org [Thu, 10 Jan 2019 08:19:39 +0000 (08:19 +0000)]
[Web Animations] Audit Web Animations classes for memory reduction
https://bugs.webkit.org/show_bug.cgi?id=193195

Reviewed by Simon Fraser and Yusuke Suzuki.

The classes, enums and structs added to support Web Animations were not as memory-efficient as they could be. We now order
members in a way that reduces padding, use Markable<T, Traits> instead of Optional<T> where applicable, declare enums as uint8_t
and removed unnecessary members.

As a result, classes and structs have shrunk as follows:

WebAnimation: 256 > 216
DeclarativeAnimation: 392 > 344
CSSAnimation: 416 > 368
CSSTransition: 440 > 392
AnimationEffect: 88 > 72
KeyframeEffect: 208 > 184
AnimationPlaybackEvent: 104 > 88
EffectTiming: 72 > 64
ComputedEffectTiming: 136 > 112
AnimationTimeline: 264 > 248
DocumentTimeline: 496 > 464
OptionalEffectTiming: 112 > 80
BaseKeyframe: 32 > 24
ParsedKeyframe: 80 > 72
BaseComputedKeyframe: 40 > 32

* animation/AnimationEffect.h: Order members in decreasing size, except for m_fill and m_direction, which we put at the top to
save 8 bytes (2 bytes of padding instead of 4 before m_animation and saving 6 bytes of padding at the end).
* animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
* animation/AnimationPlaybackEvent.h:
* animation/AnimationPlaybackEventInit.h:
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::AnimationTimeline):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):
* animation/AnimationTimeline.h: We remove the m_classType member and instead make isDocumentTimeline() virtual.
(WebCore::AnimationTimeline::isDocumentTimeline const):
(): Deleted.
(WebCore::AnimationTimeline::classType const): Deleted.
* animation/CompositeOperation.h:
* animation/CompositeOperationOrAuto.h:
* animation/ComputedEffectTiming.h:
* animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
* animation/DeclarativeAnimation.h: We keep m_wasPending and m_previousPhase at the top to save some padding at the end.
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
* animation/DocumentTimeline.h:
* animation/EffectTiming.h:
* animation/FillMode.h:
* animation/IterationCompositeOperation.h:
* animation/KeyframeEffect.cpp:
(WebCore::computeMissingKeyframeOffsets):
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
* animation/KeyframeEffect.h:
* animation/OptionalEffectTiming.h:
* animation/PlaybackDirection.h:
* animation/WebAnimation.h:
* animation/WebAnimationUtilities.h:
(WebCore::WebAnimationsMarkableDoubleTraits::isEmptyValue):
(WebCore::WebAnimationsMarkableDoubleTraits::emptyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRename some entitlements files to be more clear about their target platform
timothy_horton@apple.com [Thu, 10 Jan 2019 08:02:31 +0000 (08:02 +0000)]
Rename some entitlements files to be more clear about their target platform
https://bugs.webkit.org/show_bug.cgi?id=193311

Reviewed by Alexey Proskuryakov.

* Configurations/Network-iOSMac.entitlements: Renamed from Source/WebKit/Configurations/Network-iOS-minimalsimulator.entitlements.
* Configurations/NetworkService.xcconfig:
* Configurations/WebContent-iOSMac.entitlements: Renamed from Source/WebKit/Configurations/WebContent-iOS-minimalsimulator.entitlements.
* Configurations/WebContentService.xcconfig:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed build fix after r239816.
bfulgham@apple.com [Thu, 10 Jan 2019 04:15:16 +0000 (04:15 +0000)]
Unreviewed build fix after r239816.

Although EWS had no problem with the patch, I'm seeing build errors on the actual bots.
This patch corrects the problem.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::logFrameNavigation):
(WebKit::NetworkProcess::logUserInteraction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoCreate a WebResourceLoadStatisticsStore attached to the NetworkSession
bfulgham@apple.com [Thu, 10 Jan 2019 03:28:48 +0000 (03:28 +0000)]
Create a WebResourceLoadStatisticsStore attached to the NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=193261
<rdar://problem/47158616>

Reviewed by Alex Christensen.

This patch modifies NetworkSession so that it owns a WebResourceLoadStatisticsStore
object. This object is only created if the ResourceLoadStatistics feature is turned on.

The patch also modifies WebResourceLoadStatisticsStore so that it can be constructed
with an owning NetworkSession as an alternative to the current practice of using a
WebsiteDataStore object.

Two initial messages from the WebContent process are added (logFrameNavigation and
logUserNavigation) that notify the network process of these actions. Currently they
are called in addition the calls to the WebsiteDataStore object. These redundant calls
will be removed in a future patch.

This patch forces the ResourceLoadStatistics code in the NetworkSession to be off by
default, so there should be no change in behavior with this patch.

* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccessForFrame):
(WebKit::WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler):
(WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCap):
(WebKit::WebResourceLoadStatisticsStore::updatePrevalentDomainsToBlockCookiesFor):
(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler):
(WebKit::WebResourceLoadStatisticsStore::removePrevalentDomains):
(WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler):
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::logFrameNavigation):
(WebKit::NetworkProcess::logUserInteraction):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::enableResourceLoadStatistics):
* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::resourceLoadStatistics const):
* NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::privateSessionParameters):
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/NetworkSessionCreationParameters.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didLogUserInteraction):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebsiteDataStore::parameters):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::logFrameNavigation):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoReplace SessionTracker with HashMap member of NetworkProcess
achristensen@apple.com [Thu, 10 Jan 2019 03:08:07 +0000 (03:08 +0000)]
Replace SessionTracker with HashMap member of NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=193266

Reviewed by Joseph Pecoraro.

* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
* NetworkProcess/Downloads/DownloadManager.h:
* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::resume):
* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::destroyLegacyPrivateBrowsingSession):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::clearCachedCredentials):
(WebKit::NetworkProcess::networkSession):
(WebKit::NetworkProcess::setSession):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::preconnectTo):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
(WebKit::NetworkResourceLoader::shouldLogCookieInformation):
(WebKit::NetworkResourceLoader::logCookieInformation const):
(WebKit::logBlockedCookieInformation):
(WebKit::logCookieInformationInternal):
(WebKit::NetworkResourceLoader::logCookieInformation):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::loadRequest):
* NetworkProcess/PingLoad.h:
* NetworkProcess/PreconnectTask.cpp:
(WebKit::PreconnectTask::PreconnectTask):
* NetworkProcess/PreconnectTask.h:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* Shared/SessionTracker.cpp: Removed.
* Shared/SessionTracker.h: Removed.
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/Network/WebLoaderStrategy.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::destroyLegacyPrivateBrowsingSessionInNetworkProcess):
* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoThreadTimers should not store a raw pointer in its heap
rniwa@webkit.org [Thu, 10 Jan 2019 02:27:45 +0000 (02:27 +0000)]
ThreadTimers should not store a raw pointer in its heap
https://bugs.webkit.org/show_bug.cgi?id=192975
<rdar://problem/46893946>

Reviewed by Geoffrey Garen.

Right now, ThreadTimers's heap data structure stores a raw pointer to TimerBase. In order to harden the timer code,
this patch replaces it with ThreadTimerHeapItem, a newly introduced struct, which effectively acks like
WeakReference<TimerBase*> as the timer heap and TimerBase both store RefPtr to it, and TimerBase's destructor clears
the raw pointer back to TimerBase*.

This approach was taken instead of an out-right adoptation of WeakPtr since the heap data structure requires each node
in the heap to have a fixed "priority" yet WeakPtr with no valid pointer back to TimerBase would effectively lose its
"priority" thereby corrupting the heap data structure. That is, each item in the heap must remember its fire time and
insertion order even when the underlying TimerBase had gone away (this should never happen but the whole point of this
hardening is to make it work even in the precense of such a bug).

This patch also moves the heap index in TimerBase to ThreadTimerHeapItem, and replaces the pointer to the heap vector
in TimerBase by a reference to ThreadTimers in ThreadTimerHeapItem. Note that ThreadTimers is a per-thread singleton.

The correctness of this hardening was tested by commenting out the call to stop() and !isInHeap() assertion in
TimerBase::~TimerBase() as well as the !isInHeap() assertion in ThreadTimerHeapItem::clearTimer() and observing that
layout tests run successfully without hitting any debug assertions.

No new tests since there should be no observable behavior difference.

* WebCore.xcodeproj/project.pbxproj: Export ThreadTimers.h as a private header since it's now included in Timer.h
* platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::updateSharedTimer): Delete ThreadTimerHeapItem's with nullptr TimerBase* (TimerBase had
already been deleted). This should only happen when TimerBase's destructor failed to remove itself from the timer heap,
which should never happen.
(WebCore::ThreadTimers::sharedTimerFiredInternal): Ditto. Also removed the redundant code which had removed the timer
from the heap since setNextFireTime does the removal already.
* platform/ThreadTimers.h: Outdented the whole file.
(WebCore::ThreadTimers::timerHeap): We use Vector<RefPtr<ThreadTimerHeapItem>> instead of Vector<Ref<~>> since Ref<~>
doesn't have a copy constructor which is used by std::push_heap.
(WebCore::ThreadTimerHeapItem): Added.
(WebCore::ThreadTimerHeapItem::hasTimer const): Added.
(WebCore::ThreadTimerHeapItem::setNotInHeap): Added. ThreadTimerHeapItem uses unsigned -1 as the single value which
signifies the item not being in the heap instead of all negative values as in the old code in TimerBase.
(WebCore::ThreadTimerHeapItem::isInHeap const): Added.
(WebCore::ThreadTimerHeapItem::isFirstInHeap const): Added.
(WebCore::ThreadTimerHeapItem::timer): Added.
(WebCore::ThreadTimerHeapItem::clearTimer): Added.
(WebCore::ThreadTimerHeapItem::heapIndex const): Added.
(WebCore::ThreadTimerHeapItem::setHeapIndex): Added.
(WebCore::ThreadTimerHeapItem::timerHeap const): Added.
* platform/Timer.cpp:
(WebCore::threadGlobalTimerHeap): This function is now only used in assertions.
(WebCore::ThreadTimerHeapItem::ThreadTimerHeapItem): Added.
(WebCore::ThreadTimerHeapItem::create): Added.
(WebCore::TimerHeapPointer::TimerHeapPointer):
(WebCore::TimerHeapPointer::operator-> const):
(WebCore::TimerHeapReference::TimerHeapReference): Added a copy constructor.
(WebCore::TimerHeapReference::copyRef const): Added.
(WebCore::TimerHeapReference::operator RefPtr<ThreadTimerHeapItem>& const):
(WebCore::TimerHeapPointer::operator* const):
(WebCore::TimerHeapReference::operator=): Use move assignment operator.
(WebCore::TimerHeapReference::swapWith):
(WebCore::TimerHeapReference::updateHeapIndex): Extracted to share code between two verions of operator=.
(WebCore::swap):
(WebCore::TimerHeapIterator::TimerHeapIterator):
(WebCore::TimerHeapIterator::operator-> const):
(WebCore::TimerHeapLessThanFunction::compare): Added variants which take RefPtr<ThreadTimerHeapItem>.
(WebCore::TimerHeapLessThanFunction::operator() const):
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::~TimerBase):Clear the raw pointer in ThreadTimerHeapItem.
(WebCore::TimerBase::stop):
(WebCore::TimerBase::nextFireInterval const):
(WebCore::TimerBase::checkHeapIndex const): Added the consistency check for other items in the heap.
(WebCore::TimerBase::checkConsistency const):
(WebCore::TimerBase::heapDecreaseKey):
(WebCore::TimerBase::heapDelete):
(WebCore::TimerBase::heapDeleteMin):
(WebCore::TimerBase::heapIncreaseKey):
(WebCore::TimerBase::heapInsert):
(WebCore::TimerBase::heapPop):
(WebCore::TimerBase::heapPopMin):
(WebCore::TimerBase::heapDeleteNullMin): Added. Used to delete ThreadTimerHeapItem which no longer has a valid TimerBase.
(WebCore::parentHeapPropertyHolds):
(WebCore::childHeapPropertyHolds):
(WebCore::TimerBase::hasValidHeapPosition const):
(WebCore::TimerBase::updateHeapIfNeeded): Tweaked the heap index assertion as heapIndex() itself would assert when called
on an item with an invalid (-1) heap index.
(WebCore::TimerBase::setNextFireTime): Create ThreadTimerHeapItem. Note m_heapItem is never cleared until this TimerBase
is deleted.
(WebCore::TimerHeapReference::operator TimerBase* const): Deleted.
* platform/Timer.h:
(WebCore::TimerBase): Replaced m_nextFireTime, m_heapIndex, m_heapInsertionOrder, and m_cachedThreadGlobalTimerHeap
by m_heapItem, RefPtr to an ThreadTimerHeapItem.
(WebCore::TimerBase::augmentFireInterval):
(WebCore::TimerBase::inHeap const):
(WebCore::TimerBase::nextFireTime const):
(WebCore::TimerBase::isActive const):
(WebCore::TimerBase:: const): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUse directory local sequential numbers for Unified Sources filenames instead of globa...
Hironori.Fujii@sony.com [Thu, 10 Jan 2019 02:20:13 +0000 (02:20 +0000)]
Use directory local sequential numbers for Unified Sources filenames instead of global sequential numbers for CMake
https://bugs.webkit.org/show_bug.cgi?id=192391

Reviewed by Don Olmstead.

Unified Source Builds are using global sequential numbers for
bundle filenames UnifiedSource{sequential-number}.cpp. As the
result, every new source file added would shift the next ones and
prevent compiler caches from speeding up consecutive builds e.g.
in git-bisect sessions.

Changed it to directory local sequential numbers,
UnifiedSource-{hash-of-dir-name}-{sequential-number-within-the-dir}.cpp.

This is affecting only CMake builds which is where no
'--max-cpp-bundle-count' nor '--max-obj-c-bundle-count' options
are set. Xcode builds still use the old convention.

* Scripts/generate-unified-source-bundles.rb: Add new instance
variables @currentDirectory and @extraFiles to BundleManager.
Still use global sequential numbers if --max-cpp-bundle-count or
--max-obj-c-bundle-count is given.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
Hironori.Fujii@sony.com [Thu, 10 Jan 2019 02:04:53 +0000 (02:04 +0000)]
[Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
https://bugs.webkit.org/show_bug.cgi?id=193271

Reviewed by Brent Fulgham.

BSTR is a special data structure created by SysAllocString, not a
wchar_t null-terminated string.

* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
* MiniBrowser/win/MiniBrowserWebHost.cpp:
(MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
BSTR from wide string literals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMerge the latest version of JetStream2.0 to browserbench.org.
sbarati@apple.com [Thu, 10 Jan 2019 01:38:56 +0000 (01:38 +0000)]
Merge the latest version of JetStream2.0 to browserbench.org.

Rubber-stamped by Ryosuke Niwa.

* JetStream2.0: Copied from PerformanceTests/JetStream2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoExpand use of sourceApplicationAuditData
achristensen@apple.com [Thu, 10 Jan 2019 00:31:52 +0000 (00:31 +0000)]
Expand use of sourceApplicationAuditData
https://bugs.webkit.org/show_bug.cgi?id=192995
<rdar://problem/46627875>

Reviewed by Brady Eidson.

Source/WebKit:

sourceApplicationAuditData has been used for a long time on iOS, but it's needed on more platforms.
I also made it return an Optional instead of a bool and returning by reference. Ahhh. So much nicer.
The NetworkProcess needed an additional entitlement on Mac to continue to load anything, which is desirable.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::sourceApplicationAuditData const):
* Platform/IPC/Connection.h:
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::getAuditToken):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::sourceApplicationAuditData const):

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoREGRESSION(239737) iOS quicklook tests should not dereference null
achristensen@apple.com [Thu, 10 Jan 2019 00:19:25 +0000 (00:19 +0000)]
REGRESSION(239737) iOS quicklook tests should not dereference null
https://bugs.webkit.org/show_bug.cgi?id=193307

Reviewed by Brent Fulgham.

The quicklook tests rely on ResourceHandle on iOS for some reason.
This is a problem we'll fix later, but for now keep them working by not crashing.

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
(WebCore::ResourceHandle::receivedCredential):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoTweak wording for build/version_check style checker error
ap@apple.com [Wed, 9 Jan 2019 23:30:16 +0000 (23:30 +0000)]
Tweak wording for build/version_check style checker error
https://bugs.webkit.org/show_bug.cgi?id=193256

Reviewed by Tim Horton.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_os_version_checks):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_os_version_checks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoRestore bytecode dumper's ability to dump jump target as offset#(->targetBytecodeIndex#).
mark.lam@apple.com [Wed, 9 Jan 2019 23:03:23 +0000 (23:03 +0000)]
Restore bytecode dumper's ability to dump jump target as offset#(->targetBytecodeIndex#).
https://bugs.webkit.org/show_bug.cgi?id=193300

Reviewed by Saam Barati.

For example, instead of:
    [  95] jtrue              loc11, 9
We can now again (as before the bytecode format rewrite) have:
    [  95] jtrue              loc11, 9(->104)

* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::printLocationAndOp):
* bytecode/BytecodeDumper.h:
(JSC::BytecodeDumper::dumpValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoGigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
mark.lam@apple.com [Wed, 9 Jan 2019 22:45:06 +0000 (22:45 +0000)]
Gigacage disabling checks should handle the GIGACAGE_ALLOCATION_CAN_FAIL case properly.
https://bugs.webkit.org/show_bug.cgi?id=193292
<rdar://problem/46485450>

Reviewed by Yusuke Suzuki.

Source/bmalloc:

Previously, when GIGACAGE_ALLOCATION_CAN_FAIL is true, we allow the Gigacage to
be disabled if we fail to allocate memory for it.  However, Gigacage::primitiveGigacageDisabled()
still always assumes that the Gigacage is always enabled after ensureGigacage() is
called.

This patch updates Gigacage::primitiveGigacageDisabled() to allow the Gigacage to
already be disabled if GIGACAGE_ALLOCATION_CAN_FAIL is true and wasEnabled() is
false.

In this patch, we also put the wasEnabled flag in the 0th slot of the
g_gigacageBasePtrs buffer to ensure that it is also protected against writes just
like the Gigacage base pointers.

To achieve this, we do the following:
1. Added a reservedForFlags field in struct BasePtrs.
2. Added a ReservedForFlagsAndNotABasePtr Gigacage::Kind.
3. Added assertions to ensure that the BasePtrs::primitive is at the offset
   matching the offset computed from Gigacage::Primitive.  Ditto for
   BasePtrs::jsValue and Gigacage::JSValue.
4. Added assertions to ensure that Gigacage::ReservedForFlagsAndNotABasePtr is not
   used for fetching a Gigacage base pointer.
5. Added RELEASE_BASSERT_NOT_REACHED() to implement such assertions in bmalloc.

No test added because this issue requires Gigacage allocation to fail in order to
manifest.  I've tested it manually by modifying the code locally to force an
allocation failure.

* bmalloc/BAssert.h:
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::primitiveGigacageDisabled):
* bmalloc/Gigacage.h:
(Gigacage::wasEnabled):
(Gigacage::setWasEnabled):
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::size):
* bmalloc/HeapKind.h:
(bmalloc::heapKind):

Source/JavaScriptCore:

* runtime/VM.h:
(JSC::VM::gigacageAuxiliarySpace):

Source/WTF:

Update the USE_SYSTEM_MALLOC version of Gigacage.h to match the bmalloc version.

* wtf/Gigacage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Datalist] Crash when input with datalist is dynamically added.
zalan@apple.com [Wed, 9 Jan 2019 22:25:41 +0000 (22:25 +0000)]
[Datalist] Crash when input with datalist is dynamically added.
https://bugs.webkit.org/show_bug.cgi?id=193012
<rdar://problem/45923457>

Reviewed by Brent Fulgham.

Source/WebCore:

In certain cases (cloning, setAttribute), it's too early to check for the list attribute in createShadowSubtree
to see whether the input needs datalist related items. The list attribute is simply not set yet.
This patch only addresses the obvious crash. m_dataListDropdownIndicator clearly lacks proper lifecycle management (see webkit.org/b/193032).

Test: fast/forms/datalist/datalist-crash-when-dynamic.html

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::attributeChanged):
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
* html/TextFieldInputType.h:

LayoutTests:

* fast/forms/datalist/datalist-crash-when-dynamic-expected.txt: Added.
* fast/forms/datalist/datalist-crash-when-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[ews-build] Add link to bug along with bug title
aakash_jain@apple.com [Wed, 9 Jan 2019 22:24:22 +0000 (22:24 +0000)]
[ews-build] Add link to bug along with bug title
https://bugs.webkit.org/show_bug.cgi?id=193293

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
(ConfigureBuild.add_bug_id_url): Deleted.
(ConfigureBuild.getBugURL): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[ews-build] Use https for ews-build server
aakash_jain@apple.com [Wed, 9 Jan 2019 22:08:34 +0000 (22:08 +0000)]
[ews-build] Use https for ews-build server
https://bugs.webkit.org/show_bug.cgi?id=193193

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[ews-build] Parse and display number of style failures
aakash_jain@apple.com [Wed, 9 Jan 2019 21:59:04 +0000 (21:59 +0000)]
[ews-build] Parse and display number of style failures
https://bugs.webkit.org/show_bug.cgi?id=193280

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(CheckStyle): Use TestWithFailureCount as base class.
(CheckStyle.countFailures): Count the number of style failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[ews-build] use patch_id instead of ewspatchid
aakash_jain@apple.com [Wed, 9 Jan 2019 21:56:53 +0000 (21:56 +0000)]
[ews-build] use patch_id instead of ewspatchid
https://bugs.webkit.org/show_bug.cgi?id=193235

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
* BuildSlaveSupport/ews-build/steps.py: Ditto.
* BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
justin_fan@apple.com [Wed, 9 Jan 2019 20:05:09 +0000 (20:05 +0000)]
[WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
https://bugs.webkit.org/show_bug.cgi?id=193289

Reviewed by Dean Jackson.

Source/WebCore:

Fix broken test after pipeline layouts were added, and a small refactoring to GPURenderPipeline to avoid
retaining its descriptor after creation.

* platform/graphics/gpu/GPURenderPipeline.h:
(WebCore::GPURenderPipeline::primitiveTopology const):
* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::GPURenderPipeline::GPURenderPipeline):

LayoutTests:

Fix broken test after pipeline layouts were added.

* webgpu/js/webgpu-functions.js:
(createBasicPipeline): Ensure pipeline layout is actually optional.
* webgpu/vertex-buffer-triangle-strip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Protocol Logging: log messages as objects if inspector^2 is open
drousso@apple.com [Wed, 9 Jan 2019 19:38:45 +0000 (19:38 +0000)]
Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
https://bugs.webkit.org/show_bug.cgi?id=193284

Reviewed by Joseph Pecoraro.

Source/WebCore:

No newe tests, as this is simply exposes a value.

* inspector/InspectorFrontendHost.idl:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isBeingInspected): Added.

Source/WebInspectorUI:

If inspector^2 is closed, stringify all messages.
If inspector^2 is open, log each message JSON object without modifying it.

* UserInterface/Protocol/LoggingProtocolTracer.js:
(WI.LoggingProtocolTracer.prototype._processEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] Update sandbox profile to use iconservices instead of lsdiconservice
bfulgham@apple.com [Wed, 9 Jan 2019 19:05:59 +0000 (19:05 +0000)]
[iOS] Update sandbox profile to use iconservices instead of lsdiconservice
https://bugs.webkit.org/show_bug.cgi?id=193115
<rdar://problem/44867379>

Reviewed by Eric Carlson.

Add access to the 'com.apple.iconservices' endpoint. We will remove access to
the older name ('com.apple.lsdiconservices') once existing clients have completed
the switch.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[PSON] Flash of blank content while transitioning from page A to page B.
antti@apple.com [Wed, 9 Jan 2019 18:23:22 +0000 (18:23 +0000)]
[PSON] Flash of blank content while transitioning from page A to page B.
https://bugs.webkit.org/show_bug.cgi?id=193283

Reviewed by Chris Dumez.

Layer tree is not frozen during WebPage construction. If the flush timer (started for the initial
empty document) manages to run before the actual page load starts, we'll get a flash.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:

Rename shouldDelayAttachingDrawingArea bit to isSwapFromSuspended and make it available on all platforms.

* UIProcess/RemoteLayerTree/mac/ScrollerMac.h: Removed.
* UIProcess/RemoteLayerTree/mac/ScrollerMac.mm: Removed.
* UIProcess/RemoteLayerTree/mac/ScrollerPairMac.h: Removed.
* UIProcess/RemoteLayerTree/mac/ScrollerPairMac.mm: Removed.
* UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp: Removed.
* UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.h: Removed.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToWebProcess):
(WebKit::WebPageProxy::finishAttachingToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldAttachDrawingAreaOnPageTransition):

Freeze the layer tree in WebPage constructor if this is a swap from a suspended process.

(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::didCompletePageTransition):

Unfreeze on first non-initial empty document page transition.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWebKit Networking process crashes if the HTTPSUpgradeList is not found in the bundle
cdumez@apple.com [Wed, 9 Jan 2019 18:09:00 +0000 (18:09 +0000)]
WebKit Networking process crashes if the HTTPSUpgradeList is not found in the bundle
https://bugs.webkit.org/show_bug.cgi?id=193285
<rdar://problem/47147610>

Reviewed by Geoffrey Garen.

* NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:
(WebKit::networkHTTPSUpgradeCheckerDatabasePath):
(WebKit::NetworkHTTPSUpgradeChecker::NetworkHTTPSUpgradeChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agobuiltins should be able to use async/await
keith_miller@apple.com [Wed, 9 Jan 2019 17:40:00 +0000 (17:40 +0000)]
builtins should be able to use async/await
https://bugs.webkit.org/show_bug.cgi?id=193263

Reviewed by Saam Barati.

This patch makes it possible to use async functions when writing builtin JS code.

* Scripts/wkbuiltins/builtins_generator.py:
(BuiltinsGenerator.generate_embedded_code_string_section_for_function):
* Scripts/wkbuiltins/builtins_model.py:
(BuiltinFunction.__init__):
(BuiltinFunction.fromString):
(BuiltinFunction.__str__):
* builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
* builtins/ModuleLoader.js:
(requestInstantiate):
(async.loadModule):
(async.loadAndEvaluateModule):
(async.requestImportModule):
(loadModule): Deleted.
(): Deleted.
(loadAndEvaluateModule): Deleted.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[LFC][BFC][MarginCollapsing] Add support for peculiar cases.
zalan@apple.com [Wed, 9 Jan 2019 16:08:05 +0000 (16:08 +0000)]
[LFC][BFC][MarginCollapsing] Add support for peculiar cases.
https://bugs.webkit.org/show_bug.cgi?id=192625

Reviewed by Antti Koivisto.

Source/WebCore:

Implement some of the more peculiar cases like margin collpasing through multiple boxes etc.
Add ~100 new passing cases.

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
* layout/LayoutState.h:
(WebCore::Layout::LayoutState::hasFormattingState const):
* layout/MarginTypes.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBefore const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginBeforeForAncestors const):
(WebCore::Layout::hasPrecomputedMarginBefore):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const):
* layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::blockFormattingState const):
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginAfter): Deleted.
* layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginAfter):
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight): Deleted.
* layout/blockformatting/BlockFormattingState.h:
(WebCore::Layout::BlockFormattingState::setPositiveAndNegativeVerticalMargin):
(WebCore::Layout::BlockFormattingState::hasPositiveAndNegativeVerticalMargin const):
(WebCore::Layout::BlockFormattingState::positiveAndNegativeVerticalMargin const):
(WebCore::Layout::BlockFormattingState::setHasEstimatedMarginBefore):
(WebCore::Layout::BlockFormattingState::clearHasEstimatedMarginBefore):
(WebCore::Layout::BlockFormattingState::hasEstimatedMarginBefore const):
* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::hasClearance):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithSiblingMarginBeforeWithClearance):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithNextSiblingMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
(WebCore::Layout::computedPositiveAndNegativeMargin):
(WebCore::Layout::marginValue):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::updateCollapsedMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::computedNonCollapsedMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::nonCollapsedMarginAfter): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBeforeFromFirstChild): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginAfterFromLastChild): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithNextSibling): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfter): Deleted.
* layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::Box):
* layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::hasClearance const):
(WebCore::Display::Box::setEstimatedMarginBefore):
(WebCore::Display::Box::estimatedMarginBefore const):
(WebCore::Display::Box::setHasClearance):
(WebCore::Display::Box::invalidateEstimatedMarginBefore):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::rectWithMargin const):
* layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WPE][GTK] Purge use of g_assert() under TestWebKitAPI
mcatanzaro@igalia.com [Wed, 9 Jan 2019 15:30:58 +0000 (15:30 +0000)]
[WPE][GTK] Purge use of g_assert() under TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=192841

Reviewed by Carlos Garcia Campos.

There are separate g_assert_*() macros for use in tests, which we use inconsistently
currently. Use them always. We'll get nicer error messages now when tests fail, and the
assertions will now run during tests even if G_DISABLE_ASSERT is used when building.

Note that the documentation of g_assert() says that it is not to be used when writing tests.

* TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
* TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
(WebKitWebEditorTest::testSelectionChanged):
* TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::testJavaScriptValues):
* TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
(testWebViewAuthenticationRequest):
(testWebViewAuthenticationLoadCancelled):
(testWebViewAuthenticationFailure):
(testWebViewAuthenticationStorage):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
* TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
(testAutomationSessionRequestSession):
* TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
(testBackForwardListNavigation):
(testWebKitWebViewSessionState):
(testWebKitWebViewSessionStateWithFormData):
* TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
(ConsoleMessageTest::consoleMessageReceivedCallback):
(testWebKitConsoleMessageConsoleAPI):
(testWebKitConsoleMessageJavaScriptException):
(testWebKitConsoleMessageNetworkError):
(testWebKitConsoleMessageSecurityError):
* TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
(testCookieManagerAcceptPolicy):
(testCookieManagerCookiesChanged):
(testCookieManagerPersistentStorage):
(testCookieManagerPersistentStorageDeleteAll):
(testCookieManagerEphemeral):
* TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
(testWebKitDOMElementAutoFill):
* TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(downloadLocalFileSuccessfully):
(createFileAtDestination):
(testDownloadOverwriteDestinationDisallowed):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(testPolicyResponseDownloadCancel):
(testDownloadMIMEType):
(contextMenuCallback):
(testContextMenuDownloadActions):
(testBlobDownload):
* TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
(testWebKitWebEditorSelectionChanged):
* TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
(testWebKitFrameMainFrame):
(testWebKitFrameURI):
(testWebKitFrameJavaScriptContext):
(testWebKitFrameJavaScriptValues):
* TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
(LoadStopTrackingTest::loadFailed):
(testWebViewTitle):
(testURIRequestHTTPHeaders):
(testURIRequestHTTPMethod):
(testURIResponseHTTPHeaders):
(testRedirectToDataURI):
* TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
(testProcessPerWebView):
(testWebProcessLimit):
* TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
(testWebViewResources):
(testWebResourceLoading):
(testWebResourceSuggestedFilename):
(testWebResourceGetData):
(testWebResourceGetDataError):
(testWebViewResourcesHistoryCache):
(testWebResourceSendRequest):
* TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
(testSSL):
(testInsecureContent):
(testTLSErrorsPolicy):
(testTLSErrorsRedirect):
(testTLSErrorsHTTPAuth):
(testLoadFailedWithTLSErrors):
(testSubresourceLoadFailedWithTLSErrors):
(httpsServerCallback):
* TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
(testWebViewCreateNavigationData):
(testWebViewJavaScriptDialogs):
(testWebViewWindowProperties):
(testWebViewMouseTarget):
(testWebViewFileChooserRequest):
(testWebViewColorChooserRequest):
* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebExtensionGetTitle):
(testDocumentLoadedSignal):
(testWebKitWebViewProcessCrashed):
(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):
(permissionRequestCallback):
(didAssociateFormControlsCallback):
(testWebExtensionFormControlsAssociated):
(FormSubmissionTest::FormSubmissionTest):
(FormSubmissionTest::testFormSubmissionResult):
(testWebExtensionFormSubmissionSteps):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
(testNotInitialized):
(testClearDatabase):
(testPrivateBrowsing):
(testGetFavicon):
(testWebViewFavicon):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
(testFindControllerTextFound):
(testFindControllerTextNotFound):
(testFindControllerMatchCount):
(testFindControllerMaxMatchCount):
(testFindControllerNext):
(testFindControllerPrevious):
(testFindControllerCountedMatches):
(testFindControllerOptions):
(testFindControllerHide):
(testFindControllerInstance):
(testFindControllerGetters):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
(testNavigationPolicy):
(testResponsePolicy):
(testNewWindowPolicy):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
(testSecurityOriginBasicConstructor):
(testSecurityOriginURIConstructor):
(testSecurityOriginDefaultPort):
(testSecurityOriginFileURI):
(testOpaqueSecurityOrigin):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):
(testWebKitSettingsNewWithSettings):
(testWebKitSettingsUserAgent):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
(testWebViewNewWithUserContentManager):
(isStyleSheetInjectedForURLAtPath):
(isScriptInjectedForURLAtPath):
(testUserContentManagerInjectedStyleSheet):
(testUserContentManagerInjectedScript):
(UserScriptMessageTest::scriptMessageReceived):
(UserScriptMessageTest::waitUntilMessageReceived):
(UserScriptMessageTest::runJavaScriptFinished):
(testUserContentManagerScriptMessageReceived):
(testUserContentManagerScriptMessageInWorldReceived):
(testUserContentManagerScriptMessageFromDOMBindings):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextDefault):
(testWebContextEphemeral):
(testWebContextGetPlugins):
(testWebContextURIScheme):
(testWebContextSpellChecker):
(testWebContextLanguages):
(consoleMessageReceivedCallback):
(testWebContextSecurityFileXHR):
(ProxyTest::ProxyTest):
(testWebContextProxySettings):
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
(testWebViewWebContext):
(testWebViewWebBackend):
(testWebViewEphemeral):
(testWebViewCustomCharset):
(testWebViewSettings):
(testWebViewRunJavaScript):
(testWebViewCanShowMIMEType):
(testWebViewSubmitForm):
(testWebViewSave):
(testWebViewPageVisibility):
(testWebViewSnapshot):
(testWebViewNotification):
(testWebViewNotificationInitialPermissionAllowed):
(testWebViewNotificationInitialPermissionDisallowed):
(testWebViewIsPlayingAudio):
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(WebsiteDataTest::WebsiteDataTest):
(WebsiteDataTest::remove):
(WebsiteDataTest::clear):
(testWebsiteDataConfiguration):
(testWebsiteDataEphemeral):
(testWebsiteDataCache):
(testWebsiteDataStorage):
(testWebsiteDataDatabases):
(testWebsiteDataAppcache):
(testWebsiteDataCookies):
(testWebsiteDataDeviceIdHashSalt):
* TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(emitDocumentLoaded):
(emitURIChanged):
(sendRequestCallback):
(contextMenuCallback):
(consoleMessageSentCallback):
(emitFormControlsAssociated):
(formControlsAssociatedCallback):
(emitFormSubmissionEvent):
(willSubmitFormCallback):
(windowObjectCleared):
(methodCallCallback):
(registerGResource):
(webkit_web_extension_initialize_with_user_data):
* TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
(checkLeaks):
(WebProcessTest::create):
(runTest):
* TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
(AutocleanupsTest::testWebProcessAutocleanups):
* TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
(WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
(WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
* TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
(WebKitDOMDOMWindowTest::testSignals):
(WebKitDOMDOMWindowTest::testDispatchEvent):
(WebKitDOMDOMWindowTest::testGetComputedStyle):
* TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
* TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNamesNodeList):
(WebKitDOMNodeTest::testTagNamesHTMLCollection):
(WebKitDOMNodeTest::testDOMCache):
* TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
(WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
* TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
(testUIProcessAutocleanups):
(testWebProcessAutocleanups):
* TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
(testContextMenuPopulateMenu):
(testContextMenuDismissed):
* TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
(testWebKitDOMClientRectDivBoundingClientRectPosition):
(testWebKitDOMClientRectDivClientRectsPositionAndLength):
* TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
(testWebKitDOMDOMWindowSignals):
(testWebKitDOMDOMWindowDispatchEvent):
(testWebKitDOMDOMWindowGetComputedStyle):
* TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNamesNodeList):
(testWebKitDOMNodeTagNamesHTMLCollection):
(testWebKitDOMObjectCache):
* TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
(testWebKitDOMNodeFilterTreeWalker):
(testWebKitDOMNodeFilterNodeIterator):
* TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
* TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
(testInspectorDefault):
(testInspectorManualAttachDetach):
(testInspectorCustomContainerDestroyed):
* TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
(startTestServer):
(testInspectorServerPageList):
* TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
(OptionMenuTest::showOptionMenuCallback):
(OptionMenuTest::menuCloseCallback):
(OptionMenuTest::close):
(OptionMenuTest::activateItem):
(OptionMenuTest::selectItem):
(testOptionMenuSimple):
(testOptionMenuGroups):
(testOptionMenuActivate):
(testOptionMenuSelect):
* TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
(testPrintOperationPrintSettings):
(webViewPrintCallback):
(testPrintOperationPrint):
(testPrintCustomWidget):
* TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
(checkAtspiAccessible):
(testAtspiBasicHierarchy):
* TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
(testWebKitCheckVersion):
* TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(testWebViewEditorSelectAllNonEditable):
(testWebViewEditorSelectAllEditable):
(loadContentsAndTryToCutSelection):
(testWebViewEditorNonEditable):
(testWebViewEditorEditable):
(testWebViewEditorEditorStateTypingAttributes):
(testWebViewEditorInsertImage):
(testWebViewEditorCreateLink):
* TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
(loadChangedCallback):
(loadFailedCallback):
(loadFailedWithTLSErrorsCallback):
(LoadTrackingTest::LoadTrackingTest):
* TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
(registerGResource):
(removeNonEmptyDirectory):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::adoptView):
(Test::~Test):
* TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
(WebKitTestBus::getOrCreateConnection):
(WebKitTestBus::createProxy):
* TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
(WebKitTestServer::getWebSocketURIForPath const):
* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(WebViewTest::initializeWebView):
(WebViewTest::loadURI):
(WebViewTest::loadHtml):
(WebViewTest::loadPlainText):
(WebViewTest::loadBytes):
(WebViewTest::loadRequest):
(WebViewTest::loadAlternateHTML):
(WebViewTest::goBack):
(WebViewTest::goForward):
(WebViewTest::goToBackForwardListItem):
(resourceGetDataCallback):
(WebViewTest::mainResourceData):
(WebViewTest::javascriptResultToCString):
(WebViewTest::javascriptResultToNumber):
(WebViewTest::javascriptResultToBoolean):
(WebViewTest::javascriptResultIsNull):
(WebViewTest::javascriptResultIsUndefined):
(onSnapshotReady):
(WebViewTest::runWebProcessTest):
* TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
(WebViewTest::platformInitializeWebView):
(WebViewTest::showInWindow):
(WebViewTest::showInWindowAndWaitUntilMapped):
(WebViewTest::mouseMoveTo):
(WebViewTest::emitPopupMenuSignal):
(WebViewTest::keyStroke):
(WebViewTest::doMouseButtonEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html...
wenson_hsieh@apple.com [Wed, 9 Jan 2019 15:24:36 +0000 (15:24 +0000)]
[iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html often times out in internal automation
https://bugs.webkit.org/show_bug.cgi?id=193238

Reviewed by Megan Gardner.

Fix a flaky layout test that currently attempts to run the main logic of the test twice (once after the child
frame finishes loading, and another time after the main document finishes loading). This leads to a race
condition in the test where the incorrect text field is focused, causing the caret rect to deviate from the
expected value.

* editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[GTK] Add missing autocleanups
mcatanzaro@igalia.com [Wed, 9 Jan 2019 15:08:26 +0000 (15:08 +0000)]
[GTK] Add missing autocleanups
https://bugs.webkit.org/show_bug.cgi?id=193068

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitAutocleanups.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoUnreviewed, rolling out r239565.
carlosgc@webkit.org [Wed, 9 Jan 2019 12:42:57 +0000 (12:42 +0000)]
Unreviewed, rolling out r239565.

Rebaseline was not correct, changes were due to
webkit.org/b/193276

Reverted changeset:

"Unreviewed GTK+ gardening. Rebaseline several tests after
r239156."
https://trac.webkit.org/changeset/239565

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoREGRESSION(r239156): [FreeType] fixed width, and synthetic bold/italic not correctly...
carlosgc@webkit.org [Wed, 9 Jan 2019 12:39:25 +0000 (12:39 +0000)]
REGRESSION(r239156): [FreeType] fixed width, and synthetic bold/italic not correctly applied since r239156
https://bugs.webkit.org/show_bug.cgi?id=193276

Reviewed by Žan Doberšek.

FontCache::createFontPlatformData() is calling getFontPropertiesFromPattern() with the configure pattern instead
of the result one after the match.

* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WPE] API tests can't run in flatpak environment
philn@webkit.org [Wed, 9 Jan 2019 10:59:45 +0000 (10:59 +0000)]
[WPE] API tests can't run in flatpak environment
https://bugs.webkit.org/show_bug.cgi?id=193242

Reviewed by Michael Catanzaro.

* Scripts/run-wpe-tests: Add --wpe to arguments passed to
flatpakutils so that it knows which port it's dealing with.
* glib/common.py: Remove build_dir globals so that subsequent
calls actually take args into account.
(library_build_path):
(binary_build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Styles: clicking on property that soon to be discarded shouldn't start...
nvasilyev@apple.com [Wed, 9 Jan 2019 08:34:15 +0000 (08:34 +0000)]
Web Inspector: Styles: clicking on property that soon to be discarded shouldn't start selection
https://bugs.webkit.org/show_bug.cgi?id=193218
<rdar://problem/47098303>

Reviewed by Devin Rousso.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
A style property may get removed on blur event, so propertyElement may get removed from the DOM right when mousedown event happens.

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowClick):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._stopSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Styles: Undo reverts all changes at once
nvasilyev@apple.com [Wed, 9 Jan 2019 03:29:18 +0000 (03:29 +0000)]
Web Inspector: Styles: Undo reverts all changes at once
https://bugs.webkit.org/show_bug.cgi?id=177676
<rdar://problem/34745031>

Reviewed by Devin Rousso.

Command-Z used to revert all changes at once because Web Inspector never
set any history checkpoints in the style editor.

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype._handleBlur):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoArray.prototype.flat/flatMap have a minor bug in ArraySpeciesCreate
yusukesuzuki@slowstart.org [Wed, 9 Jan 2019 02:56:15 +0000 (02:56 +0000)]
Array.prototype.flat/flatMap have a minor bug in ArraySpeciesCreate
https://bugs.webkit.org/show_bug.cgi?id=193127

Reviewed by Saam Barati.

JSTests:

* stress/array-species-create-should-handle-masquerader.js: Added.
(shouldThrow):
* stress/is-undefined-or-null-builtin.js: Added.
(shouldBe):
(isUndefinedOrNull.vm.createBuiltin):

Source/JavaScriptCore:

`== null` is frequently used idiom to check `null` or `undefined` in JS.
However, it has a problem in terms of the builtin JS implementation: it
returns true if masquerade-as-undefined objects (e.g. document.all) come.

In this patch, we introduce a convenient builtin intrinsic @isUndefinedOrNull,
which is equivalent to C++ `JSValue::isUndefinedOrNull`. It does not consider
about masquerade-as-undefined objects, so that we can use it instead of
`value === null || value === @undefined`. We introduce is_undefined_or_null
bytecode, IsUndefinedOrNull DFG node and its DFG and FTL backends. Since
Null and Undefined have some bit patterns, we can implement this query
very efficiently.

* builtins/ArrayIteratorPrototype.js:
(next):
* builtins/ArrayPrototype.js:
(globalPrivate.arraySpeciesCreate):
* builtins/GlobalOperations.js:
(globalPrivate.speciesConstructor):
(globalPrivate.copyDataProperties):
(globalPrivate.copyDataPropertiesNoExclusions):
* builtins/MapIteratorPrototype.js:
(next):
* builtins/SetIteratorPrototype.js:
(next):
* builtins/StringIteratorPrototype.js:
(next):
* builtins/StringPrototype.js:
(match):
(repeat):
(padStart):
(padEnd):
(intrinsic.StringPrototypeReplaceIntrinsic.replace):
(search):
(split):
(concat):
(globalPrivate.createHTML):
* builtins/TypedArrayPrototype.js:
(globalPrivate.typedArraySpeciesConstructor):
(map):
(filter):
* bytecode/BytecodeIntrinsicRegistry.h:
* bytecode/BytecodeList.rb:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitIsUndefinedOrNull):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isUndefinedOrNull):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsUndefinedOrNull):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_is_undefined_or_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_is_undefined_or_null):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoWeb Inspector: Use prefers-color-scheme instead of prefers-dark-interface
nvasilyev@apple.com [Wed, 9 Jan 2019 02:03:03 +0000 (02:03 +0000)]
Web Inspector: Use prefers-color-scheme instead of prefers-dark-interface
https://bugs.webkit.org/show_bug.cgi?id=193265

Reviewed by Timothy Hatcher.

* UserInterface/Views/AuditTestContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/AuditTestGroupContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/BezierEditor.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/BoxModelDetailsSectionRow.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/BreakpointActionView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/BreakpointPopoverController.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ButtonNavigationItem.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ButtonToolbarItem.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CallFrameView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CanvasContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CanvasOverviewContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CanvasSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CanvasTabContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CodeMirrorOverrides.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/CompletionSuggestionsView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ComputedStyleDetailsPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ComputedStyleSection.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ConsoleMessageView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ConsolePrompt.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DOMTreeOutline.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DataGrid.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DebuggerDashboardView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DebuggerSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DefaultDashboardView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DetailsSection.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/DividerNavigationItem.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/Editing.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/FindBanner.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/FontResourceContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/FormattedValue.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/HoverMenu.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ImageResourceContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/LogContentView.css:
(@media (prefers-color-scheme: dark)):

* UserInterface/Views/Main.css:
(:root):

(@media (prefers-color-scheme: dark)):
* UserInterface/Views/NetworkDetailView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/NetworkTableContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/NewTabContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ObjectPreviewView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/OpenResourceDialog.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ProgressView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/QuickConsole.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/RecordingActionTreeElement.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/RecordingContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/RecordingStateDetailsSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ResourceSecurityContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ResourceSizesContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ResourceTimingBreakdownView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ScopeBar.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SearchBar.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SearchSidebarPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SettingsTabContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ShaderProgramContentView.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/ShaderProgramTreeElement.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SourceCodeTextEditor.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/TabBar.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/Table.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/TextEditor.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/TimelineDataGrid.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/TimelineIcons.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/TimelineOverview.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/Toolbar.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/TreeOutline.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/URLBreakpointPopover.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/Variables.css:
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/WebSocketContentView.css:
(@media (prefers-color-scheme: dark)):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix CompletionHandler assertions introduced today.
achristensen@apple.com [Wed, 9 Jan 2019 01:28:13 +0000 (01:28 +0000)]
Fix CompletionHandler assertions introduced today.
https://bugs.webkit.org/show_bug.cgi?id=193237

This reverts part of r239710 and all of r239725, r239738, and r239748 which unsuccessfully tried to fix all the assertions.
This code is a mess that will have to be cleaned up later.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::from):
* NetworkProcess/cache/CacheStorageEngine.h:
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::remove):
(WebKit::NetworkCache::Cache::traverse):
(WebKit::NetworkCache::Cache::clear):
(WebKit::NetworkCache::Cache::retrieveData):
* NetworkProcess/cache/NetworkCache.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::WriteOperation::~WriteOperation): Deleted.
* NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::store):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoBlob references for System Previews don't get a correct file extension
dino@apple.com [Wed, 9 Jan 2019 01:17:41 +0000 (01:17 +0000)]
Blob references for System Previews don't get a correct file extension
https://bugs.webkit.org/show_bug.cgi?id=193268
<rdar://problem/47133037>

Reviewed by Tim Horton.

Source/WebCore:

Apple platforms don't yet have a mapping from the USD MIME type to
file extensions (and we support some non-standard MIME types), which
means that downloads from Blob references don't get correctly named.

Fix this by adding an explicit mapping between System Preview types
and ".usdz".

WebKit API test: _WKDownload.SystemPreviewUSDZBlobNaming

* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSystemPreviewMIMEType): Remove USE(SYSTEM_PREVIEW) since
this applies to macOS and iOS now.
* platform/MIMETypeRegistry.h:
* platform/cocoa/MIMETypeRegistryCocoa.mm:
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): Add a mapping
for USDZ.

Tools:

New test that a Blob download of a USDZ file gets named correctly.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
(-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https...
jiewen_tan@apple.com [Wed, 9 Jan 2019 01:11:08 +0000 (01:11 +0000)]
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 6.

Add some additional temporary logging info to determine if data is actually sent.
Once the bug is determined and fixed, we should remove all logging added in this patch.

* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoEditable images sometimes don't become focused when tapped
timothy_horton@apple.com [Wed, 9 Jan 2019 01:09:06 +0000 (01:09 +0000)]
Editable images sometimes don't become focused when tapped
https://bugs.webkit.org/show_bug.cgi?id=193259
<rdar://problem/47038424>

Reviewed by Wenson Hsieh.

Often when tapping an editable image inside an editable text area, the
text area's selection will change instead of focusing the editable image.

No new tests; I have had no luck writing a test that reliably failed
beforehand (the "sometimes" is a problem).

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::defaultEventHandler):
* html/HTMLImageElement.h:
Override mousedown on editable images, focus the image, and prevent
the default behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoLeak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment...
ddkilzer@apple.com [Wed, 9 Jan 2019 00:56:35 +0000 (00:56 +0000)]
Leak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment in com.apple.WebKit.WebContent running layout tests
<https://webkit.org/b/193264>
<rdar://problem/46651026>

Reviewed by Yusuke Suzuki.

* parser/VariableEnvironment.cpp:
(JSC::CompactVariableMap::Handle::~Handle): Call delete on
m_environment instead of fastFree() to make sure the destructors
for the Vector instance variables are run.  This fixes the leaks
because calling fastFree() would only free the
CompactVariableEnvironment object, but not the heap-based
buffers allocated for the Vector instance variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[GTK] Updated Swedish translation
mcatanzaro@igalia.com [Wed, 9 Jan 2019 00:45:06 +0000 (00:45 +0000)]
[GTK] Updated Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=193257

Patch by Josef Andersson <josef.andersson@fripost.org> on 2019-01-08
Rubber-stamped by Michael Catanzaro.

* sv.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoASSERT when paused in debugger and console evaluation causes exception
commit-queue@webkit.org [Wed, 9 Jan 2019 00:39:45 +0000 (00:39 +0000)]
ASSERT when paused in debugger and console evaluation causes exception
https://bugs.webkit.org/show_bug.cgi?id=193246

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-01-08
Reviewed by Mark Lam.

Source/JavaScriptCore:

* runtime/VM.cpp:
(JSC::VM::throwException):
Improve assertion to allow for the debugger's evaluate on call frame condition.

* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::callFrameAtDebuggerEntry const):
(JSC::JSGlobalObject::setCallFrameAtDebuggerEntry):
Debugger call frame only used by assertions.

* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
* debugger/DebuggerEvalEnabler.h:
(JSC::DebuggerEvalEnabler::DebuggerEvalEnabler):
(JSC::DebuggerEvalEnabler::~DebuggerEvalEnabler):
When evaluating on a call frame, set a debug GlobalObject state.

LayoutTests:

* inspector/debugger/evaluateOnCallFrame-CommandLineAPI.html:
Correct a typo.

* inspector/debugger/evaluateOnCallFrame-exception-expected.txt: Added.
* inspector/debugger/evaluateOnCallFrame-exception.html: Added.
New test that would have asserted before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[WebAuthN] Support U2F HID Authenticators on macOS
jiewen_tan@apple.com [Wed, 9 Jan 2019 00:35:39 +0000 (00:35 +0000)]
[WebAuthN] Support U2F HID Authenticators on macOS
https://bugs.webkit.org/show_bug.cgi?id=191535
<rdar://problem/47102027>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch changes U2fCommandConstructor to produce register commands with
enforcing test of user presence. Otherwise, authenticators would silently
generate credentials. It also renames readFromU2fSignResponse to
readU2fSignResponse.

Tests: http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html
       http/wpt/webauthn/public-key-credential-create-failure-u2f.https.html
       http/wpt/webauthn/public-key-credential-create-success-u2f.https.html
       http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https.html
       http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html
       http/wpt/webauthn/public-key-credential-get-success-u2f.https.html

* Modules/webauthn/fido/U2fCommandConstructor.cpp:
(fido::WebCore::constructU2fRegisterCommand):
* Modules/webauthn/fido/U2fResponseConverter.cpp:
(fido::readU2fSignResponse):
(fido::readFromU2fSignResponse): Deleted.
* Modules/webauthn/fido/U2fResponseConverter.h:

Source/WebKit:

This patch implements the support for U2F authenticators, and enables it for hid devices.
It follows the CTAP spec to map WebAuthN requests to U2F commands and return the responses:
https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-client-to-authenticator-protocol-v2.0-id-20180227.html#u2f-interoperability
Most of the parts are done before this patch, this patch focues on: 7.2.2 and 7.3.2.

Besides implementing the U2fHidAuthenticator, this patch also adds support in the mocking
environment for U2F authenticators. It is done by extending the stages in MockHidConnection
from 4 to indefinite as multi-round communications are expected to map WebAuthN requests
to U2F requests.

* Sources.txt:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
* UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::continueAddDeviceAfterGetInfo):
* UIProcess/WebAuthentication/fido/CtapHidDriver.cpp:
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
* UIProcess/WebAuthentication/fido/CtapHidDriver.h:
(WebKit::CtapHidDriver::setProtocol):
* UIProcess/WebAuthentication/fido/U2fHidAuthenticator.cpp: Added.
(WebKit::U2fHidAuthenticator::U2fHidAuthenticator):
(WebKit::U2fHidAuthenticator::makeCredential):
(WebKit::U2fHidAuthenticator::checkExcludeList):
(WebKit::U2fHidAuthenticator::issueRegisterCommand):
(WebKit::U2fHidAuthenticator::getAssertion):
(WebKit::U2fHidAuthenticator::issueSignCommand):
(WebKit::U2fHidAuthenticator::issueNewCommand):
(WebKit::U2fHidAuthenticator::issueCommand):
(WebKit::U2fHidAuthenticator::responseReceived):
(WebKit::U2fHidAuthenticator::continueRegisterCommandAfterResponseReceived):
(WebKit::U2fHidAuthenticator::continueCheckOnlyCommandAfterResponseReceived):
(WebKit::U2fHidAuthenticator::continueBogusCommandAfterResponseReceived):
(WebKit::U2fHidAuthenticator::continueSignCommandAfterResponseReceived):
* UIProcess/WebAuthentication/fido/U2fHidAuthenticator.h: Added.
* UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::parseRequest):
(WebKit::MockHidConnection::feedReports):
* UIProcess/WebAuthentication/Mock/MockHidConnection.h:
* UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h:
* WebKit.xcodeproj/project.pbxproj:

Tools:

This patch:
1) adds support for U2F mocking mechanism;
2) updates tests to reflect U2fCommandConstructor changes.

* TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebCore/FidoTestData.h:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setWebAuthenticationMockConfiguration):

LayoutTests:

Besiding adding tests for U2F authenticators, it also changes payloadBase64 from
a string to a vector of strings. New tests are skipped for iOS.

* http/wpt/webauthn/ctap-hid-failure.https.html:
* http/wpt/webauthn/ctap-hid-success.https.html:
* http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
* http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
* http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html: Added.
* http/wpt/webauthn/public-key-credential-create-failure-u2f.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-create-failure-u2f.https.html: Added.
* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
* http/wpt/webauthn/public-key-credential-create-success-u2f.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-create-success-u2f.https.html: Copied from LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html.
* http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
* http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
* http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-get-failure-u2f-silent.https.html: Added.
* http/wpt/webauthn/public-key-credential-get-failure-u2f.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-get-failure-u2f.https.html: Added.
* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
* http/wpt/webauthn/public-key-credential-get-success-u2f.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-get-success-u2f.https.html: Added.
* http/wpt/webauthn/resources/util.js:
* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months ago[iOS] Dispatch a synthetic mousedown event prior to starting drags
wenson_hsieh@apple.com [Wed, 9 Jan 2019 00:10:24 +0000 (00:10 +0000)]
[iOS] Dispatch a synthetic mousedown event prior to starting drags
https://bugs.webkit.org/show_bug.cgi?id=193229
<rdar://problem/46717097>

Reviewed by Tim Horton.

Source/WebCore:

Tweaks some drag initiation logic on iOS to actually send a "mousedown" event to the page prior to drag start.
This improves drag and drop compatibility with web pages that expect a mousedown to always precede dragging.
Additionally, ensure that preventing the "mousedown" event also prevents "dragstart", which matches macOS
behavior.

Test: DragAndDropTests.PreventingMouseDownShouldPreventDragStart

* page/EventHandler.cpp:

Make the text drag delay 0 on iOS. This was introduced on iOS when originally bringing up drag and drop, and was
made to simply match macOS. However, it doesn't make sense to respect the delay here, since the purpose of this
delay is to disambiguate between making a text selection and starting a drag when pressing on text that is
already selected; on iOS (including iOSMac), this gesture conflict is already resolved by platform gesture
recognizers in the client layer, so there is always no delay between mouse down and drag here.

* page/ios/EventHandlerIOS.mm:

Dispatch a mousedown and inspect the value of `m_mouseDownMayStartDrag` when starting a drag on iOS. This brings
our behavior closer in line with macOS.

(WebCore::EventHandler::tryToBeginDataInteractionAtPoint):

Tools:

Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
prevents a drag from starting.

* TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
* TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:

Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoservice worker fetch handler results in bad referrer
youenn@apple.com [Tue, 8 Jan 2019 23:06:12 +0000 (23:06 +0000)]
service worker fetch handler results in bad referrer
https://bugs.webkit.org/show_bug.cgi?id=188248
<rdar://problem/47050478>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/referrer-policy-header.https-expected.txt:

Source/WebCore:

Response sanitization was removing the ReferrerPolicy header from opaque redirect responses.
Reduce sanitization of opaque redirect responses to opaque responses and allow Location header.
Make sure referrer policy is updated for all load redirections, not only CORS loads.

Test: http/tests/security/referrer-policy-redirect-link-downgrade.html

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
* platform/network/ResourceResponseBase.cpp:
(WebCore::isSafeCrossOriginResponseHeader):
(WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting):

Source/WebKit:

NetworkDataTaskCocoa is sometimes updating the referrer on its own.
Instead of updating the referrer when sending the request to WebProcess for evaluation,
Update the referrer once the web process decides to follow the redirection.
This ensures that any referrer that the WebProcess will set will be updated by NetworkDataTaskCocoa.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

LayoutTests:

* http/tests/security/referrer-policy-redirect-link-downgrade-expected.txt: Added.
* http/tests/security/referrer-policy-redirect-link-downgrade.html: Added.
* http/tests/security/resources/referrer-policy-redirect-link-downgrade.html: Added.
* http/tests/security/resources/referrer-policy-redirect-link.html:
* platform/ios-wk2/TestExpectations: Skip referrer-policy-redirect-link-downgrade.html
as it is very similar to already skipped referrer-policy-redirect-link.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoFix more assertions after r239710
achristensen@apple.com [Tue, 8 Jan 2019 22:23:12 +0000 (22:23 +0000)]
Fix more assertions after r239710
https://bugs.webkit.org/show_bug.cgi?id=193237

* NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::store):
Make default parameter an empty lambda instead of a null CompletionHandler.
This way it can be called once instead of thinking it has already been called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 months agoMove ResourceLoadStatistics files from UIProcess to NetworkProcess
bfulgham@apple.com [Tue, 8 Jan 2019 22:02:16 +0000 (22:02 +0000)]
Move ResourceLoadStatistics files from UIProcess to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=193252
<rdar://problem/47125401>

Reviewed by Alex Christensen.

This patch is the first part of a refactoring to move the ResourceLoadStatistics logic from the UIProcess to the NetworkProcess.

This patch moves code into different folders and adjusts necessary build files, but does not change where the code executes. These
changes have no impact on behavior or test results.

I also modified a few files to add missing include files uncovered by the unified build system.

* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: Renamed from Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp.
* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h: Renamed from Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.h.
* NetworkProcess/Classifier/ResourceLoadStatisticsPersistentStorage.cpp: Renamed from Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.cpp.
* NetworkProcess/Classifier/ResourceLoadStatisticsPersistentStorage.h: Renamed from Source/WebKit/UIProcess/ResourceLoadStatisticsPersistentStorage.h.
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: Renamed from Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp.
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h: Renamed from Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h.
* NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.cpp: Renamed from Source/WebKit/UIProcess/WebResourceLoadStatisticsTelemetry.cpp.
* NetworkProcess/Classifier/WebResourceLoadStatisticsTelemetry.h: Renamed from Source/WebKit/UIProcess/WebResourceLoadStatisticsTelemetry.h.
* NetworkProcess/Downloads/PendingDownload.cpp:
* NetworkProcess/Downloads/PendingDownload.h:
* CMakeLists.txt:
* PlatformMac.cmake:
* PlatformWin.cmake:
* Shared/PersistencyUtils.cpp: Renamed from Source/WebKit/UIProcess/PersistencyUtils.cpp.
* Shared/PersistencyUtils.h: Renamed from Source/WebKit/UIProcess/PersistencyUtils.h.
* Sources.txt:
* SourcesCocoa.txt:
* SourcesGTK.txt:
* SourcesWPE.txt:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration): Add missing WebKit:: scope.
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Add missing include.
* UIProcess/WebDataListSuggestionsDropdown.cpp: Ditto.
* UIProcess/mac/DisplayLink.cpp:
* UnifiedSources-input.xcfilelist:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239747 268f45cc-cd09-0410-ab3c-d52691b4dbfc