WebKit-https.git
7 years agoUnreviewed build fix after r137167.
eric.carlson@apple.com [Mon, 10 Dec 2012 19:14:45 +0000 (19:14 +0000)]
Unreviewed build fix after r137167.

* WebCore.xcodeproj/project.pbxproj: Add InbandTextTrackPrivate.h to framework private
    headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the GTK+ build after a collision of two patches.
mrobinson@webkit.org [Mon, 10 Dec 2012 19:09:39 +0000 (19:09 +0000)]
Fix the GTK+ build after a collision of two patches.

Unreviewed build fix.

* bindings/gobject/GNUmakefile.am: The GObject DOM bindings library needs to
include the harfbuzz cflags when compiling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Make hiddenPageDomTimerInterval a setting
commit-queue@webkit.org [Mon, 10 Dec 2012 19:05:44 +0000 (19:05 +0000)]
Source/WebCore: Make hiddenPageDomTimerInterval a setting
https://bugs.webkit.org/show_bug.cgi?id=104555

Patch by Parth Patel <parpatel@rim.com> on 2012-12-10
Reviewed by Yong Li.

Make hiddenPageDomTimerInterval a setting so client can customize it.

No new tests are needed.

* page/Page.cpp:
(WebCore):
(WebCore::Page::setVisibilityState):
* page/Settings.cpp:
(WebCore):
(WebCore::Settings::setHiddenPageDOMTimerAlignmentInterval):
(WebCore::Settings::hiddenPageDOMTimerAlignmentInterval):
* page/Settings.h:
(Settings):

Source/WebKit/blackberry: [BlackBerry] Make hiddenPageDomTimerInterval a setting
https://bugs.webkit.org/show_bug.cgi?id=104555

Patch by Parth Patel <parpatel@rim.com> on 2012-12-10
Reviewed by Yong Li.

HiddenPageDomTimerInterval in setting in webcore can be utilized by browser application
when needed.

* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch print-expectations doesn't work right for platforms w/ shared expectations
dpranke@chromium.org [Mon, 10 Dec 2012 19:04:57 +0000 (19:04 +0000)]
webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
https://bugs.webkit.org/show_bug.cgi?id=104405

Reviewed by Eric Seidel.

If multiple ports shared a TestExpectations file, webkit-patch
print-expectations would use the expectation for the first port
using that file and print the result for all ports, rather than
re-parse and print each port separately (e.g., we might print
the chromium-linux expectation for a file for both chromium-linux
and chromium-mac). Discovered while testing/debugging the fix
for bug 104403.

* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort._skipped_tests_for_unsupported_features):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations._model):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_platform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: fix total number of tests computed in the result summary
dpranke@chromium.org [Mon, 10 Dec 2012 18:58:39 +0000 (18:58 +0000)]
nrwt: fix total number of tests computed in the result summary
https://bugs.webkit.org/show_bug.cgi?id=104061

Reviewed by Jochen Eisinger.

Good thing I left this open, because I actually broke it again
the same way in a merge. Fix the computation of the one_line_summary
again, and add tests for it (also clean up some redundant tests).

Also, add constants into the test port code so that the knowledge
of how many tests should fail and how is next to the list of tests,
rather than a totally different place.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestList.__getitem__):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_test_results):
(MainTest.setUp):
(MainTest.test_basic):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code.CustomExitCodePort):
(MainTest.test_tolerance.ImageDiffTestPort):
(EndToEndTest.parse_full_results):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Compile fix in ImageCairoWin.cpp
commit-queue@webkit.org [Mon, 10 Dec 2012 18:47:20 +0000 (18:47 +0000)]
[WinCairo] Compile fix in ImageCairoWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=104554

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-12-10
Reviewed by Brent Fulgham.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize): Added parameter.
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Added parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
zandobersek@gmail.com [Mon, 10 Dec 2012 18:47:17 +0000 (18:47 +0000)]
Unreviewed gardening.

Adding failure expectations for failing http tests that started
failing on EFL and GTK after the Jhbuild libsoup was bumped to 2.40.0.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLog to console when script is blocked by sandbox attributes.
mkwst@chromium.org [Mon, 10 Dec 2012 18:42:46 +0000 (18:42 +0000)]
Log to console when script is blocked by sandbox attributes.
https://bugs.webkit.org/show_bug.cgi?id=104365

Reviewed by Ojan Vafai.

Source/WebCore:

Adds a console message to cover script execution blocked within the
context of a sandboxed frame which lacks the 'allow-scripts' permission.

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
    Log a warning when sandboxing flags block script execution.

Tools:

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
    Ignoring the new console message in perftests, as it broke parsing
    for the Parser/html-parser.html microbenchmark.

LayoutTests:

* fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
* fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
* fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
* fast/frames/sandboxed-iframe-scripting-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
* http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
* http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
* http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
* media/video-controls-no-scripting-expected.txt:
    Rebaselining tests with new expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC profiling and debug dump code should use inferred names when possible
fpizlo@apple.com [Mon, 10 Dec 2012 18:38:15 +0000 (18:38 +0000)]
JSC profiling and debug dump code should use inferred names when possible
https://bugs.webkit.org/show_bug.cgi?id=104519

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This does as advertised: the profiler now knows the inferred name of all code blocks,
and all uses of CodeBlock::dump() dump it along with the hash.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::dumpAssumingJITType):
* bytecode/CodeBlock.h:
* profiler/ProfilerBytecodes.cpp:
(JSC::Profiler::Bytecodes::Bytecodes):
(JSC::Profiler::Bytecodes::toJS):
* profiler/ProfilerBytecodes.h:
(JSC::Profiler::Bytecodes::inferredName):
* profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::addBytecodes):
(JSC::Profiler::Database::ensureBytecodesFor):
* profiler/ProfilerDatabase.h:
* runtime/CommonIdentifiers.h:

Tools:

The format I'm using for referring to a code block is now name#hash. For example,
v8-crypto has something called bnpSquareTo#B5QFbU. The profiler allows you to use
either the hash, the inferred name, or the combined hash and full name when referring
to blocks.

* Scripts/display-profiler-output:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Crash in NSAccessibilityUnignoredDescendant
cfleizach@apple.com [Mon, 10 Dec 2012 18:36:25 +0000 (18:36 +0000)]
AX: Crash in NSAccessibilityUnignoredDescendant
https://bugs.webkit.org/show_bug.cgi?id=104468

Reviewed by Anders Carlsson.

This crash occurred because AccessibilityScrollView stopped retaining it's ScrollView pointer.

Unfortunately, there was still a case that didn't correctly clear that variable.

That case was when a Frame had a new FrameView associated with it. The old FrameView didn't inform the
accessibility object cache that it should be removed. As a result, when the FrameView deallocated and
did try to remove, it used the wrong AXObjectCache because it was no longer correctly hooked into the
document tree.

No new tests. Existing tests will stop crashing.

* page/Frame.cpp:
(WebCore::Frame::setView): change the name of the method that tells the FrameView to detach
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::removeFromAXObjectCache): add a method that can be called in multiple places
(WebCore::FrameView::isFrameView):
(WebCore::FrameView::prepareForDetach): detaches scrollbars and accessibility
* page/FrameView.h:
(FrameView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move getPluginsList out of PlatformSupport
pilgrim@chromium.org [Mon, 10 Dec 2012 18:22:28 +0000 (18:22 +0000)]
[Chromium] Move getPluginsList out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96507

Reviewed by Darin Fisher.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::getPluginList):
* chromium/public/WebPluginListBuilder.h: Added.
(WebKit):
(WebPluginListBuilder):

Source/WebCore:

* WebCore.gypi:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginCache::plugins):
* plugins/chromium/PluginListBuilder.cpp: Added.
(WebKit):
(WebKit::PluginListBuilder::addPlugin):
(WebKit::PluginListBuilder::addMediaTypeToLastPlugin):
(WebKit::PluginListBuilder::addFileExtensionToLastMediaType):
* plugins/chromium/PluginListBuilder.h: Added.
(WebKit):
(PluginListBuilder):
(WebKit::PluginListBuilder::PluginListBuilder):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebPluginListBuilder.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::idbFactory):
* src/WebPluginListBuilderImpl.cpp: Removed.
* src/WebPluginListBuilderImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 10 Dec 2012 18:21:31 +0000 (18:21 +0000)]
Unreviewed GTK gardening.

Fixing most of the expectations added in r137153, the baselines are missing so the expectations
are changed according to that. The a11y gurus will have a look at them and determine what the
baselines should look like and whether the tests can be fixed.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProfiler should say things about OSR exits
fpizlo@apple.com [Mon, 10 Dec 2012 18:17:46 +0000 (18:17 +0000)]
Profiler should say things about OSR exits
https://bugs.webkit.org/show_bug.cgi?id=104497

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This adds support for profiling OSR exits. For each exit that is taken, the profiler
records the machine code address that the exit occurred on, the exit kind, the origin
stack, and the number of times that it happened.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/AbstractMacroAssembler.h:
(Jump):
(JSC::AbstractMacroAssembler::Jump::label):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::saveCompilation):
(CodeBlock):
(JSC::CodeBlock::compilation):
(DFGData):
* bytecode/DFGExitProfile.h:
(DFG):
* bytecode/ExitKind.cpp: Added.
(JSC):
(JSC::exitKindToString):
(JSC::exitKindIsCountable):
(WTF):
(WTF::printInternal):
* bytecode/ExitKind.h: Added.
(JSC):
(WTF):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JITCompiler):
* dfg/DFGOSRExitCompiler.cpp:
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JIT):
* jit/JumpReplacementWatchpoint.h:
(JSC::JumpReplacementWatchpoint::sourceLabel):
(JumpReplacementWatchpoint):
* profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::addOSRExitSite):
(Profiler):
(JSC::Profiler::Compilation::addOSRExit):
(JSC::Profiler::Compilation::toJS):
* profiler/ProfilerCompilation.h:
(Compilation):
* profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::newCompilation):
* profiler/ProfilerDatabase.h:
(Database):
* profiler/ProfilerOSRExit.cpp: Added.
(Profiler):
(JSC::Profiler::OSRExit::OSRExit):
(JSC::Profiler::OSRExit::~OSRExit):
(JSC::Profiler::OSRExit::toJS):
* profiler/ProfilerOSRExit.h: Added.
(Profiler):
(OSRExit):
(JSC::Profiler::OSRExit::id):
(JSC::Profiler::OSRExit::origin):
(JSC::Profiler::OSRExit::exitKind):
(JSC::Profiler::OSRExit::isWatchpoint):
(JSC::Profiler::OSRExit::counterAddress):
(JSC::Profiler::OSRExit::count):
* profiler/ProfilerOSRExitSite.cpp: Added.
(Profiler):
(JSC::Profiler::OSRExitSite::toJS):
* profiler/ProfilerOSRExitSite.h: Added.
(Profiler):
(OSRExitSite):
(JSC::Profiler::OSRExitSite::OSRExitSite):
(JSC::Profiler::OSRExitSite::codeAddress):
* runtime/CommonIdentifiers.h:

Tools:

Adds support for displaying OSR exit information for full summary (just displays the
counts and the number of recompilations), bytecode display (says which bytecodes
exited), and DFG display (annotates disassembly with taken OSR exits and their
counts).

* Scripts/display-profiler-output:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinspector/styles/styles-computed-trace still times out after r137156.
adamk@chromium.org [Mon, 10 Dec 2012 17:58:55 +0000 (17:58 +0000)]
inspector/styles/styles-computed-trace still times out after r137156.

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build GObject DOM bindings as a separate library
carlosgc@webkit.org [Mon, 10 Dec 2012 17:55:00 +0000 (17:55 +0000)]
[GTK] Build GObject DOM bindings as a separate library
https://bugs.webkit.org/show_bug.cgi?id=104527

Reviewed by Xan Lopez.

Source/WebCore:

* bindings/gobject/GNUmakefile.am: Add libWebCoreDOM library.
* bindings/gobject/WebKitDOMBinding.h: Define private macros.
* bindings/gobject/WebKitDOMCustom.h: Don't include webkit/webkitdefines.h.
* bindings/gobject/WebKitDOMEventTarget.h: Ditto.
* bindings/gobject/WebKitDOMObject.h: Ditto.
* bindings/scripts/CodeGeneratorGObject.pm:
(Generate): Don't include webkitglobalsprivate.h.
(WriteData): Don't include webkit/webkitdefines.h.
* bindings/scripts/gobject-generate-headers.pl: Define WEBKIT_API
macro in webkitdomdefines.h.
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestException.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestNode.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:

Source/WebKit/gtk:

* GNUmakefile.am: Link to libWebCoreDOM.la.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved failing test expectations for GTK+ port after r137107.
rniwa@webkit.org [Mon, 10 Dec 2012 17:53:50 +0000 (17:53 +0000)]
Removed failing test expectations for GTK+ port after r137107.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIn InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default.
adamk@chromium.org [Mon, 10 Dec 2012 17:48:33 +0000 (17:48 +0000)]
In InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default.

Unreviewed build fix.

* platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::label):
(WebCore::InbandTextTrackPrivate::language):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium test expectations update after r137152.
adamk@chromium.org [Mon, 10 Dec 2012 17:35:21 +0000 (17:35 +0000)]
Chromium test expectations update after r137152.
Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: instrument RenderBox descendants.
loislo@chromium.org [Mon, 10 Dec 2012 17:31:35 +0000 (17:31 +0000)]
Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants.
https://bugs.webkit.org/show_bug.cgi?id=104026

Reviewed by Eric Seidel.

Plain vanilla instrumentation for RenderBox descendants.

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
* rendering/RenderFrameSet.h:
(RenderFrameSet):
(GridAxis):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::reportMemoryUsage):
(WebCore):
* rendering/RenderListMarker.h:
(RenderListMarker):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::reportMemoryUsage):
(WebCore):
* rendering/RenderReplaced.h:
(RenderReplaced):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::reportMemoryUsage):
(WebCore):
* rendering/RenderTableCol.h:
(RenderTableCol):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::reportMemoryUsage):
(WebCore):
* rendering/RenderTableRow.h:
(RenderTableRow):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
* rendering/RenderTableSection.h:
(CellStruct):
(RowStruct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: wrong Enabled states on a ListBox
commit-queue@webkit.org [Mon, 10 Dec 2012 17:30:23 +0000 (17:30 +0000)]
AX: wrong Enabled states on a ListBox
https://bugs.webkit.org/show_bug.cgi?id=104483

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/listbox-enabled-states.html

* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled): taking into
account the DISABLED attribute and the aria-disabled attribute to
decide if the item is enabled or not.

LayoutTests:

* accessibility/listbox-enabled-states-expected.txt: Added.
* accessibility/listbox-enabled-states.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocr-win build fix after r137161.
adamk@chromium.org [Mon, 10 Dec 2012 17:28:02 +0000 (17:28 +0000)]
cr-win build fix after r137161.

Unreviewed.

* platform/graphics/MediaPlayer.h: Replace forward-decl of
InbandTextTrackPrivate with #include as the definition is required.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
alexis@webkit.org [Mon, 10 Dec 2012 17:25:58 +0000 (17:25 +0000)]
[CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
https://bugs.webkit.org/show_bug.cgi?id=104539

Reviewed by Antonio Gomes.

.:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

No new tests : the feature is covered by various tests and it is already enabled in many ports.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.features.am:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):
* css/CSSParser.h:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
* rendering/style/FillLayer.cpp:
(SameSizeAsFillLayer):
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::backgroundXOrigin):
(WebCore::FillLayer::backgroundYOrigin):
(WebCore::FillLayer::isBackgroundOriginSet):
(WebCore::FillLayer::clearXPosition):
(WebCore::FillLayer::clearYPosition):
(FillLayer):

Source/WebKit/chromium:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* features.gypi:

Source/WebKit/mac:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* Configurations/FeatureDefines.xcconfig:

Tools:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the related CSS3 <position> type tests for background-position
as now the feature is enabled by default.

* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove expectation of previously failing test.
adamk@chromium.org [Mon, 10 Dec 2012 17:19:55 +0000 (17:19 +0000)]
Remove expectation of previously failing test.
It passes after r137152.

Unreviewed gardening.

* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitWebViewBase produces a warning if compiled with gcc
commit-queue@webkit.org [Mon, 10 Dec 2012 17:14:13 +0000 (17:14 +0000)]
WebKitWebViewBase produces a warning if compiled with gcc
https://bugs.webkit.org/show_bug.cgi?id=104561

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-10
Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.h:
since this file can be included from C code, use void to
explicitly specify that webkit_web_view_base_get_type() doesn't
have parameters. Otherwise we get "warning: function declaration
isn't a prototype" with -Wstrict-prototypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix warning for comparison between signed and unsigned
nghanavatian@rim.com [Mon, 10 Dec 2012 17:01:52 +0000 (17:01 +0000)]
[BlackBerry] Fix warning for comparison between signed and unsigned
https://bugs.webkit.org/show_bug.cgi?id=104563

Reviewed by Rob Buis.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove the support for building a debug WebKit with a release Qt
jocelyn.turcotte@digia.com [Mon, 10 Dec 2012 16:56:21 +0000 (16:56 +0000)]
[Qt] Remove the support for building a debug WebKit with a release Qt
https://bugs.webkit.org/show_bug.cgi?id=104560

Reviewed by Tor Arne Vestbø.

This creates issues with non-framework builds of Qt (necessary for debug-only
builds) since a Qt5 prefix is now added to the base target name.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for in-band text tracks to Mac port
eric.carlson@apple.com [Mon, 10 Dec 2012 16:19:56 +0000 (16:19 +0000)]
Add support for in-band text tracks to Mac port
https://bugs.webkit.org/show_bug.cgi?id=103663

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-in-band.html

* GNUmakefile.list.am: Move InbandTextTrackPrivate.h to platform/graphics. Add InbandTextTrackPrivateClient.h.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.

* WebCore.xcodeproj/project.pbxproj: Add new files.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): No need to call processInbandTextTracks, in-band tracks
    are now registered by the media engine as they are discovered.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): New, called by the media player when a new
    in-band track is found.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTrack): New, called by the media player when an
    in-band track goes away.
* html/HTMLMediaElement.h:

* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack): Use m_private instead of tracksPrivate because
    it is zeroed during assignment.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::addTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses
    to add a new in-band track.
(WebCore::MediaPlayer::removeTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses
    to remove a new in-band track.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Added.
(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF):
(WebCore::InbandTextTrackPrivateAVF::~InbandTextTrackPrivateAVF):
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Convert an attribute string into WebVTT
    cue setting and content strings.
(WebCore::InbandTextTrackPrivateAVF::processCue): Process a new cue.
(WebCore::InbandTextTrackPrivateAVF::disconnect): Clear member variables.
(WebCore::InbandTextTrackPrivateAVF::resetCueValues): Reset cue values to defaults.
(WebCore::InbandTextTrackPrivateAVF::setMode): Set track mode and call player's trackModeChanged.
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Added.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Initialize
    m_inbandTrackConfigurationPending.
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Flush the currently accumulating
    cue so it doesn't get the wrong duration.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Handle InbandTracksNeedConfiguration.
(WebCore::MediaPlayerPrivateAVFoundation::flushCurrentCue): New, pass the current cue up to the client.
(WebCore::MediaPlayerPrivateAVFoundation::configureInbandTracks): Configure in-band tracks.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Schedule a call to configureInbandTracks.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h: Added.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm: Added.
(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC):
(WebCore::InbandTextTrackPrivateAVFObjC::disconnect):
(WebCore::InbandTextTrackPrivateAVFObjC::kind): Return track kind.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Return track label.
(WebCore::InbandTextTrackPrivateAVFObjC::language): Return track language.
(WebCore::InbandTextTrackPrivateAVFObjC::isDefault):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItem):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize m_currentTrack.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Clear m_legibleOutput.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create and initialize m_legibleOutput.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Called when the player item's
    "tracks" changes, add and remove in-band text tracks as necessary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): Pass an attributed string to the current
    track to be processed.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Tell AVFoundation to select an in-band track.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTrack): Return the current track.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]): Legible
    output delegate.

Source/WTF:

* wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT.

LayoutTests:

Test for initial support for in-band text tracks. New test skipped on all ports that don't
have support in the media engine.

* media/content/counting-subtitled.m4v: Added.
* media/track/track-in-band-expected.txt: Added.
* media/track/track-in-band.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix front-end compilation warnings
pfeldman@chromium.org [Mon, 10 Dec 2012 16:18:20 +0000 (16:18 +0000)]
Web Inspector: fix front-end compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=104557

Reviewed by Alexander Pavlov.

Corresponding annotations added.

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightNode):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.highlightDOMNode):
* inspector/front-end/DOMPresentationUtils.js:
(WebInspector.DOMPresentationUtils.linkifyNodeReference):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/Toolbar.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.
zeno.albisser@digia.com [Mon, 10 Dec 2012 16:10:57 +0000 (16:10 +0000)]
[Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.
https://bugs.webkit.org/show_bug.cgi?id=104550

With Qt5 QPainter changed to using the raster engine.
Therefore we no longer have an NSGraphicsContext that we can
use for drawing video frames.
With this patch we are rendering the video frame into an image buffer
and then paint it manually using QPainter.

Reviewed by Simon Hausmann.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore):
(WebCore::swapBgrToRgb):
    Swap the color format from BGR to RGB,
    since BGR is not supported by QImage.
(WebCore::MediaPlayerPrivateQTKit::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Link fix in InspectorController.cpp
commit-queue@webkit.org [Mon, 10 Dec 2012 16:00:37 +0000 (16:00 +0000)]
[WinCairo] Link fix in InspectorController.cpp
https://bugs.webkit.org/show_bug.cgi?id=104556

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-12-10
Reviewed by Pavel Feldman.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController): Added missing #if check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add 'WebKit/chromium/win8' to .gitignore
mkwst@chromium.org [Mon, 10 Dec 2012 15:28:43 +0000 (15:28 +0000)]
[chromium] Add 'WebKit/chromium/win8' to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=104534

Reviewed by Jochen Eisinger.

I've now added it via 'git add' once, and via 'git commit -a' twice.
Let's make that more difficult, shall we?

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: Web Inspector: update test expectation for inspector/styles/styles-comput...
loislo@chromium.org [Mon, 10 Dec 2012 15:23:37 +0000 (15:23 +0000)]
Unreviewed: Web Inspector: update test expectation for inspector/styles/styles-computed-trace.html.
it is slow in debug version. ~20 sec on linux.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
mrobinson@webkit.org [Mon, 10 Dec 2012 15:20:47 +0000 (15:20 +0000)]
Build fix.

Add a patchfile missing from my previous commit.

* gtk/patches/harfbuzz-icu-detection-fix.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove the Overrides / Settings context menu from gear icon
pfeldman@chromium.org [Mon, 10 Dec 2012 15:20:30 +0000 (15:20 +0000)]
Web Inspector: remove the Overrides / Settings context menu from gear icon
https://bugs.webkit.org/show_bug.cgi?id=104546

Reviewed by Alexander Pavlov.

It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now.
Moving present behavior to under experiment.

* inspector/front-end/OverridesView.js:
(WebInspector.OverridesView):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.OverridesSettingsTab):
(WebInspector.SettingsController):
(WebInspector.SettingsController.prototype.get statusBarItem):
(WebInspector.SettingsController.prototype._mouseDown.showSettings):
(WebInspector.SettingsController.prototype._mouseDown):
(WebInspector.SettingsController.prototype._mouseUp):
* inspector/front-end/helpScreen.css:
(#settings-screen .tabbed-pane-header):
(#settings-screen .tabbed-pane-header-tabs):
(#settings-screen .tabbed-pane-header-tab):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 10 Dec 2012 15:16:10 +0000 (15:16 +0000)]
Unreviewed GTK gardening.

Unskipping 8 failing accessibility tests, adding expected failures for them.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVisual order of empty value placeholder in INPUT_MULTIPLE_FIELDS_UI is wrong in RTL
tkent@chromium.org [Mon, 10 Dec 2012 15:13:16 +0000 (15:13 +0000)]
Visual order of empty value placeholder in INPUT_MULTIPLE_FIELDS_UI is wrong in RTL
https://bugs.webkit.org/show_bug.cgi?id=104438

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This updates datetimelocal-appearance-l10n.html for he-il
and ar-eg locales.

* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
We should not append Right-to-left-mark to each of placeholder
strings. It makes numeric field separators such as ':' and '/' RTL, and
makes a wrong visual order. We use unicode-bidi:bidi-override and
direction:ltr instead. It means we force LTR only to this element
* html/shadow/DateTimeNumericFieldElement.h:
Makes m_placeholder const again.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
Explicitly set right-to-left-mark before S, WS, ON types according to
Unicod Bidirectional Algorithm Table 4 [1]. This is needed because we
don't have context like "This literal follows European/Arabic numbers"
in a case of showing placeholders.
[1] http://www.unicode.org/reports/tr9/#Bidirectional_Character_Types

LayoutTests:

* platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium/TestExpectations:
Update bug numbers and add time-multiple-fields-localization.html.
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
Adjust test scenario for the new behavior.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(137127): Causes assertion failures on the debug bots
commit-queue@webkit.org [Mon, 10 Dec 2012 15:11:52 +0000 (15:11 +0000)]
REGRESSION(137127): Causes assertion failures on the debug bots
https://bugs.webkit.org/show_bug.cgi?id=104549

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-10
Reviewed by Alejandro G. Castro.

After handling the new TextOutput message we should return the method
handling messages received.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Soup] utilize multipart/x-mixed-replace support recently added to libsoup
kov@webkit.org [Mon, 10 Dec 2012 15:02:57 +0000 (15:02 +0000)]
[Soup] utilize multipart/x-mixed-replace support recently added to libsoup
https://bugs.webkit.org/show_bug.cgi?id=94515

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-12-09
Reviewed by Martin Robinson.

.:

* configure.ac: require soup 2.40.0, which adds the new support.

Source/WebCore:

The multipart/x-mixed-replace content type is often used for providing
"push" server support, with each part in the multipart response
replacing the previous one in the rendering. Soup recently acquired
support for multipart/x-mixed replace, which this change utilizes.

Covered by existing multipart/x-mixed-replace tests.

* platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal): add new member to this class, the multipart input stream
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation): also clear the multipart input stream on
cleanup
(WebCore::nextPartCallback): callback that handles reporting the new response delivered
with the new part, if any; uses the factored out updateFromSoupMessageHeaders method
(WebCore::sendRequestCallback): handle multipart/x-mixed-replace responses by
requesting the next part
(WebCore::readCallback): when reading has finished, request the next part when
handling a multipart/x-mixed-replace response
* platform/network/soup/ResourceResponse.h:
(ResourceResponse): add declaration for new method
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage): call new updateFromSoupMessageHeaders
method, instead of dealing with the message headers directly
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): new method, factored out from
updateFromSoupMessage, so this same code can be reused for updating responses for
multipart/x-mixed-replace responses parts

Tools:

This change requires a very recent libsoup, so update our jhbuild
requirements.

* gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace
support
* efl/jhbuild.modules: ditto

LayoutTests:

* platform/efl/TestExpectations: adjust expectations for tests that now pass.
* platform/gtk/TestExpectations: ditto.
* platform/gtk-wk2/TestExpectations: add missing multipart tests expectations.
* platform/gtk/http/tests/multipart/invalid-image-data-expected.png: new baseline
* platform/gtk/http/tests/multipart/invalid-image-data-expected.txt: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageVie...
commit-queue@webkit.org [Mon, 10 Dec 2012 14:58:52 +0000 (14:58 +0000)]
[WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale
https://bugs.webkit.org/show_bug.cgi?id=104544

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

Removed 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale()
as it was not used by anyone.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didRenderFrame):
* UIProcess/PageViewportControllerClient.h:
(PageViewportControllerClient):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setContentsScale):
* UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::setContentsScale):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement testRunner.setViewModeMediaFeature() in WebKitTestRunner
commit-queue@webkit.org [Mon, 10 Dec 2012 14:57:39 +0000 (14:57 +0000)]
Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=103886

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Export symbol for WebCore::Page::setViewMode on Mac.

No new tests, no behavior change for layout tests.

* WebCore.exp.in:

Source/WebKit2:

Add support for TestRunner::setViewModeMediaFeature().
This functionality is needed by the following LayoutTests:
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
fast/media/view-mode-media-feature.html

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetViewMode):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewMode):
(WebKit):
* WebProcess/WebPage/WebPage.h:
(WebPage):

Tools:

Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
This API is required by layout tests.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setViewModeMediaFeature):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Unskipping the following tests for EFL WebKit2:
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
fast/media/view-mode-media-feature.html

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix QtWebProcess discovery on Windows
hausmann@webkit.org [Mon, 10 Dec 2012 14:54:01 +0000 (14:54 +0000)]
[Qt] Fix QtWebProcess discovery on Windows
https://bugs.webkit.org/show_bug.cgi?id=104552

Reviewed by Jocelyn Turcotte.

Make sure to look for QtWebProcess.exe on Windows instead of QtWebProcess.

* Shared/qt/ProcessExecutablePathQt.cpp:
(WebKit::executablePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Bring Harfbuzz-ng support to Gtk
mrobinson@webkit.org [Mon, 10 Dec 2012 14:50:44 +0000 (14:50 +0000)]
[GTK] Bring Harfbuzz-ng support to Gtk
https://bugs.webkit.org/show_bug.cgi?id=92098

Reviewed by Gustavo Noronha Silva.

.:

Add support for detecting HarfBuzz during configuration phase. Add these
flags to the FreeType ones since HarfBuzz support is part of the FreeType
backend.

* configure.ac: Detect HarfBuzz.

Source/WebCore:

Enable HarfBuzz support by default. With the Freetype backend we no longer
fall back to Pango for rendering complex text.

No new tests. This is covered by existing tests.

* GNUmakefile.am: Add HarfBuzz include directories and define.
* GNUmakefile.list.am: Add HarfBuzz files to source list and remove
Pango ones.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::operator==): To properly render fallback
fonts via HarfBuzz , it's important that we actually ask Fontconfig
whether or not two patterns are the same. This ensures that when patterns
are just copies of one another they only take up one slot in the font cache
and appear to be the same font to HarfBuzzShaper.

Source/WebKit/gtk:

Add HarfBuzz dependency.

* GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the library.

Source/WebKit2:

Add a HarfBuzz dependency.

* GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS/LIBS to the libraries.

Tools:

Add HarfBuzz dependency.

* GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
* gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
should no longer affect layout test results.

LayoutTests:

Update tests results that have changed due to the switch to HarfBuzz.
In general, these are progressions or harmless metrics differences.

* platform/gtk: Update test results that have changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
hausmann@webkit.org [Mon, 10 Dec 2012 14:40:58 +0000 (14:40 +0000)]
[Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
https://bugs.webkit.org/show_bug.cgi?id=104541

Reviewed by Jocelyn Turcotte.

We now depend on a Qt 5 version that is guaranteed to have this API, so we
can remove the configure checks for it.

Source/WebKit2:

* PluginProcess.pro:
* Shared/qt/ProcessExecutablePathQt.cpp:
(WebKit::executablePath):
* WebProcess.pro:

Tools:

* qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
* qmake/config.tests/libexecdir/libexecdir.pro: Removed.
* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update
tkent@chromium.org [Mon, 10 Dec 2012 14:38:08 +0000 (14:38 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=104548

* platform/chromium/TestExpectations:
Hyphenation tests failure on WebKit-only checkout Linux

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: update expectation for inspector/styles/svg-style.xhtml
loislo@chromium.org [Mon, 10 Dec 2012 14:31:23 +0000 (14:31 +0000)]
Unreviewed: update expectation for inspector/styles/svg-style.xhtml

* inspector/styles/svg-style-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Overrides] Unable to change values in Device Metrics override setting
apavlov@chromium.org [Mon, 10 Dec 2012 14:15:20 +0000 (14:15 +0000)]
Web Inspector: [Overrides] Unable to change values in Device Metrics override setting
https://bugs.webkit.org/show_bug.cgi?id=104542

Reviewed by Vsevolod Vlasov.

Remove inadvertent object property assignment.

* inspector/front-end/OverridesView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r135863): GtkLauncher --help no longer displays all help options
commit-queue@webkit.org [Mon, 10 Dec 2012 13:51:17 +0000 (13:51 +0000)]
REGRESSION(r135863): GtkLauncher --help no longer displays all help options
https://bugs.webkit.org/show_bug.cgi?id=104382

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2012-12-10
Reviewed by Philippe Normand.

Remove gst_init() because it steals the GOptionContext.
gst_init_get_option_group() already does the initialization job.

* GtkLauncher/main.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview
charles.wei@torchmobile.com.cn [Mon, 10 Dec 2012 13:34:44 +0000 (13:34 +0000)]
[BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview
https://bugs.webkit.org/show_bug.cgi?id=104504

Reviewed by George Staikos.

When deleting a webview, the webkit thread will send a sync message to userInterfaceThread
to delete handlers, including the viewport accessor. But the UserInterfaceThread could be
doing a blit after it has deleted the viewport accessor and before the webkit thread gets
the time slot to resume it's operation to clean up the webview, which leaves a very short
time that viewport accessor of a webpage has been deleted while the webpage is still in
the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread.

So we need to check if the viewport accessor is NULL before using it in the backingstore code.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Builds for Mac are tied to the OS system instead of the SDK version.
michael.bruning@digia.com [Mon, 10 Dec 2012 13:14:10 +0000 (13:14 +0000)]
[Qt] Builds for Mac are tied to the OS system instead of the SDK version.
https://bugs.webkit.org/show_bug.cgi?id=104529

Reviewed by Simon Hausmann.

Using work by Eike Ziller <eike.ziller@digia.com>.

The build system now first tries to assign the correct system libraries
for the SDK being used for Mac builds. If this does not yield any
result, it falls back to using the Mac OS version to determine the
correct library.

No new tests (not applicable).

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build without QtQuick 2
hausmann@webkit.org [Mon, 10 Dec 2012 12:58:53 +0000 (12:58 +0000)]
[Qt] Fix build without QtQuick 2

Unreviewed trivial build fix.

This function is defined in QtWebContext, which is only used when QtQuick2 is available.

* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInvalidateContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: touch RenderingAllInOne.cpp to fix Apple Windows builder.
loislo@chromium.org [Mon, 10 Dec 2012 12:20:34 +0000 (12:20 +0000)]
Unreviewed: touch RenderingAllInOne.cpp to fix Apple Windows builder.

* rendering/RenderingAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Network: newly added items are not filtered.
commit-queue@webkit.org [Mon, 10 Dec 2012 12:18:09 +0000 (12:18 +0000)]
Web Inspector: Network: newly added items are not filtered.
https://bugs.webkit.org/show_bug.cgi?id=104021

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-10
Reviewed by Vsevolod Vlasov.

Extracted method to higlight/hide record according to filter.
Used this method to process newly created records.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._applyFilter): Extracted.
(WebInspector.NetworkLogView.prototype.performFilter): Refactored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Unreviewed: move reportMemoryUsage to public section.
loislo@chromium.org [Mon, 10 Dec 2012 12:11:46 +0000 (12:11 +0000)]
Web Inspector: Unreviewed: move reportMemoryUsage to public section.

* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.h:
(RenderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 10 Dec 2012 12:03:17 +0000 (12:03 +0000)]
Unreviewed GTK gardening.

Managing current failures on the 64-bit debug builder to get it green.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: adds an option to remove toolbar icons.
pfeldman@chromium.org [Mon, 10 Dec 2012 11:47:16 +0000 (11:47 +0000)]
Web Inspector: adds an option to remove toolbar icons.
https://bugs.webkit.org/show_bug.cgi?id=95654

Reviewed by Vsevolod Vlasov.

- removes compact mode in favor or dock-to-bottom
- introduces setting for hiding toolbar icons

* inspector/front-end/DockController.js:
(WebInspector.DockController.prototype._toggleDockState):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype.setDockedToBottom):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):
* inspector/front-end/helpScreen.css:
(body.dock-to-bottom .help-content):
* inspector/front-end/inspector.css:
(body.dock-to-bottom #toolbar):
(body.no-toolbar-icons #toolbar):
(body.dock-to-bottom.port-qt #toolbar):
(body.dock-to-bottom.inactive #toolbar):
(body.no-toolbar-icons .toolbar-item.toggleable):
(body.dock-to-bottom .toolbar-item.toggleable):
(body.dock-to-bottom .toolbar-icon):
(body.no-toolbar-icons .toolbar-icon):
(body.no-toolbar-icons #main):
(body.dock-to-bottom .toolbar-icon.custom-toolbar-icon):
(body.dock-to-bottom .toolbar-item:active .toolbar-icon):
(body.dock-to-bottom .toolbar-label):
(body.dock-to-bottom #search-toolbar-label):
(body.no-toolbar-icons .toolbar-label):
(body.no-toolbar-icons #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item.toggleable:hover):
(body.no-toolbar-icons #toolbar-dropdown .toolbar-label):
(body.no-toolbar-icons #toolbar-dropdown .toolbar-item):
(body.dock-to-bottom .toolbar-item.resources .toolbar-icon):
(body.dock-to-bottom .toolbar-item.network .toolbar-icon):
(body.dock-to-bottom .toolbar-item.scripts .toolbar-icon):
(body.dock-to-bottom .toolbar-item.timeline .toolbar-icon):
(body.dock-to-bottom .toolbar-item.profiles .toolbar-icon):
(body.dock-to-bottom .toolbar-item.audits .toolbar-icon):
(body.dock-to-bottom .toolbar-item.console .toolbar-icon):
(body.dock-to-bottom.port-qt .toolbar-item.close-left, body.dock-to-bottom.port-qt .toolbar-item.close-right):
(body.dock-to-bottom #main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove duplicate expectations
commit-queue@webkit.org [Mon, 10 Dec 2012 11:39:42 +0000 (11:39 +0000)]
[EFL] Remove duplicate expectations
https://bugs.webkit.org/show_bug.cgi?id=104526

Unreviewed gardening: collect all WebAudio-related skips
to one place.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-10

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Remove HTMLFormControlElement::autofocus
tkent@chromium.org [Mon, 10 Dec 2012 11:34:26 +0000 (11:34 +0000)]
Refactoring: Remove HTMLFormControlElement::autofocus
https://bugs.webkit.org/show_bug.cgi?id=104524

Reviewed by Kentaro Hara.

autofocus function is used only by HTMLFormControlElement itself, no
sub-classes override it, and it is not exposed via an IDL attribute,

No new tests. This doesn't make any behavior changes.

* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus): Use fastHasAttribute instead of autofocus().
* html/HTMLFormControlElement.h: Remove autofocus().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WTR] Implement AccessibilityUIElement::titleUIElement
zandobersek@gmail.com [Mon, 10 Dec 2012 11:30:35 +0000 (11:30 +0000)]
[GTK][WTR] Implement AccessibilityUIElement::titleUIElement
https://bugs.webkit.org/show_bug.cgi?id=102953

Reviewed by Martin Robinson.

Implement AccessibilityUIElement::titleUIElement in the ATK backend
in the same manner it is implemented in DumpRenderTree. Both implementations
are updated to unref the relation set before the final function return
rather than at the end of each loop through the relations held in the said
relation set.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::titleUIElement):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::titleUIElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix GC3Dintptr and GC3Dsizeiptr typedefs for Win64
commit-queue@webkit.org [Mon, 10 Dec 2012 11:29:46 +0000 (11:29 +0000)]
Fix GC3Dintptr and GC3Dsizeiptr typedefs for Win64
https://bugs.webkit.org/show_bug.cgi?id=104426

Patch by Jonathan Liu <net147@gmail.com> on 2012-12-10
Reviewed by Simon Hausmann.

The GC3Dintptr and GC3Dsizeiptr typedefs are incorrect for Win64 as
LLP64 is used there. This would result in compile error due to
narrowing conversion of 64-bit pointer to signed long int which is
32-bit.

* platform/graphics/GraphicsTypes3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the WebKit2 debug build
mrobinson@webkit.org [Mon, 10 Dec 2012 11:00:23 +0000 (11:00 +0000)]
Fix the WebKit2 debug build

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR] Move text output accumulation to the UIProcess
commit-queue@webkit.org [Mon, 10 Dec 2012 10:44:33 +0000 (10:44 +0000)]
[WTR] Move text output accumulation to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=104214

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-10
Reviewed by Darin Adler.

Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess
once a test is finished, immediately send any text output to the UIProcess. This will allow
WebKitTestRunner to output text from the UIProcess as well.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output
StringBuilder. Add a method to send output to the UIProcess.
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder
to use the new outputText method.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
(WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
(WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
method of printing the text is slightly different.
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
message by appending the results to the StringBuilder.
* WebKitTestRunner/TestInvocation.h:
(TestInvocation): Switch the type of m_textOutput.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Remove the dependency of ShareableSurface from Coordinated...
commit-queue@webkit.org [Mon, 10 Dec 2012 10:37:40 +0000 (10:37 +0000)]
Coordinated Graphics: Remove the dependency of ShareableSurface from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

It is a follow-up patch of r137117.

There are two changes
1. Add a const qualifier to supportsAlpha().
2. Use << instead of encode() when using ArgumentEncoder.

* Shared/CoordinatedGraphics/CoordinatedSurface.h:
(WebKit::CoordinatedSurface::supportsAlpha):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::copyToTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Remove the dependency of ShareableSurface from Coordinated...
commit-queue@webkit.org [Mon, 10 Dec 2012 10:35:30 +0000 (10:35 +0000)]
Coordinated Graphics: Remove the dependency of ShareableSurface from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

WebCoordinatedSurface::copyToTexture should return early if the backend
is GraphicsSurface.

* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::copyToTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Introduce HTMLFormControlElement::isDisabledOrReadOnly
tkent@chromium.org [Mon, 10 Dec 2012 10:26:01 +0000 (10:26 +0000)]
Refactoring: Introduce HTMLFormControlElement::isDisabledOrReadOnly
https://bugs.webkit.org/show_bug.cgi?id=104508

Reviewed by Kentaro Hara.

Source/WebCore:

We have a lot of code like element->disabled || element->readOnly().
isDisabledOrReadOnly makes them simpler.

No new tests. This make no behaivor change.

* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
Added. Note that the implmentation of disabled() is not just "return m_disabled;".

* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Use isDisabledOrReadOnly.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToMouseEvents): Ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly): Ditto.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::handleDOMActivateEvent): Ditto.
(WebCore::ColorInputType::didChooseColor): Ditto.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::recalcWillValidate): Ditto.
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::valueMissing): Ditto.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent): Ditto.
(WebCore::RangeInputType::handleTouchEvent): Ditto.
(WebCore::RangeInputType::handleKeydownEvent): Ditto.
* html/SearchInputType.cpp:
(WebCore::SearchInputType::handleKeydownEvent): Ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): Ditto.
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents): Ditto.
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Ditto.
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Ditto.
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::defaultEventHandler): Ditto.
(WebCore::TextFieldDecorationElement::willRespondToMouseMoveEvents): Ditto.
(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents): Ditto.

Source/WebKit/blackberry:

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup): Use isDisabledOrReadOnly.
(BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
Use isDisabledOrReadOnly. Also, remove unnecessary local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 10 Dec 2012 10:14:34 +0000 (10:14 +0000)]
Unreviewed GTK gardening.

Removing failure expectations for the MicroData tests that were fixed in r137107.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCheck that plugin functionality is enabled before querying the database for installed...
commit-queue@webkit.org [Mon, 10 Dec 2012 10:12:34 +0000 (10:12 +0000)]
Check that plugin functionality is enabled before querying the database for installed plugins.
https://bugs.webkit.org/show_bug.cgi?id=73671

Patch by Andy Shaw <andy.shaw@digia.com> on 2012-12-10
Reviewed by Jocelyn Turcotte.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::objectContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: console broken? - console.dirxml behaves like console.log
pfeldman@chromium.org [Mon, 10 Dec 2012 09:38:33 +0000 (09:38 +0000)]
Web Inspector: console broken? - console.dirxml behaves like console.log
https://bugs.webkit.org/show_bug.cgi?id=104245

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Do not generate preview for dirxml.

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):

LayoutTests:

* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-dirxml.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Remove HTMLFormControlElement::setDisabled
tkent@chromium.org [Mon, 10 Dec 2012 09:29:47 +0000 (09:29 +0000)]
Refactoring: Remove HTMLFormControlElement::setDisabled
https://bugs.webkit.org/show_bug.cgi?id=104510

Reviewed by Kentaro Hara.

Remove it because the number of call sites is only one, and the
setDisabled implementation is equivalent to setBooleanAttribute.

No new tests. This should not make behavior changes.

* html/HTMLFormControlElement.cpp: Remove setDisabled.
* html/HTMLFormControlElement.h: Ditto.
* html/FileInputType.cpp:
(WebCore::FileInputType::disabledAttributeChanged):
Replace setDisabled with setBooleanAttribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM][Refacdtoring] nextTo() and previousTo() can be part of ContentDistribution
morrita@google.com [Mon, 10 Dec 2012 09:03:06 +0000 (09:03 +0000)]
[Shadow DOM][Refacdtoring] nextTo() and previousTo() can be part of ContentDistribution
https://bugs.webkit.org/show_bug.cgi?id=104514

Reviewed by Kentaro Hara.

InsertionPoint::nextTo() and InsertionPoint::previousTo() are an
query to distributed nodes, which is what ContentDistribution
represents. We can move them to better home.

No new tests. No behavior change.

* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistribution::nextTo): Moved from InsertionPoint
(WebCore):
(WebCore::ContentDistribution::previousTo): Moved from InsertionPoint
* html/shadow/ContentDistributor.h:
(ContentDistribution):
* html/shadow/InsertionPoint.cpp:
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::nextTo): Delegated to ContentDistribution
(WebCore::InsertionPoint::previousTo): Delegated to ContentDistribution

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.
mihnea@adobe.com [Mon, 10 Dec 2012 08:42:40 +0000 (08:42 +0000)]
Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Add CoordinatedSurface to remove the dependency of ShareableSur...
commit-queue@webkit.org [Mon, 10 Dec 2012 08:28:29 +0000 (08:28 +0000)]
Coordinated Graphics: Add CoordinatedSurface to remove the dependency of ShareableSurface from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-10
Reviewed by Noam Rosenthal.

Internal Review by Gwang Yoon Hwang and Jae Hyun Park.

It is a preparation patch for Threaded Coordinated Graphics on WK1.

Create a CoordinatedSurface class that can be the base class both for
the current IPC-based ShareableSurface, renamed here to
WebCoordinatedSurface, and to a future thread-based surface
implementation.

* CMakeLists.txt:
* Shared/CoordinatedGraphics/CoordinatedSurface.h: Added.
(WebCore):
(WebKit):
(CoordinatedSurface):
(WebKit::CoordinatedSurface::~CoordinatedSurface):
(WebKit::CoordinatedSurface::supportsAlpha):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/ShareableSurface.cpp.
  Extends CoordinatedSurface.
(WebKit):
(WebKit::WebCoordinatedSurface::Handle::Handle):
(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::Handle::decode):
(WebKit::CoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::createWithSurface):
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::~WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::createHandle):
(WebKit::WebCoordinatedSurface::copyToTexture):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Renamed from Source/WebKit2/Shared/ShareableSurface.h.
(WebCore):
(WebKit):
(WebCoordinatedSurface):
(Handle):
(WebKit::WebCoordinatedSurface::Handle::graphicsSurfaceToken):
(WebKit::WebCoordinatedSurface::isBackedByGraphicsSurface):
* Target.pri:
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(WebKit):
(CoordinatedBackingStoreTile):
(CoordinatedBackingStore):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createUpdateAtlas):
(WebKit::LayerTreeCoordinatorProxy::updateImageBacking):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::updateImageBacking):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):
(LayerTreeRenderer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:
(WebKit::CoordinatedImageBacking::update):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:
(Coordinator):
(CoordinatedImageBacking):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::updateImageBacking):
(WebKit::LayerTreeCoordinator::createUpdateAtlas):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:
(UpdateAtlasClient):
(UpdateAtlas):
(WebKit::UpdateAtlas::supportsAlpha):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Mon, 10 Dec 2012 08:22:28 +0000 (08:22 +0000)]
Unreviewed EFL gardening.

Unskip 5 MicroData test cases that were fixed in r137107.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Mon, 10 Dec 2012 08:19:31 +0000 (08:19 +0000)]
Unreviewed EFL gardening.

Add fast/canvas/webgl tests to TestExpectations since they
sometimes crash on the bots.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] accessibility/language-attribute.html is failing
commit-queue@webkit.org [Mon, 10 Dec 2012 08:17:53 +0000 (08:17 +0000)]
[GTK] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98369

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

The test is failing for two reasons: Not exposing the language
for accessible objects and AccessibilityUIElement::language() not
being implemented.

Source/WebCore:

No new tests; instead, unskipped the previously-failing test.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject): Expose the language via AtkText attribute

Tools:

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::language): Implemented.

LayoutTests:

* accessibility/language-attribute.html: Modified the test to work with
both Mac and Atk platforms. (The former exposes static text objects as
accessibles; the latter folds the text into the parent element.)
* platform/gtk/TestExpectations: Unskipped the previously-failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] accessibility/editable-webarea-context-menu-point.html is failing
commit-queue@webkit.org [Mon, 10 Dec 2012 08:04:49 +0000 (08:04 +0000)]
[GTK] accessibility/editable-webarea-context-menu-point.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98364

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Tools:

The test is failing because the clickPoint values remain unchanged. The
values remain unchanged because ATK lacks a means to keep track of this
information.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
(AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details

LayoutTests:

This test seems to be Mac-specific. Therefore, move the test to that
platform and remove the skips from the other platforms.

* platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
* platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
* platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
* platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM]: reset-style-inheritance doesn't work for insertion point
tasak@google.com [Mon, 10 Dec 2012 07:43:42 +0000 (07:43 +0000)]
[Shadow DOM]: reset-style-inheritance doesn't work for insertion point
https://bugs.webkit.org/show_bug.cgi?id=103711

Reviewed by Hajime Morita.

Source/WebCore:

reset-style-inheritance can be specified by using insertion points'
attribute, e.g. <content reset-style-inheritance>.
c.f. shadow dom spec:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles

No new tests. Updated an existing test,
fast/dom/shadow/insertion-point-resetStyleInheritance.html to cover
this feature.

* html/HTMLAttributeNames.in:
Added HTMLNames::reset_style_inheritanceAttr.
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::parseAttribute):
Since both shadow and content elements have to support
reset-style-inheritance, added InsertionPoint::parseAttribute.
(WebCore::InsertionPoint::resetStyleInheritance):
(WebCore::InsertionPoint::setResetStyleInheritance):
Modified to update reset-style-inheritance attribute value.
* html/shadow/InsertionPoint.h:
(InsertionPoint):
Removed m_shouldResetStyleInheritance. Instead, use
reset-style-inheritance attribute value.

LayoutTests:

* fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:
* fast/dom/shadow/insertion-point-resetStyleInheritance.html:
Added two more basic tests to cover <content reset-style-inheritance>
and <shadow reset-style-inheritance>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and Accessibili...
commit-queue@webkit.org [Mon, 10 Dec 2012 07:28:02 +0000 (07:28 +0000)]
[GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
https://bugs.webkit.org/show_bug.cgi?id=104481

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isSelectable): Implement this by checking
the current state of the AtkObject.
(AccessibilityUIElement::isMultiSelectable): Implement this by
checking the current state of the AtkObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG ArrayPush/Pop should not pass their second child as the index for blessArrayOpera...
fpizlo@apple.com [Mon, 10 Dec 2012 06:54:30 +0000 (06:54 +0000)]
DFG ArrayPush/Pop should not pass their second child as the index for blessArrayOperation()
https://bugs.webkit.org/show_bug.cgi?id=104500

Reviewed by Oliver Hunt.

Slight across-the-board speed-up.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
commit-queue@webkit.org [Mon, 10 Dec 2012 06:45:58 +0000 (06:45 +0000)]
Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-09
Reviewed by Noam Rosenthal.

Send SetRootCompositingLayer message to the UI process before
flushing compositing states of layer tree.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNative Memory Instrumentation: instrument a part of RenderObject class tree.
loislo@chromium.org [Mon, 10 Dec 2012 06:16:45 +0000 (06:16 +0000)]
Native Memory Instrumentation: instrument a part of RenderObject class tree.
https://bugs.webkit.org/show_bug.cgi?id=103564

Reviewed by Eric Seidel.

Many RenderObject descendants have OwnPtrs and RefPtrs members.
Looks like we have to instrument all the RenderObject classes and visit
all the render objects instead of counting entire render arena memory.

* WebCore.exp.in:
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::reportRenderTreeInfo):
(WebCore):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
* platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryTypes):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
(WebCore):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::reportMemoryUsage):
(WebCore):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::reportMemoryUsage):
(WebCore):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reportMemoryUsage):
(WebCore):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::reportMemoryUsage):
(WebCore):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
(WebCore):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::reportMemoryUsage):
(WebCore):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
(WebCore):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::reportMemoryUsage):
(WebCore):
* rendering/RenderLayerModelObject.h:
(RenderLayerModelObject):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
(WebCore):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderText.cpp:
(WebCore::RenderText::reportMemoryUsage):
(WebCore):
* rendering/RenderText.h:
(RenderText):
* rendering/RenderView.cpp:
(WebCore::RenderView::reportMemoryUsage):
(WebCore):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r137003): failures in MicroData tests on EFL, GTK
rniwa@webkit.org [Mon, 10 Dec 2012 05:39:08 +0000 (05:39 +0000)]
REGRESSION (r137003): failures in MicroData tests on EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=104469

Reviewed by Darin Adler.

Fix the regression by calling propertyNodeList on HTMLPropertiesCollection
in the named getter for HTMLCollection. It's a miracle that the old code prior to r137003
worked at all since the return type of namedItem was different.

Existing tests cover this.

* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening after r137006.
commit-queue@webkit.org [Mon, 10 Dec 2012 05:09:57 +0000 (05:09 +0000)]
[Qt] Gardening after r137006.
https://bugs.webkit.org/show_bug.cgi?id=104432

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-09
Reviewed by Kentaro Hara.

Update existing tests that are affected by r137006.

* compositing/rtl/rtl-iframe-absolute-expected.txt:
* compositing/rtl/rtl-iframe-fixed-expected.txt:
* compositing/rtl/rtl-iframe-relative-expected.txt:
* platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
* platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
* platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
* platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r137103.
commit-queue@webkit.org [Mon, 10 Dec 2012 03:58:27 +0000 (03:58 +0000)]
Unreviewed, rolling out r137103.
http://trac.webkit.org/changeset/137103
https://bugs.webkit.org/show_bug.cgi?id=104503

Didn't resolve the chrome win build bot failure, problem moved
elsewhere. (Requested by noel_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-09

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK1] Gardening for Accelerated Compositing
commit-queue@webkit.org [Mon, 10 Dec 2012 03:39:35 +0000 (03:39 +0000)]
[EFL][WK1] Gardening for Accelerated Compositing
https://bugs.webkit.org/show_bug.cgi?id=104466

Unreviewed, EFL gardening.

As EFL WK1 does not support Accelerated Compositing, related cases should be skipped from layout tests.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-09

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] webkit_unit_tests tests are failing on win
noel.gordon@gmail.com [Mon, 10 Dec 2012 03:02:25 +0000 (03:02 +0000)]
[chromium] webkit_unit_tests tests are failing on win
https://bugs.webkit.org/show_bug.cgi?id=104502

Unreviewed test fix: disable applyScrollToScrollableArea test.

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening: broken or flakey hardness perftests
noel.gordon@gmail.com [Mon, 10 Dec 2012 01:59:23 +0000 (01:59 +0000)]
[Chromium] Unreviewed gardening: broken or flakey hardness perftests

fast/harness/perftests/runs-per-second-iterations.html
fast/harness/perftests/perf-runner-compute-statistics.html
fast/harness/perftests/runs-per-second-log.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] accessibility/placeholder.html is failing
commit-queue@webkit.org [Mon, 10 Dec 2012 01:09:32 +0000 (01:09 +0000)]
[GTK] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98373

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The test was failing because the placeholder text was not supported and
AccessibilityUIElement::stringAttributeValue() was not implemented.

Source/WebCore:

No new tests; instead the failing test was unskipped.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Add the placeholder text as an AtkAttribute
of the AtkObject, as is done in Gtk+ 3.

Tools:

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
names into AtkObject attribute names
(AccessibilityUIElement::stringAttributeValue): implemented

LayoutTests:

* platform/gtk/TestExpectations: Unskip the failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WebGL] Path is not resized correctly.
commit-queue@webkit.org [Sun, 9 Dec 2012 22:56:50 +0000 (22:56 +0000)]
[EFL] [WebGL] Path is not resized correctly.
https://bugs.webkit.org/show_bug.cgi?id=104458.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-09
Reviewed by Kenneth Rohde Christiansen.

In GraphicsContext3D::paintToCanvas, we flip the contents and draw on the surface.
The operations done to flip the image (translation and scale) are done before rectangle with correct size
is added to current path. This resulted in updating pixels at wrong positions.

Covered by existing tests.

* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][AC] build fix after r130525 and r133332
joone.hur@intel.com [Sun, 9 Dec 2012 22:53:57 +0000 (22:53 +0000)]
[GTK][AC] build fix after r130525 and r133332
https://bugs.webkit.org/show_bug.cgi?id=104491

Reviewed by Martin Robinson.

Build fix for Accelerated Compositing Clutter backend after r130525 and r133332.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
* platform/gtk/RedirectedXCompositeWindow.cpp:
* platform/gtk/RedirectedXCompositeWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Sun, 9 Dec 2012 21:45:41 +0000 (21:45 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for 15 layout tests that started failing after libxml2
version used in Jhbuild was bumped in r137090.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC should scale the optimization threshold for a code block according to the cost...
fpizlo@apple.com [Sun, 9 Dec 2012 20:41:09 +0000 (20:41 +0000)]
JSC should scale the optimization threshold for a code block according to the cost of compiling it
https://bugs.webkit.org/show_bug.cgi?id=104406

Reviewed by Oliver Hunt.

We've long known that we want to scale the execution count threshold needed for the DFG
to kick in to scale according to some estimate of the cost of compiling that code block.
This institutes a relationship like this:

threshold = thresholdSetting * (a * sqrt(instructionCount + b) + abs(c * instructionCount) + d

Where a, b, c, d are coefficients derived from fitting the above expression to various
data points, which I chose based on looking at one benchmark (3d-cube) and from my
own intuitions.

Making this work well also required changing the thresholdForOptimizeAfterLongWarmUp
from 5000 to 1000.

This is a >1% speed-up on SunSpider, a >3% speed-up on V8Spider, ~1% speed-up on V8v7,
neutral on Octane, and neutral on Kraken.

I also out-of-lined a bunch of methods related to these heuristics, because I couldn't
stand having them defined in the header anymore. I also made improvements to debugging
code because I needed it for tuning this change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::clipThreshold):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::counterValueForOptimizeSoon):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
* bytecode/CodeBlock.h:
* bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::hasCrossedThreshold):
* bytecode/ReduceWhitespace.cpp: Added.
(JSC::reduceWhitespace):
* bytecode/ReduceWhitespace.h: Added.
* dfg/DFGCapabilities.cpp:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
* dfg/DFGCapabilities.h:
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpHeader):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dumpHeader):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::ensureBytecodesFor):
* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Use GObject casts instead of C++ cast for GObjects in DOM bindings
carlosgc@webkit.org [Sun, 9 Dec 2012 20:15:16 +0000 (20:15 +0000)]
[GTK] Use GObject casts instead of C++ cast for GObjects in DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=104492

Reviewed by Martin Robinson.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateCFile):
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(WebKit::kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: [Chromium] Unreviewed. Temporarily disable a webkit_unit_tes...
senorblanco@chromium.org [Sun, 9 Dec 2012 19:33:08 +0000 (19:33 +0000)]
Source/WebKit/chromium: [Chromium] Unreviewed.  Temporarily disable a webkit_unit_tests test
that's failing on Windows.

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::TEST_F):

LayoutTests: [Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not treat object as equal to itself when logging to console
pfeldman@chromium.org [Sun, 9 Dec 2012 19:28:23 +0000 (19:28 +0000)]
Web Inspector: do not treat object as equal to itself when logging to console
https://bugs.webkit.org/show_bug.cgi?id=104487

Reviewed by Alexander Pavlov.

Source/WebCore:

Otherwise, mutating object in a loop results in the repeat count update instead of generation of the new preview.

Test: inspector/console/console-object-preview.html

* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::isEqual):

LayoutTests:

* inspector/console/console-object-preview-expected.txt: Added.
* inspector/console/console-object-preview.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Bump libxml2 requirement in jhbuild.modules
danw@gnome.org [Sun, 9 Dec 2012 19:28:23 +0000 (19:28 +0000)]
[GTK] Bump libxml2 requirement in jhbuild.modules
https://bugs.webkit.org/show_bug.cgi?id=104477

Reviewed by Martin Robinson.

Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
tests won't run if we only have libxml2 2.8.0 installed in the
jhbuild root.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused code in GObject DOM bindings generator
carlosgc@webkit.org [Sun, 9 Dec 2012 19:00:58 +0000 (19:00 +0000)]
Remove unused code in GObject DOM bindings generator
https://bugs.webkit.org/show_bug.cgi?id=104490

Reviewed by Martin Robinson.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties): Remove code to install event listeners and
signals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] accessibility/canvas-fallback-content.html is failing
commit-queue@webkit.org [Sun, 9 Dec 2012 18:55:30 +0000 (18:55 +0000)]
[GTK] accessibility/canvas-fallback-content.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98362

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The failure was due to platform-specific expectations of the accessible
role reported for comboboxes. The solution was conditionalizing the test.

* accessibility/canvas-fallback-content.html: Base expected role on platform.
* platform/gtk/TestExpectations: Unskipped the test.
* platform/gtk/accessibility/canvas-fallback-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Sun, 9 Dec 2012 18:20:27 +0000 (18:20 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update for the GObject bindings after r137074 and r137078.
zandobersek@gmail.com [Sun, 9 Dec 2012 18:19:22 +0000 (18:19 +0000)]
Unreviewed update for the GObject bindings after r137074 and r137078.

* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_supplemental_method2):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Sun, 9 Dec 2012 18:16:39 +0000 (18:16 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137081 268f45cc-cd09-0410-ab3c-d52691b4dbfc