WebKit-https.git
8 years agoChanging pseudoClass (:disabled) should cause distribution.
shinyak@chromium.org [Thu, 15 Nov 2012 07:41:33 +0000 (07:41 +0000)]
Changing pseudoClass (:disabled) should cause distribution.
https://bugs.webkit.org/show_bug.cgi?id=101901

Reviewed by Hajime Morita.

Source/WebCore:

We have to invalidate distribution when pseudo-class (:disabled) is changed.

According to the HTML5 spec, :disabled will match button, input, select, textarea, optgroup,
option, command, li, and fieldset. However, command is not implemented yet, we skip li and command. li might
have 'disabled' state, but we need a command element to make it 'disabled' state.

Tests: fast/dom/shadow/pseudoclass-update-disabled-button.html
       fast/dom/shadow/pseudoclass-update-disabled-fieldset.html
       fast/dom/shadow/pseudoclass-update-disabled-input.html
       fast/dom/shadow/pseudoclass-update-disabled-optgroup.html
       fast/dom/shadow/pseudoclass-update-disabled-option.html
       fast/dom/shadow/pseudoclass-update-disabled-select.html
       fast/dom/shadow/pseudoclass-update-disabled-textarea.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::parseAttribute):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::parseAttribute):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-disabled-button-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-button.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-fieldset-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-fieldset.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-input-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-input.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-optgroup-expected.txt: Added.
* fast/dom/shadow/pseudoclass-update-disabled-optgroup.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-option-expected.txt: Added.
* fast/dom/shadow/pseudoclass-update-disabled-option.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-select-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-select.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-textarea-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134691, r134703, r134715, r134716,
commit-queue@webkit.org [Thu, 15 Nov 2012 07:34:30 +0000 (07:34 +0000)]
Unreviewed, rolling out r134691, r134703, r134715, r134716,
and r134733.
http://trac.webkit.org/changeset/134691
http://trac.webkit.org/changeset/134703
http://trac.webkit.org/changeset/134715
http://trac.webkit.org/changeset/134716
http://trac.webkit.org/changeset/134733
https://bugs.webkit.org/show_bug.cgi?id=102342

"Broke the Apple Windows Debug and GTK builds." (Requested by
dydx on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

Source/WebCore:

* WebCore.exp.in:
* bindings/js/SerializedScriptValue.h:
* testing/Internals.cpp:
* testing/Internals.h:
(WebCore):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* platform/chromium/fast/storage/serialized-script-value-expected.txt: Removed.
* platform/chromium/fast/storage/serialized-script-value.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 07:12:19 +0000 (07:12 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: fixing inspector tests under Qt.
pfeldman@chromium.org [Thu, 15 Nov 2012 06:57:37 +0000 (06:57 +0000)]
Not reviewed: fixing inspector tests under Qt.

* inspector/front-end/TestController.js:
* inspector/front-end/utilities.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134741.
commit-queue@webkit.org [Thu, 15 Nov 2012 06:51:10 +0000 (06:51 +0000)]
Unreviewed, rolling out r134741.
http://trac.webkit.org/changeset/134741
https://bugs.webkit.org/show_bug.cgi?id=102337

"Change is incorrect." (Requested by dydx on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

.:

* Source/autotools/symbols.filter:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Port tiled backing store
commit-queue@webkit.org [Thu, 15 Nov 2012 06:44:33 +0000 (06:44 +0000)]
[EFL] Port tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=71352

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-14
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Added ewk_view_setting_tiled_backing_store_enabled_{get|set} to give possibility
to use WebCore's tiled backing store in WebKit/Efl port. This makes WebKit/Efl
compliant with WebKit's generic solution of tiled backing store.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore):
(WebCore::ChromeClientEfl::visibleRectForTiledBackingStore):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* ewk/ewk_frame_private.h:
Declared missing classes which used in this file.
* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint): Implemented to paint tiled backing store
* ewk/ewk_view.cpp:
(ewk_view_setting_tiled_backing_store_enabled_set):
Added API to enable/disable the WebCore's tiled backing store.
(ewk_view_setting_tiled_backing_store_enabled_get):
Added API to query if the WebCore's tiled backing store is enabled.
(ewk_view_tiled_backing_store_invalidate):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
Implemented to update visible area of tiled backing store.
* tests/test_ewk_view.cpp: Added test case of ewk_view_setting_tiled_backing_store.
(TEST_F):

Tools:

* EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
(_User_Arguments):
(windowCreate):
(parseUserArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 15 Nov 2012 06:42:21 +0000 (06:42 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix the Apple Windows Debug and GTK builds after <http://trac.webkit.org...
dbates@webkit.org [Thu, 15 Nov 2012 06:37:43 +0000 (06:37 +0000)]
Attempt to fix the Apple Windows Debug and GTK builds after <trac.webkit.org/changeset/134691>
(https://bugs.webkit.org/show_bug.cgi?id=96818)

.:

Export symbols similar to the ones we added to WebCore.exp.in in
<http://trac.webkit.org/changeset/134691>.

* Source/autotools/symbols.filter:

Source/WebKit2:

Export symbols of the form:
?deserializeBuffer@Internals@WebCore[...]
?serializeObject@Internals@WebCore[...]

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests.
haraken@chromium.org [Thu, 15 Nov 2012 05:48:35 +0000 (05:48 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8Fast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't use temporary clip rects when hit testing
simon.fraser@apple.com [Thu, 15 Nov 2012 05:47:01 +0000 (05:47 +0000)]
Don't use temporary clip rects when hit testing
https://bugs.webkit.org/show_bug.cgi?id=102329

Reviewed by Beth Dakin.

We now cache clip rects separately for painting, hit testing etc. Hit testing
clip rects are always shrunk to exclude scrollbars (so that hit testing on
the scrollbars works), so we no longer every need to use temporary clip rects
during hit testing.

Added an assertion that the scrollbar relevancy when we computed the clip rects
is the same as that when using them.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
* rendering/RenderLayer.h:
(WebCore::ClipRectsCache::ClipRectsCache):
(ClipRectsCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport animation of basic shape 'polygon'
krit@webkit.org [Thu, 15 Nov 2012 05:33:41 +0000 (05:33 +0000)]
Support animation of basic shape 'polygon'
https://bugs.webkit.org/show_bug.cgi?id=102080

Reviewed by Daniel Bates.

Source/WebCore:

The basic shapes 'circle', 'rectangle' and 'ellipse' are animatable with the committed
patch http://trac.webkit.org/changeset/134352.
This is a follow-up patch to make 'polygon' animatable as well, as long as the number
of vertices between start and end polygon is the same.

Added polygon animation test to existing test:
    fast/exclusions/shape-inside/shape-inside-animation.html
    css3/masking/clip-path-animation.html

* page/animation/CSSPropertyAnimation.cpp: Forgot to add copyright with last commits.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend): Polygons are allowed now.
(WebCore::BasicShapePolygon::blend): Interpolate polygon shapes.

LayoutTests:

Added animation test for basic shape 'polygon' to existing test
css3/masking/clip-path-animation.html and
fast/exclusions/shape-inside/shape-inside-animation.html.

* animations/resources/animation-test-helpers.js:
(parseBasicShape):
* css3/masking/clip-path-animation-expected.txt:
* css3/masking/clip-path-animation.html:
* fast/exclusions/shape-inside/shape-inside-animation-expected.txt:
* fast/exclusions/shape-inside/shape-inside-animation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix code generator warnings.
haraken@chromium.org [Thu, 15 Nov 2012 05:27:08 +0000 (05:27 +0000)]
Unreviewed. Fix code generator warnings.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix windows build exports (again)
alecflett@chromium.org [Thu, 15 Nov 2012 04:53:22 +0000 (04:53 +0000)]
Fix windows build exports (again)
https://bugs.webkit.org/show_bug.cgi?id=102324

Unreviewed windows-only build fix.

Add one more export that was causing unit tests to fail to link.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanging pseudoClass (:checked) should cause distribution.
shinyak@chromium.org [Thu, 15 Nov 2012 04:29:21 +0000 (04:29 +0000)]
Changing pseudoClass (:checked) should cause distribution.
https://bugs.webkit.org/show_bug.cgi?id=101902

Reviewed by Dimitri Glazkov.

Source/WebCore:

When the 'checked' state is changed, we have to invalidate distribution.

According to the HTML5 spec, :checked should match a checked input[type="checkbox"],
a checked input[type="radio"], a selected option, and commands. However, we don't have a command element yet.

Tests: fast/dom/shadow/pseudoclass-update-checked-input.html
       fast/dom/shadow/pseudoclass-update-checked-option.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelectedState):

LayoutTests:

Since an option element does not create a renderer, we cannot make its test a reftest.

* fast/dom/shadow/pseudoclass-update-checked-input-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-checked-input.html: Added.
* fast/dom/shadow/pseudoclass-update-checked-option-expected.txt: Added.
* fast/dom/shadow/pseudoclass-update-checked-option.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd tests for week picker
keishi@webkit.org [Thu, 15 Nov 2012 03:52:52 +0000 (03:52 +0000)]
Add tests for week picker
https://bugs.webkit.org/show_bug.cgi?id=101555

Reviewed by Kent Tamura.

Adding tests for month picker.

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(selectedWeek): Returns value of selected week.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Kill $implClassName from CodeGeneratorV8.pm
haraken@chromium.org [Thu, 15 Nov 2012 03:45:37 +0000 (03:45 +0000)]
[V8] Kill $implClassName from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102312

Reviewed by Adam Barth.

$implClassName and $interfaceName are the same.
Sometimes we are passing both $implClassName and $interfaceName to
subroutines. We can kill $implClassName.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateTypedArrayConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateFunctionCallString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] We can shave one instruction off toV8Fast
abarth@webkit.org [Thu, 15 Nov 2012 03:41:21 +0000 (03:41 +0000)]
[V8] We can shave one instruction off toV8Fast
https://bugs.webkit.org/show_bug.cgi?id=102297

Reviewed by Kentaro Hara.

There's no reason to store info.Holder in a local variable. Calling
Holder() is essentially free because it's inlined to an offset read.

I doubt this patch moves the performance needle in any measurable way,
but it makes the code slightly prettier.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8Fast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Get rid of a redundant branch in JSValueToNative()
haraken@chromium.org [Thu, 15 Nov 2012 03:31:45 +0000 (03:31 +0000)]
[V8] Get rid of a redundant branch in JSValueToNative()
https://bugs.webkit.org/show_bug.cgi?id=102311

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
(NativeToJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanging pseudoClass (:link) should cause distribution
shinyak@chromium.org [Thu, 15 Nov 2012 03:17:57 +0000 (03:17 +0000)]
Changing pseudoClass (:link) should cause distribution
https://bugs.webkit.org/show_bug.cgi?id=101698

Reviewed by Hajime Morita.

Source/WebCore:

CSSSelector :link matches anchor element with href attribute. When href attribute of an anchor element is changed,
we have to invalidate distribution.

According to the HTML spec, :link matches a link element having href attribute, currently we have not implemented it yet.

Tests: fast/dom/shadow/pseudoclass-update-link-anchor.html
       fast/dom/shadow/pseudoclass-update-link-area.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-link-anchor-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-link-anchor.html: Added.
* fast/dom/shadow/pseudoclass-update-link-area-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-link-area.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused functions from CodeGenerator.pm
haraken@chromium.org [Thu, 15 Nov 2012 03:16:09 +0000 (03:16 +0000)]
Remove unused functions from CodeGenerator.pm
https://bugs.webkit.org/show_bug.cgi?id=102316

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(GenerateCompileTimeCheckForEnumsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Clamp negative sizes to zero when converting to gfx:: types
danakj@chromium.org [Thu, 15 Nov 2012 03:05:54 +0000 (03:05 +0000)]
[chromium] Clamp negative sizes to zero when converting to gfx:: types
https://bugs.webkit.org/show_bug.cgi?id=102159

Reviewed by James Robinson.

Here we clamp Rect, RectF and Size types to not have negative widths or
heights. WebSizes that you want to keep their negative values, because
they are vectors, should be converted to Vector2d instead.

* chromium/public/WebFloatRect.h:
(WebKit::WebFloatRect::operator gfx::RectF):
* chromium/public/WebRect.h:
(WebKit::WebRect::operator gfx::Rect):
* chromium/public/WebSize.h:
(WebKit::WebSize::operator gfx::Size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update BB10 form theme.
commit-queue@webkit.org [Thu, 15 Nov 2012 02:59:21 +0000 (02:59 +0000)]
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-14
Reviewed by Rob Buis.

RIM PR 225755
Internally Reviewed by Eli Fidler.
Update checkbox, radio and menulist button style. Adjust border width
and line height.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMenuListButtonStyle):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 02:56:01 +0000 (02:56 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac-lion/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac-lion/fast/repaint/control-clip-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png:
* platform/chromium-mac/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac/fast/repaint/control-clip-expected.png:
* platform/efl-wk1/fast/forms/menulist-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/menulist-clip-expected.png.
* platform/efl-wk1/fast/forms/menulist-option-wrap-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/menulist-option-wrap-expected.png.
* platform/efl-wk1/fast/repaint/control-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/control-clip-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviwed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 02:53:15 +0000 (02:53 +0000)]
Unreviwed. Rebaselined images.

* platform/chromium-mac/fast/forms/select-empty-option-height-expected.png:
* platform/efl-wk1/fast/forms/select-empty-option-height-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/select-empty-option-height-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 02:51:17 +0000 (02:51 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-linux/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium-mac-lion/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium-mac/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: InvalidModificationError
arv@chromium.org [Thu, 15 Nov 2012 02:33:07 +0000 (02:33 +0000)]
Update DOMException name: InvalidModificationError
https://bugs.webkit.org/show_bug.cgi?id=102281

Reviewed by Kentaro Hara.

Patch 13 of 25 to update DOMException name to match the spec and Firefox.

DOMExcecption INVALID_MODIFICATION_ERR is not used in our code.

* dom/DOMCoreException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows, WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Thu, 15 Nov 2012 02:31:46 +0000 (02:31 +0000)]
[Windows, WinCairo] Unreviewed build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Missed one of the exports that was part of the WebKit2.def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build.
aestes@apple.com [Thu, 15 Nov 2012 02:19:39 +0000 (02:19 +0000)]
Fix the build.

* TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Build correction after r134703.
bfulgham@webkit.org [Thu, 15 Nov 2012 02:18:06 +0000 (02:18 +0000)]
[WinCairo] Build correction after r134703.

* win/WebKit2CFLite.def: Add exports to CFLite version of
Windows build to match Alec's last update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows, WinCairo] Correct build failure.
bfulgham@webkit.org [Thu, 15 Nov 2012 02:14:05 +0000 (02:14 +0000)]
[Windows, WinCairo] Correct build failure.
https://bugs.webkit.org/show_bug.cgi?id=102302

WebCore symbols were mistakenly added to the JavaScriptCore
library definition file.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove
WebCore symbols that were incorrectly added to the export file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodocument variable in Document::axObjectCache is actually the topDocument
abarth@webkit.org [Thu, 15 Nov 2012 02:11:52 +0000 (02:11 +0000)]
document variable in Document::axObjectCache is actually the topDocument
https://bugs.webkit.org/show_bug.cgi?id=101966

Reviewed by Chris Fleizach.

Name change requested by Darin Adler.

* dom/Document.cpp:
(WebCore::Document::axObjectCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Windows exports for TestWebKit
alecflett@chromium.org [Thu, 15 Nov 2012 01:37:58 +0000 (01:37 +0000)]
Fix Windows exports for TestWebKit
https://bugs.webkit.org/show_bug.cgi?id=102302

Unreviewed, fixing Safari Win build.

Add missing exports.

* win/WebKit2.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CF]: XMLHttpRequest "timeout" events firing as "error" events
commit-queue@webkit.org [Thu, 15 Nov 2012 01:30:31 +0000 (01:30 +0000)]
[CF]: XMLHttpRequest "timeout" events firing as "error" events
https://bugs.webkit.org/show_bug.cgi?id=102271

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-11-14
Reviewed by David Kilzer.

Initialize the tiemout flag if the error results from a timeout
in the USE(CFNETWORK) cases.

No new tests. This is covered by http/tests/xmlhttprequest/timeout
tests on ports that USE(CFNETWORK).

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: consolidate webkit-base-finding code
dpranke@chromium.org [Thu, 15 Nov 2012 01:28:46 +0000 (01:28 +0000)]
webkitpy: consolidate webkit-base-finding code
https://bugs.webkit.org/show_bug.cgi?id=102007

Reviewed by Eric Seidel.

This patch creates a new "WebKitFinder" class that other
modules can use to find the top of the WebKit tree and
commonly used subdirectories. This logic was in the
webkitpy.layout_test.port classes but wasn't specific to those
classes and now can be used by other modules without needing a port
(e.g., by the check-webkit-style python linter).

This code is somewhat redundant with the code for find_checkout_root()
in the scm modules, but it does not rely on the presence of a version
control system to work. This is a requirement for some uses of the
tree (e.g., Chromium tester checkouts).

This patch removes most of the logic from the layout_tests.port.config
module and makes that as private as possible. Now we just need to move
the default_configuration and flag_from_configuration logic into
DeprecatedPort (or someplace else appropriate) and we can finish
getting rid of the Config class (but that is a separate patch).

* Scripts/webkitpy/common/webkit_finder.py: Added.
(WebKitFinder):
(WebKitFinder.__init__):
(WebKitFinder.webkit_base):
(WebKitFinder.path_from_webkit_base):
(WebKitFinder.path_to_script):
(WebKitFinder.layout_tests_dir):
(WebKitFinder.perf_tests_dir):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port):
(Port.webkit_base):
(Port.path_from_webkit_base):
(Port.path_to_script):
(Port.layout_tests_dir):
(Port.perf_tests_dir):
(Port.set_option_default):
(Port._run_script):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_diff_text):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.__init__):
(Config.build_directory):
(Config.default_configuration):
(Config._read_configuration):
* Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.test_default_configuration__standalone):
(ConfigTest.test_default_configuration__scripterror):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.make_port):
(DriverTest.test_no_timeout):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(TestWebKitPort.__init__):
(PortTestCase.make_port):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_stop):
* Scripts/webkitpy/style/checkers/python.py:
(Pylinter.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Test conversions batch 4
dgrogan@chromium.org [Thu, 15 Nov 2012 01:19:01 +0000 (01:19 +0000)]
IndexedDB: Test conversions batch 4
https://bugs.webkit.org/show_bug.cgi?id=102267

Reviewed by Tony Chang.

These are tests that don't have the js file in resources. The only
interesting bit is that lazy-index-population uncovered a potential bug.

I think tutorial.html has outlived its usefulness now that there are
more tutorials on the web. It was very outdated. It is deleted in
this patch.

* storage/indexeddb/deletedatabase-transaction-expected.txt:
* storage/indexeddb/deletedatabase-transaction.html:
* storage/indexeddb/dont-commit-on-blocked-expected.txt:
* storage/indexeddb/dont-commit-on-blocked.html:
* storage/indexeddb/lazy-index-population-expected.txt:
* storage/indexeddb/lazy-index-population.html:
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate.html:
* storage/indexeddb/mozilla/resources/object-identity.js:
  Test added here to replace test covered in tutorial.html

* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/noblobs.html:
* storage/indexeddb/resources/dont-commit-on-blocked-worker.js:
(onSetVersionSuccess):
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion.html:
* storage/indexeddb/tutorial-expected.txt: Removed.
* storage/indexeddb/tutorial.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers when...
thakis@chromium.org [Thu, 15 Nov 2012 01:11:46 +0000 (01:11 +0000)]
[chromium/mac] Fix drawing of buttons, checkboxes, radio boxes, and steppers when the page is scaled
https://bugs.webkit.org/show_bug.cgi?id=102282

Reviewed by James Robinson.

Chromium uses skia, and skia state is synced with CG context state at
LocalCurrentGraphicsContext construction time. So delay that
construction after context transforms have happened.
(This regressed in http://trac.webkit.org/changeset/125830)

Covered by the new pixel test fast/forms/zoomed-controls.html. I
couldn't find an existing test for this.

* platform/mac/ThemeMac.mm:
(WebCore::paintCheckbox):
(WebCore::paintRadio):
(WebCore::paintButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange JSEventListener::m_jsFunction to be a weak ref.
mark.lam@apple.com [Thu, 15 Nov 2012 01:01:41 +0000 (01:01 +0000)]
Change JSEventListener::m_jsFunction to be a weak ref.
https://bugs.webkit.org/show_bug.cgi?id=101989.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added infrastructure for scanning weak ref slots.

* heap/SlotVisitor.cpp: Added #include "SlotVisitorInlines.h".
* heap/SlotVisitor.h:
(SlotVisitor): Added SlotVisitor::appendUnbarrieredWeak().
* heap/SlotVisitorInlines.h: Added #include "Weak.h".
(JSC::SlotVisitor::appendUnbarrieredWeak): Added.
* heap/Weak.h:
(JSC::operator==): Added operator==() for Weak.
* runtime/JSCell.h: Removed #include "SlotVisitorInlines.h".
* runtime/JSObject.h: Added #include "SlotVisitorInlines.h".

Source/WebCore:

No new tests.

* ForwardingHeaders/heap/SlotVisitor.h: Added.
* bindings/js/JSDOMBinding.h: Added #include <heap/SlotVisitor.h>
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::visitJSFunction):
(WebCore::JSEventListener::operator==):
 - Removed the m_wrapper checks in operator==() because they are not
   needed. There is no longer any threat of m_jsFunction pointing to
   recycled memory. The use of weak refs will ensure that m_jsFunction
   is either still holding on to its old memory exclusively, or is 0'ed
   out when the GC collects it.
* bindings/js/JSEventListener.h:
(JSEventListener):
(WebCore::JSEventListener::jsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Rename dispatchWrap
commit-queue@webkit.org [Thu, 15 Nov 2012 00:58:13 +0000 (00:58 +0000)]
[V8] Rename dispatchWrap
https://bugs.webkit.org/show_bug.cgi?id=102240

Patch by Dan Carney <dcarney@google.com> on 2012-11-14
Reviewed by Adam Barth.

Mostly a rename:
dispatchWrap->wrap
wrapSlow->createWrapper
dispatchWrapCustom->wrap

No new tests. No change in functionality.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GenerateToV8Converters):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::wrap):
(WebCore::V8Float64Array::createWrapper):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::createWrapper):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::createWrapper):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::createWrapper):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::createWrapper):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::createWrapper):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::createWrapper):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::createWrapper):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::createWrapper):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::createWrapper):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
(WebCore::toV8Fast):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::createWrapper):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::createWrapper):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::wrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore):
(WebCore::wrap):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore):
(WebCore::wrap):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::wrap):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::wrap):
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRead-only properties created with putDirect() should tell the structure that there...
fpizlo@apple.com [Thu, 15 Nov 2012 00:50:41 +0000 (00:50 +0000)]
Read-only properties created with putDirect() should tell the structure that there are read-only properties
https://bugs.webkit.org/show_bug.cgi?id=102292

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

This mostly affects things like function.length.

* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):

LayoutTests:

* fast/js/function-dot-length-read-only-expected.txt: Added.
* fast/js/function-dot-length-read-only.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/function-dot-length-read-only.js: Added.
(foo):
(Bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Refactor theme to choose whether to support foreground color of selection
commit-queue@webkit.org [Thu, 15 Nov 2012 00:49:59 +0000 (00:49 +0000)]
[EFL] Refactor theme to choose whether to support foreground color of selection
https://bugs.webkit.org/show_bug.cgi?id=102037

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-14
Reviewed by Gyuyoung Kim.

Source/WebCore:

RenderThemeEfl can change foreground color of selection using theme file.
But it can not disable supports of foreground color to keep the text color
which is selected.

This patch refactors color classes of theme file from active/inactive classes
to foreground/background classes so that RenderThemeEfl checks whether
theme file supports foreground color class.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::fillColorsFromEdjeClass):
(WebCore::RenderThemeEfl::setColorFromThemeClass):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::supportsSelectionForegroundColors):
(WebCore):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

Source/WebKit/efl:

* DefaultTheme/default.edc:
Refactored color classes from active/inactive to foreground/background.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert m_selectorVector back to a stack allocated m_reusableSelectorVector
tony@chromium.org [Thu, 15 Nov 2012 00:48:05 +0000 (00:48 +0000)]
Convert m_selectorVector back to a stack allocated m_reusableSelectorVector
https://bugs.webkit.org/show_bug.cgi?id=102295

Reviewed by Andreas Kling.

Revert r125252 because we're not going to go forward with implementing CSS hierarchies at this time.

No new tests because there should be no change in behavior.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::createFloatingSelectorVector):
(WebCore::CSSParser::sinkFloatingSelectorVector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
* css/CSSParser.h:
(WebCore::CSSParser::hasProperties):
(WebCore::CSSParser::reusableSelectorVector):
(CSSParser):
(WebCore::CSSParser::reusableRegionSelectorVector):
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::adoptSelectorVector):
* css/CSSParserValues.h:
(CSSParserSelector):
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):
* css/CSSSelectorList.h:
(CSSSelectorList):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/StyleRule.cpp:
(WebCore::StyleRuleRegion::StyleRuleRegion):
* css/StyleRule.h:
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleRegion::create):
(StyleRuleRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation...
danakj@chromium.org [Thu, 15 Nov 2012 00:43:27 +0000 (00:43 +0000)]
[chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
https://bugs.webkit.org/show_bug.cgi?id=102296

Reviewed by James Robinson.

These settings are always set by TestShell anyhow, but we should be
setting them to false here along with everything else.

* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd tests for explicit serialization values
alecflett@chromium.org [Thu, 15 Nov 2012 00:34:38 +0000 (00:34 +0000)]
Add tests for explicit serialization values
https://bugs.webkit.org/show_bug.cgi?id=96818

Reviewed by Adam Barth.

Source/WebCore:

Expose direct access to the serialization/deserialization mechanisms
of SerializedScriptValue to DumpRenderTree.

* testing/Internals.cpp:
(WebCore::Internals::serializeObject):
(WebCore):
(WebCore::Internals::deserializeBuffer):
* testing/Internals.h:
(WebCore):
* testing/Internals.idl:

LayoutTests:

Make sure SerializedScriptValues are backward compatible with future changes.

* platform/chromium/fast/storage/serialized-script-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoordinated Graphics: Remove unused members and methods in CoordinatedGraphicsLayer.
commit-queue@webkit.org [Thu, 15 Nov 2012 00:29:20 +0000 (00:29 +0000)]
Coordinated Graphics: Remove unused members and methods in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102172

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-14
Reviewed by Noam Rosenthal.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Add clear() method to JSC ScriptValue
commit-queue@webkit.org [Thu, 15 Nov 2012 00:23:55 +0000 (00:23 +0000)]
IndexedDB: Add clear() method to JSC ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=102288

Patch by Michael Pruett <michael@68k.org> on 2012-11-14
Reviewed by Kentaro Hara.

IndexedDB uses the ScriptValue::clear() method, which existed
previously only in the V8 implementation of ScriptValue. This
change is necessary to implement IndexedDB for JSC.

Tests: storage/indexeddb/*

* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::clear):
(ScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Marked more virtual/deferred/fast/images as failing.
dglazkov@chromium.org [Thu, 15 Nov 2012 00:19:01 +0000 (00:19 +0000)]
[Chromium] Marked more virtual/deferred/fast/images as failing.
https://bugs.webkit.org/show_bug.cgi?id=102294

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader
beidson@apple.com [Wed, 14 Nov 2012 23:59:01 +0000 (23:59 +0000)]
Move loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=102259

Reviewed by Alexey Proskuryakov.

Add a new WebResourceLoader message class which allows NetworkResourceLoader to message
WebResourceLoaders directly.

Consolidate the NetworkProcessConnection and WebResourceLoadScheduler messaging responsibilities
directly into WebResourceLoader.

Build-system infrastructure stuff:
* DerivedSources.make:
* Platform/CoreIPC/MessageID.h:
* WebKit2.xcodeproj/project.pbxproj:

Message directly to WebResourceLoader instead of NetworkProcessConnection:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::connection):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::willSendRequest):
* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::destinationID):

For now handle the only relevant message class which is the WebResourceLoader class:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:

Allow access to WebResourceLoaders by identifier:
* WebProcess/Network/WebResourceLoadScheduler.cpp:
* WebProcess/Network/WebResourceLoadScheduler.h:
(WebKit::WebResourceLoadScheduler::webResourceLoaderForIdentifier):

Directly handle resource loading messages instead of having WebResourceLoadScheduler do it:
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Lion build after r134681.
aestes@apple.com [Wed, 14 Nov 2012 23:56:13 +0000 (23:56 +0000)]
Fix the Lion build after r134681.

* WebProcess/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Indexing tests are flaky-crashing
jsbell@chromium.org [Wed, 14 Nov 2012 23:52:06 +0000 (23:52 +0000)]
IndexedDB: Indexing tests are flaky-crashing
https://bugs.webkit.org/show_bug.cgi?id=102283

Reviewed by Tony Chang.

Don't commit the transaction if there are outstanding pre-emptive events
from indexing operations.

Speculative fix for the flakiness.

* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Marked platform/chromium/virtual/deferred/fast/images/exif-orientation...
dglazkov@chromium.org [Wed, 14 Nov 2012 23:43:25 +0000 (23:43 +0000)]
[Chromium] Marked platform/chromium/virtual/deferred/fast/images/exif-orientation.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=102294

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in flexbox when removing absolutely positioned children
tony@chromium.org [Wed, 14 Nov 2012 23:36:04 +0000 (23:36 +0000)]
Crash in flexbox when removing absolutely positioned children
https://bugs.webkit.org/show_bug.cgi?id=100465

Reviewed by Ojan Vafai.

Source/WebCore:

We use m_numberOfChildrenOnFirstLine when computing baseline alignment.
This value gets set during flexbox layout. When we remove an absolutely
positioned child, we don't relayout and this value would get stale.

Change m_numberOfChildrenOnFirstLine to m_numberOfInFlowChildrenOnFirstLine
so the value doesn't get stale when we remove absolutely positioned children.
Also change the loop in firstLineBoxBaseline to bail if we run off the end of
the iterator.

Test: css3/flexbox/crash-removing-out-of-flow-child.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::firstLineBoxBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
* rendering/RenderFlexibleBox.h:

LayoutTests:

Test case for the crash.

* css3/flexbox/crash-removing-out-of-flow-child-expected.txt: Added.
* css3/flexbox/crash-removing-out-of-flow-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't access Node& after adding nodes to the graph.
fpizlo@apple.com [Wed, 14 Nov 2012 23:34:19 +0000 (23:34 +0000)]
Don't access Node& after adding nodes to the graph.
https://bugs.webkit.org/show_bug.cgi?id=102005

Reviewed by Oliver Hunt.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2] Need API in UIProcess to enable loading of custom protocols
aestes@apple.com [Wed, 14 Nov 2012 23:29:37 +0000 (23:29 +0000)]
[WebKit2] Need API in UIProcess to enable loading of custom protocols
https://bugs.webkit.org/show_bug.cgi?id=101674

Reviewed by Brady Eidson.

Source/WebKit2:

Enable clients of WebKit2 to implement NSURLProtocol subclasses to
control the loading of resources with schemes that WebKit2 cannot
handle natively. Since loading happens in a different process, we
accomplish this by registering a global NSURLProtocol in the web
process and proxying NSURLProtocol and NSURLProtocolClient calls to
the client's NSURLProtocol in the UI process.

* DerivedSources.make: Addded new .messages.in files.
* Platform/CoreIPC/MessageID.h:
* Shared/WebProcessCreationParameters.cpp: Added the list of supported schemes.
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(+[WKBrowsingContextController registerSchemeForCustomProtocol:]):
Added a class method where a client can register a scheme that it supports.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]):
Added a class method where a client can unregister a scheme that it no longer supports.
(+[WKBrowsingContextController customSchemes]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h: Added.
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in: Added.
* UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: Added.

Implemented an NSURLConnectionDelegate that proxies messages to the
equivalent NSURLProtocolClient in the web process:
(-[WKCustomProtocolLoader initWithCustomProtocolManagerProxy:customProtocolID:request:connection:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):

Implemented a proxy that recieves -startLoading and -stopLoading
messages from the NSURLProtocol in the web process and starts an
NSURLConnection in the UI process, which will instantiate the client's NSURLProtocol:
(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::didReceiveMessage):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):

* UIProcess/WebContext.h: Declared strings that store names of
NSNotifications used for scheme registration in the UI process.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::didReceiveMessage): Forwarded messages to the
CustomProtocolManagerProxy.
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Added the currently
registered schemes to the WebProcessCreationParameters and register
NSNotification observers for new scheme registration that forwards to
the context's web processes.
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2Prefix.h: Enabled the CUSTOM_PROTOCOLS macro for the Mac.
* WebProcess/Network/CustomProtocols/CustomProtocolManager.h: Added.
* WebProcess/Network/CustomProtocols/CustomProtocolManager.messages.in: Added.
* WebProcess/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm: Added.
(generateCustomProtocolID): Generate a per-WebProcess unique ID.

Implemented a global NSURLProtocol that claims to support all schemes
registered in the UI process. When NSURLConnection calls -startLoading
and -stopLoading, we forward these messages to the client's NSURLProtocol
in the UI process:
(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):

Implemented a manager that receives NSURLConnectionDelegate messages
forwarded from the UI process and passes them to the global NSURLProtocol's NSURLProtocolClient:
(WebKit::CustomProtocolManager::shared):
(WebKit::CustomProtocolManager::registerCustomProtocolClass):
(WebKit::CustomProtocolManager::addCustomProtocol):
(WebKit::CustomProtocolManager::removeCustomProtocol):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didReceiveMessage):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::protocolForID):

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage): Forwarded messages to the
shared CustomProtocolManager.
(WebKit::WebProcess::registerSchemeForCustomProtocol): Register a
scheme received from the UI process.
(WebKit::WebProcess::unregisterSchemeForCustomProtocol): Unregister a
scheme received from the UI process.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Declared messages for passing
supported schemes from the UI process the web process.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Register the
schemes contained in the WebProcessCreationParameters.

Tools:

Add an API test that implements a custom protocol and attempts to load
a resource requiring that protocol in a WKView. The test passes only if
didFinishLoadForFrame: fires.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Added.
(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
* TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
* TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
(-[TestBrowsingContextLoadDelegate initWithBlockToRunOnLoad:]):
(-[TestBrowsingContextLoadDelegate browsingContextControllerDidFinishLoad:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Remove magic numbers in record comparator, handle missing case
jsbell@chromium.org [Wed, 14 Nov 2012 23:28:54 +0000 (23:28 +0000)]
IndexedDB: Remove magic numbers in record comparator, handle missing case
https://bugs.webkit.org/show_bug.cgi?id=102255

Reviewed by Tony Chang.

Source/WebCore:

For some ranges of metadata entries, a simple type byte comparison is sufficient
for the backing store comparator. In two places those ranges used magic numbers,
one of which was incorrect - which could lead to failed reads/writes.

Test: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare):
* Modules/indexeddb/IDBLevelDBCoding.h:

Source/WebKit/chromium:

Add test keys for various metadata types.

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup BasicShape blending check
krit@webkit.org [Wed, 14 Nov 2012 23:27:11 +0000 (23:27 +0000)]
Cleanup BasicShape blending check
https://bugs.webkit.org/show_bug.cgi?id=102289

Reviewed by Daniel Bates.

CSSPropertyAnimation had the same code for varifying that two BasicShape objects can be blended
twice. Refactor the code and add a canBlend method in BasicShape that combines both checks. This
is a preparation for follow-up patches.

Pure refactoring without behavior change, no new tests.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Call new canBlend method for blending verification.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend): Check if two BasicShape objects can be blended.
(WebCore):
* rendering/style/BasicShapes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Basic shapes on 'shape-inside' should be animatable
krit@webkit.org [Wed, 14 Nov 2012 23:09:28 +0000 (23:09 +0000)]
[CSS Exclusions] Basic shapes on 'shape-inside' should be animatable
https://bugs.webkit.org/show_bug.cgi?id=102123

Reviewed by Antti Koivisto.

Source/WebCore:

The '-webkit-shape-inside' propery takes a BasicShape as input like
'-webkit-clip-path'. Follow up on http://trac.webkit.org/changeset/134352 and
make '-webkit-shape-inside' animatable as well.

Test: fast/exclusions/shape-inside/shape-inside-animation.html

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Blend fuction for exclusion shapes. The property takes another
    input then '-webkit-clip-path'.
(WebCore):
(PropertyWrapperBasicShape): Add wrapper for BasicShape object. Can be reused by
    '-webkit-shape-ourside' as well.
(WebCore::PropertyWrapperBasicShape::PropertyWrapperBasicShape):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):

LayoutTests:

Add new animation test for 'shape-inside', similar to 'clip-path' test.

* animations/resources/animation-test-helpers.js:
(getPropertyValue):
(comparePropertyValue):
* fast/exclusions/shape-inside/shape-inside-animation-expected.txt: Added.
* fast/exclusions/shape-inside/shape-inside-animation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoString::append() should handle two 8 bit strings without converting both to 16 bits
msaboff@apple.com [Wed, 14 Nov 2012 23:04:43 +0000 (23:04 +0000)]
String::append() should handle two 8 bit strings without converting both to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=102286

Reviewed by Oliver Hunt.

If both strings are 8 bit, then allocate and copy to a new 8 bit string.  Since most strings are
8 bit, this will save up to 3x the resulting string length in bytes.  2x is due to the possible
surviving 16 bit source string upconversion and 1x for the 16 bit result now being 8 bit.

* wtf/text/WTFString.cpp:
(WTF::String::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TexMap][Cairo] Accelerated compositing debug visuals
commit-queue@webkit.org [Wed, 14 Nov 2012 23:02:37 +0000 (23:02 +0000)]
[TexMap][Cairo] Accelerated compositing debug visuals
https://bugs.webkit.org/show_bug.cgi?id=101883

Patch by Helder Correia <helder.correia@nokia.com> on 2012-11-14
Reviewed by Kenneth Rohde Christiansen.

No new tests, just introducing a debug feature.

Add a Cairo implementation to complement the patch from bug 90116
(http://trac.webkit.org/changeset/122275).

For this feature to be enabled, the environment variable
WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS must be set to 1. Once enabled,
both repaint counters and tile borders will be painted.

A Cairo-specific drawRepaintCounter() implementation was added to
TextureMapperGL. A cairo_surface_t is used as scratch buffer to paint
the counters. It is then uploaded to a BitmapTexture acquired
from the pool and finally draw by TextureMapper. The actual compositing
happens inside LayerBackingStore::paintToTextureMapper(). Each
LayerBackingStoreTile has a repaint counter which gets incremented in
LayerBackingStore::updateTile().

Source/WebCore:

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):

Source/WebKit2:

* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::shouldShowTileDebugVisuals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some defuct flakiness dashboard unittests.
ojan@chromium.org [Wed, 14 Nov 2012 23:01:14 +0000 (23:01 +0000)]
Fix some defuct flakiness dashboard unittests.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Add JSNoStaticTables to IndexedDB interfaces
commit-queue@webkit.org [Wed, 14 Nov 2012 22:47:40 +0000 (22:47 +0000)]
IndexedDB: Add JSNoStaticTables to IndexedDB interfaces
https://bugs.webkit.org/show_bug.cgi?id=102268

Patch by Michael Pruett <michael@68k.org> on 2012-11-14
Reviewed by Geoffrey Garen.

Add JSNoStaticTables attribute to IndexedDB interface
definitions. This attribute must be specified in interfaces
which can be accessed from workers.

Tests: storage/indexeddb/*

* Modules/indexeddb/IDBAny.idl:
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBCursorWithValue.idl:
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBDatabaseException.idl:
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKey.idl:
* Modules/indexeddb/IDBKeyRange.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:
* Modules/indexeddb/IDBUpgradeNeededEvent.idl:
* Modules/indexeddb/IDBVersionChangeEvent.idl:
* Modules/indexeddb/IDBVersionChangeRequest.idl:
* dom/DOMStringList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Replace int64 with int64_t
commit-queue@webkit.org [Wed, 14 Nov 2012 22:42:15 +0000 (22:42 +0000)]
IndexedDB: Replace int64 with int64_t
https://bugs.webkit.org/show_bug.cgi?id=102270

Patch by Michael Pruett <michael@68k.org> on 2012-11-14
Reviewed by Tony Chang.

Cleaning up coding inconsistencies, no change in behavior.

Tests: storage/indexeddb/*

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Do not clear the ProcessingChangeGuard state on DeleteBackward
commit-queue@webkit.org [Wed, 14 Nov 2012 22:39:57 +0000 (22:39 +0000)]
[BlackBerry] Do not clear the ProcessingChangeGuard state on DeleteBackward
https://bugs.webkit.org/show_bug.cgi?id=102284

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-14
Reviewed by Rob Buis.

PR237497
When holding backspace, clearing the state forces a keyboard
update which resets the state of the keyboard. Handling this
specific corner case separate from all other editor commands.

Internally reviewed by Mike Fenton.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] White flicker when scrolling big pages with dark background on slower...
commit-queue@webkit.org [Wed, 14 Nov 2012 22:29:34 +0000 (22:29 +0000)]
[EFL][WK2] White flicker when scrolling big pages with dark background on slower hardware.
https://bugs.webkit.org/show_bug.cgi?id=102000

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-14
Reviewed by Noam Rosenthal.

Add helper functions to clear viewport before painting. Those functions
used by EFL Webkit2 port to set view background to match page background
in order to reduce visibility of flicker during scrolling/scaling/repainting
where page tiles are not ready.

* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore):
* platform/graphics/texmap/TextureMapperGL.h:
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::TextureMapperImageBuffer::drawSolidColor):
(WebCore):
* platform/graphics/texmap/TextureMapperImageBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: print-expectations - add --paths option to print only paths of test expecta...
commit-queue@webkit.org [Wed, 14 Nov 2012 22:25:49 +0000 (22:25 +0000)]
webkitpy: print-expectations - add --paths option to print only paths of test expectation files
https://bugs.webkit.org/show_bug.cgi?id=102269

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-14
Reviewed by Dirk Pranke.

Add --paths option to print-expectations command in order to obtain list of applicable
test expectation file paths.

* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.__init__):
(PrintExpectations.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.run_test):
(PrintExpectationsTest.test_paths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Match the LayerTreeSetting default for acceleratedAnimationEnabled in...
danakj@chromium.org [Wed, 14 Nov 2012 22:24:08 +0000 (22:24 +0000)]
[chromium] Match the LayerTreeSetting default for acceleratedAnimationEnabled in the WebLayerTreeSetting
https://bugs.webkit.org/show_bug.cgi?id=102285

Reviewed by James Robinson.

Accelerated animations default to on.

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating baselines after r134631
junov@google.com [Wed, 14 Nov 2012 22:16:58 +0000 (22:16 +0000)]
Updating baselines after r134631
https://bugs.webkit.org/show_bug.cgi?id=101974

Unreviewed

* platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png: Removed.
* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/efl-wk1/fast/borders: Added.
* platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png: Added.
* platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png: Added.
* platform/efl-wk1/fast/forms/validation-message-appearance-expected.png: Added.
* platform/efl/fast/borders/border-radius-wide-border-01-expected.png: Removed.
* platform/efl/fast/borders/borderRadiusInset01-expected.png: Removed.
* platform/efl/fast/forms/validation-message-appearance-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebgl-background-color.html started failing
commit-queue@webkit.org [Wed, 14 Nov 2012 22:09:12 +0000 (22:09 +0000)]
webgl-background-color.html started failing
https://bugs.webkit.org/show_bug.cgi?id=102247

Patch by James Robinson <jamesr@chromium.org> on 2012-11-14
Reviewed by Adrienne Walker.

The compositor thread should outlive the WebView.

* DumpRenderTree/chromium/TestShell.h:
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed regressions due to adding JSEventListener::m_wrapper null checks.
mark.lam@apple.com [Wed, 14 Nov 2012 22:07:13 +0000 (22:07 +0000)]
Fixed regressions due to adding JSEventListener::m_wrapper null checks.
https://bugs.webkit.org/show_bug.cgi?id=102183.

Reviewed by Geoffrey Garen.

Fixed JSEventListener::operator==() to work within the contract that
when m_wrapper is 0, m_jsFunction is also expected to be 0. Also fixed
some typos in comments.

No new tests.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::visitJSFunction):
(WebCore::JSEventListener::operator==):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-11-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 14 Nov 2012 22:02:05 +0000 (22:02 +0000)]
2012-11-14  Nate Chapin  <japhet@chromium.org>

        Fix chromium asserts from r134649.

        Rubber-stamped by Adam Barth.

        MainResourceLoader was calling releaseResources() twice when cancelled
        within MainResourceLoader::load(), so check reachedTerminalState() before
        calling releaseResources() there.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOnly resolve presentation attribute style once per shared ElementAttributeData.
kling@webkit.org [Wed, 14 Nov 2012 21:58:13 +0000 (21:58 +0000)]
Only resolve presentation attribute style once per shared ElementAttributeData.
<http://webkit.org/b/100990>

Reviewed by Antti Koivisto.

Track the "presentation attribute style dirty" state on ElementAttributeData instead of in a Node flag.
This allows us to avoid duplicate work for ElementAttributeData that are shared between multiple elements,
since the state is no longer per-Element.

I've left the presentation attribute cache in there for now, since it still covers the case where
two elements have the same presentation attributes but different non-presentation attributes.
It's likely that we're not gaining much from it anymore, but that's a topic for another patch.

(WebCore::StyledElement::rebuildPresentationAttributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::presentationAttributeStyle):
(WebCore::ElementAttributeData::ElementAttributeData):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::ElementAttributeData):
(ElementAttributeData):
* dom/Node.h:

    Move presentation attribute style dirty flag from Node to ElementAttributeData.

* dom/ElementAttributeData.cpp:
(SameSizeAsElementAttributeData):

    Add a compile-time object size assertion for ElementAttributeData.

* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):

    Don't mark the presentation attribute style dirty if the element is using an immutable (implies
    shared) ElementAttributeData and another element has already generated the StylePropertySet.
    The element itself is still marked for style recalc like before, this just avoids the process
    of converting the attributes to CSS properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
noam.rosenthal@nokia.com [Wed, 14 Nov 2012 21:56:19 +0000 (21:56 +0000)]
Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
https://bugs.webkit.org/show_bug.cgi?id=102133

Renamed m_CoordinatedGraphicsLayerClient to m_coordinator.
Also, there is no need for calling setCoordinator every time the tree changes,
since we can call it once when the layer is created, now that LayerTreeCoordinator
is the GraphicsLayerFactory.

Reviewed by Kenneth Rohde Christiansen

No change in functionality.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::ensureImageBackingStore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::setCoordinator):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Refactor theme font lookup into a factory
commit-queue@webkit.org [Wed, 14 Nov 2012 21:56:02 +0000 (21:56 +0000)]
[Chromium] Refactor theme font lookup into a factory
https://bugs.webkit.org/show_bug.cgi?id=101949

Patch by Scott Violet <sky@chromium.org> on 2012-11-14
Reviewed by Tony Chang.

This will ultimately allow us to use what is currently in RenderThemeChromiumLinux on windows.

No new tests. Refactoring only.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* rendering/RenderThemeChromiumFontProvider.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::defaultGUIFont): Moved into RenderThemeFontProvider.
* rendering/RenderThemeChromiumFontProvider.h: Added.
(WTF):
(WebCore):
(RenderThemeChromiumFontProvider): This is the font related methods.
* rendering/RenderThemeChromiumFontProviderLinux.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): What was in RenderThemeChromiumSkia::setDefaultFontSize.
(WebCore::RenderThemeChromiumFontProvider::systemFont): What was in RenderThemeChromiumSkia::systemFont.
* rendering/RenderThemeChromiumFontProviderWin.cpp: Added.
(WebCore):
(WebCore::pointsToPixels): Moved from RenderThemeChromiumWin.
(WebCore::getNonClientMetrics): Moved from RenderThemeChromiumWin.
(WebCore::systemFontSize): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::systemFont): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): Moved from RenderThemeChromiumWin.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): Moved into RenderThemeFontProvider.
(WebCore::RenderThemeChromiumSkia::systemFont): Calls to RenderThemeChromiumFontProvider.
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize): Calls to RenderThemeChromiumFontProvider.
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Moves defaultFontSize into RenderThemeChromiumFontProvider.
* rendering/RenderThemeChromiumWin.cpp: Moves font code into RenderThemeFontProviderWin.
(WebCore):
* rendering/RenderThemeChromiumWin.h: Removed overriden methods now handled by RenderThemeChromiumSkia.
(RenderThemeChromiumWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: test conversion batch 3
dgrogan@chromium.org [Wed, 14 Nov 2012 21:52:49 +0000 (21:52 +0000)]
IndexedDB: test conversion batch 3
https://bugs.webkit.org/show_bug.cgi?id=102168

Reviewed by Tony Chang.

These were all pretty straightforward. metadata.html could include
some additional tests that check the metadata after a versionchange
transaction aborts, but I think that's tested in one of the intversion
tests.

* storage/indexeddb/exceptions-expected.txt:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/index-duplicate-keypaths-expected.txt:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-population-expected.txt:
* storage/indexeddb/metadata-expected.txt:
* storage/indexeddb/resources/database-basics.js:
  Fix failure when run as a chromium browser test.

* storage/indexeddb/resources/exceptions.js:
  Moved some asserts from running before the database is opened to
  afterward but they appear to be testing the same thing.
(transactionComplete):
  close can't proceed until the transactions are complete, something
  setVersion didn't have to deal with.

* storage/indexeddb/resources/factory-deletedatabase.js:
  The conditions under which deleteDatabase is called in this test is
  _slightly_ different. Previously, deleteDatabase was called from
  inside a versionchange transaction, causing the original connection
  to receive a versionchange event. With upgradeneeded we have to close
  the original connection before entering a versionchange transaction,
  so the second connection is now what closes in response to the
  deleteDatabase's versionchange event.

* storage/indexeddb/resources/index-duplicate-keypaths.js:
(testCollideAutoIncrementSetup):
(testCollideAutoIncrement):
* storage/indexeddb/resources/index-multientry.js:
(prepareDatabase):
(createIndexOnStoreWithData):
* storage/indexeddb/resources/index-population.js:
(prepareDatabase.request.onsuccess):
(prepareDatabase):
(doSetVersion2):
(setVersion2):
(setVersion2Abort):
* storage/indexeddb/resources/metadata.js:
(prepareDatabase):
(snapshotConnection1):
(secondOpen.request.onupgradeneeded):
(secondOpen.request.onsuccess):
(secondOpen):
(thirdOpen.request.onupgradeneeded):
(thirdOpen.request.onerror):
(thirdOpen):
(fourthOpen.request.onupgradeneeded):
(fourthOpen.request.onsuccess):
(fourthOpen):
(checkState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Updating baselines after r134631.
dglazkov@chromium.org [Wed, 14 Nov 2012 21:47:39 +0000 (21:47 +0000)]
[Chromium] Updating baselines after r134631.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: InUseAttributeError
arv@chromium.org [Wed, 14 Nov 2012 21:27:51 +0000 (21:27 +0000)]
Update DOMException name: InUseAttributeError
https://bugs.webkit.org/show_bug.cgi?id=102141

Reviewed by Ojan Vafai.

Patch 10 of 25 to update DOMException name to match the spec and Firefox.

The name for this is not in the spec but the case was selected to match
Firefox. http://mxr.mozilla.org/mozilla-central/source/dom/base/domerr.msg#18

INUSE_ATTRIBUTE_ERR is historical and not used in any spec or any of our tests.

* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMarked fake-mouse-move tests as failing.
dglazkov@chromium.org [Wed, 14 Nov 2012 21:27:22 +0000 (21:27 +0000)]
Marked fake-mouse-move tests as failing.
https://bugs.webkit.org/show_bug.cgi?id=102277

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Incorrect line-height for styled menulist (select tag)
bfulgham@webkit.org [Wed, 14 Nov 2012 21:26:05 +0000 (21:26 +0000)]
[WinCairo] Incorrect line-height for styled menulist (select tag)
in windows theme.
https://bugs.webkit.org/show_bug.cgi?id=79435

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-11-14
Reviewed by Brent Fulgham

Applied same fix as in RenderThemeSafari::adjustMenuListButtonStyle
to Windows theme to fix issue.

Tests: fast/forms/menulist-restrict-line-height.html
       fast/forms/control-restrict-line-height.html
       fast/forms/basic-selects.html

* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustMenuListButtonStyle): Set line
height to the correct initial height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore steps towards actually hosting layers in the UI process
andersca@apple.com [Wed, 14 Nov 2012 21:16:41 +0000 (21:16 +0000)]
More steps towards actually hosting layers in the UI process
https://bugs.webkit.org/show_bug.cgi?id=102275

Reviewed by Andreas Kling.

* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::rootLayerID):
Add a getter for the root layer ID.

* UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
Add root layer member variable. Make the RemoteLayerTreeHost class a GraphicsLayerClient.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
Initialize the root layer to null.

(WebKit::RemoteLayerTreeHost::notifyAnimationStarted):
(WebKit::RemoteLayerTreeHost::notifyFlushRequired):
(WebKit::RemoteLayerTreeHost::paintContents):
Add empty stubs.

(WebKit::RemoteLayerTreeHost::commit):
Try to get the root layer.

(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
Look up the layer with the given ID in the m_layers hash table and create it if it doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: WrongDocumentError
arv@chromium.org [Wed, 14 Nov 2012 21:05:40 +0000 (21:05 +0000)]
Update DOMException name: WrongDocumentError
https://bugs.webkit.org/show_bug.cgi?id=102096

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 4 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/Range/compareBoundaryPoints-1-expected.txt:
* fast/dom/Range/compareBoundaryPoints-1.html:
* fast/dom/move-nodes-across-documents.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Don't let shift-click turn popup into tab.
ericu@chromium.org [Wed, 14 Nov 2012 20:52:56 +0000 (20:52 +0000)]
[chromium] Don't let shift-click turn popup into tab.
https://bugs.webkit.org/show_bug.cgi?id=102254

Reviewed by Adam Barth.

Change http://trac.webkit.org/changeset/132399 broke shift-click on
compose in GMail.  We didn't want to change behavior that people were
depending on, and this quick fix seems a good compromise between user
intent and developer intent.

* src/ChromeClientImpl.cpp:
(WebKit::updatePolicyForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Improve debug functionality in FatFingers
rwlbuis@webkit.org [Wed, 14 Nov 2012 20:51:45 +0000 (20:51 +0000)]
[BlackBerry] Improve debug functionality in FatFingers
https://bugs.webkit.org/show_bug.cgi?id=102263

Reviewed by Antonio Gomes.

- use logAlways to log even in release.
- dump shadow tree info if available.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::checkForText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Production build after r134640 broke it.
beidson@apple.com [Wed, 14 Nov 2012 20:42:39 +0000 (20:42 +0000)]
Fix the Production build after r134640 broke it.

* WebProcess/Network/WebResourceLoader.h:
(WebKit::WebResourceLoader::resourceLoadIdentifier): Use the un-used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPDFPlugin should make use of PDFKit's fluid zooming
timothy_horton@apple.com [Wed, 14 Nov 2012 20:38:46 +0000 (20:38 +0000)]
PDFPlugin should make use of PDFKit's fluid zooming
https://bugs.webkit.org/show_bug.cgi?id=101962
<rdar://problem/12555229>

Reviewed by Anders Carlsson.

Expose the notion of a frame that handles page scale gestures via WebFrame and to the bundle via WKBundleFrame.
The only frames that will purport to handle page scale gestures are those which contain PluginDocuments
backed by PDFPlugin, for now. Also, allow PDFKit to do its own fluid zooming animation.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameHandlesPageScaleGesture): Provide WKBundleFrameHandlesPageScaleGesture to
inform the injected bundle whether or not the frame handles scaling itself.
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Add WKBundleFrameHandlesPageScaleGesture.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::geometryDidChange): Allow PDFKit to use its fluid zooming instead of changing
the scale factor immediately.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::handlesPageScaleGesture): For now, the only frames that handle page scale
gestures themselves are plugins that purport to handle page scale changes themselves (i.e. only PDFPlugin).
* WebProcess/WebPage/WebFrame.h:
(WebFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove empty loading to DocumentLoader, simplify FrameLoader::init()
japhet@chromium.org [Wed, 14 Nov 2012 20:35:21 +0000 (20:35 +0000)]
Move empty loading to DocumentLoader, simplify FrameLoader::init()
https://bugs.webkit.org/show_bug.cgi?id=101512

Reviewed by Adam Barth.

Source/WebCore:

No new tests, though several outputs changed because we no longer send resource
    load callbacks for empty loads.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Handle empty main resource
    loads directly here.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader): Initialize some variables whose values
    were previously being reset in init(). Given that the FrameLoader is in
    an inconsistent state before init() is called anyway, there doesn't seem
    to be a disadvantage to just initializing them to their post-init() values.
(WebCore::FrameLoader::init): Just call startLoadingMainResource(), instead of
    doing a bunch of direct calls to functions FrameLoader shouldn't know about.
* loader/FrameLoaderStateMachine.cpp:
* loader/FrameLoaderStateMachine.h:
* loader/MainResourceLoader.cpp: Throughout, remove the concept of an empty load.
(WebCore::MainResourceLoader::loadNow): This only returned true when an empty
    load got deferred, which won't happen now. Return void and always treat
    as returning false.
* loader/MainResourceLoader.h:

Tools:

Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
interprets them as a non-empty load. This ensures
http/tests/navigation/new-window-redirect-history.html continues to pass
in chromium.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):

LayoutTests:

Don't expect resource load callbacks for empty loads.

* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/loading/redirect-methods-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: InvalidStateError
arv@chromium.org [Wed, 14 Nov 2012 20:28:32 +0000 (20:28 +0000)]
Update DOMException name: InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=102241

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 11 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/HTMLDialogElement/dialog-open-expected.txt:
* fast/dom/HTMLDialogElement/dialog-open.html:
* fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt:
* fast/dom/HTMLDialogElement/dialog-show-modal.html:
* fast/dom/Range/range-intersectsNode-exception-expected.txt:
* fast/dom/Range/range-intersectsNode-exception.html:
* fast/dom/Range/range-intersectsNode-expected.txt:
* fast/dom/Range/resources/intersectsNode.js:
* fast/dom/Selection/collapseToX-empty-selection-expected.txt:
* fast/dom/Selection/script-tests/collapseToX-empty-selection.js:
* fast/events/message-port-clone-expected.txt:
* fast/events/message-port-multi-expected.txt:
* fast/files/read-file-async-expected.txt:
* fast/files/workers/worker-read-file-async-expected.txt:
* fast/forms/color/color-setrangetext-expected.txt:
* fast/forms/date/date-setrangetext-expected.txt:
* fast/forms/date/date-stepup-stepdown-expected.txt:
* fast/forms/date/date-stepup-stepdown.html:
* fast/forms/datetime/datetime-setrangetext-expected.txt:
* fast/forms/datetime/datetime-stepup-stepdown-expected.txt:
* fast/forms/datetime/datetime-stepup-stepdown.html:
* fast/forms/datetimelocal/datetimelocal-setrangetext-expected.txt:
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt:
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html:
* fast/forms/file/file-setrangetext-expected.txt:
* fast/forms/file/input-file-value-expected.txt:
* fast/forms/hidden/hidden-setrangetext-expected.txt:
* fast/forms/image/image-setrangetext-expected.txt:
* fast/forms/input-stepup-stepdown-expected.txt:
* fast/forms/input-stepup-stepdown.html:
* fast/forms/input-valueasnumber-unsupported-expected.txt:
* fast/forms/input-valueasnumber-unsupported.html:
* fast/forms/month/input-valueasdate-expected.txt:
* fast/forms/month/input-valueasdate.html:
* fast/forms/month/month-setrangetext-expected.txt:
* fast/forms/month/month-stepup-stepdown-expected.txt:
* fast/forms/month/month-stepup-stepdown.html:
* fast/forms/number/number-setrangetext-expected.txt:
* fast/forms/number/number-stepup-stepdown-expected.txt:
* fast/forms/number/number-stepup-stepdown-from-renderer.html:
* fast/forms/number/number-stepup-stepdown.html:
* fast/forms/number/number-valueasnumber-expected.txt:
* fast/forms/number/number-valueasnumber.html:
* fast/forms/range/range-setrangetext-expected.txt:
* fast/forms/range/range-stepup-stepdown-expected.txt:
* fast/forms/range/range-stepup-stepdown-from-renderer.html:
* fast/forms/range/range-stepup-stepdown.html:
* fast/forms/setrangetext-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
* fast/forms/time/time-setrangetext-expected.txt:
* fast/forms/time/time-stepup-stepdown-expected.txt:
* fast/forms/time/time-stepup-stepdown.html:
* fast/forms/week/week-setrangetext-expected.txt:
* fast/forms/week/week-stepup-stepdown-expected.txt:
* fast/forms/week/week-stepup-stepdown.html:
* fast/js/dfg-custom-getter-throw-expected.txt:
* fast/js/dfg-custom-getter-throw-inlined-expected.txt:
* fast/js/script-tests/dfg-custom-getter-throw-inlined.js:
* fast/js/script-tests/dfg-custom-getter-throw.js:
* fast/mediastream/MediaStreamTrackList-expected.txt:
* fast/notifications/notifications-document-close-crash-expected.txt:
* fast/speech/scripted/start-exception-expected.txt:
* fast/speech/scripted/start-exception.html:
* fast/workers/worker-context-multi-port-expected.txt:
* fast/workers/worker-multi-port-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responseXML-xml-text-responsetype-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt:
* fast/xpath/detached-subtree-invalidate-iterator-expected.txt:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
* http/tests/media/media-source/video-media-source-duration-changed-expected.txt:
* http/tests/media/media-source/video-media-source-objects-expected.txt:
* http/tests/xmlhttprequest/exceptions-expected.txt:
* http/tests/xmlhttprequest/zero-length-response-expected.txt:
* platform/chromium-mac/fast/notifications/notifications-document-close-crash-expected.txt:
* platform/qt/editing/pasteboard/data-transfer-items-expected.txt:
* platform/qt/fast/notifications/notifications-document-close-crash-expected.txt:
* storage/websql/open-database-set-empty-version-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPDFPlugin should support downloading PDFs
timothy_horton@apple.com [Wed, 14 Nov 2012 20:27:08 +0000 (20:27 +0000)]
PDFPlugin should support downloading PDFs
https://bugs.webkit.org/show_bug.cgi?id=102152
<rdar://problem/12555313>

Reviewed by Alexey Proskuryakov.

Clicking on the "Download PDF" HUD button should download the current
PDF to the Downloads folder.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder): Added. Save the
PDF data to disk, in the Downloads folder. This will only save files with
the .pdf extension, and of MIME type "application/pdf".
* UIProcess/WebPageProxy.h:
(WebPageProxy): Add savePDFToFileInDownloadsFolder.
* UIProcess/WebPageProxy.messages.in: Add savePDFToFileInDownloadsFolder.
* WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin): Add saveToPDF().
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate saveToPDF]): Forward saveToPDF delegate callback to PDFPlugin.
(WebKit::PDFPlugin::saveToPDF): Hand WebPageProxy the raw data for the
current PDF, which it will save to the Downloads folder. We receive
the suggested filename during loading.
* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
(WebKit::SimplePDFPlugin::suggestedFilename): Expose a getter for suggestedFilename.
* WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::pluginInfo): Add a missing space after an operator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename NATIVE_TYPE_ERR to TypeError
jsbell@chromium.org [Wed, 14 Nov 2012 20:22:41 +0000 (20:22 +0000)]
Rename NATIVE_TYPE_ERR to TypeError
https://bugs.webkit.org/show_bug.cgi?id=102114

Reviewed by Kentaro Hara.

Defines names (mostly) matching WebIDL exception types for use by dom (etc) code.
V8 binding code had colliding enum members, which required prefixing.

No new tests - just internal renames.

* Modules/indexeddb/IDBCursor.cpp: s/NATIVE_TYPE_ERR/TypeError/g
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
* Modules/indexeddb/IDBDatabase.cpp: Ditto.
(WebCore::IDBDatabase::setVersion):
* Modules/indexeddb/IDBFactory.cpp: Ditto.
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBObjectStore.cpp: Ditto.
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBTransaction.cpp: Ditto.
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
* bindings/js/JSDOMBinding.cpp: Ditto.
(WebCore::setDOMException):
* bindings/v8/DateExtension.cpp: Prefix ErrorType enum/members w/ V8/v8.
(WebCore::DateExtension::OnSleepDetected):
* bindings/v8/NPV8Object.cpp: Ditto.
(_NPN_SetException):
* bindings/v8/V8Binding.cpp: Ditto.
(WebCore::throwError):
(WebCore::handleMaxRecursionDepthExceeded):
* bindings/v8/V8Binding.h: Ditto.
(WebCore):
* bindings/v8/V8NPObject.cpp: Ditto.
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8ThrowException.cpp: Rename ALL the errors!
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):
* bindings/v8/V8ThrowException.h:
(V8ThrowException):
* bindings/v8/WorkerContextExecutionProxy.cpp: Prefixing (continued)
(WebCore::WorkerContextExecutionProxy::evaluate):
* bindings/v8/custom/V8ArrayBufferCustom.cpp: Ditto.
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h: Ditto.
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioContextCustom.cpp: Ditto.
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp: Ditto.
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Ditto.
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Ditto.
(WebCore::V8SQLResultSetRowList::itemCallback):
* dom/ExceptionCode.h: Add WebIDL exception types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Style BB10 time input field font.
commit-queue@webkit.org [Wed, 14 Nov 2012 20:19:15 +0000 (20:19 +0000)]
[BlackBerry] Style BB10 time input field font.
https://bugs.webkit.org/show_bug.cgi?id=102260.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-14
Reviewed by Rob Buis.

RIM PR 243355
Adjust time input field font using BB10 system default font.

* css/themeBlackBerry.css:
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocreateDelay should raise exception when the maxDelayTime parameter is incorrect.
commit-queue@webkit.org [Wed, 14 Nov 2012 20:14:08 +0000 (20:14 +0000)]
createDelay should raise exception when the maxDelayTime parameter is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=102173

Patch by Li Yin <li.yin@intel.com> on 2012-11-14
Reviewed by Chris Rogers.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
The specified value must be greater than zero and less than three minutes or a
NOT_SUPPORTED_ERR exception will be thrown.

Source/WebCore:

Tests: webaudio/delaynode-maxdelaylimit.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createDelay):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioContext.idl: Add raising exception for createDelay.
* Modules/webaudio/DelayNode.cpp:
(WebCore):
(WebCore::DelayNode::DelayNode):
* Modules/webaudio/DelayNode.h:
(WebCore::DelayNode::create):
(DelayNode):

LayoutTests:

* webaudio/delaynode-maxdelaylimit-expected.txt:
* webaudio/delaynode-maxdelaylimit.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] css3/filters/custom/custom-filter-property-computed-style.html is a flaky...
dglazkov@chromium.org [Wed, 14 Nov 2012 19:57:24 +0000 (19:57 +0000)]
[Chromium] css3/filters/custom/custom-filter-property-computed-style.html is a flaky timeout in debug.
https://bugs.webkit.org/show_bug.cgi?id=90207

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't pass a paintingRoot when painting from RenderLayerBacking
simon.fraser@apple.com [Wed, 14 Nov 2012 19:48:25 +0000 (19:48 +0000)]
Don't pass a paintingRoot when painting from RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=102256

Reviewed by David Hyatt.

The 'paintingRoot' parameter to the RenderLayer paint functions
is used when painting just a subtree (e.g. when painting dragged
selections). There is no need to pass it when a RenderLayerBacking
paints its contents or overlay scrollbars.

Passing it requires an expensive isDescendant() check, so passing
null is more efficient.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Updated the type of flakiness for fast/forms/select/select-state-restore...
dglazkov@chromium.org [Wed, 14 Nov 2012 19:44:47 +0000 (19:44 +0000)]
[Chromium] Updated the type of flakiness for fast/forms/select/select-state-restore.html.
https://bugs.webkit.org/show_bug.cgi?id=90207

* platform/chromium/TestExpectations: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPart of "Move loading responsibility out of WebResourceLoadScheduler into a new WebRe...
beidson@apple.com [Wed, 14 Nov 2012 19:43:42 +0000 (19:43 +0000)]
Part of "Move loading responsibility out of WebResourceLoadScheduler into a new WebResourceLoader"
https://bugs.webkit.org/show_bug.cgi?id=102259

Reviewed by Alexey Proskuryakov.

WebResourceLoadScheduler has taken on too many responsibilities that shouldn't belong to it.

We should create a WebResourceLoader that will eventually act as an intermediary between
WebCore::ResourceLoader and NetworkResourceLoader.

This patch is prep-work: It adds a new skeleton class to the WebProcess.

* WebKit2.xcodeproj/project.pbxproj:

Add the new WebResourceLoader class which is a very thin skeleton for now:
* WebProcess/Network/WebResourceLoader.cpp: Added.
(WebKit::WebResourceLoader::create):
(WebKit::WebResourceLoader::WebResourceLoader):
(WebKit::WebResourceLoader::~WebResourceLoader):
* WebProcess/Network/WebResourceLoader.h: Added.
(WebKit::WebResourceLoader::coreLoader):

Adapt WebResourceLoadScheduler to use this new class where appropriate:
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addMainResourceLoad):
(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::willSendRequest):
(WebKit::WebResourceLoadScheduler::didReceiveResponse):
(WebKit::WebResourceLoadScheduler::didReceiveData):
(WebKit::WebResourceLoadScheduler::didFinishResourceLoad):
(WebKit::WebResourceLoadScheduler::didReceiveResource):
(WebKit::WebResourceLoadScheduler::didFailResourceLoad):
* WebProcess/Network/WebResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined test results.
arv@chromium.org [Wed, 14 Nov 2012 19:43:05 +0000 (19:43 +0000)]
Unreviewed. Rebaselined test results.

* fast/media/mq-js-media-except-01-expected.txt: Renamed from LayoutTests/platform/mac/fast/media/mq-js-media-except-01-expected.txt.
* platform/chromium-linux-x86/svg/dom/SVGTransformList-basics-expected.png: Removed.
* platform/chromium-mac-lion/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-mac-lion/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-win/fast/media/mq-js-media-except-01-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-getItem-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/chromium-win/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium/fast/media/mq-js-media-except-01-expected.txt: Removed.
* platform/efl-wk1/fast/media/mq-js-media-except-01-expected.txt: Renamed from LayoutTests/platform/efl/fast/media/mq-js-media-except-01-expected.txt.
* platform/efl-wk1/svg/dom/SVGLengthList-appendItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-appendItem-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-initialize-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-initialize-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-insertItemBefore-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-insertItemBefore-expected.png.
* platform/efl-wk1/svg/dom/SVGLengthList-replaceItem-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-replaceItem-expected.png.
* platform/efl-wk1/svg/dom/SVGNumberList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGNumberList-basics-expected.png.
* platform/qt/fast/files/workers/worker-read-blob-sync-expected.txt: Added.
* platform/qt/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 19:37:59 +0000 (19:37 +0000)]
Unreviewed GTK gardening.

Adding back and updating baselines that were removed by accident in r133908.

* platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
* platform/gtk/fast/forms/basic-textareas-quirks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorunCount in runner.js should be renamed to iterationCount
rniwa@webkit.org [Wed, 14 Nov 2012 19:34:49 +0000 (19:34 +0000)]
runCount in runner.js should be renamed to iterationCount
https://bugs.webkit.org/show_bug.cgi?id=102208

Reviewed by Tony Chang.

Prior to this patch, there were terminology confusions between "runs" and "iterations".
The term "run" should refer to running a performance test once, and "iteration" should
refer to one measurement in the test. i.e. Executing run-perf-should once will result in
a single "run" of performance tests and each test may execute multiple "iterations"
to complete the run.

Unfortunately, we still overload the meaning of "runs" in "runs/s" (is "function calls/s")
but that could be addressed in a separate patch.

* Animation/balls.html:
* DOM/DOMTable.html:
* DOM/resources/dom-perf.js:
* Layout/floats_100_100.html:
* Layout/floats_100_100_nested.html:
* Layout/floats_20_100.html:
* Layout/floats_20_100_nested.html:
* Layout/floats_2_100.html:
* Layout/floats_2_100_nested.html:
* Layout/floats_50_100.html:
* Layout/floats_50_100_nested.html:
* Layout/subtree-detaching.html:
* Parser/html5-full-render.html:
* SVG/SvgHitTesting.html:
* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove uses of deprecated unittest.TestCase aliases
zandobersek@gmail.com [Wed, 14 Nov 2012 19:29:25 +0000 (19:29 +0000)]
Remove uses of deprecated unittest.TestCase aliases
https://bugs.webkit.org/show_bug.cgi?id=102253

Reviewed by Dirk Pranke.

Replace the deprecated unittest.TestCase methods with the corresponding methods
everywhere inside the Tools directory. The following replacements are done:
- assertEquals -> assertEqual
- assert_ -> assertTrue
- failUnlessRaises -> assertRaises

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(SVNMirrorTest.test_CheckOutSource):
* QueueStatusServer/model/queuepropertymixin_unittest.py:
(QueuePropertyMixinTest.test_queue_property):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest._assert_short_name):
(QueueTest._assert_display_name):
(QueueTest._assert_name_with_underscores):
* QueueStatusServer/model/workitems_unittest.py:
(WorkItemsTest.test_display_position_for_attachment):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_log_entries_from_changelog):
(test_parse_log_entries_from_annotated_file):
(_assert_parse_reviewer_text_and_list):
(_assert_parse_reviewer_text_list):
(_assert_fuzzy_reviewer_match):
(_assert_parse_authors):
(test_latest_entry_parse):
(test_latest_entry_parse_single_entry):
(test_set_reviewer):
(test_set_short_description_and_bug_url):
* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
(DiffParserTest.test_diff_parser):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitSVNTest.test_revisions_changing_files_with_local_commit):
(GitSVNTest.test_upstream_branch):
(GitSVNTest.test_create_patch_with_rm_and_changed_files):
(GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_efl_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_chromium_port):
(DeprecatedPortTest.test_chromium_android_port):
(DeprecatedPortTest.test_chromium_xvfb_port):
* Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
(URLsTest.test_parse_attachment_id):
* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.assert_filesystem_normalizes):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_url_creation):
(test_parse_bug_id):
(_assert_dictionaries_equal):
(test_parse_bugs_from_xml):
(test_attachment_detail_bug_parsing):
(_assert_result_count):
(test_request_page_parsing):
(test_quip_page_parsing):
(EditUsersParserTest._assert_login_userid_pairs):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_status_parsing):
(test_latest_cached_build):
(test_results_zip_url):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_credentials_from_environment):
* Scripts/webkitpy/common/net/failuremap_unittest.py:
(FailureMapTest.test_failing_revisions):
(FailureMapTest.test_new_failures):
(FailureMapTest.test_new_failures_with_old_revisions):
(FailureMapTest.test_new_failures_with_more_old_revisions):
(FailureMapTest.test_tests_failing_for):
(FailureMapTest.test_failing_tests):
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(LayoutTestResultsTest.test_set_failure_limit_count):
* Scripts/webkitpy/common/net/unittestresults_unittest.py:
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
* Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
(ReadChecksumFromPngTest.test_read_checksum):
* Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
(LoggingTest.assert_log_equals):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ScriptErrorTest.test_string_from_args):
(ScriptErrorTest.test_message_with_output):
(ExecutiveTest.test_run_command_with_bad_command):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.serial_test_run_in_parallel):
* Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
(MockFileSystemTest.quick_check):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(GenericFileSystemTests.test_glob__trailing_asterisk):
(GenericFileSystemTests.test_glob__leading_asterisk):
(GenericFileSystemTests.test_glob__middle_asterisk):
(GenericFileSystemTests.test_glob__period_is_escaped):
(RealFileSystemTest.test_chdir):
(RealFileSystemTest.test_remove_file_with_retry):
(RealFileSystemTest.test_sep):
* Scripts/webkitpy/common/system/logtesting.py:
(TestLogStream.assertMessages):
* Scripts/webkitpy/common/system/logutils_unittest.py:
(GetLoggerTest.test_get_logger_in_webkitpy):
(GetLoggerTest.test_get_logger_not_in_webkitpy):
* Scripts/webkitpy/common/system/outputcapture.py:
(OutputCaptureTestCaseBase.assertStdout):
(OutputCaptureTestCaseBase.assertStderr):
* Scripts/webkitpy/common/system/path_unittest.py:
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_real_code):
(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/common/system/user_unittest.py:
(UserTest.test_confirm.mock_raw_input):
(UserTest.test_confirm):
* Scripts/webkitpy/common/system/zipfileset_unittest.py:
(ZipFileSetTest.test_open):
(ZipFileSetTest.test_read):
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
(WatchListTest.test_filename_definition_no_matches):
(WatchListTest.test_filename_definition):
(WatchListTest.test_cc_rules_simple):
(WatchListTest.test_cc_rules_complex):
(WatchListTest.test_cc_and_message_rules_complex):
(WatchListTest.test_cc_and_message_rules_no_matches):
(WatchListTest.test_added_match):
(WatchListTest.test_deleted_match):
(WatchListTest.test_more_and_less_match):
(WatchListTest.test_complex_match):
* Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LockCheckingRunner.handle_finished_list):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
(LayoutTestRunnerTests.test_servers_started):
(SharderTests.assert_shards):
(SharderTests.test_shard_in_two_has_no_locked_shards):
(SharderTests.test_shard_in_two_has_no_unlocked_shards):
(NaturalCompareTest.assert_cmp):
(KeyCompareTest.assert_cmp):
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_init):
(SpecifierSorterTest.test_add_specifier):
(SpecifierSorterTest.test_add_macros):
(SpecifierSorterTest.test_category_priority):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_macro_collapsing):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
(TestConfigurationConverterTest.test_specifier_converter_access):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_exp):
(MiscTests.test_result_was_expected):
(MiscTests.test_remove_pixel_failures):
(MiscTests.test_suffixes_for_expectations):
(MiscTests.test_get_expectations_string):
(SkippedTests.check):
(ExpectationSyntaxTests.assert_tokenize_exp):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_missing_bugid):
(TestExpectationSerializationTests.test_reconstitute_only_these):
* Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_crashes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_nonexistant_expectations):
(PortTest.test_additional_expectations):
* Scripts/webkitpy/layout_tests/port/builders_unittest.py:
(BuildersTest.test_path_from_name):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_default_timeout_ms):
(ChromiumAndroidPortTest.test_get_devices_one_device):
(ChromiumAndroidPortTest.test_get_devices_two_devices):
(ChromiumAndroidPortTest.test_get_device_serial_one_device):
(ChromiumAndroidPortTest.test_get_device_serial_two_devices):
(ChromiumAndroidPortTest.test_must_require_http_server):
(ChromiumAndroidDriverTest.test_get_last_stacktrace):
(ChromiumAndroidDriverTest.test_get_crash_log):
(ChromiumAndroidDriverTest.test_cmd_line):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_command_from_driver_input):
(ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
(ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_determine_architecture_fails):
(ChromiumLinuxPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.assert_name):
(ChromiumMacPortTest.test_baseline_path):
(ChromiumMacPortTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_max_locked_shards):
(ChromiumPortTestCase.test_default_timeout_ms):
(ChromiumPortTestCase.test_default_pixel_tests):
(ChromiumPortTestCase.test_all_test_configurations):
(ChromiumPortTestCase.test_default_configuration):
(ChromiumPortTestCase.test_diff_image):
(ChromiumPortTestCase.test_diff_image_crashed):
(ChromiumPortTestCase.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_setup_environ_for_server_cygpath):
(ChromiumWinTest.assert_name):
(ChromiumWinTest.test_baseline_path):
(ChromiumWinTest.test_path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_no_timeout):
(DriverTest.test_check_for_driver_crash.assert_crash):
(DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_get_from_builder_name):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
(HttpLockTest.test_current_lock_pid):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
(TestImageDiffer.test_diff_image_failed):
(TestImageDiffer.test_diff_image_passed):
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
(LeakDetectorTest.test_leaks_args):
(test_parse_leaks_output):
(test_leaks_files_in_directory):
(test_count_total_leaks):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.test_default_timeout_ms):
(assert_name):
(test_setup_environ_for_server):
(_assert_search_path):
(test_32bit):
(test_64bit):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockTestShellTest.test_pixeltest__fails):
(MockTestShellTest.test_test_shell_parse_options):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_max_locked_shards):
(PortTestCase.test_default_timeout_ms):
(PortTestCase.test_default_pixel_tests):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image_crashed):
(PortTestCase.test_get_crash_log):
(PortTestCase.assert_build_path):
(PortTestCase.test_expectations_ordering):
(_assert_config_file_for_platform):
(test_path_to_apache_config_file):
(test_additional_platform_directory):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):
(QtPortTest.test_setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_basic):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest._assert_search_path):
(WinPortTest._assert_version):
(WinPortTest.test_runtime_feature_list):
(WinPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations):
(MainTest.test_all):
(MainTest.test_repeat_each):
(MainTest.test_skipped_flag):
(MainTest.test_iterations):
(MainTest.test_run_chunk):
(MainTest.test_run_part):
(MainTest.test_run_singly):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_single_file):
(MainTest.test_single_file_with_prefix):
(MainTest.test_single_skipped_file):
(MainTest.test_stderr_is_saved):
(MainTest.test_test_list):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_exit_after_n_failures):
(MainTest.test_exit_after_n_crashes):
(MainTest.test_retrying_and_flaky_tests):
(MainTest.test_run_order__inline):
(MainTest.test_reftest_run):
(MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
(MainTest.test_reftest_skip_reftests_if_no_ref_tests):
(MainTest.test_reftest_expected_html_should_be_ignored):
(MainTest.test_reftest_driver_should_run_expected_html):
(MainTest.test_reftest_driver_should_run_expected_mismatch_html):
(MainTest.test_output_diffs):
(MainTest.test_unsupported_platform):
(EndToEndTest.test_end_to_end):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
* Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
(BaseTest.integration_test_server__normal):
(BaseTest.integration_test_server__fails):
(BaseTest.integration_test_port_and_root):
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_start_cmd):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest.test_logging_not_included):
(RegularTest._basic):
(RegularTest.test_basic):
(RegularTest.test_log_after_update):
(RegularTest.test_log_args):
(TtyTest.test_basic):
(TtyTest.test_log_after_update):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
(VerboseTest.test_log_args):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.assertWritten):
(test_test_status_line):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.assertWritten):
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_webkit_base_filter_rules):
(CheckerDispatcherSkipTest._assert_should_skip_without_warning):
(CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
(CheckerDispatcherDispatchTest.assert_checker):
(CheckerDispatcherDispatchTest.test_changelog_paths):
(CheckerDispatcherDispatchTest.test_cpp_paths):
(CheckerDispatcherDispatchTest.test_json_paths):
(CheckerDispatcherDispatchTest.test_python_paths):
(CheckerDispatcherDispatchTest.test_text_paths):
(CheckerDispatcherDispatchTest.test_xml_paths):
(StyleProcessorConfigurationTest.test_init):
(StyleProcessorConfigurationTest.test_write_style_error_emacs):
(StyleProcessorConfigurationTest.test_write_style_error_vs7):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.assert_error.handle_style_error):
(ChangeLogCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/common_unittest.py:
(CarriageReturnCheckerTest.assert_carriage_return):
(TabCheckerTest.assert_tab):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppFunctionsTest.test_convert_to_lower_with_underscores):
(CppFunctionsTest.test_create_acronym):
(CppFunctionsTest.test_parameter):
(CppFunctionsTest.test_single_line_view):
(CppFunctionsTest.test_create_skeleton_parameters):
(CppFunctionsTest.test_find_parameter_name_index):
(CppFunctionsTest.test_parameter_list):
(CppFunctionsTest.test_check_parameter_against_text):
(CppStyleTestBase.perform_lint):
(CppStyleTestBase.assert_lint):
(CppStyleTestBase.assert_lint_one_of_many_errors_re):
(CppStyleTestBase.assert_multi_line_lint):
(CppStyleTestBase.assert_language_rules_check):
(CppStyleTestBase.assert_include_what_you_use):
(CppStyleTestBase.assert_blank_lines_check):
(CppStyleTestBase.assert_positions_equal):
(FunctionDetectionTest.perform_function_detection):
(CppStyleTest.test_get_line_width):
(CppStyleTest.test_find_next_multi_line_comment_start):
(CppStyleTest.test_find_next_multi_line_comment_end):
(CppStyleTest.test_remove_multi_line_comments_from_range):
(CppStyleTest.test_position):
(CppStyleTest.test_rfind_in_lines):
(CppStyleTest.test_close_expression):
(CppStyleTest.test_include_what_you_use_no_implementation_files):
(CppStyleTest.test_include_what_you_use):
(CppStyleTest.test_files_belong_to_same_module):
(CppStyleTest.test_cleanse_line):
(CppStyleTest.test_multiline_strings):
(CppStyleTest.test_newline_at_eof.do_test):
(CppStyleTest.test_invalid_utf8.do_test):
(CppStyleTest.test_is_blank_line):
(CppStyleTest.test_allow_blank_line_before_closing_namespace):
(CppStyleTest.test_allow_blank_line_before_if_else_chain):
(CppStyleTest.test_else_on_same_line_as_closing_braces):
(CppStyleTest.test_build_header_guard):
(CppStyleTest.test_legal_copyright):
(CleansedLinesTest.test_init):
(CleansedLinesTest.test_init_empty):
(CleansedLinesTest.test_collapse_strings):
(CheckForFunctionLengthsTest.assert_function_lengths_check):
(PassPtrTest.assert_pass_ptr_check):
(LeakyPatternTest.assert_leaky_pattern_check):
(WebKitStyleTest.test_parameter_names):
(WebKitStyleTest.test_webkit_export_check):
(CppCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
(JSONCheckerTest.assert_error.handle_style_error):
(JSONCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_init):
(PNGCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_init):
(PythonCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):
* Scripts/webkitpy/style/checkers/text_unittest.py:
(TextStyleTestCase.assertNoError):
(TextStyleTestCase.assertError.error_for_test):
(TextStyleTestCase.assertError):
(TextCheckerTest.test_init):
* Scripts/webkitpy/style/checkers/watchlist_unittest.py:
(WatchListTest.test_basic_error_message.handle_style_error):
(WatchListTest):
* Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
(XcodeProjectFileCheckerTest.assert_error):
* Scripts/webkitpy/style/checkers/xml_unittest.py:
(XMLCheckerTest.assert_error.handle_style_error):
(XMLCheckerTest.test_init):
* Scripts/webkitpy/style/error_handlers_unittest.py:
(DefaultStyleErrorHandlerTest._check_initialized):
(DefaultStyleErrorHandlerTest.test_non_reportable_error):
(DefaultStyleErrorHandlerTest.test_max_reports_per_category):
(DefaultStyleErrorHandlerTest.test_line_numbers):
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest._assert_file_reader):
(TextFileReaderTest.test_process_file__does_not_exist):
(TextFileReaderTest.test_count_delete_only_file):
* Scripts/webkitpy/style/filter_unittest.py:
(CategoryFilterTest.test_init):
(CategoryFilterTest.test_init_default_arguments):
(CategoryFilterTest.test_str):
(FilterConfigurationTest.test_init):
(FilterConfigurationTest.test_default_arguments):
* Scripts/webkitpy/style/main_unittest.py:
(ChangeDirectoryTest._assert_result):
* Scripts/webkitpy/style/optparser_unittest.py:
(ArgumentPrinterTest.test_to_flag_string):
(ArgumentParserTest.test_parse_default_arguments):
(ArgumentParserTest.test_parse_explicit_arguments):
(ArgumentParserTest.test_parse_files):
(CommandOptionValuesTest.test_init):
* Scripts/webkitpy/style/patchreader_unittest.py:
(PatchReaderTest._assert_checked):
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.test_additional_system_paths):
(FinderTest.test_to_module):
(FinderTest.check_names):
* Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_individual_names_are_not_run_twice):
(TesterTest.test_integration_tests_are_not_found_by_default):
(TesterTest.test_integration_tests_are_found):
(TesterTest.integration_test_coverage_works):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_run):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(_expect_validate):
* Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
(ExpectedFailuresTest._assert_can_trust):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
(test_patches_with_acceptable_review_flag):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
(IRCCommandTest.test_create_bug):
(IRCCommandTest.test_roll_chromium_deps):
(IRCCommandTest.test_rollout):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
(test_missing_unit_test_results_path):
(test_layout_test_results):
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.process_work_item):
(LoggingDelegate.handle_unexpected_error):
(QueueEngineTest.test_trivial):
(QueueEngineTest.test_unexpected_error):
(QueueEngineTest.test_handled_error):
(QueueEngineTest._test_terminating_queue):
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest.test_find_bugs_in_string):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
(PrintExpectationsTest.run_test):
(PrintBaselinesTest.test_basic):
(PrintBaselinesTest.test_multiple):
(PrintBaselinesTest.test_csv):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest.test_log_directory):
(AbstractPatchQueueTest.test_next_patch):
(test_auto_retry):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_with_results_directory):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_test_internal_with_move_overwritten_baselines_to):
(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineJson.test_move_overwritten):
(TestRebaselineJson.test_no_optimize):
(TestRebaselineJson.test_results_directory):
(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations_noop):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):
* Scripts/webkitpy/tool/commands/roll_unittest.py:
(PostRollCommandsTest.test_prepare_state):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
(AddSvnMimetypeForPngTest.test_run):
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_ensure_bug_url):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(_assert_message_for_revert_output):
* TestResultServer/model/jsonresults_unittest.py:
(JsonResultsTest._test_merge):
(JsonResultsTest._test_get_test_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 14 Nov 2012 19:28:14 +0000 (19:28 +0000)]
Unreviewed GTK gardening.

Adding or updating baselines for changes in r134618.
Adding timeout expectations for
- fast/dom/Window/open-window-min-size.html, added in r134586 and
- inspector-protocol/nmi-webaudio.html, added in r134593.

* platform/gtk/TestExpectations:
* platform/gtk/fast/files/workers/worker-read-blob-sync-expected.txt: Added.
* platform/gtk/fast/media/mq-js-media-except-01-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace (typeof(x) != <"object", "undefined", ...>) with
bfulgham@webkit.org [Wed, 14 Nov 2012 19:26:04 +0000 (19:26 +0000)]
Replace (typeof(x) != <"object", "undefined", ...>) with
!(typeof(x) == <"object",..>). Later is_object, is_<...>  bytecode operation
will be used.

https://bugs.webkit.org/show_bug.cgi?id=98893

Patch by Valery Ignatyev <valery.ignatyev@ispras.ru> on 2012-11-14
Reviewed by Filip Pizlo.

This eliminates expensive  typeof implementation and
allows to use DFG optimizations, which doesn't support 'typeof'.

* bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaselined video LayoutTests for software compositor
enne@google.com [Wed, 14 Nov 2012 19:24:57 +0000 (19:24 +0000)]
[Chromium] Rebaselined video LayoutTests for software compositor
https://bugs.webkit.org/show_bug.cgi?id=101973

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-12
Reviewed by Adrienne Walker.

Rebaselined failing video LayouTests caused by different filtering
result between Skia and Mesa for the software compositor.

* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/self-painting-layers-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134633 268f45cc-cd09-0410-ab3c-d52691b4dbfc