WebKit-https.git
2 years agoREGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
mcatanzaro@igalia.com [Thu, 10 Aug 2017 19:31:53 +0000 (19:31 +0000)]
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Alberto Lopez Perez.

.:

* Source/cmake/FindGeoClue2.cmake:

Source/WebCore:

Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.

* PlatformGTK.cmake:

Source/WebKit:

* PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd ServiceWorkerJob.
beidson@apple.com [Thu, 10 Aug 2017 19:28:26 +0000 (19:28 +0000)]
Add ServiceWorkerJob.
https://bugs.webkit.org/show_bug.cgi?id=175241

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/workers/service/basic-register.html

This patch does a few things:
- Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
- Adds a ServiceWorkerProvider interface for WebKit to implement
- Actually creates a job for service worker registration and "schedules" it,
  though it always immediately errors out the promise.

Actually queuing jobs and executing asynchronously is coming up soon.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* dom/Document.cpp:
(WebCore::Document::sessionID const):
* dom/Document.h:

* workers/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):
* workers/ServiceWorkerContainer.h:

* workers/ServiceWorkerJob.cpp: Added.
(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):
* workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):

* workers/ServiceWorkerJobClient.h: Added.
(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):

* workers/ServiceWorkerProvider.cpp: Added.
(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):
* workers/ServiceWorkerProvider.h: Added.
* workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
* workers/ServiceWorkerRegistrationParameters.cpp: Added.
* workers/ServiceWorkerRegistrationParameters.h: Added.

Source/WebKit:

* CMakeLists.txt:
* WebKit.xcodeproj/project.pbxproj:

* WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.
(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):
* WebProcess/Storage/WebServiceWorkerProvider.h: Added.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.

* http/tests/workers/service/basic-register-expected.txt: Added.
* http/tests/workers/service/basic-register.html: Added.
* http/tests/workers/service/resources/basic-register.js: Added.
* http/tests/workers/service/resources/empty-worker.js: Added.
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
timothy_horton@apple.com [Thu, 10 Aug 2017 19:05:51 +0000 (19:05 +0000)]
Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):

Source/WebCore:

* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState):
* platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

* TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix duplicated code from r220534.
lforschler@apple.com [Thu, 10 Aug 2017 18:57:22 +0000 (18:57 +0000)]
Fix duplicated code from r220534.

Unreviewed cleanup.

* Scripts/bisect-builds:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
jiewen_tan@apple.com [Thu, 10 Aug 2017 18:47:56 +0000 (18:47 +0000)]
[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/28507240>

Reviewed by Alexey Proskuryakov.

Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.

* TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r220463.
commit-queue@webkit.org [Thu, 10 Aug 2017 18:27:01 +0000 (18:27 +0000)]
Unreviewed, rolling out r220463.
https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
https://bugs.webkit.org/show_bug.cgi?id=175340
http://trac.webkit.org/changeset/220463

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWrite a tool to bisect WebKit builds
lforschler@apple.com [Thu, 10 Aug 2017 18:22:01 +0000 (18:22 +0000)]
Write a tool to bisect WebKit builds
https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

* Scripts/bisect-builds: Added.
(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove bisect-builds script.
lforschler@apple.com [Thu, 10 Aug 2017 18:17:07 +0000 (18:17 +0000)]
Remove bisect-builds script.
https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

* Scripts/bisect-builds: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove ENABLE_GAMEPAD_DEPRECATED
mcatanzaro@igalia.com [Thu, 10 Aug 2017 17:04:46 +0000 (17:04 +0000)]
Remove ENABLE_GAMEPAD_DEPRECATED
https://bugs.webkit.org/show_bug.cgi?id=175361

Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/FindGUdev.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* platform/Linux.cmake: Removed.
* platform/gamepad/deprecated/Gamepads.h: Removed.
* platform/gamepad/glib/GamepadsGlib.cpp: Removed.
* platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
* platform/gamepad/linux/GamepadDeviceLinux.h: Removed.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAddressing post-review comments after r219173.
mmaxfield@apple.com [Thu, 10 Aug 2017 16:59:28 +0000 (16:59 +0000)]
Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

* css/CSSFontStyleValue.h:
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved...
ryanhaddad@apple.com [Thu, 10 Aug 2017 16:53:08 +0000 (16:53 +0000)]
Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
https://bugs.webkit.org/show_bug.cgi?id=170698

Unreviewed test gardening.

* TestExpectations: Skip test on debug because it times out on every run.
* platform/ios/TestExpectations: Mark as flaky on Release.
* platform/mac/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
clopez@igalia.com [Thu, 10 Aug 2017 16:33:31 +0000 (16:33 +0000)]
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

* Source/cmake/FindGeoClue2.cmake:

Tools:

* gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTry to fix windows build.
antti@apple.com [Thu, 10 Aug 2017 15:44:39 +0000 (15:44 +0000)]
Try to fix windows build.

* style/StyleUpdate.h:
(WebCore::Style::TextUpdate::TextUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
zandobersek@gmail.com [Thu, 10 Aug 2017 12:25:07 +0000 (12:25 +0000)]
[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

* PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction
for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd Ms2ger as contributor.
commit-queue@webkit.org [Thu, 10 Aug 2017 12:01:56 +0000 (12:01 +0000)]
Add Ms2ger as contributor.
https://bugs.webkit.org/show_bug.cgi?id=175325

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of...
carlosgc@webkit.org [Thu, 10 Aug 2017 11:02:33 +0000 (11:02 +0000)]
[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Update expectations of several tests failing at r220516.
magomez@igalia.com [Thu, 10 Aug 2017 10:44:57 +0000 (10:44 +0000)]
Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoText renderer updates should be done by RenderTreeUpdater
antti@apple.com [Thu, 10 Aug 2017 10:20:53 +0000 (10:20 +0000)]
Text renderer updates should be done by RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

* dom/Document.cpp:
(WebCore::Document::updateTextRenderer):

    Add range argument.

* dom/Document.h:
* dom/Text.cpp:
(WebCore::Text::updateRendererAfterContentChange):

    Remove call to setTextWithOffset and pass the range to updateTextRenderer

* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

    Call setTextWithOffset here.

* style/RenderTreeUpdater.h:
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveComposedTree):
* style/StyleUpdate.cpp:
(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

    Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

* style/StyleUpdate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ build fix for ENABLE_GLES2=ON.
zandobersek@gmail.com [Thu, 10 Aug 2017 08:37:36 +0000 (08:37 +0000)]
Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

* platform/graphics/texmap/TextureMapperGLHeaders.h:
Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
zandobersek@gmail.com [Thu, 10 Aug 2017 07:39:39 +0000 (07:39 +0000)]
[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::BitmapTexturePool):
* platform/graphics/texmap/BitmapTexturePool.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
zandobersek@gmail.com [Thu, 10 Aug 2017 07:20:16 +0000 (07:20 +0000)]
[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
* platform/graphics/texmap/BitmapTextureGL.cpp:
Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):
* platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):
* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::createTexture):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix run-benchmark after r220483.
dewei_zhu@apple.com [Thu, 10 Aug 2017 06:01:56 +0000 (06:01 +0000)]
Fix run-benchmark after r220483.
https://bugs.webkit.org/show_bug.cgi?id=175415
<rdar://problem/33803003>

Reviewed by Ryosuke Niwa.

Update run-benchmark script to adapt new Timeout implementation introduced in r220483.

* Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner._run_one_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Remove support for geoclue1
mcatanzaro@igalia.com [Thu, 10 Aug 2017 05:58:26 +0000 (05:58 +0000)]
[GTK] Remove support for geoclue1
https://bugs.webkit.org/show_bug.cgi?id=164205

Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/FindGeoClue.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

* PlatformGTK.cmake:
* platform/geoclue/GeolocationProviderGeoclue.h:
* platform/geoclue/GeolocationProviderGeoclue1.cpp: Removed.
* platform/geoclue/GeolocationProviderGeoclue2.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDisable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
cdumez@apple.com [Thu, 10 Aug 2017 04:19:34 +0000 (04:19 +0000)]
Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=175401

Reviewed by Brady Eidson.

Source/WebKit:

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBeaconAPIEnabled):
(WKPreferencesGetBeaconAPIEnabled):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* config.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences beaconAPIEnabled]): Deleted.
(-[WebPreferences setBeaconAPIEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):

LayoutTests:

* platform/mac-elcapitan-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
* platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/win/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[PAL] Move spi/cocoa and spi/cg directories into PAL
commit-queue@webkit.org [Thu, 10 Aug 2017 04:13:08 +0000 (04:13 +0000)]
[PAL] Move spi/cocoa and spi/cg directories into PAL
https://bugs.webkit.org/show_bug.cgi?id=175175

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-09
Reviewed by Myles C. Maxfield.

Source/WebCore:

* Modules/applepay/cocoa/PaymentCocoa.mm:
* Modules/applepay/cocoa/PaymentContactCocoa.mm:
* Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
* Modules/applepay/cocoa/PaymentMethodCocoa.mm:
* PlatformAppleWin.cmake:
* WebCore.xcodeproj/project.pbxproj:
* editing/cocoa/EditorCocoa.mm:
* editing/cocoa/HTMLConverter.mm:
* editing/ios/EditorIOS.mm:
* page/cocoa/ResourceUsageThreadCocoa.mm:
* page/mac/TextIndicatorWindow.mm:
* platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
* platform/cocoa/DataDetectorsCoreSoftLink.h:
* platform/cocoa/MIMETypeRegistryCocoa.mm:
* platform/cocoa/NetworkExtensionContentFilter.mm:
* platform/cocoa/ParentalControlsContentFilter.mm:
* platform/cocoa/SleepDisablerCocoa.cpp:
* platform/graphics/Font.cpp:
* platform/graphics/Font.h:
* platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
* platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
* platform/graphics/cg/ColorCG.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageBufferDataCG.cpp:
* platform/graphics/cg/ImageDecoderCG.cpp:
* platform/graphics/cg/NativeImageCG.cpp:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
* platform/graphics/cocoa/FontCascadeCocoa.mm:
* platform/graphics/cocoa/FontCocoa.mm:
* platform/graphics/cocoa/FontDescriptionCocoa.cpp:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
* platform/graphics/cocoa/IOSurface.mm:
* platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
* platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
* platform/graphics/ios/FontAntialiasingStateSaver.h:
* platform/graphics/ios/FontCacheIOS.mm:
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
* platform/graphics/mac/FontCacheMac.mm:
* platform/graphics/mac/GlyphPageMac.cpp:
* platform/graphics/win/FontCacheWin.cpp:
* platform/ios/LegacyTileCache.mm:
* platform/ios/LegacyTileGrid.mm:
* platform/ios/LegacyTileGridTile.mm:
* platform/ios/PlaybackSessionInterfaceAVKit.mm:
* platform/ios/QuickLook.mm:
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
* platform/ios/WebAVPlayerController.h:
* platform/ios/WebAVPlayerController.mm:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
* platform/ios/wak/WKGraphics.mm:
* platform/mac/DragImageMac.mm:
* platform/mac/PlatformScreenMac.mm:
* platform/mac/PlaybackSessionInterfaceMac.mm:
* platform/mac/ThemeMac.mm:
* platform/mac/VideoFullscreenInterfaceMac.mm:
* platform/mac/WebPlaybackControlsManager.h:
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
* platform/network/cocoa/CookieStorageObserver.mm:
* platform/network/cocoa/NetworkLoadMetrics.mm:
* platform/network/mac/AuthenticationMac.mm:
* platform/network/mac/ResourceHandleMac.mm:
* platform/spi/ios/DataDetectorsUISPI.h:
* platform/spi/mac/DataDetectorsSPI.h:
* platform/spi/mac/NSViewSPI.h:
* rendering/RenderThemeCocoa.mm:
* rendering/RenderThemeIOS.mm:
* rendering/RenderThemeMac.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/PlatformAppleWin.cmake:
* pal/spi/cg/CoreGraphicsSPI.h: Renamed from Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h.
(CGFloatMin):
* pal/spi/cg/ImageIOSPI.h: Renamed from Source/WebCore/platform/spi/cg/ImageIOSPI.h.
* pal/spi/cocoa/AVKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/AVKitSPI.h.
(-[AVTouchBarPlaybackControlsControlling NS_ENUM]):
* pal/spi/cocoa/CFNSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h.
* pal/spi/cocoa/CoreTextSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CoreTextSPI.h.
* pal/spi/cocoa/DataDetectorsCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h.
* pal/spi/cocoa/IOPMLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPMLibSPI.h.
* pal/spi/cocoa/IOPSLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h.
* pal/spi/cocoa/IOReturnSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOReturnSPI.h.
* pal/spi/cocoa/IOSurfaceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h.
* pal/spi/cocoa/IOTypesSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOTypesSPI.h.
* pal/spi/cocoa/LinkPresentationSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h.
* pal/spi/cocoa/MachVMSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/MachVMSPI.h.
* pal/spi/cocoa/NEFilterSourceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h.
* pal/spi/cocoa/NSAttributedStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSAttributedStringSPI.h.
* pal/spi/cocoa/NSButtonCellSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSButtonCellSPI.h.
* pal/spi/cocoa/NSCalendarDateSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h.
* pal/spi/cocoa/NSColorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
* pal/spi/cocoa/NSExtensionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSExtensionSPI.h.
* pal/spi/cocoa/NSFileManagerSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h.
* pal/spi/cocoa/NSStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
* pal/spi/cocoa/NSTouchBarSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h.
* pal/spi/cocoa/NSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h.
* pal/spi/cocoa/NSURLDownloadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h.
* pal/spi/cocoa/NSURLFileTypeMappingsSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLFileTypeMappingsSPI.h.
* pal/spi/cocoa/PassKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/PassKitSPI.h.
(NS_ERROR_ENUM):
* pal/spi/cocoa/QuartzCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h.
* pal/spi/cocoa/ServersSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/ServersSPI.h.
* pal/spi/cocoa/WebFilterEvaluatorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h.
* pal/spi/cocoa/pthreadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/pthreadSPI.h.

Source/WebKit:

* NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
* NetworkProcess/Downloads/mac/DownloadMac.mm:
* Platform/cocoa/SharedMemoryCocoa.cpp:
* Platform/mac/LayerHostingContext.mm:
* Shared/Cocoa/DataDetectionResult.mm:
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
* Shared/cf/CookieStorageUtilsCF.mm:
* Shared/ios/InteractionInformationAtPosition.mm:
* Shared/mac/HangDetectionDisablerMac.mm:
* Shared/mac/RemoteLayerBackingStore.mm:
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
* UIProcess/ios/ViewGestureControllerIOS.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/WKPDFPageNumberIndicator.mm:
* UIProcess/ios/WKScrollView.mm:
* UIProcess/mac/RemoteLayerTreeHost.mm:
* UIProcess/mac/ServicesController.mm:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
* UIProcess/mac/ViewGestureControllerMac.mm:
* UIProcess/mac/ViewSnapshotStore.mm:
* UIProcess/mac/WKViewLayoutStrategy.mm:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/ios:

* Misc/WebNSStringExtrasIOS.m:
* WebCoreSupport/WebFixedPositionContent.mm:

Source/WebKitLegacy/mac:

* History/WebHistory.mm:
* Misc/WebDownload.mm:
* Misc/WebKitNSStringExtras.mm:
* Plugins/Hosted/NetscapePluginHostManager.mm:
* Plugins/WebPluginDatabase.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebInspector/WebNodeHighlight.mm:
* WebView/WebHTMLView.mm:
* WebView/WebIndicateLayer.mm:
* WebView/WebView.mm:
* WebView/WebViewData.h:

Tools:

* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
* DumpRenderTree/mac/DumpRenderTree.mm:
* TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:

* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):

Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h

* Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_braces.CF_OPTIONS):
(WebKitStyleTest.test_braces):

Prevent CF_OPTIONS() from being handled as funtion definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoResource Load Statistics: Increase grandfathering time to 3 days
wilander@apple.com [Thu, 10 Aug 2017 03:21:04 +0000 (03:21 +0000)]
Resource Load Statistics: Increase grandfathering time to 3 days
https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

* UIProcess/WebResourceLoadStatisticsStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoInvalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
commit-queue@webkit.org [Thu, 10 Aug 2017 02:11:47 +0000 (02:11 +0000)]
Invalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
https://bugs.webkit.org/show_bug.cgi?id=175399
rdar://problem/33663344

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Eric Carlson.

Invalidate PlaybackSessionManager when WebPage is destructed.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage):
* WebProcess/cocoa/PlaybackSessionManager.h:
* WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::~PlaybackSessionManager):
(WebKit::PlaybackSessionManager::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WTF] Move TextStream into WTF
don.olmstead@sony.com [Thu, 10 Aug 2017 01:15:14 +0000 (01:15 +0000)]
[WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211

Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedTreeIterator.cpp:
* dom/Position.cpp:
* dom/Position.h:
* dom/Range.cpp:
(WebCore::operator<<):
* dom/Range.h:
* dom/ViewportArguments.cpp:
* dom/ViewportArguments.h:
* editing/VisiblePosition.cpp:
* editing/VisiblePosition.h:
* editing/VisibleSelection.cpp:
* editing/VisibleSelection.h:
* html/HTMLVideoElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* page/FrameView.cpp:
* page/ViewportConfiguration.cpp:
* page/ViewportConfiguration.h:
* page/WheelEventDeltaFilter.cpp:
* page/animation/CSSPropertyAnimation.cpp:
* page/scrolling/AsyncScrollingCoordinator.cpp:
* page/scrolling/ScrollingConstraints.cpp:
* page/scrolling/ScrollingConstraints.h:
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/ScrollingStateFixedNode.cpp:
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
* page/scrolling/ScrollingStateFrameScrollingNode.h:
* page/scrolling/ScrollingStateNode.cpp:
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
* page/scrolling/ScrollingStateOverflowScrollingNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.cpp:
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingTree.cpp:
* page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
* page/scrolling/ScrollingTreeNode.cpp:
* page/scrolling/ScrollingTreeNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
* page/scrolling/mac/ScrollingTreeStickyNode.h:
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
* platform/CalculationValue.cpp:
* platform/CalculationValue.h:
* platform/LayoutUnit.cpp:
* platform/LayoutUnit.h:
* platform/Length.cpp:
* platform/Length.h:
* platform/LengthBox.cpp:
* platform/LengthBox.h:
* platform/LengthPoint.cpp:
* platform/LengthPoint.h:
* platform/LengthSize.cpp:
* platform/LengthSize.h:
* platform/LogMacros.h:
* platform/ScrollView.cpp:
* platform/ScrollableArea.cpp:
* platform/animation/TimingFunction.cpp:
* platform/animation/TimingFunction.h:
* platform/graphics/BitmapImage.cpp:
* platform/graphics/BitmapImage.h:
* platform/graphics/Color.cpp:
* platform/graphics/Color.h:
* platform/graphics/CrossfadeGeneratedImage.cpp:
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatPoint3D.cpp:
* platform/graphics/FloatPoint3D.h:
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatRoundedRect.cpp:
* platform/graphics/FloatRoundedRect.h:
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/FontTaggedSettings.cpp:
* platform/graphics/FontTaggedSettings.h:
* platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::dump const):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::dumpAdditionalProperties const):
* platform/graphics/GraphicsTypes.cpp:
* platform/graphics/GraphicsTypes.h:
* platform/graphics/Image.cpp:
* platform/graphics/Image.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.cpp:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.cpp:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.cpp:
* platform/graphics/IntSize.h:
* platform/graphics/LayoutPoint.cpp:
* platform/graphics/LayoutPoint.h:
* platform/graphics/LayoutRect.cpp:
* platform/graphics/LayoutRect.h:
* platform/graphics/LayoutSize.cpp:
* platform/graphics/LayoutSize.h:
* platform/graphics/NamedImageGeneratedImage.cpp:
* platform/graphics/NamedImageGeneratedImage.h:
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCAAnimation.cpp:
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/PlatformCALayer.cpp:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileController.cpp:
* platform/graphics/ca/TileGrid.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
* platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::description const):
* platform/graphics/displaylists/DisplayList.h:
* platform/graphics/displaylists/DisplayListItems.cpp:
* platform/graphics/displaylists/DisplayListItems.h:
* platform/graphics/displaylists/DisplayListRecorder.cpp:
* platform/graphics/displaylists/DisplayListReplayer.cpp:
* platform/graphics/filters/DistantLightSource.cpp:
* platform/graphics/filters/DistantLightSource.h:
* platform/graphics/filters/FEBlend.cpp:
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEConvolveMatrix.cpp:
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEDiffuseLighting.cpp:
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDisplacementMap.cpp:
* platform/graphics/filters/FEDisplacementMap.h:
* platform/graphics/filters/FEDropShadow.cpp:
* platform/graphics/filters/FEDropShadow.h:
* platform/graphics/filters/FEFlood.cpp:
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FEMerge.cpp:
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FEOffset.cpp:
* platform/graphics/filters/FEOffset.h:
* platform/graphics/filters/FESpecularLighting.cpp:
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FETile.cpp:
* platform/graphics/filters/FETile.h:
* platform/graphics/filters/FETurbulence.cpp:
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/FilterEffect.cpp:
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/filters/FilterOperation.cpp:
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/filters/FilterOperations.cpp:
* platform/graphics/filters/FilterOperations.h:
* platform/graphics/filters/LightSource.h:
* platform/graphics/filters/PointLightSource.cpp:
* platform/graphics/filters/PointLightSource.h:
* platform/graphics/filters/SourceAlpha.cpp:
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.cpp:
* platform/graphics/filters/SourceGraphic.h:
* platform/graphics/filters/SpotLightSource.cpp:
* platform/graphics/filters/SpotLightSource.h:
* platform/graphics/transforms/AffineTransform.cpp:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/IdentityTransformOperation.h:
* platform/graphics/transforms/Matrix3DTransformOperation.cpp:
* platform/graphics/transforms/Matrix3DTransformOperation.h:
* platform/graphics/transforms/MatrixTransformOperation.cpp:
* platform/graphics/transforms/MatrixTransformOperation.h:
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
* platform/graphics/transforms/PerspectiveTransformOperation.h:
* platform/graphics/transforms/RotateTransformOperation.cpp:
* platform/graphics/transforms/RotateTransformOperation.h:
* platform/graphics/transforms/ScaleTransformOperation.cpp:
* platform/graphics/transforms/ScaleTransformOperation.h:
* platform/graphics/transforms/SkewTransformOperation.cpp:
* platform/graphics/transforms/SkewTransformOperation.h:
* platform/graphics/transforms/TransformOperation.cpp:
* platform/graphics/transforms/TransformOperation.h:
* platform/graphics/transforms/TransformOperations.cpp:
* platform/graphics/transforms/TransformOperations.h:
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/transforms/TranslateTransformOperation.cpp:
* platform/graphics/transforms/TranslateTransformOperation.h:
* platform/ios/SelectionRect.cpp:
(WebCore::operator<<):
* platform/ios/SelectionRect.h:
* platform/mac/ScrollAnimatorMac.mm:
* platform/text/TextAllInOne.cpp:
* rendering/InlineBox.cpp:
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::outputLineTreeAndMark const):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
* rendering/InlineTextBox.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::outputLineTreeAndMark const):
* rendering/RenderBlockFlow.h:
* rendering/RenderLayer.cpp:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderTreeAsText.cpp:
* rendering/RenderTreeAsText.h:
* rendering/ScrollAlignment.cpp:
* rendering/ScrollAlignment.h:
* rendering/SimpleLineLayoutCoverage.cpp:
* rendering/SimpleLineLayoutFunctions.cpp:
* rendering/SimpleLineLayoutFunctions.h:
* rendering/style/FillLayer.cpp:
* rendering/style/FillLayer.h:
* rendering/style/NinePieceImage.cpp:
* rendering/style/NinePieceImage.h:
* rendering/style/RenderStyleConstants.cpp:
* rendering/style/RenderStyleConstants.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/svg/SVGRenderTreeAsText.h:
(WebCore::operator<<):
* svg/SVGLengthValue.cpp:
* svg/SVGLengthValue.h:
* svg/graphics/SVGImage.cpp:
* svg/graphics/SVGImage.h:
* svg/graphics/filters/SVGFEImage.cpp:
* svg/graphics/filters/SVGFEImage.h:

Source/WebKit:

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
* Shared/VisibleContentRectUpdateInfo.cpp:
* Shared/VisibleContentRectUpdateInfo.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(WebKit::operator<<):
* UIProcess/ios/WebPageProxyIOS.mm:
* WebProcess/WebPage/ios/WebPageIOS.mm:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.
(WTF::TextStream::writeIndent):
* wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.
(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):

Tools:

* TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agofont-fallback-font-family.html is failing on perf bots
mmaxfield@apple.com [Thu, 10 Aug 2017 01:12:07 +0000 (01:12 +0000)]
font-fallback-font-family.html is failing on perf bots
https://bugs.webkit.org/show_bug.cgi?id=174989

Unreviewed.

* Layout/resources/font-fallback-font-family.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoPart 3 of: Rename DatabaseProcess to StorageProcess
aestes@apple.com [Thu, 10 Aug 2017 01:07:09 +0000 (01:07 +0000)]
Part 3 of: Rename DatabaseProcess to StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=175034

Reviewed by Brady Eidson.

Source/WebKit:

We tried renaming com.apple.WebKit.Databases to com.apple.WebKit.Storage in r219986, but
this prevented trunk WebKit from running on iOS 11 devices. This is because launchd keeps a
codesigned cache of XPC services, and refuses to launch services that aren't in the cache.

It's not possibe for us to rebuild the cache with the new service name (only Apple's
production build system can do this), and disabling the cache or opting WebKit's XPC
services out of the cache might have a negative impact on our performance testing.

For now we'll retain the name "com.apple.WebKit.Databases" on iOS 11 devices to work around
this issue. If we find a way to allow the new service to run without impacting performance,
we can revert this change.

We will rename the service to "com.apple.WebKit.Storage" on macOS and iOS Simulator, and in
a follow-up patch we'll use the new service name on post-iOS 11 device builds.

* Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
and iOS Simulator.
* Configurations/StorageService.xcconfig: Changed PRODUCT_NAME to $(WK_STORAGE_SERVICE_PRODUCT_NAME).
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName): Changed to return "com.apple.WebKit.Storage" on macOS and
iOS Simulator platforms.
* WebKit.xcodeproj/project.pbxproj: Updated the "Copy XPC services for engineering builds"
build phase to use WK_STORAGE_SERVICE_PRODUCT_NAME.

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::databaseProcessName): Updated to return
"com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Create JSSet constructor that accepts it's size as parameter
ticaiolima@gmail.com [Thu, 10 Aug 2017 00:42:24 +0000 (00:42 +0000)]
[JSC] Create JSSet constructor that accepts it's size as parameter
https://bugs.webkit.org/show_bug.cgi?id=173297

Reviewed by Saam Barati.

This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
* runtime/HashMapImpl.h:
(JSC::HashMapImpl::HashMapImpl):
* runtime/JSSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r220466, r220477, and r220487.
ryanhaddad@apple.com [Thu, 10 Aug 2017 00:35:58 +0000 (00:35 +0000)]
Unreviewed, rolling out r220466, r220477, and r220487.
https://bugs.webkit.org/show_bug.cgi?id=175411

This change broke existing API tests and follow up fixes did
not resolve all the issues. (Requested by ryanhaddad on
#webkit).

Reverted changesets:

https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220466

"WTF::Function does not allow for reference / non-default
constructible return types"
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220477

https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220487

Patch by Commit Queue <commit-queue@webkit.org> on 2017-08-09

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Remove unused find modules
mcatanzaro@igalia.com [Wed, 9 Aug 2017 23:32:14 +0000 (23:32 +0000)]
[CMake] Remove unused find modules
https://bugs.webkit.org/show_bug.cgi?id=175363

Reviewed by Carlos Alberto Lopez Perez.

* Source/cmake/FindCFLite.cmake: Removed.
* Source/cmake/FindClang.cmake: Removed.
* Source/cmake/FindDBus.cmake: Removed.
* Source/cmake/FindDirectX.cmake: Removed.
* Source/cmake/FindEspeak.cmake: Removed.
* Source/cmake/FindQuickTimeSDK.cmake: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Beacon][NetworkSession] Support CORS-preflighting on redirects
cdumez@apple.com [Wed, 9 Aug 2017 23:23:58 +0000 (23:23 +0000)]
[Beacon][NetworkSession] Support CORS-preflighting on redirects
https://bugs.webkit.org/show_bug.cgi?id=175386
<rdar://problem/33801370>

Reviewed by Youenn Fablet.

Source/WebCore:

Export a couple of WebCore symbols so I can use them in WebKit2.

Tests: http/wpt/beacon/cors/cors-preflight-redirect-failure.html
       http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html
       http/wpt/beacon/cors/cors-preflight-redirect-success.html

* loader/CrossOriginAccessControl.h:
* page/SecurityOrigin.h:

Source/WebKit:

Add support to Beacon for doing CORS-preflighting upon redirect to a different
domain.

* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::securityOrigin const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):
* NetworkProcess/PingLoad.h:

LayoutTests:

Add layout test coverage.

* http/wpt/beacon/cors/cors-preflight-redirect-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-success.html: Added.
* http/wpt/beacon/resources/beacon-preflight.py:
(main):
* http/wpt/beacon/resources/redirect.py: Added.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUse MPAVRoutingController instead of deprecated versions.
commit-queue@webkit.org [Wed, 9 Aug 2017 23:18:13 +0000 (23:18 +0000)]
Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

No new tests because no behavior change. This uses a different platform class to present
an interface.

Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.

* platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

rdar://problem/33301230

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.

* UIProcess/ios/forms/WKAirPlayRoutePicker.h:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html
cdumez@apple.com [Wed, 9 Aug 2017 23:03:10 +0000 (23:03 +0000)]
Unreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html

Temporarily restore previous timeout on this test to address flakiness on the
bots until I can rewrite it.

* http/wpt/beacon/keepalive-after-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoImport beacon/headers/header-content-type.html from upstream WPT
cdumez@apple.com [Wed, 9 Aug 2017 23:01:05 +0000 (23:01 +0000)]
Import beacon/headers/header-content-type.html from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=175395

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

* web-platform-tests/beacon/headers/header-content-type-expected.txt:
* web-platform-tests/beacon/headers/header-content-type.html:

LayoutTests:

Drop local test that has been upstreamed to WPT.

* http/wpt/beacon/headers/header-content-type-same-origin-expected.txt: Removed.
* http/wpt/beacon/headers/header-content-type-same-origin.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed build fix.
msaboff@apple.com [Wed, 9 Aug 2017 22:59:32 +0000 (22:59 +0000)]
Unreviewed build fix.

Added missing files.

* RexBench/Octane2/benchmark.js: Added.
(Octane2RegExpBenchmark):
(Octane2RegExpBenchmark.prototype.setup.):
(Octane2RegExpBenchmark.prototype.setup.Math.random):
(Octane2RegExpBenchmark.prototype.setup):
(Octane2RegExpBenchmark.prototype.runOnce):
(Octane2RegExpBenchmark.prototype.tearDown):
* RexBench/SunSpider/benchmark.js: Added.
(RegexDNABenchmark):
(RegexDNABenchmark.prototype.runOnce):
(RegexDNABenchmark.prototype.validate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark font-display as in development
mmaxfield@apple.com [Wed, 9 Aug 2017 22:42:59 +0000 (22:42 +0000)]
Mark font-display as in development
https://bugs.webkit.org/show_bug.cgi?id=175387

Unreviewed.

* features.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate for https://bugs.webkit.org/show_bug.cgi?id=175244.
weinig@apple.com [Wed, 9 Aug 2017 22:40:53 +0000 (22:40 +0000)]
Update for https://bugs.webkit.org/show_bug.cgi?id=175244.

Remove one addition of null Function test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTest accessibility/presentation-role-iframe.html is a flaky failure
n_wang@apple.com [Wed, 9 Aug 2017 22:36:04 +0000 (22:36 +0000)]
LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

* accessibility/presentation-role-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRex Bench doesn't work from the command line
msaboff@apple.com [Wed, 9 Aug 2017 22:33:27 +0000 (22:33 +0000)]
Rex Bench doesn't work from the command line
https://bugs.webkit.org/show_bug.cgi?id=175349

Reviewed by Saam Barati.

Fixed cli.js to have the same set of benchmarks and .js files as the web
page driver.

Refactored the way benchmarks are run using a new Benchmark base class.  That
class will run the benchmark as well.  Eliminated the various runBenchmark()
functions that were used for individual tests.  This refactoring was threaded
into the web page driver as well.  Changed the iteration counts on many of the
individual benchmarks.  Also changed the inner loop count for the flight
planner test.

Eliminated Octane2/base.js as it isn't needed to run Octane2/RegExp with the
new test harness.  Eliminated other dead code in Octane2/regexp.js.

* RexBench/Basic/benchmark.js:
(BasicBenchmark):
(BasicBenchmark.prototype.runIteration): Deleted.
(runBenchmark): Deleted.
* RexBench/FlightPlanner/benchmark.js:
(FlightPlannerBenchmark):
(FlightPlannerBenchmark.prototype.runOnce):
(this.performance.performance.now.currentTime): Deleted.
(else.this.preciseTime.currentTime): Deleted.
(else.currentTime): Deleted.
(FlightPlannerBenchmark.prototype.runIteration): Deleted.
(FlightPlannerBenchmark.prototype.checkResults): Deleted.
(runBenchmark): Deleted.
* RexBench/Octane2/base.js: Removed.
* RexBench/Octane2/regexp.js:
* RexBench/basic_benchmark.js:
* RexBench/benchmark.js: Added.
(this.performance.performance.now.currentTime):
(else.this.preciseTime.currentTime):
(else.currentTime):
(Benchmark):
(Benchmark.prototype.runIterations):
(Benchmark.prototype.setup):
(Benchmark.prototype.runOnce):
(Benchmark.prototype.validate):
(Benchmark.prototype.tearDown):
* RexBench/cli.js:
* RexBench/flightplan_benchmark.js:
* RexBench/flightplan_unicode_benchmark.js:
* RexBench/octane2_benchmark.js:
* RexBench/stats.js:
(Stats.prototype.toString.return.span.0.span.span):
* RexBench/sunspider_benchmark.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r219334.
commit-queue@webkit.org [Wed, 9 Aug 2017 22:08:35 +0000 (22:08 +0000)]
Unreviewed, rolling out r219334.
https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219334

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAllow nested timeouts in webkitpy
jbedard@apple.com [Wed, 9 Aug 2017 21:58:18 +0000 (21:58 +0000)]
Allow nested timeouts in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=175390
<rdar://problem/33803003>

Reviewed by David Kilzer.

We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
the executive to detect and recover from any issues connecting with devices.

* Scripts/webkitpy/benchmark_runner/utils.py:
(TimeoutError): Deleted.
(timeout): Deleted.
* Scripts/webkitpy/common/timeout_context.py: Added.
(Timeout): A timeout context designed to be nested.
(Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
(Timeout.TimeoutData.__init__):
(Timeout.default_handler): Timeout handler used if none is specified.
(Timeout.current): Access data about the most urgent timeout.
(Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
(Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
(Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
urgent timeout data.
(Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
most urgent timeout data, if such data exists.
* Scripts/webkitpy/common/timeout_context_unittest.py: Added.
(TimeoutContextTests):
(TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
(TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
(TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
(TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
over a less urgent outer timeout.
(TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
over a less urgent inner timeout.
(TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
(TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
(TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
(TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
(TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
* Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess._start): Use Timeout class.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
(SimulatedDevice.launch_app): Ditto.
(SimulatedDevice.launch_app._install_timeout): Deleted.
* Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted):Use Timeout class.
(Simulator.wait_until_device_is_in_state): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEarly error on ANY operator before new.target
caitp@igalia.com [Wed, 9 Aug 2017 21:34:20 +0000 (21:34 +0000)]
Early error on ANY operator before new.target
https://bugs.webkit.org/show_bug.cgi?id=157970

Reviewed by Saam Barati.

Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.

The following become legal in JSC:

```
!new.target
~new.target
typeof new.target
delete new.target
void new.target
```

All of which are legal in v8 and SpiderMonkey in strict and sloppy mode

JSTests:

* stress/new-target-syntax-errors.js:
* stress/new-target.js:

Source/JavaScriptCore:

* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseUnaryExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Repaint from Layout Removal] Move layer repaint rects into a map
hyatt@apple.com [Wed, 9 Aug 2017 21:03:03 +0000 (21:03 +0000)]
[Repaint from Layout Removal] Move layer repaint rects into a map
https://bugs.webkit.org/show_bug.cgi?id=175393

Reviewed by Zalan Bujtas.

Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.

Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):
* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):
* rendering/RenderLayerModelObject.h:
(WebCore::RepaintLayoutRects::RepaintLayoutRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate reviewer
weinig@apple.com [Wed, 9 Aug 2017 21:02:23 +0000 (21:02 +0000)]
Update reviewer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWTF::Function does not allow for reference / non-default constructible return types
commit-queue@webkit.org [Wed, 9 Aug 2017 20:57:51 +0000 (20:57 +0000)]
WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <sam@webkit.org> on 2017-08-09
Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

* UIProcess/WebResourceLoadStatisticsStore.h:
Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

* wtf/Function.h:
(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoImport CSS-UI-3 Web Platform Tests
dbates@webkit.org [Wed, 9 Aug 2017 20:28:01 +0000 (20:28 +0000)]
Import CSS-UI-3 Web Platform Tests
https://bugs.webkit.org/show_bug.cgi?id=175294

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* resources/resource-files.json:
* web-platform-tests/css/css-ui-3/OWNERS: Added.
* web-platform-tests/css/css-ui-3/box-sizing-001-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-001.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-003-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-003.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-005-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-005.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-007-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-007.html: Added.
[truncated]

LayoutTests:

Mark tests that we currently failure.

* TestExpectations:
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTeach ScriptExecutionContexts about their SessionID.
beidson@apple.com [Wed, 9 Aug 2017 20:25:57 +0000 (20:25 +0000)]
Teach ScriptExecutionContexts about their SessionID.
https://bugs.webkit.org/show_bug.cgi?id=175391

Reviewed by Andy Estes.

No new tests (No current change in behavior).

Turns out that Workers need to know their SessionID for future feature development.
So let's teach it to them.

* dom/ScriptExecutionContext.h: Expose a pure virtual SessionID accessor.

* dom/Document.cpp:
(WebCore::Document::sessionID const):
* dom/Document.h:

* page/SessionID.cpp:
(WebCore::SessionID::isolatedCopy const):
* page/SessionID.h:

* workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
* workers/DedicatedWorkerGlobalScope.h:

* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
* workers/DedicatedWorkerThread.h:

* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):

* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
* workers/WorkerGlobalScope.h:

* workers/WorkerGlobalScopeProxy.h:

* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* workers/WorkerMessagingProxy.h:

* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
* workers/WorkerThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked http/tests/media/video-buffered-range-contains-currentTime.html as flaky on...
jlewis3@apple.com [Wed, 9 Aug 2017 20:08:01 +0000 (20:08 +0000)]
Marked http/tests/media/video-buffered-range-contains-currentTime.html as flaky on High Sierra
<rdar://problem/33555759>

Unreviewed test gardening.

* platform/mac-highsierra-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
wenson_hsieh@apple.com [Wed, 9 Aug 2017 19:15:37 +0000 (19:15 +0000)]
[iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
https://bugs.webkit.org/show_bug.cgi?id=175392
<rdar://problem/33783207>

Reviewed by Tim Horton and Megan Gardner.

Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No change in behavior.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoOld subtitle track is not deleted on 'src' attribute change event
commit-queue@webkit.org [Wed, 9 Aug 2017 19:13:51 +0000 (19:13 +0000)]
Old subtitle track is not deleted on 'src' attribute change event
https://bugs.webkit.org/show_bug.cgi?id=175031

Patch by Kirill Ovchinnikov <kirill.ovchinnikov@lge.com> on 2017-08-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::loadTimerFired):
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::clearTextDisplayContainer):
* html/shadow/MediaControls.h:

LayoutTests:

* media/track/text-track-src-change-expected.txt: Added.
* media/track/text-track-src-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
commit-queue@webkit.org [Wed, 9 Aug 2017 18:31:24 +0000 (18:31 +0000)]
Make JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
https://bugs.webkit.org/show_bug.cgi?id=175358

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-09
Reviewed by Mark Lam.

* jit/JITOperations.cpp:
* runtime/JSObjectInlines.h:
(JSC::JSObject::putInlineForJSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoServiceWorker experimental feature should not be on by default (definitely not ready).
beidson@apple.com [Wed, 9 Aug 2017 18:05:24 +0000 (18:05 +0000)]
ServiceWorker experimental feature should not be on by default (definitely not ready).
https://bugs.webkit.org/show_bug.cgi?id=175389

Rubberstamped by Andy Estes.

* Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate for https://bugs.webkit.org/show_bug.cgi?id=175244.
weinig@apple.com [Wed, 9 Aug 2017 18:03:11 +0000 (18:03 +0000)]
Update for https://bugs.webkit.org/show_bug.cgi?id=175244.

* TestWebKitAPI/Tests/WTF/Function.cpp:
Remove tests of null Functions, as they are no longer supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r220457.
ryanhaddad@apple.com [Wed, 9 Aug 2017 17:58:12 +0000 (17:58 +0000)]
Unreviewed, rolling out r220457.

This change introduced API test failures.

Reverted changeset:

"WTF::Function does not allow for reference / non-default
constructible return types"
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220457

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WinCairo] Fix build after rev 220399
don.olmstead@sony.com [Wed, 9 Aug 2017 17:53:09 +0000 (17:53 +0000)]
[WinCairo] Fix build after rev 220399
https://bugs.webkit.org/show_bug.cgi?id=175360

Reviewed by Žan Doberšek.

No new tests. No change in behavior.

* platform/graphics/texmap/TextureMapperGLHeaders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
n_wang@apple.com [Wed, 9 Aug 2017 17:52:36 +0000 (17:52 +0000)]
AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

When adding a psuedo element child to a RenderBlockFlow element, there might be a chance where
the element has already been layed out but we are still holding onto its stale children. Fixed it
by notifying AX correctly when inserting/removing children during layout.

Test: accessibility/add-children-pseudo-element.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):

LayoutTests:

* accessibility/add-children-pseudo-element-expected.txt: Added.
* accessibility/add-children-pseudo-element.html: Added.
* accessibility/resources/svg-circle.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Styles: Add pre-populated data to spreadsheet-style view
nvasilyev@apple.com [Wed, 9 Aug 2017 17:46:27 +0000 (17:46 +0000)]
Web Inspector: Styles: Add pre-populated data to spreadsheet-style view
https://bugs.webkit.org/show_bug.cgi?id=174838
<rdar://problem/33523220>

Reviewed by Matt Baker.

This patch adds static content to the experimental RulesStyleSpreadsheetDetailsPanel.
The static content will be replaced with actual data in the follow up patches.

* UserInterface/Main.html:
* UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css: Added.
(.style-spreadsheet .style-rule):
(.style-spreadsheet .selector-line):
(.style-spreadsheet .selector):
(.style-spreadsheet :matches(.selector .matched, .selector:focus)):
(.style-spreadsheet .name):
(.style-spreadsheet .value):
(.style-spreadsheet :matches(.selector, .name, .value)):
(.style-spreadsheet :matches(.selector, .name, .value):focus):
(.style-spreadsheet .selector-inline):
(.style-spreadsheet .property):
(.style-spreadsheet .property-disabled,):
(.style-spreadsheet .property-disabled :matches(.name, .value)):
(.style-spreadsheet .styles-source):
(.style-spreadsheet :matches(a, .node-link)):
(.style-spreadsheet :matches(a, .node-link):hover):
(.style-spreadsheet .inherited):
(.style-spreadsheet .declarations):
(.style-spreadsheet input[type="checkbox"]):
(.style-spreadsheet input[type="checkbox"]:not(:checked)):
(.style-spreadsheet .declarations:hover input[type="checkbox"]):
* UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer][MSE] Add missing lock around getStreamByTrackId
commit-queue@webkit.org [Wed, 9 Aug 2017 17:23:16 +0000 (17:23 +0000)]
[GStreamer][MSE] Add missing lock around getStreamByTrackId
https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

* platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWPE-focused test gardening.
commit-queue@webkit.org [Wed, 9 Aug 2017 16:41:56 +0000 (16:41 +0000)]
WPE-focused test gardening.
https://bugs.webkit.org/show_bug.cgi?id=175385

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09

* platform/wpe/TestExpectations: Marked failing tests.
* platform/wpe/fast/events/touch/basic-single-touch-events-expected.txt: Added platform-specific expectation.
* platform/wpe/js/date-timeClip-large-values-expected.txt: Removed (the platform-neutral expectation is fine).
* platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Updated for Cache enabling.
* transitions/clip-path-path-transitions-expected.txt: Updated for test change in r219243.
* transitions/resources/transition-test-helpers.js:
(parseClipPath): Updated to support the quotes in clip-path-path-transitions.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (r219013): OAuth flows are broken when redirecting back to application...
dbates@webkit.org [Wed, 9 Aug 2017 16:30:41 +0000 (16:30 +0000)]
REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
https://bugs.webkit.org/show_bug.cgi?id=175247
<rdar://problem/33679804>

Reviewed by Brady Eidson.

Source/WebCore:

Add SPI so that Safari can differentiate between a form submission and a redirected form submission
and have PolicyCheck notify the frame loader client if the navigation was in response to receiving a
redirect response. This is the WebKit portion to fix an issue when a native app makes use of an OAuth
OAuth flow that bounces to Safari for user login and then bounce back to the app. Microsoft Graph's
OAuth flow is one example.

Safari was differentiating between a form submission and a redirected form submission based on the
nullity of WKNavigationAction.sourceFrame because in both cases the navigation type was WKNavigationTypeFormSubmitted.
The navigation type is the same for both navigations because WebKit always used the navigation
action from the original request for the redirect request when the original request redirected.
Prior to r219013, WKNavigationAction.sourceFrame would be nil for a form submission that redirects.
Following r219013, WKNavigationAction.sourceFrame is non-nil unless the navigation was initiated by
API. In particular, WKNavigationAction.sourceFrame is non-nil for the redirect navigation corresponding
to a form submission that redirects.

* loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* loader/FrameLoaderClient.h:
Have dispatchDecidePolicyForNavigationAction() take a boolean as to whether the navigation was in
response to receiving a redirect response.
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy): Notify the frame loader client whether the navigation
is in response to receiving a redirect response.

Source/WebKit:

Add SPI WKNavigationAction._isRedirect to query whether the navigation was in response to receiving
a redirect response. The majority of the WebKit change is plumbing this knowledge through to connect
it with the SPI.

* Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):
Encode and decode the boolean NavigationActionData::isRedirect.
* Shared/NavigationActionData.h:
* UIProcess/API/APINavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _isRedirect]): Added.
* UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Set NavigationActionData::isRedirect
depending on whether the navigation is in response to receiving a redirect response.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add tests for redirects.

* TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
(TEST):
* TestWebKitAPI/cocoa/TestProtocol.mm:
(createRedirectURL):
(-[TestProtocol startLoading]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
ryanhaddad@apple.com [Wed, 9 Aug 2017 16:02:10 +0000 (16:02 +0000)]
Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
https://bugs.webkit.org/show_bug.cgi?id=175255

Unreviewed test gardening.

* stress/regress-169783.js:
* wasm/stress/oom.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWTF::Function does not allow for reference / non-default constructible return types
commit-queue@webkit.org [Wed, 9 Aug 2017 15:59:01 +0000 (15:59 +0000)]
WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <sam@webkit.org> on 2017-08-09
Reviewed by Chris Dumez.

Source/JavaScriptCore:

* runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

* UIProcess/WebResourceLoadStatisticsStore.h:
Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

* wtf/Function.h:
(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[QuickLook] Use case-insensitive comparison of preview MIME types
aestes@apple.com [Wed, 9 Aug 2017 15:52:19 +0000 (15:52 +0000)]
[QuickLook] Use case-insensitive comparison of preview MIME types
https://bugs.webkit.org/show_bug.cgi?id=175350
<rdar://problem/33761159>

Reviewed by Brady Eidson.

Source/WebCore:

MIME types are case-insensitive, but PreviewLoader was using a case-sensitive comparison to
determine if a MIME type was supported by QLPreviewConverter. As a result we would fail to
preview Excel macro-enabled workbooks, since CFNetwork would sniff a MIME type of
"application/vnd.ms-excel.sheet.macroEnabled.12" but QuickLook contained
"application/vnd.ms-excel.sheet.macroenabled.12" in its set of supported MIME type strings.

Fix this by copying the QuickLook supported MIME type set into a HashSet using
ASCIICaseInsensitiveHash and using that HashSet for MIME type checks.

Test: quicklook/excel-macro-enabled.html

* loader/ios/PreviewLoader.mm:
(WebCore::PreviewLoader::shouldCreateForMIMEType):

LayoutTests:

* platform/ios-11/quicklook/excel-macro-enabled-expected.txt: Added.
* quicklook/excel-macro-enabled-expected.txt: Added.
* quicklook/excel-macro-enabled.html: Added.
* quicklook/resources/excel-macro-enabled.xlsm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed WPE gardening.
zandobersek@gmail.com [Wed, 9 Aug 2017 13:25:49 +0000 (13:25 +0000)]
Unreviewed WPE gardening.

* platform/wpe/TestExpectations: Stop skipping the whole fast/
directory and then unskipping specific subdirectories since
that overrides any expectations coming from the generic WK2
TestExpectations file. Specific subdirectories that we haven't
yet generated results for are now skipped instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove unnecessary copies of PlatformMediaSessionManager::m_sessions
commit-queue@webkit.org [Wed, 9 Aug 2017 13:06:11 +0000 (13:06 +0000)]
Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoReinstate active flag for iterators
cdumez@apple.com [Wed, 9 Aug 2017 13:04:39 +0000 (13:04 +0000)]
Reinstate active flag for iterators
https://bugs.webkit.org/show_bug.cgi?id=175312

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync WPT tests from upstream to gain test coverage.

* web-platform-tests/dom/traversal/NodeIterator-expected.txt:
* web-platform-tests/dom/traversal/NodeIterator.html:
* web-platform-tests/dom/traversal/TreeWalker-expected.txt:
* web-platform-tests/dom/traversal/TreeWalker.html:

Source/WebCore:

NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:
- https://github.com/whatwg/dom/pull/359

This patch aligns our behavior with the latest specification.

No new tests, updated existing tests.

* dom/NodeIterator.cpp:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).

* dom/Traversal.cpp:
(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):
* dom/Traversal.h:
* dom/TreeWalker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] [WPE] Update expectations for global-constructors-attributes.html.
commit-queue@webkit.org [Wed, 9 Aug 2017 09:22:21 +0000 (09:22 +0000)]
[GTK] [WPE] Update expectations for global-constructors-attributes.html.
https://bugs.webkit.org/show_bug.cgi?id=175373

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09

* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION: 2 test262/test/language/statements/async-function failures
gskachkov@gmail.com [Wed, 9 Aug 2017 09:17:44 +0000 (09:17 +0000)]
REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

* stress/async-await-syntax.js:
* stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRenderQuote should not mutate render tree
antti@apple.com [Wed, 9 Aug 2017 07:36:45 +0000 (07:36 +0000)]
RenderQuote should not mutate render tree
https://bugs.webkit.org/show_bug.cgi?id=175328

Reviewed by Zalan Bujtas.

RenderQuote text renderers are currently created and deleted in a quirky fashion using a linked list.
This patch moves to a simpler model that guarantees the mutations are always done in controlled fashion
during render tree update.

* dom/Document.cpp:
(WebCore::Document::updateTextRenderer):

    Move text renderer updating to Document so we can set the inRenderTreeUpdate bit for it too.

* dom/Document.h:
* dom/Text.cpp:
(WebCore::Text::updateRendererAfterContentChange):
* rendering/RenderDescendantIterator.h:
(WebCore::RenderDescendantIteratorAdapter<T>::at):
(WebCore::RenderDescendantConstIteratorAdapter<T>::at const):

    Add at() function for starting iteration from a specified renderer.

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

    Register and unregister quotes to RenderView.
    Don't do any mutations.

(WebCore::RenderQuote::styleDidChange):

    Invalidate the text renderer but don't mutate it.

(WebCore::RenderQuote::updateTextRenderer):
(WebCore::RenderQuote::computeText const):
(WebCore::RenderQuote::updateRenderers):

    Compute depth of all render quotes and update the text renderer as needed.

(WebCore::RenderQuote::willBeDestroyed): Deleted.
(WebCore::RenderQuote::attachQuote): Deleted.
(WebCore::RenderQuote::detachQuote): Deleted.
(WebCore::RenderQuote::updateDepth): Deleted.

    Get rid of the linked list.

* rendering/RenderQuote.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::registerQuote):
(WebCore::RenderView::unregisterQuote):

    Maintain a render tree order ListHashSet of RenderQuotes.

(WebCore::RenderView::updateSpecialRenderers):

    Add a function for making additional render tree mutations at the end of a render tree update.
    Currently this just invokes RenderQuote::updateRenderers.

* rendering/RenderView.h:
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):

    Call RenderView::updateSpecialRenderers after committing all other changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Enable SUBTLE_CRYPTO in release builds
zandobersek@gmail.com [Wed, 9 Aug 2017 07:16:56 +0000 (07:16 +0000)]
[WPE] Enable SUBTLE_CRYPTO in release builds
https://bugs.webkit.org/show_bug.cgi?id=175371

Reviewed by Carlos Garcia Campos.

* Source/cmake/OptionsWPE.cmake:
Use ON as the default port value for ENABLE_SUBTLE_CRYPTO in WPE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Enable SUBTLE_CRYPTO in GTK+ releases
carlosgc@webkit.org [Wed, 9 Aug 2017 07:13:05 +0000 (07:13 +0000)]
[GTK] Enable SUBTLE_CRYPTO in GTK+ releases
https://bugs.webkit.org/show_bug.cgi?id=172758

Reviewed by Žan Doberšek.

Add ENABLE_WEB_CRYPTO public option and make ENABLE_SUBTLE_CRYPTO depend on it.

* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Soup] Incorrect conversion in msToSoupDate()
zandobersek@gmail.com [Wed, 9 Aug 2017 07:00:34 +0000 (07:00 +0000)]
[Soup] Incorrect conversion in msToSoupDate()
https://bugs.webkit.org/show_bug.cgi?id=175320

Reviewed by Carlos Garcia Campos.

Original patch by VaL Doroshchuk.

* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::msToSoupDate): monthFromDayInYear() returns a value in the [0,11] range,
while soup_date_new() expects a month value in the [1,12] range. The return value
must be thus incremented by one to match that expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r220393.
wenson_hsieh@apple.com [Wed, 9 Aug 2017 05:36:57 +0000 (05:36 +0000)]
Unreviewed, rolling out r220393.

This patch regresses the performance of WebPage::editorState.

Reverted changeset:

"[iOS WK2] WKWebView schedules nonstop layout after pressing
cmb+b,i,u inside a contenteditable div"
https://bugs.webkit.org/show_bug.cgi?id=175116
http://trac.webkit.org/changeset/220393

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Beacon] Add support for CORS-preflighting for WK2 / NETWORK_SESSION
cdumez@apple.com [Wed, 9 Aug 2017 05:15:47 +0000 (05:15 +0000)]
[Beacon] Add support for CORS-preflighting for WK2 / NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=175264
<rdar://problem/33547793>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass additional information when creating a PingHandle so that the PingLoad
can deal with CORS-preflighting on Network process side.

Tests: http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html
       http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html
       http/wpt/beacon/cors/cors-preflight-blob-failure.html
       http/wpt/beacon/cors/cors-preflight-blob-success.html
       http/wpt/beacon/cors/cors-preflight-cookie.html

* WebCore.xcodeproj/project.pbxproj:
* loader/CrossOriginAccessControl.cpp:
(WebCore::validatePreflightResponse):
* loader/CrossOriginAccessControl.h:
* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):
* loader/CrossOriginPreflightResultCache.h:
* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* page/SecurityOrigin.h:

Source/WebKit:

Implement CORS-preflighting for beacons with a payload that has a non
safelisted MIME type, as per:
- https://w3c.github.io/beacon/#privacy
- https://www.w3.org/TR/beacon/#sec-processing-model

CORS-preflighting is completely handled on Network Process side because
a beacon request can outlive its page and therefore its WebContent
process. This requires us to pass a little more information to the
Network process, in particular the source origin and the corsMode.

The current implementation does not currently deal with CORS preflights
needed upon a redirect. This will be added in a follow-up.

* CMakeLists.txt:
* NetworkProcess/NetworkCORSPreflightChecker.cpp: Added.
(WebKit::NetworkCORSPreflightChecker::NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::~NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::startPreflight):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession):
(WebKit::NetworkCORSPreflightChecker::didReceiveData):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::didSendData):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):
* NetworkProcess/NetworkCORSPreflightChecker.h: Added.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp: Added.
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::startNetworkLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didReceiveData):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::didSendData):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):
* NetworkProcess/PingLoad.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

createPingHandle() now takes new parameters but there is currently no behavior
change on WebKit1.

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Added.
* http/wpt/beacon/cors/cors-preflight-blob-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-blob-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-blob-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-blob-success.html: Added.
* http/wpt/beacon/cors/cors-preflight-cookie-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-cookie.html: Added.
* http/wpt/beacon/resources/beacon-preflight.py: Added.
(respondToCORSPreflight):
(main):
* http/wpt/beacon/resources/set-cookie.py: Added.
(main):
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoICs should do caging
fpizlo@apple.com [Wed, 9 Aug 2017 03:48:44 +0000 (03:48 +0000)]
ICs should do caging
https://bugs.webkit.org/show_bug.cgi?id=175295

Reviewed by Saam Barati.

Adds the appropriate cage() calls in our inline caches.

* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
* bytecode/InlineAccess.cpp:
(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAddress review feedback from https://bugs.webkit.org/show_bug.cgi?id=175246.
weinig@apple.com [Wed, 9 Aug 2017 03:24:31 +0000 (03:24 +0000)]
Address review feedback from https://bugs.webkit.org/show_bug.cgi?id=175246.

* bindings/js/DOMPromiseProxy.h:
* css/FontFaceSet.cpp:
* css/FontFaceSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Canvas: support editing WebGL shaders
drousso@apple.com [Wed, 9 Aug 2017 01:55:53 +0000 (01:55 +0000)]
Web Inspector: Canvas: support editing WebGL shaders
https://bugs.webkit.org/show_bug.cgi?id=124211
<rdar://problem/15448958>

Reviewed by Matt Baker.

Source/JavaScriptCore:

* inspector/protocol/Canvas.json:
Add `updateShader` command that will change the given shader's source to the provided string,
recompile, and relink it to its associated program.
Drive-by: add description to `requestShaderSource` command.
Source/WebCore:

Test: inspector/canvas/updateShader.html

* inspector/InspectorCanvasAgent.h:
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::updateShader):

* html/canvas/WebGLRenderingContextBase.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::linkProgramWithoutInvalidatingAttribLocations):
Normally, when a program is linked, it invalidates any WebGLUniformLocation associated with
the program by incrementing its `linkCount`. In order to allow live editing of shaders, we
need to be able to compile and link a shader without invalidating these locations. This
patch moves the shader linking logic to its own function that is called by `linkProgram` so
that InspectorCanvasAgent can compile and link without invalidation.

Source/WebInspectorUI:

* UserInterface/Models/ShaderProgram.js:
(WI.ShaderProgram.prototype.updateVertexShader):
(WI.ShaderProgram.prototype.updateFragmentShader):
(WI.ShaderProgram.prototype._updateShader):

* UserInterface/Views/ShaderProgramContentView.js:
(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype._contentDidChange):

LayoutTests:

* inspector/canvas/updateShader-expected.txt: Added.
* inspector/canvas/updateShader.html: Added.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove old and unused pointIsInAssistedNode definition
megan_gardner@apple.com [Wed, 9 Aug 2017 01:39:37 +0000 (01:39 +0000)]
Remove old and unused pointIsInAssistedNode definition
https://bugs.webkit.org/show_bug.cgi?id=175335

Stage removal here to allow removal from UIKit.
Replaced by textInteractionGesture:shouldBeginAtPoint:

Reviewed by Tim Horton.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView pointIsInAssistedNode:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCreated Individual EWS Pages
commit-queue@webkit.org [Wed, 9 Aug 2017 01:24:25 +0000 (01:24 +0000)]
Created Individual EWS Pages
https://bugs.webkit.org/show_bug.cgi?id=174477

Patch by obinna obike <oobike@apple.com> on 2017-08-08
Reviewed by Aakash Jain.

Created individual pages for each EWS. Changed the link within each status bubble
to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.

* QueueStatusServer/handlers/patch.py:
(Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
* QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Updated url for specific EWS.
* QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
* QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
all ews queues.
* QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
takes you directly to the individual ews page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebIDL] Add support for Promise<> attributes
weinig@apple.com [Wed, 9 Aug 2017 01:01:44 +0000 (01:01 +0000)]
[WebIDL] Add support for Promise<> attributes
https://bugs.webkit.org/show_bug.cgi?id=175246

Reviewed by Yusuke Suzuki.

Introduces and adopts DOMPromiseProxy, a new class for binding promises in a more
straightforward and safe (from a wrapper world perspective) way.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSFontFaceCustom.cpp: Removed.
* bindings/js/JSFontFaceSetCustom.cpp: Removed.
* bindings/js/JSMediaKeySessionCustom.cpp: Removed.
* bindings/js/JSServiceWorkerContainerCustom.cpp: Removed.
* bindings/js/JSWebGPUCommandBufferCustom.cpp: Removed.

    Remove custom bindings only needed for promise attributes. Add DOMPromiseProxy.h

* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::sessionClosed):
(WebCore::MediaKeySession::registerClosedPromise): Deleted.
* Modules/encryptedmedia/MediaKeySession.h:
* Modules/encryptedmedia/MediaKeySession.idl:

    Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

* bindings/IDLTypes.h:

    Add StorageType type alias to allow specifying a specific form for storage. This allows
    use to use Ref<> for interfaces in DOMPromiseProxy.

(WebCore::IDLWrapper::convertToParameterType):

    Also add convertToParameterType, an annoying hack to workaround the fact WTF::Function
    can't return references / no

* bindings/js/DOMPromiseProxy.h: Added.
(WebCore::DOMPromiseProxy<IDLType>):

    DOMPromiseProxy is a new class (set of classes) to represent promises that works with the
    standard toJS<> / JSDOMConvert infrastructure used by the bindings generator. From the
    implementation perspective, it is similar to DOMPromiseDeferred, but instead of receiving
    one as a parameter, you can initialize it directly in your constructor and start using it.

    From the bindings perspective, a DOMPromiseProxy can be converted into a JS Promise by calling
    its promise function, which will either create a new promise, or return a cached one.

    To make this work, DOMPromiseProxy maintains a Vector of DeferredPromises that hold onto those
    actualized promises. The reason it has a Vector, is that we need one DeferredPromises per
    DOMWrapperWorld, just like we need one wrapper for an interface per DOMWrapperWorld in the
    wrapper cache. In most cases, only the normal world will be in play, so the Vector has an inline
    capacity of one.

    In addition, DOMPromiseProxy maintains a Variant of either an Exception or the result value type.
    This allows the DOMPromiseProxy to be resolved or rejected at anytime. Then, when the bindings
    request the promise, the stored result / exception can be resolved / rejected into the promise.

(WebCore::DOMPromiseProxy<IDLVoid>):

    For void promises, we need slightly different semantics (resolve takes no parameters, Value is
    a bit indicating resolved state), so it is specialized.

(WebCore::DOMPromiseProxyWithResolveCallback<IDLType>):

    In addition to the void specialization, we have DOMPromiseProxyWithResolveCallback. Instead of
    storing the value of the resolution directly, this specialization allows the owner to specify
    callback to be called when the resolved value is needed. This is needed to avoid reference
    cycles when the resolved value is the owner such as is the case with FontFace and FontFaceSet.

* bindings/js/JSDOMConvertPromise.h:
(WebCore::JSConverter<IDLPromise<T>>::convert):
Add converter that calls through to the DOMPromiseProxy function promise.

* bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::reject):
* bindings/js/JSDOMPromiseDeferred.h:
(WebCore::DeferredPromise::create):
(WebCore::DeferredPromise::DeferredPromise):

    Add a new create function for DeferredPromise that creates the JSPromiseDeferred for you.
    Also adds a mode to DeferredPromise to allow keeping the promise after resolution. Maintain
    the old behavior as the default.

    Change reject to take an Exception as sink rather than an r-value, to allow DOMPromiseProxy
    to copy a Exception into multiple DeferredPromises. For callers already moving into reject,
    this should be no change.

* bindings/scripts/CodeGeneratorJS.pm:
(AddToIncludesForIDLType):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValueDOMConvertNeedsState):
(NativeToJSValueDOMConvertNeedsGlobalObject):

    Add support DOMPromiseProxy. For now, this means a new extended attribute, [PromiseProxy],
    but once I convert all the existing promises over to using DOMPromiseProxy, it will be removed.

    Also specify the right #includes for promises and necessary parameters for conversion.

* bindings/scripts/IDLAttributes.json:

    Add [PromiseProxy], a temporary extended attribute for using DOMPromiseProxy.

* css/FontFace.cpp:
* css/FontFace.h:
* css/FontFace.idl:
* css/FontFaceSet.cpp:
* css/FontFaceSet.h:
* css/FontFaceSet.idl:

    Replace custom promise code using the registerPromise idiom with DOMPromiseProxyWithResolveCallback.
    The callback is necessary for these two classes since the value the resolve is themselves, and using
    a normal resolve would create a cycle.

* html/canvas/WebGPUCommandBuffer.cpp:
* html/canvas/WebGPUCommandBuffer.h:
* html/canvas/WebGPUCommandBuffer.idl:
* platform/graphics/cocoa/GPUCommandBufferMetal.mm:
* platform/graphics/gpu/GPUCommandBuffer.cpp:
* platform/graphics/gpu/GPUCommandBuffer.h:

    Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

* page/NavigatorBase.cpp:
(WebCore::NavigatorBase::NavigatorBase):
* page/NavigatorBase.h:

    Forward declare ServiceWorkerContainer and add an explicit constructor to allow
    removing #include of ServiceWorkerContainer.h in the header, avoiding an #include cycle.

* workers/ServiceWorkerContainer.cpp:
* workers/ServiceWorkerContainer.h:
* workers/ServiceWorkerContainer.idl:

    Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
* bindings/scripts/test/TestObj.idl:

    Add / update tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake JSC_validateExceptionChecks=1 succeed on JSTests/slowMicrobenchmarks/spread...
commit-queue@webkit.org [Wed, 9 Aug 2017 00:26:04 +0000 (00:26 +0000)]
Make JSC_validateExceptionChecks=1 succeed on JSTests/slowMicrobenchmarks/spread-small-array.js.
https://bugs.webkit.org/show_bug.cgi?id=175347

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-08
Reviewed by Saam Barati.

This is done by making finishCreation explicitely check for exceptions after setConstantRegister and setConstantIdentifiersSetRegisters.
I chose to have this check replace the boolean returned previously by these functions for readability. The performance impact should be
negligible considering how much more finishCreation does.
This fix then caused another issue to appear as it was now clear that finishCreation can throw. And since it is called by ProgramCodeBlock::create(),
FunctionCodeBlock::create() and friends, that are in turn called by ScriptExecutable::newCodeBlockFor, this last function also required a few tweaks.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
(JSC::CodeBlock::setConstantRegisters):
* bytecode/CodeBlock.h:
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSeparate jsc stress test script writer from run-jsc-stress-tests
commit-queue@webkit.org [Wed, 9 Aug 2017 00:18:08 +0000 (00:18 +0000)]
Separate jsc stress test script writer from run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=175216

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-08
Reviewed by Mark Lam.

* Scripts/run-jsc-stress-tests:
* Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoResource Load Statistics: Merge of dataRecordsRemoved should use std::max()
wilander@apple.com [Wed, 9 Aug 2017 00:03:55 +0000 (00:03 +0000)]
Resource Load Statistics: Merge of dataRecordsRemoved should use std::max()
https://bugs.webkit.org/show_bug.cgi?id=175348
<rdar://problem/33785695>

Reviewed by Chris Dumez.

No new tests. Online change of a statistic that doesn't affect logic flow.

* loader/ResourceLoadStatistics.cpp:
(WebCore::ResourceLoadStatistics::merge):
    Now uses std::max() instead of addition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDon't enable default icon loading in WK1 for apps linked against old SDKs.
beidson@apple.com [Tue, 8 Aug 2017 23:53:04 +0000 (23:53 +0000)]
Don't enable default icon loading in WK1 for apps linked against old SDKs.
<rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342

Reviewed by Andy Estes.

* Misc/WebKitVersionChecks.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
  the app is linked against new WebKit with the new behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html as flaky.
ryanhaddad@apple.com [Tue, 8 Aug 2017 23:36:49 +0000 (23:36 +0000)]
Mark media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175195

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSandbox flags do not support document.domain control
bfulgham@apple.com [Tue, 8 Aug 2017 23:27:08 +0000 (23:27 +0000)]
Sandbox flags do not support document.domain control
https://bugs.webkit.org/show_bug.cgi?id=175281
<rdar://problem/33778936>

Reviewed by Chris Dumez.

Source/WebCore:

Update the 'setDomain' logic to honor the sandbox properties as defined in the current
HTML5 specification. This brings us in line with how Chrome and other browsers have
worked for some time.

Test: fast/frames/sandboxed-iframe-domain.html

* dom/Document.cpp:
(WebCore::Document::setDomain): Add check for sandbox flag (with appropriate error message)
* dom/SecurityContext.h:

LayoutTests:

* fast/frames/resources/sandboxed-iframe-set-domain.html: Added.
* fast/frames/sandboxed-iframe-domain.html: Added.
* fast/frames/sandboxed-iframe-domain-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkipping imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
jlewis3@apple.com [Tue, 8 Aug 2017 23:24:08 +0000 (23:24 +0000)]
Skipping imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
<rdar://problem/33555052>

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-highsierra/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix Ubuntu LTS build
mcatanzaro@igalia.com [Tue, 8 Aug 2017 23:03:21 +0000 (23:03 +0000)]
Unreviewed, fix Ubuntu LTS build
https://bugs.webkit.org/show_bug.cgi?id=174490

Source/JavaScriptCore:

* inspector/remote/glib/RemoteInspectorGlib.cpp:
* inspector/remote/glib/RemoteInspectorServer.cpp:

Source/WebDriver:

* glib/SessionHostGlib.cpp:

Source/WebKit:

* UIProcess/glib/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::RemoteInspectorClient):

Tools:

* TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix the Mac debug build after r220418.
wenson_hsieh@apple.com [Tue, 8 Aug 2017 21:06:18 +0000 (21:06 +0000)]
Unreviewed, fix the Mac debug build after r220418.

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::prepareForMoveToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip plugins/crash-restoring-plugin-page-from-page-cache.html on macOS debug.
ryanhaddad@apple.com [Tue, 8 Aug 2017 20:55:09 +0000 (20:55 +0000)]
Skip plugins/crash-restoring-plugin-page-from-page-cache.html on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=175270

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
wenson_hsieh@apple.com [Tue, 8 Aug 2017 20:45:21 +0000 (20:45 +0000)]
[Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
https://bugs.webkit.org/show_bug.cgi?id=175302
<rdar://problem/33762116>

Reviewed by Tim Horton.

Source/WebKit:

Refactor WebViewImpl's m_view from a raw pointer to a WeakObjCPtr to ensure that it is automatically cleared out
when the WKWebView or WKView are destroyed, and also changes several places where we implicitly block capture
the WebViewImpl to only capture a WeakPtr to the WebViewImpl. Most of the changes here are boilerplate
adjustments for how m_view is now a weak pointer.

Test: WKWebViewMacEditingTests.DoNotCrashWhenInterpretingKeyEventWhileDeallocatingView.

* Shared/mac/WeakObjCPtr.h:
(WebKit::WeakObjCPtr::operator ValueType * const):
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateTouchBar):
(WebKit::WebViewImpl::updateMediaTouchBar):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::window):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused const):
(WebKit::WebViewImpl::renewGState):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::updateWindowAndViewFrames):
(WebKit::WebViewImpl::updateLayer):
(WebKit::WebViewImpl::printOperationWithPrintInfo):
(WebKit::WebViewImpl::updateContentInsetsIfAutomatic):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::intrinsicDeviceScaleFactor const):
(WebKit::WebViewImpl::windowDidBecomeKey):
(WebKit::WebViewImpl::windowDidResignKey):
(WebKit::WebViewImpl::windowDidChangeScreen):
(WebKit::WebViewImpl::mightBeginDragWhileInactive):
(WebKit::WebViewImpl::acceptsFirstMouse):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::windowResizeMouseLocationIsInVisibleScrollerThumb):
(WebKit::WebViewImpl::viewWillMoveToWindow):
(WebKit::WebViewImpl::viewDidMoveToWindow):
(WebKit::WebViewImpl::viewDidChangeBackingProperties):
(WebKit::WebViewImpl::hitTest):
(WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent):
(WebKit::WebViewImpl::colorSpace):
(WebKit::WebViewImpl::prepareForMoveToWindow):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::pressureChangeWithEvent):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::executeSavedCommandBySelector):
(WebKit::WebViewImpl::validRequestorForSendAndReturnTypes):
(WebKit::WebViewImpl::handleRequestedCandidates):
(WebKit::WebViewImpl::preferencesDidChange):
(WebKit::WebViewImpl::setTextIndicator):
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly):
(WebKit::WebViewImpl::accessibilityRegisterUIProcessTokens):
(WebKit::WebViewImpl::sendToolTipMouseExited):
(WebKit::WebViewImpl::sendToolTipMouseEntered):
(WebKit::WebViewImpl::toolTipChanged):
(WebKit::WebViewImpl::setAcceleratedCompositingRootLayer):
(WebKit::WebViewImpl::updateThumbnailViewLayer):
(WebKit::WebViewImpl::setInspectorAttachmentView):
(WebKit::WebViewImpl::inspectorAttachmentView):
(WebKit::WebViewImpl::draggedImage):
(WebKit::WebViewImpl::draggingEntered):
(WebKit::WebViewImpl::draggingUpdated):
(WebKit::WebViewImpl::draggingExited):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::hitTestForDragTypes):
(WebKit::WebViewImpl::startWindowDrag):
(WebKit::WebViewImpl::dragImageForView):
(WebKit::WebViewImpl::setPromisedDataForImage):
(WebKit::WebViewImpl::setPromisedDataForAttachment):
(WebKit::WebViewImpl::takeViewSnapshot):
(WebKit::WebViewImpl::scrollWheel):
(WebKit::WebViewImpl::magnifyWithEvent):
(WebKit::WebViewImpl::rotateWithEvent):
(WebKit::WebViewImpl::doneWithKeyEvent):
(WebKit::WebViewImpl::interpretKeyEvent):
(WebKit::WebViewImpl::firstRectForCharacterRange):
(WebKit::WebViewImpl::characterIndexForPoint):
(WebKit::WebViewImpl::performKeyEquivalent):
(WebKit::WebViewImpl::keyUp):
(WebKit::WebViewImpl::keyDown):
(WebKit::WebViewImpl::mouseMoved):
(WebKit::WebViewImpl::windowIsFrontWindowUnderMouse):
(WebKit::WebViewImpl::userInterfaceLayoutDirection):

Tools:

Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
See WebKit ChangeLog for more details.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
* TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
(-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
(-[SlowTextInputContext handleEvent:completionHandler:]):
(-[SlowInputWebView inputContext]):
(-[SlowInputWebView _web_superInputContext]):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark fast/images/async-image-body-background-image.html as flaky on macOS.
ryanhaddad@apple.com [Tue, 8 Aug 2017 19:58:26 +0000 (19:58 +0000)]
Mark fast/images/async-image-body-background-image.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=175193

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBaseline JIT should do caging
fpizlo@apple.com [Tue, 8 Aug 2017 19:44:20 +0000 (19:44 +0000)]
Baseline JIT should do caging
https://bugs.webkit.org/show_bug.cgi?id=175037

Reviewed by Mark Lam.
Source/bmalloc:

This centralizes the notion of permanently enabling the primitive gigacage, which we only do in jsc
and WebProcess.

This saves the baseline JIT from emitting some code. Otherwise it would always have to emit enabled
checks on each typed array access.

* bmalloc/Gigacage.cpp:
(Gigacage::primitiveGigacageDisabled):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
* bmalloc/Gigacage.h:
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Source/JavaScriptCore:

Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.

Also modifies FTL caging to be more defensive when caging is disabled.

Relanded with fixed AssemblyHelpers::cageConditionally().

* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
* bytecode/InlineAccess.cpp:
(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
* jsc.cpp:
(jscmain):
(primitiveGigacageDisabled): Deleted.

Source/WebKit:

Use a better API to disable disabling the primitive gigacage.

* WebProcess/WebProcess.cpp:
(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::primitiveGigacageDisabled): Deleted.

Source/WTF:

* wtf/Gigacage.h:
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):
(Gigacage::basePtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, gardening test262 for Promise resolve / reject function length
utatane.tea@gmail.com [Tue, 8 Aug 2017 19:16:10 +0000 (19:16 +0000)]
Unreviewed, gardening test262 for Promise resolve / reject function length
https://bugs.webkit.org/show_bug.cgi?id=175333

* test262.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoChange fast seek logic to prevent ping-ponging.
commit-queue@webkit.org [Tue, 8 Aug 2017 19:03:57 +0000 (19:03 +0000)]
Change fast seek logic to prevent ping-ponging.
https://bugs.webkit.org/show_bug.cgi?id=175167
rdar://problem/32936116

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-08
Reviewed by Jer Noble.

Source/WebCore:

Updated test: media/video-fast-seek.html

Changed fast seek behavior to always seek early than seek time; and after current time when seeking forward.
This prevents ping-ponging, where a fast seek overshoots the target looking for a keyframe.
A subsequent seek will suddenly be on the other side of current time and
will search in the opposite direction for a key frame; repeat.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::fastSeek):

LayoutTests:

Test now requires forward fast seek result to be between current time and the target time,
and a backward seek to be before the seek time.

* media/video-fast-seek.html:
* media/media-source/media-source-fastseek.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove obsolete failure expectations for event_loadedmetadata.html.
commit-queue@webkit.org [Tue, 8 Aug 2017 17:22:07 +0000 (17:22 +0000)]
Remove obsolete failure expectations for event_loadedmetadata.html.
https://bugs.webkit.org/show_bug.cgi?id=175027

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-08

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoResource Load Statistics: Clear web processes' state on history removal
wilander@apple.com [Tue, 8 Aug 2017 17:18:24 +0000 (17:18 +0000)]
Resource Load Statistics: Clear web processes' state on history removal
https://bugs.webkit.org/show_bug.cgi?id=175271
<rdar://problem/33756560>

Reviewed by Chris Dumez.

Source/WebKit:

https://bugs.webkit.org/show_bug.cgi?id=175090 introduced state
in the web process and that state needs to be cleared when the
UI process' statistics are cleared as part of history removal.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearResourceLoadStatistics):
* UIProcess/WebProcessPool.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::clearResourceLoadStatisticsInWebProcesses):
* UIProcess/WebsiteData/WebsiteDataStore.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearResourceLoadStatistics):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Tools:

Test infrastructure for asynchronous tests of website data
removal for _WKWebsiteDataTypeResourceLoadStatistics.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
(WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::statisticsClearThroughWebsiteDataRemoval):

LayoutTests:

* http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal-expected.txt: Added.
* http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html: Added.
* platform/mac-wk2/TestExpectations:
    user-interaction-reported-after-website-data-removal.html marked as [ Pass ].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220412 268f45cc-cd09-0410-ab3c-d52691b4dbfc