WebKit-https.git
7 years ago[Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile...
zandobersek@gmail.com [Tue, 14 Aug 2012 17:58:19 +0000 (17:58 +0000)]
[Gtk] Include all files guarded by ENABLE_* guards in Source/WebCore/GNUmakefile.list.am into the build
https://bugs.webkit.org/show_bug.cgi?id=90696

Reviewed by Philippe Normand.

Include all files in the Autotools build that are currently guarded by ENABLE_* guards in
the WebCore GNUmakefile.list.am, regardless of the feature being enabled. Compilation should
rely on proper use of guards inside source files and preprocessor work to keep the disabled
features out.

The only exception left is the ENABLE_WEBGL guard that includes the ANGLE into compilation
only if WebGL feature is enabled.

No new tests - no new functionality.

* GNUmakefile.am:
* GNUmakefile.list.am:
* bindings/gobject/GNUmakefile.am: Add StorageInfo to the DOM bindings, despite
the feature being currently disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark inspector/debugger tests as flaky timeout on Win7
enne@google.com [Tue, 14 Aug 2012 17:58:08 +0000 (17:58 +0000)]
[chromium] Mark inspector/debugger tests as flaky timeout on Win7
https://bugs.webkit.org/show_bug.cgi?id=94002

Unreviewed gardening. Update expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
commit-queue@webkit.org [Tue, 14 Aug 2012 17:55:03 +0000 (17:55 +0000)]
[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
https://bugs.webkit.org/show_bug.cgi?id=93108

Patch by Iain Merrick <husky@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange,
and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is
used by selectRange.

The test uses sample files that contain selected text on load. The test uses
WebViewImpl::selectionBounds to get the coordinates, deselects all, then
calls WebFrameImpl::selectRange to attempt to reselect the same text.

Four cases are tested:
- the basic case
- the case where the selected text is offscreen due to a scroll
- the case where the selected text is in an iframe
- the case where the selected text is in an editable element

* tests/WebFrameTest.cpp:
* tests/data/select_range_basic.html: Added.
* tests/data/select_range_editable.html: Added.
* tests/data/select_range_iframe.html: Added.
* tests/data/select_range_scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlumb through EXT_debug_marker entry points
commit-queue@webkit.org [Tue, 14 Aug 2012 17:51:48 +0000 (17:51 +0000)]
Plumb through EXT_debug_marker entry points
https://bugs.webkit.org/show_bug.cgi?id=93860

Patch by Gregg Tavares <gman@google.com> on 2012-08-14
Reviewed by Kenneth Russell.

Source/Platform:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT are
all entry points exposed by the OpenGL ES EXT_debug_marker
extension.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::insertEventMarkerEXT):
(WebKit::WebGraphicsContext3D::pushGroupMarkerEXT):
(WebKit::WebGraphicsContext3D::popGroupMarkerEXT):

Source/WebCore:

insertEventMarkerEXT, pushGroupMarkerEXT, popGroupMarkerEXT,
are all entry points exposed by the OpenGL ES
EXT_debug_marker extension

No new tests as no new functionality exposed to web.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
* platform/chromium/support/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DChromium::pushGroupMarkerEXT):
(WebCore::Extensions3DChromium::popGroupMarkerEXT):
* platform/graphics/Extensions3D.h:
(Extensions3D):
* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGL::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGL::popGroupMarkerEXT):
* platform/graphics/opengl/Extensions3DOpenGL.h:
(Extensions3DOpenGL):
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::insertEventMarkerEXT):
(WebCore):
(WebCore::Extensions3DOpenGLES::pushGroupMarkerEXT):
(WebCore::Extensions3DOpenGLES::popGroupMarkerEXT):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
(Extensions3DOpenGLES):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: Word-spacing affects each space and non-breaking space
robert@webkit.org [Tue, 14 Aug 2012 17:36:45 +0000 (17:36 +0000)]
CSS 2.1 failure: Word-spacing affects each space and non-breaking space
https://bugs.webkit.org/show_bug.cgi?id=89826

Reviewed by Eric Seidel.

Source/WebCore:

Add word spacing to consecutive spaces in a run per http://www.w3.org/TR/CSS21/text.html#spacing-props.

Test: fast/css/word-spacing-characters.html
      fast/css/word-spacing-characters-complex-text.html
      fast/css/word-spacing-characters-linebreak.html
      css2.1/20110323/word-spacing-characters-002.htm
      css2.1/20110323/word-spacing-characters-003.htm
      css2.1/20110323/word-spacing-remove-space-001.htm
      css2.1/20110323/word-spacing-remove-space-002.htm
      css2.1/20110323/word-spacing-remove-space-003.htm
      css2.1/20110323/word-spacing-remove-space-004.htm
      css2.1/20110323/word-spacing-remove-space-005.htm
      css2.1/20110323/word-spacing-remove-space-006.htm
      css2.1/20110323/c541-word-sp-001.htm
      css2.1/20110323/c541-word-sp-000.htm

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): All spaces (ordinary space or &nbsp;) get word-spacing added, even
  if they are consecutive.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::isWordEnd): ditto, but for the complex text case on Chromium. Had to use
  m_run rather than m_normalizedBuffer here as m_normalizedBuffer turns tabs into spaces! Unlike the simple
  text path, '\n' gets word-spacing - I observed this from fast/text/atsui-spacing-features.html but can't
  find it specified anywhere.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Tested by word-spacing-linebreak.html

LayoutTests:

* css2.1/20110323/c541-word-sp-000-expected.html: Added.
* css2.1/20110323/c541-word-sp-000.htm: Renamed from LayoutTests/css2.1/t1604-c541-word-sp-00-b-a.html.
* css2.1/20110323/c541-word-sp-001-expected.html: Added.
* css2.1/20110323/c541-word-sp-001.htm: Added.
  Replaces t1604-c541-word-sp-01-b-a.html below.
* css2.1/20110323/word-spacing-characters-002-expected.html: Added.
* css2.1/20110323/word-spacing-characters-002.htm: Added.
* css2.1/20110323/word-spacing-characters-003-expected.html: Added.
* css2.1/20110323/word-spacing-characters-003.htm: Added.
  These passed already.
* css2.1/20110323/word-spacing-remove-space-001-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-001.htm: Added.
* css2.1/20110323/word-spacing-remove-space-002-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-002.htm: Added.
* css2.1/20110323/word-spacing-remove-space-003-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-003.htm: Added.
* css2.1/20110323/word-spacing-remove-space-004-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-004.htm: Added.
* css2.1/20110323/word-spacing-remove-space-005-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-005.htm: Added.
* css2.1/20110323/word-spacing-remove-space-006-expected.html: Added.
* css2.1/20110323/word-spacing-remove-space-006.htm: Added.
  These 6 tests are fixed by this patch.
* css2.1/t1604-c541-word-sp-01-b-a.html: Removed.
  Per http://lists.w3.org/Archives/Public/public-css-testsuite/2010Jan/0029.html t1604-c541-word-sp-01-b-a.htm is
  now invalid and has been replaced by c541-word-sp-001.htm above.
* fast/css/word-spacing-characters-complex-text-expected.html: Added.
* fast/css/word-spacing-characters-complex-text.html: Added.
  This is a complex text version of word-spacing-characters-001.htm
* fast/css/word-spacing-characters-expected.html: Added.
* fast/css/word-spacing-characters.html: Added.
  The original test (word-spacing-characters-001.htm) has two spaces between the non-breaking spaces in the second last case.
  This causes WebKit to split the text into two-runs and drop the second of the two spaces. This entire test can be replaced
  with word-spacing-characters-001.htm from the css test suite when https://bugs.webkit.org/show_bug.cgi?id=89827 is fixed.
* fast/css/word-spacing-linebreak-expected.html: Added.
* fast/css/word-spacing-linebreak.html: Added.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/chromium-linux/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-linux/fast/css/word-space-extra-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-mac-snowleopard/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/chromium-win/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/chromium-win/fast/css/word-space-extra-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/efl/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/mac/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/qt/TestExpectations:
* platform/qt/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Removed.
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Removed.
* platform/qt/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Removed.
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProx...
piman@chromium.org [Tue, 14 Aug 2012 17:25:55 +0000 (17:25 +0000)]
[chromium] race between CCLayerTreeHostImpl::releaseContentsTextures and CCThreadProxy::beginFrameCompleteOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=93684

Reviewed by James Robinson.

This keeps track of whether we're between the beginFrame post and the
commit when releaseContentsTextures comes, and if that is the case, we
prune the texture uploads, keep the "textures purged" flag on and kick a
new commit.

Added CCLayerTreeHostTestEvictTextures test.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::beginFramePosted):
(WebCore):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::contentsTexturesPurged):
(WebCore::CCLayerTreeHostImpl::contentsTexturesWerePurgedSinceLastBeginFrame):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCTextureUpdateController.h:
(CCTextureUpdateController):
* platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp:
(WebCore::CCTextureUpdateQueue::clearUploads):
(WebCore):
* platform/graphics/chromium/cc/CCTextureUpdateQueue.h:
(CCTextureUpdateQueue):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Pass URL String's 8-bit buffer directly to platform layer when possible
commit-queue@webkit.org [Tue, 14 Aug 2012 17:19:36 +0000 (17:19 +0000)]
[BlackBerry] Pass URL String's 8-bit buffer directly to platform layer when possible
https://bugs.webkit.org/show_bug.cgi?id=93861

Patch by Yong Li <yoli@rim.com> on 2012-08-14
Reviewed by Rob Buis.

PR# 187605.
URL strings and HTTP header strings usually use 8-bit buffers internally. We can
just pass the buffers to platform calls when only Latin1 strings are needed.

* platform/blackberry/ReadOnlyLatin1String.h: Added.
(WebCore):
(ReadOnlyLatin1String): A utility class that uses either WTF::CString or WTF::String's 8-bit buffer.
(WebCore::ReadOnlyLatin1String::ReadOnlyLatin1String): Can only be constructed with WTF::String for now.
(WebCore::ReadOnlyLatin1String::data):
(WebCore::ReadOnlyLatin1String::length):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
commit-queue@webkit.org [Tue, 14 Aug 2012 17:16:19 +0000 (17:16 +0000)]
Fix  LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
https://bugs.webkit.org/show_bug.cgi?id=92974

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Replace space characters by U+0020 SPACE characters in
CanvasRenderingContext2D::drawTextInternal() in order to
comply with the HTML Canvas 2D Context specification:
- http://www.w3.org/TR/2dcontext/#drawing-text-to-the-canvas

No new tests, already tested by canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::replaceCharacterInString):
(WebCore):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

Unskip canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html for
all the ports now that space characters are correctly replaced in
the text passed to fillText() and strokeText().

* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
zhajiang@rim.com [Tue, 14 Aug 2012 17:09:55 +0000 (17:09 +0000)]
[BlackBerry] Double-tap zoom on blocks on cnn.com desktop page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=93895

Reviewed by Antonio Gomes.
Patch by Jacky Jiang  <zhajiang@rim.com>

PR: 188232
When adjusting block zoom node, don't choose a node if the width of the
node size is very close to the width of the actual visible size as
block zoom can do nothing on such kind of node. This condition is more
restrictive than the one based on area and can bail out early.
In this way, we can get a better node for double-tap zoom.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Change the call to setUserScalable to use the setting.
kpiascik@rim.com [Tue, 14 Aug 2012 17:01:37 +0000 (17:01 +0000)]
[BlackBerry] Change the call to setUserScalable to use the setting.
https://bugs.webkit.org/show_bug.cgi?id=93974

Reviewed by Rob Buis.

We should be using the WebSetting and not the current value of m_userScalable.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 14 Aug 2012 16:52:00 +0000 (16:52 +0000)]
Unreviewed GTK gardening.

Adding image failure expectation for fast/css-generated-content/quotes-lang.html.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, updated the GTK WK2 Skipped file with well-known
sergio@webkit.org [Tue, 14 Aug 2012 16:47:27 +0000 (16:47 +0000)]
Unreviewed, updated the GTK WK2 Skipped file with well-known
failures in the WK2 bot.

* platform/gtk-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Avoid assertion failure in App Cache.
staikos@webkit.org [Tue, 14 Aug 2012 16:36:02 +0000 (16:36 +0000)]
[BlackBerry] Avoid assertion failure in App Cache.
https://bugs.webkit.org/show_bug.cgi?id=93926

Reviewed by Rob Buis.

Short-circuit data url decoding if we know it's not a data URL to
avoid an assertion failure in debug mode.  No functional change.

No new tests since this is just a debug mode assertion failure.

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Do not warn when the default theme is not found
commit-queue@webkit.org [Tue, 14 Aug 2012 16:12:17 +0000 (16:12 +0000)]
[EFL] Do not warn when the default theme is not found
https://bugs.webkit.org/show_bug.cgi?id=93968

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Even if you are using a custom theme, we always try to load first the
theme at the default path (that may or may not exist). In the case it
doesn't exist and you have a custom theme, we were always getting a
misleading error message.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Pass cursor continue results back in callback
jsbell@chromium.org [Tue, 14 Aug 2012 16:06:43 +0000 (16:06 +0000)]
IndexedDB: Pass cursor continue results back in callback
https://bugs.webkit.org/show_bug.cgi?id=92278

Reviewed by Tony Chang.

Supply the updated cursor key/primaryKey/value in the success callback,
rather than forcing the callee to make three calls into the back end to
fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation()
are given the three new payload parameters (and the latter is renamed.)

Source/WebCore:

No new tests - no behavioral changes.

* Modules/indexeddb/IDBCallbacks.h: Updated callbacks.
(IDBCallbacks):
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady): Takes values rather than fetching them.
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursorBackendImpl.cpp: Delete accessors.
(WebCore::IDBCursorBackendImpl::advanceInternal): Pass along updated cursor state.
(WebCore::IDBCursorBackendImpl::continueFunctionInternal): Ditto.
* Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl): Delete accessors from interface...
(WebCore::IDBCursorBackendImpl::key): ...but keep them for use within back-end.
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):
* Modules/indexeddb/IDBCursorBackendInterface.h: Delete accessors.
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal): Pass along new cursor state.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal): Ditto.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResultCursor): Stash updated cursor state until dispatch.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent): Update cursor with new state.
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* inspector/InspectorIndexedDBAgent.cpp: Update iteration code to use new callbacks.
(WebCore):

Source/WebKit/chromium:

* public/WebIDBCallbacks.h:
(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub.
(WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto.
* public/WebIDBCursor.h:
(WebIDBCursor): Methods can be removed once Chromium is cleaned up.
* src/IDBCallbacksProxy.cpp: Updated callbacks.
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit):
* src/IDBCallbacksProxy.h: Updated callbacks.
(IDBCallbacksProxy):
* src/IDBCursorBackendProxy.cpp: Remove back end accessors.
* src/IDBCursorBackendProxy.h:
(IDBCursorBackendProxy):
* src/WebIDBCallbacksImpl.cpp: Updated callbacks.
(WebKit::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h: Updated callbacks.
(WebIDBCallbacksImpl):
* src/WebIDBCursorImpl.cpp: Remove back end accessors.
* src/WebIDBCursorImpl.h: Remove back end accessors.
(WebIDBCursorImpl):
* tests/IDBAbortOnCorruptTest.cpp: Update test stubs.
(WebCore::MockIDBCallbacks::onSuccess):
* tests/IDBDatabaseBackendTest.cpp: Ditto.
* tests/IDBRequestTest.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 14 Aug 2012 15:53:26 +0000 (15:53 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=93967

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14

* platform/efl/TestExpectations:
* platform/efl/fast/css-generated-content/quotes-lang-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline filter results after 125462
fmalita@chromium.org [Tue, 14 Aug 2012 15:48:19 +0000 (15:48 +0000)]
[Chromium] Rebaseline filter results after 125462
https://bugs.webkit.org/show_bug.cgi?id=93969

Unreviewed gardening.

* platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
* platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
* platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
* platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac/css3/filters/effect-invert-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
* platform/chromium-mac/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac/css3/filters/filtered-inline-expected.png:
* platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
* platform/chromium-mac/css3/filters/nested-filters-expected.png:
* platform/chromium-mac/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
* platform/chromium-mac/svg/filters/color-interpolation-filters-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png.
* platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
* platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-expected.png: Removed.
* platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
* platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-win/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-win/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-win/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-win/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-win/css3/filters/effect-brightness-expected.png:
* platform/chromium-win/svg/filters/color-interpolation-filters-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/efl/svg/filters/color-interpolation-filters-expected.txt: Removed.
* platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Removed.
* svg/filters/color-interpolation-filters-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/color-interpolation-filters-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Some callback of Select onchange doesn't work
charles.wei@torchmobile.com.cn [Tue, 14 Aug 2012 15:09:08 +0000 (15:09 +0000)]
[BlackBerry] Some callback of Select onchange doesn't work
https://bugs.webkit.org/show_bug.cgi?id=93944

Reviewed by George Staikos.

The Selection element is implemented with PagePopup, an HTML-based WebView with
some Javascripts to make the UI of the select and option lists; The selection
change is initiated from the javascript code in the Select Webview, and back to
the native code of SelectPopupClient, which now in turn dispatches
FormControlChangeEvent to the select element directly, and that causes the
javascript callback been invoked in the same cycle as the javascript in the
Popup View, and causes some Javascript Context problem.

The solution is to send the FormControlChangeEvent asynchronously by a timer,
when the JavaScript in the Popup view finishes execution, we then send the
FormControlChangeEvent to the select element in the content page, that avoids
the concurrent Javascript context issue.

* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::SelectPopupClient):
(WebCore::SelectPopupClient::setValueAndClosePopup):
(WebCore):
(WebCore::SelectPopupClient::notifySelectionChange):
* WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate INdT build bot to Mountain Lion.
alexis.menard@openbossa.org [Tue, 14 Aug 2012 14:52:25 +0000 (14:52 +0000)]
Update INdT build bot to Mountain Lion.
https://bugs.webkit.org/show_bug.cgi?id=93963

Reviewed by Csaba Osztrogonác.

We updated the machine as well as the OS as the Qt port is now running
on top of Qt5.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
commit-queue@webkit.org [Tue, 14 Aug 2012 14:33:40 +0000 (14:33 +0000)]
[BlackBerry] Get rid of glCopyTexImage2D in Canvas and WebGL code paths
https://bugs.webkit.org/show_bug.cgi?id=93614

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

We used to set up resource sharing between the compositing thread
context and the Canvas and WebGL contexts, and use glCopyTexImage2D to
get a copy of the framebuffer to use as front buffer for compositing
purposes.

Now we instead create an EGLImage and blit the Canvas/WebGL output to
it. The compositing thread creates a texture from the EGLImage in order
to composite the output.

Source/WebCore:

Created a new EGLImageLayerWebKitThread base class that handles the
EGLImage and does the blitting. CanvasLayerWebKitThread and
WebGLLayerWebKitThread now inherit from this new base class.

However, we need to be careful to restore state after the blit because
it's done using the Canvas/WebGL context.

The BlackBerry implementation of GraphicsContext3D::prepareTexture()
was changed to no longer call glCopyTexImage, and
GraphicsContext3D::platformLayer() now returns the target texture
directly.

Reviewed internally by Filip Spacek.

PR 188472

No change in behavior, new tests.

* PlatformBlackBerry.cmake:
* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::makeContextCurrent):
(WebCore::CanvasLayerWebKitThread::textureSize):
(WebCore):
(WebCore::CanvasLayerWebKitThread::textureID):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(CanvasLayerWebKitThread):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp: Added.
(WebCore):
(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setImage):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h: Added.
(WebCore):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::create):
(WebCore::EGLImageLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::EGLImageLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::setNeedsDisplay):
(WebCore::EGLImageLayerWebKitThread::makeContextCurrent):
(WebCore::EGLImageLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createImageIfNeeded):
(WebCore::EGLImageLayerWebKitThread::createShaderIfNeeded):
(WebCore::EGLImageLayerWebKitThread::drawTexture):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.h: Copied from Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.h.
(WebCore):
(EGLImageLayerWebKitThread):
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::setClient):
(LayerCompositingThread):
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(LayerData):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
* platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::WebGLLayerWebKitThread::makeContextCurrent):
(WebCore):
(WebCore::WebGLLayerWebKitThread::textureSize):
(WebCore::WebGLLayerWebKitThread::textureID):
* platform/graphics/blackberry/WebGLLayerWebKitThread.h:
(WebGLLayerWebKitThread):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore):
(WebCore::GraphicsContext3D::prepareTexture):

Source/WebKit/blackberry:

This allows us to turn off resource sharing, so the WebPageCompositor
no longer needs to pass the compositing thread context to the webkit
thread.

Reviewed internally by Filip Spacek.

PR 188472

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorHelper):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectation files for fast/forms/date/calendar-picker-appearance...
tkent@chromium.org [Tue, 14 Aug 2012 14:31:45 +0000 (14:31 +0000)]
[Chromium] Update expectation files for fast/forms/date/calendar-picker-appearance.html

* platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove unneeded build logic for Android
peter@chromium.org [Tue, 14 Aug 2012 14:26:14 +0000 (14:26 +0000)]
[Chromium] Remove unneeded build logic for Android
https://bugs.webkit.org/show_bug.cgi?id=93962

Reviewed by Dimitri Glazkov.

The Android SDK and NDK have been checked in to the Chromium tree, which
allows WebKit to leverage those as well. They will already be pulled in
through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
environment variable, the envsetup.sh will set the project files up
appropriately for us.

Source/WebKit/chromium:

* DEPS:

Tools:

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1...
commit-queue@webkit.org [Tue, 14 Aug 2012 14:05:48 +0000 (14:05 +0000)]
REGRESSION (r125450): 4 canvas/philip/tests tests failing on Apple Lion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=93910

Unreviewed gardening.

Removed wrong and duplicated expectations. Mac port should use the
global expectations since this test is now passing.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-14

* platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
* platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Tue, 14 Aug 2012 14:00:40 +0000 (14:00 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Texture cache must adapt to HashMap changes
commit-queue@webkit.org [Tue, 14 Aug 2012 13:53:14 +0000 (13:53 +0000)]
[BlackBerry] Texture cache must adapt to HashMap changes
https://bugs.webkit.org/show_bug.cgi?id=93955

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

* platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::textureForTiledContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Qt gardening
allan.jensen@nokia.com [Tue, 14 Aug 2012 13:37:50 +0000 (13:37 +0000)]
Unreviewed, Qt gardening

Unmark tests that has been passing since they were fixed generally in r125371.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening for Qt, rebaselining marked test from r125167.
allan.jensen@nokia.com [Tue, 14 Aug 2012 13:30:01 +0000 (13:30 +0000)]
Unreviewed gardening for Qt, rebaselining marked test from r125167.

Changelog and commit mixed with entry below.

* platform/qt/TestExpectations:
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening for Qt, rebaselining marked test from r125167.
allan.jensen@nokia.com [Tue, 14 Aug 2012 13:27:15 +0000 (13:27 +0000)]
Unreviewed gardening for Qt, rebaselining marked test from r125167.

* platform/qt/TestExpectations:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] LayerCompositingThread.h doesn't compile
commit-queue@webkit.org [Tue, 14 Aug 2012 13:16:34 +0000 (13:16 +0000)]
[BlackBerry] LayerCompositingThread.h doesn't compile
https://bugs.webkit.org/show_bug.cgi?id=93956

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

I forgot to upstream this local change.

* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerOverride::setBounds):
(WebCore::LayerOverride::setOpacity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE
commit-queue@webkit.org [Tue, 14 Aug 2012 12:52:56 +0000 (12:52 +0000)]
[Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE
https://bugs.webkit.org/show_bug.cgi?id=93843

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

QNX does not implement MADV_FREE_REUSE nor MADV_FREE_REUSABLE.
The Blackberry port already sets the define to use the system
malloc, which is now also done for QNX in general.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] LayerAnimation is not immutable, which makes dereferencing an expensive...
commit-queue@webkit.org [Tue, 14 Aug 2012 12:39:17 +0000 (12:39 +0000)]
[BlackBerry] LayerAnimation is not immutable, which makes dereferencing an expensive operation
https://bugs.webkit.org/show_bug.cgi?id=93946

Patch by Ed Baker <edbaker@rim.com> on 2012-08-14
Reviewed by Antonio Gomes.

Make LayerAnimation immutable so it can be dereferenced from the main
WebKit thread without having to dispatch to the compositing thread,
which is an expensive operation.

TransformOperation and TimingFunction need to be made thread safe as
they are referenced in LayerAnimation, but that effort is being tracked
by a separate bug, #86483.

Reviewed internally by Arvid Nilsson.

No change in behavior, no new tests.

* platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::name):
(LayerAnimation):
(WebCore::LayerAnimation::LayerAnimation):
(WebCore::LayerAnimation::setName):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::~LayerWebKitThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GraphicsLayerBlackBerry::willBeDestroyed() must call superclass implemen...
commit-queue@webkit.org [Tue, 14 Aug 2012 12:34:23 +0000 (12:34 +0000)]
[BlackBerry] GraphicsLayerBlackBerry::willBeDestroyed() must call superclass implementation
https://bugs.webkit.org/show_bug.cgi?id=93947

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-14
Reviewed by Rob Buis.

This was fixed locally, but not upstreamed yet.

Based on an original patch by Konrad Piascik.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove custom JSC bindings from ConvolverNode.idl
commit-queue@webkit.org [Tue, 14 Aug 2012 12:10:37 +0000 (12:10 +0000)]
Remove custom JSC bindings from ConvolverNode.idl
https://bugs.webkit.org/show_bug.cgi?id=93952

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-14
Reviewed by Kentaro Hara.

We should remove custom bindings as CodeGenerator uses UNUSED_PARAM macro.

No new tests. No behavioural changes.
All tests under webaudio/* should behave same.

* GNUmakefile.list.am: Removed JSConvolverNodeCustom.cpp from builds.
* Modules/webaudio/ConvolverNode.idl: Removed [JSCustomSetter].
* UseJSC.cmake: Removed JSConvolverNodeCustom.cpp from builds.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto
* bindings/js/JSConvolverNodeCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix failing tst_QWebPage::findText unit test
commit-queue@webkit.org [Tue, 14 Aug 2012 11:56:06 +0000 (11:56 +0000)]
[Qt] Fix failing tst_QWebPage::findText unit test
https://bugs.webkit.org/show_bug.cgi?id=93951

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::findText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add external test runner for running inspector front-end tests with...
pfeldman@chromium.org [Tue, 14 Aug 2012 11:52:00 +0000 (11:52 +0000)]
Web Inspector: add external test runner for running inspector front-end tests with no TestRunner infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=93833

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added mock test runner that allows running front-end layout tests.
InspectorFrontendAPI can now dispatch whatever it receives from its embedder (opener).

* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.evaluateForTest):
(InspectorFrontendAPI.dispatch):
(InspectorFrontendAPI.loadCompleted):
(.onMessageFromOpener):

LayoutTests:

* http/tests/inspector/inspector-test.js:
* http/tests/inspector/resources/test-runner.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Incomplete repaint of link underline
allan.jensen@nokia.com [Tue, 14 Aug 2012 11:47:30 +0000 (11:47 +0000)]
[Qt] Incomplete repaint of link underline
https://bugs.webkit.org/show_bug.cgi?id=66034

Reviewed by Kenneth Rohde Christiansen.

When trying to point a line of width 30, we end up painting on of width 31, because Qt
interprets the line as end-inclusive. So adjust for end-include/exclusive difference
before requesting the draw from Qt.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] [GTK] Plugin tests failing in WK2 bot
sergio@webkit.org [Tue, 14 Aug 2012 11:46:56 +0000 (11:46 +0000)]
[WK2] [GTK] Plugin tests failing in WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=93954

Reviewed by Carlos Garcia Campos.

Plugin tests are failing in the WK2 bot because we aren't exporting
the Netscape plugin when creating the product archive.

* BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
to the list of directories to export.
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix test calendar-picker-appearance.html after r125507
keishi@webkit.org [Tue, 14 Aug 2012 11:43:44 +0000 (11:43 +0000)]
[Chromium] Fix test calendar-picker-appearance.html after r125507

Unreviewed.

* fast/forms/date/calendar-picker-appearance.html: Use resize event instead of transitionEnd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QtWebKit linking fails for QNX cross build
commit-queue@webkit.org [Tue, 14 Aug 2012 11:42:04 +0000 (11:42 +0000)]
[Qt] QtWebKit linking fails for QNX cross build
https://bugs.webkit.org/show_bug.cgi?id=93460

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-14
Reviewed by Simon Hausmann.

The GCC 4.4.2 used by the QNX BBNDK 2.0.1 fails to link QtWebKit.
Apparently it does not properly support the linker invokation using
-Wl,-whole-archive -l... -Wl,-no-whole-archive
yielding a "cc: no files to process" error. This patch works around
this issue by adding an empty dummy file (and thus object file) to
the linking stage.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crash in http/tests/plugins/plugin-document-has-focus
commit-queue@webkit.org [Tue, 14 Aug 2012 11:39:28 +0000 (11:39 +0000)]
Fix crash in http/tests/plugins/plugin-document-has-focus
https://bugs.webkit.org/show_bug.cgi?id=93949

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Jochen Eisinger.

Covered by http/tests/plugins/plugin-document-has-focus.html. If that
doesn't crash, we're good!

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::pluginIsLoadable):
    Check the PluginDocument's ownerElement before derefing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix apk generation for the Android platform
peter@chromium.org [Tue, 14 Aug 2012 11:32:46 +0000 (11:32 +0000)]
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix (step 2).

The path from webkit_unit_tests isn't robust enough. Use the same
convention as the Chromium side, i.e. walk up from the ant_build_out path.
One-line Android-only gyp change.

* WebKitUnitTests.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename functions in the ARM port of DFG-JIT for better code readability.
commit-queue@webkit.org [Tue, 14 Aug 2012 11:28:25 +0000 (11:28 +0000)]
Rename functions in the ARM port of DFG-JIT for better code readability.
https://bugs.webkit.org/show_bug.cgi?id=93609

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-14
Reviewed by Zoltan Herczeg.

Rename functions in the ARM port of DFG-JIT for better code
readability, and for following the WebKit coding style
wherever it is possible.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::genInt):
(JSC::ARMAssembler::getImm):
(JSC::ARMAssembler::moveImm):
(JSC::ARMAssembler::encodeComplexImm):
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::bitAnd):
(JSC::ARMAssembler::bitAnds):
(JSC::ARMAssembler::eor):
(JSC::ARMAssembler::eors):
(JSC::ARMAssembler::sub):
(JSC::ARMAssembler::subs):
(JSC::ARMAssembler::rsb):
(JSC::ARMAssembler::rsbs):
(JSC::ARMAssembler::add):
(JSC::ARMAssembler::adds):
(JSC::ARMAssembler::adc):
(JSC::ARMAssembler::adcs):
(JSC::ARMAssembler::sbc):
(JSC::ARMAssembler::sbcs):
(JSC::ARMAssembler::rsc):
(JSC::ARMAssembler::rscs):
(JSC::ARMAssembler::tst):
(JSC::ARMAssembler::teq):
(JSC::ARMAssembler::cmp):
(JSC::ARMAssembler::cmn):
(JSC::ARMAssembler::orr):
(JSC::ARMAssembler::orrs):
(JSC::ARMAssembler::mov):
(JSC::ARMAssembler::movw):
(JSC::ARMAssembler::movt):
(JSC::ARMAssembler::movs):
(JSC::ARMAssembler::bic):
(JSC::ARMAssembler::bics):
(JSC::ARMAssembler::mvn):
(JSC::ARMAssembler::mvns):
(JSC::ARMAssembler::mul):
(JSC::ARMAssembler::muls):
(JSC::ARMAssembler::mull):
(JSC::ARMAssembler::vmov_f64):
(JSC::ARMAssembler::vadd_f64):
(JSC::ARMAssembler::vdiv_f64):
(JSC::ARMAssembler::vsub_f64):
(JSC::ARMAssembler::vmul_f64):
(JSC::ARMAssembler::vcmp_f64):
(JSC::ARMAssembler::vsqrt_f64):
(JSC::ARMAssembler::vabs_f64):
(JSC::ARMAssembler::vneg_f64):
(JSC::ARMAssembler::ldrImmediate):
(JSC::ARMAssembler::ldrUniqueImmediate):
(JSC::ARMAssembler::dtrUp):
(JSC::ARMAssembler::dtrUpRegister):
(JSC::ARMAssembler::dtrDown):
(JSC::ARMAssembler::dtrDownRegister):
(JSC::ARMAssembler::halfDtrUp):
(JSC::ARMAssembler::halfDtrUpRegister):
(JSC::ARMAssembler::halfDtrDown):
(JSC::ARMAssembler::halfDtrDownRegister):
(JSC::ARMAssembler::doubleDtrUp):
(JSC::ARMAssembler::doubleDtrDown):
(JSC::ARMAssembler::push):
(JSC::ARMAssembler::pop):
(JSC::ARMAssembler::poke):
(JSC::ARMAssembler::peek):
(JSC::ARMAssembler::vmov_vfp64):
(JSC::ARMAssembler::vmov_arm64):
(JSC::ARMAssembler::vmov_vfp32):
(JSC::ARMAssembler::vmov_arm32):
(JSC::ARMAssembler::vcvt_f64_s32):
(JSC::ARMAssembler::vcvt_s32_f64):
(JSC::ARMAssembler::vcvt_u32_f64):
(JSC::ARMAssembler::vcvt_f64_f32):
(JSC::ARMAssembler::vcvt_f32_f64):
(JSC::ARMAssembler::clz):
(JSC::ARMAssembler::lslRegister):
(JSC::ARMAssembler::lsrRegister):
(JSC::ARMAssembler::asrRegister):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::vmov):
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::countLeadingZeros32):
(JSC::MacroAssemblerARM::convertibleLoadPtr):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::pop):
(JSC::MacroAssemblerARM::push):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::relativeTableJump):
(JSC::MacroAssemblerARM::moveWithPatch):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] UpdateAtlas is wasting memory
allan.jensen@nokia.com [Tue, 14 Aug 2012 11:22:06 +0000 (11:22 +0000)]
[Qt] UpdateAtlas is wasting memory
https://bugs.webkit.org/show_bug.cgi?id=93606

Reviewed by Jocelyn Turcotte.

Imported and QAreaAllocator from Qt3D and ported it to WebCore style,
and use this new area allocator to replace old one from UpdateAtlas.

* CMakeLists.txt:
* Target.pri:
* WebProcess/WebPage/AreaAllocator.cpp: Added.
(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):
* WebProcess/WebPage/AreaAllocator.h: Added.
(WebCore::nextPowerOfTwo):
(AreaAllocator):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
(GeneralAreaAllocator):
(Node):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove duplicated platform test expectations
ossy@webkit.org [Tue, 14 Aug 2012 11:14:55 +0000 (11:14 +0000)]
[Qt] Remove duplicated platform test expectations
https://bugs.webkit.org/show_bug.cgi?id=93351

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-10
Reviewed by Csaba Osztrogonác.

Remove platform test expectations that are the same as the global
expectations.

* platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
* platform/qt-5.0-wk2/plugins/document-open-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceMotion/no-page-cache-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceMotion/optional-event-properties-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceMotion/window-property-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/no-page-cache-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/optional-event-properties-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/window-property-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
* platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
* platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Removed.
* platform/qt/compositing/geometry/composited-in-columns-expected.txt: Removed.
* platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/qt/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
* platform/qt/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
* platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt: Removed.
* platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
* platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
* platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt: Removed.
* platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Removed.
* platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid01-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid02-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid03-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusSolid04-expected.txt: Removed.
* platform/qt/fast/box-shadow/box-shadow-radius-expected.txt: Removed.
* platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt: Removed.
* platform/qt/fast/css/font-face-descending-unicode-range-expected.txt: Removed.
* platform/qt/fast/css/font-face-font-family-descriptor-expected.txt: Removed.
* platform/qt/fast/css/font-family-pictograph-expected.txt: Removed.
* platform/qt/fast/css/hsla-color-expected.txt: Removed.
* platform/qt/fast/css/rgba-custom-text-expected.txt: Removed.
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
* platform/qt/fast/dom/icon-url-change-expected.txt: Removed.
* platform/qt/fast/dom/icon-url-list-expected.txt: Removed.
* platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Removed.
* platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Removed.
* platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Removed.
* platform/qt/fast/reflections/reflection-masks-expected.txt: Removed.
* platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
* platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
* platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt: Removed.
* platform/qt/fast/writing-mode/background-vertical-lr-expected.txt: Removed.
* platform/qt/fast/writing-mode/background-vertical-rl-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
* platform/qt/svg/custom/bug86119-expected.txt: Removed.
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
* platform/qt/svg/custom/svg-features-expected.txt: Removed.
* platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Removed.
* platform/qt/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
* platform/qt/svg/hixie/viewbox/002-expected.txt: Removed.
* platform/qt/svg/hixie/viewbox/003-expected.txt: Removed.
* platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Removed.
* platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Removed.
* platform/qt/svg/text/text-viewbox-rescale-expected.txt: Removed.
* platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Removed.
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug26553-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug83786-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix apk generation for the Android platform
peter@chromium.org [Tue, 14 Aug 2012 11:02:21 +0000 (11:02 +0000)]
[Chromium] Fix apk generation for the Android platform
https://bugs.webkit.org/show_bug.cgi?id=93841

Unreviewed build fix.

APK generation was broken as the configuration file assumed compilation
would only occur in the Chromium tree. Pass the path to Chromium's source
base directory as a property to ant.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125525.
commit-queue@webkit.org [Tue, 14 Aug 2012 10:24:07 +0000 (10:24 +0000)]
Unreviewed, rolling out r125525.
http://trac.webkit.org/changeset/125525
https://bugs.webkit.org/show_bug.cgi?id=93950

rebaseline revert after r125526... (Requested by philn on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-14

* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Removed.
* platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fixed displaying buffering progress in the media control.
commit-queue@webkit.org [Tue, 14 Aug 2012 10:13:06 +0000 (10:13 +0000)]
[EFL] Fixed displaying buffering progress in the media control.
https://bugs.webkit.org/show_bug.cgi?id=75681

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

It is required "rangeRect" instead of "rect" to display buffering
progress properly.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening after r125516.
kkristof@inf.u-szeged.hu [Tue, 14 Aug 2012 10:12:41 +0000 (10:12 +0000)]
[Qt] Gardening after r125516.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-08-14
Reviewed by Csaba Osztrogonác.

Added baseline to fast/text/zero-font-size.html.

* platform/qt/fast/text/zero-font-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to SpinButto...
yosin@chromium.org [Tue, 14 Aug 2012 09:56:51 +0000 (09:56 +0000)]
[Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to SpinButtonElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=93943

Reviewed by Kent Tamura.

This patch copys html/shadow/TextControlInnerElement.{cpp,h} to SpinButtonElement.{cpp,h} for
preparation of bug 93941, Set SpinButtonElement free from HTMLInputElement.

No new tests. This patch doesn't change behavior.

* html/shadow/SpinButtonElement.cpp: Copied from Source/WebCore/html/shadow/TextControlInnerElements.cpp.
* html/shadow/SpinButtonElement.h: Copied from Source/WebCore/html/shadow/TextControlInnerElements.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next"...
sergio@webkit.org [Tue, 14 Aug 2012 09:28:20 +0000 (09:28 +0000)]
[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
https://bugs.webkit.org/show_bug.cgi?id=91083

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

After r122428 search_next()/search_prev() should return just 1 match
if the text is found.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerNext):
(testFindControllerPrevious):

Tools:

Unskipped a couple of API tests that should work fine from now on.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK gardening.
philn@webkit.org [Tue, 14 Aug 2012 09:21:21 +0000 (09:21 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/TestExpectations: Skip media-source tests, the GTK
port doesn't support this feature yet and the tests time out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement the plugin-types Content Security Policy directive.
commit-queue@webkit.org [Tue, 14 Aug 2012 09:16:51 +0000 (09:16 +0000)]
Implement the plugin-types Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=91919

Patch by Mike West <mkwst@chromium.org> on 2012-08-14
Reviewed by Adam Barth.

Source/WebCore:

The CSP 1.1 editor's draft defines the 'plugin-types' directive as a
mechanism for whitelisting only specific types of plugin content on a
page. A protected resource might trust only Flash content, for instance,
and could enforce that preference via a Content Security Policy of
'plugin-types application/x-shockwave-flash'. Flash would load, no other
plugin type would.

Specification details available at: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#plugin-types--experimental

This experimental directive is gated on the ENABLE_CSP_NEXT flag, which
is currently only enabled in Chromium.

Tests: http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html
       http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::pluginIsLoadable):
    Adding a check against 'allowPluginType', and passing in both the
    MIME type of the plugin, as well as the declared MIME type from the
    object/embed element (ensuring that we do this correctly, even if
    we're inside a PluginDocument).
(WebCore::SubframeLoader::createJavaAppletWidget):
    Same as 'pluginIsLoadable', but hard-coded to
    'application/x-java-applet'.
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::logInvalidPluginTypes):
    Plugin types that don't match the grammar ('not/a/mime/type') are
    logged to the console, and ignored for purposes of matching.
(WebCore):
(WebCore::CSPDirectiveList::checkPluginType):
    Given both the plugin type and the declared type attribute, returns
    true if both types match, and are contained in the list of accepted
    plugin types.
(WebCore::CSPDirectiveList::checkPluginTypeAndReportViolation):
    Calls out to checkPluginType, and reports a violation if that check
    fails.
(WebCore::CSPDirectiveList::allowPluginType):
    Analog to the other 'CSPDirectiveList::allowXXX' methods, this
    branches between simply checking the type against the policy, and
    checking against the policy and then reporting violations.
(WebCore::CSPDirectiveList::parsePluginTypes):
    Given a directive value, parse out the media types contained within
    by splitting on spaces, and validating each token. Valid tokens are
    added to 'm_pluginTypes' for use in 'checkPluginType'.
(WebCore::CSPDirectiveList::addDirective):
    Wire up 'plugin-types' as a valid directive (if the ENABLE_CSP_NEXT
    flag is set). This has been combined with the other implemented 1.1
    header, 'script-nonce'.
(WebCore::ContentSecurityPolicy::allowPluginType):
    The public interface to this set of functionality.
* page/ContentSecurityPolicy.h:

LayoutTests:

* http/tests/plugins/resources/mock-plugin-unknown-type.pl:
    Adding a mock plugin resource that is served with a type that WebKit
    doesn't understand. Using it to test a confusion attack in
    plugintypes-url-02.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html: Added.
* http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
* http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
    Renaming the `q` parameter to `plugin` in these two tests.
* http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
    Add output of explicit MIME types to the object data renderer, and
    changed the `q` parameter to be slightly less confusingly named.
    It's now `plugin`.
* http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js: Added.
    Copy `multiple-iframe-test.js`, and add in plugin-specific details,
    like `plugin`, `log`, and `type`.
(test):
(finishTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable DNS prefetch
charles.wei@torchmobile.com.cn [Tue, 14 Aug 2012 09:12:22 +0000 (09:12 +0000)]
[BlackBerry] Enable DNS prefetch
https://bugs.webkit.org/show_bug.cgi?id=93846

Reviewed by George Staikos.

Source/WebCore:

No new tests.

* PlatformBlackBerry.cmake:
* platform/blackberry/TemporaryLinkStubs.cpp:
* platform/network/blackberry/DNSBlackBerry.cpp: Copied from Source/WebCore/platform/blackberry/TemporaryLinkStubs.cpp.
(WebCore):
(WebCore::prefetchDNS):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeech Input: wrong position was reported for scolled-down elements
hans@chromium.org [Tue, 14 Aug 2012 09:06:50 +0000 (09:06 +0000)]
Speech Input: wrong position was reported for scolled-down elements
https://bugs.webkit.org/show_bug.cgi?id=93634

Reviewed by Kent Tamura.

Source/WebCore:

When clicking on a speech-enabled input element, WebKit reports
the position of the element to the embedder, so that it can show
a bubble indicating that speech recognition is in progress for
the element that the user clicked on.

On a page that was scrolled, this position was being reported
erroneously: it was given relative to the frame content as opposed to
the root view, and the in-progress bubble would be shown in the wrong
place.

Test: fast/speech/bubble-position-scrolled.html

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

LayoutTests:

Test that the position of the speech element is passed to the embedder
corectly, i.e. where the user clicked, when the page is scrolled down.

* fast/speech/bubble-position-scrolled-expected.txt: Added.
* fast/speech/bubble-position-scrolled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Implement smart separators for context menu in WebKit2 GTK+
carlosgc@webkit.org [Tue, 14 Aug 2012 09:06:14 +0000 (09:06 +0000)]
[GTK] Implement smart separators for context menu in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=90449

Reviewed by Martin Robinson.

Don't add to the context menu separators that are at the very
beginning or end of the menu. Once the context menu is shown,
monitor menu items visibility to hide or show separators to make
sure they never appear in the context menu unless they are between
two visible items.

* UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuSmartSeparators):
(beforeAll):
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemVisibilityChanged):
(WebKit):
(WebKit::WebContextMenuProxyGtk::append):
(WebKit::WebContextMenuProxyGtk::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Drop "Loading..." message from FileContentView
commit-queue@webkit.org [Tue, 14 Aug 2012 09:04:29 +0000 (09:04 +0000)]
Web Inspector: Drop "Loading..." message from FileContentView
https://bugs.webkit.org/show_bug.cgi?id=91732

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-14
Reviewed by Vsevolod Vlasov.

* inspector/front-end/FileContentView.js:
(WebInspector.FileContentView.prototype.wasShown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r125519.
commit-queue@webkit.org [Tue, 14 Aug 2012 08:56:11 +0000 (08:56 +0000)]
Unreviewed, rolling out r125519.
http://trac.webkit.org/changeset/125519
https://bugs.webkit.org/show_bug.cgi?id=93945

New ref-tests caused image failures on chromium-mac bots.
(Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-14

Source/WebCore:

* css/html.css:
(meter):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLMeterElement.h:
(WebCore):
(HTMLMeterElement):
* html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):
* html/shadow/MeterShadowElement.h:
(WebCore):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::valueRatio):
* rendering/RenderMeter.h:
(RenderMeter):

LayoutTests:

* fast/dom/HTMLMeterElement/meter-clone-expected.txt:
* fast/dom/HTMLMeterElement/meter-clone.html:
* fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
* fast/dom/shadow/resources/replaced-element-styles.css:
(.progress-inner-element-like):
* fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-dynamic.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-expected.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-multiple.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-with-style.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Removed.
* fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Removed.
* fast/dom/shadow/shadowdom-for-meter.html: Removed.
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r125519.
philn@webkit.org [Tue, 14 Aug 2012 08:53:28 +0000 (08:53 +0000)]
Unreviewed, GTK rebaseline after r125519.

* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] Compare results between different platforms
kkristof@inf.u-szeged.hu [Tue, 14 Aug 2012 08:48:26 +0000 (08:48 +0000)]
[NRWT] Compare results between different platforms
https://bugs.webkit.org/show_bug.cgi?id=90555

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_search_path):
(Port):
(Port.compare_baseline):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove page popup resources to separate directory
keishi@webkit.org [Tue, 14 Aug 2012 08:48:24 +0000 (08:48 +0000)]
Move page popup resources to separate directory
https://bugs.webkit.org/show_bug.cgi?id=93932

Reviewed by Kent Tamura.

.:

* ManualTests/forms/calendar-picker.html:
* ManualTests/forms/color-suggestion-picker.html:

Source/WebCore:

Keeping the resources organized.

No new tests.

* Resources/pagepopups/calendarPicker.css: Renamed from Source/WebCore/Resources/calendarPicker.css.
* Resources/pagepopups/calendarPicker.js: Renamed from Source/WebCore/Resources/calendarPicker.js.
* Resources/pagepopups/calendarPickerMac.css: Renamed from Source/WebCore/Resources/calendarPickerMac.css.
* Resources/pagepopups/colorSuggestionPicker.css: Renamed from Source/WebCore/Resources/colorSuggestionPicker.css.
* Resources/pagepopups/colorSuggestionPicker.js: Renamed from Source/WebCore/Resources/colorSuggestionPicker.js.
* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Move wheel event handler to spin button class
yosin@chromium.org [Tue, 14 Aug 2012 08:44:42 +0000 (08:44 +0000)]
[Forms] Move wheel event handler to spin button class
https://bugs.webkit.org/show_bug.cgi?id=93928

Reviewed by Kent Tamura.

This patch moves implmentation of wheel event handling from TextFieldInput
class to SpinButtonElement class to share implementation in TextFieldInput
class, and DateTimeEditElement.

No new tests. This patch doesn't change behavior. fast/orms/number/number-wheel.html
covers this change.

* html/BaseDateAndTimeInputType.cpp: Removed handleWheelEvent() implementation.
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Removed handleWheelEvent() declaration.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Removed wheel event handling.
* html/InputType.cpp: Removed handleWheelEvent() implementation.
* html/InputType.h:
(InputType): Removed handleWheelEvent() declaration.
* html/NumberInputType.cpp: Removed handleWheelEvent() implementation.
* html/NumberInputType.h:
(NumberInputType): Removed handleWheelEvent() declaration.
* html/TextFieldInputType.cpp: Removed handleWheelEventForSpinButton() declaration.
(WebCore::TextFieldInputType::forwardEvent): Changed to call SpinButtonElement::forwardEvent().
* html/TextFieldInputType.h:
(TextFieldInputType): Removed handleWheelEventForSpinButton() declaration.
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::forwardEvent): Moved implementation of wheel event handling code
from TextFieldInputType::handleWheelEventForSpinButton().
* html/shadow/TextControlInnerElements.h:
(SpinButtonElement): Added forwardEvent() declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK baseline for test introduced in r125462.
philn@webkit.org [Tue, 14 Aug 2012 08:23:03 +0000 (08:23 +0000)]
Unreviewed, GTK baseline for test introduced in r125462.

* platform/gtk/svg/filters/color-interpolation-filters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening. Add expectations for recent flakiness.
yutak@chromium.org [Tue, 14 Aug 2012 07:53:14 +0000 (07:53 +0000)]
[Chromium] Unreviewed gardening. Add expectations for recent flakiness.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAuthorShadowDOM for meter element
shinyak@chromium.org [Tue, 14 Aug 2012 07:48:15 +0000 (07:48 +0000)]
AuthorShadowDOM for meter element
https://bugs.webkit.org/show_bug.cgi?id=91970

Reviewed by Hajime Morita.

Source/WebCore:

We add support for AuthorShadowDOM for a meter element.

According to the Shadow DOM spec, a meter element should behave like having a UserAgentShadowRoot and
an element in UserAgentShadowRoot draws a real 'meter' bar. In this patch, we change the inner structure
of a meter element so that we can distribute an element having RenderMeter to AuthorShadowDOM.

Before this patch, a meter element has the following inner structure.

    <meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot
                       |
                       +-- MeterBarElement
                       |
                       +-- MeterValueElement

After this patch, a meter element will have the following inner structure.

    <meter>--UserAgentShadowRoot -- -- -- -- -- -- -- -- -- -- AuthorShadowRoot
                       |
                       +-- MeterInnerElement
                                   |
                                   +-- MeterBarElement
                                   |
                                   +-- MeterValueElement

However, if RenderTheme supports rendering meter, MeterInnerElement will not create a renderer
unless an AuthorShadowDOM is attached to it so that we can keep the current rendering style.

Tests: fast/dom/shadow/shadowdom-for-meter-dynamic.html
       fast/dom/shadow/shadowdom-for-meter-multiple.html
       fast/dom/shadow/shadowdom-for-meter-with-style.html
       fast/dom/shadow/shadowdom-for-meter-without-appearance.html
       fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html
       fast/dom/shadow/shadowdom-for-meter.html

* css/html.css:
(meter): Changed the display type. inline-box is not supported WebKit. inline-block is true.
(meter::-webkit-meter-inner-element):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::willAddAuthorShadowRoot):
(WebCore::HTMLMeterElement::renderMeter):
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLMeterElement.h:
(WebCore):
(WebCore::HTMLMeterElement::hasAuthorShadowRoot):
(HTMLMeterElement):
(WebCore::isHTMLMeterElement):
(WebCore::toHTMLMeterElement):
* html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore):
(WebCore::MeterInnerElement::MeterInnerElement): We introduce a new element having RenderMeter
so that we can distribute an element having RenderMeter to AuthorShadowDOM.
(WebCore::MeterInnerElement::rendererIsNeeded): Different from a progress element, meter element will not be
rendered using a theme. So we don't need to check the style appearance.
(WebCore::MeterInnerElement::createRenderer):
(WebCore::MeterInnerElement::shadowPseudoId):
* html/shadow/MeterShadowElement.h:
(WebCore):
(MeterInnerElement):
(WebCore::MeterInnerElement::create):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::meterElement):
(WebCore):
(WebCore::RenderMeter::valueRatio):
* rendering/RenderMeter.h:
(RenderMeter):

LayoutTests:

Contains the following tests:
  (1) meter element with AuthorShadowDOM
  (2) meter element with multiple AuthorShadowDOM with a shadow element
  (3) meter element with multiple AuthorShadowDOM without a shadow element
  (4) meter element with AuthorShadowDOM with dynamic value update
  (5) meter element with AuthorShadowDOM with style
  (6) meter element with AuthorShadowDOM with -webkit-appearance: none

* fast/dom/HTMLMeterElement/meter-clone-expected.txt:
* fast/dom/HTMLMeterElement/meter-clone.html:
* fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
* fast/dom/shadow/resources/replaced-element-styles.css:
(.meter-like):
(.meter-inner-element-like):
* fast/dom/shadow/shadowdom-for-meter-dynamic-expected.html: Added.
* fast/dom/shadow/shadowdom-for-meter-dynamic.html: Added.
* fast/dom/shadow/shadowdom-for-meter-expected.html: Added.
* fast/dom/shadow/shadowdom-for-meter-multiple-expected.html: Added.
* fast/dom/shadow/shadowdom-for-meter-multiple.html: Added.
* fast/dom/shadow/shadowdom-for-meter-with-style-expected.html: Added.
* fast/dom/shadow/shadowdom-for-meter-with-style.html: Added.
* fast/dom/shadow/shadowdom-for-meter-without-appearance-expected.html: Added.
* fast/dom/shadow/shadowdom-for-meter-without-appearance.html: Added.
* fast/dom/shadow/shadowdom-for-meter-without-shadow-element-expected.html: Added.
* fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html: Added.
* fast/dom/shadow/shadowdom-for-meter.html: Added.
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] inspector/debugger/debugger-pause-on-exception.html is duplicated in TestE...
commit-queue@webkit.org [Tue, 14 Aug 2012 07:46:00 +0000 (07:46 +0000)]
[EFL][WK2] inspector/debugger/debugger-pause-on-exception.html is duplicated in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=93936

Unreviewed EFL gardening. Remove duplicated test
in WK2-EFL TestExpectations.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-14

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskip passing inspector tests after r125394.
kkristof@inf.u-szeged.hu [Tue, 14 Aug 2012 07:37:59 +0000 (07:37 +0000)]
[Qt] Unreviewed gardening. Unskip passing inspector tests after r125394.
https://bugs.webkit.org/show_bug.cgi?id=93228

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename LayoutTestController to TestRunner in DumpRenderTree
rniwa@webkit.org [Tue, 14 Aug 2012 07:36:41 +0000 (07:36 +0000)]
Rename LayoutTestController to TestRunner in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93758

Reviewed by Tony Chang.

Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
since it already has TestRunner class shared between DumpRenderTree and content_shell.

* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/PixelDumpSupport.cpp:
* DumpRenderTree/StorageTrackerDelegate.h:
* DumpRenderTree/StorageTrackerDelegate.mm:
* DumpRenderTree/TestRunner.cpp:
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
* DumpRenderTree/chromium/DRTTestRunner.cpp:
* DumpRenderTree/chromium/DRTTestRunner.h:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
* DumpRenderTree/chromium/NotificationPresenter.h:
* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/TestShell.h:
* DumpRenderTree/chromium/WebPermissions.cpp:
* DumpRenderTree/chromium/WebPermissions.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
* DumpRenderTree/efl/EditingCallbacks.cpp:
* DumpRenderTree/efl/TestRunnerEfl.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
* DumpRenderTree/gtk/EditingCallbacks.cpp:
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
* DumpRenderTree/mac/DumpRenderTree.mm:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* DumpRenderTree/mac/EditingDelegate.mm:
* DumpRenderTree/mac/FrameLoadDelegate.mm:
* DumpRenderTree/mac/HistoryDelegate.mm:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
* DumpRenderTree/mac/PolicyDelegate.h:
* DumpRenderTree/mac/PolicyDelegate.mm:
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/mac/UIDelegate.mm:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
* DumpRenderTree/win/DumpRenderTree.cpp:
* DumpRenderTree/win/EditingDelegate.cpp:
* DumpRenderTree/win/FrameLoadDelegate.cpp:
* DumpRenderTree/win/HistoryDelegate.cpp:
* DumpRenderTree/win/PolicyDelegate.h:
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
* DumpRenderTree/win/TestRunnerWin.cpp:
* DumpRenderTree/win/UIDelegate.cpp:
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
* DumpRenderTree/wx/TestRunnerWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] String returned by g_path_get_dirname() must be freed
commit-queue@webkit.org [Tue, 14 Aug 2012 07:31:34 +0000 (07:31 +0000)]
[GTK] String returned by g_path_get_dirname() must be freed
https://bugs.webkit.org/show_bug.cgi?id=93885

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-14
Reviewed by Philippe Normand.

Fix a memory leak in GTK's DRT code.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(pathFromSoupURI): Free the string returned by g_path_get_dirname().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] undefined reference to 'g_type_init' with gold linker
commit-queue@webkit.org [Tue, 14 Aug 2012 07:25:47 +0000 (07:25 +0000)]
[EFL] undefined reference to 'g_type_init' with gold linker
https://bugs.webkit.org/show_bug.cgi?id=93935

Unreviewed build fix. Link against glib-gobject to
fix linking error with gold linker.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-14

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoregression(r124510) webintents/web-intents-obj-constructor.html is crashing
commit-queue@webkit.org [Tue, 14 Aug 2012 07:22:31 +0000 (07:22 +0000)]
regression(r124510) webintents/web-intents-obj-constructor.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=93096

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-14
Reviewed by Kentaro Hara.

Source/WebCore:

Add null-check for JSC::ExecState pointer in JSDictionary constructor
before using it. The exec may indeed be null, thus causing crashes.

No new test, already tested by webintents/web-intents-obj-constructor.html

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::tryGetProperty):
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):
* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::JSDictionary):

LayoutTests:

Unskip webintents/web-intents-obj-constructor.html now that the
crash is fixed in WebCore.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add getter for capture attribute of input element
commit-queue@webkit.org [Tue, 14 Aug 2012 07:17:54 +0000 (07:17 +0000)]
[WK2] Add getter for capture attribute of input element
https://bugs.webkit.org/show_bug.cgi?id=93710

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-14
Reviewed by Antonio Gomes.

Add getter for capture attribute to WKOpenPanelParameters to support HTML Media Capture.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebOpenPanelParameters.cpp:
(WebKit):
(WebKit::WebOpenPanelParameters::capture):
* Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
* UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopyCapture):
* UIProcess/API/C/WKOpenPanelParameters.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK build fix after r125508.
zandobersek@gmail.com [Tue, 14 Aug 2012 07:14:45 +0000 (07:14 +0000)]
Unreviewed GTK build fix after r125508.

Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 14 Aug 2012 06:49:54 +0000 (06:49 +0000)]
Unreviewed GTK gardening.

Adding an empty platform baseline for r125462 just to avoid exceptions
in the layout-test step on the buildbots. The baseline will be updated
accordingly later.

* platform/gtk/svg/filters/color-interpolation-filters-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening, rebaselining after r125462.
joone@webkit.org [Tue, 14 Aug 2012 05:35:12 +0000 (05:35 +0000)]
[EFL] Unreviewed gardening, rebaselining after r125462.

Add a new test result to avoid layout-test exception

* platform/efl/svg/filters/color-interpolation-filters-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename files that declare and define LayoutTestController in DumpRenderTree
rniwa@webkit.org [Tue, 14 Aug 2012 04:58:40 +0000 (04:58 +0000)]
Rename files that declare and define LayoutTestController in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=93899

Reviewed by Tony Chang.

Renamed files and fixed style errors.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/LayoutTestController.cpp: Removed.
* DumpRenderTree/LayoutTestController.h: Removed.
* DumpRenderTree/PixelDumpSupport.cpp:
* DumpRenderTree/StorageTrackerDelegate.mm:
* DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
* DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
(LayoutTestController):
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
* DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
* DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
* DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
* DumpRenderTree/chromium/LayoutTestController.h: Removed.
* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/TestShell.h:
* DumpRenderTree/chromium/WebPermissions.cpp:
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/efl/CMakeLists.txt:
* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
* DumpRenderTree/efl/EditingCallbacks.cpp:
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
* DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
* DumpRenderTree/gtk/EditingCallbacks.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
* DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
* DumpRenderTree/mac/DumpRenderTree.mm:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* DumpRenderTree/mac/EditingDelegate.mm:
* DumpRenderTree/mac/FrameLoadDelegate.mm:
* DumpRenderTree/mac/HistoryDelegate.mm:
* DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
* DumpRenderTree/mac/PolicyDelegate.mm:
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
* DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
* DumpRenderTree/mac/UIDelegate.mm:
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
* DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
* DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
* DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
(WebCore):
(LayoutTestController):
(LayoutTestController::setCloseRemainingWindowsWhenComplete):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setCallCloseOnWebViews):
(LayoutTestController::addDisallowedURL):
(LayoutTestController::abortModal):
* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
* DumpRenderTree/win/DumpRenderTree.cpp:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/EditingDelegate.cpp:
* DumpRenderTree/win/FrameLoadDelegate.cpp:
* DumpRenderTree/win/HistoryDelegate.cpp:
* DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
* DumpRenderTree/win/PolicyDelegate.cpp:
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
* DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
(LayoutTestController::setUserStyleSheetEnabled):
(resolveCygwinPath):
* DumpRenderTree/win/UIDelegate.cpp:
* DumpRenderTree/wscript:
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
* DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove fade in transition from calendar picker
keishi@webkit.org [Tue, 14 Aug 2012 04:29:02 +0000 (04:29 +0000)]
Remove fade in transition from calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93816

Reviewed by Kent Tamura.

The fade in transition was incomplete because it was only fading in the
popup content and not the popup itself. Removing the effect for now.

No new tests. Can't test animation.

* Resources/calendarPicker.css:
(#main):
* Resources/calendarPicker.js:
(initialize):
(fixWindowSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWPARAM and LPARAM are incorrectly defined for x64
commit-queue@webkit.org [Tue, 14 Aug 2012 03:32:12 +0000 (03:32 +0000)]
WPARAM and LPARAM are incorrectly defined for x64
https://bugs.webkit.org/show_bug.cgi?id=89902

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.

Include WindowsExtras.h for PLATFORM(WIN) to define WPARAM and LPARAM correctly
* platform/PlatformKeyboardEvent.h:
* platform/PlatformMouseEvent.h:
* platform/PlatformWheelEvent.h:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
* platform/win/WindowMessageListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows 64 bit compliance
commit-queue@webkit.org [Tue, 14 Aug 2012 03:20:33 +0000 (03:20 +0000)]
Windows 64 bit compliance
https://bugs.webkit.org/show_bug.cgi?id=93275

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2012-08-13
Reviewed by Brent Fulgham.

Fixed a few compile and link problems for Win64

* WinLauncher/WinLauncher.cpp:
* win/DLLLauncher/DLLLauncherMain.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
commit-queue@webkit.org [Tue, 14 Aug 2012 02:53:57 +0000 (02:53 +0000)]
[Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=93918

Patch by John Bates <jbates@google.com> on 2012-08-13
Reviewed by James Robinson.

Also, update some trace events.

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::setActive):
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::onVSyncParametersChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderBlock::LineBreaker::nextLineBreak
commit-queue@webkit.org [Tue, 14 Aug 2012 02:52:03 +0000 (02:52 +0000)]
Crash in WebCore::RenderBlock::LineBreaker::nextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=93806

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-08-13
Reviewed by Abhishek Arya.

Source/WebCore:

When looking for line breaks on the first line, existing code was
checking for text-combine only in the first-line style. Since
text-combine isn't inherited this resulted in a line break being
chosen before combineText was called. When this happened and then
combineText was called subsequently, the position of the line break
iterator would be invalid.

This patch changes the check to use the regular style as in
skipLeadingWhitespace and textWidth.

Test: fast/text/text-combine-first-line-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Don't use the
first-line style when checking text-combine.

LayoutTests:

* fast/text/text-combine-first-line-crash-expected.txt: Added.
* fast/text/text-combine-first-line-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed. Rebaseline test results for add-table-overpaint.html.
yutak@chromium.org [Tue, 14 Aug 2012 02:49:44 +0000 (02:49 +0000)]
[Chromium] Unreviewed. Rebaseline test results for add-table-overpaint.html.

* platform/chromium-mac/fast/repaint/add-table-overpaint-expected.png: Added.
* platform/chromium-win/fast/repaint/add-table-overpaint-expected.png: Renamed from LayoutTests/platform/chromium/fast/repaint/add-table-overpaint-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused method HTMLDocumentParser::script()
commit-queue@webkit.org [Tue, 14 Aug 2012 02:43:04 +0000 (02:43 +0000)]
Remove unused method HTMLDocumentParser::script()
https://bugs.webkit.org/show_bug.cgi?id=93916

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-13
Reviewed by Eric Seidel.

The use of HTMLDocumentParser::script() was removed in r61640 and has never been used since then.

No behavior change, so no new tests.

* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLDocumentParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document...
tsepez@chromium.org [Tue, 14 Aug 2012 02:37:54 +0000 (02:37 +0000)]
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283

Reviewed by Eric Seidel.

Source/WebCore:

Chromium has a refptr that needs to be NULLed at this point.

The approach is to change the client redirectDataToPlugin method(s) to expect
the possibility of a NULL argument, and the use this to clear the refptr on
the chromium platform.  Other platforms can merely ignore the NULL case, thereby
maintaining the existing behaviour.

Formal testing is nearly impossible without some chrome-specific plugins.

* html/PluginDocument.cpp:
(WebCore::PluginDocument::detach):

Source/WebKit/blackberry:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):

Source/WebKit/chromium:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, NULLing Chromium's refptr that needs to be NULLed.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):

Source/WebKit/efl:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/qt:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

Chromium has a refptr that needs to be NULLed at this point.

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

Chromium has a refptr that needs to be NULLed at this point.

Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, update test expectations to reflect the recent results and
yutak@chromium.org [Tue, 14 Aug 2012 02:17:06 +0000 (02:17 +0000)]
[Chromium] Unreviewed, update test expectations to reflect the recent results and
remove lint errors.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Paint animated layers immediately to avoid animation hiccups.
commit-queue@webkit.org [Tue, 14 Aug 2012 02:14:16 +0000 (02:14 +0000)]
[chromium] Paint animated layers immediately to avoid animation hiccups.
https://bugs.webkit.org/show_bug.cgi?id=93028

Patch by Eric Penner <epenner@google.com> on 2012-08-13
Reviewed by Adrienne Walker.

Source/WebCore:

This is a technique used on Android, which is very prone
to hiccups in animations. Paint the entire layer if it is
of reasonable size such that there is no hiccups when the
animation reaches unpainted content. The reasonable size
is choosen for page-transitions specifically, as this was
the problem case (animations would just jump to the end).

Since we already have a special case this just modifies it
and replaces the unit test with a new one. This can be
improved/simplified further when distances/directions are
available for the animated layers.

Replaced one test.
Fixed bugs in and improved idlePaintNonVisibleLayers test.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::resetUpdateState):
(WebCore::UpdatableTile::markForUpdate):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::markOcclusionsAndRequestTextures):
(WebCore::TiledLayerChromium::haveTexturesForTiles):
(WebCore::TiledLayerChromium::markTilesForUpdate):
(WebCore::TiledLayerChromium::updateTileTextures):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateContentRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::contentRectToTileIndices):
* platform/graphics/chromium/cc/CCPriorityCalculator.h:
(WebCore::CCPriorityCalculator::maxPriority):

Source/WebKit/chromium:

Replaced one test. Test painting full animated layer.

* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Simple refactoring that I forgot to apply in r125495.
haraken@chromium.org [Tue, 14 Aug 2012 02:10:43 +0000 (02:10 +0000)]
Unreviewed. Simple refactoring that I forgot to apply in r125495.

* bindings/v8/V8ThrowException.cpp:
(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
* bindings/v8/V8ThrowException.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE][EFL] Fix build break with --tiled-backing-store
ryuan.choi@samsung.com [Tue, 14 Aug 2012 02:09:14 +0000 (02:09 +0000)]
[CMAKE][EFL] Fix build break with --tiled-backing-store
https://bugs.webkit.org/show_bug.cgi?id=93487

Unreviewed build fix for Efl with --tiled-backing-store.

* CMakeLists.txt:
Checked bison version and selected proper glslang files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Factor out exception related methods of V8Proxy
haraken@chromium.org [Tue, 14 Aug 2012 02:04:13 +0000 (02:04 +0000)]
[V8] Factor out exception related methods of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93792

Reviewed by Adam Barth.

To remove V8Proxy, this patch factors out exception related methods of V8Proxy
to a separate file.

(1) Move exception related methods from V8Proxy.{h,cpp} to V8ThrowException.{h,cpp}.
(2) To avoid writing V8ThrowException::throwError() here and there in V8 binding,
implement WebCore::throwError() in V8Binding.{h,cpp}. Ideally, we want to list up
all V8 binding APIs in V8Binding.h.
(3) Replace all V8Proxy::throwError() with throwError().

Nit: I couldn't write the definition of WebCore::throwError() in V8BInding.h
due to circular dependency issues. Either way, these methods wouldn't be
performance-critical.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::MethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::OnSleepDetected):
* bindings/v8/NPV8Object.cpp:
(_NPN_SetException):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/V8Binding.cpp:
(WebCore::setDOMException):
(WebCore):
(WebCore::throwError):
(WebCore::throwTypeError):
(WebCore::throwNotEnoughArgumentsError):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toV8Sequence):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/V8Proxy.h:
(V8Proxy):
(WebCore):
* bindings/v8/V8ThrowException.cpp: Added.
(WebCore):
(WebCore::DOMExceptionStackGetter):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
(WebCore::V8ThrowException::throwError):
(WebCore::V8ThrowException::throwTypeError):
(WebCore::V8ThrowException::throwNotEnoughArgumentsError):
* bindings/v8/V8ThrowException.h: Added.
(WebCore):
(V8ThrowException):
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
(WebCore::setTypeMismatchException):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback):
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertySetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
* bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorSetter):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
* bindings/v8/custom/V8IntentConstructor.cpp:
(WebCore::V8Intent::constructorCallback):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageSetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
haraken@chromium.org [Tue, 14 Aug 2012 01:45:51 +0000 (01:45 +0000)]
[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
https://bugs.webkit.org/show_bug.cgi?id=93818

Reviewed by Adam Barth.

(1) This patch moves GCEventData class from V8Binding.h to ScriptGCEvent.h.
(2) This patch makes GCEventData::startTime and GCEventData::usedHeapSize
private members.
(3) This patch removes unused forward declarations from V8Binding.h.

No tests. No change in behavior.

* bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
* bindings/v8/ScriptGCEvent.h:
(GCEventData):
(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(WebCore::GCEventData::listeners):
(WebCore::GCEventData::startTime):
(WebCore::GCEventData::setStartTime):
(WebCore::GCEventData::usedHeapSize):
(WebCore::GCEventData::setUsedHeapSize):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8PerIsolateData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
haraken@chromium.org [Tue, 14 Aug 2012 01:39:32 +0000 (01:39 +0000)]
[V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
https://bugs.webkit.org/show_bug.cgi?id=93830

Reviewed by Adam Barth.

This patch moves checkNewLegal() from V8Proxy.h to SafeAllocation.h.
In addition, this patch renames checkNewLegal() to isValidConstructorMode()
for clarification.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/SafeAllocation.cpp: Added.
* bindings/v8/SafeAllocation.h:
(WebCore::SafeAllocation::newInstance):
(WebCore):
* bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove unused methods from V8Binding.h
haraken@chromium.org [Tue, 14 Aug 2012 01:34:06 +0000 (01:34 +0000)]
[V8] Remove unused methods from V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=93836

Reviewed by Adam Barth.

enableStringImplCache() and v8UndetectableString() are not used by anybody.

No tests. No change in behavior.

* bindings/v8/V8Binding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
haraken@chromium.org [Tue, 14 Aug 2012 01:32:08 +0000 (01:32 +0000)]
[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
https://bugs.webkit.org/show_bug.cgi?id=93834

Reviewed by Adam Barth.

This patch moves hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.

No tests. No change in behavior.

* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::hintForGCIfNecessary):
* bindings/v8/V8GCController.h:
(V8GCController):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline after r125193.
shawnsingh@chromium.org [Tue, 14 Aug 2012 01:29:31 +0000 (01:29 +0000)]
Unreviewed rebaseline after r125193.

* platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png:
* platform/chromium-win/compositing/masks/layer-mask-placement-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124970.
commit-queue@webkit.org [Tue, 14 Aug 2012 01:27:21 +0000 (01:27 +0000)]
Unreviewed, rolling out r124970.
http://trac.webkit.org/changeset/124970
https://bugs.webkit.org/show_bug.cgi?id=93495

Postponing the merge in a clearer context (Requested by
Michelangelo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-13

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransform):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd test to demonstrate overpainting seen in bug 92800
eric@webkit.org [Tue, 14 Aug 2012 01:24:46 +0000 (01:24 +0000)]
Add test to demonstrate overpainting seen in bug 92800
https://bugs.webkit.org/show_bug.cgi?id=93901

Reviewed by Levi Weintraub.

Bug 92800 is a rather complicated change to fix this overpainting bug.
Adding the test before the change so that it's easier for me to track as I change
this behavior and for reviewers to see that I'm fixing this overpainting.

* fast/repaint/add-table-overpaint-expected.png: Added.
* fast/repaint/add-table-overpaint-expected.txt: Added.
* fast/repaint/add-table-overpaint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update for webcomponents-bugzilla address.
morrita@google.com [Tue, 14 Aug 2012 01:04:15 +0000 (01:04 +0000)]
Unreviewed update for webcomponents-bugzilla address.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] renderSurface in incorrect space if owning layer has empty but non-zero...
shawnsingh@chromium.org [Tue, 14 Aug 2012 01:03:48 +0000 (01:03 +0000)]
[chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
https://bugs.webkit.org/show_bug.cgi?id=93795

Reviewed by Adrienne Walker.

Source/WebCore:

If a renderSurface is created by a layer that had zero
area (empty) but non-zero bounds (either width or height was
non-zero), then one translation transform was accidentally being
skipped, causing the renderSurface drawTransform to be incorrect.
The fix is simply to move that transform outside of the
if-statement so it is not skipped.

Unit test added:
  CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer()

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable CSS Sticky Position on Windows.
commit-queue@webkit.org [Tue, 14 Aug 2012 00:57:27 +0000 (00:57 +0000)]
Enable CSS Sticky Position on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93905

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-13
Reviewed by Tim Horton.

As per https://bugs.webkit.org/show_bug.cgi?id=90046, the ENABLE_CSS_STICKY_POSITION needs to be turned on for Windows as well.

* win/tools/vsprops/FeatureDefines.vsprops:
Include ENABLE_CSS_STICKY_POSITION flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove [TreatReturnedNullAs=False]
haraken@chromium.org [Tue, 14 Aug 2012 00:55:37 +0000 (00:55 +0000)]
[V8] Remove [TreatReturnedNullAs=False]
https://bugs.webkit.org/show_bug.cgi?id=93835

Reviewed by Adam Barth.

[TreatReturnedNullAs=False] is neither defined in the Web IDL spec
nor used in any WebKit IDL file.

No tests. No change in behavior.

* WebCore.order:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
(WebCore):
* bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/V8Binding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
haraken@chromium.org [Tue, 14 Aug 2012 00:53:23 +0000 (00:53 +0000)]
[V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=93839

Reviewed by Adam Barth.

For naming consistency with toWebCoreString() and toWebCoreAtomicString(),
this patch renames v8ValueToWebCoreDOMStringList() to toDOMStringList().
("WebCore" wouldn't be needed because it's clear from "DOMStringList".)

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125483 268f45cc-cd09-0410-ab3c-d52691b4dbfc