WebKit-https.git
11 years agoUnreviewed Gtk build fix
jmalonzo@webkit.org [Sat, 8 Aug 2009 02:33:20 +0000 (02:33 +0000)]
Unreviewed Gtk build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnother windows build fix attempt
oliver@apple.com [Sat, 8 Aug 2009 02:22:08 +0000 (02:22 +0000)]
Another windows build fix attempt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
oliver@apple.com [Sat, 8 Aug 2009 02:11:35 +0000 (02:11 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 8 Aug 2009 01:57:24 +0000 (01:57 +0000)]
2009-08-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix - add html/canvas to the include path.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoProspective build fix for Qt following r46937.
treat@webkit.org [Sat, 8 Aug 2009 01:43:29 +0000 (01:43 +0000)]
Prospective build fix for Qt following r46937.

Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-07
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Yong Li <yong.li@torchmobile.com>
abarth@webkit.org [Sat, 8 Aug 2009 01:25:07 +0000 (01:25 +0000)]
2009-08-07  Yong Li  <yong.li@torchmobile.com>

        WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
        https://bugs.webkit.org/show_bug.cgi?id=27734

        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::advanceData):
        (WebCore::GlyphBuffer::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Yong Li <yong.li@torchmobile.com>
abarth@webkit.org [Sat, 8 Aug 2009 01:24:13 +0000 (01:24 +0000)]
2009-08-07  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Eric Seidel.

        WINCE PORT: pass unrecognized glyphs to GDI to handle
        https://bugs.webkit.org/show_bug.cgi?id=27734

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Move Canvas related file to a subdirectories
cmarrin@apple.com [Sat, 8 Aug 2009 01:01:16 +0000 (01:01 +0000)]
    Move Canvas related file to a subdirectories
        https://bugs.webkit.org/show_bug.cgi?id=28026

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Szabo Carol <carol.szabo@nokia.com>
abarth@webkit.org [Sat, 8 Aug 2009 00:54:15 +0000 (00:54 +0000)]
2009-08-07  Szabo Carol  <carol.szabo@nokia.com>

        Reviewed by David Hyatt.

        QtWebkit ignores letter-spacing and word-spacing styles.
        QtWebkit handles custom letter-spacing and word-spacing in the native QFont
        class, but the values for these options are not not passed on from
        the platform independent part of the Font class.
        Fixed QtWebkit behavior by applying the options to QFont when it is
        returned via Font::font()

        http://bugs.webkit.org/show_bug.cgi?id=27988

        LayoutTests:
        fast/css/word-space-extra.html
        css2.1/t1604-c542-letter-sp-00-b-a.html
        css2.1/t1604-c541-word-sp-01-b-a.html
        css1/text_properties/word_spacing.html

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::font):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Nicolas Weber <thakis@chromium.org>
abarth@webkit.org [Sat, 8 Aug 2009 00:52:11 +0000 (00:52 +0000)]
2009-08-07  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Darin Adler.

        Use correct highlight color for listboxes and completion popups.

        https://bugs.webkit.org/show_bug.cgi?id=28090

        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        Rename activeListBoxSelectionBackgroundColor to
        platformActiveListBoxSelectionBackgroundColor, so that it actually
        overrides a virtual method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Maxime Simon <simon.maxime@gmail.com>
abarth@webkit.org [Sat, 8 Aug 2009 00:48:13 +0000 (00:48 +0000)]
2009-08-07  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        Added a fourth bunch of Haiku-specific files for WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=26988

        * platform/haiku/PasteboardHaiku.cpp: Added.
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::generalPasteboard):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::clear):
        * platform/haiku/PlatformKeyboardEventHaiku.cpp: Added.
        (WebCore::keyIdentifierForHaikuKeyCode):
        (WebCore::windowsKeyCodeForKeyEvent):
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
        (WebCore::PlatformKeyboardEvent::currentCapsLockState):
        * platform/haiku/PlatformMouseEventHaiku.cpp: Added.
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/haiku/PlatformWheelEventHaiku.cpp: Added.
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
abarth@webkit.org [Sat, 8 Aug 2009 00:41:26 +0000 (00:41 +0000)]
2009-08-07  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for Noncopyable class
        https://bugs.webkit.org/show_bug.cgi?id=27879

        Several classes which are inherited from Noncopyable are instantiated by
        operator new, so Noncopyable class has been inherited from FastAllocBase.

        * wtf/Noncopyable.h:

2009-08-07  George Staikos <george.staikos@torchmobile.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=27305
        Implement WinCE-specific unicode layer.
        Written by George Staikos <george.staikos@torchmobile.com>
        with bug fixes by Yong Li <yong.li@torchmobile.com>
        refactored by Joe Mason <joe.mason@torchmobile.com>

        * wtf/Platform.h:
        * wtf/unicode/Unicode.h:
        * wtf/unicode/wince/UnicodeWince.cpp: Added.
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::foldCase):
        (WTF::Unicode::isPrintableChar):
        (WTF::Unicode::isSpace):
        (WTF::Unicode::isLetter):
        (WTF::Unicode::isUpper):
        (WTF::Unicode::isLower):
        (WTF::Unicode::isDigit):
        (WTF::Unicode::isPunct):
        (WTF::Unicode::toTitleCase):
        (WTF::Unicode::direction):
        (WTF::Unicode::category):
        (WTF::Unicode::decompositionType):
        (WTF::Unicode::combiningClass):
        (WTF::Unicode::mirroredChar):
        (WTF::Unicode::digitValue):
        * wtf/unicode/wince/UnicodeWince.h: Added.
        (WTF::Unicode::):
        (WTF::Unicode::isSeparatorSpace):
        (WTF::Unicode::isHighSurrogate):
        (WTF::Unicode::isLowSurrogate):
        (WTF::Unicode::isArabicChar):
        (WTF::Unicode::hasLineBreakingPropertyComplexContext):
        (WTF::Unicode::umemcasecmp):
        (WTF::Unicode::surrogateToUcs4):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* platform/gtk/Skipped: Skip a newly-failing test. I filed a bug about it too.
darin@apple.com [Sat, 8 Aug 2009 00:06:55 +0000 (00:06 +0000)]
* platform/gtk/Skipped: Skip a newly-failing test. I filed a bug about it too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Nicolas Weber <thakis@chromium.org>
abarth@webkit.org [Sat, 8 Aug 2009 00:03:21 +0000 (00:03 +0000)]
2009-08-07  Nicolas Weber  <thakis@chromium.org>

        Teach WebKit how to decode jpegs in cmyk and ycck color spaces.
        Heavily inspired by Firefox's take on this issue.

        https://bugs.webkit.org/show_bug.cgi?id=27909

        Reviewed by Eric Seidel.

        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode):
        Tell jpeglib to convert ycck to cmyk and keep cmyk.
        (WebCore::convertCMYKToRGBA):
        Added function to convert cmyk to rgb.
        (WebCore::convertRGBToRGBA):
        Extracted existing conversion logic into its own function.
        (WebCore::JPEGImageDecoder::outputScanlines):
        Call convertCMYKToRGBA for cmyk images, convertRGBToRGBA for rgb
        images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* platform/gtk/Skipped: Updated since textarea-arrow-navigation.html moved.
darin@apple.com [Sat, 8 Aug 2009 00:03:15 +0000 (00:03 +0000)]
* platform/gtk/Skipped: Updated since textarea-arrow-navigation.html moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Sat, 8 Aug 2009 00:02:31 +0000 (00:02 +0000)]
2009-08-07  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Mark Rowe.

        Add http/tests/misc/favicon-loads-with-images-disabled.html to get the
        Windows Debug bot back green.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
abarth@webkit.org [Fri, 7 Aug 2009 23:51:39 +0000 (23:51 +0000)]
2009-07-30  Martin Robinson  <mrobinson@appcelerator.com>

        Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

        [GTK] new-window-policy-decision-requested provides no information about the target frame
        https://bugs.webkit.org/show_bug.cgi?id=27792

        Add frameName property to the WebKitWebNavigation object.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::getNavigationAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        * webkit/webkitwebnavigationaction.cpp:
        (webkit_web_navigation_action_get_property):
        (webkit_web_navigation_action_set_property):
        (webkit_web_navigation_action_class_init):
        (webkit_web_navigation_action_get_target_frame):
        (webkit_web_navigation_action_set_target_frame):
        * webkit/webkitwebnavigationaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* Scripts/commit-log-editor: Fix unchecked access to environment
darin@apple.com [Fri, 7 Aug 2009 23:34:46 +0000 (23:34 +0000)]
* Scripts/commit-log-editor: Fix unchecked access to environment
variable that may not be there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago"Shadow tree" DOM nodes are being accidentally exposed to JavaScript
darin@apple.com [Fri, 7 Aug 2009 23:25:57 +0000 (23:25 +0000)]
"Shadow tree" DOM nodes are being accidentally exposed to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=28086

Patch by Darin Adler <darin@apple.com> on 2009-08-07
Reviewed by Adele Peterson.

Rewrite tests that depend on selection inside <input> and <textarea> elements
from showing up with getSelection(), since does not match Firefox and needs to
change soon.

* editing/deleting/delete-ligature-002-expected.txt: Updated.
* editing/deleting/delete-ligature-002.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.

* editing/deleting/delete-ligature-003-expected.txt: Updated.
* editing/deleting/delete-ligature-003.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.

* editing/deleting/skip-virama-001-expected.txt: Updated.
* editing/deleting/skip-virama-001.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.

* editing/input/textarea-arrow-navigation-expected.txt: Moved to fast/forms.
* editing/input/textarea-arrow-navigation.html: Ditto.

* editing/inserting/insert-thai-characters-001-expected.txt: Updated.
* editing/inserting/insert-thai-characters-001.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.

* editing/selection/5213963-expected.txt: Added. This is now a text-only test.
* editing/selection/5213963.html: Added a call to dumpAsText(). Changed selection
testing to use selectionEnd instead of getSelection().type.

* editing/selection/find-in-text-control-expected.txt: Updated.
* editing/selection/find-in-text-control.html: Changed test to distinguish the
different text controls. Made it use activeElement to find out if the selection
is inside a control.

* editing/selection/move-begin-end-expected.txt: Updated.
* editing/selection/move-begin-end.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.

* editing/text-iterator/thai-cursor-movement-expected.txt: Updated.
* editing/text-iterator/thai-cursor-movement.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.

* fast/forms/textarea-arrow-navigation-expected.txt: Moved from editing/input since
this is a <textarea> test, not a general editing test.
* fast/forms/textarea-arrow-navigation.html: Ditto.
Changed to use eventSender instead of the editing machinery to test the down arrow.

* platform/mac/editing/selection/5213963-expected.checksum: Removed.
This is now a text-only test.
* platform/mac/editing/selection/5213963-expected.png: Ditto.
* platform/mac/editing/selection/5213963-expected.txt: Ditto.
* platform/qt/editing/selection/5213963-expected.txt: Ditto.
* platform/win/editing/selection/5213963-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
atwilson@chromium.org [Fri, 7 Aug 2009 23:24:30 +0000 (23:24 +0000)]
WebCore:

2009-08-07  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        SharedWorkers should be shared
        https://bugs.webkit.org/show_bug.cgi?id=28058

        Added tracking of shared workers to the SharedWorkerRepository.

        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::SharedWorkerProxy::create):
        Changed SharedWorkerProxy to derive from ThreadSafeShared, as it needs to outlive the repository (if closed while some documents are still loading).
        (WebCore::SharedWorkerProxy::thread):
        (WebCore::SharedWorkerProxy::closing):
        Added flag used to determine whether the worker has closed itself while loading.
        (WebCore::SharedWorkerProxy::url):
        (WebCore::SharedWorkerProxy::name):
        Proxy now tracks worker URL and name to allow validity checks per section 4.8.3 of the WebWorkers spec.
        (WebCore::SharedWorkerProxy::SharedWorkerProxy):
        (WebCore::SharedWorkerProxy::addToDocumentSet):
        Added API to track the document set for a worker to allow worker shutdown. Currently does nothing.
        (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
        Renamed SharedWorkerLoader to be SharedWorkerScriptLoader for clarity.
        (WebCore::SharedWorkerScriptLoader::load):
        (WebCore::SharedWorkerScriptLoader::notifyFinished):
        (WebCore::DefaultSharedWorkerRepository::instance):
        (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
        Now handles "worker already loaded" case.
        (WebCore::SharedWorkerRepository::connect):
        Delegates to DefaultSharedWorkerRepository::connectToWorker
        (WebCore::DefaultSharedWorkerRepository::connectToWorker):
        Added code to track the SharedWorkerProxy in a map, and to handle the "worker already loaded" case.
        (WebCore::DefaultSharedWorkerRepository::getProxy):
        Atomic get-or-create operation on the internal tracking HashMap.
        * workers/DefaultSharedWorkerRepository.h:
        * workers/SharedWorker.cpp:
        (WebCore::SharedWorker::SharedWorker):
        * workers/SharedWorkerRepository.h:
        Removed instance() API and made constructor private to prevent instantiation.
        (WebCore::SharedWorkerRepository::SharedWorkerRepository):

LayoutTests:

2009-08-07  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        SharedWorkers should be shared
        https://bugs.webkit.org/show_bug.cgi?id=28058

        Added tracking to the SharedWorkerRepository so instances of SharedWorkers are shared across pages.

        * fast/workers/shared-worker-shared-expected.txt: Added.
        * fast/workers/shared-worker-shared.html-disabled: Added sharing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Maxime Simon <simon.maxime@gmail.com>
abarth@webkit.org [Fri, 7 Aug 2009 23:14:31 +0000 (23:14 +0000)]
2009-08-07  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        Added four Haiku-specific files for WebCore:
        PopupMenuHaiku.cpp, ScreenHaiku.cpp,
        SearchPopupMenuHaiku.cpp and SoundHaiku.cpp
        https://bugs.webkit.org/show_bug.cgi?id=28080

        * platform/haiku/PopupMenuHaiku.cpp: Added.
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::updateFromElement):
        (WebCore::PopupMenu::itemWritingDirectionIsNatural):
        * platform/haiku/ScreenHaiku.cpp: Added.
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        * platform/haiku/SearchPopupMenuHaiku.cpp: Added.
        (WebCore::SearchPopupMenu::SearchPopupMenu):
        (WebCore::SearchPopupMenu::saveRecentSearches):
        (WebCore::SearchPopupMenu::loadRecentSearches):
        (WebCore::SearchPopupMenu::enabled):
        * platform/haiku/SoundHaiku.cpp: Added.
        (WebCore::systemBeep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Maxime Simon <simon.maxime@gmail.com>
abarth@webkit.org [Fri, 7 Aug 2009 23:14:12 +0000 (23:14 +0000)]
2009-08-07  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        Added two Haiku-specific files to WebCore:
        TemporaryLinkStubs.cpp and WidgetHaiku.cpp
        https://bugs.webkit.org/show_bug.cgi?id=28080

        * platform/haiku/TemporaryLinkStubs.cpp: Added.
        (loadResourceIntoArray):
        (WebCore::historyContains):
        (WebCore::supportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):
        (WebCore::userIdleTime):
        (WebCore::callOnMainThread):
        (WebCore::SharedBuffer::createWithContentsOfFile):
        (WebCore::KURL::fileSystemPath):
        (WebCore::getSupportedKeySizes):
        * platform/haiku/WidgetHaiku.cpp: Added.
        (WebCore::Widget::Widget):
        (WebCore::Widget::~Widget):
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        (WebCore::Widget::setFocus):
        (WebCore::Widget::setCursor):
        (WebCore::Widget::show):
        (WebCore::Widget::hide):
        (WebCore::Widget::paint):
        (WebCore::Widget::setIsSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Jian Li <jianli@chromium.org>
abarth@webkit.org [Fri, 7 Aug 2009 23:12:57 +0000 (23:12 +0000)]
2009-08-07  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix the problem that isAttribute is set to false for onerror and
        onmessage in worker custom code.
        https://bugs.webkit.org/show_bug.cgi?id=28083

        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        (WebCore::getEventListener):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        (WebCore::getEventListener):
        (WebCore::ACCESSOR_SETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>
abarth@webkit.org [Fri, 7 Aug 2009 23:11:30 +0000 (23:11 +0000)]
2009-08-07  Vitaly Repeshko  <vitalyr@quad.spb.corp.google.com>

        Reviewed by Dimitri Glazkov.

        V8 bindings: speed up lookupDOMWrapper by using new V8 API function.

https://bugs.webkit.org/show_bug.cgi?id=28071

        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::lookupDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: selectionHasStyle doesn't handle text-specific properties properly
rniwa@webkit.org [Fri, 7 Aug 2009 23:05:14 +0000 (23:05 +0000)]
WebCore: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch modifies selectionHasStyle so that it returns TrueTriState when text styles
(text-decoration, font-style, font-weight, & color) are present in all text nodes,
regardless of whether the style is also present in their ancestor nodes or not.
e.g. New behavior concludes that <b><i>hello</i><i>world</i></b> has italic style.

WebKit now applies the text styles (bold, italic, etc) if the specified style was not present on
at least one text node, rather than at the beginning of selection except on Mac.
On Mac, WebKit applies the text style if the style was not present at the beginning of style.

Test: editing/execCommand/toggle-compound-styles.html

* editing/ApplyStyleCommand.cpp:
(WebCore::getPropertiesNotInComputedStyle): bug fix, must use copy instead of makeMutable for a mutable style.
* editing/Editor.cpp:
(WebCore::):
(WebCore::triStateOfStyleInComputedStyle): Added a boolean type to ignore text-specific styles
(WebCore::Editor::selectionHasStyle): Ignores text-specific styles for all but text nodes
* editing/EditorCommand.cpp:
(WebCore::executeToggleStyle): Uses selectionHasStyle instead of selectionStartHasStyle

LayoutTests: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch adds toggle-compound-styles to make sure WebKit can handle nested text styles
such as <b><i>hello</i>world</b> (italicized) and <b><i>hello</i>world</b> (not italicized)
on all platforms except on Mac (to match TextEdit's behavior).

* editing/execCommand/resources/toggle-compound-styles.js: Added.
(testSingleToggle):
* editing/execCommand/toggle-compound-styles.html: Added.
* platform/gtk/editing/execCommand: Added.
* platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Added.
* platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Added.
* platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Added.
* platform/win/editing/execCommand: Added.
* platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Jian Li <jianli@chromium.org>
abarth@webkit.org [Fri, 7 Aug 2009 22:36:47 +0000 (22:36 +0000)]
2009-08-07  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Do not register V8 error message listener in WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=28082

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Kwang Yul Seo <skyul@company100.net>
abarth@webkit.org [Fri, 7 Aug 2009 22:25:04 +0000 (22:25 +0000)]
2009-08-07  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Cairo-based Windows port does not handle cookies properly
        https://bugs.webkit.org/show_bug.cgi?id=27414

        curl handles cookies by itself, so using WinINet functions
        to get and set cookies is wrong.

        Replace CookieJarWin.cpp with CookieJarCurl.cpp so that
        cookies can be implemented later once curl provides an API to
        get and set cookies.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Michael Nordman <michaeln@google.com>
dglazkov@chromium.org [Fri, 7 Aug 2009 22:09:08 +0000 (22:09 +0000)]
2009-08-07  Michael Nordman  <michaeln@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=28074

        V8 bindings for the window.applicationCache attribute.

        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 7 Aug 2009 21:41:29 +0000 (21:41 +0000)]
2009-08-07  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Fix three tests so they are not dependent on the getSelection() result
        reflecting selections inside <input> and <textarea> elements.

        * fast/events/right-click-focus.html: Removed unneeded check of anchorNode.
        The test works fine by just testing the actual result of typing.

        * fast/forms/focus-style-pending.html: Detect focus with an onfocus
        attribute rather than by looking at getSelection().focusNode.

        * fast/forms/search-click-in-placeholder.html: Detect focus with an onfocus
        attribute rather than by looking at getSelection().baseNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Right click on timeline of media controls panel cause seek
ajwong@chromium.org [Fri, 7 Aug 2009 21:39:03 +0000 (21:39 +0000)]
WebCore: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920

Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.

Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.

* media/controls-right-click-on-timebar-expected.txt: Added.
* media/controls-right-click-on-timebar.html: Added.

LayoutTests: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920

Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.

Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.

* media/controls-right-click-on-timebar-expected.txt: Added.
* media/controls-right-click-on-timebar.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agodeprecatedCopyInheritableProperties must be replaced by two different functions
rniwa@webkit.org [Fri, 7 Aug 2009 21:36:24 +0000 (21:36 +0000)]
deprecatedCopyInheritableProperties must be replaced by two different functions
https://bugs.webkit.org/show_bug.cgi?id=28057

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch deletes deprecatedInheritableProperties and modifies call callees to call either editingStyleAtPosition
or prepareEditingStyleToApplyAt. The concept of editing style is introduced in this patch,
which consists of all CSS properties need to be preserved under editing operations.

No test is added since this patch does not change any behavior.

* css/CSSComputedStyleDeclaration.cpp: Removed deprecatedCopyInheritableProperties
* css/CSSComputedStyleDeclaration.h: Removed deprecatedCopyInheritableProperties
* editing/ApplyStyleCommand.cpp:
(WebCore::):
(WebCore::editingStyleAtPosition): Obtains the editing-specific computed style at the position
(WebCore::prepareEditingStyleToApplyAt): Removes redundant editing styles at the specified position
(WebCore::removeStylesAddedByNode): Removes the style derived from the specified node
* editing/ApplyStyleCommand.h:
(WebCore::):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Uses editingStyleAtPosition
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses editingStyleAtPosition
* editing/DeleteSelectionCommand.cpp:
(WebCore::removeEnclosingAnchorStyle): Uses removeStyleOfNode
(WebCore::DeleteSelectionCommand::saveTypingStyleState): Uses editingStyleAtPosition
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Uses prepareEditingStyleToApplyAt
* editing/EditCommand.cpp:
* editing/EditCommand.h:
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Uses editingStyleAtPosition
(WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Uses prepareEditingStyleToApplyAt
* editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::doApply): Uses editingStyleAtPosition
* editing/ReplaceSelectionCommand.cpp:
(WebCore::handleStyleSpansBeforeInsertion): Uses editingStyleAtPosition
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Uses editingStyleAtPosition and prepareEditingStyleToApplyAt
(WebCore::ReplaceSelectionCommand::doApply): Uses prepareEditingStyleToApplyAt
* editing/markup.cpp:
(WebCore::removeEnclosingMailBlockquoteStyle): Uses removeStyleOfNode
(WebCore::removeDefaultStyles): Uses prepareEditingStyleToApplyAt
(WebCore::createMarkup): Uses editingStyleAtPosition

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 7 Aug 2009 21:36:23 +0000 (21:36 +0000)]
2009-08-07  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Another try at making the gc-9.html test less prone to intermittent failure.

        * fast/dom/gc-9.html: Changed this to do the "before garbage collection"
        test right after setting the properties. This practically eliminates the
        possibility that we will get unlucky and get a garbage collection between
        when theproperty is set and tested, which seems to have happened at least
        once on the buildbot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHandle the case where only a single test is missing results.
mrowe@apple.com [Fri, 7 Aug 2009 21:10:33 +0000 (21:10 +0000)]
Handle the case where only a single test is missing results.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 George Staikos <george.staikos@torchmobile.com>
abarth@webkit.org [Fri, 7 Aug 2009 21:07:23 +0000 (21:07 +0000)]
2009-08-07  George Staikos <george.staikos@torchmobile.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=27305
        Implement WinCE-specific unicode layer.
        Written by George Staikos <george.staikos@torchmobile.com>
        with bug fixes by Yong Li <yong.li@torchmobile.com>
        refactored by Joe Mason <joe.mason@torchmobile.com>

        * wtf/Platform.h:
        * wtf/unicode/Unicode.h:
        * wtf/unicode/wince/UnicodeWince.cpp: Added.
        (WTF::Unicode::toLower):
        (WTF::Unicode::toUpper):
        (WTF::Unicode::foldCase):
        (WTF::Unicode::isPrintableChar):
        (WTF::Unicode::isSpace):
        (WTF::Unicode::isLetter):
        (WTF::Unicode::isUpper):
        (WTF::Unicode::isLower):
        (WTF::Unicode::isDigit):
        (WTF::Unicode::isPunct):
        (WTF::Unicode::toTitleCase):
        (WTF::Unicode::direction):
        (WTF::Unicode::category):
        (WTF::Unicode::decompositionType):
        (WTF::Unicode::combiningClass):
        (WTF::Unicode::mirroredChar):
        (WTF::Unicode::digitValue):
        * wtf/unicode/wince/UnicodeWince.h: Added.
        (WTF::Unicode::):
        (WTF::Unicode::isSeparatorSpace):
        (WTF::Unicode::isHighSurrogate):
        (WTF::Unicode::isLowSurrogate):
        (WTF::Unicode::isArabicChar):
        (WTF::Unicode::hasLineBreakingPropertyComplexContext):
        (WTF::Unicode::umemcasecmp):
        (WTF::Unicode::surrogateToUcs4):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Yongjun Zhang <yongjun.zhang@nokia.com>
abarth@webkit.org [Fri, 7 Aug 2009 20:15:37 +0000 (20:15 +0000)]
2009-08-07  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28069

        Add inline to help winscw compiler resolve specialized argument in
        templated functions.

        * runtime/LiteralParser.cpp:
        (JSC::LiteralParser::Lexer::lexString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
kenneth@webkit.org [Fri, 7 Aug 2009 20:09:13 +0000 (20:09 +0000)]
2009-08-07  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Move fast/forms/menulist-style-color.html to Skipped list for mac/win.
        Bug filed - https://bugs.webkit.org/show_bug.cgi?id=28079

        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 7 Aug 2009 19:52:33 +0000 (19:52 +0000)]
2009-08-07  Anders Carlsson  <andersca@apple.com>

        Fix Tiger build.

        * WebView/WebRenderNode.mm:
        (-[WebRenderNode _initWithCoreFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
abarth@webkit.org [Fri, 7 Aug 2009 19:51:38 +0000 (19:51 +0000)]
2009-08-07  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for RegExpObjectData struct
        http://bugs.webkit.org/show_bug.cgi?id=26750

        Inherits RegExpObjectData struct from FastAllocBase because
        it has been instantiated by 'new' in JavaScriptCore/runtime/RegExpObject.cpp:62

        * runtime/RegExpObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Steve Block <steveblock@google.com>
abarth@webkit.org [Fri, 7 Aug 2009 19:27:18 +0000 (19:27 +0000)]
2009-08-07  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        Bug 27250: Geolocation callback function IDL files are superfluous
        https://bugs.webkit.org/show_bug.cgi?id=27250

        The objects for the Geolocation success and error callbacks are created 'manually' in
        WebCore/bindings/js/JSGeolocationCustom.cpp. Furthermore, the callback interfaces are
        marked 'NoInterfaceObject' in the W3C spec, so the prototype should not
        appear on the window object. Hence IDL files for these callbacks are not required.

        See http://www.w3.org/TR/geolocation-API/#geolocation_interface and
        http://www.w3.org/TR/WebIDL/#NoInterfaceObject.

        No new tests required.

        * DerivedSources.make: Modified. Removed reference to IDL files.
        * WebCore.gypi: Modified. Removed reference to IDL files.
        * WebCore.xcodeproj/project.pbxproj: Modified. Removed reference to IDL files.
        * page/PositionCallback.idl: Removed.
        * page/PositionErrorCallback.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 George Wright <george.wright@torchmobile.com>
ben@webkit.org [Fri, 7 Aug 2009 19:17:43 +0000 (19:17 +0000)]
2009-08-07  George Wright  <george.wright@torchmobile.com>

        Reviewed by Adam Treat.

        Fix DumpRenderTree for the Qt port to always dump the
        PNG data unless the expected and actual hashes match.

        https://bugs.webkit.org/show_bug.cgi?id=28077

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
kenneth@webkit.org [Fri, 7 Aug 2009 18:51:30 +0000 (18:51 +0000)]
2009-08-07  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Add Test results for mac and windows for new tests.

        https://bugs.webkit.org/show_bug.cgi?id=28050

        * platform/mac/fast/forms/text-style-color-expected.txt: Added.
        * platform/win/fast/forms/text-style-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Adam Treat <adam.treat@torchmobile.com>
abarth@webkit.org [Fri, 7 Aug 2009 18:51:25 +0000 (18:51 +0000)]
2009-08-07  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        Build fix for Qt when ENABLE_VIDEO = 0.  This was necessitated by r46890 which
        put the idl files back into play regardless of compile time defines.

        * html/TimeRanges.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=28076
pkasting@chromium.org [Fri, 7 Aug 2009 18:38:15 +0000 (18:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=28076
Add fast/images/icon-decoding.html to Qt skip list until it has
results.

Reviewed by Adam Treat.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 7 Aug 2009 18:36:23 +0000 (18:36 +0000)]
2009-08-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Timothy Hatcher and Sam Weinig.

        Change WebRenderNode to take a WebFrame instead of a WebFrameView.

        * WebView/WebRenderNode.h:
        * WebView/WebRenderNode.mm:
        (-[WebRenderNode _initWithName:position:rect:coreFrame:children:]):
        (copyRenderNode):
        (-[WebRenderNode _initWithCoreFrame:]):
        (-[WebRenderNode initWithWebFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 7 Aug 2009 18:17:37 +0000 (18:17 +0000)]
2009-08-07  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        Build fix for Qt when ENABLE_VIDEO = 0.  This was necessitated by r46890 which
        put the idl files back into play regardless of compile time defines.

        * html/TimeRanges.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Pierre d'Herbemont <pdherbemont@apple.com>
abarth@webkit.org [Fri, 7 Aug 2009 18:14:36 +0000 (18:14 +0000)]
2009-08-07  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Eric Seidel.

        commit-log-editor does not produce a git commit log that is git friendly.
        https://bugs.webkit.org/show_bug.cgi?id=27754

        We make sure we end up with:
        - A first paragraph describing the bug. It is eventually prefixed by
        "WebKit: <line>" or "WebCore: <line>". This used to be
        "WebCore:\n\n<line>".
        - The Reviewed By line.
        - An eventual Patch By line if author and committer doesn't match.
        - The rest of the commit.

        * Scripts/commit-log-editor:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake run-webkit-unittests executable.
abarth@webkit.org [Fri, 7 Aug 2009 17:56:34 +0000 (17:56 +0000)]
Make run-webkit-unittests executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
kenneth@webkit.org [Fri, 7 Aug 2009 17:37:48 +0000 (17:37 +0000)]
2009-08-07  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by George Staikos.

        Coding style patches for RenderThemeQt.cpp based on results from cpp_style.py.

        https://bugs.webkit.org/show_bug.cgi?id=28050

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::baselinePosition):
        (WebCore::inflateButtonRect):
        (WebCore::RenderThemeQt::supportsFocus):
        (WebCore::RenderThemeQt::applyTheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
kenneth@webkit.org [Fri, 7 Aug 2009 17:37:10 +0000 (17:37 +0000)]
2009-08-07  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
        from discarding style colour.

        Add new tests and remove tests from platform/qt/Skipped that now pass.

        https://bugs.webkit.org/show_bug.cgi?id=28050

        * fast/forms/menulist-style-color.html: Added.
        * fast/forms/text-style-color.html: Added.
        * platform/qt/Skipped:
        * platform/qt/fast/forms/menulist-style-color-expected.txt: Added.
        * platform/qt/fast/forms/text-style-color-expected.txt: Added.

2009-08-07  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
        from discarding style colour.

        Add tests and remove tests from platform/qt/Skipped that now pass.

        https://bugs.webkit.org/show_bug.cgi?id=28050

        Tests: fast/forms/menulist-style-color.html
               fast/forms/text-style-color.html

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::adjustTextFieldStyle):
        (WebCore::RenderThemeQt::adjustMenuListStyle):
        (WebCore::RenderThemeQt::adjustMenuListButtonStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 7 Aug 2009 17:22:20 +0000 (17:22 +0000)]
2009-08-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  (Darin Adler indicated he'd prefer if we landed these
        kinds of changes unreviewed, like editing the WebKit Team wiki page.)

        Added Pierre d'Herbemont to list of committers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 7 Aug 2009 15:57:28 +0000 (15:57 +0000)]
2009-08-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=22495
        [V8] Re-land http://trac.webkit.org/changeset/46821, now that
        http://trac.webkit.org/changeset/46874 re-landed

        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 7 Aug 2009 15:52:25 +0000 (15:52 +0000)]
2009-08-07  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Darin Adler and George Staikos.

        Add rectToRect convenience function which returns the TransformationMatrix
        which maps the 'from' rectangle to the 'to' rectangle.

        https://bugs.webkit.org/show_bug.cgi?id=28067

        No tests as this would require binding the method to js and since it is static
        that doesn't seem possible.  Please check the math.

        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::TransformationMatrix::rectToRect):
        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Fri, 7 Aug 2009 15:35:19 +0000 (15:35 +0000)]
WebCore:

2009-08-07  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Implement the HTML5 hashchange event.
        https://bugs.webkit.org/show_bug.cgi?id=21605

        Test: fast/loader/hashchange-event.html

        * dom/EventNames.h: Add "hashchange"
        * html/HTMLAttributeNames.in: Add "onhashchange"

        * loader/FrameLoader.cpp:
        (WebCore::HashChangeEventTask::create):
        (WebCore::HashChangeEventTask::performTask):
        (WebCore::HashChangeEventTask::HashChangeEventTask):
        (WebCore::FrameLoader::scrollToAnchor): When an anchor navigation is completed and the
          new fragment identifier is different from the old one, queue a hash change event
          on the Document.

        Add a window event listener for the hashchange event if onhashchange is encountered:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):

        Add a new string utility method that gives "null and empty are equivalent" behavior:
        * platform/text/PlatformString.h:
        (WebCore::equalIgnoringNullity):
        * platform/text/StringImpl.cpp:
        (WebCore::equalIgnoringNullity):
        * platform/text/StringImpl.h:

LayoutTests:

2009-08-07  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Implement the HTML5 hashchange event.
        https://bugs.webkit.org/show_bug.cgi?id=21605

        * fast/loader/hashchange-event-expected.txt: Added.
        * fast/loader/hashchange-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Jessie Berlin <jberlin@apple.com>
jberlin@apple.com [Fri, 7 Aug 2009 14:57:59 +0000 (14:57 +0000)]
2009-08-07  Jessie Berlin  <jberlin@apple.com>

        Add the initial implementation of the ability to resize the columns in
        a DataGrid in the Web Inspector. Enables that functionality in both the
        Profile View and in the Local Storage View.

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=26182

        In this version, resizing a column can change the width of at most two
        columns (the columns to the left and right of the resizer being dragged).

        Possible changes in future patches:

        1) Be able to specify the minimum size of a column and the maximum size
           of a column. If the minimum size is equal to the maximum size, the
           column can't be resized.
        2) Make the behavior more in line with the following description:

        Everything before the column that is resized stays fixed size. The
        resized column changes sizes. The other columns except the last stay
        the same size. And the last column adjusts to fit with a minimum size.
        If the last column is already the minimum, the next to last column
        shrinks, etc.

        3) Make it possible to scale the column sizes appropriately when the
           Web Inspector window gets resized.

        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype.update):
        Once the DataGrid is added to the DOM, update the widths of the
        DataGrid in order to put the resizers in place.
        (WebInspector.DOMStorageItemsView.prototype.resize):
        Update the widths of the DataGrid in order to correctly adjust the
        positions of the resizers.

        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        Store column groups whose widths can later be changed when the columns
        are resized by the user.
        Also, keep track of whether the widths of the columns have been
        initialized.
        (WebInspector.DataGrid.prototype.updateWidths):
        Create the resizers for the columns.
        (WebInspector.DataGrid.prototype._clickInDataTable):
        Didn't actually change anything in this method, just added a comma to
        the end of the function.
        (WebInspector.DataGrid.prototype._startResizerDragging):
        Store the resizer that is currently dragging.
        (WebInspector.DataGrid.prototype._resizerDragging):
        Constrain the area that the resizer can be dragged to the column to
        it's left and right, with some padding added to make sure that the
        neighboring columns don't disappear.
        (WebInspector.DataGrid.prototype._endResizerDragging):

        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.resize):
        Resize the view.
        (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
        ditto.

        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.prototype.show):
        Now that the DataGrid is actually attached to the DOM, update the
        widths of the DataGrid in order to put the resizers in place.
        (WebInspector.ProfileView.prototype.resize):
        Update the widths of the DataGrid in order to correctly adjust the
        positions of the resizers.

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.resize):
        Resize the view.
        (WebInspector.ProfilesPanel.prototype._updateSidebarWidth):
        ditto.

        * inspector/front-end/inspector.css:
        Add in a style rule for a resizer in the Data Grid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 7 Aug 2009 09:55:23 +0000 (09:55 +0000)]
2009-08-07  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Back out r46847 and fix the Qt build system to always generate
        all the JS binding files from IDL files. The generated files
        have #if feature guards, so the #ifs are not needed in the
        files using them.

        * WebCore.pro:
        * bindings/js/JSEventTarget.cpp:
        * bindings/js/JSWorkerContextBase.cpp:
        * bindings/js/WorkerScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
abarth@webkit.org [Fri, 7 Aug 2009 07:32:03 +0000 (07:32 +0000)]
2009-08-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adele Peterson.

        Cannot scroll for box-reflect:right
        https://bugs.webkit.org/show_bug.cgi?id=27979

        Update m_overflowLeft an m_overflowWidth for reflection just like
        m_overflowTop and m_overflowHeight.

        * fast/reflections/reflection-overflow-scroll-expected.txt: Added.
        * fast/reflections/reflection-overflow-scroll.html: Added.
        * fast/reflections/resources/reflection-overflow-scroll.js: Added.
        * platform/mac/fast/reflections/reflection-nesting-expected.txt:
        * platform/mac/fast/repaint/reflection-redraw-expected.txt:

2009-08-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adele Peterson.

        Cannot scroll for box-reflect:right
        https://bugs.webkit.org/show_bug.cgi?id=27979

        Update m_overflowLeft an m_overflowWidth for reflection just like
        m_overflowTop and m_overflowHeight.

        Test: fast/reflections/reflection-overflow-scroll.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):

2009-08-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adele Peterson.

        Cannot scroll for box-reflect:right
        https://bugs.webkit.org/show_bug.cgi?id=27979

        Update m_overflowLeft an m_overflowWidth for reflection just like
        m_overflowTop and m_overflowHeight.

        * Scripts/make-js-test-wrappers:  Added regexp to skip box-shadow-overflo
w-scroll.js

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
abarth@webkit.org [Fri, 7 Aug 2009 06:53:08 +0000 (06:53 +0000)]
2009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        box-shadow's spread is ignored with <table>
        https://bugs.webkit.org/show_bug.cgi?id=28017

        Use RenderStyle::getBoxShadowExtent just like RenderBlock.

        * fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Added.
        * fast/box-shadow/box-shadow-overflow-scroll.html: Added.
        * fast/box-shadow/resources/box-shadow-overflow-scroll.js: Added.

2009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        box-shadow's spread is ignored with <table>
        https://bugs.webkit.org/show_bug.cgi?id=28017

        Use RenderStyle::getBoxShadowExtent just like RenderBlock.

        Test: fast/box-shadow/box-shadow-overflow-scroll.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout):

2009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        box-shadow's spread is ignored with <table>
        https://bugs.webkit.org/show_bug.cgi?id=28017

        Use RenderStyle::getBoxShadowExtent just like RenderBlock.

        * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 7 Aug 2009 06:14:31 +0000 (06:14 +0000)]
2009-08-06  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Copy expected (txt only) result from Mac for
        fast/images/icon-decoding.html from r46871 since we seem to pass this
        test as well.

        * platform/gtk/fast/images/icon-decoding-expected.txt: Copied from LayoutTests/platform/mac/fast/images/icon-decoding-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 7 Aug 2009 05:51:45 +0000 (05:51 +0000)]
2009-08-06  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: NodeLists Don't Display Well in the Console
        https://bugs.webkit.org/show_bug.cgi?id=28061

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._format): Specific check if the object is a NodeList, display as an "array"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Yusuke Sato <yusukes@chromium.org>
abarth@webkit.org [Fri, 7 Aug 2009 05:39:44 +0000 (05:39 +0000)]
2009-08-06  Yusuke Sato  <yusukes@chromium.org>

        Reviewed by David Levin.

        Chromium Linux: add support for @font-face
        https://bugs.webkit.org/show_bug.cgi?id=28015

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::~CachedFont):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::platformDataFromCustomData):
        (WebCore::CachedFont::allClientsRemoved):

        Modified #ifdefs so that chromium linux can load remote fonts.

        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::createFontCustomPlatformData):

        Create SkTypeface for a web font by calling SkTypeface::CreateFromStream function.

        (WebCore::RemoteFontStream::RemoteFontStream):
        (WebCore::RemoteFontStream::~RemoteFontStream):
        (WebCore::RemoteFontStream::rewind):
        (WebCore::RemoteFontStream::read):

        New class that implements SkStream interface and wraps wtf's SharedBuffer.

        * platform/graphics/chromium/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):

        Added member variables for Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Yong Li <yong.li@torchmobile.com>
abarth@webkit.org [Fri, 7 Aug 2009 05:09:49 +0000 (05:09 +0000)]
2009-08-06  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Eric Seidel.

        Fix JPEGImageDecoder.cpp compile error on WinCE
        https://bugs.webkit.org/show_bug.cgi?id=28051

        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric Seidel.
kevino@webkit.org [Fri, 7 Aug 2009 04:45:14 +0000 (04:45 +0000)]
Reviewed by Eric Seidel.

Adding support for building wx Python bindings using the waf build system.

https://bugs.webkit.org/show_bug.cgi?id=27619

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric Seidel.
kevino@webkit.org [Fri, 7 Aug 2009 04:24:23 +0000 (04:24 +0000)]
Reviewed by Eric Seidel.

Adding WebCore support for the waf build system for wx.

https://bugs.webkit.org/show_bug.cgi?id=27619

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Norbert Leser <norbert.leser@nokia.com>
abarth@webkit.org [Fri, 7 Aug 2009 04:11:00 +0000 (04:11 +0000)]
2009-08-06  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Darin Adler.

        Updated patch for bug #27059:
        Symbian platform always uses little endian encoding,
        regardless of compiler.
        We need to make sure that we correctly detect EABI architecture
        for armv5 targets on Symbian,
        where __EABI__ is set but not __ARM_EABI__

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
abarth@webkit.org [Fri, 7 Aug 2009 03:30:08 +0000 (03:30 +0000)]
JavaScriptCore:

2009-08-06  Adam Barth  <abarth@webkit.org>

        Unreviewed revert.

        http://bugs.webkit.org/show_bug.cgi?id=27879

        Revert 46877 because it broke GTK.

        * wtf/Noncopyable.h:

WebCore:

2009-08-06  Adam Barth  <abarth@webkit.org>

        Unreviewed revert.

        http://bugs.webkit.org/show_bug.cgi?id=27879

        Revert 46877 because it broke GTK.

        * platform/graphics/wince/GraphicsContextWince.cpp:

WebKit/win:

2009-08-06  Adam Barth  <abarth@webkit.org>

        Unreviewed revert.

        http://bugs.webkit.org/show_bug.cgi?id=27879

        Revert 46877 because it broke GTK.

        * COMPropertyBag.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 7 Aug 2009 03:05:42 +0000 (03:05 +0000)]
2009-08-06  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
        ( https://bugs.webkit.org/show_bug.cgi?id=27635 )

        This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
        (No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

        * bytecode/CodeBlock.cpp:
        (JSC::printStructureStubInfo):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

        * bytecode/CodeBlock.h:
        (JSC::):
        (JSC::CallLinkInfo::seenOnce):
        (JSC::CallLinkInfo::setSeen):
        (JSC::MethodCallLinkInfo::seenOnce):
        (JSC::MethodCallLinkInfo::setSeen):
            - Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.

        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::StructureStubInfo):
        (JSC::StructureStubInfo::initGetByIdSelf):
        (JSC::StructureStubInfo::initGetByIdProto):
        (JSC::StructureStubInfo::initGetByIdChain):
        (JSC::StructureStubInfo::initGetByIdSelfList):
        (JSC::StructureStubInfo::initGetByIdProtoList):
        (JSC::StructureStubInfo::initPutByIdTransition):
        (JSC::StructureStubInfo::initPutByIdReplace):
        (JSC::StructureStubInfo::seenOnce):
        (JSC::StructureStubInfo::setSeen):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitGetById):
        (JSC::BytecodeGenerator::emitPutById):
            - Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::unlinkCall):
            - Remove the "don't lazy link" stage of calls.

        * jit/JIT.h:
        (JSC::JIT::compileCTIMachineTrampolines):
            - Remove the "don't lazy link" stage of calls.

        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallSlowCase):
            - Remove the "don't lazy link" stage of calls.

        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        (JSC::JITThunks::tryCachePutByID):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::JITStubs::DEFINE_STUB_FUNCTION):
        (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
            - Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.

        * jit/JITStubs.h:
        (JSC::JITThunks::ctiStringLengthTrampoline):
        (JSC::JITStubs::):
            - Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.

        * wtf/PtrAndFlags.h:
        (WTF::PtrAndFlags::PtrAndFlags):
        (WTF::PtrAndFlags::operator!):
        (WTF::PtrAndFlags::operator->):
            - Add ! and -> operators, add constuctor with pointer argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Fri, 7 Aug 2009 01:56:36 +0000 (01:56 +0000)]
2009-08-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Eric Seidel.

        Bug 27956 - AX: roleValue should be cached for performance
        https://bugs.webkit.org/show_bug.cgi?id=27956

        Caches the role value of an accessibility object instead of calculating it everytime.
        The changes gained a 5% speedup using VoiceOver to navigate a webpage.

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::handleAriaRoleChanged):

        Use generic role setter instead of specific ARIA role setter.

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::AccessibilityObject):
        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::headingLevel):

        Make headingLevel into instance method so that it can *safely* be called in the constructor.

        (WebCore::AccessibilityObject::setRoleValue):
        (WebCore::AccessibilityObject::roleValue):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::headingLevel):
        (WebCore::AccessibilityRenderObject::intValue):
        (WebCore::AccessibilityRenderObject::updateAccessibilityRole):
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (AXAttributeStringSetHeadingLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
abarth@webkit.org [Fri, 7 Aug 2009 01:09:14 +0000 (01:09 +0000)]
2009-08-06  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Adam Barth.

        Allow custom memory allocation control for Noncopyable class
        https://bugs.webkit.org/show_bug.cgi?id=27879

        Several classes which inherited from Noncopyable are instantiated by
        operator new, so Noncopyable class has been inherited from FastAllocBase.

        * wtf/Noncopyable.h:

2009-08-06  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Adam Barth.

        Change Noncopyable inheriting to public
        http://bugs.webkit.org/show_bug.cgi?id=27879

        Since Noncopyable is inherited from FastAllocBase, Noncopyable's
        inheriting has been changed to public.

        * platform/graphics/wince/GraphicsContextWince.cpp:

2009-08-06  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Adam Barth.

        Change Noncopyable inheriting to public
        http://bugs.webkit.org/show_bug.cgi?id=27879

        Since Noncopyable is inherited from FastAllocBase,
        Noncopyable's inheriting has been changed to public.

        * COMPropertyBag.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd explicit dependencies for our build verification scripts to ensure that they...
mrowe@apple.com [Fri, 7 Aug 2009 00:59:13 +0000 (00:59 +0000)]
Add explicit dependencies for our build verification scripts to ensure that they always run after linking has completed.

Rubber-stamped by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 7 Aug 2009 00:59:05 +0000 (00:59 +0000)]
2009-08-06  Simon Fraser  <simon.fraser@apple.com>

        Make the test a little more sloppy to try to fix sporadic failures on Windows.

        * animations/play-state.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 7 Aug 2009 00:32:39 +0000 (00:32 +0000)]
2009-08-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Implement the matchMedium method on the Media interface described in the CSSOM View Module.
        https://bugs.webkit.org/show_bug.cgi?id=22495

        Add a new Media interface, obtainable via the AbstractView, that can
        evaluate queries via its matchesMedium() method.

        Test: fast/media/matchmedium-query-api.html

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Add Media.* files to the build.

        * css/Media.cpp: Added.
        (WebCore::Media::Media):
        (WebCore::Media::type):
        (WebCore::Media::matchMedium):
        * css/Media.h: Added.
        (WebCore::Media::create):
        (WebCore::Media::document):
        * css/Media.idl: Added.
        Media::matchMedium() uses a MediaQueryEvaluator() to test the query.

        * page/AbstractView.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::media):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        Add a readonly attribute for Media.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 7 Aug 2009 00:28:49 +0000 (00:28 +0000)]
2009-08-06  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        * fast/dom/gc-9-expected.txt: Generated new results.
        * fast/dom/gc-9.html: Turned off tests that are unpredictable based
        on what happens during garbage collection. These do represent bugs,
        so we want to turn them back on again once the bugs are fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 7 Aug 2009 00:27:38 +0000 (00:27 +0000)]
2009-08-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Strip line endings at all points auto-version.sh reads data, not just
        the one I happened to run into.

        * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 7 Aug 2009 00:25:41 +0000 (00:25 +0000)]
2009-08-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28025
        Add a test for .ico decoding.

        * fast/images/icon-decoding.html: Added.
        * fast/images/resources/1bit.ico: Added.
        * fast/images/resources/2entries.ico: Added.
        * fast/images/resources/32bit.ico: Added.
        * fast/images/resources/8bit.ico: Added.
        * platform/mac/fast/images/icon-decoding-expected.checksum: Added.
        * platform/mac/fast/images/icon-decoding-expected.png: Added.
        * platform/mac/fast/images/icon-decoding-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 6 Aug 2009 23:46:13 +0000 (23:46 +0000)]
2009-08-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler and Dan Bernstein.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::hasHTMLView):
        Always return true when we're in viewless mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Michelangelo De Simone <micdesim@gmail.com>
abarth@webkit.org [Thu, 6 Aug 2009 23:45:37 +0000 (23:45 +0000)]
2009-08-06  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27455
        Test suite for form controls' custom validation message.

        * fast/dom/domListEnumeration-expected.txt: Corrected
        * fast/dom/resources/domListEnumeration.js: Corrected
        * fast/forms/ValidityState-customError-001-expected.txt: Added.
        * fast/forms/ValidityState-customError-001.html: Added.
        * fast/forms/ValidityState-customError-002-expected.txt: Added.
        * fast/forms/ValidityState-customError-002.html: Added.
        * fast/forms/ValidityState-customError-003-expected.txt: Added.
        * fast/forms/ValidityState-customError-003.html: Added.
        * fast/forms/ValidityState-customError-004-expected.txt: Added.
        * fast/forms/ValidityState-customError-004.html: Added.

2009-08-06  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27455
        Support for a custom validation message in ValidityState and related
        form controls.
        http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-cva-setcustomvalidity

        Tests: fast/forms/ValidityState-customError-001.html
               fast/forms/ValidityState-customError-002.html
               fast/forms/ValidityState-customError-003.html
               fast/forms/ValidityState-customError-004.html

        * html/HTMLButtonElement.idl: setCustomValidity DOM method
        * html/HTMLFieldSetElement.idl: ditto
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::setCustomValidity): ditto
        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::valueMissing): moved down
        * html/HTMLInputElement.idl: ditto
        * html/HTMLSelectElement.idl: ditto
        * html/HTMLTextAreaElement.idl:
        * html/ValidityState.h:
        (WebCore::ValidityState::setCustomErrorMessage): method to set custom
        validation message
        (WebCore::ValidityState::customError): validation flag

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBring a little order to our otherwise out of control lives.
mrowe@apple.com [Thu, 6 Aug 2009 23:00:21 +0000 (23:00 +0000)]
Bring a little order to our otherwise out of control lives.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoStop copying .idl files in to the framework resources directory.
mrowe@apple.com [Thu, 6 Aug 2009 22:56:01 +0000 (22:56 +0000)]
Stop copying .idl files in to the framework resources directory.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 6 Aug 2009 22:51:27 +0000 (22:51 +0000)]
2009-08-06  Anders Carlsson  <andersca@apple.com>

        Remove WebGraphicsExtras.h include.

        * Plugins/WebNetscapePluginView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build some more.
mrowe@apple.com [Thu, 6 Aug 2009 22:51:24 +0000 (22:51 +0000)]
Fix the build some more.

Add JSWebSocket.cpp and JSWebSocket.h to the Xcode project, and move the WebSocket-related
files and groups in to the appropriate locations.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Thu, 6 Aug 2009 22:38:44 +0000 (22:38 +0000)]
Build fix.

Don't attempt to build a file that Anders just deleted.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Fumitoshi Ukai <ukai@chromium.org>
jorlow@chromium.org [Thu, 6 Aug 2009 22:30:10 +0000 (22:30 +0000)]
2009-08-06  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add WebSocket.idl
        https://bugs.webkit.org/show_bug.cgi?id=27209

        Add WebSocket.idl in WebCore/websockets/.
        Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
        Other build systems will be updated once the code is functional.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebSocketConstructor.cpp: Added.
        * bindings/js/JSWebSocketConstructor.h: Added.
        * bindings/js/JSWebSocketCustom.cpp: Added.
        * websockets/WebSocket.cpp: Added.
        * websockets/WebSocket.h: Added.
        * websockets/WebSocket.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 6 Aug 2009 22:08:24 +0000 (22:08 +0000)]
2009-08-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Remove WebGraphicsExtras, it is no longer used.

        * Misc/WebGraphicsExtras.c: Removed.
        * Misc/WebGraphicsExtras.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 6 Aug 2009 21:57:42 +0000 (21:57 +0000)]
2009-08-06  Simon Fraser  <simon.fraser@apple.com>

        Fix a test in http/tests/media that was missed in the earlier 'media' rename.

        * http/tests/media/video-play-stall.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 6 Aug 2009 21:41:23 +0000 (21:41 +0000)]
2009-08-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
        https://bugs.webkit.org/show_bug.cgi?id=28055

        This patch converts boldSelection.html to a dumpAsText and adds description on what it tests.
        Namely, it tests bolding the first 21 letters  of a sentence.
        Since bolding must be done by adding b tag instead of a style span, we print innerHTML of the result.

        * editing/execCommand/boldSelection-expected.txt: Added.
        * editing/execCommand/boldSelection.html:
        * platform/mac/editing/execCommand/boldSelection-expected.checksum: Removed.
        * platform/mac/editing/execCommand/boldSelection-expected.png: Removed.
        * platform/mac/editing/execCommand/boldSelection-expected.txt: Removed.
        * platform/qt/editing/execCommand/boldSelection-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Jian Li <jianli@chromium.org>
jianli@chromium.org [Thu, 6 Aug 2009 21:29:23 +0000 (21:29 +0000)]
2009-08-06  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Style cleaning for WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=27997

        Cleanup WorkerContextExecutioonProxy related files to follow
        WebKit coding styles after all V8 binding codes are upstreamed.
        1) Lower-case the first letter of remaining functins in class
           WorkerContextExecutionProxy. Update the V8 code generator
           and all other references accordingly.
        2) Integrate getConstructor from WorkerContextExecutionProxy
           to V8DOMWrapper.
        3) Other misc changes, like removing trailing whitespaces and
           sorting the include files.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructorForContext):
        (WebCore::V8DOMWrapper::convertToV8Object):
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::~V8WorkerContextEventListener):
        (WebCore::V8WorkerContextEventListener::handleEvent):
        (WebCore::V8WorkerContextEventListener::reportError):
        (WebCore::V8WorkerContextEventListener::getReceiverObject):
        * bindings/v8/V8WorkerContextObjectEventListener.cpp:
        (WebCore::weakObjectEventListenerCallback):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::handleConsoleMessage):
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertWorkerContextToV8Object):
        (WebCore::WorkerContextExecutionProxy::toV8):
        (WebCore::WorkerContextExecutionProxy::forgetV8EventObject):
        (WebCore::WorkerContextExecutionProxy::removeEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        (WebCore::WorkerContextExecutionProxy::context):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 6 Aug 2009 21:15:05 +0000 (21:15 +0000)]
2009-08-06  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Dan Bernstein.

        Move a video test from fast/media to media/, since fast/media is all about
        CSS media queries.

        * media/video-controls-with-mutation-event-handler-expected.txt: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler-expected.txt.
        * media/video-controls-with-mutation-event-handler.html: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 6 Aug 2009 21:09:24 +0000 (21:09 +0000)]
2009-08-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=28056
        Change media tests to not use a variable in global scope with the name
        'media', to avoid conflict with window.media.

        * media/audio-constructor-autobuffer-expected.txt:
        * media/audio-constructor-autobuffer.html:
        * media/audio-constructor-src.html:
        * media/audio-constructor.html:
        * media/audio-data-url-expected.txt:
        * media/audio-data-url.html:
        * media/audio-mpeg-supported-expected.txt:
        * media/audio-mpeg-supported.html:
        * media/media-load-event-expected.txt:
        * media/media-load-event.html:
        * media/video-can-play-type.html:
        * media/video-loop-expected.txt:
        * media/video-loop.html:
        * media/video-seek-past-end-paused-expected.txt:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing-expected.txt:
        * media/video-seek-past-end-playing.html:
        * media/video-source-media.html:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-invalid-remove.html:
        * media/video-src-plus-source-expected.txt:
        * media/video-src-plus-source.html:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-test.js:
        (findMediaElement):
        (waitForEvent):
        (waitForEventAndTest):
        (relativeURL):
        * media/video-timeupdate-during-playback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Thu, 6 Aug 2009 20:50:53 +0000 (20:50 +0000)]
2009-08-06  Eric Seidel  <eric@webkit.org>

        No review, only changing make-js-test-wrappers.

        Fix make-js-test-wrappers to ignore a few more js tests
        with custom templates.

        * Scripts/make-js-test-wrappers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 6 Aug 2009 20:20:21 +0000 (20:20 +0000)]
2009-08-06  Eric Seidel  <eric@webkit.org>

        No review, only changing make-js-test-wrappers.

        Fix make-js-test-wrappers to ignore a few more js tests
        with custom templates.

        * Scripts/make-js-test-wrappers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
abarth@webkit.org [Thu, 6 Aug 2009 19:17:44 +0000 (19:17 +0000)]
2009-08-06  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct
        https://bugs.webkit.org/show_bug.cgi?id=27877

        Inherits PolymorphicAccessStructureList struct from FastAllocBase because it has been instantiated by
        'new' in JavaScriptCore/jit/JITStubs.cpp:1229.

        * bytecode/Instruction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 6 Aug 2009 18:49:41 +0000 (18:49 +0000)]
2009-08-06  Brent Fulgham  <bfulgham@webkit.org>

        Rubber-stamped by Adam Barth.

        Update my blog's address.

        * config.ini:  Update Blog address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Drew Wilson <atwilson@google.com>
atwilson@chromium.org [Thu, 6 Aug 2009 18:25:50 +0000 (18:25 +0000)]
2009-08-06  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Refactored worker tests to share code with shared worker versions. Shared worker tests are currently disabled by default.

        Worker layout tests should be refactored to enable testing SharedWorkers also.
        https://bugs.webkit.org/show_bug.cgi?id=27963

        * fast/workers/resources/shared-worker-common.js:
        (onconnect):
        (gc):
        (handleMessage):
        * fast/workers/resources/shared-worker-create-common.js: Added.
        (createWorker.worker.port.onmessage):
        (createWorker.worker.postMessage):
        (createWorker):
        * fast/workers/resources/worker-context-gc.js: Added.
        (log):
        (worker.onmessage):
        * fast/workers/resources/worker-create-common.js: Added.
        (createWorker):
        * fast/workers/resources/worker-location.js: Added.
        (log):
        (gc):
        (worker.onmessage):
        * fast/workers/resources/worker-navigator.js: Added.
        (log):
        (worker.onmessage):
        * fast/workers/resources/worker-replace-global-constructor.js:
        * fast/workers/resources/worker-replace-self.js: Added.
        (log):
        (worker.onmessage):
        * fast/workers/shared-worker-context-gc-expected.txt: Added.
        * fast/workers/shared-worker-context-gc.html-disabled: Added.
        * fast/workers/shared-worker-location-expected.txt: Added.
        * fast/workers/shared-worker-location.html-disabled: Added.
        * fast/workers/shared-worker-navigator-expected.txt: Added.
        * fast/workers/shared-worker-navigator.html-disabled: Added.
        * fast/workers/shared-worker-replace-global-constructor.html-disabled:
        * fast/workers/shared-worker-replace-self-expected.txt: Added.
        * fast/workers/shared-worker-replace-self.html-disabled: Added.
        * fast/workers/worker-context-gc.html:
        * fast/workers/worker-location.html:
        * fast/workers/worker-navigator.html:
        * fast/workers/worker-replace-global-constructor.html:
        * fast/workers/worker-replace-self.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 6 Aug 2009 18:02:18 +0000 (18:02 +0000)]
2009-08-06  Darin Adler  <darin@apple.com>

        Fix Mac Leopard debug build.

        * platform/text/StringImpl.cpp:
        (WebCore::equalIgnoringCase): Removed meaningless assertion; an unsigned
        is always >= 0 and checking causes a warning in the newer versions of gcc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Thu, 6 Aug 2009 16:43:15 +0000 (16:43 +0000)]
WebCore:

2009-08-06  Adam Barth  <abarth@webkit.org>

        Unreview rollout.

        Revert 46840 because it broke the reliability tests.

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::ScheduledAction):
        (WebCore::ScheduledAction::execute):
        * bindings/v8/ScheduledAction.h:
        (WebCore::ScheduledAction::ScheduledAction):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8Custom::WindowSetTimeoutImpl):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::SetTimeoutOrInterval):

LayoutTests:

2009-08-06  Adam Barth  <abarth@webkit.org>

        Unreviewed rollout.

        Revert 46840 because it broke the reliability tests.

        * http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Removed.
        * http/tests/security/isolatedWorld/window-setTimeout-function.html: Removed.
        * http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Removed.
        * http/tests/security/isolatedWorld/window-setTimeout-string.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 6 Aug 2009 16:43:04 +0000 (16:43 +0000)]
2009-08-06  Adam Barth  <abarth@webkit.org>

        Unreviewed rollout.

        Revert 46840 in preparation to revert 46838, which broke the reliability tests.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::updateDocumentWrapperCache):
        (WebCore::V8Proxy::initContextIfNeeded):
        (WebCore::V8Proxy::mainWorldContext):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 6 Aug 2009 16:37:54 +0000 (16:37 +0000)]
2009-08-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: move style-related utilities into InjectedScript.

        http://bugs.webkit.org/show_bug.cgi?id=27939

        * inspector/front-end/DOMAgent.js:
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit):
        (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands):
        (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties):
        (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.applyStyleText):
        (InjectedScript.toggleStyleEnabled):
        (InjectedScript._serializeStyle):
        (InjectedScript._getUniqueStyleProperties):
        (InjectedScript._getLonghandProperties):
        (InjectedScript._getShorthandPriority):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._update):
        (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
        (WebInspector.StylePropertiesSection.prototype.onpopulate):
        (WebInspector.StylePropertyTreeElement.prototype.get priority):
        (WebInspector.StylePropertyTreeElement.prototype.get value):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 6 Aug 2009 15:58:05 +0000 (15:58 +0000)]
2009-08-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Unreviewed build fix, add #ifdef guards around
        inclusions of shared worker specific files.

        * bindings/js/JSEventTarget.cpp:
        * bindings/js/JSWorkerContextBase.cpp:
        * bindings/js/WorkerScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Thu, 6 Aug 2009 15:57:56 +0000 (15:57 +0000)]
2009-08-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        cssgrammar.cpp fails to compile with RVCT compiler
        https://bugs.webkit.org/show_bug.cgi?id=27952

        * css/CSSGrammar.y: Do not convert to String to get rid of the stray
        memory allocation

        * platform/text/StringImpl.cpp:
        (WebCore::equalIgnoringCase):
        * platform/text/StringImpl.h:
        (WebCore::equalIgnoringCase): Add charactersEqualIgnoringCase
          function that works with a character pointer and length

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
atwilson@chromium.org [Thu, 6 Aug 2009 15:30:37 +0000 (15:30 +0000)]
WebCore:

2009-08-01  Drew Wilson  <atwilson@google.com>

        Reviewed by NOBODY (OOPS!).

        Created first working implementation of SharedWorkers (execution only, no sharing).
        https://bugs.webkit.org/show_bug.cgi?id=27927

        Added initial implementations of SharedWorkerThread and SharedWorkerContext.
        No v8 bindings yet.

        * DerivedSources.cpp:
        Added shared worker files.
        * DerivedSources.make:
        Added shared worker files.
        * GNUmakefile.am:
        Added shared worker files.
        * WebCore.gypi:
        Added shared worker files.
        * WebCore.pro:
        Added shared worker files.
        * WebCore.vcproj/WebCore.vcproj:
        Added shared worker files.
        * WebCore.xcodeproj/project.pbxproj:
        Added shared worker files.
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        Added code to convert from EventTarget to correct JS class.
        (WebCore::toEventTarget):
        Added code to cast from JS object to appropriate EventTarget impl class.
        * bindings/js/JSSharedWorkerConstructor.cpp:
        (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):
        (WebCore::constructSharedWorker):
        Tweaked the constructor code to pass in the lexical global object like normal workers.
        * bindings/js/JSSharedWorkerContextCustom.cpp: Added.
        (WebCore::JSSharedWorkerContext::mark):
        Custom marking of the onconnect handler.
        * bindings/js/JSWorkerContextBase.cpp:
        (WebCore::toJSSharedWorkerContext):
        (WebCore::toJSWorkerContext):
        Added proper conversion to the correct WorkerContext derived class.
        * bindings/js/JSWorkerContextBase.h:
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::initScript):
        Updated WorkerScriptController to create the correct type of binding object (JSSharedWorkerContext vs JSDedicatedWorkerContext)
        * bindings/scripts/CodeGeneratorV8.pm:
        Added support for SharedWorkerContext.
        * bindings/v8/DOMObjectsInclude.h:
        Added shared worker bindings files.
        * dom/EventNames.h:
        Added connect event.
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toSharedWorkerContext):
        Added API for casting to new derived class (SharedWorkerContext).
        * dom/EventTarget.h:
        * workers/AbstractWorker.cpp:
        (WebCore::AbstractWorker::resolveURL):
        Moved code that resolves/validates URLs to base class so it can be shared between dedicated/shared workers.
        * workers/AbstractWorker.h:
        * workers/DedicatedWorkerContext.cpp:
        (WebCore::DedicatedWorkerContext::logException):
        Refactored exception handling code - moved onerror handling to base class.
        * workers/DedicatedWorkerContext.h:
        (WebCore::DedicatedWorkerContext::isDedicatedWorkerContext):
        * workers/SharedWorker.cpp:
        (WebCore::SharedWorker::SharedWorker):
        Changed constructor to fire up worker thread.
        * workers/SharedWorker.h:
        * workers/SharedWorkerContext.cpp: Added.
        (WebCore::SharedWorkerContext::SharedWorkerContext):
        (WebCore::SharedWorkerContext::~SharedWorkerContext):
        (WebCore::SharedWorkerContext::logException):
        (WebCore::SharedWorkerContext::addMessage):
        Placeholder methods until we add support for sending exceptions/messages to console.
        (WebCore::SharedWorkerContext::dispatchConnect):
        (WebCore::SharedWorkerContext::thread):
        * workers/SharedWorkerContext.h: Added.
        (WebCore::SharedWorkerContext::create):
        (WebCore::SharedWorkerContext::isSharedWorkerContext):
        (WebCore::SharedWorkerContext::toSharedWorkerContext):
        (WebCore::SharedWorkerContext::setOnconnect):
        (WebCore::SharedWorkerContext::onconnect):
        (WebCore::SharedWorkerContext::name):
        * workers/SharedWorkerContext.idl: Added.
        * workers/SharedWorkerRepository.h: Added.
        (WebCore::SharedWorkerRepository::~SharedWorkerRepository):
        * workers/DefaultSharedWorkerRepository.cpp: Added.
        Implementation of core singleton class that will be used to implement sharing.
        (WebCore::SharedWorkerProxy::setThread):
        Proxy object used to handle resource loading for a given shared worker.
        (WebCore::SharedWorkerProxy::postTaskToLoader):
        (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
        Placeholder routines until we implement loading.
        (WebCore::SharedWorkerConnectTask::create):
        Creates a task to fire off a connect event on the worker thread.
        (WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):
        (WebCore::SharedWorkerConnectTask::performTask):
        (WebCore::SharedWorkerLoader::SharedWorkerLoader):
        Added helper object to load the initial script for the worker.
        (WebCore::SharedWorkerLoader::load):
        (WebCore::SharedWorkerLoader::notifyFinished):
        (WebCore::SharedWorkerRepository::instance):
        (WebCore::DefaultSharedWorkerRepository::instance):
        (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
        Fires off the worker thread once the script is loaded.
        (WebCore::SharedWorkerRepository::connect):
        (WebCore::DefaultSharedWorkerRepository::DefaultSharedWorkerRepository):
        (WebCore::DefaultSharedWorkerRepository::~DefaultSharedWorkerRepository):
        * workers/DefaultSharedWorkerRepository.h: Added.
        * workers/SharedWorkerThread.cpp: Added.
        (WebCore::SharedWorkerThread::create):
        (WebCore::SharedWorkerThread::SharedWorkerThread):
        (WebCore::SharedWorkerThread::~SharedWorkerThread):
        (WebCore::SharedWorkerThread::createWorkerContext):
        * workers/SharedWorkerThread.h: Added.
        * workers/Worker.cpp:
        (WebCore::Worker::Worker):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::reportException):
        * workers/WorkerContext.h:
        (WebCore::WorkerContext::isSharedWorkerContext):
        (WebCore::WorkerContext::isDedicatedWorkerContext):
        Added APIs to determine the type of a given context.

LayoutTests:

2009-08-05  Drew Wilson  <atwilson@google.com>

        Reviewed by NOBODY (OOPS!).

        SharedWorkers should instantiate a thread and a SharedWorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=27927

        Added disabled tests for SharedWorker minimal functionality.

        Began refactoring of dedicated worker tests to allow sharing test cases between shared and dedicated worker (will continue in another patch).

        * fast/workers/resources/shared-worker-common.js: Added.
        * fast/workers/resources/shared-worker-script-error.js: Added.
        * fast/workers/resources/worker-replace-global-constructor.js: Moved common code into shared .js file.
        * fast/workers/shared-worker-constructor.html-disabled:
        * fast/workers/shared-worker-gc-expected.txt: Added.
        * fast/workers/shared-worker-gc.html-disabled: Added.
        * fast/workers/shared-worker-load-error-expected.txt: Added.
        * fast/workers/shared-worker-load-error.html-disabled: Added.
        * fast/workers/shared-worker-replace-global-constructor-expected.txt: Added.
        * fast/workers/shared-worker-replace-global-constructor.html-disabled: Added.
        * fast/workers/shared-worker-script-error-expected.txt: Added.
        * fast/workers/shared-worker-script-error.html-disabled: Added.
        * fast/workers/shared-worker-simple-expected.txt: Added.
        * fast/workers/shared-worker-simple.html-disabled: Added.
        * fast/workers/worker-replace-global-constructor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46845 268f45cc-cd09-0410-ab3c-d52691b4dbfc