WebKit-https.git
4 months agoCodeBlock::m_instructionCount is wrong
sbarati@apple.com [Tue, 30 Apr 2019 23:37:27 +0000 (23:37 +0000)]
CodeBlock::m_instructionCount is wrong
https://bugs.webkit.org/show_bug.cgi?id=197304

Reviewed by Yusuke Suzuki.

What we were calling instructionCount() was wrong, as evidenced by
us using it incorrectly both in the sampling profiler and when we
dumped bytecode for a given CodeBlock. Prior to the bytecode rewrite,
instructionCount() was probably valid to do bounds checks against.
However, this is no longer the case. This patch renames what we called
instructionCount() to bytecodeCost(). It is now only used to make decisions
about inlining and tier up heuristics. I've also named options related to
this appropriately.

This patch also introduces instructionsSize(). The result of this method
is valid to do bounds checks against.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType const):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::CodeBlock::predictedMachineCodeSize):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::instructionsSize const):
(JSC::CodeBlock::bytecodeCost const):
(JSC::CodeBlock::instructionCount const): Deleted.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::getInliningBalance):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):
* dfg/DFGCapabilities.h:
(JSC::DFG::isSmallEnoughToInlineCodeInto):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpHeader):
* dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
* dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLCompile.cpp:
(JSC::FTL::compile):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* jit/JIT.cpp:
(JSC::JIT::link):
* jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dumpHeader):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::shouldJIT):
* profiler/ProfilerBytecodes.cpp:
(JSC::Profiler::Bytecodes::Bytecodes):
* runtime/Options.h:
* runtime/SamplingProfiler.cpp:
(JSC::tryGetBytecodeIndex):
(JSC::SamplingProfiler::processUnverifiedStackTraces):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoimported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.htm is a flaky...
sroberts@apple.com [Tue, 30 Apr 2019 22:49:04 +0000 (22:49 +0000)]
imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.htm is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=182849

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations: Updating expectations for flaky failure on iOS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoTypeArrays should not store properties that are canonical numeric indices
tzagallo@apple.com [Tue, 30 Apr 2019 22:25:09 +0000 (22:25 +0000)]
TypeArrays should not store properties that are canonical numeric indices
https://bugs.webkit.org/show_bug.cgi?id=197228
<rdar://problem/49557381>

Reviewed by Darin Adler.

JSTests:

* stress/typed-array-canonical-numeric-index-string.js: Added.
(makeTest.assert):
(makeTest):
(const.testInvalidIndices.makeTest.set assert):
(const.testInvalidIndices.makeTest):
(const.testValidIndices.makeTest.set assert):
(const.testValidIndices.makeTest):

Source/JavaScriptCore:

According to the spec[1], TypedArrays should not perform an ordinary GetOwnProperty/SetOwnProperty
if the index is a CanonicalNumericIndexString, but invalid according toIntegerIndexedElementGet
and similar functions. I.e., there are a few properties that should not be set in a TypedArray,
like NaN, Infinity and -0.

[1]: https://www.ecma-international.org/ecma-262/9.0/index.html#sec-integer-indexed-exotic-objects-defineownproperty-p-desc

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex):
* runtime/JSTypedArrays.cpp:
* runtime/PropertyName.h:
(JSC::canonicalNumericIndexString):

LayoutTests:

* fast/canvas/canvas-ImageData-behaviour-expected.txt:
* fast/canvas/canvas-ImageData-behaviour.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUpdate Spanish Translation
mcatanzaro@igalia.com [Tue, 30 Apr 2019 22:12:11 +0000 (22:12 +0000)]
Update Spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=197407

Patch by Álvaro Torralba <donfrutosgomez@gmail.com> on 2019-04-30
Rubber-stamped by Michael Catanzaro.

* es.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRegression(PSON) URL scheme handlers can no longer respond asynchronously
cdumez@apple.com [Tue, 30 Apr 2019 21:11:07 +0000 (21:11 +0000)]
Regression(PSON) URL scheme handlers can no longer respond asynchronously
https://bugs.webkit.org/show_bug.cgi?id=197426
<rdar://problem/50256169>

Reviewed by Brady Eidson.

Source/WebKit:

The issue was that when committing the provisional process, we would call WebPageProxy::processDidTerminate()
which would call WebPageProxy::stopAllURLSchemeTasks(). This would terminate all URL scheme tasks associated
with the page, including the one associated with the provisisional page / process.

To address the issue, pass m_process to stopAllURLSchemeTasks() in processDidTerminate() and only stop the
tasks associated with the m_process (which is the process we're about to swap away from).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidTerminate):
(WebKit::WebPageProxy::stopAllURLSchemeTasks):
* UIProcess/WebPageProxy.h:
* UIProcess/WebURLSchemeHandler.cpp:
(WebKit::WebURLSchemeHandler::processForTaskIdentifier):
(WebKit::WebURLSchemeHandler::stopAllTasksForPage):
* UIProcess/WebURLSchemeHandler.h:
* UIProcess/WebURLSchemeTask.h:
(WebKit::WebURLSchemeTask::process const):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONScheme setShouldRespondAsynchronously:]):
(-[PSONScheme webView:startURLSchemeTask:]):
(-[PSONScheme webView:stopURLSchemeTask:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244773.
commit-queue@webkit.org [Tue, 30 Apr 2019 20:21:11 +0000 (20:21 +0000)]
Unreviewed, rolling out r244773.
https://bugs.webkit.org/show_bug.cgi?id=197436

Causing assertion failures on debug queues (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Make Document audio producers use WeakPtr"
https://bugs.webkit.org/show_bug.cgi?id=197382
https://trac.webkit.org/changeset/244773

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoTransform is sometimes left in a bad state after an animation
simon.fraser@apple.com [Tue, 30 Apr 2019 20:20:37 +0000 (20:20 +0000)]
Transform is sometimes left in a bad state after an animation
https://bugs.webkit.org/show_bug.cgi?id=197401
rdar://problem/48179186

Reviewed by Dean Jackson.

Source/WebCore:

In some more complex compositing scenarios, at the end of an animation we'd
fail to push a new transform onto a layer, because updateGeometry() would
think there's an animation running (which there is, but in the "Ending" state).

It's simpler in this code to just always push transform and opacity to the layer;
they will get overridden by the animation while it's running. The current code
dates from the first landing of the file, and the reason for the if (!isRunningAcceleratedTransformAnimation)
check is lost in the sands of time.

I was not able to get a reliable ref or layer tree test for this, because the next compositing update
fixes it, and WTR seems to trigger one.  But the added test does show the bug
in Safari, and is a good test to have.

Test: compositing/animation/transform-after-animation.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):

LayoutTests:

Share code between all the overlap tests that work by creating dot matrices, and strip
out the transforms from the layer tree dumps, because they can vary with timing in these
tests.

* compositing/animation/transform-after-animation-expected.html: Added.
* compositing/animation/transform-after-animation.html: Added.
* compositing/backing/backing-store-attachment-empty-keyframe-expected.txt:
* compositing/layer-creation/animation-overlap-with-children.html:
* compositing/layer-creation/mismatched-rotated-transform-animation-overlap-expected.txt:
* compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html:
* compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html:
* compositing/layer-creation/mismatched-transform-transition-overlap.html:
* compositing/layer-creation/multiple-keyframes-animation-overlap-expected.txt:
* compositing/layer-creation/multiple-keyframes-animation-overlap.html:
* compositing/layer-creation/resources/compositing-overlap-utils.js: Added.
(makeDots):
(layerTreeWithoutTransforms):
(dumpLayers):
* compositing/layer-creation/scale-rotation-animation-overlap-expected.txt:
* compositing/layer-creation/scale-rotation-animation-overlap.html:
* compositing/layer-creation/scale-rotation-transition-overlap.html:
* compositing/layer-creation/translate-animation-overlap-expected.txt:
* compositing/layer-creation/translate-animation-overlap.html:
* compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* compositing/layer-creation/translate-scale-animation-overlap.html:
* compositing/layer-creation/translate-scale-transition-overlap.html:
* compositing/layer-creation/translate-transition-overlap.html:
* legacy-animation-engine/compositing/backing/backing-store-attachment-empty-keyframe-expected.txt:
* legacy-animation-engine/compositing/backing/backing-store-attachment-empty-keyframe.html:
* legacy-animation-engine/compositing/backing/transform-transition-from-outside-view-expected.txt:
* legacy-animation-engine/compositing/layer-creation/animation-overlap-with-children.html:
* legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-animation-overlap.html:
* legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-transition-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/mismatched-rotated-transform-transition-overlap.html:
* legacy-animation-engine/compositing/layer-creation/mismatched-transform-transition-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/mismatched-transform-transition-overlap.html:
* legacy-animation-engine/compositing/layer-creation/multiple-keyframes-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/multiple-keyframes-animation-overlap.html:
* legacy-animation-engine/compositing/layer-creation/scale-rotation-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/scale-rotation-animation-overlap.html:
* legacy-animation-engine/compositing/layer-creation/scale-rotation-transition-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/scale-rotation-transition-overlap.html:
* legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-animation-overlap.html:
* legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap.html:
* legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap.html:
* legacy-animation-engine/compositing/layer-creation/translate-transition-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html:
* platform/ios/compositing/layer-creation/scale-rotation-animation-overlap-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoOnly use a related page's process if that page has not been closed yet
cdumez@apple.com [Tue, 30 Apr 2019 20:20:00 +0000 (20:20 +0000)]
Only use a related page's process if that page has not been closed yet
https://bugs.webkit.org/show_bug.cgi?id=197393
<rdar://problem/50302423>

Reviewed by Tim Horton.

Source/WebKit:

We should not attempt to use a related page's process if that related page has already been closed.
Once closed, a page's process is invalid and trying to launch a new process for the closed page
leads to crashes such as the one in the radar.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcess):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createWebPage):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244774.
commit-queue@webkit.org [Tue, 30 Apr 2019 20:09:44 +0000 (20:09 +0000)]
Unreviewed, rolling out r244774.
https://bugs.webkit.org/show_bug.cgi?id=197431

Causing assertion failures on debug queues (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Reject/throw when calling AudioContext methods on a stopped
AudioContext"
https://bugs.webkit.org/show_bug.cgi?id=197391
https://trac.webkit.org/changeset/244774

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd WKContentRuleList ping resource-type
achristensen@apple.com [Tue, 30 Apr 2019 19:42:34 +0000 (19:42 +0000)]
Add WKContentRuleList ping resource-type
https://bugs.webkit.org/show_bug.cgi?id=197325
<rdar://problem/49841404>

Reviewed by Geoff Garen.

Source/WebCore:

Tests: http/tests/contentextensions/block-ping-resource-type-ping.html and http/tests/contentextensions/block-ping-resource-type-raw.html

* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
* contentextensions/ContentExtensionsBackend.h:
* loader/PingLoader.cpp:
(WebCore::processContentRuleListsForLoad):
(WebCore::PingLoader::sendPing):
* loader/ResourceLoadInfo.cpp:
(WebCore::ContentExtensions::readResourceType):
(WebCore::ContentExtensions::ResourceLoadInfo::getResourceFlags const):
* loader/ResourceLoadInfo.h:
* page/UserContentProvider.cpp:
(WebCore::UserContentProvider::processContentRuleListsForLoad):
* page/UserContentProvider.h:

LayoutTests:

* http/tests/contentextensions/block-ping-resource-type-raw--expected.txt: Copied from LayoutTests/http/tests/contentextensions/block-ping-expected.txt.
* http/tests/contentextensions/block-ping-resource-type-raw.html: Copied from LayoutTests/http/tests/contentextensions/block-ping.html.
* http/tests/contentextensions/block-ping-resource-type-raw.html.json: Copied from LayoutTests/http/tests/contentextensions/block-ping.html.json.
* http/tests/contentextensions/block-ping-resource-type-ping-expected.txt: Copied from LayoutTests/http/tests/contentextensions/block-ping-expected.txt.
* http/tests/contentextensions/block-ping-resource-type-ping.html: Copied from LayoutTests/http/tests/contentextensions/block-ping.html.
* http/tests/contentextensions/block-ping-resource-type-ping.html.json: Copied from LayoutTests/http/tests/contentextensions/block-ping.html.json.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[ews-build] Enable Bindings tests queue on new EWS
aakash_jain@apple.com [Tue, 30 Apr 2019 18:42:38 +0000 (18:42 +0000)]
[ews-build] Enable Bindings tests queue on new EWS
https://bugs.webkit.org/show_bug.cgi?id=197424

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
* BuildSlaveSupport/ews-build/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Automation: use a more informative key to indicate automation availability
bburg@apple.com [Tue, 30 Apr 2019 18:38:16 +0000 (18:38 +0000)]
Web Automation: use a more informative key to indicate automation availability
https://bugs.webkit.org/show_bug.cgi?id=197377
<rdar://problem/50258069>

Reviewed by Devin Rousso.

The existing WIRAutomationEnabledKey does not encode uncertainty.
Add a new key that provides an 'Unknown' state, and prefer to use it.

Since an application's initial listing is sent from a background dispatch queue
on Cocoa platforms, this can race with main thread initialization that sets up
RemoteInspector::Client. Therefore, the initial listing may not properly represent
the client's capabilites because the client is not yet available. Allowing for
an "Unknown" state that is later upgraded to Available or Not Available makes it
possible to work around this potential race.

* inspector/remote/RemoteInspectorConstants.h:
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::pushListingsNow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[ews-build] Configure ews151 for running various tests
aakash_jain@apple.com [Tue, 30 Apr 2019 18:35:03 +0000 (18:35 +0000)]
[ews-build] Configure ews151 for running various tests
https://bugs.webkit.org/show_bug.cgi?id=197419

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[ews-build] Parse and display bindings test failures
aakash_jain@apple.com [Tue, 30 Apr 2019 18:33:30 +0000 (18:33 +0000)]
[ews-build] Parse and display bindings test failures
https://bugs.webkit.org/show_bug.cgi?id=197423

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(RunBindingsTests.__init__): Set timeout of 5 minutes.
(RunBindingsTests.start): Initialize log_observer for json output.
(RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
(RunBindingsTests._addToLog): Method to add message to log.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFixing typo in https://trac.webkit.org/changeset/244780/webkit.
sroberts@apple.com [Tue, 30 Apr 2019 18:27:58 +0000 (18:27 +0000)]
Fixing typo in https://trac.webkit.org/changeset/244780/webkit.

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoscrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky...
sroberts@apple.com [Tue, 30 Apr 2019 18:18:04 +0000 (18:18 +0000)]
scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197425

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Updating expectations for flaky failure

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix failing ARM64E wasm tests
keith_miller@apple.com [Tue, 30 Apr 2019 17:57:48 +0000 (17:57 +0000)]
Fix failing ARM64E wasm tests
https://bugs.webkit.org/show_bug.cgi?id=197420

Reviewed by Saam Barati.

This patch fixes a bug in the slow path of our JS->Wasm IC bridge
where we wouldn't untag the link register before tail calling.

Additionally, this patch fixes a broken assert when using setting
Options::useTailCalls=false.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallForwardArgumentsInTailPosition):
* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix the build after r244777.
aestes@apple.com [Tue, 30 Apr 2019 17:51:47 +0000 (17:51 +0000)]
Fix the build after r244777.

* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoLong-standing rare crash under -[WKWebView _web_immediateActionAnimationControllerFor...
timothy_horton@apple.com [Tue, 30 Apr 2019 17:37:47 +0000 (17:37 +0000)]
Long-standing rare crash under -[WKWebView _web_immediateActionAnimationControllerForHitTestResultInternal...]
https://bugs.webkit.org/show_bug.cgi?id=197404
<rdar://problem/24589331>

Reviewed by Wenson Hsieh.

* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _updateImmediateActionItem]):
(-[WKImmediateActionController menuItem:previewItemAtPoint:]):
(-[WKImmediateActionController menuItem:itemFrameForPoint:]):
(-[WKImmediateActionController _animationControllerForDataDetectedLink]):
Add some null checks; _webHitTestResult can be null if we (somehow) get
an immediate action gesture without having previously gotten a
mouseDidMoveOverElement from the Web Content process. Cover all our bases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoanimations/play-state-in-shorthand.html is a flaky failure
sroberts@apple.com [Tue, 30 Apr 2019 17:08:54 +0000 (17:08 +0000)]
animations/play-state-in-shorthand.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=192501

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations: Updating expectations for flaky failure
* platform/mac/TestExpectations: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[iOS] Fix crash caused by sandbox violation
pvollan@apple.com [Tue, 30 Apr 2019 16:40:08 +0000 (16:40 +0000)]
[iOS] Fix crash caused by sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=197416
<rdar://problem/50266257>

Reviewed by Brent Fulgham.

Add syscall to the iOS sandbox.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed. Add myself as a committer.
psaavedra@igalia.com [Tue, 30 Apr 2019 16:34:29 +0000 (16:34 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[WebGPU] Move 'gpu' API entry point from DOMWindow to Navigator
justin_fan@apple.com [Tue, 30 Apr 2019 16:33:35 +0000 (16:33 +0000)]
[WebGPU] Move 'gpu' API entry point from DOMWindow to Navigator
https://bugs.webkit.org/show_bug.cgi?id=197348

Reviewed by Myles C. Maxfield.

Source/WebCore:

Latest API provides 'gpu' through Navigator instead of DOMWindow. Replace DOMWindowWebGPU with NavigatorGPU.

Existing tests updated to match. Add test: webgpu-enabled-in-worker.html to ensure workers can access WebGPU.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/webgpu/NavigatorGPU.cpp:
(WebCore::NavigatorGPU::from):
(WebCore::NavigatorGPU::supplementName):
(WebCore::NavigatorGPU::gpu):
(WebCore::NavigatorGPU::gpu const):
* Modules/webgpu/NavigatorGPU.h:
* Modules/webgpu/NavigatorGPU.idl:
* Modules/webgpu/WorkerNavigatorGPU.cpp:
(WebCore::WorkerNavigatorGPU::from):
(WebCore::WorkerNavigatorGPU::supplementName):
(WebCore::WorkerNavigatorGPU::gpu):
(WebCore::WorkerNavigatorGPU::gpu const):
* Modules/webgpu/WorkerNavigatorGPU.h:
* Modules/webgpu/WorkerNavigatorGPU.idl:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

WebGPU is now accessed through navigator.gpu instead of window.gpu.
Add webgpu-enabled-in-worker to ensure workers can access WebGPU.

* webgpu/adapter-options.html:
* webgpu/js/create-worker-device.js: Added.
(async.tryCreateDevice):
* webgpu/js/webgpu-functions.js:
(async.getBasicDevice):
* webgpu/queue-creation.html:
* webgpu/webgpu-enabled-in-worker-expected.txt: Added.
* webgpu/webgpu-enabled-in-worker.html: Added.
* webgpu/webgpu-enabled.html:
* webgpu/whlsl.html:

Add navigator.gpu to expectations for navigator-detached-no-crash.
* fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac-highsierra/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUpdate WPT service-worker resource-timing test to use hosts[alt]
youenn@apple.com [Tue, 30 Apr 2019 16:23:20 +0000 (16:23 +0000)]
Update WPT service-worker resource-timing test to use hosts[alt]
https://bugs.webkit.org/show_bug.cgi?id=197329

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Set alt server as 127.0.0.1.
Use hosts[alt][] instead of domains[www] to trigger a cross origin load.

* resources/config.json:
* web-platform-tests/service-workers/service-worker/resource-timing.https-expected.txt: Removed.
* web-platform-tests/service-workers/service-worker/resource-timing.sub.https-expected.txt: Added.
* web-platform-tests/service-workers/service-worker/resource-timing.sub.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resource-timing.https.html.
* web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.sub.html:

LayoutTests:

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoSource/WebCore:
zalan@apple.com [Tue, 30 Apr 2019 16:07:48 +0000 (16:07 +0000)]
Source/WebCore:
Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347
<rdar://problem/49393423>

Reviewed by Wenson Hsieh.

Tests: fast/events/touch/ios/double-tap-for-double-click1.html
       fast/events/touch/ios/double-tap-for-double-click2.html

* page/Frame.h:
* page/ios/FrameIOS.mm:
(WebCore::Frame::nodeRespondingToDoubleClickEvent):

Source/WebKit:
[iOS] Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347
<rdar://problem/49393423>

Reviewed by Wenson Hsieh.

This patch adds support for dispatching dblclick event as the result of the double tap gesture.

1. The new double tap gesture recognizer always fires regardless of what type of action the other, existing double gesture recognizers (double-tap to zoom) trigger.
2. The dblclick event is dispatched on the node with registered dblclick event handler unless the node prohibits double tap gesture (touch-action != auto).

* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):

LayoutTests:
Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347
<rdar://problem/49393423>

Reviewed by Wenson Hsieh.

* fast/events/touch/ios/double-tap-for-double-click1-expected.txt: Added.
* fast/events/touch/ios/double-tap-for-double-click1.html: Added.
* fast/events/touch/ios/double-tap-for-double-click2-expected.txt: Added.
* fast/events/touch/ios/double-tap-for-double-click2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoReject/throw when calling AudioContext methods on a stopped AudioContext
youenn@apple.com [Tue, 30 Apr 2019 15:17:07 +0000 (15:17 +0000)]
Reject/throw when calling AudioContext methods on a stopped AudioContext
https://bugs.webkit.org/show_bug.cgi?id=197391

Reviewed by Eric Carlson.

Source/WebCore:

Return InvalidStateError in that case.
ASSERT that we do not call lazyInitialize after being stopped
since this would mean we are doing unneeded processing.

Test: http/wpt/webaudio/audiocontext-stopped.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::createBufferSource):
(WebCore::AudioContext::createMediaElementSource):
(WebCore::AudioContext::createMediaStreamSource):
(WebCore::AudioContext::createMediaStreamDestination):
(WebCore::AudioContext::createScriptProcessor):
(WebCore::AudioContext::createBiquadFilter):
(WebCore::AudioContext::createWaveShaper):
(WebCore::AudioContext::createPanner):
(WebCore::AudioContext::createConvolver):
(WebCore::AudioContext::createDynamicsCompressor):
(WebCore::AudioContext::createAnalyser):
(WebCore::AudioContext::createGain):
(WebCore::AudioContext::createDelay):
(WebCore::AudioContext::createChannelSplitter):
(WebCore::AudioContext::createChannelMerger):
(WebCore::AudioContext::createOscillator):
(WebCore::AudioContext::createPeriodicWave):
(WebCore::AudioContext::startRendering):
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioContext.idl:

LayoutTests:

* http/wpt/webaudio/audiocontext-stopped-expected.txt: Added.
* http/wpt/webaudio/audiocontext-stopped.html: Added.
* http/wpt/webaudio/resources/audiocontext-stopped-iframe.html: Added.
* platform/win/TestExpectations: Skip test for win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoMake Document audio producers use WeakPtr
youenn@apple.com [Tue, 30 Apr 2019 15:16:11 +0000 (15:16 +0000)]
Make Document audio producers use WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=197382

Reviewed by Eric Carlson.

Source/WebCore:

Move from a hash set of raw pointers to a hash set of weak pointers.
This helps make the code cleaner.
No observable change of behavior.

* Modules/mediastream/MediaStreamTrack.h:
* dom/Document.cpp:
(WebCore::Document::addAudioProducer):
(WebCore::Document::removeAudioProducer):
(WebCore::Document::updateIsPlayingMedia):
(WebCore::Document::pageMutedStateDidChange):
* dom/Document.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
* html/HTMLMediaElement.h:
* page/MediaProducer.h:

Source/WTF:

* wtf/WeakHashSet.h:
(WTF::WeakHashSet::hasNullReferences const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoTighten type of ScrollingTree:rootNode() to ScrollingTreeFrameScrollingNode
antti@apple.com [Tue, 30 Apr 2019 15:12:26 +0000 (15:12 +0000)]
Tighten type of ScrollingTree:rootNode() to ScrollingTreeFrameScrollingNode
https://bugs.webkit.org/show_bug.cgi?id=197414

Reviewed by Frédéric Wang.

Source/WebCore:

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::mainFrameViewportChangedViaDelegatedScrolling):
(WebCore::ScrollingTree::updateTreeFromStateNode):
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::rootNode const):

Source/WebKit:

* UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRefactor AudioContext to register/unregister itself at construction/destruction time
youenn@apple.com [Tue, 30 Apr 2019 15:03:38 +0000 (15:03 +0000)]
Refactor AudioContext to register/unregister itself at construction/destruction time
https://bugs.webkit.org/show_bug.cgi?id=197383

Reviewed by Eric Carlson.

Registering/Unregistering is cheap.
Instead of registering/unregistering in initialize/uninitialize,
move this code to constructor/destructor.
No observable change of behavior.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::visibilityStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[ews-build] Enable webkitpy queue on new EWS
aakash_jain@apple.com [Tue, 30 Apr 2019 15:01:05 +0000 (15:01 +0000)]
[ews-build] Enable webkitpy queue on new EWS
https://bugs.webkit.org/show_bug.cgi?id=197396

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
* BuildSlaveSupport/ews-build/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[ews-build] Parse and display webkitpy failures
aakash_jain@apple.com [Tue, 30 Apr 2019 14:51:13 +0000 (14:51 +0000)]
[ews-build] Parse and display webkitpy failures
https://bugs.webkit.org/show_bug.cgi?id=197395

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitPyTests.start): Initialize log_observer for json output.
(RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
(RunWebKitPyTests._addToLog): Method to add message to log.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWebCore::StyleColorScheme should not have explicitly-declared copy constructor
mcatanzaro@igalia.com [Tue, 30 Apr 2019 14:32:43 +0000 (14:32 +0000)]
WebCore::StyleColorScheme should not have explicitly-declared copy constructor
https://bugs.webkit.org/show_bug.cgi?id=197412

Reviewed by Don Olmstead.

Either we need to explicitly declare a copy assignment operator here, or the copy
constructor needs to be removed. Having one without the other causes a huge warning spam
with GCC 9. In this case, the copy constructor is redundant because it's identical to an
implicitly-declared copy constructor, so let's just remove it.

* rendering/style/StyleColorScheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoREGRESSION(r244750): [GTK][WPE] Network process is crashing in all layout tests
carlosgc@webkit.org [Tue, 30 Apr 2019 11:00:30 +0000 (11:00 +0000)]
REGRESSION(r244750): [GTK][WPE] Network process is crashing in all layout tests
https://bugs.webkit.org/show_bug.cgi?id=197406

Reviewed by Žan Doberšek.

Do not trasnfer ownership of cachePath to traverseDirectory() lambda, since it's passed also as first argument
and it can be passed as a reference.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::deleteOldVersions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[GTK] Support prefers-color-scheme media query
carlosgc@webkit.org [Tue, 30 Apr 2019 09:06:23 +0000 (09:06 +0000)]
[GTK] Support prefers-color-scheme media query
https://bugs.webkit.org/show_bug.cgi?id=196685

Reviewed by Michael Catanzaro.

.:

Enable DARK_MODE_CSS. Supported color schemes feature is not supported for now. I'm not sure we will be able to
suport it, because it requires to change the theme too many times, which is very slow in GTK.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

Change the gtk-application-prefer-dark-theme setting when tests change the useDarkModeAppearance setting.

* PlatformGTK.cmake:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::resetToConsistentState):
(WebCore::InternalSettings::setUseDarkAppearanceInternal):
(WebCore::InternalSettings::setUseDarkAppearance):
* testing/InternalSettings.h:

LayoutTests:

Unskip css-dark-mode tests and add platform specific results for some of the tests using the supported color
scheme feature.

* platform/gtk/TestExpectations:
* platform/gtk/css-dark-mode/color-scheme-css-expected.txt: Added.
* platform/gtk/css-dark-mode/color-scheme-meta-expected.txt: Added.
* platform/gtk/css-dark-mode/default-colors-expected.txt: Added.
* platform/gtk/css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Added.
* platform/gtk/css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Added.
* platform/gtk/css-dark-mode/prefers-color-scheme-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed GTK gardening. Rebaseline tests after r244635.
carlosgc@webkit.org [Tue, 30 Apr 2019 09:04:15 +0000 (09:04 +0000)]
Unreviewed GTK gardening. Rebaseline tests after r244635.

* platform/gtk/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/gtk/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/gtk/fast/forms/basic-inputs-expected.png:
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/basic-textareas-expected.png:
* platform/gtk/fast/forms/basic-textareas-expected.txt:
* platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
* platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
* platform/gtk/fast/forms/disabled-select-change-index-expected.png:
* platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
* platform/gtk/fast/forms/file/file-input-disabled-expected.png:
* platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
* platform/gtk/fast/forms/input-appearance-disabled-expected.png:
* platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
* platform/gtk/fast/forms/input-disabled-color-expected.png:
* platform/gtk/fast/forms/input-disabled-color-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoMake JITType an enum class
sbarati@apple.com [Tue, 30 Apr 2019 03:27:39 +0000 (03:27 +0000)]
Make JITType an enum class
https://bugs.webkit.org/show_bug.cgi?id=197394

Reviewed by Yusuke Suzuki.

This makes the code more easily searchable.

* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType const):
(JSC::CodeBlock::specialOSREntryBlockOrNull):
(JSC::timeToLive):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::baselineAlternative):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::noticeIncomingCall):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::frameRegisterCount):
(JSC::CodeBlock::bytecodeOffsetFromCallSiteIndex):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::jitType const):
(JSC::CodeBlock::hasBaselineJITProfiling const):
* bytecode/CodeBlockWithJITType.h:
(JSC::CodeBlockWithJITType::CodeBlockWithJITType):
* bytecode/DeferredSourceDump.cpp:
(JSC::DeferredSourceDump::DeferredSourceDump):
* bytecode/DeferredSourceDump.h:
* bytecode/ExitingJITType.h:
(JSC::exitingJITTypeFor):
* bytecode/InlineCallFrame.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpHeader):
* dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::checkIfOptimizationThresholdReached):
(JSC::DFG::JITCode::optimizeNextInvocation):
(JSC::DFG::JITCode::dontOptimizeAnytimeSoon):
(JSC::DFG::JITCode::optimizeAfterWarmUp):
(JSC::DFG::JITCode::optimizeSoon):
(JSC::DFG::JITCode::forceOptimizationSlowPathConcurrently):
(JSC::DFG::JITCode::setOptimizationThresholdBasedOnCompilationResult):
* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
(JSC::DFG::prepareCatchOSREntry):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::OSRExit::compileOSRExit):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
* dfg/DFGOSRExitCompilerCommon.h:
(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):
* dfg/DFGOperations.cpp:
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct const):
* ftl/FTLCompile.cpp:
(JSC::FTL::compile):
* ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeCommon):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
* ftl/FTLThunks.cpp:
(JSC::FTL::genericGenerationThunkGenerator):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::callSiteBitsAreBytecodeOffset const):
(JSC::CallFrame::callSiteBitsAreCodeOriginIndex const):
* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::dump const):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::AssemblyHelpers):
* jit/JIT.cpp:
(JSC::JIT::link):
* jit/JITCode.cpp:
(JSC::JITCode::typeName):
(WTF::printInternal):
* jit/JITCode.h:
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JSC::JITCode::isExecutableScript):
(JSC::JITCode::couldBeInterpreted):
(JSC::JITCode::isJIT):
(JSC::JITCode::isOptimizingJIT):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::jitTypeFor):
* jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dumpHeader):
* jit/JITOperations.cpp:
* jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITToDFGDeferredCompilationCallback.cpp:
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
* jit/JITWorklist.cpp:
(JSC::JITWorklist::compileLater):
(JSC::JITWorklist::compileNow):
* jit/Repatch.cpp:
(JSC::readPutICCallTarget):
(JSC::ftlThunkAwareRepatchCall):
* llint/LLIntEntrypoint.cpp:
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
(JSC::LLInt::setModuleProgramEntrypoint):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::processUnverifiedStackTraces):
* runtime/SamplingProfiler.h:
* runtime/VM.cpp:
(JSC::jitCodeForCallTrampoline):
(JSC::jitCodeForConstructTrampoline):
* tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
* tools/JSDollarVM.cpp:
(JSC::CallerFrameJITTypeFunctor::CallerFrameJITTypeFunctor):
(JSC::CallerFrameJITTypeFunctor::jitType):
(JSC::functionLLintTrue):
(JSC::functionJITTrue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreivewed, fix FTL implementation of r244760
ysuzuki@apple.com [Tue, 30 Apr 2019 02:54:08 +0000 (02:54 +0000)]
Unreivewed, fix FTL implementation of r244760
https://bugs.webkit.org/show_bug.cgi?id=197362

Reviewed by Saam Barati.

Looked with Saam. ValueFromBlock from double case block was overridden by NaN thing now.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244755.
tsavell@apple.com [Mon, 29 Apr 2019 23:55:51 +0000 (23:55 +0000)]
Unreviewed, rolling out r244755.

Casued several test failures on iOS

Reverted changeset:

"Double-tapping a post to like doesn't work on Instagram.com
(needs 'dblclick' event)"
https://bugs.webkit.org/show_bug.cgi?id=197347
https://trac.webkit.org/changeset/244755

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[iOS] The UIProcess may get killed for trying to stay runnable in the background...
cdumez@apple.com [Mon, 29 Apr 2019 22:40:48 +0000 (22:40 +0000)]
[iOS] The UIProcess may get killed for trying to stay runnable in the background for more than 30 seconds
https://bugs.webkit.org/show_bug.cgi?id=197385
<rdar://problem/50001505>

Reviewed by Geoffrey Garen.

If the UIProcess holds a background assertion for itself for 30 seconds, the assertion's invalidation handler
will get called and it is our responsibility to release this assertion or the UIProcess will get killed by the
system. The logic in ProcessAssertion would normally do that but it would also happily try and re-take another
background process assertion shortly after the previous one expired (and before the UIProcess got suspended).
When doing so, the new background assertion would expire right away and we would get killed without its
invalidation handler getting called.

To address the issue, the logic in ProcessAssertion will now prevent taking a new background assertion after
one expires and until the application becomes foreground again.

* UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agonormalizeMapKey should normalize NaN to one PureNaN bit pattern to make MapHash same
ysuzuki@apple.com [Mon, 29 Apr 2019 22:25:03 +0000 (22:25 +0000)]
normalizeMapKey should normalize NaN to one PureNaN bit pattern to make MapHash same
https://bugs.webkit.org/show_bug.cgi?id=197362

Reviewed by Saam Barati.

JSTests:

* stress/map-with-nan.js: Added.
(shouldBe):
(div):
(NaN1):
(NaN2):
(NaN3):
(NaN4):
(NaN1NoInline):
(NaN2NoInline):
(NaN3NoInline):
(NaN4NoInline):
(test1):
(test2):
(test3):
(test4):
* stress/set-with-nan.js: Added.
(shouldBe):
(div):
(NaN1):
(NaN2):
(NaN3):
(NaN4):
(NaN1NoInline):
(NaN2NoInline):
(NaN3NoInline):
(NaN4NoInline):
(test2):
(test4):

Source/JavaScriptCore:

Our Map/Set's hash algorithm relies on the bit pattern of JSValue. So our Map/Set has
normalization of the key, which normalizes Int32 / Double etc. But we did not normalize
pure NaNs into one canonicalized pure NaN. So we end up having multiple different pure NaNs
in one Map/Set. This patch normalizes NaN into one jsNaN(), which uses PNaN for the representation.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNormalizeMapKey):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):
* runtime/HashMapImpl.h:
(JSC::normalizeMapKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago<rdar://problem/50299396> Fix internal High Sierra build
achristensen@apple.com [Mon, 29 Apr 2019 21:48:43 +0000 (21:48 +0000)]
<rdar://problem/50299396> Fix internal High Sierra build
https://bugs.webkit.org/show_bug.cgi?id=197388

Source/bmalloc:

* Configurations/Base.xcconfig:

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebCore/PAL:

* Configurations/Base.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit:

* Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig:
* Configurations/WebKitLegacy.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MobileMiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoSource/WebCore:
zalan@apple.com [Mon, 29 Apr 2019 21:31:00 +0000 (21:31 +0000)]
Source/WebCore:
Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347
<rdar://problem/49393423>

Reviewed by Wenson Hsieh.

Tests: fast/events/touch/ios/double-tap-for-double-click1.html
       fast/events/touch/ios/double-tap-for-double-click2.html

* page/Frame.h:
* page/ios/FrameIOS.mm:
(WebCore::Frame::nodeRespondingToDoubleClickEvent):

Source/WebKit:
[iOS] Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347
<rdar://problem/49393423>

Reviewed by Wenson Hsieh.

This patch adds support for dispatching dblclick event as the result of the double tap gesture.

1. The new double tap gesture recognizer always fires regardless of what type of action the other, existing double gesture recognizers (double-tap to zoom) trigger.
2. The dblclick event is dispatched on the node with registered dblclick event handler unless the node prohibits double tap gesture (touch-action != auto).

* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):

LayoutTests:
Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)
https://bugs.webkit.org/show_bug.cgi?id=197347
<rdar://problem/49393423>

Reviewed by Wenson Hsieh.

* fast/events/touch/ios/double-tap-for-double-click1-expected.txt: Added.
* fast/events/touch/ios/double-tap-for-double-click1.html: Added.
* fast/events/touch/ios/double-tap-for-double-click2-expected.txt: Added.
* fast/events/touch/ios/double-tap-for-double-click2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoREGRESSION (r244142): Fandango accounts tab crashes under Color()
timothy_horton@apple.com [Mon, 29 Apr 2019 21:05:33 +0000 (21:05 +0000)]
REGRESSION (r244142): Fandango accounts tab crashes under Color()
https://bugs.webkit.org/show_bug.cgi?id=197380
<rdar://problem/50186175>

Reviewed by Megan Gardner.

* UIProcess/API/Cocoa/WKWebView.mm:
(baseScrollViewBackgroundColor):
We now call -_updateScrollViewBackground from -setBackgroundColor:.
-setBackgroundColor: can be called from -[UIView initWithCoder:]; if it
is, WKWebView's _page is not yet initialized, so we crash. Return an invalid color.
Then, the caller falls back to WKContentView's backgroundColor. But WKContentView
isn't initialized yet either. So add a further fallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRemove spurious GVA printf logging
youenn@apple.com [Mon, 29 Apr 2019 20:50:37 +0000 (20:50 +0000)]
Remove spurious GVA printf logging
https://bugs.webkit.org/show_bug.cgi?id=197368
<rdar://problem/35975256>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/mac.py:
(MacPort.logging_patterns_to_strip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoREGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site...
simon.fraser@apple.com [Mon, 29 Apr 2019 20:45:26 +0000 (20:45 +0000)]
REGRESSION (r238090): animation on https://robotodyssey.online gets stuck; site broken
https://bugs.webkit.org/show_bug.cgi?id=197381
Source/WebCore:

Reviewed by Zalan Bujtas.

When -webkit-clip-path changes on a composited layer, we need to trigger a backing geometry update
to push the changes to GraphicsLayers.

Test: compositing/style-change/clip-path-change.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::recompositeChangeRequiresGeometryUpdate):

LayoutTests:

<rdar://problem/50308128>

Reviewed by Zalan Bujtas.

* compositing/style-change/clip-path-change-expected.html: Added.
* compositing/style-change/clip-path-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd InteractionIsHappening to SuppressSelectionAssistantReason
dino@apple.com [Mon, 29 Apr 2019 20:34:16 +0000 (20:34 +0000)]
Add InteractionIsHappening to SuppressSelectionAssistantReason
https://bugs.webkit.org/show_bug.cgi?id=197375
<rdar://problem/50304986>

Reviewed by Megan Gardner.

Add a new reason for suppressing the selection assistant, to
be used in a follow-up patch.

* UIProcess/ios/WKContentViewInteraction.h: Add InteractionIsHappening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoStorage::deleteOldVersions does not need to retain Storage
achristensen@apple.com [Mon, 29 Apr 2019 20:32:47 +0000 (20:32 +0000)]
Storage::deleteOldVersions does not need to retain Storage
https://bugs.webkit.org/show_bug.cgi?id=197336
<rdar://problem/48679972>

Reviewed by Darin Adler.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::deleteOldVersions):
Something is wrong with the lifetime of Storage, but we only need a String, not the whole Storage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agogetDisplayMedia should be called on user gesture
youenn@apple.com [Mon, 29 Apr 2019 20:04:33 +0000 (20:04 +0000)]
getDisplayMedia should be called on user gesture
https://bugs.webkit.org/show_bug.cgi?id=197356
Source/WebCore:

Reviewed by Eric Carlson.

Allow getDisplayMedia on user gesture only.
Otherwise reject the promise.
Minor refactoring to align getDisplayMedia, getUserMedia and
enumerateDevices when called with no document.

Test: fast/mediastream/screencapture-user-gesture.html

* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getUserMedia const):
* Modules/mediastream/MediaDevices.h:
* Modules/mediastream/NavigatorMediaDevices.h:
* page/DOMWindow.h:
* testing/Internals.cpp:
(WebCore::Internals::setDisableGetDisplayMediaUserGestureConstraint):
* testing/Internals.h:
* testing/Internals.idl:

Tools:

<rdar://problem/50296074>

Reviewed by Eric Carlson.

Update test configuration to inject internals
so that we can use it to simulate a user click to call getDisplayMedia.

* TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(TestWebKitAPI::GetDisplayMediaTest::SetUp):

LayoutTests:

Reviewed by Eric Carlson.

* fast/mediastream/media-stream-page-muted.html:
* fast/mediastream/screencapture-user-gesture-expected.txt: Added.
* fast/mediastream/screencapture-user-gesture.html: Added.
* http/tests/media/media-stream/get-display-media-iframe-allow-attribute-expected.txt:
* http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html:
* http/tests/media/media-stream/get-display-media-prompt.html:
* http/tests/media/media-stream/resources/get-display-media-devices-iframe.html:

* resources/testharnessreport.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoline should not be broken before the first space after a word
jfernandez@igalia.com [Mon, 29 Apr 2019 19:56:56 +0000 (19:56 +0000)]
line should not be broken before the first space after a word
https://bugs.webkit.org/show_bug.cgi?id=197278

Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

Added new Web Platform Tests to cover the cases discussed [1] with the CSS WG.

[1] https://github.com/w3c/csswg-drafts/issues/3701

* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-001-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-001.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-003-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-003.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-004-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-004.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-005-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-005.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-006-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-006.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-007-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-007.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-008-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-008.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-009-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-009.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-010-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-010.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-011-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-011.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-012-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-012.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-013-expected.html: Added.
* web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-013.html: Added.

Source/WebCore:

The 'white-space: break-spaces' only adds breaking opportunities after
a white space character. However, it's possible to break before the
first space after a word when the feature is used in combination with
other properties, like overflow-wrap.

However, breaking before the first space should not be allowed if
there are previous opportunities. We wrongly assumed that we had to
consider these previous breaking opportunities if the proper combination
of line breaking properties is being used, so that breaking before the
first space after a word is allowed.

This wrong assumption caused several issues, like the one described in
the bug, that lead to incorrectly break before the first space even
though there are previous opportunities, either white spaces or between
letters.

Theses issues have been analyzed [1] by the CSS WG and finally agreed on a
expected behavior, represented in the Web Platform tests added in this
patch.

For the later case, of considering previous opportunities between
letters, we have a seperated issue #952254, so the tests covering such
cases will be added to the TestExpecations as Failure entries.

[1] https://github.com/w3c/csswg-drafts/issues/3701

Tests: imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-001.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-003.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-004.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-005.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-006.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-007.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-008.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-009.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-010.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-011.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-012.html
       imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-013.html

* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::trailingSpacesHang):

LayoutTests:

Added a few Skip (due to unimplemented features) and Failure (break-all related
issues) entries for some of the tests added by this patch.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[Cocoa] Move common sandbox files from Shared/mac to Shared/Cocoa
bfulgham@apple.com [Mon, 29 Apr 2019 19:52:56 +0000 (19:52 +0000)]
[Cocoa] Move common sandbox files from Shared/mac to Shared/Cocoa
https://bugs.webkit.org/show_bug.cgi?id=197376
<rdar://problem/50305272>

Reviewed by Dean Jackson.

The Apple sandboxing logic currently lives in the inappropriate 'Shared/mac' directory. This is
confusing because the code is used by all Apple ports, not just macOS.

This patch just moves the relevant files from 'Shared/mac' to 'Shared/Cocoa' to avoid this confusion.

* Shared/Cocoa/SandboxExtensionCocoa.mm: Renamed from Source/WebKit/Shared/mac/SandboxExtensionMac.mm.
* Shared/Cocoa/SandboxInitialiationParametersCocoa.mm: Renamed from Source/WebKit/Shared/mac/SandboxInitialiationParametersMac.mm.
* Shared/Cocoa/SandboxUtilities.h: Renamed from Source/WebKit/Shared/mac/SandboxUtilities.h.
* Shared/Cocoa/SandboxUtilities.mm: Renamed from Source/WebKit/Shared/mac/SandboxUtilities.mm.
* SourcesCocoa.txt:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[CMake] Add WEBKIT_EXECUTABLE macro
don.olmstead@sony.com [Mon, 29 Apr 2019 19:36:21 +0000 (19:36 +0000)]
[CMake] Add WEBKIT_EXECUTABLE macro
https://bugs.webkit.org/show_bug.cgi?id=197206

Unreviewed build fix.

Calls to add_dependencies were not happening.

* Source/cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoJITStubRoutineSet wastes 180KB of HashTable capacity on can.com
ysuzuki@apple.com [Mon, 29 Apr 2019 19:21:02 +0000 (19:21 +0000)]
JITStubRoutineSet wastes 180KB of HashTable capacity on can.com
https://bugs.webkit.org/show_bug.cgi?id=186732

Reviewed by Saam Barati.

Source/JavaScriptCore:

Our current mechanism of JITStubRoutineSet consumes more memory than needed. Basically we have HashMap<uintptr_t, StubRoutine*> and register
each executable address by 16 byte to this entry. So if your StubRoutine has 128bytes, it just adds 8 entries to this hash table.
In Gmail, we see a ~2MB table size.

Instead, this patch uses Vector<pair<uintptr_t, StubRoutine*>> and performs binary search onto this sorted vector. Before conservative
scanning, we sort this vector. And doing binary search with the sorted vector to find executing stub routines from the conservative roots.
This vector includes uintptr_t startAddress to make binary searching fast.

Large amount of conservative scan should be filtered by range check, so I think binary search here is OK, but we can decide based on what the
performance bots say.

* heap/Heap.cpp:
(JSC::Heap::addCoreConstraints):
* heap/JITStubRoutineSet.cpp:
(JSC::JITStubRoutineSet::~JITStubRoutineSet):
(JSC::JITStubRoutineSet::add):
(JSC::JITStubRoutineSet::prepareForConservativeScan):
(JSC::JITStubRoutineSet::clearMarks):
(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
(JSC::JITStubRoutineSet::traceMarkedStubRoutines):
* heap/JITStubRoutineSet.h:
(JSC::JITStubRoutineSet::mark):
(JSC::JITStubRoutineSet::prepareForConservativeScan):
(JSC::JITStubRoutineSet::size const): Deleted.
(JSC::JITStubRoutineSet::at const): Deleted.

Source/WTF:

* wtf/Range.h:
(WTF::Range::contains const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[GTK] Back/forward gesture snapshot always times out
commit-queue@webkit.org [Mon, 29 Apr 2019 19:08:18 +0000 (19:08 +0000)]
[GTK] Back/forward gesture snapshot always times out
https://bugs.webkit.org/show_bug.cgi?id=197233

Patch by Alexander Mikhaylenko <exalm7659@gmail.com> on 2019-04-29
Reviewed by Michael Catanzaro.

Delaying web process launch caused a regression where we create ViewGestureController when the
web process doesn't yet exist. The controller immediately tries to connect to it and fails,
and because of that never receives DidHitRenderTreeSizeThreshold() message, so navigation
snapshot always stays until timeout after performing the gesture.

To prevent this, create the controller in webkitWebViewBaseDidRelaunchWebProcess() instead of
webkitWebViewBaseCreateWebPage(). Additionally, since settings are now created earlier than
ViewGestureController, store the value of whether swipe gesture is enabled in WebKitWebViewBase
and immediately apply it when creating the controller.

Since there is now a point where controller is null, make webkitWebViewBaseViewGestureController()
return null and add null checks everywhere.

* UIProcess/API/glib/WebKitWebView.cpp:
(enableBackForwardNavigationGesturesChanged):
Move the logic into webkitWebViewBaseSetEnableBackForwardNavigationGesture().
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore): Add a null check.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw): Ditto.
(webkitWebViewBaseScrollEvent): Ditto.
(webkitWebViewBaseSetEnableBackForwardNavigationGesture): Added. In addition to what was in
WebKitWebViewBase::enableBackForwardNavigationGesturesChanged(), store the value in a field
for the case ViewGestureController doesn't exist yet.
(webkitWebViewBaseViewGestureController): Return a pointer instead of reference.
(webkitWebViewBaseCreateWebPage): Stop creating ViewGestureController.
(webkitWebViewBaseDidRelaunchWebProcess): Move creating ViewGestureController here. Also
immediately call setSwipeGestureEnabled() with the stored value.
(webkitWebViewBaseDidStartProvisionalLoadForMainFrame): Add a null check.
(webkitWebViewBaseDidFirstVisuallyNonEmptyLayoutForMainFrame):Ditto.
(webkitWebViewBaseDidFinishLoadForMainFrame): Ditto.
(webkitWebViewBaseDidFailLoadForMainFrame): Ditto.
(webkitWebViewBaseDidSameDocumentNavigationForMainFrame): Ditto.
(webkitWebViewBaseDidRestoreScrollPosition): Ditto.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUser-facing strings should use curly quotes instead of straight
cdumez@apple.com [Mon, 29 Apr 2019 18:22:25 +0000 (18:22 +0000)]
User-facing strings should use curly quotes instead of straight
https://bugs.webkit.org/show_bug.cgi?id=197370

Reviewed by Geoffrey Garen.

Source/WebCore:

Update localizable strings.

* en.lproj/Localizable.strings:

Source/WebKit:

Update localizable alert text that was recently added to use curly quotes instead of
straight ones, as per our guidelines.

* UIProcess/Cocoa/WKOrientationAccessAlert.mm:
(WebKit::presentOrientationAccessAlert):
* UIProcess/Cocoa/WKStorageAccessAlert.mm:
(WebKit::presentStorageAccessAlert):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[Win] Add flag to enable version information stamping and disable by default.
Basuke.Suzuki@sony.com [Mon, 29 Apr 2019 18:18:54 +0000 (18:18 +0000)]
[Win] Add flag to enable version information stamping and disable by default.
https://bugs.webkit.org/show_bug.cgi?id=197249
<rdar://problem/50224412>

Reviewed by Ross Kirsling.

.:

This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
Then enable it by default on AppleWin.

* Source/cmake/OptionsWin.cmake:

Source/JavaScriptCore:

This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
Then enable it by default on AppleWin.

* CMakeLists.txt:

Source/WTF:

This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
Then enable it by default on AppleWin.

* wtf/CMakeLists.txt:

WebKitLibraries:

Modify script not to invoke SVN command if the directory for SVN doesn't exists.

* win/tools/scripts/auto-version.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed fix for non-unified build after r244687.
ross.kirsling@sony.com [Mon, 29 Apr 2019 18:18:32 +0000 (18:18 +0000)]
Unreviewed fix for non-unified build after r244687.

* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRTCTrackEvent should be delayed until the whole remote description is set
youenn@apple.com [Mon, 29 Apr 2019 16:24:31 +0000 (16:24 +0000)]
RTCTrackEvent should be delayed until the whole remote description is set
https://bugs.webkit.org/show_bug.cgi?id=196808
<rdar://problem/49802649>

Reviewed by Eric Carlson.

Source/WebCore:

As per https://w3c.github.io/webrtc-pc/#set-description,
fire events just before resolving the setRemoteDescription promise.
This ensures that the exposed stream has all necessary tracks from the beginning.
Pending track events are created in LibWebRTCMediaEndpoint and stored in PeerConnectionBackend.

Covered by updated test.

* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
(WebCore::PeerConnectionBackend::addPendingTrackEvent):
(WebCore::PeerConnectionBackend::stop):
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCPeerConnection.cpp:
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::addPendingTrackEvent):
(WebCore::LibWebRTCMediaEndpoint::newTransceiver):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

LayoutTests:

* webrtc/video-addTrack.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[GTK] [l10n] Updated Ukrainian translation of WebKitGTK+
mcatanzaro@igalia.com [Mon, 29 Apr 2019 14:10:06 +0000 (14:10 +0000)]
[GTK] [l10n] Updated Ukrainian translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=197364

Patch by Yuri Chornoivan <yurchor@ukr.net> on 2019-04-29
Rubber-stamped by Michael Catanzaro.

* uk.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd Danish translation
mcatanzaro@igalia.com [Mon, 29 Apr 2019 14:08:30 +0000 (14:08 +0000)]
Add Danish translation
https://bugs.webkit.org/show_bug.cgi?id=194850

Patch by scootergrisen <scootergrisen@gmail.com> on 2019-04-29
Rubber-stamped by Michael Catanzaro.

* da.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoBuild fix.
achristensen@apple.com [Mon, 29 Apr 2019 14:02:10 +0000 (14:02 +0000)]
Build fix.

* UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet updateSheetPosition]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244648.
commit-queue@webkit.org [Mon, 29 Apr 2019 12:24:02 +0000 (12:24 +0000)]
Unreviewed, rolling out r244648.
https://bugs.webkit.org/show_bug.cgi?id=197363

 Lots of tests  are crashing (Requested by KaL on #webkit).

Reverted changeset:

"[GTK] Back/forward gesture snapshot always times out"
https://bugs.webkit.org/show_bug.cgi?id=197233
https://trac.webkit.org/changeset/244648

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoREGRESSION(r244635): [GTK] Wrong background color used in non-dark mode
carlosgc@webkit.org [Mon, 29 Apr 2019 10:14:01 +0000 (10:14 +0000)]
REGRESSION(r244635): [GTK] Wrong background color used in non-dark mode
https://bugs.webkit.org/show_bug.cgi?id=197276

Reviewed by Michael Catanzaro.

Since r244635, we are now getting the frame view background color from the theme. That's correct for dark mode,
but in non-dark mode we still want to use white backgrounds by default. This made a lot of tests to fail.

* css/CSSValueKeywords.in: Add -webkit-control-background when HAVE(OS_DARK_MODE_SUPPORT).
* css/html.css: Use -webkit-control-background instead of -apple-system-control-background.
* page/FrameView.cpp:
(WebCore::FrameView::updateBackgroundRecursively): Use CSSValueWindow instead of CSSValueWindowframe.
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemColor const): Only get the window background from the theme in dark mode. Handle
also CSSValueWebkitControlBackground.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const): Handle CSSValueWebkitControlBackground when HAVE(OS_DARK_MODE_SUPPORT).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agorun-benchmarks should have an intial prep and restore env call for tasks that are...
slewis@apple.com [Mon, 29 Apr 2019 09:14:43 +0000 (09:14 +0000)]
run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
https://bugs.webkit.org/show_bug.cgi?id=197339

Reviewed by Dewei Zhu.

Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
test run for setup steps that are too expensive to do every iteration.

* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._run_benchmark):
* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver):
(BrowserDriver.prepare_initial_env):
(BrowserDriver.restore_env_after_all_testing):
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.prepare_initial_env):
(LinuxBrowserDriver.restore_env_after_all_testing):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepare_initial_env):
(OSXBrowserDriver.restore_env_after_all_testing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[WPE][GTK] window-object-cleared documentation should reference webkit_frame_get_js_c...
mcatanzaro@igalia.com [Mon, 29 Apr 2019 08:36:32 +0000 (08:36 +0000)]
[WPE][GTK] window-object-cleared documentation should reference webkit_frame_get_js_context_for_script_world()
https://bugs.webkit.org/show_bug.cgi?id=197357

Reviewed by Carlos Garcia Campos.

We should recommend using the non-deprecated replacement for
webkit_frame_get_javascript_context_for_script_world().

* WebProcess/InjectedBundle/API/glib/WebKitScriptWorld.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUpdate the CSS Text WPT test suite
jfernandez@igalia.com [Mon, 29 Apr 2019 08:08:51 +0000 (08:08 +0000)]
Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=197326

Unreviewed test gardening.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html:
* web-platform-tests/css/css-text/overflow-wrap/w3c-import.log:
* web-platform-tests/css/css-text/parsing/text-transform-valid.html:
* web-platform-tests/css/css-text/parsing/word-break-invalid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-invalid.html:
* web-platform-tests/css/css-text/parsing/word-break-valid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-valid.html:
* web-platform-tests/css/css-text/text-transform/w3c-import.log:
* web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-003.html:
* web-platform-tests/css/css-text/white-space/break-spaces-004.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008-expected.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-015.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-016.html:
* web-platform-tests/css/css-text/white-space/textarea-break-spaces-001-expected.html:
* web-platform-tests/css/css-text/white-space/w3c-import.log:

LayoutTests:

* TestExpectations:
  - The break-spaces-008.html fails due to bug 197277

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[Apple Pay] Increment the API version from 6 to 7
aestes@apple.com [Mon, 29 Apr 2019 05:17:08 +0000 (05:17 +0000)]
[Apple Pay] Increment the API version from 6 to 7
https://bugs.webkit.org/show_bug.cgi?id=197041
<rdar://problem/49986625>

Reviewed by Geoffrey Garen.

* Modules/applepay/PaymentCoordinatorClient.cpp:
(WebCore::PaymentCoordinatorClient::supportsVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix the watchOS engineering build.
aestes@apple.com [Sun, 28 Apr 2019 19:28:09 +0000 (19:28 +0000)]
Fix the watchOS engineering build.

.:

* Source/Makefile: Moved libwebrtc logic into Source/ThirdParty/Makefile.

Source/ThirdParty:

* Makefile: Started building libwebrtc on watchOS.

Source/ThirdParty/libwebrtc:

* Makefile: Set OTHER_OPTIONS to build libwebrtc's boringssl target on watchOS, which is a
dependency for TestWebKitAPI's TCPServer.

Source/WebCore:

* Modules/webgpu/WebGPUComputePassEncoder.cpp: Included Logging.h.

Tools:

* TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
(TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix imported/w3c/web-platform-tests/fetch/api/request/request-keepalive.html assert_t...
youenn@apple.com [Sun, 28 Apr 2019 19:06:01 +0000 (19:06 +0000)]
Fix imported/w3c/web-platform-tests/fetch/api/request/request-keepalive.html assert_throws call
https://bugs.webkit.org/show_bug.cgi?id=197338

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRemove no longer needed mDNS ICE candidate resolution code
youenn@apple.com [Sun, 28 Apr 2019 19:02:39 +0000 (19:02 +0000)]
Remove no longer needed mDNS ICE candidate resolution code
https://bugs.webkit.org/show_bug.cgi?id=197315

Reviewed by Eric Carlson.

No change of behavior.
Removed code is no longer exercised as mDNS resolution happens inside libwebrtc
using the same resolution mechanism as for TURN/STUN server names.

* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::addIceCandidateSucceeded):
(WebCore::PeerConnectionBackend::addIceCandidateFailed):
* Modules/mediastream/PeerConnectionBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[WKTR] Move test timeout handling to the UIProcess
cdumez@apple.com [Sat, 27 Apr 2019 22:45:38 +0000 (22:45 +0000)]
[WKTR] Move test timeout handling to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=197333

Reviewed by Darin Adler.

Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
every WebContent process in the case of swapping.

Also, because of process caching, the timeout timer would sometime fire in a cached process and it
would lead to crashes when firing the timer.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::shouldDumpPixels const):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
(WTR::TestRunner::waitUntilDone):
(WTR::TestRunner::setWaitUntilDone):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
* WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
* WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::createTestSettingsDictionary):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
(WTR::TestInvocation::waitToDumpWatchdogTimerFired):
(WTR::TestInvocation::setWaitUntilDone):
(WTR::TestInvocation::done):
* WebKitTestRunner/TestInvocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoMove some Compositing logging to the Layers log channel
simon.fraser@apple.com [Sat, 27 Apr 2019 19:31:00 +0000 (19:31 +0000)]
Move some Compositing logging to the Layers log channel
https://bugs.webkit.org/show_bug.cgi?id=197345

Reviewed by Sam Weinig.

Make Compositing logging a bit less verbose by moving the GraphicsLayer tree dump
to the Layers log channel. Also log GraphicsLayers after flushing, when we'll have
accurate visible rects.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateCoverage):
* rendering/RenderLayerCompositor.cpp:
(WebCore::layersLogEnabled):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoImprove safety of MachMessage class
cdumez@apple.com [Sat, 27 Apr 2019 17:09:24 +0000 (17:09 +0000)]
Improve safety of MachMessage class
https://bugs.webkit.org/show_bug.cgi?id=197323
<rdar://problem/44291920>

Reviewed by Darin Adler.

Improve safety of MachMessage class and clean things up a bit.

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::sendOutgoingMessage):
- Pass MessageReceiverName / MessageName when constructing the MachMessage rather
  than setting them afterwards since they never change for a given MachMessage.
- Set header->msgh_id to the right value right away instead of setting it first
  to inlineBodyMessageID and then later fixing it to be outOfLineBodyMessageID
  when the body is out of line.
- When messageBodyIsOOL was true, we would call getDescriptorAndSkip() which
  would advance the pointer by sizeof(mach_msg_port_descriptor_t), even though
  the descriptor type is mach_msg_ool_descriptor_t. This would not matter in
  the end because we would not use the messageData pointer after this but
  still.

* Platform/IPC/mac/MachMessage.cpp:
(IPC::MachMessage::create):
Use fastZeroedMalloc() instead of fastMalloc() for safety, given that this class
has a mach_msg_header_t flexible array member. This is what is recommended by the
mach documentation. It is much safer because it otherwize relies on the user
(Connection::sendOutgoingMessage()) to initialize ALL the message members
correctly. I suspect this was the cause of <rdar://problem/44291920> because
Connection::sendOutgoingMessage() would fail to initialize header->msgh_voucher_port
and the MachMessage destructor would then call mach_msg_destroy(header()), which
would mach_msg_destroy_port(header->msgh_voucher_port).

(IPC::MachMessage::MachMessage):
Pass MessageReceiverName / MessageName when constructing the MachMessage rather
than setting them afterwards since they never change for a given MachMessage.

(IPC::MachMessage::messageSize):
Drop if checks for portDescriptorCount and memoryDescriptorCount since the logic
will do the right thing even if they are 0.

* Platform/IPC/mac/MachMessage.h:
(IPC::MachMessage::header):
(IPC::MachMessage::messageReceiverName const):
(IPC::MachMessage::messageName const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoLookup only looking up the first word in selection
megan_gardner@apple.com [Sat, 27 Apr 2019 14:41:24 +0000 (14:41 +0000)]
Lookup only looking up the first word in selection
https://bugs.webkit.org/show_bug.cgi?id=197341
<rdar://problem/48221414>

Reviewed by Wenson Hsieh.

Lookup is not testable.

Reveal needs the full range in order to correctly create the item for the popover.

* editing/cocoa/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRename m_LayerTreeFreezeReasons to m_layerTreeFreezeReasons
wenson_hsieh@apple.com [Sat, 27 Apr 2019 06:50:01 +0000 (06:50 +0000)]
Rename m_LayerTreeFreezeReasons to m_layerTreeFreezeReasons
https://bugs.webkit.org/show_bug.cgi?id=197343

Reviewed by Antti Koivisto.

No change in behavior.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoReduce the number of copies made during SourceBufferPrivateAVFObjC::append() using...
jer.noble@apple.com [Sat, 27 Apr 2019 05:38:40 +0000 (05:38 +0000)]
Reduce the number of copies made during SourceBufferPrivateAVFObjC::append() using SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=197335
<rdar://problem/49175604>

Rubber-stamped by Alex Christensen.

* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoEnable new build rule for post-processing headers when using XCBuild
krollin@apple.com [Sat, 27 Apr 2019 04:28:55 +0000 (04:28 +0000)]
Enable new build rule for post-processing headers when using XCBuild
https://bugs.webkit.org/show_bug.cgi?id=197340
<rdar://problem/50226685>

Reviewed by Brent Fulgham.

In Bug 197116, we conditionally disabled the old method for
post-processing header files when we are using the new XCBuild build
system. This check-in conditionally enables the new post-processing
facility. Note that the old system is disabled and the new system
enabled only when the USE_NEW_BUILD_SYSTEM environment variable is set
to YES.

Source/JavaScriptCore:

* Configurations/JavaScriptCore.xcconfig:

Source/WebKit:

* Configurations/WebKit.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/WebKitLegacy.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd new mac target numbers
jberlin@webkit.org [Sat, 27 Apr 2019 02:20:53 +0000 (02:20 +0000)]
Add new mac target numbers
https://bugs.webkit.org/show_bug.cgi?id=197313

Reviewed by Alex Christensen.

* Configurations/Version.xcconfig:
Source/JavaScriptCore:

* Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty/libwebrtc:

* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore:

* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore/PAL:

* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKit:

* Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/WebKitTargetConditionals.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244708.
commit-queue@webkit.org [Sat, 27 Apr 2019 00:37:40 +0000 (00:37 +0000)]
Unreviewed, rolling out r244708.
https://bugs.webkit.org/show_bug.cgi?id=197334

"Broke the debug build" (Requested by rmorisset on #webkit).

Reverted changeset:

"All prototypes should call didBecomePrototype()"
https://bugs.webkit.org/show_bug.cgi?id=196315
https://trac.webkit.org/changeset/244708

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[CMake] Add WEBKIT_EXECUTABLE macro
don.olmstead@sony.com [Sat, 27 Apr 2019 00:06:38 +0000 (00:06 +0000)]
[CMake] Add WEBKIT_EXECUTABLE macro
https://bugs.webkit.org/show_bug.cgi?id=197206

Reviewed by Konstantin Tokarev.

.:

Add WEBKIT_EXECUTABLE macro for creating executable targets. This wraps the creation of
executable targets using the same conventions of WEBKIT_FRAMEWORK.

Common code from the two macros were moved to WEBKIT_TARGET which is meant as an internal
macro.

Add WEBKIT_WRAP_EXECUTABLE macro to support Windows targets which use a DLLLauncherMain to
launch the executable.

* Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

Migrate to WEBKIT_EXECUTABLE for the jsc and test targets.

* b3/air/testair.cpp:
* b3/testb3.cpp:
* dfg/testdfg.cpp:
* shell/CMakeLists.txt:
* shell/PlatformGTK.cmake:
* shell/PlatformJSCOnly.cmake: Removed.
* shell/PlatformMac.cmake:
* shell/PlatformPlayStation.cmake:
* shell/PlatformWPE.cmake:
* shell/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[JSC] linkPolymorphicCall now does GC
ysuzuki@apple.com [Fri, 26 Apr 2019 23:32:35 +0000 (23:32 +0000)]
[JSC] linkPolymorphicCall now does GC
https://bugs.webkit.org/show_bug.cgi?id=197306

Reviewed by Saam Barati.

JSTests:

* stress/link-polymorphic-call-can-gc.js: Added.
(module):
(instance):

Source/JavaScriptCore:

Previously, we assumed that linkPolymorphicCall does not perform allocations. So we put CallVariant into a Vector<>.
But now, WebAssemblyFunction's entrypoint generation can allocate JSToWasmICCallee and cause GC. Since CallLinkInfo
does not hold these cells, they can be collected, and we will see dead cells in the middle of linkPolymorphicCall.
We should defer GC for a while in linkPolymorphicCall. We use DeferGCForAWhile instead of DeferGC because the
caller "operationLinkPolymorphicCall" assumes that this function does not cause GC.

* jit/Repatch.cpp:
(JSC::linkPolymorphicCall):

Tools:

The test is sensitive to allocations and even adding $vm makes it non-reproducible.
To add this test, we add `runWithoutBaseOption`.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUse kDNSServiceFlagsKnownUnique to speed up mdns name registration for ICE candidates
youenn@apple.com [Fri, 26 Apr 2019 23:01:10 +0000 (23:01 +0000)]
Use kDNSServiceFlagsKnownUnique to speed up mdns name registration for ICE candidates
https://bugs.webkit.org/show_bug.cgi?id=197328

Reviewed by Eric Carlson.

This allows skipping the probing step of MDNS name registration.
We can do that as registered names are random UUIDs.

* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::registerMDNSName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAll prototypes should call didBecomePrototype()
rmorisset@apple.com [Fri, 26 Apr 2019 22:21:25 +0000 (22:21 +0000)]
All prototypes should call didBecomePrototype()
https://bugs.webkit.org/show_bug.cgi?id=196315

Reviewed by Saam Barati.

JSTests:

* stress/function-prototype-indexed-accessor.js: Added.

Source/JavaScriptCore:

Otherwise we won't remember to run haveABadTime() when someone adds to them an indexed accessor.

I added a check used in both Structure::finishCreation() and Structure::changePrototypeTransition to make sure we don't
create structures with invalid prototypes.
It found a lot of objects that are used as prototypes in JSGlobalObject and yet were missing didBecomePrototype() in their finishCreation().
Somewhat surprisingly, some of them have names like FunctionConstructor and not only FooPrototype.

* runtime/BigIntPrototype.cpp:
(JSC::BigIntPrototype::finishCreation):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::finishCreation):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::finishCreation):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::finishCreation):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::finishCreation):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::finishCreation):
* runtime/IntlCollatorPrototype.cpp:
(JSC::IntlCollatorPrototype::finishCreation):
* runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::finishCreation):
* runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototype::finishCreation):
* runtime/IntlPluralRulesPrototype.cpp:
(JSC::IntlPluralRulesPrototype::finishCreation):
* runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
* runtime/JSDataViewPrototype.cpp:
(JSC::JSDataViewPrototype::finishCreation):
* runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
* runtime/JSGlobalObject.cpp:
(JSC::createConsoleProperty):
* runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::finishCreation):
* runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
* runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::finishCreation):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
* runtime/Structure.cpp:
(JSC::Structure::isValidPrototype):
(JSC::Structure::changePrototypeTransition):
* runtime/Structure.h:
* runtime/SymbolPrototype.cpp:
(JSC::SymbolPrototype::finishCreation):
* wasm/js/WebAssemblyCompileErrorPrototype.cpp:
(JSC::WebAssemblyCompileErrorPrototype::finishCreation):
* wasm/js/WebAssemblyInstancePrototype.cpp:
(JSC::WebAssemblyInstancePrototype::finishCreation):
* wasm/js/WebAssemblyLinkErrorPrototype.cpp:
(JSC::WebAssemblyLinkErrorPrototype::finishCreation):
* wasm/js/WebAssemblyMemoryPrototype.cpp:
(JSC::WebAssemblyMemoryPrototype::finishCreation):
* wasm/js/WebAssemblyModulePrototype.cpp:
(JSC::WebAssemblyModulePrototype::finishCreation):
* wasm/js/WebAssemblyPrototype.cpp:
(JSC::WebAssemblyPrototype::finishCreation):
* wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:
(JSC::WebAssemblyRuntimeErrorPrototype::finishCreation):
* wasm/js/WebAssemblyTablePrototype.cpp:
(JSC::WebAssemblyTablePrototype::finishCreation):

Source/WebCore:

It was found by existing tests, with the new assert in JSC::Structure

* bindings/js/JSWindowProxy.cpp:
(WebCore::JSWindowProxy::setWindow):
* bindings/scripts/CodeGeneratorJS.pm:
(GeneratePrototypeDeclaration):
(GenerateConstructorHelperMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[iOS] Our process assertion should not allow idle sleep
cdumez@apple.com [Fri, 26 Apr 2019 22:05:01 +0000 (22:05 +0000)]
[iOS] Our process assertion should not allow idle sleep
https://bugs.webkit.org/show_bug.cgi?id=197317
<rdar://problem/50137740>

Reviewed by Geoffrey Garen.

Our process assertion should not allow idle sleep. This is bad for power because the device
may switch between sleep and awake state frequently, as it get woken up by network packages.

* UIProcess/ios/ProcessAssertionIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUpdate inactive reviewers' status to 'contributor'.
ap@apple.com [Fri, 26 Apr 2019 21:14:24 +0000 (21:14 +0000)]
Update inactive reviewers' status to 'contributor'.

Accidentally skipped one at first.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUpdate inactive reviewers' status to 'contributor'.
ap@apple.com [Fri, 26 Apr 2019 20:47:29 +0000 (20:47 +0000)]
Update inactive reviewers' status to 'contributor'.

* Scripts/webkitpy/common/config/contributors.json: The change.

* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/checkout/checkout_mock.py:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
Sadly, regression tests operate on a crazy mix of mock and live data for
contributors.json. It would be a substantial project to mock all code paths,
so changing the tests instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoCreate AVFoundationSoftLink.{h,mm} to reduce duplicate code
eric.carlson@apple.com [Fri, 26 Apr 2019 19:58:41 +0000 (19:58 +0000)]
Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
https://bugs.webkit.org/show_bug.cgi?id=197171
<rdar://problem/47454979>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm

* Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):
* WebCore.xcodeproj/project.pbxproj:
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::category const):
(WebCore::AudioSession::routeSharingPolicy const):
(WebCore::AudioSession::routingContextUID const):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::numberOfOutputChannels const):
(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::label const):
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
* platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
* platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
* platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:
(WebCore::AVFoundationMIMETypeCache::canDecodeType):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsMediaCapability):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):
* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::isAvailable):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::setStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::imageDecoderAssetOptions):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSamples):
(SOFT_LINK_CONSTANT_MAY_FAIL): Deleted.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::label const):
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label const):
* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::devicePicker):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Deleted.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):
* platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:
(WebCore::validateHEVCParameters):
* platform/ios/PlatformSpeechSynthesizerIOS.mm:
(getAVSpeechUtteranceDefaultSpeechRate):
(getAVSpeechUtteranceMaximumSpeechRate):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(SOFT_LINK_CONSTANT): Deleted.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoRect]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
* platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):
* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::getAVFormatIDKeyWithFallback):
(WebCore::getAVNumberOfChannelsKeyWithFallback):
(WebCore::getAVSampleRateKeyWithFallback):
(WebCore::getAVEncoderBitRateKeyWithFallback):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setVideoInput):
(WebCore::MediaRecorderPrivateWriter::setAudioInput):
* platform/mediastream/RealtimeVideoSource.h:
* platform/mediastream/VideoPreset.h:
* platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):
* platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]):
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::deviceIsAvailable):
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
(WebCore::AVCaptureDeviceManager::isAvailable):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoPreset::create):
(WebCore::AVVideoPreset::AVVideoPreset):
(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::sensorOrientationFromVideoOutput):
(WebCore::AVVideoCaptureSource::setupSession):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::AVVideoCaptureSource::generatePresets):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver captureOutput:didOutputSampleBuffer:fromConnection:]):

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/cocoa/AVFoundationSoftLink.h: Added.
* pal/cocoa/AVFoundationSoftLink.mm: Added.

Source/WebKit:

* Shared/ios/WebIconUtilities.mm:
(WebKit::iconForVideoFile):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone const):

Source/WebKitLegacy/mac:

* WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(SOFT_LINK_CLASS): Deleted.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
ddkilzer@apple.com [Fri, 26 Apr 2019 18:32:46 +0000 (18:32 +0000)]
WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
<https://webkit.org/b/197314>
<rdar://problem/50245252>

Reviewed by Simon Fraser.

* WebKitTestRunner/UIScriptControllerCocoa.mm:
(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):
- Use adopt(JSStringCreateWithCFString(...)) to fix leaks.

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator sendEventStream:completionBlock:]):
- Call -autorelease to fix leak of NSDictionary.

* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::accessibilitySpeakSelectionContent const):
(WTR::UIScriptController::selectFormPopoverTitle const):
(WTR::UIScriptController::textContentType const):
(WTR::UIScriptController::formInputLabel const):
(WTR::UIScriptController::scrollingTreeAsText const):
- Use adopt(JSStringCreateWithCFString(...)) to fix leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244683.
commit-queue@webkit.org [Fri, 26 Apr 2019 18:32:41 +0000 (18:32 +0000)]
Unreviewed, rolling out r244683.
https://bugs.webkit.org/show_bug.cgi?id=197320

Causing crash on iOS Simulator and EWS failures (Requested by
sroberts on #webkit).

Reverted changeset:

"[iOS] Add internal setting to force -webkit-text-size-adjust
to "auto""
https://bugs.webkit.org/show_bug.cgi?id=197275
https://trac.webkit.org/changeset/244683

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agowebkitpy: Running a single test will always use the default device
jbedard@apple.com [Fri, 26 Apr 2019 18:25:28 +0000 (18:25 +0000)]
webkitpy: Running a single test will always use the default device
https://bugs.webkit.org/show_bug.cgi?id=195472
<rdar://problem/48724825>

Reviewed by Lucas Forschler.

It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
requested will be run regardless of what shard they are in.

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
on the default device type.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
(RunTest.test_run_part): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUse normal loading path for ping loads
youenn@apple.com [Fri, 26 Apr 2019 18:10:17 +0000 (18:10 +0000)]
Use normal loading path for ping loads
https://bugs.webkit.org/show_bug.cgi?id=196807

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/beacon/headers/header-content-type-expected.txt:

Source/WebCore:

Make use of regular code path for ping loads and beacon.
This is done conditionally on KeepAlive flag.
The benefits are a single loading code path and service worker interception.

For that purpose, introduce a LoaderStrategy switch based on KeepAlive runtime flag.
This switch is used to use ping loads when keepAlive is set or regular loads.
In case of regular loads, the keepAlive flag should be used to extend the lifetime of the load.

Migrate ping loads to use CachedResourceLoader instead of PingLoad.
For that purpose, introduce a new Ping CachedResource type.

Covered by existing tests.

* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
* inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::inspectorResourceType):
* loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient):
* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType):
* loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType):
(WebCore::CachedResource::load):
(WebCore::CachedResource::cancelLoad):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldUsePingLoad):
(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestPingResource):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::isResourceSuitableForDirectReuse):
(WebCore::destinationForType):
* loader/cache/CachedResourceLoader.h:

Source/WebKit:

In case a NetworkResourceLoader has the keepAlive option we do the following:
- Always use NetworkLoadChecker as we might need it to do checks after the Web context is gone.
- In case of aborting a KeepAlive loader, remove it from NetworkConnectionToWebProcess map
and add it to a kept-alive NetworkSession load set. The loader is only kept alive if it
has not yet received a response. Mark the loader as kept-alive.
- In case loader is kept-alive, cancel the load as soon as a response is gathered.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::transferKeptAliveLoad):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::addKeptAliveLoad):
(WebKit::NetworkProcess::removeKeptAliveLoad):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkResourceLoadMap.cpp:
(WebKit::NetworkResourceLoadMap::remove):
(WebKit::NetworkResourceLoadMap::take):
* NetworkProcess/NetworkResourceLoadMap.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):
* NetworkProcess/NetworkResourceLoader.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):
(WebKit::WebLoaderStrategy::usePingLoad const):
* WebProcess/Network/WebLoaderStrategy.h:

LayoutTests:

* TestExpectations:
* http/tests/blink/sendbeacon/beacon-cross-origin.https-expected.txt:
* http/tests/blink/sendbeacon/connect-src-beacon-allowed.html:
* http/tests/security/contentSecurityPolicy/connect-src-beacon-allowed.html:
* http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-connect-src-beacon-redirect-blocked.php:
* http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt:
* http/wpt/beacon/beacon-async-error-logging-expected.txt:
* http/wpt/beacon/beacon-async-error-logging.html:
* http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt:
* http/wpt/beacon/contentextensions/beacon-redirect-blocked-expected.txt:
* http/wpt/beacon/resources/beacon-preflight.py:
(respondToCORSPreflight):
(main):
* platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-report-only-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoMark some cache-storage as slow on iOS-simulator
youenn@apple.com [Fri, 26 Apr 2019 17:47:12 +0000 (17:47 +0000)]
Mark some cache-storage as slow on iOS-simulator
https://bugs.webkit.org/show_bug.cgi?id=197316

Unreviewed.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRemoving test expectation changes for tests no longer timing out
sroberts@apple.com [Fri, 26 Apr 2019 17:38:54 +0000 (17:38 +0000)]
Removing test expectation changes for tests no longer timing out
https://bugs.webkit.org/show_bug.cgi?id=195719

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix Windows build after r244695
achristensen@apple.com [Fri, 26 Apr 2019 17:33:46 +0000 (17:33 +0000)]
Fix Windows build after r244695
       ​https://bugs.webkit.org/show_bug.cgi?id=197165

* loader/PingLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix internal High Sierra build after r244653
achristensen@apple.com [Fri, 26 Apr 2019 17:21:59 +0000 (17:21 +0000)]
Fix internal High Sierra build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

* DerivedSources.make:
-std=gnu++17 didn't exist yet.  -std=gnu++1z did.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
achristensen@apple.com [Fri, 26 Apr 2019 17:03:15 +0000 (17:03 +0000)]
Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
https://bugs.webkit.org/show_bug.cgi?id=197165

Reviewed by Youenn Fablet.

Source/WebCore:

No change in behavior.  This will just make it harder for people working on the loader to mistake
these ContentExtension specific structures for other structures general to loading.
One such mistake was made in r244248.

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
* contentextensions/ContentExtensionsBackend.h:
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::subresourcesAllowReuse const):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
* loader/PingLoader.cpp:
(WebCore::processContentRuleListsForLoad):
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
* loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType): Deleted.
(WebCore::readResourceType): Deleted.
(WebCore::readLoadType): Deleted.
(WebCore::ResourceLoadInfo::isThirdParty const): Deleted.
(WebCore::ResourceLoadInfo::getResourceFlags const): Deleted.
* loader/ResourceLoadInfo.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
* loader/ResourceLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
* page/UserContentProvider.cpp:
(WebCore::UserContentProvider::processContentRuleListsForLoad):
(WebCore::UserContentProvider::actionsForResourceLoad):
* page/UserContentProvider.h:

Tools:

* TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr
don.olmstead@sony.com [Fri, 26 Apr 2019 16:51:48 +0000 (16:51 +0000)]
Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr
https://bugs.webkit.org/show_bug.cgi?id=197291

Reviewed by Konstantin Tokarev.

Source/JavaScriptCore:

Replace uses of strcasestr with WTF::findIgnoringASCIICaseWithoutLength.

* API/tests/testapi.cpp:
* assembler/testmasm.cpp:
* b3/air/testair.cpp:
* b3/testb3.cpp:
* dfg/testdfg.cpp:
* dynbench.cpp:

Source/WTF:

Adds an implementation of strcasestr within WTF.

* wtf/text/StringCommon.h:
(WTF::findIgnoringASCIICaseWithoutLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoReplace iOS build queue hardware
ryanhaddad@apple.com [Fri, 26 Apr 2019 16:48:01 +0000 (16:48 +0000)]
Replace iOS build queue hardware
https://bugs.webkit.org/show_bug.cgi?id=197312

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/config.json:
Use newer hardware that supports macOS Mojave.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix an internal High Sierra build after r244653
achristensen@apple.com [Fri, 26 Apr 2019 16:47:35 +0000 (16:47 +0000)]
Fix an internal High Sierra build after r244653
       ​https://bugs.webkit.org/show_bug.cgi?id=197131

* DerivedSources.make:
Apparently we can't use gnu++17 when preprocessing Platform.h in the makefile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAX: Provide iOS method for setting focus
cfleizach@apple.com [Fri, 26 Apr 2019 16:36:29 +0000 (16:36 +0000)]
AX: Provide iOS method for setting focus
https://bugs.webkit.org/show_bug.cgi?id=197200
<rdar://problem/50131679>

Reviewed by Alex Christensen.

Put the focus setting code in a place that iOS and macOS can access.
Override a platform level method for setting focus on iOS.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilitySetFocus:]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilitySetFocus:]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agopropertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
commit-queue@webkit.org [Fri, 26 Apr 2019 16:32:25 +0000 (16:32 +0000)]
propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
https://bugs.webkit.org/show_bug.cgi?id=197303

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-26
Reviewed by Alex Christensen.

Source/WebCore:

Therefore SVGElement::propertyRegistry() was called instead. This means
these two elements will not have access to the properties of the base
class SVGFilterPrimitiveStandardAttributes.

Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg

* svg/SVGElement.cpp:
(WebCore::SVGElement::commitPropertyChange):
* svg/SVGFEFloodElement.h:
* svg/SVGFEMergeElement.h:

LayoutTests:

* svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added.
* svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244690 268f45cc-cd09-0410-ab3c-d52691b4dbfc