WebKit-https.git
6 years agoREGRESSION(r165704): [GTK] Inspector resources not correctly generated
commit-queue@webkit.org [Wed, 2 Apr 2014 15:38:40 +0000 (15:38 +0000)]
REGRESSION(r165704): [GTK] Inspector resources not correctly generated
https://bugs.webkit.org/show_bug.cgi?id=130343

Patch by Martin Robinson <mrobinson@igalia.com> on 2014-04-02
Reviewed by Gustavo Noronha Silva.

.:

* CMakeLists.txt: Add a variable which points to the directory to store WebInspectorUI
derived sources.
* Source/cmake/WebKitFS.cmake: Generate WebInspectorUI derived sources directories.

Source/JavaScriptCore:

* CMakeLists.txt: We generate the inspector JavaScript file into a directory like the one
in which it should be distributed. This allows us to more easily package it for GTK+.

Source/WebCore:

* CMakeLists.txt: Generate the web inspector JS file into the new WebInspectorUI derived sources
directory.

Source/WebKit2:

* PlatformGTK.cmake: Pass all appropriate directories to the
GResources XML generation script.

Tools:

* gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
of directories on the command line and look for all appropriate files in those directories for the
GResource archive. Also make archive paths relative to those directories.
(find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
(find_all_files_in_directory.select_file): Whether or not to add the file to the archive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r166642.
zalan@apple.com [Wed, 2 Apr 2014 15:29:20 +0000 (15:29 +0000)]
Unreviewed build fix after r166642.
(WinCairo should really turn subpixel layout on.)

* platform/graphics/LayoutSize.h:
(WebCore::flooredForPainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[webkitpy] Avoid multiple "Preparing rollout for bug" log messages
commit-queue@webkit.org [Wed, 2 Apr 2014 15:10:02 +0000 (15:10 +0000)]
[webkitpy] Avoid multiple "Preparing rollout for bug" log messages
https://bugs.webkit.org/show_bug.cgi?id=131106

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-04-02
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/tool/commands/download.py:
(AbstractRolloutPrepCommand._prepare_state):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(test_prepare_rollout):
(test_create_rollout):
(test_create_rollout_resolved):
(test_rollout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd LayoutTest for crash with bidi isolates
ddkilzer@apple.com [Wed, 2 Apr 2014 14:52:23 +0000 (14:52 +0000)]
Add LayoutTest for crash with bidi isolates

Merged from Blink (patch by jww@chromium.org):
https://src.chromium.org/viewvc/blink?revision=156580&view=revision
http://crbug.com/265838

See Bug 120504: Fix nested unicode-bidi: isolate
<https://bugs.webkit.org/show_bug.cgi?id=120504>
<http://trac.webkit.org/changeset/155554>

* fast/text/international/unicode-bidi-isolate-nested-with-removes-expected.txt: Added.
* fast/text/international/unicode-bidi-isolate-nested-with-removes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Make GraphicsContext::drawTiledImage* functions float based.
zalan@apple.com [Wed, 2 Apr 2014 14:37:22 +0000 (14:37 +0000)]
Subpixel rendering: Make GraphicsContext::drawTiledImage* functions float based.
https://bugs.webkit.org/show_bug.cgi?id=131062

Reviewed by Simon Fraser.

This is in preparation to support subpixel positioned/sized background images. Generated images
need to be able to sized on device pixels.

No change in behavior.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Build fix after r166496.
commit-queue@webkit.org [Wed, 2 Apr 2014 14:27:43 +0000 (14:27 +0000)]
[WinCairo] Build fix after r166496.
https://bugs.webkit.org/show_bug.cgi?id=131006

Patch by Alex Christensen <achristensen@webkit.org> on 2014-04-02
Reviewed by Carlos Garcia Campos.

* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
Added std::function<void()> constructors to help Visual Studio decide which version of
GMainLoopSource::schedule or GMainLoopSource::scheduleAfterDelay to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Transition class CSSImageGeneratorValue/class StyleImage (and...
zalan@apple.com [Wed, 2 Apr 2014 14:18:58 +0000 (14:18 +0000)]
Subpixel rendering: Transition class CSSImageGeneratorValue/class StyleImage (and its dependencies) from
IntSize to FloatSize to enable subpixel sized (generated)images.
https://bugs.webkit.org/show_bug.cgi?id=130659

Reviewed by Simon Fraser and Andreas Kling.

This is in preparation to support subpixel positioned/sized background images. Generated images
needs to be able to sized on device pixels.

No change in behavior.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::fixedSize):
(WebCore::CSSCanvasValue::image):
* css/CSSCanvasValue.h:
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
* css/CSSCrossfadeValue.h:
* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::image):
* css/CSSFilterImageValue.h:
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::endPointsFromAngle):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::fixedSize):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
(WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
* css/CSSImageGeneratorValue.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setContainerSizeForRenderer):
* loader/cache/CachedImage.h:
* platform/graphics/FloatSizeHash.h: Added.
(WTF::FloatHash<WebCore::FloatSize>::hash):
(WTF::FloatHash<WebCore::FloatSize>::equal):
(WTF::HashTraits<WebCore::FloatSize>::constructDeletedValue):
(WTF::HashTraits<WebCore::FloatSize>::isDeletedValue):
* platform/graphics/LayoutSize.h:
(WebCore::flooredForPainting):
* rendering/RenderImageResourceStyleImage.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::computePreferredLogicalWidths):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::image):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::imageSize):
(WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
(WebCore::StyleCachedImageSet::image):
* rendering/style/StyleCachedImageSet.h:
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
(WebCore::StyleGeneratedImage::image):
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
* rendering/style/StylePendingImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):
* svg/graphics/SVGImageCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWarning fix for RenderLayer.
commit-queue@webkit.org [Wed, 2 Apr 2014 13:53:32 +0000 (13:53 +0000)]
Warning fix for RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=131090

Patch by Gergo Balogh <gbalogh.u-szeged@partner.samsung.com> on 2014-04-02
Reviewed by Csaba Osztrogonác.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantDependentFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOperator stretching: read the Open Type MATH table
fred.wang@free.fr [Wed, 2 Apr 2014 13:01:34 +0000 (13:01 +0000)]
Operator stretching: read the Open Type MATH table
https://bugs.webkit.org/show_bug.cgi?id=130324

Reviewed by Chris Fleizach.

Source/WebCore:

We parse and expose some data from the OpenType MATH table that will be
be relevant for at least the MathML operator stretching (bug 130322):
math constants, italic corrections and size variants / glyph assembly.
This will be tested when the MathML code uses the data.

* WebCore.xcodeproj/project.pbxproj: Add OpenTypeTypes.h to the Mac build.
* platform/graphics/opentype/OpenTypeMathData.cpp: We implement the low-level parsing of the MATH table.
(WebCore::OpenType::MathItalicsCorrectionInfo::getItalicCorrection):
(WebCore::OpenType::MathGlyphInfo::mathItalicsCorrectionInfo):
(WebCore::OpenType::GlyphAssembly::getAssemblyParts):
(WebCore::OpenType::MathGlyphConstruction::getSizeVariants):
(WebCore::OpenType::MathGlyphConstruction::getAssemblyParts):
(WebCore::OpenType::MathVariants::mathGlyphConstruction):
(WebCore::OpenType::MATHTable::mathConstants):
(WebCore::OpenType::MATHTable::mathGlyphInfo):
(WebCore::OpenType::MATHTable::mathVariants):
(WebCore::OpenTypeMathData::OpenTypeMathData): We load the MATH table.
(WebCore::OpenTypeMathData::getMathConstant): We add a function to get values from the MathConstant subtable.
(WebCore::OpenTypeMathData::getItalicCorrection): We add a function to get italic correction from the MathGlyphInfo subtable.
(WebCore::OpenTypeMathData::getMathVariants): We add a function to get size variants / glyph assembly from the MathVariants subtable.
* platform/graphics/opentype/OpenTypeMathData.h: We expose three new functions to get math data.
* platform/graphics/opentype/OpenTypeTypes.h: We share the coverage tables that are common to vertical and math data.
(WebCore::OpenType::TableWithCoverage::getCoverageIndex): We add a function to get the coverage index from a given glyph.
* platform/graphics/opentype/OpenTypeVerticalData.cpp: We move the coverage tables to OpenTypeTypes.h.

Source/WTF:

* wtf/Platform.h: enable OPENTYPE_MATH on platforms that can read OpenType tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add option to use separate web process for new window in MiniBrowser
commit-queue@webkit.org [Wed, 2 Apr 2014 11:22:33 +0000 (11:22 +0000)]
[EFL] Add option to use separate web process for new window in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=130190

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-04-02
Reviewed by Gyuyoung Kim.

New created window (CTRL + n) will be open in separated web process.
This option is enabled by adding a flag (S/separate-process) with launching
MiniBrowser.

* MiniBrowser/efl/main.c:
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Move NEWS file to a new location
carlosgc@webkit.org [Wed, 2 Apr 2014 09:58:39 +0000 (09:58 +0000)]
[GTK] Move NEWS file to a new location
https://bugs.webkit.org/show_bug.cgi?id=130901

Reviewed by Brent Fulgham.

Source/WebKit2:

* gtk/NEWS: Renamed from Source/WebKit/gtk/NEWS.

Tools:

* gtk/manifest.txt: Update the NEWS file path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Composite all layers into one evas_object using TextureMapper.
commit-queue@webkit.org [Wed, 2 Apr 2014 09:23:10 +0000 (09:23 +0000)]
[EFL] Composite all layers into one evas_object using TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=130969

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-04-02
Reviewed by Gyuyoung Kim.

The EFL port uses two evas_objects to render the entire webpage: backing_store and compositingObject.
backing_store is used to paint a non-composited layer with ewk functions,
whereas compositingObject is used to paint other layers with TextureMapper.
These evas_objects are eventually composited into the window buffer by Evas.

This patch moves to use only one evas_object by integrating these two evas_objects,
and makes that TextureMapper handles all rendering paths like WebKit2.

* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::resize):
(WebCore::AcceleratedCompositingContext::flushAndRenderLayers):
(WebCore::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebCore::AcceleratedCompositingContext::paintToGraphicsContext):
(WebCore::AcceleratedCompositingContext::paintToCurrentGLContext):
(WebCore::AcceleratedCompositingContext::compositeLayers):
(WebCore::AcceleratedCompositingContext::initialize): Deleted.
(WebCore::AcceleratedCompositingContext::canComposite): Deleted.
(WebCore::AcceleratedCompositingContext::compositeLayersToContext): Deleted.
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer): Deleted.
* WebCoreSupport/AcceleratedCompositingContextEfl.h:
(WebCore::AcceleratedCompositingContext::setRootGraphicsLayer):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(_ewk_view_accelerated_compositing_cb):
(_ewk_view_smart_add):
(_ewk_view_smart_resize):
(_ewk_view_smart_calculate):
(_ewk_view_smart_show):
(_ewk_view_smart_hide):
(_ewk_view_smart_flush):
(_ewk_view_smart_zoom_weak_set):
(_ewk_view_smart_zoom_weak_smooth_scale_set):
(ewk_view_bg_color_set):
(ewk_view_scroll):
(ewk_view_root_graphics_layer_set):
(ewk_view_mark_for_sync):
(_ewk_view_scrolls_flush): Deleted.
(_ewk_view_scroll_process): Deleted.
(_ewk_view_smart_scrolls_process): Deleted.
(_ewk_view_smart_repaints_process): Deleted.
(ewk_view_scrolls_process): Deleted.
(_ewk_view_accelerated_compositing_context_create_if_needed): Deleted.
(_ewk_view_accelerated_compositing_object_create_if_needed): Deleted.
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Build fix with GMainLoopSource.
commit-queue@webkit.org [Wed, 2 Apr 2014 09:14:36 +0000 (09:14 +0000)]
[WinCairo] Build fix with GMainLoopSource.
https://bugs.webkit.org/show_bug.cgi?id=131089

Patch by Alex Christensen <achristensen@webkit.org> on 2014-04-02
Reviewed by Carlos Garcia Campos.

* wtf/gobject/GMainLoopSource.cpp:
Only compile if glib is used, which fixes compile errors with video disabled in WinCairo.
* wtf/gobject/GMainLoopSource.h:
Export the GMainLoopSource functions to WTF.dll to link with where they are called in the GStreamer code.
Also removed spaces to appease style bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Drop port check from FindEGL.cmake.
rakuco@webkit.org [Wed, 2 Apr 2014 07:38:02 +0000 (07:38 +0000)]
[CMake] Drop port check from FindEGL.cmake.
https://bugs.webkit.org/show_bug.cgi?id=131091

Reviewed by Gyuyoung Kim.

There is no reason to mark some variables as advanced only for the
GTK+ port.

* Source/cmake/FindEGL.cmake: Mark EGL_INCLUDE_DIR and EGL_LIBRARY
as advanced regardless of the port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Blending] Compositing requirements for blending are not computed correctly
commit-queue@webkit.org [Wed, 2 Apr 2014 07:30:52 +0000 (07:30 +0000)]
[CSS Blending] Compositing requirements for blending are not computed correctly
https://bugs.webkit.org/show_bug.cgi?id=130664

Patch by Ion Rosca <rosca@adobe.com> on 2014-04-02
Reviewed by Dean Jackson.

Source/WebCore:

Tests: css3/compositing/blend-mode-accelerated-with-multiple-stacking-contexts.html
       css3/compositing/blend-mode-with-accelerated-sibling.html

Compositing requirements for blending: if a layer having blend mode
other than normal is composited for any reason, its closest stacking
context ancestor should be composited as well.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h: added a new field,
m_hasUnisolatedCompositedBlendingDescendants, which is true if the layer
has composited blending descendants not isolated by any stacking context child;
added a new method: isolatesCompositedBlending(), which is true if we should
accelerate that layer in order to perform isolation correctly.

* rendering/RenderLayerCompositor.cpp:
(WebCore::CompositingState::CompositingState): m_subtreeHasBlending was renamed
m_hasUnisolatedCompositedBlendingDescendants in order to be more self-explanatory.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
computes the isolation requirements for composited blending by
(re)setting RenderLayer::m_hasUnisolatedCompositedBlendingDescendants flag.

(WebCore::RenderLayerCompositor::reasonsForCompositing):
fixed the reason of compositing: isolation instead of blending.

(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
* rendering/RenderLayerCompositor.h:

LayoutTests:

* css3/compositing/blend-mode-accelerated-with-multiple-stacking-contexts-expected.txt: Added.
* css3/compositing/blend-mode-accelerated-with-multiple-stacking-contexts.html: Added.
* css3/compositing/blend-mode-with-accelerated-sibling-expected.txt: Added.
* css3/compositing/blend-mode-with-accelerated-sibling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOperator stretching: expose a math data API
fred.wang@free.fr [Wed, 2 Apr 2014 07:05:14 +0000 (07:05 +0000)]
Operator stretching: expose a math data API
https://bugs.webkit.org/show_bug.cgi?id=130572

Reviewed by Chris Fleizach.

We expose a new SimpleFontData API to give access to the data from the
OpenType MATH table. The class OpenTypeMathData will
be implemented in bug 130324. On Darwin platform, we also implement the
missing FontPlatformData::openTypeTable function which will be necessary
to load the OpenType MATH table. The changes are intended to be used
for MathML operator stretching (bug 130322) so tests are not added yet.

* CMakeLists.txt: add new OpenTypeMathData files.
* WebCore.vcxproj/WebCore.vcxproj: ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::openTypeTable): We implement openTypeTable() on Darwin platform.
* platform/graphics/FontPlatformData.h: We expose openTypeTable() on Darwin platform.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::mathData): Initialize and return the math data.
* platform/graphics/SimpleFontData.h: We expose a mathData() function to access the MATH data.
* platform/graphics/opentype/OpenTypeMathData.cpp: Added. This is a new class that will be used to parse the data from the OpenType MATH table.
(WebCore::OpenTypeMathData::OpenTypeMathData):
* platform/graphics/opentype/OpenTypeMathData.h: Added.
(WebCore::OpenTypeMathData::create):
(WebCore::OpenTypeMathData::hasMathData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Displaying region's children in another region not supported
mihnea@adobe.com [Wed, 2 Apr 2014 06:29:38 +0000 (06:29 +0000)]
[CSSRegions] Displaying region's children in another region not supported
https://bugs.webkit.org/show_bug.cgi?id=130735

Reviewed by David Hyatt.

Source/WebCore:

With http://trac.webkit.org/changeset/166353, we disabled the possibility
of collecting the region's children into another flow and displaying them
in another region.
I added a new test for this and also changed the plain ASSERT in Element dtor
to ASSERT_WITH_SECURITY_IMPLICATION to better reflect the meaning of the assertion.

Test: fast/regions/region-child-not-flowed.html

* dom/Element.cpp:
(WebCore::Element::~Element):

LayoutTests:

With http://trac.webkit.org/changeset/166353, we disabled the possibility
of collecting the region's children into another flow and displaying them
in another region. With that change, we also skipped the existing tests.

Add a dedicated test that passes if a region child cannot be painted in another region,
in order to complete the skipped tests. This test should be removed when support for
this functionality will be added again.

* fast/regions/region-child-not-flowed-expected.html: Added.
* fast/regions/region-child-not-flowed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Simplify the RenderFlowThread state pusher
abucur@adobe.com [Wed, 2 Apr 2014 05:36:54 +0000 (05:36 +0000)]
[CSS Regions] Simplify the RenderFlowThread state pusher
https://bugs.webkit.org/show_bug.cgi?id=131035

Reviewed by David Hyatt.

The RenderFlowThread state pusher is desynchronized from the RenderView layout state pusher
by one renderer. This patch fixes the anomaly by correctly ordering the push and pop operations
between the two systems.

Tests: no functional change, no new tests.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstRegion):
* rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowillReveal edge events should be hooked up for overflow:scroll
bdakin@apple.com [Wed, 2 Apr 2014 04:49:28 +0000 (04:49 +0000)]
willReveal edge events should be hooked up for overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=131071
-and corresponding-
<rdar://problem/16190392>

Reviewed by Sam Weinig.

Source/WebCore:

This patch moves the will reveal logic from FrameView to Document so that it can
be shared for RenderLayers.

This is mostly just a moved function, but now the function takes an Element* that
represents the target of the event if the target is not the window.
* dom/Document.cpp:
(WebCore::Document::sendWillRevealEdgeEventsIfNeeded):
* dom/Document.h:

No longer implement sendWillRevealEdgeEventsIfNeeded() on FrameView or
ScrollableArea at all. Call into Document instead.
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::sendWillRevealEdgeEventsIfNeeded): Deleted.
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::sendWillRevealEdgeEventsIfNeeded): Deleted.

Call sendWillRevealEdgeEventsIfNeeded() after sending scroll events.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

LayoutTests:

* fast/events/will-reveal-edge-on-div-expected.txt: Added.
* fast/events/will-reveal-edge-on-div.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/16294704> Remove _pageExtendedBackgroundColor entirely
benjamin@webkit.org [Wed, 2 Apr 2014 03:36:29 +0000 (03:36 +0000)]
<rdar://problem/16294704> Remove _pageExtendedBackgroundColor entirely
https://bugs.webkit.org/show_bug.cgi?id=131075

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-01
Reviewed by Beth Dakin.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _pageExtendedBackgroundColor]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients
jhoneycutt@apple.com [Wed, 2 Apr 2014 02:48:14 +0000 (02:48 +0000)]
Crash in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients

<https://bugs.webkit.org/show_bug.cgi?id=121887>
<rdar://problem/15073043>

Reviewed by Dean Jackson.

Source/WebCore:

Test: svg/filters/first-letter-crash.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
Added a null check to prevent crashes for anonymous RenderObjects.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::filterNeedsRepaint):
Get the enclosing element, if there is one, and recalculate its style.
We use the enclosing element so that we recalculate style for the
ancestor of an anonymous RenderElement.
(WebCore::RenderLayer::enclosingElement):
Remove an assertion; we may now reach this condition if loading a
cached SVG document results in RenderLayer::filterNeedsRepaint() being
called before the object has been inserted into the render tree.

* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayer::FilterInfo::notifyFinished):
Tell the RenderLayer that the filter needs repainting.
(WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients):
Get the Element from the renderer rather than asking the renderer's
Element, which will be null for anonymous RenderObjects.

* rendering/RenderLayerFilterInfo.h:
Removed declaration for the old workaround function, layerElement().

LayoutTests:

* svg/filters/first-letter-crash-expected.txt: Added.
* svg/filters/first-letter-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild break when disabled VIDEO since r166261
ryuan.choi@samsung.com [Wed, 2 Apr 2014 02:41:12 +0000 (02:41 +0000)]
Build break when disabled VIDEO since r166261
https://bugs.webkit.org/show_bug.cgi?id=131087

Reviewed by Gyuyoung Kim.

* testing/Internals.cpp: Added ENABLE(VIDEO) guards
(WebCore::Internals::simulateSystemSleep):
(WebCore::Internals::simulateSystemWake):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Scheduler for 32-bit JSC bot.
lforschler@apple.com [Wed, 2 Apr 2014 00:43:20 +0000 (00:43 +0000)]
Add Scheduler for 32-bit JSC bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStub out more WKNavigation properties
andersca@apple.com [Tue, 1 Apr 2014 23:54:44 +0000 (23:54 +0000)]
Stub out more WKNavigation properties
https://bugs.webkit.org/show_bug.cgi?id=131080

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKNavigation.h:
* UIProcess/API/Cocoa/WKNavigation.mm:
(-[WKNavigation initialRequest]):
(-[WKNavigation response]):
(-[WKNavigation error]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Tue, 1 Apr 2014 23:45:12 +0000 (23:45 +0000)]
Fix build.

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename -[WKWebView activeURL] to -[WKWebView URL]
andersca@apple.com [Tue, 1 Apr 2014 23:37:58 +0000 (23:37 +0000)]
Rename -[WKWebView activeURL] to -[WKWebView URL]
https://bugs.webkit.org/show_bug.cgi?id=131077

Reviewed by Tim Horton.

Keep -[WKWebView activeURL] as SPI until no clients depend on it.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView URL]):
(-[WKWebView activeURL]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeActiveURL):
(WebKit::NavigationState::didChangeActiveURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove HeapProfiler from the Web Inspector protocol.
timothy@apple.com [Tue, 1 Apr 2014 23:20:06 +0000 (23:20 +0000)]
Remove HeapProfiler from the Web Inspector protocol.

https://bugs.webkit.org/show_bug.cgi?id=131070

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* inspector/agents/InspectorConsoleAgent.h:
* inspector/agents/JSGlobalObjectConsoleAgent.cpp:
(Inspector::JSGlobalObjectConsoleAgent::addInspectedHeapObject): Deleted.
* inspector/agents/JSGlobalObjectConsoleAgent.h:
* inspector/protocol/Console.json:

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptHeapSnapshot.h: Removed.
* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::takeHeapSnapshot): Deleted.
(WebCore::ScriptProfiler::isSampling): Deleted.
(WebCore::ScriptProfiler::hasHeapProfiler): Deleted.
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorHeapProfilerAgent.cpp: Removed.
* inspector/InspectorHeapProfilerAgent.h: Removed.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::removeProfile):
(WebCore::InspectorProfilerAgent::resetState): The CommandLineAPIHost call to
clear inspected objects should have not been here. It was only needed by the
HeapProfilerAgent.
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::collectGarbage): Deleted.
(WebCore::InspectorProfilerAgent::createSnapshotHeader): Deleted.
(WebCore::InspectorProfilerAgent::isSampling): Deleted.
(WebCore::InspectorProfilerAgent::hasHeapProfiler): Deleted.
(WebCore::InspectorProfilerAgent::getHeapSnapshot): Deleted.
(WebCore::InspectorProfilerAgent::takeHeapSnapshot): Deleted.
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId): Deleted.
(WebCore::InspectorProfilerAgent::getHeapObjectId): Deleted.
* inspector/InspectorProfilerAgent.h:
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorHeapProfilerAgent): Deleted.
(WebCore::InstrumentingAgents::setInspectorHeapProfilerAgent): Deleted.
* inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::addInspectedHeapObject): Deleted.
* inspector/WebConsoleAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
* inspector/protocol/HeapProfiler.json: Removed.
* inspector/protocol/Profiler.json:

Source/WebInspectorUI:

* UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js: Updated.
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js: Ditto.
* Versions/Inspector-iOS-6.0.json: Removed heap related stuff.
* Versions/Inspector-iOS-7.0.json: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove -[WKWebView stopLoading:] back to WKIBActions
andersca@apple.com [Tue, 1 Apr 2014 23:00:54 +0000 (23:00 +0000)]
Move -[WKWebView stopLoading:] back to WKIBActions
https://bugs.webkit.org/show_bug.cgi?id=131072

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Remove stale localStorage deletion transition code
commit-queue@webkit.org [Tue, 1 Apr 2014 22:18:07 +0000 (22:18 +0000)]
Web Inspector: Remove stale localStorage deletion transition code
https://bugs.webkit.org/show_bug.cgi?id=131061

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-04-01
Reviewed by Timothy Hatcher.

* UserInterface/Base/ImageUtilities.js:
This code has been in for a while. We have transitioned to Web SQL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed test gardening.
bfulgham@apple.com [Tue, 1 Apr 2014 22:18:06 +0000 (22:18 +0000)]
Unreviewed test gardening.

* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Exclusions] Remove exclusions parsing support
zoltan@webkit.org [Tue, 1 Apr 2014 22:13:34 +0000 (22:13 +0000)]
[CSS Exclusions] Remove exclusions parsing support
https://bugs.webkit.org/show_bug.cgi?id=131046

Reviewed by David Hyatt.

Source/WebCore:

CSS Exclusions specification [1] needs some evolution before the actual implementation happens.
We have only the parsing code in WebKit for -webkit-wrap-flow and -webkit-wrap-through.
This patch removes the code from the trunk for now, it doesn't make sense to keep it around.

[1] http://www.w3.org/TR/css3-exclusions/

Removed existing parsing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted.
(WebCore::CSSPrimitiveValue::operator WrapFlow): Deleted.
(WebCore::CSSPrimitiveValue::operator WrapThrough): Deleted.
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

Source/WebInspectorUI:

* UserInterface/Models/CSSKeywordCompletions.js:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

* fast/exclusions/css-exclusions-disabled-expected.txt: Removed.
* fast/exclusions/css-exclusions-disabled.html: Removed.
* fast/exclusions/css-exclusions-enabled-expected.txt: Removed.
* fast/exclusions/css-exclusions-enabled.html: Removed.
* fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Removed.
* fast/exclusions/parsing/parsing-wrap-flow.html: Removed.
* fast/exclusions/parsing/parsing-wrap-through-expected.txt: Removed.
* fast/exclusions/parsing/parsing-wrap-through.html: Removed.
* fast/exclusions/parsing/script-tests/parsing-test-utils.js: Removed.
* fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Removed.
* fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Removed.
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMigrate more headers
andersca@apple.com [Tue, 1 Apr 2014 22:03:31 +0000 (22:03 +0000)]
Migrate more headers
https://bugs.webkit.org/show_bug.cgi?id=131068

Reviewed by Tim Horton.

Source/WebKit/mac:

* MigrateHeaders.make:

Source/WebKit2:

* UIProcess/API/Cocoa/WKBackForwardList.h:
Remove a newline.

* WebKit2.xcodeproj/project.pbxproj:
Move files from the "Deprecated" group.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the rest of the old Canvas inspection support.
timothy@apple.com [Tue, 1 Apr 2014 22:02:15 +0000 (22:02 +0000)]
Remove the rest of the old Canvas inspection support.

https://bugs.webkit.org/show_bug.cgi?id=131066

Reviewed by Joseph Pecoraro.

Source/WebCore:

* CMakeLists.txt: Removed Canvas.json.
* DerivedSources.make: Ditto.
* inspector/InjectedScriptCanvasModuleSource.js: Removed.
* inspector/protocol/Canvas.json: Removed.

Source/WebInspectorUI:

* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js: Updated.
* Versions/Inspector-iOS-7.0.json: Removed Canvas domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEliminate HTMLFormElement::m_shouldSubmit
ap@apple.com [Tue, 1 Apr 2014 21:57:15 +0000 (21:57 +0000)]
Eliminate HTMLFormElement::m_shouldSubmit
https://bugs.webkit.org/show_bug.cgi?id=131055

Reviewed by Tim Horton.

m_shouldSubmit was used for two purposes:
- as a return value in a function whose return value is ignored by all callers;
- to make a decision that's local to a function.

There is no need for it to be an instance variable.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::prepareForSubmission):
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Enable runtime feature if feature flag is enabled
rego@igalia.com [Tue, 1 Apr 2014 21:57:12 +0000 (21:57 +0000)]
[CSS Grid Layout] Enable runtime feature if feature flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=130013

Reviewed by Simon Fraser.

Source/WebKit/mac:

Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Source/WebKit2:

Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.

* Shared/WebPreferencesStore.h:

LayoutTests:

Modify layout test as feature is not disabled by default in WK2.
The test now checks that the runtime feature can be disabled.

* fast/css-grid-layout/grid-disabled-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt.
* fast/css-grid-layout/grid-disabled.html: Renamed from LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDemote WKBackForwardListDidChangeNotification to SPI
andersca@apple.com [Tue, 1 Apr 2014 21:35:54 +0000 (21:35 +0000)]
Demote WKBackForwardListDidChangeNotification to SPI
https://bugs.webkit.org/show_bug.cgi?id=131059

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKBackForwardList.h:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
* UIProcess/API/Cocoa/WKBackForwardListInternal.h:
* UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h.
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didChangeBackForwardList):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add SPI to determine if a WKWebView is displaying a PDF
aestes@apple.com [Tue, 1 Apr 2014 21:29:48 +0000 (21:29 +0000)]
[Cocoa] Add SPI to determine if a WKWebView is displaying a PDF
https://bugs.webkit.org/show_bug.cgi?id=131063

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isDisplayingPDF]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove some explicit template instantiations from logging code
simon.fraser@apple.com [Tue, 1 Apr 2014 21:27:35 +0000 (21:27 +0000)]
Remove some explicit template instantiations from logging code
https://bugs.webkit.org/show_bug.cgi?id=131065

Reviewed by Tim Horton.

No need to explicitly state template types.

* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpChangedLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
commit-queue@webkit.org [Tue, 1 Apr 2014 21:22:56 +0000 (21:22 +0000)]
[CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
https://bugs.webkit.org/show_bug.cgi?id=130935

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-04-01
Reviewed by Darin Adler.

Removed the 'checkLayout' script references from the test.

* fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html: Added.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.txt: Removed.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove last reference to GTK+ WK1 EWS
rego@igalia.com [Tue, 1 Apr 2014 21:21:41 +0000 (21:21 +0000)]
[GTK] Remove last reference to GTK+ WK1 EWS
https://bugs.webkit.org/show_bug.cgi?id=131058

Reviewed by Martin Robinson.

In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.

* QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a 32bit JSC builder/tester.
lforschler@apple.com [Tue, 1 Apr 2014 21:09:04 +0000 (21:09 +0000)]
Add a 32bit JSC builder/tester.
https://bugs.webkit.org/show_bug.cgi?id=131054

Reviewed by Michael Saboff.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Compile32bitJSC):
(Run32bitJSCTests):
(Run32bitJSCTests.countFailures):
(BuildAndTest32bitJSCFactory):
(BuildAndTest32bitJSCFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS WebKit2] Partial repaint is broken
timothy_horton@apple.com [Tue, 1 Apr 2014 20:47:18 +0000 (20:47 +0000)]
[iOS WebKit2] Partial repaint is broken
https://bugs.webkit.org/show_bug.cgi?id=131056

Reviewed by Dean Jackson.

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
We need to check if the repaint rects themselves cover the whole
layer's surface, not just their bounds. Otherwise, we'll optimize
out the back->front copy and end up not painting the whole layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPass a WKNavigationAction to the create UIDelegate method
andersca@apple.com [Tue, 1 Apr 2014 20:35:47 +0000 (20:35 +0000)]
Pass a WKNavigationAction to the create UIDelegate method
https://bugs.webkit.org/show_bug.cgi?id=131053

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKUIDelegate.h:
* UIProcess/Cocoa/UIClient.h:
* UIProcess/Cocoa/UIClient.mm:
(WebKit::UIClient::setDelegate):
(WebKit::UIClient::createNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
benjamin@webkit.org [Tue, 1 Apr 2014 20:33:13 +0000 (20:33 +0000)]
[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
https://bugs.webkit.org/show_bug.cgi?id=131009

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-01
Reviewed by Sam Weinig.

The two finger pan should not block the pinch gesture recognizer.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _twoFingerPanRecognized:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove a couple of useless static strings
benjamin@webkit.org [Tue, 1 Apr 2014 20:32:33 +0000 (20:32 +0000)]
Remove a couple of useless static strings
https://bugs.webkit.org/show_bug.cgi?id=131003

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-01
Reviewed by David Kilzer.

There is zero value in keeping those strings alive.

* css/StyleProperties.cpp:
(WebCore::isInitialOrInherit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agosvg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face...
mmaxfield@apple.com [Tue, 1 Apr 2014 20:05:08 +0000 (20:05 +0000)]
svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html frequently assert in ComplexTextController::offsetForPosition
https://bugs.webkit.org/show_bug.cgi?id=119747

Reviewed by Simon Fraser.

Source/WebCore:

Even though kerning and ligatures currently don't work with the
simple text path, messing those up is better than creating null
CTRun and CTLine objects.

Rather than calling the badly-named renderingContext() function on TextRun objects
to determine if they are drawn with an SVG font, this patch creates a wrapper function
with a better name and uses that instead.

Test: svg/text/svg-font-hittest.html

* platform/graphics/Font.cpp:
(WebCore::isDrawnWithSVGFont): Wrapper around renderingContext()
(WebCore::Font::drawText): Use wrapper function
(WebCore::Font::drawEmphasisMarks): Use wrapper function
(WebCore::Font::width): Use wrapper function
(WebCore::Font::selectionRectForText): Use wrapper function
(WebCore::Font::offsetForPosition): If we are using an SVG font, use the simple path
instead of the complex one
(WebCore::Font::codePath): Use wrapper function
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):

LayoutTests:

Clicking on SVG text used to cause a ComplexTextController to be built
around the SVG text (which is incorrect and would crash). This test
does just that and makes sure there is no crash.

* svg/text/resources/Litherum.svg: Added.
* svg/text/svg-font-hittest-expected.txt: Added.
* svg/text/svg-font-hittest.html: Added.
* LayoutTests/platform/mac/TestExpectations: Unskipped tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove limits from WKBackForwardList getters
andersca@apple.com [Tue, 1 Apr 2014 19:53:04 +0000 (19:53 +0000)]
Remove limits from WKBackForwardList getters
https://bugs.webkit.org/show_bug.cgi?id=131052

Reviewed by Beth Dakin.

* UIProcess/API/Cocoa/WKBackForwardList.h:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backList]):
(-[WKBackForwardList forwardList]):
(-[WKBackForwardList backListCount]): Deleted.
(-[WKBackForwardList forwardListCount]): Deleted.
(-[WKBackForwardList backListWithLimit:]): Deleted.
(-[WKBackForwardList forwardListWithLimit:]): Deleted.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backList):
(WebKit::WebBackForwardList::forwardList):
* UIProcess/WebBackForwardList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderQuote must destroy remaining text renderer before first letter renderer
dbates@webkit.org [Tue, 1 Apr 2014 19:38:13 +0000 (19:38 +0000)]
RenderQuote must destroy remaining text renderer before first letter renderer
https://bugs.webkit.org/show_bug.cgi?id=78023
<rdar://problem/10830009>

Reviewed by Brent Fulgham.

Merged from Blink (patch by Abhishek Arya):
https://src.chromium.org/viewvc/blink?view=rev&revision=151270

Source/WebCore:

Following the fix for <https://bugs.webkit.org/show_bug.cgi?id=114586>, a
RenderQuote may have child render objects for the first letter of its text
and everything following the first letter so as to support the CSS first-
letter property. The latter renderer is responsible for destroying the former
on destruction. It's sufficient to reverse the destruction of the children of
RenderQuote to ensure that we destroy the remaining text renderer before we
destroy the first letter renderer.

Test: fast/css-generated-content/quote-first-letter-crash.html

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateText):

LayoutTests:

* fast/css-generated-content/quote-first-letter-crash-expected.txt: Added.
* fast/css-generated-content/quote-first-letter-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo not allow HTTP refresh headers to refresh to javascript: URLs
ddkilzer@apple.com [Tue, 1 Apr 2014 19:21:34 +0000 (19:21 +0000)]
Do not allow HTTP refresh headers to refresh to javascript: URLs
<http://webkit.org/b/119051>
<rdar://problem/14536453>

Reviewed by Alexey Proskuryakov.

Merged from Blink (patch by tsepez@chromium.org):
https://src.chromium.org/viewvc/blink?revision=153912&view=revision
http://crbug.com/258151

    This behaviour has been standard in IE since IE7.  This makes us both
    more compatible and less vulnerable to XSS.

Source/WebCore:

Tests: http/tests/security/no-javascript-location-percent-escaped.html
       http/tests/security/no-javascript-location.html
       http/tests/security/no-javascript-refresh-percent-escaped.php
       http/tests/security/no-javascript-refresh-spaces.php
       http/tests/security/no-javascript-refresh-static-percent-escaped.html
       http/tests/security/no-javascript-refresh-static-spaces.html
       http/tests/security/no-javascript-refresh-static.html
       http/tests/security/no-javascript-refresh.php

* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
- Do not fire meta http refresh for a javascript: URL protocol.

LayoutTests:

* http/tests/security/no-javascript-refresh-expected.txt: Added.
* http/tests/security/no-javascript-refresh-static-expected.txt: Added.
* http/tests/security/no-javascript-refresh-static.html: Added.
* http/tests/security/no-javascript-refresh.php: Added.
- Original Blink layout tests with typos fixed and 'PASS:' text
  added.

* http/tests/security/no-javascript-location.html: Added.
* http/tests/security/no-javascript-location-expected.txt: Added.
* http/tests/security/resources/no-javascript-location.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php.
* http/tests/security/no-javascript-location-percent-escaped.html: Added.
* http/tests/security/no-javascript-location-percent-escaped-expected.txt: Added.
* http/tests/security/resources/no-javascript-location-percent-escaped.php: Added.
- Add tests using a javascript: URL in a Location: header.

* http/tests/security/no-javascript-refresh-percent-escaped.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php.
* http/tests/security/no-javascript-refresh-percent-escaped-expected.txt: Added.
* http/tests/security/no-javascript-refresh-spaces.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php.
* http/tests/security/no-javascript-refresh-spaces-expected.txt: Added.
- Add tests using a percent-escaped javascript: URL and a
  javascript: URL with leading spaces in a Refresh: header from
  a web server.

* http/tests/security/no-javascript-refresh-static-percent-escaped.html: Added.
* http/tests/security/no-javascript-refresh-static-percent-escaped-expected.txt: Added.
* http/tests/security/no-javascript-refresh-static-spaces.html: Added.
* http/tests/security/no-javascript-refresh-static-spaces-expected.txt: Added.
- Add tests using a percent-escaped javascript: URL and a
  javascript: URL with leading spaces in a meta http-equiv tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix. Remove duplicate file entries.
psolanki@apple.com [Tue, 1 Apr 2014 19:07:58 +0000 (19:07 +0000)]
Unreviewed build fix. Remove duplicate file entries.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStub out the web process -> UI process message SPI
andersca@apple.com [Tue, 1 Apr 2014 18:48:31 +0000 (18:48 +0000)]
Stub out the web process -> UI process message SPI
https://bugs.webkit.org/show_bug.cgi?id=131048

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _userContentController]):
(-[WKWebViewConfiguration _setUserContentController:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/Cocoa/_WKScriptMessage.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
* UIProcess/API/Cocoa/_WKScriptMessage.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
(-[_WKScriptMessage body]):
(-[_WKScriptMessage originatingWebView]):
* UIProcess/API/Cocoa/_WKScriptMessageHandler.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
* UIProcess/API/Cocoa/_WKScriptWorld.h:
* UIProcess/API/Cocoa/_WKUserContentController.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
* UIProcess/API/Cocoa/_WKUserContentController.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h.
(-[_WKUserContentController addScriptMessageHandler:name:world:]):
(-[_WKUserContentController removeScriptMessageHandler:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInvalidate CFNetwork connection cache on memory pressure.
akling@apple.com [Tue, 1 Apr 2014 17:45:02 +0000 (17:45 +0000)]
Invalidate CFNetwork connection cache on memory pressure.
<https://webkit.org/b/131038>

Stop holding on to cached HTTP connections if we come under memory pressure.

Reviewed by Geoff Malloc-Garen.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformLowMemoryHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTweak WKPreferences API
andersca@apple.com [Tue, 1 Apr 2014 17:39:11 +0000 (17:39 +0000)]
Tweak WKPreferences API
https://bugs.webkit.org/show_bug.cgi?id=131047

Reviewed by Simon Fraser.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
(-[WKPreferences initWithUserDefaultsKeyPrefix:]):
(-[WKPreferences userDefaultsKeyPrefix]):
(-[WKPreferences initWithUserDefaultsPrefixKey:]): Deleted.
(-[WKPreferences userDefaultsPrefixKey]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable WEB_TIMING on Mac and iOS
simon.fraser@apple.com [Tue, 1 Apr 2014 17:08:54 +0000 (17:08 +0000)]
Enable WEB_TIMING on Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=128064

Source/JavaScriptCore:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING. Add PerformanceTiming.cpp and JSPerformanceTiming.cpp
to the project.

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if
commit-queue@webkit.org [Tue, 1 Apr 2014 16:36:45 +0000 (16:36 +0000)]
AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if
roleValue is ApplicationAlertRole || ApplicationStatusRole
https://bugs.webkit.org/show_bug.cgi?id=130907

Patch by James Craig <jcraig@apple.com> on 2014-04-01
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html:
       platform/mac/accessibility/aria-liveregions-attributes.html:

Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):

LayoutTests:

Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec.

* inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html:
* platform/mac/accessibility/aria-liveregions-attributes-expected.txt:
* platform/mac/accessibility/aria-liveregions-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html...
ossy@webkit.org [Tue, 1 Apr 2014 16:32:41 +0000 (16:32 +0000)]
[EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html and Dromaeo performance tests crash
https://bugs.webkit.org/show_bug.cgi?id=131039

Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-04-01
Reviewed by Csaba Osztrogonác.

* wtf/Platform.h: Disable CSS JIT on EFL until proper fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the !ENABLE(BATTERY_STATUS) build
dbatyai.u-szeged@partner.samsung.com [Tue, 1 Apr 2014 16:18:38 +0000 (16:18 +0000)]
Fix the !ENABLE(BATTERY_STATUS) build
https://bugs.webkit.org/show_bug.cgi?id=130183

Reviewed by Anders Carlsson.

* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r166583.
commit-queue@webkit.org [Tue, 1 Apr 2014 16:04:46 +0000 (16:04 +0000)]
Unreviewed, rolling out r166583.
https://bugs.webkit.org/show_bug.cgi?id=131040

It's causing frequent crashes when running Layout Tests
(Requested by svillar on #webkit).

Reverted changeset:

"[GTK][Cmake] Enable CSS JIT"
https://bugs.webkit.org/show_bug.cgi?id=131022
http://trac.webkit.org/changeset/166583

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fixing debug builds after r166586.
zandobersek@gmail.com [Tue, 1 Apr 2014 15:47:47 +0000 (15:47 +0000)]
Unreviewed. Fixing debug builds after r166586.

* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener): Fix the ASSERT.
(WebCore::SVGElement::removeEventListener): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPrevent unnecessary copies in compareEqual template
zandobersek@gmail.com [Tue, 1 Apr 2014 15:35:46 +0000 (15:35 +0000)]
Prevent unnecessary copies in compareEqual template
https://bugs.webkit.org/show_bug.cgi?id=131014

Reviewed by Antti Koivisto.

* rendering/style/RenderStyle.h:
(compareEqual): Casting the second parameter to a non-const, non-reference type
causes an extra copy of that object. Casting to the const reference type of the
first parameter avoids that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[UI-side compositing] Fix animations, and add logging
simon.fraser@apple.com [Tue, 1 Apr 2014 15:29:16 +0000 (15:29 +0000)]
[UI-side compositing] Fix animations, and add logging
https://bugs.webkit.org/show_bug.cgi?id=131011

Reviewed by Tim Horton.

UI-side animations were broken because GraphicsLayerCARemote::addAnimation()
never called the superclass, so fix.

Add logging for animations to the layer tree commit output.

* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpProperty):
(WebKit::RemoteLayerTreeTextStream::operator<<):
(WebKit::dumpChangedLayers):
* WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix after r166582.
zalan@apple.com [Tue, 1 Apr 2014 15:28:36 +0000 (15:28 +0000)]
Build fix after r166582.

* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid unnecessary HashSet copies when calling collectInstancesForSVGElement
zandobersek@gmail.com [Tue, 1 Apr 2014 15:22:36 +0000 (15:22 +0000)]
Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement
https://bugs.webkit.org/show_bug.cgi?id=131020

Reviewed by Andreas Kling.

Remove collectInstancesForSVGElement() to avoid HashSet copies when assigning a const
HashSet reference to a non-const HashSet reference. Instead, range-based for-loops are
deployed to iterate directly over the const reference to HashSet that's returned by
SVGElement::instancesForElement(). SVGElement::containingShadowRoot() return value
is checked to see if the iteration should be performed in the first place, preserving
the behavior of collectInstancesForSVGElement().

* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
(WebCore::collectInstancesForSVGElement): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove the attributes HashMap out of the parseAttributes function
zandobersek@gmail.com [Tue, 1 Apr 2014 15:20:40 +0000 (15:20 +0000)]
Move the attributes HashMap out of the parseAttributes function
https://bugs.webkit.org/show_bug.cgi?id=131019

Reviewed by Andreas Kling.

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::parseAttributes): Avoid copying the HashMap object that's being returned by
converting it to an xvalue through using std::move() in the return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] No longer build WebKit1 gtkdoc
mrobinson@webkit.org [Tue, 1 Apr 2014 15:13:40 +0000 (15:13 +0000)]
[GTK] No longer build WebKit1 gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=130970

Reviewed by Anders Carlsson.

* gtk/common.py:
(gtk_version_of_pkg_config_file): Deleted.
* gtk/generate-gtkdoc:
(get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
was only applicable for WebKit1.
(get_generator_for_config): No longer look for the WebKit1 configuration file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][Cmake] Enable CSS JIT
commit-queue@webkit.org [Tue, 1 Apr 2014 14:32:44 +0000 (14:32 +0000)]
[GTK][Cmake] Enable CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=131022

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-04-01
Reviewed by Martin Robinson.

* wtf/Platform.h: Enable CSS JIT for GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Transition class Image (and its dependencies) from int to float...
zalan@apple.com [Tue, 1 Apr 2014 14:17:58 +0000 (14:17 +0000)]
Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images.
https://bugs.webkit.org/show_bug.cgi?id=130643

Reviewed by Simon Fraser.

This is in preparation to support subpixel positioned/sized background images. While 1x bitmap images can't take
subpixel sizing on hidpi resolutions, both generated and hidpi images can.
This patch does not change Image behavior in general as both position and size are still snapped to integral values.

No change in behavior.

Source/WebCore:

* WebCore.exp.in:
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::fixedSize):
* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::drawImageIntoBuffer):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
* platform/Cursor.cpp:
(WebCore::determineHotSpot):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::size):
(WebCore::BitmapImage::currentFrameSize):
* platform/graphics/BitmapImage.h:
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/GeneratedImage.h:
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::adjustParametersForTiledDrawing):
* platform/graphics/Gradient.h:
* platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.cpp:
(WebCore::Image::adjustSourceRectForDownSampling):
* platform/graphics/Image.h:
(WebCore::Image::setContainerSize):
(WebCore::Image::rect):
(WebCore::Image::width):
(WebCore::Image::height):
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
* platform/graphics/IntPoint.cpp:
(WebCore::IntPoint::IntPoint):
* platform/graphics/IntPoint.h:
* platform/graphics/IntSize.cpp:
(WebCore::IntSize::IntSize):
* platform/graphics/IntSize.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cg/ImageBufferDataCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::size):
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
(WebCore::applyRotationForPainting):
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/mac/GraphicsContextMac.mm:
* platform/graphics/mac/IconMac.mm:
* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/mac/DragImageMac.mm:
(WebCore::createDragImageFromImage):
* platform/win/DragImageCGWin.cpp:
(WebCore::createDragImageFromImage):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer):
* svg/graphics/SVGImageCache.h:
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::size):
* svg/graphics/SVGImageForContainer.h:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::externalRepresentation):
* testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeImage):
* UIProcess/API/efl/EwkView.cpp:
(EwkView::updateCursor):

LayoutTests:

* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
* svg/custom/feDisplacementMap-01-expected.txt:
* svg/filters/feImage-change-target-id-expected.txt:
* svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt:
* svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt:
* svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt:
* svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt:
* svg/filters/feImage-late-indirect-update-expected.txt:
* svg/filters/feImage-multiple-targets-id-change-expected.txt:
* svg/filters/feImage-position-expected.txt:
* svg/filters/feImage-preserveAspectRatio-all-expected.txt:
* svg/filters/feImage-preserveAspectratio-expected.txt:
* svg/filters/feImage-reference-invalidation-expected.txt:
* svg/filters/feImage-reference-svg-primitive-expected.txt:
* svg/filters/feImage-remove-target-expected.txt:
* svg/filters/feImage-subregions-expected.txt:
* svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt:
* svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt:
* svg/filters/feImage-target-add-to-document-expected.txt:
* svg/filters/feImage-target-attribute-change-expected.txt:
* svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
* svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
* svg/filters/feImage-target-changes-id-expected.txt:
* svg/filters/feImage-target-id-change-expected.txt:
* svg/filters/feImage-target-inline-style-change-expected.txt:
* svg/filters/feImage-target-property-change-expected.txt:
* svg/filters/feImage-target-reappend-to-document-expected.txt:
* svg/filters/feImage-target-remove-from-document-expected.txt:
* svg/filters/feImage-target-style-change-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Running minibrowser with url crashes in debug build
mario.prada@samsung.com [Tue, 1 Apr 2014 12:36:48 +0000 (12:36 +0000)]
[GTK] Running minibrowser with url crashes in debug build
https://bugs.webkit.org/show_bug.cgi?id=130492

Reviewed by Martin Robinson.

Update "uri-scheme" test not to use invalid URIs in it, so we
don't get a mistmatch when comparing the original URI stored in
the test class with the one returned by the WebKitWebView.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextURIScheme): Update the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_asy...
commit-queue@webkit.org [Tue, 1 Apr 2014 11:38:37 +0000 (11:38 +0000)]
[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API
https://bugs.webkit.org/show_bug.cgi?id=131017

Patch by Joonghun Park <jh718.park@samsung.com> on 2014-04-01
Reviewed by Gyuyoung Kim.

* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
Fix memory leaks and errors caused by duplication of Ecore_Timer deletion
as well as update a naming style of local variable.
(EWK2DatabaseManagerTest::databaseOriginsCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't copy the children map in webkitWebViewBaseContainerForall
zandobersek@gmail.com [Tue, 1 Apr 2014 09:11:14 +0000 (09:11 +0000)]
Don't copy the children map in webkitWebViewBaseContainerForall
https://bugs.webkit.org/show_bug.cgi?id=131016

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerForall): Avoid copying the GtkWidget-to-IntRect HashMap object
by transforming the iteration to a range-based for-loop over that HashMap's keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
zandobersek@gmail.com [Tue, 1 Apr 2014 09:07:25 +0000 (09:07 +0000)]
[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
https://bugs.webkit.org/show_bug.cgi?id=131015

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
That function already returns a reference, so the return value should be stored accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd myself as a commiter.
mitica@adobe.com [Tue, 1 Apr 2014 09:04:45 +0000 (09:04 +0000)]
Add myself as a commiter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CoordinatedGraphics] Content scale factor should not be applied to draw contents...
eunmi15.lee@samsung.com [Tue, 1 Apr 2014 08:34:12 +0000 (08:34 +0000)]
[CoordinatedGraphics] Content scale factor should not be applied to draw contents when fixed layout is not used.
https://bugs.webkit.org/show_bug.cgi?id=130962

Reviewed by Gyuyoung Kim.

Delegating scaling is turned off when fixed layout is not used in the
coordinated graphics, so page scale factor is applied to the contents
directly.
In that case, we should not apply page scale factor to coordinated
graphics to draw contents and calculate visible content rect.

Currently, page scale factor is applied twice to the coordinated
graphics and contents, so result of scaling is abnormal.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::transformToScene):
(WebKit::WebView::visibleContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Rename ewk_application_cache_manager_delete{_all}
ryuan.choi@samsung.com [Tue, 1 Apr 2014 08:01:26 +0000 (08:01 +0000)]
[EFL][WK2] Rename ewk_application_cache_manager_delete{_all}
https://bugs.webkit.org/show_bug.cgi?id=131012

Reviewed by Gyuyoung Kim.

While discussing Bug 130577, we resulted that _clear and _xxx_del is better name for the EFL.
This patch will rename similar API in ewk_application_cache_manager.

In addition, fixed some typos in doxygen.

* UIProcess/API/efl/ewk_application_cache_manager.cpp:
(ewk_application_cache_manager_clear): Renamed from ewk_application_cache_manager_delete_all
(ewk_application_cache_manager_entries_for_origin_del): Renamed from ewk_application_cache_manager_delete
(ewk_application_cache_manager_delete_all): Deleted.
(ewk_application_cache_manager_delete): Deleted.
* UIProcess/API/efl/ewk_application_cache_manager.h:
* UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix when disabled ACCESSIBILITY
ryuan.choi@samsung.com [Tue, 1 Apr 2014 07:41:42 +0000 (07:41 +0000)]
Unreviewed build fix when disabled ACCESSIBILITY

* accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:
Separated macros not to check ATK version when disabled ACCESSIBILITY

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake][EFL] Enable CSS JIT
gyuyoung.kim@samsung.com [Tue, 1 Apr 2014 07:38:06 +0000 (07:38 +0000)]
[CMake][EFL] Enable CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=131010

Reviewed by Benjamin Poulain.

Source/WebCore:

Add an inclusion path for enabling CSS JIT on EFL and GTK ports.
This patch only enables it for EFL port.

* CMakeLists.txt:

Source/WTF:

* wtf/Platform.h: Enable CSS JIT for EFL port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
mrobinson@webkit.org [Tue, 1 Apr 2014 07:28:14 +0000 (07:28 +0000)]
[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=130978

Reviewed by Carlos Garcia Campos.

Unify how we decide if an attribute is readable or writeable and improve the code.
This results in some attributes now being marked as read-only which didn't have
corresponding case statements in the set_property switch statements and also correctly
installs set_property support for some more POD types.

* bindings/scripts/CodeGeneratorGObject.pm:
(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
update the list of types to reflect the full list of types we can generate setters for.
(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
(GenerateProperties): Use grep and the new helpers to simplify the code.
(GetReadableProperties): Deleted.
(GetWriteableProperties): Deleted.
* bindings/scripts/test/GObject: Update results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix after r166553.
zandobersek@gmail.com [Tue, 1 Apr 2014 06:34:18 +0000 (06:34 +0000)]
Unreviewed GTK build fix after r166553.

* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Pass 'WebKit2.' as the second argument to WebPreferences::create().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Extract the control of page background out of color_set
ryuan.choi@samsung.com [Tue, 1 Apr 2014 06:09:55 +0000 (06:09 +0000)]
[EFL][WK2] Extract the control of page background out of color_set
https://bugs.webkit.org/show_bug.cgi?id=127539

Reviewed by Gyuyoung Kim.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
Added m_viewBackgroundColor to clear when m_setDrawsBackground is false.
(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore::CoordinatedGraphicsScene::setViewBackgroundColor):
(WebCore::CoordinatedGraphicsScene::viewBackgroundColor):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
Added EFL guard not to set opaque as a default for MainFrameRenderViewLayer.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
Added EFL guard to apply page scale on RenderView like IOS.

Source/WebKit2:

EFL have a way to change the color using evas_object_color_set and we used it to change background.
But, We should not use it because the alpha value of color_set is used
for the transparancy of object itself including background and contents.

This patch added ewk_view_bg_color_{get|set} to change the background color.

* UIProcess/API/C/efl/WKViewEfl.cpp:
Extracted controls of page background out of color_set.
color_set will be only used for the opacity of whole contents.
(WKViewSetBackgroundColor): Added to share page background color.
(WKViewGetBackgroundColor):
* UIProcess/API/C/efl/WKViewEfl.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::handleEvasObjectColorSet):
* UIProcess/API/efl/ewk_view.cpp:
Removed ewk_view_draws_page_background_set which just control whether to draw background.
ewk_view_bg_color_set will conver it.
(ewk_view_bg_color_set):
(ewk_view_bg_color_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp: Added simple test case.
* UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::setViewBackgroundColor):
(WebKit::WebViewEfl::viewBackgroundColor):
* UIProcess/efl/WebViewEfl.h:

Tools:

Added an option(C) to change background color.

* MiniBrowser/efl/main.c:
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2]Implement ewk APIs of web local storage which have deletion functions of...
commit-queue@webkit.org [Tue, 1 Apr 2014 06:01:28 +0000 (06:01 +0000)]
[EFL][WK2]Implement ewk APIs of web local storage which have deletion functions of the local storage entries
https://bugs.webkit.org/show_bug.cgi?id=130577

Patch by Joonghun Park <jh718.park@samsung.com> on 2014-03-31
Reviewed by Gyuyoung Kim.

* UIProcess/API/efl/ewk_storage_manager.cpp:
(ewk_storage_manager_entries_clear):
(ewk_storage_manager_entries_for_origin_del):
* UIProcess/API/efl/ewk_storage_manager.h:
* UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::wkStorageManager):
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
adding and updating API unittest and fixing memory leak of the existing test case
(EWK2StorageManagerTest::getStorageOriginsCallback):
(EWK2StorageManagerTest::checkOrigin):
(EWK2StorageManagerTest::getOrigin):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix on the EFL port with latest EFL libraries since r166149
ryuan.choi@samsung.com [Tue, 1 Apr 2014 05:44:38 +0000 (05:44 +0000)]
Unreviewed build fix on the EFL port with latest EFL libraries since r166149

* ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
commit-queue@webkit.org [Tue, 1 Apr 2014 05:37:12 +0000 (05:37 +0000)]
[WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
https://bugs.webkit.org/show_bug.cgi?id=130955

Patch by Byungseon Shin <sun.shin@lge.com> on 2014-03-31
Reviewed by Dean Jackson.

To avoid aliasing issues when we render content to WebGL canvas,
 we need to implement MSAA support.
- Imagination OpenGLES GPU Driver already support MSAA, so we
 need a separate code path to enable it.

* platform/graphics/Extensions3D.h:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(WebCore::Extensions3DOpenGLCommon::isImagination):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename policy enums to match the delegate methods
andersca@apple.com [Tue, 1 Apr 2014 02:13:27 +0000 (02:13 +0000)]
Rename policy enums to match the delegate methods
https://bugs.webkit.org/show_bug.cgi?id=131002

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKNavigationDelegate.h:
(NS_ENUM):
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd more preferences
andersca@apple.com [Tue, 1 Apr 2014 02:03:54 +0000 (02:03 +0000)]
Add more preferences
https://bugs.webkit.org/show_bug.cgi?id=131001

Reviewed by Simon Fraser.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences isJavaScriptEnabled]):
(-[WKPreferences setJavaScriptEnabled:]):
(-[WKPreferences javaScriptCanOpenWindowsAutomatically]):
(-[WKPreferences setJavaScriptCanOpenWindowsAutomatically:]):
(-[WKPreferences suppressesIncrementalRendering]):
(-[WKPreferences setSuppressesIncrementalRendering:]):
(-[WKPreferences isJavaEnabled]):
(-[WKPreferences setJavaEnabled:]):
(-[WKPreferences arePlugInsEnabled]):
(-[WKPreferences setPlugInsEnabled:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Unreviewed build fix after r166496.
alex.christensen@flexsim.com [Tue, 1 Apr 2014 01:52:47 +0000 (01:52 +0000)]
[WinCairo] Unreviewed build fix after r166496.

* win/tools/vsprops/GStreamerCommon.props:
Added gio-2.0.lib to list of GStreamer includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build.
timothy_horton@apple.com [Tue, 1 Apr 2014 01:46:22 +0000 (01:46 +0000)]
Fix the build.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build.
simon.fraser@apple.com [Tue, 1 Apr 2014 01:34:02 +0000 (01:34 +0000)]
Fix the iOS build.

* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
* UIProcess/mac/RemoteLayerTreeHost.h:
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::setLayerID):
(WebKit::RemoteLayerTreeHost::layerID):
(WebKit::RemoteLayerTreeHost::createLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a couple of iOS specific preferences
andersca@apple.com [Tue, 1 Apr 2014 01:23:25 +0000 (01:23 +0000)]
Add a couple of iOS specific preferences
https://bugs.webkit.org/show_bug.cgi?id=130999

Reviewed by Simon Fraser.

* Shared/WebPreferencesStore.h:
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences allowsInlineMediaPlayback]):
(-[WKPreferences setAllowsInlineMediaPlayback:]):
(-[WKPreferences mediaPlaybackRequiresUserAction]):
(-[WKPreferences setMediaPlaybackRequiresUserAction:]):
(-[WKPreferences mediaPlaybackAllowsAirPlay]):
(-[WKPreferences setMediaPlaybackAllowsAirPlay:]):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
msaboff@apple.com [Tue, 1 Apr 2014 01:10:35 +0000 (01:10 +0000)]
REGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
https://bugs.webkit.org/show_bug.cgi?id=130992

Reviewed by Mark Hahnenberg.

Forward JSObjectGetPrivate() and JSObjectSetPrivate() to the wrapped object.

* API/JSObjectRef.cpp:
(JSObjectGetPrivate):
(JSObjectSetPrivate):
* API/tests/testapi.c:
(main): Added new test case to validate we are properly foarwarding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a new -[WKPreferences initWithUserDefaultsPrefixKey:] initializer
andersca@apple.com [Tue, 1 Apr 2014 01:02:09 +0000 (01:02 +0000)]
Add a new -[WKPreferences initWithUserDefaultsPrefixKey:] initializer
https://bugs.webkit.org/show_bug.cgi?id=130996

Reviewed by Simon Fraser.

Add a "key prefix" to the WebKit::WebPreferences create function, so we can use a different
key prefix ("WebKit") for the modern API and not pollute the user defaults namespace with
the old key prefix ("WebKit2.").

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
(-[WKPreferences initWithUserDefaultsPrefixKey:]):
(-[WKPreferences userDefaultsPrefixKey]):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences):
* UIProcess/WebPreferences.h:
(WebKit::WebPreferences::create):
* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
(WebKit::WebPreferences::platformUpdateFloatValueForKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove duplicate entries in Derived Sources.
psolanki@apple.com [Tue, 1 Apr 2014 00:53:29 +0000 (00:53 +0000)]
Remove duplicate entries in Derived Sources.

Rubber-stamped by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrashes in PageConsole::addMessage
ap@apple.com [Tue, 1 Apr 2014 00:19:14 +0000 (00:19 +0000)]
Crashes in PageConsole::addMessage
https://bugs.webkit.org/show_bug.cgi?id=130991
<rdar://problem/14795232>

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/tests/misc/detached-frame-console.html

* page/DOMWindow.cpp: (WebCore::DOMWindow::printErrorMessage): Added a null check.
It's legitimate for this to be called for a window that is not currently displayed
in a frame.

LayoutTests:

* http/tests/misc/detached-frame-console-expected.txt: Added.
* http/tests/misc/detached-frame-console.html: Added.
* http/tests/misc/resources/detached-frame-console-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build.
timothy_horton@apple.com [Tue, 1 Apr 2014 00:12:40 +0000 (00:12 +0000)]
Fix the build.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build.
timothy_horton@apple.com [Tue, 1 Apr 2014 00:08:00 +0000 (00:08 +0000)]
Fix the build.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r166144?): fast/preloader/document-write.html is very flaky
ap@apple.com [Tue, 1 Apr 2014 00:00:32 +0000 (00:00 +0000)]
REGRESSION (r166144?): fast/preloader/document-write.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=130942

* platform/mac/TestExpectations: Marking as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed test correction after r166530.
bfulgham@apple.com [Mon, 31 Mar 2014 23:50:17 +0000 (23:50 +0000)]
Unreviewed test correction after r166530.

* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
fine-grained setting for swipe tests. This prevents existing tests from breaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename -[WKNavigationAction destinationFrame] to -[WKNavigationAction targetFrame]
andersca@apple.com [Mon, 31 Mar 2014 23:49:47 +0000 (23:49 +0000)]
Rename -[WKNavigationAction destinationFrame] to -[WKNavigationAction targetFrame]
https://bugs.webkit.org/show_bug.cgi?id=130994

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKNavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction description]):
(-[WKNavigationAction targetFrame]):
(-[WKNavigationAction setTargetFrame:]):
(-[WKNavigationAction destinationFrame]): Deleted.
(-[WKNavigationAction setDestinationFrame:]): Deleted.
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after...
timothy_horton@apple.com [Mon, 31 Mar 2014 23:30:43 +0000 (23:30 +0000)]
[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
https://bugs.webkit.org/show_bug.cgi?id=130768
<rdar://problem/16421471>

Reviewed by Benjamin Poulain.

* Shared/mac/RemoteLayerBackingStore.h:
Make RemoteLayerBackingStore noncopyable.
Add flush(), which synchronously flushes painting operations on the underlying backing store.
Add storage for the CGContext that needs to be flushed, and ensure that it is flushed before we paint again.

* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):

(RemoteLayerBackingStore::drawInContext):
Don't flush the context immediately after painting.

(RemoteLayerBackingStore::flush):
Flush the current front surface/buffer's context.
Clear the new pending-flush members.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::flushBackingStoreChangesInTransaction):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Crawl through all of the valid changed backing stores in the transaction and flush them.
Reset changed properties after encoding the commit.

* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::resetChangedProperties):
(WebKit::RemoteLayerTreeTransaction::changedLayers):
(WebKit::RemoteLayerTreeTransaction::changedLayerProperties):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
(WebKit::dumpChangedLayers):
Instead of storing a copy of the LayerProperties struct for each changed layer
while building the transaction in the Web process, store a list of changed layers,
and directly encode the commit from those layers' LayerProperties. This provides a few benefits:
        - We avoid copying LayerProperties for every changed layer, every commit
        - We can make RemoteLayerBackingStore noncopyable
        - We can walk the changed layers after building the transaction
        in order to flush backing store, and actually affect the layers'
        own RemoteLayerBackingStore instead of a copy.
The UI process will still generate a LayerPropertiesMap at decode time.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
Don't copy the LayerProperties struct for the debug overlay. Instead,
adjust the properties which the debug overlay whacks directly on the layer,
after applying the normal LayerProperties.

* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::recursiveBuildTransaction):
Don't reset changed layer properties in the middle of building a transaction. Instead,
RemoteLayerTreeDrawingArea::flushLayers() will reset all the flags on all changed layers
after the commit is encoded.

* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
(WebKit::PlatformCALayerRemote::properties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove GC_LOGGING
mhahnenberg@apple.com [Mon, 31 Mar 2014 23:27:29 +0000 (23:27 +0000)]
Improve GC_LOGGING
https://bugs.webkit.org/show_bug.cgi?id=130988

Reviewed by Geoffrey Garen.

GC_LOGGING can be useful for diagnosing where we're spending our time during collection,
but it doesn't distinguish between Eden and Full collections in the data it gathers. This
patch updates it so that it can. It also adds the process ID to the beginning of each line
of input to be able to distinguish between the output of multiple processes exiting at the
same time.

* heap/Heap.cpp:
(JSC::Heap::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r166536.
commit-queue@webkit.org [Mon, 31 Mar 2014 23:23:43 +0000 (23:23 +0000)]
Unreviewed, rolling out r166536.
https://bugs.webkit.org/show_bug.cgi?id=130993

This is not the correct fix. (Requested by bfulgham on
#webkit).

Reverted changeset:

"Unreviewed test fix after r166530."
http://trac.webkit.org/changeset/166536

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166543 268f45cc-cd09-0410-ab3c-d52691b4dbfc