WebKit-https.git
11 years agoWebCore:
darin@apple.com [Tue, 10 Mar 2009 14:46:42 +0000 (14:46 +0000)]
WebCore:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
        https://bugs.webkit.org/show_bug.cgi?id=23564
        rdar://problem/6537238

        Test: fast/dom/HTMLElement/innerHTML-selection-crash.html

        * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
        call to the one of the two overloads of this function that wasn't calling it. This fixes
        this crash and other possible crashes inside innerHTML.

LayoutTests:

2009-03-10  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
        https://bugs.webkit.org/show_bug.cgi?id=23564
        rdar://problem/6537238

        * fast/dom/HTMLElement/innerHTML-selection-crash-expected.txt: Added.
        * fast/dom/HTMLElement/innerHTML-selection-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 14:10:56 +0000 (14:10 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24285
        Text resource loading checks for BOM twice

        This removes TextDecoder class, since its only purpose was to check for BOM, which is
        already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
        BOM checked, but I didn't find any cases where it would significantly change behavior.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Remove TextDecoder.{h,cpp}.

        * platform/text/TextDecoder.cpp: Removed.
        * platform/text/TextDecoder.h: Removed.

        * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
        TextCodec separately.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
        (WebCore::TextResourceDecoder::setEncoding): Ditto.
        (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
        even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
        BOM again. Made this function return the detected BOM length.
        (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
        a text resource.
        (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
        resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.

        * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
        Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
        checks for BOM, which was a counter-intuitive feature.

        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::setEncoding):
        (WebCore::CachedScript::encoding):
        (WebCore::CachedScript::script):
        * loader/CachedScript.h:
        * loader/appcache/ManifestParser.cpp:
        (WebCore::parseManifest):
        Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
        A side effect of this is that these resources will now be subject to encoding auto-detection.

        * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
        * page/Page.cpp: (WebCore::Page::userStyleSheet):
        Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
        re-usable (for repeated decoding of the same resource).

        * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 12:58:05 +0000 (12:58 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24488
        An assertion failure when updating an offline application cache after emptying caches

        Emptying appcache cannot be performed automatically, so no test.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
        storage, even if the application wasn't updated server side.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6425807> Implement WorkerUtils.importScripts()
oliver@apple.com [Tue, 10 Mar 2009 09:44:30 +0000 (09:44 +0000)]
<rdar://problem/6425807> Implement WorkerUtils.importScripts()
<https://bugs.webkit.org/show_bug.cgi?id=22721>

Reviewed by Alexey Proskuryakov

Implement importScripts, currently uses a series of synchronous loads
to fetch the scripts, but this is simpler than a synchronous load of
multiple loads in parallel.  In future we'll want to switch to parallel
loading, but this will do for now.

Test: http/tests/workers/worker-importScripts.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 08:11:04 +0000 (08:11 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24462
        Move cross-origin access control code out of XMLHttpRequest

        Step 1: move preflight result cache and access control helper functions.

        No change in behavior, so no test.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/CrossOriginAccessControl.cpp: Added.
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
        (WebCore::isSimpleCrossOriginAccessRequest):
        (WebCore::createAllowedCrossOriginResponseHeadersSet):
        (WebCore::isOnAccessControlResponseHeaderWhitelist):
        (WebCore::passesAccessControlCheck):
        * loader/CrossOriginAccessControl.h: Added.
        * loader/CrossOriginPreflightResultCache.cpp: Added.
        (WebCore::parseAccessControlMaxAge):
        (WebCore::addToAccessControlAllowList):
        (WebCore::parseAccessControlAllowList):
        (WebCore::CrossOriginPreflightResultCacheItem::parse):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
        (WebCore::CrossOriginPreflightResultCache::shared):
        (WebCore::CrossOriginPreflightResultCache::appendEntry):
        (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
        * loader/CrossOriginPreflightResultCache.h: Added.
        (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
        (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
        (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
        (WebCore::XMLHttpRequest::didReceiveResponse):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Mar 2009 07:46:09 +0000 (07:46 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19797
        Bring the list of forbidden headers in sync with XMLHttpRequest spec draft

        Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from
        XMLHttpRequest 2 draft.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
mitz@apple.com [Tue, 10 Mar 2009 07:03:45 +0000 (07:03 +0000)]
    Reviewed by Adele Peterson.

        - fix https://bugs.webkit.org/show_bug.cgi?id=23975
          <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical
        scrollbar rect calculation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 10 Mar 2009 05:50:27 +0000 (05:50 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Oliver Hunt

        https://bugs.webkit.org/show_bug.cgi?id=24475

        When repainting replaced elements, need to union the selection
        and overflow rects because either may extend outside the other.

        Test: fast/repaint/transform-replaced-shadows.html

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::clippedOverflowRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 24447: REGRESSION (r41508): Google Maps does not complete initialization
oliver@apple.com [Tue, 10 Mar 2009 01:09:44 +0000 (01:09 +0000)]
Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
<rdar://problem/6657774>

Reviewed by Gavin Barraclough

r41508 actually exposed a pre-existing bug where we were not invalidating the result
register cache at jump targets.  This causes problems when condition loads occur in an
expression -- namely through the ?: and || operators.  This patch corrects these issues
by marking the target of all forward jumps as being a jump target, and then clears the
result register cache when ever it starts generating code for a targeted instruction.

I do not believe it is possible to cause this class of failure outside of a single
expression, and expressions only provide forward branches, so this should resolve this
entire class of bug.  That said i've included a test case that gets as close as possible
to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
problem in future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Tue, 10 Mar 2009 00:38:33 +0000 (00:38 +0000)]
2009-03-09  Stephanie Lewis  <slewis@apple.com>

        Fix build.

        * editing/Editor.cpp:
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::markAllMisspellingsAndBadGrammarInRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Kim Christensen <kimworking@gmail.com>
darin@chromium.org [Tue, 10 Mar 2009 00:22:38 +0000 (00:22 +0000)]
2009-03-09  Kim Christensen  <kimworking@gmail.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24276
        Dropdown / select boxes do not consider the windows task bar in Chromium.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 9 Mar 2009 22:34:30 +0000 (22:34 +0000)]
2009-03-09  Sam Weinig  <sam@webkit.org>

        Roll out r41393.  It has been causing failures on the bots for about a week.

        * fast/block/float/resources/se_arrow.png: Removed.
        * fast/block/float/resources/yinyang.png: Removed.
        * fast/block/float/t0905-c414-flt-fit-01-d-g.html: Removed.
        * fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Removed.
        * fast/block/float/t0905-c5526-flthw-00-c-g.html: Removed.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
        * platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
        * platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Removed.
        * platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 9 Mar 2009 22:20:50 +0000 (22:20 +0000)]
WebCore:

        Reviewed by Adele Peterson and Dave Hyatt.

        - fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
          misaligned edit fields

        Test: fast/forms/legend-display-none.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display
        property of legend elements to 'block' unless it is 'none'.
        * css/html4.css: Do not force the display property of legend elements to
        'block' using CSS, because that prevents style rules from setting it to
        'none'.

LayoutTests:

        Reviewed by Adele Peterson and Dave Hyatt.

        - test for <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
          misaligned edit fields

        * fast/forms/legend-display-none-expected.txt: Added.
        * fast/forms/legend-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Mon, 9 Mar 2009 21:01:54 +0000 (21:01 +0000)]
WebCore:

2009-03-09  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23024

        Fix an incorrect criteria in the if statement that leaves references to
        deleted floating objects in RenderBlock.

        Test: fast/block/float/crash-on-absolute-positioning.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

2009-03-09  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23024

        Added regression test for a bug that causes crashes.

        * fast/block/float/crash-on-absolute-positioning.html: Added.
        * platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 9 Mar 2009 21:01:42 +0000 (21:01 +0000)]
2009-03-09  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Bug 23175: String and UString should be able to share a UChar* buffer.
        <https://bugs.webkit.org/show_bug.cgi?id=23175>

        Add CrossThreadRefCounted.

        * wtf/CrossThreadRefCounted.h: Added.
        (WTF::CrossThreadRefCounted::create):
        (WTF::CrossThreadRefCounted::isShared):
        (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe):
        (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread):
        (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
        (WTF::CrossThreadRefCounted::~CrossThreadRefCounted):
        (WTF::CrossThreadRefCounted::ref):
        (WTF::CrossThreadRefCounted::deref):
        (WTF::CrossThreadRefCounted::release):
        (WTF::CrossThreadRefCounted::copy):
        (WTF::CrossThreadRefCounted::threadSafeDeref):
        * wtf/RefCounted.h:
        * wtf/Threading.h:
        (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase):
        (WTF::ThreadSafeSharedBase::derefBase):
        (WTF::ThreadSafeShared::ThreadSafeShared):
        (WTF::ThreadSafeShared::deref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 9 Mar 2009 19:48:22 +0000 (19:48 +0000)]
2009-03-09  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Unify JSC/V8 idl file.
        https://bugs.webkit.org/show_bug.cgi?id=24424

        * page/Location.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 9 Mar 2009 19:48:16 +0000 (19:48 +0000)]
2009-03-09  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Unify JSC/V8 for History.idl.

        * page/History.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Mike Belshe <mike@belshe.com>
eric@webkit.org [Mon, 9 Mar 2009 19:48:10 +0000 (19:48 +0000)]
2009-03-09  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Unify JSC/V8 implementations of DOMWindow.idl.

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 9 Mar 2009 18:39:52 +0000 (18:39 +0000)]
2009-03-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        WebKit side of <rdar://problem/6530007>

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEnumerate):
        Call NetscapePluginInstanceProxy::enumerate.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::enumerate):
        Enumerate the JS object and serialize its values.

        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::getPropertyNames):
        Ask the plug-in host to get the property names and deserialize them.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 9 Mar 2009 18:06:10 +0000 (18:06 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24163

        Implement mapping of FloatQuads through 3D transforms.

        Removed the redundant localToContainerQuad() methods, which can now
        shared code with the old mapLocalToAbsolutePoint(), which was
        renamed to mapLocalToContainer(). This can now convert a point,
        and optionally a FloatQuad, which are carried along in the TransformState.

        Optimized TransformState to reduce to simple FloatPoint.move()
        if there are no transforms, and to heap-allocate a transform only if
        necessary to accumulate transforms (when using preserve-3d).

        Tested by 3d point mapping tests, and the inspector highlight (which now shows
        the correct quads for 3d-transformed elements).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 9 Mar 2009 17:01:29 +0000 (17:01 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24433

        During hit testing with transforms, if a layer has backface-visibility: hidden,
        we need to check for it whether or not the layer has a transform, because it
        might be an ancestor that is transformed.

        Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 9 Mar 2009 16:53:32 +0000 (16:53 +0000)]
2009-03-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt and Cameron Zwarich

        https://bugs.webkit.org/show_bug.cgi?id=24440

        The sublayer added to WebHTMLView to host accelerated compositing layers needs to
        be a subclass of NSView which allows context menu clicks through.

        * WebView/WebHTMLView.mm:
        (-[WebLayerHostingView rightMouseDown:]):
        (-[WebHTMLView attachRootLayer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
treat@webkit.org [Mon, 9 Mar 2009 16:37:43 +0000 (16:37 +0000)]
2009-03-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24353
        Allow to overrule default build options for Qt build.

        * WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
        * JavaScriptCore.pri: Allow to overrule ENABLE_JIT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-09 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 9 Mar 2009 16:32:21 +0000 (16:32 +0000)]
2009-03-09  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=24463
        WebCore::qstring is detaching and copying twice for every single
        WebCore::TextRun that is processed and drawn.  This elevates this method
        to one of the top-ten most expensive methods in all of QtWebKit according
        to profiling.  This changes the method so that QString only detaches
        when absolutely necessary.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::qstring):
        (WebCore::fixSpacing):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Mon, 9 Mar 2009 06:29:27 +0000 (06:29 +0000)]
2009-03-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber-stamped by Mark Rowe.

        [Gtk] Skip failing tests that require the eventSender.

        The Gtk+ platform is lacking an implementation of the
        eventSender. We will enable the tests once there is an
        implementation of that class.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSplit ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
mrowe@apple.com [Mon, 9 Mar 2009 05:36:31 +0000 (05:36 +0000)]
Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
Frame.h no longer needs to include it.  This cuts the size of the symbols
for a debug build by around 3%.

Reviewed by Oliver Hunt.

* dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::gotoAnchor):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/Frame.cpp:
(WebCore::Frame::revealSelection):
(WebCore::Frame::revealCaret):
* page/Frame.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose):
(WebCore::RenderLayer::autoscroll):
* rendering/RenderLayer.h:
* rendering/ScrollBehavior.cpp: Added.
(WebCore::):
* rendering/ScrollBehavior.h: Added.
(WebCore::):
(WebCore::ScrollAlignment::getVisibleBehavior):
(WebCore::ScrollAlignment::getPartialBehavior):
(WebCore::ScrollAlignment::getHiddenBehavior):

Add the new files to the build systems:
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.pro:
* WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:

Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
* dom/Clipboard.cpp:
* editing/EditorCommand.cpp:
* editing/InsertLineBreakCommand.cpp:
* editing/TypingCommand.cpp:
* html/HTMLFormControlElement.cpp:
* loader/archive/cf/LegacyWebArchive.cpp:
* loader/icon/IconLoader.cpp:
* page/animation/AnimationController.cpp:
* rendering/RenderSlider.cpp:
* rendering/RenderTextControl.cpp:

WebKit/mac:
* Plugins/WebNetscapePluginView.mm:
* WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):

WebKit/win:
* WebView.cpp:
(WebView::centerSelectionInVisibleArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPush the include of Frame.h out of RenderView.h and down to those files
mrowe@apple.com [Mon, 9 Mar 2009 03:44:38 +0000 (03:44 +0000)]
Push the include of Frame.h out of RenderView.h and down to those files
that need it.  This cuts the size of symbols for RenderFoo object files
by around 15% in a debug build.

Reviewed Dan Bernstein.

* bindings/objc/DOM.mm:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderInline.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderReplaced.cpp:
* rendering/RenderText.cpp:
* rendering/RenderView.cpp:
(WebCore::RenderView::zoomFactor):
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove some unnecessary or redundant includes from files related to the JS bindings.
mrowe@apple.com [Mon, 9 Mar 2009 03:18:08 +0000 (03:18 +0000)]
Remove some unnecessary or redundant includes from files related to the JS bindings.
This cuts the size of the symbols for a debug build by around 3%.

Rubber-stamped by Dan Bernstein.

* bindings/js/JSCustomPositionCallback.cpp:
* bindings/js/JSCustomPositionErrorCallback.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSPluginElementFunctions.cpp:
* bindings/js/JSSVGPODTypeWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled
zecke@webkit.org [Mon, 9 Mar 2009 03:17:11 +0000 (03:17 +0000)]
[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled

setJavaScriptProfilingEnabled is implemented by enabling the
developer extras using the WebKitWebSettings and adding the
JavaScript Profiling option to the WebKitWebInspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 8 Mar 2009 23:21:14 +0000 (23:21 +0000)]
2009-03-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
        and provisionalHistoryItem() from FrameLoader.

        * WebCore.base.exp:
        * WebCore.order:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::frameLoadCompleted):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-08 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 8 Mar 2009 19:35:54 +0000 (19:35 +0000)]
2009-03-08  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        Implement proper logging for the GTK+ port, inspired by the one in
        Qt. We use the WEBKIT_DEBUG environment variable which was already
        being used to decide whether to setup a logger for soup or not.

        * platform/gtk/LoggingGtk.cpp:
        (WebCore::getChannelFromName):
        (WebCore::InitializeLoggingChannelsIfNecessary):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ensureSessionIsInitialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
oliver@apple.com [Sun, 8 Mar 2009 13:01:30 +0000 (13:01 +0000)]
Build fix.

Reviewed by NOBODY(Build fix)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 24268: RuntimeArray is not a fully implemented JSArray
oliver@apple.com [Sun, 8 Mar 2009 10:47:01 +0000 (10:47 +0000)]
Bug 24268: RuntimeArray is not a fully implemented JSArray
<https://bugs.webkit.org/show_bug.cgi?id=24268>

Reviewed by Cameron Zwarich.

Don't cast a type to JSArray, just because it reportsArray as a supertype
in the JS type system.  Doesn't appear feasible to create a testcase
unfortunately as setting up the failure conditions requires internal access
to JSC not present in DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 8 Mar 2009 00:05:05 +0000 (00:05 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - WebCore part of removing build-time and run-time support for legacy
          versions of CFNetwork and Core Graphics

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::platformDataInit):
        * platform/network/cf/FormDataStreamCFNet.cpp:
        (WebCore::setHTTPBody):
        (WebCore::httpBodyFromRequest):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::didSendBodyData):
        (WebCore::shouldUseCredentialStorageCallback):
        (WebCore::ResourceHandle::start):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::filterCookies):

WebKit/win:

        Reviewed by Mark Rowe.

        - WebKit part of removing build-time and run-time support for legacy
          versions of CFNetwork and Core Graphics

        * WebView.cpp:
        (WebView::setCacheModel):

WebKitLibraries:

        Reviewed by Mark Rowe.

        - WebKitSystemInterface part of removing build-time and run-time support
          for legacy versions of CFNetwork and Core Graphics

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 7 Mar 2009 22:16:09 +0000 (22:16 +0000)]
2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Updated Skipped list per r41464. Not reviewed.
        This should remove the warnings that come up everytime we run the gtk layout tests.
        http://trac.webkit.org/changeset/41464

        The ff. tests have been moved to fast/css/getComputedStyle in the Skipped list:
         fast/css/computed-style-without-renderer.html
         fast/css/computed-style.html
         fast/css/getComputedStyle-border-box.html

        The ff. test has been removed from the Skipped list:
          fast/css/marginComputedStyle.html

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 7 Mar 2009 22:15:58 +0000 (22:15 +0000)]
2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubber-stamped by Holger Freyther.

        Remove fast/canvas/gradient-empty-path.html from the skipped
        list as it was removed by r39288.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 7 Mar 2009 22:15:44 +0000 (22:15 +0000)]
2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] Enable http security, plugins and ssl tests
        https://bugs.webkit.org/show_bug.cgi?id=24393

        Enable http tests for security, plugins and ssl, skipping tests
        that are failing/crashing.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 7 Mar 2009 22:15:25 +0000 (22:15 +0000)]
2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] Enable http history tests
        https://bugs.webkit.org/show_bug.cgi?id=24394

        Get the index of the current item from the list of (history) items
        to print before adding the back history items to the list. This
        will make the 'curr' pointer point to the correct item in the
        actual results, therefore, passing some of the http/tests/history
        tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpBackForwardListForWebView):

2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] Enable http history tests
        https://bugs.webkit.org/show_bug.cgi?id=24394

        Enable http/tests/history, adding failing tests to the Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Alexey Proskuryakov.
mitz@apple.com [Sat, 7 Mar 2009 21:28:55 +0000 (21:28 +0000)]
    Reviewed by Alexey Proskuryakov.

        - fix a bug where debug builds were clearing the HTML5 application cache
          on application termination

        * WebView/WebView.mm:
        (-[WebView _close]): Call -[WebCache setDisabled:YES] instead of
        -[WebCache empty].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Sat, 7 Mar 2009 19:46:43 +0000 (19:46 +0000)]
WebCore:

2009-03-07  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24444
        No multiple JS property for <input type="file" multiple />

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::multiple):
        (WebCore::HTMLInputElement::setMultiple):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:

LayoutTests:

2009-03-07  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Test for https://bugs.webkit.org/show_bug.cgi?id=24444
        No multiple JS property for <input type="file" multiple />

        * fast/forms/input-multiple-expected.txt: Added.
        * fast/forms/input-multiple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-07 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Sat, 7 Mar 2009 18:42:26 +0000 (18:42 +0000)]
2009-03-07  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Cameron Zwarich.

        These methods are clearly returning the wrong values as the two were
        returning swapped information.

        * Api/qwebpage.cpp:
        (QWebPage::totalBytes):
        (QWebPage::bytesReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-07 Xan Lopez <xan@gnome.org>
xan@webkit.org [Sat, 7 Mar 2009 12:03:13 +0000 (12:03 +0000)]
2009-03-07  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24358
        [GTK] Scrollbars not clipped correctly

        ScrollView scrollbars in subframes are *not* native, so take that
        into account again.

        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::getLocationInParentWindow):
        (ScrollbarGtk::frameRectsChanged):
        (ScrollbarGtk::paint):
        * platform/gtk/ScrollbarGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 7 Mar 2009 04:58:36 +0000 (04:58 +0000)]
2009-03-06  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        When preforming an op_mov, preserve any existing register mapping.

        ~0.5% progression on v8 tests x86-64.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 7 Mar 2009 00:26:34 +0000 (00:26 +0000)]
2009-03-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24405
        Horizontal scrolling on Windows was reversed from Mac (and intuition).

        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 6 Mar 2009 23:47:06 +0000 (23:47 +0000)]
2009-03-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Sam Weinig.

        Convert some C-style casts to static_cast<>()s.

        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/wx/MouseWheelEventWx.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Fri, 6 Mar 2009 23:05:55 +0000 (23:05 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 6 Mar 2009 23:01:47 +0000 (23:01 +0000)]
2009-03-06  Darin Adler  <darin@apple.com>

        Fixed broken test I just landed for bug 24422.

        * fast/dom/location-new-window-no-crash-expected.txt: Updated.
        * fast/dom/resources/location-new-window-no-crash.js: Added code to make the window
        opening and closing work in DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 6 Mar 2009 22:12:38 +0000 (22:12 +0000)]
2009-03-06  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver Hunt.

        Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)

        I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.

        * page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element.
          That is no longer true, so we should return the document element for a truly empty document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Jay Campan <jcampan@google.com>
darin@chromium.org [Fri, 6 Mar 2009 21:32:32 +0000 (21:32 +0000)]
2009-03-06  Jay Campan  <jcampan@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24306

        Adding a flag to ResourceRequestBase to indicate whether or not upload
        progress notifications are needed for a resource. This is useful to
        avoid sending these notifications when there are no consumers
        (especially in the Chromium case where IPC is involved).

        * platform/network/ResourceRequestBase.h:
        (WebCore::ResourceRequestBase::reportUploadProgress):
        (WebCore::ResourceRequestBase::setReportUploadProgress):
        (WebCore::ResourceRequestBase::ResourceRequestBase):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::loadRequestAsynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dimich@chromium.org [Fri, 6 Mar 2009 21:21:06 +0000 (21:21 +0000)]
WebCore:

2009-03-04  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24150
        Add virtual ScriptExecutionContext::encoding()

        Test: http/tests/workers/text-encoding.html

        * dom/Document.cpp:
        (WebCore::Document::encoding):
        * dom/Document.h:
        (WebCore::Document::inputEncoding):
        (WebCore::Document::charset):
        (WebCore::Document::characterSet):
        Add new virtual method and route DOM synonym functions on Document through it.

        * dom/ScriptExecutionContext.h:
        * workers/Worker.cpp:
        (WebCore::Worker::Worker):
        (WebCore::Worker::notifyFinished):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::encoding):
        (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
        * workers/WorkerContext.h:
        (WebCore::WorkerContext::create):
        * workers/WorkerContextProxy.h:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::startWorkerContext):
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThreadStartupData::create):
        (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
        (WebCore::WorkerThread::create):
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::workerThread):
        * workers/WorkerThread.h:
        All of the above route the 'encoding' parameter of parent context to the new
        instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy
        through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.

LayoutTests:

2009-03-04  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24150
        Add virtual ScriptExecutionContext::encoding()

        Test to verify how the text encoding in workers is used.
        Script decoding and url completion is checked, with and
        w/o http 'Content-Type: ...;charset=...' header.

        * http/tests/workers/resources/worker-encoded.php: Added.
        * http/tests/workers/resources/xhr-query-utf8.php: Added.
        * http/tests/workers/resources/xhr-response.php: Added.
        * http/tests/workers/text-encoding-expected.txt: Added.
        * http/tests/workers/text-encoding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 6 Mar 2009 20:43:24 +0000 (20:43 +0000)]
2009-03-06  Peter Kasting  <pkasting@google.com>

        Build bustage fix.

        * dom/Node.cpp:
        (WebCore::Node::dispatchWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Mar 2009 20:17:28 +0000 (20:17 +0000)]
2009-03-06  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti Koivisto.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView):  Delay callback while setting up movieview.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Mar 2009 20:08:55 +0000 (20:08 +0000)]
WebCore:

2009-03-06  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Justin Garcia.

        https://bugs.webkit.org/show_bug.cgi?id=24108

        Update spelling and grammar checking to use the new combined text
        checking (with automatic language identification) on Snow Leopard.
        Tested manually in Mail and Safari; automated tests to come later.

        * editing/Editor.cpp:
        (WebCore::findFirstMisspellingOrBadGrammarInRange):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::guessesForMisspelledOrUngrammaticalRange):
        (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        (WebCore::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        * editing/Editor.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
        * page/EditorClient.h:
        * page/Frame.cpp:
        (WebCore::Frame::respondToChangedSelection):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):

WebKit/mac:

2009-03-06  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Justin Garcia.

        https://bugs.webkit.org/show_bug.cgi?id=24108

        Update spelling and grammar checking to use the new combined text
        checking (with automatic language identification) on Snow Leopard.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::checkSpellingAndGrammarOfParagraph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 6 Mar 2009 19:52:07 +0000 (19:52 +0000)]
2009-03-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24407
        Windows scroll amount was too small, and wheel scroll distance
        conversion code was overly complex.

        * page/EventHandler.cpp:
        (WebCore::scrollAndAcceptEvent):
        * platform/PlatformWheelEvent.h:
        (WebCore::):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/Scrollbar.h:
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/qt/WheelEventQt.cpp:
        * platform/win/WheelEventWin.cpp:
        (WebCore::horizontalScrollChars):
        (WebCore::verticalScrollLines):
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/wx/MouseWheelEventWx.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 6 Mar 2009 19:18:02 +0000 (19:18 +0000)]
2009-03-06  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        When building QtWebKit in release mode make sure that QT_SHARED is defined
        otherwise none of the public API will be exported.  This leads to missing
        symbols and link errors if hidden-visibility is used.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 6 Mar 2009 19:14:04 +0000 (19:14 +0000)]
2009-03-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Roben.

        Generate valid bindings with HTML5 database support disabled.

        * inspector/InspectorController.idl: Added feature guard around
        databaseTableNames definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-04 Xan Lopez <xan@gnome.org>
xan@webkit.org [Fri, 6 Mar 2009 19:06:32 +0000 (19:06 +0000)]
2009-03-04  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24358
        [GTK] Scrollbars not clipped correctly

        Do not take into account the case of being a ScrollView scrollbar,
        since those are native in our case.

        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::frameRectsChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-04 Xan Lopez <xan@gnome.org>
xan@webkit.org [Fri, 6 Mar 2009 19:06:19 +0000 (19:06 +0000)]
2009-03-04  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24358
        [GTK] Scrollbars not clipped correctly

        Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
        specific and it's our only Widget anyway.

        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::paint):
        * platform/gtk/ScrollbarGtk.h:
        * platform/gtk/WidgetGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-04 Xan Lopez <xan@gnome.org>
xan@webkit.org [Fri, 6 Mar 2009 19:06:05 +0000 (19:06 +0000)]
2009-03-04  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24358
        [GTK] Scrollbars not clipped correctly

        Use correct clip rectangle and apply coordinate translation needed
        for non-ScrollView scrollbars.

        We were ignoring the clip rectangle passed as parameter, which is
        wrong in the case of non coalesced expose events. This, in turn,
        uncovers the fact that we were not applying coordinate translation
        to our position.

        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Change the isCygwin check in update-webkit to isAppleWinWebKit
aroben@apple.com [Fri, 6 Mar 2009 19:05:26 +0000 (19:05 +0000)]
    Change the isCygwin check in update-webkit to isAppleWinWebKit

        This matches a similar check in build-webkit, and is more correct.

        Reviewed by Alexey Proskuryakov.

        * Scripts/update-webkit: Only call update-webkit-auxiliary-libs if
        isAppleWinWebKit is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is present...
aroben@apple.com [Fri, 6 Mar 2009 19:05:03 +0000 (19:05 +0000)]
    Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is present but out of date

        Reviewed by Alexey Proskuryakov.

        * Scripts/update-webkit-support-libs: Changed to use
        dieAndInstructToDownload when the zip file doesn't exist. Added an MD5
        check to make sure the file is up-to-date. If it is out of date, print
        an error message and quit.
        (sub dieAndInstructToDownload): Added. Prints an error message and
        quits with an error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Mar 2009 19:03:38 +0000 (19:03 +0000)]
2009-03-06  Eric Carlson  <eric.carlson@apple.com>

        Build fix, no review

        * platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Mar 2009 18:55:49 +0000 (18:55 +0000)]
2009-03-06  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=22790
        Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
        Replace media engine setRect with setSize since they don't use about the
        position anyway.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect.
        (WebCore::MediaPlayer::setSize): Ditto.
        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayer::size): Changed from rect().

        * platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.

        * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect
        (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
        (WebCore::MediaPlayerPrivate::paint): update comment
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:  m_rect
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect.
        (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize.
        (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
        (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so
        the movie is drawn in the correct location.

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::setSize):  Changed from setRect
        * platform/graphics/qt/MediaPlayerPrivatePhonon.h:

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::setSize):  Changed from setRect
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Fri, 6 Mar 2009 18:55:37 +0000 (18:55 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24363

        Fixed test and fixed expected results to reflect the fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Fri, 6 Mar 2009 17:22:07 +0000 (17:22 +0000)]
WebCore:

2009-03-06  Darin Adler  <darin@apple.com>

        Reviewed by Darin Fisher.

        Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
        https://bugs.webkit.org/show_bug.cgi?id=24422
        rdar://problem/6402208

        Test: fast/dom/location-new-window-no-crash.html

        The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
        to add some checks for empty URLs. We could also put the empty URL checks at some
        other bottleneck level and add more assertions over time. I tried adding a few more
        assertions to functions like loadURL and hit them while running the regression tests,
        so it's probably going to be a bit tricky to clean this up throughout the loader.

        * loader/FrameLoader.cpp:
        (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct
        immutable by making all its members const. Added assertions about the arguments,
        including that the URL is not empty. Initialized one uninitialized member in one of
        the constructors.
        (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this
        a no-op if passed an empty URL.
        (WebCore::FrameLoader::scheduleLocationChange): Ditto.
        (WebCore::FrameLoader::scheduleRefresh): Ditto.

LayoutTests:

2009-03-06  Darin Adler  <darin@apple.com>

        Reviewed by Darin Fisher.

        Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
        https://bugs.webkit.org/show_bug.cgi?id=24422
        rdar://problem/6402208

        The new test manipulates all the properties of the location object on a new window which
        has no location yet. I tested Firefox too and added comments about how its behavior differs
        from WebKit. At some point we may want to tweak our behavior to be a bit closer to theirs,
        or check IE's behavior or if HTML 5 or some other W3 specification has something to say
        about this, but for now the main purpose of the test is to verify we don't crash.

        * fast/dom/location-new-window-no-crash-expected.txt: Added.
        * fast/dom/location-new-window-no-crash.html: Added.
        * fast/dom/resources/location-new-window-no-crash.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 6 Mar 2009 16:35:32 +0000 (16:35 +0000)]
2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24423
        Use new soup_message_body_set_accumulate API in soup backend

        Disable accumulating chunks for request_body on file uploads,
        using the new soup API.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 6 Mar 2009 16:35:13 +0000 (16:35 +0000)]
2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24423
        Use new soup_message_body_set_accumulate API in soup backend

        Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
        the new soup_message_body_set_accumulate API in soup.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotHeadersCallback):
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 6 Mar 2009 15:54:58 +0000 (15:54 +0000)]
2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24051
        Soup backend needs content sniffing capabilities

        Perform content sniffing when using soup, so that we have a chance
        of figuring out the Content-Type of the file if it's not sent by
        the server.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotHeadersCallback):
        (WebCore::gotChunkCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 6 Mar 2009 15:42:21 +0000 (15:42 +0000)]
2009-03-06  Darin Adler  <darin@apple.com>

        * fast/dom/Window/window-properties-expected.txt: Updated for recent addition of canPlayType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 6 Mar 2009 13:27:31 +0000 (13:27 +0000)]
2009-03-05  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Olliej.

        https://bugs.webkit.org/show_bug.cgi?id=24295
        webkit_web_back_forward_list_add_item needs a Since tag

        Add missing Since tag to webkit_web_back_forward_list_add_item
        documentation.

        * webkit/webkitwebbackforwardlist.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 6 Mar 2009 13:24:13 +0000 (13:24 +0000)]
2009-03-05  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24417
        [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings

        NULL-check for timer on _cancel and _dispose, to avoid bad
        warnings.

        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::webkit_download_finalize):
        (_WebKitDownloadPrivate::webkit_download_cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-06 Hironori Bono <hbono@chromium.org>
ap@webkit.org [Fri, 6 Mar 2009 11:13:10 +0000 (11:13 +0000)]
2009-03-06  Hironori Bono  <hbono@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24342
        Cannot insert a Thai character after a Thai prepend character when using ICU 4.0

        This change creates a new break iterator "cursorMovementIterator" for
        moving cursors and use it when moving an input cursor.
        In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
        based on the one of ICU 3.8.
        On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
        just calls the characterBreakIterator() function.

        Test: editing/inserting/insert-thai-characters-001.html

        * platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
        * platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU.
        (WebCore::setUpIteratorWithRules): Ditto.
        (WebCore::cursorMovementIterator): Ditto.
        * platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt.
        (WebCore::cursorMovementIterator): Ditto.
        * rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor.
        (WebCore::RenderText::previousOffset): Ditto.
        (WebCore::RenderText::nextOffset): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Fri, 6 Mar 2009 07:28:48 +0000 (07:28 +0000)]
    Reviewed by Oliver Hunt.

        <rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
        Characters (a compatibility issue with widgets).

        Test: http/tests/xmlhttprequest/broken-xml-encoding.html

        Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
        responses.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder):
        (WebCore::TextResourceDecoder::decode):
        (WebCore::TextResourceDecoder::flush):
        * loader/TextResourceDecoder.h:
        (WebCore::TextResourceDecoder::useLenientXMLDecoding):
        Don't stop on XML decoding errors if useLenientXMLDecoding() was called.

        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML
        decoding errors. This behavior is now limited to other kinds of XML content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ddkilzer@apple.com [Fri, 6 Mar 2009 07:17:39 +0000 (07:17 +0000)]
JavaScriptCore:

2009-03-05  Simone Fiorentino  <simone.fiorentino@consulenti.fastweb.it>

        Bug 24382: request to add SH4 platform

        <https://bugs.webkit.org/show_bug.cgi?id=24382>

        Reviewed by David Kilzer.

        * wtf/Platform.h: Added support for SH4 platform.

WebCore:

2009-03-05  Simone Fiorentino  <simone.fiorentino@consulenti.fastweb.it>

        Bug 24382: request to add SH4 platform

        <https://bugs.webkit.org/show_bug.cgi?id=24382>

        Reviewed by David Kilzer.

        * platform/text/AtomicString.cpp:
        (WebCore::equal): Aligned memory access on SH4 platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 6 Mar 2009 07:02:10 +0000 (07:02 +0000)]
2009-03-05  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Writes of constant values to SF registers should be made with direct memory
        writes where possible, rather than moving the value via a hardware register.

        ~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.

        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::storePtr):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::movq_i32m):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Jeremy Moskovich <jeremy@chromium.org>
darin@chromium.org [Fri, 6 Mar 2009 05:15:55 +0000 (05:15 +0000)]
2009-03-05  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Simon Fraser.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24215

        Gears expects an object tag with display:none to instantiate the plugin,
        so we add a workaround to make this work and fix Gears on WebKit trunk.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Avi Drissman <avi@chromium.org>
darin@chromium.org [Fri, 6 Mar 2009 05:13:08 +0000 (05:13 +0000)]
2009-03-05  Avi Drissman  <avi@chromium.org>

        Reviewed by Darin Fisher.

        Need to have Chromium Mac match Safari Mac's accesskey handling
        https://bugs.webkit.org/show_bug.cgi?id=24404

        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Mar 2009 04:12:57 +0000 (04:12 +0000)]
2009-03-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24412

        Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
        but no transform. We need to make localTransformState if we see preserve-3d.
        Also need to call update3DTransformedDescendantStatus() before we test
        m_has3DTransformedDescendant.

        Test: transforms/3d/hit-testing/hit-preserves-3d.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWhen we replace a bit of selected text with a string of the same length, we now send...
justin.garcia@apple.com [Fri, 6 Mar 2009 04:12:12 +0000 (04:12 +0000)]
When we replace a bit of selected text with a string of the same length, we now send a selection change notification.  The selection endpoints aren't changing their positions in the DOM or their offsets in the document, but they're probably changing visually (unless the text is fixed width), so it seems right to send the notification.

On the other hand, this happens during a setMarkedText call, which shouldn't even touch the selection.  But that's a different (and known) bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Hyatt.
eric@webkit.org [Fri, 6 Mar 2009 02:40:36 +0000 (02:40 +0000)]
    Reviewed by David Hyatt.

        Changes to RenderLayer destruction to hopefully help catch an elusive crasher
        https://bugs.webkit.org/show_bug.cgi?id=24409

        Added a new RenderBoxModelObject::destroyLayer() call which is
        now the only way which RenderLayers should ever be destroyed.
        This ensures that the pointer to the layer is cleared in the
        RenderObject after destruction, allowing us to ASSERT in the
        RenderBoxModelObject destructor.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        (WebCore::RenderBoxModelObject::destroyLayer):
        (WebCore::RenderBoxModelObject::destroy):
        (WebCore::RenderBoxModelObject::styleDidChange):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::stackingContext):
        (WebCore::RenderLayer::destroy):
        (WebCore::RenderLayer::removeOnlyThisLayer):
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Hyatt.
eric@webkit.org [Fri, 6 Mar 2009 02:35:01 +0000 (02:35 +0000)]
    Reviewed by David Hyatt.

        Remove old, unused IE 5.5 scrollbar-* CSS properties.
        Sort the unimplemented getComputedStyle properties so it's
        easier to see which ones actually need implementation.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 6 Mar 2009 01:42:05 +0000 (01:42 +0000)]
2009-03-05  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24079
        <rdar://problem/6611233> REGRESSION (r39549): Page loads cannot be interrupted with Command-. or Escape
        <rdar://problem/6636563> Ctrl-tab shortcut doesn't switch tabs when focus is in text field

        * WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]):
        If WebKit does not support the command, we need to pass the selector to super.  In this case,
        we'll consider the event not to be handled.  This is not perfect because in theory, [super doCommandBySelector:]
        can do some action that would cause WebKit to need to consider the event handled.  But in practice, I've found no
        example of that happening and causing broken behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake changes to previous checkin from the code review.
justin.garcia@apple.com [Fri, 6 Mar 2009 01:25:40 +0000 (01:25 +0000)]
Make changes to previous checkin from the code review.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Mar 2009 01:00:29 +0000 (01:00 +0000)]
WebCore:

2009-03-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
        within the document without changing its position in the DOM.  For example, pressing return in (caret marked by ^):
        <div contentEditable="true"><div>^Hello</div></div>
        Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
        for example).

        Changes to layout tests demonstrate fix.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand.  The TypingCommand knows whether or
        not it did work that needs to be applied.
        * editing/Editor.cpp:
        (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
        (WebCore::Editor::unappliedEditing): Ditto.
        (WebCore::Editor::reappliedEditing): Ditto.
        (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here.  Also call out to
        EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
        even if they did not change it's position in the DOM.  Any TypingCommand that gets this far changed it's position
        in the document.
        * editing/Editor.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
        (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing.  We won't get this far if we don't need to.
        (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
        adding to the killring and responding to a change in selections if the delete was a no-op.
        (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
        * editing/TypingCommand.h:

LayoutTests:

2009-03-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        WebViewDidChangeSelectionNotification isn't always called.
        Undo was enabled, shouldDeleteDOMRange was called, etc. for no-op backward and forward deletes.

        * platform/mac/editing/deleting/delete-4038408-fix-expected.txt:
        * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
        * platform/mac/editing/deleting/delete-br-002-expected.txt:
        * platform/mac/editing/deleting/delete-br-004-expected.txt:
        * platform/mac/editing/deleting/delete-br-005-expected.txt:
        * platform/mac/editing/deleting/delete-br-006-expected.txt:
        * platform/mac/editing/deleting/delete-br-009-expected.txt:
        * platform/mac/editing/deleting/delete-br-010-expected.txt:
        * platform/mac/editing/deleting/delete-hr-expected.txt:
        * platform/mac/editing/deleting/delete-tab-004-expected.txt:
        * platform/mac/editing/deleting/forward-delete-expected.txt:
        * platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt:
        * platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt:
        * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
        * platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
        * platform/mac/editing/inserting/insert-br-004-expected.txt:
        * platform/mac/editing/inserting/insert-br-005-expected.txt:
        * platform/mac/editing/inserting/insert-br-006-expected.txt:
        * platform/mac/editing/inserting/insert-br-008-expected.txt:
        * platform/mac/editing/inserting/insert-div-006-expected.txt:
        * platform/mac/editing/inserting/insert-div-008-expected.txt:
        * platform/mac/editing/inserting/insert-div-010-expected.txt:
        * platform/mac/editing/inserting/insert-div-011-expected.txt:
        * platform/mac/editing/inserting/insert-div-013-expected.txt:
        * platform/mac/editing/inserting/insert-div-015-expected.txt:
        * platform/mac/editing/inserting/insert-div-019-expected.txt:
        * platform/mac/editing/inserting/insert-div-021-expected.txt:
        * platform/mac/editing/inserting/insert-paragraph-01-expected.txt:
        * platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
        * platform/mac/editing/inserting/insert-paragraph-05-expected.txt:
        * platform/mac/editing/inserting/insert-tab-004-expected.txt:
        * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/mac/editing/inserting/line-break-expected.txt:
        * platform/mac/editing/pasteboard/3976872-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-010-expected.txt:
        * platform/mac/editing/style/block-style-006-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Adam Roben.
eric@webkit.org [Fri, 6 Mar 2009 00:35:54 +0000 (00:35 +0000)]
    Rubber-stamped by Adam Roben.

        Move all of the fast/css/*computed* tests into fast/css/getComputedStyle
        in preparation for adding a bunch more getComputedStyle tests.

        * fast/css/getComputedStyle/computed-style-display-none-expected.txt: Renamed from LayoutTests/fast/css/computed-style-display-none-expected.txt.
        * fast/css/getComputedStyle/computed-style-display-none.html: Renamed from LayoutTests/fast/css/computed-style-display-none.html.
        * fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/fast/css/computed-style-expected.txt.
        * fast/css/getComputedStyle/computed-style-negative-top-expected.txt: Renamed from LayoutTests/fast/css/computed-style-negative-top-expected.txt.
        * fast/css/getComputedStyle/computed-style-negative-top.html: Renamed from LayoutTests/fast/css/computed-style-negative-top.html.
        * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
        * fast/css/getComputedStyle/computed-style-without-renderer.html: Renamed from LayoutTests/fast/css/computed-style-without-renderer.html.
        * fast/css/getComputedStyle/computed-style.html: Renamed from LayoutTests/fast/css/computed-style.html.
        * fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-position-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-background-position.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-position.html.
        * fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-size-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-background-size.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-size.html.
        * fast/css/getComputedStyle/getComputedStyle-border-box-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-box-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-border-box.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-box.html.
        * fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-image-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-border-image.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-image.html.
        * fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-border-spacing.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing.html.
        * fast/css/getComputedStyle/getComputedStyle-borderRadius-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-borderRadius.html: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius.html.
        * fast/css/getComputedStyle/getComputedStyle-relayout-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-relayout-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-relayout.html: Renamed from LayoutTests/fast/css/getComputedStyle-relayout.html.
        * fast/css/getComputedStyle/getComputedStyle-transform-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-transform-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-transform.html: Renamed from LayoutTests/fast/css/getComputedStyle-transform.html.
        * fast/css/getComputedStyle/getComputedStyle-zIndex-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto-expected.txt.
        * fast/css/getComputedStyle/getComputedStyle-zIndex-auto.html: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto.html.
        * fast/css/marginComputedStyle.html: Removed.
        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-expected.txt.
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt.
        * platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.checksum.
        * platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.png.
        * platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.txt.
        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-expected.txt.
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-without-renderer-expected.txt.
        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-expected.txt.
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 23:18:30 +0000 (23:18 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Roben.

        Eliminate a ref-counting leak in InspectorController.

        * inspector/InspectorController.h: Made constructor private, added static create method.
        * page/Page.cpp:
        (WebCore::Page::Page): Change initializer to use static create method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 22:58:55 +0000 (22:58 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24355
        Add InspectorController.idl and convert InspectorController.cpp to use
        JSC bindings.

        * DerivedSources.make: Added InspectorController.idl
        * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
        * bindings/js/JSInspectorControllerCustom.cpp: Added.
        * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
        * inspector/InspectorController.cpp: Removed hand-rolled bindings.
        * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
        * inspector/InspectorController.idl: Added.
        * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 5 Mar 2009 22:56:52 +0000 (22:56 +0000)]
2009-03-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24400
        Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
        media element attributes

        Test: media/video-loop.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        (WebCore::HTMLMediaElement::loadInternal):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::seek):
        (WebCore::HTMLMediaElement::playInternal):
        (WebCore::HTMLMediaElement::loop):
        (WebCore::HTMLMediaElement::setLoop):
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
        (WebCore::HTMLMediaElement::endedPlayback):
        (WebCore::HTMLMediaElement::updatePlayState):
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:

2009-03-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24400
        Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
        media element attributes

        * media/loopend-limits-expected.txt: Removed.
        * media/loopend-limits.html: Removed.
        * media/loopstart-limits-expected.txt: Removed.
        * media/loopstart-limits.html: Removed.
        * media/video-dom-end-expected.txt: Removed.
        * media/video-dom-end.html: Removed.
        * media/video-dom-loopcount-expected.txt: Removed.
        * media/video-dom-loopcount.html: Removed.
        * media/video-dom-loopend-expected.txt: Removed.
        * media/video-dom-loopend.html: Removed.
        * media/video-dom-loopstart-expected.txt: Removed.
        * media/video-dom-loopstart.html: Removed.
        * media/video-dom-start-expected.txt: Removed.
        * media/video-dom-start.html: Removed.
        * media/video-end-expected.txt: Removed.
        * media/video-end.html: Removed.
        * media/video-loop.html: Added, test for new "loop" attribute.
        * media/video-loopcount-expected.txt: Removed.
        * media/video-loopcount.html: Removed.
        * media/video-loopend-expected.txt: Removed.
        * media/video-loopend.html: Removed.
        * media/video-loopstart-expected.txt: Removed.
        * media/video-loopstart.html: Removed.
        * media/video-seek-past-end-paused-expected.txt: Updated for loop changes, add more tests.
        * media/video-seek-past-end-paused.html: Ditto.
        * media/video-seek-past-end-playing-expected.txt: Ditto.
        * media/video-seek-past-end-playing.html: Ditto.
        * media/video-start-expected.txt: Removed.
        * media/video-start.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6651112> Safari asks about re-posting a form even when page...
sfalken@apple.com [Thu, 5 Mar 2009 22:16:19 +0000 (22:16 +0000)]
    <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached

        Reviewed by Ada Chan.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 5 Mar 2009 22:11:51 +0000 (22:11 +0000)]
2009-03-05  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add test for potential crash in window.frames.length
        https://bugs.webkit.org/show_bug.cgi?id=24339

        * fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
        * fast/dom/Window/window-collection-length-no-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Mar 2009 20:37:03 +0000 (20:37 +0000)]
2009-03-05  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=24248

        Make sure painting of overflow controls checks that visibility:visible is set on the block before
        painting.  Pixel tests caught this regression.

        Make sure resizer painting pushes a clip of the corner rect.  It was relying on the clip layers happened
        to do to their bounds (which had nothing to do with overflow).

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintResizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 5 Mar 2009 19:58:19 +0000 (19:58 +0000)]
2009-03-05  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24386
        A faster implementation of extractMIMETypeFromMediaType.

        * platform/network/HTTPParsers.cpp:
        (WebCore::extractMIMETypeFromMediaType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 5 Mar 2009 19:58:10 +0000 (19:58 +0000)]
2009-03-05  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=24392
        Do not get the current time for unless we're doing PRELOAD_DEBUG as this
        can be unnecessarily expensive.

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 5 Mar 2009 19:39:48 +0000 (19:39 +0000)]
2009-03-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24327

        When mapping points and hit testing through transforms, work
        correctly when acclerated animations of transforms are running.

        Tested by LayoutTests/animations/animation-hit-test-transform.html,
        which only failed when ACCELERATED_COMPOSITING was turned on.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::currentTransform):
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::transformFromContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Mike Belshe <mike@belshe.com>
darin@chromium.org [Thu, 5 Mar 2009 19:17:16 +0000 (19:17 +0000)]
2009-03-05  Mike Belshe  <mike@belshe.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24391
        Frame.cpp uses JSC specific includes

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 5 Mar 2009 18:40:21 +0000 (18:40 +0000)]
2009-03-05  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24389
        WebKitGTK+ crashes when cancelling plugin loads

        Remove bogus calls to the client's didFinishLoading method from
        our ResourceHandle::cancel implementation. Calling
        didFinishLoading here is mostly inoffensive for most loads, but
        causes crashes when plugin loads are cancelled.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 5 Mar 2009 18:34:30 +0000 (18:34 +0000)]
2009-03-05  Steve Falkenburg  <sfalken@apple.com>

        Windows build fix.

        * WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Thu, 5 Mar 2009 18:16:33 +0000 (18:16 +0000)]
2009-03-05  Adam Treat  <adam.treat@torchmobile.com>

        Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0.  The method
        ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
        protected by an #if and uses HTMLPlugInElement so it must be included.

        * bindings/js/ScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 17:34:38 +0000 (17:34 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        GTK Build fix.

        * inspector/ConsoleMessage.h: Use proper header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 5 Mar 2009 17:14:07 +0000 (17:14 +0000)]
2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24376
        Split InspectorController.cpp file into separate classes.

        * GNUmakefile.am: Modified to include new files.
        * WebCore.pro: Ditto.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * inspector/ConsoleMessage.cpp: Added.
        * inspector/ConsoleMessage.h: Added.
        * inspector/InspectorController.cpp:
        * inspector/InspectorDOMStorageResource.cpp: Added.
        * inspector/InspectorDOMStorageResource.h: Added.
        * inspector/InspectorDatabaseResource.cpp: Added.
        * inspector/InspectorDatabaseResource.h: Added.
        * inspector/InspectorResource.cpp: Added.
        * inspector/InspectorResource.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41449 268f45cc-cd09-0410-ab3c-d52691b4dbfc