WebKit-https.git
8 years agoRemove custom scrollbar painting hooks
andersca@apple.com [Mon, 3 Oct 2011 22:31:24 +0000 (22:31 +0000)]
Remove custom scrollbar painting hooks
https://bugs.webkit.org/show_bug.cgi?id=69163

Source/WebCore:

Reviewed by Alexey Proskuryakov.

The custom scrollbar and scroll corner painting hooks aren't used by anyone
so go ahead and remove them. This removes the setter/getter and ChromeClient functions.

* page/Chrome.cpp:
* page/ChromeClient.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):

Source/WebKit/chromium:

Reviewed by Alexey Proskuryakov.

* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars):

Source/WebKit/win:

Reviewed by Alexey Proskuryakov.

Remove now unused WebPreferences and ChromeClient overrides.

* Interfaces/IWebPreferences.idl:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::unused3):
(WebPreferences::unused4):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Remove overridden ChromeClient member functions.

Reviewed by Alexey Proskuryakov.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
No need to enable custom scrollbar painting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results again now that Leopard has finally cycled.
abarth@webkit.org [Mon, 3 Oct 2011 22:25:38 +0000 (22:25 +0000)]
Update results again now that Leopard has finally cycled.

* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename many obviously-correct call sites in WebCore using releaseRef to use it by...
darin@apple.com [Mon, 3 Oct 2011 22:15:44 +0000 (22:15 +0000)]
Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
https://bugs.webkit.org/show_bug.cgi?id=68672

Reviewed by Daniel Bates.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
* css/CSSStyleSelector.cpp:
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::styleForElement):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderTheme::themeForPage):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderTheme::themeForPage):
* platform/haiku/RenderThemeHaiku.cpp:
(WebCore::RenderTheme::themeForPage):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::resolve):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::releaseConnectionForDownload):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
* platform/text/BidiContext.cpp:
(WebCore::BidiContext::create):
* platform/wx/RenderThemeWx.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeMac.mm:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderTheme::themeForPage):
* rendering/style/RenderStyle.cpp:
(WebCore::defaultStyle):
Call leakRef instead of releaseRef. I did this only in the cases where
it was obvious to me this was the right way to do it. I'll keep revisiting
sites still calling it releaseRef until they are all gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoremove dead code in flipForWritingMode
ojan@chromium.org [Mon, 3 Oct 2011 22:00:25 +0000 (22:00 +0000)]
remove dead code in flipForWritingMode
https://bugs.webkit.org/show_bug.cgi?id=68948

Reviewed by Hajime Morita.

ChildToParentFlippingAdjustment is never used, so the third argument
to flipForWritingMode always has the same value.

In addition, renamed to flipForWritingModeForChild to be more clear
that it's operating on the child and renamed flipFloatForWritingMode to match.

No new tests. This is just a code cleanup. No functional changes.

* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::flipFloatForWritingModeForChild):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::flipForWritingModeForChild):
(WebCore::RenderBox::topLeftLocation):
* rendering/RenderBox.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96526.
jer.noble@apple.com [Mon, 3 Oct 2011 21:57:53 +0000 (21:57 +0000)]
Unreviewed, rolling out r96526.
http://trac.webkit.org/changeset/96526
https://bugs.webkit.org/show_bug.cgi?id=68587

WEB_AUDIO has numerous 64->32 bit casting warnings, causing
build breakages where -Wall is enabled.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results to account for Windows Vista.
abarth@webkit.org [Mon, 3 Oct 2011 21:55:23 +0000 (21:55 +0000)]
Update results to account for Windows Vista.

* platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex...
joepeck@webkit.org [Mon, 3 Oct 2011 21:50:04 +0000 (21:50 +0000)]
<webkit.org/b/69152> Web Inspector: rgb() with percentages shows wrong hex/hsl values

Reviewed by Pavel Feldman.

Source/WebCore:

Previously we assumed rgb values were always in byte form,
but they could include percentage values. Ex. rgb(100%,0,0).
This patch fixes this, and in the process includes clamping
for invalid percentages, byte values, and alpha values.

Test: inspector/styles/styles-invalid-color-values.html

* inspector/front-end/Color.js:
(WebInspector.Color.prototype._clamp):
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
(WebInspector.Color.prototype._individualRGBValueToHexValue):
(WebInspector.Color.prototype._rgbToHex):
(WebInspector.Color.prototype._rgbToHSL):
An individual rgb value can be either a decimal/float or a
percentage. Rewrite the conversion functions to handle either
input. Regardless of the type of input, always return a clamped
decimal/float value between 0 and 255.

(WebInspector.Color.prototype._rgbaToHSLA):
(WebInspector.Color.prototype._hslaToRGBA):
(WebInspector.Color.prototype._parse):
Clamp the alpha value between 0 and 1.

LayoutTests:

This test outputs all of the supported color format representations
for supplied CSS color values. We expect some of the CSS values
to be clamped, e.g. rgb(300,0,0) to rgb(255,0,0). This also tests
that rgb percentages, such as rgb(100%,0,0), work correctly.

* inspector/styles/styles-invalid-color-values-expected.txt: Added.
* inspector/styles/styles-invalid-color-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium-cg-mac results after http://trac.webkit.org/changeset/96530.
abarth@webkit.org [Mon, 3 Oct 2011 21:45:40 +0000 (21:45 +0000)]
Update chromium-cg-mac results after trac.webkit.org/changeset/96530.

* platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-cg-mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowatchlist: Make watchlist run on a bot.
levin@chromium.org [Mon, 3 Oct 2011 21:44:17 +0000 (21:44 +0000)]
watchlist: Make watchlist run on a bot.
https://bugs.webkit.org/show_bug.cgi?id=68974

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
* Scripts/webkitpy/tool/commands/queues_unittest.py:
Change to log what is run so that we can see the style command
and the watchlist command being run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowatchlist: Allow specified a bug to attach the watchlist info to.
levin@chromium.org [Mon, 3 Oct 2011 21:44:10 +0000 (21:44 +0000)]
watchlist: Allow specified a bug to attach the watchlist info to.
https://bugs.webkit.org/show_bug.cgi?id=69288

Reviewed by Eric Seidel.

* Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
Add tests and fix an existing test because the unit tests do not go through the
normal command line processing (so the -g argument remained when we determined bug ids).
* Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
get the assert raises regex method.
* Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results now that the race condition is fixed. It seems like the
abarth@webkit.org [Mon, 3 Oct 2011 21:42:58 +0000 (21:42 +0000)]
Update results now that the race condition is fixed.  It seems like the
cross-platform results would need to be updated as well, but no bot has
told me that yet.

* platform/chromium-mac-leopard/svg/as-object: Added.
* platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baselines after http://trac.webkit.org/changeset/96530.
abarth@webkit.org [Mon, 3 Oct 2011 21:37:42 +0000 (21:37 +0000)]
Update baselines after trac.webkit.org/changeset/96530.

* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
* platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
* platform/chromium-cg-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
* platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
* platform/chromium-linux/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-mac/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
* platform/chromium-mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
* platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-win/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
* platform/chromium-win/svg/custom/pattern-size-bigger-than-target-size-expected.png:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
* platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
* platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Removed.
* svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT: Add JSStringUtils.{cpp,h}
commit-queue@webkit.org [Mon, 3 Oct 2011 20:57:54 +0000 (20:57 +0000)]
[EFL] DRT: Add JSStringUtils.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=66397

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-10-03
Reviewed by Ryosuke Niwa.

Adds helper functions to compare the equality of C-style strings and
JSStringRef objects.

* DumpRenderTree/efl/JSStringUtils.cpp: Added.
(equals):
* DumpRenderTree/efl/JSStringUtils.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should work in Safari 5.1
abarth@webkit.org [Mon, 3 Oct 2011 20:51:21 +0000 (20:51 +0000)]
garden-o-matic should work in Safari 5.1
https://bugs.webkit.org/show_bug.cgi?id=69290

Reviewed by Sam Weinig.

My old implementation of bind was too clever by half.  This one seems
to work better, at least according to this test.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96532.
commit-queue@webkit.org [Mon, 3 Oct 2011 20:43:37 +0000 (20:43 +0000)]
Unreviewed, rolling out r96532.
http://trac.webkit.org/changeset/96532
https://bugs.webkit.org/show_bug.cgi?id=69289

Accidentally marked failures as expected instead of creating
new baseline. (Requested by krit on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for DFG JIT 32_64.
barraclough@apple.com [Mon, 3 Oct 2011 20:39:10 +0000 (20:39 +0000)]
Unreviewed build fix for DFG JIT 32_64.

* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit->chromium DEPS roll 103471->103694
abarth@webkit.org [Mon, 3 Oct 2011 20:25:13 +0000 (20:25 +0000)]
webkit->chromium DEPS roll 103471->103694
https://bugs.webkit.org/show_bug.cgi?id=69271

This brings in a new tools/win/supalink directory from
http://src.chromium.org/viewvc/chrome?view=rev&revision=103474

Patch by Elliot Poger <epoger@google.com> on 2011-10-03
Reviewed by Adam Barth.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUneviewed by rebaseline after SVG Pattern patch with bug 69261.
krit@webkit.org [Mon, 3 Oct 2011 20:24:09 +0000 (20:24 +0000)]
Uneviewed by rebaseline after SVG Pattern patch with bug 69261.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerformanceTests/Parser/html-parser is only testing parsing of the head element
eric@webkit.org [Mon, 3 Oct 2011 20:09:25 +0000 (20:09 +0000)]
PerformanceTests/Parser/html-parser is only testing parsing of the head element
https://bugs.webkit.org/show_bug.cgi?id=69283

Reviewed by Adam Barth.

While investigating https://bugs.webkit.org/show_bug.cgi?id=68944
I found that the html-parser benchmark was only parsing up to the
first script tag per loop!  We've fixed this by adding the sandbox
tag which will deny all external loads and allow the parser to
synchronously continue parsing the entire document to completion
(as we had expected it was doing).

This changes the profile somewhat.  Line number counting is much
hotter, since we're actually accounting for the parse of the entire
document in our sample.

Total sample time only about doubles, from 1800ms to 3800ms on my machine
which is less than I would have expected.

* Parser/html-parser.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG Pattern tile pixelated on patternTransform
krit@webkit.org [Mon, 3 Oct 2011 19:54:45 +0000 (19:54 +0000)]
SVG Pattern tile pixelated on patternTransform
https://bugs.webkit.org/show_bug.cgi?id=69261

Source/WebCore:

Reviewed by Rob Buis.

Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.

Test: svg/custom/pattern-scaled-pattern-space.svg

* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):

LayoutTests:

Reviewed by Rob Buis.

Add a new test to check that SVG pattern tiles are not pixelated on
scaling with patternTransform.
Updated two more pixel tests. Both changes are progressions.

* platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/mac/svg/custom/non-scaling-stroke-expected.png:
* svg/custom/pattern-scaled-pattern-space-expected.png: Added.
* svg/custom/pattern-scaled-pattern-space-expected.txt: Added.
* svg/custom/pattern-scaled-pattern-space.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add WebWidget API for accessing the current WebCompositor
jamesr@google.com [Mon, 3 Oct 2011 19:52:01 +0000 (19:52 +0000)]
[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181

Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

* public/WebWidget.h:
(WebKit::WebWidget::compositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother round of updates after http://trac.webkit.org/changeset/96509.
abarth@webkit.org [Mon, 3 Oct 2011 19:44:22 +0000 (19:44 +0000)]
Another round of updates after trac.webkit.org/changeset/96509.

* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png:
* platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png:
* platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png:
* platform/chromium-win/fast/invalid/017-expected.png:
* platform/chromium-win/fast/invalid/018-expected.png:
* platform/chromium-win/fast/invalid/020-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should speculate more aggressively on obvious cases on
fpizlo@apple.com [Mon, 3 Oct 2011 19:25:16 +0000 (19:25 +0000)]
DFG should speculate more aggressively on obvious cases on
polymorphic get_by_id
https://bugs.webkit.org/show_bug.cgi?id=69235

Reviewed by Oliver Hunt.

This implements trivial polymorphic get_by_id. It also fixes
problems in the CSE for CheckStructure in the put_by_id
transition case.

Doing this required knowing whether a polymorphic get_by_id stub
was doing a direct access rather than a call of some kind.

Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
scaled mean of all benchmarks.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addStructureSet):
(JSC::DFG::Graph::addStructureTransitionData):
* dfg/DFGNode.h:
(JSC::DFG::StructureTransitionData::StructureTransitionData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::structureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::structureSet):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureSet.h: Added.
(JSC::DFG::StructureSet::StructureSet):
(JSC::DFG::StructureSet::add):
(JSC::DFG::StructureSet::addAll):
(JSC::DFG::StructureSet::remove):
(JSC::DFG::StructureSet::contains):
(JSC::DFG::StructureSet::isSubsetOf):
(JSC::DFG::StructureSet::isSupersetOf):
(JSC::DFG::StructureSet::size):
(JSC::DFG::StructureSet::at):
(JSC::DFG::StructureSet::operator[]):
(JSC::DFG::StructureSet::last):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable WEB_AUDIO by default in the WebKit/mac port.
jer.noble@apple.com [Mon, 3 Oct 2011 19:21:01 +0000 (19:21 +0000)]
Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587

Reviewed by Simon Fraser.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

Source/WebCore:

No new tests; existing webaudio/ layout tests cover this.

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
    the WebCore.framework bundle.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBiquadFilterNode .type attribute is not handled correctly
crogers@google.com [Mon, 3 Oct 2011 19:13:22 +0000 (19:13 +0000)]
BiquadFilterNode .type attribute is not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=69182

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/biquadfilternode-basic.html

* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::initialize):
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::AudioChannelMerger):
* webaudio/AudioChannelSplitter.cpp:
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
* webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::AudioGainNode):
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::setNodeType):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
* webaudio/AudioNode.h:
(WebCore::AudioNode::nodeType):
* webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
* webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
(WebCore::BiquadFilterNode::setType):
* webaudio/BiquadFilterNode.h:
* webaudio/BiquadFilterNode.idl:
* webaudio/BiquadProcessor.h:
(WebCore::BiquadProcessor::setType):
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
* webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
* webaudio/HighPass2FilterNode.cpp:
(WebCore::HighPass2FilterNode::HighPass2FilterNode):
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
* webaudio/LowPass2FilterNode.cpp:
(WebCore::LowPass2FilterNode::LowPass2FilterNode):
* webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
* webaudio/RealtimeAnalyserNode.cpp:
(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
* webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):

LayoutTests:

* webaudio/biquadfilternode-basic-expected.txt: Added.
* webaudio/biquadfilternode-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: support role mapping for HTML5 section elements
cfleizach@apple.com [Mon, 3 Oct 2011 19:01:28 +0000 (19:01 +0000)]
AX: support role mapping for HTML5 section elements
https://bugs.webkit.org/show_bug.cgi?id=69150

Source/WebCore:

We need to map these HTML5 elements to appropriate ARIA roles. That mapping is:
  article -> Document article
  nav -> Landmark navigation
  aside -> Landmark complementary
  section -> Document region
  address -> Landmark content info
  header -> Landmark banner (unless it's in an article or section)
  footer -> Landmark content info (unless it's in an article or section)

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html-section-elements.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

* platform/mac/accessibility/html-section-elements-expected.txt: Added.
* platform/mac/accessibility/html-section-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: change my e-mail in commiters.py
ademar@webkit.org [Mon, 3 Oct 2011 18:55:46 +0000 (18:55 +0000)]
Unreviewed: change my e-mail in commiters.py

(I'm leaving the company and my @openbossa.org will be no more)

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: click point for AXHeadings often returns point on empty space (results in wrong...
cfleizach@apple.com [Mon, 3 Oct 2011 18:09:28 +0000 (18:09 +0000)]
AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262

Actually commit the files this time.

Reviewed by John Sullivan.

* platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
* platform/mac/accessibility/heading-clickpoint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResults from more bots for http://trac.webkit.org/changeset/96498.
abarth@webkit.org [Mon, 3 Oct 2011 18:05:37 +0000 (18:05 +0000)]
Results from more bots for trac.webkit.org/changeset/96498.

* platform/chromium-cg-mac-leopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/chromium-win-vista/svg/filters: Removed.
* platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: click point for AXHeadings often returns point on empty space (results in wrong...
cfleizach@apple.com [Mon, 3 Oct 2011 18:04:54 +0000 (18:04 +0000)]
AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262

Source/WebCore:

When the contextual menu is opened for a heading, often it will open on empty space because
the heading is wider than the content inside. The click point should thus use the content
inside the heading as the click point.

To accomplish this we need to query whether we have children using children() which is a non-const
method, hence the removal of const from clickPoint().

Reviewed by John Sullivan.

Test: platform/mac/accessibility/heading-clickpoint.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by John Sullivan.

* platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
* platform/mac/accessibility/heading-clickpoint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96500.
abarth@webkit.org [Mon, 3 Oct 2011 18:00:05 +0000 (18:00 +0000)]
Unreviewed, rolling out r96500.
http://trac.webkit.org/changeset/96500
https://bugs.webkit.org/show_bug.cgi?id=69268

Breaks inspector, change landed with no test. (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
* inspector/front-end/Linkifier.js: Removed.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnbork the test_expectations file.
abarth@webkit.org [Mon, 3 Oct 2011 17:51:36 +0000 (17:51 +0000)]
Unbork the test_expectations file.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd exact match attribute selectors to the fast path
antti@apple.com [Mon, 3 Oct 2011 17:40:18 +0000 (17:40 +0000)]
Add exact match attribute selectors to the fast path
https://bugs.webkit.org/show_bug.cgi?id=69159

Reviewed by Sam Weinig.

Attribute selectors are increasingly common and we have them in our default style sheet too.
[foo] and [foo="bar"] type selectors can be resolved quickly and easily in the fast path.

- Implement fast path checking for simple attribute selectors.
- Get rid of the ill-defined CSSSelector::hasAttribute(), inline CSSSelector::attribute()

This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
(WebCore::CSSSelector::hasTag):
(WebCore::CSSSelector::attribute):
(WebCore::CSSSelector::isAttributeSelector):
* css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkSelector):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::attributeNameMatches):
(WebCore::SelectorChecker::checkExactAttribute):
(WebCore::SelectorChecker::fastCheckRightmostAttributeSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate expectations for tables tests after http://trac.webkit.org/changeset/96509.
abarth@webkit.org [Mon, 3 Oct 2011 17:37:05 +0000 (17:37 +0000)]
Update expectations for tables tests after trac.webkit.org/changeset/96509.

* platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt: Added.
* platform/chromium-win/fast/forms/file-input-disabled-expected.txt:
* platform/chromium-win/fast/invalid/residual-style-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/chromium/fast/invalid: Added.
* platform/chromium/fast/invalid/017-expected.txt: Added.
* platform/chromium/fast/invalid/018-expected.txt: Added.
* platform/chromium/fast/invalid/020-expected.txt: Added.
* platform/chromium/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium/fast/invalid/table-inside-stray-table-content-expected.txt: Added.
* platform/chromium/fast/table: Added.
* platform/chromium/fast/table/inline-form-assert-expected.txt: Added.
* platform/chromium/tables: Added.
* platform/chromium/tables/mozilla: Added.
* platform/chromium/tables/mozilla/bugs: Added.
* platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
* platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Added.
* platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Added.
* platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug220653-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/core: Added.
* platform/chromium/tables/mozilla_expected_failures/core/conflicts-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/other: Added.
* platform/chromium/tables/mozilla_expected_failures/other/empty_cells-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorespect other paint flags when setting flags for the font. No need to fiddle with...
reed@google.com [Mon, 3 Oct 2011 17:20:36 +0000 (17:20 +0000)]
respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText.
https://bugs.webkit.org/show_bug.cgi?id=69172

Reviewed by Stephen White.

No new tests. This is a cleanup/optimization, existing tests apply

* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION(r95526): It made 3 inspector tests fail
ossy@webkit.org [Mon, 3 Oct 2011 16:57:43 +0000 (16:57 +0000)]
[Qt] REGRESSION(r95526): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=69265

* platform/qt/Skipped: Skip failing tests to make buildbot happy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete bogus expected PNG.
abarth@webkit.org [Mon, 3 Oct 2011 16:56:27 +0000 (16:56 +0000)]
Delete bogus expected PNG.

* platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFontFallbackList: Glyph pages waste a lot of memory.
commit-queue@webkit.org [Mon, 3 Oct 2011 16:50:53 +0000 (16:50 +0000)]
FontFallbackList: Glyph pages waste a lot of memory.
https://bugs.webkit.org/show_bug.cgi?id=69260

Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Dan Bernstein.

Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
glyph pages. This reduces memory consumption by ~900 kB when loading the
full HTML5 spec.

The cost is two additional rehash()es of FontFallbackList::m_pages when
adding the 32nd and 64th pages to the hash map.

* platform/graphics/FontFallbackList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add failing uri parameter to provisional-load-failed and load-failed signals
carlosgc@webkit.org [Mon, 3 Oct 2011 16:36:46 +0000 (16:36 +0000)]
[GTK] Add failing uri parameter to provisional-load-failed and load-failed signals
https://bugs.webkit.org/show_bug.cgi?id=69252

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(didFailProvisionalLoadWithErrorForFrame): Pass failing URL to
signal handler.
(didFailLoadWithErrorForFrame): Ditto.
(webkit_web_loader_client_class_init): Add failing URL parameter
to provisional-load-failed and load-failed signals.
* UIProcess/API/gtk/WebKitWebLoaderClient.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadStatusProvisionalLoadFailed): Update to API changes.
(loadStatusLoadFailed): Ditto.
(loadErrorProvisionalLoadFailed): Ditto.
* UIProcess/API/gtk/webkit2marshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo causing race condition in this test.
abarth@webkit.org [Mon, 3 Oct 2011 16:19:59 +0000 (16:19 +0000)]
Fix typo causing race condition in this test.

* svg/as-object/embedded-svg-immediate-offsetWidth-query.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRight border missing from table with colspan and collapsing border
commit-queue@webkit.org [Mon, 3 Oct 2011 16:19:06 +0000 (16:19 +0000)]
Right border missing from table with colspan and collapsing border
https://bugs.webkit.org/show_bug.cgi?id=14274

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-10-03
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/bug14274.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
* rendering/RenderTable.h:
(WebCore::RenderTable::colToEffCol):

LayoutTests:

* fast/table/border-collapsing/bug14274-expected.png: Copied from LayoutTests/platform/chromium-win/fast/invalid/020-expected.png.
* fast/table/border-collapsing/bug14274-expected.txt: Added.
* fast/table/border-collapsing/bug14274.html: Added.
* platform/chromium-linux/fast/forms/file-input-disabled-expected.txt:
* platform/chromium-linux/fast/invalid/residual-style-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/chromium-win/fast/invalid/017-expected.png:
* platform/chromium-win/fast/invalid/017-expected.txt:
* platform/chromium-win/fast/invalid/018-expected.png:
* platform/chromium-win/fast/invalid/018-expected.txt:
* platform/chromium-win/fast/invalid/020-expected.png:
* platform/chromium-win/fast/invalid/020-expected.txt:
* platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/chromium-win/fast/table/inline-form-assert-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
* platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
* platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
* platform/qt/fast/invalid/table-residual-style-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix memory leak when loading url
carlosgc@webkit.org [Mon, 3 Oct 2011 16:17:49 +0000 (16:17 +0000)]
[GTK] Fix memory leak when loading url
https://bugs.webkit.org/show_bug.cgi?id=69247

Reviewed by Martin Robinson.

Release URL created with WKURLCreateWithUTF8CString().

Source/WebKit2:

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_uri):

Tools:

* MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback):
* MiniBrowser/gtk/main.c:
(loadURI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baselines after http://trac.webkit.org/changeset/96498.
abarth@webkit.org [Mon, 3 Oct 2011 16:16:21 +0000 (16:16 +0000)]
Update baselines after trac.webkit.org/changeset/96498.

* platform/chromium-linux-x86/svg/filters: Removed.
* platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
* platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/chromium-win-vista/svg/filters: Added.
* platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Added.
* platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[UNIX] Rename NetscapePluginModule::pluginInfo to NetscapePluginModule::getPluginInfo...
carlosgc@webkit.org [Mon, 3 Oct 2011 16:14:43 +0000 (16:14 +0000)]
[UNIX] Rename NetscapePluginModule::pluginInfo to NetscapePluginModule::getPluginInfoForLoadedPlugin()
https://bugs.webkit.org/show_bug.cgi?id=69147

Reviewed by Martin Robinson.

* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix make distcheck build
carlosgc@webkit.org [Mon, 3 Oct 2011 16:11:48 +0000 (16:11 +0000)]
[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69243

Reviewed by Martin Robinson.

Source/JavaScriptCore:

* GNUmakefile.list.am:

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofeColorMatrix saturation is not limited to range 0..1 anymore
krit@webkit.org [Mon, 3 Oct 2011 16:02:19 +0000 (16:02 +0000)]
feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245

Unreviewed rebaseline of Win Chromium DRT results.

* platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fix: Qt::escape is deprecated in Qt5
ossy@webkit.org [Mon, 3 Oct 2011 15:58:32 +0000 (15:58 +0000)]
[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162

Use QString::toHtmlEscaped in the Qt5 case.

Source/JavaScriptCore:

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.

* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Added.
(escapeHtml):
* wtf/wtf.pri:

Source/WebCore:

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.

No new tests needed.

* WebCore.pro: adjust the include path accordingly
in the v8 case.

Source/WebKit/qt:

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas.

* Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: [chromium] clean up inspector layout test suppressions on chromium.
pfeldman@chromium.org [Mon, 3 Oct 2011 15:51:45 +0000 (15:51 +0000)]
Not reviewed: [chromium] clean up inspector layout test suppressions on chromium.
https://bugs.webkit.org/show_bug.cgi?id=69263

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening after r96404.
ossy@webkit.org [Mon, 3 Oct 2011 15:43:13 +0000 (15:43 +0000)]
Unreviewed gardening after r96404.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03

* platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure...
loislo@chromium.org [Mon, 3 Oct 2011 15:07:00 +0000 (15:07 +0000)]
Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146

In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.

Reviewed by Yury Semikhatsky.

Test: inspector/performance/resources/network-append-30-requests.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
* inspector/front-end/Linkifier.js: Added.
(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateSourceAnchors):
(WebInspector.Linkifier.prototype._updateAnchor):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Web Inspector: more compilation fixes including making ConsoleMessage...
pfeldman@chromium.org [Mon, 3 Oct 2011 14:56:25 +0000 (14:56 +0000)]
Source/WebCore: Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
https://bugs.webkit.org/show_bug.cgi?id=69253

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessageImpl):
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.get path):
(WebInspector.Cookie.prototype.get domain):
(WebInspector.Cookie.prototype.expires):
* inspector/front-end/DOMAgent.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.searchInContent):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResource):
* inspector/front-end/externs.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.extensionServer.notifyResourceContentCommitted):
(WebInspector.resourceForURL):
(WebInspector.debuggerPresentationModel.linkifyLocation):
(WebInspector.ObjectPropertiesSection):
(WebInspector.ElementsTreeOutline):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
* inspector/generate-protocol-externs:

Tools: Unreviewed. Add Zoltán Árvai as contributor.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2011-10-03

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofeColorMatrix saturation is not limited to range 0..1 anymore
krit@webkit.org [Mon, 3 Oct 2011 14:27:24 +0000 (14:27 +0000)]
feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Opera doesn't limit the range of values for saturation on feColorMatrix from 0 to 1. The limitation
was also removed from the new Filter Effects 1.0 specification. Values outside this range lead to
under- or oversaturation of the filter input image.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/publish/Filters.html#feColorMatrixElement

Test: svg/filters/feColorMatrix-saturate.svg

* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):

LayoutTests:

Reviewed by Nikolas Zimmermann.

Added new test case to test under- or oversaturation of the filter input image if the value
is not in the range of 0..1.
feColorMatrix-values needed a change, since it relies to the old specification text.

* platform/mac/svg/filters/feColorMatrix-values-expected.png:
* platform/mac/svg/filters/feColorMatrix-values-expected.txt:
* svg/filters/feColorMatrix-saturate-expected.png: Added.
* svg/filters/feColorMatrix-saturate-expected.txt: Added.
* svg/filters/feColorMatrix-saturate.svg: Added.
* svg/filters/feColorMatrix-values.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT: Add DumpHistoryItem.{cpp,h}
commit-queue@webkit.org [Mon, 3 Oct 2011 14:21:17 +0000 (14:21 +0000)]
[EFL] DRT: Add DumpHistoryItem.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=63992

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-03
Reviewed by Antonio Gomes.

This is the code responsible for dumping the back and forward history
list.

* DumpRenderTree/efl/DumpHistoryItem.cpp: Added.
(dumpHistoryItem):
(dumpBackForwardListForWebView):
(dumpBackForwardListForWebViews):
* DumpRenderTree/efl/DumpHistoryItem.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink HTMLLIElement.
commit-queue@webkit.org [Mon, 3 Oct 2011 14:16:46 +0000 (14:16 +0000)]
Shrink HTMLLIElement.
https://bugs.webkit.org/show_bug.cgi?id=69250

Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Antti Koivisto.

Don't cache the explicit "value" attribute on the HTMLLIElement,
but fetch it with fastGetAttribute when needed.
This shrinks HTMLLIElement by one CPU word.

* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::parseMappedAttribute):
(WebCore::HTMLLIElement::attach):
* html/HTMLLIElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
ryuan.choi@samsung.com [Mon, 3 Oct 2011 14:13:19 +0000 (14:13 +0000)]
[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
https://bugs.webkit.org/show_bug.cgi?id=68599

Use a C++ compiler for these files and fix compile issues and coding style.

Reviewed by Hajime Morita.

* CMakeListsEfl.txt:
* ewk/ewk_tiled_backing_store.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.c.
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_tiled_matrix.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.c.
* ewk/ewk_tiled_model.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.c.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.
commit-queue@webkit.org [Mon, 3 Oct 2011 14:04:16 +0000 (14:04 +0000)]
[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.
https://bugs.webkit.org/show_bug.cgi?id=68439

We use a dispatch queue and a dispatch source in the WebProcess
to receive a notification when the UI Process dies.
The WebProcess then commits suicide.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::parentProcessDiedCallback):
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening after r96257.
kbalazs@webkit.org [Mon, 3 Oct 2011 13:58:35 +0000 (13:58 +0000)]
Unreviewed gardening after r96257.
https://bugs.webkit.org/show_bug.cgi?id=69257

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agolibdispatch based ParallelJobs is not enough parallel
kbalazs@webkit.org [Mon, 3 Oct 2011 13:06:58 +0000 (13:06 +0000)]
libdispatch based ParallelJobs is not enough parallel
https://bugs.webkit.org/show_bug.cgi?id=66378

Reviewed by Zoltan Herczeg.

Use the appropriate libdispatch API for our use case.
Throw away the hard coded limit of parallel threads
and use dispatch_apply with the default priority normal
queue istead of using our own custom serial queue (which
was a misuse of the API). Enabling PARALLEL_JOBS is now
a 60% win (2.63x as fast) on the methanol benchmark
(https://gitorious.org/methanol) with an SVG centric test set
while the old implementation was almost identical (less than 5% win).

* wtf/ParallelJobsLibdispatch.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Add support for backend search in script content.
vsevik@chromium.org [Mon, 3 Oct 2011 12:56:52 +0000 (12:56 +0000)]
Web Inspector: Add support for backend search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/search/search-in-concatenated-script.html
       http/tests/inspector/search/search-in-script.html

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):

LayoutTests:

* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):
* http/tests/inspector/search/resources/search-concatenated.html: Added.
* http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
* http/tests/inspector/search/search-in-concatenated-script.html: Added.
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-script-expected.txt: Added.
* http/tests/inspector/search/search-in-script.html: Added.
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96481.
commit-queue@webkit.org [Mon, 3 Oct 2011 11:58:07 +0000 (11:58 +0000)]
Unreviewed, rolling out r96481.
http://trac.webkit.org/changeset/96481
https://bugs.webkit.org/show_bug.cgi?id=69251

Breaks webkit_unit_tests on Linux(dbg) (Requested by hwennborg
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03

* WebKit.gypi:
* public/WebCompositor.h:
* public/WebWidgetClient.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
* src/WebCompositorImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):
* tests/WebCompositorImplTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
commit-queue@webkit.org [Mon, 3 Oct 2011 11:37:54 +0000 (11:37 +0000)]
[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223

WebKitTestRunner must include Qt / qnamespace header
to get a definition of Qt::MouseButtons.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.

* WebKitTestRunner/EventSenderProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add Zoltán Árvai as contributor.
ossy@webkit.org [Mon, 3 Oct 2011 10:55:11 +0000 (10:55 +0000)]
Unreviewed. Add Zoltán Árvai as contributor.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
pfeldman@chromium.org [Mon, 3 Oct 2011 09:54:27 +0000 (09:54 +0000)]
Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=69244

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatParameter):
(WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessage.prototype._formatParameterAsString):
(WebInspector.ConsoleMessage.prototype._printArray):
(WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):
* inspector/front-end/ConsoleView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt gardening after r96404
rgabor@webkit.org [Mon, 3 Oct 2011 09:30:18 +0000 (09:30 +0000)]
Unreviewed Qt gardening after r96404

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-03

* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: restore partial front-end compilability
pfeldman@chromium.org [Mon, 3 Oct 2011 09:16:12 +0000 (09:16 +0000)]
Web Inspector: restore partial front-end compilability
https://bugs.webkit.org/show_bug.cgi?id=69221

Removed unused isWhitespace; introduced missing classes in Inspector.json;
generated externs for the protocol types along with the commands.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-03
Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
* inspector/front-end/ElementsTreeOutline.js:
():
* inspector/front-end/Object.js:
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._mouseMove):
* inspector/front-end/View.js:
* inspector/front-end/externs.js:
(Array.prototype.remove):
* inspector/generate-protocol-externs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomethod/enctype/formMethod/formEnctype properties should be limited to known values.
tkent@chromium.org [Mon, 3 Oct 2011 06:59:23 +0000 (06:59 +0000)]
method/enctype/formMethod/formEnctype properties should be limited to known values.
https://bugs.webkit.org/show_bug.cgi?id=68887

Reviewed by Hajime Morita.

Source/WebCore:

According to the standard and other browser behaviors, the
following IDL properties should be reflected to the corresponding
HTML attributes on setting, but should return normalized values on
getting.
- HTMLFormElement::method
- HTMLFormElement::enctype
- HTMLInputElement::formMethod
- HTMLInputElement::formEnctype
- HTMLButtonElement::formMethod
- HTMLButtonElement::formEnctype

Tests: fast/forms/enctype-attribute.html
       fast/forms/method-attribute.html

* html/HTMLButtonElement.idl:
Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formEnctype):
Normalizes the value by parseEncodingType().
(WebCore::HTMLFormControlElement::setFormEnctype):
Simply calls setAttribute()
(WebCore::HTMLFormControlElement::formMethod):
Normalizes the value by parseMethodType().
(WebCore::HTMLFormControlElement::setFormMethod):
Simply calls setAttribute()
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
Follow the Attributes function renaming.
(WebCore::HTMLFormElement::method):
Normalizes the value by parseMethodType().
* html/HTMLFormElement.idl:
Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.
* html/HTMLInputElement.idl: ditto.
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::parseEncodingType):
New function made from a part of old parseEncodingType().
(WebCore::FormSubmission::Attributes::updateEncodingType):
Renamed from parseEncodingType().
(WebCore::FormSubmission::Attributes::parseMethodType):
New function made from a part of old parseMethodType().
(WebCore::FormSubmission::Attributes::updateMethodType):
Renamed from parseMethodType().
(WebCore::FormSubmission::create):
Follow the Attributes function renaming.
* loader/FormSubmission.h:
(WebCore::FormSubmission::Attributes::methodString):
A helper function to provide normalized strings for FormSubmission::Method.

LayoutTests:

* fast/dom/element-attribute-js-null-expected.txt:
* fast/dom/element-attribute-js-null.html: Correct an expectation for HTMLFormElement::method.
* fast/forms/enctype-attribute-expected.txt: Added.
* fast/forms/enctype-attribute.html: Added.
* fast/forms/method-attribute-expected.txt: Added.
* fast/forms/method-attribute.html: Added.
* fast/forms/script-tests/submit-form-attributes.js: Correct expectations.
* fast/forms/submit-form-attributes-expected.txt: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt]REGRESSION(r95912): It made sputnik tests flakey
zherczeg@webkit.org [Mon, 3 Oct 2011 06:49:50 +0000 (06:49 +0000)]
[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990

Reviewed by Geoffrey Garen.

Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.

* runtime/Structure.h:
(JSC::Structure::transitionCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG misses some obvious opportunities for common subexpression elimination
fpizlo@apple.com [Mon, 3 Oct 2011 02:13:11 +0000 (02:13 +0000)]
DFG misses some obvious opportunities for common subexpression elimination
https://bugs.webkit.org/show_bug.cgi?id=69233

Reviewed by Oliver Hunt.

0.7% speed-up on SunSpider.

* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add WebWidget API for accessing the current WebCompositor
commit-queue@webkit.org [Mon, 3 Oct 2011 01:11:45 +0000 (01:11 +0000)]
[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181

Patch by James Robinson <jamesr@chromium.org> on 2011-10-02
Reviewed by Darin Fisher.

Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.

Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.

* public/WebWidget.h:
(WebKit::WebWidget::compositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStrength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAg...
weinig@apple.com [Mon, 3 Oct 2011 00:40:43 +0000 (00:40 +0000)]
Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
https://bugs.webkit.org/show_bug.cgi?id=69230

Reviewed by Anders Carlsson.

../WebCore:

* WebCore.exp.in:
* page/Frame.h:
* page/mac/FrameMac.mm:

../WebKit/mac:

* WebView/WebHTMLRepresentation.mm:
(regExpForLabels):
(searchForLabelsBeforeElement):
(matchLabelsAgainstString):
(matchLabelsAgainstElement):
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 67455 - Different regular expression result
barraclough@apple.com [Mon, 3 Oct 2011 00:22:04 +0000 (00:22 +0000)]
Bug 67455 - Different regular expression result

Reviewed by Darin Adler.

Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.

Source/JavaScriptCore:

* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchParentheses):
    - Simplify some nested if else logic.
(JSC::Yarr::Interpreter::backtrackParentheses):
    - Simplify some nested if else logic.
    - Only return early from backtrackParentheses on success/error, not on failure.

LayoutTests:

* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:
    - Added test cases from bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
ap@apple.com [Sun, 2 Oct 2011 20:02:03 +0000 (20:02 +0000)]
REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=68542

Reviewed by Mark Rowe.

* WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
commit-queue@webkit.org [Sun, 2 Oct 2011 19:54:31 +0000 (19:54 +0000)]
[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223

Source/WebCore:

Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
Add a missing include path and a missing objective source file to WebCore.pro.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

No new tests, build fix.

* WebCore.pro:
* platform/mac/WebVideoFullscreenHUDWindowController.h:

Source/WebKit2:

After the merge of the Qt5 refactor branch, networking stuff has been
extracted into a separate library. The qmlplugin needs to link to that
library to get QNetworkReply defined.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.

* UIProcess/API/qt/qmlplugin/qmlplugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove an unused member in RenderTable::ColumnStruct
jchaffraix@webkit.org [Sun, 2 Oct 2011 19:41:08 +0000 (19:41 +0000)]
Remove an unused member in RenderTable::ColumnStruct
https://bugs.webkit.org/show_bug.cgi?id=69119

Reviewed by Darin Adler.

No test as there should be no change in behavior.

The member was added several years ago and its users were removed or changed. The code would
need a refactoring but this would be tricky to get right. This change just removes the member
to reap the short-term benefits.

* rendering/RenderTable.h:
(WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove temporary baselines after http://trac.webkit.org/changeset/96470.
abarth@webkit.org [Sun, 2 Oct 2011 17:38:09 +0000 (17:38 +0000)]
Remove temporary baselines after trac.webkit.org/changeset/96470.

* platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-win-vista/svg/css: Removed.
* platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-win-xp/svg/css: Removed.
* platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
* platform/chromium/svg/filters: Removed.
* platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
* platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* svg/css/circle-in-mask-with-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up obsolete code in gardeningserver.py related to
abarth@webkit.org [Sun, 2 Oct 2011 17:35:35 +0000 (17:35 +0000)]
Clean up obsolete code in gardeningserver.py related to
STATIC_FILE_NAMES.  Rather than serve the UI via the Python HTTP
server, we just serve it off the filesystem directly.

We had planned to serve the UI off build.webkit.org, but that server is
somewhat slow.  We'll probably serve the UI of some web server, but
we'll need to work that out later.

* Scripts/webkitpy/tool/commands/gardenomatic.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRip out half-backed garden-o-matic features in preparation for wider use
abarth@webkit.org [Sun, 2 Oct 2011 17:18:28 +0000 (17:18 +0000)]
Rip out half-backed garden-o-matic features in preparation for wider use
https://bugs.webkit.org/show_bug.cgi?id=69226

This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features.  We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting.  We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baseline and expectations after http://trac.webkit.org/changeset/96470
abarth@webkit.org [Sun, 2 Oct 2011 15:25:49 +0000 (15:25 +0000)]
Update baseline and expectations after trac.webkit.org/changeset/96470

* platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
* platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
* platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
* platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
* platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
* platform/chromium-mac/svg/filters/filter-clip-expected.png:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-win-vista/svg/css: Added.
* platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-win-xp/svg/css: Added.
* platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-win/svg/custom/mask-colorspace-expected.png:
* platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
* platform/chromium/svg/filters: Added.
* platform/chromium/svg/filters/filter-clip-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
* platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
* platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
* platform/mac/svg/filters/filter-clip-expected.txt: Removed.
* platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
* platform/qt/svg/filters/filter-clip-expected.txt: Removed.
* svg/custom/grayscale-gradient-mask-expected.txt: Added.
* svg/custom/mask-with-all-units-expected.txt: Added.
* svg/filters/filter-clip-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble...
mitz@apple.com [Sun, 2 Oct 2011 08:25:34 +0000 (08:25 +0000)]
REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
https://bugs.webkit.org/show_bug.cgi?id=68760

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/invalid-lengths.html

Made length-comparison media queries accept only length values. In compatibility mode, numbers
are allowed as well, and they are interpreted as pixels.

* css/MediaQueryEvaluator.cpp:
(WebCore::computeLength): Added this helper function.
(WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
(WebCore::device_widthMediaFeatureEval): Ditto.
(WebCore::heightMediaFeatureEval): Ditto.
(WebCore::widthMediaFeatureEval): Ditto.

LayoutTests:

* fast/media/invalid-lengths-expected.txt: Added.
* fast/media/invalid-lengths.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG Mask should take 'color-interpolation' into account to determine the color space...
krit@webkit.org [Sun, 2 Oct 2011 07:15:08 +0000 (07:15 +0000)]
SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
https://bugs.webkit.org/show_bug.cgi?id=69076

Source/WebCore:

Reviewed by Simon Fraser.

SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
is a performance improvement for platforms without native support for linearRGB color space. The
color space transformation can be avoided.

Test: svg/custom/grayscale-gradient-mask-2.svg

* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
* rendering/svg/RenderSVGResourceMasker.h:

LayoutTests:

Reviewed by Simon Fraser.

Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.

* platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
* platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
* platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
* svg/custom/grayscale-gradient-mask-2.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTweak expectations for leopard some more.
abarth@webkit.org [Sun, 2 Oct 2011 06:49:32 +0000 (06:49 +0000)]
Tweak expectations for leopard some more.

* platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect post-build step for WinCairo test runs.
bfulgham@webkit.org [Sun, 2 Oct 2011 04:34:17 +0000 (04:34 +0000)]
Correct post-build step for WinCairo test runs.
https://bugs.webkit.org/show_bug.cgi?id=69191

Reviewed by Brian Weinstein.

* DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
shell case to handle the CFLite build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fixing draw matrix for composited layers. This
vangelis@chromium.org [Sun, 2 Oct 2011 02:21:48 +0000 (02:21 +0000)]
[chromium] Fixing draw matrix for composited layers. This
was a regression introduced by:
http://trac.webkit.org/changeset/96454

https://bugs.webkit.org/show_bug.cgi?id=69217

Reviewed by James Robinson.

Tests: compositor test now pass

* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLeopard build fix: Updated for Strong<T> changes.
ggaren@apple.com [Sun, 2 Oct 2011 01:13:04 +0000 (01:13 +0000)]
Leopard build fix: Updated for Strong<T> changes.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
* WebView/WebScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved redundant helper functions for allocating Strong handles
ggaren@apple.com [Sun, 2 Oct 2011 00:54:56 +0000 (00:54 +0000)]
Removed redundant helper functions for allocating Strong handles
https://bugs.webkit.org/show_bug.cgi?id=69218

Reviewed by Sam Weinig.

../JavaScriptCore:

* heap/Heap.h:
(JSC::Heap::handleHeap):
* runtime/JSGlobalData.h: Removed these helper functions, since they
just created indirection.

* heap/StrongInlines.h: Added. Broke out a header for inline functions
to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Go forth and build.

* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::setSingleTransition):
* heap/Local.h:
(JSC::::Local):
* heap/Strong.h:
(JSC::::Strong):
(JSC::::set):
* heap/Weak.h:
(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.

* bytecompiler/BytecodeGenerator.cpp:
* runtime/JSGlobalData.cpp:
* runtime/LiteralParser.cpp:
* runtime/RegExpCache.cpp: Updated for header changes.

../JavaScriptGlue:

* JSRun.cpp:
* JSValueWrapper.cpp:

../WebCore:

* ForwardingHeaders/heap/StrongInlines.h: Added.
* bindings/js/JSCallbackData.h:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptCachedFrameData.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptState.cpp:
* bindings/js/ScriptValue.h:
* bindings/js/WorkerScriptController.cpp:
* bridge/runtime_root.cpp:

../WebKit2:

* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded myself to reviewers, because I'm now a reviewer.
fpizlo@apple.com [Sat, 1 Oct 2011 22:08:07 +0000 (22:08 +0000)]
Added myself to reviewers, because I'm now a reviewer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAll of JSC's heuristics should be in one place for easier tuning
fpizlo@apple.com [Sat, 1 Oct 2011 22:03:22 +0000 (22:03 +0000)]
All of JSC's heuristics should be in one place for easier tuning
https://bugs.webkit.org/show_bug.cgi?id=69201

Reviewed by Oliver Hunt.

This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.

It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* runtime/Heuristics.cpp: Added.
(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h: Added.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBencher script makes it difficult to do automated performance testing
fpizlo@apple.com [Sat, 1 Oct 2011 21:58:45 +0000 (21:58 +0000)]
Bencher script makes it difficult to do automated performance testing
https://bugs.webkit.org/show_bug.cgi?id=69207

Reviewed by Sam Weinig.

This adds two new features:

The ability to disable automatic VM detection, which is flaky if any
profiling features are enabled in jsc.

The ability to compute, and report, a scaled result for all benchmark
suites. It is the geometric mean of three numbers: SunSpider's
arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
It is also possible to turn off all other output from bencher and just
get this number with the --brief option.

* Scripts/bencher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport string length in the DFG
oliver@apple.com [Sat, 1 Oct 2011 21:46:51 +0000 (21:46 +0000)]
Support string length in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69215

Reviewed by Geoff Garen.

Adds a GetStringLength node to the DFG so that we can support
string.length inline.

* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSString.h:
(JSC::JSString::offsetOfLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTR is not successfully changing the NSUserDefaults
weinig@apple.com [Sat, 1 Oct 2011 20:48:57 +0000 (20:48 +0000)]
WTR is not successfully changing the NSUserDefaults
https://bugs.webkit.org/show_bug.cgi?id=69204

Reviewed by Dan Bernstein.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
get our overrides picked up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete bogus text expectation.
abarth@webkit.org [Sat, 1 Oct 2011 19:56:47 +0000 (19:56 +0000)]
Delete bogus text expectation.

* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed...
commit-queue@webkit.org [Sat, 1 Oct 2011 19:21:44 +0000 (19:21 +0000)]
JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69205

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-01
Reviewed by Gavin Barraclough.

If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).

* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNote test as timing out.
abarth@webkit.org [Sat, 1 Oct 2011 17:32:10 +0000 (17:32 +0000)]
Note test as timing out.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate Mac baselines.
abarth@webkit.org [Sat, 1 Oct 2011 17:29:56 +0000 (17:29 +0000)]
Update Mac baselines.

* platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/svg/as-object: Added.
* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Removed.
* platform/chromium-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96421.
commit-queue@webkit.org [Sat, 1 Oct 2011 07:22:29 +0000 (07:22 +0000)]
Unreviewed, rolling out r96421.
http://trac.webkit.org/changeset/96421
https://bugs.webkit.org/show_bug.cgi?id=69206

It broke Qt-WK2 build (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-01

Source/JavaScriptCore:

* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Removed.
* wtf/wtf.pri:

Source/WebCore:

* WebCore.pro:

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Track separate scroll deltas on the compositor thread
enne@google.com [Sat, 1 Oct 2011 03:15:10 +0000 (03:15 +0000)]
[chromium] Track separate scroll deltas on the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69034

Reviewed by James Robinson.

Source/WebCore:

Test: new tests in CCLayerTreeHostImplTest/CCLayerTreeHostTest

Track scroll deltas and maximum scrolls on LayerChromium/CCLayerImpl.
The CCLayerImpl tree is now able to adjust these scroll deltas
independent of the main thread. To push them back to the main thread,
CCLayerTreeHostImpl collects them all and then bakes them into the
scroll position during a begin frame and commit call. This allows new
deltas to be collected while the scroll position containing the old
delta and the old scroll position will be overwritten during the next
commit.

Only the main frame is supported right now for pushing this scroll
delta back into the authoritative WebKit source to keep both sides in
sync.

Move tilingTransform() to the impl tree because drawTransform() is now
updated using scroll deltas and so the results from calculating draw
transforms needs to be dynamic so that children are updated properly.

Also, exposed DebugScopedSetImplThread public because it's used in a
few places.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore::LayerChromium::scrollDelta):
(WebCore::LayerChromium::scrollable):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setViewport):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::scrollBy):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::maxScrollPosition):
(WebCore::CCLayerImpl::setMaxScrollPosition):
(WebCore::CCLayerImpl::scrollDelta):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::scrollable):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::applyScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
(WebCore::CCTiledLayerImpl::draw):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:

Source/WebKit/chromium:

Add testing support for scroll deltas on layers.

* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyScrollDelta):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostImplTest.cpp: Added.
(WebCore::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebCore::CCLayerTreeHostImplTest::expectClearedScrollDeltasRecursive):
(WebCore::CCLayerTreeHostImplTest::expectContains):
(WebCore::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::applyScrollDelta):
(WTF::MockLayerTreeHostClient::applyScrollDelta):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::CCLayerTreeHostTestScrollSimple::CCLayerTreeHostTestScrollSimple):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollSimple::afterTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::CCLayerTreeHostTestScrollMultipleRedraw):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::afterTest):
* tests/TreeSynchronizerTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-30 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 1 Oct 2011 03:12:37 +0000 (03:12 +0000)]
2011-09-30  Daniel Bates  <dbates@webkit.org>

        Attempt to fix the Apple Windows and WinCairo Debug builds after
        <http://trac.webkit.org/changeset/96446> (https://bugs.webkit.org/show_bug.cgi?id=69203).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove the symbol
        ?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z since the
        corresponding function, JSValue::toStrictThisObject(), was removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=69202
hyatt@apple.com [Sat, 1 Oct 2011 03:07:46 +0000 (03:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69202

[CSS3 Regions] Make positioned objects use the first region as the ICB when it
is their containing block. Make sure static distance computations take into
account the current region as well.

Reviewed by Sam Weinig.

Source/WebCore:

Added new tests in fast/regions.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForContent):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::computeLogicalTopPositionedOffset):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
* rendering/RenderFlowThread.h:

LayoutTests:

* fast/regions/positioned-objects-block-static-in-regions.html: Added.
* fast/regions/positioned-objects-block-static-in-rtl-regions.html: Added.
* fast/regions/positioned-objects-in-regions.html: Added.
* fast/regions/positioned-objects-in-rtl-regions.html: Added.
* fast/regions/positioned-objects-inline-static-in-regions.html: Added.
* fast/regions/positioned-objects-inline-static-in-rtl-regions.html: Added.
* fast/regions/positioned-objects-perpendicular-flows-in-regions.html: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG operation results are not set correctly in JSVALUE32_64 DFG JIT
commit-queue@webkit.org [Sat, 1 Oct 2011 02:14:36 +0000 (02:14 +0000)]
DFG operation results are not set correctly in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69126

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
Reviewed by Gavin Barraclough.

The setupResults routine has the bug of reversing the source and destination.
Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::setupTwoStubArgs):
(JSC::DFG::setupResults):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding unit tests for LayerChromium. Emphasis on verifying
commit-queue@webkit.org [Sat, 1 Oct 2011 02:12:06 +0000 (02:12 +0000)]
Adding unit tests for LayerChromium.  Emphasis on verifying
behavior of notifySyncRequired callback and tree manipulations.
https://bugs.webkit.org/show_bug.cgi?id=68572

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-30
Reviewed by James Robinson.

* WebKit.gypi:
* tests/LayerChromiumTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96450 268f45cc-cd09-0410-ab3c-d52691b4dbfc