WebKit-https.git
7 years agoWeb Inspector: Flame Chart. Provide Overview pane for better user expirience.
loislo@chromium.org [Wed, 20 Mar 2013 16:19:07 +0000 (16:19 +0000)]
Web Inspector: Flame Chart. Provide Overview pane for better user expirience.
https://bugs.webkit.org/show_bug.cgi?id=112496

Reviewed by Yury Semikhatsky.

This patch implements basic part of Overview Pane in FlameChart.
The idea of the patch is to move everything into chart-container element.
And put OverviewGrid into new overview-container element.

Drive by change: fix the layout of the flame chart elements.
Drive by change: fix the drag window & drag resizer mechanics
for the case when the parent element has zero offsetLeft.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.OverviewCalculator):
(WebInspector.FlameChart.OverviewCalculator.prototype._updateBoundaries):
(WebInspector.FlameChart.OverviewCalculator.prototype.computePosition):
(WebInspector.FlameChart.OverviewCalculator.prototype.formatTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.maximumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.minimumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.update):
* inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._resizerElementStartDragging):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.WindowSelector):
* inspector/front-end/TimelineOverviewPane.js:
* inspector/front-end/flameChart.css:
(.chart-container .item-anchor):
(.overview-container):
(.chart-container):
(#flame-chart-overview-grid .resources-dividers-label-bar):
* inspector/front-end/inspectorCommon.css:
(.resources-divider-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Plumbing CSS warnings
commit-queue@webkit.org [Wed, 20 Mar 2013 16:07:26 +0000 (16:07 +0000)]
Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

Adding a framework for plumbing CSS warnings from CSSParser/grammar to the Inspector console.

* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::logError):
* css/CSSParser.h:
(CSSParser):
(CSSParser::Location):
(WebCore):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):
* css/StyleSheetContents.h:
(StyleSheetContents):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* page/PageConsole.cpp:
(WebCore::PageConsole::addMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Qt 4.8 expected results removal from Trunk.
kadam@inf.u-szeged.hu [Wed, 20 Mar 2013 16:05:26 +0000 (16:05 +0000)]
[Qt] Qt 4.8 expected results removal from Trunk.

Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/TestExpectations: Removed.
* platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Removed.
* platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Removed.
* platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
* platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Removed.
* platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Removed.
* platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Removed.
* platform/qt-4.8/fast/events/xsl-onload-expected.txt: Removed.
* platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Removed.
* platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Removed.
* platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Removed.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Removed.
* platform/qt-4.8/fast/text/find-kana-expected.txt: Removed.
* platform/qt-4.8/fast/text/find-russian-expected.txt: Removed.
* platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Removed.
* platform/qt-4.8/fast/url/path-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Removed.
* platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
* platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Removed.
* platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Removed.
* platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Removed.
* platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Removed.
* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Removed.
* platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
* platform/qt-4.8/svg/custom/bug45331-expected.png: Removed.
* platform/qt-4.8/svg/custom/bug45331-expected.txt: Removed.
* platform/qt-4.8/svg/custom/bug78807-expected.txt: Removed.
* platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Removed.
* platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Removed.
* platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Removed.
* platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
junov@google.com [Wed, 20 Mar 2013 15:59:08 +0000 (15:59 +0000)]
[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=112605

Reviewed by James Robinson.

Source/WebCore:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

No new tests: Affected code paths covered by existing tests.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* html/HTMLCanvasElement.h:
* page/Settings.in:
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(ImageBuffer):
* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecording):
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
(WebCore::Canvas2DLayerBridge::flush):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::ImageBuffer):

Source/WebKit/chromium:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

* public/WebSettings.h:
(WebKit::WebSettings::setDeferred2dCanvasEnabled):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
* tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):

Tools:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):

LayoutTests:

Marked some 2d canvas tests as failing. These tests are using the
two point radial gradient API.  The bug was already present in
chromium. Starts getting detected in DRT with this change.
Related: crbug.com/222140

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDrop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
mkwst@chromium.org [Wed, 20 Mar 2013 15:42:42 +0000 (15:42 +0000)]
Drop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112813

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112042, this patch brings 'document.domain'
mismatch error messages into line with the newly origin-only default
message. There will probably be two or three more patches in this series
just to keep the rebaselines down to something managably reviewable.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
    Move the default message redefinition up out of the final 'return' so
    that 'document.domain' mismatch errors grab the new text.

LayoutTests:

* http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
* http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
* http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add promptText param to Page.handleJavaScriptDialog
commit-queue@webkit.org [Wed, 20 Mar 2013 15:40:38 +0000 (15:40 +0000)]
Web Inspector: Add promptText param to Page.handleJavaScriptDialog
https://bugs.webkit.org/show_bug.cgi?id=112706

Patch by Ken Kania <kkania@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
* inspector/InspectorPageAgent.h:

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Qt 4.8 tool related stuff removal from webkitpy.
kadam@inf.u-szeged.hu [Wed, 20 Mar 2013 15:10:54 +0000 (15:10 +0000)]
[Qt] Qt 4.8 tool related stuff removal from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=112699.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._search_paths):
(QtPort._port_specific_expectations_files):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix SourceFrame.js compilation warning
commit-queue@webkit.org [Wed, 20 Mar 2013 14:59:52 +0000 (14:59 +0000)]
Web Inspector: fix SourceFrame.js compilation warning
https://bugs.webkit.org/show_bug.cgi?id=112804

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.

No new tests: no change in behavior.

- Explicitly parse lineNumber from object property name.
- Add type annotations to ensure addMessageToSource is monomorphic.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.clearMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] unsafe persistent access in V8LazyEventListener
commit-queue@webkit.org [Wed, 20 Mar 2013 14:34:33 +0000 (14:34 +0000)]
[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807

Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.

No new tests.

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
anilsson@rim.com [Wed, 20 Mar 2013 14:32:50 +0000 (14:32 +0000)]
[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
https://bugs.webkit.org/show_bug.cgi?id=112757

Reviewed by Rob Buis.

PR 306465

Make the LayerRenderer and associated code more bullet-proof when it
comes to enabling vertex attribute arrays, by enabling them already
when LayerRenderer::useProgram() is called. This fixes a bug where the
video hole punch rectangle wasn't punched when preceding rendering
caused the vertex attribute array at index 0 to be disabled, such as
when rendering the text selection overlay immediately before video.

A number of places where the position attribute index was hard-coded
to 0 were also fixed. This causes no change in behavior, the position
attribute was really at 0, but nonetheless that shouldn't be hardcoded.

The effects of this patch are only manually testable.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::useProgram):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] implement highlightRange method
commit-queue@webkit.org [Wed, 20 Mar 2013 14:30:19 +0000 (14:30 +0000)]
Web Inspector: [CodeMirror] implement highlightRange method
https://bugs.webkit.org/show_bug.cgi?id=112802

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

- Implement highlightRange/removeHighlight methods in
CodeMirrorTextEditor.
- Update TextEditor interface closure annotations.

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.removeHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):
* inspector/front-end/DefaultTextEditor.js:
* inspector/front-end/TextEditor.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] show source location for codemirror text editor
commit-queue@webkit.org [Wed, 20 Mar 2013 14:28:37 +0000 (14:28 +0000)]
Web Inspector: [CodeMirror] show source location for codemirror text editor
https://bugs.webkit.org/show_bug.cgi?id=112798

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

No new tests.

- Implement CodeMirrorTextEditor.copyRange method
- Fire "selectionChange" event for text editor delegate from
CodeMirrorTextEditor.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
(WebInspector.CodeMirrorTextEditor.prototype._cursorActivity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable kerning by default
allan.jensen@digia.com [Wed, 20 Mar 2013 14:18:54 +0000 (14:18 +0000)]
[Qt] Enable kerning by default
https://bugs.webkit.org/show_bug.cgi?id=112704

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

Enable default kerning when fast kerning is available.

To support layout tests that depend on kerning being off by default,
a method is added to DumpRenderTreeSupportQt to reset the default.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetDefaultTypesettingFeatures):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):

Tools:

Disable kerning by default, since some reference test expectations
expect kerning to be default off.

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement and32 on MIPS platform
commit-queue@webkit.org [Wed, 20 Mar 2013 14:06:09 +0000 (14:06 +0000)]
Implement and32 on MIPS platform
https://bugs.webkit.org/show_bug.cgi?id=112665

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-20
Reviewed by Zoltan Herczeg.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32): Added missing method.
(MacroAssemblerMIPS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove empty function stubs from TestRunnerQt.
zeno.albisser@digia.com [Wed, 20 Mar 2013 13:29:41 +0000 (13:29 +0000)]
[Qt] Remove empty function stubs from TestRunnerQt.
https://bugs.webkit.org/show_bug.cgi?id=112799

We are reducing the code in TestRunnerQt step by step,
in order to finally replace all of it with the generic
TestRunner implementation.
This patch removes several simple function stubs that
currently do not implement any actual functionality.

Reviewed by Kenneth Rohde Christiansen.

* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[or] Updated WebKitGTK+ Translation for Odia [or] language.
kov@webkit.org [Wed, 20 Mar 2013 13:16:45 +0000 (13:16 +0000)]
[or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037

Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).

* or.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146331.
commit-queue@webkit.org [Wed, 20 Mar 2013 13:08:38 +0000 (13:08 +0000)]
Unreviewed, rolling out r146331.
http://trac.webkit.org/changeset/146331
https://bugs.webkit.org/show_bug.cgi?id=112795

Does not work as expected (Requested by carewolf on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

Source/WebCore:

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Resources] Local Storage: "Add item" row height doesn't match underly...
eustas@chromium.org [Wed, 20 Mar 2013 12:43:13 +0000 (12:43 +0000)]
Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
https://bugs.webkit.org/show_bug.cgi?id=112433

Reviewed by Pavel Feldman.

Fixed cell height to correspond grid step.

* inspector/front-end/dataGrid.css:
(.data-grid td): Fixed cell height to correspond grid step.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
commit-queue@webkit.org [Wed, 20 Mar 2013 12:26:23 +0000 (12:26 +0000)]
[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
https://bugs.webkit.org/show_bug.cgi?id=112687

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.

Hide the SearchBar by default on window creation.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
allan.jensen@digia.com [Wed, 20 Mar 2013 11:53:52 +0000 (11:53 +0000)]
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Kerning is on by default in Qt. This means we need to disable it
when WebCore does not request it.

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: OverviewGrid rename classes according to names of js classes.
loislo@chromium.org [Wed, 20 Mar 2013 11:51:27 +0000 (11:51 +0000)]
Web Inspector: OverviewGrid rename classes according to names of js classes.
https://bugs.webkit.org/show_bug.cgi?id=112786

Reviewed by Yury Semikhatsky.

It is a part of meta bug 'extract OverviewGrid from TimelineOverviewPane'.
As the last step it renames timeline-...... classes to overview-grid-...... classes
and moves them to inspectorCommon.css

* inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
* inspector/front-end/inspectorCommon.css:
(.overview-grid-window-selector):
(.overview-grid-window):
(.overview-grid-dividers-background):
(.overview-grid-window-rulers):
(.overview-grid-window-resizer):
* inspector/front-end/timelinePanel.css:
(.timeline-frame-overview .overview-grid-window):
(.timeline-frame-overview .overview-grid-dividers-background):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146304.
commit-queue@webkit.org [Wed, 20 Mar 2013 11:50:58 +0000 (11:50 +0000)]
Unreviewed, rolling out r146304.
http://trac.webkit.org/changeset/146304
https://bugs.webkit.org/show_bug.cgi?id=112788

to many expectations to update (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(WebKit):
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
* DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
(WebThemeControlDRTWin):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
(WebThemeEngineDRTMac):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146315.
commit-queue@webkit.org [Wed, 20 Mar 2013 11:43:46 +0000 (11:43 +0000)]
Unreviewed, rolling out r146315.
http://trac.webkit.org/changeset/146315
https://bugs.webkit.org/show_bug.cgi?id=112789

followup to 146304 rollout (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
* platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Removed.
* platform/chromium-win/css1/box_properties/border_right_inline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146316.
commit-queue@webkit.org [Wed, 20 Mar 2013 11:41:33 +0000 (11:41 +0000)]
Unreviewed, rolling out r146316.
http://trac.webkit.org/changeset/146316
https://bugs.webkit.org/show_bug.cgi?id=112790

followup to 146304 rollout (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Switch Drawer animation from JavaScript to CSS transitions.
commit-queue@webkit.org [Wed, 20 Mar 2013 11:31:48 +0000 (11:31 +0000)]
Web Inspector: Switch Drawer animation from JavaScript to CSS transitions.
https://bugs.webkit.org/show_bug.cgi?id=112586

This is prerequisite to make Drawer work in overlay mode.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.this.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.immediatelyFinishAnimation):
(WebInspector.Drawer.prototype._getAnimationStyles):
* inspector/front-end/UIUtils.js:
* inspector/front-end/inspector.css:
(.animate-slow *):
(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [DataGrid] Refactorings.
eustas@chromium.org [Wed, 20 Mar 2013 11:30:13 +0000 (11:30 +0000)]
Web Inspector: [DataGrid] Refactorings.
https://bugs.webkit.org/show_bug.cgi?id=112690

Reviewed by Pavel Feldman.

Source/WebCore:

1. Avoid using string literals;
2. Remove unused notifications; turn "populate" to method invocation;
3. Replace some getters with regular functions.

* inspector/front-end/DataGrid.js: Applied refactorings.
* inspector/front-end/ApplicationCacheItemsView.js: Adopted changes.
* inspector/front-end/BottomUpProfileDataGridTree.js: Ditto.
* inspector/front-end/CPUProfileView.js: Ditto.
* inspector/front-end/CSSSelectorProfileView.js: Ditto.
* inspector/front-end/CookiesTable.js: Ditto.
* inspector/front-end/DirectoryContentView.js: Ditto.
* inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
* inspector/front-end/HeapSnapshotGridNodes.js: Ditto.
* inspector/front-end/NativeMemorySnapshotView.js: Ditto.
* inspector/front-end/NetworkPanel.js: Ditto.
* inspector/front-end/ProfileDataGridTree.js: Ditto.
* inspector/front-end/ResourceWebSocketFrameView.js: Ditto.
* inspector/front-end/TopDownProfileDataGridTree.js: Ditto.
* inspector/front-end/dataGrid.css: Ditto.

LayoutTests:

Adopted changes.

* inspector/profiler/heap-snapshot-test.js: Adopted changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Support -webkit-font-smoothing
allan.jensen@digia.com [Wed, 20 Mar 2013 11:22:14 +0000 (11:22 +0000)]
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Set QFont antialiasing settings based on the font smoothing settings in FontDescription.

* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):

Source/WebKit/qt:

Export an interface so DRT can also disable font-smoothing like WTR does.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setShouldUseFontSmoothing):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Set shouldUseFontSmoothing to false to match WebKitTestRunner.

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed rebaselining after r146206.
zeno.albisser@digia.com [Wed, 20 Mar 2013 11:05:42 +0000 (11:05 +0000)]
[Qt] Unreviewed rebaselining after r146206.

The webgl-composite-modes test started failing due to
the newly introduced more restrictive pixel tolerance.
It turns out that the expectation was created without multisampling
enabled. However, Qt does implement this.

* platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
* platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's...
commit-queue@webkit.org [Wed, 20 Mar 2013 11:04:44 +0000 (11:04 +0000)]
ewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=112536

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-03-20
Reviewed by Gyuyoung Kim.

Added changes to clear JS garbage and release FastMalloc's free pages to OS
while calling ewk_settings_memory_cache_clear API.

* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] accessibility/aria-scrollbar-role.html is failing
commit-queue@webkit.org [Wed, 20 Mar 2013 10:15:34 +0000 (10:15 +0000)]
[EFL] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111989

Unreviewed EFL gardening

accessibility/aria-scrollbar-role.html passes after r146312.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame.
commit-queue@webkit.org [Wed, 20 Mar 2013 10:01:22 +0000 (10:01 +0000)]
[EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.

.:

Add a manual test to check the running of scripted transition animation.

* ManualTests/animation/transition-on-and-offscreen-animation.html: Added.

Source/WebKit/efl:

Add dummy functions for WK1.

Example test case: ManualTests/animation/transition-on-and-offscreen-animation.html

* WebCoreSupport/ChromeClientEfl.cpp: Add dummy functions for WK1.
(WebCore):
(WebCore::ChromeClientEfl::scheduleAnimation):
(WebCore::ChromeClientEfl::serviceScriptedAnimations):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):

Source/WTF:

The issue is that if the animation starts outside of the area covered by keepRects,
the web process does not create tiles of the animation layer and the layer moves
without having any tiles. In order to fix this issue, CoordinatedLayerHost must call
scheduleLayerFlush to create new tiles when the layer enters the area covered by keepRect.
However EFL port didn't call scheduleLayerFlush periodically for animation.
We can tie scripted animations with synchronization of the layer and that already
has been implemented in r123786 by Qt port. This patch is for activating r123786 patch.

The testing is covered by ManualTests/animation/transition-on-and-offscreen-animation.html

* wtf/Platform.h: Disable REQUEST_ANIMATION_FRAME_TIMER.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Allow toolbar customization
commit-queue@webkit.org [Wed, 20 Mar 2013 10:01:06 +0000 (10:01 +0000)]
Web Inspector: Allow toolbar customization
https://bugs.webkit.org/show_bug.cgi?id=112440

Adds a tools menu item that allows the user to show/hide
inspector panels on the toolbar.

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.

* inspector/front-end/InspectorView.js:
* inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.ExperimentsSettings):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._isPanelVisibleByDefault):
(WebInspector.Toolbar.prototype.set _hidePanel):
(WebInspector.Toolbar.prototype._showPanel):
(WebInspector.Toolbar.prototype._togglePanelsMenu):
* inspector/front-end/inspector.css:
(#toolbar-panels-menu):
(#toolbar-panels-menu:hover):
(#toolbar-panels-menu:active):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: Fix incorrect debugger column number value.
mark.lam@apple.com [Wed, 20 Mar 2013 09:09:38 +0000 (09:09 +0000)]
Source/JavaScriptCore: Fix incorrect debugger column number value.
https://bugs.webkit.org/show_bug.cgi?id=112741.

Reviewed by Oliver Hunt.

1. In lexer, parser, and debugger code, renamed column to charPosition.
2. Convert the charPosition to the equivalent column number before
   passing it to the debugger.
3. Changed ScopeNodes to take both a startLocation and an endLocation.
   This allows FunctionBodyNodes, ProgramNodes, and EvalNodess to emit
   correct debug hooks with correct starting line and column numbers.
4. Fixed the Lexer to not reset the charPosition (previously
   columnNumber) in Lexer::lex().

* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::debug):
- convert charPosition to column for the debugger.
* interpreter/Interpreter.h:
* jit/JITStubs.cpp:
(DEFINE_STUB_FUNCTION(void, op_debug)):
* llint/LLIntSlowPaths.cpp:
(LLINT_SLOW_PATH_DECL(slow_op_debug)):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
* parser/Lexer.h:
(JSC::Lexer::currentCharPosition):
(Lexer):
(JSC::::lexExpectIdentifier):
* parser/NodeConstructors.h:
(JSC::Node::Node):
* parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::Node::charPosition):
(Node):
(StatementNode):
(JSC::StatementNode::lastLine):
(ScopeNode):
(JSC::ScopeNode::startLine):
(JSC::ScopeNode::startCharPosition):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
* parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
* parser/Parser.h:
(JSC::::parse):
* parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionBody):

Source/WTF: Introducing String::reverseFindLineTerminator().
https://bugs.webkit.org/show_bug.cgi?id=112741.

Reviewed by Oliver Hunt.

This is needed by the JSC debugger code for computing column numbers.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reverseFindLineTerminator):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::reverseFindLineTerminator):
* wtf/text/WTFString.h:
(WTF::String::reverseFindLineTerminator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
eustas@chromium.org [Wed, 20 Mar 2013 09:08:56 +0000 (09:08 +0000)]
Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
https://bugs.webkit.org/show_bug.cgi?id=112667

Reviewed by Pavel Feldman.

New parameter will allow more options on how long setting will persist.
Possible options are: localStorage, sessionStorage and no-storage.

Additional change: use delete instead of .removeItem to make it possible
use any object as storage.

* inspector/front-end/Settings.js:
Added "storage" parameter and used is instead of "window.localStorage".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening.
antonm@chromium.org [Wed, 20 Mar 2013 08:55:39 +0000 (08:55 +0000)]
Unreviewed Chromium gardening.

Rebaselining after r146304.

* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening.
antonm@chromium.org [Wed, 20 Mar 2013 08:43:36 +0000 (08:43 +0000)]
Unreviewed Chromium gardening.

Rebaselining after r146304.

* platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
* platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
* platform/chromium-win/css1/box_properties/border_right_inline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Network] Fix the bug of WebSocketFrameView crash.
commit-queue@webkit.org [Wed, 20 Mar 2013 08:38:12 +0000 (08:38 +0000)]
Web Inspector: [Network] Fix the bug of WebSocketFrameView crash.
https://bugs.webkit.org/show_bug.cgi?id=112771.

Patch by Pan Deng <pan.deng@intel.com> on 2013-03-20
Reviewed by Pavel Feldman.

WebSocketFrameView crashes when websocket receives an error message, this
patch fixes this problem, and error message will be shown in dataGrid as expected.

No new tests.

* inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView): Handle the errorMessage case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove remainings of obsolete LogLevels and MessageSources from inspector JS part.
commit-queue@webkit.org [Wed, 20 Mar 2013 08:34:23 +0000 (08:34 +0000)]
Remove remainings of obsolete LogLevels and MessageSources from inspector JS part.
https://bugs.webkit.org/show_bug.cgi?id=112709

By the way tuned messagesources in ApplicationCacheGroup.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.ConsoleMessageImpl.prototype.toString):
* inspector/front-end/ConsoleModel.js:
* inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
(WebInspector.ExtensionServer.prototype._makeConsoleMessage):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] accessibility/aria-scrollbar-role.html is failing
commit-queue@webkit.org [Wed, 20 Mar 2013 08:12:15 +0000 (08:12 +0000)]
[GTK] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98358

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20
Reviewed by Martin Robinson.

Source/WebCore:

Adds support for checking an orientation attribute of accessibility object.
AccessibilityObject that represents ScrollBar element should be ATK_VALUE type.
ScrollBar element can be considered as a Range Widget that is able to expose some
range values.

Test: accessibility/aria-scrollbar-role.html

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
(getInterfaceMaskFromObject):

Tools:

Adds support for checking accessibility object's orientation.
Orientation is checked by retrieving proper state of accessibility object.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(checkElementState):
(AccessibilityUIElement::orientation):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::orientation):

LayoutTests:

Fixed failing test.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixing a typo in libLevelDB_la_CFLAGS assignment - cxflags -> cflags.
zandobersek@gmail.com [Wed, 20 Mar 2013 08:07:19 +0000 (08:07 +0000)]
Unreviewed. Fixing a typo in libLevelDB_la_CFLAGS assignment - cxflags -> cflags.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Rebaselining after r146305.
zandobersek@gmail.com [Wed, 20 Mar 2013 08:03:37 +0000 (08:03 +0000)]
Unreviewed GTK gardening. Rebaselining after r146305.

* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/gtk/http/tests/security/contentSecurityPolicy/1.1: Added.
* platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r146089): It broke 20 sputnik tests on ARM traditional and Thumb2
ossy@webkit.org [Wed, 20 Mar 2013 07:43:14 +0000 (07:43 +0000)]
REGRESSION(r146089): It broke 20 sputnik tests on ARM traditional and Thumb2
https://bugs.webkit.org/show_bug.cgi?id=112676

Rubber-stamped by Filip Pizlo.

Add one more EABI_32BIT_DUMMY_ARG to make DFG JIT ARM EABI compatible
again after r146089 similar to https://bugs.webkit.org/show_bug.cgi?id=84449

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAbsolute position div without width specified does not reflow its text when it is...
robert@webkit.org [Wed, 20 Mar 2013 07:16:08 +0000 (07:16 +0000)]
Absolute position div without width specified does not reflow its text when it is moved (and computed width changes)
https://bugs.webkit.org/show_bug.cgi?id=112052

Source/WebCore:

Reviewed by Emil A Eklund.

If a positioned block has auto width then any movement means the block needs to be resized.

Test: fast/block/positioned-block-auto-width-movement.html

* rendering/style/RenderStyle.cpp:
(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::diff):

LayoutTests:

Reviewed by Emil A Eklund.

* fast/block/positioned-block-auto-width-movement-expected.html: Added.
* fast/block/positioned-block-auto-width-movement.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146301.
commit-queue@webkit.org [Wed, 20 Mar 2013 06:37:24 +0000 (06:37 +0000)]
Unreviewed, rolling out r146301.
http://trac.webkit.org/changeset/146301
https://bugs.webkit.org/show_bug.cgi?id=112776

Caused hundreds of tests to hit assertions on Windows debug
bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
(WebCore):
(DocumentLoader):
* loader/MainResourceLoader.cpp: Added.
(WebCore):
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::~MainResourceLoader):
(WebCore::MainResourceLoader::create):
(WebCore::MainResourceLoader::clearResource):
(WebCore::MainResourceLoader::frameLoader):
(WebCore::MainResourceLoader::request):
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::setDefersLoading):
(WebCore::MainResourceLoader::defersLoading):
(WebCore::MainResourceLoader::setDataBufferingPolicy):
(WebCore::MainResourceLoader::loader):
(WebCore::MainResourceLoader::identifier):
* loader/MainResourceLoader.h: Added.
(WebCore):
(MainResourceLoader):
(WebCore::MainResourceLoader::cachedMainResource):
(WebCore::MainResourceLoader::documentLoader):
* loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSP 1.1: Stub out SecurityPolicyViolationEvent interface.
mkwst@chromium.org [Wed, 20 Mar 2013 06:23:08 +0000 (06:23 +0000)]
CSP 1.1: Stub out SecurityPolicyViolationEvent interface.
https://bugs.webkit.org/show_bug.cgi?id=112681

Reviewed by Adam Barth.

Source/WebCore:

A first pass at a SecurityPolicyViolationEvent interface is defined in
CSP 1.1's editor's draft[1]. This patch puts the big components into
place so that we can start getting some implementation experience with
the new event interface as it's defined, and feed that back into the
working group.

Here, we're only defining the interface, and creating a listener on the
Document. Events aren't yet being fired when Content Security Policy
violations occur. I'll tackle that in a future patch; adding files is
a big enough annoyance to do it separately.

This patch has only two web-visible impacts:

- Document objects now have an 'onsecuritypolicyviolation' attribute.
- A SecurityPolicyViolationEvent constructor is accessible on the Window object.

Ports that have not enabled the CSP_NEXT flag should experience no change.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicyviolationevent-events

Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
    Wow! A new file! This is so exciting! I'm going to tell ALL my build
    systems about this!
* dom/Document.h:
* dom/Document.idl:
    Define an 'onsecuritypolicyviolation' event handler on Document objects.
* dom/EventNames.h:
* dom/EventNames.in:
    Define a 'securitypolicyviolation' event type.
* dom/SecurityPolicyViolationEvent.h: Added.
(WebCore::SecurityPolicyViolationEventInit::SecurityPolicyViolationEventInit):
(SecurityPolicyViolationEventInit):
(SecurityPolicyViolationEvent):
(WebCore::SecurityPolicyViolationEvent::create):
(WebCore::SecurityPolicyViolationEvent::documentURI):
(WebCore::SecurityPolicyViolationEvent::referrer):
(WebCore::SecurityPolicyViolationEvent::blockedURI):
(WebCore::SecurityPolicyViolationEvent::violatedDirective):
(WebCore::SecurityPolicyViolationEvent::effectiveDirective):
(WebCore::SecurityPolicyViolationEvent::originalPolicy):
(WebCore::SecurityPolicyViolationEvent::sourceURL):
(WebCore::SecurityPolicyViolationEvent::lineNumber):
(WebCore::SecurityPolicyViolationEvent::interfaceName):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
* dom/SecurityPolicyViolationEvent.idl: Added.
    Define the SecurityPolicyViolationEvent's IDL, and then create all the
    boilerplate necessary to properly initialize a SecurityPolicyViolationEvent
    object with the relevant properties.
* page/DOMWindow.idl:
    Add the new SecurityPolicyViolationEvent constructor to the Window object
    so it's available on a page.

LayoutTests:

* http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html: Added.
    Simple test which checks only that events are created correctly,
    and that the event handler exists on Document. We'll test the
    real functionality once we wire the event up to the handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move WebThemeEngine implementations to TestRunner library
jochen@chromium.org [Wed, 20 Mar 2013 05:59:27 +0000 (05:59 +0000)]
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(WebKit):
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Timeline] Tune status bar UI for limited-width window.
eustas@chromium.org [Wed, 20 Mar 2013 05:13:34 +0000 (05:13 +0000)]
Web Inspector: [Timeline] Tune status bar UI for limited-width window.
https://bugs.webkit.org/show_bug.cgi?id=112702

Reviewed by Pavel Feldman.

Reduce filter titles when there is not enough space.

* inspector/front-end/TimelinePanel.js: Add classnames to elements.
* inspector/front-end/timelinePanel.css: Specify "flex" behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQt and GTK+ rebaselines after r146272.
rniwa@webkit.org [Wed, 20 Mar 2013 04:31:02 +0000 (04:31 +0000)]
Qt and GTK+ rebaselines after r146272.

* css3/flexbox/flexbox-baseline-expected.txt:
* platform/qt/css3/flexbox/flexbox-baseline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge MainResourceLoader into DocumentLoader
japhet@chromium.org [Wed, 20 Mar 2013 04:21:39 +0000 (04:21 +0000)]
Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969

Reviewed by Adam Barth.

No new tests, refactor only.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from
    ~MainResourceLoader.
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
(WebCore):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::dataReceived):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks
     for normal and empty loads, just use a single boolean.
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoadingMainResource):
* loader/MainResourceLoader.cpp: Removed.
* loader/MainResourceLoader.h: Removed.
* loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove testRunner.setTouchDragDropEnabled to internals.settings
tony@chromium.org [Wed, 20 Mar 2013 04:16:47 +0000 (04:16 +0000)]
Move testRunner.setTouchDragDropEnabled to internals.settings
https://bugs.webkit.org/show_bug.cgi?id=112739

Reviewed by Adam Barth.

Tools:

* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner): Remove unnecessary code.
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo): Always set to false.

LayoutTests:

Update tests to use internals.settings. This testRunner method was only exposed on
Chromium, but now that Settings.in generates internals.settings setters, we can
use that instead.

* fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html:
* fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html:
* fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html:
* touchadjustment/touch-links-longpress.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
pilgrim@chromium.org [Wed, 20 Mar 2013 04:08:49 +0000 (04:08 +0000)]
[Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112754

Reviewed by Darin Fisher.

Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
now that it's always defined.

Source/WebKit/chromium:

* public/WebCommonWorkerClient.h:
(WebCommonWorkerClient):
* public/WebFrame.h:
(WebFrame):
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):
* src/LocalFileSystemChromium.cpp:
(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::openFileSystem):
* src/WebWorkerClientImpl.h:
* src/WorkerFileSystemCallbacksBridge.cpp:
* src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix expected results added in r146224.
rniwa@webkit.org [Wed, 20 Mar 2013 04:00:45 +0000 (04:00 +0000)]
Fix expected results added in r146224.

* fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt:
* fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r146272.
rniwa@webkit.org [Wed, 20 Mar 2013 03:32:57 +0000 (03:32 +0000)]
Mac rebaseline after r146272.

* platform/mac/css3/flexbox/flexbox-baseline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines after r146272.
ojan@chromium.org [Wed, 20 Mar 2013 02:51:20 +0000 (02:51 +0000)]
Rebaselines after r146272.

* platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
* platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCache a pointer to V8DOMActivityLogger in PerContextData.
commit-queue@webkit.org [Wed, 20 Mar 2013 02:38:54 +0000 (02:38 +0000)]
Cache a pointer to V8DOMActivityLogger in PerContextData.
https://bugs.webkit.org/show_bug.cgi?id=112719

Patch by Ankur Taly <ataly@google.com> on 2013-03-19
Reviewed by Kentaro Hara.

Adds a data member (and getter, setter methods) to V8PerContextData
that holds a pointer to a V8DOMActivityLogger. This member is set while
initializing the context for a V8DOMWindowShell. Ownership of the pointer
is still retained by the HashMap in DOMWrapperWorld.
As a result of this patch, subsequent patches that will implement logging
for DOM API access (See bug 107207) will be able to obtain a reference to
the logger directly from PerContextData. This will benefit performance as it
will be faster than looking up the logger in the DOMActivityLoggerMap in
DOMWrapperWorld.

There are no new tests as there is no change in behavior.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8PerContextData.h:
(WebCore::V8PerContextData::activityLogger):
(V8PerContextData):
(WebCore::V8PerContextData::setActivityLogger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows rebaseline after r146284.
rniwa@webkit.org [Wed, 20 Mar 2013 02:14:26 +0000 (02:14 +0000)]
Windows rebaseline after r146284.

* platform/win/fast/dom/icon-url-property-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146290.
kbr@google.com [Wed, 20 Mar 2013 02:12:24 +0000 (02:12 +0000)]
Unreviewed, rolling out r146290.
http://trac.webkit.org/changeset/146290
https://bugs.webkit.org/show_bug.cgi?id=112751

Broke Chromium Mac build.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(WebKit):
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
* DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
(WebThemeControlDRTWin):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
(WebThemeEngineDRTMac):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodo not use string reference for enum support in CodeGeneratorJS.pm
commit-queue@webkit.org [Wed, 20 Mar 2013 02:11:22 +0000 (02:11 +0000)]
do not use string reference for enum support in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112760

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-19
Reviewed by Kentaro Hara.

Do use string references in generated JS bindings for enum values.

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] canvas-fallback-content.html is failing
commit-queue@webkit.org [Wed, 20 Mar 2013 02:08:09 +0000 (02:08 +0000)]
[EFL] canvas-fallback-content.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111998

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-19
Reviewed by Chris Fleizach.

Tools:

Adds support for getting platform name.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticValues):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::platformName):

LayoutTests:

Fixed failing test. The reason of failure is different accessibility role for combobox element.

* accessibility/canvas-fallback-content.html: Use platform specific role.
* platform/efl-wk1/TestExpectations: Unskipped.
* platform/efl-wk2/TestExpectations: Unskipped.
* platform/efl/accessibility/canvas-fallback-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move WebThemeEngine implementations to TestRunner library
jochen@chromium.org [Wed, 20 Mar 2013 01:58:51 +0000 (01:58 +0000)]
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
* DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(WebKit):
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaselining after r146279.
kbr@google.com [Wed, 20 Mar 2013 01:56:30 +0000 (01:56 +0000)]
Unreviewed rebaselining after r146279.

* platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
* platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:
* platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark fast/canvas/canvas-toDataURL-webp.html as failing
commit-queue@webkit.org [Wed, 20 Mar 2013 01:47:58 +0000 (01:47 +0000)]
[chromium] Mark fast/canvas/canvas-toDataURL-webp.html as failing
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.

Patch by James Zern <jzern@chromium.org> on 2013-03-19

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the test results and expectations for win-wk2
benjamin@webkit.org [Wed, 20 Mar 2013 01:43:54 +0000 (01:43 +0000)]
Remove the test results and expectations for win-wk2
https://bugs.webkit.org/show_bug.cgi?id=112510

Reviewed by Tim Horton.

* platform/win-wk2/TestExpectations: Removed.
* platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
* platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Removed.
* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Removed.
* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Removed.
* platform/win-wk2/editing/selection/after-line-break-expected.txt: Removed.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Removed.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Removed.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Removed.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Removed.
* platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Removed.
* platform/win-wk2/fast/css/pseudo-any-expected.txt: Removed.
* platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Removed.
* platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
* platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
* platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
* platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Removed.
* platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Removed.
* platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Removed.
* platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Removed.
* platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Removed.
* platform/win-wk2/plugins/resize-from-plugin-expected.txt: Removed.
* platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
* platform/win-wk2/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
* platform/win-wk2/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
* platform/win-wk2/svg/text/bidi-text-query-expected.png: Removed.
* platform/win-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd failing test expectations on Windows per bugs 112764 and 112766.
rniwa@webkit.org [Wed, 20 Mar 2013 01:23:16 +0000 (01:23 +0000)]
Add failing test expectations on Windows per bugs 112764 and 112766.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake RLC::haveNonMainLayersWithTiledBacking() public and fix the name
simon.fraser@apple.com [Wed, 20 Mar 2013 01:10:47 +0000 (01:10 +0000)]
Make RLC::haveNonMainLayersWithTiledBacking() public and fix the name
https://bugs.webkit.org/show_bug.cgi?id=112763

Reviewed by Tim Horton.

Downstream code needs to call hasNonMainLayersWithTiledBacking().

* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::hasNonMainLayersWithTiledBacking):
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrameLoader::didChangeIcons isn't called when the favicon is changed.
levin@chromium.org [Wed, 20 Mar 2013 01:09:38 +0000 (01:09 +0000)]
FrameLoader::didChangeIcons isn't called when the favicon is changed.
https://bugs.webkit.org/show_bug.cgi?id=112080

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/dom/icon-url-property.html

* dom/Document.cpp:
(WebCore::Document::addIconURL): Made the callback for didChangeIcons
happen whenever there are favicon changes instead of filtering it
and have to be in sync about what hosts care about. As far as I could
tell no hosts rely on this callback except for Chromium, so in general
doing less work here may potentially help a small amount for other
ports.

LayoutTests:

* fast/dom/icon-url-property-expected.txt:
* fast/dom/icon-url-property.html: Add some more calls
to trigger didChangeIcons callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't throw on infinity or NaN index in HTMLOptionsCollection.add()
commit-queue@webkit.org [Wed, 20 Mar 2013 00:57:28 +0000 (00:57 +0000)]
Don't throw on infinity or NaN index in HTMLOptionsCollection.add()
https://bugs.webkit.org/show_bug.cgi?id=112612

Patch by Michael Pruett <michael@68k.org> on 2013-03-19
Reviewed by Kentaro Hara.

Source/WebCore:

HTMLOptionsCollection.add() should not throw a type error when
its optional index argument is infinity or NaN. Such values
should instead be converted to 0 with no error.

Tests: fast/dom/non-numeric-values-numeric-parameters.html
       fast/js/select-options-add.html

* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):

LayoutTests:

* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/js/select-options-add-expected.txt:
* platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Removed.
* platform/chromium/fast/js/select-options-add-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSecurity: Heap-use-after-free in WebCore::AXObjectCache::getOrCreate
dmazzoni@google.com [Wed, 20 Mar 2013 00:27:16 +0000 (00:27 +0000)]
Security: Heap-use-after-free in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=112044

Reviewed by Chris Fleizach.

Source/WebCore:

Always call recalcSectionsIfNeeded before accessing
table sections.

Test: accessibility/table-remove-cell-crash.html

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):

LayoutTests:

Adds test showing a crash / assertion failure if a cell is
deleted from a table and the table's AX object is accessed.

* accessibility/table-remove-cell-crash-expected.txt: Added.
* accessibility/table-remove-cell-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] add IDL 'enum' in DOM methods
commit-queue@webkit.org [Wed, 20 Mar 2013 00:21:09 +0000 (00:21 +0000)]
[v8] add IDL 'enum' in DOM methods
https://bugs.webkit.org/show_bug.cgi?id=112644

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-19
Reviewed by Kentaro Hara.

This adds V8 support for enumerations in method parameters.

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::methodWithEnumArgMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r146277.
kbr@google.com [Wed, 20 Mar 2013 00:19:23 +0000 (00:19 +0000)]
Unreviewed, rolling out r146277.
http://trac.webkit.org/changeset/146277
https://bugs.webkit.org/show_bug.cgi?id=111695

Broke Chromium Android build

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
* chromium/public/WebSpeechSynthesisUtterance.h: Removed.
* chromium/public/WebSpeechSynthesisVoice.h: Removed.
* chromium/public/WebSpeechSynthesizer.h: Removed.
* chromium/public/WebSpeechSynthesizerClient.h: Removed.

Source/WebCore:

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
* Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
(SpeechSynthesisUtterance):
* Modules/speech/SpeechSynthesisVoice.h:
* WebCore.exp.in:
* WebCore.gypi:
* platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
* platform/PlatformSpeechSynthesisUtterance.cpp:
* platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
* platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore::PlatformSpeechSynthesisVoice::create):
* platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
* platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):
* platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
* platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create):
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
* platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):

Source/WebKit/chromium:

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't compute background obscuration on every repaint
antti@apple.com [Wed, 20 Mar 2013 00:17:58 +0000 (00:17 +0000)]
Don't compute background obscuration on every repaint
https://bugs.webkit.org/show_bug.cgi?id=112457

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/backgrounds/obscured-background-child-style-change.html

It is generally enough to compute background obscuration status once per layout rather than doing it on every repaint.
Since there are fewer layouts than repaints this will allow more expensive checks in the future.

With this patch adds caching and invalidation of the obscuration status.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layout):

    Invalidate the obscuration status on layout.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):

    Invalidate the parent obscuration status if there is repaint-only style change (often background related).
    Tested by the new fast/css/obscured-background-child-style-change.html.

(WebCore::RenderBox::layout):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
* rendering/RenderBox.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):

    Use CachedImage::currentFrameKnownToBeOpaque which ensures that the frame is decoded and we get the real status.
    Tested by an additional case in fast/css/obscured-background-child-style-change.html.

* rendering/RenderImage.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasBoxDecorations):
(WebCore::RenderObject::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::boxDecorationState):
(WebCore::RenderObject::RenderObjectBitfields::setBoxDecorationState):

    Combine box decoration bit and the obscuration status so we only need one extra bit.

(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setHasBoxDecorations):
(WebCore::RenderObject::invalidateBackgroundObscurationStatus):
(WebCore::RenderObject::backgroundIsKnownToBeObscured):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):

LayoutTests:

* fast/backgrounds/obscured-background-child-style-change-expected.html: Added.
* fast/backgrounds/obscured-background-child-style-change.html: Added.
* fast/repaint/obscured-background-no-repaint.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Selection overlay is sometimes in wrong position.
commit-queue@webkit.org [Tue, 19 Mar 2013 23:46:28 +0000 (23:46 +0000)]
[BlackBerry] Selection overlay is sometimes in wrong position.
https://bugs.webkit.org/show_bug.cgi?id=112748

Patch by Andrew Lo <anlo@rim.com> on 2013-03-19
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

Internal PR 305384.
Translate by parent's offset when drawing selection overlay.

* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement Web Speech Synthesis for Chromium
dmazzoni@google.com [Tue, 19 Mar 2013 23:26:08 +0000 (23:26 +0000)]
Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):
* chromium/public/WebSpeechSynthesisUtterance.h: Added.
(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):
* chromium/public/WebSpeechSynthesisVoice.h: Added.
(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):
* chromium/public/WebSpeechSynthesizer.h: Added.
(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):
* chromium/public/WebSpeechSynthesizerClient.h: Added.
(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
* Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
* Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):
* WebCore.exp.in:
* WebCore.gypi:
* platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
* platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):
* platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):
* platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
* platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):
* platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):
* platform/PlatformSpeechSynthesizer.h:
(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
* platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):
* platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):
* platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):
* platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.
(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):
* platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.
(WebCore):
(WebSpeechSynthesizerClientImpl):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
* platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix after r146220.
rniwa@webkit.org [Tue, 19 Mar 2013 23:17:47 +0000 (23:17 +0000)]
Another build fix after r146220.

* English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r146164): It made all inspector tests timeout on ARM traditional
ossy@webkit.org [Tue, 19 Mar 2013 23:16:06 +0000 (23:16 +0000)]
REGRESSION(r146164): It made all inspector tests timeout on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=112697

Unreviewed gardening, skip _all_ inspector test to be able catch new regressions.

* platform/qt-arm/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Add parsing for grid-auto-{row|column}
jchaffraix@webkit.org [Tue, 19 Mar 2013 23:12:28 +0000 (23:12 +0000)]
[CSS Grid Layout] Add parsing for grid-auto-{row|column}
https://bugs.webkit.org/show_bug.cgi?id=112724

Reviewed by Tony Chang.

Source/WebCore:

This change is a first step towards handling grid-auto-{row|column}.
For now, only the parsing, storing and getComputedStyle bits are implemented.
In order to do so without duplicating code, the functions handling <track-size>
(named <track-minmax> in the code based on a previous version of the grammar)
have been tweaked to be called in a standalone fashion. The code was also
updated to match the grammar more closely:
- <track-minmax> is now <track-size>.
- <track-group> was renmoved, folded into <track-list>.

Test: fast/css-grid-layout/grid-auto-columns-rows-get-set.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackSize):
Renamed from valueForGridTrackMinMax.

(WebCore::valueForGridTrackList):
Folded valueForGridTrackGroup here.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Added the parsing for grid-auto-{rows|columns}.

(WebCore::CSSParser::parseGridTrackSize):
Renamed from parseGridTrackMinMax. Changed to return the parsed value (or 0 in case of
error). This enables us to reuse it in parseValue. Note that this function now moves
the parser value list instead of the caller.

(WebCore::CSSParser::parseGridTrackList):
Updated after parseGridTrackSize changes and parseGridTrackGroup removal.

* css/CSSParser.h: Updated the names.
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
Added the 2 new non-inherited properties.

* css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
Renamed from createGridTrackMinMax. Also simplified to ensure code reuse (applyProperty hands
down a CSSValue) and consistency (the state wasn't consistently the last argument).

(WebCore::createGridTrackList):
Folded createGridTrackGroup into this function.

(WebCore::StyleResolver::applyProperty):
Added the code for the new properties.

* rendering/style/RenderStyle.h:
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
Added the storage and boiler-plate code for the new properties.

LayoutTests:

* fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-auto-columns-rows-get-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved a using declaration to avoid name conflicts
ggaren@apple.com [Tue, 19 Mar 2013 23:07:39 +0000 (23:07 +0000)]
Removed a using declaration to avoid name conflicts
https://bugs.webkit.org/show_bug.cgi?id=112752

Reviewed by Ryosuke Niwa.

* html/ClassList.cpp: Put the using declaration here instead.

* html/ClassList.h: Don't put a using declaration in this header because
it can cause name conflicts with SVGNames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake intrinsic size keywords on flexboxes work
ojan@chromium.org [Tue, 19 Mar 2013 22:37:55 +0000 (22:37 +0000)]
Make intrinsic size keywords on flexboxes work
https://bugs.webkit.org/show_bug.cgi?id=112652

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html
       fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html

* platform/Length.h:
(WebCore::Length::isSpecifiedOrIntrinsic):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Pass in the Length so that RenderFlexibleBox can call this method and avoid
doing a bunch of code duplication.

* rendering/RenderBox.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
Instead of just calling valueForLength, call computeLogicalWidthInRegionUsing so that
we properly resolve intrinsic Length types. Incidentally, this should also make viewport
percentage units work.

(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Resolve intrinsic min/max Lengths. Also, instead of calling minPreferredLogicalWidth for the
min-width: auto case, call computeMainAxisExtentForChild to correctly compute the min intrinsic size.

LayoutTests:

* fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items-expected.txt: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-flex-items-expected.txt: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html: Added.
* platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
This looks like a rounding difference. The new result matches the non-column result
in this same test, so it looks more correct to me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the Windows build.
ggaren@apple.com [Tue, 19 Mar 2013 22:30:31 +0000 (22:30 +0000)]
Try to fix the Windows build.

* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType): Qualify the
namespace to avoid conflicts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix after r146264.
rniwa@webkit.org [Tue, 19 Mar 2013 22:27:54 +0000 (22:27 +0000)]
Windows build fix after r146264.

* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Hook up scroll position to proximity detector
commit-queue@webkit.org [Tue, 19 Mar 2013 22:27:01 +0000 (22:27 +0000)]
[BlackBerry] Hook up scroll position to proximity detector
https://bugs.webkit.org/show_bug.cgi?id=112743

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.

PR 243385
Reviewed Internally By Genevieve Mak.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::adjustDocumentScrollPosition):
(WebKit):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when loading http://www.jqchart.com/jquery/gauges/RadialGauge/LiveData
msaboff@apple.com [Tue, 19 Mar 2013 22:22:06 +0000 (22:22 +0000)]
Crash when loading jqchart.com/jquery/gauges/RadialGauge/LiveData
https://bugs.webkit.org/show_bug.cgi?id=112694

Reviewed by Filip Pizlo.

We were trying to convert an NewArray to a Phantom, but convertToPhantom doesn't handle
nodes with variable arguments.  Added code to insert a Phantom node in front of all the
live children of a var args node.  Added ASSERT not var args for convertToPhantom to
catch any other similar cases.  Added a new convertToPhantomUnchecked() for converting
var arg nodes.

* dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
* dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::setOpAndDefaultNonExitFlags): Added ASSERT(!(m_flags & NodeHasVarArgs))
(JSC::DFG::Node::setOpAndDefaultNonExitFlagsUnchecked):
(JSC::DFG::Node::convertToPhantomUnchecked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r146223): chromium asserts/crashes in DocumentLoader
japhet@chromium.org [Tue, 19 Mar 2013 22:16:19 +0000 (22:16 +0000)]
REGRESSION(r146223): chromium asserts/crashes in DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112745

Reviewed by Kenneth Russell.

Fixes layout tests on chromium debug

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError): Frame might be detached, get
    defersLoading() from mainResourceLoader().
(WebCore::DocumentLoader::responseReceived): RefPtr got dropped, it's really needed.
(WebCore::DocumentLoader::receivedData): Frame might be detached, get
    defersLoading() from mainResourceLoader().
(WebCore::DocumentLoader::cancelMainResourceLoad): The ResourceError parameter
    can be null if coming from the WebKit layer, we should have a default just in case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skipping plugin snapshot tests temporarily to work out compositing issues.
dino@apple.com [Tue, 19 Mar 2013 22:03:51 +0000 (22:03 +0000)]
Unreviewed. Skipping plugin snapshot tests temporarily to work out compositing issues.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Separate WebView further from EwkView
mikhail.pozdnyakov@intel.com [Tue, 19 Mar 2013 21:55:48 +0000 (21:55 +0000)]
[EFL][WK2] Separate WebView further from EwkView
https://bugs.webkit.org/show_bug.cgi?id=111591

Reviewed by Caio Marcelo de Oliveira Filho.

Source/WebKit2:

Main points are:
- WKView API has no dependency on EFL types
- WebView class does not store the Evas_Object

* UIProcess/API/C/efl/WKView.cpp:
(WKViewCreate):

    WKView creation does not require any EFL objects to be passed.

* UIProcess/API/C/efl/WKView.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::create):

    WKViewRef is passed to EwkView constructor from outside rather than
    created inside.

(EwkView::webView):
* UIProcess/API/efl/EwkView.h:
(EwkView):
(EwkView::wkView):
(EwkView::page):

    EwkView keeps WKViewRef rather than pointer to WebView class.

* UIProcess/API/efl/ewk_view_private.h: Added.
(EWKViewCreate):
(EWKViewGetWKView):

    Added private API to create ewk view evas object and return its WKViewRef.

* UIProcess/API/efl/ewk_view.cpp:
(ewkCreateEvasObject):
(ewk_view_smart_add):
(ewk_view_add):
(ewk_view_add_with_context):
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

    Updated accordingly to the new APIs.

* UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::create):
(WebKit):
(WebKit::WebView::setEwkView):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
* UIProcess/efl/WebView.h:
(WebView):

    Implementation of updated WKView API.

Tools:

Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
since we can afford it having EWKViewGetWKView() private API to access WKView.

* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::dispatchEvent):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowSnapshotImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactored script content removal in the fragment parser for clarity and speed
ggaren@apple.com [Tue, 19 Mar 2013 21:51:48 +0000 (21:51 +0000)]
Refactored script content removal in the fragment parser for clarity and speed
https://bugs.webkit.org/show_bug.cgi?id=112734

Reviewed by Enrica Casucci.

Source/WebCore:

* WebCore.exp.in: Export!

* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseHTML):
(WebCore::DocumentFragment::parseXML):
* dom/DocumentFragment.h:
(DocumentFragment): Updated for rename of FragmentScriptingPermission to
ParserContentPolicy.

* dom/Element.cpp:
(WebCore::isEventHandlerAttribute):
(WebCore::Element::isJavaScriptURLAttribute):
(WebCore::Element::isJavaScriptAttribute): Fixed a FIXME by factoring
out some helper functions that reuse isURLAttribute(). This makes our
attribute removal slightly more precise, as reflected in test changes.

(WebCore::Element::stripJavaScriptAttributes): Factored this function out
of parserSetAttributes to clarify that the parser is responsible for
fully removing scripts before inserting anything into the DOM.

Now that this is a helper function, we can avoid doing any work in the
common case, where script content is allowed. Also, when we do have to
strip attributes, we use "two finger compaction" to avoid copying the
vector, and to avoid O(N) vector removal operations when there is
something to remove.

(WebCore::Element::parserSetAttributes):
* dom/Element.h:

* dom/FragmentScriptingPermission.h:
(WebCore::scriptingContentIsAllowed):
(WebCore::disallowScriptingContent):
(WebCore::pluginContentIsAllowed):
(WebCore::allowPluginContent): Renamed for clarity, and added some helper
functions for reading values out of this enum.

* dom/ScriptableDocumentParser.cpp:
(WebCore::ScriptableDocumentParser::ScriptableDocumentParser): Moved
a settings check into the parser constructor so we're sure that all
clients get the right behavior.

* dom/ScriptableDocumentParser.h:
(WebCore::ScriptableDocumentParser::parserContentPolicy):
(ScriptableDocumentParser):
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::createFragmentForInnerOuterHTML):
(WebCore::createContextualFragment):
* editing/markup.h: Updated for renames.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isURLAttribute): Fixed a bug where
isURLAttribute would ignore href attributes in other namespaces, like
xlink:href.

* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::isURLAttribute): Same bug.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::isURLAttribute): Fixed a logic error where HTMLElement
wouldn't call through to its base class.

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::isURLAttribute): Same isURLAttribute namespace
bug as above.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::setAttributes): Helper function for optionally stripping
disallowed attributes before setting them on an element. This helps all
clients get the right behavior without sprinkling checks everywhere.

(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):

(WebCore::HTMLConstructionSite::insertScriptElement): Don't schedule the
element for insertion into the document if the element is forbidden. This
is slightly clearer than leaving an empty forbidden element in the document.

(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
* html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::parserContentPolicy):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::parseDocumentFragment):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::create):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
Updated for renames and interface changes above.

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag): Removed isParsingFragment()
checks to make it possible to use ParserContentPolicy in more places.

Removed call to removeChildren() because, if an element is forbidden,
we fully remove the element now. This brings behavior for <script>
elements in line with behavior for plug-in elements. It also brings
behavior of the HTML parser in line with behavior of the XML parser.

* html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::create):
(FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement):
* platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
* platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::documentFragment): Updated for renames and interface
changes.

* svg/SVGAElement.cpp:
(WebCore::SVGAElement::isURLAttribute): Fixed a bug where SVG anchor
elements didn't identify their URL attributes.

* svg/SVGAElement.h:
(SVGAElement):

* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock): No need to disallow
scripting attributes here because we're creating the attributes
ourselves and we know they're not scripting attributes.

* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::parseDocumentFragment):
* xml/parser/XMLDocumentParser.h:
(WebCore::XMLDocumentParser::create):
(XMLDocumentParser): Updated for renames and interface changes above.

Removed the 8 inline capacity in the attribute vector so we could share
helper functions with the HTML parser, which didn't have it.

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::setAttributes):
(WebCore):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::setAttributes):
(WebCore):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement): Same changes as for the
HTML parser.

LayoutTests:

Updated tests to improve coverage and reflect behavior tweaks to improve
clarity.

* editing/pasteboard/paste-noscript-expected.txt:
    - The "href", "source", and "action" attributes are fully removed now,
    instead of being set to the empty string, because for clarity we
    fully remove script attributes instead of setting their values to
    the empty string.

    - The "formaction" attribute on the form control is not removed because,
    even though it seems to contain javascript content, the formaction
    attribute doesn't map to anything on a form element, and won't ever
    run as script.

    - I added a button with a "formaction" attribute, to verify that it
    does get stripped, since this is the case where the "formaction"
    attribute can run as script.

* editing/pasteboard/paste-noscript-svg-expected.txt:
    - The "xlink:href" attribute is fully removed now. See above.

* editing/pasteboard/paste-noscript-xhtml-expected.txt:
* editing/pasteboard/paste-noscript.html:
    - The "href", "source", and "action" attributes are fully removed now.
    See above.

    - The <script> element is fully removed now. See above.

    - The "formaction" attribute on the form control is not removed.
    See above.

    - I added a button with a "formaction" attribute. See above.

* editing/pasteboard/paste-visible-script-expected.txt:
    - The <script> elements are fully removed now. See above.

* editing/pasteboard/resources/paste-noscript-content.html:
    - The "formaction" attribute on the form control is not removed.
    See above.

    - I added a button with a "formaction" attribute. See above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in SpeculativeJIT::fillSpeculateIntInternal<false> on http://bellard.org/jslinux
mhahnenberg@apple.com [Tue, 19 Mar 2013 21:49:34 +0000 (21:49 +0000)]
Crash in SpeculativeJIT::fillSpeculateIntInternal<false> on bellard.org/jslinux
https://bugs.webkit.org/show_bug.cgi?id=112738

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixIntEdge): We shouldn't be killing this node because it could be
referenced by other people.

LayoutTests:

* fast/js/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Added.
* fast/js/dfg-rshift-by-zero-eliminate-valuetoint32.html: Added.
* fast/js/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Added.
(f):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up static_casts for SVG renderers
pdr@google.com [Tue, 19 Mar 2013 21:45:52 +0000 (21:45 +0000)]
Clean up static_casts for SVG renderers
https://bugs.webkit.org/show_bug.cgi?id=111651

Reviewed by Abhishek Arya.

toRenderSVGPath and toRenderSVGFilter are preferred over static_casts because bad casts can
be caught on our testing infrastructure. This patch replaces all static_casts for
RenderSVGPath and RenderSVGFilter with toRenderSVGPath and toRenderSVGFilter, respectively.

This patch also adds FIXME to the remaining toRenderSVG* instances that are missing.

No new tests as this is covered with existing tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

    This call is currently safe due to the element->hasTagName(SVGNames::clipPathTag) check.

* rendering/svg/RenderSVGPath.h:
(WebCore):
(WebCore::toRenderSVGPath):
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore):
(WebCore::toRenderSVGFilter):
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow):
(WebCore::SVGRenderSupport::rendererHasSVGShadow):
(WebCore::SVGRenderSupport::setRendererHasSVGShadow):
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):

    This cast was not correct! Thankfully it was not required anyway.

* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):

    This cast was not correct!

* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):

    This cast was not correct!

* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanges to VS2010 project files should only trigger builds on Windows bots.
roger_fong@apple.com [Tue, 19 Mar 2013 21:40:32 +0000 (21:40 +0000)]
Changes to VS2010 project files should only trigger builds on Windows bots.
https://bugs.webkit.org/show_bug.cgi?id=112731

Reviewed by Timothy Horton.

* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
bdakin@apple.com [Tue, 19 Mar 2013 21:30:59 +0000 (21:30 +0000)]
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673

Reviewed by Simon Fraser.

FrameLoaderClient::didChangeScrollOffset() should be called whenever something is
actually being scrolled.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add machinery for generating specialized bindings for the main world
commit-queue@webkit.org [Tue, 19 Mar 2013 21:17:04 +0000 (21:17 +0000)]
[V8] Add machinery for generating specialized bindings for the main world
https://bugs.webkit.org/show_bug.cgi?id=111417

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-19
Reviewed by Jochen Eisinger.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

Added an IDL attribute (V8PerWorldBindings) to define which
attribute getters / setters to specialize.

This patch generates main world bindings for getters and setters of Node
and Element. (The possibility to generate bindings for callbacks will be
added later.)

No new tests (updated existing bindings tests).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):
* bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::configureTemplate):
* bindings/v8/V8DOMConfiguration.h:
(BatchedAttribute):
(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8EventTargetCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
* dom/Element.idl:
* dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFeatureObserver: Measure X-Frame-Options usage.
mkwst@chromium.org [Tue, 19 Mar 2013 21:12:24 +0000 (21:12 +0000)]
FeatureObserver: Measure X-Frame-Options usage.
https://bugs.webkit.org/show_bug.cgi?id=112670

Reviewed by Adam Barth.

This patch adds three FeatureObserver entries to gather information
about 'X-Frame-Options' usage in general, and in particular usage
and potential misunderstanding of the 'SAMEORIGIN' value.

Three entries are added:

- XFrameOptions measures the raw number of 'X-Frame-Options' headers.

- XFrameOptionsSameOrigin measures the number of those headers that
  set the value to 'SAMEORIGIN'.

- XFrameOptionsSameOriginWithBadAncestorChain measures the number of
  occasions in which the frame passed the "top-only" origin check we're
  currently performing, but would have failed a more strict check
  against poisoned ancestor chains (that is, an ancestor chain that
  looks like 'example.com' -> 'evil.com' -> 'example.com').

Mozilla is considering changing 'SAMEORIGIN's behavior to block the
latter loophole[1], and the UI Safety spec is considering dropping
'top-only' entirely[2]. This data will inform those decisions.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=725490
[2]: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0007.html

This doesn't change web-visible behavior; it only adds histograms

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
    When processing an 'X-Frame-Options' header's value, call out to
    FeatureObserver when relevant to increment the correct histogram
    entries.
* page/FeatureObserver.h:
    Added three entries to the FeatureObserver enum: XFrameOptions,
    XFrameOptionsSameOrigin, and XFrameOptionsSameOriginWithBadAncestorChain.
    Each is explained above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments...
roger_fong@apple.com [Tue, 19 Mar 2013 21:00:28 +0000 (21:00 +0000)]
Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2013-03-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 19 Mar 2013 20:59:14 +0000 (20:59 +0000)]
2013-03-19  Oliver Hunt  <oliver@apple.com>

        RELEASE_ASSERT fires in exception handler lookup

        RS=Geoff Garen.

        Temporarily switch this RELEASE_ASSERT into a regular ASSERT
        as currently this is producing fairly bad crashiness.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::handlerForBytecodeOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDashboards: Introduce history namespace and unit tests.
jparent@chromium.org [Tue, 19 Mar 2013 20:51:44 +0000 (20:51 +0000)]
Dashboards: Introduce history namespace and unit tests.
https://bugs.webkit.org/show_bug.cgi?id=112645

Reviewed by Ojan Vafai.

Laying the framework for introducing the new history object and
namespace.  This moves only static functions into the history
namespace, and moves corresponding unit tests into seperate
unit test file.

* TestResultServer/static-dashboards/aggregate_results.html:
* TestResultServer/static-dashboards/dashboard_base.js:
(parseCrossDashboardParameters):
(parseDashboardSpecificParameters):
(parseParameters):
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(.switch.return):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/history.js: Added.
* TestResultServer/static-dashboards/history_unittests.js: Added.
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/run-embedded-unittests.html:
* TestResultServer/static-dashboards/run-unittests.html:
* TestResultServer/static-dashboards/timeline_explorer.html:
* TestResultServer/static-dashboards/timeline_explorer.js:
* TestResultServer/static-dashboards/treemap.html:
* TestResultServer/static-dashboards/treemap.js:
(.switch.return):
* TestResultServer/static-dashboards/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerateHashValue should be usable outside CodeGeneratorJS.pm
abarth@webkit.org [Tue, 19 Mar 2013 20:45:36 +0000 (20:45 +0000)]
GenerateHashValue should be usable outside CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112736

Reviewed by Benjamin Poulain.

GenerateHashValue is not specific to CodeGeneratorJS.pm. Instead, the
function matches the StringHash used in WTF. This patch moves the
function into a separate Perl module so that it can be used by other
Perl scripts. For example, I plan to use this function to compute the
hash value for HTMLNames at compile time rather than at startup.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):
* bindings/scripts/Hash.pm: Added.
(leftShift):
(GenerateHashValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Tue, 19 Mar 2013 20:35:43 +0000 (20:35 +0000)]
[WinCairo] Unreviewed build fix.

* win/tools/vsprops/FeatureDefinesCairo.vsprops: This file was out
of sync with the main Windows build, and the VS2010 version of the
WinCairo port, preventing consistent builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Flip WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
pilgrim@chromium.org [Tue, 19 Mar 2013 20:34:15 +0000 (20:34 +0000)]
[Chromium] Flip WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112726

Reviewed by Adam Barth.

Now that all embedders respect this ifdef, we can safely define it
to get everything to use the new top-level WebFileSystemType enum.

* chromium/public/WebFileSystemType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Allow PlugIn Snapshotting to be tested
dino@apple.com [Tue, 19 Mar 2013 20:30:34 +0000 (20:30 +0000)]
Source/WebCore: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696

Reviewed by Tim Horton.

Expose a new setting maximumPlugInSnapshotAttempts that can
be set by testing scripts.

Tests: plugins/snapshotting/restart.html
       plugins/snapshotting/simple.html

* page/Settings.in:

Source/WebKit2: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696

Reviewed by Tim Horton.

Use the new maximumPlugInSnapshotAttempts setting rather than a hardcoded
value. At the same time, if this value is 0, then snapshot immediately
(don't wait to get a snapshot and test it).

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): Snapshot immediately if maximum attempts are 0.
(WebKit::PluginView::pluginSnapshotTimerFired): Use setting rather than file local variable.

LayoutTests: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696
<rdar://problem/12456731>

Reviewed by Tim Horton.

Two new simple tests for plugin snapshotting. One that makes
sure the plugin was snapshotted (looks for the RenderSnapshottedPlugin)
and one that restarts a snapshotted plugin by clicking.

Since this feature is currently only enabled in WebKit2, the tests
are skipped everywhere else.

* platform/chromium/TestExpectations: Skip plugins/snapshotting.
* platform/efl/TestExpectations: Ditto.
* platform/gtk/TestExpectations: Ditto.
* platform/mac-wk2/TestExpectations: Ditto.
* platform/mac-wk2/plugins/snapshotting/restart-expected.txt: Added.
* platform/mac-wk2/plugins/snapshotting/simple-expected.txt: Added.
* platform/mac/TestExpectations: Skip plugins/snapshotting.
* platform/qt/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.
* plugins/snapshotting/restart.html: Added.
* plugins/snapshotting/simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosvn-apply has trouble applying a patch that adds a Windows newline to EOF
dbates@webkit.org [Tue, 19 Mar 2013 20:27:30 +0000 (20:27 +0000)]
svn-apply has trouble applying a patch that adds a Windows newline to EOF
https://bugs.webkit.org/show_bug.cgi?id=112732

Reviewed by Eric Seidel.

Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
of an existing file cannot be applied.

In particular, svn-{apply, unapply} compensate for differences in line endings
by converting the line endings in a diff to match the line endings in the target
file. The diff(1) command precedes the last line of a diff that adds a newline
character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
when applying this modified diff. Instead, svn-{apply, unapply} should not modify
the newline characters in this special character sequence to match the line endings
in the target file.

* Scripts/VCSUtils.pm:
(parseDiff):
* Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
Added tests:
    - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
    - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
    - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
    - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
(escapeNewLineCharacters): Added.
(toMacLineEndings): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146249 268f45cc-cd09-0410-ab3c-d52691b4dbfc