WebKit-https.git
12 years agoMake svg/batik/text/textDecoration2.svg use Lucida Grande
oliver [Sat, 13 Oct 2007 22:36:36 +0000 (22:36 +0000)]
Make svg/batik/text/textDecoration2.svg use Lucida Grande

RS=Eric.

        This test case used to use Lucida Sans which is apparently available on some
        systems, but not all.  Switching to Lucida Grande results in a slight change
        but we'll be testing with a font that everyone has.

        * svg/batik/text/textDecoration2-expected.checksum:
        * svg/batik/text/textDecoration2-expected.png:
        * svg/batik/text/textDecoration2-expected.txt:
        * svg/batik/text/textDecoration2.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing a few testcases by enabling SVG_EXPERIMENTAL on windows, and making the requir...
oliver [Sat, 13 Oct 2007 21:41:15 +0000 (21:41 +0000)]
Fixing a few testcases by enabling SVG_EXPERIMENTAL on windows, and making the required fixes and corrections.

Reviewed by Maciej

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:
        * bindings/scripts/CodeGeneratorJS.pm:
        * ksvg2/scripts/make_names.pl:
        * ksvg2/svg/SVGColor.cpp:
        (WebCore::SVGColor::colorFromRGBColorString):
        * page/DOMWindow.idl:
        * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
        * platform/win/WebCoreTextRenderer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
weinig [Sat, 13 Oct 2007 01:16:14 +0000 (01:16 +0000)]
    Reviewed by Darin.

        * platform/mac/editing/pasteboard/paste-RTFD-expected.txt: Update results to reflect current
        tree. Reopening <rdar://problem/5483567> (see below) to note the potential bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
darin [Sat, 13 Oct 2007 01:11:07 +0000 (01:11 +0000)]
    Reviewed by Oliver Hunt.

        - change test that was accidentally detecting changes in frame load delegate
          calls to run in a directory where we do not log frame load delegate calls

        At some point we may want to test them (and so re-add the test that is
        currently intermittently giving different results), but this test is about
        the DOMContentLoaded event and we want to test just that.

        * http/tests/loading/DOMContentLoaded-event-expected.txt: Removed.
        * http/tests/loading/DOMContentLoaded-event.html: Removed.
        * http/tests/misc/DOMContentLoaded-event-expected.txt: Copied from http/tests/loading/DOMContentLoaded-event-expected.txt.
        * http/tests/misc/DOMContentLoaded-event.html: Copied from http/tests/loading/DOMContentLoaded-event.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Stephanie and Oliver.
darin [Sat, 13 Oct 2007 01:03:22 +0000 (01:03 +0000)]
    Reviewed by Stephanie and Oliver.

        * platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
        Update result to reflect current behavior. This is a bug and we wrote
        a bug report in Radar, <rdar://problem/5538793>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
darin [Sat, 13 Oct 2007 00:44:04 +0000 (00:44 +0000)]
    Reviewed by Sam.

        - more float/int conversion (to try to get the old builbot up)

        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout): Cast to int.
        (WebCore::RenderSVGRoot::applyContentTransforms): Ditto.
        (WebCore::RenderSVGRoot::nodeAtPoint): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justing [Sat, 13 Oct 2007 00:40:48 +0000 (00:40 +0000)]
WebCore:

        Reviewed by Harrison.

        <rdar://problem/5483370> GoogleDocs: Deleting cell text in a table row also removes any empty rows beneath the row being edited
        <rdar://problem/5482524> GoogleDocs: A hang occurs when applying list to selected table

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::modifyRange):
        (WebCore::InsertListCommand::doApply):

LayoutTests:

        Reviewed by Harrison.

        <rdar://problem/5483370> GoogleDocs: Deleting cell text in a table row also removes any empty rows beneath the row being edited
        <rdar://problem/5482524> GoogleDocs: A hang occurs when applying list to selected table

        * editing/deleting/5483370.html: Added.
        * editing/pasteboard/5483567.html-disabled: Removed.
        * editing/execCommand/5482524.html: Added.
        * platform/mac/editing/deleting/5483370-expected.checksum: Added.
        * platform/mac/editing/deleting/5483370-expected.png: Added.
        * platform/mac/editing/deleting/5483370-expected.txt: Added.
        * platform/mac/editing/execCommand/5482524-expected.checksum: Added.
        * platform/mac/editing/execCommand/5482524-expected.png: Added.
        * platform/mac/editing/execCommand/5482524-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - fix another float/int conversion
darin [Sat, 13 Oct 2007 00:17:04 +0000 (00:17 +0000)]
    - fix another float/int conversion

        * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
        (WebCore::SVGResourceMasker::applyMask): Explicitly cast to int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
darin [Fri, 12 Oct 2007 23:41:55 +0000 (23:41 +0000)]
    Reviewed by Oliver Hunt.

        - more work toward getting layout tests passing

        * fast/images/svg-background-crash-on-refresh.html: Removed.
        * fast/images/svg-background-crash-on-refresh.html-disabled: Copied from fast/images/svg-background-crash-on-refresh.html.
        Needed to disable this test because it causes a hang; not necessarily right after
        this test, sometimes quite a few tests later.

        * platform/mac-leopard/Skipped: Re-enabled a test that's fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * fast/css/computed-style-expected.txt: Again, but right this time.
darin [Fri, 12 Oct 2007 23:41:02 +0000 (23:41 +0000)]
    * fast/css/computed-style-expected.txt: Again, but right this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
darin [Fri, 12 Oct 2007 23:03:30 +0000 (23:03 +0000)]
    Reviewed by Oliver Hunt.

        - fix float/int conversions that cause warnings on older versions
          of gcc (like the version currently being used on the PowerPC
          buildbot slave)

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint): Explicitly cast to int.
        (WebCore::RenderPath::addFocusRingRects): Use enclosingIntRect
        to convert a FloatRect to an IntRect.
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
        Use 0 for the initial value of an int, rather than 0.0f.
        (WebCore::svgTextStyleForInlineTextBox): Explicitly cast to int.
        (WebCore::applyTextAnchorToTextChunk): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
darin [Fri, 12 Oct 2007 21:19:23 +0000 (21:19 +0000)]
    Reviewed by Oliver Hunt.

        * fast/css/computed-style-expected.txt: Added SVG CSS properties.
        * fast/css/computed-style-without-renderer-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrect date in merge markers
oliver [Fri, 12 Oct 2007 20:54:15 +0000 (20:54 +0000)]
Correct date in merge markers

RS=Darin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCast zoom factor to int as the original patch did. This is necessary to appease...
oliver [Fri, 12 Oct 2007 20:40:05 +0000 (20:40 +0000)]
Cast zoom factor to int as the original patch did.  This is necessary to appease some versions of gcc.

Reviewed by Mark.

        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-12 Eric Seidel <eric@webkit.org>
eseidel [Fri, 12 Oct 2007 20:13:26 +0000 (20:13 +0000)]
2007-10-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        Fix leaks in SVG code from feature-branch.

        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::filterEffect):
        * ksvg2/svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::filterEffect):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::filterEffect):
        * ksvg2/svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::buildStops):
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::resolveStyle): always refs style
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::create): fastFree buffer if CG Context creation fails

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore Layout test tidying
oliver [Fri, 12 Oct 2007 18:58:47 +0000 (18:58 +0000)]
More Layout test tidying

RS=Alexey

Move dom/xhtml/level2/html/HTMLBaseElement0[12].xhtml expected output
to cross platform directory, remove unnecessary pixel results.

        * dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Added.
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt: Removed.
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrect expected output of a few test cases
oliver [Fri, 12 Oct 2007 18:35:44 +0000 (18:35 +0000)]
Correct expected output of a few test cases

RS=Eric

        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
        * platform/mac/dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
        * platform/mac/fast/dom/dom-parse-serialize-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-12 Mark Rowe <mrowe@apple.com>
bdash [Fri, 12 Oct 2007 17:32:14 +0000 (17:32 +0000)]
2007-10-12  Mark Rowe  <mrowe@apple.com>

        Windows, Gtk and Qt build fixes.  Add new files to projects.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd merge markers
oliver [Fri, 12 Oct 2007 15:41:23 +0000 (15:41 +0000)]
Add merge markers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Bug 15469: feature branch has 100's of implicit double -> float conversions
oliver [Fri, 12 Oct 2007 15:41:08 +0000 (15:41 +0000)]
Fix Bug 15469: feature branch has 100's of implicit double -> float conversions

        Reviewed by Sam.

        Re-enable -Wshorten-64-to-32, and make required code changes to make us build sanely again.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/css/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::cssPrimitiveToLength):
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        (WebCore::SVGAnimateMotionElement::updateAnimatedValue):
        (WebCore::parsePoint):
        (WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::parseKeyNumbers):
        (WebCore::parseKeySplines):
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
        (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
        * ksvg2/svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::SVGFECompositeElement):
        (WebCore::SVGFECompositeElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
        (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
        (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
        (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
        * ksvg2/svg/SVGFELightElement.cpp:
        (WebCore::SVGFELightElement::SVGFELightElement):
        (WebCore::SVGFELightElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
        (WebCore::SVGFEOffsetElement::parseMappedAttribute):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
        (WebCore::SVGFESpecularLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
        (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
        * ksvg2/svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::parseMappedAttribute):
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGLength.cpp:
        (WebCore::SVGLength::setValueAsString):
        (WebCore::SVGLength::PercentageOfViewport):
        * ksvg2/svg/SVGNumber.idl:
        * ksvg2/svg/SVGNumberList.cpp:
        (WebCore::SVGNumberList::parse):
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGParserUtilities.cpp:
        (WebCore::_parseNumber):
        (WebCore::parseNumber):
        (WebCore::pointsListFromSVGData):
        (WebCore::PathBuilder::svgMoveTo):
        (WebCore::PathBuilder::svgLineTo):
        (WebCore::PathBuilder::svgCurveToCubic):
        (WebCore::SVGPathSegListBuilder::svgMoveTo):
        (WebCore::SVGPathSegListBuilder::svgLineTo):
        (WebCore::SVGPathSegListBuilder::svgLineToHorizontal):
        (WebCore::SVGPathSegListBuilder::svgLineToVertical):
        (WebCore::SVGPathSegListBuilder::svgCurveToCubic):
        (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth):
        (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic):
        (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth):
        (WebCore::SVGPathSegListBuilder::svgArcTo):
        * ksvg2/svg/SVGParserUtilities.h:
        * ksvg2/svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::SVGPathElement):
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
        (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGTransformDistance.cpp:
        (WebCore::SVGTransformDistance::addToSVGTransform):
        (WebCore::SVGTransformDistance::distance):
        * ksvg2/svg/SVGTransformDistance.h:
        * ksvg2/svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::parseTransformValue):
        * ksvg2/svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::parseViewSpec):
        * platform/graphics/svg/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
        * platform/graphics/svg/cg/CgSupport.cpp:
        (WebCore::applyStrokeStyleToContext):
        * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
        (WebCore::SVGPaintServerPattern::setup):
        * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
        (WebCore::SVGResourceFilter::applyFilter):
        * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
        (WebCore::SVGComponentTransferFunction::SVGComponentTransferFunction):
        * platform/graphics/svg/filters/SVGFEComposite.cpp:
        (WebCore::SVGFEComposite::SVGFEComposite):
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
        (WebCore::SVGFEConvolveMatrix::SVGFEConvolveMatrix):
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
        (WebCore::SVGFEDiffuseLighting::SVGFEDiffuseLighting):
        * platform/graphics/svg/filters/SVGFEFlood.cpp:
        (WebCore::SVGFEFlood::SVGFEFlood):
        * platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
        (WebCore::SVGFEGaussianBlur::SVGFEGaussianBlur):
        * platform/graphics/svg/filters/SVGFEMorphology.cpp:
        (WebCore::SVGFEMorphology::SVGFEMorphology):
        * platform/graphics/svg/filters/SVGFEOffset.cpp:
        (WebCore::SVGFEOffset::SVGFEOffset):
        * platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
        (WebCore::SVGFESpecularLighting::SVGFESpecularLighting):
        * platform/graphics/svg/filters/SVGFETurbulence.cpp:
        (WebCore::SVGFETurbulence::SVGFETurbulence):
        * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
        (WebCore::SVGFEColorMatrix::getCIFilter):
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
        (WebCore::getVectorForChannel):
        (WebCore::getLightVectors):
        * platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
        (WebCore::SVGFEImage::getCIFilter):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::drawMarkersIfNeeded):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::calcViewport):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::relativeBBox):
        * rendering/RenderSVGTextPath.cpp:
        * rendering/SVGCharacterLayoutInfo.cpp:
        (WebCore::calculateBaselineShift):
        (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
        (WebCore::SVGCharacterLayoutInfo::processedChunk):
        (WebCore::SVGCharacterLayoutInfo::nextPathLayoutPointAndAngle):
        (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
        * rendering/SVGCharacterLayoutInfo.h:
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
        (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
        (WebCore::pathForDecoration):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
        (WebCore::applyTextAnchorToTextChunk):
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
oliver [Fri, 12 Oct 2007 15:40:54 +0000 (15:40 +0000)]
JavaScriptCore:

        Reviewed by Eric Seidel.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15076
        "deg2rad has multiple definitions"

        Define deg2rad, rad2deg, deg2grad, grad2deg, rad2grad, grad2rad
        These are used through WebKit.

        Change based on original patch by Rob Buis.

        * wtf/MathExtras.h:
        (deg2rad):
        (rad2deg):
        (deg2grad):
        (grad2deg):
        (rad2grad):
        (grad2rad):

WebCore:

        Reviewed by Eric Seidel.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15076
        "deg2rad has multiple definitions"

        Use deg2rad, rad2deg, deg2grad, grad2deg, rad2grad, grad2rad
        from wtf where appropriate.

        No test cases as this doesn't change behaviour.

        Change based on original patch by Rob Buis.

        * ksvg2/svg/SVGAngle.cpp:
        (WebCore::SVGAngle::calculate):
        (WebCore::SVGAngle::convertToSpecifiedUnits):
        (WebCore::SVGAngle::todeg):
        (WebCore::SVGAngle::torad):
        * platform/graphics/AffineTransform.cpp:
        (WebCore::AffineTransform::rotateFromVector):
        (WebCore::AffineTransform::skewX):
        (WebCore::AffineTransform::skewY):
        * platform/graphics/cg/AffineTransformCG.cpp:
        (WebCore::AffineTransform::rotate):
        * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
        * rendering/RenderPath.cpp:
        (WebCore::drawMarkerWithData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Oliver.
oliver [Fri, 12 Oct 2007 15:40:39 +0000 (15:40 +0000)]
Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=6421 (<text> textLength attribute is not respected)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=6422 (<text> lengthAdjust attribute is not respected)

Implement textLength and full lengthAdjust (both 'spacing' & 'spacingAndGlyphs' mode)
for <text> & <tspan> & friends. <textPath> is still todo, as it's special.

Also fix usage of cummulatedGlyphWidth/Height in SVGInlineTextBox, calculateGlyphBoundaries was
supposed to be used in the distance calculations, to take per character transformations into account (ie. rotation).

Fixes: svg/W3C-SVG-1.1/text-text-01-b.svg (complelty fixed the single W3C textLength testcase)
Partly fixed: svg/batik/text/textOnPathSpaces.svg (kerning support missing)
Partly fixed: svg/batik/text/textLayout.svg (word-letter spacing & textLength is todo)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for Bug 15468: Parsing of numbers and lists is too lenient in SVG
oliver [Fri, 12 Oct 2007 15:40:24 +0000 (15:40 +0000)]
Fix for Bug 15468: Parsing of numbers and lists is too lenient in SVG

Reviewed by Niko.

Correct parsing of numbers, number lists, and length lists in SVG.

        * ksvg2/svg/SVGLength.cpp:
        (WebCore::SVGLength::setValueAsString):
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGLengthList.cpp:
        (WebCore::SVGLengthList::parse):
        * ksvg2/svg/SVGParserUtilities.cpp:
        (WebCore::parseNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-11 Allan Sandfeld Jensen <sandfeld@kde.org>
oliver [Fri, 12 Oct 2007 15:40:08 +0000 (15:40 +0000)]
2007-10-11  Allan Sandfeld Jensen  <sandfeld@kde.org>

         Reviewed by Maciej and Eric.

         Implement CSS selector combinators nondeterministic matching.
         Fixes http://bugs.webkit.org/show_bug.cgi?id=3428

         * css/CSSStyleSelector.cpp:
         (WebCore::CSSStyleSelector::matchRulesForList):
         (WebCore::CSSStyleSelector::checkSelector): Split the function and make the second part recursive
         (WebCore::CSSStyleSelector::checkOneSelector): Handle pseodo-elements rules and hoveractive quirks
         here instead of in checkSelector.
         * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-10 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:39:51 +0000 (15:39 +0000)]
2007-10-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Fix the SVG dom so that rect.x.baseVal = rect.x.baseVal like it should.
        http://bugs.webkit.org/show_bug.cgi?id=14150

        Test: svg/dom/animated-tearoff-equlity.xhtml

        * ksvg2/svg/SVGAnimatedTemplate.h:
        (WebCore::SVGAnimatedTypeWrapperKey::SVGAnimatedTypeWrapperKey):
        (WebCore::SVGAnimatedTypeWrapperKey::operator==):
        (WebCore::SVGAnimatedTypeWrapperKeyHash::hash):
        (WebCore::SVGAnimatedTypeWrapperKeyHash::equal):
        (WebCore::SVGAnimatedTypeWrapperKeyHashTraits::deletedValue):
        (WebCore::SVGAnimatedTypeWrapperKeyHashTraits::emptyValue):
        (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
        (WebCore::SVGAnimatedTemplate::wrapperCache):
        (WebCore::SVGAnimatedTemplate::forgetWrapper):
        (WebCore::lookupOrCreateWrapper):
        * ksvg2/svg/SVGElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrecting expected output of svg/batik/text/textOnPathSpaces
oliver [Fri, 12 Oct 2007 15:39:33 +0000 (15:39 +0000)]
Correcting expected output of svg/batik/text/textOnPathSpaces

RS = Eric.

* svg/batik/text/textOnPathSpaces-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLeopard build fix -- SVGDocument should not trty to make read/write properties read...
oliver [Fri, 12 Oct 2007 15:39:15 +0000 (15:39 +0000)]
Leopard build fix -- SVGDocument should not trty to make read/write properties read-only

        Reviewed by Maciej.

        Remove those API definitions SVGDocument now inherits from Document

        * ksvg2/svg/SVGDocument.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
oliver [Fri, 12 Oct 2007 15:38:55 +0000 (15:38 +0000)]
    Reviewed by Eric.

        - fix assertion failures on quit.

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): Dynamically alocate function-scope static
        UStrings to avoid the static destructor getting called later.
        * kjs/lookup.h: Dynamically alocate function-scope static
        Identifiers to avoid the static destructor getting called later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-10 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:38:34 +0000 (15:38 +0000)]
2007-10-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Make renderers pull localTransform instead of depending on DOM elements to push
        This allows for cleaner invalidation code, and makes writing animation easier.
        Also fixed a tiny bug in SVGRenderImage focus ring calculations while there

        Updated test results for svg/custom/focus-ring.svg

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::createRenderer):
        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement):
        * ksvg2/svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::canvasResource):
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGGElement.cpp:
        (WebCore::SVGGElement::createRenderer):
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::getCTM):
        (WebCore::SVGLocatable::getScreenCTM):
        * ksvg2/svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        (WebCore::SVGMarkerElement::notifyAttributeChange):
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::rendererIsNeeded):
        (WebCore::SVGStyledElement::notifyResourceParentIfExistant):
        * ksvg2/svg/SVGStyledElement.h:
        (WebCore::SVGStyledElement::style):
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
        (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
        (WebCore::SVGStyledTransformableElement::notifyAttributeChange):
        (WebCore::SVGStyledTransformableElement::createRenderer):
        * ksvg2/svg/SVGStyledTransformableElement.h:
        (WebCore::SVGStyledTransformableElement::toPathData):
        * ksvg2/svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::createRenderer):
        * ksvg2/svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::updateReferencedText):
        * ksvg2/svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::parseMappedAttribute):
        (WebCore::SVGTextElement::animatedLocalTransform):
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPathElement.cpp:
        * ksvg2/svg/SVGTextPathElement.h:
        * ksvg2/svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::getCTM):
        (WebCore::SVGTransformable::getScreenCTM):
        * ksvg2/svg/SVGTransformable.h:
        * ksvg2/svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::createRenderer):
        (WebCore::SVGUseElement::attachShadowTree):
        * platform/graphics/AffineTransform.h:
        (WebCore::AffineTransform::operator!=):
        * platform/graphics/svg/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::setMarker):
        * platform/graphics/svg/SVGResourceMarker.h:
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::calculateLocalTransform):
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderForeignObject.h:
        (WebCore::RenderForeignObject::localTransform):
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath):
        (WebCore::RenderPath::localTransform):
        (WebCore::RenderPath::calculateLocalTransform):
        (WebCore::RenderPath::layout):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::localTransform):
        (WebCore::RenderSVGContainer::calculateLocalTransform):
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::localTransform):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::calculateLocalTransform):
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSVGText.h:
        (WebCore::RenderSVGText::isSVGText):
        (WebCore::RenderSVGText::localTransform):
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath):
        (WebCore::RenderSVGTextPath::startOffset):
        (WebCore::RenderSVGTextPath::exactAlignment):
        (WebCore::RenderSVGTextPath::stretchMethod):
        * rendering/RenderSVGTextPath.h:
        * rendering/RenderSVGTransformableContainer.cpp: Added.
        (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
        * rendering/RenderSVGTransformableContainer.h: Added.
        * rendering/RenderSVGViewportContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 15451: SVGStyledElement must unregister itself from Resources on detach
oliver [Fri, 12 Oct 2007 15:38:12 +0000 (15:38 +0000)]
Bug 15451: SVGStyledElement must unregister itself from Resources on detach

Reviewed by Eric.

Use a global hashtable to maintain the relationship between the
various SVG resources and their clients, across dom updates, etc.

        * ChangeLog:
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::detach):
        * ksvg2/svg/SVGStyledElement.h:
        * platform/graphics/svg/SVGPaintServer.h:
        * platform/graphics/svg/SVGResource.cpp:
        (WebCore::ResourceSet::ResourceSet):
        (WebCore::clientMap):
        (WebCore::SVGResource::~SVGResource):
        (WebCore::SVGResource::invalidate):
        (WebCore::SVGResource::removeClient):
        (WebCore::SVGResource::addClient):
        * platform/graphics/svg/SVGResource.h:
        (WebCore::):
        (WebCore::SVGResource::isPaintServer):
        (WebCore::SVGResource::isFilter):
        (WebCore::SVGResource::isClipper):
        (WebCore::SVGResource::isMarker):
        (WebCore::SVGResource::isMasker):
        * platform/graphics/svg/SVGResourceClipper.h:
        (WebCore::SVGResourceClipper::resourceType):
        * platform/graphics/svg/SVGResourceFilter.h:
        * platform/graphics/svg/SVGResourceMarker.h:
        * platform/graphics/svg/SVGResourceMasker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-10 Mark Rowe <mrowe@apple.com>
oliver [Fri, 12 Oct 2007 15:37:49 +0000 (15:37 +0000)]
2007-10-10  Mark Rowe  <mrowe@apple.com>

        Windows build fix after r26109.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Bug 15433: Filters do not repaint when base resources change/update
oliver [Fri, 12 Oct 2007 15:37:27 +0000 (15:37 +0000)]
Fix Bug 15433: Filters do not repaint when base resources change/update

        Reviewed by Eric.

        SVGFEImage now actually responds to image updates, and triggers a repaint.

        * platform/graphics/svg/SVGResource.h:
        * platform/graphics/svg/filters/SVGFEImage.cpp:
        (WebCore::SVGFEImage::setCachedImage):
          Don't re-set the image lest we want to trigger infinite recursion.
        (WebCore::SVGFEImage::imageChanged):
          Image change means we need to tell our clients to repaint
        * platform/graphics/svg/filters/SVGFEImage.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::prepareToRenderSVGContent):
          make sure that users of filters are registered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-09 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:37:03 +0000 (15:37 +0000)]
2007-10-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Alp.

        Track changes in r26109 to fix the Gtk+ build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders.
oliver [Fri, 12 Oct 2007 15:36:39 +0000 (15:36 +0000)]
    Reviewed by Anders.

        http://bugs.webkit.org/show_bug.cgi?id=15436
        Wrong node order for XPath reverse axes

        Test: fast/xpath/reverse-axes.html

        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Do not prematurely sort reverse
        axes. Generate preceding axis nodes in reversed document order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mitz.
oliver [Fri, 12 Oct 2007 15:36:14 +0000 (15:36 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=15437
        XPath substring-after function is broken

        Test: fast/xpath/substring-after.html

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunSubstringAfter::evaluate): Fix it for real this time, hopefully.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed.
oliver [Fri, 12 Oct 2007 15:35:34 +0000 (15:35 +0000)]
Not reviewed.

Regenerated the SVG test baseline, they have been generated with _trunk_ instead of feature-branch.
Not sure who committed it, but it's wrong - so I'm fixing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
oliver [Fri, 12 Oct 2007 15:34:58 +0000 (15:34 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=15080
        <use> element not refresh after adding objects by script in referrer

        Update shadow tree when elements are added/removed from a tree
        that is referenced by a <use>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
oliver [Fri, 12 Oct 2007 15:34:25 +0000 (15:34 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=15088
        HTMLOptionElement.selected returns false when parent HTMLSelectElement is "display: none" until parent's .selectedIndex is accessed

        Make sure the list items are up to date when there is no renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHackTop [26957:WebKitTools]% less ChangeLog [/Stuff/Project...
oliver [Fri, 12 Oct 2007 15:33:50 +0000 (15:33 +0000)]
HackTop [26957:WebKitTools]% less ChangeLog                           [/Stuff/Projects/WebKit/WebKitTools]
2007-10-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        * Scripts/build-webkit: add --help, remove unused --color

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-08 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:33:16 +0000 (15:33 +0000)]
2007-10-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Build fix.  Fix circular build rule for CSS*.in files evident on clean build.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/css/CSSPropertyNames.in: Removed.
        * ksvg2/css/CSSValueKeywords.in: Removed.
        * ksvg2/css/SVGCSSPropertyNames.in: Copied from ksvg2/css/CSSPropertyNames.in.
        * ksvg2/css/SVGCSSValueKeywords.in: Copied from ksvg2/css/CSSValueKeywords.in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-08 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:32:39 +0000 (15:32 +0000)]
2007-10-08  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        Implement getComputedStyle support for SVG CSS values
        http://bugs.webkit.org/show_bug.cgi?id=15422

        This also unifies SVG and non-SVG CSS hash lookups. A unified hash
        solves correctness problems as well as offers improved speed.

        Test: svg/css/getComputedStyle-basic.xhtml

        * DerivedSources.make: unify SVG and non-SVG CSS hash files
        * WebCore.xcodeproj/project.pbxproj: remove old SVG CSS hash files
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): call getPropertyCSSValue
        * css/CSSComputedStyleDeclaration.h: add getPropertyCSSValue
        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSStyleDeclaration.cpp:
        (WebCore::propertyID):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * ksvg2/css/CSSPropertyNames.in: remove font-size-adjust
        * ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: Added.
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): added.
        * ksvg2/css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * ksvg2/scripts/cssmakeprops: Removed.
        * ksvg2/scripts/cssmakevalues: Removed.
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::mapAttributeToCSSProperty):
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): remove font-size-adjust

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
oliver [Fri, 12 Oct 2007 15:32:01 +0000 (15:32 +0000)]
WebCore:

        Reviewed by Steve Falkenburg;

        Fix for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9

        Test: fast/innerHTML/innerHTML-script-tag-crash.xhtml

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::lineNumber): Return 1 when there is no context.
        (WebCore::XMLTokenizer::columnNumber): ditto.

LayoutTests:

        Reviewed by Steve Falkenburg.

        Test for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9

        * fast/innerHTML/innerHTML-script-tag-crash-expected.txt: Added.
        * fast/innerHTML/innerHTML-script-tag-crash.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/mac/FontPlatformDataMac.mm:
oliver [Fri, 12 Oct 2007 15:31:23 +0000 (15:31 +0000)]
    * platform/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::setFont): Restored one of the -1 checks removed in
        the previous change - we do need to check m_font!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-07 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:30:43 +0000 (15:30 +0000)]
2007-10-07  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        * Drosera/mac/DebuggerDocumentPlatform.mm:
        (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
oliver [Fri, 12 Oct 2007 15:30:04 +0000 (15:30 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=15397
        Layout tests freeze in HashTable::lookup

        Fixes a DRT freeze on PowerPC.

        * platform/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::FontPlatformData): Don't ask for a size of a nil font,
        the result is undefined.
        (WebCore::FontPlatformData::setFont): Ditto. Also removed some checks for -1 that
        were not sufficient, and thus likely unnecessary,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed.
oliver [Fri, 12 Oct 2007 15:29:24 +0000 (15:29 +0000)]
Not reviewed.
Forgot to land some result test changes in my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric.
oliver [Fri, 12 Oct 2007 15:28:41 +0000 (15:28 +0000)]
Reviewed by Eric.

Fix some issues with rotation & baseline-shift, when spanning
across <tspan> elements. Highlighted by the existing batik tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-07 Mark Rowe <mrowe@apple.com>
oliver [Fri, 12 Oct 2007 15:27:57 +0000 (15:27 +0000)]
2007-10-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
        http://bugs.webkit.org/show_bug.cgi?id=5122

        This is based on a patch by Daniel Peebles (pumpkingod@gmail.com).

        Test: http/tests/loading/DOMContentLoaded-event.html

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing): Dispatch the DOMContentLoaded event when parsing completes.
        * dom/EventNames.h:  Add DOMContentLoaded to the list of events.

2007-10-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Test for Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
        http://bugs.webkit.org/show_bug.cgi?id=5122

        * http/tests/loading/DOMContentLoaded-event-expected.txt: Added.
        * http/tests/loading/DOMContentLoaded-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark.
oliver [Fri, 12 Oct 2007 15:27:13 +0000 (15:27 +0000)]
Reviewed by Mark.
Fix textLength.svg testcase - missed xmlns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-07 Ed Schouten <ed@fxq.nl>
oliver [Fri, 12 Oct 2007 15:26:27 +0000 (15:26 +0000)]
2007-10-07  Ed Schouten  <ed@fxq.nl>

        Reviewed and landed by Alexey Proskuryakov.

        Add PLATFORM(FREEBSD), so we can fix the build on FreeBSD-like
        systems by including <pthread_np.h>. Also fix some (disabled)
        regcomp()/regexec() code; it seems some variable names have
        changed.

        * kjs/config.h:
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoForgot to commit this with r25958.
oliver [Fri, 12 Oct 2007 15:25:42 +0000 (15:25 +0000)]
Forgot to commit this with r25958.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Seidel.
oliver [Fri, 12 Oct 2007 15:24:56 +0000 (15:24 +0000)]
    Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=15368
        xsl:import fails when preceded by comment

        Test: fast/xsl/import-after-comment.xml

        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::loadChildSheets): It's OK for xsl:import to be preceded by
        non-element nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-07 Vincent Ricard <magic@magicninja.org>
oliver [Fri, 12 Oct 2007 15:24:07 +0000 (15:24 +0000)]
2007-10-07  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Maciej.  Landed by eseidel.

        http://bugs.webkit.org/show_bug.cgi?id=15062
        Implement document.compatMode

        Tests: fast/dom/compatMode-AlmostStrict.html
               fast/dom/compatMode-Compat.html
               fast/dom/compatMode-Strict.html

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::compatMode):
        * html/HTMLDocument.h:
        * html/HTMLDocument.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-07 Sam Weinig <sam@webkit.org>
oliver [Fri, 12 Oct 2007 15:23:17 +0000 (15:23 +0000)]
2007-10-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin & Nikolas.  Landed by eseidel.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14455
        Autogenerate the JS bindings for the StyleSheetList

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSStyleSheetListCustom.cpp: Added.
        (WebCore::JSStyleSheetList::canGetItemsForName):
        (WebCore::JSStyleSheetList::nameGetter):
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::StyleSheetList):
        (WebCore::StyleSheetList::documentDestroyed):
        (WebCore::StyleSheetList::getNamedItem):
        * css/StyleSheetList.h: Add Document member variable and
        getNamedItem function to accommodate the odd javascript
        name getter functionality.
        * css/StyleSheetList.idl:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        * page/DOMWindow.idl: Add StyleSheetListConstructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-07 Lars Naesbye Christensen <lars@naesbye.dk>
oliver [Fri, 12 Oct 2007 15:22:26 +0000 (15:22 +0000)]
2007-10-07  Lars Naesbye Christensen  <lars@naesbye.dk>

        Reviewed by Eric Seidel.

        make CSS cell cursor more mac-like
        http://bugs.webkit.org/show_bug.cgi?id=15325

        * Resources/cellCursor.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-06 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:21:35 +0000 (15:21 +0000)]
2007-10-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        SVG does not correctly handle onfocusin, onfocusout or onactivate
        http://bugs.webkit.org/show_bug.cgi?id=12573

        Test: svg/W3C-SVG-1.1/script-handle-02-b.svg

        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::parseMappedAttribute):
        * ksvg2/svg/svgattrs.in: add onfocusin, onfocusout and onactivate

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Oliver.
oliver [Fri, 12 Oct 2007 15:20:42 +0000 (15:20 +0000)]
Reviewed by Oliver.
Never pass null input images to CICrop filter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark.
oliver [Fri, 12 Oct 2007 15:19:49 +0000 (15:19 +0000)]
Reviewed by Mark.

Remove useless onload/onunload handlers from js-update-container.svg,
causing a console message saying these handlers don't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Oliver.
oliver [Fri, 12 Oct 2007 15:18:39 +0000 (15:18 +0000)]
Rubberstamped by Oliver.
Update SVG baseline with Tiger. No regressions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-06 Mark Rowe <mrowe@apple.com>
oliver [Fri, 12 Oct 2007 15:17:32 +0000 (15:17 +0000)]
2007-10-06  Mark Rowe  <mrowe@apple.com>

Reviewed by Alp Toker.

Gtk+ build fix and minor code cleanup.

* WebCore.pro:
        * platform/gtk/FontCacheGtk.cpp:
        (WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::fontExists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mitz.
oliver [Fri, 12 Oct 2007 15:16:31 +0000 (15:16 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=15380
        XPath: id('foo') doesn't resolve correctly

        Test: fast/xpath/id-simple.html

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunId::evaluate): Fixed a logic error in id() parameter parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoving a conflict marker.
oliver [Fri, 12 Oct 2007 15:15:28 +0000 (15:15 +0000)]
Removing a conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * fast/dom/xmlhttprequest-get-expected.txt: Updated event properties
oliver [Fri, 12 Oct 2007 15:14:25 +0000 (15:14 +0000)]
    * fast/dom/xmlhttprequest-get-expected.txt: Updated event properties
        for changes made in bug 15102.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
oliver [Fri, 12 Oct 2007 15:13:16 +0000 (15:13 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13707
        REGRESSION: JavaScript exceptions on quotes.burntelectrons.org

        http://bugs.webkit.org/show_bug.cgi?id=12628
        document.body is not supported in XHTML documents

        http://bugs.webkit.org/show_bug.cgi?id=14213
        On page with MIME type application/xhtml+xml, cookie don't work

WebCore:
        Moved a bunch of methods and properties from HTMLDocument down into Document to make
        them available for all documents (xml, svg).
        What was kept in HTMLDocument:
        - some methods and properties that are not in HTML5 (yet?);
        - open/write/writeln/close, as they will need to be modified to work on XML documents, and aren't
        of much use for those anyway;
        - designMode, because its definition in HTML5 is incompatible with our implementation.

        Covered by existing tests.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::JSDocument::setLocation):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        * bindings/objc/PublicDOMInterfaces.h:
        * dom/Document.cpp:
        (WebCore::Document::setBody):
        (WebCore::Document::cookie):
        (WebCore::Document::setCookie):
        (WebCore::Document::lastModified):
        * dom/Document.h:
        (WebCore::Document::title):
        * dom/Document.idl:
        * html/HTMLDocument.cpp:
        * html/HTMLDocument.h:
        * html/HTMLDocument.idl:

LayoutTests:
        * dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
        * dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
        * dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
        * dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
        * dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
        * dom/xhtml/level2/html/HTMLBodyElement07-expected.txt:
        * dom/xhtml/level2/html/HTMLBodyElement08-expected.txt:
        * dom/xhtml/level2/html/HTMLBodyElement09-expected.txt:
        * dom/xhtml/level2/html/HTMLBodyElement10-expected.txt:
        * dom/xhtml/level2/html/HTMLBodyElement11-expected.txt:
        * dom/xhtml/level2/html/HTMLBodyElement12-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument01-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument02-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument03-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument05-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument07-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument08-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument09-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument10-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument11-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument12-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument13-expected.txt:
        * dom/xhtml/level2/html/HTMLDocument14-expected.txt:
        * dom/xhtml/level2/html/doc01-expected.txt:
        These now pass. Changed HTMLBaseElement* to dump as text.

        * fast/dom/Window/window-properties-expected.txt: Added Document.prototype.getElementsByName

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-06 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:12:08 +0000 (15:12 +0000)]
2007-10-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver Hunt.

        RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)
        http://bugs.webkit.org/show_bug.cgi?id=15388
        This makes the Sun Lively Kernel invalidate only what it should!

        No tests possible in DRT.

        * ksvg2/svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::notifyAttributeChange): replace call to rebuildRenderer
        * ksvg2/svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::notifyAttributeChange): replace call to rebuildRenderer
        * ksvg2/svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::notifyAttributeChange): replace call to rebuildRenderer
        (WebCore::SVGImageElement::hasRelativeValues): implemented
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::notifyAttributeChange): replace call to rebuildRenderer
        * ksvg2/svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::notifyAttributeChange): replace call to rebuildRenderer
        * ksvg2/svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::notifyAttributeChange): replace call to rebuildRenderer
        * ksvg2/svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::notifyAttributeChange): replace call to rebuildRenderer
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGStyledElement.h:
        (WebCore::SVGStyledElement::hasRelativeValues): default to true instead
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::updateLocalTransform): don't layout if no change
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGTransform.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout):
        (WebCore::RenderSVGContainer::selfWillPaint): return true if have a filter
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::layout):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::layout):
        (WebCore::RenderSVGViewportContainer::calcViewport): use floats

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
oliver [Fri, 12 Oct 2007 15:11:01 +0000 (15:11 +0000)]
    Reviewed by Eric.

        Use document() instead of ownerDocument() and a few other cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-05 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:09:53 +0000 (15:09 +0000)]
2007-10-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver Hunt.

        SVG invalidates way too much during layout()
        http://bugs.webkit.org/show_bug.cgi?id=14003

        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::ownerSVGElement): simplify if
        (WebCore::SVGElement::viewportElement): simplify if
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout): only layout children if parent changed
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout): only layout children when size changes
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout): hack to avoid bad RenderBlock::layout code
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::layout): don't use RenderSVGContainer::layout()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago30%+ performance improvement for svg embedded in xhtml
oliver [Fri, 12 Oct 2007 15:08:44 +0000 (15:08 +0000)]
30%+ performance improvement for svg embedded in xhtml

Reviewed by Eric.

Relayout internal to SVG was incorrectly being propagated to
the containing xhtml element, which subsequently resulted in
a full paint of the SVG, rather than just the dirty regions.

* rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-03 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 15:07:33 +0000 (15:07 +0000)]
2007-10-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12310
        Remove static variables from removeAllChildren causing crash.
        removeAllChildren now iterates over the entire tree instead of recursing.
        Also (according to Maciej) a possible 1-2% speedboost on HTML iBench.

        Test: fast/images/svg-background-crash-on-refresh.html

        * WebCore.xcodeproj/project.pbxproj:
        * dom/ContainerNode.cpp:
        (WebCore::addChildNodesToDeletionQueue):
        (WebCore::ContainerNode::removeAllChildren): use new addChildNodesToDeletionQueue

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows build bustage once and for all. Feature branch builds on Windows now.
oliver [Fri, 12 Oct 2007 15:06:22 +0000 (15:06 +0000)]
Fix Windows build bustage once and for all.  Feature branch builds on Windows now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows build bustage once and for all. Feature branch builds on Windows now.
oliver [Fri, 12 Oct 2007 15:05:10 +0000 (15:05 +0000)]
Fix Windows build bustage once and for all.  Feature branch builds on Windows now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
oliver [Fri, 12 Oct 2007 15:04:00 +0000 (15:04 +0000)]
    Reviewed by Mark Rowe.

        Mac build fix for issue introduced in r26027

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows build bustage. Make sure the font update method is called with the corre...
oliver [Fri, 12 Oct 2007 15:02:48 +0000 (15:02 +0000)]
Fix Windows build bustage.  Make sure the font update method is called with the correct # of arguments when used in Windows WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows build bustage. Make sure the font update method is called with the corre...
oliver [Fri, 12 Oct 2007 15:01:35 +0000 (15:01 +0000)]
Fix Windows build bustage.  Make sure the font update method is called with the correct # of arguments when used in Windows WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix more SVG build bustage on Windows. Remove a deleted file from the project. ...
oliver [Fri, 12 Oct 2007 15:00:23 +0000 (15:00 +0000)]
Fix more SVG build bustage on Windows.  Remove a deleted file from the project.  Remove a const from an unimplemented mask method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix UChar ambiguity in SVG code that keeps Windows from compiling the feature branch.
oliver [Fri, 12 Oct 2007 14:59:10 +0000 (14:59 +0000)]
Fix UChar ambiguity in SVG code that keeps Windows from compiling the feature branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix windows build bustage on feature branch.
oliver [Fri, 12 Oct 2007 14:57:55 +0000 (14:57 +0000)]
Fix windows build bustage on feature branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix windows build bustage on feature branch.
oliver [Fri, 12 Oct 2007 14:56:42 +0000 (14:56 +0000)]
Fix windows build bustage on feature branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Land support for the CSS @font-face rule. This patch allows custom fonts
oliver [Fri, 12 Oct 2007 14:55:24 +0000 (14:55 +0000)]
    Land support for the CSS @font-face rule.  This patch allows custom fonts
        to be downloaded from the Web and rendered in Web pages.  Right now only
        TrueType fonts are supported.  Proprietary formats like .eot are not
        supported.

        Reviewed by Eric Seidel

        Many tests will be coming in a future landing.

        * WebCore.base.exp:
        Expose some more stuff for WebKit, caused by font restructuring.

        * WebCore.xcodeproj/project.pbxproj:
        Add all the new font face files.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Make sure to ignore the 'src' property of @font-face rules.

        * css/CSSFontFace.cpp: Added.
        (WebCore::CSSFontFace::CSSFontFace):
        (WebCore::CSSFontFace::~CSSFontFace):
        (WebCore::CSSFontFace::isLoaded):
        (WebCore::CSSFontFace::isValid):
        (WebCore::CSSFontFace::addSource):
        (WebCore::CSSFontFace::fontLoaded):
        (WebCore::CSSFontFace::getFontData):
        * css/CSSFontFace.h: Added.
        A CSSFontFace is a composite object.  It consists of multiple font-face sources, where each source represents either a remote or local
        file in a @font-face rule's src list.

        * css/CSSFontFaceRule.cpp:
        (WebCore::CSSFontFaceRule::setDeclaration):
        (WebCore::CSSFontFaceRule::cssText):
        * css/CSSFontFaceRule.h:
        The implementation of the @font-face rule itself in the CSS sheet back end.

        * css/CSSFontFaceSource.cpp: Added.
        (WebCore::CSSFontFaceSource::CSSFontFaceSource):
        (WebCore::CSSFontFaceSource::~CSSFontFaceSource):
        (WebCore::CSSFontFaceSource::pruneTable):
        (WebCore::CSSFontFaceSource::isLoaded):
        (WebCore::CSSFontFaceSource::isValid):
        (WebCore::CSSFontFaceSource::fontLoaded):
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSFontFaceSource.h: Added.
        (WebCore::CSSFontFaceSource::string):
        (WebCore::CSSFontFaceSource::setFontFace):
        A font face source represents a single remote or local font.  If it represents a remote font than it wraps a CachedFont.

        * css/CSSFontFaceSrcValue.cpp: Added.
        (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
        (WebCore::CSSFontFaceSrcValue::cssText):
        * css/CSSFontFaceSrcValue.h: Added.
        (WebCore::CSSFontFaceSrcValue::m_isLocal):
        (WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):
        (WebCore::CSSFontFaceSrcValue::resource):
        (WebCore::CSSFontFaceSrcValue::format):
        (WebCore::CSSFontFaceSrcValue::isLocal):
        (WebCore::CSSFontFaceSrcValue::setFormat):
        Used in parsing.  Represents the parsed form of the src value that can then be used to build up a CSSFontFace.

        * css/CSSFontSelector.cpp: Added.
        (WebCore::CSSFontSelector::CSSFontSelector):
        (WebCore::CSSFontSelector::~CSSFontSelector):
        (WebCore::CSSFontSelector::isEmpty):
        (WebCore::CSSFontSelector::docLoader):
        (WebCore::hashForFont):
        (WebCore::CSSFontSelector::addFontFaceRule):
        (WebCore::CSSFontSelector::fontLoaded):
        (WebCore::CSSFontSelector::getFontData):
        * css/CSSFontSelector.h: Added.
        The CSS font selector is the object that selects the correct font given a specified font family.  It builds up a database of CSSFontFaces that can then be handed
        back.

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        Modify the CSS grammar to now understand @font-face rules.

        * css/CSSPropertyNames.in:
        Add the src property.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::updateFont):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::ensureFontSelector):
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::fontSelector):
        The style selector now creates a font selector object and feeds it the appropriate information when @font-face rules are encountered.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        Patch the update method now that it takes a font selector argument.

        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::getStatistics):
        * loader/Cache.h:
        Teach the Cache about CachedFonts.

        * loader/CachedFont.cpp: Added.
        (WebCore::CachedFont::CachedFont):
        (WebCore::CachedFont::~CachedFont):
        (WebCore::CachedFont::ref):
        (WebCore::CachedFont::data):
        (WebCore::CachedFont::beginLoadIfNeeded):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::platformDataFromCustomData):
        (WebCore::CachedFont::allReferencesRemoved):
        (WebCore::CachedFont::checkNotify):
        (WebCore::CachedFont::error):
        * loader/CachedFont.h: Added.
        (WebCore::CachedFont::schedule):
        The implementation of CachedFont.  This represents the downloaded resource and has all the raw font data.

        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::fontLoaded):
        Add a new fontLoaded method for clients of cached resources to track when fonts finish downloading.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestFont):
        * loader/DocLoader.h:
         Add the ability to request a font.

        * platform/Font.cpp:
        (WebCore::Font::operator==):
        (WebCore::Font::update):
        (WebCore::Font::drawText):
        * platform/Font.h:
        * platform/FontCache.cpp:
        (WebCore::FontCache::getFontData):
        * platform/FontCache.h:
        * platform/FontData.cpp:
        (WebCore::FontData::FontData):
        * platform/FontData.h:
        (WebCore::FontData::isCustomFont):
        (WebCore::FontData::isLoading):
        * platform/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList):
        (WebCore::FontFallbackList::invalidate):
        (WebCore::FontFallbackList::fontDataAt):
        * platform/FontFallbackList.h:
        (WebCore::FontFallbackList::loadingCustomFonts):
        (WebCore::FontFallbackList::fontSelector):
        * platform/FontSelector.h: Added.
        (WebCore::FontSelector::~FontSelector):
        * platform/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::getRoot):
        (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
        (WebCore::GlyphPageTreeNode::~GlyphPageTreeNode):
        (WebCore::GlyphPageTreeNode::initializePage):
        (WebCore::GlyphPageTreeNode::getChild):
        (WebCore::GlyphPageTreeNode::pruneCustomFontData):
        * platform/GlyphPageTreeNode.h:
        (WebCore::GlyphPageTreeNode::GlyphPageTreeNode):
        (WebCore::GlyphPageTreeNode::page):
        * platform/PopupMenuClient.h:
        * platform/mac/FontCacheMac.mm:
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::FontCache::fontExists):
        (WebCore::FontCache::createFontPlatformData):
        * platform/mac/FontCustomPlatformData.cpp: Added.
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/mac/FontCustomPlatformData.h: Added.
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        * platform/mac/FontDataMac.mm:
        (WebCore::initFontData):
        (WebCore::FontData::platformInit):
        (WebCore::FontData::smallCapsFontData):
        (WebCore::FontData::platformWidthForGlyph):
        (WebCore::FontData::checkShapesArabic):
        * platform/mac/FontMac.mm:
        (WebCore::initializeATSUStyle):
        (WebCore::Font::drawGlyphs):
        * platform/mac/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::operator==):
        * platform/mac/FontPlatformDataMac.mm: Added.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::~FontPlatformData):
        (WebCore::FontPlatformData::setFont):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * platform/win/FontCacheWin.cpp:
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::FontCache::fontExists):
        * platform/win/FontCustomPlatformData.cpp: Added.
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::getData):
        (WebCore::releaseData):
        (WebCore::getBytesWithOffset):
        (WebCore::createFontCustomPlatformData):
        * platform/win/FontCustomPlatformData.h: Added.
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        * platform/win/FontDataWin.cpp:
        (WebCore::FontData::platformInit):
        (WebCore::FontData::platformDestroy):
        (WebCore::FontData::smallCapsFontData):
        (WebCore::FontData::containsCharacters):
        (WebCore::FontData::determinePitch):
        * platform/win/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::operator==):
        * platform/win/FontPlatformDataWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint):
        Changes to platform to support rendering of custom fonts.  Too large to go into, but for ports, the relevant object to implement is
        FontCustomPlatformData (to get the data loaded into your native font format), and then you have to patch your other font objects to know
        how to use the font.

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::paintItemForeground):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::fontSelector):
        * rendering/RenderMenuList.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::fontSelector):
        * rendering/RenderTextControl.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::setFontFromControlSize):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::setFontFromControlSize):
        Patches for update now taking a font selector argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
oliver [Fri, 12 Oct 2007 14:54:03 +0000 (14:54 +0000)]
    Reviewed by Eric.

        Remove unneeded code and other cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
oliver [Fri, 12 Oct 2007 14:52:44 +0000 (14:52 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=15260
        Any styles defined after <element> {<property>:%} style are ignored by Safari

        Add dummy rule to skip constructions like width: %.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Olliej.
oliver [Fri, 12 Oct 2007 14:51:24 +0000 (14:51 +0000)]
    Reviewed by Olliej.

        Adapt to changed location of Ahem font.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-03 Mark Rowe <mrowe@apple.com>
oliver [Fri, 12 Oct 2007 14:50:05 +0000 (14:50 +0000)]
2007-10-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Lars.

        Get Gtk+ port building on the feature branch.

        * WebCore.pro:
        * ksvg2/svg/SVGSVGElement.cpp:
        * platform/graphics/svg/cairo/RenderPathCairo.cpp:
        (WebCore::RenderPath::strokeContains):
        * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp:
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::renderPath):
        * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp:
        (WebCore::SVGPaintServerSolid::setup):
        * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp:
        (WebCore::SVGResourceMasker::applyMask):
        * rendering/SVGCharacterLayoutInfo.cpp:
        * rendering/SVGInlineTextBox.cpp:
        * rendering/SVGRootInlineBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
oliver [Fri, 12 Oct 2007 14:48:43 +0000 (14:48 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=15102
        XMLHttpRequests should dispatch a readystatechange event.

        Test: http/tests/xmlhttprequest/readystatechange.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener): Added readystatechange
        event support. Fixed the function to dispatch the same event to all listeners
        instead of creating a new copy for each one. Changed bubbling/cancelability of
        load and readystatechange events to match Firefox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
oliver [Fri, 12 Oct 2007 14:47:19 +0000 (14:47 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=10370
        RegExp fails to match non-ASCII characters against [\S\s]

        Test: fast/js/regexp-negative-special-characters.html

        * pcre/pcre_compile.c:
        (compile_branch): Adjust opcode and bitmap as necessary to include (or exclude)
        character codes >255. Fix suggested by Philip Hazel.

        * pcre/pcre_exec.c:
        (match): Merged fix for PCRE bug 580 (\S\S vs. \S{2}).

        * tests/mozilla/expected.html: One test was fixed.
        * pcre/MERGING: Added information about this fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-02 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 14:45:54 +0000 (14:45 +0000)]
2007-10-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver Hunt.

        http://bugs.webkit.org/show_bug.cgi?id=13828
        Fixes svg/custom/rootmost-svg-xy-attrs.xhtml

        * WebCore.xcodeproj/project.pbxproj: fix warning about SVGDOM.h
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::viewport): use new isOutermostSVG()
        (WebCore::SVGSVGElement::getCTM): use isOutermostSVG()
        (WebCore::SVGSVGElement::getScreenCTM): use isOutermostSVG()
        (WebCore::SVGSVGElement::createRenderer): use isOutermostSVG()
        (WebCore::SVGSVGElement::isOutermostSVG):
        * ksvg2/svg/SVGSVGElement.h: add isOutermostSVG
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcViewport): ignore x/y

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mitz.
oliver [Fri, 12 Oct 2007 14:44:29 +0000 (14:44 +0000)]
    Reviewed by Mitz.

        - Avoid uselessly serializing CSS property values on replacement for 10% CK DOM speedup
        http://bugs.webkit.org/show_bug.cgi?id=15340

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::removeProperty): Don't generate return value unless needed.
        (WebCore::CSSMutableStyleDeclaration::setProperty): Use the no-return version appropriately.
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::removeProperty): New version with no return value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
oliver [Fri, 12 Oct 2007 14:43:04 +0000 (14:43 +0000)]
    Reviewed by Oliver.

        - skip extra hash lookup and avoid converting char* to UString for 19% speedup on CK JS array test
        http://bugs.webkit.org/show_bug.cgi?id=15350

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): Implement the two mentioned optimizations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
oliver [Fri, 12 Oct 2007 14:41:35 +0000 (14:41 +0000)]
WebCore:

        Reviewed by Oliver.

        - Use Vector<UChar> instead of DeprecatedString for innerHTML, for 35% speedup on CK DOM test
        http://bugs.webkit.org/show_bug.cgi?id=15339

        Rewrote both versions of createMarkup to build based on
        Vector<UChar> instead of String. Also other miscellaneous
        speedups (mainly content strings are now encoded in a way that
        doesn't take a function call per character, and switch is avoided).

        This also causes a functional change - we no longer escape '>' since this was unnecessary and it's faster
        to avoid testing for it. See updated test results.

        * editing/markup.cpp:
        (WebCore::appendString):
        (WebCore::appendAttributeValue):
        (WebCore::escapeContentText):
        (WebCore::appendEscapedContent):
        (WebCore::appendDeprecatedString):
        (WebCore::appendQuotedURLAttributeValue):
        (WebCore::stringValueForRange):
        (WebCore::ucharRange):
        (WebCore::appendUCharRange):
        (WebCore::appendNamespace):
        (WebCore::appendStartMarkup):
        (WebCore::getStartMarkup):
        (WebCore::appendEndMarkup):
        (WebCore::getEndMarkup):
        (WebCore::appendMarkup):
        (WebCore::joinMarkups):
        (WebCore::createMarkup):
        * editing/markup.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge markupStringFromNode:nodes:]):
        (-[WebCoreFrameBridge markupStringFromRange:nodes:]):

LayoutTests:

        Reviewed by Oliver.

        - test updates for "file:///Volumes/Data/mjs/Work/src/Safari/OpenSource/LayoutTests/fast/dom/serialize-attribute.xhtml"
        http://bugs.webkit.org/show_bug.cgi?id=15339

        We no longer entity-escape the '>' character in content or attribute values since this is unnecessary.

        * fast/dom/dom-parse-serialize-expected.txt:
        * fast/dom/serialize-attribute.xhtml:
        * fast/xsl/xslt-processor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark.
oliver [Fri, 12 Oct 2007 14:40:05 +0000 (14:40 +0000)]
    Reviewed by Mark.

        - Efficiently handle regexp property identifiers for 19% speedup on Celtic Kane regexp test
        http://bugs.webkit.org/show_bug.cgi?id=15337

        * kjs/CommonIdentifiers.h:
        * kjs/regexp_object.cpp:
        (RegExpProtoFunc::callAsFunction):
        (RegExpObjectImp::arrayOfMatches):
        (RegExpObjectImp::construct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark.
oliver [Fri, 12 Oct 2007 14:38:37 +0000 (14:38 +0000)]
    Reviewed by Mark.

        - Cache global prorotypes more efficiently for 10% speedup on CK AJAX benchmark
        http://bugs.webkit.org/show_bug.cgi?id=15335

        * kjs/lookup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated last ChangeLog entry to indicate speedup:
oliver [Fri, 12 Oct 2007 14:37:09 +0000 (14:37 +0000)]
Updated last ChangeLog entry to indicate speedup:
        (65% speedup on Celtic Kane JS 2007 DOM test)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
oliver [Fri, 12 Oct 2007 14:35:39 +0000 (14:35 +0000)]
    Reviewed by Eric.

        - fixed "innerHTML updates layout every time (very bad if adding to it in a loop)"
        http://bugs.webkit.org/show_bug.cgi?id=15326

        * editing/markup.cpp:
        (WebCore::createMarkup): The Node version of this function currently never uses
        the render tree, so don't bother to update layout. This is the version used for
        innerHTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-02 Nicholas Shanks <webkit@nickshanks.com>
oliver [Fri, 12 Oct 2007 14:34:09 +0000 (14:34 +0000)]
2007-10-02  Nicholas Shanks  <webkit@nickshanks.com>

        Reviewed by eseidel & hyatt.

        Add support for CSS3 values 'start' and 'end' to text-align property.

        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue): allow start and end values
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): handle start and end values

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-02 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 14:32:36 +0000 (14:32 +0000)]
2007-10-02  Eric Seidel  <eric@webkit.org>

        Rubber-stamped by Maciej.

        Updating test results after feature-branch rebase for tests whose new results are more correct.
        Also adding a few missing pixel test results.

        * fast/dom/attribute-case-sensitivity-expected.txt:
        * fast/dom/attribute-case-sensitivity2-expected.txt:
        * fast/layers/scroll-rect-to-visible-expected.png:
        * fast/text/international/bidi-neutral-run-expected.png:
        * platform/mac/editing/pasteboard/5478250-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5478250-expected.png: Added.
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
        * svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.png:
        * svg/batik/text/textEffect-expected.png:
        * svg/batik/text/textEffect3-expected.png:
        * svg/custom/js-late-gradient-and-object-creation-expected.png:
        * svg/custom/use-infinite-recursion-expected.checksum: Added.
        * svg/custom/use-infinite-recursion-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrecting expected layout test results
oliver [Fri, 12 Oct 2007 14:31:04 +0000 (14:31 +0000)]
Correcting expected layout test results

RS = Eric

        * fast/dom/Window/window-properties-expected.txt:
        * fast/images/svg-as-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out previous change as made layout-test-results unusable with large tables
oliver [Fri, 12 Oct 2007 14:29:30 +0000 (14:29 +0000)]
Roll out previous change as made layout-test-results unusable with large tables

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-02 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 14:27:56 +0000 (14:27 +0000)]
2007-10-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam Wenig.

        Make layout results table sortable (using sorttable.js)

        * Scripts/resources: Added.
        * Scripts/resources/sorttable.js: Added.
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-02 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 14:26:22 +0000 (14:26 +0000)]
2007-10-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        Make pixel tests more useful!
        Finally fix the image diff 0.00% mystery problem
        Highlight any image differences in the image diff.
        Add a link from image diffs back to original test file.

        * DumpRenderTree/mac/ImageDiff.m:
        (compareImages): highlight any differences
        (computePercentageDifferent): round to two decimal places
        * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-10-02 Eric Seidel <eric@webkit.org>
oliver [Fri, 12 Oct 2007 14:24:49 +0000 (14:24 +0000)]
2007-10-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        * Scripts/run-webkit-tests: print the % image difference on main results page

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26463 268f45cc-cd09-0410-ab3c-d52691b4dbfc