WebKit-https.git
6 months ago[macOS / iOS Debug] Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnect...
ryanhaddad@apple.com [Tue, 7 May 2019 16:03:09 +0000 (16:03 +0000)]
[macOS / iOS Debug] Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197662

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations: Mark test as flaky.
* platform/mac-wk2/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[macOS] Avoid crashing the UI process when writing empty data to the pasteboard
wenson_hsieh@apple.com [Tue, 7 May 2019 14:39:10 +0000 (14:39 +0000)]
[macOS] Avoid crashing the UI process when writing empty data to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=197644
<rdar://problem/50526364>

Reviewed by Tim Horton.

Source/WebKit:

Test: WebKit.WKWebProcessPlugInDoNotCrashWhenCopyingEmptyClientData

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::setBufferForType):

Make this function robust by not attempting to create a shared memory buffer in the case where the given data
buffer is empty.

Tools:

Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.

* TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
* TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
(-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[GTK] Crash in webkitWebViewBaseSetEnableBackForwardNavigationGesture
carlosgc@webkit.org [Tue, 7 May 2019 14:33:47 +0000 (14:33 +0000)]
[GTK] Crash in webkitWebViewBaseSetEnableBackForwardNavigationGesture
https://bugs.webkit.org/show_bug.cgi?id=197653

Reviewed by Žan Doberšek.

We still need to null-check the ViewGestureController there, since it can be called with a running process but
not yet attached when using a related view.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetEnableBackForwardNavigationGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
carlosgc@webkit.org [Tue, 7 May 2019 12:33:56 +0000 (12:33 +0000)]
[GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
https://bugs.webkit.org/show_bug.cgi?id=197651

Reviewed by Žan Doberšek.

This is required since the process creation was delayed until something is loaded in the view.

* MiniBrowser/gtk/BrowserWindow.c:
(browser_window_get_or_create_web_view_for_automation):
* MiniBrowser/wpe/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago<body> with overflow:hidden CSS is scrollable on iOS
antti@apple.com [Tue, 7 May 2019 12:02:25 +0000 (12:02 +0000)]
<body> with overflow:hidden CSS is scrollable on iOS
https://bugs.webkit.org/show_bug.cgi?id=153852
<rdar://problem/38715356>

Reviewed by Antoine Quint.

Source/WebCore:

Tests: fast/scrolling/ios/body-overflow-hidden-frame.html
       fast/scrolling/ios/body-overflow-hidden.html

* page/scrolling/ScrollingTreeScrollingNode.h:

Source/WebKit:

Disable touch scrolling of the main scroll view when <body> has overflow:hidden.

This already works for subframes where we don't create a scrollview in the first place.
The patch also adds a test for that.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):

Update scrollability after scrolling tree commits.

* UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::hasScrollableMainFrame const):

Base the decision on root ScrollingTreeScrollingNode::canHaveScrollbars() which is computed from overflow.
This matches Mac where wheel event dispatch is similarly blocked based on this property.

* UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:

LayoutTests:

* fast/scrolling/ios/body-overflow-hidden-expected.html: Added.
* fast/scrolling/ios/body-overflow-hidden-frame-expected.html: Added.
* fast/scrolling/ios/body-overflow-hidden-frame.html: Added.
* fast/scrolling/ios/body-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMouse event simulation should be limited to the graphing calculator on Desmos.com
graouts@webkit.org [Tue, 7 May 2019 09:50:15 +0000 (09:50 +0000)]
Mouse event simulation should be limited to the graphing calculator on Desmos.com
https://bugs.webkit.org/show_bug.cgi?id=197652
<rdar://problem/47068176>

Reviewed by Antti Koivisto.

* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoImport WPT referrer-policy tests
youenn@apple.com [Tue, 7 May 2019 09:44:54 +0000 (09:44 +0000)]
Import WPT referrer-policy tests
https://bugs.webkit.org/show_bug.cgi?id=197321

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* resources/import-expectations.json:
* web-platform-tests/common/: Refreshed.
* web-platform-tests/custom-elements/custom-element-registry/per-global-expected.txt:
* web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/navigated-named-objects.window-expected.txt:
* web-platform-tests/referrer-policy/: Added.

LayoutTests:

fix-197321

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUpdate test262 expectations for Proxy passes
dino@apple.com [Tue, 7 May 2019 05:05:42 +0000 (05:05 +0000)]
Update test262 expectations for Proxy passes
https://bugs.webkit.org/show_bug.cgi?id=197628

Reviewed by Yusuke Suzuki.

There are two consistent passes in Proxy.ownKeys.

* test262/expectations.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoImprove coordination for creating UIWindow instances.
commit-queue@webkit.org [Tue, 7 May 2019 03:51:58 +0000 (03:51 +0000)]
Improve coordination for creating UIWindow instances.
https://bugs.webkit.org/show_bug.cgi?id=197578.
<rdar://problem/50456965>.

Patch by James Savage <james.savage@apple.com> on 2019-05-06
Reviewed by Wenson Hsieh.

Source/WebCore:

* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(makeWindowFromView): Pull out window creation.
(VideoFullscreenInterfaceAVKit::doSetup): Call new helper function.

Source/WebKit:

* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(makeWindowFromView): Pull out window creation.
(-[WKFullScreenWindowController enterFullScreen]): Call new helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoJSWrapperMap should check if existing prototype properties are wrappers when copying...
keith_miller@apple.com [Tue, 7 May 2019 01:23:39 +0000 (01:23 +0000)]
JSWrapperMap should check if existing prototype properties are wrappers when copying exported methods.
https://bugs.webkit.org/show_bug.cgi?id=197324
<rdar://problem/50253144>

Reviewed by Saam Barati.

The current implementation prevents using JSExport to shadow a
method from a super class. This was because we would only add a
method if the prototype didn't already claim to have the
property. Normally this would only happen if an Objective-C super
class already exported a ObjCCallbackFunction for the method,
however, if the user exports a property that is already on
Object.prototype the overriden method won't be exported.

This patch fixes the object prototype issue by checking if the
property on the prototype chain is an ObjCCallbackFunction, if
it's not then it adds an override.

* API/JSWrapperMap.mm:
(copyMethodsToObject):
* API/tests/testapi.mm:
(-[ToStringClass toString]):
(-[ToStringClass other]):
(-[ToStringSubclass toString]):
(-[ToStringSubclassNoProtocol toString]):
(testToString):
(testObjectiveCAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago_overrideViewportWithArguments does not work when called before loading
timothy_horton@apple.com [Tue, 7 May 2019 01:03:01 +0000 (01:03 +0000)]
_overrideViewportWithArguments does not work when called before loading
https://bugs.webkit.org/show_bug.cgi?id=197638
<rdar://problem/50505111>

Reviewed by Wenson Hsieh.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::viewportArguments const):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setOverrideViewportArguments): Deleted.
* dom/Document.h:
(WebCore::Document::viewportArguments const): Deleted.
* page/Page.cpp:
(WebCore::Page::setOverrideViewportArguments):
* page/Page.h:
(WebCore::Page::overrideViewportArguments const):
* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setViewportArguments):
Move overrideViewportArguments to Page, since it is view-global in the API.

Source/WebKit:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setOverrideViewportArguments):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoASSERT at WebKit::NetworkCache::makeSafeToUseMemoryMapForPath under Storage::StoreBod...
cdumez@apple.com [Tue, 7 May 2019 00:42:44 +0000 (00:42 +0000)]
ASSERT at WebKit::NetworkCache::makeSafeToUseMemoryMapForPath under Storage::StoreBodyAsBlob when running WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=197635
<rdar://problem/50473149>

Reviewed by Geoffrey Garen.

We need to make sure the the path at blobPathString exists before calling FileSystem::makeSafeToUseMemoryMapForPath().
If the blob does not already exist when BlobStorage::add() is called, what will create it is the call to Data::mapToFile().

* NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
(WebKit::NetworkCache::BlobStorage::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] We should check OOM for description string of Symbol
ysuzuki@apple.com [Tue, 7 May 2019 00:29:09 +0000 (00:29 +0000)]
[JSC] We should check OOM for description string of Symbol
https://bugs.webkit.org/show_bug.cgi?id=197634

Reviewed by Keith Miller.

JSTests:

* stress/check-symbol-description-oom.js: Added.
(shouldThrow):

Source/JavaScriptCore:

When resoling JSString for description of Symbol, we should check OOM error.
We also change JSValueMakeSymbol(..., nullptr) to returning a symbol value
without description, (1) to simplify the code and (2) give a way for JSC API
to create a symbol value without description.

* API/JSValueRef.cpp:
(JSValueMakeSymbol):
* API/tests/testapi.cpp:
(TestAPI::symbolsTypeof):
(TestAPI::symbolsDescription):
(testCAPIViaCpp):
* dfg/DFGOperations.cpp:
* runtime/Symbol.cpp:
(JSC::Symbol::createWithDescription):
* runtime/Symbol.h:
* runtime/SymbolConstructor.cpp:
(JSC::callSymbol):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd assertions to JSLazyEventListener to help catch the cause of a crash
cdumez@apple.com [Tue, 7 May 2019 00:21:25 +0000 (00:21 +0000)]
Add assertions to JSLazyEventListener to help catch the cause of a crash
https://bugs.webkit.org/show_bug.cgi?id=197617

Reviewed by Alexey Proskuryakov.

Add assertions to JSLazyEventListener to help catch the cause of <rdar://problem/24314027>.

* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::checkValidityForEventTarget):
* bindings/js/JSLazyEventListener.h:
* dom/EventListener.h:
(WebCore::EventListener::checkValidityForEventTarget):
* dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::innerInvokeEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Respect already defined USE_LLINT_EMBEDDED_OPCODE_ID compiler variable.
chris.reid@sony.com [Tue, 7 May 2019 00:20:01 +0000 (00:20 +0000)]
[JSC] Respect already defined USE_LLINT_EMBEDDED_OPCODE_ID compiler variable.
https://bugs.webkit.org/show_bug.cgi?id=197633

Reviewed by Don Olmstead.

When the variable `USE_LLINT_EMBEDDED_OPCODE_ID` is defined, stop defining
its value with platform default one.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoOccasional crashes in layout tests when firing the shrink-to-fit-content timer
wenson_hsieh@apple.com [Tue, 7 May 2019 00:08:10 +0000 (00:08 +0000)]
Occasional crashes in layout tests when firing the shrink-to-fit-content timer
https://bugs.webkit.org/show_bug.cgi?id=197629
<rdar://problem/50514382>

Reviewed by Tim Horton.

Fixes several crashing layout tests by stopping the shrink-to-fit-content timer when the page closes.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[Web GPU] Add demos to webkit.org
justin_fan@apple.com [Tue, 7 May 2019 00:04:38 +0000 (00:04 +0000)]
[Web GPU] Add demos to webkit.org
https://bugs.webkit.org/show_bug.cgi?id=196951

Reviewed by Dean Jackson.

Add simple triangle and spinning textured cube demos to the website.
Add Web GPU to experimental-features.html.

* demos/webgpu/css/style.css: Added.
(body):
(canvas):
(body.error canvas):
(h1):
(#container):
(select):
(div#log):
(body.error):
(body.error #contents):
(#error):
(@media (max-width: 480px)):
(body.error #error):
(#error h2):
(#error p):
* demos/webgpu/hello-cube.html: Added.
* demos/webgpu/hello-triangle.html: Added.
* demos/webgpu/index.html: Added.
* demos/webgpu/resources/circle.svg: Added.
* demos/webgpu/resources/hello-cube.png: Added.
* demos/webgpu/resources/hello-triangle.png: Added.
* demos/webgpu/resources/safari-alpha.png: Added.
* demos/webgpu/scripts/gl-matrix-min.js: Added.
(return.n):
(return.n.d):
(return.):
(return.get n.n):
(return.n.o):
* demos/webgpu/scripts/hello-triangle.js: Added.
(async.helloTriangle):
* experimental-features.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoVersioning.
alancoon@apple.com [Mon, 6 May 2019 23:49:56 +0000 (23:49 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't...
pvollan@apple.com [Mon, 6 May 2019 23:29:46 +0000 (23:29 +0000)]
-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=197510
Source/WebCore:

<rdar://problem/50372338>

Reviewed by Alex Christensen.

This patch implements deletion of non persistent credentials for a set of origins. In order for this to work, fetching
credentials from the credential storage needs to return a set of SecurityOriginData objects, instead of a set of origin
strings. This is implemented by iterating over all the elements in the credential map, and creating a SecurityOriginData
object for each credential based on the protection space.

API test: WKWebsiteDataStore.RemoveNonPersistentCredentials

* platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::removeCredentialsWithOrigin):
(WebCore::CredentialStorage::originsWithCredentials const):
* platform/network/CredentialStorage.h:
(WebCore::CredentialStorage::originsWithCredentials const): Deleted.

Source/WebKit:

Reviewed by Alex Christensen.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):

Tools:

Reviewed by Alex Christensen.

* TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTemporarily disable generate-xcfilelists
krollin@apple.com [Mon, 6 May 2019 23:13:47 +0000 (23:13 +0000)]
Temporarily disable generate-xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=197619
<rdar://problem/50507392>

Reviewed by Alex Christensen.

We need to perform a significant update to the generate-xcfilelist
scripts. This work involves coordinated work with another facility. If
the work does not occur in tandem, the build will be broken. To avoid
this, disable the invoking of the scripts during the transition. The
checking will be restored once the new scripts are in place.

Source/JavaScriptCore:

* Scripts/check-xcfilelists.sh:

Source/WebCore:

No new tests -- no change in user-visible functionality.

* Scripts/check-xcfilelists.sh:

Source/WebKit:

* Scripts/check-xcfilelists.sh:

Tools:

* DumpRenderTree/Scripts/check-xcfilelists.sh:
* WebKitTestRunner/Scripts/check-xcfilelists.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[PlayStation] Fix build break since r244919
Basuke.Suzuki@sony.com [Mon, 6 May 2019 23:10:36 +0000 (23:10 +0000)]
[PlayStation] Fix build break since r244919
https://bugs.webkit.org/show_bug.cgi?id=197627

Reviewed by Ross Kirsling.

Bugfix for POSIX socket implementation and suppress warnings.

* inspector/remote/socket/RemoteInspectorConnectionClient.h:
(Inspector::RemoteInspectorConnectionClient::didAccept):
* inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
(Inspector::Socket::getPort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed build fix after r244984.
cdumez@apple.com [Mon, 6 May 2019 23:07:33 +0000 (23:07 +0000)]
Unreviewed build fix after r244984.

* WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoPrewarmed WebContent processes never app nap
cdumez@apple.com [Mon, 6 May 2019 22:47:26 +0000 (22:47 +0000)]
Prewarmed WebContent processes never app nap
https://bugs.webkit.org/show_bug.cgi?id=197630

Reviewed by Geoffrey Garen.

Do not require actually having a WebPage in the WebContent process to App Nap.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateThrottleState):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoHitpoint for link which spans two lines in web content is incorrect
commit-queue@webkit.org [Mon, 6 May 2019 22:33:52 +0000 (22:33 +0000)]
Hitpoint for link which spans two lines in web content is incorrect
https://bugs.webkit.org/show_bug.cgi?id=197511
<rdar://problem/49971483>

Patch by Andres Gonzalez <andresg_22@apple.com> on 2019-05-06
Reviewed by Chris Fleizach.

Source/WebCore:

- Special case for links to return first char location as clickPoint instead of middle point of bounding rect.
- Modified iOS ActivationPoint to use clickPoint. This way all code paths go through the same function.
- Made boundsForRects to return content coordinates in all platforms. Adjusted all callers, directly or indirectly, appropriately.

Tests: accessibility/ios-simulator/links-activation.html
       accessibility/links-activation.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::boundsForRects):
(WebCore::AccessibilityRenderObject::boundsForRects const): Deleted.
* accessibility/AccessibilityRenderObject.h:
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

LayoutTests:

- Added LayoutTest.

* accessibility/ios-simulator/links-activation-expected.txt: Added.
* accessibility/ios-simulator/links-activation.html: Added.
* accessibility/links-activation-expected.txt: Added.
* accessibility/links-activation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoFix the build after r244975
dbates@webkit.org [Mon, 6 May 2019 22:28:19 +0000 (22:28 +0000)]
Fix the build after r244975
(https://bugs.webkit.org/show_bug.cgi?id=197474)

Actually make use of the Keyboard Event when building with USE(UIKIT_KEYBOARD_ADDITIONS)
and substitute -> for . since it's now passed by reference.

* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::handleInputMethodKeydown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed, land one more test
ysuzuki@apple.com [Mon, 6 May 2019 22:26:28 +0000 (22:26 +0000)]
Unreviewed, land one more test
https://bugs.webkit.org/show_bug.cgi?id=197587

* stress/setter-frame-flush.js: Added.
(setter):
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdopt AVStreamDataParser.audiovisualMIMETypes
jer.noble@apple.com [Mon, 6 May 2019 22:22:26 +0000 (22:22 +0000)]
Adopt AVStreamDataParser.audiovisualMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=197581
<rdar://problem/50458981>

Reviewed by Eric Carlson.

Source/WebCore:

Add a new singleton class, AVStreamDataParserMIMETypeCache, and rename AVFoundationMIMETypeCache to the more precise
AVAssetMIMETypeCache.  Update all the old AVFoundationMIMETypeCache with the new name.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.h: Renamed from Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.h.
(WebCore::AVAssetMIMETypeCache::setCacheMIMETypesCallback):
* platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm: Renamed from Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm.
(WebCore::AVAssetMIMETypeCache::singleton):
(WebCore::AVAssetMIMETypeCache::setSupportedTypes):
(WebCore::AVAssetMIMETypeCache::types):
(WebCore::AVAssetMIMETypeCache::supportsContentType):
(WebCore::AVAssetMIMETypeCache::canDecodeType):
(WebCore::AVAssetMIMETypeCache::isAvailable const):
(WebCore::AVAssetMIMETypeCache::loadMIMETypes):
* platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.h: Added.
* platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm: Added.
(WebCore::AVStreamDataParserMIMETypeCache::singleton):
(WebCore::AVStreamDataParserMIMETypeCache::types):
(WebCore::AVStreamDataParserMIMETypeCache::supportsContentType):
(WebCore::AVStreamDataParserMIMETypeCache::canDecodeType):
(WebCore::AVStreamDataParserMIMETypeCache::isAvailable const):
(WebCore::AVStreamDataParserMIMETypeCache::loadMIMETypes):
* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::ImageDecoderAVFObjC::create):
(WebCore::ImageDecoderAVFObjC::supportsMediaType):
(WebCore::ImageDecoderAVFObjC::supportsContentType):
(WebCore::ImageDecoderAVFObjC::canDecodeType):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):

Source/WebKit:

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
(WebKit::WebProcess::setMediaMIMETypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTerminate service workers that use too much CPU / power
cdumez@apple.com [Mon, 6 May 2019 21:44:01 +0000 (21:44 +0000)]
Terminate service workers that use too much CPU / power
https://bugs.webkit.org/show_bug.cgi?id=197626
<rdar://problem/50374707>

Reviewed by Geoffrey Garen.

Terminate service worker processes that use over 50% CPU on average over the last 8 minutes,
similarly to what we do for background WebContent processes.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didExceedCPULimit):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::updateCPULimit):
(WebKit::WebProcess::updateCPUMonitorState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTemplateObject passed to template literal tags are not always identical for the same...
ysuzuki@apple.com [Mon, 6 May 2019 21:33:27 +0000 (21:33 +0000)]
TemplateObject passed to template literal tags are not always identical for the same source location.
https://bugs.webkit.org/show_bug.cgi?id=190756

Reviewed by Saam Barati.

JSTests:

* complex.yaml:
* complex/tagged-template-regeneration-after.js: Added.
(shouldBe):
* complex/tagged-template-regeneration.js: Added.
(call):
(test):
* modules/tagged-template-inside-module.js: Added.
(from.string_appeared_here.call):
* modules/tagged-template-inside-module/other-tagged-templates.js: Added.
(call):
(export.otherTaggedTemplates):
* stress/call-and-construct-should-return-same-tagged-templates.js: Added.
(shouldBe):
(call):
(poly):
* stress/tagged-templates-in-direct-eval-should-not-produce-same-site-object.js: Added.
(shouldBe):
(call):
* stress/tagged-templates-in-global-function-should-not-produce-same-site-object.js: Added.
(shouldBe):
(call):
* stress/tagged-templates-in-indirect-eval-should-not-produce-same-site-object.js: Added.
(shouldBe):
(call):
* stress/tagged-templates-in-multiple-functions.js: Added.
(shouldBe):
(call):
(a):
(b):
(c):

Source/JavaScriptCore:

Tagged template literal requires that the site object is allocated per source location. Previously, we create the site object
when linking CodeBlock and cache it in CodeBlock. But this is wrong because,

1. CodeBlock can be jettisoned and regenerated. So every time CodeBlock is regenerated, we get the different site object.
2. Call and Construct can have different CodeBlock. Even if the function is called in call-form or construct-form, we should return the same site object.

In this patch, we start caching these site objects in the top-level ScriptExecutable, this matches the spec's per source location since the only one top-level
ScriptExecutable is created for the given script code. Each ScriptExecutable of JSFunction can be created multiple times because CodeBlock creates it.
But the top-level one is not created by CodeBlock. This top-level ScriptExecutable is well-aligned to the Script itself. The top-level ScriptExecutable now has HashMap,
which maps source locations to cached site objects.

1. This patch threads the top-level ScriptExecutable to each FunctionExecutable creation. Each FunctionExecutable has a reference to the top-level ScriptExecutable.
2. We put TemplateObjectMap in ScriptExecutable, which manages cached template objects.
3. We move FunctionExecutable::m_cachedPolyProtoStructure to the FunctionExecutable::RareDate to keep FunctionExecutable 128 bytes.

* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
* Scripts/wkbuiltins/builtins_templates.py:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantRegisters):
* bytecode/CodeBlock.h:
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::link):
* bytecode/UnlinkedFunctionExecutable.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addTemplateObjectConstant):
(JSC::BytecodeGenerator::emitGetTemplateObject):
* bytecompiler/BytecodeGenerator.h:
* runtime/CachedTypes.cpp:
(JSC::CachedTemplateObjectDescriptor::encode):
(JSC::CachedTemplateObjectDescriptor::decode const):
(JSC::CachedJSValue::encode):
(JSC::CachedJSValue::decode const):
* runtime/EvalExecutable.cpp:
(JSC::EvalExecutable::ensureTemplateObjectMap):
(JSC::EvalExecutable::visitChildren):
* runtime/EvalExecutable.h:
* runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::finishCreation):
(JSC::FunctionExecutable::visitChildren):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::ensureRareDataSlow):
(JSC::FunctionExecutable::ensureTemplateObjectMap):
* runtime/FunctionExecutable.h:
* runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::instantiateDeclarations):
* runtime/JSTemplateObjectDescriptor.cpp:
(JSC::JSTemplateObjectDescriptor::JSTemplateObjectDescriptor):
(JSC::JSTemplateObjectDescriptor::create):
* runtime/JSTemplateObjectDescriptor.h:
* runtime/ModuleProgramExecutable.cpp:
(JSC::ModuleProgramExecutable::ensureTemplateObjectMap):
(JSC::ModuleProgramExecutable::visitChildren):
* runtime/ModuleProgramExecutable.h:
* runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::ensureTemplateObjectMap):
(JSC::ProgramExecutable::visitChildren):
* runtime/ProgramExecutable.h:
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::topLevelExecutable):
(JSC::ScriptExecutable::createTemplateObject):
(JSC::ScriptExecutable::ensureTemplateObjectMap):
* runtime/ScriptExecutable.h:
* tools/JSDollarVM.cpp:
(JSC::functionCreateBuiltin):
(JSC::functionDeleteAllCodeWhenIdle):
(JSC::JSDollarVM::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWebAudio Node JS wrappers should not be collected if events can be fired
youenn@apple.com [Mon, 6 May 2019 21:14:12 +0000 (21:14 +0000)]
WebAudio Node JS wrappers should not be collected if events can be fired
https://bugs.webkit.org/show_bug.cgi?id=197533

Reviewed by Jer Noble.

Source/WebCore:

Before the patch, some web audio nodes could fire event listeners, but were not protected from GC.
Use CustomIsReachable to ensure theses nodes can be collected if:
- their AudioContext is stopped (typically due to document being navigated away).
- their AudioContext is closed.
- nodes do not have event listeners.

Covered by WPT mediacapture-streams/MediaStreamTrack-MediaElement-disabled-audio-is-silence.https.html and
WPT webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html
and web audio WebRTC tests.
Specific newly added test: webaudio/webaudio-gc.html

* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::isClosed const):
* Modules/webaudio/AudioNode.idl:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioNodeCustom.cpp: Added.
(WebCore::JSAudioNodeOwner::isReachableFromOpaqueRoots):

LayoutTests:

* webaudio/webaudio-gc-expected.txt: Added.
* webaudio/webaudio-gc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION: Layout test imported/w3c/web-platform-tests/resource-timing/resource...
ryanhaddad@apple.com [Mon, 6 May 2019 20:44:27 +0000 (20:44 +0000)]
REGRESSION: Layout test imported/w3c/web-platform-tests/resource-timing/resource-timing-level1.sub.html is frequently failing on EWS
https://bugs.webkit.org/show_bug.cgi?id=197473

Unreviewed test gardening.

* platform/ios/TestExpectations: Mark test as flaky on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoGoogle Docs & Yahoo! Japan: Can’t compose characters with Chinese or Japanese keyboard
dbates@webkit.org [Mon, 6 May 2019 20:41:02 +0000 (20:41 +0000)]
Google Docs & Yahoo! Japan: Can’t compose characters with Chinese or Japanese keyboard
https://bugs.webkit.org/show_bug.cgi?id=197474
<rdar://problem/47219324>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix up some #if defs to compile more Mac code when building on iOS.

* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Source/WebKit:

Adopt UIKit SPI (added in <rdar://problem/50181162>) to ask the Input Manager to handle
the key event. If the Input Manager handled it then we pass along this information to
WebCore, just as we do for Mac, so that it can alter its event handling logic. Otherwise,
we handle the event as we do now.

A large part of this patch is fixing up #if defs to compile more Mac code when building
on iOS.

* Platform/spi/ios/UIKitSPI.h: Expose more SPI.
* Shared/NativeWebKeyboardEvent.h:
* Shared/WebEvent.h:
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):
* Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::encode const):
(WebKit::WebKeyboardEvent::decode):
* Shared/ios/NativeWebKeyboardEventIOS.mm:
(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
* Shared/ios/WebIOSEventFactory.h:
* Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::createWebKeyboardEvent):
Compile more Mac code on iOS. Just like on Mac we maintain some bookkeeping on
whether an event was handled by the Input Manager.

* UIProcess/Automation/ios/WebAutomationSessionIOS.mm:
(WebKit::WebAutomationSession::sendSynthesizedEventsToPage): Pass NativeWebKeyboardEvent::HandledByInputMethod::No
to keep the behavior we have now.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView shouldSuppressUpdateCandidateView]): Added. Used to tell UIKit whether to
suppress updating/showing the candidate view.
(-[WKContentView setMarkedText:selectedRange:]):
Bookkeeping to track whether we need to delay showing/updating the inline candidate view.
The concept in UIKit is deferment, but at the time of writing its simply a request to delay
the update for 0.4 seconds. We opt into this delay only for the first key that begins
marked text (i.e. the transition from no marked text to marked text). We do this because we
may not have up-to-date editor state at the time UIKit is ready to show/update the inline
candidate view for us to answer -textFirstRect and -textLastRect, which UIKit calls as part
of computing the frame rect for the inline candidate view on screen. Once we receive up-to-date
editor state, in -selectionChanged, we tell UIKit to layout the keyboard, which ultimately
causes it to re-compute the frame rect for the inline candidate view and show it.

(-[WKContentView handleKeyWebEvent:]): Pass NativeWebKeyboardEvent::HandledByInputMethod::No
to keep the behavior we have now.
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]): Ask the keyboard to handle the
event using the Input Manager. If it was handled then there is no need to delay calling the
completion handler, call it, then tell the web process about the key event and that it was
already handled by the Input Manager.
(-[WKContentView _selectionChanged]): Tell the keyboard to update the candidate view, if needed.
* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::handleInputMethodKeydown): Mark the event as default handled if
the UI process told us that the event was handled by the Input Manager just like we do on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTests under pointerevents/ios are flaky
graouts@webkit.org [Mon, 6 May 2019 20:39:28 +0000 (20:39 +0000)]
Tests under pointerevents/ios are flaky
https://bugs.webkit.org/show_bug.cgi?id=197624

Reviewed by Dean Jackson.

Tests under pointerevents/ios generate touches that use UIScriptController may not succeed if ran in multiple iterations or in a specific
order due to not ensuring that all touches are released when the test completes. We now ensure that we do when running swipes, taps, and pinches.

* pointerevents/ios/pointer-events-dispatch-on-stylus.html: Use the new ui.tapStylus() method to generate a tap with the stylus which ensures all
touches are removed upon completion.
* pointerevents/ios/pointer-events-dispatch-on-touch.html: Use a tap to ensure all touches are removed upon completion.
* pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down.html: Use a tap to ensure all touches are removed upon completion.
* pointerevents/ios/pointer-events-implicit-capture-release-exception.html: Use a tap to ensure all touches are removed upon completion.
* pointerevents/ios/pointer-events-implicit-capture-release.html: Use a tap to ensure all touches are removed upon completion.
* pointerevents/ios/pointer-events-prevent-default-allows-click-event.html: Ensure both the "click" event and the tap generation have succeeded before
marking the test as complete.
* pointerevents/ios/pointer-events-set-pointer-capture-exceptions.html: Use a tap to ensure all touches are removed upon completion.
* pointerevents/ios/touch-action-none-link-traversal.html: Ensure both the "load" event and the tap generation have succeeded before marking the test
as complete.
* pointerevents/ios/touch-action-pan-x-pan-y.html: Remove the requestAnimationFrame() call since ui.swipe() now resolves its promise once all touches
have completed.
* pointerevents/ios/touch-action-pan-x.html: Remove the requestAnimationFrame() call since ui.swipe() now resolves its promise once all touches
have completed.
* pointerevents/ios/touch-action-pan-y.html: Remove the requestAnimationFrame() call since ui.swipe() now resolves its promise once all touches
have completed.
* pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html: Remove the requestAnimationFrame() call since ui.pinchOut() now resolves its promise
once all touches have completed.
* pointerevents/ios/touch-action-pointercancel-pan-x.html: We don't need to track "pointermove" events since dispatch of "pointercancel" is asynchronous
and the number of "pointermove" events prior to its dispatch can legitimately vary.
* pointerevents/ios/touch-action-pointercancel-pan-y.html: We don't need to track "pointermove" events since dispatch of "pointercancel" is asynchronous
and the number of "pointermove" events prior to its dispatch can legitimately vary.
* pointerevents/utils.js:
(const.ui.new.UIController.prototype.swipe): Wait until the swipe is complete before resolving the promise.
(const.ui.new.UIController.prototype.pinchOut): Use a custom sequence to ensure that the pinch releases touches upon completion.
(const.ui.new.UIController.prototype.tapStylus): Introduce this new method to perform a stylus tap which ensures all touches are complete before resolving
the promise.
(const.ui.new.UIController.prototype.beginTouches): Deleted.
(const.ui.new.UIController.prototype.beginStylus): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoJS2 should print scores for different categories
sbarati@apple.com [Mon, 6 May 2019 20:36:40 +0000 (20:36 +0000)]
JS2 should print scores for different categories
https://bugs.webkit.org/show_bug.cgi?id=197605

Reviewed by Yusuke Suzuki.

* JetStream2/JetStreamDriver.js:
(displayCategoryScores):
(isInBrowser.document.onkeydown):
(Driver.prototype.async.start):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[PlayStation] JSC Stress tests failing due to timezone printing
stephan.szabo@sony.com [Mon, 6 May 2019 20:27:53 +0000 (20:27 +0000)]
[PlayStation] JSC Stress tests failing due to timezone printing
https://bugs.webkit.org/show_bug.cgi?id=197615

PlayStation's strftime does not give timezone strings, which
results in time strings like "Wed Oct 23 1974 11:45:01 GMT-0700"
rather than "Wed Oct 23 1974 11:45:01 GMT-0700 (Pacific Daylight Time)"
which causes diff failures with the expectations. Add expectations
without the timezone string and use those on playstation.

Reviewed by Ross Kirsling.

* ChakraCore.yaml: Update these tests to use alternate expectation file on PlayStation
* ChakraCore/test/GlobalFunctions/InternalToString.baseline-jsc-playstation: Added.
* ChakraCore/test/Operators/equals.baseline-jsc-playstation: Added.
* ChakraCore/test/fieldopts/objtypespec-newobj.2.baseline-jsc-playstation: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd assertions to CachedFrame to help figure out crash in CachedFrame constructor
cdumez@apple.com [Mon, 6 May 2019 20:25:27 +0000 (20:25 +0000)]
Add assertions to CachedFrame to help figure out crash in CachedFrame constructor
https://bugs.webkit.org/show_bug.cgi?id=197621

Reviewed by Geoffrey Garen.

Add release assertions to try and figure out who is sometimes detaching the document from its
frame while constructing CachedFrames for its descendants.

* dom/Document.cpp:
(WebCore::Document::detachFromFrame):
* dom/Document.h:
(WebCore::Document::setMayBeDetachedFromFrame):
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoNull check m_mainFrame in WebPageProxy.cpp
commit-queue@webkit.org [Mon, 6 May 2019 20:24:29 +0000 (20:24 +0000)]
Null check m_mainFrame in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=197618
<rdar://problem/47463054>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-05-06
Reviewed by Geoffrey Garen.

It's already null checked in some places, and the places where it isn't are causing crashes.
Let's fix all of them.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::createNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUse more efficient path resolution logic
bfulgham@apple.com [Mon, 6 May 2019 20:14:10 +0000 (20:14 +0000)]
Use more efficient path resolution logic
https://bugs.webkit.org/show_bug.cgi?id=197389
<rdar://problem/50268491>

Reviewed by Maciej Stachowiak.

The code in SandboxExtensionsCocoa.mm 'resolveSymlinksInPath' is pretty inefficient, and tries to reproduce (badly)
logic that is already provided by the operating system.

To make matters worse, 'resolvePathForSandboxExtension' was effectively performing the work of fully resolving
symlinks twice, since NSString's 'stringByStandardizingPath' method does some of this already.

Instead, we should just use NSString's 'stringByResolvingSymlinksInPath', which does the symlink resolution
using more efficient logic than our 'resolveSymlinksInPath' code.

* Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::resolveSymlinksInPath): Removed.
(WebKit::resolvePathForSandboxExtension): Remove redundant call to 'resolveSymlinksInPath', and switches from
'stringByStandardizingPath' to 'stringByResolvingSymlinksInPath', which can take the place of both calls.
(WebKit::stringByResolvingSymlinksInPath): Switch to call 'stringByResolvingSymlinksInPath'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoIntroduce SPI to request modern compatibility mode but defer to site-specific quirks
wenson_hsieh@apple.com [Mon, 6 May 2019 17:50:25 +0000 (17:50 +0000)]
Introduce SPI to request modern compatibility mode but defer to site-specific quirks
https://bugs.webkit.org/show_bug.cgi?id=197614
<rdar://problem/50208577>

Reviewed by Tim Horton.

Add plumbing for a new _allowSiteSpecificQuirksToOverrideCompatibilityMode SPI property on
WKWebpagePreferences.

* UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
* UIProcess/API/APIWebsitePolicies.h:
* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _allowSiteSpecificQuirksToOverrideCompatibilityMode]):
(-[WKWebpagePreferences _setAllowSiteSpecificQuirksToOverrideCompatibilityMode:]):
* UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
* UIProcess/WebPageProxy.cpp:

Use currentRequest instead of originalRequest; see internal change for more details.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoFix typo in https://trac.webkit.org/changeset/244962/webkit
tsavell@apple.com [Mon, 6 May 2019 17:50:15 +0000 (17:50 +0000)]
Fix typo in https://trac.webkit.org/changeset/244962/webkit
https://bugs.webkit.org/show_bug.cgi?id=136627

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed, rolling out r244917.
ryanhaddad@apple.com [Mon, 6 May 2019 17:23:13 +0000 (17:23 +0000)]
Unreviewed, rolling out r244917.

Caused
TestWebKitAPI.WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog
failure on debug bots.

Reverted changeset:

"Use more efficient path resolution logic"
https://bugs.webkit.org/show_bug.cgi?id=197389
https://trac.webkit.org/changeset/244917

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoVersioning.
bshafiei@apple.com [Mon, 6 May 2019 17:07:06 +0000 (17:07 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agomark media/track/track-cue-rendering-vertical.html as failing for Mojave after r24489...
tsavell@apple.com [Mon, 6 May 2019 16:14:05 +0000 (16:14 +0000)]
mark media/track/track-cue-rendering-vertical.html as failing for Mojave after r244891 unmarked it.
https://bugs.webkit.org/show_bug.cgi?id=136627

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[GLib] WebCore::MainThreadSharedTimer should use the appropriate GSource priority...
zandobersek@gmail.com [Mon, 6 May 2019 09:03:48 +0000 (09:03 +0000)]
[GLib] WebCore::MainThreadSharedTimer should use the appropriate GSource priority, name
https://bugs.webkit.org/show_bug.cgi?id=197606

Reviewed by Carlos Garcia Campos.

* platform/MainThreadSharedTimer.cpp:
(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
Use the MainThreadSharedTimer GLib priority for this timer. The name is
also adjusted accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[CMake] fuse-ld should also be set in module linker flags
chris.reid@sony.com [Mon, 6 May 2019 07:54:28 +0000 (07:54 +0000)]
[CMake] fuse-ld should also be set in module linker flags
https://bugs.webkit.org/show_bug.cgi?id=197583

Reviewed by Michael Catanzaro.

Add fuse-ld to CMAKE_MODULE_LINKER_FLAGS.

* Source/cmake/OptionsCommon.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Add more tests for DFG SetLocal emission for adhoc SetterCall frame
ysuzuki@apple.com [Mon, 6 May 2019 07:04:58 +0000 (07:04 +0000)]
[JSC] Add more tests for DFG SetLocal emission for adhoc SetterCall frame
https://bugs.webkit.org/show_bug.cgi?id=197587

Reviewed by Sam Weinig.

This patch adds more tests to r244939. It also inlines setter calls, and eventually see that no PutStack is emitted because MovHint's KillStack kills it.

* stress/adhoc-setter-frame-should-not-be-killed.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agofast/attachment/attachment-folder-icon.html is an Image Only failure on recent macOS...
wenson_hsieh@apple.com [Sun, 5 May 2019 10:45:22 +0000 (10:45 +0000)]
fast/attachment/attachment-folder-icon.html is an Image Only failure on recent macOS builds
https://bugs.webkit.org/show_bug.cgi?id=197593
<rdar://problem/50379267>

Reviewed by Tim Horton.

On recent versions of macOS, -[NSWorkspace iconForFileType:] returns the generic document icon for
"public.directory". Instead of using this UTI to generate attachment icons for "multipart/x-folder" and
"application/vnd.apple.folder", we should instead be using "public.folder", which has a folder icon. This fixes
the existing test fast/attachment/attachment-folder-icon.html, which currently results in an image diff on these
builds of macOS.

* rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoRevert r244953 and r244954 because they broke internal builds.
achristensen@apple.com [Sun, 5 May 2019 04:31:55 +0000 (04:31 +0000)]
Revert r244953 and r244954 because they broke internal builds.
https://bugs.webkit.org/show_bug.cgi?id=197534

Source/WebCore:

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::changeCount const):
(WebCore::PlatformPasteboard::write):

Source/WebCore/PAL:

* pal/spi/ios/UIKitSPI.h:
(currentUserInterfaceIdiomIsPad): Deleted.

Source/WebKit:

* Platform/spi/ios/PDFKitSPI.h:
* Platform/spi/ios/UIKitSPI.h: Added.
(currentUserInterfaceIdiomIsPad):
* Shared/DocumentEditingContext.mm:
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
* Shared/ios/NativeWebKeyboardEventIOS.mm:
* Shared/ios/NativeWebTouchEventIOS.mm:
* Shared/ios/WebIconUtilities.mm:
* UIProcess/API/Cocoa/NSAttributedString.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/ApplicationStateTracker.mm:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
* UIProcess/Cocoa/WKShareSheet.mm:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
* UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
* UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
* UIProcess/WKImagePreviewViewController.mm:
* UIProcess/_WKTouchEventGenerator.mm:
* UIProcess/ios/DragDropInteractionState.h:
* UIProcess/ios/InputViewUpdateDeferrer.mm:
* UIProcess/ios/PageClientImplIOS.mm:
* UIProcess/ios/SmartMagnificationController.mm:
* UIProcess/ios/TextCheckerIOS.mm:
* UIProcess/ios/ViewGestureControllerIOS.mm:
* UIProcess/ios/WKActionSheet.mm:
* UIProcess/ios/WKActionSheetAssistant.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:
* UIProcess/ios/WKKeyboardScrollingAnimator.mm:
* UIProcess/ios/WKPDFPageNumberIndicator.mm:
* UIProcess/ios/WKPDFView.mm:
* UIProcess/ios/WKPasswordView.mm:
* UIProcess/ios/WKScrollView.h:
* UIProcess/ios/WKScrollView.mm:
* UIProcess/ios/WKSyntheticTapGestureRecognizer.h:
* UIProcess/ios/WKWebEvent.mm:
* UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
* UIProcess/ios/WebPageProxyIOS.mm:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
* UIProcess/ios/forms/WKFileUploadPanel.mm:
* UIProcess/ios/forms/WKFocusedFormControlView.h:
* UIProcess/ios/forms/WKFormColorControl.mm:
* UIProcess/ios/forms/WKFormColorPicker.mm:
* UIProcess/ios/forms/WKFormInputControl.mm:
* UIProcess/ios/forms/WKFormPopover.mm:
* UIProcess/ios/forms/WKFormSelectControl.h:
* UIProcess/ios/forms/WKFormSelectControl.mm:
* UIProcess/ios/forms/WKFormSelectPicker.mm:
* UIProcess/ios/forms/WKFormSelectPopover.mm:
* UIProcess/ios/forms/WKNumberPadViewController.mm:
* UIProcess/ios/forms/WKQuickboardListViewController.h:
* UIProcess/ios/forms/WKSelectMenuListViewController.mm:
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
* UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
* WebProcess/WebPage/ios/WebPageIOS.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:

Tools:

* DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
* DumpRenderTree/mac/DumpRenderTree.mm:
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
* TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
* TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
* TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
* TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
* TestWebKitAPI/cocoa/DragAndDropSimulator.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
* TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
* TestWebKitAPI/ios/UIKitSPI.h: Added.
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
* WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
* WebKitTestRunner/ios/HIDEventGenerator.h:
* WebKitTestRunner/ios/HIDEventGenerator.mm:
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
* WebKitTestRunner/ios/TestControllerIOS.mm:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
* WebKitTestRunner/ios/mainIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoFix internal build.
achristensen@apple.com [Sun, 5 May 2019 03:29:16 +0000 (03:29 +0000)]
Fix internal build.
https://bugs.webkit.org/show_bug.cgi?id=197534

* pal/spi/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMerge the three UIKitSPI.h files into a single one in PAL
achristensen@apple.com [Sun, 5 May 2019 03:01:51 +0000 (03:01 +0000)]
Merge the three UIKitSPI.h files into a single one in PAL
https://bugs.webkit.org/show_bug.cgi?id=197534

Reviewed by Darin Adler.

Source/WebCore:

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::changeCount const):
(WebCore::PlatformPasteboard::write):

Source/WebCore/PAL:

* pal/spi/ios/UIKitSPI.h:
(currentUserInterfaceIdiomIsPad):

Source/WebKit:

* Platform/spi/ios/PDFKitSPI.h:
* Platform/spi/ios/UIKitSPI.h: Removed.
* Shared/DocumentEditingContext.mm:
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
* Shared/ios/NativeWebKeyboardEventIOS.mm:
* Shared/ios/NativeWebTouchEventIOS.mm:
* Shared/ios/WebIconUtilities.mm:
* UIProcess/API/Cocoa/NSAttributedString.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/ApplicationStateTracker.mm:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
* UIProcess/Cocoa/WKShareSheet.mm:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
* UIProcess/Gamepad/ios/UIGamepadProviderIOS.mm:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
* UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
* UIProcess/WKImagePreviewViewController.mm:
* UIProcess/_WKTouchEventGenerator.mm:
* UIProcess/ios/DragDropInteractionState.h:
* UIProcess/ios/InputViewUpdateDeferrer.mm:
* UIProcess/ios/PageClientImplIOS.mm:
* UIProcess/ios/SmartMagnificationController.mm:
* UIProcess/ios/TextCheckerIOS.mm:
* UIProcess/ios/ViewGestureControllerIOS.mm:
* UIProcess/ios/WKActionSheet.mm:
* UIProcess/ios/WKActionSheetAssistant.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:
* UIProcess/ios/WKKeyboardScrollingAnimator.mm:
* UIProcess/ios/WKPDFPageNumberIndicator.mm:
* UIProcess/ios/WKPDFView.mm:
* UIProcess/ios/WKPasswordView.mm:
* UIProcess/ios/WKScrollView.h:
* UIProcess/ios/WKScrollView.mm:
* UIProcess/ios/WKSyntheticTapGestureRecognizer.h:
* UIProcess/ios/WKWebEvent.mm:
* UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
* UIProcess/ios/WebPageProxyIOS.mm:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
* UIProcess/ios/forms/WKFileUploadPanel.mm:
* UIProcess/ios/forms/WKFocusedFormControlView.h:
* UIProcess/ios/forms/WKFormColorControl.mm:
* UIProcess/ios/forms/WKFormColorPicker.mm:
* UIProcess/ios/forms/WKFormInputControl.mm:
* UIProcess/ios/forms/WKFormPopover.mm:
* UIProcess/ios/forms/WKFormSelectControl.h:
* UIProcess/ios/forms/WKFormSelectControl.mm:
* UIProcess/ios/forms/WKFormSelectPicker.mm:
* UIProcess/ios/forms/WKFormSelectPopover.mm:
* UIProcess/ios/forms/WKNumberPadViewController.mm:
* UIProcess/ios/forms/WKQuickboardListViewController.h:
* UIProcess/ios/forms/WKSelectMenuListViewController.mm:
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
* UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
* WebProcess/WebPage/ios/WebPageIOS.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:

Tools:

* DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
* DumpRenderTree/mac/DumpRenderTree.mm:
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
* TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
* TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
* TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
* TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
* TestWebKitAPI/cocoa/DragAndDropSimulator.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
* TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
* TestWebKitAPI/ios/UIKitSPI.h: Removed.
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
* WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
* WebKitTestRunner/ios/HIDEventGenerator.h:
* WebKitTestRunner/ios/HIDEventGenerator.mm:
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
* WebKitTestRunner/ios/TestControllerIOS.mm:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
* WebKitTestRunner/ios/mainIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: Provide UIString descriptions to improve localizations
nvasilyev@apple.com [Sun, 5 May 2019 01:31:10 +0000 (01:31 +0000)]
Web Inspector: Provide UIString descriptions to improve localizations
https://bugs.webkit.org/show_bug.cgi?id=195132
<rdar://problem/48457817>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/LoadLocalizedStrings.js:
(WI.UIString):
(WI.repeatedUIString.timelineRecordLayout):
(WI.repeatedUIString.timelineRecordPaint):
(WI.repeatedUIString.timelineRecordComposite):
(WI.repeatedUIString.allExceptions):
(WI.repeatedUIString.uncaughtExceptions):
(WI.repeatedUIString.assertionFailures):
(WI.repeatedUIString.allRequests):
(WI.repeatedUIString.fetch):
(WI.repeatedUIString.revealInDOMTree):
* UserInterface/Models/LayoutTimelineRecord.js:
(WI.LayoutTimelineRecord.displayNameForEventType):
* UserInterface/Models/RenderingFrameTimelineRecord.js:
(WI.RenderingFrameTimelineRecord.displayNameForTaskType):
* UserInterface/Models/Resource.js:
(WI.Resource.displayNameForType):
* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.layout):
* UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.displayNameForSampleType):
* UserInterface/Views/ContextMenuUtilities.js:
* UserInterface/Views/DOMBreakpointTreeElement.js:
(WI.DOMBreakpointTreeElement.displayNameForType):
* UserInterface/Views/DOMNodeTreeElement.js:
(WI.DOMNodeTreeElement.prototype.populateContextMenu):
(WI.DOMNodeTreeElement):
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype._populateTagContextMenu):
(WI.DOMTreeElement.prototype._populateNodeContextMenu):
* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._addBreakpoint):
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointMouseDown):
(WI.DebuggerSidebarPanel):
* UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WI.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.shortDisplayNameForResourceType):
(WI.NetworkTableContentView.prototype.initialLayout):
* UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._handleCreateBreakpointMouseDown):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderSelector):
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout):

Tools:

Allow WI.UIString to take:
- WI.UIString(string, key, comment)
- WI.UIString(string, comment)
- WI.UIString(string)

* Scripts/extract-localizable-js-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: Styles: use the same green color for modified properties as in Changes...
nvasilyev@apple.com [Sun, 5 May 2019 01:01:56 +0000 (01:01 +0000)]
Web Inspector: Styles: use the same green color for modified properties as in Changes panel
https://bugs.webkit.org/show_bug.cgi?id=197538

Reviewed by Timothy Hatcher.

* UserInterface/Views/ChangesDetailsSidebarPanel.css:
(.changes-panel .css-property-line.added):
(.changes-panel .css-property-line.removed):
(.changes-panel .css-property-line.added::before):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property.modified):
(.spreadsheet-style-declaration-editor .property.modified:not(.selected)):
(@media (prefers-color-scheme: dark)):
* UserInterface/Views/Variables.css:
(:root):
(@media (prefers-color-scheme: dark)):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTypedArrays should not store properties that are canonical numeric indices
tzagallo@apple.com [Sat, 4 May 2019 19:12:31 +0000 (19:12 +0000)]
TypedArrays should not store properties that are canonical numeric indices
https://bugs.webkit.org/show_bug.cgi?id=197228
<rdar://problem/49557381>

Reviewed by Saam Barati.

JSTests:

* stress/array-species-config-array-constructor.js:
(test):
* stress/put-direct-index-broken-2.js:
* stress/typed-array-canonical-numeric-index-string.js: Added.
(makeTest.assert):
(makeTest):
(const.testInvalidIndices.makeTest.set assert):
(const.testInvalidIndices.makeTest):
(const.makeTestValidIndex.configurable.set assert):
(const.makeTestValidIndex.configurable):
* stress/typedarray-access-monomorphic-neutered.js:
(checkNoException):
(testNoException):
(testFTLNoException):
* stress/typedarray-access-neutered.js:
(testNoException):
* stress/typedarray-getownproperty-not-configurable.js:
(foo):
* test262/expectations.yaml:

Source/JavaScriptCore:

According to the spec[1]:
- TypedArrays should not perform an ordinary GetOwnProperty/SetOwnProperty if the index is a
CanonicalNumericIndexString, but invalid according to IntegerIndexedElementGet and similar
functions. I.e., there are a few properties that should not be set in a TypedArray, like NaN,
Infinity and -0.
- On DefineOwnProperty, the out-of-bounds check should be performed before validating the property
descriptor.
- On GetOwnProperty, the returned descriptor for numeric properties should have writable set to true.

[1]: https://www.ecma-international.org/ecma-262/9.0/index.html#sec-integer-indexed-exotic-objects-defineownproperty-p-desc

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex):
* runtime/PropertyName.h:
(JSC::isCanonicalNumericIndexString):

LayoutTests:

* fast/canvas/canvas-ImageData-behaviour-expected.txt:
* fast/canvas/canvas-ImageData-behaviour.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoConvert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
youenn@apple.com [Sat, 4 May 2019 17:51:12 +0000 (17:51 +0000)]
Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
https://bugs.webkit.org/show_bug.cgi?id=197549

Reviewed by Eric Carlson.

No change of behavior.

* platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[Win10] Some tests are failing only on specific machines
pvollan@apple.com [Sat, 4 May 2019 15:11:49 +0000 (15:11 +0000)]
[Win10] Some tests are failing only on specific machines
https://bugs.webkit.org/show_bug.cgi?id=197509

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[macOS] Fix programmatic scrolling with async overflow scroll
simon.fraser@apple.com [Sat, 4 May 2019 06:58:40 +0000 (06:58 +0000)]
[macOS] Fix programmatic scrolling with async overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=197590

Reviewed by Sam Weinig.
Source/WebCore:

ScrollingTreeOverflowScrollingNodeMac needs to handle RequestedScrollPosition.

Tests: scrollingcoordinator/mac/programmatic-frame-scroll.html
       scrollingcoordinator/mac/programmatic-overflow-scroll.html

* page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:
(WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren):

LayoutTests:

Tests for programmatic scrolling of overflow and iframes.

* scrollingcoordinator/mac/programmatic-frame-scroll-expected.html: Added.
* scrollingcoordinator/mac/programmatic-frame-scroll.html: Added.
* scrollingcoordinator/mac/programmatic-overflow-scroll-expected.html: Added.
* scrollingcoordinator/mac/programmatic-overflow-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: DOM: dragging a node to the console should log the node
drousso@apple.com [Sat, 4 May 2019 02:45:08 +0000 (02:45 +0000)]
Web Inspector: DOM: dragging a node to the console should log the node
https://bugs.webkit.org/show_bug.cgi?id=197330

Reviewed by Timothy Hatcher.

* UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype._ondragstart):
* UserInterface/Views/LogContentView.js:
(WI.LogContentView):
(WI.LogContentView.prototype._handleDragOver): Added.
(WI.LogContentView.prototype._handleDrop): Added.
* UserInterface/Views/QuickConsole.js:
(WI.QuickConsole):
(WI.QuickConsole.prototype._handleDragOver): Added.
(WI.QuickConsole.prototype._handleDrop): Added.

* UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
Drive-by: update the format to be more unique.
* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION (r244897): Caret may appear wider than normal after zooming to focus an...
wenson_hsieh@apple.com [Sat, 4 May 2019 02:40:29 +0000 (02:40 +0000)]
REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
https://bugs.webkit.org/show_bug.cgi?id=197579

Reviewed by Tim Horton.

Source/WebKit:

Fixes a couple of flaky tests (CaretSelectionRectAfterRestoringFirstResponderWithRetainActiveFocusedState and
CaretSelectionRectAfterRestoringFirstResponder) that began failing after r244897. These tests both begin by
focusing an editable element, which causes the web view to zoom in. The tests subsequently check that the caret
rect is {{ 16, 13 }, { 2, 15 }}. While the specified caret rect (coming from EditorState) is {{ 16, 13 }, { 3,
15 }}, the narrower caret rect is used because we take measures to preserve the width of the caret relative to
the view (see the inverse scaling logic in -[WKContentView selectedTextRange] for more details).

See below for more details.

* UIProcess/ios/WKContentViewInteraction.h:

Remove _isZoomingToRevealFocusedElement, now that we don't need it anymore (see -observeValueForKeyPath:).

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView observeValueForKeyPath:ofObject:change:context:]):

Stop bailing from a selection update when changing scale, while zooming to reveal the focused element. This
check was added in r239441 to prevent UIWKTextInteractionAssistant's selection scrolling logic from interfering
with WKContentView-driven logic for zooming to the focused element. However, since r244141, this is no longer
necessary since selection scrolling is only driven by code in the web process.

This new update while zooming to reveal the focused element ensures that the WKTextRange returned by
-selectedTextRange after zooming will have a width that is inversely scaled using the content view's current
scale, such that it has a consistent width (relative to the web view) across different scales.

(-[WKContentView _zoomToRevealFocusedElement]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::layerTreeCommitComplete):

Remove any attempt here to notify PageClient about editor states after focus. This logic was actually incorrect,
since it didn't ensure that the layer tree commit that is being completed actually contained an editor state; as
such, the "editor state" received here could be stale.

Tools:

Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
ensure that the the focused element has been blurred.

* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[iOS] outlook.live.com: Compose email frame not fully visible and not scrollable
zalan@apple.com [Sat, 4 May 2019 02:25:03 +0000 (02:25 +0000)]
[iOS] outlook.live.com: Compose email frame not fully visible and not scrollable
https://bugs.webkit.org/show_bug.cgi?id=197573
<rdar://problem/48008441>

Reviewed by Wenson Hsieh.

Source/WebCore:

The outlook mail view's flex column setup produces a somewhat unfortunate layout at certain viewport widths.
This patch addresses the issue by ensuring that we never fall into that range.

* page/Quirks.cpp:
(WebCore::Quirks::shouldIgnoreShrinkToFitContent const):
(WebCore::Quirks::overriddenViewportLayoutWidth const):
* page/Quirks.h:

Source/WebKit:

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::adjustLayoutSizeIfNeeded):
(WebKit::WebPage::setViewportConfigurationViewLayoutSize):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::immediatelyShrinkToFitContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd a tool to block spammer accounts
ap@apple.com [Sat, 4 May 2019 01:33:24 +0000 (01:33 +0000)]
Add a tool to block spammer accounts
https://bugs.webkit.org/show_bug.cgi?id=197537

Reviewed by Darin Adler.

Usage: block-spammers email1 email2 ...

The tool finds and hides all bugs and comments from this account. Before any work
is done, these bugs and comments are displayed for confirmation.

* Scripts/block-spammers: Added.
(get_bugzilla_token):
(invalidate_bugzilla_token):
(get_user_info):
(get_user_info_self):
(can_use_this_tool):
(disable_user):
(get_bugs_created_by_user):
(get_bugs_commented_on_by_user):
(get_comments):
(hide_bug):
(hide_comments):
(ask_yes_no):
(sanitized_string):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agorun-apit-tests: Add --iterations and --repeat-each
jbedard@apple.com [Sat, 4 May 2019 01:03:20 +0000 (01:03 +0000)]
run-apit-tests: Add --iterations and --repeat-each
https://bugs.webkit.org/show_bug.cgi?id=197563

Reviewed by Aakash Jain.

* Scripts/webkitpy/api_tests/manager.py:
(Manager.run): Add --iterations and --repeat-each/
* Scripts/webkitpy/api_tests/run_api_tests.py:
(parse_args): Duplicate the test list based on --iterations and --repeat-each.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMake imageForElementActionType a class method on _WKElementAction
dino@apple.com [Sat, 4 May 2019 01:01:49 +0000 (01:01 +0000)]
Make imageForElementActionType a class method on _WKElementAction
https://bugs.webkit.org/show_bug.cgi?id=197588
<rdar://problem/50463157>

Reviewed by Wenson Hsieh.

Make this helper function a class method, so that it can
be more easily detected.

* UIProcess/API/Cocoa/_WKElementAction.h:
* UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction imageForElementActionType:]):
(_WKUIImageForElementActionType): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoNew EWS: Clicking on white bubble navigates to page with only bubbles
aakash_jain@apple.com [Sat, 4 May 2019 00:17:25 +0000 (00:17 +0000)]
New EWS: Clicking on white bubble navigates to page with only bubbles
https://bugs.webkit.org/show_bug.cgi?id=197520

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
ysuzuki@apple.com [Fri, 3 May 2019 23:57:21 +0000 (23:57 +0000)]
[JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
https://bugs.webkit.org/show_bug.cgi?id=197584

Reviewed by Saam Barati.

JSTests:

* stress/adhoc-setter-frame-should-emit-setlocal-again.js: Added.
(X):
(foo):

Source/JavaScriptCore:

In r244864, we emit MovHint for adhocly created GetterCall/SetterCall frame locals in the callee side to make OSR availability analysis's pruning correct.
However, we just emit MovHint, and we do not emit SetLocal since we ensured that these locals are already flushed in the same place before. However, MovHint
and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack
just before MovHint's target location even if the MovHint's target is the same to the previously emitted MovHint and SetLocal.
This patch emits SetLocal too when emitting MovHint for GetterCall/SetterCall frame locals.

The example is like this.

    a:  SomeValueNode
     :  MovHint(@a, loc10)
    b:  SetLocal(@a, loc10)
        ...
    c:  MovHint(@a, loc10)

Then, this will be converted to the style in SSA conversion.

    a:  SomeValueNode
     :  KillStack(loc10)
    b:  PutStack(@a, loc10)
        ...
    c:  KillStack(loc10)

Then, @b will be removed later since @c kills it.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inlineCall):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::Handle::stopAllocating):
(JSC::MarkedBlock::Handle::resumeAllocating):
(JSC::MarkedBlock::aboutToMarkSlow):
(JSC::MarkedBlock::Handle::didConsumeFreeList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[WebAuthN] A focused document should be required
jiewen_tan@apple.com [Fri, 3 May 2019 23:41:36 +0000 (23:41 +0000)]
[WebAuthN] A focused document should be required
https://bugs.webkit.org/show_bug.cgi?id=197543
<rdar://problem/50430989>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch adds a check to see if the invoking document is focused before
calling into WebAuthN. This patch also removes some out-to-dated comments.

Test: http/wpt/webauthn/public-key-credential-unfocused-document.https.html

* Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):
* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):

LayoutTests:

* http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
* http/wpt/webauthn/public-key-credential-unfocused-document.https-expected.txt: Added.
* http/wpt/webauthn/public-key-credential-unfocused-document.https.html: Copied from LayoutTests/http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html.
* http/wpt/webauthn/resources/last-layer-frame.https.html:
* http/wpt/webauthn/resources/second-layer-frame.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoiOS JSC tests frequently exiting with execption after stress/json-stringify-string...
msaboff@apple.com [Fri, 3 May 2019 23:34:52 +0000 (23:34 +0000)]
iOS JSC tests frequently exiting with execption after stress/json-stringify-string-builder-overflow.js.no-cjit-validate-phases
https://bugs.webkit.org/show_bug.cgi?id=197586

Reviewed by Keith Miller.

We should only run one config of this test and only when we think we'll have the memory.

* stress/json-stringify-string-builder-overflow.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnresponsive Service Worker processes should get killed
cdumez@apple.com [Fri, 3 May 2019 23:23:55 +0000 (23:23 +0000)]
Unresponsive Service Worker processes should get killed
https://bugs.webkit.org/show_bug.cgi?id=197580
<rdar://problem/50458239>

Reviewed by Geoffrey Garen.

Enable the background responsiveness logic for service worker processes so that they get
killed if they becomes unresponsive. The logic was previously not enabling the timer for
service worker processes because it required having a page.

* UIProcess/BackgroundProcessResponsivenessTimer.cpp:
(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive const):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::didFinishLaunching):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[iOS] set the default maximum camera count to 1 for enumerateDevices
youenn@apple.com [Fri, 3 May 2019 23:13:31 +0000 (23:13 +0000)]
[iOS] set the default maximum camera count to 1 for enumerateDevices
https://bugs.webkit.org/show_bug.cgi?id=197566

Reviewed by Eric Carlson.

Source/WebKit:

The previous number for iOS was 2 as there is a front and a back camera.
Since we are by default setting deviceIds to "", it is better to just have one,
as it might confuse applications to have two devices with the same ID.

Covered by updated test.

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):

LayoutTests:

* fast/mediastream/get-user-media-device-id.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[lldb-webkit] Support adding pretty-printing for qualified types
dbates@webkit.org [Fri, 3 May 2019 23:13:30 +0000 (23:13 +0000)]
[lldb-webkit] Support adding pretty-printing for qualified types
https://bugs.webkit.org/show_bug.cgi?id=197518

Reviewed by Darin Adler.

Remove all "::"s from the name of the specified type when computing the name for the Python classes
that will provide summary and synthetic details as LLDB is not happy about registering such classes
when they contain :: in their name.

* lldb/lldb_webkit.py:
(addSummaryAndSyntheticFormattersForRawBitmaskType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: DOM: rename "low power" to "display composited"
drousso@apple.com [Fri, 3 May 2019 23:08:19 +0000 (23:08 +0000)]
Web Inspector: DOM: rename "low power" to "display composited"
https://bugs.webkit.org/show_bug.cgi?id=197296

Reviewed by Joseph Pecoraro.

Removed specific ChangeLog entries since it is almost entirely mechanical changes.

Source/JavaScriptCore:

* inspector/protocol/DOM.json:

Source/WebCore:

* inspector/agents/InspectorDOMAgent.h:
* inspector/agents/InspectorDOMAgent.cpp:

Source/WebInspectorUI:

* UserInterface/Protocol/DOMObserver.js:
* UserInterface/Controllers/DOMManager.js:
* UserInterface/Controllers/TimelineManager.js:
* UserInterface/Models/DOMNode.js:
* UserInterface/Models/MediaInstrument.js:
* UserInterface/Models/MediaTimelineRecord.js:
* UserInterface/Models/TimelineRecording.js:
* UserInterface/Views/DOMEventsBreakdownView.js:
* UserInterface/Views/DOMEventsBreakdownView.css:
* UserInterface/Views/NetworkTableContentView.js:
* UserInterface/Views/NetworkTableContentView.css:
* UserInterface/Views/TimelineIcons.css:
* UserInterface/Views/TimelineTabContentView.js:
* UserInterface/Images/PowerEfficientPlaybackStateChanged.svg: Added.
* UserInterface/Images/LowPower.svg: Removed.
* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoPass KeyboardEvent by reference in more places
dbates@webkit.org [Fri, 3 May 2019 23:04:09 +0000 (23:04 +0000)]
Pass KeyboardEvent by reference in more places
https://bugs.webkit.org/show_bug.cgi?id=197480

Reviewed by Wenson Hsieh.

Source/WebCore:

* editing/Editor.cpp:
(WebCore::Editor::handleKeyboardEvent):
(WebCore::Editor::handleInputMethodKeydown):
* loader/EmptyClients.cpp:
* page/EditorClient.h:

Source/WebKit:

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleEditingKeyboardEvent):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleEditingKeyboardEvent):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleKeyboardEvent):
(WebEditorClient::handleInputMethodKeydown):

Source/WebKitLegacy/win:

* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::handleKeyboardEvent):
(WebEditorClient::handleInputMethodKeydown):
* WebCoreSupport/WebEditorClient.h:
* WebView.cpp:
(WebView::handleEditingKeyboardEvent):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoEnable Fetch Keep Alive by default
youenn@apple.com [Fri, 3 May 2019 22:43:03 +0000 (22:43 +0000)]
Enable Fetch Keep Alive by default
https://bugs.webkit.org/show_bug.cgi?id=197331

Reviewed by Geoffrey Garen.

* Shared/WebPreferences.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoNew EWS: patches on recently added queues listed as #1 for older bugs
aakash_jain@apple.com [Fri, 3 May 2019 22:06:57 +0000 (22:06 +0000)]
New EWS: patches on recently added queues listed as #1 for older bugs
https://bugs.webkit.org/show_bug.cgi?id=197496

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble):
(StatusBubble._queue_position):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[iOS Sim Debug] ASSERTION FAILED The atomic string comes from an other thread! Layout...
cdumez@apple.com [Fri, 3 May 2019 22:03:20 +0000 (22:03 +0000)]
[iOS Sim Debug] ASSERTION FAILED The atomic string comes from an other thread! Layout Test imported/w3c/web-platform-tests/workers/WorkerNavigator_appName.htm is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=197530
<rdar://problem/50448285>

Reviewed by Geoffrey Garen.

The issue is that NavigatorBase::platform() was not thread safe but was called by both Navigator on
the main thread and WorkerNavigator on worker threads.

No new tests, covered by existing tests.

* page/Navigator.cpp:
(WebCore::Navigator::platform const):
* page/Navigator.h:

* page/NavigatorBase.cpp:
(WebCore::NavigatorBase::platform const):
* page/NavigatorBase.h:
Make NavigatorBase::platform() thread safe.

* platform/ios/Device.cpp:
(WebCore::deviceName):
* platform/ios/Device.h:
Make WebCore::deviceName() thread safe.

* platform/ios/UserAgentIOS.mm:
(WebCore::deviceNameForUserAgent):
Cache value returned by WebCore::deviceName() for performance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUse WeakPtr for JSLazyEventListener::m_originalNode for safety
cdumez@apple.com [Fri, 3 May 2019 22:01:13 +0000 (22:01 +0000)]
Use WeakPtr for JSLazyEventListener::m_originalNode for safety
https://bugs.webkit.org/show_bug.cgi?id=197576
<rdar://problem/24314027>

Reviewed by Alex Christensen.

* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::create):
* bindings/js/JSLazyEventListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION(r230367): a "." is prepended before cookies set without an explicit domain
drousso@apple.com [Fri, 3 May 2019 21:59:09 +0000 (21:59 +0000)]
REGRESSION(r230367): a "." is prepended before cookies set without an explicit domain
https://bugs.webkit.org/show_bug.cgi?id=197268
<rdar://problem/49767847>

Reviewed by Alex Christensen.

RFC 2965 states "If an explicitly specified value does not start with a dot, the user agent
supplies a leading dot.", so we should only be adding a leading "." if a `domain` is provided.

In order to not regress r230367, also delete all cookies for the non-"."-prefixed domain.

* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteCookiesForHostnames): Added.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Deleted.
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerDeleteCookiesForHostname):
* NetworkProcess/Cookies/WebCookieManager.messages.in:
* NetworkProcess/Cookies/WebCookieManager.h:
* NetworkProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteCookiesForHostnames): Added.
(WebKit::WebCookieManager::deleteCookiesForHostname): Deleted.
Since the underlying `NetworkStorageSession` accepts a list of domains, extend that support
to allow the IPC to send a list of domains as well, but still keep the C API the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agowebkit-patch --no-review upload does not submit patch to New EWS
aakash_jain@apple.com [Fri, 3 May 2019 21:58:25 +0000 (21:58 +0000)]
webkit-patch --no-review upload does not submit patch to New EWS
https://bugs.webkit.org/show_bug.cgi?id=197519
<rdar://problem/50424887>

Reviewed by Lucas Forschler.

* Scripts/webkitpy/tool/steps/submittoews.py:
(SubmitToEWS.run): Submit to both old and new EWS.
* Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
* Scripts/webkitpy/common/net/ewsserver.py: Added.
(EWSServer._server_url): Method to return server url.
(EWSServer._post_patch_to_ews): Method to post patch to ews.
(EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
* Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
* Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
* Scripts/webkitpy/common/net/statusserver_mock.py:
(MockStatusServer.submit_to_ews): Updated the log text.
* Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
* Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
* Scripts/webkitpy/tool/main.py:
(WebKitPatch.__init__): Initialize ews_server.
* Scripts/webkitpy/tool/mocktool.py:
(MockTool.__init__): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAVFoundation framework isn't always installed
eric.carlson@apple.com [Fri, 3 May 2019 21:47:37 +0000 (21:47 +0000)]
AVFoundation framework isn't always installed
https://bugs.webkit.org/show_bug.cgi?id=197577
<rdar://problem/50447841>

Reviewed by Jer Noble.

Use PAL::isAVFoundationFrameworkAvailable() to check to see if AVFoundation is
installed, not PAL::AVFoundationLibrary().

* platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:
(WebCore::AVFoundationMIMETypeCache::isAvailable const):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
* platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:
(WebCore::validateHEVCParameters):
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::isAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd assertion to check whether shm files have maximum FileProtection of CompleteUnles...
sihui_liu@apple.com [Fri, 3 May 2019 21:24:06 +0000 (21:24 +0000)]
Add assertion to check whether shm files have maximum FileProtection of CompleteUnlessOpen
https://bugs.webkit.org/show_bug.cgi?id=197390
<rdar://problem/42685773>

Reviewed by Geoffrey Garen.

Source/WebCore:

We have seen crashes about accessing database files after device is locked. We are suspecting this is because
shm files have wrong data protection class, but shm files should not have Complete class protection when it
is created. It is likely the protection class is changed later. Add an assertion to verify our guess. If the
crash signature changes after this patch, we probably need to change database implementation. If it is not, we
have other problem than data protection.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):

Source/WebKit:

Move data protection check to WebCore so it can be applied to database files.

* NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
(WebKit::NetworkCache::BlobStorage::add):
* NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::makeSafeToUseMemoryMapForPath): Deleted.
* NetworkProcess/cache/NetworkCacheFileSystem.h:
* NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm: Removed.
* SourcesCocoa.txt:
* UIProcess/API/APIContentRuleListStore.cpp:
(API::openAndMapOrCopyContentRuleList):
(API::compiledToFile):

Source/WTF:

* wtf/FileSystem.cpp:
(WTF::FileSystemImpl::isSafeToUseMemoryMapForPath):
(WTF::FileSystemImpl::makeSafeToUseMemoryMapForPath):
* wtf/FileSystem.h:
* wtf/cocoa/FileSystemCocoa.mm:
(WTF::FileSystemImpl::isSafeToUseMemoryMapForPath):
(WTF::FileSystemImpl::makeSafeToUseMemoryMapForPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
cdumez@apple.com [Fri, 3 May 2019 21:22:30 +0000 (21:22 +0000)]
ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
https://bugs.webkit.org/show_bug.cgi?id=197574
<rdar://problem/50453181>

Reviewed by Tim Horton.

Source/WebKit:

Tweak the assertion so that it holds even if the WebView gets closed because the completion
handler has been called.

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::prepareForMoveToWindow):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[WinCairo] Implement and enable RemoteInspector Server.
Basuke.Suzuki@sony.com [Fri, 3 May 2019 21:03:34 +0000 (21:03 +0000)]
[WinCairo] Implement and enable RemoteInspector Server.
https://bugs.webkit.org/show_bug.cgi?id=197432

Reviewed by Ross Kirsling.

.:

Add new build flag USE_INSPECTOR_SOCKET_SERVER to indicate using Socket implementation for RemoteInspector
protocol. Currently PlayStation is the only platform which uses this. WinCairo is the second one.

* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/JavaScriptCore:

Implement Windows implementation for Socket Backend of RemoteInspector and enable it on WinCairo
for experimental feature.

Also add listener interface for connection between RemoteInspector and RemoteInspectorServer
for flexible configuration.

* PlatformWin.cmake:
* inspector/remote/RemoteInspector.h:
* inspector/remote/socket/RemoteInspectorConnectionClient.h:
(Inspector::RemoteInspectorConnectionClient::didAccept):
* inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::connect):
(Inspector::RemoteInspectorServer::listenForTargets):
(Inspector::RemoteInspectorServer::didAccept):
(Inspector::RemoteInspectorServer::dispatchMap):
(Inspector::RemoteInspectorServer::start):
(Inspector::RemoteInspectorServer::addServerConnection): Deleted.
* inspector/remote/socket/RemoteInspectorServer.h:
(Inspector::RemoteInspectorServer::RemoteInspectorServer):
* inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::dispatchMap):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::setServerPort):
* inspector/remote/socket/RemoteInspectorSocket.h:
* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::listenInet):
(Inspector::RemoteInspectorSocketEndpoint::getPort const):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):
* inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
* inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
(Inspector::Socket::init): Added.
(Inspector::Socket::listen): Signature changed.
(Inspector::Socket::getPort): Added.
* inspector/remote/socket/win/RemoteInspectorSocketWin.cpp: Added.
(Inspector::Socket::init):
(Inspector::Socket::Socket::Socket):
(Inspector::Socket::Socket::~Socket):
(Inspector::Socket::Socket::close):
(Inspector::Socket::Socket::operator PlatformSocketType const):
(Inspector::Socket::Socket::operator bool const):
(Inspector::Socket::Socket::leak):
(Inspector::Socket::Socket::create):
(Inspector::Socket::setOpt):
(Inspector::Socket::setOptEnabled):
(Inspector::Socket::enableOpt):
(Inspector::Socket::connectTo):
(Inspector::Socket::bindAndListen):
(Inspector::Socket::connect):
(Inspector::Socket::listen):
(Inspector::Socket::accept):
(Inspector::Socket::createPair):
(Inspector::Socket::setup):
(Inspector::Socket::isValid):
(Inspector::Socket::isListening):
(Inspector::Socket::getPort):
(Inspector::Socket::read):
(Inspector::Socket::write):
(Inspector::Socket::close):
(Inspector::Socket::preparePolling):
(Inspector::Socket::poll):
(Inspector::Socket::isReadable):
(Inspector::Socket::isWritable):
(Inspector::Socket::markWaitingWritable):
(Inspector::Socket::clearWaitingWritable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoCache.add and Cache.addAll should compute a correct response body size
youenn@apple.com [Fri, 3 May 2019 20:36:39 +0000 (20:36 +0000)]
Cache.add and Cache.addAll should compute a correct response body size
https://bugs.webkit.org/show_bug.cgi?id=197464

Reviewed by Chris Dumez.

Source/WebCore:

Compute the response body size as we do for regular Cache.put

Test: http/wpt/cache-storage/cache-quota-add.any.html

* Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::computeRecordBodySize):
* Modules/cache/CacheStorageConnection.h:
* Modules/cache/DOMCache.cpp:
(WebCore::FetchTasksHandler::addResponseBody):
(WebCore::DOMCache::addAll):
Compute the response body size requires getting access to the connection.
'this' is added to the lambda which is fine since taskHandler keeps a
Ref to 'this' in its completion handler.
(WebCore::DOMCache::toConnectionRecord):
* Modules/fetch/FetchResponse.h:

LayoutTests:

* http/wpt/cache-storage/cache-quota-add.any-expected.txt: Added.
* http/wpt/cache-storage/cache-quota-add.any.html: Added.
* http/wpt/cache-storage/cache-quota-add.any.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUse more efficient path resolution logic
bfulgham@apple.com [Fri, 3 May 2019 19:42:53 +0000 (19:42 +0000)]
Use more efficient path resolution logic
https://bugs.webkit.org/show_bug.cgi?id=197389
<rdar://problem/50268491>

Reviewed by Maciej Stachowiak.

The code in SandboxExtensionsCocoa.mm 'resolveSymlinksInPath' is pretty inefficient, and tries to reproduce (badly)
logic that is already provided by the operating system.

To make matters worse, 'resolvePathForSandboxExtension' was effectively performing the work of fully resolving
symlinks twice, since NSString's 'stringByStandardizingPath' method does some of this already.

Instead, we should just use NSString's 'stringByResolvingSymlinksInPath', which does the symlink resolution
using more efficient logic than our 'resolveSymlinksInPath' code.

* Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::resolveSymlinksInPath): Removed.
(WebKit::resolvePathForSandboxExtension): Remove redundant call to 'resolveSymlinksInPath', and switches from
'stringByStandardizingPath' to 'stringByResolvingSymlinksInPath', which can take the place of both calls.
(WebKit::stringByResolvingSymlinksInPath): Switch to call 'stringByResolvingSymlinksInPath'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoNeed additional UIPreviewAction information in WKImagePreviewViewController
dino@apple.com [Fri, 3 May 2019 19:35:00 +0000 (19:35 +0000)]
Need additional UIPreviewAction information in WKImagePreviewViewController
https://bugs.webkit.org/show_bug.cgi?id=197540
<rdar://problem/50430510>

Reviewed by Wenson Hsieh.

Include a WebKitAdditions file to provide a macro for
additional UIPreviewAction information.

While here, take the opportunity to move from the deprecated
UIViewControllerPreviewAction to the newer UIPreviewAction.

* UIProcess/WKImagePreviewViewController.mm:
(-[WKImagePreviewViewController previewActionItems]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Generator CodeBlock generation should be idempotent
ysuzuki@apple.com [Fri, 3 May 2019 18:54:44 +0000 (18:54 +0000)]
[JSC] Generator CodeBlock generation should be idempotent
https://bugs.webkit.org/show_bug.cgi?id=197552

Reviewed by Keith Miller.

JSTests:

Add complex.yaml, which controls how to run JSC shell more.
We split test files into two to run macro task between them which allows debugger to be attached to VM.

* complex.yaml: Added.
* complex/generator-regeneration-after.js: Added.
* complex/generator-regeneration.js: Added.
(gen):

Source/JavaScriptCore:

ES6 Generator saves and resumes the current execution state. Since ES6 generator can save the execution state at expression
granularity (not statement granularity), the saved state involves locals. But if the underlying CodeBlock is jettisoned and
recompiled with different code generation option (like, debugger, type profiler etc.), the generated instructions can be largely
different and it does not have the same state previously used. If we resume the previously created generator with the newly
generator function, resuming is messed up.

    function* gen () { ... }
    var g = gen();
    g.next();

    // CodeBlock is destroyed & Debugger is enabled.

    g.next();

In this patch,

1. In generatorification, we use index Identifier (localN => Identifier("N")) instead of private symbols to generate the same
   instructions every time we regenerate the CodeBlock.

2. We decouple the options which can affect on the generated code (Debugger, TypeProfiler, ControlFlowProfiler) from the BytecodeGenerator,
   and pass them as a parameter, OptionSet<CodeGeneratorMode>.

3. Generator ScriptExecutable remembers the previous CodeGeneratorMode and reuses this parameter to regenerate CodeBlock. It means that,
   even if the debugger is enabled, previously created generators are not debuggable. But newly created generators are debuggable.

* bytecode/BytecodeGeneratorification.cpp:
(JSC::BytecodeGeneratorification::storageForGeneratorLocal):
(JSC::BytecodeGeneratorification::run):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantRegisters):
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::wasCompiledWithDebuggingOpcodes const):
(JSC::UnlinkedCodeBlock::wasCompiledWithTypeProfilerOpcodes const):
(JSC::UnlinkedCodeBlock::wasCompiledWithControlFlowProfilerOpcodes const):
(JSC::UnlinkedCodeBlock::codeGenerationMode const):
* bytecode/UnlinkedEvalCodeBlock.h:
* bytecode/UnlinkedFunctionCodeBlock.h:
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
* bytecode/UnlinkedFunctionExecutable.h:
* bytecode/UnlinkedGlobalCodeBlock.h:
(JSC::UnlinkedGlobalCodeBlock::UnlinkedGlobalCodeBlock):
* bytecode/UnlinkedModuleProgramCodeBlock.h:
* bytecode/UnlinkedProgramCodeBlock.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitTypeProfilerExpressionInfo):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::emitProfileControlFlow):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitLogShadowChickenPrologueIfNecessary):
(JSC::BytecodeGenerator::emitLogShadowChickenTailIfNecessary):
(JSC::BytecodeGenerator::emitDebugHook):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::shouldEmitDebugHooks const):
(JSC::BytecodeGenerator::shouldEmitTypeProfilerHooks const):
(JSC::BytecodeGenerator::shouldEmitControlFlowProfilerHooks const):
* bytecompiler/NodesCodegen.cpp:
(JSC::PrefixNode::emitResolve):
(JSC::EmptyVarExpression::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
* parser/ParserModes.h:
(): Deleted.
* parser/SourceCodeKey.h:
(JSC::SourceCodeFlags::SourceCodeFlags):
(JSC::SourceCodeKey::SourceCodeKey):
* runtime/CachedTypes.cpp:
(JSC::CachedCodeBlock::isClassContext const):
(JSC::CachedCodeBlock::codeGenerationMode const):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::CachedCodeBlock<CodeBlockType>::encode):
(JSC::CachedCodeBlock::wasCompiledWithDebuggingOpcodes const): Deleted.
* runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedProgramCodeBlock):
(JSC::CodeCache::getUnlinkedEvalCodeBlock):
(JSC::CodeCache::getUnlinkedModuleProgramCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
(JSC::generateUnlinkedCodeBlockForFunctions):
(JSC::sourceCodeKeyForSerializedBytecode):
(JSC::sourceCodeKeyForSerializedProgram):
(JSC::sourceCodeKeyForSerializedModule):
(JSC::serializeBytecode):
* runtime/CodeCache.h:
(JSC::generateUnlinkedCodeBlockImpl):
(JSC::generateUnlinkedCodeBlock):
* runtime/Completion.cpp:
(JSC::generateProgramBytecode):
(JSC::generateModuleBytecode):
* runtime/DirectEvalExecutable.cpp:
(JSC::DirectEvalExecutable::create):
* runtime/IndirectEvalExecutable.cpp:
(JSC::IndirectEvalExecutable::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::defaultCodeGenerationMode const):
* runtime/ModuleProgramExecutable.cpp:
(JSC::ModuleProgramExecutable::create):
* runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::newCodeBlockFor):
* runtime/ScriptExecutable.h:
* tools/JSDollarVM.cpp:
(JSC::changeDebuggerModeWhenIdle):
(JSC::functionEnableDebuggerModeWhenIdle):
(JSC::functionDisableDebuggerModeWhenIdle):

Tools:

* Scripts/run-javascriptcore-tests:
(runJSCStressTests):
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoProvide UIImages for element actions
dino@apple.com [Fri, 3 May 2019 18:52:44 +0000 (18:52 +0000)]
Provide UIImages for element actions
https://bugs.webkit.org/show_bug.cgi?id=197539
<rdar://problem/50430363>

Reviewed by Wenson Hsieh.

Use an additions include to export a function that
relates a UIImage to a _WKElementAction.

* UIProcess/API/Cocoa/_WKElementAction.h:
* UIProcess/API/Cocoa/_WKElementAction.mm:
(_WKUIImageForElementActionType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[Cairo] Improve ShadowBlur performance using tiling optimization
commit-queue@webkit.org [Fri, 3 May 2019 18:31:06 +0000 (18:31 +0000)]
[Cairo] Improve ShadowBlur performance using tiling optimization
https://bugs.webkit.org/show_bug.cgi?id=197308
Patch by Tomoki Imai <Tomoki.Imai@sony.com> on 2019-05-03
Reviewed by Žan Doberšek.

Enable tiling tiling-based optimization for drawRectShadow() and drawInsetShadow().
Since r228776, cairo ports doesn't have tiling-based optimization.

For AppleWin, this patch refactors code and it shares almost same code as cairo port.
Only the difference is that AppleWin uses ScratchBuffer, but cairo ports doesn't.
This should avoid a performance regression for AppleWin.

No new tests, covered by existing tests.

* platform/graphics/ShadowBlur.cpp:
(WebCore::calculateLobes):
Fix stylecheck errors

(WebCore::ShadowBlur::blurLayerImage):
Fix stylecheck errors

(WebCore::ShadowBlur::calculateLayerBoundingRect):
We don't use position of m_sourceRect, so change the type to FloatSize.

(WebCore::ShadowBlur::drawShadowBuffer):
Use m_layerSize instead of m_shadowedResultSize to fillRect, as m_layerSize is always smaller than m_shadowedResultSize.
It's because in m_layerSize is equal to m_shadowedResultSize if it's not clipped.
Clipping doesn't increase size of m_layerSize, so m_layerSize is always smaller than or equal to m_shadowedResultSize.

(WebCore::ShadowBlur::templateSize const):
Fix stylecheck errors

(WebCore::ShadowBlur::drawRectShadow):
(WebCore::ShadowBlur::drawInsetShadow):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
Incorporate tile-based drawing.
To accomplish it, this patch abstracts GraphicsContext::drawImageBuffer to ShadowBlur::DrawImageCallback,
GraphicsContext::fillRect to ShadowBlur::FillRectCallback, drawing rect with hole to  ShadowBlur::FillRectWithHoleCallback.

Variants which takes GraphicsContext as parameter now just calls another drawRectShadow.

(WebCore::ShadowBlur::drawLayerPieces):
Instead of graphicsContext.drawImageBuffer, call corresponding callback.

(WebCore::ShadowBlur::drawLayerPiecesAndFillCenter):
This function calls drawLayerPieces and fill center for outer shadow.
Drawing outer shadow requires another callback for graphicsContext.fillRect.

(WebCore::ShadowBlur::drawShadowLayer):
Use m_layerSize instead of m_shadowedResultSize to fillRect,
as m_layerSize is always smaller than m_shadowedResultSize.

* platform/graphics/ShadowBlur.h:
Rename m_sourceRect to m_shadowedResultSize, and change it to FloatSize from FloatRect.
Remove GraphicsContext usage as much as possible and replace them by corresponding callbacks.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawShadowImage):
This function corresponds to ShadowBlur::DrawImageCallback.

(WebCore::Cairo::fillShadowBuffer):
Erase sourceRect, as it's always bigger than layerSize.

(WebCore::Cairo::drawPathShadow):
(WebCore::Cairo::drawGlyphsShadow):
Erase unused parameter.

(WebCore::Cairo::fillRect):
(WebCore::Cairo::fillRoundedRect):
(WebCore::Cairo::fillRectWithRoundedHole):
For tile-based optimization, add extra arguments to drawRectShadow.

(WebCore::Cairo::drawSurface):
Erase unused parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd a quirk to make youtube navigation bar scrollable without mouse hover on iOS
antti@apple.com [Fri, 3 May 2019 18:18:12 +0000 (18:18 +0000)]
Add a quirk to make youtube navigation bar scrollable without mouse hover on iOS
https://bugs.webkit.org/show_bug.cgi?id=197555
<rdar://problem/49582231>

Reviewed by Brent Fulgham.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyleForSiteSpecificQuirks):

Turn 'overflow:hidden' into 'overflow:auto' on element with id="guide-inner-content".

* page/Quirks.cpp:
(WebCore::Quirks::needsYouTubeOverflowScrollQuirk const):
* page/Quirks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoExpose full screen controller SPI to check if full screen is open and close full...
commit-queue@webkit.org [Fri, 3 May 2019 17:34:46 +0000 (17:34 +0000)]
Expose full screen controller SPI to check if full screen is open and close full screen
https://bugs.webkit.org/show_bug.cgi?id=197263

Patch by Jay Mulani <jmulani@apple.com> on 2019-05-03
Reviewed by Jer Noble.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView closeFullScreenWindowController]):
(-[WKWebView fullScreenWindowController]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoLayoutTest imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin...
youenn@apple.com [Fri, 3 May 2019 17:32:25 +0000 (17:32 +0000)]
LayoutTest imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.htm is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=182849
<rdar://problem/50353372>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Modernize the test and add an assertion that the body is transmitted after a redirection.

* web-platform-tests/xhr/event-upload-progress-crossorigin.htm:

Source/WebKit:

In case of restarting the load after a redirection, which now happens in case
of following cross origin redirections with same-origin credentials, make sure to
update the request as would do NetworkLoad.
This is in particular important to preserve the request body.

Covered by WPT updated test.

* NetworkProcess/NetworkLoad.cpp:
(WebKit::updateRequest):
(WebKit::NetworkLoad::updateRequestAfterRedirection const):
(WebKit::NetworkLoad::continueWillSendRequest):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest):

LayoutTests:

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoDo not require log_to_stderr for WebRTC logging through WebKit
youenn@apple.com [Fri, 3 May 2019 16:39:05 +0000 (16:39 +0000)]
Do not require log_to_stderr for WebRTC logging through WebKit
https://bugs.webkit.org/show_bug.cgi?id=197560

Reviewed by Eric Carlson.

* Source/webrtc/rtc_base/logging.cc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: Record actions performed on WebGL2RenderingContext
drousso@apple.com [Fri, 3 May 2019 16:36:17 +0000 (16:36 +0000)]
Web Inspector: Record actions performed on WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=176008
<rdar://problem/34213884>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* inspector/protocol/Recording.json:
* inspector/scripts/codegen/generator.py:
Add `canvas-webgl2` as a `Type`.

Source/WebCore:

Tests: inspector/canvas/recording-webgl2.html
       inspector/canvas/recording-webgl2-snapshots.html

* html/canvas/WebGL2RenderingContext.idl:

* bindings/js/CallTracerTypes.h:
* inspector/RecordingSwizzleTypes.h:

* inspector/InspectorCanvas.h:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::canvasChanged): Added.
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::shouldSnapshotWebGL2Action): Added.
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseObjectForRecording):
(WebCore::InspectorCanvas::appendActionSnapshotIfNeeded):
(WebCore::InspectorCanvas::buildAction):
* inspector/agents/InspectorCanvasAgent.h:
* inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::canvasChanged): Added.
(WebCore::InspectorCanvasAgent::startRecording):
Provide an actual implementation of `CanvasObserver::canvasChanged` since it can be used to
determine whether or not an action needs a snapshot.

* page/PageConsoleClient.cpp:
(WebCore::canvasRenderingContext):

Source/WebInspectorUI:

* UserInterface/Models/Recording.js:
(WI.Recording.fromPayload):
(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.async swizzle):
(WI.Recording.prototype.createContext):

* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.constantNameForParameter):
(WI.RecordingAction._prototypeForType):
(WI.RecordingAction.prototype.async swizzle):
Treat all actions with a snapshot as being a "visible" action.

* UserInterface/Views/CanvasTabContentView.css:
(.content-view.tab.canvas .navigation-bar > .item .canvas:matches(.webgl, .webgl2, .webgpu, .webmetal) .icon): Added.
(.content-view.tab.canvas .navigation-bar > .item .canvas.webgl): Deleted.
* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype.shown):
(WI.CanvasSidebarPanel.prototype._canvasChanged):
(WI.CanvasSidebarPanel.prototype._updateRecordNavigationItem):

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype.initialLayout):
* UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM.createParameterElement):

LayoutTests:

* inspector/canvas/recording-webgl2.html: Added.
* inspector/canvas/recording-webgl2-expected.txt: Added.
* inspector/canvas/recording-webgl2-snapshots.html: Added.
* inspector/canvas/recording-webgl2-snapshots-expected.txt: Added.

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed, rolling out r244881.
commit-queue@webkit.org [Fri, 3 May 2019 14:32:23 +0000 (14:32 +0000)]
Unreviewed, rolling out r244881.
https://bugs.webkit.org/show_bug.cgi?id=197559

Breaks compilation of jsconly on linux, breaking compilation
for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
guijemont on #webkit).

Reverted changeset:

"[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
WEBKIT_COPY_FILES"
https://bugs.webkit.org/show_bug.cgi?id=197174
https://trac.webkit.org/changeset/244881

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoResolve the percentage values of inset properties against proper box.
commit-queue@webkit.org [Fri, 3 May 2019 13:19:57 +0000 (13:19 +0000)]
Resolve the percentage values of inset properties against proper box.
https://bugs.webkit.org/show_bug.cgi?id=189549

Patch by Joonghun Park <jh718.park@samsung.com> on 2019-05-03
Reviewed by Antti Koivisto.

Before this CL, sticky element's layout was executed relative to
a box's overflow container,
but the value returned by getComputedStyle was resolved against
its containing block.

So, the computed value and the actual value used in layout
was different before this change.

LayoutTests/imported/w3c:

* web-platform-tests/css/cssom/getComputedStyle-insets-sticky-container-for-abspos-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-sticky-expected.txt.
* web-platform-tests/css/cssom/getComputedStyle-insets-sticky-container-for-abspos.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-sticky.html.
* web-platform-tests/css/cssom/getComputedStyle-insets-sticky-expected.txt:
* web-platform-tests/css/cssom/getComputedStyle-insets-sticky.html:
* web-platform-tests/css/cssom/getComputedStyle-sticky-pos-percent-expected.txt: Added.
* web-platform-tests/css/cssom/getComputedStyle-sticky-pos-percent.html: Added.
* web-platform-tests/css/cssom/support/getComputedStyle-insets.js:
(runTestsWithWM):

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-sticky-container-for-abspos.html
       imported/w3c/web-platform-tests/css/cssom/getComputedStyle-sticky-pos-percent.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::positionOffsetValue):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::enclosingScrollportBox const):
* rendering/RenderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed WPE build fix after r244898.
zandobersek@gmail.com [Fri, 3 May 2019 08:42:18 +0000 (08:42 +0000)]
Unreviewed WPE build fix after r244898.

* WebKitTestRunner/wpe/TestControllerWPE.cpp:
(WTR::TestController::abortModal): Add the missing (no-op) definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd a quirk to make gmail navigation bar scrollable without mouse hover on iOS
antti@apple.com [Fri, 3 May 2019 06:48:14 +0000 (06:48 +0000)]
Add a quirk to make gmail navigation bar scrollable without mouse hover on iOS
https://bugs.webkit.org/show_bug.cgi?id=197529
<rdar://problem/49403416>

Reviewed by Simon Fraser.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustRenderStyleForSiteSpecificQuirks):

Turn 'overflow:hidden' to 'overflow:auto' on element with role="navigation".
This should be both reasonably targeted and robust.

* css/StyleResolver.h:
* page/Quirks.cpp:
(WebCore::Quirks::needsGMailOverflowScrollQuirk const):
* page/Quirks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMark U+01C0 as a homograph of U+006C
commit-queue@webkit.org [Fri, 3 May 2019 06:23:59 +0000 (06:23 +0000)]
Mark U+01C0 as a homograph of U+006C
https://bugs.webkit.org/show_bug.cgi?id=197526
<rdar://problem/50301904>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-05-02
Reviewed by Tim Horton.

Source/WTF:

* wtf/URLHelpers.cpp:
(WTF::URLHelpers::isLookalikeCharacter):

Tools:

* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: Dark Mode: borders between section should be lighter than background
nvasilyev@apple.com [Fri, 3 May 2019 06:17:09 +0000 (06:17 +0000)]
Web Inspector: Dark Mode: borders between section should be lighter than background
https://bugs.webkit.org/show_bug.cgi?id=197551

Reviewed by Joseph Pecoraro.

* UserInterface/Views/DetailsSection.css:
(.details-section .details-section):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMake focusing-element-with-tabindex-by-tap-or-click.html more robust on iOS
rniwa@webkit.org [Fri, 3 May 2019 05:02:30 +0000 (05:02 +0000)]
Make focusing-element-with-tabindex-by-tap-or-click.html more robust on iOS
https://bugs.webkit.org/show_bug.cgi?id=197548

Reviewed by Wenson Hsieh.

There was a race between the time the editable element was focused and the keyboard was brought up
to when the next non-editable element was focused. Made the test explicitly wait for the keyboard
to come up and go down between test cases to make it more robust.

* fast/events/focusing-element-with-tabindex-by-tap-or-click.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd logging for RenderLayer clip rects
simon.fraser@apple.com [Fri, 3 May 2019 05:01:49 +0000 (05:01 +0000)]
Add logging for RenderLayer clip rects
https://bugs.webkit.org/show_bug.cgi?id=197547

Reviewed by Zalan Bujtas.

Add a ClipRects log channel, and stream output for ClipRect and ClipRects.

* platform/Logging.h:
* rendering/ClipRect.cpp:
(WebCore::operator<<):
* rendering/ClipRect.h:
* rendering/RenderLayer.cpp:
(WebCore::operator<<):
(WebCore::RenderLayer::calculateClipRects const):
* rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244900 268f45cc-cd09-0410-ab3c-d52691b4dbfc