WebKit-https.git
10 years ago2010-05-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 11 May 2010 17:53:49 +0000 (17:53 +0000)]
2010-05-11  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Doesn't support gtk-key-themes
        https://bugs.webkit.org/show_bug.cgi?id=28257

        Add support for GTK+ key themes.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::backspaceCallback): Added.
        (WebKit::cutClipboardCallback): Added.
        (WebKit::copyClipboardCallback): Added.
        (WebKit::pasteClipboardCallback): Added.
        (WebKit::selectAllCallback): Added.
        (WebKit::deleteFromCursorCallback): Added.
        (WebKit::moveCursorCallback): Added.
        (WebKit::EditorClient::generateEditorCommands): Added.
        (WebKit::EditorClient::executePendingEditorCommands): Added.
        (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks.
        (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer.
        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 11 May 2010 17:37:47 +0000 (17:37 +0000)]
2010-05-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
        https://bugs.webkit.org/show_bug.cgi?id=38653

        Check if willSendRequest cancelled the request before setting the
        first party for the cookies in the message, otherwise we'll get a
        critical warning.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in gyp changes for r59110
jam@chromium.org [Tue, 11 May 2010 17:11:37 +0000 (17:11 +0000)]
Check in gyp changes for r59110

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r59001): 11 media tests are failing on Windows (38847)
weinig@apple.com [Tue, 11 May 2010 16:47:20 +0000 (16:47 +0000)]
REGRESSION (r59001): 11 media tests are failing on Windows (38847)
rdar://problem/7962997
https://bugs.webkit.org/show_bug.cgi?id=38847

Patch by Jer Noble <jer.noble@apple.com> on 2010-05-11
Reviewed by Adele Peterson.

QTMovieWin was too much refactored; the cacheMovieScale() function should have
been left in QTMovie (instead of being moved into QTMovieGWorld).  This fixes the
video-size-intrinsic-scale test.

QTMovieTask::updateTaskTimer() was ignoring the maxInterval parameter unless
QTGetTimeUntilNextTask() returned an error, which caused the next timer to be
scheduled for extremely far in the future, breaking some of the layout tests.

QTMovieTask::fireTaskClients() now makes a local copy of the task list before
calling clients, in case one of them removes themselves from the task list and
invalidates our iterating pointer.

* platform/graphics/win/QTMovie.cpp:
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMoviePrivate::cacheMovieScale):
* platform/graphics/win/QTMovieGWorld.cpp:
(QTMovieGWorldPrivate::movieLoadStateChanged):
* platform/graphics/win/QTMovieTask.cpp:
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 11 May 2010 16:38:17 +0000 (16:38 +0000)]
2010-05-11  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Port SharedBuffer to WinCE.
        https://bugs.webkit.org/show_bug.cgi?id=37222

        Use only functions which are available on Win32 and WinCE.

        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge some pseudo-valid-*.html tests into one.
tkent@chromium.org [Tue, 11 May 2010 16:14:37 +0000 (16:14 +0000)]
Merge some pseudo-valid-*.html tests into one.
https://bugs.webkit.org/show_bug.cgi?id=38846

Reviewed by Shinichiro Hamaji.

No additional test cases and no removed test cases.

* fast/css/pseudo-valid-003-expected.txt: Removed.
* fast/css/pseudo-valid-003.html: Removed.
* fast/css/pseudo-valid-005-expected.txt: Removed.
* fast/css/pseudo-valid-005.html: Removed.
* fast/css/pseudo-valid-006-expected.txt: Removed.
* fast/css/pseudo-valid-006.html: Removed.
* fast/css/pseudo-valid-unapplied-expected.txt: Added.
* fast/css/pseudo-valid-unapplied.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Jesus Sanchez-Palencia <jesus@webkit.org>
eric@webkit.org [Tue, 11 May 2010 15:45:27 +0000 (15:45 +0000)]
2010-05-11  Jesus Sanchez-Palencia  <jesus@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Add PageClientQGraphicsWidget specific implementation.
        QGraphicsWebViewPrivate doesn't inherit QWebPageClient anymore
        and the needed functions were moved to this new PageClient class,
        including Tiling and Accelerated Composite specific ones.

        [Qt] PageClientQt specific implementation for QGraphicsWidget
        https://bugs.webkit.org/show_bug.cgi?id=37866

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
        (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
        (QGraphicsWebViewPrivate::syncLayers):
        (QGraphicsWebViewPrivate::_q_scaleChanged):
        (QGraphicsWebView::event):
        (QGraphicsWebView::setPage):
        (QGraphicsWebView::updateGeometry):
        (QGraphicsWebView::setGeometry):
        (QGraphicsWebView::setResizesToContents):
        * WebCoreSupport/PageClientQt.cpp:
        (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
        (WebCore::PageClientQGraphicsWidget::scroll):
        (WebCore::PageClientQGraphicsWidget::update):
        (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
        (WebCore::PageClientQGraphicsWidget::syncLayers):
        (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
        (WebCore::PageClientQGraphicsWidget::markForSync):
        (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition):
        (WebCore::PageClientQGraphicsWidget::updateTiledBackingStoreScale):
        (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled):
        (WebCore::PageClientQGraphicsWidget::inputMethodEnabled):
        (WebCore::PageClientQGraphicsWidget::setInputMethodHint):
        (WebCore::PageClientQGraphicsWidget::cursor):
        (WebCore::PageClientQGraphicsWidget::updateCursor):
        (WebCore::PageClientQGraphicsWidget::palette):
        (WebCore::PageClientQGraphicsWidget::screenNumber):
        (WebCore::PageClientQGraphicsWidget::ownerWidget):
        (WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget):
        (WebCore::PageClientQGraphicsWidget::pluginParent):
        (WebCore::PageClientQGraphicsWidget::style):
        * WebCoreSupport/PageClientQt.h:
        (WebCore::QGraphicsItemOverlay::page):
        (WebCore::QGraphicsItemOverlay::boundingRect):
        (WebCore::QGraphicsItemOverlay::paint):
        (WebCore::QGraphicsItemOverlay::prepareGraphicsItemGeometryChange):
        (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
        (WebCore::PageClientQGraphicsWidget::isQWidgetClient):
        (WebCore::PageClientQGraphicsWidget::allowsAcceleratedCompositing):
        (WebCore::PageClientQGraphicsWidget::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Tue, 11 May 2010 15:15:54 +0000 (15:15 +0000)]
2010-05-11  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/text/find-hidden-text.html
        https://bugs.webkit.org/show_bug.cgi?id=32922

        Remove fast/text/find-hidden-text.html from the skipped list of Qt.

        * platform/qt/Skipped:
2010-05-11  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/text/find-hidden-text.html
        https://bugs.webkit.org/show_bug.cgi?id=32922

        Use the real page step for populating the QStyleOption otherwhise
        the size can be negative, which can break the QStyle used.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::styleOptionSlider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 11 May 2010 14:15:14 +0000 (14:15 +0000)]
2010-05-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make styles rendering more user-friendly.

        https://bugs.webkit.org/show_bug.cgi?id=36747

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._update):
        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
        (WebInspector.ComputedStyleSidebarPane):
        (WebInspector.StylePropertiesSection):
        (WebInspector.StylePropertiesSection.prototype.collapse):
        (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
        * inspector/front-end/inspector.css:
        (#elements-content):
        (#elements-sidebar):
        (.styles-sidebar-separator):
        (.styles-section):
        (.styles-section .header):
        (.styles-section .header .title):
        (.styles-section .header .subtitle):
        (.styles-section .header .subtitle a):
        (.styles-section .properties):
        (.styles-section.no-affect .properties li):
        (.styles-section.no-affect .properties li.editing):
        (.styles-section.expanded .properties):
        (.styles-section .properties li):
        (.styles-section .properties li.parent):
        (.styles-section .properties ol):
        (.styles-section .properties ol.expanded):
        (.styles-section .properties li.parent::before):
        (.styles-section .properties li.parent.expanded::before):
        (.styles-section .properties li .info):
        (.styles-section:hover .properties .enabled-button):
        (.styles-section .properties li.disabled .enabled-button):
        (.styles-section .properties .enabled-button):
        (.styles-section .properties .overloaded, .styles-section .properties .disabled):
        (.styles-section.computed-style .properties .disabled):
        (.styles-section .properties .implicit, .styles-section .properties .inherited):
        (.styles-section .properties .inherited):
        (.styles-section.show-inherited .properties .inherited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 13:09:04 +0000 (13:09 +0000)]
2010-05-11  John Gregg  <johnnyg@google.com>

        [chromium] Unreviewed, test expectations.

        * platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
        * platform/chromium-win/svg/filters/filteredImage-expected.checksum: Added.
        * platform/chromium-win/svg/filters/filteredImage-expected.png: Added.
        * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
        * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png: Added.
        * platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
        * platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 11 May 2010 12:11:09 +0000 (12:11 +0000)]
2010-05-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
        https://bugs.webkit.org/show_bug.cgi?id=38799

        Cleanup SVGRootInlineBox/SVGInlineTextBox. Move buildLayoutInformationForTextBox to SVGInlineTextBox.
        Move lots of helper methods into new SVGTextLayoutUtilities class. Adapted all callsites.

        Fixed bug in kerning handling, hkern was applyable to vertical text as well. Covered by two new tests.

        Tests: svg/text/text-hkern-on-vertical-text.svg
               svg/text/text-vkern-on-horizontal-text.svg

        * Android.mk: Add SVGTextLayoutUtilities.cpp/h to build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphWidth): Use textRenderer()->characters() instead of textRenderer()->text()->characters() as shortcut.
        (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): Fix style issue, no else if after a return branch.
        (WebCore::SVGInlineTextBox::paintSelection): Use !color.alpha() instead of color.alpha() == 0.
        (WebCore::SVGInlineTextBox::buildLayoutInformation): Moved from SVGRootInlineBox::buildLayoutInformationForTextBox.
        * rendering/SVGInlineTextBox.h: Fix indention.
        (WebCore::SVGInlineTextBox::selectionTop): Inlined.
        (WebCore::SVGInlineTextBox::selectionHeight): Inlined.
        * rendering/SVGRenderTreeAsText.cpp: Include SVGTextLayoutUtilities.h
        * rendering/SVGRootInlineBox.cpp: Move almost all static text layout helper functions in SVGTextLayoutUtilities
        (WebCore::calculateTextLengthCorrectionForTextChunk): Fixed style issue in long if conditions spanning multiple lines.
        (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use different topLeftPositionOfCharacterRange() taking start/end iterators.
        (WebCore::SVGRootInlineBox::buildLayoutInformation): Use the moved SVGInlineTextBox::buildLayoutInformation() method.
        (WebCore::SVGRootInlineBox::buildTextChunks): Fixed small style issue, remove unneeded parenthesis.
        (WebCore::SVGRootInlineBox::layoutTextChunks): Fix style issue in debugging code.
        * rendering/SVGRootInlineBox.h: Rename 'LastGlyphInfo' to 'SVGLastGlyphInfo' and move to SVGTextLayoutUtilities.
        (WebCore::SVGRootInlineBox::svgTextChunks): Inlined for speed.
        * rendering/SVGTextLayoutUtilities.cpp: Added.
        (WebCore::isVerticalWritingMode):
        (WebCore::dominantBaselineToShift):
        (WebCore::alignmentBaselineToShift):
        (WebCore::glyphOrientationToAngle):
        (WebCore::glyphOrientationIsMultiplyOf180Degrees):
        (WebCore::applyGlyphAdvanceAndShiftRespectingOrientation):
        (WebCore::topLeftPositionOfCharacterRange):
        (WebCore::cummulatedWidthOfInlineBoxCharacterRange):
        (WebCore::cummulatedHeightOfInlineBoxCharacterRange):
        (WebCore::svgTextRunForInlineTextBox):
        (WebCore::calculateCSSKerning):
        (WebCore::applySVGKerning):
        * rendering/SVGTextLayoutUtilities.h: Added.
        (WebCore::):
        (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
        (WebCore::SVGLastGlyphInfo::SVGLastGlyphInfo):
2010-05-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
        https://bugs.webkit.org/show_bug.cgi?id=38799

        * platform/mac/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
        * platform/mac/svg/text/text-hkern-on-vertical-text-expected.png: Added.
        * platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
        * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
        * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
        * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
        * svg/text/text-hkern-on-vertical-text.svg: Added.
        * svg/text/text-vkern-on-horizontal-text.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: RenderSVGImage::imageChanged should invalidate the SVG filter cache
zherczeg@webkit.org [Tue, 11 May 2010 09:22:09 +0000 (09:22 +0000)]
WebCore: RenderSVGImage::imageChanged should invalidate the SVG filter cache
https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

Test: svg/filters/filteredImage.svg

* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::imageChanged):

LayoutTests: Test case for SVG filter cache invalidation, after an image resource arrives.
https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

* platform/gtk/Skipped:
* platform/mac/svg/filters/filteredImage-expected.checksum: Added.
* platform/mac/svg/filters/filteredImage-expected.png: Added.
* platform/mac/svg/filters/filteredImage-expected.txt: Added.
* platform/qt/svg/filters/filteredImage-expected.txt: Added.
* svg/filters/filteredImage.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 08:08:21 +0000 (08:08 +0000)]
2010-05-11  Simon Fraser  <simon.fraser@apple.com>

        Test result fixes for Leopard.

        Leopard needs custom results for tests that dump the layer tree, because Leopard
        CA does not have geometry flipping, so we do that ourselves by setting a transform.

        * platform/mac-leopard/compositing/iframes/composited-parent-iframe-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/enter-compositing-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 11 May 2010 07:24:08 +0000 (07:24 +0000)]
2010-05-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
        https://bugs.webkit.org/show_bug.cgi?id=38889

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 07:18:53 +0000 (07:18 +0000)]
2010-05-11  John Gregg  <johnnyg@google.com>

        [chromium] Update win-vista version of the baseline recently updated for win-xp.

        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 06:43:57 +0000 (06:43 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Fix asserting GTK build.

        r59137 changed the behavior of RenderObject::repaintUsingContainer(). I mistakenly
        thought that non-compositing builds would always pass a 0 repaintContainer, but
        actually the RenderView is passed in this case. So use this to repaint if
        ACCELERATED_COMPOSITING is turned off.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintUsingContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 06:32:36 +0000 (06:32 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Skip two new flakey tests:

        # Tests are flakey: https://bugs.webkit.org/show_bug.cgi?id=38888
        compositing/iframes/iframe-resize.html
        compositing/iframes/overlapped-iframe.html

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 06:22:15 +0000 (06:22 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        No review; attempt to fix failing tests.

        Increase the timeout to give compositing updates a chance to happen.

        * compositing/iframes/iframe-resize.html:
        * compositing/iframes/overlapped-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 06:06:18 +0000 (06:06 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Fix warning on Windows about unreachable code.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 06:05:03 +0000 (06:05 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Reduce timeouts from 500 to 50ms to make the tests run more quickly.

        * compositing/iframes/resources/enter-compositing-subframe.html:
        * compositing/iframes/resources/leave-compositing-subframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:47:04 +0000 (05:47 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
        flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
        content to show up in both compositing layers, and the painted background inside the iframe.

        Fix by taking the flattening state from the parent frame, if there is one. For the root
        frame, we continue to look to see if we're painting into a bitmap.

        * WebView/WebFrame.mm:
        (-[WebFrame _drawRect:contentsOnly:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:47:00 +0000 (05:47 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        RenderObject::repaintUsingContainer() incorrectly did a view-based
        repaint if the repaint container was the RenderView. Instead, we need
        to check to see if the RenderView's layer is composited, and, if so,
        whether it's painting into the window or not. This can occur when iframes
        are composited.

        The bug is timing-sensitive, involving compositing in iframes, and I was not able to
        concoct a good testcase.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintUsingContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:44:06 +0000 (05:44 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        Changes to allow compositing layers for iframes to switch between being hosted
        by the iframe's layer-backed NSView, and parented in the GraphicsLayer tree of the
        enclosing document.

        Tests: compositing/iframes/connect-compositing-iframe.html
               compositing/iframes/connect-compositing-iframe2.html
               compositing/iframes/connect-compositing-iframe3.html

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::hasCompositedContent): New convenience method.
        (WebCore::FrameView::setIsOverlapped): If we're composited, poke the owner document in case it
            wants to re-evaluate compositing decisions.
        (WebCore::FrameView::isOverlapped): Just expose the existing flag.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::shouldBeNormalFlowOnly):
        (WebCore::RenderLayer::isSelfPaintingLayer):

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): If this is an iframe, we need
            to ensure that the layers for the iframe content are hooked up.
        (WebCore::RenderLayerBacking::updateDrawsContent): When an iframe toggles between different
            attachments, the 'drawsContent' behavior of its root layer changes, so needs to be updated.

        * rendering/RenderLayerCompositor.h:
        (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer()
            instead of detachRootPlatformLayer() and manually zeroing out the OwnPtrs.
        (WebCore::RenderLayerCompositor::updateBacking): If a RenderIFrame changes compositing mode,
            we need to ensure that its content compositor attachment is updated.
        (WebCore::RenderLayerCompositor::repaintOnCompositingChange): The existing code had a bug
            that caused repaints for RenderViews (which have no parent) to bail. We only want to bail
            for non-RenderViews that are not attached.
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Factored the iframe-connecting
            code into a new method, parentIFrameContentLayers().
        (WebCore::RenderLayerCompositor::parentIFrameContentLayers): New method to share the code that hooks
            up the iframe's compositing layers to the parent.
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Add logic to propagate
            compositing out of iframes on Mac in two situations: 1) when the FrameView is overlapped, and 2)
            if the parent document is already composited.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Clean up the logic here to better deal
            with dynamic changes of the attachment type.
        (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Clean up and null out the clipping layer here.
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call rootLayerAttachmentChanged().
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto. Also unparent the clipping and platform layers.
        (WebCore::RenderLayerCompositor::updateRootLayerAttachment): Call ensureRootPlatformLayer() to re-evaluate
            the layer attachment.
        (WebCore::RenderLayerCompositor::rootLayerAttachmentChanged): We need to update the drawsContent() status
            of the RenderView's layer's backing, because it changes depending on the attachment.

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint): Do overlap testing if the frameView can do fast repaints (as before),
            but also now when the frameView has composited content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding a test that makes sure openDatabaseSync() deals correctly with invalid inputs.
dumi@chromium.org [Tue, 11 May 2010 05:37:42 +0000 (05:37 +0000)]
Adding a test that makes sure openDatabaseSync() deals correctly with invalid inputs.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

* fast/workers/storage: Added.
* fast/workers/storage/open-database-sync-inputs-expected.txt: Added.
* fast/workers/storage/open-database-sync-inputs.html: Added.
* fast/workers/storage/resources: Added.
* fast/workers/storage/resources/open-database-sync-inputs.js: Added.
(notAString.toString):
* fast/workers/storage/resources/test-inputs-common.js: Added.
(log):
(finishTest):
(runTest.worker.onmessage):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:34:48 +0000 (05:34 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        Rename the static shouldPropagateCompositingToIFrameParent() to shouldPropagateCompositingToEnclosingIFrame(),
        to pave the way for runtime switches in the propagation behavior. We have to make sure we call it on
        the correct RenderLayerCompositor (that belonging to the iframe's content document).

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintingGoesToWindow): Now that we know the root layer attachment, we
        can simplify this method.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode): No need for the setNeedsStyleRecalc()
        here, because the ensureRootPlatformLayer() or destroyRootPlatformLayer() will have already done it.

        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Use the root layer attachment to determine
        whether to parent the iframe's layers.

        (WebCore::RenderLayerCompositor::didMoveOnscreen): Method name change.
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Name change.
        (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): We need to consult the iframe contents
        document's compositor to ask whether propagation is appropriate.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Name change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:33:23 +0000 (05:33 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        Use an enum for the type of root layer attachment on a RenderLayerCompositor, so we can
        determine if the attachment is via the ChromeClient, via an enclosing iframe, or unattached.

        * rendering/RenderLayerCompositor.h: New RootLayerAttachment enum.
        (WebCore::RenderLayerCompositor::rootLayerAttachment): getter for the current attachment.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::RenderLayerCompositor): Init m_rootLayerAttachment.
        (WebCore::RenderLayerCompositor::~RenderLayerCompositor): Assert that is unattached.
        (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer instead of willMoveOffscreen,
        when there are no layers left. Also clear out the clipping layer.
        (WebCore::RenderLayerCompositor::didMoveOnscreen): Call attachRootPlatformLayer.
        (WebCore::RenderLayerCompositor::willMoveOffscreen): Call ensureRootPlatformLayer with the appropriate attachment.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Only create the m_rootPlatformLayer if we don't have one
           already, but be sure to always set the root layer geometry orientation. Also only create the
           m_clippingLayer if we need to.
        (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Call detachRootPlatformLayer().
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Code moved from didMoveOnscreen, but switching on
            attachment.
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer): Code moved from willMoveOffscreen, but switching on
            attachment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:27:13 +0000 (05:27 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        Clean up the geometry logic when propagating compositing out of iframes.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateRootLayerPosition): Geometry on m_rootPlatformLayer no longer
        needs to be special when there's a clipping layer.

        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Don't set the clipping layer to have
        flipped geometry ever, and only set the root layer to have flipped geometry if it is not
        being hosted in an iframe. Also no need to set a custom anchor point on the clipping layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:22:31 +0000 (05:22 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Fix up test results from last commit, which were generated with a build from before r59129.

        * platform/win/compositing/iframes/composited-parent-iframe-expected.txt:
        * platform/win/compositing/iframes/iframe-resize-expected.txt:
        * platform/win/compositing/iframes/leave-compositing-iframe-expected.txt:
        * platform/win/compositing/iframes/overlapped-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:12:50 +0000 (05:12 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=38856
        Allow compositing layers to be connected across iframe boundaries on Mac

        Add several more iframe-compositing-related tests. These tests:
            * an iframe dynamically entering compositing mode
            * an iframe dynamically leaving compositing mode
            * an overlapped iframe
            * a compositing iframe being resized

        composited-iframe.html had no value and is removed.

        * compositing/iframes/composited-iframe-expected.txt: Removed.
        * compositing/iframes/composited-iframe.html: Removed.
        * compositing/iframes/enter-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
        * compositing/iframes/enter-compositing-iframe.html: Added.
        * compositing/iframes/iframe-resize-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
        * compositing/iframes/iframe-resize.html: Added.
        * compositing/iframes/leave-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
        * compositing/iframes/leave-compositing-iframe.html: Added.
        * compositing/iframes/overlapped-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
        * compositing/iframes/overlapped-iframe.html: Added.
        * compositing/iframes/resources/enter-compositing-subframe.html: Added.
        * compositing/iframes/resources/leave-compositing-subframe.html: Added.
        * platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
        * platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
        * platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 11 May 2010 05:08:18 +0000 (05:08 +0000)]
2010-05-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Allow compositing layers to be connected across iframe boundaries on Mac
        https://bugs.webkit.org/show_bug.cgi?id=38856

        Clean up some methods related to composited iframes. No behavioral changes.

        * rendering/RenderLayerBacking.h: Move innerRenderLayerCompositor() to be a static method:
            RenderLayerCompositor::iframeContentsCompositor().
        * rendering/RenderLayerBacking.cpp: Remove innerRenderLayerCompositor().
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call iframeContentsCompositor().

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode): Call enclosingIFrameElement()
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): iframeContentsCompositor() is now a static method in this class.
        Also check that the iframe contents are in compositing mode (slightly clearer than relying on rootPlatformLayer() returning
        null).
        (WebCore::RenderLayerCompositor::iframeContentsCompositor): Moved from RenderLayerBacking.
        (WebCore::RenderLayerCompositor::didMoveOnscreen): Use enclosingIFrameElement() method.
        (WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto.
        (WebCore::RenderLayerCompositor::enclosingIFrameElement): New method.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Call enclosingIFrameElement().
        * rendering/RenderLayerCompositor.h: New method, iframeContentsCompositor().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 05:06:57 +0000 (05:06 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Final set of baselines and expectations to green up the build.

        * platform/chromium-mac/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
        * platform/chromium-win/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 04:49:38 +0000 (04:49 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] rebaseline SVG test for windows after recent changes.

        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
        * platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
        * platform/chromium-win/svg/batik/filters/feTile-expected.png:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
        * platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect-expected.png: Added.
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.png: Added.
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
        * platform/chromium-win/svg/batik/text/textProperties-expected.txt:
        * platform/chromium-win/svg/custom/empty-mask-expected.txt:
        * platform/chromium-win/svg/custom/empty-merge-expected.checksum:
        * platform/chromium-win/svg/custom/empty-merge-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/chromium-win/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png:
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
        * platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/chromium-win/svg/custom/invalid-css-expected.txt:
        * platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
        * platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
        * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
        * platform/chromium-win/svg/custom/text-filter-expected.checksum:
        * platform/chromium-win/svg/custom/text-filter-expected.png:
        * platform/chromium-win/svg/custom/text-filter-expected.txt:
        * platform/chromium-win/svg/custom/visibility-override-filter-expected.checksum:
        * platform/chromium-win/svg/custom/visibility-override-filter-expected.png:
        * platform/chromium-win/svg/filters/big-sized-filter-2-expected.checksum:
        * platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
        * platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
        * platform/chromium-win/svg/filters/big-sized-filter-expected.png:
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
        * platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
        * platform/chromium-win/svg/filters/feComposite-expected.checksum:
        * platform/chromium-win/svg/filters/feComposite-expected.png:
        * platform/chromium-win/svg/filters/feComposite-expected.txt:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
        * platform/chromium-win/svg/filters/feMerge-expected.checksum:
        * platform/chromium-win/svg/filters/feMerge-expected.png:
        * platform/chromium-win/svg/filters/feOffset-expected.checksum:
        * platform/chromium-win/svg/filters/feOffset-expected.png:
        * platform/chromium-win/svg/filters/feTile-expected.checksum:
        * platform/chromium-win/svg/filters/feTile-expected.png:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
        * platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
        * platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
        * platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
        * platform/chromium-win/svg/text/text-vkern-expected.checksum: Added.
        * platform/chromium-win/svg/text/text-vkern-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixing the expectations for Chromium.
dumi@chromium.org [Tue, 11 May 2010 04:12:22 +0000 (04:12 +0000)]
Unreviewed, fixing the expectations for Chromium.

* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a crash when closing a WebView while the Web Inspector is open.
timothy@apple.com [Tue, 11 May 2010 03:51:02 +0000 (03:51 +0000)]
Fix a crash when closing a WebView while the Web Inspector is open.

<rdar://problem/7966830>

Reviewed by Mark Rowe.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
* WebView/WebView.mm:
(-[WebView _close]): Null out _private->page before deleting the page, so code called
during destruction don't access a half deleted Page object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 11 May 2010 03:45:56 +0000 (03:45 +0000)]
2010-05-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Build DRT when running build-webkit --chromium
        https://bugs.webkit.org/show_bug.cgi?id=38730

        This allows DRT to use the same .o and .lib files when building
        on Windows.

        * WebKit.gyp: Move DRT.gyp targets into this file.
        * gyp_webkit: DRT.gyp is gone
2010-05-10  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Build DRT when running build-webkit --chromium
        https://bugs.webkit.org/show_bug.cgi?id=38730

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
        * Scripts/build-dumprendertree: This does nothing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 11 May 2010 03:40:24 +0000 (03:40 +0000)]
2010-05-10  Eric Seidel  <eric@webkit.org>

        Unreviewed, just removing newline from -expected.txt file

        REGRESSION(r59100): "Added test is broken on many platforms." (Requested by eseidel on #webkit).
        https://bugs.webkit.org/show_bug.cgi?id=38881

        Looks like http://trac.webkit.org/changeset/59119
        added an extra newline by mistake.  Removing.

        * plugins/geturlnotify-during-document-teardown-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixing Qt's expectations.
dumi@chromium.org [Tue, 11 May 2010 02:54:25 +0000 (02:54 +0000)]
Unreviewed, fixing Qt's expectations.

* platform/qt/http/tests/security/cross-frame-access-call-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove conflict markers from ChangeLog
abarth@webkit.org [Tue, 11 May 2010 02:39:33 +0000 (02:39 +0000)]
Remove conflict markers from ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r59100): Added test is broken on many platforms.
jhoneycutt@apple.com [Tue, 11 May 2010 02:35:56 +0000 (02:35 +0000)]
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881

Reviewed by Eric Seidel.

* platform/mac-snowleopard/Skipped:
Skipped, because we're not logging NPP_Destroy on Snow Leopard.

* platform/qt/Skipped:
Skipped due to lack of support for setCallCloseOnWebViews on
LayoutTestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r59100): Added test is broken on many platforms.
jhoneycutt@apple.com [Tue, 11 May 2010 02:35:35 +0000 (02:35 +0000)]
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881

Reviewed by Eric Seidel.

WebKitTools:

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy):
Use pluginLog, rather than printf, to match other platforms.

LayoutTests:

* plugins/geturlnotify-during-document-teardown-expected.txt:
Update the expected result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Cleaning up and fixing the existing JSC DB bindings.
dumi@chromium.org [Tue, 11 May 2010 02:06:11 +0000 (02:06 +0000)]
WebCore: Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):

LayoutTests: Fixing the expectations for openDatabase() in cross-frame-access-call.html.
Related to changes in patches #6 and #7 at https://bugs.webkit.org/show_bug.cgi?id=34994.

Reviewed by Brady Eidson.

* http/tests/security/cross-frame-access-call-expected.txt:
* http/tests/security/cross-frame-access-call.html:
* platform/chromium-linux/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/chromium-mac/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/chromium/http: Added.
* platform/chromium/http/tests: Added.
* platform/chromium/http/tests/security: Added.
* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 01:52:33 +0000 (01:52 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Fix a build failure caused by assuming the default platform in
        a unit test for new-run-webkit-tests instead of specifying
        --platform test.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 11 May 2010 01:50:38 +0000 (01:50 +0000)]
2010-05-10  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket needs to suspend/resume as Active DOM object.
        https://bugs.webkit.org/show_bug.cgi?id=38171

        Implement suspend()/resume() in WebSocket and WebSocketChannel.
        While WebSocketChannel is suspended, it only adds received data in m_buffer
        or record the handle was closed, and report no event to WebSocket.
        When resumed, it will process buffer or handle closing.
        Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
        So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
        so that next call of processBuffer() would process the next frame.

        * websockets/ThreadableWebSocketChannel.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
          Mark channel is opened, and process pending events if not suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
          Push message back in pending queue, and process pending events if not suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
          Mark channel is closed, and process pending events if not suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
          Mark suspended.
        (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
          Unmark suspended, and process pending events.
        (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
        (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::canSuspend):
        (WebCore::WebSocket::suspend):
        (WebCore::WebSocket::resume):
        (WebCore::WebSocket::didClose):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::connect):
        (WebCore::WebSocketChannel::send):
        (WebCore::WebSocketChannel::bufferedAmount):
        (WebCore::WebSocketChannel::close):
        (WebCore::WebSocketChannel::suspend):
        (WebCore::WebSocketChannel::resume):
         When resumed, it will process buffer and
         handle closing if handle was already closed while suspended.
        (WebCore::WebSocketChannel::didClose):
         If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed.
        (WebCore::WebSocketChannel::didReceiveData):
         Add received data in buffer and process buffer while it is not suspended.
        (WebCore::WebSocketChannel::processBuffer):
         Process handshake header or one frame message.
         Return true if there are more data to be processed.
         Return false otherwise (e.g. incomplete handshake header or incomplete frame).
        * websockets/WebSocketChannel.h:
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::resume):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::resume):
        (WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
        (WebCore::WorkerThreadableWebSocketChannel::mainThreadResume):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
        * websockets/WorkerThreadableWebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 01:45:16 +0000 (01:45 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Fix sort order for expectations after previous change.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 01:30:18 +0000 (01:30 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build-fix

        new-run-webkit-tests: fix test failure caused by me failing to update
        the expected output. Also, run '--platform test' instead of
        'platform dryrun' since the former is guaranteed to work and the
        latter isn't.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement the JSC bindings for the sync DB API.
dumi@chromium.org [Tue, 11 May 2010 01:18:42 +0000 (01:18 +0000)]
Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
* bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 11 May 2010 01:07:32 +0000 (01:07 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Unreviewed, test expectation change for Chromium following r59010.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 11 May 2010 00:44:58 +0000 (00:44 +0000)]
2010-05-10  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=36566
        The animation-fill-mode property was missing from
        a few places where the animation shorthand is set up.

        Test: animations/animation-shorthand-removed.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure
        animation-fill-mode is included in the animation shorthand
        * css/CSSPropertyLonghand.cpp:
        (WebCore::initShorthandMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 11 May 2010 00:10:07 +0000 (00:10 +0000)]
2010-05-10  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
        https://bugs.webkit.org/show_bug.cgi?id=38854

        * public/WebScrollbar.h: Added.
        (WebKit::WebScrollbar::):
        (WebKit::WebScrollbar::~WebScrollbar):
        * public/WebScrollbarClient.h: Added.
        * public/WebThemeEngine.h:
        * src/AssertMatchingEnums.cpp:
        * src/WebScrollbarImpl.cpp: Added.
        (WebKit::WebScrollbar::create):
        (WebKit::WebScrollbar::defaultThickness):
        (WebKit::WebScrollbarImpl::WebScrollbarImpl):
        (WebKit::WebScrollbarImpl::~WebScrollbarImpl):
        (WebKit::WebScrollbarImpl::setLocation):
        (WebKit::WebScrollbarImpl::value):
        (WebKit::WebScrollbarImpl::setValue):
        (WebKit::WebScrollbarImpl::setDocumentSize):
        (WebKit::WebScrollbarImpl::scroll):
        (WebKit::WebScrollbarImpl::paint):
        (WebKit::WebScrollbarImpl::handleInputEvent):
        (WebKit::WebScrollbarImpl::onMouseDown):
        (WebKit::WebScrollbarImpl::onMouseUp):
        (WebKit::WebScrollbarImpl::onMouseMove):
        (WebKit::WebScrollbarImpl::onMouseLeave):
        (WebKit::WebScrollbarImpl::onMouseWheel):
        (WebKit::WebScrollbarImpl::onKeyDown):
        (WebKit::WebScrollbarImpl::valueChanged):
        (WebKit::WebScrollbarImpl::invalidateScrollbarRect):
        (WebKit::WebScrollbarImpl::isActive):
        (WebKit::WebScrollbarImpl::scrollbarCornerPresent):
        (WebKit::WebScrollbarImpl::getTickmarks):
        * src/WebScrollbarImpl.h: Added.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::scrollViewWithKeyboard):
        (WebKit::WebViewImpl::mapKeyCodeForScroll):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
weinig@apple.com [Tue, 11 May 2010 00:08:33 +0000 (00:08 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.

Reviewed by Darin Adler.

Test: fast/dom/Element/normalize-crash.html

* dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
* dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
* dom/NamedAttrMap.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.

Reviewed by Darin Adler.

* fast/dom/Element/normalize-crash-expected.txt: Added.
* fast/dom/Element/normalize-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 00:01:21 +0000 (00:01 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by David Levin.

        new-run-webkit-tests: looks like the unicode conversion broke
        --print-last-failures and --retest-last-failures. Fixing.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 11 May 2010 00:00:15 +0000 (00:00 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by David Levin.

        Re-attempt to fix 38616 - newline handling in new-run-webkit-tests.
        I didn't handle some cases correctly before and the solution was
        confusing. The new patch assumes all calls to the printing module
        don't have newlines, and will append newlines where necessary, just
        like logging does.

        https://bugs.webkit.org/show_bug.cgi?id=38790

        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Mon, 10 May 2010 23:58:12 +0000 (23:58 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Unreviewed, svg test rebaselines after r59002 for linux.

        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
        * platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.png:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.txt: Added.
        * platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect-expected.png: Added.
        * platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.png: Added.
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
        * platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
        * platform/chromium-linux/svg/custom/empty-mask-expected.txt: Added.
        * platform/chromium-linux/svg/custom/empty-merge-expected.checksum:
        * platform/chromium-linux/svg/custom/empty-merge-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.txt: Added.
        * platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
        * platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/chromium-linux/svg/custom/invalid-css-expected.txt: Added.
        * platform/chromium-linux/svg/custom/mask-invalidation-expected.txt: Added.
        * platform/chromium-linux/svg/custom/non-opaque-filters-expected.txt: Added.
        * platform/chromium-linux/svg/custom/text-filter-expected.checksum:
        * platform/chromium-linux/svg/custom/text-filter-expected.png: Removed.
        * platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
        * platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Added.
        * platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
        * platform/chromium-linux/svg/filters/feColorMatrix-values-expected.txt: Added.
        * platform/chromium-linux/svg/filters/feComposite-expected.checksum:
        * platform/chromium-linux/svg/filters/feComposite-expected.png: Removed.
        * platform/chromium-linux/svg/filters/feComposite-expected.txt: Added.
        * platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feMerge-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feMerge-expected.png: Added.
        * platform/chromium-linux/svg/filters/feOffset-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feTile-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/feTile-expected.png: Added.
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Removed.
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Added.
        * platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
        * platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
        * platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Added.
        * platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
        * platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Removed.
        * platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
        * platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Removed.
        * platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
        * platform/chromium-linux/svg/text/text-vkern-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Fix V8 code generator script to generate the correct code for
jianli@chromium.org [Mon, 10 May 2010 23:38:18 +0000 (23:38 +0000)]
[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873

Reviewed by Adam Barth.

Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd test to GTK skipped list.
jhoneycutt@apple.com [Mon, 10 May 2010 23:35:51 +0000 (23:35 +0000)]
Add test to GTK skipped list.

Rubber-stamped by Mark Rowe.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the 32-bit WebKit2 build.
mrowe@apple.com [Mon, 10 May 2010 23:14:53 +0000 (23:14 +0000)]
Fix the 32-bit WebKit2 build.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 10 May 2010 23:02:46 +0000 (23:02 +0000)]
2010-05-10  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Make tkent a reviewer
        https://bugs.webkit.org/show_bug.cgi?id=38875

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash closing window containing Flash plug-in
jhoneycutt@apple.com [Mon, 10 May 2010 22:56:26 +0000 (22:56 +0000)]
Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>

Reviewed by Eric Seidel.

WebCore:

Test: plugins/geturlnotify-during-document-teardown.html

* plugins/PluginView.cpp:
(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.

WebKitTools:

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate):
Initialize new member to false.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
Added a new member.

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
Check whether the element has the "testGetURLOnDestroy" attribute, and
record that.
(NPP_Destroy):
If "testGetURLOnDestroy" is set, perform a load while destroying the
plug-in.

LayoutTests:

* plugins/geturlnotify-during-document-teardown.html: Added.
* plugins/resources/geturlnotify-on-destroy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 10 May 2010 22:48:18 +0000 (22:48 +0000)]
2010-05-10  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Executive.kill_* do not work with windows python
        https://bugs.webkit.org/show_bug.cgi?id=38872

        http://trac.webkit.org/changeset/57444 is where the original
        breakage occurred.
        http://trac.webkit.org/changeset/58314 is where the regression
        started affecting chromium.

        I have since learned that sys.platform has no "windows" value.
        "win32" is always the value, under 32 or 64 bit windows

        The tests for this code are not run anywhere because
        test-webkitpy does not yet work on "win32".  Mostly due to
        depending on unixisms like "cat" and "yes".

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 10 May 2010 22:13:36 +0000 (22:13 +0000)]
    Reviewed by Darin Adler.

        Based on a patch by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28697
        <rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()

        It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
        that it can adjust start and end position to any node except for the one being removed -
        so these notifications cannot be batched.

        Test: fast/dom/Range/remove-all-children-crash.html

        * dom/ContainerNode.cpp:
        (WebCore::willRemoveChild): Removed unused ExceptionCode.
        (WebCore::willRemoveChildren): New function, used in removeChildren() case.
        (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it.
        (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode.
        (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode
        and willRemoveChild.

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.

        * dom/Document.h:
        (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.

        * dom/Range.h:
        * dom/Range.cpp:
        (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case.
        (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement the V8 bindings for the sync DB API.
dumi@chromium.org [Mon, 10 May 2010 21:34:40 +0000 (21:34 +0000)]
Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994

Reviewed by Adam Barth.

* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up and fix the existing V8 DB bindings.
dumi@chromium.org [Mon, 10 May 2010 20:46:34 +0000 (20:46 +0000)]
Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Adam Barth.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix for wx 2.8 after complex text changes.
kevino@webkit.org [Mon, 10 May 2010 20:03:07 +0000 (20:03 +0000)]
[wx] Build fix for wx 2.8 after complex text changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnbreak the world. (Fix Mac builds).
andersca@apple.com [Mon, 10 May 2010 19:59:45 +0000 (19:59 +0000)]
Unbreak the world. (Fix Mac builds).

* Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-07 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 10 May 2010 19:53:34 +0000 (19:53 +0000)]
2010-05-07  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Add a bunch of windows-specific chromium baselines for the different
        versions of windows to update them from a skia change.

        https://bugs.webkit.org/show_bug.cgi?id=38784

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 10 May 2010 19:47:16 +0000 (19:47 +0000)]
2010-05-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Fix a bug in rebaseline-chromium-webkit-tests where we would crash
        instead of logging an error and exiting if it couldn't find either a
        debug or a release build of the image diff binary.

        https://bugs.webkit.org/show_bug.cgi?id=38692

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 10 May 2010 19:46:30 +0000 (19:46 +0000)]
2010-05-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
        https://bugs.webkit.org/show_bug.cgi?id=38861

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 John Gregg <johnnyg@google.com>
johnnyg@google.com [Mon, 10 May 2010 19:36:11 +0000 (19:36 +0000)]
2010-05-10  John Gregg  <johnnyg@google.com>

        [chromium] Try to fix the chromium build after r59085 by
        including MathExtras.h before using isnan().
        https://bugs.webkit.org/show_bug.cgi?id=38860

        * html/canvas/WebGLIntegralTypedArrayBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix for wx trunk after complex text changes.
kevino@webkit.org [Mon, 10 May 2010 18:59:09 +0000 (18:59 +0000)]
[wx] Build fix for wx trunk after complex text changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Mon, 10 May 2010 18:14:09 +0000 (18:14 +0000)]
2010-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Provide mechanism to cache metadata for a resource
        https://bugs.webkit.org/show_bug.cgi?id=37874

        No new tests because no new functionality.

        * WebCore.gypi:
        * loader/CachedMetadata.h: Added.
        (WebCore::CachedMetadata::create):
        (WebCore::CachedMetadata::deserialize):
        (WebCore::CachedMetadata::serialize):
        (WebCore::CachedMetadata::~CachedMetadata):
        (WebCore::CachedMetadata::dataTypeID):
        (WebCore::CachedMetadata::data):
        (WebCore::CachedMetadata::size):
        (WebCore::CachedMetadata::readUnsigned):
        (WebCore::CachedMetadata::appendUnsigned):
        (WebCore::CachedMetadata::CachedMetadata):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::setSerializedCachedMetadata):
        (WebCore::CachedResource::setCachedMetadata):
        (WebCore::CachedResource::cachedMetadata):
        * loader/CachedResource.h:
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::didReceiveCachedMetadata):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didReceiveCachedMetadata):
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
        * loader/loader.cpp:
        (WebCore::Loader::Host::didReceiveCachedMetadata):
        * loader/loader.h:
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Provide mechanism to cache metadata for a resource
        https://bugs.webkit.org/show_bug.cgi?id=37874

        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange the order of the RendererType enum values, so that old versions of WebKitPlugi...
andersca@apple.com [Mon, 10 May 2010 18:12:14 +0000 (18:12 +0000)]
Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
use accelerated compositing and not layer backed views.

Reviewed by Simon Fraser.

* Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 10 May 2010 17:53:21 +0000 (17:53 +0000)]
2010-05-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Refactor WebGLArray types to share more code
        https://bugs.webkit.org/show_bug.cgi?id=37712

        Refactored WebGLArray types for maximal code sharing. Added
        WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
        superclasses. Changed overridden virtuals to have minimal
        visibility (private instead of public). Fixed const correctness of
        a few methods. There are no changes to the public APIs of the
        WebGLArray classes; the JavaScript bindings are unchanged.

        No new tests; existing tests cover this functionality. Ran all
        WebGL layout tests in Safari and Chromium on Mac OS X.

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * html/canvas/WebGLArray.h:
        (WebCore::WebGLArray::buffer):
        (WebCore::WebGLArray::baseAddress):
        (WebCore::WebGLArray::byteOffset):
        * html/canvas/WebGLByteArray.cpp:
        (WebCore::WebGLByteArray::create):
        (WebCore::WebGLByteArray::WebGLByteArray):
        (WebCore::WebGLByteArray::slice):
        * html/canvas/WebGLByteArray.h:
        (WebCore::WebGLByteArray::isByteArray):
        * html/canvas/WebGLFloatArray.cpp:
        (WebCore::WebGLFloatArray::create):
        (WebCore::WebGLFloatArray::WebGLFloatArray):
        (WebCore::WebGLFloatArray::slice):
        * html/canvas/WebGLFloatArray.h:
        (WebCore::WebGLFloatArray::set):
        (WebCore::WebGLFloatArray::item):
        (WebCore::WebGLFloatArray::isFloatArray):
        * html/canvas/WebGLIntArray.cpp:
        (WebCore::WebGLIntArray::create):
        (WebCore::WebGLIntArray::WebGLIntArray):
        (WebCore::WebGLIntArray::slice):
        * html/canvas/WebGLIntArray.h:
        (WebCore::WebGLIntArray::isIntArray):
        * html/canvas/WebGLIntegralTypedArrayBase.h: Added.
        (WebCore::WebGLIntegralTypedArrayBase::set):
        (WebCore::WebGLIntegralTypedArrayBase::item):
        (WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
        * html/canvas/WebGLShortArray.cpp:
        (WebCore::WebGLShortArray::create):
        (WebCore::WebGLShortArray::WebGLShortArray):
        (WebCore::WebGLShortArray::slice):
        * html/canvas/WebGLShortArray.h:
        (WebCore::WebGLShortArray::isShortArray):
        * html/canvas/WebGLTypedArrayBase.h: Added.
        (WebCore::WebGLTypedArrayBase::data):
        (WebCore::WebGLTypedArrayBase::set):
        (WebCore::WebGLTypedArrayBase::length):
        (WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase):
        (WebCore::WebGLTypedArrayBase::create):
        (WebCore::WebGLTypedArrayBase::sliceImpl):
        (WebCore::WebGLTypedArrayBase::byteLength):
        * html/canvas/WebGLUnsignedByteArray.cpp:
        (WebCore::WebGLUnsignedByteArray::create):
        (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
        (WebCore::WebGLUnsignedByteArray::slice):
        * html/canvas/WebGLUnsignedByteArray.h:
        (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
        * html/canvas/WebGLUnsignedIntArray.cpp:
        (WebCore::WebGLUnsignedIntArray::create):
        (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
        (WebCore::WebGLUnsignedIntArray::slice):
        * html/canvas/WebGLUnsignedIntArray.h:
        (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
        * html/canvas/WebGLUnsignedShortArray.cpp:
        (WebCore::WebGLUnsignedShortArray::create):
        (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
        (WebCore::WebGLUnsignedShortArray::slice):
        * html/canvas/WebGLUnsignedShortArray.h:
        (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
jer.noble@apple.com [Mon, 10 May 2010 17:25:38 +0000 (17:25 +0000)]
Unreviewed.

Adding myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, not reviewed.
bfulgham@webkit.org [Mon, 10 May 2010 17:12:11 +0000 (17:12 +0000)]
Build fix, not reviewed.

Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 16:23:36 +0000 (16:23 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Unreviewed.

        Further optimization for SVG's repaintRect calculation
        https://bugs.webkit.org/show_bug.cgi?id=38820

        New baseline for Qt.

        * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/qt/svg/css/mask-with-shadow-expected.txt:
        * platform/qt/svg/custom/empty-mask-expected.txt:
        * platform/qt/svg/custom/mask-invalidation-expected.txt:
        * platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/qt/svg/custom/transformedMaskFails-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 15:59:19 +0000 (15:59 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Further optimization for SVG's repaintRect calculation
        https://bugs.webkit.org/show_bug.cgi?id=38820

        This is a further optimization to get smaller repaintRects on SVG objects
        in combination with masker or clipper resources.
        Masker takes the unite of all stroke boundaries of it's childs.
        Both, clipper and masker, store this union to avoid multiple calls of the childs
        and the unite calculations now.
        The unite rect can be transformed to any targets objectBoundingBox, if the content
        unit of the resource is set to objectBoundingBoxMode.
        This speeds up the use of resources with multiple target objects.

        No behavior changes, the smaller repaintRects cause updates for DRT results.

        * rendering/RenderSVGResource.h:
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::invalidateClients):
        (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
        (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
        * rendering/RenderSVGResourceFilter.h:
        * rendering/RenderSVGResourceGradient.h:
        (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::invalidateClients):
        (WebCore::RenderSVGResourceMasker::createMaskImage):
        (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/RenderSVGResourcePattern.h:
        (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
        * rendering/RenderSVGResourceSolidColor.h:
        (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Further optimization for SVG's repaintRect calculation
        https://bugs.webkit.org/show_bug.cgi?id=38820

        The repaintRect of SVG objects with masks got smaller. This made
        updates of some results necessary.

        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
        * platform/mac/svg/batik/masking/maskRegions-expected.txt:
        * platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/mac/svg/css/mask-with-shadow-expected.txt:
        * platform/mac/svg/custom/empty-mask-expected.txt:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
        * platform/mac/svg/custom/mask-inside-defs-expected.txt:
        * platform/mac/svg/custom/mask-invalidation-expected.txt:
        * platform/mac/svg/custom/mask-with-all-units-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/visibility-override-mask-expected.txt:
        * svg/custom/transformedMaskFails-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 10 May 2010 15:21:41 +0000 (15:21 +0000)]
2010-05-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Cosmetic changes.
        1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
        2) Standard tooltips for resource links are clashing with Popover.
        3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
        https://bugs.webkit.org/show_bug.cgi?id=38732

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Mon, 10 May 2010 14:48:55 +0000 (14:48 +0000)]
2010-05-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        Layout test for Session Storage quota should only expect to fit 39 objects.
        https://bugs.webkit.org/show_bug.cgi?id=38843

        The script should be ready for the exception when inserting the 40th
        element, as that is where it will be thrown if a quota is enforced.
        This is the same change as in http://trac.webkit.org/changeset/50979.

        * storage/domstorage/quota-expected.txt:
        * storage/domstorage/script-tests/quota.js:
        (testNoQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Adam Langley <agl@chromium.org>
agl@chromium.org [Mon, 10 May 2010 14:36:20 +0000 (14:36 +0000)]
2010-05-10  Adam Langley  <agl@chromium.org>

        Expectations change. Not reviewed.

        Delete the current baselines for the WOFF test because they are
        incomplete.

        Remove the SKIP tag from test_expectations so that the builders
        will run the test and then the rebaseline tool can be used to
        checkin real baselines.

        * platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Removed.
        * platform/chromium-win/fast/css/font-face-woff-expected.checksum: Removed.
        * platform/chromium-win/fast/css/font-face-woff-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Mon, 10 May 2010 14:27:26 +0000 (14:27 +0000)]
2010-05-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
        https://bugs.webkit.org/show_bug.cgi?id=38750

        Put a per-origin quota on session storage since it is using memory in
        the browser process, and should not be allowed to grow arbitrarily
        large. See also http://trac.webkit.org/changeset/58828.

        * public/WebStorageNamespace.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createSessionStorageNamespace):
        * src/StorageNamespaceProxy.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):

2010-05-10  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
        https://bugs.webkit.org/show_bug.cgi?id=38750

        Put a per-origin quota on session storage since it is using memory in
        the browser process, and should not be allowed to grow arbitrarily
        large. See also http://trac.webkit.org/changeset/58828.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createSessionStorageNamespace):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
ossy@webkit.org [Mon, 10 May 2010 14:03:26 +0000 (14:03 +0000)]
[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.

Rubber-stamped by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=32967

WebCore:

* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/DumpRenderTreeQt.h:

LayoutTests:

* platform/qt/Skipped:
* platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>
eric@webkit.org [Mon, 10 May 2010 13:18:38 +0000 (13:18 +0000)]
2010-05-10  Markus Goetz  <Markus.Goetz@nokia.com>

        Reviewed by Simon Hausmann.

        Qt after 4.6.3 has its integrated DNS cache. Therefore some
        code is not necessary anymore.

        https://bugs.webkit.org/show_bug.cgi?id=38834

        * platform/network/qt/DnsPrefetchHelper.h:
        (WebCore::DnsPrefetchHelper::lookup):
        (WebCore::DnsPrefetchHelper::lookedUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 10 May 2010 13:07:31 +0000 (13:07 +0000)]
2010-05-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        [Qt] Disable JIT support for mingw-w64
        https://bugs.webkit.org/show_bug.cgi?id=38747

        Disale JIT for mingw-w64 as it is reportedly
        unstable.

        Thanks for Vanboxem Rruben for the investigation.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:53:47 +0000 (11:53 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Uneviewed.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        New baseline for Win. Only two tests needed an update.

        * platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/win/svg/filters/feColorMatrix-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Mon, 10 May 2010 11:40:49 +0000 (11:40 +0000)]
2010-05-10  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Darin Adler.

        Asserted that Node::setDocument() is not being used to change
        the document of a node.

        https://bugs.webkit.org/show_bug.cgi?id=38821

        * dom/Node.cpp:
        (WebCore::Node::setDocument):
          Added an ASSERT at the beginning of the function.
        * dom/Node.h:
          Documented that Node::setDocument() should not be used to change the
          document of a node until after the node has been removed from its
          prior document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:37:33 +0000 (11:37 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Unreviewed.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        New baseline for Gtk. Just one test needed an update.

        * platform/gtk/svg/filters/filter-on-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:34:49 +0000 (11:34 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Unreviewed.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        New baseline for Qt.

        * platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/qt/svg/filters/feColorMatrix-values-expected.txt:
        * platform/qt/svg/filters/feComposite-expected.txt:
        * platform/qt/svg/filters/feGaussianBlur-expected.txt:
        * platform/qt/svg/filters/feMerge-expected.txt:
        * platform/qt/svg/filters/feOffset-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/filters/filter-clip-expected.txt:
        * platform/qt/svg/filters/filter-on-tspan-expected.txt:
        * platform/qt/svg/filters/filter-source-position-expected.txt:
        * platform/qt/svg/filters/shadow-on-filter-expected.txt:
        * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/qt/svg/filters/sourceAlpha-expected.txt:
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/qt/svg/filters/subRegion-one-effect-expected.txt:
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 10 May 2010 11:15:25 +0000 (11:15 +0000)]
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        All SVG Filter effects get dumped now. The structure of the DRT output
        changed. The last effect is shown first, followed by the previous effects.

        No changed behaior, so no new test added.

        * platform/graphics/filters/FEBlend.cpp:
        (WebCore::operator<<):
        (WebCore::FEBlend::externalRepresentation):
        * platform/graphics/filters/FEBlend.h:
        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::operator<<):
        (WebCore::FEColorMatrix::externalRepresentation):
        * platform/graphics/filters/FEColorMatrix.h:
        * platform/graphics/filters/FEComponentTransfer.cpp:
        (WebCore::operator<<):
        (WebCore::FEComponentTransfer::externalRepresentation):
        * platform/graphics/filters/FEComponentTransfer.h:
        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::operator<<):
        (WebCore::FEComposite::externalRepresentation):
        * platform/graphics/filters/FEComposite.h:
        (WebCore::):
        (WebCore::FEComposite::uniteChildEffectSubregions):
        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::externalRepresentation):
        * platform/graphics/filters/FEGaussianBlur.h:
        (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::externalRepresentation):
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::externalRepresentation):
        * platform/graphics/filters/SourceAlpha.h:
        * platform/graphics/filters/SourceGraphic.cpp:
        (WebCore::SourceGraphic::externalRepresentation):
        * platform/graphics/filters/SourceGraphic.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeIndent):
        * rendering/RenderTreeAsText.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer):
        * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
        (WebCore::operator<<):
        (WebCore::FEConvolveMatrix::externalRepresentation):
        * svg/graphics/filters/SVGFEConvolveMatrix.h:
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
        (WebCore::FEDiffuseLighting::externalRepresentation):
        * svg/graphics/filters/SVGFEDiffuseLighting.h:
        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        (WebCore::operator<<):
        (WebCore::FEDisplacementMap::externalRepresentation):
        * svg/graphics/filters/SVGFEDisplacementMap.h:
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::externalRepresentation):
        * svg/graphics/filters/SVGFEFlood.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::externalRepresentation):
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::externalRepresentation):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFEMorphology.cpp:
        (WebCore::operator<<):
        (WebCore::FEMorphology::externalRepresentation):
        * svg/graphics/filters/SVGFEMorphology.h:
        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::externalRepresentation):
        * svg/graphics/filters/SVGFEOffset.h:
        * svg/graphics/filters/SVGFESpecularLighting.cpp:
        (WebCore::FESpecularLighting::externalRepresentation):
        * svg/graphics/filters/SVGFESpecularLighting.h:
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::externalRepresentation):
        * svg/graphics/filters/SVGFETile.h:
        * svg/graphics/filters/SVGFETurbulence.cpp:
        (WebCore::operator<<):
        (WebCore::FETurbulence::externalRepresentation):
        * svg/graphics/filters/SVGFETurbulence.h:
2010-05-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        SVG FilterEffects need more detailed DRT information
        https://bugs.webkit.org/show_bug.cgi?id=38683

        All SVG Filter effects get dumped now. The structure of the DRT output
        changed. The last effect is shown first, followed by the previous effects.

        * platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/filters/filterRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textFeatures-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/custom/visibility-override-filter-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-2-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feComposite-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feGaussianBlur-expected.txt:
        * platform/mac/svg/filters/feMerge-expected.txt:
        * platform/mac/svg/filters/feOffset-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filter-clip-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:
        * platform/mac/svg/filters/filter-source-position-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/filters/shadow-on-filter-expected.txt:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/mac/svg/filters/sourceAlpha-expected.txt:
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt:
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 10 May 2010 09:53:53 +0000 (09:53 +0000)]
2010-05-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Change IndexedDB to use events instead of callbacks
        https://bugs.webkit.org/show_bug.cgi?id=38594

        Switch IndexedDB over to an event based model to match what
        Mozilla (and probably MS?) are doing.  This also gets rid of
        a lot of template mess at the expense of a little extra boiler
        plate code (for each type that IDBResult.result could be).

        This change also introduces JSC bindings that match the level of
        functionality the V8 bindings have.

        Still not testable, but that shoudl change shortly.

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSIDBRequestCustom.cpp: Added.
        (WebCore::JSIDBRequest::result):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
        * bindings/v8/custom/V8IDBRequestCustom.cpp: Added.
        (WebCore::V8IDBRequest::resultAccessorGetter):
        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toIDBRequest):
        * dom/EventTarget.h:
        * storage/IDBCallbacks.h:
        * storage/IDBDatabaseRequest.h:
        (WebCore::IDBDatabaseRequest::createObjectStore):
        * storage/IDBRequest.cpp: Added.
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::~IDBRequest):
        (WebCore::IDBRequest::idbDatabaseResult):
        (WebCore::IDBRequest::serializedScriptValueResult):
        (WebCore::IDBRequest::onError):
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::abort):
        (WebCore::IDBRequest::scriptExecutionContext):
        (WebCore::IDBRequest::stop):
        (WebCore::IDBRequest::suspend):
        (WebCore::IDBRequest::resume):
        (WebCore::IDBRequest::eventTargetData):
        (WebCore::IDBRequest::ensureEventTargetData):
        (WebCore::IDBRequest::timerFired):
        (WebCore::IDBRequest::onEventCommon):
        * storage/IDBRequest.h: Added.
        (WebCore::IDBRequest::create):
        (WebCore::IDBRequest::):
        (WebCore::IDBRequest::resultType):
        (WebCore::IDBRequest::readyState):
        (WebCore::IDBRequest::error):
        (WebCore::IDBRequest::toIDBRequest):
        (WebCore::IDBRequest::refEventTarget):
        (WebCore::IDBRequest::derefEventTarget):
        * storage/IDBRequest.idl: Added.
        * storage/IndexedDatabase.h:
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
        * storage/IndexedDatabaseRequest.h:
        * storage/IndexedDatabaseRequest.idl:
2010-05-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Change IndexedDB to use events instead of callbacks
        https://bugs.webkit.org/show_bug.cgi?id=38594

        Change the glue here to match the changes I made in WebCore.

        * WebKit.gyp:
        * public/WebIDBCallbacks.h:
        * public/WebIndexedDatabase.h:
        * src/IDBCallbacksProxy.cpp: Added.
        (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::onError):
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IndexedDatabaseProxy.cpp:
        (WebCore::IndexedDatabaseProxy::open):
        * src/IndexedDatabaseProxy.h:
        * src/WebIndexedDatabaseImpl.cpp:
        (WebKit::WebIndexedDatabaseImpl::open):
        * src/WebIndexedDatabaseImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Mon, 10 May 2010 07:02:34 +0000 (07:02 +0000)]
2010-05-09  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
        https://bugs.webkit.org/show_bug.cgi?id=38723

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/MD5.cpp:
        (WTF::expectMD5):
          Fix for checksum change.
        (WTF::MD5::checksum):
          Take a reference to output, instead of returning the result by value, to reduce coping for performance.
        * wtf/MD5.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test expectation update.
tkent@chromium.org [Mon, 10 May 2010 05:07:50 +0000 (05:07 +0000)]
Unreviewed, test expectation update.

Update Chromium/Linux expectation for fast/forms/input-file-re-render.html.
http://crbug.com/40027

* platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
* platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix accidental repeat addition of emit_op_new_regexp
oliver@apple.com [Mon, 10 May 2010 02:17:55 +0000 (02:17 +0000)]
Fix accidental repeat addition of emit_op_new_regexp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Geoffrey Garen <ggaren@apple.com>
oliver@apple.com [Mon, 10 May 2010 01:41:07 +0000 (01:41 +0000)]
2010-05-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Reserve a large-ish initial capacity for Lexer::m_buffer16.

        SunSpider says 0.3% faster.

        m_buffer16 is used when parsing complex strings -- for example, strings
        with escape sequences in them. These kinds of strings can be really long,
        and we want to avoid repeatedly copying as we grow m_buffer16.

        The net memory cost is quite low, since it's proporitional to source
        code we already have in memory, and we throw away m_buffer16 right when
        we're done parsing.

        * parser/Lexer.cpp:
        (JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
        since setCode will be called before we're asked to lex anything.
        (JSC::Lexer::setCode): Reserve enough space to lex half the source code
        as a complex string without having to copy.
        (JSC::Lexer::clear): No need to reserve initial capacity here either,
        since setCode will be called before we're asked to lex anything.
2010-05-09  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
        https://bugs.webkit.org/show_bug.cgi?id=38828

        Replace incorrect test for caching regexp literals with ones that tests that they are not cached.

        * fast/js/regexp-literals-are-constants-expected.txt: Removed.
        * fast/js/regexp-literals-are-constants.html: Removed.
        * fast/js/regexp-literals-arent-constants-expected.txt: Added.
        * fast/js/regexp-literals-arent-constants.html: Added.
        * fast/js/script-tests/regexp-literals-are-constants.js: Removed.
        * fast/js/script-tests/regexp-literals-arent-constants.js: Added.
        (test1):
        (returnRegExpLiteral):
        (returnConditionalRegExpLiteral):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 9 May 2010 22:09:43 +0000 (22:09 +0000)]
2010-05-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Not reviewed: rollback the commit r59062

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 9 May 2010 21:38:18 +0000 (21:38 +0000)]
2010-05-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Cosmetic changes.
        1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
        2) Standard tooltips for resource links are clashing with Popover.
        3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
        https://bugs.webkit.org/show_bug.cgi?id=38732

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReserve a large-ish initial capacity for Lexer::m_buffer16.
ggaren@apple.com [Sun, 9 May 2010 21:16:16 +0000 (21:16 +0000)]
Reserve a large-ish initial capacity for Lexer::m_buffer16.

Reviewed by Oliver Hunt.

SunSpider says 0.3% faster.

m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.

The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.

* parser/Lexer.cpp:
(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 9 May 2010 21:11:50 +0000 (21:11 +0000)]
2010-05-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Remove YARR configuration rules from Qt make system
        https://bugs.webkit.org/show_bug.cgi?id=38819

        Setting YARR based on JIT seeting is now in Platform.h
        for all ports. This patch essentially reverses r49238.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 9 May 2010 20:58:42 +0000 (20:58 +0000)]
2010-05-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: If some record is not in visible area then it's expand element also is not
        visible even if it has children in visible area.
        https://bugs.webkit.org/show_bug.cgi?id=38643

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._refreshRecords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38557
weinig@apple.com [Sun, 9 May 2010 20:34:20 +0000 (20:34 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib

Reviewed by Darin Adler.

This fix does two things.
- Don't use QualifiedName as the key to a HashMap, use a
  RefPtr<QualifiedNameImpl> instead.  We should remove the HashTraits for
  QualifiedName and that will happen in a follow up patch.
- Only mark cached NodeLists on Documents instead of all Nodes. This is
  okay since the marking of NodeLists is an optimization to keep NodeList
  wrappers alive and is not mandated by any spec.

* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
* dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):
* dom/NodeRareData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-09 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 9 May 2010 16:37:25 +0000 (16:37 +0000)]
2010-05-09  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used
        https://bugs.webkit.org/show_bug.cgi?id=38574

        The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
        (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
        (QGraphicsWebViewPrivate::setRootGraphicsLayer):
        (QGraphicsWebViewPrivate::updateCompositingScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59057 268f45cc-cd09-0410-ab3c-d52691b4dbfc