WebKit-https.git
7 years agoStop calling Element::ensureShadowRoot() if it is used in construction phase.
commit-queue@webkit.org [Wed, 8 Feb 2012 08:57:08 +0000 (08:57 +0000)]
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 8 Feb 2012 08:47:02 +0000 (08:47 +0000)]
2012-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing results for a new SVG test.

        * platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
        * platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-02-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 8 Feb 2012 08:37:01 +0000 (08:37 +0000)]
2012-02-08  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, updating expectations to SKIP test that times out or crashes on most...
dmazzoni@google.com [Wed, 8 Feb 2012 08:29:22 +0000 (08:29 +0000)]
Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace [CheckNodeSecurity] with [CheckAccessToNode]
haraken@chromium.org [Wed, 8 Feb 2012 08:13:58 +0000 (08:13 +0000)]
Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

* page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

* http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
* http/tests/security/cross-frame-access-frameelement.html: Added.
* http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
haraken@chromium.org [Wed, 8 Feb 2012 08:05:56 +0000 (08:05 +0000)]
Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
https://bugs.webkit.org/show_bug.cgi?id=78081

Reviewed by Adam Barth.

[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* dom/Node.idl:
* html/HTMLElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] enable-webaudio WebSetting
philn@webkit.org [Wed, 8 Feb 2012 08:05:05 +0000 (08:05 +0000)]
[GTK][WK2] enable-webaudio WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77959

Reviewed by Martin Robinson.

Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Add WebKitResponsePolicyDecision
mrobinson@webkit.org [Wed, 8 Feb 2012 07:21:31 +0000 (07:21 +0000)]
[GTK] [WK2] Add WebKitResponsePolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=76789

Reviewed by Philippe Normand.

Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.

* GNUmakefile.am: Added new source files to the list.
* UIProcess/API/gtk/WebKitPolicyClient.cpp:
(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.
* UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
* UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
* UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
* UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:
(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move geometry headers in Platform API to Platform directory
commit-queue@webkit.org [Wed, 8 Feb 2012 06:56:26 +0000 (06:56 +0000)]
[chromium] Move geometry headers in Platform API to Platform directory
https://bugs.webkit.org/show_bug.cgi?id=78067

Patch by James Robinson <jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

Source/Platform:

This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.

Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.

* Platform.gyp/Platform.gyp:
* Platform.gyp/copy_webcore_headers.py: Added.
(CopyHeaders):
(Main):
* chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.
(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.
(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):
* chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.
(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.
(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.
(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.
(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):

Source/WebKit/chromium:

Add forwarding headers for several API types moved into Platform.

* public/platform/WebFloatPoint.h:
* public/platform/WebFloatQuad.h:
* public/platform/WebFloatRect.h:
* public/platform/WebPoint.h:
* public/platform/WebRect.h:
* public/platform/WebSize.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd "JS" prefix to JSC-specific IDLs
haraken@chromium.org [Wed, 8 Feb 2012 06:40:54 +0000 (06:40 +0000)]
Add "JS" prefix to JSC-specific IDLs
https://bugs.webkit.org/show_bug.cgi?id=77846

Reviewed by Darin Adler.

In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:

[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject]  (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate]  (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/TestTypedArray.idl:
* dom/Attr.idl:
* dom/DataTransferItemList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Node.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/DOMFormData.idl:
* html/DOMURL.idl:
* html/HTMLAppletElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLVideoElement.idl:
* html/TextTrackCue.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* mediastream/LocalMediaStream.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/StorageInfo.idl:
* svg/SVGElement.idl:
* svg/SVGElementInstance.idl:
* workers/DedicatedWorkerContext.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] WebTextCheckingResult should have new default constructor
morrita@google.com [Wed, 8 Feb 2012 06:33:11 +0000 (06:33 +0000)]
[Chromium] WebTextCheckingResult should have new default constructor
https://bugs.webkit.org/show_bug.cgi?id=78066

Reviewed by Ryosuke Niwa.

Added a new default constructor. ex-default constructor will be removed
in an upcoming change.

* public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
haraken@chromium.org [Wed, 8 Feb 2012 05:47:36 +0000 (05:47 +0000)]
Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
https://bugs.webkit.org/show_bug.cgi?id=78076

Reviewed by Adam Barth.

This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].

Test: bindings/scripts/test/TestCustomNamedGetter.idl

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

* html/HTMLDocument.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameSetElement.idl:

* bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.

* bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.
(WebCore):
(WebDOMTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.
(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.
(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.
(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.
(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.
(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert TableSection cell and border calculations to integers
eae@chromium.org [Wed, 8 Feb 2012 05:37:54 +0000 (05:37 +0000)]
Revert TableSection cell and border calculations to integers
https://bugs.webkit.org/show_bug.cgi?id=77918

Reviewed by Eric Seidel.

Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.

No new tests.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
* rendering/RenderTableSection.h:
(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlumb through webGLErrorsToConsoleEnable in WebSettings
commit-queue@webkit.org [Wed, 8 Feb 2012 05:34:09 +0000 (05:34 +0000)]
Plumb through webGLErrorsToConsoleEnable in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=78061

Patch by Gregg Tavares <gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessar...
commit-queue@webkit.org [Wed, 8 Feb 2012 05:06:33 +0000 (05:06 +0000)]
Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* wtf/Platform.h:

Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* WebCore.gypi:
* platform/PlatformGestureRecognizer.h: Removed.
* platform/chromium/FramelessScrollView.h:
(WebCore):
(FramelessScrollView):
* platform/chromium/GestureRecognizerChromium.cpp: Removed.
* platform/chromium/GestureRecognizerChromium.h: Removed.
* platform/chromium/PopupContainer.cpp:
(WebCore):
* platform/chromium/PopupContainer.h:
* platform/chromium/PopupListBox.cpp:
(WebCore):
* platform/chromium/PopupListBox.h:
(PopupListBox):

Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* blackberry/WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* WebKit.gypi:
* features.gypi:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
* tests/InnerGestureRecognizerTest.cpp: Removed.

LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

* fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
* fast/events/touch/page-scaled-touch-gesture-click.html:
* fast/events/touch/touch-gesture-click-expected.txt: Removed.
* fast/events/touch/touch-gesture-click.html: Removed.
* fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
* fast/events/touch/touch-gesture-scroll.html: Removed.
* platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
* platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
arv@chromium.org [Wed, 8 Feb 2012 04:23:34 +0000 (04:23 +0000)]
[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052

Reviewed by Nate Chapin.

Source/WebCore:

Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.

Covered by existing tests

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
haraken@chromium.org [Wed, 8 Feb 2012 04:14:02 +0000 (04:14 +0000)]
[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
leo.yang@torchmobile.com.cn [Wed, 8 Feb 2012 04:05:20 +0000 (04:05 +0000)]
[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd pixelSnappedX/Y/Width/Height methods
eae@chromium.org [Wed, 8 Feb 2012 03:56:27 +0000 (03:56 +0000)]
Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040

Reviewed by Eric Seidel.

Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.

When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.

In summary, the values are computed as follows:
        x: round(x)
        y: round(y)
        maxX: round(x + width)
        maxY: round(y + height)
        width: round(x + width) - round(x)
        height: round(y + height) - round(y)

We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.

No new tests, no functionality changes.

* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
* rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 8 Feb 2012 03:53:22 +0000 (03:53 +0000)]
Unreviewed gardening.

Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.

* platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS3 calc() - simple parse time evaluation
mikelawther@chromium.org [Wed, 8 Feb 2012 03:40:33 +0000 (03:40 +0000)]
CSS3 calc() - simple parse time evaluation
https://bugs.webkit.org/show_bug.cgi?id=77960

Source/WebCore:

Adds simple number/percent expression evaluation. rgb() and hsl() functions now
allow simple calc() expressions.

Reviewed by Ojan Vafai.

* css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parsedDouble):

LayoutTests:

Reviewed by Ojan Vafai.

* css3/calc/color-hsl-expected.txt:
* css3/calc/color-rgb-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
kling@webkit.org [Wed, 8 Feb 2012 03:26:18 +0000 (03:26 +0000)]
REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<http://webkit.org/b/78068>

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid making a window for the Web Inspector when it is docked.
timothy@apple.com [Wed, 8 Feb 2012 03:20:07 +0000 (03:20 +0000)]
Avoid making a window for the Web Inspector when it is docked.

This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.

https://webkit.org/b/78064

Reviewed by Brian Weinstein.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove TextureMapperQt from the gyp projects
noel.gordon@gmail.com [Wed, 8 Feb 2012 03:10:38 +0000 (03:10 +0000)]
Remove TextureMapperQt from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=78055

Reviewed by Noam Rosenthal.

TextureMapperQt.{cpp,h} were removed in r106659, remove references to
these files from the gyp projects.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomerge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
tony@chromium.org [Wed, 8 Feb 2012 03:00:36 +0000 (03:00 +0000)]
merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036

Reviewed by Darin Adler.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebCore:

In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.

No new tests, build refactoring.

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
* DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
* DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
* WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
* css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
* css/DashboardSupportCSSPropertyNames.in: Removed.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable IPP for FFTFrame
commit-queue@webkit.org [Wed, 8 Feb 2012 02:51:57 +0000 (02:51 +0000)]
Enable IPP for FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=75522

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07
Reviewed by Tony Chang.

Add the FFTFrame implementation using Intel IPP's DFT algorithm.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
(FFTFrame):
* platform/audio/FFTFrameStub.cpp:
* platform/audio/ipp/FFTFrameIPP.cpp: Added.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProperly detect top level frames when propogating compositing
enne@google.com [Wed, 8 Feb 2012 02:47:50 +0000 (02:47 +0000)]
Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoResolve crash in FrameLoader::checkTimerFired.
commit-queue@webkit.org [Wed, 8 Feb 2012 02:21:04 +0000 (02:21 +0000)]
Resolve crash in FrameLoader::checkTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=77907

Patch by Chris Palmer <palmer@google.com> on 2012-02-07
Reviewed by Eric Seidel.

Source/WebCore:

Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkTimerFired):

LayoutTests:

* http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
* http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
commit-queue@webkit.org [Wed, 8 Feb 2012 02:06:08 +0000 (02:06 +0000)]
[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=78039

Patch by Justin Novosad <junov@chromium.org> on 2012-02-07
Reviewed by Stephen White.

Adding the --enable-deferred-2d-canvas switch to DumpRenderTree

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setDeferred2dCanvasEnabled):
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
commit-queue@webkit.org [Wed, 8 Feb 2012 02:05:34 +0000 (02:05 +0000)]
[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
https://bugs.webkit.org/show_bug.cgi?id=78029

Patch by Yong Li <yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.

When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.

No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Use *bin* and *lib* directories for executable and libraries.
gyuyoung.kim@samsung.com [Wed, 8 Feb 2012 01:51:10 +0000 (01:51 +0000)]
[CMAKE] Use *bin* and *lib* directories for executable and libraries.
https://bugs.webkit.org/show_bug.cgi?id=77928

Reviewed by Daniel Bates.

CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.

.:

* CMakeLists.txt: Set library output path.
* Source/cmake/WebKitFS.cmake: Remove *Programs* creation.

Source/JavaScriptCore:

* shell/CMakeLists.txt: Change *Programs* with *bin*.

Source/WebKit2:

* CMakeLists.txt:

Tools:

* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* Scripts/run-launcher:
* Scripts/webkitdirs.pm:
(jscProductDir):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_driver):
(EflPort._path_to_image_diff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove extraneous MathML code before bug 52444 fix
commit-queue@webkit.org [Wed, 8 Feb 2012 01:49:27 +0000 (01:49 +0000)]
Remove extraneous MathML code before bug 52444 fix
https://bugs.webkit.org/show_bug.cgi?id=78034

Source/WebCore:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.

Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.

No new tests.

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore):
* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):
    - changed to a static member function since 'this' is unused;
      removed redundant non-const version
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):
    - changed to a static member function since 'this' is unused;
      removed redundant non-const version
(WebCore):
* rendering/mathml/RenderMathMLFraction.cpp:
* rendering/mathml/RenderMathMLMath.cpp:
* rendering/mathml/RenderMathMLMath.h:
* rendering/mathml/RenderMathMLOperator.h:
(WebCore):
* rendering/mathml/RenderMathMLRoot.cpp:
* rendering/mathml/RenderMathMLRow.cpp:
* rendering/mathml/RenderMathMLRow.h:
* rendering/mathml/RenderMathMLSquareRoot.cpp:
* rendering/mathml/RenderMathMLSquareRoot.h:
* rendering/mathml/RenderMathMLSubSup.cpp:
* rendering/mathml/RenderMathMLSubSup.h:
* rendering/mathml/RenderMathMLUnderOver.cpp:
* rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.

The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.

* mathml/presentation/row.xhtml:
* platform/mac/mathml/presentation/row-expected.png:
* platform/mac/mathml/presentation/row-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOverride expected-failure mac-leopard/media/media-blocked-by-beforeload-expected...
commit-queue@webkit.org [Wed, 8 Feb 2012 01:37:55 +0000 (01:37 +0000)]
Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=78030

Unreviewed.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.
timothy@apple.com [Wed, 8 Feb 2012 01:28:16 +0000 (01:28 +0000)]
Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.

If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of Source/autotools/webkit.m4
commit-queue@webkit.org [Wed, 8 Feb 2012 01:16:40 +0000 (01:16 +0000)]
Get rid of Source/autotools/webkit.m4
https://bugs.webkit.org/show_bug.cgi?id=77833

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Martin Robinson.

Move checks from webkit.m4 to configure.ac and modernize macros:
  . Check for visibility flags after CXX has been defined
  . Use PKG_PROG_PKG_CONFIG for pkg-config lookup
  . Drop unused LIBFFTW_REQUIRED_VERSION
  . Update ICU libs for mingw (bug 77837).
  . Require Pango 1.21.0 (as per unicode backend)
  . Bump minimum glib version due to g_thread_init changes

* Source/autotools/webkit.m4: Removed.
* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
commit-queue@webkit.org [Wed, 8 Feb 2012 01:03:07 +0000 (01:03 +0000)]
[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
https://bugs.webkit.org/show_bug.cgi?id=78020

Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

Revert r101854.

This patch is tested by the following unit test:
- TextureManagerTest.requestTextureExceedingPreferredLimit

* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::reserve):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):

Source/WebKit/chromium:

Update TextureManagerTest.requestTextureExceedingPreferredLimit test.

* tests/TextureManagerTest.cpp:
(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse the non-fast-scrollable region to detect when we can't do fast scrolling
andersca@apple.com [Wed, 8 Feb 2012 01:00:06 +0000 (01:00 +0000)]
Use the non-fast-scrollable region to detect when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=78056
<rdar://problem/10247932>

Reviewed by Sam Weinig.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.

* platform/graphics/Region.cpp:
* platform/graphics/Region.h:
Add a simple contains(const IntPoint&) member function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10475450> Synthetic bold is illegible under some scaling transforms
mitz@apple.com [Wed, 8 Feb 2012 00:59:11 +0000 (00:59 +0000)]
<rdar://problem/10475450> Synthetic bold is illegible under some scaling transforms
https://bugs.webkit.org/show_bug.cgi?id=78044

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/text/synthetic-bold-transformed-expected.html
       fast/text/synthetic-bold-transformed.html

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.

LayoutTests:

* fast/text/synthetic-bold-transformed-expected.html: Added.
* fast/text/synthetic-bold-transformed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add missing initialization of editable variable.
commit-queue@webkit.org [Wed, 8 Feb 2012 00:55:58 +0000 (00:55 +0000)]
[EFL] Add missing initialization of editable variable.
https://bugs.webkit.org/show_bug.cgi?id=77948

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07
Reviewed by Eric Seidel.

The value of editable in Ewk_Frame_Smart_Data struct is not set.

* ewk/ewk_frame.cpp:
(ewk_frame_editable_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate LayoutUnit usage in ColumnInfo and RenderFrameSet
leviw@chromium.org [Wed, 8 Feb 2012 00:52:39 +0000 (00:52 +0000)]
Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914

Reviewed by Eric Seidel.

Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.

No new tests. No changed behavior.

* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
* rendering/RenderFrameSet.h:
(RenderFrameSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd JSC support for delivering mutations when the outermost script context exits
adamk@chromium.org [Wed, 8 Feb 2012 00:40:31 +0000 (00:40 +0000)]
Add JSC support for delivering mutations when the outermost script context exits
https://bugs.webkit.org/show_bug.cgi?id=70289

Reviewed by Eric Seidel.

Source/WebCore:

The meat of this change is in JSMainThreadExecState, where a counter
is incremented every time WebCore calls into JSC and decremented every
time it returns. When the counter reaches zero, any pending mutations
are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope).

The rest of the changes are of two sorts: compilation/logic fixes for
JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional
usages of JSMainThreadExecState so as to trigger the above
increment/decrements at the appropriate times.

* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add support
for tryGetProperty with a HashMap<AtomicString>.
* bindings/js/JSDictionary.h:
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSMainThreadExecState.cpp:
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
Increment a static recursion level counter.
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
Decrement a static recursion level counter and, if we are
at zero (the outermost script invocation), deliver any
outstanding mutation records.
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
Use JSMainThreadExecState instead of JSC::call.
* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
Fix JSDictionary logic, add support for attributeFilter.

Tools:

* DumpRenderTree/mac/EventSendingController.mm: Add support for
eventSender.scheduleAsynchronousKeyDown.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
* Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.

LayoutTests:

With the various fixes in this change, 8/10 tests in fast/mutation
pass under WebKit/Mac. Of the failing tests, only one is due to
a deficiency in the Mac port's code (end-of-task-delivery.html);
the other is due to lack of support for a feature (FILE_SYSTEM)
exercised by the test (non-event-delivery.html).

* fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available.
* fast/mutation/observe-attributes.html: Fixed calls to removeEventListener.
* fast/mutation/observe-characterdata.html: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build.
andersca@apple.com [Wed, 8 Feb 2012 00:17:42 +0000 (00:17 +0000)]
Fix build.

* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollableAreaBoundingBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Use element disappears after scripted change
leviw@chromium.org [Wed, 8 Feb 2012 00:14:42 +0000 (00:14 +0000)]
[SVG] Use element disappears after scripted change
https://bugs.webkit.org/show_bug.cgi?id=74392

Reviewed by Eric Seidel.

Source/WebCore:

Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.

Test: svg/custom/use-disappears-after-style-update.svg

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::didRecalcStyle):

LayoutTests:

* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* svg/custom/use-disappears-after-style-update.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
haraken@chromium.org [Wed, 8 Feb 2012 00:00:18 +0000 (00:00 +0000)]
Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973

Reviewed by Adam Barth.

This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomedia/audio-data-url.html test broken on Lion
jer.noble@apple.com [Tue, 7 Feb 2012 23:53:02 +0000 (23:53 +0000)]
media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779

Reviewed by Eric Carlson.

Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrolling tree should keep track of region we can't do fast scrolling for
andersca@apple.com [Tue, 7 Feb 2012 23:47:59 +0000 (23:47 +0000)]
Scrolling tree should keep track of region we can't do fast scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050

Reviewed by Dan Bernstein.

We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.

* page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.

* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.

* platform/ScrollableArea.h:
Add scrollableAreaBoundingBox member function.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agounicode-bidi:plaintext is supposed to be effective on display:inline elements too
leviw@chromium.org [Tue, 7 Feb 2012 23:46:40 +0000 (23:46 +0000)]
unicode-bidi:plaintext is supposed to be effective on display:inline elements too
https://bugs.webkit.org/show_bug.cgi?id=73310

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.

Tests: fast/text/international/inline-plaintext-is-isolated-expected.html
       fast/text/international/inline-plaintext-is-isolated.html
       fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
       fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
       fast/text/international/inline-plaintext-with-generated-content-expected.html
       fast/text/international/inline-plaintext-with-generated-content.html

* platform/text/UnicodeBidi.h:
(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.
* rendering/InlineIterator.h:
(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.

LayoutTests:

Ref tests for unicode-bidi: plaintext on inlines.

* fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
* fast/text/international/inline-plaintext-is-isolated.html: Added.
* fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
* fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
* fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
* fast/text/international/inline-plaintext-with-generated-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash on http://www.rickshawbags.com/
barraclough@apple.com [Tue, 7 Feb 2012 23:43:28 +0000 (23:43 +0000)]
Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045

Reviewed by Darin Adler.

Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()

This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.

* runtime/JSType.h:
    - sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
      and thus is excluded from isVariableObject() checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
haraken@chromium.org [Tue, 7 Feb 2012 23:38:19 +0000 (23:38 +0000)]
[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957

Reviewed by Adam Barth.

This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Crash when using per-tile painting on Windows.
commit-queue@webkit.org [Tue, 7 Feb 2012 23:29:58 +0000 (23:29 +0000)]
[Chromium] Crash when using per-tile painting on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75715

Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.

Tested with manual tests.

* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.
jer.noble@apple.com [Tue, 7 Feb 2012 23:12:27 +0000 (23:12 +0000)]
Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.

* platform/mac/PlatformClockCM.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening after r106982.
jchaffraix@webkit.org [Tue, 7 Feb 2012 23:07:47 +0000 (23:07 +0000)]
Unreviewed gardening after r106982.

* platform/chromium/test_expectations.txt:
We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unit test for bug #77996
commit-queue@webkit.org [Tue, 7 Feb 2012 23:03:10 +0000 (23:03 +0000)]
[chromium] Unit test for bug #77996
https://bugs.webkit.org/show_bug.cgi?id=78019

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream DumpRenderTreeSupport
commit-queue@webkit.org [Tue, 7 Feb 2012 22:52:27 +0000 (22:52 +0000)]
[BlackBerry] Upstream DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=77991

Patch by Rob Buis <rbuis@rim.com> on 2012-02-07
Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

* blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.
(toGeolocationClientMock):
(DumpRenderTreeSupport::DumpRenderTreeSupport):
(DumpRenderTreeSupport::~DumpRenderTreeSupport):
(DumpRenderTreeSupport::javaScriptObjectsCount):
(DumpRenderTreeSupport::garbageCollectorCollect):
(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
(DumpRenderTreeSupport::linksIncludedInFocusChain):
(DumpRenderTreeSupport::dumpConfigurationForViewport):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
* blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.
(WebKit):
(WebCore):
(WTF):
(DumpRenderTreeSupport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Allow retaining texture across frames in composited video playback and...
jamesr@google.com [Tue, 7 Feb 2012 22:20:25 +0000 (22:20 +0000)]
[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
https://bugs.webkit.org/show_bug.cgi?id=77923

Reviewed by Kenneth Russell.

Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
error checking in case the TextureManager cannot successfully reserve memory for the texture.

Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
continues and that we don't create a new set of textures for each plane on each frame.

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::reserveTextures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB createIndex should fail if options arg is invalid
commit-queue@webkit.org [Tue, 7 Feb 2012 22:18:29 +0000 (22:18 +0000)]
IndexedDB createIndex should fail if options arg is invalid
https://bugs.webkit.org/show_bug.cgi?id=58467

Patch by Eugene Girard <girard@chromium.org> on 2012-02-07
Reviewed by Tony Chang.

This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.

* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/resources/index-basics.js:
(deleteExisting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 7 Feb 2012 22:08:07 +0000 (22:08 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Mark those 2 tests as crashing in Debug as they seem
to be hitting an ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, paint the bots green.
ossy@webkit.org [Tue, 7 Feb 2012 22:02:18 +0000 (22:02 +0000)]
[Qt] Unreviewed gardening, paint the bots green.

* platform/qt/Skipped: Skip failing/crashing tests, because we like regressions in trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=77912
mdelaney@apple.com [Tue, 7 Feb 2012 21:52:58 +0000 (21:52 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=77912
Removing old CG shadow code.

A CG-specific shadow offset hack was added in http://trac.webkit.org/changeset/34317
for this particular setShadow method. However, this shadow offset adjustment for CG
has since moved down into platform specific code. Thus, this offset adjustment here
is now redundant.

The CG-only shadow setting code block in this setShadow method is now redundant.
Since it sets the shadow values to the CGContext directly - and not to the State object -
it will be overwritten later by any subsequent calls to setting shadow values such as
blur, offset, or shadow color.

Reviewed by Simon Fraser.

No new tests. Current canvas tests cover this path.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProcess Scroll-gesture events from the compositor.
commit-queue@webkit.org [Tue, 7 Feb 2012 21:52:21 +0000 (21:52 +0000)]
Process Scroll-gesture events from the compositor.
https://bugs.webkit.org/show_bug.cgi?id=77477

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-07
Reviewed by James Robinson.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Gracefully handle compositor initialization failure in single-threaded...
jamesr@google.com [Tue, 7 Feb 2012 21:50:57 +0000 (21:50 +0000)]
[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
https://bugs.webkit.org/show_bug.cgi?id=78013

Reviewed by Kenneth Russell.

If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
some early outs.

Tested manually by forcing the first makeContextCurrent() call fail.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Keep a reference in didReceiveInvalidMessage.
ap@apple.com [Tue, 7 Feb 2012 21:48:24 +0000 (21:48 +0000)]
    Keep a reference in didReceiveInvalidMessage.
        https://bugs.webkit.org/show_bug.cgi?id=78024

        Reviewed by Anders Carlsson.

        * UIProcess/WebConnectionToWebProcess.cpp:
        (WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Chris Rogers to reviewers section
crogers@google.com [Tue, 7 Feb 2012 21:46:15 +0000 (21:46 +0000)]
Add Chris Rogers to reviewers section
https://bugs.webkit.org/show_bug.cgi?id=78016

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agolayoutTestController.display() is flaky for SVG tests
zimmermann@webkit.org [Tue, 7 Feb 2012 21:37:43 +0000 (21:37 +0000)]
layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Dan Bernstein.

Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/9567286> and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit...
beidson@apple.com [Tue, 7 Feb 2012 21:37:17 +0000 (21:37 +0000)]
<rdar://problem/9567286> and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html

Associate the credential with the URL of the challenge itself, not the original request:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

LayoutTests:

* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r106958.
jchaffraix@webkit.org [Tue, 7 Feb 2012 21:24:53 +0000 (21:24 +0000)]
Revert r106958.

* platform/chromium/test_expectations.txt:
It was a mistake as the test is really flaky not slow,
so now it is taking way longer to fail (see http://webkit.org/b/77997).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomove warning about css values and render style constants closer to where it applies
tony@chromium.org [Tue, 7 Feb 2012 21:22:29 +0000 (21:22 +0000)]
move warning about css values and render style constants closer to where it applies
https://bugs.webkit.org/show_bug.cgi?id=78017

Reviewed by Darin Adler.

Move the warning about keeping RenderStyleConstnats.h enums and
CSSValueKeywords.in values in the same order closer to the properties
that the warning applies to. The warning was easy to miss and was
confusing since it doesn't apply to most values.

Also refactor 2 conversion functions to
enumerate the possible values so the order doesn't matter.

No new tests, just refactoring and comment cleanup.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().
* css/CSSValueKeywords.in:
* css/SVGCSSPropertyNames.in:
* css/SVGCSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse CMClock as a timing source for PlatformClock where available.
jer.noble@apple.com [Tue, 7 Feb 2012 20:48:30 +0000 (20:48 +0000)]
Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885

Reviewed by Eric Carlson.

Source/JavaScriptCore:

* wtf/Platform.h: Added WTF_USE_COREMEDIA.

Source/WebCore:

No new tests; performance improvement covered by existing test cases.

* WebCore.xcodeproj/project.pbxproj:
* platform/Clock.cpp:
(Clock::create): Use PlatformClockCM if available.
* platform/mac/PlatformClockCM.h: Added.
(WebCore::PlatformClockCM::playRate):
(WebCore::PlatformClockCM::isRunning):
* platform/mac/PlatformClockCM.mm: Added.
(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
(PlatformClockCM::setCurrentTime):
(PlatformClockCM::currentTime):
(PlatformClockCM::setPlayRate):
(PlatformClockCM::start):
(PlatformClockCM::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrollableAreaSet should be moved from Page to FrameView
andersca@apple.com [Tue, 7 Feb 2012 20:45:52 +0000 (20:45 +0000)]
ScrollableAreaSet should be moved from Page to FrameView
https://bugs.webkit.org/show_bug.cgi?id=62762

Reviewed by Beth Dakin.

Source/WebCore:

It makes more sense for the set of scrollable areas to be per frame view instead of per page;
scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.

* WebCore.exp.in:
Replace the Page member functions with FrameView member functions instead.

* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
Check if the frame view contains the given layer.

(WebCore::EventHandler::updateMouseEventTargetNode):
Ditto.

* page/FocusController.cpp:
(WebCore::contentAreaDidShowOrHide):
Add helper function.

(WebCore::FocusController::setContainingWindowIsVisible):
Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
inside all subframe views.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.

(WebCore::FrameView::~FrameView):
Don't remove the scrollable area here.

(WebCore::FrameView::zoomAnimatorTransformChanged):
m_page is gone so use m_frame->page() instead.

(WebCore::FrameView::setAnimatorsAreActive):
Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
this will be done implicitly.

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
to do this for all scrollable areas on the page, but we only need to do it for this frame view.

(WebCore::FrameView::scrollAnimatorEnabled):
Get the page from m_frame since m_page is gone.

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea):
Move these member functions here from Page.

(WebCore::FrameView::addChild):
If we are adding a frame view, add it to the scrollable area set.

(WebCore::FrameView::removeChild):
If we are removing a frame view, remove it from the scrollable area set.

* page/FrameView.h:
Move the member function declarations and the scrollable area set member variable here from Page.

* page/Page.cpp:
(WebCore::Page::~Page):
Don't call disconnectPage on the scrollable areas anymore.

* platform/ScrollView.h:
(ScrollView):
Make addChild and removeChild virtual.

* platform/ScrollableArea.h:
Remove disconnectFromPage.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::styleChanged):
The frame view now keeps track of the scrollable areas.

* rendering/RenderLayer.h:
Remove the page member variable and disconnectFromPage.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
The frame view now keeps track of the scrollable areas.

* rendering/RenderListBox.h:
Remove the page member variable and disconnectFromPage.

Source/WebKit/chromium:

Update for changes to WebCore now that the scrollable area set is kept per frame view.

* src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
* src/ScrollbarGroup.h:
(WebCore):
(ScrollbarGroup):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::scrollbarGroup):

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::initialize):
Call FrameView::addScrollableArea instead.

(WebKit::BuiltInPDFView::destroy):
Call FrameView::removeScrollableArea instead.

* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Remove disconnectFromPage since it no longer exists on ScrollableArea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry...
commit-queue@webkit.org [Tue, 7 Feb 2012 20:40:08 +0000 (20:40 +0000)]
[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77993

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-07
Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h: Added.
* blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 7 Feb 2012 20:28:57 +0000 (20:28 +0000)]
Unreviewed gardening.

* platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
* platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Rebaseline some old entries in test_expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocreateImpulseBuffer uses incorrect length
commit-queue@webkit.org [Tue, 7 Feb 2012 20:16:09 +0000 (20:16 +0000)]
createImpulseBuffer uses incorrect length
https://bugs.webkit.org/show_bug.cgi?id=77665

Patch by Raymond Toy <rtoy@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

* webaudio/resources/audio-testing.js:
(createImpulseBuffer):  Fix bug so the buffer has the correct
length.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant checks in CanvasRenderingContext2D.cpp
mdelaney@apple.com [Tue, 7 Feb 2012 20:04:23 +0000 (20:04 +0000)]
Remove redundant checks in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=78000

Reviewed by Dan Bernstein.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in ContainerNode functions due to mutation events.
inferno@chromium.org [Tue, 7 Feb 2012 20:01:42 +0000 (20:01 +0000)]
Crash in ContainerNode functions due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=77999

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add RefPtr to protect premature deletion of this due to mutation events.

Tests: fast/dom/remove-body-during-body-replacement.html
       fast/dom/remove-body-during-body-replacement2.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):

LayoutTests:

* fast/dom/remove-body-during-body-replacement-expected.txt: Added.
* fast/dom/remove-body-during-body-replacement.html: Added.
* fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
* fast/dom/remove-body-during-body-replacement2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
jsbell@chromium.org [Tue, 7 Feb 2012 19:59:12 +0000 (19:59 +0000)]
[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

Unreviewed test expectations change. Removed this expectation in r106857
but it's still timing out so restoring it for now.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Memory bug during occlusion tracking if Vector::append() needs to realloca...
commit-queue@webkit.org [Tue, 7 Feb 2012 19:46:49 +0000 (19:46 +0000)]
[Chromium] Memory bug during occlusion tracking if Vector::append() needs to reallocate the buffer
https://bugs.webkit.org/show_bug.cgi?id=77996

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

We're holding onto the last element in the Vector and then calling
append(). If append() reallocates the Vector's buffer, the pointer
is no longer valid.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::enterTargetRenderSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Crash due to column style not updated on post block
inferno@chromium.org [Tue, 7 Feb 2012 19:37:26 +0000 (19:37 +0000)]
Source/WebCore: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

Test: fast/multicol/span/split-inline-wrong-post-block-crash.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):

LayoutTests: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

* fast/multicol/span/split-inline-wrong-post-block-crash-expected.txt: Added.
* fast/multicol/span/split-inline-wrong-post-block-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 7 Feb 2012 19:34:29 +0000 (19:34 +0000)]
Unreviewed gardening.

* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
* platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen
on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
commit-queue@webkit.org [Tue, 7 Feb 2012 19:30:40 +0000 (19:30 +0000)]
[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
https://bugs.webkit.org/show_bug.cgi?id=77896

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by Kenneth Russell.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium: remove WebSpeechInputResult::set
hans@chromium.org [Tue, 7 Feb 2012 19:26:26 +0000 (19:26 +0000)]
Chromium: remove WebSpeechInputResult::set
https://bugs.webkit.org/show_bug.cgi?id=77977

Reviewed by Darin Fisher.

It was renamed to assign() in r106475.

Source/WebKit/chromium:

* public/WebSpeechInputResult.h:

Tools:

* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
(makeRectResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoApple/Safari: Enable WebGL multisampling on ATI cards
dino@apple.com [Tue, 7 Feb 2012 19:18:47 +0000 (19:18 +0000)]
Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Address review comments by Alexey Proskuryakov and Mark Rowe.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocomposited mask test for CSS3 calc
mikelawther@chromium.org [Tue, 7 Feb 2012 19:18:19 +0000 (19:18 +0000)]
composited mask test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76006

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/resources/alpha-gradient.png: Added.
* css3/calc/simple-composited-mask-expected-mismatch.html: Added.
* css3/calc/simple-composited-mask.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac
commit-queue@webkit.org [Tue, 7 Feb 2012 19:03:21 +0000 (19:03 +0000)]
[Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac
https://bugs.webkit.org/show_bug.cgi?id=75132

Unreviewed, chromium expectations update.
Fixed with http://crrev.com/120714.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 7 Feb 2012 18:57:10 +0000 (18:57 +0000)]
[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76998

Reviewed by Martin Robinson.

* GNUmakefile.am: Add WebKitEditingCommands.h.
* UIProcess/API/gtk/WebKitEditingCommands.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(didValidateCommand): Callback called by the C API when an editor
command has been validated.
(webkit_web_view_can_execute_editing_command): Asynchronously
validate the given editing command.
(webkit_web_view_can_execute_editing_command_finish): Finish async
operation started by webkit_web_view_can_execute_editing_command().
(webkit_web_view_execute_editing_command): Execute the given
command.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
loop on load failure, now finished is always called.
* UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest
instead of LoadTrackingTest.
* UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.
(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(loadChanged):
(WebViewTest::waitUntilLoadFinished): Run a main loop until load
finished.
* UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
* UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDashboard on perf-o-matic should be sorted
rniwa@webkit.org [Tue, 7 Feb 2012 18:54:24 +0000 (18:54 +0000)]
Dashboard on perf-o-matic should be sorted
https://bugs.webkit.org/show_bug.cgi?id=77924

Reviewed by Tony Chang.

Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.

* Websites/webkit-perf.appspot.com/js/config.js:
(fetchDashboardManifest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, chromium expectations update.
commit-queue@webkit.org [Tue, 7 Feb 2012 18:49:10 +0000 (18:49 +0000)]
Unreviewed, chromium expectations update.
[Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD
https://bugs.webkit.org/show_bug.cgi?id=77412

Fixed with http://crrev.com/120714.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 7 Feb 2012 17:45:05 +0000 (17:45 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Mark an SVG test as SLOW.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: CodeGeneratorInspector.py: extend Array validator functionality
vsevik@chromium.org [Tue, 7 Feb 2012 17:38:00 +0000 (17:38 +0000)]
Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
https://bugs.webkit.org/show_bug.cgi?id=77919

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Reviewed by Yury Semikhatsky.

Array validator method runtimeCast is added, internal backing method
is moved from .cpp to .h (it's template anyway), boolean validator is
supported.

* inspector/CodeGeneratorInspector.py:
(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params):
(TypeBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoApple/Safari: Enable WebGL multisampling on ATI cards
dino@apple.com [Tue, 7 Feb 2012 17:34:59 +0000 (17:34 +0000)]
Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Reviewed by Chris Marrin.

Follow Chrome's lead to allow WebGL antialiasing
on ATI cards as long as we're on 10.7.2 and above.

No new tests. Covered by existing tests.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test media/controls-drag-timebar.html is flaky
commit-queue@webkit.org [Tue, 7 Feb 2012 17:21:25 +0000 (17:21 +0000)]
[Chromium] Layout Test media/controls-drag-timebar.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77531

No more flakiness.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
Reviewed by Eric Carlson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening.
ossy@webkit.org [Tue, 7 Feb 2012 17:19:02 +0000 (17:19 +0000)]
[Qt][WK2] Unreviewed gardening.

* platform/qt-wk2/Skipped: Skip failing tests, because we like regressions in trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add generic support for undo-ing DOM edits.
pfeldman@chromium.org [Tue, 7 Feb 2012 17:00:32 +0000 (17:00 +0000)]
Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html
       inspector/elements/undo-dom-edits.html
       inspector/styles/undo-add-property.html
       inspector/styles/undo-change-property.html
       inspector/styles/undo-property-toggle.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorCSSAgent.cpp:
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(InspectorDOMAgent::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::perform):
(WebCore::InspectorDOMAgent::DOMAction::undo):
(WebCore):
(InspectorDOMAgent::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::perform):
(WebCore::InspectorDOMAgent::RemoveChildAction::undo):
(InspectorDOMAgent::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::perform):
(WebCore::InspectorDOMAgent::InsertBeforeAction::undo):
(InspectorDOMAgent::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::perform):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::undo):
(InspectorDOMAgent::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::perform):
(WebCore::InspectorDOMAgent::SetAttributeAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::perform):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::newNode):
(InspectorDOMAgent::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::perform):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::undo):
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore::InspectorDOMAgent::markUndoableState):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):
* inspector/InspectorHistory.cpp: Added.
(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):
* inspector/InspectorHistory.h: Added.
(WebCore):
(InspectorHistory):
(Action):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):
* inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):
* inspector/elements/undo-dom-edits-2-expected.txt: Added.
* inspector/elements/undo-dom-edits-2.html: Added.
* inspector/elements/undo-dom-edits-expected.txt: Added.
* inspector/elements/undo-dom-edits.html: Added.
* inspector/styles/undo-add-property-expected.txt: Added.
* inspector/styles/undo-add-property.html: Added.
* inspector/styles/undo-change-property-expected.txt: Added.
* inspector/styles/undo-change-property.html: Added.
* inspector/styles/undo-property-toggle-expected.txt: Added.
* inspector/styles/undo-property-toggle.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, more svg rebaselines following change in r106918.
tonyg@chromium.org [Tue, 7 Feb 2012 16:55:19 +0000 (16:55 +0000)]
Unreviewed, more svg rebaselines following change in r106918.

* platform/chromium-linux/svg/text/text-text-05-t-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r106935.
tonyg@chromium.org [Tue, 7 Feb 2012 16:43:23 +0000 (16:43 +0000)]
Unreviewed, rolling out r106935.
http://trac.webkit.org/changeset/106935
https://bugs.webkit.org/show_bug.cgi?id=77994

"Crashes runMultiThread webkit_unit_test" (Requested by tonyg-
cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* public/WebWidget.h:
(WebWidget):
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Tue, 7 Feb 2012 16:28:17 +0000 (16:28 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip one more test because of this bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEncode radius, force and rotationAngle in WebPlatformTouchPoint.
commit-queue@webkit.org [Tue, 7 Feb 2012 16:18:30 +0000 (16:18 +0000)]
Encode radius, force and rotationAngle in WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=77986

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

* Shared/WebEvent.h:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::radius):
(WebKit::WebPlatformTouchPoint::rotationAngle):
(WebKit::WebPlatformTouchPoint::force):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
* Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening after r106898. Update platform specific expected results
ossy@webkit.org [Tue, 7 Feb 2012 16:16:16 +0000 (16:16 +0000)]
Unreviewed gardening after r106898. Update platform specific expected results

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r106932.
commit-queue@webkit.org [Tue, 7 Feb 2012 16:13:37 +0000 (16:13 +0000)]
Unreviewed, rolling out r106932.
http://trac.webkit.org/changeset/106932
https://bugs.webkit.org/show_bug.cgi?id=77988

Breaks Mac bots (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorHistory.cpp: Removed.
* inspector/InspectorHistory.h: Removed.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheetForInlineStyle::text):
* inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype.handleShortcut):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
* inspector/elements/undo-dom-edits-2-expected.txt: Removed.
* inspector/elements/undo-dom-edits-2.html: Removed.
* inspector/elements/undo-dom-edits-expected.txt: Removed.
* inspector/elements/undo-dom-edits.html: Removed.
* inspector/styles/undo-add-property-expected.txt: Removed.
* inspector/styles/undo-add-property.html: Removed.
* inspector/styles/undo-change-property-expected.txt: Removed.
* inspector/styles/undo-change-property.html: Removed.
* inspector/styles/undo-property-toggle-expected.txt: Removed.
* inspector/styles/undo-property-toggle.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Give emulated touch-point a radius
commit-queue@webkit.org [Tue, 7 Feb 2012 16:09:43 +0000 (16:09 +0000)]
[Qt] Give emulated touch-point a radius
https://bugs.webkit.org/show_bug.cgi?id=77985

Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/qml/MockTouchPoint.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate .gitignore for Qt Creator/KDevelop.
commit-queue@webkit.org [Tue, 7 Feb 2012 16:00:58 +0000 (16:00 +0000)]
Update .gitignore for Qt Creator/KDevelop.
https://bugs.webkit.org/show_bug.cgi?id=77984

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-07
Reviewed by Simon Hausmann.

* .gitignore: Ignore temp files created by Qt Creator and KDevelop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106945 268f45cc-cd09-0410-ab3c-d52691b4dbfc