WebKit-https.git
9 years ago2010-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 9 Jun 2010 21:39:42 +0000 (21:39 +0000)]
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Update readPixels to take ArrayBufferView rather than returning it
        https://bugs.webkit.org/show_bug.cgi?id=40322

        No new tests; covered by existing tests, which have been modified.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::readPixels):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Test how XML directives get attached to the DOM
        https://bugs.webkit.org/show_bug.cgi?id=40384

        In the old parser, the XML directive doesn't get added to the DOM.  In
        new parser (and in Minefield), it gets added as a comment, which shows
        up in this test.

        This behavior was tested more obliquely by
        fast/css-generated-content/hover-style-change.html in some
        DumpRenderTree output.  I've removed that coverage from the CSS test
        and moved it to a new parser test that can actually be run in other
        browsers.

        * fast/css-generated-content/hover-style-change.html:
            - Remove XML directive that was causing this test to depend on
              out-of-spec parser behavior w.r.t. whether to attach the XML
              directive to the DOM.
        * fast/parser/xml-directive-in-dom-expected.txt: Added.
        * fast/parser/xml-directive-in-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 21:19:51 +0000 (21:19 +0000)]
2010-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Test how XML directives get attached to the DOM
        https://bugs.webkit.org/show_bug.cgi?id=40384

        In the old parser, the XML directive doesn't get added to the DOM.  In
        new parser (and in Minefield), it gets added as a comment, which shows
        up in this test.

        This behavior was tested more obliquely by
        fast/css-generated-content/hover-style-change.html in some
        DumpRenderTree output.  I've removed that coverage from the CSS test
        and moved it to a new parser test that can actually be run in other
        browsers.

        * fast/css-generated-content/hover-style-change.html:
            - Remove XML directive that was causing this test to depend on
              out-of-spec parser behavior w.r.t. whether to attach the XML
              directive to the DOM.
        * fast/parser/xml-directive-in-dom-expected.txt: Added.
        * fast/parser/xml-directive-in-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 21:07:15 +0000 (21:07 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Laszlo Gombos.

        [Qt] ContextMenuClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40242

        * WebCoreSupport/ContextMenuClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Fix drawing zero-sized gradients on Canvas.
jchaffraix@webkit.org [Wed, 9 Jun 2010 21:02:47 +0000 (21:02 +0000)]
WebCore: Fix drawing zero-sized gradients on Canvas.
https://bugs.webkit.org/show_bug.cgi?id=40340

Patch by Enrico Ros <eros@codeaurora.org> on 2010-06-09
Reviewed by Ariya Hidayat.

HTML5 draft says that nothing must be painted if the gradient start
point equals the stop point.

This commit fixes the following canvas test:
http://philip.html5.org/tests/canvas/suite/tests/2d.gradient.interpolate.zerosize.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect): skip zero-sized linear gradients
* platform/graphics/Gradient.h:
(WebCore::Gradient::isRadial): made public
(WebCore::Gradient::isZeroSize): true if start == stop

LayoutTests: Fixed zero-sized gradients on canvas.
https://bugs.webkit.org/show_bug.cgi?id=40340

Patch by Enrico Ros <eros@codeaurora.org> on 2010-06-09
Reviewed by Ariya Hidayat.

* platform/mac/Skipped: Unskip the test that is passing now.
* platform/qt/Skipped: Unskip the test that is passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 20:53:30 +0000 (20:53 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] ChromeClientQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40240

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::pageRect):
        (WebCore::ChromeClientQt::createWindow):
        (WebCore::ChromeClientQt::runJavaScriptAlert):
        (WebCore::ChromeClientQt::runJavaScriptConfirm):
        (WebCore::ChromeClientQt::runJavaScriptPrompt):
        (WebCore::ChromeClientQt::print):
        (WebCore::ChromeClientQt::attachRootGraphicsLayer):
        (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Wed, 9 Jun 2010 20:31:37 +0000 (20:31 +0000)]
2010-06-09  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Adam Treat.

        [EFL] Allow building core libraries as shared objects to speed up
        linking time on machines with small amounts of memory.
        http://webkit.org/b/39899

        * CMakeLists.txt: Add SHARED_CORE option.
        * cmake/FindGlib.cmake: Add GObject to the list of GLib libraries to
        search.
        * cmake/OptionsEfl.cmake: Remove default library type definitions.
        * cmake/WebKitHelpers.cmake: -fvisibility=hidden did not behave well
        when SHARED_CORE is used.
2010-06-09  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Adam Treat.

        [EFL] Allow building core libraries as shared objects to speed up
        linking time on machines with small amounts of memory.
        http://webkit.org/b/39899

        * CMakeLists.txt: If building with shared core, install the lib.
        * jsc/CMakeListsEfl.txt: Needs Glib and Ecore to link dynamically.
        * wtf/CMakeLists.txt: If building with shared core, install the lib.
2010-06-09  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Adam Treat.

        [EFL] Allow building core libraries as shared objects to speed up
        linking time on machines with small amounts of memory.
        http://webkit.org/b/39899

        * CMakeLists.txt: If building with shared core, install the lib.
        Remove npapi.cpp (causes conflicts when linking dynamically).
        * CMakeListsEfl.txt: EFL libraries are needed to link dynamically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8070662> REGRESSION (r51629): WebBackForwardList created via -init...
mrowe@apple.com [Wed, 9 Jun 2010 20:03:37 +0000 (20:03 +0000)]
<rdar://problem/8070662> REGRESSION (r51629): WebBackForwardList created via -init crashes when -addItem: is called.

Reviewed by Adele Peterson.

A WebBackForwardList created via -init results in a BackForwardList being created with a null m_page.
BackForwardList needs to be careful not to dereference m_page without first ensuring it's not null.

* history/BackForwardList.cpp:
(WebCore::BackForwardList::addItem): Null-check m_page.
(WebCore::BackForwardList::goBack): Ditto.
(WebCore::BackForwardList::goForward): Ditto.
(WebCore::BackForwardList::goToItem): Ditto.
(WebCore::BackForwardList::setCapacity): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 9 Jun 2010 19:37:42 +0000 (19:37 +0000)]
2010-06-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add dummy Context Menu implementation
        https://bugs.webkit.org/show_bug.cgi?id=40223

        Brew MP does not use Context Menu. Add dummy implementation.

        * platform/brew/ContextMenuBrew.cpp: Added.
        (WebCore::ContextMenu::ContextMenu):
        (WebCore::ContextMenu::~ContextMenu):
        (WebCore::ContextMenu::itemCount):
        (WebCore::ContextMenu::insertItem):
        (WebCore::ContextMenu::appendItem):
        (WebCore::ContextMenu::itemWithAction):
        (WebCore::ContextMenu::itemAtIndex):
        (WebCore::ContextMenu::setPlatformDescription):
        (WebCore::ContextMenu::platformDescription):
        (WebCore::ContextMenu::releasePlatformDescription):
        * platform/brew/ContextMenuItemBrew.cpp: Added.
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::~ContextMenuItem):
        (WebCore::ContextMenuItem::releasePlatformDescription):
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::action):
        (WebCore::ContextMenuItem::title):
        (WebCore::ContextMenuItem::platformSubMenu):
        (WebCore::ContextMenuItem::setType):
        (WebCore::ContextMenuItem::setAction):
        (WebCore::ContextMenuItem::setTitle):
        (WebCore::ContextMenuItem::setSubMenu):
        (WebCore::ContextMenuItem::setChecked):
        (WebCore::ContextMenuItem::setEnabled):
        (WebCore::ContextMenuItem::enabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 9 Jun 2010 19:25:25 +0000 (19:25 +0000)]
2010-06-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Port Clipboard
        https://bugs.webkit.org/show_bug.cgi?id=35734

        Add dummy Clipboard.

        * platform/brew/ClipboardBrew.cpp: Added.
        (WebCore::ClipboardBrew::ClipboardBrew):
        (WebCore::ClipboardBrew::~ClipboardBrew):
        (WebCore::ClipboardBrew::clearData):
        (WebCore::ClipboardBrew::clearAllData):
        (WebCore::ClipboardBrew::getData):
        (WebCore::ClipboardBrew::setData):
        (WebCore::ClipboardBrew::types):
        (WebCore::ClipboardBrew::files):
        (WebCore::ClipboardBrew::setDragImage):
        (WebCore::ClipboardBrew::setDragImageElement):
        (WebCore::ClipboardBrew::createDragImage):
        (WebCore::ClipboardBrew::declareAndWriteDragImage):
        (WebCore::ClipboardBrew::writeURL):
        (WebCore::ClipboardBrew::writeRange):
        (WebCore::ClipboardBrew::writePlainText):
        (WebCore::ClipboardBrew::hasData):
        * platform/brew/ClipboardBrew.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Wed, 9 Jun 2010 19:12:56 +0000 (19:12 +0000)]
2010-06-09  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] ClipboardQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39781

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBugzilla: Don't send mail for cancel/deny/granted for in-rietveld.
jparent@chromium.org [Wed, 9 Jun 2010 19:06:04 +0000 (19:06 +0000)]
Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=40345

* Bugzilla/Flag.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 9 Jun 2010 18:32:27 +0000 (18:32 +0000)]
2010-06-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Rietveld upload queue fails when setting in-rietveld flag
        https://bugs.webkit.org/show_bug.cgi?id=40371

        Make the comment arguments to set_flag_on_attachment optional
        and add it to the MockBugzilla.

        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 9 Jun 2010 18:24:10 +0000 (18:24 +0000)]
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * src/GraphicsContext3D.cpp:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::float32ArrayEnabled):
        * bindings/js/JSArrayBufferViewCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::float32Array):
        (WebCore::JSDOMWindow::webGLFloatArray):
        * bindings/js/JSFloat32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSFloatArrayConstructor.cpp.
        (WebCore::):
        (WebCore::JSFloat32ArrayConstructor::JSFloat32ArrayConstructor):
        (WebCore::constructCanvasFloatArray):
        (WebCore::JSFloat32ArrayConstructor::getConstructData):
        * bindings/js/JSFloat32ArrayConstructor.h: Copied from WebCore/bindings/js/JSFloatArrayConstructor.h.
        * bindings/js/JSFloat32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSFloatArrayCustom.cpp.
        (WebCore::JSFloat32Array::indexSetter):
        (WebCore::toJS):
        (WebCore::JSFloat32Array::set):
        * bindings/js/JSFloatArrayConstructor.cpp: Removed.
        * bindings/js/JSFloatArrayConstructor.h: Removed.
        * bindings/js/JSFloatArrayCustom.cpp: Removed.
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::dataFunctionf):
        (WebCore::dataFunctionMatrix):
        * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
        (WebCore::toV8):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
        * bindings/v8/custom/V8Float32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8FloatArrayCustom.cpp.
        (WebCore::V8Float32Array::constructorCallback):
        (WebCore::V8Float32Array::setCallback):
        (WebCore::toV8):
        * bindings/v8/custom/V8FloatArrayCustom.cpp: Removed.
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::vertexAttribAndUniformHelperf):
        (WebCore::uniformMatrixHelper):
        * html/canvas/Float32Array.cpp: Copied from WebCore/html/canvas/FloatArray.cpp.
        (WebCore::Float32Array::create):
        (WebCore::Float32Array::Float32Array):
        (WebCore::Float32Array::slice):
        * html/canvas/Float32Array.h: Copied from WebCore/html/canvas/FloatArray.h.
        * html/canvas/Float32Array.idl: Copied from WebCore/html/canvas/FloatArray.idl.
        * html/canvas/FloatArray.cpp: Removed.
        * html/canvas/FloatArray.h: Removed.
        * html/canvas/FloatArray.idl: Removed.
        * html/canvas/WebGLGetInfo.cpp:
        (WebCore::WebGLGetInfo::WebGLGetInfo):
        (WebCore::WebGLGetInfo::getWebGLFloatArray):
        * html/canvas/WebGLGetInfo.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getUniform):
        (WebCore::WebGLRenderingContext::getVertexAttrib):
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):
        (WebCore::WebGLRenderingContext::vertexAttrib1fv):
        (WebCore::WebGLRenderingContext::vertexAttrib2fv):
        (WebCore::WebGLRenderingContext::vertexAttrib3fv):
        (WebCore::WebGLRenderingContext::vertexAttrib4fv):
        (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
        * page/DOMWindow.idl:
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/constructed-objects-prototypes.js:
        (constructorPropertiesOnWindow):
        * fast/dom/script-tests/prototype-inheritance-2.js:
        (constructorNamesForWindow):
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/js/script-tests/global-constructors.js:
2010-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Rename FloatArray to Float32Array
        https://bugs.webkit.org/show_bug.cgi?id=40323

        Used do-webcore-rename to perform renaming. Manually undid
        incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
        WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
        ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
        all layout tests on Safari; built Chromium and ran selected WebGL
        tests.

        * Scripts/do-webcore-rename:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some unused variable warnings from JITOpcodes
loki@webkit.org [Wed, 9 Jun 2010 18:12:01 +0000 (18:12 +0000)]
Remove some unused variable warnings from JITOpcodes
https://bugs.webkit.org/show_bug.cgi?id=40298

Reviewed by David Levin.

* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:49:48 +0000 (17:49 +0000)]
2010-06-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        video-timeupdate-duringplayback.html missing closing angle
        https://bugs.webkit.org/show_bug.cgi?id=40311

        This patch removes invalid markup from video-timeupdate-during-playback.html
        because that is not the point of that test. It adds a new test with
        the same markup to webkit01.dat. New test fails with --html5-parser.

        * html5lib/resources/webkit01.dat:
        * media/video-timeupdate-during-playback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:12:01 +0000 (17:12 +0000)]
2010-06-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        LayoutTests needlessly depend on old parser quirks covered by other tests
        https://bugs.webkit.org/show_bug.cgi?id=40354

        There are two quirks of the old HTMLTokenizer which I'm removing
        from various tests in this change.
         - <tag<tag> parsing is a quirk unique to WebKit's old tokenizer
           and is already tested by fast/invalid/016.html and
           html5lib/runner.html.
         - <script/> is another quirk unique to WebKit's old tokenizer and
           is covered by fast/parser/script-tag-with-trailing-slash.html

        * fast/block/float/4145535Crash.html:
         - The test tests a CSS crasher.  Changed the html to
           be explicit about how it should be parsed instead of
           depending on the <tag<tag> quirk of the old parser.
        * fast/dom/HTMLScriptElement/script-load-events.html:
         - Remove testing of <script/> since that's already covered
           by fast/parser/script-tag-with-trailing-slash.html
        * fast/dom/HTMLScriptElement/script-set-src-expected.txt:
         - Same as above.
        * fast/dom/HTMLScriptElement/script-set-src.html:
         - Same as above.
        * fast/events/pageshow-pagehide.html:
         - Remove dependence on <tag<tag> quirk.
        * fast/events/resources/pageshow-pagehide-subframe-cachable.html:
         - <tag<tag> quirk.
        * fast/events/resources/pageshow-pagehide-subframe.html:
         - <tag<tag> quirk.
        * fast/frames/sandboxed-iframe-navigation-parent.html:
         - <tag<tag> quirk.
        * fast/lists/w3-css3-list-styles-alphabetic.html:
         - <tag<tag> quirk.
        * fast/multicol/negativeColumnWidth.html:
         - <tag<tag> quirk.
        * fast/ruby/ruby-illegal-2.html:
         - The original fix (https://trac.webkit.org/changeset/53525) was
           a fix to rendering code.  I've simply corrected the test to be
           explicit about how it should be parsed so that it can test the
           rendering code path without depending on the <tag<tag> quirk
           of the old HTMLTokenizer.
        * fast/ruby/ruby-illegal-3.html:
         - Same as above.
        * http/tests/misc/generated-content-inside-table.html:
         - Remove dependence on the <script/> quirk.
        * svg/custom/svg-fonts-in-html-linebreaks.html:
         - <tag<tag> quirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:09:03 +0000 (17:09 +0000)]
2010-06-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5 Parser needs to integrate with the XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=40287

        This fixes most of the XSSAuditor tests, except for the ones
        which rely on the srcValue "context".  The previous HTMLTokenizer
        implementation was both Lexer and ScriptRunner and thus could
        provide the XSSAuditor with the un-modified attribute source.
        This naive implementation will fail the context-sensitive tests
        but Adam Barth says he'll just have to find a new way to provide
        the required information to the XSSAuditor in a later patch.

        Covered by numerous http/tests/security/xssAuditor tests.

        * html/HTML5ScriptRunner.cpp:
        (WebCore::HTML5ScriptRunner::requestScript):
         - Ask the HTML5ScriptRunner host before running any scripts.
        * html/HTML5ScriptRunnerHost.h:
         - Add a shouldLoadExternalScriptFromSrc declaration.
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::shouldLoadExternalScriptFromSrc):
         - Ask the XSSAuditor if we're allowed to run the passed script.
        * html/HTML5Tokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Wed, 9 Jun 2010 17:05:17 +0000 (17:05 +0000)]
2010-06-09  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix script-after-frameset test in HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=40274

        The old HTMLTokenizer enforced this in scriptHandler(). We don't use
        that code anymore, so it needs to be implemented. The spec does this
        as a part of "insertion mode"->"after frameset", so this adds an
        InsertionMode enum instead of a one-off boolean.

        No new tests because covered by fast/tokenizer/script-after-frameset.html

        * html/HTML5TreeBuilder.cpp:
        (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
        (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
        * html/HTML5TreeBuilder.h:
        (WebCore::HTML5TreeBuilder::):
        (WebCore::HTML5TreeBuilder::setInsertionMode):
        (WebCore::HTML5TreeBuilder::insertionMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 9 Jun 2010 16:58:57 +0000 (16:58 +0000)]
2010-06-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add EventLoop
        https://bugs.webkit.org/show_bug.cgi?id=39401

        BREW MP does not have an explicit event loop. Add dummy EventLoop::cycle.

        * platform/brew/EventLoopBrew.cpp: Added.
        (WebCore::EventLoop::cycle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Wed, 9 Jun 2010 16:01:01 +0000 (16:01 +0000)]
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * inspector/InspectorClient.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::InspectorFrontend):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::frontendLoaded):
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorObject::writeJSON):
        * inspector/front-end/inspector.js:
        * loader/EmptyClients.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * efl/WebCoreSupport/InspectorClientEfl.cpp:
        * efl/WebCoreSupport/InspectorClientEfl.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/WebInspectorClientCF.cpp:
        (WebInspectorClient::storeSetting):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * src/InspectorClientImpl.cpp:
        * src/InspectorClientImpl.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::InspectorClient):
        (WebKit::InspectorClient::openInspectorFrontend):
        (WebKit::InspectorFrontendClient::InspectorFrontendClient):
        (WebKit::InspectorFrontendClient::destroyInspectorWindow):
        * WebCoreSupport/InspectorClientGtk.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/InspectorClientHaiku.cpp:
        * WebCoreSupport/InspectorClientHaiku.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::openInspectorFrontend):
        (-[WebInspectorWindowController destroyInspectorView]):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::InspectorClientQt):
        (WebCore::InspectorClientQt::openInspectorFrontend):
        (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
        (WebCore::InspectorFrontendClientQt::closeWindow):
        * WebCoreSupport/InspectorClientQt.h:
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::~WebInspectorClient):
        (WebInspectorClient::openInspectorFrontend):
        * WebCoreSupport/WebInspectorClient.h:
        (WebInspectorClient::frontendClosing):
2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.
        http://trac.webkit.org/changeset/60889
        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by
        loislo on #webkit).

        * WebKitSupport/InspectorClientWx.cpp:
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 9 Jun 2010 15:51:58 +0000 (15:51 +0000)]
2010-06-09  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Carlson.

        [Windows] Build fix on Japanese Windows
        https://bugs.webkit.org/show_bug.cgi?id=40358

        cl.exe on Japanese Windows assumes files with invalid CP932
        sequences broken and doesn't build them at all.

        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Remove non-ASCII characters
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: ditto.
        * platform/graphics/win/WKCAImageQueue.cpp: ditto.
        * platform/graphics/win/WKCAImageQueue.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Pavel Podivilov <podivilov@chromium.org>
yurys@chromium.org [Wed, 9 Jun 2010 15:00:30 +0000 (15:00 +0000)]
2010-06-09  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Add isDebuggerAlwaysEnabled method to ScriptDebugServer.
        This method returns true if debugger should always be enabled when
        frontend is attached.
        https://bugs.webkit.org/show_bug.cgi?id=40289

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontend):
2010-06-09  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: retreive debugger script source synchronously when
        frontend is attached. We need this to be able to stop on top-level
        breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=40289

        * WebKit.gypi:
        * src/DebuggerAgent.h:
        * src/DebuggerAgentImpl.cpp:
        * src/DebuggerAgentImpl.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
        * src/js/DebuggerScript.js:
        * src/js/DevTools.js:
        (WebInspector.loaded):
        * src/js/DevToolsHostStub.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 9 Jun 2010 14:49:28 +0000 (14:49 +0000)]
2010-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix.

        * WebProcess/WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 9 Jun 2010 14:40:25 +0000 (14:40 +0000)]
2010-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix.

        WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
        data from inspected page to WebInspector as JSON string via http. The native
        serialization to JSON string is supported by InspectorValue's classes. This patch
        has the implementation of sendMessageToFrontend function. WebKit version of it still
        uses ScriptFunctionCall and will be switched to another transport a little bit later.
        https://bugs.webkit.org/show_bug.cgi?id=40134

        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
        (WebKit::WebInspectorClient::sendMessageToFrontend):
        * WebProcess/WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 9 Jun 2010 14:33:28 +0000 (14:33 +0000)]
Unreviewed.

[Qt] canvas/philip/tests/2d.path.stroke.overlap.html fails with Qt-4.6.2 or higher
https://bugs.webkit.org/show_bug.cgi?id=40362

* platform/qt/Skipped: canvas/philip/tests/2d.path.stroke.overlap.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
loislo@chromium.org [Wed, 9 Jun 2010 14:18:57 +0000 (14:18 +0000)]
    WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
        data from inspected page to WebInspector as JSON string via http. The native
        serialization to JSON string is supported by InspectorValue's classes. This patch
        has the implementation of sendMessageToFrontend function. WebKit version of it still
        uses ScriptFunctionCall and will be switched to another transport a little bit later.
        https://bugs.webkit.org/show_bug.cgi?id=40134

        * inspector/InspectorClient.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::InspectorFrontend):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::frontendLoaded):
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorObject::writeJSON):
        * inspector/front-end/inspector.js:
        (WebInspector.dispatchMessageToFrontend):
        * loader/EmptyClients.h:
        (WebCore::EmptyInspectorClient::sendMessageToFrontend):
        * efl/WebCoreSupport/InspectorClientEfl.cpp:
        (WebCore::InspectorClientEfl::sendMessageToFrontend):
        * efl/WebCoreSupport/InspectorClientEfl.h:
        * WebCoreSupport/WebInspectorClientCF.cpp:
        (WebInspectorClient::releaseFrontendPage):
        (WebInspectorClient::sendMessageToFrontend):
        * src/InspectorClientImpl.cpp:
        (WebKit::InspectorClientImpl::sendMessageToFrontend):
        * src/InspectorClientImpl.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::releaseFrontendPage):
        (WebKit::InspectorClient::sendMessageToFrontend):
        * WebCoreSupport/InspectorClientGtk.h:
        * WebCoreSupport/InspectorClientHaiku.cpp:
        (WebCore::InspectorClientHaiku::sendMessageToFrontend):
        * WebCoreSupport/InspectorClientHaiku.h:
        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::openInspectorFrontend):
        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::InspectorClientQt):
        (WebCore::InspectorClientQt::openInspectorFrontend):
        (WebCore::InspectorClientQt::releaseFrontendPage):
        (WebCore::InspectorClientQt::sendMessageToFrontend):
        * WebCoreSupport/InspectorClientQt.h:
        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::~WebInspectorClient):
        (WebInspectorClient::openInspectorFrontend):
        * WebCoreSupport/WebInspectorClient.h:
        * WebKitSupport/InspectorClientWx.cpp:
        (WebCore::InspectorClientWx::sendMessageToFrontend):
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 9 Jun 2010 14:09:32 +0000 (14:09 +0000)]
2010-06-09  Stephen White  <senorblanco@chromium.org>

        Unreviewed; expectations fix.

        Add new expectations for layout tests post-r60885 ("Implement non-scaling stroke").  Mark one test flaky.

        * platform/chromium-linux/svg/custom/non-scaling-stroke-expected.checksum: Added.
        * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-win/svg/custom/non-scaling-stroke-expected.checksum: Added.
        * platform/chromium-win/svg/custom/non-scaling-stroke-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Imperfect dependency for generated SVGNames.cpp
ossy@webkit.org [Wed, 9 Jun 2010 10:24:34 +0000 (10:24 +0000)]
[Qt] Imperfect dependency for generated SVGNames.cpp
https://bugs.webkit.org/show_bug.cgi?id=40359

Reviewed by Dirk Schulze.

* WebCore.pri: Missing dependency added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 9 Jun 2010 08:57:35 +0000 (08:57 +0000)]
2010-06-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: update stack trace after script source editing
        https://bugs.webkit.org/show_bug.cgi?id=40357

        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent.prototype.editScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
        (devtools.DebuggerAgent.prototype.editScriptSource.requestBacktrace):
        (devtools.DebuggerAgent.prototype.editScriptSource.handleBacktraceResponse):
        (devtools.DebuggerAgent.prototype.editScriptSource.reportDidCommitEditing):
        (devtools.DebuggerAgent.prototype.editScriptSource):
        (devtools.DebuggerAgent.prototype.requestBacktrace_):
        (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
        (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
        (devtools.DebuggerAgent.prototype.updateCallFramesFromBacktraceResponse_):
        * src/js/InspectorControllerImpl.js:
        (.devtools.InspectorBackendImpl.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 9 Jun 2010 07:24:39 +0000 (07:24 +0000)]
2010-06-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Implement non-scaling-stroke (from SVG Tiny 1.2, also in Opera)
        https://bugs.webkit.org/show_bug.cgi?id=31438

        This is the implementation of the SVG property vector-effect according
        to the specification of SVG Tiny 1.2.
        getScreenCTM() was not able to calculate the transformation matrix in
        comparison to the host coordinate system for objects, that get refereced
        by a use element. This is fixed and covered by the the new test as well.
        This patch is based upon a patch of Jeff Schiller.

        Test: svg/custom/non-scaling-stroke.svg

        * css/CSSComputedStyleDeclaration.cpp: Added CSSPropertyVectorEffect.
        (WebCore::):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EVectorEffect):
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        * css/SVGCSSPropertyNames.in:
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * css/SVGCSSValueKeywords.in: Add vector-effect value non-scaling-stroke.
        * rendering/RenderPath.cpp: Revert transformations to ctm and transform path instead.
        (WebCore::fillAndStrokePath):
        * rendering/RenderSVGResourceContainer.h:
        (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
        * rendering/RenderSVGResourceGradient.cpp: Transform the gradient with the screenCTM.
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourcePattern.cpp: Transform the pattern with the screenCTM.
        (WebCore::RenderSVGResourcePattern::applyResource):
        * rendering/style/SVGRenderStyle.h: Added vector-effect property, not interited.
        (WebCore::SVGRenderStyle::NonInheritedFlags::):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h: Added enums for vector-effect.
        (WebCore::):
        * svg/SVGLocatable.cpp: Calculate screenCTM for <use> referenced objects.
        (WebCore::SVGLocatable::computeCTM):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
        * svg/svgattrs.in:
2010-06-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Implement non-scaling-stroke (from SVG Tiny 1.2, also in Opera)
        https://bugs.webkit.org/show_bug.cgi?id=31438

        Test for SVG property vector-effect. The stroke-width should not get influenced by
        any transformation on the object or its parrent.
        Some ports needed platform specific test results for getComputedStyle.

        * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/mac/svg/custom/non-scaling-stroke-expected.checksum: Added.
        * platform/mac/svg/custom/non-scaling-stroke-expected.png: Added.
        * platform/mac/svg/custom/non-scaling-stroke-expected.txt: Added.
        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:
        * svg/custom/non-scaling-stroke.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 9 Jun 2010 07:22:39 +0000 (07:22 +0000)]
2010-06-08  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
        https://bugs.webkit.org/show_bug.cgi?id=40285

        Take 2 at landing this patch, this time rolling DEPS just a bit
        further to pick up some chromium fixes.

        * DEPS
        * gyp_webkit:
2010-06-08  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
        https://bugs.webkit.org/show_bug.cgi?id=40285

        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-02 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Jun 2010 06:29:10 +0000 (06:29 +0000)]
2010-06-02  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Tamura Kent

        Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
        https://bugs.webkit.org/show_bug.cgi?id=40052

        Add WebThemeEngineDRT and WebThemeControlDRT from Chromium rev. 48907

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
        (WebKit::):
        (WebKit::WebThemeControlDRT::WebThemeControlDRT):
        (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
        (WebKit::WebThemeControlDRT::box):
        (WebKit::WebThemeControlDRT::line):
        (WebKit::WebThemeControlDRT::triangle):
        (WebKit::WebThemeControlDRT::roundRect):
        (WebKit::WebThemeControlDRT::oval):
        (WebKit::WebThemeControlDRT::circle):
        (WebKit::WebThemeControlDRT::nestedBoxes):
        (WebKit::WebThemeControlDRT::markState):
        (WebKit::WebThemeControlDRT::draw):
        (WebKit::WebThemeControlDRT::drawTextField):
        (WebKit::WebThemeControlDRT::drawProgressBar):
        * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
        (WebKit::WebThemeControlDRT::):
        * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
        (WebKit::):
        (WebKit::WebThemeEngineDRT::paintButton):
        (WebKit::WebThemeEngineDRT::paintMenuList):
        (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
        (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
        (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
        (WebKit::WebThemeEngineDRT::paintTextField):
        (WebKit::WebThemeEngineDRT::paintTrackbar):
        (WebKit::WebThemeEngineDRT::paintProgressBar):
        * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
        (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothi...
mrowe@apple.com [Wed, 9 Jun 2010 05:55:47 +0000 (05:55 +0000)]
<rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothing in applications linked against 10.4 SDK

Reviewed by Adele Peterson.

WebCore:

Revert the change to ContextMenu::addInspectElementItem from r56051. It was made without
explanation and broke a reliance that WebKit has on the presence of a separator before the
Inspect Element menu item. This also restores the context menu item to the correct location
at the bottom of the context menu in applications built against the Mac OS X 10.4 SDK.

* platform/ContextMenu.cpp:
(WebCore::ContextMenu::addInspectElementItem):

WebKit/mac:

* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients): Fix up the tag on the Inspect Element menu item. This ensures that even if the
context menu layout doesn't match our expectations that the menu item will continue to trigger the web inspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 9 Jun 2010 05:23:23 +0000 (05:23 +0000)]
2010-06-08  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed build fix

        Bug 38145 - Validate *tex* functions input parameters according to ES2 conformance
        https://bugs.webkit.org/show_bug.cgi?id=38145
        https://bugs.webkit.org/show_bug.cgi?id=40346

        Fix for 38145 broke the build ('log2 not found' on Windows),
        the fix from 40346 also didn't catch ('log ambiguous').

        2nd quick fix: add explicit casts to double and use double constants.

        No new tests.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateTexFuncParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-18 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 9 Jun 2010 04:44:14 +0000 (04:44 +0000)]
2010-05-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Fix for Bug 34529 -  [CSSOM] issues with cssText and selectorText
        Add U16_LENGTH that is needed to implement CSS character serialization.
        https://bugs.webkit.org/show_bug.cgi?id=34529

        * wtf/unicode/qt4/UnicodeQt4.h:
        * wtf/unicode/wince/UnicodeWince.h:
2010-05-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Fix for Bug 34529 -  [CSSOM] issues with cssText and selectorText
        https://bugs.webkit.org/show_bug.cgi?id=34529

        * fast/css/selector-text-escape-expected.txt: Added.
        * fast/css/selector-text-escape.html: Added.
2010-05-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Fix for Bug 34529 -  [CSSOM] issues with cssText and selectorText
        Serialize selector as per http://dev.w3.org/csswg/cssom/#serializing-selectors
        Without this patch, for example, selectors containing ':' or '.' are not properly serialized.
        https://bugs.webkit.org/show_bug.cgi?id=34529

        Test: fast/css/selector-text-escape.html

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSOMUtils.cpp: Added.
        (WebCore::appendCharacter):
        (WebCore::serializeCharacter):
        (WebCore::serializeCharacterAsCodePoint):
        (WebCore::serializeIdentifier):
        (WebCore::serializeString):
        * css/CSSOMUtils.h: Added.
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::selectorText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
tony@chromium.org [Wed, 9 Jun 2010 04:30:50 +0000 (04:30 +0000)]
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60878.
        http://trac.webkit.org/changeset/60878
        https://bugs.webkit.org/show_bug.cgi?id=40349

        broke linux build (Requested by tony^work on #webkit).

        * DEPS:
        * gyp_webkit:
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60878.
        http://trac.webkit.org/changeset/60878
        https://bugs.webkit.org/show_bug.cgi?id=40349

        broke linux build (Requested by tony^work on #webkit).

        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 9 Jun 2010 04:04:28 +0000 (04:04 +0000)]
2010-06-08  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
        https://bugs.webkit.org/show_bug.cgi?id=40285

        * gyp_webkit:
2010-06-08  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
        https://bugs.webkit.org/show_bug.cgi?id=40285

        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInsertListCommand needs cleanup
rniwa@webkit.org [Wed, 9 Jun 2010 03:47:34 +0000 (03:47 +0000)]
InsertListCommand needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=36430

Reviewed by Justin Garcia

Separated code for listifying and unlistifying paragraphs.
Also isolated the dependency on the selection in doApply.

No test is added since this is a cleanup.

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): isolated code to listify / unlistify paragraphs
(WebCore::InsertListCommand::unlistifyParagraph): ditto
(WebCore::InsertListCommand::listifyParagraph): ditto
* editing/InsertListCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 9 Jun 2010 02:11:31 +0000 (02:11 +0000)]
2010-06-08  Kenneth Russell  <kbr@google.com>

        Unreviewed, build fix.

        Fix build breakage from 38145
        https://bugs.webkit.org/show_bug.cgi?id=40346

        The fix for bug 38145 broke the Chromium Win build because
        Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
        change log2(x) to log(x) / log(2). Built and ran WebGL layout
        tests in Safari on Mac OS X. Changed download mirrors for
        python-irclib to working ones.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateTexFuncParameters):
2010-06-08  Kenneth Russell  <kbr@google.com>

        Unreviewed, build fix.

        Fix build breakage from 38145
        https://bugs.webkit.org/show_bug.cgi?id=40346

        The fix for bug 38145 broke the Chromium Win build because
        Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
        change log2(x) to log(x) / log(2). Built and ran WebGL layout
        tests in Safari on Mac OS X. Changed download mirrors for
        python-irclib to working ones.

        * Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Wed, 9 Jun 2010 01:02:44 +0000 (01:02 +0000)]
2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
        https://bugs.webkit.org/show_bug.cgi?id=39058

        * Scripts/old-run-webkit-tests:
         use sourceDir() to find ensure-valid-python in checkPythonVersion()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Wed, 9 Jun 2010 00:45:24 +0000 (00:45 +0000)]
2010-06-08  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Validate *tex* functions input parameters according to ES2 conformance
        https://bugs.webkit.org/show_bug.cgi?id=38145

        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Internalformat and format need to be the same.
        * fast/canvas/webgl/tex-input-validation-expected.txt: Added.
        * fast/canvas/webgl/tex-input-validation.html: Added.
2010-06-08  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Validate *tex* functions input parameters according to ES2 conformance
        https://bugs.webkit.org/show_bug.cgi?id=38145

        Test: fast/canvas/webgl/tex-input-validation.html

        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::getColorBufferFormat): Get color buffer internalformat.
        * html/canvas/WebGLFramebuffer.h: Ditto.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::WebGLRenderingContext): Deal with max tex units and max texture size.
        (WebCore::WebGLRenderingContext::copyTexImage2D): Validate input parameters.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
        (WebCore::WebGLRenderingContext::texParameterf): Ditto.
        (WebCore::WebGLRenderingContext::texParameteri): Ditto.
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
        (WebCore::WebGLRenderingContext::handleNPOTTextures): Deal with max tex units.
        (WebCore::WebGLRenderingContext::isTexInternalformatColorBufferCombinationValid): Check whether the texture format and framebuffer color buffer internalformat combination is valid.
        (WebCore::WebGLRenderingContext::getTextureBinding): get the current bound texture for given target.
        (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): Validate input format/type for *tex* functions.
        (WebCore::WebGLRenderingContext::validateTexFuncParameters): Validate input parameters for *tex* functions.
        (WebCore::WebGLRenderingContext::texParameter): Base function for texParameteri and texParameterf.
        * html/canvas/WebGLRenderingContext.h: Deal with max tex units.
        * html/canvas/WebGLTexture.cpp:
        (WebCore::WebGLTexture::WebGLTexture): Cache internalformat.
        * html/canvas/WebGLTexture.h: Ditto.
        (WebCore::WebGLTexture::setInternalformat):
        (WebCore::WebGLTexture::getInternalformat):
        * platform/graphics/GraphicsContext3D.cpp: internalformat and format need to be the same.
        (WebCore::GraphicsContext3D::extractImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Wed, 9 Jun 2010 00:29:13 +0000 (00:29 +0000)]
2010-06-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
        https://bugs.webkit.org/show_bug.cgi?id=38548

        * editing/pasteboard/drop-link-expected.txt: Mouse down on an element where canStartSelection returns
                                                     false no longer clears the selection so we get one less
                                                     notification from the editing delegate.
        * editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Added.
        * editing/selection/click-in-focusable-link-should-not-clear-selection.html: Added.
        * editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Added.
        (description.getElementCenter):
        (doubleClickOnElement):
        (mouseDownOnElement):
        (selectionShouldBe):
2010-06-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
        https://bugs.webkit.org/show_bug.cgi?id=38548

        Test: editing/selection/click-in-focusable-link-should-not-clear-selection.html

        * page/FocusController.cpp:
        (WebCore::clearSelectionIfNeeded): Make sure we do not clear selection when canStartSelection
                                           returns false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 9 Jun 2010 00:05:08 +0000 (00:05 +0000)]
2010-06-08  Tony Chang  <tony@chromium.org>

        Not reviewed, build fix.

        [chromium] fix linux compile
        https://bugs.webkit.org/show_bug.cgi?id=40343

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8071268> WebKit2 URLs are displayed as 1-character strings in log...
andersca@apple.com [Tue, 8 Jun 2010 23:55:38 +0000 (23:55 +0000)]
<rdar://problem/8071268> WebKit2 URLs are displayed as 1-character strings in log statements

Reviewed by John Sullivan.

Create a CFString from our WebCore string and then create the CFURL from the CFString.

* UIProcess/API/C/cf/WKURLCF.cpp:
(WKURLCopyCFURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 8 Jun 2010 23:26:37 +0000 (23:26 +0000)]
2010-06-08  Stephen White  <senorblanco@chromium.org>

        Unreviewed, expectations fix.

        [CHROMIUM] Remove expectations for editing/pasteboard/drop-link.html on mac, since the change was reverted.  Mark http/tests/multipart/invalid-image-data.html as flaky on linux/dbg.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Crashfix on Path::contains
jchaffraix@webkit.org [Tue, 8 Jun 2010 23:09:34 +0000 (23:09 +0000)]
[Qt] Crashfix on Path::contains
https://bugs.webkit.org/show_bug.cgi?id=40253

Patch by Enrico Ros <eros@codeaurora.org> on 2010-06-08
Reviewed by Ariya Hidayat.

Fix accessing the first item of an empty vector, that happens when
CanvasRenderingContext2D::isPointInPath is invoked over a borderless
path (e.g. a path made of just a MoveTo operation).

* platform/graphics/qt/PathQt.cpp:
(WebCore::isPointOnPathBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
senorblanco@chromium.org [Tue, 8 Jun 2010 22:03:36 +0000 (22:03 +0000)]
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60864.
        http://trac.webkit.org/changeset/60864
        https://bugs.webkit.org/show_bug.cgi?id=40337

        Remove expected results, since r60859 was also reverted
        (Requested by senorblanco on #webkit).

        * platform/chromium-win/editing/pasteboard/drop-link-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Tue, 8 Jun 2010 21:44:13 +0000 (21:44 +0000)]
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60859.
        http://trac.webkit.org/changeset/60859
        https://bugs.webkit.org/show_bug.cgi?id=40334

        Included debugging statements. Caused a test to fail.
        (Requested by ojan on #webkit).

        * editing/pasteboard/drop-link-expected.txt:
        * editing/pasteboard/drop-link.html:
        * editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Removed.
        * editing/selection/click-in-focusable-link-should-not-clear-selection.html: Removed.
        * editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Removed.
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60859.
        http://trac.webkit.org/changeset/60859
        https://bugs.webkit.org/show_bug.cgi?id=40334

        Included debugging statements. Caused a test to fail.
        (Requested by ojan on #webkit).

        * page/FocusController.cpp:
        (WebCore::clearSelectionIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 8 Jun 2010 21:27:03 +0000 (21:27 +0000)]
2010-06-08  Stephen White  <senorblanco@chromium.org>

        Unreviewed; expectations fix.

        Update chromium expectations for r60865, r60859.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Jun 2010 20:48:50 +0000 (20:48 +0000)]
2010-06-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ojan Vafai.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        This is a re-land of r59840 rolled out in r59857 due to DRT limitations.

        * editing/selection/extend-selection-after-double-click-expected.txt:
        Updated expectations.
        * editing/selection/extend-selection-after-double-click.html:
        Use the new DRT support for changing editing behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 8 Jun 2010 20:28:51 +0000 (20:28 +0000)]
2010-06-08  Stephen White  <senorblanco@chromium.org>

        Unreviewed; expectations fix.

        Added new chromium-win expectations for editing/pasteboard/drop-link.html, after r60859.

        * platform/chromium-win/editing/pasteboard/drop-link-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
krit@webkit.org [Tue, 8 Jun 2010 19:56:35 +0000 (19:56 +0000)]
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60858.
        http://trac.webkit.org/changeset/60858
        https://bugs.webkit.org/show_bug.cgi?id=40325

        Qt needs a clean build. Rolling out the patch for now and fix
        it tomorrow (Requested by krit on #webkit).

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        * css/CSSPrimitiveValueMappings.h:
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        * css/SVGCSSPropertyNames.in:
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * css/SVGCSSValueKeywords.in:
        * rendering/RenderPath.cpp:
        (WebCore::fillAndStrokePath):
        * rendering/RenderSVGResourceContainer.h:
        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::applyResource):
        * rendering/style/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::NonInheritedFlags::):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h:
        (WebCore::):
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::computeCTM):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
        * svg/svgattrs.in:
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60858.
        http://trac.webkit.org/changeset/60858
        https://bugs.webkit.org/show_bug.cgi?id=40325

        Qt needs a clean build. Rolling out the patch for now and fix
        it tomorrow (Requested by krit on #webkit).

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/mac/svg/custom/non-scaling-stroke-expected.checksum: Removed.
        * platform/mac/svg/custom/non-scaling-stroke-expected.png: Removed.
        * platform/mac/svg/custom/non-scaling-stroke-expected.txt: Removed.
        * svg/css/getComputedStyle-basic-expected.txt:
        * svg/custom/non-scaling-stroke.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 8 Jun 2010 19:49:40 +0000 (19:49 +0000)]
2010-06-08  Daniel Bates  <dbates@rim.com>

        Unreviewed, fix Xcode project file after change-set 60841.

        Xcode is not happy about the entries for files EditingBehavior.h and
        EditingBehaviorTypes.h that were added in change-set 60841 (Bug # 39854).
        Lets make Xcode happy.

        Also, lets place these entries in alphabetic order.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 8 Jun 2010 19:44:15 +0000 (19:44 +0000)]
2010-06-08  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Kenneth Rohde Christiansen.

        [Qt] Put even more structure on Skipped file.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Tue, 8 Jun 2010 19:29:13 +0000 (19:29 +0000)]
2010-06-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by ojan@chromium.org.

        REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
        https://bugs.webkit.org/show_bug.cgi?id=38548

        We should not clear the selection when canStartSelection returns false.

        * editing/pasteboard/drop-link-expected.txt: Mouse down on an element where canStartSelection returns
                                                     false no longer clears the selection so we get one less
                                                     notification from the editing delegate.
        * editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Added.
        * editing/selection/click-in-focusable-link-should-not-clear-selection.html: Added.
        * editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Added.
        (description.getElementCenter):
        (doubleClickOnElement):
        (mouseDownOnElement):
        (selectionShouldBe):
2010-06-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by ojan@chromium.org.

        REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
        https://bugs.webkit.org/show_bug.cgi?id=38548

        We should not clear the selection when canStartSelection returns false.

        Test: editing/selection/click-in-focusable-link-should-not-clear-selection.html

        * page/FocusController.cpp:
        (WebCore::clearSelectionIfNeeded): Make sure we do not clear selection when canStartSelection
                                           returns false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 8 Jun 2010 19:11:11 +0000 (19:11 +0000)]
2010-06-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Implement non-scaling-stroke (from SVG Tiny 1.2, also in Opera)
        https://bugs.webkit.org/show_bug.cgi?id=31438

        This is the implementation of the SVG property vector-effect according
        to the specification of SVG Tiny 1.2.
        getScreenCTM() was not able to calculate the transformation matrix in
        comparison to the host coordinate system for objects, that get refereced
        by a use element. This is fixed and covered by the the new test as well.
        This patch is based upon a patch of Jeff Schiller.

        Test: svg/custom/non-scaling-stroke.svg

        * css/CSSComputedStyleDeclaration.cpp: Added CSSPropertyVectorEffect.
        (WebCore::):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EVectorEffect):
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        * css/SVGCSSPropertyNames.in:
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * css/SVGCSSValueKeywords.in: Add vector-effect value non-scaling-stroke.
        * rendering/RenderPath.cpp: Revert transformations to ctm and transform path instead.
        (WebCore::fillAndStrokePath):
        * rendering/RenderSVGResourceContainer.h:
        (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
        * rendering/RenderSVGResourceGradient.cpp: Transform the gradient with the screenCTM.
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourcePattern.cpp: Transform the pattern with the screenCTM.
        (WebCore::RenderSVGResourcePattern::applyResource):
        * rendering/style/SVGRenderStyle.h: Added vector-effect property, not interited.
        (WebCore::SVGRenderStyle::NonInheritedFlags::):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h: Added enums for vector-effect.
        (WebCore::):
        * svg/SVGLocatable.cpp: Calculate screenCTM for <use> referenced objects.
        (WebCore::SVGLocatable::computeCTM):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
        * svg/svgattrs.in:
2010-06-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Implement non-scaling-stroke (from SVG Tiny 1.2, also in Opera)
        https://bugs.webkit.org/show_bug.cgi?id=31438

        Test for SVG property vector-effect. The stroke-width should not get influenced by
        any transformation on the object or its parrent.

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/mac/svg/custom/non-scaling-stroke-expected.checksum: Added.
        * platform/mac/svg/custom/non-scaling-stroke-expected.png: Added.
        * platform/mac/svg/custom/non-scaling-stroke-expected.txt: Added.
        * svg/css/getComputedStyle-basic-expected.txt:
        * svg/custom/non-scaling-stroke.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* mac/WebKit2.exp:
sullivan@apple.com [Tue, 8 Jun 2010 18:41:34 +0000 (18:41 +0000)]
* mac/WebKit2.exp:
Added _WKPageGetEstimatedProgress and _WKFrameGetPage

Rubber-stamped by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Jun 2010 18:16:29 +0000 (18:16 +0000)]
2010-06-08  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        Adding baselines for new tests.

        * platform/gtk/fast/forms/slider-padding-expected.txt: Added.
        * platform/gtk/svg/custom/fill-opacity-hsl-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/fill-opacity-hsl-expected.txt.
        * platform/gtk/svg/custom/fill-opacity-rgba-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/fill-opacity-rgba-expected.txt.
        * platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago * GNUmakefile.am: Also adding platform/Cursor.cpp to Gtk build.
ap@apple.com [Tue, 8 Jun 2010 18:00:43 +0000 (18:00 +0000)]
    * GNUmakefile.am: Also adding platform/Cursor.cpp to Gtk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed buildfix after r60849.
ossy@webkit.org [Tue, 8 Jun 2010 17:52:55 +0000 (17:52 +0000)]
[Qt] Unreviewed buildfix after r60849.

* WebCore.pro: platform/Cursor.cpp is added to Qt build system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Jun 2010 17:52:47 +0000 (17:52 +0000)]
2010-06-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Would like a way to query WKPageRef for the current progress value
        https://bugs.webkit.org/show_bug.cgi?id=40310
        <rdar://problem/8071299>

        Add WKPageGetEstimatedProgress. Remove the progress parameter from the didChangeProgress
        loader client callback function.

        * UIProcess/API/C/WKPage.cpp:
        (WKPageGetEstimatedProgress):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebLoaderClient.cpp:
        (WebKit::WebLoaderClient::didChangeProgress):
        * UIProcess/WebLoaderClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        (WebKit::WebPageProxy::close):
        (WebKit::WebPageProxy::didStartProgress):
        (WebKit::WebPageProxy::didChangeProgress):
        (WebKit::WebPageProxy::didFinishProgress):
        (WebKit::WebPageProxy::processDidExit):
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::estimatedProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Tue, 8 Jun 2010 17:37:44 +0000 (17:37 +0000)]
2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60830.
        http://trac.webkit.org/changeset/60830
        https://bugs.webkit.org/show_bug.cgi?id=40305

        Broke the Windows build (Requested by abarth on #webkit).

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * wtf/OwnPtrCommon.h:
        * wtf/brew/OwnPtrBrew.h: Removed.
        * wtf/win/OwnPtrWin.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Buildbot fix.
kenneth@webkit.org [Tue, 8 Jun 2010 17:34:41 +0000 (17:34 +0000)]
Unreviewed Buildbot fix.

Reset the Qt TextBreakIterator when reusing it.

* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::setUpIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Jun 2010 17:32:59 +0000 (17:32 +0000)]
2010-06-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Would like a way to tell which WKPageRef a WKFrameRef is part of
        https://bugs.webkit.org/show_bug.cgi?id=40308
        <rdar://problem/8071251>

        Add and implement WKFrameGetPage.

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetPage):
        * UIProcess/API/C/WKFrame.h:
        * UIProcess/WebFrameProxy.h:
        (WebKit::WebFrameProxy::page):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by John Sullivan.
ap@apple.com [Tue, 8 Jun 2010 17:29:36 +0000 (17:29 +0000)]
    Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=15779
        <rdar://problem/8002964> Custom CSS .cur cursor anchor point is ignored

        Test: manual-tests/cur-hotspot.html

        Currently, this patch only has effect in Safari 5 on Windows. Other platforms will need
        to implement getting hot spot information from .cur files.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Added Cursor.cpp. Looks like TextWrangler fixed line endings in vcproj file.

        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::CSSCursorImageValue): Renamed "hotspot" to "hotSpot" to match
        other code.
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Ditto. Added a FIXME about possibly
        incorrect code for resolving differences with CSS specified hotspot.

        * css/CSSCursorImageValue.h:
        (WebCore::CSSCursorImageValue::create):
        (WebCore::CSSCursorImageValue::hotSpot):
        Renamed "hotspot" to "hotSpot" to match other code.

        * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Start with an invalid value for hot
        spot, so that we can differentiate between missing and (0, 0) CSS hot spots. Missing and
        invalid (-1, -1) are treated identically by Firefox, so we don't need to differentiate these.

        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Renamed "hotspot" to
        "hotSpot" to match other code.

        * page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Don't ignore cursors with
        invalid CSS hot spots. Firefox ignores only the hot spot, not the whole cursor in this case
        (and IE doesn't support CSS3 cursor declarations).

        * platform/Cursor.cpp: Added. (WebCore::determineHotSpot): Added a function that decides
        where hot spot is, provided an image and a possible out of band coordinate specification.

        * platform/Cursor.h: Added determineHotSpot().

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::getHotSpot):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/Image.h:
        (WebCore::Image::getHotSpot):
        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::getHotSpot):
        * platform/graphics/ImageSource.h:
        Added plumbing to get hot spot data from an image provider.

        * platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::getHotSpot): CG implemantation.

        * platform/mac/CursorMac.mm: (WebCore::createCustomCursor): Call determineHotSpot() to
        determine where hot spot should be.
        (WebCore::Cursor::Cursor): Renamed "hotspot" to "hotSpot" to match other code.

        * platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Call determineHotSpot() to determine
        where hot spot should be.

        * platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor): Ditto. This must be done despite
        this platform not having an implementation for ImageSource::getHotSpot(), because we no longer
        check for out of bounds hot spots in EventHandler::selectCursor().

        * platform/qt/CursorQt.cpp: (WebCore::Cursor::Cursor): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* mac/WebKit2.exp:
sullivan@apple.com [Tue, 8 Jun 2010 17:25:37 +0000 (17:25 +0000)]
* mac/WebKit2.exp:
Added a few more symbols needed by Mac clients.

Rubber-stamped by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] TextBreakIterator Qt performance
kenneth@webkit.org [Tue, 8 Jun 2010 17:04:49 +0000 (17:04 +0000)]
[Qt] TextBreakIterator Qt performance
https://bugs.webkit.org/show_bug.cgi?id=39958

Reviewed by Antti Koivisto.

Rework TextBreakIteratorQt to be more in line with the ICU version.

We now reuse iterators where ever possible. The string data is compared
with memcmp, which should be faster than using a hash, as you need
to traverse the full buffer in the case the strings don't match,
where as the compare would fail quickly.

* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::TextBreakIterator::TextBreakIterator):
(WebCore::setUpIterator):
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r60785.
abecsi@webkit.org [Tue, 8 Jun 2010 15:48:28 +0000 (15:48 +0000)]
Unreviewed build fix after r60785.

[GTK] Add missing GtkVersioning.h include to fix the build
on older GTK+ versions.

No new tests needed.

* platform/gtk/WidgetGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix after r60479.
abecsi@webkit.org [Tue, 8 Jun 2010 15:24:15 +0000 (15:24 +0000)]
Unreviewed buildfix after r60479.

[GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
versions other than 2.17.3.

* DumpRenderTree/gtk/EventSender.cpp:
(getRootCoords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 8 Jun 2010 15:04:35 +0000 (15:04 +0000)]
2010-06-08  Stephen White  <senorblanco@chromium.org>

        Unreviewed; expectations fix.

        Restore expectations for media/video-duration-known-after-eos.html, since it's still failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 8 Jun 2010 14:52:59 +0000 (14:52 +0000)]
2010-06-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extend ScriptDebugServer to support script source editing
        https://bugs.webkit.org/show_bug.cgi?id=40297

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::editScriptSource):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::editScriptSource):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::editScriptSource):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::editScriptSource):
        (WebCore::InspectorController::currentCallFrames):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::didContinue):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didEditScriptSource):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/Script.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.canEditScripts):
        (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
        (WebInspector.ScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/Settings.js:
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._editLine):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._handleDoubleClick):
        (WebInspector.TextViewer.prototype._commitEditingLine):
        * inspector/front-end/inspector.css:
        (#scripts-files option.extension-script):

2010-06-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extend ScriptDebugServer to support script source editing
        https://bugs.webkit.org/show_bug.cgi?id=40297

        * src/js/DebuggerAgent.js:
        (devtools.ScriptInfo.prototype.worldType):
        * src/js/DebuggerScript.js:
        (debuggerScriptConstructor.DebuggerScript.editScriptSource):
        * src/js/DevTools.js:
        (WebInspector.loaded):
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 8 Jun 2010 14:42:59 +0000 (14:42 +0000)]
2010-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Unit testing for WebKitDOMNode hierarchy walk
        https://bugs.webkit.org/show_bug.cgi?id=40171

        Add DOM node test to the build system.

        * GNUmakefile.am:

WebKit/gtk:

2010-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Unit testing for WebKitDOMNode hierarchy walk
        https://bugs.webkit.org/show_bug.cgi?id=40171

        Add some DOM node unit testing.

        * tests/testdomnode.c: Added.
        (finish_loading):
        (dom_node_fixture_setup):
        (dom_node_fixture_teardown):
        (test_dom_node_hierarchy_navigation):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor platform dependent editing behavior code out of Settings
tonikitoo@webkit.org [Tue, 8 Jun 2010 13:18:51 +0000 (13:18 +0000)]
Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854

[ Re-landing of r60816 with the m_editor initialized before m_selectionController in Frame constructor. ]

Reviewed by Ojan Vafai and Darin Adler.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

As per discussion in bug 36627, the following was suggested by Darin Adler: "before the addition of any
new EditingBehavior, I think we need to add functions to translate the overall behavior policy into specific
behaviors rather than directly saying 'behavior == Mac' or 'behavior == Windows'. Helper functions that
expression the different rules in plain language.".

Patch is a first step of an incremental approach to address this request. It does not yet replace all
direct use of Editing{Mac,Windows}Behaviors, but adds infra for that and replaces some of them.

No behavior change, so no new tests.

* GNUmakefile.am:
* WebCore.pro:
* WebCore/WebCore.gypi
* WebCore/WebCore.vcproj/WebCore.vcproj
* WebCore/WebCore.xcodeproj/project.pbxproj
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h: Moved out EditingBehavior enum to WebCore/editing/EditingBehaviorTypes.h,
and renamed to EditingBehaviorTypes.
(WebCore::Settings::setEditingBehaviorType): Renamed from setEditingBehavior.
(WebCore::Settings::editingBehaviorType): Renamed from editingBehavior.
* editing/EditingBehavior.h: Added.
(WebCore::EditingBehavior::EditingBehavior): Class to work as a central point for
editing behavior that might have to be handled differently in the different platforms/ports.
Class should be not used or instantiated directly, but rather implicitly constructed
through the Editor class.
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldConsiderSelectionAsDirectional):
(WebCore::EditingBehavior::shouldCenterAlignWhenSelectionIsRevealed):
* editing/EditingBehaviorTypes.h: Added.
(WebCore::):
* editing/Editor.cpp:
(WebCore::Editor::behavior): Getter for EditingBehavior class.
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::executeToggleStyle):
(WebCore::SelectionController::setIsDirectional):
(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::modify):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):

- Call sites will look like:
if (frame->editor()->behavior().shouldThisIfThat()))
   // do something

WebKit:

EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.

WebKit/chromium:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEditingBehavior):

WebKit/gtk:
* webkit/webkitprivate.cpp:
(WebKit::core):
* webkit/webkitprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

WebKit/mac:
* WebView/WebFrame.mm:
(core):
* WebView/WebFrameInternal.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):

WebKit/qt:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setEditingBehavior):

WebKit/win:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrevent Geolocation making callbacks to a ScriptExecutionContext that no longer exists
steveblock@google.com [Tue, 8 Jun 2010 12:29:05 +0000 (12:29 +0000)]
Prevent Geolocation making callbacks to a ScriptExecutionContext that no longer exists
https://bugs.webkit.org/show_bug.cgi?id=40162

Reviewed by Jeremy Orlow.

WebCore:

Before making callbacks, we check that the relevant ScriptExecutionContext still exists.
To achieve this, the callbacks inherit from ActiveDOMObject.

The ScriptExecutionContext is ref'ed from script, so may not be GC'ed for some time after
it is disconnected from its frame. Making the callback currently involves accessing the
Frame, so an additional check for the Frame is required.

This change also prevents the V8 bindings from incorrectly holding a reference to the Frame.

Test: fast/dom/Geolocation/callback-to-deleted-context.html

* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCustomPositionCallback.cpp:
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
* bindings/js/JSCustomPositionErrorCallback.cpp:
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomPositionCallback.cpp:
(WebCore::V8CustomPositionCallback::V8CustomPositionCallback):
(WebCore::V8CustomPositionCallback::handleEvent):
* bindings/v8/custom/V8CustomPositionCallback.h:
(WebCore::V8CustomPositionCallback::create):
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
(WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback):
(WebCore::V8CustomPositionErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomPositionErrorCallback.h:
(WebCore::V8CustomPositionErrorCallback::create):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):
* page/PositionCallback.h:
(WebCore::PositionCallback::PositionCallback):
* page/PositionErrorCallback.h:
(WebCore::PositionErrorCallback::PositionErrorCallback):

LayoutTests:

* fast/dom/Geolocation/callback-to-deleted-context-expected.txt: Added.
* fast/dom/Geolocation/callback-to-deleted-context.html: Added.
* fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html: Added.
* fast/dom/Geolocation/resources/callback-to-deleted-context-inner2.html: Added.
* fast/dom/Geolocation/script-tests/callback-to-deleted-context.js: Added.
* platform/gtk/Skipped: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGeolocation should have a LayoutTest for reentrant calls that cause a PERMISSION_DENI...
steveblock@google.com [Tue, 8 Jun 2010 12:17:31 +0000 (12:17 +0000)]
Geolocation should have a LayoutTest for reentrant calls that cause a PERMISSION_DENIED error
https://bugs.webkit.org/show_bug.cgi?id=40174

Reviewed by Alexey Proskuryakov.

Tests for reentrant calls with success and POSITION_UNAVAILABLE responses already exist,
but the code path for PERMISSION_DENIED is different.

* fast/dom/Geolocation/reentrant-permission-denied-expected.txt: Added.
* fast/dom/Geolocation/reentrant-permission-denied.html: Added.
* fast/dom/Geolocation/script-tests/reentrant-permission-denied.js: Added.
* platform/gtk/Skipped: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: adding bulach@chromium.org to commiters list.
bulach@chromium.org [Tue, 8 Jun 2010 12:05:14 +0000 (12:05 +0000)]
Unreviewed: adding bulach@chromium.org to commiters list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 8 Jun 2010 11:39:33 +0000 (11:39 +0000)]
2010-06-08  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. fast/js/large-expressions is failing only in debug mode.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 8 Jun 2010 11:32:01 +0000 (11:32 +0000)]
2010-06-08  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Remove passing tests from expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 8 Jun 2010 11:29:06 +0000 (11:29 +0000)]
2010-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Avoid duplicated signals in DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=40170

        Do not create duplicated event signals between a class and its
        ancestor.

        * bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 8 Jun 2010 11:25:10 +0000 (11:25 +0000)]
2010-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Add inner-node property to WebKitHitTestResult
        https://bugs.webkit.org/show_bug.cgi?id=40131

        Add a 'inner-node' property to WebKitHitTestResult, carrying the
        DOM node where the hit test happened.

        * tests/testhittestresult.c:
        (load_status_cb):
        * webkit/webkithittestresult.cpp:
        (webkit_hit_test_result_get_property):
        (webkit_hit_test_result_set_property):
        (webkit_hit_test_result_class_init):
        * webkit/webkitprivate.cpp:
        (WebKit::kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build box fix.
tkent@chromium.org [Tue, 8 Jun 2010 10:58:08 +0000 (10:58 +0000)]
Unreviewed, build box fix.
Touch DOMWindow.idl to reflect ENABLE_METER_TAG change on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Jun 2010 10:52:04 +0000 (10:52 +0000)]
2010-06-08  MORITA Hajime  <morrita@google.com>

        Unreviewed. An attempt to fix test break.

        * Configurations/FeatureDefines.xcconfig:
2010-06-08  MORITA Hajime  <morrita@google.com>

        Unreviewed. An attempt to fix test break.

        * Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Jun 2010 09:54:51 +0000 (09:54 +0000)]
2010-06-08  MORITA Hajime  <morrita@google.com>

        Unreviewd. Update expectations to follow r60820, r60821

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:
2010-06-08  MORITA Hajime  <morrita@google.com>

        Unreviewd. Touched the file to force rebuild.

        * html/HTMLMeterElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 8 Jun 2010 08:35:10 +0000 (08:35 +0000)]
2010-06-08  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Adam Barth.

        Change OwnPtrCommon to include platform-specific headers
        https://bugs.webkit.org/show_bug.cgi?id=40279

        Adding new type to OwnPtrCommon needlessly causes all ports to do full rebuilds.
        Change OwnPtrCommon to include platform-specific headers to avoid all ports rebuilds.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * wtf/OwnPtrCommon.h:
        * wtf/brew/OwnPtrBrew.h: Added.
        * wtf/win/OwnPtrWin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Jun 2010 08:16:29 +0000 (08:16 +0000)]
2010-06-08  MORITA Hajime  <morrita@google.com>

        Unreviewd. Updated test_expectations.txt to follow r60822

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Tue, 8 Jun 2010 08:08:52 +0000 (08:08 +0000)]
2010-06-08  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Fix the math for transform matrices of composited layers. There
        were problems both with how content layers were setting their position and
        how the overal matrix stack was computed when the layer anchor isn't at the
        center of the layer.
        https://bugs.webkit.org/post_bug.cgi

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::updateContentsRect):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayersRecursive):
        (WebCore::LayerRendererChromium::drawLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 8 Jun 2010 07:20:06 +0000 (07:20 +0000)]
2010-06-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5Lexer does not handle <div FOO ><img><img></div> correctly
        https://bugs.webkit.org/show_bug.cgi?id=40283

        * html5lib/resources/webkit01.dat:
         - Add another test for this failure case.
2010-06-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5Lexer does not handle <div FOO ><img><img></div> correctly
        https://bugs.webkit.org/show_bug.cgi?id=40283

        Fix a typo in the AfterAttributeNameState.
        The compiler really should have caught this since the typo
        resulted in unreachable code.

        Tests:
         10 tables/mozilla/marvin/colgroup* tests.
         Also added a new sub-test in html5lib/resources/webkit01.dat

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):
         - Fix typo of = instead of >

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 8 Jun 2010 07:15:52 +0000 (07:15 +0000)]
2010-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement HTML5's forceQuirks flag
        https://bugs.webkit.org/show_bug.cgi?id=40284

        I didn't implement this before because I didn't know how to test it,
        but now I do.

        Tests:
          * fast/doctypes/doctype-parsing.html.

        When we actually implement the quirks mode handling in the tree
        builder, we'll probably want to add to this test.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):
        * html/HTML5Token.h:
        (WebCore::HTML5Token::forceQuirks):
        (WebCore::HTML5Token::setForceQuirks):
        * html/HTML5TreeBuilder.cpp:
        (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::parseDoctypeToken):
        * html/HTMLTokenizer.h:
        (WebCore::DoctypeToken::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 8 Jun 2010 07:10:37 +0000 (07:10 +0000)]
2010-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove ASSERT in ~HTML5Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=40282

        We thought this ASSERT would be a good idea, but the problem is that
        this object is deleted without warning in some circumstances, so
        there's no way to know whether it has reached the end of its state
        machine.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::~HTML5Tokenizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 8 Jun 2010 07:08:28 +0000 (07:08 +0000)]
2010-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove another unterminated <title> element
        https://bugs.webkit.org/show_bug.cgi?id=40281

        We're already testing untermianted <title> element behavior in specific
        tests for that beheavior.  We don't need to test it redudantly here.

        * http/tests/security/frame-loading-via-document-write.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 8 Jun 2010 06:36:14 +0000 (06:36 +0000)]
2010-06-07  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] roll chromium DEPS
        https://bugs.webkit.org/show_bug.cgi?id=40277

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Jun 2010 06:26:06 +0000 (06:26 +0000)]
2010-06-07  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Mac] <meter> elements should be rendered as level indicators.
        https://bugs.webkit.org/show_bug.cgi?id=40217

        * fast/dom/HTMLMeterElement/meter-appearances-capacity.html: Added.
        * fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html: Added.
        * fast/dom/HTMLMeterElement/meter-optimums.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped: removed <meter> related tests.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt.
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
        * platform/win/Skipped:
2010-06-07  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Mac] <meter> elements should be rendered as level indicators.
        https://bugs.webkit.org/show_bug.cgi?id=40217

        Implemented RenderThemeMac::paintMeter() using NSLevelIndicatorCell.

        This change also added new -webkit-appearance values to select the
        style of level indicators:

        - relevancy-level-indicator,
        - continuous-capacity-level-indicator,
        - discrete-capacity-level-indicator, and
        - rating-level-indicator.

        The size of elements are adjusted based on the bounds of the indicator
        to make room for painting whole indicator cells.

        Tests: fast/dom/HTMLMeterElement/meter-appearances-capacity.html
               fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
               fast/dom/HTMLMeterElement/meter-optimums.html

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in:
        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::gaugeRegion):
        * html/HTMLMeterElement.h:
        (WebCore::HTMLMeterElement::):
        * platform/ThemeTypes.h:
        (WebCore::):
        * rendering/RenderMeter.cpp:
        (WebCore::RenderMeter::calcWidth):
        (WebCore::RenderMeter::calcHeight):
        * rendering/RenderMeter.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::meterSizeForBounds):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::meterSizeForBounds):
        (WebCore::RenderThemeMac::paintMeter):
        (WebCore::RenderThemeMac::levelIndicatorStyleFor):
        (WebCore::RenderThemeMac::levelIndicatorFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-06 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Jun 2010 05:23:57 +0000 (05:23 +0000)]
2010-06-06  MORITA Hajime  <morrita@google.com>

        Unreviewd, follow up to r60820

        https://bugs.webkit.org/show_bug.cgi?id=40219
        [Mac] ENABLE_METER_TAG should be enabled

        Added ENABLE_METER_TAG.

        * Configurations/FeatureDefines.xcconfig:
2010-06-06  MORITA Hajime  <morrita@google.com>

        Unreviewd, follow up to r60820

        https://bugs.webkit.org/show_bug.cgi?id=40219
        [Mac] ENABLE_METER_TAG should be enabled

        * Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Jun 2010 05:02:53 +0000 (05:02 +0000)]
2010-06-07  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=40219
        [Mac] ENABLE_METER_TAG should be enabled

        Added ENABLE_METER_TAG.

        * Configurations/FeatureDefines.xcconfig:
2010-06-07  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Mac] ENABLE_METER_TAG should be enabled.
        https://bugs.webkit.org/show_bug.cgi?id=40219

        * Configurations/FeatureDefines.xcconfig:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert "Refactor platform dependent editing behavior code out of Settings"
tonikitoo@webkit.org [Tue, 8 Jun 2010 04:09:25 +0000 (04:09 +0000)]
Revert "Refactor platform dependent editing behavior code out of Settings"

This reverts commit r60816: Crashed all bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert "2010-06-07 Antonio Gomes <tonikitoo@webkit.org>"
tonikitoo@webkit.org [Tue, 8 Jun 2010 04:08:02 +0000 (04:08 +0000)]
Revert "2010-06-07 Antonio Gomes <tonikitoo@webkit.org>"

This reverts r60817: Unsuccessful attept to fix the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Tue, 8 Jun 2010 04:00:21 +0000 (04:00 +0000)]
2010-06-07 Antonio Gomes <tonikitoo@webkit.org>

        Unreviewed attempt to fix crashy bots (Mac,Win,Qt,Gtk) after r60816.

        * editing/Editor.cpp:
        (WebCore::Editor::behavior):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor platform dependent editing behavior code out of Settings
tonikitoo@webkit.org [Tue, 8 Jun 2010 03:08:48 +0000 (03:08 +0000)]
Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854

Reviewed by Ojan Vafai and Darin Adler.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

As per discussion in bug 36627, the following was suggested by Darin Adler: "before the addition of any
new EditingBehavior, I think we need to add functions to translate the overall behavior policy into specific
behaviors rather than directly saying 'behavior == Mac' or 'behavior == Windows'. Helper functions that
expression the different rules in plain language.".

Patch is a first step of an incremental approach to address this request. It does not yet replace all
direct use of Editing{Mac,Windows}Behaviors, but adds infra for that and replaces some of them.

No behavior change, so no new tests.

* GNUmakefile.am:
* WebCore.pro:
* WebCore/WebCore.gypi
* WebCore/WebCore.vcproj/WebCore.vcproj
* WebCore/WebCore.xcodeproj/project.pbxproj
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h: Moved out EditingBehavior enum to WebCore/editing/EditingBehaviorTypes.h,
and renamed to EditingBehaviorTypes.
(WebCore::Settings::setEditingBehaviorType): Renamed from setEditingBehavior.
(WebCore::Settings::editingBehaviorType): Renamed from editingBehavior.
* editing/EditingBehavior.h: Added.
(WebCore::EditingBehavior::EditingBehavior): Class to work as a central point for
editing behavior that might have to be handled differently in the different platforms/ports.
Class should be not used or instantiated directly, but rather implicitly constructed
through the Editor class.
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldConsiderSelectionAsDirectional):
(WebCore::EditingBehavior::shouldCenterAlignWhenSelectionIsRevealed):
* editing/EditingBehaviorTypes.h: Added.
(WebCore::):
* editing/Editor.cpp:
(WebCore::Editor::behavior): Getter for EditingBehavior class.
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::executeToggleStyle):
(WebCore::SelectionController::setIsDirectional):
(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::modify):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):

- Call sites will look like:
if (frame->editor()->behavior().shouldThisIfThat()))
   // do something

WebKit:

EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.

WebKit/chromium:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEditingBehavior):

WebKit/gtk:
* webkit/webkitprivate.cpp:
(WebKit::core):
* webkit/webkitprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

WebKit/mac:
* WebView/WebFrame.mm:
(core):
* WebView/WebFrameInternal.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):

WebKit/qt:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setEditingBehavior):

WebKit/win:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 8 Jun 2010 02:33:36 +0000 (02:33 +0000)]
2010-06-07  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just commit an edit XCode keeps making automatically.

        It appears someone hand-edited the file, XCode no-like.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 8 Jun 2010 02:25:44 +0000 (02:25 +0000)]
2010-06-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5 Parser fails script-tests which use document.write
        https://bugs.webkit.org/show_bug.cgi?id=40276

        We were leaving the TreeBuilder paused when executing the scripts
        resulting in document.write() calls being ignored.

        I don't see a good way to ASSERT this correct behavior, since
        the HTML5ScriptRunner and the HTML5TreeBuilder do not know about
        each other.  We should never have document.write() called while
        the HTML5TreeBuilder is paused, however both document.write and
        the network call the same HTML5Tokenizer::write method.  It's OK
        to be paused when the network writes, but during document.write
        (or any other script execution).

        Tested by all of fast/url and numerous other tests.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::notifyFinished):
         - Unpause the treebuilder before executing scripts.
        (WebCore::HTML5Tokenizer::executeScriptsWaitingForStylesheets):
         - Unpause the treebuilder before executing scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60814 268f45cc-cd09-0410-ab3c-d52691b4dbfc