WebKit-https.git
4 years agoUpdate TestExpectations for a couple video track tests.
ap@apple.com [Fri, 24 Jun 2016 00:25:23 +0000 (00:25 +0000)]
Update TestExpectations for a couple video track tests.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTry to fix the non-internal builds by defining CARenderServerBufferRef.
simon.fraser@apple.com [Fri, 24 Jun 2016 00:12:36 +0000 (00:12 +0000)]
Try to fix the non-internal builds by defining CARenderServerBufferRef.

* platform/spi/cocoa/QuartzCoreSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server...
simon.fraser@apple.com [Fri, 24 Jun 2016 00:08:00 +0000 (00:08 +0000)]
[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
https://bugs.webkit.org/show_bug.cgi?id=159077

Reviewed by Tim Horton.

Source/WebCore:

Add CARenderServer SPIs.

Test: fast/harness/snapshot-captures-compositing.html

* platform/spi/cocoa/QuartzCoreSPI.h:

Tools:

Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
This allows them to capture compositing layers in snapshots, rather than doing a software paint,
thus enabling testing of more things.

* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(createBitmapContext): Moved to this file to share it.
* DumpRenderTree/cg/PixelDumpSupportCG.h:
* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView):
(BitmapContext::createFromUIImage): Deleted.
(BitmapContext::pixelData): Deleted.
(BitmapContext::BitmapContext): Deleted.
(computeMD5HashStringForBitmapContext): Deleted.
(dumpBitmap): Deleted.
* DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):
(createBitmapContext): Deleted.
* WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Deleted.
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage):

LayoutTests:

Test that fails if snapshotting doesn't correctly snapshot 3D transforms.

* fast/harness/snapshot-captures-compositing-expected.html: Added.
* fast/harness/snapshot-captures-compositing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoVersioning.
bshafiei@apple.com [Fri, 24 Jun 2016 00:00:28 +0000 (00:00 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDFGSpeculativeJIT's m_slowPathLambdas should restore the current node field and DFG...
sbarati@apple.com [Thu, 23 Jun 2016 23:28:50 +0000 (23:28 +0000)]
DFGSpeculativeJIT's m_slowPathLambdas should restore the current node field and DFG OSR entry functions should use DeferGCForAWhile instead of DeferGC
https://bugs.webkit.org/show_bug.cgi?id=159064
<rdar://problem/26599119>

Reviewed by Filip Pizlo.

The DFG has a list of m_slowPathLambdas that are code generators it emits
amongst its slow paths. These lambdas, however, did not update the m_currentNode field.
This caused us to use whatever Node happened to be used as the currentNode at the time
we call the slowPathLambda. This means the wrong CallSiteIndex was stored into the call
frame when we made a call. This may lead to a crash if the CallSiteIndex corresponds to
the wrong CodeOrigin. For example, the wrong CodeOrigin could have an InlineCallFrame with
a calleeRecovery that will not be in sync with the current stack state. Trying
to recover that callee will often lead to a crash. The solution is to update
m_currentNode to the DFG::Node* it corresponds to when emitting these slowPathLambdas.

I found this bug because we were inside this bad state when calling an operation
that happened to have a DeferGC. When this DeferGC actually GCed, it would
take a StackTrace, which would lead to a crash because we were updating
ShadowChicken with vm.topCallFrame. It just so happened that the CallSiteIndex
in the call frame in this program corresponded to an InlineCallFrame with a calleeRecover.
However, this CallSiteIndex didn't correspond to the actual state of execution
of the program. I'm adding new options to make reproducing DeferGC related
bugs easier by making DeferGC force a GC according to some probability. To
always have DeferGC force a GC, you can set that probability to 1.

There is a second bug that I discovered after solving the above bug. We were
using DeferGC instead of DeferGCForAWhile in the OSR entry related functions
in the DFG. This would cause us to take a stack trace when the call frame was
in an inconsistent state. For example, the operation would call FTL::prepareOSREntry,
which would replace the DFG CodeBlock in the call frame with the FTL CodeBlock.
However, we wouldn't update the CallSiteIndex to correspond to an FTL CallSiteIndex.
This would lead to a crash when taking a stack trace. The solution is to prevent
stack traces from being taken when the program is in this state by using
DeferGCForAWhie instead of DeferGC.

* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
* dfg/DFGSpeculativeJIT.h:
* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::collectAccordingToDeferGCProbability):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::markListSet):
* runtime/Options.cpp:
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
* runtime/Options.h:
* tests/stress/slow-path-generator-updating-current-node-dfg.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: add assertions to catch dangling frontends that persist between tests
bburg@apple.com [Thu, 23 Jun 2016 23:22:21 +0000 (23:22 +0000)]
Web Inspector: add assertions to catch dangling frontends that persist between tests
https://bugs.webkit.org/show_bug.cgi?id=159073

Reviewed by Joseph Pecoraro.

Based on the analysis in https://webkit.org/b/159070, we suspect that some test
flakiness might be caused by dangling frontends from previous test cases. Add an
assertion that should catch any frontends that are attached to the inspected page's
backend. There should never be any frontends connected when a test first starts.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::setIsUnderTest):
* inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r202380): iOS 9.x internal builds are broken
ddkilzer@apple.com [Thu, 23 Jun 2016 22:52:00 +0000 (22:52 +0000)]
REGRESSION (r202380): iOS 9.x internal builds are broken

Follow-up fix for: Enable window.open() for existing versions of Secret Society
<https://webkit.org/b/159049>
<rdar://problem/26528349>

* wtf/spi/darwin/dyldSPI.h: Define DYLD_IOS_VERSION_10_0 when
building on internal SDKs older than iOS 10.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agorequestFrameAnimation() callback timestamp should be very close to Performance.now()
commit-queue@webkit.org [Thu, 23 Jun 2016 22:46:28 +0000 (22:46 +0000)]
requestFrameAnimation() callback timestamp should be very close to Performance.now()
https://bugs.webkit.org/show_bug.cgi?id=159038

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Pass the Performance.now() to requestFrameAnimation() callback. Do not add
the timeUntilOutput which is the difference between outputTime and now since
this addition makes us report a timestamp ahead in the future by almost 33ms.

A new function named "nowTimestamp()" is added to the DOMWindow class. It
calls Performance.now() if WEB_TIMING is enabled, otherwise it calls
monotonicallyIncreasingTime(). The returned timestamp is seconds and it is
relative to the document loading time.

The timestamp passing will be removed all the down till the callers of
ScriptedAnimationController::serviceScriptedAnimations(). The callers will
getting the now timestamp by calling DOMWindow::nowTimestamp().

Tests: animations/animation-callback-timestamp.html
       animations/animation-multiple-callbacks-timestamp.html

* dom/Document.cpp:
(WebCore::Document::monotonicTimestamp):
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::animationTimerFired):
(WebCore::ScriptedAnimationController::displayRefreshFired):
* dom/ScriptedAnimationController.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getVideoPlaybackQuality):
* loader/DocumentLoadTiming.h:
(WebCore::DocumentLoadTiming::referenceWallTime):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::nowTimestamp):
* page/DOMWindow.h:
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
* page/FrameView.h:
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore::DisplayRefreshMonitor::setMonotonicAnimationStartTime): Deleted.
* platform/graphics/DisplayRefreshMonitorClient.cpp:
(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):
* platform/graphics/DisplayRefreshMonitorClient.h:
* platform/graphics/GraphicsLayerUpdater.cpp:
(WebCore::GraphicsLayerUpdater::displayRefreshFired):
* platform/graphics/GraphicsLayerUpdater.h:
* platform/graphics/ios/DisplayRefreshMonitorIOS.h:
* platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
(-[WebDisplayLinkHandler handleDisplayLink:]):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
(WebCore::mediaTimeToCurrentTime): Deleted.
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::displayLinkCallback):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):
* platform/graphics/mac/DisplayRefreshMonitorMac.h:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):

Source/WebKit2:

* WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::didUpdateLayers):

LayoutTests:

* animations/animation-callback-timestamp-expected.txt: Added.
* animations/animation-callback-timestamp.html: Added.
* animations/animation-multiple-callbacks-timestamp-expected.txt: Added.
* animations/animation-multiple-callbacks-timestamp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unused HarfBuzzFaceCoreText.cpp
ddkilzer@apple.com [Thu, 23 Jun 2016 21:28:52 +0000 (21:28 +0000)]
Remove unused HarfBuzzFaceCoreText.cpp
<https://webkit.org/b/159065>

Reviewed by Myles C. Maxfield.

* platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFailing baseline JIT compilation of a code block and then trying to compile it from...
fpizlo@apple.com [Thu, 23 Jun 2016 20:55:41 +0000 (20:55 +0000)]
Failing baseline JIT compilation of a code block and then trying to compile it from OSR from DFG/FTL will corrupt the CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=158806

Reviewed by Saam Barati.

If we try to compile a CodeBlock that we already tried compiling in the past then we need
to clean up the data structures that were partly filled in by the failed compile. That
causes some races, since the DFG may be trying to parse those data structures while we are
clearing them. This patch introduces such a clean-up (CodeBlock::resetJITData()) and fixes
the races.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::getCallLinkInfoMap):
(JSC::CodeBlock::getByValInfoMap):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::resetJITData):
(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::setSteppingMode):
(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::ensureResultProfile):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getFromAllValueProfiles):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::numberOfResultProfiles):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addRareCaseProfile): Deleted.
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset): Deleted.
(JSC::CodeBlock::couldTakeSpecialFastCase): Deleted.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
* jit/JIT.cpp:
(JSC::JIT::link):
* jit/JITWorklist.cpp:
(JSC::JITWorklist::compileNow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLand test expectations for rdar://problem/26952627.
ryanhaddad@apple.com [Thu, 23 Jun 2016 20:16:51 +0000 (20:16 +0000)]
Land test expectations for rdar://problem/26952627.

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Memory Timeline sometimes shows impossible value for bmalloc size...
commit-queue@webkit.org [Thu, 23 Jun 2016 20:05:23 +0000 (20:05 +0000)]
Web Inspector: Memory Timeline sometimes shows impossible value for bmalloc size (underflowed)
https://bugs.webkit.org/show_bug.cgi?id=158110
<rdar://problem/26498584>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-06-23
Reviewed by Andreas Kling.

Source/JavaScriptCore:

* heap/Heap.cpp:
(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):
* heap/Heap.h:
(JSC::Heap::externalMemorySize):
* heap/HeapInlines.h:
(JSC::Heap::reportExternalMemoryVisited):
Keep count of external memory we visit.

* heap/SlotVisitor.h:
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::reportExternalMemoryVisited):
Report external memory visited like we do extra memory, since
it will be some subset of extra memory that is external.

Source/WebCore:

IOSurface memory backing Canvas element buffers should be classified as "GC Owned",
but should not be considered a part of bmalloc. In fact, the actual memory cost is
external to the Web Content Process. The majority of extra memory reporters tend
to report extra memory that is also allocated in bmalloc. However, some report
non-bmalloc memory, such as the IOSurfaces here.

Continue to report the memory cost without changes to inform the Heap for garbage
collection. However, also keep better accounting of GCOwned memory that is external
to the process for better accounting for the Resource Usage overlay and Web Inspector
Memory timeline.

This is a bit of a game where we want to display the best possible number for
"GCOwned memory" in the tools, but some of that memory shows up in the other
regions (bmalloc, system malloc, etc). Already many sizes are estimates
(ReportExtraMemory, reportExtraMemory ignores small allocations), so we just focus
on getting the largest sources of allocations, such as Canvas IOSurfaces here,
into the right bucket. ResourceUsageThreadCocoa continues to subtract the "extra"
memory from bmalloc. So, we should address other large sources of "extra memory"
not in bmalloc. A likely candidate is HTMLMediaElement which uses the deprecated
reporting right now.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
Add a way to report External memory, dependent on reporting Extra memory.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::externalMemoryCost):
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
Report external memory cost just like extra memory.

* page/ResourceUsageData.cpp:
(WebCore::ResourceUsageData::ResourceUsageData):
* page/ResourceUsageData.h:
(WebCore::MemoryCategoryInfo::totalSize):
* page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::RingBuffer::at):
(WebCore::appendDataToHistory):
(WebCore::ResourceUsageOverlay::platformDraw):
* page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::categoryForVMTag):
(WebCore::ResourceUsageThread::platformThreadBody):
Do not count the GCOwned External memory as dirty memory.
Include External memory output in the overlay.

* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::collectSample):
When sizing the JavaScript portion, include both the GC Owned
category's dirty and external memory. Ultimately we will
want this everywhere in case things change.

* platform/graphics/ImageBuffer.cpp:
(WebCore::memoryCost):
(WebCore::externalMemoryCost):
* platform/graphics/ImageBuffer.h:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::memoryCost):
(WebCore::ImageBuffer::externalMemoryCost):
Report IOSurface total bytes as extra memory and external memory
so that it can be tracked as GC Owned memory that is separate from
regular (bmalloc/other) in process memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] A WebPageProxy in closed state should not be allowed to hold a process assertion
cdumez@apple.com [Thu, 23 Jun 2016 19:58:56 +0000 (19:58 +0000)]
[iOS] A WebPageProxy in closed state should not be allowed to hold a process assertion
https://bugs.webkit.org/show_bug.cgi?id=159068
<rdar://problem/17665473>

Reviewed by Tim Horton.

A WebPageProxy in closed state should not be allowed to hold a process assertion. It
currently happens that WebPageProxy::close() gets called but that the WebPageProxy is
kept alive by Safari (e.g. In case of top-hit preloading). In such cases, we fail to
release the foreground process assertion that the WebPageProxy holds.

We should clear the foreground process assertion that the WebPageProxy holds as soon
as WebPageProxy::close() is called.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[jhbuild] Added libxslt module.
annulen@yandex.ru [Thu, 23 Jun 2016 19:24:34 +0000 (19:24 +0000)]
[jhbuild] Added libxslt module.
https://bugs.webkit.org/show_bug.cgi?id=159034

Unreviewed, followup for r202373.

* efl/install-dependencies: Removed libxslt
* gtk/install-dependencies: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHandle (0, 0) ranges from Lookup
ap@apple.com [Thu, 23 Jun 2016 19:17:49 +0000 (19:17 +0000)]
Handle (0, 0) ranges from Lookup
https://bugs.webkit.org/show_bug.cgi?id=159062
rdar://problem/26960385

Reviewed by Tim Horton.

Source/WebCore:

* editing/mac/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult):
Paper over <https://bugs.webkit.org/show_bug.cgi?id=159063>, which seems too involved
to fix now.

LayoutTests:

* platform/mac/TestExpectations: Unmark the test that was broken due to this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[OS X][WK2] Expand sandbox for new mach endpoints
bfulgham@apple.com [Thu, 23 Jun 2016 19:16:42 +0000 (19:16 +0000)]
[OS X][WK2] Expand sandbox for new mach endpoints
https://bugs.webkit.org/show_bug.cgi?id=159040
<rdar://problem/25238336>

Reviewed by Alexey Proskuryakov.

Grant the WebContent and Networking processes the mach lookup capability for
various Security-related mach endpoints..

* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: first heap snapshot taken when a page is reloaded happens before the...
joepeck@webkit.org [Thu, 23 Jun 2016 18:52:59 +0000 (18:52 +0000)]
Web Inspector: first heap snapshot taken when a page is reloaded happens before the reload navigation
https://bugs.webkit.org/show_bug.cgi?id=158995
<rdar://problem/26923778>

Reviewed by Brian Burg.

Source/WebCore:

When the "Heap" instrument is included in the Timeline list
of instruments, defer starting it in an auto-capture scenario
until after the page does its first navigation.

AutoCapture on the backend happens when it is enabled at
the main resource starts loading. In that case it proceeds
through the following phases:

    No Auto Capture:
        None

    Auto Capture:
        BeforeLoad -> FirstNavigation -> AfterFirstNavigation

When toggling instruments for backend initiated capture
most instruments do not care and will just start/stop.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the TimelineAgent that the main frame navigated.
Do this after informing the HeapAgent (so any potential
snapshot does not get cleared) and PageAgent (so the
frontend knows the page navigated before the agent starts).

* inspector/InspectorTimelineAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::mainFrameNavigated):
Update the auto capture phase transitions.

(WebCore::InspectorTimelineAgent::toggleHeapInstrument):
Only start the heap agent during the None phase (console.profile)
or with the first navigation (auto capture page navigation).

Source/WebInspectorUI:

Let instruments decide to do work or not based on programmatic
(backend initiated) starts and stop.

Programmatic start can happen due to Auto Capture or console.profile.
Programmatic stop can happen due to console.profileEnd.

For example, this allows the frontend to avoid sending agents start/stop
messages when the backend would have already started/stopped the agents.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.capturingStopped):
(WebInspector.TimelineManager.prototype.autoCaptureStarted):
(WebInspector.TimelineManager.prototype.programmaticCaptureStarted):
Call Recording.start/stop with a programmatic flag so the frontend
instruments can perform a more informed start/stop.

* UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.start):
(WebInspector.TimelineRecording.prototype.stop):
Let the instruments decide to do work based on the start/stop
being initiated by the backend or not.

* UserInterface/Models/HeapAllocationsInstrument.js:
(WebInspector.HeapAllocationsInstrument.prototype.startInstrumentation):
(WebInspector.HeapAllocationsInstrument.prototype.stopInstrumentation):
* UserInterface/Models/Instrument.js:
(WebInspector.Instrument.startLegacyTimelineAgent):
(WebInspector.Instrument.prototype.startInstrumentation):
(WebInspector.Instrument.prototype.stopInstrumentation):
(WebInspector.Instrument):
* UserInterface/Models/MemoryInstrument.js:
(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
(WebInspector.MemoryInstrument):
* UserInterface/Models/NetworkInstrument.js:
* UserInterface/Models/ScriptInstrument.js:
(WebInspector.ScriptInstrument.prototype.startInstrumentation):
(WebInspector.ScriptInstrument.prototype.stopInstrumentation):
(WebInspector.ScriptInstrument):
Avoid sending start/stop tracking messages when programmatic.
This still allows the instruments to do their own frontend tracking,
such as the Heap agent triggering periodic snapshots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Snapshots should be cleared at some point
joepeck@webkit.org [Thu, 23 Jun 2016 18:52:54 +0000 (18:52 +0000)]
Web Inspector: Snapshots should be cleared at some point
https://bugs.webkit.org/show_bug.cgi?id=157907
<rdar://problem/26373610>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* heap/HeapSnapshotBuilder.h:
* heap/HeapSnapshotBuilder.cpp:
(JSC::HeapSnapshotBuilder::resetNextAvailableObjectIdentifier):
Provide a way to reset the object identifier counter.

* inspector/agents/InspectorHeapAgent.h:
* inspector/agents/InspectorHeapAgent.cpp:
(Inspector::InspectorHeapAgent::clearHeapSnapshots):
Make clearHeapSnapshots protected, so it can be called from a
a PageHeapAgent on page navigations.

Source/WebCore:

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
New specialized agent.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Construct a specialized HeapAgent.

* inspector/PageHeapAgent.h:
* inspector/PageHeapAgent.cpp:
(WebCore::PageHeapAgent::PageHeapAgent):
(WebCore::PageHeapAgent::enable):
(WebCore::PageHeapAgent::disable):
(WebCore::PageHeapAgent::mainFrameNavigated):
Clear backend snapshots on page navigations.
Set the PageHeapAgent instrumenting agent on enable/disable.

* inspector/InstrumentingAgents.cpp:
(WebCore::InstrumentingAgents::reset):
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::pageHeapAgent):
(WebCore::InstrumentingAgents::setPageHeapAgent):
Active PageHeapAgent.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the PageHeapAgent when the mainframe navigates.

Source/WebInspectorUI:

Invalidate HeapSnapshotProxy objects when the page navigates.
This allows us to clear our frontend data for the snapshots.
When a snapshot is invalidated, it is disabled in the UI.
This means you cannot select the snapshot or see content
views for the snapshot. If you are in a snapshot when it is
invalidated, you are taken out to the snapshot list.

* UserInterface/Main.html:
New files.

* UserInterface/Proxies/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.invalidateSnapshotProxies):
(WebInspector.HeapSnapshotProxy.prototype.get invalid):
(WebInspector.HeapSnapshotProxy.prototype._invalidate):
Keep track of valid snapshots, and provide a static method to invalidate them.

(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotProxy.prototype.update):
(WebInspector.HeapSnapshotProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

* UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WebInspector.HeapSnapshotDiffProxy.prototype.get invalid):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotDiffProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotDiffProxy.prototype.update):
(WebInspector.HeapSnapshotDiffProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

* UserInterface/Proxies/HeapSnapshotWorkerProxy.js:
(WebInspector.HeapSnapshotWorkerProxy.prototype._mainResourceDidChange):
Invalidate and discard snapshots when the main frame navigates.

(WebInspector.HeapSnapshotWorkerProxy.prototype._handleMessage):
(WebInspector.HeapSnapshotWorkerProxy):
* UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:
(HeapSnapshotWorker.prototype.clearSnapshots):
(HeapSnapshotWorker.prototype._handleMessage):
(HeapSnapshotWorker):
A message may come in for a snapshot before it has been cleared.
If that is the case, the object may not exist. Return an error so
that the callback can be deleted on the calling side.

* UserInterface/Views/HeapAllocationsTimelineDataGridNodePathComponent.js:
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get previousSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get nextSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent):
Don't show invalid snapshots in page component picker.

* UserInterface/Views/HeapAllocationsTimelineOverviewGraph.css:
(.timeline-overview-graph.heap-allocations > img.snapshot.invalid):
* UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCells):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype._heapSnapshotInvalidated):
Give invalid snapshots an invalidated appearance in the snapshot list.

* UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):
* UserInterface/Views/HeapAllocationsTimelineView.css:
(.timeline-view.heap-allocations > .data-grid tr.invalid):
(.timeline-view.heap-allocations > .data-grid:not(:focus, .force-focus) tr.selected.invalid):
Give invalid snapshots an invalidated appearance in the overview graph.

* UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.get selectionPathComponents):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent.updateHeapSnapshotForEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotInvalidated):
(WebInspector.HeapAllocationsTimelineView.prototype._updateCompareHeapSnapshotButton):
(WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
Handle interactions when snapshots in the list are invalidated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCSSComputedStyleDeclaration::length should recalculate styles if needed to provide...
commit-queue@webkit.org [Thu, 23 Jun 2016 18:43:43 +0000 (18:43 +0000)]
CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
https://bugs.webkit.org/show_bug.cgi?id=159053
<rdar://problem/26638119>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/variables/custom-property-computed-style-length-update.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::length):

LayoutTests:

* fast/css/variables/custom-property-computed-style-length-update-expected.txt: Added.
* fast/css/variables/custom-property-computed-style-length-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r201194.
commit-queue@webkit.org [Thu, 23 Jun 2016 16:56:48 +0000 (16:56 +0000)]
Unreviewed, rolling out r201194.
https://bugs.webkit.org/show_bug.cgi?id=159059

Not needed for iOS (Requested by bfulgham on #webkit).

Reverted changeset:

"[OS X][WK2] Expand sandbox for new mach endpoints"
https://bugs.webkit.org/show_bug.cgi?id=157919
http://trac.webkit.org/changeset/201194

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/WebCore:
wilander@apple.com [Thu, 23 Jun 2016 16:35:17 +0000 (16:35 +0000)]
Source/WebCore:
Enable window.open() for existing versions of Secret Society
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

No new tests. Tested manually in the app.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
    Now checks with Settings whether it should allow a popup even though it is
    not processing a user gesture.
* page/Settings.in:
    Added setting allowWindowOpenWithoutUserGesture.
* platform/RuntimeApplicationChecks.h:
* platform/RuntimeApplicationChecks.mm:
(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
    Added.

Source/WebKit/mac:
Enable window.open() for existing versions of Secret Society app
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

* WebView/WebView.mm:
(shouldAllowWindowOpenWithoutUserGesture):
    Added.
(shouldConvertInvalidURLsToBlank):
    Changed hex number to constant DYLD_IOS_VERSION_10_0.

Source/WTF:
Enable window.open() for existing versions of Secret Society
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

* wtf/spi/darwin/dyldSPI.h:
    Added DYLD_IOS_VERSION_10_0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoOnly call sqlite3_initialize() when a SQLite database is actually being opened
cdumez@apple.com [Thu, 23 Jun 2016 16:03:18 +0000 (16:03 +0000)]
Only call sqlite3_initialize() when a SQLite database is actually being opened
https://bugs.webkit.org/show_bug.cgi?id=159033

Reviewed by Brady Eidson.

Only call sqlite3_initialize() when a SQLite database is actually being opened
instead of doing it unconditionally. sqlite3_initialize() was previously called
in the SQLiteDatabase constructor which gets called on WebContent process
initialization because a DatabaseTracker is constructed on initialization and
DatabaseTracker has a SQLiteDatabase data member.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::initializeSQLiteIfNecessary):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::SQLiteDatabase): Deleted.
* platform/sql/SQLiteDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 speci...
adam.bergkvist@ericsson.com [Thu, 23 Jun 2016 15:10:46 +0000 (15:10 +0000)]
WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification
https://bugs.webkit.org/show_bug.cgi?id=159054

Reviewed by Eric Carlson.

Add checks for same state and closed RTCPeerConnection in the 'update ICE connection state'
and 'update ICE gathering state' routines as described in [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state

No change in current behavior.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Bump gstreamer version from 1.6.3 to 1.8.0
commit-queue@webkit.org [Thu, 23 Jun 2016 15:05:31 +0000 (15:05 +0000)]
[EFL] Bump gstreamer version from 1.6.3 to 1.8.0
https://bugs.webkit.org/show_bug.cgi?id=159050

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2016-06-23
Reviewed by Antonio Gomes.

To be sync with GTK port, this patch bumps gstreamer version for EFL port.

* efl/jhbuild.modules:
* efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
* efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC: Add support for RTCPeerConnection legacy MediaStream-based API
adam.bergkvist@ericsson.com [Thu, 23 Jun 2016 13:52:13 +0000 (13:52 +0000)]
WebRTC: Add support for RTCPeerConnection legacy MediaStream-based API
https://bugs.webkit.org/show_bug.cgi?id=158940

Reviewed by Eric Carlson.

Source/WebCore:

Implement the legacy MediaStream-based RTCPeerConnection API as JS built-ins. The
getRemoteStreams() function and the 'addstream' event are partly implemented with native
code.

Test: fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html

* Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):
(WebCore::MediaEndpointPeerConnection::getRemoteStreams):
The getRemoteStreams() function and the 'addstream' event is backed up by native code.
* Modules/mediastream/MediaEndpointPeerConnection.h:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
(getLocalStreams):
(getRemoteStreams):
(getStreamById):
(addStream):
(removeStream):
Legacy API implemented as JS built-ins.
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
* bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

Add test for RTCPeerConnection legacy MediaStream-based API.

* fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html: Added.
* platform/mac/TestExpectations:
Skip test for mac port (not building with WEB_RTC yet)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed test gardening.
pvollan@apple.com [Thu, 23 Jun 2016 10:08:44 +0000 (10:08 +0000)]
Unreviewed test gardening.

Update test expectations for passing accessibility tests after r202149,
and fix style issues in test expectations file.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[jhbuild] Added libxslt module.
annulen@yandex.ru [Thu, 23 Jun 2016 09:51:51 +0000 (09:51 +0000)]
[jhbuild] Added libxslt module.
https://bugs.webkit.org/show_bug.cgi?id=159034

Reviewed by Michael Catanzaro.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Update OptionsGTK.cmake and NEWS for 2.13.2 release.
carlosgc@webkit.org [Thu, 23 Jun 2016 09:16:46 +0000 (09:16 +0000)]
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.13.2 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

* gtk/NEWS: Add release notes for 2.13.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Fix the build with CSS Shapes disabled.
carlosgc@webkit.org [Thu, 23 Jun 2016 08:50:42 +0000 (08:50 +0000)]
Unreviewed. Fix the build with CSS Shapes disabled.

* css/StyleBuilderConverter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Soup] Clean up SocketStreamHandle soup implementation
carlosgc@webkit.org [Thu, 23 Jun 2016 07:23:19 +0000 (07:23 +0000)]
[Soup] Clean up SocketStreamHandle soup implementation
https://bugs.webkit.org/show_bug.cgi?id=159024

Reviewed by Žan Doberšek.

Stop using a global HashMap to "acivate"/"deactivate" handles, and just take a reference of the handle and
pass the ownership to the callbacks, using a GCancellable to cancel all async operations.

* platform/network/soup/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
(WebCore::SocketStreamHandle::id): Deleted.
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::connectedCallback):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::readReadyCallback):
(WebCore::SocketStreamHandle::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandle::writeReadyCallback):
(WebCore::getHandleFromId): Deleted.
(WebCore::deactivateHandle): Deleted.
(WebCore::activateHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::connectedCallback): Deleted.
(WebCore::readReadyCallback): Deleted.
(WebCore::writeReadyCallback): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Use Windows api function to find top level parent.
pvollan@apple.com [Thu, 23 Jun 2016 06:44:02 +0000 (06:44 +0000)]
[Win] Use Windows api function to find top level parent.
https://bugs.webkit.org/show_bug.cgi?id=159021

Reviewed by Brent Fulgham.

Delete findTopLevelParent function, and use Win32 function GetAncestor instead.

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::runModal):
(findTopLevelParent): Deleted.
* MiniBrowser/win/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::runModal):
(findTopLevelParent): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
pvollan@apple.com [Thu, 23 Jun 2016 06:33:07 +0000 (06:33 +0000)]
[Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=158934

Reviewed by Brent Fulgham.

Source/WebKit/win:

Add a method to delete all indexed databases.

* Interfaces/IWebDatabaseManager.idl:
* WebDatabaseManager.cpp:
(WebDatabaseManager::QueryInterface):
(WebDatabaseManager::deleteAllIndexedDatabases):
* WebDatabaseManager.h:

Tools:

DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.

* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::clearAllDatabases):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r201880): WebSockets based remote inspector is broken since r201880
carlosgc@webkit.org [Thu, 23 Jun 2016 06:10:48 +0000 (06:10 +0000)]
REGRESSION(r201880): WebSockets based remote inspector is broken since r201880
https://bugs.webkit.org/show_bug.cgi?id=158613

Reviewed by Michael Catanzaro.

In r201880 SocketStreamHandleClient was modified to receive references instead of
pointers. WebSocketServerConnection also implements SocketStreamHandleClient but since it's doesn't use
override, it was unnoticed and not updated, so we ended up using the default empty implementation instead of
the WebSocketServerConnection one.

* UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::setSocketHandle):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
(WebKit::WebSocketServerConnection::didUpdateBufferedAmount):
(WebKit::WebSocketServerConnection::didFailSocketStream): Deleted.
* UIProcess/InspectorServer/WebSocketServerConnection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agorun-javascriptcore-tests should have some environment variables for commonly used...
sbarati@apple.com [Thu, 23 Jun 2016 05:46:10 +0000 (05:46 +0000)]
run-javascriptcore-tests should have some environment variables for commonly used settings
https://bugs.webkit.org/show_bug.cgi?id=159047

Reviewed by Keith Miller.

This patch adds three environment variables that run-javascriptcore-tests
consults:
- RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
  determines if we should run the api tests or not.
- RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
  determines if we will perform a build or not before running the tests.
  to set the default should-build setting.
- RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
  a yaml file. If set, we will run the extra tests it refers to.

All the values in these environment variables will be overridden if an
option is explicitly passed in. For example, the following will run
the api tests:
`RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS][WK2] Expand sandbox to read voice services preferences
bfulgham@apple.com [Thu, 23 Jun 2016 04:01:04 +0000 (04:01 +0000)]
[iOS][WK2] Expand sandbox to read voice services preferences
https://bugs.webkit.org/show_bug.cgi?id=159046
<rdar://problem/26926722>

Reviewed by Alexey Proskuryakov.

Expand the sandbox to permit read-only access to voice services preferences.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
sbarati@apple.com [Thu, 23 Jun 2016 03:24:18 +0000 (03:24 +0000)]
TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=159037
<rdar://problem/26935349>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

The primary focus of this patch is to make the concurrent
baseline JIT work with the type profiler. We were clearing
the type profiler log on the background baseline compiler
thread which lead to bad things happening. This patch fixes
this by processing the log before we launch the compile on
a background thread.

Secondly, I audited the type profiler code inside the DFG,
and found that we were doing some racy things. I haven't
seen any crashes because of these things, but it is possible
that they exist. We were grabbing a RefPtr to a TypeSet,
even though TypeSet was RefCounted and not ThreadSafeRefCounted.
This patch makes TypeSet ThreadSafeRefCounted. We were
also copying a StructureSet while the execution thread could
be augmenting the StructureSet. This patch puts changes to
TypeSet's StructureSet behind a ConcurrentJITLock.

I've also added two more large running tests that run with the
type profiler enabled. These are here just to catch any major bugs
in the type profiler implementation.

* jit/JIT.cpp:
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
(JSC::JIT::doMainThreadPreparationBeforeCompile):
(JSC::JIT::frameRegisterCountFor):
* jit/JIT.h:
(JSC::JIT::compile):
* jit/JITWorklist.cpp:
(JSC::JITWorklist::Plan::Plan):
(JSC::JITWorklist::Plan::compileInThread):
* runtime/TypeSet.cpp:
(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::invalidateCache):
* runtime/TypeSet.h:
(JSC::TypeSet::create):
(JSC::TypeSet::isEmpty):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::structureSet):
* tests/typeProfiler/deltablue-for-of.js: Added.
* tests/typeProfiler/getter-richards.js: Added.

Tools:

Run typeProfiler.yaml tests under an additional CJIT enabled mode.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWe should have a DFG intrinsic that checks if a value is a TypedArrayView
keith_miller@apple.com [Thu, 23 Jun 2016 01:39:01 +0000 (01:39 +0000)]
We should have a DFG intrinsic that checks if a value is a TypedArrayView
https://bugs.webkit.org/show_bug.cgi?id=159048

Reviewed by Saam Barati.

This patch adds a new DFG Intrinsic that checks if a value is a TypedArrayView.
The intrinsic, IsTypedArrayView, works in the same way that the other Is<insert-type>
DFG nodes work. Additionally, a new builtin function isTypedArrayView has been added.
These changes are needed to fix regressions in %TypedArray%.prototype.subarray.

* builtins/BuiltinNames.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIsTypedArrayView):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsTypedArrayView):
(JSC::FTL::DFG::LowerDFGToB3::isTypedArrayView):
* runtime/Intrinsic.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewPrivateFuncIsTypedArrayView):
* runtime/JSTypedArrayViewPrototype.h:
* tests/stress/istypedarrayview-intrinsic.js: Added.
(makeFn):
(typedArrays.forEach):
(let.test):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix style issues in webkitpy
aakash_jain@apple.com [Thu, 23 Jun 2016 01:13:45 +0000 (01:13 +0000)]
Fix style issues in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=159019

Reviewed by Daniel Bates.

Fixed the formatting issues as reported by check-webkit-style in webkitpy.
There is no functionality change.
Only affected file names retained below for brevity.

* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
* Scripts/webkitpy/benchmark_runner/utils.py:
* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/checkout/checkout.py:
* Scripts/webkitpy/common/checkout/checkout_mock.py:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/commitinfo.py:
* Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
* Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
* Scripts/webkitpy/common/checkout/scm/scm.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/config/committers_unittest.py:
* Scripts/webkitpy/common/config/irc.py:
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
* Scripts/webkitpy/common/config/urls.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
* Scripts/webkitpy/common/net/networktransaction_unittest.py:
* Scripts/webkitpy/common/net/statusserver.py:
* Scripts/webkitpy/common/system/autoinstall.py:
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/common/system/executive_mock.py:
* Scripts/webkitpy/common/system/executive_unittest.py:
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/common/system/filesystem_unittest.py:
* Scripts/webkitpy/common/system/logutils_unittest.py:
* Scripts/webkitpy/common/system/path.py:
* Scripts/webkitpy/common/system/path_unittest.py:
* Scripts/webkitpy/common/system/platforminfo.py:
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/common/system/user_unittest.py:
* Scripts/webkitpy/common/system/workspace_unittest.py:
* Scripts/webkitpy/common/thread/threadedmessagequeue.py:
* Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/models/test_configuration.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/models/test_failures.py:
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
* Scripts/webkitpy/layout_tests/views/printing.py:
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
* Scripts/webkitpy/port/base_unittest.py:
* Scripts/webkitpy/port/driver.py:
* Scripts/webkitpy/port/driver_unittest.py:
* Scripts/webkitpy/port/factory.py:
* Scripts/webkitpy/port/gtk.py:
* Scripts/webkitpy/port/server_process_unittest.py:
* Scripts/webkitpy/port/test.py:
* Scripts/webkitpy/port/win.py:
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checkers/common_unittest.py:
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
* Scripts/webkitpy/style/checkers/js.py:
* Scripts/webkitpy/style/checkers/jsonchecker.py:
* Scripts/webkitpy/style/checkers/png.py:
* Scripts/webkitpy/style/checkers/text.py:
* Scripts/webkitpy/style/checkers/text_unittest.py:
* Scripts/webkitpy/style/error_handlers.py:
* Scripts/webkitpy/style/filter.py:
* Scripts/webkitpy/style/filter_unittest.py:
* Scripts/webkitpy/style/optparser.py:
* Scripts/webkitpy/style/optparser_unittest.py:
* Scripts/webkitpy/test/main.py:
* Scripts/webkitpy/w3c/test_converter.py:
* Scripts/webkitpy/w3c/test_converter_unittest.py:
* Scripts/webkitpy/w3c/test_importer_unittest.py:
* Scripts/webkitpy/xcode/simulator.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd SPI to allow creating a WKCertificateInfoRef from a SecTrustRef
commit-queue@webkit.org [Thu, 23 Jun 2016 00:19:53 +0000 (00:19 +0000)]
Add SPI to allow creating a WKCertificateInfoRef from a SecTrustRef
https://bugs.webkit.org/show_bug.cgi?id=159025

Patch by Sam Weinig <sam@webkit.org> on 2016-06-22
Reviewed by Tim Horton.

* Shared/API/c/mac/WKCertificateInfoMac.h:
* Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithServerTrust):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest expectations gardening for rdar://problem/26960385
ap@apple.com [Thu, 23 Jun 2016 00:14:45 +0000 (00:14 +0000)]
Test expectations gardening for rdar://problem/26960385

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDatabaseProcess doesn't handle WebProcesses going away uncleanly.
beidson@apple.com [Wed, 22 Jun 2016 23:46:05 +0000 (23:46 +0000)]
DatabaseProcess doesn't handle WebProcesses going away uncleanly.
https://bugs.webkit.org/show_bug.cgi?id=158894

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by additions to existing API test).

* Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::registerDatabaseConnection):
(WebCore::IDBServer::IDBConnectionToClient::unregisterDatabaseConnection):
(WebCore::IDBServer::IDBConnectionToClient::connectionToClientClosed):
* Modules/indexeddb/server/IDBConnectionToClient.h:

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::unregisterConnection): Call connectionToClientClosed() on
  the connection, which cleans up after it in the server.

* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection):

Source/WebKit2:

* DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didClose):

* DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess): Actually unregister this connection
  from the IDBServer so it can clean up.
(WebKit::WebIDBConnectionToClient::~WebIDBConnectionToClient):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: Add support for CSS4 :focus-within pseudo
commit-queue@webkit.org [Wed, 22 Jun 2016 23:35:25 +0000 (23:35 +0000)]
AX: Add support for CSS4 :focus-within pseudo
https://bugs.webkit.org/show_bug.cgi?id=140144

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-22
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/css/pseudo-focus-within-basics.html
       fast/css/pseudo-focus-within-inside-shadow-dom.html
       fast/css/pseudo-focus-within-style-sharing-1.html
       fast/css/pseudo-focus-within-style-sharing-2.html
       fast/selectors/focus-within-style-update.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasFocusWithin):
* dom/ContainerNode.cpp:
(WebCore::destroyRenderTreeIfNeeded):
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::setFocus):
(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::setIsNamedFlowContentElement):
(WebCore::Element::clearIsNamedFlowContentElement):
(WebCore::Element::setStyleAffectedByFocusWithin):
(WebCore::Element::rareDataStyleAffectedByFocusWithin):
(WebCore::Element::rareDataIsNamedFlowContentElement):
* dom/Element.h:
(WebCore::Element::hasFocusWithin):
(WebCore::Element::styleAffectedByFocusWithin):
(WebCore::Element::isNamedFlowContentElement):
(WebCore::Element::setHasFocusWithin):
* dom/ElementRareData.h:
(WebCore::ElementRareData::styleAffectedByFocusWithin):
(WebCore::ElementRareData::setStyleAffectedByFocusWithin):
(WebCore::ElementRareData::isNamedFlowContentElement):
(WebCore::ElementRareData::setIsNamedFlowContentElement):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetComputedStyle):
* dom/Node.h:
(WebCore::Node::flagHasFocusWithin):
(WebCore::Node::isNamedFlowContentNode): Deleted.
(WebCore::Node::setIsNamedFlowContentNode): Deleted.
(WebCore::Node::clearIsNamedFlowContentNode): Deleted.
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::nextNodeInsideContentElement):
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateElementRenderer):
* style/StyleRelations.cpp:
(WebCore::Style::commitRelationsToRenderStyle):
(WebCore::Style::commitRelations):
* style/StyleRelations.h:
* style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement):

LayoutTests:

* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:
* fast/css/pseudo-focus-within-basics-expected.html: Added.
* fast/css/pseudo-focus-within-basics.html: Added.
* fast/css/pseudo-focus-within-inside-shadow-dom-expected.html: Added.
* fast/css/pseudo-focus-within-inside-shadow-dom.html: Added.
* fast/css/pseudo-focus-within-style-sharing-1-expected.html: Added.
* fast/css/pseudo-focus-within-style-sharing-1.html: Added.
* fast/css/pseudo-focus-within-style-sharing-2-expected.html: Added.
* fast/css/pseudo-focus-within-style-sharing-2.html: Added.
* fast/selectors/focus-within-style-update-expected.txt: Added.
* fast/selectors/focus-within-style-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoStop using PassRefPtr in ShareableResource
cdumez@apple.com [Wed, 22 Jun 2016 23:31:42 +0000 (23:31 +0000)]
Stop using PassRefPtr in ShareableResource
https://bugs.webkit.org/show_bug.cgi?id=159043

Reviewed by Alex Christensen.

Stop using PassRefPtr in ShareableResource.

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::store):
* NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):
* Shared/ShareableResource.cpp:
(WebKit::shareableResourceDeallocate):
(WebKit::ShareableResource::wrapInSharedBuffer):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::create):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::ShareableResource):
* Shared/ShareableResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoIntegrate WebKit's CFURLConnection with App Transport Security
oliver@apple.com [Wed, 22 Jun 2016 23:23:46 +0000 (23:23 +0000)]
Integrate WebKit's CFURLConnection with App Transport Security
https://bugs.webkit.org/show_bug.cgi?id=159039
<rdar://problem/26953685>

Reviewed by Alex Christensen.

Pass additional options to NSURLConnect initialiser to identify that
this connection is for WebKit content loading.

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate animometer.plan
jonlee@apple.com [Wed, 22 Jun 2016 22:56:56 +0000 (22:56 +0000)]
Update animometer.plan
https://bugs.webkit.org/show_bug.cgi?id=159012

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION: Double tap to zoom does not work on yahoo finance
dino@apple.com [Wed, 22 Jun 2016 22:52:00 +0000 (22:52 +0000)]
REGRESSION: Double tap to zoom does not work on yahoo finance
https://bugs.webkit.org/show_bug.cgi?id=158886
<rdar://problem/24917760>

Reviewed by Simon Fraser.

Source/WebKit2:

We shouldn't enable fast click on pages that have
had to shrink to fit. In other words, we should enable
double-tap-to-zoom if the page has already zoomed.

Test: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsDoubleTapGestures]):

LayoutTests:

* fast/events/ios/viewport-shrink-to-fit-allows-double-tap-expected.txt: Added.
* fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: don't start auto capturing if the Inspector window is not visible
bburg@apple.com [Wed, 22 Jun 2016 22:19:22 +0000 (22:19 +0000)]
Web Inspector: don't start auto capturing if the Inspector window is not visible
https://bugs.webkit.org/show_bug.cgi?id=159014

Reviewed by Joseph Pecoraro.
<rdar://problem/26931269>

Followup, add a missing super.closed() call mentioned in review comments.

* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.prototype.closed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: don't start auto capturing if the Inspector window is not visible
bburg@apple.com [Wed, 22 Jun 2016 22:05:40 +0000 (22:05 +0000)]
Web Inspector: don't start auto capturing if the Inspector window is not visible
https://bugs.webkit.org/show_bug.cgi?id=159014
<rdar://problem/26931269>

Reviewed by Joseph Pecoraro.

TimelineTabContentView should not tell the timeline manager to enable
auto-capturing unless the Web Inspector UI is visible. If it is preloaded
but not shown to the user, then auto-capturing may inadvertently disable
the debugger, causing it to miss `debugger` statements and not bring the
inspector to front.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.set autoCaptureOnPageLoad):
Bail out if nothing changed. Coerce to a boolean since the backend requires a boolean.

* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView): Listen for UI visibility changes.
(WebInspector.TimelineTabContentView.prototype.shown):
Enable auto-capturing if the UI is visible.

(WebInspector.TimelineTabContentView.prototype.closed): Added.
Remove listeners on global objects so this tab doesn't leak.

(WebInspector.TimelineTabContentView.prototype._inspectorVisibilityChanged):
Update the auto-capturing setting if the UI became visible or not visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Automation: Automation.inspectBrowsingContext should have an option to enable...
bburg@apple.com [Wed, 22 Jun 2016 21:41:01 +0000 (21:41 +0000)]
Web Automation: Automation.inspectBrowsingContext should have an option to enable timeline auto-capturing
https://bugs.webkit.org/show_bug.cgi?id=159004
<rdar://problem/26931269>

Reviewed by Joseph Pecoraro.

Automation.inspectBrowsingContext was added to make it easier to hit breakpoints inside of
code evaluated using Automation.evaluateJavaScriptFunction. I recently changed the behavior
of this command to automatically start profiling the page as soon as the inspector attached
so that a full timeline recording could be obtained. However, starting a timeline recording
turns off the debugger, so this command is not so useful for debugging right now.

Add a new option, enableAutoCapturing, to the inspectBrowsingContext command. Don't toggle
profiling automatically unless this optional flag is present and set to true.

* UIProcess/Automation/Automation.json:
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::inspectBrowsingContext):
(WebKit::WebAutomationSession::inspectorFrontendLoaded): Deleted.
* UIProcess/Automation/WebAutomationSession.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdopt commitPriority to get rid of the 2 AVPL solution for PiP
jeremyj-wk@apple.com [Wed, 22 Jun 2016 21:17:29 +0000 (21:17 +0000)]
Adopt commitPriority to get rid of the 2 AVPL solution for PiP
https://bugs.webkit.org/show_bug.cgi?id=158949
rdar://problem/26867866

Reviewed by Simon Fraser.

No new tests because there is no behavior change. This reverts changes from
https://bugs.webkit.org/show_bug.cgi?id=158148 and instead uses -[CAContext commitPriority:]
to prevent flicker when moving a layer between contexts.
commitPriority allows the layer to be added to the destination context before it is
removed from the source context.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: remove m_secondaryVideoLayer.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): ditto.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: ditto
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): ditto
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers):ditto
* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: ditto
* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayer): ditto
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): ditto and adopt commitPriority.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame): ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayers): Deleted.
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer): remove m_secondaryVideoLayer.
* platform/spi/cocoa/QuartzCoreSPI.h: Add commitPriority.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest gardening for css3/line-break-language-sensitive
mmaxfield@apple.com [Wed, 22 Jun 2016 21:06:16 +0000 (21:06 +0000)]
Test gardening for css3/line-break-language-sensitive
https://bugs.webkit.org/show_bug.cgi?id=159017

Unreviewed.

Some reftests had content which ended up outside of the viewport. This patch
splits that extra content out into separate tests.

In addition, this test migrates these tests to using a web font, so the results
of this test are not sensitive to platform-specific font fallback.

Because of the migration to the web font, css3/line-break-language-sensitive is
no longer needed.

* TestExpectations:
* css3/line-break-language-sensitive/line-break-auto-centered-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-centered.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-half-kana-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-half-kana.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-hyphens.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-inseparables-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-inseparables.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-iteration-marks-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-iteration-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-postfixes.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-prefixes-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-prefixes.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-sound-marks-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-auto-sound-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-centered.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-half-kana-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-half-kana.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-hyphens.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-inseparables-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-inseparables.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-iteration-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-postfixes.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-prefixes-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-prefixes.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-sound-marks-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-loose-sound-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-centered-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-centered.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-half-kana-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-half-kana.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-hyphens-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-hyphens.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-inseparables-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-inseparables.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-iteration-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-postfixes.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-prefixes-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-prefixes.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-sound-marks-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-normal-sound-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-centered-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-centered.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-half-kana-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-half-kana.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-hyphens.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-inseparables-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-inseparables.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-iteration-marks-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-iteration-marks.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-postfixes.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-prefixes-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-prefixes.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-sound-marks-expected.html: Removed.
* css3/line-break-language-sensitive/line-break-strict-sound-marks.html: Removed.
* css3/line-break/line-break-auto-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-strict-hyphens-expected.html.
* css3/line-break/line-break-auto-centered-2.html: Added.
* css3/line-break/line-break-auto-centered-expected.html:
* css3/line-break/line-break-auto-centered.html:
* css3/line-break/line-break-auto-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-auto-half-kana-2.html: Added.
* css3/line-break/line-break-auto-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-auto-half-kana-3.html: Added.
* css3/line-break/line-break-auto-half-kana-4-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-strict-postfixes-expected.html.
* css3/line-break/line-break-auto-half-kana-4.html: Added.
* css3/line-break/line-break-auto-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-auto-postfixes-expected.html.
* css3/line-break/line-break-auto-half-kana-5.html: Added.
* css3/line-break/line-break-auto-half-kana-expected.html:
* css3/line-break/line-break-auto-half-kana.html:
* css3/line-break/line-break-auto-hyphens-expected.html:
* css3/line-break/line-break-auto-hyphens.html:
* css3/line-break/line-break-auto-inseparables-expected.html:
* css3/line-break/line-break-auto-inseparables.html:
* css3/line-break/line-break-auto-iteration-marks-expected.html:
* css3/line-break/line-break-auto-iteration-marks.html:
* css3/line-break/line-break-auto-postfixes-expected.html:
* css3/line-break/line-break-auto-postfixes.html:
* css3/line-break/line-break-auto-prefixes-expected.html:
* css3/line-break/line-break-auto-prefixes.html:
* css3/line-break/line-break-auto-sound-marks-expected.html:
* css3/line-break/line-break-auto-sound-marks.html:
* css3/line-break/line-break-loose-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-hyphens-expected.html.
* css3/line-break/line-break-loose-centered-2.html: Added.
* css3/line-break/line-break-loose-centered-expected.html:
* css3/line-break/line-break-loose-centered.html:
* css3/line-break/line-break-loose-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-loose-half-kana-2.html: Added.
* css3/line-break/line-break-loose-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-loose-half-kana-3.html: Added.
* css3/line-break/line-break-loose-half-kana-4-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-centered-expected.html.
* css3/line-break/line-break-loose-half-kana-4.html: Added.
* css3/line-break/line-break-loose-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-iteration-marks-expected.html.
* css3/line-break/line-break-loose-half-kana-5.html: Added.
* css3/line-break/line-break-loose-half-kana-expected.html:
* css3/line-break/line-break-loose-half-kana.html:
* css3/line-break/line-break-loose-hyphens-expected.html:
* css3/line-break/line-break-loose-hyphens.html:
* css3/line-break/line-break-loose-inseparables-expected.html:
* css3/line-break/line-break-loose-inseparables.html:
* css3/line-break/line-break-loose-iteration-marks-expected.html:
* css3/line-break/line-break-loose-iteration-marks.html:
* css3/line-break/line-break-loose-postfixes-expected.html:
* css3/line-break/line-break-loose-postfixes.html:
* css3/line-break/line-break-loose-prefixes-expected.html:
* css3/line-break/line-break-loose-prefixes.html:
* css3/line-break/line-break-loose-sound-marks-expected.html:
* css3/line-break/line-break-loose-sound-marks.html:
* css3/line-break/line-break-normal-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-normal-iteration-marks-expected.html.
* css3/line-break/line-break-normal-centered-2.html: Added.
* css3/line-break/line-break-normal-centered-expected.html:
* css3/line-break/line-break-normal-centered.html:
* css3/line-break/line-break-normal-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-normal-half-kana-2.html: Added.
* css3/line-break/line-break-normal-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-normal-half-kana-3.html: Added.
* css3/line-break/line-break-normal-half-kana-4-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-normal-half-kana-4.html: Added.
* css3/line-break/line-break-normal-half-kana-5-expected.html: Copied from LayoutTests/css3/line-break/line-break-loose-postfixes-expected.html.
* css3/line-break/line-break-normal-half-kana-5.html: Added.
* css3/line-break/line-break-normal-half-kana-expected.html:
* css3/line-break/line-break-normal-half-kana.html:
* css3/line-break/line-break-normal-hyphens-expected.html:
* css3/line-break/line-break-normal-hyphens.html:
* css3/line-break/line-break-normal-inseparables-expected.html:
* css3/line-break/line-break-normal-inseparables.html:
* css3/line-break/line-break-normal-iteration-marks-expected.html:
* css3/line-break/line-break-normal-iteration-marks.html:
* css3/line-break/line-break-normal-postfixes-expected.html:
* css3/line-break/line-break-normal-postfixes.html:
* css3/line-break/line-break-normal-prefixes-expected.html:
* css3/line-break/line-break-normal-prefixes.html:
* css3/line-break/line-break-normal-sound-marks-expected.html:
* css3/line-break/line-break-normal-sound-marks.html:
* css3/line-break/line-break-strict-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-auto-hyphens-expected.html.
* css3/line-break/line-break-strict-centered-2.html: Added.
* css3/line-break/line-break-strict-centered-expected.html:
* css3/line-break/line-break-strict-centered.html:
* css3/line-break/line-break-strict-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
* css3/line-break/line-break-strict-half-kana-2.html: Added.
* css3/line-break/line-break-strict-half-kana-3-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-strict-postfixes-expected.html.
* css3/line-break/line-break-strict-half-kana-3.html: Added.
* css3/line-break/line-break-strict-half-kana-4-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
* css3/line-break/line-break-strict-half-kana-4.html: Added.
* css3/line-break/line-break-strict-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
* css3/line-break/line-break-strict-half-kana-5.html: Added.
* css3/line-break/line-break-strict-half-kana-expected.html:
* css3/line-break/line-break-strict-half-kana.html:
* css3/line-break/line-break-strict-hyphens-expected.html:
* css3/line-break/line-break-strict-hyphens.html:
* css3/line-break/line-break-strict-inseparables-expected.html:
* css3/line-break/line-break-strict-inseparables.html:
* css3/line-break/line-break-strict-iteration-marks-expected.html:
* css3/line-break/line-break-strict-iteration-marks.html:
* css3/line-break/line-break-strict-postfixes-expected.html:
* css3/line-break/line-break-strict-postfixes.html:
* css3/line-break/line-break-strict-prefixes-expected.html:
* css3/line-break/line-break-strict-prefixes.html:
* css3/line-break/line-break-strict-sound-marks-expected.html:
* css3/line-break/line-break-strict-sound-marks.html:
* css3/line-break/resources/AllAhem.svg: Added.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r201629): Weird button glitching on github.com
simon.fraser@apple.com [Wed, 22 Jun 2016 20:44:26 +0000 (20:44 +0000)]
REGRESSION (r201629): Weird button glitching on github.com
https://bugs.webkit.org/show_bug.cgi?id=159031
rdar://problem/26880332

Reviewed by Tim Horton.

Source/WebCore:

r201629 changed the logic slightly when creating an image buffer for a scaled context;
it set the buffer context's scale to the scale in the source context, but this failed
to take into account the rounding up of the buffer size, which the old code did.

Fix by reverting to the old behavior.

Since buffer sizes can only be integral, changed compatibleBufferSize() to return
an IntSize.

Test: fast/backgrounds/scaled-gradient-background.html

* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::compatibleBufferSize):
* platform/graphics/ImageBuffer.h:
* platform/graphics/IntRect.h:
(WebCore::IntRect::area):
* platform/graphics/IntSize.h:
(WebCore::IntSize::area): Make this return an unsigned.

LayoutTests:

* fast/backgrounds/scaled-gradient-background-expected.html: Added.
* fast/backgrounds/scaled-gradient-background.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMail snapshot has black webview in multitasking switcher
timothy_horton@apple.com [Wed, 22 Jun 2016 20:39:49 +0000 (20:39 +0000)]
Mail snapshot has black webview in multitasking switcher
https://bugs.webkit.org/show_bug.cgi?id=159036
<rdar://problem/25972938>

Reviewed by Simon Fraser.

There is a window of time between an application going into the background
and SpringBoard's snapshotting mechanism completing where it is possible
(though difficult, timing-wise) for RemoteLayerBackingStoreCollection to
make still-needed surfaces volatile (and, even worse, for them to get emptied).

UIKit suggested instead waiting for the window context teardown notification,
which does indeed seem to fire after the snapshotting is complete.
This may have the convenient side effect of making the volatility timer
repeat fewer times in general, because it is now started closer to the
last time that the surfaces will be in-use.

* UIProcess/ApplicationStateTracker.h:
* UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView didMoveToWindow]):
(-[WKContentView _applicationDidFinishSnapshottingAfterEnteringBackground]):
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView didMoveToWindow]):
(-[WKPDFView _applicationDidFinishSnapshottingAfterEnteringBackground]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationDidEnterBackground):
(WebKit::WebPage::applicationDidFinishSnapshottingAfterEnteringBackground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMove the WebKitLegacy Apple Pay code to the open source repository
andersca@apple.com [Wed, 22 Jun 2016 20:38:15 +0000 (20:38 +0000)]
Move the WebKitLegacy Apple Pay code to the open source repository
https://bugs.webkit.org/show_bug.cgi?id=159035

Reviewed by Tim Horton.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
* WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.
(WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
(WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
(WebPaymentCoordinatorClient::supportsVersion):
(WebPaymentCoordinatorClient::canMakePayments):
(WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
(WebPaymentCoordinatorClient::showPaymentUI):
(WebPaymentCoordinatorClient::completeMerchantValidation):
(WebPaymentCoordinatorClient::completeShippingMethodSelection):
(WebPaymentCoordinatorClient::completeShippingContactSelection):
(WebPaymentCoordinatorClient::completePaymentMethodSelection):
(WebPaymentCoordinatorClient::completePaymentSession):
(WebPaymentCoordinatorClient::abortPaymentSession):
(WebPaymentCoordinatorClient::mainFrameDestroyed):
* WebKitAdditions.mm: Removed.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoInline the last of the Apple Pay WebCore code
andersca@apple.com [Wed, 22 Jun 2016 20:00:03 +0000 (20:00 +0000)]
Inline the last of the Apple Pay WebCore code
https://bugs.webkit.org/show_bug.cgi?id=159032

Reviewed by Tim Horton.

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
* page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame):
* page/MainFrame.h:
* page/PageConfiguration.h:
* platform/cocoa/ThemeCocoa.mm:
(WebCore::passKitBundle):
(WebCore::loadPassKitPDFPage):
(WebCore::applePayButtonLogoBlack):
(WebCore::applePayButtonLogoWhite):
(WebCore::drawApplePayButton):
(WebCore::ThemeCocoa::drawNamedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest expectation gardening for rdar://problem/26950065
ap@apple.com [Wed, 22 Jun 2016 19:36:35 +0000 (19:36 +0000)]
Test expectation gardening for rdar://problem/26950065

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest expectation gardening.
ap@apple.com [Wed, 22 Jun 2016 19:25:35 +0000 (19:25 +0000)]
Test expectation gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoException is not thrown when shipping method is an invalid amount
andersca@apple.com [Wed, 22 Jun 2016 19:10:00 +0000 (19:10 +0000)]
Exception is not thrown when shipping method is an invalid amount
https://bugs.webkit.org/show_bug.cgi?id=159030
rdar://problem/26700413

Reviewed by Tim Horton.

* Modules/applepay/ApplePaySession.cpp:
(WebCore::createShippingMethods):
Bail if createShippingMethod returns Nullopt.

(WebCore::createPaymentRequest):
Bail if createShippingMethods returns Nullopt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoException is not thrown when shipping method is an invalid amount
andersca@apple.com [Wed, 22 Jun 2016 18:43:18 +0000 (18:43 +0000)]
Exception is not thrown when shipping method is an invalid amount
https://bugs.webkit.org/show_bug.cgi?id=159029
rdar://problem/26700413

Reviewed by Tim Horton.

* Modules/applepay/PaymentRequest.h:
Change ShippingMethod::amount to be a signed 64-bit integer.

* Modules/applepay/PaymentRequestValidator.cpp:
(WebCore::PaymentRequestValidator::validate):
Call validateShippingMethods.

(WebCore::PaymentRequestValidator::validateShippingMethods):
Validate all the shipping methods.

(WebCore::PaymentRequestValidator::validateShippingMethod):
Check that the amount is >= 0.

* Modules/applepay/PaymentRequestValidator.h:
Add new members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoW3C test importer should generate files to ignore by WebKit SCM
commit-queue@webkit.org [Wed, 22 Jun 2016 18:20:31 +0000 (18:20 +0000)]
W3C test importer should generate files to ignore by WebKit SCM
https://bugs.webkit.org/show_bug.cgi?id=142743

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2016-06-22
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* resources/TestRepositories: Added the option to generate .gitignore and __init__.py for wpt repo.
* web-platform-tests/.gitignore: Regeneration changes the order of the ignored files and removes the __init__.py which is now committed to WebKit trunk.
* web-platform-tests/__init__.py: Added.

Tools:

TestDownloader generates the .gitignore file according submodules git repository information.
TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.

* Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
(TestImporter):
(TestImporter.write_init_py): Writing not empty __init__.py files.
(TestImporter.import_tests): Using  of write_init_py.
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_git_ignore_generation): Added .gitignore test.
(TestImporterTest):
(TestImporterTest.test_initpy_generation): Added __init__.py test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection
adam.bergkvist@ericsson.com [Wed, 22 Jun 2016 18:15:40 +0000 (18:15 +0000)]
WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=158985

Source/WebCore:

Reviewed by Eric Carlson.

Implement MediaEndpointPeerConnection's isNegotiationNeeded, markAsNeedingNegotiation and
clearNegotiationNeededState functions. The calls to these functions are already up-to-date.

Test: fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html

* Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::markAsNeedingNegotiation):
* Modules/mediastream/MediaEndpointPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

LayoutTests:

Add tests for the RTCPeerConnection negotiationneeded event.

Reviewed by Eric Carlson.

* fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html: Added.
Verify that a negotiationneeded event is fired when not all local media can be included in
an answer. (The answerer cannot reply with more m-lines than the offer had to begin with.)
* fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
Verify that a negotiationneeded event is fired when tracks are added and removed from an
RTCPeerConnection.
* platform/gtk/TestExpectations:
Unskip fast/mediastream/RTCPeerConnection-onnegotiationneeded.html.
* platform/mac/TestExpectations:
The mac port does not build with WEB_RTC enabled yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoimported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a...
commit-queue@webkit.org [Wed, 22 Jun 2016 18:14:10 +0000 (18:14 +0000)]
imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=155760

Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-22
Reviewed by Alexey Proskuryakov.

Making test more predictable.
Upstreamed to w3c repository as https://github.com/w3c/web-platform-tests/pull/3203.

* web-platform-tests/streams/readable-streams/general.js:
(promise_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebRTC: Replace RTCPeerConnection custom constructor with a JS built-in constructor
adam.bergkvist@ericsson.com [Wed, 22 Jun 2016 18:12:46 +0000 (18:12 +0000)]
WebRTC: Replace RTCPeerConnection custom constructor with a JS built-in constructor
https://bugs.webkit.org/show_bug.cgi?id=158832

Reviewed by Eric Carlson and Youenn Fablet.

Use a JS built-in constructor instead of a custom constructor. This makes it easier to
initialize private fields for functions implemented as JS built-ins. The constructor
behavior is in need of updating, but that is left to a follow-up change [1].

[1] http://webkit.org/b/158936
No change in behavior.

* CMakeLists.txt:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::initializeWith):
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
Add JS built-in constructor function.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSRTCPeerConnectionCustom.cpp: Removed.
(WebCore::constructJSRTCPeerConnection): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrossOriginPreflightChecker should call DocumentThreadableLoader preflightFailure...
commit-queue@webkit.org [Wed, 22 Jun 2016 18:11:00 +0000 (18:11 +0000)]
CrossOriginPreflightChecker should call DocumentThreadableLoader preflightFailure instead of didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=158984

Patch by Youenn Fablet <youenn@apple.com> on 2016-06-22
Reviewed by Darin Adler.

No change of behavior.

Calling DocumentThreadableLoader preflightFailure instead of didFailLoading for any preflight error case.

* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::notifyFinished): Directly calling preflightFailure callback.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.
(WebCore::CrossOriginPreflightChecker::handleLoadingFailure): Deleted.
(WebCore::CrossOriginPreflightChecker::redirectReceived): Deleted (should have been removed as part of
https://bugs.webkit.org/show_bug.cgi?id=111008).
* loader/CrossOriginPreflightChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Simplify CSS rule for ContentBrowser navigation bar items
nvasilyev@apple.com [Wed, 22 Jun 2016 18:10:45 +0000 (18:10 +0000)]
Web Inspector: Simplify CSS rule for ContentBrowser navigation bar items
https://bugs.webkit.org/show_bug.cgi?id=159000

Reviewed by Timothy Hatcher.

* UserInterface/Views/ContentBrowser.css:
(.content-browser > .navigation-bar > .item):
Both these values result in 28px, but `100%` is simplier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoJSDOMIterator forEach should support second optional parameter
cdumez@apple.com [Wed, 22 Jun 2016 17:50:15 +0000 (17:50 +0000)]
JSDOMIterator forEach should support second optional parameter
https://bugs.webkit.org/show_bug.cgi?id=159020

Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-22
Reviewed by Chris Dumez.

Source/WebCore:

Covered by beefed up test.

* bindings/js/JSDOMIterator.h:
(WebCore::iteratorForEach): Setting callback thisValue to the second argument passed to forEach.

LayoutTests:

* fast/dom/nodeListIterator-expected.txt:
* fast/dom/nodeListIterator.html: Adding 'thisValue' various checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMedia controls stop working after exiting PiP
jer.noble@apple.com [Wed, 22 Jun 2016 17:16:27 +0000 (17:16 +0000)]
Media controls stop working after exiting PiP
https://bugs.webkit.org/show_bug.cgi?id=159026
<rdar://problem/26753579>

Reviewed by Eric Carlson.

Do not slave setting WebVideoFullscreenModelVideoElement::setVideoElement() to
WebPlaybackSessionModelVideoElement::setMediaElement(). After all, someone else
(i.e., the media controls) may still be using it.

* platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::setVideoElement): Deleted.
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::didCleanupFullscreen):
(WebVideoFullscreenControllerContext::setUpFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate document's isPlayingMedia() state whenever media element's media state changes
jer.noble@apple.com [Wed, 22 Jun 2016 17:14:02 +0000 (17:14 +0000)]
Update document's isPlayingMedia() state whenever media element's media state changes
https://bugs.webkit.org/show_bug.cgi?id=159018
<rdar://problem/26586630>

Reviewed by Beth Dakin.

The Document can end up with a stale m_mediaState if its own value isn't updated when
its constituent HTMLMediaElement's m_mediaStates change.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateMediaState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd logging related to process assertions to help debug process suspension issues
cdumez@apple.com [Wed, 22 Jun 2016 17:00:23 +0000 (17:00 +0000)]
Add logging related to process assertions to help debug process suspension issues
https://bugs.webkit.org/show_bug.cgi?id=159001

Reviewed by Antti Koivisto.

Add logging related to process assertions to help debug process suspension issues.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::didChangeIsLoading):
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateActivityToken):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setIsHoldingLockedFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash under GraphicsLayerCA::recursiveCommitChanges() with deep layer trees
simon.fraser@apple.com [Wed, 22 Jun 2016 16:58:17 +0000 (16:58 +0000)]
Crash under GraphicsLayerCA::recursiveCommitChanges() with deep layer trees
https://bugs.webkit.org/show_bug.cgi?id=159023
rdar://problem/25377842

Reviewed by Tim Horton.

Having an on-stack DisplayList::Recorder increased the stack frame size significantly,
causing stack exhaustion with deep layer trees, despite the existing depth check.

Make the Recorder heap-allocated to fix this.

Tested by LayoutTests/compositing//layer-creation/deep-tree.html.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveCommitChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWKWebView with no WKNavigationDelegate does not follow universal links
weinig@apple.com [Wed, 22 Jun 2016 16:55:49 +0000 (16:55 +0000)]
WKWebView with no WKNavigationDelegate does not follow universal links
<rdar://problem/24374110>
https://bugs.webkit.org/show_bug.cgi?id=158997

Reviewed by Dan Bernstein.

Source/WebKit2:

API Test:
     WKWebView.DefaultNavigationDelegate

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
When initializing the WKWebView, set a default navigation client.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
Add a new test that shows that we have a default navigation delegate by swizzling
-[NSWorkspace openURL:]. This will only be called if there is a default client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Add support for variadic parameters to GObject DOM bindings
carlosgc@webkit.org [Wed, 22 Jun 2016 08:59:31 +0000 (08:59 +0000)]
[GTK] Add support for variadic parameters to GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=158942

Reviewed by Michael Catanzaro.

Generate code for functions having variadic parameters.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
(SkipFunction):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_variadic_string_method):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Implement modal dialog support in MiniBrowser.
pvollan@apple.com [Wed, 22 Jun 2016 08:35:03 +0000 (08:35 +0000)]
[Win] Implement modal dialog support in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=158976

Reviewed by Brent Fulgham.

* MiniBrowser/win/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::createWebViewWithRequest):
(getHandleFromWebView):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::canRunModal):
(findTopLevelParent):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::createModalDialog):
* MiniBrowser/win/PrintWebUIDelegate.h:
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::runModal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agowindow.showModalDialog doesn't work in DumpRenderTree on Windows
pvollan@apple.com [Wed, 22 Jun 2016 07:48:15 +0000 (07:48 +0000)]
window.showModalDialog doesn't work in DumpRenderTree on Windows
https://bugs.webkit.org/show_bug.cgi?id=53675

Reviewed by Brent Fulgham.

Tools:

Implement modal dialog support in DumpRenderTree.

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::canRunModal):
(getHandleFromWebView):
(UIDelegate::createModalDialog):
(findTopLevelParent):
(UIDelegate::runModal):
(UIDelegate::webViewClose):
* DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Update test expectations for modal dialog tests.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLand test expectations for rdar://problem/26422051.
ap@apple.com [Wed, 22 Jun 2016 05:52:52 +0000 (05:52 +0000)]
Land test expectations for rdar://problem/26422051.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago:hover CSS pseudo-class sometimes keeps matching ever after mouse has left the element
commit-queue@webkit.org [Wed, 22 Jun 2016 05:52:05 +0000 (05:52 +0000)]
:hover CSS pseudo-class sometimes keeps matching ever after mouse has left the element
https://bugs.webkit.org/show_bug.cgi?id=158340

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-21
Reviewed by Simon Fraser.

Source/WebCore:

When removing a hovered subtree from the document, we were getting
into an inconsistent state where m_hoveredElement is in the detached
subtree and we have no way of clearing the existing IsHovered flags.

What happens is:
-The root "a" has an child "b" that is hovered.
-"a" starts being removed from the tree, its renderer is destroyed.
-RenderTreeUpdater::tearDownRenderers() pushes "a" on the teardownStack
 and calls hoveredElementDidDetach().
-hoveredElementDidDetach() is called with "a". "a" is not the hovered
 element, the function does nothing.
-RenderTreeUpdater::tearDownRenderers() pushes "b" on the teardownStack
 and calls hoveredElementDidDetach().
-hoveredElementDidDetach() is called with "b". The next parent with a renderer
 is "a", m_hoveredElement is set to "a".
-"a"'s parent is set to nullptr.

-> We have a m_hoveredElement on the root of a detached tree, making
   it impossible to clear the real dirty tree.

This patch changes the order in which we clear the flags.
It is done in the order in which we clear the renderers to ensure
the last element with a dead renderer is the last to update m_hoveredElement.

Tests: fast/css/ancestor-of-hovered-element-detached.html
       fast/css/ancestor-of-hovered-element-removed.html

* Source/WebCore/style/RenderTreeUpdater.cpp:

LayoutTests:

* fast/css/ancestor-of-hovered-element-detached-expected.txt: Added.
* fast/css/ancestor-of-hovered-element-detached.html: Added.
* fast/css/ancestor-of-hovered-element-removed-expected.txt: Added.
* fast/css/ancestor-of-hovered-element-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Fetch API] Rename 'origin-only' referrer policy to 'origin'
commit-queue@webkit.org [Wed, 22 Jun 2016 05:47:58 +0000 (05:47 +0000)]
[Fetch API] Rename 'origin-only' referrer policy to 'origin'
https://bugs.webkit.org/show_bug.cgi?id=158982

Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-21
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Renaming origin-only to origin.

* web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
* web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
* web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
* web-platform-tests/fetch/api/request/request-clone.sub.html:
* web-platform-tests/fetch/api/request/request-idl.html:
* web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
* web-platform-tests/fetch/api/request/request-init-001.sub.html:
* web-platform-tests/fetch/api/request/request-init-003.sub.html:

Source/WebCore:

Covered by updated tests.

* Modules/fetch/FetchRequest.cpp:
(WebCore::setReferrerPolicy): Renaming origin-only to origin.
* Modules/fetch/FetchRequest.idl: Ditto.
* loader/FetchOptions.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest expectations gardening.
ap@apple.com [Wed, 22 Jun 2016 05:42:01 +0000 (05:42 +0000)]
Test expectations gardening.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLet the compiler generate the move constructor and assignment operator for ScriptExec...
cdumez@apple.com [Wed, 22 Jun 2016 05:00:16 +0000 (05:00 +0000)]
Let the compiler generate the move constructor and assignment operator for ScriptExecutionContext::Task
https://bugs.webkit.org/show_bug.cgi?id=159013

Reviewed by Brady Eidson.

Let the compiler generate the move constructor and assignment operator for
ScriptExecutionContext::Task. We previously manually defined the move
constructor but there is no need as it doesn't do anything special.

* dom/ScriptExecutionContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDumpRenderTree crashed in com.apple.WebCore: WebCore::HTMLSelectElement::updateSelect...
dino@apple.com [Wed, 22 Jun 2016 03:53:47 +0000 (03:53 +0000)]
DumpRenderTree crashed in com.apple.WebCore: WebCore::HTMLSelectElement::updateSelectedState
https://bugs.webkit.org/show_bug.cgi?id=159009
<rdar://problem/23454623>

Reviewed by Jon Lee.

It seems we can get bogus indices from UIKit's implementation
of UIWebSelectMultiplePicker. Guard against this situation.

Covered by running the existing tests in WebKit1 with Guard Malloc,
such as fast/spatial-navigation/snav-multiple-select-optgroup.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateSelectedState): Early return
if we get an index out of range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix formatting issues reported by check-webkit-style
aakash_jain@apple.com [Wed, 22 Jun 2016 03:34:05 +0000 (03:34 +0000)]
Fix formatting issues reported by check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=159008

Reviewed by Alexey Proskuryakov.

Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
There is no functionality change.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
(Rollout):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_exception_during_command):
(IRCBotTest.test_exception_during_command.CommandWithException):
(IRCBotTest.test_exception_during_command.CommandWithException.execute):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_missing_unit_test_results_path):
(test_layout_test_results):
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
* Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand):
(AbstractSequencedCommand.__init__):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/commands/openbugs.py:
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToCommitQueue):
(PatchesToCommitQueue.__init__):
(PatchesToCommitQueue._needs_commit_queue):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_platform):
(PrintBaselinesTest):
(PrintBaselinesTest.setUp):
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue):
(AbstractQueue.__init__):
(AbstractQueue.execute):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_auto_retry):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._rebaseline):
* Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone):
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/commands/upload.py:
(PostCommits._comment_text_for_commit):
(PostCommits):
(PostCommits.execute):
(MarkBugFixed):
(MarkBugFixed.__init__):
* Scripts/webkitpy/tool/commands/upload_unittest.py:
(UploadCommandsTest):
(UploadCommandsTest.test_commit_message_for_current_diff):
* Scripts/webkitpy/tool/grammar_unittest.py:
(GrammarTest):
(GrammarTest.test_join_with_separators):
* Scripts/webkitpy/tool/multicommandtool.py:
(HelpCommand.__init__):
(HelpCommand):
(HelpCommand._help_epilog):
(HelpCommand._remove_help_options):
(MultiCommandTool):
(MultiCommandTool.__init__):
(MultiCommandTool.main):
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(TrivialCommand):
(TrivialCommand.__init__):
(MultiCommandToolTest):
(MultiCommandToolTest._assert_tool_main_outputs):
(MultiCommandToolTest.test_retry):
(test_command_help):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/applypatch.py:
* Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
(ApplyPatchWithLocalCommit):
(ApplyPatchWithLocalCommit.options):
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle):
(CheckStyle.options):
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
(CloseBugForLandDiffTest):
(CloseBugForLandDiffTest.test_empty_state):
* Scripts/webkitpy/tool/steps/closepatch.py:
* Scripts/webkitpy/tool/steps/commit.py:
(Commit.run):
* Scripts/webkitpy/tool/steps/confirmdiff.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
* Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
* Scripts/webkitpy/tool/steps/metastep.py:
(MetaStep):
(MetaStep.__init__):
(MetaStep.run):
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
* Scripts/webkitpy/tool/steps/options.py:
(Options):
* Scripts/webkitpy/tool/steps/postdiff.py:
* Scripts/webkitpy/tool/steps/postdiffforcommit.py:
* Scripts/webkitpy/tool/steps/postdiffforrevert.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest):
(PrepareChangeLogTest.test_resolve_existing_entry):
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Scripts/webkitpy/tool/steps/promptforbugortitle.py:
* Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
* Scripts/webkitpy/tool/steps/revertrevision.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest):
(StepsTest._step_options):
* Scripts/webkitpy/tool/steps/update.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
(UpdateChangeLogsWithReviewerTest):
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate canvas size when benchmark begins
jonlee@apple.com [Wed, 22 Jun 2016 03:26:57 +0000 (03:26 +0000)]
Update canvas size when benchmark begins
https://bugs.webkit.org/show_bug.cgi?id=159010

Reviewed by Dean Jackson.

Previously we would evaluate the media queries and assign the canvas size to the test
on body.onload. Instead, do it once the user starts the benchmark.

* Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()
to benchmarkController._startBenchmark.
* Animometer/resources/runner/animometer.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd new timestamp option
jonlee@apple.com [Wed, 22 Jun 2016 03:26:24 +0000 (03:26 +0000)]
Add new timestamp option
https://bugs.webkit.org/show_bug.cgi?id=159006

Reviewed by Dean Jackson.

Add a new option to take timestamps from the rAF callback.

* Animometer/developer.html: Added option.
* Animometer/tests/resources/main.js:
(Benchmark): Fall back to using the rAF timestamp if performance.now()
is not available.
(Benchmark._animateLoop): Update how timestamp is set. Prefer to use
local var instead of accessing private var.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r202296.
cdumez@apple.com [Wed, 22 Jun 2016 03:16:14 +0000 (03:16 +0000)]
Unreviewed, rolling out r202296.

Broke basic browsing in Safari

Reverted changeset:

"WKWebView with no WKNavigationDelegate does not follow
universal links"
https://bugs.webkit.org/show_bug.cgi?id=158997
http://trac.webkit.org/changeset/202296

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImprovements to Animometer benchmark
jonlee@apple.com [Wed, 22 Jun 2016 03:12:26 +0000 (03:12 +0000)]
Improvements to Animometer benchmark
https://bugs.webkit.org/show_bug.cgi?id=157738

Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.

Update tests.

* Animometer/tests/master/text.html: Ensure only three text sizes for
the three canvases.
* Animometer/tests/master/focus.html: Reduce the text size to fit with smaller
particle sizes.
* Animometer/tests/master/resources/focus.js: Remove the quadratic distribution for
particle sizes, and make it linear. Reduce the size variance. Shuffle the math to
reduce some calculations per frame. Fix the placement of the particles which might
otherwise be culled.
* Animometer/tests/master/resources/image-data.js: Reduce the particle size
to encourage larger scores.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImprovements to Animometer benchmark
jonlee@apple.com [Wed, 22 Jun 2016 03:11:15 +0000 (03:11 +0000)]
Improvements to Animometer benchmark
https://bugs.webkit.org/show_bug.cgi?id=157738

Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.

Include confidence interval for the final score, and store the canvas
size in the serialization so that it is accurately shown in results.

* Animometer/developer.html: Add a "confidence" div.
* Animometer/index.html: Ditto. Convert "mean" to "confidence".
* Animometer/resources/debug-runner/animometer.js: Look at options, and
if the configuration is included, update the body class based on it
(similar to what we do when we first load the page). That way, if you
drag-and-drop previous results in, that configuration is reflected in
the dashboard. Show the full confidence interval.

* Animometer/resources/debug-runner/animometer.css:
* Animometer/resources/debug-runner/animometer.js: Style update.
* Animometer/resources/runner/animometer.css:

* Animometer/resources/runner/animometer.js:
(_processData): Propagate the confidence interval values out and calculate
the lower and upper bounds. For now, shortcut the aggregate calculation,
since we only go through one iteration.
(this._processData.calculateScore): Propagate the confidence interval out
to be next to the score. Depending on the controller these values are
calculated differently.
(this._processData._getResultsProperty): Convenience function.
(this._processData.get score): Refactor.
(this._processData.get scoreLowerBound): Get the aggregate lower bound.
(this._processData.get scoreUpperBound): Get the aggregate upper bound.
(window.sectionsManager.setSectionScore):
(window.benchmarkController._startBenchmark): When the benchmark starts, note
the canvas size and add it to options. That way it will be automatically be
serialized.
(window.benchmarkController.showResults): Include the maximum deviation
percentage.
* Animometer/resources/runner/lines.svg: Make the background line up with the
skew.
* Animometer/resources/runner/tests.js:
(Headers.details.text): Refactor.
* Animometer/resources/statistics.js:
(Statistics.largestDeviationPercentage): Convenience function to calculate
the deviation percentage on either end and return the largest deviation.
* Animometer/resources/strings.js:

Allow specifying a regression profile to use instead of taking the one
with the lowest error.

Address an issue in the focus test when the regression calculated ends
up overestimating the change point, causing a cascade of tougher
ramps. The reason behind this is that at max complexity of an initial
ramp, the frame length is very high, and it influences the second
segment of the piecewise regression strongly, causing it to be very
steep. As a result, the first segment, expected to be flat, ends up
covering a higher range of complexity. That makes the change point
much higher than it should be. To avoid this, we will add a sanity
check on the maximum value of the ramp. If the regression's projected
value at the maximum complexity of the current ramp is very slow (less
than 20 fps), 1) reduce the maximum complexity by 20%, and 2) do not
include the regression's change point in the change point estimator.
That estimator is used as the midpoint of the next ramp, and including
the change point from a poor regression can bake in the error. The
controller already knows how to adjust for ramps that are too easy for
the system.

* Animometer/resources/runner/animometer.js:
(this._processData.findRegression): Takes a preferred profile and gives that to
Regression.
(this._processData.calculateScore): With the ramp controller, take the profile
of the ramp that was used the most when calculating the ramp's regression. That
profile is what is used for the test's score.
* Animometer/resources/statistics.js:
(Regression.Utilities.createClass): Update to take an options object which can
specify a profile to calculate with. Otherwise it will continue to use both and
select the one with the lower error.
(_calculateRegression): Fix an issue where we claim 0 error if the regression
calculation fails due to divide-by-zero. Instead reject that regression calculation
by giving it Number.MAX_VALUE.
* Animometer/resources/strings.js: New strings for marking a regression as flat
or slope.
* Animometer/tests/resources/main.js:
(RampController): Rename the thresholds for clarity. Add a threshold that, if
exceeded, will lower the maximum complexity of the next ramp.
(tune): Relax the cdf check to consider whether the interval definitely falls in
the desired frame length threshold.
(processSamples): Include the profile in the ramp.

Update ramp controller test. Increase the length of the test to 30 seconds, and extend
the interval to 120 ms during sampling. Improve the estimation of the ramp parameters.

* Animometer/developer.html: Change default to 30 seconds, and don't show the progress bar
by default.
* Animometer/resources/runner/animometer.js: Change default to 30 seconds.
* Animometer/tests/resources/main.js: A number of improvements to the ramp controller, in
the order in which they appear in the patch:

- With a longer test length use longer ramps with longer intervals to get more data at each
complexity. Keep the 100 ms interval length during the ramp up phase since we don't need to
spend more time there to find the right order of magnitude, but increase it during the
ramps to 120 ms.
- The ramp linearly interpolates the complexity to render based on its timestamp, but it would
never sample the minimum complexity. Instead of lerping max to min complexity from time
0 to t where t is the ramp length, instead lerp from 0 to (t - intervalSampleLength) so that
we can have at least one interval sample at the min complexity for that ramp.
- Some regression calculations only come out with one line segment rather than the two
we expect. This could be due to a noisy ramp or the ramp's range is too narrow. If that's the
case, influence the minimum complexity of the next ramp towards the lowest bound of 1, so that
we ensure that at least part of the ramp is covering a complexity range that the system can
handle at full 60.
- Remove an assignment to interpolatedFrameLength since that is never subsequently used.

Update the format used to serialize the results for analysis.

Each data point used to have named properties for fields like complexity and frame rate.
In addition the serialized numbers had rounding errors that took up many characters.
Update the format by introducing a new data container called SampleData, which contains a
field map. The map maps a string to an array index. Each data point is an array, so, to
get a stat, use the field map to get the array index into the data point. This allows future
versions to track other data, and reduces the size of the output string by two-thirds.

* Animometer/resources/extensions.js:
(Utilities.toFixedNumber): Add convenience function that truncates the number to a fixed
precision, and converts it back to a number.
(SampleData): New class that contains sample data and a field map that maps properties to
an array index.
(get length): Number of data points.
(addField): Add a field to the field map.
(push): Add a data point.
(sort): Sort the data.
(slice): Return new SampleData object with sliced data.
(forEach): Iterate over the data with provided function.
(createDatum):
(getFieldInDatum): Returns the data point associated with the field name by looking it up
in the field map in the datum provided, which can be the datum object itself (an array) or
an index into the data member variable.
(setFieldInDatum): Sets the data point associated with the field name.
(at): Returns the data point at the provided index.
(toArray): Serializes the data where the field map serves as property names for each point.

* Animometer/resources/debug-runner/graph.js:
(updateGraphData): Remove unused _testData. Convert the data to the old array format for the
graph to use, since the old format was much easier to work with when displaying the graphs.
(onGraphTypeChanged): For some controllers, no alternative score or mean is provided.
* Animometer/resources/runner/animometer.css:
* Animometer/resources/runner/animometer.js: Refactor to use SampleData. Update JSON output
to only go to 3 digits of precision for purposes of reducing the data size.
* Animometer/resources/strings.js: Add new strings to put into the field maps.
* Animometer/tests/resources/main.js: Refactor to use SampleData.

* Animometer/developer.html:
* Animometer/index.html: Restructure results table for both pages. Add charset attribute to
tests.js include.
* Animometer/resources/debug-runner/animometer.css: Clear out styles from release runner.
* Animometer/resources/debug-runner/graph.js:
(onGraphTypeChanged): Update score and mean if bootstrap results are available from the
controller, since not all controllers do bootstrapping.
* Animometer/resources/debug-runner/tests.js: Update header text.
* Animometer/resources/runner/animometer.css: Include confidence interval in results.
* Animometer/resources/runner/animometer.js:
(ResultsTable._addHeader): Header contents can be HTML, so use innerHTML instead.
(ResultsTable._addBody): Add tbody element.
(ResultsTable._addTest): Allow a data cell to invoke a JS function to get its contents.
(window.benchmarkController.showResults): Add table that includes tests' confidence intervals.
* Animometer/resources/runner/tests.js:
(Headers.details.text): Add new details table that includes bootstrap confidence interval.
The interval can be asymmetric, but for simplicity, report the maximum deviation percentage
on either side of the bootstrap median.
* Animometer/resources/statistics.js:
(bootstrap): Include the confidence percentage in the return object.

Report canvas size in results.

* Animometer/developer.html: Add markup to indicate whether a small, medium, or large
canvas was used.
* Animometer/index.html: Ditto.
* Animometer/resources/debug-runner/animometer.js: Call determineCanvasSize().
* Animometer/resources/runner/animometer.css: Update styles to set the canvas based on the
body class size.
* Animometer/resources/runner/animometer.js:
(window.benchmarkController.initialize): Update styles to set the canvas based on the
body class size.
(window.benchmarkController.determineCanvasSize): Run various media queries and set the body
class based on the size of the device.

* Animometer/developer.html: Refactor to include the main CSS file, and redo
the layout so that it doesn't rely on flexbox.
* Animometer/resources/debug-runner/animometer.css:
* Animometer/resources/debug-runner/animometer.js:
(updateDisplay): Since various parts of the script alter the body class, we can't
replace the className directly. Instead, remove all display-based values and then add
the one that was selected.
* Animometer/resources/debug-runner/graph.js:
(updateGraphData): To set the size of the graph, use window.innerHeight.
* Animometer/resources/runner/animometer.js:
(window.sectionsManager.showSection): Since various parts of the script alter the body
class, we can't replace the className directly. Remove all of the section classes
individually and then add the one desired.
* Animometer/tests/resources/stage.css: Remove -apple-system as a font to use in the
stage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPass ScriptExecutionContext::Task as rvalue reference
cdumez@apple.com [Wed, 22 Jun 2016 03:06:36 +0000 (03:06 +0000)]
Pass ScriptExecutionContext::Task as rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=159007

Reviewed by Anders Carlsson.

Pass ScriptExecutionContext::Task as rvalue reference since its non-copyable
and has to be moved in.

* workers/WorkerLoaderProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
* workers/WorkerMessagingProxy.h:
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
* workers/WorkerRunLoop.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoInclude IdentifierInlines.h.
andersca@apple.com [Wed, 22 Jun 2016 02:52:46 +0000 (02:52 +0000)]
Include IdentifierInlines.h.

* bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd PaymentHeaders.h file.
andersca@apple.com [Wed, 22 Jun 2016 02:02:54 +0000 (02:02 +0000)]
Add PaymentHeaders.h file.

* Modules/applepay/PaymentHeaders.h: Added.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake a bunch of Apple Pay headers private instead of project.
andersca@apple.com [Wed, 22 Jun 2016 01:36:56 +0000 (01:36 +0000)]
Make a bunch of Apple Pay headers private instead of project.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMove the last Apple Pay WebCore files to the open source repository
andersca@apple.com [Wed, 22 Jun 2016 01:05:31 +0000 (01:05 +0000)]
Move the last Apple Pay WebCore files to the open source repository
https://bugs.webkit.org/show_bug.cgi?id=159005

Reviewed by Tim Horton.

* DerivedSources.make:
* Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp: Added.
* Modules/applepay/ApplePayPaymentAuthorizedEvent.h: Added.
* Modules/applepay/ApplePayPaymentAuthorizedEvent.idl: Added.
* Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp: Added.
* Modules/applepay/ApplePayPaymentMethodSelectedEvent.h: Added.
* Modules/applepay/ApplePayPaymentMethodSelectedEvent.idl: Added.
* Modules/applepay/ApplePaySession.cpp: Added.
* Modules/applepay/ApplePaySession.h: Added.
* Modules/applepay/ApplePaySession.idl: Added.
* Modules/applepay/ApplePayShippingContactSelectedEvent.cpp: Added.
* Modules/applepay/ApplePayShippingContactSelectedEvent.h: Added.
* Modules/applepay/ApplePayShippingContactSelectedEvent.idl: Added.
* Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp: Added.
* Modules/applepay/ApplePayShippingMethodSelectedEvent.h: Added.
* Modules/applepay/ApplePayShippingMethodSelectedEvent.idl: Added.
* Modules/applepay/ApplePayValidateMerchantEvent.cpp: Added.
* Modules/applepay/ApplePayValidateMerchantEvent.h: Added.
* Modules/applepay/ApplePayValidateMerchantEvent.idl: Added.
* Modules/applepay/Payment.h: Added.
* Modules/applepay/PaymentAuthorizationStatus.h: Added.
* Modules/applepay/PaymentContact.h: Added.
* Modules/applepay/PaymentMerchantSession.h: Added.
* Modules/applepay/PaymentMethod.h: Added.
* Modules/applepay/PaymentRequestValidator.cpp: Added.
* Modules/applepay/PaymentRequestValidator.h: Added.
* Modules/applepay/cocoa/PaymentContactCocoa.mm: Added.
* Modules/applepay/cocoa/PaymentMethodCocoa.mm: Added.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp: Added.
* bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp: Added.
* bindings/js/JSApplePaySessionCustom.cpp: Added.
* bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp: Added.
* bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp: Added.
* dom/EventNames.in:
* dom/EventTargetFactory.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix build.
andersca@apple.com [Wed, 22 Jun 2016 00:08:10 +0000 (00:08 +0000)]
Fix build.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r202302, r202303, r202305, and
jiewen_tan@apple.com [Wed, 22 Jun 2016 00:04:48 +0000 (00:04 +0000)]
Unreviewed, rolling out r202302, r202303, r202305, and
r202306.

Roll out the rollouts because of breaking the build.

Reverted changesets:

"Unreviewed, rolling out r200678."
https://bugs.webkit.org/show_bug.cgi?id=157453
http://trac.webkit.org/changeset/202302

"Unreviewed, rolling out r200619."
https://bugs.webkit.org/show_bug.cgi?id=131443
http://trac.webkit.org/changeset/202303

"Unreviewed, attempt to fix the build after r202303."
http://trac.webkit.org/changeset/202305

"Unreviewed, attempt to fix the build after r202303."
http://trac.webkit.org/changeset/202306

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, attempt to fix the build after r202303.
cdumez@apple.com [Tue, 21 Jun 2016 23:52:50 +0000 (23:52 +0000)]
Unreviewed, attempt to fix the build after r202303.

* bindings/js/JSDOMIterator.h:
(WebCore::IteratorInspector::decltype):
(WebCore::IteratorInspector::test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, attempt to fix the build after r202303.
cdumez@apple.com [Tue, 21 Jun 2016 23:47:55 +0000 (23:47 +0000)]
Unreviewed, attempt to fix the build after r202303.

* bindings/js/JSDOMIterator.h:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLayoutTest tiled-drawing/scrolling/latched-div-with-scroll-snap.html is flaky
zalan@apple.com [Tue, 21 Jun 2016 23:32:34 +0000 (23:32 +0000)]
LayoutTest tiled-drawing/scrolling/latched-div-with-scroll-snap.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=158320

Reviewed by Simon Fraser.

This test case is flaky because:
1. There are multiple mouseScrollByWithWheelAndMomentumPhases() event bundles and they all need their own
callbacks. (see additional eventSender.callAfterScrollingCompletes()) -> fail
2. When the test fails, the testFailed() function is called with undefined variables. -> timeout

* platform/mac-wk2/TestExpectations:
* tiled-drawing/scrolling/latched-div-with-scroll-snap.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r200619.
jiewen_tan@apple.com [Tue, 21 Jun 2016 23:24:37 +0000 (23:24 +0000)]
Unreviewed, rolling out r200619.

This incompleted feature broke http://m.yahoo.co.jp. Roll it
out together with r200678.

Reverted changeset:

"NodeList should be iterable"
https://bugs.webkit.org/show_bug.cgi?id=131443
http://trac.webkit.org/changeset/200619

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r200678.
jiewen_tan@apple.com [Tue, 21 Jun 2016 23:21:14 +0000 (23:21 +0000)]
Unreviewed, rolling out r200678.

This incompleted feature broke http://m.yahoo.co.jp. Roll it
out together with r200619.

Reverted changeset:

"Ensure DOM iterators remain done"
https://bugs.webkit.org/show_bug.cgi?id=157453
http://trac.webkit.org/changeset/200678

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSkip HeapSnapshot test on WebKit1. Shared VM skews the data.
joepeck@webkit.org [Tue, 21 Jun 2016 23:09:50 +0000 (23:09 +0000)]
Skip HeapSnapshot test on WebKit1. Shared VM skews the data.

Unreviewed gardening.

In this case, snapshots with snapshots with snapshots in the same VM
causes the test to run out of memory. This does not happen in WebKit2.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest gardening for platform-specific font-fallback on macOS Sierra
mmaxfield@apple.com [Tue, 21 Jun 2016 23:07:31 +0000 (23:07 +0000)]
Test gardening for platform-specific font-fallback on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=159003
<rdar://problem/25807529>

Unreviewed.

* fast/text/font-cursive-italic-cjk-2-expected.html: Added.
* fast/text/font-cursive-italic-cjk-2.html: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202300 268f45cc-cd09-0410-ab3c-d52691b4dbfc