WebKit-https.git
6 years agoImage menu is offset by the amount the view is scrolled
beidson@apple.com [Wed, 7 May 2014 21:17:53 +0000 (21:17 +0000)]
Image menu is offset by the amount the view is scrolled
<rdar://problem/16818966> and https://bugs.webkit.org/show_bug.cgi?id=132663

Reviewed by Tim Horton.

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot,
  and skip the [NSView convertPoint:toView:] step.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up the difference between painting focus rings and adding PDF annotations
dino@apple.com [Wed, 7 May 2014 20:03:13 +0000 (20:03 +0000)]
Clean up the difference between painting focus rings and adding PDF annotations
https://bugs.webkit.org/show_bug.cgi?id=132638

Follow-up comments from Darin Adler.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline): Move "else if" to a separate "if" for clarity.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Don't guard against outlineIsAuto(). ASSERT instead.
(WebCore::RenderObject::addPDFURLRect): Give "rect" variable a better name.
(WebCore::RenderObject::paintOutline): Move "else if" to a separate "if" for clarity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake blob size computation lazy
ap@apple.com [Wed, 7 May 2014 18:57:35 +0000 (18:57 +0000)]
Make blob size computation lazy
https://bugs.webkit.org/show_bug.cgi?id=132653

Reviewed by Anders Carlsson.

Source/WebCore:
* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::size):
* fileapi/Blob.h:
(WebCore::Blob::size): Deleted.
* fileapi/File.cpp:
(WebCore::File::size): Deleted.
* fileapi/File.h:
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::blobSize):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::unregisterBlobURLTask): Deleted.
* fileapi/ThreadableBlobRegistry.h:
* platform/network/BlobData.cpp:
(WebCore::BlobData::appendData):
* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):
* platform/network/BlobRegistryImpl.h:

Source/WebKit2:
* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::blobSize):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLForSlice):
(WebKit::NetworkConnectionToWebProcess::blobSize):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLForSlice):
(WebKit::BlobRegistryProxy::blobSize):
* WebProcess/FileAPI/BlobRegistryProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKit1 is flashy when compositing layers come and go
simon.fraser@apple.com [Wed, 7 May 2014 18:49:26 +0000 (18:49 +0000)]
WebKit1 is flashy when compositing layers come and go
https://bugs.webkit.org/show_bug.cgi?id=132655

Source/WebKit/mac:

Reviewed by Sam Weinig.

In r166117 I removed code to flush compositing layers in FrameView::paintContents(),
which caused problems when painting iframes. However, this removed a flush
that WebKit1 relied on to flush compositing layers when painting, which caused
flashing when compositing layers come and go, and broke WebView snapshotting
in some cases.

Fix by adding back compositing layer flushing, but this time in WebKit1's
-viewWillDraw code path. This allows removal of some flushing in DumpRenderTree.

* WebView/WebHTMLView.mm:
(-[WebHTMLView viewWillDraw]):
* WebView/WebView.mm:
(-[WebView _flushCompositingChanges]):
* WebView/WebViewInternal.h:
* WebView/WebViewPrivate.h:

Tools:
<rdar://problem/16830981&16788846>

Reviewed by Sam Weinig.

Revert the change from r166117.

* DumpRenderTree/mac/DumpRenderTree.mm:
(updateDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd scrolling tree logging to RemoteLayerTree output
simon.fraser@apple.com [Wed, 7 May 2014 18:42:53 +0000 (18:42 +0000)]
Add scrolling tree logging to RemoteLayerTree output
https://bugs.webkit.org/show_bug.cgi?id=132640

Reviewed by Beth Dakin.

Source/WebCore:

Support scrolling tree logging in the RemoteLayerTree log channel
output.

ScrollingStateTree::commit() unconditionally set treeStateClone->m_hasChangedProperties
to true, but we should set it based on original scrolling state tree's
m_hasChangedProperties.

We have to encode all of the scrolling state nodes anyway (they only encode
changed properties), but we can use this for future optimizations, and to
avoid spurious logging.

* WebCore.exp.in: Export a couple of things we need.
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::commit):

Source/WebKit2:

Support scrolling tree logging in the RemoteLayerTree log channel
output.

Encode/decode ScrollingStateTree::hasChangedProperties() so we can use
it to avoid logging. Log all the things.

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::RemoteScrollingTreeTextStream):
(WebKit::RemoteScrollingTreeTextStream::increaseIndent):
(WebKit::RemoteScrollingTreeTextStream::decreaseIndent):
(WebKit::RemoteScrollingTreeTextStream::writeIndent):
(WebKit::dumpProperty):
(WebKit::RemoteScrollingTreeTextStream::operator<<):
(WebKit::RemoteScrollingTreeTextStream::dump):
(WebKit::RemoteScrollingTreeTextStream::recursiveDumpNodes):
(WebKit::RemoteScrollingCoordinatorTransaction::description):
(WebKit::RemoteScrollingCoordinatorTransaction::dump):
* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: aria-expanded changes are not communicated to clients
cfleizach@apple.com [Wed, 7 May 2014 18:32:06 +0000 (18:32 +0000)]
AX: aria-expanded changes are not communicated to clients
https://bugs.webkit.org/show_bug.cgi?id=132642

Reviewed by Mario Sanchez Prada.

Source/WebCore:
When aria-expanded changes on non list/tree items, send out a generic
AXExpandedChange notification.

Test: platform/mac/accessibility/expanded-notification.html

* accessibility/AXObjectCache.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:
* platform/mac/accessibility/expanded-notification-expected.txt: Added.
* platform/mac/accessibility/expanded-notification.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRelease build fix.
ap@apple.com [Wed, 7 May 2014 18:24:21 +0000 (18:24 +0000)]
Release build fix.

* platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes):
Removed unused globals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEliminate "well known MIME type" support
ap@apple.com [Wed, 7 May 2014 18:19:21 +0000 (18:19 +0000)]
Eliminate "well known MIME type" support
https://bugs.webkit.org/show_bug.cgi?id=132654

Reviewed by Anders Carlsson.

Vestiges of FileSystem API.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::files):
(WebCore::DataTransfer::hasFileOfType):
* fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::contentTypeFromFilePathOrName):
* fileapi/File.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::createFileList):
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::findMimeType): Deleted.
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Deleted.
* platform/MIMETypeRegistry.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix windows build.
oliver@apple.com [Wed, 7 May 2014 18:13:04 +0000 (18:13 +0000)]
Fix windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[HTML] Default argument to HTMLTableElement.insertRow() should be -1
ch.dumez@samsung.com [Wed, 7 May 2014 17:29:33 +0000 (17:29 +0000)]
[HTML] Default argument to HTMLTableElement.insertRow() should be -1
https://bugs.webkit.org/show_bug.cgi?id=132651

Reviewed by Alexey Proskuryakov.

Source/WebCore:
HTMLTableElement.insertRow()'s argument default value should be -1, not 0,
as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#htmltableelement

The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
https://codereview.chromium.org/270213007/

Test: fast/dom/HTMLTableElement/insertRow-default-argument.html

* html/HTMLTableElement.h:
* html/HTMLTableElement.idl:

LayoutTests:
Add layout test to test that the default argument to HTMLTableElement.insertRow()
is -1.

* fast/dom/HTMLTableElement/insertRow-default-argument-expected.txt: Added.
* fast/dom/HTMLTableElement/insertRow-default-argument.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
cfleizach@apple.com [Wed, 7 May 2014 16:17:47 +0000 (16:17 +0000)]
AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
https://bugs.webkit.org/show_bug.cgi?id=132622

Reviewed by Mario Sanchez Prada.

Source/WebCore:
The select text with criteria mechanism used through accessibility needs to support
a few more parameters to be complete (including capitalize, lowercase and uppercase).

Updated: accessibility/select-text.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
* rendering/RenderText.cpp:
(WebCore::makeCapitalized):
* rendering/RenderText.h:

Tools:
* DumpRenderTree/AccessibilityUIElement.cpp:
(selectTextWithCriteriaCallback):
(isEqualCallback):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:
* platform/mac/accessibility/select-text-expected.txt:
* platform/mac/accessibility/select-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShare mac/editing/spelling/editing-multiple-words-with-markers.html with other platforms
g.czajkowski@samsung.com [Wed, 7 May 2014 14:54:56 +0000 (14:54 +0000)]
Share mac/editing/spelling/editing-multiple-words-with-markers.html with other platforms
https://bugs.webkit.org/show_bug.cgi?id=132649

Reviewed by Ryosuke Niwa.

This test does not verify autocorrection feature which is only implemented
by Mac. Other WebKit ports might be interested in running it due to
verification of spelling markers after merging two misspelled words.

Additionally, add the test case confirming spelling markers
before any selection change.

Due to bug 125689, this test starts using asynchronous spellchecking.

* editing/spelling/editing-multiple-words-with-markers-expected.txt:
Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt
* editing/spelling/editing-multiple-words-with-markers.html:
Renamed from platform/mac/editing/spelling/editing-multiple-words-with-markers.html

* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Mark editing-multiple-words-with-markers.html as failing since those
platforms didn't turn on asynchronous spellchecking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDocumentLoader::dataReceived assertion failed
commit-queue@webkit.org [Wed, 7 May 2014 14:07:02 +0000 (14:07 +0000)]
DocumentLoader::dataReceived assertion failed
https://bugs.webkit.org/show_bug.cgi?id=132017

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-05-07
Reviewed by Brent Fulgham.

We need to call didReceiveResponse client method before the didReceiveData client method, otherwise we get a lot of asserts.
This patch also fixes frequent crashes in downloadTimerCallback method on page loading.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::calculateWebTimingInformations): Initialize local variables.
(WebCore::headerCallback): Call didReceiveResponse client method here instead of in downloadTimerCallback.
(WebCore::ResourceHandleManager::downloadTimerCallback): Remove call to didReceiveResponse method.
(WebCore::ResourceHandleManager::dispatchSynchronousJob): Removed empty line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: Animated GIF inside compositing layer never resumes animation when scroll...
antti@apple.com [Wed, 7 May 2014 13:11:00 +0000 (13:11 +0000)]
REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
https://bugs.webkit.org/show_bug.cgi?id=132608

Reviewed by Simon Fraser.

Source/WebCore:
Test: fast/repaint/animation-after-layer-scroll.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

    Check if any animations need to be restarted after layer scroll.

LayoutTests:
* fast/repaint/animation-after-layer-scroll-expected.txt: Added.
* fast/repaint/animation-after-layer-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGraphicsLayer::client() should return a reference.
commit-queue@webkit.org [Wed, 7 May 2014 11:44:00 +0000 (11:44 +0000)]
GraphicsLayer::client() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=126372

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-05-07
Reviewed by Simon Fraser.

GraphicsLayers always have a GraphicsLayerClient attached,
so make client() a reference and remove some unnecessary branches.
The author of the changes in the mac port is Andreas Kling <akling@apple.com>.

Source/WebCore:
* WebCore.exp.in:
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::willBeDestroyed):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
(WebCore::GraphicsLayer::addRepaintRect):
(WebCore::dumpChildren):
(WebCore::GraphicsLayer::dumpProperties):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::client):
(WebCore::GraphicsLayer::pageScaleFactor):
(WebCore::GraphicsLayer::deviceScaleFactor):
* platform/graphics/GraphicsLayerFactory.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::initialize):
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::computePositionRelativeToBase):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldAggressivelyRetainTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldTemporarilyRetainTileCohorts):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::createGraphicsLayer):
* platform/graphics/texmap/coordinated/CompositingCoordinator.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateLayerForTopOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):

Source/WebKit/win:
* WebView.cpp:
(WebView::setAcceleratedCompositing):

Source/WebKit2:
* WebProcess/WebPage/PageOverlayController.cpp:
(WebKit::PageOverlayController::initialize):
(WebKit::PageOverlayController::installPageOverlay):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
* WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Corrected typo
calvaris@igalia.com [Wed, 7 May 2014 10:54:29 +0000 (10:54 +0000)]
[GStreamer] Corrected typo
https://bugs.webkit.org/show_bug.cgi?id=132609

Reviewed by Martin Robinson.

Corrected m_canFallBackToLastFinishedSeekPositon typo and
initialized in the constructor to prevent problems in the future.

No test needed.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialized m_canFallBackToLastFinishedSeekPosition as false.
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
m_canFallBackToLastFinishedSeekPositon ->
m_canFallBackToLastFinishedSeekPosition

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup the build from unused parameter in UIProcess Module
commit-queue@webkit.org [Wed, 7 May 2014 10:39:48 +0000 (10:39 +0000)]
Cleanup the build from unused parameter in UIProcess Module
https://bugs.webkit.org/show_bug.cgi?id=131969

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-05-07
Reviewed by Csaba Osztrogonác.

Fixed unused parameter by omitting the parameter name

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageFindClient):
* UIProcess/WebFindClient.cpp:
(WebKit::WebFindClient::didFindString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert PassOwnPtr to unique_ptr in CrossThreadTask.h
gyuyoung.kim@samsung.com [Wed, 7 May 2014 10:20:14 +0000 (10:20 +0000)]
Convert PassOwnPtr to unique_ptr in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=132605

Reviewed by Dirk Schulze.

* dom/CrossThreadTask.h: Converted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SOUP] TLSErrors do not cause page load to fail when not ignored
carlosgc@webkit.org [Wed, 7 May 2014 10:11:30 +0000 (10:11 +0000)]
[SOUP] TLSErrors do not cause page load to fail when not ignored
https://bugs.webkit.org/show_bug.cgi?id=121548

Reviewed by Sergio Villar Senin.

Source/WebCore:
This only happens in case of redirection, when the initial URL is
an HTTPS site with an invalid certificate, that redirects to
another location. We are starting the redirection without checking
the TLS errors.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Check TLS errors before starting a
possible redirection.

Tools:
Add unit tests to check that the load fails with TLS errors in
case of a redirection.

* TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(testTLSErrorsRedirect):
(httpsServerCallback):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Remove runtime feature
rego@igalia.com [Wed, 7 May 2014 09:56:14 +0000 (09:56 +0000)]
[CSS Grid Layout] Remove runtime feature
https://bugs.webkit.org/show_bug.cgi?id=132382

Reviewed by Benjamin Poulain.

PerformanceTests:
Remove set of WebKitCSSGridLayoutEnabled preference.

* Layout/auto-grid-lots-of-data.html:
* Layout/fixed-grid-lots-of-data.html:

Source/WebCore:
Remove cssGridLayoutEnabled setting. Update methods using it accordingly.

* WebCore.order:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::cssGridLayoutEnabled): Deleted.
* css/CSSParser.h:
* css/CSSParserMode.h:
* dom/Document.cpp:
(WebCore::Document::cssGridLayoutEnabled): Deleted.
* dom/Document.h:
* page/Settings.in:

Source/WebKit/efl:
Remove cssGridLayoutEnabled setting usage.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled): Deleted.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/mac:
Remove cssGridLayoutEnabled setting usage.

* WebKit.order:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences cssGridLayoutEnabled]): Deleted.
(-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:
Remove cssGridLayoutEnabled setting usage.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCSSGridLayoutEnabled): Deleted.
(WKPreferencesGetCSSGridLayoutEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed):
* UIProcess/gtk/ExperimentalFeatures.cpp:
* UIProcess/gtk/ExperimentalFeatures.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* mac/WebKit2.order:

Tools:
Remove cssGridLayoutEnabled setting usage.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):

LayoutTests:
Remove set of WebKitCSSGridLayoutEnabled preference.
Remove fast/css-grid-layout/grid-disabled.html patch as the setting is not available anymore.

* fast/css-grid-layout/anonymous-grid-items-expected.html:
* fast/css-grid-layout/anonymous-grid-items.html:
* fast/css-grid-layout/auto-content-resolution-columns.html:
* fast/css-grid-layout/auto-content-resolution-rows.html:
* fast/css-grid-layout/breadth-size-resolution-grid.html:
* fast/css-grid-layout/calc-resolution-grid-item.html:
* fast/css-grid-layout/containing-block-grids.html:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
* fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
* fast/css-grid-layout/flex-content-resolution-columns.html:
* fast/css-grid-layout/flex-content-resolution-rows.html:
* fast/css-grid-layout/flex-content-sized-column-use-available-width.html:
* fast/css-grid-layout/flex-content-sized-columns-resize.html:
* fast/css-grid-layout/floating-empty-grids.html:
* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
* fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
* fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
* fast/css-grid-layout/grid-auto-columns-rows-update.html:
* fast/css-grid-layout/grid-auto-flow-get-set.html:
* fast/css-grid-layout/grid-auto-flow-resolution.html:
* fast/css-grid-layout/grid-auto-flow-update.html:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
* fast/css-grid-layout/grid-disabled-expected.txt: Removed.
* fast/css-grid-layout/grid-disabled.html: Removed.
* fast/css-grid-layout/grid-dynamic-updates-relayout.html:
* fast/css-grid-layout/grid-element-border-grid-item.html:
* fast/css-grid-layout/grid-element-border-padding-grid-item.html:
* fast/css-grid-layout/grid-element-change-columns-repaint.html:
* fast/css-grid-layout/grid-element-change-rows-repaint.html:
* fast/css-grid-layout/grid-element-empty-row-column.html:
* fast/css-grid-layout/grid-element-min-max-height.html:
* fast/css-grid-layout/grid-element-min-max-width.html:
* fast/css-grid-layout/grid-element-padding-grid-item.html:
* fast/css-grid-layout/grid-element-padding-margin.html:
* fast/css-grid-layout/grid-element-repeat-get-set.html:
* fast/css-grid-layout/grid-element-shrink-to-fit.html:
* fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
* fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
* fast/css-grid-layout/grid-item-area-get-set.html:
* fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
* fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
* fast/css-grid-layout/grid-item-change-column-repaint.html:
* fast/css-grid-layout/grid-item-change-row-repaint.html:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css-grid-layout/grid-item-end-after-get-set.html:
* fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
* fast/css-grid-layout/grid-item-margin-resolution.html:
* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
* fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
* fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
* fast/css-grid-layout/grid-item-negative-indexes.html:
* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
* fast/css-grid-layout/grid-item-negative-position-resolution.html:
* fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
* fast/css-grid-layout/grid-item-order-paint-order.html:
* fast/css-grid-layout/grid-item-position-changed-dynamic.html:
* fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
* fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
* fast/css-grid-layout/grid-item-spanning-resolution.html:
* fast/css-grid-layout/grid-item-start-before-get-set.html:
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
* fast/css-grid-layout/grid-preferred-logical-widths.html:
* fast/css-grid-layout/grid-strict-ordering-crash.html:
* fast/css-grid-layout/grid-template-areas-get-set.html:
* fast/css-grid-layout/grid-template-shorthand-get-set.html:
* fast/css-grid-layout/implicit-columns-auto-resolution.html:
* fast/css-grid-layout/implicit-position-dynamic-change.html:
* fast/css-grid-layout/implicit-rows-auto-resolution.html:
* fast/css-grid-layout/minmax-fixed-logical-height-only.html:
* fast/css-grid-layout/minmax-fixed-logical-width-only.html:
* fast/css-grid-layout/minmax-max-content-resolution-columns.html:
* fast/css-grid-layout/minmax-max-content-resolution-rows.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
* fast/css-grid-layout/minmax-spanning-resolution-columns.html:
* fast/css-grid-layout/minmax-spanning-resolution-rows.html:
* fast/css-grid-layout/named-grid-line-get-set.html:
* fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
* fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set.html:
* fast/css-grid-layout/non-grid-element-repeat-get-set.html:
* fast/css-grid-layout/non-named-grid-line-get-set.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
* fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
* fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
* fast/css-grid-layout/percent-resolution-grid-item.html:
* fast/css-grid-layout/place-cell-by-index.html:
* fast/css-grid-layout/should-not-collapse-anonymous-blocks.html:
* ietestcenter/css3/grid/grid-column-002.htm:
* ietestcenter/css3/grid/testRunnerEnableGrid.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed GTK gardening
berto@igalia.com [Wed, 7 May 2014 08:35:03 +0000 (08:35 +0000)]
[GTK] Unreviewed GTK gardening

Avoid duplicated expectations and remove failure flag for fixed
js/dom/basic-weakmap.html test.

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-05-07

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoURTBF after r168393 to fix !IOS builds.
ossy@webkit.org [Wed, 7 May 2014 08:15:54 +0000 (08:15 +0000)]
URTBF after r168393 to fix !IOS builds.

* Shared/WebEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build errors for BlobDataItem after r168391.
ossy@webkit.org [Wed, 7 May 2014 07:56:07 +0000 (07:56 +0000)]
Fix build errors for BlobDataItem after r168391.
https://bugs.webkit.org/show_bug.cgi?id=132643

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2014-05-07
Reviewed by Carlos Garcia Campos.

Patch updates BlobDataItem params usage in ResourceHandleSoup.cpp
to be inline with r168391.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::blobIsOutOfDate): BlobDataItem class is updated in r168391.
Corresponding parameter changes are done to resolve build error.
(WebCore::addEncodedBlobItemToSoupMessageBody): BlobDataItem class is updated
in r168391. Corresponding parameter changes are done to resolve build error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFollowup to "Add WK2 SPI to prevent the previous back/forward item from remaining...
beidson@apple.com [Wed, 7 May 2014 05:37:22 +0000 (05:37 +0000)]
Followup to "Add WK2 SPI to prevent the previous back/forward item from remaining in the list"
<rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636

Reviewed by NOBODY (My mistake while addressing previous review feedback)

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient): During review feedback, this client switched from default negative to default
  positve, so when the client isn't implemented...  return true instead of false.

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem): Fix nonsensical comments while I'm at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Makefile targets for copying static libraries (LLVM and WKSI)
ddkilzer@apple.com [Wed, 7 May 2014 05:18:07 +0000 (05:18 +0000)]
Add Makefile targets for copying static libraries (LLVM and WKSI)
<http://webkit.org/b/132619>

Reviewed by Mark Rowe.

.:
* Makefile:
(MODULES): Add WebKitLibraries.

Tools:
* Scripts/copy-webkitlibraries-to-product-directory: Set a
sensible default for product directory if not specified on
either the command-line or in the environment (by Xcode) by
calling productDir() in webkitdirs.pm.

WebKitLibraries:
* Makefile: Added.
(libs): Install both LLVM and WKSI static libraries.
(all): Add dependency on 'libs' target.
(debug d): Set configuration, the call 'libs' target.
(release r): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
lforschler@apple.com [Wed, 7 May 2014 05:15:47 +0000 (05:15 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WK2 SPI to prevent the previous back/forward item from remaining in the list
beidson@apple.com [Wed, 7 May 2014 04:50:57 +0000 (04:50 +0000)]
Add WK2 SPI to prevent the previous back/forward item from remaining in the list
<rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636

Reviewed by Sam Weinig.

Source/WebKit2:
Add new PageLoaderClient SPI to keep the current back/forward item from remaining in the list:
* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::shouldKeepCurrentBackForwardListItemInList):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
* UIProcess/API/C/WKPageLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::shouldKeepCurrentBackForwardListItemInList):
* UIProcess/WebPageProxy.h:

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem): Use that SPI to determine whether we should insert the new item after
the previous item, or simply replace the previous item.
(WebKit::WebBackForwardList::goToItem): Use that SPI to determine whether the previous item stays or goes.

Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

* TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
(TestWebKitAPI::itemURLLastComponentIsString):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
* TestWebKitAPI/Tests/WebKit2/simple3.html: Added.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Update for new client layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewd build fix for C-LOOP after r168396.
msaboff@apple.com [Wed, 7 May 2014 04:01:25 +0000 (04:01 +0000)]
Unreviewd build fix for C-LOOP after r168396.

* runtime/TestRunnerUtils.cpp:
(JSC::optimizeNextInvocation): Wrapped actual call inside #if ENABLE(JIT)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago-[WKWebView isLoading] is NO immediately after -loadRequest: until the provisional...
mitz@apple.com [Wed, 7 May 2014 03:47:06 +0000 (03:47 +0000)]
-[WKWebView isLoading] is NO immediately after -loadRequest: until the provisional load starts
https://bugs.webkit.org/show_bug.cgi?id=132639

Reviewed by Darin Adler.

* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Updated for change from isLoadingState to isLoading.
(WebKit::PageLoadState::isLoading): Renamed from isLoadingState, changed to take Data and
check whether there is a non-null pending API request URL. If so, return true.
* UIProcess/PageLoadState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up the difference between painting focus rings and adding PDF annotations
dino@apple.com [Wed, 7 May 2014 02:58:39 +0000 (02:58 +0000)]
Clean up the difference between painting focus rings and adding PDF annotations
https://bugs.webkit.org/show_bug.cgi?id=132638

Reviewed by Simon Fraser.

The code to add a PDF annotation when printing was called from
drawFocusRing, which is quite confusing. With just little movement
of code, we can detect an annotation and call addPDFURLRect in the
paint phase, and drawFocusRing becomes something that only
draws focus rings.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline): Split calls to drawFocusRing
and addPDFURLRect.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Get rid of call to PDF.
(WebCore::RenderObject::addPDFURLRect): Change the signature so it
can be called externally, and calculates the rectangle itself.
(WebCore::RenderObject::paintOutline): Split the calls.
* rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCalling createPattern with a broken image must throw an invalidstate error
cabanier@adobe.com [Wed, 7 May 2014 02:25:00 +0000 (02:25 +0000)]
Calling createPattern with a broken image must throw an invalidstate error
https://bugs.webkit.org/show_bug.cgi?id=132407

Reviewed by Darin Adler.

Source/WebCore:
Updated createPattern so it throws an invalidState exception
if you pass it an image that is in the broken state.

Tests:
* canvas/philip/tests/2d.pattern.image.broken.html:
* canvas/philip/tests/2d.pattern.image.incomplete.empty.html:
* fast/canvas/canvas-empty-image-pattern.html:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):

LayoutTests:
* canvas/philip/tests/2d.pattern.image.broken-expected.txt:
* canvas/philip/tests/2d.pattern.image.broken.html:
* canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt:
* canvas/philip/tests/2d.pattern.image.incomplete.empty.html:
* fast/canvas/canvas-empty-image-pattern-expected.txt:
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* platform/mac/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][Mac] Display sleeps while playing <video> content.
jer.noble@apple.com [Wed, 7 May 2014 01:44:13 +0000 (01:44 +0000)]
[iOS][Mac] Display sleeps while playing <video> content.
https://bugs.webkit.org/show_bug.cgi?id=132624

Reviewed by Darin Adler.

On iOS and Mac, create a DisplaySleepDisablerCocoa rather than an (no-op) DisplaySleepDisabler.

* platform/cocoa/DisplaySleepDisablerCocoa.cpp:
(WebCore::DisplaySleepDisabler::create):
* platform/cocoa/DisplaySleepDisablerCocoa.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Allow focus rings to redraw themselves if necessary
dino@apple.com [Wed, 7 May 2014 01:41:57 +0000 (01:41 +0000)]
[Mac] Allow focus rings to redraw themselves if necessary
https://bugs.webkit.org/show_bug.cgi?id=132593

Fix iOS build.

* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing): We no longer use the color parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Allow focus rings to redraw themselves if necessary
dino@apple.com [Wed, 7 May 2014 01:07:46 +0000 (01:07 +0000)]
[Mac] Allow focus rings to redraw themselves if necessary
https://bugs.webkit.org/show_bug.cgi?id=132593

Reviewed by Simon Fraser.

Source/WebCore:
Mac allows focus rings to change rendering over time. Expose this
functionality to WebKit by having the rendering code detect that
a focused element has asked to repaint itself, and also have
the FocusController object remember how long it has been since
an element was focused.

This patch removes WebCoreNSCellExtras, since a better version is
available in WebKitSystemInterface, and it was going to be cumbersome
to port the code from there into WebKit.

* WebCore.exp.in: Export _wkDrawFocusRingAtTime and _wkDrawCellFocusRingWithFrameAtTime.
* WebCore.xcodeproj/project.pbxproj: Remove WebCoreNSCellExtras.
* page/FocusController.cpp:
(WebCore::FocusController::FocusController): Initialize the repaint timer.
(WebCore::FocusController::~FocusController): Stop the repaint timer on deletion.
(WebCore::FocusController::setFocusedElement): Keep track of the current time when focused.
(WebCore::FocusController::focusedElementNeedsRepaint): Start the repaint timer.
(WebCore::FocusController::focusRepaintTimerFired): Ask the focused element to repaint itself.
(WebCore::FocusController::timeSinceFocusWasSet):
* page/FocusController.h: Expose timeSinceFocusWasSet() and focusedElementNeedsRepaint(), as
well as add the timer for repainting.

* platform/ControlStates.h: Add timeSinceControlWasFocused member variable, allowing the platform
code such as Theme to obtain the value from FocusController.
(WebCore::ControlStates::ControlStates):
(WebCore::ControlStates::timeSinceControlWasFocused):
(WebCore::ControlStates::setTimeSinceControlWasFocused):

* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::drawFocusRing): New Mac-only method that uses timeOffset.

* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::drawFocusRingToContext): No need to pass in color and radius - these are now
ignored in WKDrawFocusRing. However, I didn't want to change the signature of the
WKSI function.
(WebCore::drawFocusRingToContextAtTime): Call into the new method WKDrawFocusRingAtTime.
(WebCore::GraphicsContext::drawFocusRing): Color and radius no longer used.

* platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): Update the margins since our focus ring can be a lot bigger.
(WebCore::radioMargins): Ditto.
(WebCore::paintToggleButton): Drawing a focus ring might trigger a repaint too.
(WebCore::buttonMargins): Increase the margins.
(WebCore::paintButton): If our focus ring wants to be drawn again, set the ControlStates flag.

* platform/mac/WebCoreNSCellExtras.h: Removed.
* platform/mac/WebCoreNSCellExtras.m: Removed.

* platform/mac/WebCoreSystemInterface.h: Declare the new methods.
* platform/mac/WebCoreSystemInterface.mm:

* rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle): Expand the overflow rects by the maximum
focus ring width. This might be different from the current outline size.
(WebCore::RenderElement::setStyle): Ditto.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): If we're on Mac, use the new drawFocusRing method,
which sets a parameter to true if the focused element needs a repaint.

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::updateControlStatesForRenderer): Copy the value from FocusController
so that the platform Theme code can use it.

* rendering/RenderTheme.h:
(WebCore::RenderTheme::platformFocusRingMaxWidth): Add a way to get the maximum width
of a focus ring for the platform. This is used to extend the overflow rects.
* rendering/RenderThemeMac.h: Override the focus ring width.
* rendering/RenderThemeMac.mm: On newer versions of OS X, we have a larger focus ring.
(WebCore::RenderThemeMac::platformFocusRingMaxWidth):
(WebCore::RenderThemeMac::paintMenuList): If a menu is focused, and needs a repaint, mark
it as such.

Source/WebKit/mac:
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.

Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd test for deleteAllCompiledCode
msaboff@apple.com [Wed, 7 May 2014 00:34:34 +0000 (00:34 +0000)]
Add test for deleteAllCompiledCode
https://bugs.webkit.org/show_bug.cgi?id=132632

Reviewed by Phil Pizlo.

Added two new hooks to jsc, one to call Heap::deleteAllCompiledCode() and
the other to call CodeBlock::optimizeNextInvocation().  Used these two hooks
to write a test that will queue up loads of DFG compiles and then call
Heap::deleteAllCompiledCode() to make sure that it can handle compiled
code as well as code being compiled.

* jsc.cpp:
(GlobalObject::finishCreation):
(functionDeleteAllCompiledCode):
(functionOptimizeNextInvocation):
* runtime/TestRunnerUtils.cpp:
(JSC::optimizeNextInvocation):
* runtime/TestRunnerUtils.h:
* tests/stress/deleteAllCompiledCode.js: Added.
(functionList):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/16833442> [iOS WebKit2]: Keep the order of contentView in _scrollView...
benjamin@webkit.org [Wed, 7 May 2014 00:29:29 +0000 (00:29 +0000)]
<rdar://problem/16833442> [iOS WebKit2]: Keep the order of contentView in _scrollView after rotation
https://bugs.webkit.org/show_bug.cgi?id=132634

Reviewed by Enrica Casucci.

Nice idea of Yongjun.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTake WKView's topContentInset into account when docking Web Inspector to the right.
timothy@apple.com [Wed, 7 May 2014 00:17:00 +0000 (00:17 +0000)]
Take WKView's topContentInset into account when docking Web Inspector to the right.

https://bugs.webkit.org/show_bug.cgi?id=132631

Reviewed by Joseph Pecoraro.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Subtract topContentInset
from the height of the frame for the Inspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][WK2] WebKit2 does not set CanPreventNativeGestures on the platform events
benjamin@webkit.org [Wed, 7 May 2014 00:01:53 +0000 (00:01 +0000)]
[iOS][WK2] WebKit2 does not set CanPreventNativeGestures on the platform events
https://bugs.webkit.org/show_bug.cgi?id=132594

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-06
Reviewed by Simon Fraser.

Set CanPreventNativeGestures on the plaform event.
Change the tracking of WKContentView to be similar to WebPageProxy.

* Shared/WebEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::canPreventNativeGestures):
(WebKit::WebTouchEvent::setCanPreventNativeGestures):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
* Shared/ios/WebTouchEventIOS.cpp:
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _webTouchEventsRecognized:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Animate AVPlayerLayer into and out of full screen
jer.noble@apple.com [Tue, 6 May 2014 23:36:20 +0000 (23:36 +0000)]
[iOS] Animate AVPlayerLayer into and out of full screen
https://bugs.webkit.org/show_bug.cgi?id=132603

Reviewed by Simon Fraser.

Rather than synchronize animations across the WebProcess / UIProcess boundary, animate
the AVPlayerLayer into place by first resizing the full screen layer to occupy the
entire screen in the WebProcess, and use a sublayerTransform animation in the UIProcess
to scale the AVPlayer from its initial screen location, as well as back to its final screen
location.

* platform/graphics/GeometryUtilities.cpp:
(WebCore::largestRectWithAspectRatioInsideRect): Added utility method.
* platform/graphics/GeometryUtilities.h:
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVVideoLayer init]): Added, initialize video gravity and enable child layer masking.
(-[WebAVVideoLayer setBounds:]): Create a transform to scale the video area.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Block implicit animations during setup.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Reset the gravity to ResizeAspect
    if necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake BlobDataItem use a refcounted object for files
ap@apple.com [Tue, 6 May 2014 23:34:35 +0000 (23:34 +0000)]
Make BlobDataItem use a refcounted object for files
https://bugs.webkit.org/show_bug.cgi?id=132628

Reviewed by Anders Carlsson.

* CMakeLists.txt:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
Added BlobDataFileReference.{h|cpp}

* WebCore.exp.in: Removed unused exports.

* platform/network/BlobData.h:
(WebCore::BlobDataItem::offset):
(WebCore::BlobDataItem::BlobDataItem):
Use a wrapper class for files, not a path. Changed to be more class-like accordingly.

* platform/network/BlobData.cpp:
(WebCore::BlobData::appendData):
(WebCore::BlobData::appendFile):
(WebCore::BlobData::appendBlob): Deleted.
(WebCore::BlobData::BlobData): Deleted.
We never add blobs to BlobData, they are always resolved to data of file references.
Lots of very confusing code to delete.

* platform/network/BlobDataFileReference.h: Added.
* platform/network/BlobDataFileReference.cpp: Added.
(WebCore::BlobDataFileReference::size):
(WebCore::BlobDataFileReference::expectedModificationTime):
(WebCore::BlobDataFileReference::computeFileSystemData):
A unique reference to a file referenced by blob, to be preserved when you slice
or combine blobs.

* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::blobSize):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::getSizeForNext):
(WebCore::BlobResourceHandle::didGetSize):
(WebCore::BlobResourceHandle::readDataSync):
(WebCore::BlobResourceHandle::readFileSync):
(WebCore::BlobResourceHandle::readDataAsync):
(WebCore::BlobResourceHandle::readFileAsync):
* platform/network/BlobResourceHandle.h:
* platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
Updated for BlobDataItem interface changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[HTML] Default argument to HTMLTableRowElement.insertCell() should be -1
ch.dumez@samsung.com [Tue, 6 May 2014 23:32:51 +0000 (23:32 +0000)]
[HTML] Default argument to HTMLTableRowElement.insertCell() should be -1
https://bugs.webkit.org/show_bug.cgi?id=132615

Reviewed by Darin Adler.

Source/WebCore:
HTMLTableRowElement.insertCell()'s argument default value should be -1, not
0, as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tr-element

The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
https://codereview.chromium.org/263323004/

Test: fast/dom/HTMLTableRowElement/insertCell-default-argument.html

* html/HTMLTableRowElement.h:
* html/HTMLTableRowElement.idl:

LayoutTests:
Add layout test to test that the default argument to
HTMLTableRowElement.insertCell() is -1.

* fast/dom/HTMLTableRowElement/insertCell-default-argument-expected.txt: Added.
* fast/dom/HTMLTableRowElement/insertCell-default-argument.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
oliver@apple.com [Tue, 6 May 2014 23:11:00 +0000 (23:11 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][WK2] Add tap highlight on the simple UITapGestureRecognizer
benjamin@webkit.org [Tue, 6 May 2014 22:53:12 +0000 (22:53 +0000)]
[iOS][WK2] Add tap highlight on the simple UITapGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=132623
<rdar://problem/16709507>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-06
Reviewed by Enrica Casucci.

Add a low latency highlight for tap/click.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::commitPotentialTapFailed):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _showTapHighlightWithColor:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _finishInteraction]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _singleTapDidReset:]):
(-[WKContentView _commitPotentialTapFailed]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _attemptClickAtLocation:]):
* UIProcess/ios/WKSyntheticClickTapGestureRecognizer.h: Added.
* UIProcess/ios/WKSyntheticClickTapGestureRecognizer.m: Added.
(-[WKSyntheticClickTapGestureRecognizer setGestureRecognizedTarget:action:]):
(-[WKSyntheticClickTapGestureRecognizer setResetTarget:action:]):
(-[WKSyntheticClickTapGestureRecognizer setState:]):
(-[WKSyntheticClickTapGestureRecognizer reset]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::potentialTapAtPosition):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::cancelPotentialTap):
(WebKit::WebPageProxy::tapHighlightAtPosition):
(WebKit::WebPageProxy::commitPotentialTapFailed):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::handleTap):
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
(WebKit::WebPage::potentialTapAtPosition):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::cancelPotentialTap):
(WebKit::WebPage::tapHighlightAtPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPut WebArchive and WebArchiveResource in the API namespace.
andersca@apple.com [Tue, 6 May 2014 22:44:56 +0000 (22:44 +0000)]
Put WebArchive and WebArchiveResource in the API namespace.

Rubber-stamped by Dan Bernstein.

* Shared/API/c/WKSharedAPICast.h:
* Shared/API/c/mac/WKWebArchive.cpp:
(WKWebArchiveGetTypeID):
(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
* Shared/API/c/mac/WKWebArchiveResource.cpp:
(WKWebArchiveResourceGetTypeID):
(WKWebArchiveResourceCreate):
* Shared/APIWebArchive.cpp: Renamed from Source/WebKit2/Shared/WebArchive.cpp.
(API::WebArchive::create):
(API::WebArchive::WebArchive):
(API::WebArchive::~WebArchive):
(API::WebArchive::mainResource):
(API::WebArchive::subresources):
(API::WebArchive::subframeArchives):
(API::releaseCFData):
(API::WebArchive::data):
(API::WebArchive::coreLegacyWebArchive):
* Shared/APIWebArchive.h: Renamed from Source/WebKit2/Shared/WebArchive.h.
* Shared/APIWebArchiveResource.cpp: Renamed from Source/WebKit2/Shared/WebArchiveResource.cpp.
(API::WebArchiveResource::create):
(API::WebArchiveResource::WebArchiveResource):
(API::WebArchiveResource::~WebArchiveResource):
(API::releaseCFData):
(API::WebArchiveResource::data):
(API::WebArchiveResource::URL):
(API::WebArchiveResource::MIMEType):
(API::WebArchiveResource::textEncoding):
(API::WebArchiveResource::coreArchiveResource):
* Shared/APIWebArchiveResource.h: Renamed from Source/WebKit2/Shared/WebArchiveResource.h.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd missing line from r168384.
akling@apple.com [Tue, 6 May 2014 22:27:23 +0000 (22:27 +0000)]
Add missing line from r168384.

* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::~ChildNodesLazySnapshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCan't make a booking at virginamerica.com
oliver@apple.com [Tue, 6 May 2014 22:17:04 +0000 (22:17 +0000)]
Can't make a booking at virginamerica.com
https://bugs.webkit.org/show_bug.cgi?id=132626

Reviewed by Geoffrey Garen.

Source/WebCore:
Test: fast/dom/assign-to-prototype-accessor-on-prototype-should-be-silent.html

We can't throw an exception when a site incorrectly attempts
to use a dom property setter directly on the prototype as
there are sites that do this as compatibility workarounds
for old browsers. Instead we treat use of the setter on
the prototype object in the same way we do getters, and just
log a warning to the console.

* bindings/js/JSDOMBinding.cpp:
(WebCore::reportDeprecatedSetterError):
* bindings/js/JSDOMBinding.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::setJSTestNondeterministicNondeterministicWriteableAttr):
(WebCore::setJSTestNondeterministicNondeterministicExceptionAttr):
(WebCore::setJSTestNondeterministicNondeterministicGetterExceptionAttr):
(WebCore::setJSTestNondeterministicNondeterministicSetterExceptionAttr):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjEnumAttr):
(WebCore::setJSTestObjByteAttr):
(WebCore::setJSTestObjOctetAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjReplaceableAttribute):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::setJSTestObjAttributeWithReservedEnumType):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
(WebCore::setJSTestTypedefsStringAttrWithGetterException):
(WebCore::setJSTestTypedefsStringAttrWithSetterException):

LayoutTests:
Add testcase to make sure that we are silently ignoring usage
of prototype setters and the prototype itself. We dump a warning
to the console as throwing an exception breaks sites that used
to rely on essentially no-op behavior.

* fast/dom/assign-to-prototype-accessor-on-prototype-should-be-silent-expected.txt: Added.
* fast/dom/assign-to-prototype-accessor-on-prototype-should-be-silent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSString::toAtomicString() should return AtomicString.
akling@apple.com [Tue, 6 May 2014 22:16:22 +0000 (22:16 +0000)]
JSString::toAtomicString() should return AtomicString.
<https://webkit.org/b/132627>

Remove premature optimization where I was trying to avoid refcount
churn when returning an already atomicized String.

Instead of using reinterpret_cast to mangle the String member into
a const AtomicString& return value, just return AtomicString.

Reviewed by Geoff Garen.

* runtime/JSString.h:
(JSC::JSString::toAtomicString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChildNodesLazySnapshot::m_childNodes needs two heap allocations.
akling@apple.com [Tue, 6 May 2014 22:13:45 +0000 (22:13 +0000)]
ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
<https://webkit.org/b/132616>

This seems a bit silly, since ChildNodesLazySnapshot is always
allocated on the stack.

Change it to be a bool + a Vector instead of using the nullity
as a presence indicator. This way we also don't end up with an
out-of-line ~OwnPtr for the Vector.

Reviewed by Geoff Garen.

* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::ChildNodesLazySnapshot):
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEliminate BlobStorageData
ap@apple.com [Tue, 6 May 2014 22:11:07 +0000 (22:11 +0000)]
Eliminate BlobStorageData
https://bugs.webkit.org/show_bug.cgi?id=132617

Reviewed by Anders Carlsson.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/network/BlobData.h:
(WebCore::BlobData::create):
(WebCore::BlobData::BlobData):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::loadResourceSynchronously):
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
(WebCore::BlobRegistryImpl::blobSize):
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::doStart):
(WebCore::BlobResourceHandle::getSizeForNext):
(WebCore::BlobResourceHandle::didGetSize):
(WebCore::BlobResourceHandle::seek):
(WebCore::BlobResourceHandle::readSync):
(WebCore::BlobResourceHandle::readDataSync):
(WebCore::BlobResourceHandle::readFileSync):
(WebCore::BlobResourceHandle::readAsync):
(WebCore::BlobResourceHandle::readDataAsync):
(WebCore::BlobResourceHandle::readFileAsync):
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
* platform/network/BlobResourceHandle.h:
* platform/network/BlobStorageData.h: Removed.
* platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::addEncodedBlobToSoupMessageBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build.
simon.fraser@apple.com [Tue, 6 May 2014 21:45:08 +0000 (21:45 +0000)]
Fix the iOS build.

WebCore::Editor::replaceNodeFromPasteboard(WebCore::Node*, WTF::String const&) is Mac-only.
Also sort the export file.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBegin Removal of Old Multi-Column Code.
hyatt@apple.com [Tue, 6 May 2014 21:35:52 +0000 (21:35 +0000)]
Begin Removal of Old Multi-Column Code.
https://bugs.webkit.org/show_bug.cgi?id=132480

Reviewed by Andreas Kling.

Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::regionBasedColumnsEnabled): Deleted.
* dom/Document.h:
* page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
* page/Settings.in:
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::addForcedColumnBreak): Deleted.
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginatingColumns): Deleted.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::renderName):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks): Deleted.
(WebCore::RenderBlock::containingColumnsBlock): Deleted.
(WebCore::RenderBlock::splitFlow): Deleted.
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): Deleted.
(WebCore::RenderBlock::columnsBlockForSpanningElement): Deleted.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Deleted.
(WebCore::RenderBlock::updateLogicalWidthAndColumnWidth): Deleted.
(WebCore::RenderBlock::isTopLayoutOverflowAllowed): Deleted.
(WebCore::RenderBlock::isLeftLayoutOverflowAllowed): Deleted.
(WebCore::RenderBlock::paintColumnRules): Deleted.
(WebCore::RenderBlock::initialBlockOffsetForPainting): Deleted.
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn): Deleted.
(WebCore::RenderBlock::paintColumnContents): Deleted.
(WebCore::ColumnRectIterator::ColumnRectIterator): Deleted.
(WebCore::ColumnRectIterator::advance): Deleted.
(WebCore::ColumnRectIterator::columnRect): Deleted.
(WebCore::ColumnRectIterator::hasMore): Deleted.
(WebCore::ColumnRectIterator::adjust): Deleted.
(WebCore::ColumnRectIterator::update): Deleted.
(WebCore::RenderBlock::hitTestColumns): Deleted.
(WebCore::RenderBlock::adjustForColumnRect): Deleted.
(WebCore::RenderBlock::availableLogicalWidth): Deleted.
(WebCore::RenderBlock::columnGap): Deleted.
(WebCore::RenderBlock::computeColumnCountAndWidth): Deleted.
(WebCore::RenderBlock::requiresColumns): Deleted.
(WebCore::RenderBlock::setComputedColumnCountAndWidth): Deleted.
(WebCore::RenderBlock::updateColumnProgressionFromStyle): Deleted.
(WebCore::RenderBlock::computedColumnWidth): Deleted.
(WebCore::RenderBlock::computedColumnCount): Deleted.
(WebCore::RenderBlock::columnInfo): Deleted.
(WebCore::RenderBlock::columnCount): Deleted.
(WebCore::RenderBlock::columnRectAt): Deleted.
(WebCore::RenderBlock::adjustPointToColumnContents): Deleted.
(WebCore::RenderBlock::adjustRectForColumns): Deleted.
(WebCore::RenderBlock::flipForWritingModeIncludingColumns): Deleted.
(WebCore::RenderBlock::adjustStartEdgeForWritingModeIncludingColumns): Deleted.
(WebCore::RenderBlock::adjustForColumns): Deleted.
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns): Deleted.
(WebCore::RenderBlock::paginationUnit): Deleted.
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer): Deleted.
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer): Deleted.
(WebCore::RenderBlock::computeLineGridPaginationOrigin): Deleted.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::createAnonymousBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::createAnonymousColumnsBlock): Deleted.
(WebCore::RenderBlock::createAnonymousColumnSpanBlock): Deleted.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustIntrinsicLogicalWidthsForColumns):
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths):
(WebCore::RenderBlockFlow::recomputeLogicalWidthAndColumnWidth):
(WebCore::RenderBlockFlow::columnGap):
(WebCore::RenderBlockFlow::computeColumnCountAndWidth):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::inNormalFlow):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::updateMinimumPageHeight):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):
(WebCore::RenderBlockFlow::requiresColumns):
(WebCore::RenderBlockFlow::setComputedColumnCountAndWidth):
(WebCore::RenderBlockFlow::updateColumnProgressionFromStyle):
(WebCore::RenderBlockFlow::computedColumnWidth):
(WebCore::RenderBlockFlow::computedColumnCount):
* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::hasOverhangingFloats):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderFlowThread.h:
* rendering/RenderGeometryMap.cpp:
(WebCore::canMapBetweenRenderers):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
(WebCore::checkContainingBlockChainForPagination): Deleted.
(WebCore::RenderLayer::useRegionBasedColumns): Deleted.
(WebCore::RenderLayer::paintPaginatedChildLayer): Deleted.
(WebCore::RenderLayer::paintChildLayerIntoColumns): Deleted.
(WebCore::RenderLayer::hitTestPaginatedChildLayer): Deleted.
(WebCore::RenderLayer::hitTestChildLayerColumns): Deleted.
* rendering/RenderLayer.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::shouldCheckColumnBreaks):
* rendering/RenderMultiColumnFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::offsetFromContainer):
* rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::hasColumns): Deleted.
(WebCore::RenderObject::setHasColumns): Deleted.
(WebCore::RenderObject::isAnonymousColumnsBlock): Deleted.
(WebCore::RenderObject::isAnonymousColumnSpanBlock): Deleted.
(WebCore::RenderObject::adjustForColumns): Deleted.
(WebCore::RenderObject::offsetForColumns): Deleted.
* rendering/RenderText.cpp:
(WebCore::RenderText::selectionRectForRepaint):
* rendering/RenderView.cpp:
(WebCore::RenderView::availableLogicalHeight):
(WebCore::RenderView::pageOrViewLogicalHeight):
(WebCore::RenderView::unextendedBackgroundRect):
(WebCore::RenderView::backgroundRect):
(WebCore::RenderView::shouldDisableLayoutStateForSubtree):
(WebCore::RenderView::pageNumberForBlockProgressionOffset):
(WebCore::RenderView::pageCount):
(WebCore::RenderView::paginationUnit): Deleted.
* rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
* style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):

LayoutTests:
* platform/mac/fast/multicol/client-rects-expected.png:
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/client-rects-spanners-complex-expected.png:
* platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
* platform/mac/fast/multicol/client-rects-spanners-expected.png:
* platform/mac/fast/multicol/client-rects-spanners-expected.txt:
* platform/mac/fast/multicol/newmulticol/client-rects-expected.png:
* platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPut the symlink in the right place.
andersca@apple.com [Tue, 6 May 2014 21:32:25 +0000 (21:32 +0000)]
Put the symlink in the right place.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't select an image that is about to have its menu shown.
beidson@apple.com [Tue, 6 May 2014 21:08:14 +0000 (21:08 +0000)]
Don't select an image that is about to have its menu shown.
<rdar://problem/16807845> and https://bugs.webkit.org/show_bug.cgi?id=132579

Reviewed by Tim Horton.

Source/WebCore:
* WebCore.exp.in:

* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::replaceNodeFromPasteboard): New method that first selects
  the Node and then immediately pastes over it. Since it’s synchronous the
  selection never has a chance to paint.

* html/shadow/mac/ImageControlsButtonElementMac.cpp:
(WebCore::ImageControlsButtonElementMac::defaultEventHandler): Don’t select the image.

Source/WebKit/mac:
* Misc/WebSharingServicePickerController.mm:
(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
  Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] make metadata cue attributes consistent
eric.carlson@apple.com [Tue, 6 May 2014 20:19:31 +0000 (20:19 +0000)]
[Mac] make metadata cue attributes consistent
https://bugs.webkit.org/show_bug.cgi?id=132610

Reviewed by Jer Noble.

Source/WebCore:
No new tests, updated http/tests/media/track-in-band-hls-metadata.html.

* platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithAVMetadataItemInContext): Don't include keys @dataTypeNamespace
    or @pictureType, @dataType -> @type.

LayoutTests:
* http/tests/media/track-in-band-hls-metadata-expected.txt:
* http/tests/media/track-in-band-hls-metadata.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago"Flash of content without image" when pasting a raw image from the pasteboard
beidson@apple.com [Tue, 6 May 2014 20:10:01 +0000 (20:10 +0000)]
"Flash of content without image" when pasting a raw image from the pasteboard
<rdar://problem/16826199> and https://bugs.webkit.org/show_bug.cgi?id=132612

Reviewed by Tim Horton.

Let an ArchiveResource be flagged as "should load immediately":
* loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::ArchiveResource):
* loader/archive/ArchiveResource.h:
(WebCore::ArchiveResource::setShouldLoadImmediately):
(WebCore::ArchiveResource::shouldLoadImmediately):

Set that flag on the ArchiveResource for the image.
Note we quite explicitly do this only in the "read a single image" from the pasteboard
case, because we don't want to do this synchronous step for multiple images at once
such as when pasting a WebArchive:
* editing/mac/EditorMac.mm:
(WebCore::Editor::WebContentReader::readImage):

When creating a new CachedResource, if there is an ArchiveResource that is set to
load immediately, populate the CachedResource immediately instead of scheduling a load:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Enabled regions performance tests by default
stavila@adobe.com [Tue, 6 May 2014 19:48:53 +0000 (19:48 +0000)]
[CSSRegions] Enabled regions performance tests by default
https://bugs.webkit.org/show_bug.cgi?id=128244

Reviewed by Andreas Kling.

Enabled regions performance tests.

* Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRoll out r167889
mhahnenberg@apple.com [Tue, 6 May 2014 19:15:42 +0000 (19:15 +0000)]
Roll out r167889

Rubber stamped by Geoff Garen.

It broke some websites.

Source/JavaScriptCore:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::hadDeletedOffset): Deleted.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::pinAndPreventTransitions): Deleted.
* runtime/Structure.h:
* runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::propertyTable):
(JSC::Structure::checkOffsetConsistency):
(JSC::Structure::hadDeletedOffsets): Deleted.
* tests/stress/for-in-after-delete.js:
(foo): Deleted.

LayoutTests:
* js/regress/delete-a-few-properties-then-get-by-id-expected.txt:
* js/regress/delete-a-few-properties-then-get-by-id.html:
* js/regress/script-tests/delete-a-few-properties-then-get-by-id.js:
(MyObject): Deleted.
(foo): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove the WebKitLegacy header check to the right file
andersca@apple.com [Tue, 6 May 2014 19:14:19 +0000 (19:14 +0000)]
Move the WebKitLegacy header check to the right file
https://bugs.webkit.org/show_bug.cgi?id=132620
<rdar://problem/16815716>

Reviewed by Dan Bernstein.

* WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:
* WebKitLegacy/WebKit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for debug after r168367.
achristensen@apple.com [Tue, 6 May 2014 18:32:31 +0000 (18:32 +0000)]
Unreviewed build fix for debug after r168367.

* platform/NotImplemented.cpp:
Added include NotImplemented.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved unnecessary notImplemented.h includes.
enrica@apple.com [Tue, 6 May 2014 18:30:18 +0000 (18:30 +0000)]
Removed unnecessary notImplemented.h includes.
https://bugs.webkit.org/show_bug.cgi?id=132587

Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-06
Reviewed by Anders Carlsson.

* Modules/webdatabase/Database.cpp:
* accessibility/AccessibilityObject.cpp:
* bindings/js/Dictionary.h:
* bindings/js/SerializedScriptValue.cpp:
* html/HTMLMediaSession.cpp:
* html/ImageDocument.cpp:
* html/parser/HTMLFormattingElementList.cpp:
* loader/appcache/ApplicationCacheStorage.cpp:
* page/mac/EventHandlerMac.mm:
* platform/NotImplemented.cpp:
* platform/audio/ios/MediaSessionManagerIOS.mm:
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
* platform/ios/PlatformScreenIOS.mm:
* platform/mac/PlatformScreenMac.mm:
* platform/mac/WidgetMac.mm:
* platform/mediastream/MediaStreamTrackPrivate.cpp:
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
* platform/mediastream/mac/AVMediaCaptureSource.mm:
* rendering/RenderGrid.cpp:
* workers/SharedWorkerGlobalScope.cpp:
* workers/WorkerGlobalScope.cpp:
* workers/WorkerMessagingProxy.cpp:
Removed notImplemented from list of includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed GTK gardening
commit-queue@webkit.org [Tue, 6 May 2014 18:30:07 +0000 (18:30 +0000)]
[GTK] Unreviewed GTK gardening

Rebaseline affected tests by the modifications done to
inline SVG sizing behavior introduced on r168350.

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-05-06

* platform/gtk/svg/custom/bug45331-expected.txt:
* platform/gtk/svg/custom/external-paintserver-reference-expected.txt:
* platform/gtk/svg/custom/junk-data-expected.txt:
* platform/gtk/svg/custom/linking-base-external-reference-expected.txt:
* platform/gtk/svg/custom/missing-xlink-expected.txt:
* platform/gtk/svg/custom/path-bad-data-expected.txt:
* platform/gtk/svg/custom/use-font-face-crash-expected.txt:
* platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
* platform/gtk/svg/hixie/error/012-expected.txt:
* platform/gtk/svg/in-html/circle-expected.txt:
* platform/gtk/svg/transforms/animated-path-inside-transformed-html-expected.txt:
* platform/gtk/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/gtk/svg/wicd/rightsizing-grid-expected.txt:
* platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
* platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPut WebKitPluginHost.app in WebKitLegacy.framework
andersca@apple.com [Tue, 6 May 2014 18:16:40 +0000 (18:16 +0000)]
Put WebKitPluginHost.app in WebKitLegacy.framework
https://bugs.webkit.org/show_bug.cgi?id=132592
<rdar://problem/15920046>

Reviewed by Dan Bernstein.

Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved unnecessary notImplemented.h includes.
commit-queue@webkit.org [Tue, 6 May 2014 18:04:53 +0000 (18:04 +0000)]
Removed unnecessary notImplemented.h includes.
https://bugs.webkit.org/show_bug.cgi?id=132587

Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-06
Reviewed by Anders Carlsson.

Source/WebCore:
* Modules/webdatabase/Database.cpp:
* accessibility/AccessibilityObject.cpp:
* bindings/js/Dictionary.h:
* bindings/js/SerializedScriptValue.cpp:
* html/HTMLMediaSession.cpp:
* html/ImageDocument.cpp:
* html/parser/HTMLFormattingElementList.cpp:
* loader/appcache/ApplicationCacheStorage.cpp:
* page/mac/EventHandlerMac.mm:
* platform/NotImplemented.cpp:
* platform/audio/ios/MediaSessionManagerIOS.mm:
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
* platform/ios/PlatformScreenIOS.mm:
* platform/mac/PlatformScreenMac.mm:
* platform/mac/WidgetMac.mm:
* platform/mediastream/MediaStreamTrackPrivate.cpp:
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
* platform/mediastream/mac/AVMediaCaptureSource.mm:
* rendering/RenderGrid.cpp:
* workers/SharedWorkerGlobalScope.cpp:
* workers/WorkerGlobalScope.cpp:
* workers/WorkerMessagingProxy.cpp:
Removed notImplemented from list of includes.

Source/WebKit2:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/mac/WebContextMenuProxyMac.mm:
* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
Removed notImplemented from list of includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after http://trac.webkit.org/changeset/168364
enrica@apple.com [Tue, 6 May 2014 17:58:13 +0000 (17:58 +0000)]
Unreviewed build fix after trac.webkit.org/changeset/168364

* rendering/RenderLineBreak.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[HTML] Default argument to HTMLTableSectionElement.insertRow() should be -1
ch.dumez@samsung.com [Tue, 6 May 2014 17:54:40 +0000 (17:54 +0000)]
[HTML] Default argument to HTMLTableSectionElement.insertRow() should be -1
https://bugs.webkit.org/show_bug.cgi?id=132570

Reviewed by Darin Adler.

Source/WebCore:
HTMLTableSectionElement.insertRow()'s argument default value should be -1, not
0, as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tbody-element

The new behavior matches the one of Firefox 29 and IE11, and soon Blink:
https://code.google.com/p/chromium/issues/detail?id=369803

Test: fast/dom/HTMLTableSectionElement/insertRow-default-argument.html

* html/HTMLTableSectionElement.h:
* html/HTMLTableSectionElement.idl:

LayoutTests:
Add layout test to test that the default argument to
HTMLTableSectionElement.insertRow() is -1.

* fast/dom/HTMLTableSectionElement/insertRow-default-argument-expected.txt: Added.
* fast/dom/HTMLTableSectionElement/insertRow-default-argument.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r155957): Selection rects are incorrect when the selection contains BR...
enrica@apple.com [Tue, 6 May 2014 17:49:51 +0000 (17:49 +0000)]
REGRESSION(r155957): Selection rects are incorrect when the selection contains BR elements.
https://bugs.webkit.org/show_bug.cgi?id=132596
<rdar://problem/16692206>

Reviewed by Antti Koivisto.

This patch adds an implementation of collectSelectionRects to RenderLineBreak.
It uses the same logic used by RenderText to compute and annotate the returned rect
which is computed, like the caret rect, using information from the rootline box.

* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionRects):
* rendering/RenderLineBreak.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Optimize the number of regions invalidations
abucur@adobe.com [Tue, 6 May 2014 17:30:40 +0000 (17:30 +0000)]
[CSS Regions] Optimize the number of regions invalidations
https://bugs.webkit.org/show_bug.cgi?id=132611

Reviewed by David Hyatt.

Source/WebCore:
It is possible to invalidate the region chain of a flow thread
during the layout of the region when its height is not final.

This patch places the check after the height of the region
is determined, reducing the number of invalidations.

Tests: Less invalidations and repaints in the repaint tests for
the flow threads.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::updateLogicalHeight):
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::invalidateRegionIfNeeded):
* rendering/RenderNamedFlowFragment.h:

LayoutTests:
Because there are less region invalidations there are less repaints
of the flow threads.

* fast/regions/repaint/repaint-regions-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Extended Background] Respect repeat-x/repeat-y when creating margin tiles
weinig@apple.com [Tue, 6 May 2014 16:44:41 +0000 (16:44 +0000)]
[Extended Background] Respect repeat-x/repeat-y when creating margin tiles
https://bugs.webkit.org/show_bug.cgi?id=132534

Reviewed by Beth Dakin.

If the background image that is causing margin tiles only repeats in dimension only create
the tiles in that dimension.

* page/FrameView.cpp:
(WebCore::FrameView::updateExtendBackgroundIfNecessary):
(WebCore::FrameView::calculateExtendedBackgroundMode):
(WebCore::FrameView::updateTilesForExtendedBackgroundMode):
(WebCore::FrameView::setBackgroundExtendsBeyondPage): Deleted.
(WebCore::FrameView::needsExtendedBackgroundRectForPainting): Deleted.
(WebCore::FrameView::setHasExtendedBackgroundRectForPainting): Deleted.
* page/FrameView.h:
* page/Settings.cpp:
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::hasHorizontalMargins):
(WebCore::TileController::hasVerticalMargins):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
* rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix iOS build.
darin@apple.com [Tue, 6 May 2014 16:19:22 +0000 (16:19 +0000)]
Try to fix iOS build.

* DumpRenderTree/mac/TestRunnerMac.mm:
(-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
Updated since I changed testRunner into a pointer instead of a reference.
Updated argument names to avoid conflict with field names.
(-[APITestDelegateIPhone run]): Ditto.
(-[APITestDelegateIPhone _cleanUp]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: VoiceOver does not announce text changes for content editable regions in Safari
cfleizach@apple.com [Tue, 6 May 2014 16:17:19 +0000 (16:17 +0000)]
AX: VoiceOver does not announce text changes for content editable regions in Safari
https://bugs.webkit.org/show_bug.cgi?id=132577

Reviewed by Mario Sanchez Prada.

Source/WebCore:
When text or children are changed inside of a contenteditable region, we need to
convert those actions into AXValueChange notifications.

Test: accessibility/content-editable-set-inner-text-generates-axvalue-notification.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::hasContentEditableAttributeSet): Deleted.
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasContentEditableAttributeSet):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textChanged):

LayoutTests:
* accessibility/content-editable-set-inner-text-generates-axvalue-notification-expected.txt: Added.
* accessibility/content-editable-set-inner-text-generates-axvalue-notification.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Fix two more AdoptCF I missed in my last patch.
darin@apple.com [Tue, 6 May 2014 14:14:49 +0000 (14:14 +0000)]
[iOS] Fix two more AdoptCF I missed in my last patch.

* WebView/WebHTMLView.mm:
(imageFromRect): Use adoptCF instead of AdoptCF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SVG2] Share "on"- event attributes with HTMLElement
krit@webkit.org [Tue, 6 May 2014 14:04:13 +0000 (14:04 +0000)]
[SVG2] Share "on"- event attributes with HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=132604

Reviewed by Mihnea Ovidenie.

Source/WebCore:
Share "on" event attribute parsing between SVGElement and HTMLElement.

Tests: fast/dom/script-tests/event-attribute-availability.js:

* html/HTMLElement.cpp:
(WebCore::HTMLElement::populateEventNameForAttributeLocalNameMap):
(WebCore::populateEventNameForAttributeLocalNameMap): Deleted.
* html/HTMLElement.h: Make populateEventNameForAttributeLocalNameMap
    public for use in SVGElement.
* svg/SVGElement.cpp: Use HTMLElement code to parse "on" event
    attributes.
(WebCore::SVGElement::parseAttribute):

LayoutTests:
Test that the "on" event attributes supported by HTMLElement are
supported by SVGElement as well.

* fast/dom/event-attribute-availability-expected.txt:
* fast/dom/script-tests/event-attribute-availability.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r168304.
commit-queue@webkit.org [Tue, 6 May 2014 13:34:58 +0000 (13:34 +0000)]
Unreviewed, rolling out r168304.
https://bugs.webkit.org/show_bug.cgi?id=132607

Broke the build (Requested by KaL on #webkit).

Reverted changeset:

"[GTK][CMake] Unable to do make install"
https://bugs.webkit.org/show_bug.cgi?id=130188
http://trac.webkit.org/changeset/168304

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Blending] Rename all the tests css3/compositing to css3/blending
commit-queue@webkit.org [Tue, 6 May 2014 13:17:26 +0000 (13:17 +0000)]
[CSS Blending] Rename all the tests css3/compositing to css3/blending
https://bugs.webkit.org/show_bug.cgi?id=132606

Patch by Ion Rosca <rosca@adobe.com> on 2014-05-06
Reviewed by Andrei Bucur.

* css3/blending: Renamed from LayoutTests/css3/compositing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInsp...
stavila@adobe.com [Tue, 6 May 2014 12:37:52 +0000 (12:37 +0000)]
Web Inspector: [CSS Regions] Add the regionOversetChange event to the iOS 7.0 WebInspector UI
https://bugs.webkit.org/show_bug.cgi?id=132566

Reviewed by Antti Koivisto.

The regionOversetChange event was missing from the iOS7 WebInspector.

* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Blending] Rename layout tests css3/compositing to css3/blending
commit-queue@webkit.org [Tue, 6 May 2014 12:16:58 +0000 (12:16 +0000)]
[CSS Blending] Rename layout tests css3/compositing to css3/blending
https://bugs.webkit.org/show_bug.cgi?id=132578

Patch by Ion Rosca <rosca@adobe.com> on 2014-05-06
Reviewed by Andrei Bucur.

* css3/blending: Renamed from css3/compositing.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-sim/css3/blending: Renamed from platform/ios-sim/css3/compositing
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/mac/css3/blending: Renamed from platform/mac/css3/compositing.
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThere is no HW_AVAILCPU on FreeBSD, NetBSD, and OpenBSD
berto@igalia.com [Tue, 6 May 2014 10:58:05 +0000 (10:58 +0000)]
There is no HW_AVAILCPU on FreeBSD, NetBSD, and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=132542

Reviewed by Michael Saboff.

Use sysconf() to get the number of processor cores.

* wtf/NumberOfCores.cpp:
(WTF::numberOfProcessorCores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShare mac/editing/spelling/delete-into-misspelled-word.html with other platforms
g.czajkowski@samsung.com [Tue, 6 May 2014 06:54:23 +0000 (06:54 +0000)]
Share mac/editing/spelling/delete-into-misspelled-word.html with other platforms
https://bugs.webkit.org/show_bug.cgi?id=132561

Reviewed by Darin Adler.

This test does not use Mac specific features and
can be run by other platforms as well.

Due to bug 125689, this test starts using asynchronous spellchecking.

* editing/spelling/delete-into-misspelled-word-expected.txt:
Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt
* editing/spelling/delete-into-misspelled-word.html:
Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-misspelled-word.html

* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Mark delete-into-misspelled-word.html as failing since those
platforms didn't turn on asynchronous spellchecking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle
zandobersek@gmail.com [Tue, 6 May 2014 06:19:50 +0000 (06:19 +0000)]
[Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=132559

Reviewed by Carlos Garcia Campos.

Manage the read buffer array through a std::unique_ptr<char[]> object.
This avoids handling with the raw pointer and also ensures that the memory
allocated with the new[] operator is deleted with the delete[] operator,
a problem exposed by the AddressSanitizer in WebSocket tests.

* platform/network/soup/SocketStreamHandle.h:
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdapt inline SVG sizing behavior to Firefox and Blink
krit@webkit.org [Tue, 6 May 2014 06:06:28 +0000 (06:06 +0000)]
Adapt inline SVG sizing behavior to Firefox and Blink
https://bugs.webkit.org/show_bug.cgi?id=132569

Reviewed by Dean Jackson.

Source/WebCore:
This patch is ported from Blink CR 308992. Thanks to David Vest for helping
with back porting his Blink patch. From the commit message:

"The basis of this change is to map explicit width and height
attributes to CSS properties, essentially promoting them to
presentation attributes. Note that implicit "100%" width and height
are not mapped.

This enables us to remove the concept of "percentage intrinsic size"
and rely on normal CSS rules to resolve percentage values.

The change has been approved by the SVG WG and the spec is being
updated. Minutes here:

http://www.w3.org/2014/04/07-svg-minutes.html#item03"

The new model was indeed approved by the SVG WG and is basically following
the CSS 2.1 model for replaced elements.

With this patch WebKit, Firefox and Blink have the same behavior for inline SVG.
This is the first successful approach to unify the sizing behavior of SVG
across UAs.

Tests: svg/as-object/sizing/svg-in-object-placeholder-height-auto.html
       svg/as-object/sizing/svg-in-object-placeholder-height-fixed.html
       svg/as-object/sizing/svg-in-object-placeholder-height-percentage.html
       svg/in-html/sizing/svg-inline.html

* css/svg.css: Root SVG elements still need to be sized with height: 100% and
    width: 100%. This is necessary since width and height are presentation
    attributes now.
(svg:root):
* rendering/RenderBox.h:
(WebCore::RenderBox::computeIntrinsicRatioInformation): Remove all special
    behavior for intrinsic and percentage based sizes in SVG. This simplifies and
    unifies the code a lot. Most of the logic that is used is in RenderBox and
    RenderReplaced now. RenderSVGRoot was cleaned up a lot and is much lighter.
    And so it SVGSVGElement.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeIntrinsicRatioInformation):
* rendering/RenderImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
* rendering/RenderReplaced.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::hasRelativeDimensions):
(WebCore::RenderSVGRoot::hasRelativeIntrinsicLogicalWidth): Deleted.
(WebCore::RenderSVGRoot::hasRelativeLogicalHeight): Deleted.
* rendering/svg/RenderSVGRoot.h:
* svg/SVGElement.h:
(WebCore::SVGElement::invalidateSVGPresentationAttributeStyle):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::isPresentationAttribute):
(WebCore::SVGSVGElement::collectStyleForPresentationAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged):
(WebCore::SVGSVGElement::currentViewportSize):
(WebCore::SVGSVGElement::hasIntrinsicWidth):
(WebCore::SVGSVGElement::hasIntrinsicHeight):
(WebCore::SVGSVGElement::intrinsicWidth):
(WebCore::SVGSVGElement::intrinsicHeight):
(WebCore::SVGSVGElement::widthAttributeEstablishesViewport): Deleted.
(WebCore::SVGSVGElement::heightAttributeEstablishesViewport): Deleted.
* svg/SVGSVGElement.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::containerSize):
* xml/XMLErrors.cpp: If an error occurs in a stand alone SVG file, we create
    an XHTML document with the error message and append the SVG file.
    This SVG file now follows the CSS sizing behavior as inline SVG.
    Therefore, we need to set width and height to 100% explicitly.
(WebCore::XMLErrors::insertErrorMessageBlock):

LayoutTests:
The new sizing behavior for inline SVG causes different DRT outputs for about 40 test cases.
This is expected but for most tests an improvement since the SVGs fit into the documents
and scrollbars disappear or the general size gets smaller.
Some tests needed to be updated. The size was either not set at all or not properly.

svg-in-object.js and svg-inline.js contain dozens of new tests to check the correct sizing
behavior.

The tests were written by David Vest from Opera as part of CR 308992.

Many of the -expected updates are caused by SVG size changes in turn
affecting where line breaks are inserted.

* TestExpectations:
* accessibility/svg-image-expected.txt:
* css3/flexbox/flexitem.html:
* fast/css/infinite-floating-value-expected.txt:
* fast/css/remove-fixed-resizer-crash-expected.txt:
* fast/css3-text/css3-word-spacing-percentage/word-spacing-crash-expected.txt:
* fast/repaint/moving-shadow-on-container.html:
* fast/repaint/moving-shadow-on-path.html:
* fast/repaint/svg-layout-root-style-attr-update.html:
* fast/shapes/shape-outside-floats/shape-outside-relative-size-svg-expected.html:
* fast/shapes/shape-outside-floats/shape-outside-relative-size-svg.html:
* http/tests/xmlviewer/dumpAsText/svg-expected.txt:
* platform/mac/svg/batik/filters/feTile-expected.txt:
* platform/mac/svg/batik/masking/maskRegions-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/mac/svg/batik/text/longTextOnPath-expected.txt:
* platform/mac/svg/batik/text/textDecoration-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textLength-expected.txt:
* platform/mac/svg/batik/text/textOnPath-expected.txt:
* platform/mac/svg/batik/text/textPosition-expected.txt:
* platform/mac/svg/batik/text/verticalText-expected.txt:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/mac/svg/custom/bug45331-expected.txt:
* platform/mac/svg/custom/junk-data-expected.txt:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
* platform/mac/svg/custom/path-bad-data-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/custom/use-font-face-crash-expected.txt:
* platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt:
* platform/mac/svg/hixie/error/012-expected.txt:
* platform/mac/svg/hixie/intrinsic/001-expected.png: Removed.
* platform/mac/svg/hixie/intrinsic/001-expected.txt: Removed.
* platform/mac/svg/hixie/intrinsic/002-expected.png: Removed.
* platform/mac/svg/hixie/intrinsic/002-expected.txt: Removed.
* platform/mac/svg/in-html/circle-expected.txt:
* platform/mac/svg/text/non-bmp-positioning-lists-expected.txt:
* platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/mac/svg/wicd/rightsizing-grid-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-zoom-coords-expected.txt:
* platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
* svg/animations/animate-css-xml-attributeType-expected.txt:
* svg/as-image/image-respects-deviceScaleFactor.html:
* svg/as-image/image-respects-pageScaleFactor.html:
* svg/as-image/svg-as-image-with-relative-size-expected.html:
* svg/as-image/svg-as-relative-image.html:
* svg/as-object/sizing/svg-in-object-placeholder-height-auto-expected.txt: Added.
* svg/as-object/sizing/svg-in-object-placeholder-height-auto.html: Added.
* svg/as-object/sizing/svg-in-object-placeholder-height-fixed-expected.txt: Added.
* svg/as-object/sizing/svg-in-object-placeholder-height-fixed.html: Added.
* svg/as-object/sizing/svg-in-object-placeholder-height-percentage-expected.txt: Added.
* svg/as-object/sizing/svg-in-object-placeholder-height-percentage.html: Added.
* svg/as-object/sizing/svg-in-object.js: Added.
(.):
(.addAttr):
(.generateSVGURI):
(buildDemo):
(.doCombinationTestRecursive):
(doCombinationTest):
(debugHint):
(.debugHint):
(testSVGInObjectWithPlaceholderHeightAttr.):
(testSVGInObjectWithPlaceholderHeightAttr):
* svg/css/composite-shadow-example.html:
* svg/css/composite-shadow-with-opacity.html:
* svg/css/max-width-2.html:
* svg/css/stars-with-shadow.html:
* svg/custom/absolute-sized-content-with-resources.xhtml:
* svg/custom/altglyph.svg:
* svg/custom/document-all-includes-svg-expected.txt:
* svg/custom/external-paintserver-reference-expected.txt:
* svg/custom/external-paintserver-reference.svg:
* svg/custom/get-text-element-transform-crash-expected.txt:
* svg/custom/linking-base-external-reference-expected.txt:
* svg/custom/linking-base-external-reference.xhtml:
* svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
* svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Removed.
* svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
* svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Removed.
* svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Removed.
* svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
* svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Removed.
* svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
* svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Removed.
* svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
* svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Removed.
* svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
* svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Removed.
* svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
* svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Removed.
* svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Removed.
* svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
* svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Removed.
* svg/custom/pending-resource-after-removal.xhtml:
* svg/custom/percentage-of-html-parent.xhtml:
* svg/custom/relative-sized-content-with-resources.xhtml:
* svg/custom/relative-sized-content.xhtml:
* svg/custom/relative-sized-deep-shadow-tree-content.xhtml:
* svg/custom/relative-sized-image.xhtml:
* svg/custom/relative-sized-inner-svg.xhtml:
* svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
* svg/custom/relative-sized-shadow-tree-content.xhtml:
* svg/custom/relative-sized-use-on-symbol.xhtml:
* svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml:
* svg/custom/tref-with-progress-tag-setpseudo-assert-expected.txt:
* svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt:
* svg/custom/use-invalid-html-expected.txt:
* svg/custom/window-named-item-lookup-expected.txt:
* svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt:
* svg/dom/parent-view-layout-crash-expected.txt:
* svg/dom/stylesheet-candidate-node-crash-main-expected.txt:
* svg/dom/svg-root-lengths.html:
* svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt:
* svg/hixie/intrinsic/001-expected.png: Removed.
* svg/hixie/intrinsic/001-expected.txt: Removed.
* svg/hixie/intrinsic/001.html: Removed.
* svg/hixie/intrinsic/002-expected.png: Removed.
* svg/hixie/intrinsic/002-expected.txt: Removed.
* svg/hixie/intrinsic/002.html: Removed.
* svg/hixie/intrinsic/resources/001.svg: Removed.
* svg/hixie/intrinsic/resources/002.svg: Removed.
* svg/in-html/sizing/svg-inline-expected.txt: Added.
* svg/in-html/sizing/svg-inline.html: Added.
* svg/in-html/sizing/svg-inline.js: Added.
(.):
(setupSVGElement):
(buildDemo):
(.doCombinationTestRecursive):
(doCombinationTest):
(debugHint):
(.debugHint):
* svg/path-arc-invalid-expected.txt:
* svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
* svg/text/append-text-node-to-tspan.html:
* svg/text/kerning.svg:
* svg/text/modify-text-node-in-tspan.html:
* svg/text/multichar-glyph.svg:
* svg/text/remove-text-node-from-tspan.html:
* svg/text/remove-tspan-from-text.html:
* svg/text/svg-rtl-text-crash-expected.txt:
* svg/text/text-block-child-crash-expected.txt:
* svg/transforms/animated-path-inside-transformed-html.xhtml:
* svg/transforms/svg-css-transforms-clip-path.xhtml:
* svg/transforms/transform-origin-css-property.xhtml:
* svg/zoom/page/zoom-foreignObject.svg:
* svg/zoom/page/zoom-svg-as-relative-image.html:
* svg/zoom/text/zoom-foreignObject.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Blending] Add tests using blending and isolation for body and html elements.
commit-queue@webkit.org [Tue, 6 May 2014 06:04:28 +0000 (06:04 +0000)]
[CSS Blending] Add tests using blending and isolation for body and html elements.
https://bugs.webkit.org/show_bug.cgi?id=132325

Patch by Ion Rosca <rosca@adobe.com> on 2014-05-05
Reviewed by Dirk Schulze.

* css3/compositing/blend-mode-body-child-background-color-expected.html: Added.
* css3/compositing/blend-mode-body-child-background-color.html: Added.
* css3/compositing/blend-mode-body-child-expected.html: Added.
* css3/compositing/blend-mode-body-child-isolate-background-color-expected.html: Added.
* css3/compositing/blend-mode-body-child-isolate-background-color.html: Added.
* css3/compositing/blend-mode-body-child-isolate-html-background-color-expected.html: Added.
* css3/compositing/blend-mode-body-child-isolate-html-background-color.html: Added.
* css3/compositing/blend-mode-body-child.html: Added.
* css3/compositing/blend-mode-body-element-expected.html: Added.
* css3/compositing/blend-mode-body-element.html: Added.
* css3/compositing/blend-mode-html-element-screen-expected.html: Added.
* css3/compositing/blend-mode-html-element-screen.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRetainPtr: Use adoptCF function instead of AdoptCF constructor argument
darin@apple.com [Tue, 6 May 2014 03:12:54 +0000 (03:12 +0000)]
RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
https://bugs.webkit.org/show_bug.cgi?id=80222

Reviewed by Alexey Proskuryakov.

Source/WTF:
All the clients are gone, so we can now remove AdoptCF and AdoptNS.

* wtf/RetainPtr.h: Removed the public constructors that let you specify AdoptCF
and AdoptNS. Instead, made the adoptCF and adoptNS functions be friends and use
a private constructor that takes an Adopt argument.
(WTF::adoptCF): Moved the Objective-C class check in here.
(WTF::adoptNS): Moved the code to deal with the CFRetain for garbage collection
in here; it used to be spread across the constructor and adoptNSReference.

Tools:
* DumpRenderTree/mac/TestRunnerMac.mm:
(-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
do more work here so we don't use RetainPtr local variables.
(-[APITestDelegateIPhone dealloc]): Added.
(-[APITestDelegateIPhone run]): Added an early exit if the web view is already
created. Updated for changes to member names and types.
(-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
updated for changes to member names and types. Changed to two word spelling.
(-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
name of _cleanUp method.
(-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
Ditto.
(-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r168334.
akling@apple.com [Tue, 6 May 2014 02:54:26 +0000 (02:54 +0000)]
Unreviewed, rolling out r168334.

Broke builds.

Reverted changeset:

"Put WebKitPluginHost.app in WebKitLegacy.framework"
https://bugs.webkit.org/show_bug.cgi?id=132592
http://trac.webkit.org/changeset/168334

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=132593
dino@apple.com [Tue, 6 May 2014 02:49:41 +0000 (02:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=132593

Update WebKitSystemInterface to allow animated focus rings.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceMavericks.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] REGRESSION(167145): JavaScript media controls are broken
ryuan.choi@samsung.com [Tue, 6 May 2014 02:08:38 +0000 (02:08 +0000)]
[EFL] REGRESSION(167145): JavaScript media controls are broken
https://bugs.webkit.org/show_bug.cgi?id=131573

Reviewed by Brent Fulgham.

* PlatformEfl.cmake: Add the localized strings file to the list of user agent scripts.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::mediaControlsScript): Include the localized strings file in the script body.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement scan backward and forward in video fullscreen.
commit-queue@webkit.org [Tue, 6 May 2014 01:49:29 +0000 (01:49 +0000)]
Implement scan backward and forward in video fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=132517

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-05
Reviewed by Simon Fraser.

Source/WebCore:
Implement scanning forward and backward. This implements methods in
WebAVPlayerController and forwards them through WebVideoFullscreenModelMediaElement
and on to HTMLMediaElement.

* WebCore.exp.in: necessary exports.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController seekToTime:]):
Use fastSeek in this case.
(-[WebAVPlayerController canScanForward]): If you can play, you can scan.
(+[WebAVPlayerController keyPathsForValuesAffectingCanScanForward]): ditto
(-[WebAVPlayerController beginScanningForward:]): ditto
(-[WebAVPlayerController endScanningForward:]): ditto
(-[WebAVPlayerController canScanBackward]): If you can play, you can scan.
(+[WebAVPlayerController keyPathsForValuesAffectingCanScanBackward]): ditto
(-[WebAVPlayerController beginScanningBackward:]): ditto
(-[WebAVPlayerController endScanningBackward:]): ditto
(-[WebAVPlayerController canSeekToBeginning]):
This looks at seekableRanges to determine if any seeking is possible.
(+[WebAVPlayerController keyPathsForValuesAffectingCanSeekToBeginning]):
depends on seekableRanges.
(-[WebAVPlayerController seekToBeginning:]): seek to -ininity
(-[WebAVPlayerController canSeekToEnd]):
This looks at seekableRanges to determine if any seeking is possible.
(+[WebAVPlayerController keyPathsForValuesAffectingCanSeekToEnd]):
depends on seekableRanges.
(-[WebAVPlayerController seekToEnd:]): seek to INFINITY.
* platform/ios/WebVideoFullscreenModel.h:
Add 4 new functions.
* platform/ios/WebVideoFullscreenModelMediaElement.h:
ditto
* platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::fastSeek): forwards to HTMLMediaEelement
(WebVideoFullscreenModelMediaElement::beginScanningForward): forwards to HTMLMediaEelement
(WebVideoFullscreenModelMediaElement::beginScanningBackward): forwards to HTMLMediaEelement
(WebVideoFullscreenModelMediaElement::endScanning): forwards to HTMLMediaEelement

Source/WebKit2:
Plumb through scanning/seeking functions.

* UIProcess/ios/WebVideoFullscreenManagerProxy.h:
* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::fastSeek):
(WebKit::WebVideoFullscreenManagerProxy::beginScanningForward):
(WebKit::WebVideoFullscreenManagerProxy::beginScanningBackward):
(WebKit::WebVideoFullscreenManagerProxy::endScanning):
* WebProcess/ios/WebVideoFullscreenManager.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix debug build.
akling@apple.com [Tue, 6 May 2014 01:22:02 +0000 (01:22 +0000)]
Fix debug build.

* runtime/JSCellInlines.h:
(JSC::JSCell::fastGetOwnProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][WK2] Prefetch DNS hostnames on tap highlight
benjamin@webkit.org [Tue, 6 May 2014 01:14:02 +0000 (01:14 +0000)]
[iOS][WK2] Prefetch DNS hostnames on tap highlight
https://bugs.webkit.org/show_bug.cgi?id=132509

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-05
Reviewed by Alexey Proskuryakov.

Source/WebCore:
* WebCore.exp.in:
* dom/Element.cpp:
* dom/Element.h:
(WebCore::Element::absoluteLinkURL()):

Source/WebKit2:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::tapHighlightAtPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS WK2] Flickery scrolling inside overflow-scrolling: touch
simon.fraser@apple.com [Tue, 6 May 2014 01:10:30 +0000 (01:10 +0000)]
[iOS WK2] Flickery scrolling inside overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=132591
<rdar://problem/16760466>

Reviewed by Tim Horton.

Source/WebCore:

Avoid triggering layer tree commits that touch the layer's boundsOrigin
while the user is scrolling in the UI process.

Fix the WKOverflowScrollViewDelegate to pass along an "inUserInteration"
flag to the ScrollingTree to say that we're in the middle of a user interaction
(and also to send a final non-interactive update). That gets passed along
to the web process, and turned into "SyncScrollingLayerPosition" update.
AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll() consults
this, and uses it to set a flag on the ScrollableArea to say that the scroll
is a user scroll.

RenderLayerBacking then makes use of this (in existing code, shared with WK1)
to avoid triggering layer bounds setting. Instead, it now just calls syncBoundsOrigin(),
which updates the GraphicsLayer without touching platform layers. This is necessary
so that GraphicsLayer geometry is up-to-date (used for tiled layer visibility
computations).

Finally, a hack in GraphicsLayerCA::computeVisibleRect() is conditionalized
for WebKit1 by checking the type of platform layer.

* WebCore.exp.in:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):
* page/scrolling/ScrollingTree.h:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::syncBoundsOrigin):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleRect):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit2:

Avoid triggering layer tree commits that touch the layer's boundsOrigin
while the user is scrolling in the UI process.

Fix the WKOverflowScrollViewDelegate to pass along an "inUserInteration"
flag to the ScrollingTree to say that we're in the middle of a user interaction
(and also to send a final non-interactive update). That gets passed along
to the web process, and turned into "SyncScrollingLayerPosition" update.
AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll() consults
this, and uses it to set a flag on the ScrollableArea to say that the scroll
is a user scroll.

RenderLayerBacking then makes use of this (in existing code, shared with WK1)
to avoid triggering layer bounds setting. Instead, it now just calls syncBoundsOrigin(),
which updates the GraphicsLayer without touching platform layers. This is necessary
so that GraphicsLayer geometry is up-to-date (used for tiled layer visibility
computations).

Finally, a hack in GraphicsLayerCA::computeVisibleRect() is conditionalized
for WebKit1 by checking the type of platform layer.

* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::rootScrollingNodeID):
(WebKit::RemoteScrollingCoordinatorProxy::isPointInNonFastScrollableRegion):
(WebKit::RemoteScrollingCoordinatorProxy::viewportChangedViaDelegatedScrolling):
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll):
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
* UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::scrollingTreeNodeDidScroll):
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(-[WKOverflowScrollViewDelegate scrollViewDidScroll:]):
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]):
(-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):
* WebProcess/Scrolling/RemoteScrollingCoordinator.h:
* WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in:
* WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark http/tests/media/hls/video-controls-live-stream.html as WontFix on Mountain...
akling@apple.com [Tue, 6 May 2014 01:03:26 +0000 (01:03 +0000)]
Mark http/tests/media/hls/video-controls-live-stream.html as WontFix on Mountain Lion.
<https://webkit.org/b/132491>

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize GetByVal when subscript is a rope string.
akling@apple.com [Tue, 6 May 2014 00:53:29 +0000 (00:53 +0000)]
Optimize GetByVal when subscript is a rope string.
<https://webkit.org/b/132590>

Use JSString::toIdentifier() in the various GetByVal implementations
to try and avoid allocating extra strings.

Added canUseFastGetOwnProperty() and wrap calls to fastGetOwnProperty()
in that, to avoid calling JSString::value() which always resolves ropes
into new strings and de-optimizes subsequent toIdentifier() calls.

My iMac says ~9% progression on Dromaeo/dom-attr.html

Reviewed by Phil Pizlo.

* dfg/DFGOperations.cpp:
* jit/JITOperations.cpp:
(JSC::getByVal):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getByVal):
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSCell::canUseFastGetOwnProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPut WebKitPluginHost.app in WebKitLegacy.framework
andersca@apple.com [Tue, 6 May 2014 00:47:33 +0000 (00:47 +0000)]
Put WebKitPluginHost.app in WebKitLegacy.framework
https://bugs.webkit.org/show_bug.cgi?id=132592
<rdar://problem/15920046>

Reviewed by Dan Bernstein.

Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop using BlobData on client side
ap@apple.com [Tue, 6 May 2014 00:42:52 +0000 (00:42 +0000)]
Stop using BlobData on client side
https://bugs.webkit.org/show_bug.cgi?id=132582

Reviewed by Sam Weinig.

Source/WebCore:
Blob registration now uses either a single file path, or a vector of much simpler
BlobPart objects, not an array with arbitrarily sliced blobs or files, which can't happen.

* Modules/websockets/WebSocket.cpp:(WebCore::WebSocket::didReceiveBinaryData):
Use a new simpler Blob constructor.

* WebCore.xcodeproj/project.pbxproj: Added BlobPart, removed BlobRegistrationData.

* bindings/js/JSBlobCustom.cpp: (WebCore::JSBlobConstructor::constructJSBlob):
Use Vector<BlobPart> instead of BlobData (1 line of code instead of 5).

* dom/DataTransfer.cpp: (WebCore::DataTransfer::hasFileOfType): Updated for
File::contentTypeFromFilePathOrName rename.

* fileapi/Blob.cpp: (WebCore::Blob::Blob):
* fileapi/Blob.h:
(WebCore::Blob::create):
(WebCore::Blob::deserialize):
* fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::contentTypeFromFilePathOrName):
(WebCore::createBlobDataForFileWithType): Deleted.
(WebCore::createBlobDataForFile): Deleted.
(WebCore::createBlobDataForFileWithName): Deleted.
(WebCore::File::contentTypeFromFilePath): Deleted.
* fileapi/File.h: (WebCore::File::deserialize): Deleted.
Added and updated constructors to not use BlobData. Changed special case constructors
to use name tags instead of non-enforced comments.

* fileapi/ThreadableBlobRegistry.h:
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext): Updated with new data members
that were split out of BlobData.
(WebCore::ThreadableBlobRegistry::registerFileBlobURL): Added.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Updated to pass Content-Type
explicitly, as it's no longer hidden in BlobData.

* fileapi/WebKitBlobBuilder.h:
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::finalize):
(WebCore::BlobBuilder::appendBytesData): Deleted.
Updated to use BlobPart. There is no longer any need to special case Files,
the registry takes care of that.

* platform/network/BlobData.h:
* platform/network/BlobData.cpp:
(WebCore::BlobDataItem::detachFromCurrentThread): Deleted.
(WebCore::BlobData::detachFromCurrentThread): Deleted.
BlobData will only be used on main thread by the registry.

* platform/network/BlobPart.h: Added. A new class to encapsulate a list of blobs
that are combined into a new blob, as exposed to JS via Blob constructor.

* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
* platform/network/BlobRegistryImpl.h:
Updated for the new registration methods. We no longer have arbitrary BlobDatas
coming in.

* platform/network/FormData.cpp: Don't include BlobData for now (but really,
BlobStorageData is the same thing, and they will be merged soon).
Unfortunately, FormData is used by both client and registry side, and there is
no clear delimitation at the time.

* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseBlob): Use the new simpler
way to create a Blob.

Source/WebKit2:
Update for WebCore changes.

* CMakeLists.txt:
* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerFileBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURL):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerFileBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Shared/FileAPI/BlobRegistrationData.cpp: Removed.
* Shared/FileAPI/BlobRegistrationData.h: Removed.
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<BlobPart>::encode):
(IPC::ArgumentCoder<BlobPart>::decode):
* Shared/WebCoreArgumentCoders.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerFileBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURL):
* WebProcess/FileAPI/BlobRegistryProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r168256): ASSERTION FAILED: (buffer + m_length) == position loading vanit...
akling@apple.com [Mon, 5 May 2014 23:39:04 +0000 (23:39 +0000)]
REGRESSION (r168256): ASSERTION FAILED: (buffer + m_length) == position loading vanityfair.com article.
<https://webkit.org/b/168256>
<rdar://problem/16816316>

Source/JavaScriptCore:
Make resolveRopeSlowCase8() behave like its 16-bit counterpart and not
clear the fibers. The caller takes care of this.

Test: fast/dom/getElementById-with-rope-string-arg.html

Reviewed by Geoffrey Garen.

* runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeSlowCase8):

LayoutTests:
Reviewed by Geoffrey Garen.

* fast/dom/getElementById-with-rope-string-arg-expected.txt: Added.
* fast/dom/getElementById-with-rope-string-arg.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up Image Document and tweak the layout and viewport
benjamin@webkit.org [Mon, 5 May 2014 23:35:38 +0000 (23:35 +0000)]
Clean up Image Document and tweak the layout and viewport
https://bugs.webkit.org/show_bug.cgi?id=132552

Source/WebCore:
Reviewed by Sam Weinig.

The #ifdef in every function was making quite a mess. A lot of that code does
not make sense on iOS.

This patch make a clean split between mouse related stuff and iOS.

Also:
-Change the viewport to be only width based, and avoid scaling in portrait.
-Center the image horizontally in the view.

* html/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::imageUpdated):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::imageFitsInWindow):
(WebCore::ImageDocument::windowSizeChanged):
(WebCore::ImageDocument::imageClicked):
* html/ImageDocument.h:

Tools:
Reviewed by Anders Carlsson.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
Update the default settings to have something consistent with WebKit2.

LayoutTests:
Reviewed by Anders Carlsson.

* svg/custom/anchor-on-use-expected.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNeed a delegate that informs the UI process when the page's pin state changes
bdakin@apple.com [Mon, 5 May 2014 23:14:43 +0000 (23:14 +0000)]
Need a delegate that informs the UI process when the page's pin state changes
https://bugs.webkit.org/show_bug.cgi?id=132583
-and corresponding-
<rdar://problem/16806231>

Reviewed by Anders Carlsson.

Source/WebCore:
We should default all of these pin-state value to true.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):

Source/WebKit2:
New UIClient function pinnedStateDidChange.

* UIProcess/API/APIUIClient.h:
(API::UIClient::pinnedStateDidChange):

Create WKPageUIClientV3 to add this function.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/C/WKPageUIClient.h:

Change default initialization to true instead of false, which makes more sense for
this API.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd SPI to provide the WebCrypto master key
andersca@apple.com [Mon, 5 May 2014 23:09:58 +0000 (23:09 +0000)]
Add SPI to provide the WebCrypto master key
https://bugs.webkit.org/show_bug.cgi?id=132586
<rdar://problem/16091460>

Reviewed by Dan Bernstein.

* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::webCryptoMasterKey):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::webCryptoMasterKey):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::wrapCryptoKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=132522
barraclough@apple.com [Mon, 5 May 2014 23:06:52 +0000 (23:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=132522
Clean up ProcessThrottler

Unreviewed: bad build fix. Will work out what the right include is asap.

* UIProcess/ios/WebProcessProxyIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNamed element cache can become invalid during HTMLCollection::updateNamedElementCache()
ch.dumez@samsung.com [Mon, 5 May 2014 22:50:33 +0000 (22:50 +0000)]
Named element cache can become invalid during HTMLCollection::updateNamedElementCache()
https://bugs.webkit.org/show_bug.cgi?id=132575

Reviewed by Ryosuke Niwa.

Source/WebCore:
Make sure the named element cache object stays valid in
HTMLCollection::updateNamedElementCache() while it is populating it.

The method was previously creating and setting the cache first, and then start
traversing the DOM tree to populate it. As a consequence, hasNamedElementCache()
would start returning true before the cache is actually populated.
The issue is that finding matches in the DOM tree can cause
HTMLCollection::invalidateCache() to be called under certain circumstances and
thus the named element cache object can become invalid while
updateNamedElementCache() is populating it.

To avoid the issue, this patch updates updateNamedElementCache() so that the
named element cache map is set *after* traversing the DOM tree. This way,
hasNamedElementCache() returns false while the cache is being populated and
there is no chance of it being invalidated too early.

Test: fast/dom/htmlcollection-selectedOptions-namedItem-crash.html

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::updateNamedElementCache):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::setNameItemCache):
(WebCore::HTMLCollection::createNameItemCache): Deleted.
* html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::updateNamedElementCache):

LayoutTests:
Add layout test to verify that HTMLCollection::updateNamedElementCache() is no longer
crashing for collections of selected options.

* fast/dom/htmlcollection-selectedOptions-namedItem-crash-expected.txt: Added.
* fast/dom/htmlcollection-selectedOptions-namedItem-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WIN] Enhance auto-version.sh to handle all-caps or mixed-case build environment...
bfulgham@apple.com [Mon, 5 May 2014 22:11:57 +0000 (22:11 +0000)]
[WIN] Enhance auto-version.sh to handle all-caps or mixed-case build environment variable
https://bugs.webkit.org/show_bug.cgi?id=132580
<rdar://problem/16811179>

Reviewed by Dean Jackson.

* win/tools/scripts/auto-version.sh: Incorporate Mark's revised syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168321 268f45cc-cd09-0410-ab3c-d52691b4dbfc