WebKit-https.git
11 years ago2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 18 May 2009 11:30:06 +0000 (11:30 +0000)]
2009-05-17  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Various autotools build refactoring and fixes
        https://bugs.webkit.org/show_bug.cgi?id=25286

        Add JavaScriptCore/ to JSC include path only since it's not
        required when building WebCore.

        * GNUmakefile.am:

2009-05-17 Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Various autotools build refactoring and fixes
        https://bugs.webkit.org/show_bug.cgi?id=25286

        Refactor library cflags

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 11:11:15 +0000 (11:11 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        Skip new tests from r43822 on Gtk
        https://bugs.webkit.org/show_bug.cgi?id=25780

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 10:55:42 +0000 (10:55 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Oliver Hunt.

        Add missing files from r43821
        https://bugs.webkit.org/show_bug.cgi?id=25780

        * editing/pasteboard/get-data-text-plain-drop-expected.txt: Added.
        * editing/pasteboard/get-data-text-plain-drop.html: Added.
        * editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
        * editing/pasteboard/get-data-text-plain-paste.html: Added.
        * editing/pasteboard/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
        * editing/pasteboard/resources/get-data-text-plain-paste.js: Added.
        (handlePaste):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 10:29:14 +0000 (10:29 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25716

        * Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 10:11:47 +0000 (10:11 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25716

        * Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
sfalken@apple.com [Mon, 18 May 2009 01:20:08 +0000 (01:20 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Kilzer.
mitz@apple.com [Mon, 18 May 2009 00:31:45 +0000 (00:31 +0000)]
    Reviewed by David Kilzer.

        - move fast/repaint/repaint.js into the resources subdirectory

        * fast/repaint/repaint.js: Removed.
        * fast/repaint/resources/repaint.js: Copied from fast/repaint/repaint.js.
        * (89 tests changed to load the script from the new location)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix for WML: constr->const
staikos@webkit.org [Sun, 17 May 2009 20:11:47 +0000 (20:11 +0000)]
Unreviewed build fix for WML: constr->const

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 20:06:05 +0000 (20:06 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        Fix done by Simon Fraser (reviewed by me).

        <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
        transitions has bad layout and overlapping garbled text when printing

        * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 19:12:55 +0000 (19:12 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
        also a type check on the selected index to avoid a bad cast to HTMLOptionElement.

        * manual-tests/select-option-in-onload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 17 May 2009 18:34:43 +0000 (18:34 +0000)]
2009-05-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Rename local variables for readability.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 17:50:02 +0000 (17:50 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        * platform/gtk/Skipped: Disable another media test that seems to be failing at least
        intermittently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 17:47:13 +0000 (17:47 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 25840: fix some warnings seen on the GTK bot
        https://bugs.webkit.org/show_bug.cgi?id=25840

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
        This is really just to quiet warnings. I think this code is unreachable.
        Someone could put ASSERT_NOT_REACHED() in here too at some point.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream): Use proper printf format for int
        here, %d, not %lu. This could cause a real problem when compiled 64-bit,
        so it's good to fix.

        * rendering/RenderTextControl.cpp:
        (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
        really just to quiet the warning, but still seems like a good idea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Chris Fleizach <cfleizach@apple.com>
darin@apple.com [Sun, 17 May 2009 16:50:21 +0000 (16:50 +0000)]
2009-05-17  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 25769: Fix accessibility warnings on GTK
        https://bugs.webkit.org/show_bug.cgi?id=25769

        * page/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
        (WebCore::AccessibilityTable::rowCount): Ditto.
        * page/AccessibilityTable.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 17 May 2009 16:47:09 +0000 (16:47 +0000)]
WebCore:

2009-05-17  Kai Brüning  <kai@granus.net>

        Reviewed by Darin Adler.

        bug 25822: DOM normalize does not remove empty text node between element nodes
        https://bugs.webkit.org/show_bug.cgi?id=25822

        Test: fast/dom/Node/normalize.html

        * dom/Node.cpp:
        (WebCore::Node::normalize): Changed to remove any empty text nodes.

LayoutTests:

2009-05-17  Kai Brüning  <kai@granus.net>

        Reviewed by Darin Adler.

        Test case for bug 25822: DOM normalize does not remove empty text node between element nodes
        https://bugs.webkit.org/show_bug.cgi?id=25822

        The test case strives to test the whole functionality of Node's normalize().

        * fast/dom/Node/normalize-expected.txt: Added.
        * fast/dom/Node/normalize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-16 Dave Moore <davemoore@google.com>
mrowe@apple.com [Sun, 17 May 2009 03:44:51 +0000 (03:44 +0000)]
2009-05-16  Dave Moore  <davemoore@google.com>

        Reviewed by Darin Adler.

        Allow Strings to be created with one malloc node with no copying
        https://bugs.webkit.org/show_bug.cgi?id=25779

        Add new methods to String and StringImpl, refactoring existing
        methods in StringImpl to use new createUninitialized() method.

        * platform/text/PlatformString.h:
        (WebCore::String::createUninitialized):
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::createUninitialized):
        (WebCore::StringImpl::create):
        * platform/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
mrowe@apple.com [Sun, 17 May 2009 03:38:38 +0000 (03:38 +0000)]
<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance

Reviewed by Darin Adler.

Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.

This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit:
andersca@apple.com [Sat, 16 May 2009 21:51:42 +0000 (21:51 +0000)]
WebKit:

2009-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig and Dan Bernstein.

        Fix <rdar://problem/6889644>.

        * English.lproj/Localizable.strings:

WebKit/mac:

2009-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig and Dan Bernstein.

        Fix <rdar://problem/6889644>

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSet the svn:mime-type property of recently-added PNG files to image/png
mitz@apple.com [Sat, 16 May 2009 20:21:49 +0000 (20:21 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - revert an accidental change from r43802.
mitz@apple.com [Sat, 16 May 2009 20:06:21 +0000 (20:06 +0000)]
    - revert an accidental change from r43802.

        * WebInspector/WebInspector.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 16 May 2009 19:58:13 +0000 (19:58 +0000)]
2009-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page

        Fix logic. The plug-in returns true if it handled the event.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendEvent:isDrawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 16 May 2009 19:56:49 +0000 (19:56 +0000)]
WebCore:

        Reviewed by Alexey Proskuryakov.

        - fix <rdar://problem/6873305> Two distinct characters are not displayed
          correctly with 2 of the font selections from the stickies widget

        Test: platform/mac/editing/pasteboard/text-precomposed.html

        Ensure that "text/plain" data retrieved from the clipboard is always
        precomposed. This makes Clipboard::getData() and
        Pasteboard::documentFragment() consistent with Pasteboard::plainText()
        and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::getData):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::documentFragment):

WebKit/mac:

        Reviewed by Alexey Proskuryakov.

        - fix <rdar://problem/6873305> Two distinct characters are not displayed
          correctly with 2 of the font selections from the stickies widget

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text.
        This is consistent with
        -_documentFragmentFromPasteboard:forType:inContext:subresources:.

LayoutTests:

        Reviewed by Alexey Proskuryakov.

        - test for <rdar://problem/6873305> Two distinct characters are not
          displayed correctly with 2 of the font selections from the stickies
          widget

        * platform/mac/editing/pasteboard/text-precomposed-expected.txt: Added.
        * platform/mac/editing/pasteboard/text-precomposed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] Merge r41819 into Gtk to log through the JS console
zecke@webkit.org [Sat, 16 May 2009 09:11:17 +0000 (09:11 +0000)]
[GTK] Merge r41819 into Gtk to log through the JS console

https://bugs.webkit.org/show_bug.cgi?id=25787

Copy over the log routine from the OSX TestNetscapePlugin to
the copy of Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html
zecke@webkit.org [Sat, 16 May 2009 09:10:57 +0000 (09:10 +0000)]
[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html

WebKitTools:
2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Jan Michael Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25787

        Forward port r39877 from main.c of OSX to TestNetscapePlugin
        of Gtk.

        * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):

LayoutTests:
2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Jan Michael Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25787

        Enable plugins/npruntime.html

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Sat, 16 May 2009 07:56:21 +0000 (07:56 +0000)]
Build fix.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily): Declare valueForFamily as static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 16 May 2009 06:57:56 +0000 (06:57 +0000)]
2009-05-15  Darin Adler  <darin@apple.com>

        Fix some failures from recent changes.

        * platform/gtk/Skipped: Added recently-added test to the "no expected results" section.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
        * svg/css/getComputedStyle-basic-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sat, 16 May 2009 06:06:29 +0000 (06:06 +0000)]
WebCore:

2009-05-15  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
        only the generic font, if any generic font is in the family list

        Test: fast/css/getComputedStyle/computed-style-font-family.html

        * css/CSSComputedStyleDeclaration.cpp:
        Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
        (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
        (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
        property as specified in the CSS standard. Fixed clip to return "auto" when there is no
        clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
        internal linkage since there was no reason for them to have external linkage.

LayoutTests:

2009-05-15  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
        only the generic font, if any generic font is in the family list

        * fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
        * fast/css/getComputedStyle/computed-style-font-family.html: Added.

        * fast/css/getComputedStyle/computed-style.html: Updated array of properties to dump
        that are not visible when iterating the computed style object. Removed pointless
        unused array of unimplemented properties.
        * fast/css/getComputedStyle/computed-style-without-renderer.html: Ditto.

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 16 May 2009 02:17:51 +0000 (02:17 +0000)]
2009-05-15  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Jan Alonzo.

        Plug memory leak.

        * webkit/webkitwebsettings.cpp:
        (free_spell_checking_language):
        (webkit_web_settings_finalize):
        (webkit_web_settings_set_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Sat, 16 May 2009 01:06:35 +0000 (01:06 +0000)]
WebCore:

2009-05-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=25741

        Append instead of throwing when insertItemBefore gets an out-of-bound
        index.

        Test: svg/dom/svglist-insertItemBefore-appends.html

        * svg/SVGList.h:
        (WebCore::SVGList::insertItemBefore):

LayoutTests:

2009-05-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=25741

        Test that insertBeforeItem behaves properly for out of bounds indices.

        * svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
        * svg/dom/svglist-exception-on-out-bounds-error.html:
        * svg/dom/svglist-insertItemBefore-appends-expected.txt: Added.
        * svg/dom/svglist-insertItemBefore-appends.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Don't parse args using getopt since it isn't available on Windows.
kevino@webkit.org [Sat, 16 May 2009 00:33:12 +0000 (00:33 +0000)]
wx build fix. Don't parse args using getopt since it isn't available on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 16 May 2009 00:31:33 +0000 (00:31 +0000)]
2009-05-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=25829

        Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.

        Test: fast/backgrounds/background-clip-text.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 16 May 2009 00:06:07 +0000 (00:06 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard
          arrows, I can't navigate caret between To Do items in a Note message

        Test: editing/selection/move-by-line-004.html

        * editing/visible_units.cpp:
        (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper
        function.
        (WebCore::previousLinePosition): When advancing to the next candidate
        node, stop when leaving the closest ancestor of the original node that
        is not an inline. The code, incorrectly, was trying to exit the closest
        ancestor of that type which was editable, and therefore missing other
        blocks in the same editable root.
        (WebCore::nextLinePosition): Ditto.

LayoutTests:

        Reviewed by Sam Weinig.

        - test for <rdar://problem/6888244> REGRESSION: Using the Up or Down
          keyboard arrows, I can't navigate caret between To Do items in a Note
          message

        * editing/selection/move-by-line-004-expected.txt: Added.
        * editing/selection/move-by-line-004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
jmalonzo@webkit.org [Fri, 15 May 2009 23:50:35 +0000 (23:50 +0000)]
2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Jan Alonzo.

        Converting filename to uri by concatenating strings is broken
        on Windows. So, don't do it for that platform.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startGio):

2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Jan Alonzo.

        Converting filename to uri by concatenating strings is broken
        on Windows. Use proper glib conversion functions.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_open):
        * tests/testdownload.c:
        (test_webkit_download_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 15 May 2009 23:49:05 +0000 (23:49 +0000)]
2009-05-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Fix <rdar://problem/6875398>.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        If we failed to instantiate the plug-in, call cleanup() so that any streams created by the plug-in from its
        NPP_New callback are destroyed.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Make cleanup() public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 15 May 2009 22:40:11 +0000 (22:40 +0000)]
2009-05-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Looking like MSVC doesn't like static variables in inline methods?
        Make the state of the SSE2 check a static variable on the class
        MacroAssemblerX86Common as a speculative build fix for Windows.

        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::convertInt32ToDouble):
        (JSC::MacroAssemblerX86Common::branchDouble):
        (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerX86Common::isSSE2Present):
        (JSC::MacroAssemblerX86Common::):
        * jit/JIT.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 15 May 2009 22:28:03 +0000 (22:28 +0000)]
2009-05-15  Gustavo Noronha Silva  <gns@gnome.org>

        Disable new tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Nate Chapin <japhet@google.com>
dglazkov@chromium.org [Fri, 15 May 2009 22:27:57 +0000 (22:27 +0000)]
2009-05-15  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
        https://bugs.webkit.org/show_bug.cgi?id=25739

        * bindings/v8/V8Collection.cpp: Added.
        (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
        * bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
        * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):  Moved from v8_custom.cpp.
        (WebCore::INDEXED_PROPERTY_SETTER):  Moved from v8_custom.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
ddkilzer@apple.com [Fri, 15 May 2009 22:22:46 +0000 (22:22 +0000)]
    <rdar://problem/6649936> Add *.exp export files to WebCore Xcode project

        Reviewed by Darin Adler and Timothy Hatcher.

        * WebCore.xcodeproj/project.pbxproj: Added Exports group, moved
        WebCore.base.exp into the group, and added 10 other *.exp files
        in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add some assembler headers to JavaScriptCore.vcproj
aroben@apple.com [Fri, 15 May 2009 22:15:04 +0000 (22:15 +0000)]
    Add some assembler headers to JavaScriptCore.vcproj

        This is just a convenience for Windows developers.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 15 May 2009 22:03:49 +0000 (22:03 +0000)]
2009-05-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25826
        Change type to only have custom getter in JCS.

        * html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 15 May 2009 21:54:28 +0000 (21:54 +0000)]
2009-05-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Kilzer.

        Add a settings entry to en/disable web font support
        https://bugs.webkit.org/show_bug.cgi?id=25239

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 15 May 2009 21:11:10 +0000 (21:11 +0000)]
2009-05-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
        API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
        FP is presently only supported on SSE2 platforms, not x87.  On platforms where a suitable
        hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
        other methods ASSERT_NOT_REACHED().

        * assembler/AbstractMacroAssembler.h:
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::MacroAssemblerX86):
        (JSC::MacroAssemblerX86::branch32):
        (JSC::MacroAssemblerX86::branchPtrWithPatch):
        (JSC::MacroAssemblerX86::supportsFloatingPoint):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::):
        (JSC::MacroAssemblerX86Common::loadDouble):
        (JSC::MacroAssemblerX86Common::storeDouble):
        (JSC::MacroAssemblerX86Common::addDouble):
        (JSC::MacroAssemblerX86Common::subDouble):
        (JSC::MacroAssemblerX86Common::mulDouble):
        (JSC::MacroAssemblerX86Common::convertInt32ToDouble):
        (JSC::MacroAssemblerX86Common::branchDouble):
        (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerX86Common::branch32):
        (JSC::MacroAssemblerX86Common::branch16):
        (JSC::MacroAssemblerX86Common::branchTest32):
        (JSC::MacroAssemblerX86Common::branchAdd32):
        (JSC::MacroAssemblerX86Common::branchMul32):
        (JSC::MacroAssemblerX86Common::branchSub32):
        (JSC::MacroAssemblerX86Common::set32):
        (JSC::MacroAssemblerX86Common::setTest32):
        (JSC::MacroAssemblerX86Common::x86Condition):
        (JSC::MacroAssemblerX86Common::isSSE2Present):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::movePtrToDouble):
        (JSC::MacroAssemblerX86_64::moveDoubleToPtr):
        (JSC::MacroAssemblerX86_64::setPtr):
        (JSC::MacroAssemblerX86_64::branchPtr):
        (JSC::MacroAssemblerX86_64::branchTestPtr):
        (JSC::MacroAssemblerX86_64::branchAddPtr):
        (JSC::MacroAssemblerX86_64::branchSubPtr):
        (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
        * assembler/X86Assembler.h:
        * jit/JIT.cpp:
        (JSC::JIT::JIT):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_rshift):
        (JSC::JIT::emitSlow_op_rshift):
        (JSC::JIT::emitSlow_op_jnless):
        (JSC::JIT::emitSlow_op_jnlesseq):
        (JSC::JIT::compileBinaryArithOp):
        (JSC::JIT::compileBinaryArithOpSlowCase):
        (JSC::JIT::emit_op_add):
        (JSC::JIT::emitSlow_op_add):
        (JSC::JIT::emit_op_mul):
        (JSC::JIT::emitSlow_op_mul):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 15 May 2009 20:43:07 +0000 (20:43 +0000)]
2009-05-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Steve Falkenburg.

        Remove dead youtube site specific hack that was commented out.

        * bindings/js/JSNavigatorCustom.cpp:
        * page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 15 May 2009 20:09:36 +0000 (20:09 +0000)]
2009-05-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
        <rdar://problem/6884742>
        REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)

        Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>

        * bindings/js/JSHTMLInputElementCustom.cpp:
        (WebCore::needsGmailQuirk):
        (WebCore::JSHTMLInputElement::type):
        * html/HTMLInputElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 15 May 2009 19:40:08 +0000 (19:40 +0000)]
2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25810
        Upstream V8 DOM Wrapper map declarations.

        No behavior change, so no tests.

        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::WeakReferenceMap): Added.
        (WebCore::WeakReferenceMap::~WeakReferenceMap): Added.
        (WebCore::WeakReferenceMap::get): Added.
        (WebCore::WeakReferenceMap::set): Added.
        (WebCore::WeakReferenceMap::forget): Added.
        (WebCore::WeakReferenceMap::contains): Added.
        (WebCore::WeakReferenceMap::impl): Added.
        (WebCore::DOMWrapperMap::DOMWrapperMap): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 May 2009 19:10:49 +0000 (19:10 +0000)]
2009-05-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=25773

        Rename GraphicsLayer::graphicsContextsFlipped() to
        GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.

        Clean up code around the GraphicsLayer "contents" layer that makes use of this
        flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
        which can then always do the flipping if necessary.

        Only affects ACCELERATED_COMPOSITING builds.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::):
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::contentsLayer):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayer::compositingCoordinatesOrientation):
        (WebCore::GraphicsLayerCA::setBackgroundColor):
        (WebCore::GraphicsLayerCA::clearBackgroundColor):
        (WebCore::GraphicsLayerCA::setContentsToImage):
        (WebCore::GraphicsLayerCA::clearContents):
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
        (WebCore::GraphicsLayerCA::setContentsLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago https://bugs.webkit.org/show_bug.cgi?id=25765
cmarrin@apple.com [Fri, 15 May 2009 18:17:51 +0000 (18:17 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=25765

        Avoid calling setNeedsStyleRecalc() when we are
        putting an animated page in the cache. This avoids
        the assert and subsequent problems with a dirty
        page going into the cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Francisco Tolmasky <francisco@280north.com>
aroben@apple.com [Fri, 15 May 2009 18:13:28 +0000 (18:13 +0000)]
2009-05-15  Francisco Tolmasky  <francisco@280north.com>

        BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
        <https://bugs.webkit.org/show_bug.cgi?id=25467>

        Reviewed by Adam Roben.

JavaScriptCore:

        * JavaScriptCore.exp: Added calculatedFunctionName
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
        * debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode.
        (JSC::DebuggerCallFrame::calculatedFunctionName):
        * debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.

WebCore:

        * inspector/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
        * inspector/front-end/CallStackSidebarPane.js: Remove "|| anonymous function" since it is handled internally just like in profiles
        (WebInspector.CallStackSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 15 May 2009 17:59:16 +0000 (17:59 +0000)]
2009-05-15  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/6889823> hash table iterator used after hash table modified in
        ProxyInstance::fieldNamed() when viewing movie trailer

        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::methodsNamed): Move add call after the waitForReply call.
        Anders says that by the time we return someone else might have done the same add
        for us.
        (WebKit::ProxyInstance::fieldNamed): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 15 May 2009 17:41:13 +0000 (17:41 +0000)]
2009-05-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6892055>
        Replace WKN_GetLocation with WKN_ResolveURL (WKN_GetLocation was confusing and did not take the base URL into account)

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCResolveURL):
        New MIG callback.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::resolveURL):
        Use FrameLoader::complete URL here.

        * Plugins/Hosted/WebKitPluginClient.defs:
        Add new MIG definition.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
        * Plugins/WebNetscapeContainerCheckPrivate.h:
        * Plugins/WebNetscapeContainerCheckPrivate.mm:
        (browserContainerCheckFuncs):
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView resolveURL:forTarget:]):
        * Plugins/npapi.mm:
        (WKN_ResolveURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 15 May 2009 17:27:06 +0000 (17:27 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/6892052> WebTextIterator should not “emit
          characters between all visible positions”

        * WebView/WebTextIterator.mm:
        (-[WebTextIterator initWithRange:]): Changed to construct a TextIterator
        with emitCharactersBetweenAllVisiblePositions set to false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix (and a matching Mac change, to avoid unnecessarily divergin...
ap@webkit.org [Fri, 15 May 2009 16:45:40 +0000 (16:45 +0000)]
    Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        Check strings with isEmpty(), not relying on any implicit conversions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
ap@webkit.org [Fri, 15 May 2009 16:06:21 +0000 (16:06 +0000)]
    Reviewed by Darin Adler, Brady Eidson and Eric Carlson.

        <rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
        username and password (Lightwave 9.6 for Mac from Newtek site)

        CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
        for other protocols (including FTP) should be included as part of the URL.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::WebCoreSynchronousLoader::load):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
        Put credentials in URL for non-HTTP requests.

        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
        Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP
        headers to be received, so they cannot work with other protocols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 May 2009 15:33:06 +0000 (15:33 +0000)]
2009-05-15  Simon Fraser  <simon.fraser@apple.com>

        Carrying forwards Darin Adler's rubber stamp

        Make the comment field wider too.

        * skins/custom/global.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 May 2009 15:16:56 +0000 (15:16 +0000)]
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        Make the URL, Summary and Keyword fields wider to mitigate the
        effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
        things generally better.

        * skins/custom/global.css:
        * template/en/custom/bug/edit.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
jmalonzo@webkit.org [Fri, 15 May 2009 12:43:52 +0000 (12:43 +0000)]
2009-05-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Jan Alonzo.

        Use AC_CANONICAL_HOST instead of AC_CANONICAL_SYSTEM, since
        the JIT compiler is not a cross-compiler

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLook for libWebKitSystemInterface.a in a more reasonable location.
mrowe@apple.com [Fri, 15 May 2009 11:53:45 +0000 (11:53 +0000)]
Look for libWebKitSystemInterface.a in a more reasonable location.

Reviewed by Dave Kilzer.

* Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Fri, 15 May 2009 11:47:05 +0000 (11:47 +0000)]
2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] In the image decoder, remove the raw image data represented as QImage
        once the image is converted to QPixmap and inserted in the pixmap cache.
        This effectively reduces the heap usage when running on graphics system
        other than raster (i.e the case where QImage != QPixmap).

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
        * platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Fri, 15 May 2009 11:46:01 +0000 (11:46 +0000)]
2009-05-15  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Refactor alpha channel detection the image decoder.
        Sets the boolean flag as soon as the image is being read.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
        (WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
        (WebCore::ImageDecoderQt::supportsAlpha): Simplified.
        (WebCore::ImageDecoderQt::reset): Resetted the flag.
        * platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Mark Rowe says skipping tests doesn't need review. :)
eric@webkit.org [Fri, 15 May 2009 08:34:42 +0000 (08:34 +0000)]
    Mark Rowe says skipping tests doesn't need review. :)

        Add new tests from r43759 to windows and tiger skipped lists until bug 25816 can be resolved.
        https://bugs.webkit.org/show_bug.cgi?id=25816

        Original bug: http://bugs.webkit.org/show_bug.cgi?id=25464

        * platform/win/Skipped:
        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 15 May 2009 08:08:17 +0000 (08:08 +0000)]
2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Finish support for disabling the JavaScript Debugger and Profiler
        at compile time in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=24917

        * bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
        * bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
        * inspector/JavaScriptCallFrame.cpp: Ditto.
        * inspector/JavaScriptCallFrame.h: Ditto.
        * inspector/JavaScriptCallFrame.idl: Ditto.
        * inspector/JavaScriptDebugListener.h: Ditto.
        * inspector/JavaScriptDebugServer.cpp: Ditto.
        * inspector/JavaScriptDebugServer.h: Ditto.
        * inspector/JavaScriptProfile.cpp: Ditto.
        * inspector/JavaScriptProfile.h: Ditto.
        * inspector/JavaScriptProfileNode.cpp: Ditto.
        * inspector/JavaScriptProfileNode.h: Ditto.
        * page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
        * page/Console.h: Ditto.
        * page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
eric@webkit.org [Fri, 15 May 2009 07:55:44 +0000 (07:55 +0000)]
2009-05-15  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK] Implement layoutTestController.waitForPolicyDelegate
        https://bugs.webkit.org/show_bug.cgi?id=25036

        Connect to 'navigation-policy-decision-requested' and handle
        waitForPolicy in the callback.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (invalidateAnyPreviousWaitToDumpWatchdog):
        (webViewNavigationPolicyDecisionRequested):
        (main):
        * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::notifyDone):
        (LayoutTestController::waitForPolicyDelegate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Jungshik Shin <jshin@chromium.org>
eric@webkit.org [Fri, 15 May 2009 07:49:36 +0000 (07:49 +0000)]
2009-05-15  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Dimitri Glazkov

        http://bugs.webkit.org/show_bug.cgi?id=25464

        Improve the font fallback for characters belonging to 'common' scripts
        in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
        marks in North Indian scripts) and currency signs (e.g. Thai Baht)
        rendered correctly in Chromium on Win.

        Tests: fast/text/international/danda-space.html
               fast/text/international/thai-baht-space.html

        * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
        (WebCore::FontMap::getScriptBasedOnUnicodeBlock):
        (WebCore::FontMap::getScript):
        (WebCore::getFallbackFamily):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 15 May 2009 07:06:43 +0000 (07:06 +0000)]
2009-05-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25731
        [Qt] Cleanup - move files exclusive to XPATH and XSLT under the
        appropriate build section

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPartial revert of 43604. Turns out we need some V8 magic for this to work right.
abarth@webkit.org [Fri, 15 May 2009 07:02:47 +0000 (07:02 +0000)]
Partial revert of 43604.  Turns out we need some V8 magic for this to work right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Evan Martin <evan@chromium.org>
eric@webkit.org [Fri, 15 May 2009 07:02:34 +0000 (07:02 +0000)]
2009-05-14  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel and Darin Fisher.

        Fix a font-related leak in Chromium's Skia backend found by Valgrind.
        https://bugs.webkit.org/show_bug.cgi?id=25760

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        Use caches instead of "new" on every call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>
eric@webkit.org [Fri, 15 May 2009 05:38:48 +0000 (05:38 +0000)]
2009-05-14  Rahul Kuchhal  <kuchhal@chromium.org>

        Reviewed by Eric Seidel.

        Initialize m_spreadMethod in the second constructor too. Not sure if
        a test case can be written, so no test case.
        https://bugs.webkit.org/show_bug.cgi?id=25814

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::Gradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, rollout only.
eric@webkit.org [Fri, 15 May 2009 05:19:28 +0000 (05:19 +0000)]
    No review, rollout only.

        Roll out r43753 as it caused a test to fail
        Turns out more than one test was using the modified JS file.

        * editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
        * editing/pasteboard/paste-blockquote-before-blockquote.html:
        * editing/pasteboard/resources/TEMPLATE.html: Removed.
        * editing/pasteboard/resources/paste-blockquote-before-blockquote.js:
        (copyAndPasteNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Julie Parent <jparent@google.com>
eric@webkit.org [Fri, 15 May 2009 04:34:38 +0000 (04:34 +0000)]
2009-05-14  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25716
        Convert a test located in the resources directory into being a regular js test,
        so we can add add more tests there and run make-js-test-wrappers without clobbering this one.

        * editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
        * editing/pasteboard/paste-blockquote-before-blockquote.html:
        * editing/pasteboard/resources/TEMPLATE.html: Added.
        * editing/pasteboard/resources/paste-blockquote-before-blockquote.js:
        (createLine):
        (copyAndPasteNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 May 2009 03:54:53 +0000 (03:54 +0000)]
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Fix Windows build after renaming MediaControlElements to MediaControlElementType.

        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart):
        * rendering/RenderMediaControls.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 15 May 2009 03:44:10 +0000 (03:44 +0000)]
2009-05-14  Gavin Barraclough  <barraclough@apple.com>

        Build fix, not reviewed.

        Quick fixes for JIT builds with OPTIMIZE flags disabled.

        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::compilePutByIdHotPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Back out incorrect Windows build fix
sfalken@apple.com [Fri, 15 May 2009 03:29:45 +0000 (03:29 +0000)]
    Back out incorrect Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 May 2009 03:10:03 +0000 (03:10 +0000)]
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6739671> Movie controller’s play button does not change into a pause
        button

        Fix a controls repaint issue when the playing state of a video changes by
        educating the MediaControlInputElements about the state they are currently
        displaying, and making them repaint when that state changes. This applies
        to the play/pause and mute/unmute buttons, which both have two states.

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::MediaControlInputElement):
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
        Pass in and initialize the MediaControlElementType.

        (WebCore::MediaControlInputElement::update):
        Update the display type too

        (WebCore::MediaControlInputElement::setDisplayType):
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
        (WebCore::MediaControlMuteButtonElement::updateDisplayType):
        Choose muted vs. unmuted display.

        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
        (WebCore::MediaControlPlayButtonElement::updateDisplayType):
        Choose play vs. paused display.

        * rendering/MediaControlElements.h:
        Renamed the MediaControlElements enum to MediaControlElementType.
        (WebCore::MediaControlInputElement::updateDisplayType):
        Add a MediaControlElementType member variable with a setter to allow
        the element to know what type it is displaying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 14 May 2009 23:14:25 +0000 (23:14 +0000)]
2009-05-14  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=25197

        Add support for aspect-ratio and orientation
        media queries.

        Tests: fast/media/mq-aspect-ratio.html
               fast/media/mq-orientation.html

        * css/MediaFeatureNames.h:
        * css/MediaQueryEvaluator.cpp:
        (WebCore::orientationMediaFeatureEval):
        (WebCore::aspect_ratioMediaFeatureEval):
        (WebCore::min_aspect_ratioMediaFeatureEval):
        (WebCore::max_aspect_ratioMediaFeatureEval):
        * css/MediaQueryExp.h:
        (WebCore::MediaQueryExp::isViewportDependent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Thu, 14 May 2009 23:04:16 +0000 (23:04 +0000)]
WebCore:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Resubmitting previous patch, correctly this time.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):

LayoutTests:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Resubmitting previous patch, correctly this time.

        * editing/execCommand/outdent-blockquote-test1.html: Copied from editing/execCommand/outdent-blockquote-test1.html.
        * editing/execCommand/outdent-blockquote-test2.html: Copied from editing/execCommand/outdent-blockquote-test2.html.
        * editing/execCommand/outdent-blockquote-test3.html: Copied from editing/execCommand/outdent-blockquote-test3.html.
        * editing/execCommand/outdent-blockquote-test4.html: Copied from editing/execCommand/outdent-blockquote-test4.html.
        * platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt.
        * platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt.
        * platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt.
        * platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt.
        * platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
timothy@apple.com [Thu, 14 May 2009 22:18:47 +0000 (22:18 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Thu, 14 May 2009 21:56:09 +0000 (21:56 +0000)]
WebCore:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Rolling out to fix a bug and the build

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):

LayoutTests:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Rolled out for bug and build fix.

        * editing/execCommand/outdent-blockquote-test1.html: Removed.
        * editing/execCommand/outdent-blockquote-test2.html: Removed.
        * editing/execCommand/outdent-blockquote-test3.html: Removed.
        * editing/execCommand/outdent-blockquote-test4.html: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Thu, 14 May 2009 21:28:45 +0000 (21:28 +0000)]
WebCore:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6510362> In some situations message content is messed up
        when indentation is decreased

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
        here served to do nothing because this function will return if the
        second argument is the parent of the first.  Not only does this now work
        as intended, but is necessary for the rest of this fix.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we
        are the last node in a <blockquote>, and can therefore remove the
        <blockquote> we need the endOfEnclosingBlock to extend to the end of
        the <blockquote> not just the next block, which could be a <div>, for
        example.
        - Also If a <blockquote> is removed, but it's the child of another
        <blockquote> then its children are now children of the top <blockquote>.
        In this case we want to split the parent <blockquote> because the next
        paragraph assumes that it is the first node in its <blockquote> and if
        that is not true, various bugs arise.

LayoutTests:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6510362> In some situations message content is messed up
        when indentation is decreased

        - These tests are the various combinations of <blockquote>s that
        revealed bugs in our old logic.

        * editing/execCommand/outdent-blockquote-test1.html: Added.
        * editing/execCommand/outdent-blockquote-test2.html: Added.
        * editing/execCommand/outdent-blockquote-test3.html: Added.
        * editing/execCommand/outdent-blockquote-test4.html: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 14 May 2009 20:47:56 +0000 (20:47 +0000)]
2009-05-14  David Hyatt  <hyatt@apple.com>

        Reviewed by Tim Hatcher.

        Fix for <rdar://problem/6886217> REGRESSION (S4 beta-ToT): Adium chat window contents no longer resize.

        Technically this is a bug in Adium.  It appears that Adium has subclassed the WebView and implemented
        viewDidMoveToWindow in its subclass improperly.  It doesn't call up to the base class WebView like it
        should and so our boundsChanged notification never gets added.

        Reduce the dependence on viewDidMoveToWindow by moving the registration of observers into
        viewWillMoveToWindow instead.

        * WebView/WebView.mm:
        (-[WebView addSizeObserversForWindow:]):
        (-[WebView removeWindowObservers]):
        (-[WebView addWindowObserversForWindow:]):
        (-[WebView viewWillMoveToWindow:]):
        (-[WebView viewDidMoveToWindow]):
        (-[WebView viewDidMoveToSuperview]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 14 May 2009 20:42:30 +0000 (20:42 +0000)]
2009-05-14  Brady Eidson  <beidson@apple.com>

        Build fix.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::setDefaultMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 14 May 2009 20:09:22 +0000 (20:09 +0000)]
2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben.

        Fix http/tests/xmlhttprequest/cache-override.html on Windows

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
        (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
        (WebCore::WebCoreSynchronousLoader::load): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Paul Godavari <paul@chromium.org>
levin@chromium.org [Thu, 14 May 2009 19:55:16 +0000 (19:55 +0000)]
2009-05-14  Paul Godavari  <paul@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug: Mac Chromium popup menus are not positioned correctly
        on scrolled pages:
        https://bugs.webkit.org/show_bug.cgi?id=25772

        Fix Mac Chromium popup menu placement by taking into
        account any scrolling in the current window. This mirrors
        the positioning done in PopupContainer::show(), which is
        used on Chromium Windows and linux.

        Also fixed indenting for this method.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showExternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Drew Wilson <atwilson@google.com>
levin@chromium.org [Thu, 14 May 2009 19:55:07 +0000 (19:55 +0000)]
2009-05-14  Drew Wilson  <atwilson@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25774
        Upstream V8MessagePortCustom.cpp from the chromium repository.

        * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/mac:
levin@chromium.org [Thu, 14 May 2009 19:54:58 +0000 (19:54 +0000)]
WebKit/mac:

2009-05-14  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24704

        Allow the local cache directory to be set using a defaults key.

        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
        * WebKit.exp:

WebKitTools:

2009-05-14  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24704

        Make paths where data is saved be scoped to the ~ directory,
        so that one can run independent instances by setting CFFIXED_USER_HOME.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (libraryPath):
        (setDefaultsToConsistentValuesForTesting):
        (dumpFrameAsPDF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 May 2009 19:21:30 +0000 (19:21 +0000)]
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=25777

        StyleGeneratedImage::imageSize() needs to take zooming into account for
        fixed-size images (i.e. canvas) so that canvas-as-image-background
        renders correctly with zooming.

        Test: fast/canvas/canvas-bg-zoom.html

        * rendering/style/StyleGeneratedImage.cpp:
        (WebCore::StyleGeneratedImage::imageSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 14 May 2009 19:09:40 +0000 (19:09 +0000)]
    Reviewed by Darin Adler.

        Patch originally by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25796
        <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().

        Test: http/tests/security/credentials-in-referer.html

        * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
        SubresourceLoader::create() anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 14 May 2009 19:07:47 +0000 (19:07 +0000)]
2009-05-14  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disabling tests that are failing intermittently.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25797: Pages with image maps are not properly read with Voiceover
cfleizach@apple.com [Thu, 14 May 2009 19:01:05 +0000 (19:01 +0000)]
Bug 25797: Pages with image maps are not properly read with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=25797

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Thu, 14 May 2009 18:56:14 +0000 (18:56 +0000)]
WebCore:

2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790

        Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::shouldContentSniff):
        * platform/network/ResourceHandle.h:

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::createCFURLResponseWithDefaultMIMEType):
        (WebCore::didReceiveResponse):

LayoutTests:

2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790

        * platform/win/Skipped: Renable these tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 14 May 2009 17:51:28 +0000 (17:51 +0000)]
2009-05-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25791
        Bug 25791: HTMLMediaElement: implement 'startTime' attribute

        Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
        value that only the media engine can know, so we just need to add the attribute
        to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
        the engine can make it available.

        Test: media/media-startTime.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::startTime): New.
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::startTime): New.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::startTime): New.

2009-05-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25791
        Bug 25791: HTMLMediaElement: implement 'startTime' attribute

        Add test for 'startTime' attribute.

        * media/media-startTime-expected.txt: Added.
        * media/media-startTime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Thu, 14 May 2009 17:44:14 +0000 (17:44 +0000)]
2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        Add a comment to QWebView::iconChanged(), mentioning that you will
        need to set the icon database path for icons to be loaded, and thus
        receive the signal.

        * Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Tony Chang <tony@chromium.org>
dglazkov@chromium.org [Thu, 14 May 2009 17:35:51 +0000 (17:35 +0000)]
2009-05-14  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        Move iframe content to a file because Chromium has
        AllowLocalLoadsForLocalOnly enabled.  This prevents the parent
        frame from modifying the iframe content if it is a data: URL.

        https://bugs.webkit.org/show_bug.cgi?id=25766

        * fast/frames/content-opacity-2.html:
        * fast/frames/resources/empty-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add a failing text control metrics test to the Windows Skipped file
aroben@apple.com [Thu, 14 May 2009 17:34:04 +0000 (17:34 +0000)]
    Add a failing text control metrics test to the Windows Skipped file

        See Bug 25794: fast/replaced/table-percent-height-text-controls fails
        on Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25794>

        * platform/win/Skipped: Added
        fast/replaced/table-percent-height-text-controls.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
sfalken@apple.com [Thu, 14 May 2009 17:29:09 +0000 (17:29 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Thu, 14 May 2009 17:27:09 +0000 (17:27 +0000)]
2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        Only create a QWidget wrapper for the plugin in the case it is not
        in the Qt window mapper, and thus receiving events from the Qt
        event system. Native Qt based plugins running in process, will
        already be in the window mapper, and thus creating a wrapper,
        stops them from getting events from Qt, as they are redirected
        to the wrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 14 May 2009 16:45:39 +0000 (16:45 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25784
        Leaks seen on HTTP tests

        We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
        disabling content sniffing, matching the normal code path.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
        and m_pass before overwriting.
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 14 May 2009 16:39:48 +0000 (16:39 +0000)]
2009-05-14  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6879999> Automator actions that use WebKit on a background thread fail when run outside of Automator

        * WebView/WebView.mm:
        (clientNeedsWebViewInitThreadWorkaround): Added. Contains new broader rule.
        (needsWebViewInitThreadWorkaround): Changed to call clientNeedsWebViewInitThreadWorkaround.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Yury Semikhatsky <yurys@chromium.org>
dglazkov@chromium.org [Thu, 14 May 2009 16:14:28 +0000 (16:14 +0000)]
2009-05-14  Yury Semikhatsky <yurys@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25418
        Remove new lines from event handler wrapper to make line numbers
        in the wrapped script conside with the lines in the original script.

        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::getListenerFunction):
        (WebCore::V8LazyEventListener::getWrappedListenerFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add a timing-out test to the Windows Skipped file
aroben@apple.com [Thu, 14 May 2009 16:11:44 +0000 (16:11 +0000)]
    Add a timing-out test to the Windows Skipped file

        See Bug 25792: fast/encoding/percent-escaping.html times out on
        Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25792>

        * platform/win/Skipped: Added fast/encoding/percent-escaping.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 14 May 2009 16:11:25 +0000 (16:11 +0000)]
2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Remove a JSC-specific include that is already added by including
        ScriptController.

        No change in behavior, so no tests.

        * dom/Document.cpp: Removed JSDOMBinding include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43705 268f45cc-cd09-0410-ab3c-d52691b4dbfc