WebKit-https.git
10 years ago2010-07-24 Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
commit-queue@webkit.org [Sat, 24 Jul 2010 12:54:38 +0000 (12:54 +0000)]
2010-07-24  Riccardo Magliocchetti  <riccardo.magliocchetti@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] Enable jit compilation on arm
        https://bugs.webkit.org/show_bug.cgi?id=42856

        Add missing bits to configure.ac to build the arm jit.
        Compile and tested on debian sid armel on a qemu vm.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 24 Jul 2010 04:17:12 +0000 (04:17 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Buildfix for !ENABLE(FILTERS) after r63531.
        https://bugs.webkit.org/show_bug.cgi?id=42914

        * rendering/RenderSVGContainer.cpp: Add missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Kavita Kanetkar <kkanetkar@chromium.org>
commit-queue@webkit.org [Sat, 24 Jul 2010 03:35:26 +0000 (03:35 +0000)]
2010-07-23  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Joseph Pecoraro.

        Implement remaining Inspector support for chrome's appcache
        https://bugs.webkit.org/show_bug.cgi?id=42426

        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
        (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
        (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
        (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
        * inspector/InspectorApplicationCacheAgent.h:
        (WebCore::InspectorController::connectFrontend):
        * loader/appcache/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::fillResourceList):
        (WebCore::ApplicationCacheHost::applicationCacheInfo):
        * loader/appcache/ApplicationCacheHost.h: Changed creation + update times to double and moved appcache info here from InspectorApplicationCacheAgent.h
        (WebCore::ApplicationCacheHost::CacheInfo::CacheInfo):
        (WebCore::ApplicationCacheHost::ResourceInfo::ResourceInfo):
2010-07-23  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Joseph Pecoraro.

        Implement remaining Inspector support for chrome's appcache
        https://bugs.webkit.org/show_bug.cgi?id=42426

        * src/ApplicationCacheHost.cpp: Plugging in chrome's appcache info.
        (WebCore::ApplicationCacheHost::applicationCacheInfo):
        (WebCore::ApplicationCacheHost::fillResourceList):
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Sat, 24 Jul 2010 01:48:39 +0000 (01:48 +0000)]
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Fixing support for compiling EFL port without glib.

        * cmake/FindGthread.cmake: Added.
        * cmake/OptionsEfl.cmake:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Remove gobject/GRefPtr.cpp if not using soup/glib.

        * wtf/CMakeListsEfl.txt:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        No new tests, no new features added.
        Just add flags and directories for glib if necessary.
        Put some ifdefs on glib calls.

        * CMakeListsEfl.txt:
        * platform/graphics/cairo/FontPlatformDataCairo.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Just add glib flags and directories if necessary.

        * CMakeListsEfl.txt:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Put some ifdefs on glib calls.

        * ewk/ewk_main.cpp:
        (ewk_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 24 Jul 2010 00:09:52 +0000 (00:09 +0000)]
2010-07-23  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        CanvasRenderingContext2D has lots of style errors
        https://bugs.webkit.org/show_bug.cgi?id=42918

        CanvasRenderingContext2D.h and .cpp have lots of style errors.  I'm planning to post patches
        to both of these files soon, so to minimize merge conflicts and additional style violations
        it seems best to fix all of these errors in bulk before posting any functional changes.  In
        particular the header file is incorrectly indented so any correctly formatted addition will
        be out of place.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::setFillStyle):
        (WebCore::CanvasRenderingContext2D::transform):
        (WebCore::CanvasRenderingContext2D::setTransform):
        (WebCore::CanvasRenderingContext2D::arcTo):
        (WebCore::CanvasRenderingContext2D::arc):
        (WebCore::validateRectForCanvas):
        (WebCore::CanvasRenderingContext2D::strokeRect):
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::createRadialGradient):
        (WebCore::CanvasRenderingContext2D::createPattern):
        (WebCore::CanvasRenderingContext2D::willDraw):
        (WebCore::CanvasRenderingContext2D::createImageData):
        (WebCore::CanvasRenderingContext2D::putImageData):
        (WebCore::CanvasRenderingContext2D::setFont):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * html/canvas/CanvasRenderingContext2D.h:
        (WebCore::CanvasRenderingContext2D::is2d):
        (WebCore::CanvasRenderingContext2D::getLineCap):
        (WebCore::CanvasRenderingContext2D::getLineJoin):
        (WebCore::CanvasRenderingContext2D::state):
        (WebCore::CanvasRenderingContext2D::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Sat, 24 Jul 2010 00:07:49 +0000 (00:07 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 24 Jul 2010 00:03:53 +0000 (00:03 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Remove FIXME that we already fixed.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 23 Jul 2010 22:34:29 +0000 (22:34 +0000)]
2010-07-23  James Robinson  <jamesr@chromium.org>

        Unreviewed.  Add chromium expectations for new tests.

        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum:
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png:
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum:
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png:
        * platform/chromium-win/tables/layering: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 23 Jul 2010 22:17:56 +0000 (22:17 +0000)]
2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Move more form submission logic into FormSubmission.
        https://bugs.webkit.org/show_bug.cgi?id=41110

        Two major moves:
        * Fold HTMLFormElement::prepareFormSubmission into FormSubmission::create
        * Move non-static (non-FormData-building) methods of FormDataBuilder
            to FormSubmission::Attributes.

        Mechanical moving, no change in behavior, so no new tests.

        * WebCore.xcodeproj/project.pbxproj: Gave FormDataBuilder.h "project" and
            FormSubmission.h "private" visibility.
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submit): Changed to use FormSubmission::create.
        (WebCore::HTMLFormElement::parseMappedAttribute): Changed to use m_attributes.
        * html/HTMLFormElement.h:
        (WebCore::HTMLFormElement::enctype): Ditto.
        (WebCore::HTMLFormElement::encoding): Ditto.
        (WebCore::HTMLFormElement::acceptCharset): Ditto.
        * loader/FormSubmission.cpp:
        (WebCore::generateFormDataIdentifier): Moved from HTMLFormElement.
        (WebCore::appendMailtoPostFormDataToURL): Ditto.
        (WebCore::FormSubmission::Attributes::parseAction): Moved from FormDataBuilder.
        (WebCore::FormSubmission::Attributes::parseEncodingType): Ditto.
        (WebCore::FormSubmission::Attributes::parseMethodType): Ditto.
        (WebCore::FormSubmission::FormSubmission): Made inline.
        (WebCore::FormSubmission::create): Added logic that used to be in
            HTMLFormElement::prepareFormSubmission.
        * loader/FormSubmission.h:
        (WebCore::FormSubmission::):
        (WebCore::FormSubmission::Attributes::Attributes): Added new class.
        (WebCore::FormSubmission::Attributes::method): Moved from FormDataBuilder.
        (WebCore::FormSubmission::Attributes::isMultiPartForm): Ditto.
        (WebCore::FormSubmission::Attributes::action): Ditto.
        (WebCore::FormSubmission::Attributes::target): Ditto.
        (WebCore::FormSubmission::Attributes::setTarget): Ditto.
        (WebCore::FormSubmission::Attributes::encodingType): Ditto.
        (WebCore::FormSubmission::Attributes::acceptCharset): Ditto.
        (WebCore::FormSubmission::Attributes::setAcceptCharset): Ditto.
        (WebCore::FormSubmission::target): Ditto.
        (WebCore::FormSubmission::contentType): Const-ified return type.
        (WebCore::FormSubmission::boundary): Ditto.
        * platform/network/FormDataBuilder.cpp:
        (WebCore::FormDataBuilder::encodingFromAcceptCharset): Renamed method for clarity,
            made it use param instead of a class member.
        * platform/network/FormDataBuilder.h:
        (WebCore::FormDataBuilder::FormDataBuilder): Made constructor private.
        * wml/WMLGoElement.cpp: Changed to use FormSubmision::Attributes.
        * wml/WMLGoElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 22:14:02 +0000 (22:14 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
        https://bugs.webkit.org/show_bug.cgi?id=42365

        * http/tests/misc/write-from-dom-script-expected.txt: Added.
        * http/tests/misc/write-from-dom-script.html: Added.
          - Test the scenario where a script added to the DOM asynchronously
            while the nesting level is >0.  It's supposed to have its calls to
            document.write blocked.
        * http/tests/misc/write-while-waiting.html:
          - Writes are only prevented from scripts that are added to the DOM.
            Scripts that run via setTimeout do not have their writes blocked.
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
        https://bugs.webkit.org/show_bug.cgi?id=42365

        This patch implements the changes Ian made to HTML5 to address these
        issues.  Let's try it and see how well it works.

        Test: http/tests/misc/write-from-dom-script.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::write):
        * dom/Document.h:
        (WebCore::Document::writeDisabled):
        (WebCore::Document::setWriteDisabled):
        * dom/DocumentParser.h:
        (WebCore::DocumentParser::hasInsertionPoint):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::insertedIntoDocument):
        (WebCore::ScriptElementData::ScriptElementData):
        (WebCore::ScriptElementData::evaluateScript):
        * dom/ScriptElement.h:
        (WebCore::ScriptElementData::writeDisabled):
        (WebCore::ScriptElementData::setWriteDisabled):
        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::hasInsertionPoint):
        (WebCore::HTMLDocumentParser::insert):
        * html/HTMLDocumentParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
ddkilzer@apple.com [Fri, 23 Jul 2010 21:59:13 +0000 (21:59 +0000)]
<webkit.org/b/42911> Update ruby tools to work with shallow framework bundles

Reviewed by Mark Rowe.

* Scripts/check-for-inappropriate-files-in-framework: Added
check for the SHALLOW_BUNDLE environment variable so that the
script will work with iOS WebKit builds.
* Scripts/check-for-webkit-framework-include-consistency: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 21:46:54 +0000 (21:46 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for PopupMenuWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=42906

        Use correct API for BitmapInfo landed in r63944.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Jul 2010 20:29:36 +0000 (20:29 +0000)]
2010-07-23  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Land the expectation for win.

        Backslash isn't transcoded in <input>
        https://bugs.webkit.org/show_bug.cgi?id=42878

        * platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 fsamuel@chromium.org <fsamuel@chromium.org>
jamesr@google.com [Fri, 23 Jul 2010 20:22:29 +0000 (20:22 +0000)]
2010-07-23  fsamuel@chromium.org  <fsamuel@chromium.org>

        Reviewed by David Hyatt.

        Updated table painting to draw cell layers in the correct order.

        Table Cell Layering
        https://bugs.webkit.org/show_bug.cgi?id=40775

        Tests: tables/layering/paint-test-layering-1.html
               tables/layering/paint-test-layering-2.html

        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        (WebCore::AccessibilityTable::addChildren):
        (WebCore::AccessibilityTable::cellForColumnAndRow):
        * accessibility/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::titleUIElement):
        * accessibility/AccessibilityTableColumn.cpp:
        (WebCore::AccessibilityTableColumn::headerObjectForSection):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::splitColumn):
        (WebCore::RenderTable::calcBorderLeft):
        (WebCore::RenderTable::calcBorderRight):
        (WebCore::RenderTable::cellAbove):
        (WebCore::RenderTable::cellBelow):
        (WebCore::RenderTable::cellBefore):
        (WebCore::RenderTable::cellAfter):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        (WebCore::RenderTableSection::ensureRows):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::calcOuterBorderTop):
        (WebCore::RenderTableSection::calcOuterBorderBottom):
        (WebCore::RenderTableSection::calcOuterBorderLeft):
        (WebCore::RenderTableSection::calcOuterBorderRight):
        (WebCore::RenderTableSection::firstLineBoxBaseline):
        (WebCore::compareCellPositions):
        (WebCore::RenderTableSection::paintCell):
        (WebCore::RenderTableSection::paintObject):
        (WebCore::RenderTableSection::numColumns):
        (WebCore::RenderTableSection::appendColumn):
        (WebCore::RenderTableSection::splitColumn):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::CellStruct::CellStruct):
        (WebCore::RenderTableSection::CellStruct::primaryCell):
        (WebCore::RenderTableSection::CellStruct::hasCells):
        (WebCore::RenderTableSection::primaryCellAt):
2010-07-23  fsamuel@chromium.org  <fsamuel@chromium.org>

        Reviewed by David Hyatt.

        Updated table painting to draw cell layers in the correct order.

        Table Cell Layering
        https://bugs.webkit.org/show_bug.cgi?id=40775

        * platform/chromium-linux/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-2-expected.txt: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.txt: Added.
        * platform/gtk/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/gtk/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/gtk/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/gtk/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/gtk/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/gtk/tables/layering/paint-test-layering-2-expected.txt: Added.
        * platform/mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/mac/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/mac/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/mac/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/mac/tables/layering/paint-test-layering-2-expected.txt: Added.
        * tables/layering/paint-test-layering-1.html: Added.
        * tables/layering/paint-test-layering-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 20:16:58 +0000 (20:16 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for Path.h
        https://bugs.webkit.org/show_bug.cgi?id=42904

        * platform/graphics/Path.h: Add missing typedef PlatformPath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 23 Jul 2010 19:51:56 +0000 (19:51 +0000)]
2010-07-23  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations fix.

        * platform/chromium-win/fast/borders/different-color-borders-expected.checksum: Added.
        * platform/chromium-win/fast/borders/different-color-borders-expected.png: Added.
        * platform/chromium-win/fast/borders/different-color-borders-expected.txt: Added.
        New baseline for new test.
        * platform/chromium/test_expectations.txt:
        Remove passing tests from expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 19:08:42 +0000 (19:08 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Reserve capacity for attributes
        https://bugs.webkit.org/show_bug.cgi?id=42877

        This is about a 1.7% improvement to the parsing benchmark.

        * html/HTMLToken.h:
        (WebCore::AtomicHTMLToken::AtomicHTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 18:54:03 +0000 (18:54 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Inline HTMLElementStack::top
        https://bugs.webkit.org/show_bug.cgi?id=42879

        According to sampling, HTMLElementStack::top is the hotest function in
        the treebuilder.  Inlining it is about a 0.3% improvement to the
        parsing benchmark.  This squares with how often it occurs in samples.

        * html/HTMLElementStack.cpp:
        * html/HTMLElementStack.h:
        (WebCore::HTMLElementStack::top):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 18:38:22 +0000 (18:38 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for GraphicsContext
        https://bugs.webkit.org/show_bug.cgi?id=42888

        Use AffineTransform insted of TransformationMatrix and
        add ColorSpace parameter to the drawBitmap methods.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::affineTransform):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::drawBitmap):
        (WebCore::GraphicsContext::drawBitmapPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Fri, 23 Jul 2010 18:17:35 +0000 (18:17 +0000)]
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Instead of just libsoup, the EFL port now can use libcurl backend.
        This is a step in the direction of removing dependency on glib. Just
        need to pass the option -DNETWORK_BACKEND=curl to cmake in order to
        enable it.

        * cmake/OptionsEfl.cmake:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Add files and flags for soup/curl specific backend being
        used.
        Put some ifdefs around soup/glib calls.

        No new tests, no new features implemented.

        * CMakeListsEfl.txt:
        * platform/efl/FileSystemEfl.cpp:
        (WebCore::fileSystemRepresentation):
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Just add soup/curl directories and flags for the specific
        backend being used.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Put some ifdefs around soup calls.

        * ewk/ewk_cookies.cpp:
        (ewk_cookies_file_set):
        (ewk_cookies_clear):
        (ewk_cookies_get_all):
        (ewk_cookies_cookie_del):
        (ewk_cookies_cookie_free):
        (ewk_cookies_policy_set):
        (ewk_cookies_policy_get):
        * ewk/ewk_main.cpp:
        (ewk_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 17:47:54 +0000 (17:47 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add fast-reject path for InputStreamPreprocessor::peek
        https://bugs.webkit.org/show_bug.cgi?id=42881

        This is about a 2.5% speedup on the parsing benchmark.

        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Hans Wennborg <hans@chromium.org>
commit-queue@webkit.org [Fri, 23 Jul 2010 17:27:39 +0000 (17:27 +0000)]
2010-07-23  Hans Wennborg  <hans@chromium.org>

        Reviewed by Ojan Vafai.

        Rebaseline fast/dom/prototype-inheritance.html for chromium
        https://bugs.webkit.org/show_bug.cgi?id=42824

        Since Chromium revision 53317, ENABLE_DEVICE_ORIENTATION is enabled,
        which means window.DeviceOrientationEvent will show up
        in this layout test.

        * platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 17:11:11 +0000 (17:11 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=42885

        Make PasteboardWin more portable and remove the global namespace prefix
        from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

        * platform/win/PasteboardWin.cpp:
        (WebCore::PasteboardOwnerWndProc):
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 23 Jul 2010 16:41:58 +0000 (16:41 +0000)]
2010-07-23  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, rolling out r63925.
        http://trac.webkit.org/changeset/63925
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Introduced a regression in history state.

        * page/History.cpp:
        (WebCore::History::urlForState):
2010-07-23  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, rolling out r63925.
        http://trac.webkit.org/changeset/63925
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Introduced a regression in history state.

        * fast/history/history-replace-illegal-expected.txt: Removed.
        * fast/history/history-replace-illegal.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 23 Jul 2010 16:26:15 +0000 (16:26 +0000)]
2010-07-23  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed build fix.

        Fix make dist by aligning the source list with currently used headers.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 23 Jul 2010 16:25:30 +0000 (16:25 +0000)]
2010-07-23  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, rolling out r63959.
        http://trac.webkit.org/changeset/63959
        https://bugs.webkit.org/show_bug.cgi?id=42884

        63925 introduced a regression and is being reverted.

        * platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Removed.
        * platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 16:24:42 +0000 (16:24 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Implement TCSpinLock.
        https://bugs.webkit.org/show_bug.cgi?id=41792

        Implement the SpinLock with InterlockedExchange from the Windows API.

        * wtf/TCSpinLock.h:
        (TCMalloc_SpinLock::Lock):
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SpinLock::IsHeld):
        (TCMalloc_SpinLock::Init):
        (TCMalloc_SlowLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 16:10:51 +0000 (16:10 +0000)]
2010-07-23  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        QScriptValue::equals benchmark crash fix.

        Patch changes QScriptValue::equals implementation to cover
        more edge cases.

        Problem exposes an issue in our autotests (all values got
        bound to an engine too fast - bug 42366).

        [Qt] QScriptValue::equals asserts
        https://bugs.webkit.org/show_bug.cgi?id=42363

        * api/qscriptvalue_p.h:
        (QScriptValuePrivate::equals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Alex Milowski <alex@milowski.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 15:57:41 +0000 (15:57 +0000)]
2010-07-23  Alex Milowski  <alex@milowski.com>

        Reviewed by Darin Adler.

        Moved the 'mathml' group back to where it belongs as
        siblings of the other major folders.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Fri, 23 Jul 2010 15:44:05 +0000 (15:44 +0000)]
2010-07-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Notify browser when window shall be closed.

        This is used for window.close() events Javascript, though it would be
        triggered for any event on WebCore that might ask for the window to be
        closed.

        https://bugs.webkit.org/show_bug.cgi?id=42890

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::closeWindowSoon): call new function and moves its
        previous functionality there.
        * ewk/ewk_private.h:
        * ewk/ewk_view.cpp:
        (ewk_view_window_close): stop all loaders as was being done previously and
        notify browser afterwards.
        * ewk/ewk_view.h: declare new virtual method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Fri, 23 Jul 2010 15:41:10 +0000 (15:41 +0000)]
Unreviewed.

Process link elements immediately if there are no beforeload listeners.
https://bugs.webkit.org/show_bug.cgi?id=42859

Add Qt specific expected result after r63924.

* platform/qt/http/tests/security/mixedContent: Added.
* platform/qt/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Copied from LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt and updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 15:30:30 +0000 (15:30 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Buildfix for WinCE graphics after r56015.
        https://bugs.webkit.org/show_bug.cgi?id=41354

        Use fabs() insetead of abs().

        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/wince/PlatformPathWince.cpp:
        (WebCore::PlatformPath::addArcTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 ryuan choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 14:50:57 +0000 (14:50 +0000)]
2010-07-23  ryuan choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL]build break because of r63927
        https://bugs.webkit.org/show_bug.cgi?id=42864

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDoc: Fixed incorrect QML property type.
hausmann@webkit.org [Fri, 23 Jul 2010 14:48:14 +0000 (14:48 +0000)]
Doc: Fixed incorrect QML property type.

Patch by David Boddie <dboddie@trolltech.com> on 2010-07-23
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Fri, 23 Jul 2010 14:36:54 +0000 (14:36 +0000)]
2010-07-23  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable the build of MiniBrowser.

        * WebKit.pro: add MiniBrowser.pro to SUBDIRS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 14:34:26 +0000 (14:34 +0000)]
2010-07-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Set proxy address for Soup
        https://bugs.webkit.org/show_bug.cgi?id=42721

        Sets the given proxy URI for libsoup network backend. This method will
        support libcurl network backend later.

        * EWebLauncher/main.c:
        (main): Invoke proxy set method
        * ewk/ewk_settings.cpp:
        (ewk_settings_proxy_uri_set): Sets proxy URI.
        * ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix for Qt apps
hausmann@webkit.org [Fri, 23 Jul 2010 14:27:11 +0000 (14:27 +0000)]
[Qt] Build fix for Qt apps

Add webkit to QT_CONFIG. qconfig.pri will read qt_webkit_version.pri and
that's how it will pick up webkit in QT_CONFIG.

* qt_webkit_version.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 14:19:18 +0000 (14:19 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Inline HTMLTokenizer::InputStreamPreprocessor::peek
        https://bugs.webkit.org/show_bug.cgi?id=42880

        According to sampling HTMLTokenizer::InputStreamPreprocessor::peek is
        the hotest function in the tokenizer.  Inlining this function is about
        a 2.2% speedup on the parser benchmark.  Turns out the tokenizer is
        much hotter than the tree builder.  :)

        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Fri, 23 Jul 2010 14:04:16 +0000 (14:04 +0000)]
2010-07-23  Andras Becsi  <abecsi@webkit.org>

        Unreviewed build fix.

        [Qt] Fix WebKit2 linkage.

        No new tests needed.

        * WebCore.pro: add InjectedBundlePageEditorClient.cpp to WK2 sources

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Fri, 23 Jul 2010 13:39:33 +0000 (13:39 +0000)]
2010-07-23  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Setup the QtWebProcess

        https://bugs.webkit.org/show_bug.cgi?id=42623

        * WebCore.pro: Added WebProcessMainQt.cpp to SOURCES.
2010-07-23  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Setup the QtWebProcess

        https://bugs.webkit.org/show_bug.cgi?id=42623

        * WebKit.pro: Add WebKit2.pro to the build guarded by webkit2 config variable.
2010-07-19 Balazs Kelemen <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Setup the QtWebProcess

        https://bugs.webkit.org/show_bug.cgi?id=42623

        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        Remove the framework entry point from here to WebProcess/qt/WebProcessMainQt.cpp to match with with the mac and the win port.
        * WebKit2.pro: Added.
        * WebProcess/qt/WebProcessMainQt.cpp: Added.
        (WebKit::WebProcessMainQt): Framework entry point for Qt.
        * qt/MainQt.cpp: Added.
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 23 Jul 2010 13:19:18 +0000 (13:19 +0000)]
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Chromium tests fix.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 12:54:29 +0000 (12:54 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for PluginDatabaseWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=41887

        Define KEY_ENUMERATE_SUB_KEYS only if not defined.

        * plugins/win/PluginDatabaseWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 23 Jul 2010 12:46:19 +0000 (12:46 +0000)]
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: migrate from utility context-based injected
        script dispatch to upstream schema.

        https://bugs.webkit.org/show_bug.cgi?id=42883

        * bindings/v8/ScriptProfile.cpp:
        (WebCore::ScriptProfile::title):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getProfile):
        * inspector/front-end/InjectedScriptAccess.js:
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Reviewed by Yury Semikhatsky.

        Chromium DevTools: migrate from utility context-based injected
        script dispatch to upstream schema.

        https://bugs.webkit.org/show_bug.cgi?id=42883

        * src/ToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        * src/WebDevToolsAgentImpl.h:
        * src/js/DevToolsHostStub.js:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 23 Jul 2010 12:20:21 +0000 (12:20 +0000)]
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: rolling out r63963.

        * bindings/v8/ScriptProfile.cpp:
        (WebCore::ScriptProfile::title):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getProfile):
        * inspector/front-end/InjectedScriptAccess.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 23 Jul 2010 12:12:00 +0000 (12:12 +0000)]
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: migrate from utility context-based injected
        script dispatch to upstream schema.

        https://bugs.webkit.org/show_bug.cgi?id=42883

        * bindings/v8/ScriptProfile.cpp:
        (WebCore::ScriptProfile::title):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getProfile):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess.get if):
        (InjectedScriptAccess):
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Reviewed by Yury Semikhatsky.

        Chromium DevTools: migrate from utility context-based injected
        script dispatch to upstream schema.

        https://bugs.webkit.org/show_bug.cgi?id=42883

        * src/ToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        * src/WebDevToolsAgentImpl.h:
        * src/js/DevToolsHostStub.js:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 23 Jul 2010 11:58:54 +0000 (11:58 +0000)]
2010-07-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: error info propagation in InspectorBackendDispatch should be improved
        https://bugs.webkit.org/show_bug.cgi?id=42873

        * inspector/CodeGeneratorInspector.pm: report wrong parameter count and wrong
        parametere type errror to the dispatch method caller

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 23 Jul 2010 11:42:51 +0000 (11:42 +0000)]
2010-07-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: injectedScriptId is missing in the stack frame wrappers.

        https://bugs.webkit.org/show_bug.cgi?id=42889

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Fri, 23 Jul 2010 11:24:22 +0000 (11:24 +0000)]
Unreviewed.

[Qt] Search input field doesn't have cancel button
https://bugs.webkit.org/show_bug.cgi?id=42887

* platform/qt/Skipped: fast/forms/search-cancel-button-events.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Fri, 23 Jul 2010 10:02:51 +0000 (10:02 +0000)]
2010-07-23  Marcus Bulach  <bulach@chromium.org>

        Unreviewed. Adds expectations for chromium.

        [chromium] Updates baselines following changes in history (http://trac.webkit.org/changeset/63925)
        https://bugs.webkit.org/show_bug.cgi?id=42884

        * platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Added.
        * platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Fri, 23 Jul 2010 09:02:17 +0000 (09:02 +0000)]
2010-07-22  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Updates baselines following changes in border drawing code (http://trac.webkit.org/changeset/63864).
        https://bugs.webkit.org/show_bug.cgi?id=42822

        * platform/chromium-linux/fast/borders/different-color-borders-expected.checksum: Added.
        * platform/chromium-linux/fast/borders/different-color-borders-expected.png: Added.
        * platform/chromium-linux/fast/borders/different-color-borders-expected.txt: Added.
        * platform/chromium-mac/fast/borders/border-radius-constraints-expected.checksum:
        * platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
        * platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.checksum:
        * platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
        * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
        * platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum:
        * platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum:
        * platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum:
        * platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Added.
        * platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusInset01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
        * platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png:
        * platform/chromium-mac/fast/borders/different-color-borders-expected.checksum: Added.
        * platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
        * platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png:
        * platform/chromium-mac/fast/css/nested-rounded-corners-expected.checksum: Added.
        * platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Added.
        * platform/chromium-mac/fast/forms/basic-selects-expected.checksum:
        * platform/chromium-mac/fast/forms/basic-selects-expected.png:
        * platform/chromium-mac/fast/forms/menulist-clip-expected.checksum:
        * platform/chromium-mac/fast/forms/menulist-clip-expected.png:
        * platform/chromium-mac/fast/forms/menulist-narrow-width-expected.checksum:
        * platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png:
        * platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum:
        * platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
        * platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum:
        * platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png:
        * platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum:
        * platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
        * platform/chromium-mac/fast/forms/select-baseline-expected.checksum:
        * platform/chromium-mac/fast/forms/select-baseline-expected.png:
        * platform/chromium-mac/fast/overflow/border-radius-clipping-expected.checksum:
        * platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win-xp/fast/css/nested-rounded-corners-expected.png: Added.
        * platform/chromium-win/fast/css/nested-rounded-corners-expected.checksum: Added.
        * platform/chromium-win/fast/css/nested-rounded-corners-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Jul 2010 08:37:15 +0000 (08:37 +0000)]
2010-07-23  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Kent Tamura.

        Backslash isn't transcoded in <input>
        https://bugs.webkit.org/show_bug.cgi?id=42878

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
2010-07-23  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Kent Tamura.

        Backslash isn't transcoded in <input>
        https://bugs.webkit.org/show_bug.cgi?id=42878

        * editing/selection/find-yensign-and-backslash-expected.txt:
        * platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
        * platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
        * platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 23 Jul 2010 07:28:24 +0000 (07:28 +0000)]
2010-07-23  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Roll Chromium revision
        https://bugs.webkit.org/show_bug.cgi?id=42876

        * DEPS: Roll Chromium revision to r53434 in order to have the
        logger initialization change (r53303)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Jul 2010 07:17:34 +0000 (07:17 +0000)]
2010-07-23  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Put a failing result for now.

        Backslash is transcoded into yen sign even when non japanese font is specified
        https://bugs.webkit.org/show_bug.cgi?id=39654

        * editing/selection/find-yensign-and-backslash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rolling out r63947 and r63948, because they broke Qt Windows build.
ossy@webkit.org [Fri, 23 Jul 2010 07:03:14 +0000 (07:03 +0000)]
Unreviewed rolling out r63947 and r63948, because they broke Qt Windows build.

* jit/JITStubs.cpp:
* jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 23 Jul 2010 06:47:03 +0000 (06:47 +0000)]
2010-07-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        media/video-duration-known-after-eos.html test is slow
        https://bugs.webkit.org/show_bug.cgi?id=42809

        Seek near the end of the media to speed the test up.

        * media/video-duration-known-after-eos-expected.txt:
        * media/video-duration-known-after-eos.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 23 Jul 2010 06:39:07 +0000 (06:39 +0000)]
2010-07-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: CodeGeneratorInspector was extended and now it can
        generate InspectorBackedDispatcher's code. This dispatcher will
        validate and dispatch incoming inspector commands only by native
        code without using javaScript. That is necessary step for
        RemoteDebugging support.
        https://bugs.webkit.org/show_bug.cgi?id=42588

        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::inspectorBackendDispatcher):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.setDocument):

2010-07-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: CodeGeneratorInspector was extended and now it can
        generate InspectorBackedDispatcher's code. This dispatcher will
        validate and dispatch incoming inspector commands only by native
        code without using javaScript. That is necessary step for
        RemoteDebugging support.
        https://bugs.webkit.org/show_bug.cgi?id=42588

        * src/ToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
        * src/WebDevToolsAgentImpl.h:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl.prototype.callInspectorController_):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Jul 2010 06:26:09 +0000 (06:26 +0000)]
2010-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Add expectations for Qt and Gtk.

        Backslash is transcoded into yen sign even when non japanese font is specified
        https://bugs.webkit.org/show_bug.cgi?id=39654

        * platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
        * platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Jul 2010 05:39:21 +0000 (05:39 +0000)]
2010-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Kent Tamura.

        Backslash is transcoded into yen sign even when non japanese font is specified
        https://bugs.webkit.org/show_bug.cgi?id=39654

        * fast/text/backslash-to-yen-sign-euc.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
        * platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
        * platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
2010-07-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Kent Tamura.

        Backslash is transcoded into yen sign even when non japanese font is specified
        https://bugs.webkit.org/show_bug.cgi?id=39654

        Test: fast/text/backslash-to-yen-sign-euc.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Call FontDescriptor::setIsSpecifiedFont.
        * platform/graphics/Font.cpp:
        (WebCore::Font::Font):
        * platform/graphics/FontDescription.h: Added m_isSpecifiedFont and its accessors.
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::isSpecifiedFont):
        (WebCore::FontDescription::setIsSpecifiedFont):
        (WebCore::FontDescription::operator==):
        * platform/text/transcoder/FontTranscoder.cpp:
        (WebCore::FontTranscoder::converterType): Don't transcode backslashes if a font family is explicitly specified.
        (WebCore::FontTranscoder::convert):
        (WebCore::FontTranscoder::needsTranscoding):
        * platform/text/transcoder/FontTranscoder.h: Change the arguments from AtomicString fontFamily to Font.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::updateNeedsTranscoding):
        (WebCore::RenderText::setTextInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
darin@apple.com [Fri, 23 Jul 2010 03:46:35 +0000 (03:46 +0000)]
Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42847

Reviewed by Sam Weinig.

WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Removed WKBundleFrameCopyInnerText.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
* WebProcess/WebPage/WebFrame.cpp: Removed innerText.
* WebProcess/WebPage/WebFrame.h: Ditto.

WebKitTools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<): Replaced the WKStringToUTF8 function with
a set of overloaded stream operators.
(WTR::dumpPath): Changed to use ostringstream and return a string.
(WTR::propertyValue): Added.
(WTR::propertyObject): Added.
(WTR::propertyString): Added.
(WTR::numericWindowPropertyValue): Changed to call propertyValue.
(WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::dumpFrameText): Use propertyObject and propertyString instead of
WKBundleFrameCopyInnerText.
(WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::InjectedBundlePage::dump): Ditto.
(WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEeeep! r63947 hosed all non-x86 builds!
barraclough@apple.com [Fri, 23 Jul 2010 03:43:51 +0000 (03:43 +0000)]
Eeeep! r63947 hosed all non-x86 builds!

* jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 42818 - [Qt] REGRESSION(63348): jsc is broken
barraclough@apple.com [Fri, 23 Jul 2010 03:28:34 +0000 (03:28 +0000)]
Bug 42818 - [Qt] REGRESSION(63348): jsc is broken
Speculative fix, need fastcall conventions on Qt/Win.

Reviewed by Oliver Hunt.

* jit/JITStubs.cpp:
* jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 23 Jul 2010 03:24:53 +0000 (03:24 +0000)]
2010-07-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Do more constant folding
        https://bugs.webkit.org/show_bug.cgi?id=42867

        Constant fold a few more operations.  SunSpider says this is
        a win but I suspect that's just code motion at play.

        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::makeModNode):
        (JSC::ASTBuilder::makeURightShiftNode):
        (JSC::ASTBuilder::makeBitOrNode):
        (JSC::ASTBuilder::makeBitAndNode):
        (JSC::ASTBuilder::makeBitXOrNode):
        (JSC::ASTBuilder::makeBinaryNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
jhoneycutt@apple.com [Fri, 23 Jul 2010 03:20:31 +0000 (03:20 +0000)]
Windows build fix.

Commit some changes missed by the commit-queue in r63944.

* platform/win/BitmapInfo.h:
(WebCore::BitmapInfo::is16bit):
(WebCore::BitmapInfo::is32bit):
(WebCore::BitmapInfo::width):
(WebCore::BitmapInfo::height):
(WebCore::BitmapInfo::size):
(WebCore::BitmapInfo::paddedWidth):
(WebCore::BitmapInfo::numPixels):
(WebCore::BitmapInfo::paddedBytesPerLine):
(WebCore::BitmapInfo::bytesPerLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 02:55:21 +0000 (02:55 +0000)]
2010-07-22  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Add additonal methods to BitmapInfo.
        https://bugs.webkit.org/show_bug.cgi?id=42071

        Added a parameter to create 16bit BitmapInfo and
        some additional accessors for the WinCE port.

        Set bmiHeader.biSize only at constructor.

        * platform/win/BitmapInfo.cpp: Added property svn:eol-style.
        (WebCore::bitmapInfoForSize):
        (WebCore::BitmapInfo::create):
        (WebCore::BitmapInfo::createBottomUp):
        * platform/win/BitmapInfo.h: Added property svn:eol-style.
        (WebCore::BitmapInfo::is16bit):
        (WebCore::BitmapInfo::is32bit):
        (WebCore::BitmapInfo::width):
        (WebCore::BitmapInfo::height):
        (WebCore::BitmapInfo::size):
        (WebCore::BitmapInfo::paddedWidth):
        (WebCore::BitmapInfo::numPixels):
        (WebCore::BitmapInfo::paddedBytesPerLine):
        (WebCore::BitmapInfo::bytesPerLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 23 Jul 2010 02:36:02 +0000 (02:36 +0000)]
2010-07-22  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        Autoscroll on selection should take scrollbars into account as outside of the content.
        https://bugs.webkit.org/show_bug.cgi?id=40403

        ScrollView's scroll-bar was considered as a part of content rect,
        that prevents autoscroll to happen when the pointer is over the
        scroll-bar.  This change excluded scroll-bar region from scrolling
        delta calculation.

        Test: WebCore/manual-tests/autoscroll-over-scrollbar.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agomaxLength should not be applied to non-text types
tkent@chromium.org [Fri, 23 Jul 2010 02:29:32 +0000 (02:29 +0000)]
maxLength should not be applied to non-text types
https://bugs.webkit.org/show_bug.cgi?id=42814

Reviewed by Darin Adler.

WebCore:

According to the HTML5 specification, maxLength attribute should
be applied to text, search, url, tel, email, and password types.

Test: fast/forms/input-maxlength-unsupported.html

* dom/InputElement.cpp:
(WebCore::InputElement::handleBeforeTextInsertedEvent):
 Apply maxLength() only if supportsMaxLength() is true.
* dom/InputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::patternMismatch):
 Code cleanup by isTextType().
(WebCore::HTMLInputElement::tooLong):
 ditto.
(WebCore::HTMLInputElement::isTextType):
 Added. This returns true for types with maxLength/pattern/placeholder.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::supportsMaxLength):
 Added. Just calls isTextType().
(WebCore::HTMLInputElement::supportsPlaceholder):
 Code cleanup by isTextType().
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::supportsMaxLength):
 Added. Always returns true.

LayoutTests:

* fast/forms/input-maxlength-unsupported-expected.txt: Added.
* fast/forms/input-maxlength-unsupported.html: Added.
* fast/forms/script-tests/input-maxlength-unsupported.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[cleanup] logic to extract adjacent lists and list children in listifyParagraph and...
rniwa@webkit.org [Fri, 23 Jul 2010 02:26:47 +0000 (02:26 +0000)]
[cleanup] logic to extract adjacent lists and list children in listifyParagraph and unlistifyParagraph should be isolated
https://bugs.webkit.org/show_bug.cgi?id=42841

Reviewed by Kent Tamura.

Added enclosingListChild that takes the list node containing the node for the second argument
to ensure that it only returns the enclosing list child of the specified list node.

Added adjacentEnclosingList that finds adjacent lists of the specified position.
It takes the current position, the adjacent position that may or may not have a list, and the list type,
and avoids a list that belongs to a different table cell or an outer list that contains the current position.

No new tests needed.

* editing/InsertListCommand.cpp:
(WebCore::enclosingListChild): Added. See above.
(WebCore::InsertListCommand::unlistifyParagraph): Uses enclosingListChild.
(WebCore::adjacentEnclosingList): Added. See above.
(WebCore::InsertListCommand::listifyParagraph): Uses adjacentEnclosingList.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 02:15:09 +0000 (02:15 +0000)]
2010-07-22  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WIN] Correct DeleteObject usage in PasteboardWin
        https://bugs.webkit.org/show_bug.cgi?id=41956

        Call DeleteObject() if OpenClipboard() fails and don't
        call DeleteObject() on objects returned from SelectObject().

        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Fri, 23 Jul 2010 02:02:57 +0000 (02:02 +0000)]
2010-07-22  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Log function is incorrectly used.
        r63804 used LOG function, but it should receive one more parameter.
        Used LOG_ERROR instead, since this is an error message.
        https://bugs.webkit.org/show_bug.cgi?id=42842

        * platform/efl/WidgetEfl.cpp:
        (WebCore::Widget::applyFallbackCursor): use LOG_ERROR in place of LOG

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago More Windows build fixing.
ap@apple.com [Fri, 23 Jul 2010 01:56:20 +0000 (01:56 +0000)]
    More Windows build fixing.

        * win/WebKit2Generated.make: Copy the new public headers to $(WEBKITOUTPUTDIR)\include\WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fix.
ap@apple.com [Fri, 23 Jul 2010 01:30:00 +0000 (01:30 +0000)]
    Windows build fix.

        * win/WebKit2.vcproj: Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Fri, 23 Jul 2010 01:24:09 +0000 (01:24 +0000)]
2010-07-22  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Darin Adler.

        SVG: Temporarily disable the layout test for the bug 41175 on Leopard.
        https://bugs.webkit.org/show_bug.cgi?id=42802

        * platform/mac-leopard/Skipped: svg/filters/filter-empty-g.svg skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Fri, 23 Jul 2010 01:11:17 +0000 (01:11 +0000)]
2010-07-22  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Implement input method notification
        https://bugs.webkit.org/show_bug.cgi?id=42640

        Notify browser when keyboard should be shown/hidden. Input method
        hints are updated before sending the signal. Client should be able to
        determine the input type by calling ewk_view_imh_get().

        * efl/EWebLauncher/main.c:
        (on_inputmethod_changed): example implementation that just prints to
        stdout if keyboard should be shown or hidden and the imh flags.
        (browserCreate): listen to signal about input method changing its
        state.
        * efl/WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::setInputMethodState): call new function
        responsible for implementing this notification.
        * efl/ewk/ewk_private.h: ewk_view_input_method_state_set() is called
        only from inside WebKit.
        * efl/ewk/ewk_view.cpp: implement setters and getters
        (ewk_view_imh_get):
        (ewk_view_input_method_state_set):
        * efl/ewk/ewk_view.h: introduce Ewk_Imh enum which contains the
        possible input types.
        (_Ewk_View_Smart_Class::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 John Gregg <johnnyg@google.com>
johnnyg@google.com [Fri, 23 Jul 2010 00:59:06 +0000 (00:59 +0000)]
2010-07-22  John Gregg  <johnnyg@google.com>

        Unreviewed; chromium test expectation change.

        fast/forms/input-file-directory-upload.html passes on windows after r63914
        https://bugs.webkit.org/show_bug.cgi?id=42768

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Sam Weinig and Darin Adler.
ap@apple.com [Fri, 23 Jul 2010 00:49:55 +0000 (00:49 +0000)]
    Reviewed by Sam Weinig and Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=42193
        Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

        Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
        fixed, but this makes difference one line smaller on many editing tests.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
        * WebProcess/InjectedBundle/API/c/WKBundleBase.h:
        * WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Added.
        (WKBundleNodeCopyNodeName):
        (WKBundleNodeGetParent):
        * WebProcess/InjectedBundle/API/c/WKBundleNode.h: Added.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSetEditorClient):
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Added.
        (WKBundleRangeGetStartOffset):
        (WKBundleRangeGetStartContainer):
        (WKBundleRangeGetEndOffset):
        (WKBundleRangeGetEndContainer):
        * WebProcess/InjectedBundle/API/c/WKBundleRange.h: Added.
        Added WKBundleRangeRef and WKBundleNodeRef types for injected bundles. These are just pointers
        to respective WebCore objects, without any WebKit2 wrappers.

        * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: Added.
        (WebKit::InjectedBundlePageEditorClient::InjectedBundlePageEditorClient):
        (WebKit::InjectedBundlePageEditorClient::initialize):
        (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
        * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Added.
        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::shouldBeginEditing):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::initializeInjectedBundleEditorClient):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::injectedBundleEditorClient):
        Added the plumbing for invoking injected bundle code for editor client. There is no real API
        for editor client yet.

WebKitTools:
        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added dumpEditingCallbacks() and setAcceptsEditing().

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
        (WTR::operator<<): Print a range.
        (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
        clients.
        (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
        (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
        calls.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::LayoutTestController):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (WTR::LayoutTestController::dumpEditingCallbacks):
        (WTR::LayoutTestController::setAcceptsEditing):
        (WTR::LayoutTestController::acceptsEditing):
        (WTR::LayoutTestController::shouldDumpEditingCallbacks):
        Store m_acceptsEditing and m_dumpEditingCallbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 23 Jul 2010 00:43:29 +0000 (00:43 +0000)]
2010-07-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ojan Vafai.

        Cancel button of search input field should fire input/change events
        https://bugs.webkit.org/show_bug.cgi?id=34393

        * fast/forms/script-tests/search-cancel-button-events.js: Added.
        * fast/forms/search-cancel-button-events-expected.txt: Added.
        * fast/forms/search-cancel-button-events.html: Added.
2010-07-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ojan Vafai.

        Cancel button of search input field should fire input/change events
        https://bugs.webkit.org/show_bug.cgi?id=34393

        Test: fast/forms/search-cancel-button-events.html

        * rendering/TextControlInnerElements.cpp:
        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/8222626>
weinig@apple.com [Fri, 23 Jul 2010 00:37:03 +0000 (00:37 +0000)]
Fix for <rdar://problem/8222626>
Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.

Reviewed by Maciej Stachowiak.

WebCore:

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Update project files.

* dom/UserTypingGestureIndicator.cpp: Copied from dom/UserGestureIndicator.cpp.
(WebCore::UserTypingGestureIndicator::processingUserTypingGesture):
(WebCore::focusedNode):
(WebCore::UserTypingGestureIndicator::focusedElementAtGestureStart):
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
(WebCore::UserTypingGestureIndicator::~UserTypingGestureIndicator):
* dom/UserTypingGestureIndicator.h: Copied from dom/UserGestureIndicator.h.
Version of UserGestureIndicator that just tracks keyboard gestures and the focused
node they were targeting.

* editing/Editor.cpp:
(WebCore::Editor::confirmComposition):
(WebCore::Editor::setComposition):
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
Put UserTypingGestureIndicator on the stack for user generated keyboard events.

WebKit/mac:

The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually

* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextField):

WebKit/win:

The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually

* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::textDidChangeInTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 23 Jul 2010 00:32:24 +0000 (00:32 +0000)]
2010-07-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ojan Vafai.

        <input type=number> stepper buttons should dispatch input/change events
        https://bugs.webkit.org/show_bug.cgi?id=42440

        * fast/forms/input-number-events-expected.txt: Added.
        * fast/forms/input-number-events.html: Added.
        * fast/forms/script-tests/input-number-events.js: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-07-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ojan Vafai.

        <input type=number> stepper buttons should dispatch input/change events
        https://bugs.webkit.org/show_bug.cgi?id=42440

        Test: fast/forms/input-number-events.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepUpFromRenderer):
         Sets a flag to dispatch 'change' event and dispatches 'input' event
         if the value is changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 23 Jul 2010 00:29:11 +0000 (00:29 +0000)]
2010-07-22  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Make history state methods validate against document URL
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Test: fast/history/history-replace-illegal.html

        * page/History.cpp:
        (WebCore::History::urlForState):
2010-07-22  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Make history state methods validate against document URL
        https://bugs.webkit.org/show_bug.cgi?id=42858

        * fast/history/history-replace-illegal-expected.txt: Added.
        * fast/history/history-replace-illegal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen there are no beforeload listeners on a document,
aestes@apple.com [Fri, 23 Jul 2010 00:25:17 +0000 (00:25 +0000)]
When there are no beforeload listeners on a document,
HTMLLinkElement::process() should be called immediately when the node is
inserted into the document, rather than waiting until after attach is
performed.
<https://bugs.webkit.org/show_bug.cgi?id=42859>
<rdar://problem/8194528>

Reviewed by Maciej Stachowiak.

No new tests.

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedIntoDocument): If there are no
beforeload listeners, call process() immediately.  Otherwise, add it as
a post-attach callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 23 Jul 2010 00:18:58 +0000 (00:18 +0000)]
2010-07-22  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        REGRESSION: box shadows on WebGL canvas elements repainted every frame
        https://bugs.webkit.org/show_bug.cgi?id=42852

        Avoid calling HTMLCanvasElement::willDraw() every time a WebGL canvas'
        contents update.  This call is only needed in the non-compositing
        rendering path.

        Covered by fast/canvas/webgl/canvas-test.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::markContextChanged):
        (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 23 Jul 2010 00:05:51 +0000 (00:05 +0000)]
2010-07-22  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: test that inspector will log syntax error in console without crashing
        https://bugs.webkit.org/show_bug.cgi?id=42831

        * inspector/console-log-syntax-error-expected.txt: Added.
        * inspector/console-log-syntax-error.html: Added.
        * inspector/resources/syntax-error.js: Added.
        * platform/chromium/inspector/console-log-syntax-error-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Thu, 22 Jul 2010 23:52:15 +0000 (23:52 +0000)]
2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=41413

        Add a DRT API to set a flag so that notification requests are ignored,
        and add a test for cancelling a pending notification request.
        New API and test are disabled for Chromium port.

        * fast/notifications/notifications-cancel-request-permission-expected.txt: Added.
        * fast/notifications/notifications-cancel-request-permission.html: Added.
        * fast/notifications/resources: Added.
        * fast/notifications/resources/notifications-cancel-request-permission.html: Added.
        * platform/chromium/test_expectations.txt:
2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=41413

        Remove DumpRenderTree private API and introduce new API.
        Also add support for informing the UI when a notification request is cancelled.

        * Api/qwebpage.cpp:
        (QWebPage::setUserPermission):
        * Api/qwebpage.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (WebCore::NotificationPresenterClientQt::requestPermission):
        (WebCore::NotificationPresenterClientQt::checkPermission):
        (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
        (WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
        (WebCore::NotificationPresenterClientQt::toPage):
        (WebCore::NotificationPresenterClientQt::toFrame):
        * WebCoreSupport/NotificationPresenterClientQt.h:
2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=41413

        Update DumpRenderTree and QtTestBrowser to use the new API.
        Add new DRT API to flag that notifications permission requests should be ignored.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::requestPermission):
        (WebCore::WebPage::checkPermission):
        (WebCore::WebPage::cancelRequestsForPermission):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
        (LayoutTestController::checkDesktopNotificationPermission):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::ignoreReqestForPermission):
        * QtTestBrowser/main.cpp:
        (LauncherWindow::LauncherWindow):
        * QtTestBrowser/webpage.cpp:
        (WebPage::WebPage):
        (WebPage::requestPermission):
        (WebPage::checkPermission):
        (WebPage::cancelRequestsForPermission):
        * QtTestBrowser/webpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdapt sandbox for new WebProcess bootstrap service naming scheme.
andersca@apple.com [Thu, 22 Jul 2010 23:32:17 +0000 (23:32 +0000)]
Adapt sandbox for new WebProcess bootstrap service naming scheme.
<rdar://problem/8225000>

Patch by Ivan Krstić <ike@apple.com> on 2010-07-22
Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Thu, 22 Jul 2010 23:16:37 +0000 (23:16 +0000)]
2010-07-22  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Ojan Vafai.

        Remove useless PlatformScrollBar
        https://bugs.webkit.org/show_bug.cgi?id=41911

        * WebCore.gypi:
        * platform/win/PlatformScrollBar.h: Removed.
        * platform/win/PlatformScrollBarWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows] Home hey doesn't work in first DIV inside a TABLE
rniwa@webkit.org [Thu, 22 Jul 2010 22:55:21 +0000 (22:55 +0000)]
[Windows] Home hey doesn't work in first DIV inside a TABLE
https://bugs.webkit.org/show_bug.cgi?id=42767

Reviewed by Ojan Vafai.

WebCore:

The bug was caused by positionAvoidingFirstPositionInTable moving outside of the editing region.
Added a check so that it avoids the first position in the table only if the table is editable.

Test: editing/selection/home-inside-noneditable-table.html

* editing/visible_units.cpp:
(WebCore::positionAvoidingFirstPositionInTable):

LayoutTests:

Added a test to move caret backwards to the line boundary inside a content-editable div
inside a non-editable table.

* editing/selection/home-inside-noneditable-table-expected.txt: Added.
* editing/selection/home-inside-noneditable-table.html: Added.
* resources/dump-as-markup.js: Modified to support multiple calls to dump
(Markup.dump.get if):
(Markup.dump):
(Markup.notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIt should be possible to attach to the WebProcess in gdb during startup
andersca@apple.com [Thu, 22 Jul 2010 22:18:50 +0000 (22:18 +0000)]
It should be possible to attach to the WebProcess in gdb during startup
https://bugs.webkit.org/show_bug.cgi?id=42853

Reviewed by Adam Roben.

Create an unique bootstrap service name and pass it to the web process, instead of registering a per process
name (which was incorrect anyway). This lets us get rid of the requirement that the UI process always should be
the parent process of the web process, something which is false when running under the debugger.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't assert when Connection::invalidate is called before Connection::dispatchConnect...
andersca@apple.com [Thu, 22 Jul 2010 21:58:17 +0000 (21:58 +0000)]
Don't assert when Connection::invalidate is called before Connection::dispatchConnectionDidClose
https://bugs.webkit.org/show_bug.cgi?id=42851

Reviewed by Sam Weinig.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchConnectionDidClose):
Just return early if m_client is 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build warning for missing parentheses.
tonikitoo@webkit.org [Thu, 22 Jul 2010 21:34:13 +0000 (21:34 +0000)]
Fix build warning for missing parentheses.

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore/html/HTMLInputElement.cpp:113: warning: suggest parentheses around '&&' within '||'

* html/HTMLInputElement.cpp:
(WebCore::isNumberCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 22 Jul 2010 21:26:55 +0000 (21:26 +0000)]
2010-07-22  John Gregg  <johnnyg@google.com>

        Reviewed by Kent Tamura.

        [chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
        https://bugs.webkit.org/show_bug.cgi?id=42768

        Normalize path separators for the script API by convering \'s to /'s.

        Covered by input-file-directory-upload.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setFileListFromRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger
aroben@apple.com [Thu, 22 Jul 2010 21:25:32 +0000 (21:25 +0000)]
Use ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger

While ::DebugBreak can make it easier to attach a debugger (because it
brings up the Just-in-Time debugger window), using ::MessageBox has
two advantages:
  1) It explains to the user what's going on, so it's harder to
     mistake this debugging aid for a bug.
  2) It allows you to debug the UI process and the web process using
     the same debugger, if desired.

Special thanks to John Sullivan for help with the text that's shown in
the alert.

Fixes <http://webkit.org/b/42848> WebKit2's wait-for-debugger
debugging aid should explain to the user what's happening

Reviewed by John Sullivan and Anders Carlsson.

* WebProcess/WebKitMain.cpp:
(WebKitMain): Use a ::MessageBox instead of a ::DebugBreak to wait for
the debugger. The alert explains to the user what's going on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WorkQueue aware of potential errors with ::WaitForMultipleObjects
aroben@apple.com [Thu, 22 Jul 2010 21:25:13 +0000 (21:25 +0000)]
Make WorkQueue aware of potential errors with ::WaitForMultipleObjects

Fixes <http://webkit.org/b/42846> WorkQueue should detect
::WaitForMultipleObject failures

Reviewed by Anders Carlsson.

* Platform/win/WorkQueueWin.cpp:
(WorkQueue::workQueueThreadBody): Added some assertions about the
various things that can fail with ::WaitForMultipleObjects,
specifically:
  - Passing too many objects
  - Timeouts (which shouldn't happen since we pass a timeout interval
    of INFINITE)
  - Abandoned mutexes (which shouldn't happen since we don't wait on
    any mutexes currently)
  - Miscellaneous failures

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Simon Fraser.
dimich@chromium.org [Thu, 22 Jul 2010 21:06:00 +0000 (21:06 +0000)]
Rubberstamped by Simon Fraser.

* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies): Add initialization of m_localizationStrategy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
dumi@chromium.org [Thu, 22 Jul 2010 20:56:49 +0000 (20:56 +0000)]
WebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::execute):

LayoutTests: Simplify some tests, and make sure db.changeVersion()'s third parameter is optional.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

* fast/workers/storage/resources/change-version-sync-1.js:
* fast/workers/storage/resources/change-version-sync-2.js:
* storage/change-version.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 22 Jul 2010 20:43:06 +0000 (20:43 +0000)]
2010-07-22  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        * platform/chromium/test_expectations.txt:
        Updated expectations to match reality on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-20 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Thu, 22 Jul 2010 20:33:08 +0000 (20:33 +0000)]
2010-07-20  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Darin Adler.

        Code Generator: Allow negative and string constants.
        Also add tests for hexadecimal numbers.

        * bindings/scripts/CodeGeneratorJS.pm:
        If it is a string, do not try to cast it to an int.

        * bindings/scripts/IDLStructure.pm:
        Add a regex just for constant values that allows strings, hexadecimal numbers, and integral numbers.

        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        Update the tests.

        * bindings/scripts/test/JS/JSTestObj.cpp:
        Ditto.

        * bindings/scripts/test/JS/JSTestObj.h:
        Ditto.

        * bindings/scripts/test/ObjC/DOMTestObj.h:
        Ditto.

        * bindings/scripts/test/TestObj.idl:
        Add tests for negative numbers, strings, and hexadecimal numbers.

        * bindings/scripts/test/V8/V8TestObj.cpp:
        Update the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 22 Jul 2010 20:17:38 +0000 (20:17 +0000)]
2010-07-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Composited layers don't scroll in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=42771

        More prep work: make a single scrollPositionChanged() bottleneck method, and use it to
        send the scroll event, repaint fixed elements, and update compositing layers.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
        (WebCore::FrameView::scrollPositionChanged):
        (WebCore::FrameView::repaintFixedElementsAfterScrolling):
        (WebCore::FrameView::valueChanged):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::valueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 22 Jul 2010 20:00:39 +0000 (20:00 +0000)]
2010-07-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
        https://bugs.webkit.org/show_bug.cgi?id=42325

        * platform/mac-wk2/Skipped: Removed a duplicate and sorted lists of tests.
        Added some tests to the pasteboard list. Removed the tests from the
        dumpChildFramesAsText list that now pass, and moved others to other lists.
2010-07-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
        https://bugs.webkit.org/show_bug.cgi?id=42325

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added dumpChildFramesAsText.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::dumpFrameText): Added.
        (WTR::dumpDescendantFramesText): Added.
        (WTR::InjectedBundlePage::dumpAllFramesText): Added.
        (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
        instead of the shouldDumpAsText function, and added a case for AllFramesText.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
        m_whatToDump.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
        dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
        and shouldDumpSourceAsWebArchive. Added whatToDump.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-22 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 22 Jul 2010 18:39:31 +0000 (18:39 +0000)]
2010-07-22  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] Propagate return value of EventHandler::handleMouseWheelEvent
        to caller of WebViewImpl::handleInputEvent.

        https://bugs.webkit.org/show_bug.cgi?id=42835

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::mouseWheel):
        (WebKit::WebViewImpl::handleInputEvent):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=42836
weinig@apple.com [Thu, 22 Jul 2010 18:18:26 +0000 (18:18 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
Add localized strings stubs for WebKit2.

Reviewed by Anders Carlsson.

WebCore:

- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
  for localized strings.

Gets us below 200 tests failing in WebKitTestRunner.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/mac/WebCoreViewFactory.h:
* platform/LocalizationStrategy.h: Added.
(WebCore::LocalizationStrategy::~LocalizationStrategy):
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pluginStrategy):
(WebCore::PlatformStrategies::localizationStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::~PlatformStrategies):
* platform/mac/LocalizedStringsMac.mm:

WebKit/mac:

- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
  for localized strings.

Gets us below 200 tests failing in WebKitTestRunner.

* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
* WebCoreSupport/WebViewFactory.mm:

WebKit2:

Gets us below 200 tests failing in WebKitTestRunner.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63904 268f45cc-cd09-0410-ab3c-d52691b4dbfc