tony@chromium.org [Tue, 17 Jul 2012 17:14:36 +0000 (17:14 +0000)]
Unreviewed gardening. Remove tests that have been passing consistently according to the flakiness dashboard.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 16:54:59 +0000 (16:54 +0000)]
Rename CSS Exclusions CSSWrapShape class properties to match Exclusion shape function parameters
https://bugs.webkit.org/show_bug.cgi?id=89669
Patch by Hans Muller <hmuller@adobe.com> on 2012-07-17
Reviewed by Dirk Schulze.
Renamed left,top properties in the exclusion shape types to better match the specification
http://dev.w3.org/csswg/css3-exclusions/#shapes-from-svg-syntax:
WrapShapeRectangle, CSSWrapShapeRectangle - left,top should be x, y
WrapShapeCircle, CSSWrapShapeCircle - left,top should be centerX, centerY
WrapShapeEllipse, CSSWrapShapeEllipse - left,top should be centerX, centerY
No new tests or tests revisions were needed, the existing tests cover these APIs.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):
* css/CSSWrapShapes.cpp:
(WebCore::CSSWrapShapeRectangle::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
* css/CSSWrapShapes.h:
(WebCore::CSSWrapShapeRectangle::x):
(WebCore::CSSWrapShapeRectangle::y):
(WebCore::CSSWrapShapeRectangle::setX):
(WebCore::CSSWrapShapeRectangle::setY):
(CSSWrapShapeRectangle):
(WebCore::CSSWrapShapeCircle::centerX):
(WebCore::CSSWrapShapeCircle::centerY):
(WebCore::CSSWrapShapeCircle::setCenterX):
(WebCore::CSSWrapShapeCircle::setCenterY):
(CSSWrapShapeCircle):
(WebCore::CSSWrapShapeEllipse::centerX):
(WebCore::CSSWrapShapeEllipse::centerY):
(WebCore::CSSWrapShapeEllipse::setCenterX):
(WebCore::CSSWrapShapeEllipse::setCenterY):
(CSSWrapShapeEllipse):
* css/WrapShapeFunctions.cpp:
(WebCore::valueForWrapShape):
(WebCore::wrapShapeForValue):
* rendering/style/WrapShapes.h:
(WebCore::WrapShapeRectangle::x):
(WebCore::WrapShapeRectangle::y):
(WebCore::WrapShapeRectangle::setX):
(WebCore::WrapShapeRectangle::setY):
(WrapShapeRectangle):
(WebCore::WrapShapeCircle::centerX):
(WebCore::WrapShapeCircle::centerY):
(WebCore::WrapShapeCircle::setCenterX):
(WebCore::WrapShapeCircle::setCenterY):
(WrapShapeCircle):
(WebCore::WrapShapeEllipse::centerX):
(WebCore::WrapShapeEllipse::centerY):
(WebCore::WrapShapeEllipse::setCenterX):
(WebCore::WrapShapeEllipse::setCenterY):
(WrapShapeEllipse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 17 Jul 2012 16:32:25 +0000 (16:32 +0000)]
Web Inspector: implement search / replace in source files (behind experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=91394
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change adds "loop" parameter to the go to next / previous search + adds a UI component
for search / replace of text in the sources panel. New UI component is behind the experiment.
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._updateFilter):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.performSearch):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
(WebInspector.Panel.prototype.canSearchAndReplace):
(WebInspector.Panel.prototype.replaceSelectionWith):
(WebInspector.Panel.prototype.replaceAllWith):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype.showSearchField):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onInput):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._toggleReplaceVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.createSearchRegex):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.commitEditing):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype._commitEditing):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
* inspector/front-end/inspector.css:
(.search-replace):
(.search-replace:focus):
(.toolbar-search-navigation-controls):
(.toolbar-search-navigation.enabled):
(.toolbar-search):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search button):
(.toolbar-search button:active):
(.toolbar-search-control):
(.toolbar-replace-control):
(.toolbar-search-navigation.enabled:active):
(.toolbar-search-navigation.toolbar-search-navigation-prev):
(.toolbar-search-navigation.toolbar-search-navigation-prev.enabled:active):
(.toolbar-search-navigation.toolbar-search-navigation-next):
(.toolbar-search-navigation.toolbar-search-navigation-next.enabled:active):
(.drawer-header-close-button):
(.inspector-footer):
LayoutTests:
* inspector/debugger/pause-in-inline-script.html:
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-url-comment.html:
* inspector/editor/indentation.html:
* inspector/editor/text-editor-line-breaks.html:
* inspector/editor/text-editor-model.html:
* inspector/editor/text-editor-undo-redo.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 17 Jul 2012 15:25:23 +0000 (15:25 +0000)]
Unreviewed chromium expectations fix.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 14:51:54 +0000 (14:51 +0000)]
[Qt][V8] Remove the V8 related codepaths and configuration
https://bugs.webkit.org/show_bug.cgi?id=90863
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-07-17
Reviewed by Simon Hausmann.
.:
* Source/api.pri:
* WebKit.pro:
Source/WebCore:
No new tests because no new functionality.
* DerivedSources.pri:
* Target.pri:
* WebCore.gypi:
* WebCore.pri:
* bindings/v8/ScriptCachedFrameData.cpp:
* bindings/v8/ScriptCachedFrameData.h:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptControllerQt.cpp: Removed.
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):
* config.h:
Source/WebKit/qt:
* Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize):
* Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
* v8/ForwardingHeaders/v8-debug.h: Removed.
* v8/ForwardingHeaders/v8-preparser.h: Removed.
* v8/ForwardingHeaders/v8-profiler.h: Removed.
* v8/ForwardingHeaders/v8-testing.h: Removed.
* v8/ForwardingHeaders/v8.h: Removed.
* v8/ForwardingHeaders/v8stdint.h: Removed.
Source/WTF:
* WTF.pri:
Tools:
* Scripts/build-webkit: Remove --v8 option.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 17 Jul 2012 14:45:30 +0000 (14:45 +0000)]
[GTK] Don't use deprecated soup API in WebKit2APITests/TestResources
https://bugs.webkit.org/show_bug.cgi?id=91496
Reviewed by Martin Robinson.
soup_message_headers_get() is deprecated, use
soup_message_headers_get_one() instead.
* UIProcess/API/gtk/tests/TestResources.cpp:
(serverCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 13:51:25 +0000 (13:51 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=91479
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-17
* platform/efl/Skipped:
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 13:45:32 +0000 (13:45 +0000)]
[Qt] fast/box-{shadow,sizing} tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91397
Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-17
Reviewed by Simon Hausmann.
Updated expected Qt results for most box-shadow/ and box-sizing layout tests,
after testfonts changes made by bug 85203.
* platform/qt-5.0/Skipped:
* platform/qt/fast/box-shadow/basic-shadows-expected.png:
* platform/qt/fast/box-shadow/basic-shadows-expected.txt:
* platform/qt/fast/box-shadow/border-radius-big-expected.png:
* platform/qt/fast/box-shadow/border-radius-big-expected.txt:
* platform/qt/fast/box-shadow/box-shadow-radius-expected.txt:
* platform/qt/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/qt/fast/box-shadow/box-shadow-transformed-expected.txt:
* platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.txt:
* platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
* platform/qt/fast/box-shadow/inset-box-shadows-expected.txt:
* platform/qt/fast/box-shadow/inset-expected.png:
* platform/qt/fast/box-shadow/inset-expected.txt:
* platform/qt/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt:
* platform/qt/fast/box-shadow/transform-fringing-expected.png:
* platform/qt/fast/box-shadow/transform-fringing-expected.txt:
* platform/qt/fast/box-sizing/box-sizing-expected.png:
* platform/qt/fast/box-sizing/box-sizing-expected.txt:
* platform/qt/fast/box-sizing/panels-one-expected.png:
* platform/qt/fast/box-sizing/panels-one-expected.txt:
* platform/qt/fast/box-sizing/panels-two-expected.png:
* platform/qt/fast/box-sizing/panels-two-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Tue, 17 Jul 2012 13:23:04 +0000 (13:23 +0000)]
[QT] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
https://bugs.webkit.org/show_bug.cgi?id=91390
Reviewed by Zoltan Herczeg.
Fix the regression by using the proper imagetype conversion in ImageBuffer::platformTransformColorSpace.
The test is unskipped.
Source/WebCore:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
LayoutTests:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 17 Jul 2012 12:30:03 +0000 (12:30 +0000)]
[GTK] Fix a typo in WebKit2APITests/TestResources
https://bugs.webkit.org/show_bug.cgi?id=91495
Reviewed by Xan Lopez.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceLoading):
(testWebResourceResponse):
(testWebResourceMimeType):
(testWebResourceActiveURI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 17 Jul 2012 12:21:28 +0000 (12:21 +0000)]
[Qt] Unreviewed gardening after r122824.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-17
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 12:11:52 +0000 (12:11 +0000)]
Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
https://bugs.webkit.org/show_bug.cgi?id=91196
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-17
Reviewed by Pavel Feldman.
Source/WebCore:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel. Also refactored
InspectorController::connectFrontend() to receive
InspectorFrontendChannel.
No new test as code refactoring done.
* inspector/InspectorClient.h:
(WebCore):
(InspectorClient):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::reconnectFrontend):
* inspector/InspectorController.h:
(WebCore):
(InspectorController):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::openInspectorFrontend):
(WebCore::EmptyInspectorClient::hideHighlight):
Source/WebKit/blackberry:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::enableWebInspector):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::openInspectorFrontend):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
Source/WebKit/chromium:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::openInspectorFrontend):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::openInspectorFrontend):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
Source/WebKit/efl:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::openInspectorFrontend):
* WebCoreSupport/InspectorClientEfl.h:
(InspectorClientEfl):
Source/WebKit/gtk:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend):
* WebCoreSupport/InspectorClientGtk.h:
(InspectorClient):
Source/WebKit/mac:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
Source/WebKit/qt:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
* WebCoreSupport/InspectorClientQt.h:
(InspectorClientQt):
Source/WebKit/win:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
Source/WebKit/wince:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/InspectorClientWinCE.cpp:
(WebKit::InspectorClientWinCE::openInspectorFrontend):
* WebCoreSupport/InspectorClientWinCE.h:
(InspectorClientWinCE):
Source/WebKit/wx:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::openInspectorFrontend):
* WebKitSupport/InspectorClientWx.h:
(InspectorClientWx):
Source/WebKit2:
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 17 Jul 2012 11:37:43 +0000 (11:37 +0000)]
[Qt] REGRESSION(r122768, r122771) - it made ~ 160 fails on WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91490
Unreviewed gardening.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-17
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 17 Jul 2012 11:27:55 +0000 (11:27 +0000)]
Unreviewed, rolling out r122834.
http://trac.webkit.org/changeset/122834
https://bugs.webkit.org/show_bug.cgi?id=91492
it broke the chromium (Requested by kkristof on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-17
.:
* Source/api.pri:
* WebKit.pro:
Source/WebCore:
* DerivedSources.pri:
* Target.pri:
* WebCore.pri:
* bindings/v8/ScriptCachedFrameData.cpp:
(WebCore):
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
* bindings/v8/ScriptCachedFrameData.h:
(WebCore):
(ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptControllerQt.cpp: Copied from Source/WebCore/bindings/v8/ScriptCachedFrameData.cpp.
(WebCore):
(WebCore::ScriptController::qtScriptEngine):
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):
* config.h:
Source/WebKit/qt:
* Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
(QtWebElementRuntime::initialize):
* Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
(Bindings):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore):
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
(WebCore::FrameLoaderClientQt::willReleaseScriptContext):
(WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext):
(WebCore::FrameLoaderClientQt::createDocumentLoader):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):
* v8/ForwardingHeaders/v8-debug.h: Added.
* v8/ForwardingHeaders/v8-preparser.h: Added.
* v8/ForwardingHeaders/v8-profiler.h: Added.
* v8/ForwardingHeaders/v8-testing.h: Added.
* v8/ForwardingHeaders/v8.h: Added.
* v8/ForwardingHeaders/v8stdint.h: Added.
Source/WTF:
* WTF.pri:
Tools:
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 17 Jul 2012 11:11:55 +0000 (11:11 +0000)]
[GTK] Paste primary selection when middle clicking in X11 WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91411
Reviewed by Xan Lopez.
Handle middle click events to paste primary selection as expected
in any X11 application.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent): Call handleMousePressedEvent() for GTK+
platform.
* WebProcess/WebPage/WebPage.h:
(WebPage): Add handleMousePressedEvent() for GTK+ platform.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::handleMousePressedEvent): Handle middle click
events to paste primary selection like we do in WebKit1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 17 Jul 2012 10:58:50 +0000 (10:58 +0000)]
[Qt][V8] Remove the V8 related codepaths and configuration
https://bugs.webkit.org/show_bug.cgi?id=90863
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-07-17
Reviewed by Simon Hausmann.
.:
* Source/api.pri:
* WebKit.pro:
Source/WebCore:
No new tests, because there is no new functionality.
* DerivedSources.pri:
* Target.pri:
* WebCore.pri:
* bindings/v8/ScriptCachedFrameData.cpp:
* bindings/v8/ScriptCachedFrameData.h:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptControllerQt.cpp: Removed.
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::histogramEnumeration):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):
* config.h:
Source/WebKit/qt:
* Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
(convertWebElementVariantToJSValue):
(QtWebElementRuntime::initialize):
* Api/qwebframe.cpp:
(QWebFramePrivate::didClearWindowObject):
(QWebFramePrivate::addQtSenderToGlobalObject):
(QWebFrame::addToJavaScriptWindowObject):
(QWebFrame::evaluateJavaScript):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(convertNodeVariantToJSValue):
(QtDRTNodeRuntime::initialize):
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
(DumpRenderTreeSupportQt::garbageCollectorCollect):
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportQt::injectInternalsObject):
(DumpRenderTreeSupportQt::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createDocumentLoader):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
* v8/ForwardingHeaders/v8-debug.h: Removed.
* v8/ForwardingHeaders/v8-preparser.h: Removed.
* v8/ForwardingHeaders/v8-profiler.h: Removed.
* v8/ForwardingHeaders/v8-testing.h: Removed.
* v8/ForwardingHeaders/v8.h: Removed.
* v8/ForwardingHeaders/v8stdint.h: Removed.
Source/WTF:
* WTF.pri:
Tools:
* Scripts/build-webkit: Remove --v8 option.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 17 Jul 2012 10:36:35 +0000 (10:36 +0000)]
[Qt] Add --use-test-fonts option to Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=91402
Reviewed by Tor Arne Vestbø.
Same stuff that already exists for QtTestBrowser.
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 10:23:27 +0000 (10:23 +0000)]
[BlackBerry] Enable registerProtocolHandler for Blackberry
https://bugs.webkit.org/show_bug.cgi?id=90422
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-07-17
Reviewed by George Staikos.
Implements APIs were added in Custom Scheme Handler specification
which is at http://dev.w3.org/html5/spec/Overview.html#custom-handlers.
Test cases:
fast/dom/register-protocol-handler.html
fast/dom/unregister-protocol-handler.html
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
(WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 09:59:36 +0000 (09:59 +0000)]
"in body" insertion mode, "any other end tag" step 2.1 is updated
https://bugs.webkit.org/show_bug.cgi?id=91473
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-17
Reviewed by Eric Seidel.
The HTML5 spec is updated to change the 'end tag' processing to not imply
its own end tag, since that makes no sense. Step 2.1 now says
"Generate implied end tags, except for elements with the same tag name as the token."
Modified to follow the updated spec. Also removed the first FIXME because now
ElementRecord can't be deleted by the preceeding call.
This patch does not actually change the behavior because of the previous
check (aborts if generateImpliedEndTags has already popped the node for the token),
so no new tests.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 17 Jul 2012 09:45:25 +0000 (09:45 +0000)]
[Qt] platfrom/qt/editing/inserting tests needs update after test font change.
https://bugs.webkit.org/show_bug.cgi?id=91378.
Unreviewed rebaseline.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
* platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
* platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
* platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/inserting/12882-expected.png: Added.
* platform/qt/editing/inserting/12882-expected.txt:
* platform/qt/editing/inserting/4278698-expected.png:
* platform/qt/editing/inserting/4278698-expected.txt:
* platform/qt/editing/inserting/4840662-expected.png: Added.
* platform/qt/editing/inserting/4840662-expected.txt:
* platform/qt/editing/inserting/4875189-1-expected.png: Added.
* platform/qt/editing/inserting/4875189-1-expected.txt:
* platform/qt/editing/inserting/4875189-2-expected.png: Added.
* platform/qt/editing/inserting/4875189-2-expected.txt:
* platform/qt/editing/inserting/4959067-expected.png: Added.
* platform/qt/editing/inserting/4959067-expected.txt:
* platform/qt/editing/inserting/4960120-1-expected.png:
* platform/qt/editing/inserting/4960120-1-expected.txt:
* platform/qt/editing/inserting/4960120-2-expected.png: Added.
* platform/qt/editing/inserting/4960120-2-expected.txt:
* platform/qt/editing/inserting/5002441-expected.png: Added.
* platform/qt/editing/inserting/5002441-expected.txt:
* platform/qt/editing/inserting/5058163-1-expected.png: Added.
* platform/qt/editing/inserting/5058163-1-expected.txt:
* platform/qt/editing/inserting/5058163-2-expected.png: Added.
* platform/qt/editing/inserting/5058163-2-expected.txt:
* platform/qt/editing/inserting/5156401-2-expected.png: Added.
* platform/qt/editing/inserting/5156401-2-expected.txt:
* platform/qt/editing/inserting/5418891-expected.png: Added.
* platform/qt/editing/inserting/5418891-expected.txt:
* platform/qt/editing/inserting/5510537-expected.png: Added.
* platform/qt/editing/inserting/5510537-expected.txt:
* platform/qt/editing/inserting/5549929-2-expected.png: Added.
* platform/qt/editing/inserting/5549929-2-expected.txt:
* platform/qt/editing/inserting/5549929-3-expected.png: Added.
* platform/qt/editing/inserting/5549929-3-expected.txt:
* platform/qt/editing/inserting/6703873-expected.png: Added.
* platform/qt/editing/inserting/6703873-expected.txt:
* platform/qt/editing/inserting/before-after-input-element-expected.png:
* platform/qt/editing/inserting/before-after-input-element-expected.txt:
* platform/qt/editing/inserting/break-blockquote-after-delete-expected.png: Added.
* platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
* platform/qt/editing/inserting/editable-html-element-expected.png:
* platform/qt/editing/inserting/editable-html-element-expected.txt:
* platform/qt/editing/inserting/editable-inline-element-expected.png: Added.
* platform/qt/editing/inserting/editable-inline-element-expected.txt:
* platform/qt/editing/inserting/edited-whitespace-1-expected.png: Added.
* platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
* platform/qt/editing/inserting/editing-empty-divs-expected.png:
* platform/qt/editing/inserting/editing-empty-divs-expected.txt:
* platform/qt/editing/inserting/insert-3654864-fix-expected.txt: Removed.
* platform/qt/editing/inserting/insert-3775316-fix-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
* platform/qt/editing/inserting/insert-3775316-fix-expected.txt:
* platform/qt/editing/inserting/insert-3778059-fix-expected.png: Added.
* platform/qt/editing/inserting/insert-3778059-fix-expected.txt:
* platform/qt/editing/inserting/insert-3800346-fix-expected.png: Added.
* platform/qt/editing/inserting/insert-3800346-fix-expected.txt:
* platform/qt/editing/inserting/insert-3851164-fix-expected.txt: Removed.
* platform/qt/editing/inserting/insert-after-delete-001-expected.png:
* platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
* platform/qt/editing/inserting/insert-at-end-01-expected.png: Added.
* platform/qt/editing/inserting/insert-at-end-01-expected.txt:
* platform/qt/editing/inserting/insert-at-end-02-expected.png: Added.
* platform/qt/editing/inserting/insert-at-end-02-expected.txt:
* platform/qt/editing/inserting/insert-br-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
* platform/qt/editing/inserting/insert-br-001-expected.txt:
* platform/qt/editing/inserting/insert-br-002-expected.png: Added.
* platform/qt/editing/inserting/insert-br-002-expected.txt:
* platform/qt/editing/inserting/insert-br-003-expected.png:
* platform/qt/editing/inserting/insert-br-003-expected.txt:
* platform/qt/editing/inserting/insert-br-004-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-3851164-fix-expected.png.
* platform/qt/editing/inserting/insert-br-004-expected.txt:
* platform/qt/editing/inserting/insert-br-005-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
* platform/qt/editing/inserting/insert-br-005-expected.txt:
* platform/qt/editing/inserting/insert-br-006-expected.png:
* platform/qt/editing/inserting/insert-br-006-expected.txt:
* platform/qt/editing/inserting/insert-br-007-expected.png:
* platform/qt/editing/inserting/insert-br-007-expected.txt:
* platform/qt/editing/inserting/insert-br-008-expected.png:
* platform/qt/editing/inserting/insert-br-008-expected.txt:
* platform/qt/editing/inserting/insert-br-009-expected.png:
* platform/qt/editing/inserting/insert-br-009-expected.txt:
* platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
* platform/qt/editing/inserting/insert-br-at-tabspan-001-expected.txt:
* platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.png:
* platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
* platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.png:
* platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/qt/editing/inserting/insert-br-quoted-001-expected.png: Added.
* platform/qt/editing/inserting/insert-br-quoted-001-expected.txt:
* platform/qt/editing/inserting/insert-br-quoted-002-expected.png: Added.
* platform/qt/editing/inserting/insert-br-quoted-002-expected.txt:
* platform/qt/editing/inserting/insert-br-quoted-003-expected.png: Added.
* platform/qt/editing/inserting/insert-br-quoted-003-expected.txt:
* platform/qt/editing/inserting/insert-br-quoted-004-expected.png: Added.
* platform/qt/editing/inserting/insert-br-quoted-004-expected.txt:
* platform/qt/editing/inserting/insert-br-quoted-005-expected.png: Added.
* platform/qt/editing/inserting/insert-br-quoted-005-expected.txt:
* platform/qt/editing/inserting/insert-br-quoted-006-expected.png: Added.
* platform/qt/editing/inserting/insert-br-quoted-006-expected.txt:
* platform/qt/editing/inserting/insert-div-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
* platform/qt/editing/inserting/insert-div-001-expected.txt:
* platform/qt/editing/inserting/insert-div-002-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png.
* platform/qt/editing/inserting/insert-div-002-expected.txt:
* platform/qt/editing/inserting/insert-div-003-expected.png:
* platform/qt/editing/inserting/insert-div-003-expected.txt:
* platform/qt/editing/inserting/insert-div-004-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
* platform/qt/editing/inserting/insert-div-004-expected.txt:
* platform/qt/editing/inserting/insert-div-005-expected.png: Added.
* platform/qt/editing/inserting/insert-div-005-expected.txt:
* platform/qt/editing/inserting/insert-div-006-expected.png:
* platform/qt/editing/inserting/insert-div-006-expected.txt:
* platform/qt/editing/inserting/insert-div-007-expected.png:
* platform/qt/editing/inserting/insert-div-007-expected.txt:
* platform/qt/editing/inserting/insert-div-008-expected.png:
* platform/qt/editing/inserting/insert-div-008-expected.txt:
* platform/qt/editing/inserting/insert-div-009-expected.txt: Removed.
* platform/qt/editing/inserting/insert-div-010-expected.txt: Removed.
* platform/qt/editing/inserting/insert-div-011-expected.png: Added.
* platform/qt/editing/inserting/insert-div-011-expected.txt:
* platform/qt/editing/inserting/insert-div-012-expected.png: Added.
* platform/qt/editing/inserting/insert-div-012-expected.txt:
* platform/qt/editing/inserting/insert-div-013-expected.png: Added.
* platform/qt/editing/inserting/insert-div-013-expected.txt:
* platform/qt/editing/inserting/insert-div-014-expected.png: Added.
* platform/qt/editing/inserting/insert-div-014-expected.txt:
* platform/qt/editing/inserting/insert-div-015-expected.png: Added.
* platform/qt/editing/inserting/insert-div-015-expected.txt:
* platform/qt/editing/inserting/insert-div-016-expected.png: Added.
* platform/qt/editing/inserting/insert-div-016-expected.txt:
* platform/qt/editing/inserting/insert-div-017-expected.png: Added.
* platform/qt/editing/inserting/insert-div-017-expected.txt:
* platform/qt/editing/inserting/insert-div-018-expected.png: Added.
* platform/qt/editing/inserting/insert-div-018-expected.txt:
* platform/qt/editing/inserting/insert-div-019-expected.png: Added.
* platform/qt/editing/inserting/insert-div-019-expected.txt:
* platform/qt/editing/inserting/insert-div-020-expected.png: Added.
* platform/qt/editing/inserting/insert-div-020-expected.txt:
* platform/qt/editing/inserting/insert-div-022-expected.png: Added.
* platform/qt/editing/inserting/insert-div-022-expected.txt:
* platform/qt/editing/inserting/insert-div-023-expected.png:
* platform/qt/editing/inserting/insert-div-023-expected.txt:
* platform/qt/editing/inserting/insert-div-024-expected.png:
* platform/qt/editing/inserting/insert-div-024-expected.txt:
* platform/qt/editing/inserting/insert-div-025-expected.png:
* platform/qt/editing/inserting/insert-div-025-expected.txt:
* platform/qt/editing/inserting/insert-div-026-expected.png: Added.
* platform/qt/editing/inserting/insert-div-026-expected.txt:
* platform/qt/editing/inserting/insert-div-027-expected.png: Added.
* platform/qt/editing/inserting/insert-div-027-expected.txt:
* platform/qt/editing/inserting/insert-paragraph-01-expected.png: Added.
* platform/qt/editing/inserting/insert-paragraph-01-expected.txt:
* platform/qt/editing/inserting/insert-paragraph-02-expected.png: Added.
* platform/qt/editing/inserting/insert-paragraph-02-expected.txt:
* platform/qt/editing/inserting/insert-paragraph-03-expected.png: Added.
* platform/qt/editing/inserting/insert-paragraph-03-expected.txt:
* platform/qt/editing/inserting/insert-paragraph-04-expected.png: Added.
* platform/qt/editing/inserting/insert-paragraph-04-expected.txt:
* platform/qt/editing/inserting/insert-paragraph-05-expected.png: Added.
* platform/qt/editing/inserting/insert-paragraph-05-expected.txt:
* platform/qt/editing/inserting/insert-space-in-empty-doc-expected.png:
* platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/qt/editing/inserting/insert-tab-001-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
* platform/qt/editing/inserting/insert-tab-001-expected.txt:
* platform/qt/editing/inserting/insert-tab-002-expected.png: Copied from LayoutTests/platform/qt/editing/inserting/insert-after-delete-001-expected.png.
* platform/qt/editing/inserting/insert-tab-002-expected.txt:
* platform/qt/editing/inserting/insert-tab-004-expected.png: Renamed from LayoutTests/platform/qt/editing/inserting/insert-3851164-fix-expected.png.
* platform/qt/editing/inserting/insert-tab-004-expected.txt:
* platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.png:
* platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
* platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.png:
* platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
* platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.png: Renamed from LayoutTests/platform/qt/editing/inserting/insert-3654864-fix-expected.png.
* platform/qt/editing/inserting/insert-text-at-tabspan-003-expected.txt:
* platform/qt/editing/inserting/insert-text-with-newlines-expected.png:
* platform/qt/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/qt/editing/inserting/line-break-expected.png: Added.
* platform/qt/editing/inserting/line-break-expected.txt:
* platform/qt/editing/inserting/multiple-lines-selected-expected.png:
* platform/qt/editing/inserting/multiple-lines-selected-expected.txt:
* platform/qt/editing/inserting/paragraph-separator-01-expected.png: Added.
* platform/qt/editing/inserting/paragraph-separator-01-expected.txt:
* platform/qt/editing/inserting/paragraph-separator-02-expected.png: Added.
* platform/qt/editing/inserting/paragraph-separator-02-expected.txt:
* platform/qt/editing/inserting/paragraph-separator-03-expected.png:
* platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
* platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
* platform/qt/editing/inserting/paragraph-separator-in-table-1-expected.txt:
* platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
* platform/qt/editing/inserting/paragraph-separator-in-table-2-expected.txt:
* platform/qt/editing/inserting/redo-expected.png:
* platform/qt/editing/inserting/redo-expected.txt:
* platform/qt/editing/inserting/return-key-with-selection-001-expected.png: Added.
* platform/qt/editing/inserting/return-key-with-selection-001-expected.txt:
* platform/qt/editing/inserting/return-key-with-selection-002-expected.png: Added.
* platform/qt/editing/inserting/return-key-with-selection-002-expected.txt:
* platform/qt/editing/inserting/return-key-with-selection-003-expected.png:
* platform/qt/editing/inserting/return-key-with-selection-003-expected.txt:
* platform/qt/editing/inserting/typing-001-expected.png:
* platform/qt/editing/inserting/typing-001-expected.txt:
* platform/qt/editing/inserting/typing-002-expected.png:
* platform/qt/editing/inserting/typing-002-expected.txt:
* platform/qt/editing/inserting/typing-003-expected.png:
* platform/qt/editing/inserting/typing-003-expected.txt:
* platform/qt/editing/inserting/typing-around-br-001-expected.png:
* platform/qt/editing/inserting/typing-around-br-001-expected.txt:
* platform/qt/editing/inserting/typing-around-image-001-expected.png:
* platform/qt/editing/inserting/typing-around-image-001-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 17 Jul 2012 09:20:42 +0000 (09:20 +0000)]
Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91477
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 09:09:57 +0000 (09:09 +0000)]
[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459
Reviewed by Ryosuke Niwa.
Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.
* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::accessibilityController):
(TestShell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 17 Jul 2012 09:05:44 +0000 (09:05 +0000)]
[Qt] Unreviewed gardening after r122768 or r122771.
https://bugs.webkit.org/show_bug.cgi?id=91476
Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-17
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 17 Jul 2012 08:45:06 +0000 (08:45 +0000)]
[Qt] Unreviewed gardening after 122816. Skipped fast/dom/shadow/shadowdom-for-media.html
because ENABLE(SHADOW_DOM) is disabled on Qt.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-17
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Tue, 17 Jul 2012 08:37:42 +0000 (08:37 +0000)]
[Regression] Infinite loop in document.elementFromPoint
https://bugs.webkit.org/show_bug.cgi?id=90820
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Node::shadowAncestorNode returns the caller node itself for SVGElement. However,
since we have already implemented event retargeting algorithm in Shadow DOM, we don't have to
take a special care of SVGElement for Node.shadowAncestorNode() now.
This patch will removes the special care code and fixes infinite loop in document.elementFromPoint().
Test: svg/hittest/svg-use-element-from-point.html
* dom/Node.cpp:
(WebCore::Node::shadowAncestorNode):
LayoutTests:
* svg/hittest/svg-use-element-from-point-expected.txt: Added.
* svg/hittest/svg-use-element-from-point.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Tue, 17 Jul 2012 08:27:27 +0000 (08:27 +0000)]
Shadow DOM for img element
https://bugs.webkit.org/show_bug.cgi?id=90532
Reviewed by Hajime Morita.
Source/WebCore:
This patch adds Shadow DOM support for img element.
According to the Shadow DOM spec, img element should behave like having a user agent Shadow DOM.
However, if we add Shadow DOM to img by default, it will cause performance regression and memory bloat.
So, we would like to postpone adding a Shadow DOM to img until when we really need it. In other words,
we add our User Agent Shadow DOM to img just before a user adds Author Shadow DOM.
The User Agent Shadow DOM for img has only one element, which displays an image. If img has
a Shadow DOM, img will behave like <span style="display: inline-block"> by default. The display style can
be chagned using CSS though.
This patch also adds ImageLoaderClient. The element we render an image and the element we take an argument
from were the same, however not they might be different. We would like to encapsulate the fact into
ImageLoaderClient.
Tests: fast/dom/shadow/shadowdom-for-image-alt-update.html
fast/dom/shadow/shadowdom-for-image-alt.html
fast/dom/shadow/shadowdom-for-image-content.html
fast/dom/shadow/shadowdom-for-image-dynamic.html
fast/dom/shadow/shadowdom-for-image-event-click.html
fast/dom/shadow/shadowdom-for-image-in-shadowdom.html
fast/dom/shadow/shadowdom-for-image-map.html
fast/dom/shadow/shadowdom-for-image-style.html
fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html
fast/dom/shadow/shadowdom-for-image-with-width-and-height.html
fast/dom/shadow/shadowdom-for-image.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/html.css:
(img):
* html/HTMLImageElement.cpp:
(WebCore::ImageElement::setImageIfNecessary):
(WebCore):
(WebCore::ImageElement::createRendererForImage):
(WebCore::HTMLImageElement::willAddAuthorShadowRoot): When we don't have a user agent Shadow DOM yet
we add it.
(WebCore::HTMLImageElement::createShadowSubtree):
(WebCore::HTMLImageElement::imageElement):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::createRenderer): If a user agent Shadow DOM is attached, we create
Renderer from style, instead of creating RenderImage.
(WebCore::HTMLImageElement::attach):
(WebCore::HTMLImageElement::innerElement):
* html/HTMLImageElement.h:
(WebCore):
(ImageElement):
(HTMLImageElement):
(WebCore::HTMLImageElement::sourceElement):
(WebCore::HTMLImageElement::refSourceElement):
(WebCore::HTMLImageElement::derefSourceElement):
(WebCore::HTMLImageElement::imageRenderer):
(WebCore::HTMLImageElement::imageLoader):
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::HTMLImageLoader):
(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::sourceURI):
(WebCore::HTMLImageLoader::notifyFinished):
* html/HTMLImageLoader.h:
(HTMLImageLoader):
* html/HTMLInputElement.h:
* html/HTMLObjectElement.h:
* html/HTMLPlugInElement.h:
* html/HTMLTagNames.in:
* html/HTMLVideoElement.h:
* html/shadow/ImageInnerElement.cpp: Added.
(WebCore):
(WebCore::ImageInnerElement::ImageInnerElement):
(WebCore::ImageInnerElement::hostImage):
(WebCore::ImageInnerElement::imageLoader):
(WebCore::ImageInnerElement::attach):
(WebCore::ImageInnerElement::createRenderer):
* html/shadow/ImageInnerElement.h: Added.
(WebCore):
(ImageInnerElement):
(WebCore::ImageInnerElement::imageRenderer):
(WebCore::ImageInnerElement::create):
(WebCore::isImageInnerElement):
(WebCore::toImageInnerElement):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore):
(WebCore::ImageLoader::document):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::renderImageResource):
(WebCore::ImageLoader::updatedHasPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
* loader/ImageLoader.h:
(WebCore):
(ImageLoader):
(WebCore::ImageLoader::client):
* loader/ImageLoaderClient.h: Added.
(WebCore):
(ImageLoaderClient): Provides the necessary interfaces to ImageLoader.
(WebCore::ImageLoaderClient::~ImageLoaderClient):
(ImageLoaderClientBase):
(WebCore::ImageLoaderClientBase::sourceElement):
(WebCore::ImageLoaderClientBase::imageElement):
(WebCore::ImageLoaderClientBase::refSourceElement):
(WebCore::ImageLoaderClientBase::derefSourceElement):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
(WebCore::RenderImage::hostImageElement):
(WebCore):
* rendering/RenderImage.h:
(WebCore):
(RenderImage):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
* svg/SVGImageElement.h:
(SVGImageElement):
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::SVGImageLoader):
(WebCore::SVGImageLoader::dispatchLoadEvent):
(WebCore::SVGImageLoader::sourceURI):
* svg/SVGImageLoader.h:
(SVGImageLoader):
LayoutTests:
Contains the following test cases.
(1) ShadowDOM is attached to an img element and use a shadow element
(2) ShadowDOM is attached to an img element and use a content element
(3) width and height are specified
(4) src attribute is dynamically changed
(5) multiple ShadowDOMs are attached to an img element
(6) ShadowDOM is attached to an img element in Shadow DOM
(7) event retargetting
(8) img with display: none, display: inline, display: block
(9) image map
(10) alt text
(11) alt text with dynamic update
* fast/dom/shadow/shadowdom-for-image-alt-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-alt-update-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-alt-update.html: Added.
* fast/dom/shadow/shadowdom-for-image-alt.html: Added.
* fast/dom/shadow/shadowdom-for-image-content-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-content.html: Added.
* fast/dom/shadow/shadowdom-for-image-dynamic-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-dynamic.html: Added.
* fast/dom/shadow/shadowdom-for-image-event-click-expected.txt: Added.
* fast/dom/shadow/shadowdom-for-image-event-click.html: Added.
* fast/dom/shadow/shadowdom-for-image-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-in-shadowdom-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-in-shadowdom.html: Added.
* fast/dom/shadow/shadowdom-for-image-map-expected.txt: Added.
* fast/dom/shadow/shadowdom-for-image-map.html: Added.
* fast/dom/shadow/shadowdom-for-image-style-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-style.html: Added.
* fast/dom/shadow/shadowdom-for-image-with-multiple-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-image-with-width-and-height-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-with-width-and-height.html: Added.
* fast/dom/shadow/shadowdom-for-image.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 17 Jul 2012 08:22:17 +0000 (08:22 +0000)]
Internals: Remove injectPagePopupController()
https://bugs.webkit.org/show_bug.cgi?id=91471
Reviewed by Hajime Morita.
r122558 introduced injectPagePopupController(), however we'd like to
avoid adding such JavaScript binding code. We can avoid it by exposing a
PagePopupController for a mock and injecting the following code to the
popup document:
<script>window.pagePopupController = window.internals.pagePopupController</script>
No new tests. This is a kind of refactoring.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::pagePopupController):
Added. Accessor for PagePopupControler owned by the MockPagePopupDriver.
* testing/InternalSettings.h:
(InternalSettings): Declare pagePopupController() for Internals::pagePopupController().
* testing/Internals.cpp:
(WebCore::Internals::pagePopupController):
Added. This uses InternalSettings::pagePopupController().
* testing/Internals.h:
(Internals): Declare pagePopupController() for Internals.idl.
* testing/Internals.idl: Declare pagePopupController.
* testing/MockPagePopupDriver.cpp:
Moved m_pagePopupController from MockPagePopup to MockPagePopupDriver.
(WebCore::MockPagePopup::MockPagePopup):
Added a script element to prepare window.pagePopupController.
Removed a callsite of injectPagePopupController().
(WebCore::MockPagePopupDriver::openPagePopup):
(WebCore::MockPagePopupDriver::closePagePopup):
* testing/MockPagePopupDriver.h:
(WebCore::MockPagePopupDriver::pagePopupController):
Accessor for a PagePopupController object.
(MockPagePopupDriver): Add RefPtr<PagePopupController> data member.
* testing/v8/WebCoreTestSupport.cpp: Remove injectPagePopupController().
* testing/v8/WebCoreTestSupport.h: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 08:11:40 +0000 (08:11 +0000)]
[Chromium] Move TextInputController into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91457
Reviewed by Ryosuke Niwa.
This patch is purely moving code. TextInputController is one of the
objects exposed to JavaScript and so should be in the TestRunner
library.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
* DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 08:10:50 +0000 (08:10 +0000)]
[Chromium] TextInputController shouldn't know about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91455
Reviewed by Kent Tamura.
This patch uses the same pattern we used for the
AccessibilityController to remove the dependency on TestShell.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::TextInputController):
(TextInputController::insertText):
(TextInputController::doCommand):
(TextInputController::setMarkedText):
(TextInputController::unmarkText):
(TextInputController::hasMarkedText):
(TextInputController::markedRange):
(TextInputController::selectedRange):
(TextInputController::firstRectForCharacterRange):
(TextInputController::validAttributesForMarkedText):
(TextInputController::setComposition):
* DumpRenderTree/chromium/TextInputController.h:
(WebKit):
(TextInputController):
(TextInputController::setWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 17 Jul 2012 08:02:39 +0000 (08:02 +0000)]
Unreviewed chromium tests rebaselines after r122791.
* platform/chromium-win/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 17 Jul 2012 08:00:53 +0000 (08:00 +0000)]
Unreviewed chromium tests rebaselines after r122785.
* platform/chromium-linux-x86/fast/borders/border-image-scaled-gradient-expected.png: Added.
* platform/chromium-linux-x86/fast/reflections/reflection-with-zoom-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png.
* platform/chromium-linux/fast/borders/border-image-scaled-gradient-expected.png:
* platform/chromium-linux/fast/css/transformed-mask-expected.png:
* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png:
* platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
* platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
* platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png:
* platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/transformed-mask-expected.png:
* platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png:
* platform/chromium-mac/fast/css/transformed-mask-expected.png:
* platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
* platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-mac/fast/gradients/css3-radial-gradients-expected.png:
* platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png:
* platform/chromium-mac/fast/gradients/css3-repeating-radial-gradients-expected.png:
* platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
* platform/chromium-win-xp/fast/borders/border-image-scaled-gradient-expected.png: Added.
* platform/chromium-win-xp/fast/reflections/reflection-with-zoom-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png.
* platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png:
* platform/chromium-win/fast/css/transformed-mask-expected.png:
* platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
* platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png:
* platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png:
* platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png:
* platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Tue, 17 Jul 2012 07:59:57 +0000 (07:59 +0000)]
Unreviewed buildfix from Zoltan Herczeg after 122768.
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 17 Jul 2012 07:52:29 +0000 (07:52 +0000)]
[EFL] Move codes related to theme setting from Widget to RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=89842
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
WebKit/Efl uses custom theme for Scrollbar, RenderTheme and Cursor.
However, theme information itself is in WidgetEfl so it is accessed by
calling recursive function.
Because theme is managed by each page, this patch moves codes related to
theme from WidgetEfl to RenderThemeEfl which is contained by page.
* platform/Widget.h: Removed functions related to theme.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::setThemePath): Added to set theme path.
(WebCore::RenderThemeEfl::createEdje): Updated method to use RenderThemeEfl's theme.
(WebCore::RenderThemeEfl::RenderThemeEfl):
* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::themePath): Added to get theme path
* platform/efl/ScrollbarEfl.cpp: Updated method to use RenderThemeEfl's theme.
(ScrollbarEfl::setParent):
* platform/efl/WidgetEfl.cpp: Removed codes related theme.
(WidgetPrivate):
Source/WebKit:
* CMakeLists.txt: Added html/shadow to WebKit_INCLUDE_DIRECTORIES.
Source/WebKit/efl:
* ewk/ewk_frame.cpp:
(ewk_frame_view_create_for_view): Removed codes which set theme in FrameView.
* ewk/ewk_view.cpp:
(ewk_view_theme_set): Called RenderThemeEfl::setThemePath instead of setting theme in FrameView.
Source/WebKit2:
* CMakeLists.txt: Added html/shadow to WebKit_INCLUDE_DIRECTORIES.
* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::setThemePath): Called RenderThemeEfl::setThemePath instead of setting theme in FrameView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Tue, 17 Jul 2012 07:26:52 +0000 (07:26 +0000)]
HTMLMediaElement should not use Element::ensureShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=77936
Reviewed by Hajime Morita.
Source/WebCore:
a video element and an audio element add UserAgentShadowRoot dynamically, and they assume that it's the oldest ShadowRoot.
However an AuthorShadowRoot could be added by a user before a video element and an audio element add UserAgentShadowRoot.
It breaks the assumption that the UserAgentShadowRoot is the oldest.
If the UserAgentShadowRoot is not the oldest, the AuthorShadowRoot a page author added might be ignored.
Since the timing to add UserAgentShadowRoot is not known by a user, the fact that UserAgentShadorRoot is
not the oldest will cause inconsistent behavior.
Adding AuthorShadowRoot to a video element and an audio element is allowed by this patch.
Test: fast/dom/shadow/shadowdom-for-media.html
* dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createShadowSubtree):
(WebCore):
(WebCore::HTMLMediaElement::willAddAuthorShadowRoot):
(WebCore::HTMLMediaElement::createMediaControls):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
LayoutTests:
Adding Shadow DOM to a video element and an audio element is allowed now.
* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-disable.html:
* fast/dom/shadow/shadowdom-for-media-expected.txt: Added.
* fast/dom/shadow/shadowdom-for-media.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 17 Jul 2012 07:23:18 +0000 (07:23 +0000)]
[Forms] Test expectations of datetime/datetime-local/time should not contain milliseconds when they aren't expected
https://bugs.webkit.org/show_bug.cgi?id=91469
Reviewed by Kent Tamura.
This patch gets rid of unexpected millisecond strings from both test
cases and expected text.
This is adaptation of behavior change caused by r119948, introducing
decimal arithmetic, which corrected the expression step mod 1000 used
in BaseDateAndTimeInputType::serialize for checking adding milliseconds
or not, which converts internal date time representation into string.
Before r119948, we used fmod(step, 1000) for this. However, it doesn't
return mathematically correct value when quotient is very large, e.g.
fmod(3.
40282346e+38, 1000) returns 616 on x86 linux, although we
expect that it is 0.
* fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for big step value tests.
* fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: ditto.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: ditto.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: ditto.
* fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Get rid of millig seconds for a big step value test and expected value's fractinal second is zero.
* fast/forms/time/time-stepup-stepdown-from-renderer.html: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 17 Jul 2012 07:19:25 +0000 (07:19 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/Skipped:
* platform/qt/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 07:11:52 +0000 (07:11 +0000)]
Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=89055
Patch by David Barr <davidbarr@chromium.org> on 2012-07-17
Reviewed by Kent Tamura.
The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-
20120417/#the-image-orientation
Add a configuration option for CSS image-orientation support, disabling it by default.
.:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Tools:
* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 17 Jul 2012 07:08:17 +0000 (07:08 +0000)]
Attempt to fix the Chromium Mac build after <trac.webkit.org/changeset/122802>
(https://bugs.webkit.org/show_bug.cgi?id=91451)
Remove unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
This instance variable has remained unused since it was added in
<http://trac.webkit.org/changeset/116718> (https://bugs.webkit.org/show_bug.cgi?id=85725).
I'm unclear as to why the Chromium Mac build began to complain about this
unused instance variable following <http://trac.webkit.org/changeset/122802>, since this
code has been in the tree for a while and we previously instantiated AbsoluteQuadsGeneratorContext
with wasFixed (even though it wasn't used). Regardless, we should remove the unused
instance variable AbsoluteQuadsGeneratorContext::m_wasFixed.
* rendering/RenderInline.cpp:
(WebCore): Remove AbsoluteQuadsGeneratorContext::m_wasFixed.
(WebCore::RenderInline::absoluteQuads):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 06:43:41 +0000 (06:43 +0000)]
Unreviewed. Remove two empty directories.
* public/linuxish: Removed.
* src/linuxish: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 17 Jul 2012 06:27:50 +0000 (06:27 +0000)]
Add RegisterProtocolHandlerClient to the Modules/protocolhandler
https://bugs.webkit.org/show_bug.cgi?id=90940
Reviewed by Hajime Morita.
Source/WebCore:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In addition, NavigatorRegisterProtocolHandler should be supplementable.
No new tests. Covered by existing tests.
* GNUmakefile.list.am:
* Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:
(WebCore::NavigatorRegisterProtocolHandler::from):
(WebCore::NavigatorRegisterProtocolHandler::create):
(WebCore):
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered):
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::supplementName):
(WebCore::provideRegisterProtocolHandlerTo):
* Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:
(WebCore):
(NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::client):
* Modules/protocolhandler/RegisterProtocolHandlerClient.h: Added.
(WebCore):
(RegisterProtocolHandlerClient):
* WebCore.gypi:
* loader/EmptyClients.h:
* page/ChromeClient.h:
(ChromeClient):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::setCookies):
(WebCore::getRawCookies):
Source/WebKit:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
* PlatformEfl.cmake: Add RegisterProtocolHandlerEfl files and include path.
Source/WebKit/chromium:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, RegisterProtocolHandlerClientImpl class is added to ChromeClientImpl files.
In addition, existing functions related to protocol handler in ChromeClientImpl class are moved to
RegisterProtocolHandlerClientImpl class.
* WebKit.gyp:
* src/ChromeClientImpl.cpp: Implement RegisterProtocolHandlerClientImpl class.
(WebKit):
(WebKit::RegisterProtocolHandlerClientImpl::create):
(WebKit::RegisterProtocolHandlerClientImpl::RegisterProtocolHandlerClientImpl):
(WebKit::RegisterProtocolHandlerClientImpl::registerProtocolHandler):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
(RegisterProtocolHandlerClientImpl):
(WebKit::RegisterProtocolHandlerClientImpl::~RegisterProtocolHandlerClientImpl):
(WebKit):
* src/WebViewImpl.cpp: Register RegisterProtocolHandlerClientImpl in order to support supplement.
(WebKit::WebViewImpl::WebViewImpl):
* src/WebViewImpl.h:
Source/WebKit/efl:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient
In order to support this, RegisterProtocolHandlerClientEfl class is added and ewk_view registers
RegisterProtocolHandlerClientEfl. In addition, existing concrete functions in ChromeClientEfl are moved
to RegisterProtocolHandlerClientEfl.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
* WebCoreSupport/ChromeClientEfl.h:
* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp: Added.
(WebCore):
(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::RegisterProtocolHandlerClientEfl::RegisterProtocolHandlerClientEfl):
(WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
(WebCore::RegisterProtocolHandlerClientEfl::isProtocolHandlerRegistered):
(WebCore::RegisterProtocolHandlerClientEfl::unregisterProtocolHandler):
* WebCoreSupport/RegisterProtocolHandlerClientEfl.h: Added.
(RegisterProtocolHandlerClientEfl):
(WebCore::RegisterProtocolHandlerClientEfl::~RegisterProtocolHandlerClientEfl):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit/gtk:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, RegisterProtocolHandlerClientGtk class is added and webview registers
RegisterProtocolHandlerClientGtk. In addition, existing concrete functions in ChromeClientGtk are moved
to RegisterProtocolHandlerClientGtk.
* GNUmakefile.am:
* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp: Added.
(WebKit):
(WebKit::RegisterProtocolHandlerClient::RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::registerProtocolHandler):
* WebCoreSupport/RegisterProtocolHandlerClientGtk.h: Added.
(WebKit):
(RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::~RegisterProtocolHandlerClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
Source/WebKit2:
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, WebRegisterProtocolHandlerClient class is added. However, this is not implemented yet.
In addition, existing virtual functions in WebChromeClient are moved to WebRegisterProtocolHandlerClient.
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h: Added.
(WebKit):
(WebRegisterProtoclHandlerClient):
(WebKit::WebRegisterProtoclHandlerClient::isProtocolHandlerRegistered):
(WebKit::WebRegisterProtoclHandlerClient::unregisterProtocolHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 06:27:31 +0000 (06:27 +0000)]
[Chromium] Move Task.(cpp|h) into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91446
Reviewed by Ryosuke Niwa.
Task is a dependency of EventSender, which needs to move into TestRunner.a.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
* DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 06:19:01 +0000 (06:19 +0000)]
[Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91443
Reviewed by Tony Chang.
Purely a file move (and a sorting of #includes).
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
* DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
* DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
* DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 17 Jul 2012 05:11:16 +0000 (05:11 +0000)]
REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing.
https://bugs.webkit.org/show_bug.cgi?id=91244
Reviewed by Kent Tamura.
This patch enables and updates disabled test cases of DecimalTest
caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor()
for small fraction numbers and added test cases. Fixes in r122552
itself is correct however, it didn't update existing tests for very small
fraction numbers.
* tests/DecimalTest.cpp:
(TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000),
ceiling rounds number toward positive infinity.
(TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000),
floor rounds number toward negative infinity.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 04:37:29 +0000 (04:37 +0000)]
.: Expose an export for the iconUrl list so Internals can use it
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
* Source/autotools/symbols.filter: export iconURLs
Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
As it turns out, it can contain stale URLs in the case that some script
manipulates the DOM, which breaks scripts trying to reset the favicon
URL. Also added a method in Internals to allow tests to get the list of
icon
Tests: fast/dom/icon-url-change.html
fast/dom/icon-url-list.html
* WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
* dom/Document.cpp:
(WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
(WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
(WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace
* dom/Document.h:
(Document): removed the addIconURL method which is no longer used
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
(WebCore):
(WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor
* html/HTMLLinkElement.h:
(HTMLLinkElement): declared the icon type and size accessors
* testing/Internals.cpp:
(WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
(WebCore):
* testing/Internals.h:
(Internals): declared the method for unit testing the icon URL list
* testing/Internals.idl: exported the Document::iconURLs function
Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
* win/WebKit2.def: export the DocumentL::iconURLs function
LayoutTests: Add some new unit tests to test the favicon changing dynamically
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.
* fast/dom/icon-url-change-expected.txt: Added.
* fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
* fast/dom/icon-url-list-expected.txt: Added.
* fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
* fast/dom/icon-url-property-expected.txt: update unit test expectations
* fast/dom/icon-url-property.html: update and enable existing favicon test
* platform/chromium/TestExpectations: reenable the url-property test
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 04:33:25 +0000 (04:33 +0000)]
WebCore needs WEBCORE_TESTING macro to mark methods being exported for testing.
https://bugs.webkit.org/show_bug.cgi?id=90764
Patch by Hajime Morrita <morrita@chromium.org> on 2012-07-16
Reviewed by Adam Barth.
.:
Removed symbols which are now covered by WEBCORE_TESTING.
* Source/autotools/symbols.filter:
Source/WebCore:
Defined WEBCORE_TESTING based on USE(EXPORT_MACROS_FOR_TESTING) and
applied it to FrameDestructionObserver.
* bindings/js/JSDOMGlobalObject.h: Removed conflicting symbols
* page/FrameDestructionObserver.h: Added WEBKIT_TESTING
(FrameDestructionObserver):
* platform/PlatformExportMacros.h:
Source/WebKit2:
Removed symbols which are now covered by WEBCORE_TESTING.
* win/WebKit2.def:
* win/WebKit2CFLite.def:
Source/WTF:
Added USE(EXPORT_MACROS_FOR_TESTING) and enabled it on GTK and Windows.
* wtf/ExportMacros.h:
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 04:00:50 +0000 (04:00 +0000)]
[Chromium] AccessibilityController shouldn't know anything about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91441
Reviewed by Tony Chang.
This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
* DumpRenderTree/chromium/AccessibilityController.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::getFocusedElement):
(AccessibilityController::getRootElement):
* DumpRenderTree/chromium/AccessibilityController.h:
(WebKit):
(AccessibilityController):
(AccessibilityController::setWebView):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 03:51:21 +0000 (03:51 +0000)]
[EFL][WK2] Implement decidePolicyForResponse in policy client
https://bugs.webkit.org/show_bug.cgi?id=91401
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-16
Reviewed by Kenneth Rohde Christiansen.
Provide implementation for decidePolicyForResponse callback
in WebKit2 EFL's policy client.
* UIProcess/API/efl/ewk_view_policy_client.cpp:
(decidePolicyForResponseCallback):
(ewk_view_policy_client_attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 03:26:00 +0000 (03:26 +0000)]
REGRESSION: RenderInline::absoluteQuads produces incorrect results for fixed position.
https://bugs.webkit.org/show_bug.cgi?id=91451
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-16
Reviewed by Simon Fraser.
Source/WebCore:
RenderInline::absoluteQuads relies on copies of RenderGeometryMap,
created indirectly by passing AbsoluteQuadsGeneratorContext object by
value. These copies are unsafe because the individual transform steps
within the geometry map include a owned poitner to their respective
transform.
Modify the callee methods to take context by reference and disable
copy constructor for RenderGeometryMap.
Test: fast/inline/inline-fixed-position-boundingbox.html
* rendering/RenderGeometryMap.h:
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep): Add missing
m_offset to copy constructor initialization list.
(RenderGeometryMap): Disable copy constructor.
* rendering/RenderInline.cpp: Pass context object by reference.
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
(RenderInline::generateLineBoxRects): Update method declarations to
show pass by reference context parameter.
(RenderInline::generateCulledLineBoxRects): Ditto.
LayoutTests:
Add a regression test for boundingBox of an inline element with fixed position.
* fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
* fast/inline/inline-fixed-position-boundingbox.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 17 Jul 2012 03:24:33 +0000 (03:24 +0000)]
Some events should be always stopped at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=90436
Reviewed by Ryosuke Niwa.
Source/WebCore:
The spec is here:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped
Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):
LayoutTests:
* fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt: Added.
* fast/dom/shadow/events-stopped-at-shadow-boundary.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 03:20:42 +0000 (03:20 +0000)]
[Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=91312
Reviewed by Ryosuke Niwa.
Looking forward to moving more objects into TestRunner.a, we're going
to need an object to own all the interfaces and to put them through
their lifecycle.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 17 Jul 2012 03:09:47 +0000 (03:09 +0000)]
[EFL][WK2] Add APIs to support theme.
https://bugs.webkit.org/show_bug.cgi?id=90107
Reviewed by Hajime Morita.
Source/WebKit2:
RenderThemeEfl uses edj file to render native theme of form elements.
This patch provides default theme and a way to change edj theme file for
WebKit2/Efl.
* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_base_add):
(ewk_view_theme_set):
(ewk_view_theme_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::setThemePath):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::setThemePath):
Tools:
Override default theme path for MiniBrowser and WebKitTestRunner.
* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/efl/main.c:
(browserCreate):
* WebKitTestRunner/PlatformEfl.cmake:
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Tue, 17 Jul 2012 03:01:29 +0000 (03:01 +0000)]
[EFL][DRT] Implement dumpFrameScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=87638
Reviewed by Hajime Morita.
Tools:
* DumpRenderTree/efl/DumpRenderTree.cpp:
(dumpFrameScrollPosition): Implemented.
(shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
LayoutTests:
Updated expected results to dump scrolled position.
* platform/efl/compositing/geometry/fixed-in-composited-expected.txt:
* platform/efl/compositing/geometry/horizontal-scroll-composited-expected.txt:
* platform/efl/compositing/geometry/video-fixed-scrolling-expected.txt:
* platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
* platform/efl/css2.1/
20110323/abspos-containing-block-initial-001-expected.txt:
* platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt:
* platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
* platform/efl/fast/dom/focus-contenteditable-expected.txt:
* platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt:
* platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt:
* platform/efl/fast/dynamic/anchor-lock-expected.txt:
* platform/efl/fast/events/autoscroll-expected.txt:
* platform/efl/fast/events/reveal-link-when-focused-expected.txt:
* platform/efl/fast/layers/scroll-rect-to-visible-expected.txt:
* platform/efl/fast/multicol/scrolling-overflow-expected.txt: Added.
* platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
* platform/efl/fast/overflow/overflow_hidden-expected.txt:
* platform/efl/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/efl/fast/overflow/scrollRevealButton-expected.txt:
* platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.txt:
* platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
* platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
* platform/efl/fast/repaint/fixed-expected.txt:
* platform/efl/fast/repaint/fixed-move-after-scroll-expected.txt:
* platform/efl/fast/repaint/fixed-tranformed-expected.txt:
* platform/efl/fast/repaint/repaint-during-scroll-expected.txt:
* platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/efl/transforms/2d/transform-fixed-container-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Tue, 17 Jul 2012 02:25:18 +0000 (02:25 +0000)]
REGRESSION(r119948): [Form] HTMLInputElement.valueAsNumber for input type "month" should return number of month since January 1970
https://bugs.webkit.org/show_bug.cgi?id=91211
Reviewed by Kent Tamura.
This patch changes BaseDateAndTimeInputType::valueAsDouble() to call
virtual function parseToNumber() which "month" input type overrides
instead of non-virtual function parseToDouble() which returns number
of milliseconds.
No new tests. Existing test (fast/form/month/input-valueasnumber-month.html) coverts this, although it is disabled.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Changed to call parseToNumber().
(WebCore::BaseDateAndTimeInputType::parseToNumber): Changed to what parseToDouble() did.
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Remove parseToDouble().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 17 Jul 2012 02:10:34 +0000 (02:10 +0000)]
Unreviewed chromium mac rebaseline of fast/text/textIteratorNilRenderer for r122769.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 17 Jul 2012 01:43:56 +0000 (01:43 +0000)]
Unreviewed, roll out 122790 because it broke the Windows build. I'm not
sure what to do with exported symbols that are predicated on NDEBUG.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/CodeBlock.cpp:
(JSC):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 17 Jul 2012 01:39:40 +0000 (01:39 +0000)]
Unreviewed chromium mac/win rebaseline for r122769.
* platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-win-xp/css1: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/css1/basic/inheritance-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 17 Jul 2012 01:24:45 +0000 (01:24 +0000)]
[chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438
Reviewed by Kenneth Russell.
r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.
This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 17 Jul 2012 01:14:18 +0000 (01:14 +0000)]
dumpCallFrame is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=91444
Reviewed by Gavin Barraclough.
Various changes have been made to the SF calling convention, but
dumpCallFrame has not been updated to reflect these changes.
That resulted in both bogus information, as well as numerous
assertions of sadness.
This patch makes dumpCallFrame actually work again and adds the
wonderful feature of telling you the name of the variable that a
register reflects, or what value it contains.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
A really innefficient mechanism for finding the name of a local register.
This should only ever be used by debug code so this should be okay.
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
Debug builds no longer throw away a functions symbol table, this allows
us to actually perform a register# to name mapping
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
We weren't propogating the bytecode offset here leading to assertions
in debug builds when dumping bytecode of DFG compiled code.
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
Rework to actually be correct.
(JSC::getCallerInfo):
Return the byteocde offset as well now, given we have to determine it
anyway.
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionDumpCallFrame):
Give debug builds of JSC a method for calling dumpCallFrame so we can
inspect a callframe without requiring us to break in a debugger.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 00:57:54 +0000 (00:57 +0000)]
NRWRT Should provide a VS project to work on
https://bugs.webkit.org/show_bug.cgi?id=91436
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-16
Reviewed by Dirk Pranke.
Adding VS2010 project for modifying webkitpy. Uses pytools
<http://pytools.codeplex.com> which integrates python into
Visual Studio.
* Scripts/webkitpy/webkitpy.pyproj: Added.
* Scripts/webkitpy/webkitpy.sln: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 00:57:46 +0000 (00:57 +0000)]
Vertical alternate glyph (GSUB) support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81389
Patch by Koji Ishii <kojiishi@gmail.com> on 2012-07-16
Reviewed by Tony Chang.
Source/WebCore:
This patch adds support for reading 'GSUB' OpenType table to get
vertical alternate glyphs.
http://www.microsoft.com/typography/otspec/gsub.htm
Like bug 81326, this code isn't on any code path yet.
Tests: WebKit/chromium/tests/OpenTypeVerticalDataTest.cpp
* platform/graphics/opentype/OpenTypeTypes.h:
(WebCore::OpenType::validateTable): Moved from OpenTypeVerticalData.cpp for unit tests.
(OpenType):
(TableBase): Ditto.
(WebCore::OpenType::TableBase::isValidEnd):
(WebCore::OpenType::TableBase::validatePtr):
(WebCore::OpenType::TableBase::validateOffset):
* platform/graphics/opentype/OpenTypeVerticalData.cpp:
(OpenType): Added several OpenType tables used by 'GSUB' table.
(CoverageTable):
(Coverage1Table):
(Coverage2Table):
(RangeRecord):
(SubstitutionSubTable):
(WebCore::OpenType::SubstitutionSubTable::coverage):
(SingleSubstitution2SubTable):
(LookupTable):
(WebCore::OpenType::LookupTable::getSubstitutions):
(LookupList):
(WebCore::OpenType::LookupList::lookup):
(FeatureTable):
(WebCore::OpenType::FeatureTable::getGlyphSubstitutions):
(FeatureList):
(FeatureRecord):
(WebCore::OpenType::FeatureList::feature):
(LangSysTable):
(WebCore::OpenType::LangSysTable::feature):
(ScriptTable):
(LangSysRecord):
(WebCore::OpenType::ScriptTable::defaultLangSys):
(ScriptList):
(ScriptRecord):
(WebCore::OpenType::ScriptList::script):
(WebCore::OpenType::ScriptList::defaultScript):
(WebCore::OpenType::ScriptList::defaultLangSys):
(GSUBTable):
(WebCore::OpenType::GSUBTable::scriptList):
(WebCore::OpenType::GSUBTable::featureList):
(WebCore::OpenType::GSUBTable::lookupList):
(WebCore::OpenType::GSUBTable::defaultLangSys):
(WebCore::OpenType::GSUBTable::feature):
(WebCore::OpenType::GSUBTable::getVerticalGlyphSubstitutions):
(WebCore::OpenTypeVerticalData::OpenTypeVerticalData):
(WebCore::OpenTypeVerticalData::loadMetrics): Split code to load metrics from ctor.
(WebCore::OpenTypeVerticalData::loadVerticalGlyphSubstitutions): Load the vertical alternate Glyph substitution table.
(WebCore):
(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs): Substitute Glyph IDs with vertical alternate Glyph IDs.
* platform/graphics/opentype/OpenTypeVerticalData.h:
(OpenTypeVerticalData): Added m_verticalGlyphMap.
Source/WebKit/chromium:
Tests for pointer validations for OpenType tables.
* WebKit.gypi:
* tests/OpenTypeVerticalDataTest.cpp: Added.
(WebCore):
(TestTable):
(WebCore::TestTable::validateOffset):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Tue, 17 Jul 2012 00:52:57 +0000 (00:52 +0000)]
Fix spelling of EnforceIFrameAllowFullScreenRequirement and ExemptIFrameAllowFullScreenRequirement.
https://bugs.webkit.org/show_bug.cgi?id=91437
Reviewed by Adrienne Walker.
Document contained spelling errors of 'FulScreen' instead of 'FullScreen'
for the FullScreenCheckType enumeration.
No test changes needed.
* dom/Document.cpp:
(WebCore::Document::requestFullScreenForElement):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::webkitRequestFullscreen):
(WebCore::Element::webkitRequestFullScreen):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 17 Jul 2012 00:48:54 +0000 (00:48 +0000)]
Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why
https://bugs.webkit.org/show_bug.cgi?id=91174
Reviewed by Kent Tamura.
Clarified the explanation.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 00:46:13 +0000 (00:46 +0000)]
Unreviewed, rolling out r120033.
http://trac.webkit.org/changeset/120033
https://bugs.webkit.org/show_bug.cgi?id=91454
Broke background gradients (Requested by smfr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 17 Jul 2012 00:43:21 +0000 (00:43 +0000)]
[Chromium] Move GamepadController into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91311
Reviewed by Tony Chang.
GamepadController looks like a simple class to move into TestRunner.a
because it has almost zero dependence on TestShell.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
* DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
* DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
* DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
- GamepadController depends on these bindings helpers.
* DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
* DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
- Just moved these files and removed the unused TestShell
references.
* DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
- No longer needed.
* DumpRenderTree/chromium/TestShell.cpp:
- Update call to constructor to avoid passing in this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Tue, 17 Jul 2012 00:31:41 +0000 (00:31 +0000)]
IndexedDB: Implement spec updates to IDBTransaction.error
https://bugs.webkit.org/show_bug.cgi?id=91409
Reviewed by Tony Chang.
Source/WebCore:
The Indexed DB spec was updated to resolve some edge cases around the
IDBTransaction.error attribute. It was agreed that accessing error should
never throw, error should be null if the transaction is not finished or
abort() was explicitly called, an appropriate error should be returned if
a commit failed, and a generic AbortError should be used if a request
callback throws. These cases are now handled per spec, except that a reason
is not provided for the commit failure (it's always UnknownError).
Test: storage/indexeddb/transaction-error.html
storage/indexeddb/transaction-abort.html
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent): Refactor some nested if() blocks; don't
re-abort the transaction if dispatching in response to an abort.
(WebCore::IDBRequest::uncaughtExceptionInEventHandler): Abort transaction
only if not already aborting, and set it's error to AbortError.
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Set error if abort triggered by back end.
* Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::db): Move impl to header file.
(WebCore::IDBTransaction::error): Move impl to header file, simplify.
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl: The error attribute no longer throws.
LayoutTests:
Update transaction-abort test to accomodate refinements in the spec around
IDBTransaction.error and add a dedicated test to exercise all spec behavior
for the property.
* storage/indexeddb/resources/transaction-abort.js:
(startTest):
(firstAdd):
(secondAdd):
(transactionAborted):
* storage/indexeddb/resources/transaction-error.js: Added.
(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(startTest.trans.onabort):
(startTest):
(testErrorFromRequest.request.onerror):
(testErrorFromRequest.trans.onabort):
(testErrorFromRequest):
(testErrorFromException.request.onerror):
(testErrorFromException.trans.onabort):
(testErrorFromException):
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-error-expected.txt: Added.
* storage/indexeddb/transaction-error.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 00:31:09 +0000 (00:31 +0000)]
[chromium] Fix WebFrameTest flakiness due to synthetic mouse events
https://bugs.webkit.org/show_bug.cgi?id=91428
Patch by Alexandre Elias <aelias@google.com> on 2012-07-16
Reviewed by Adam Barth.
Synthetic mouse move events on scrolling can cause segfaults in
WebFrameTest due to delayed callbacks on the message loop after
state destruction. This is currently only affecting
the Android port, but has the potential to affect other platforms in the
future.
We can avoid the issue by disabling the deviceSupportsMouse
setting, which shouldn't be needed by any WebFrameTest.
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::createWebViewAndLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 17 Jul 2012 00:03:48 +0000 (00:03 +0000)]
Source/WebCore: IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.
Refactor IndexWriter to depend only on IDBIndexMetadata and on
(databaseId, objectStoreId, indexId) so that it can talk directly
to the backing store, and also eventually be moved into the renderer.
This also introduces IDBObjectStoreBackendInterface::putWithIndexKeys
as a replacement for IDBObjectStoreBackendInterface::put, already
stubbed out in the chromium port. It will fully replace put()
after both chromium and webkit sides have reached alignment.
No new tests as this is just a refactor and existing tests cover
correctness.
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
* Modules/indexeddb/IDBIndexBackendImpl.h:
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
Source/WebKit/chromium: IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.
Stub out implementations of putWithIndexKeys(), already implemented
on the chromium side.
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::putWithIndexKeys):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
Tools: [Chromium-android] Don't use test_shell mode of DRT
https://bugs.webkit.org/show_bug.cgi?id=88542
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-07-16
Reviewed by Dirk Pranke.
Test shell mode is about to be removed.
Switch to use DRT mode for chromium-android.
Summary of changes:
1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter::handleImage): Outputs base64 on Android.
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit): Changed err_file to err_fifo, required by python ServerProcess.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver.cmd_line):
(ChromiumAndroidDriver._deadlock_detector):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver.start):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._command_from_driver_input):
(ChromiumAndroidDriver._read_prompt):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_driver_cmd_line):
(ChromiumAndroidDriverTest.test_cmd_line):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.test_drt_cmd_line):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_command_from_driver_input):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.__init__): Added universal_newlines to handle Android 'adb shell' line ends.
(ServerProcess._start):
(ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
(ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
(ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input):
(WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(MockServerProcess.read_stdout):
(MockServerProcess.start):
(MockServerProcess):
(MockServerProcess.stop):
(MockServerProcess.kill):
(WebKitDriverTest.test_read_block):
(WebKitDriverTest.test_read_binary_block):
(WebKitDriverTest.test_read_base64_block):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 23:58:48 +0000 (23:58 +0000)]
IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.
Source/WebCore:
Refactor IndexWriter to depend only on IDBIndexMetadata and on
(databaseId, objectStoreId, indexId) so that it can talk directly
to the backing store, and also eventually be moved into the renderer.
This also introduces IDBObjectStoreBackendInterface::putWithIndexKeys
as a replacement for IDBObjectStoreBackendInterface::put, already
stubbed out in the chromium port. It will fully replace put()
after both chromium and webkit sides have reached alignment.
No new tests as this is just a refactor and existing tests cover
correctness.
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
* Modules/indexeddb/IDBIndexBackendImpl.h:
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
Source/WebKit/chromium:
Stub out implementations of putWithIndexKeys(), already implemented
on the chromium side.
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::putWithIndexKeys):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Mon, 16 Jul 2012 23:47:13 +0000 (23:47 +0000)]
[chromium] Unreviewed gardening. Layout Test plugins/embed-attributes-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91445
Started failing around r122770
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 16 Jul 2012 23:46:06 +0000 (23:46 +0000)]
nrwt: move a bunch of printing code from manager.py to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91439
Reviewed by Ojan Vafai.
All of the logic that handles what gets logged should eventually
live in printing.py; this patch moves a large chunk of code that
prints all of the stuff after the run completes.
There are no functional changes, this is just moving code
around. Covered by existing tests (updated as necessary).
This code is all pretty messy and most of it should be deleted
(or extracted after the fact from results.json), but I'm saving
that for further patches. My goal is just to manager.py to a
more manageable state.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._num_digits):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ResultSummaryTest.summarized_results):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
(ResultSummary.add):
Here we had to add a list of the slow tests to the result
summary so that we didn't need to call back into the manager and
the test expectations object to figure out if a test is SLOW.
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_results):
(Printer):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 16 Jul 2012 23:45:35 +0000 (23:45 +0000)]
[chromium] Unify compositor quad transforms into content space
https://bugs.webkit.org/show_bug.cgi?id=91350
Reviewed by Kenneth Russell.
Source/WebCore:
For the purpose of simplification and as a first step towards removing
any transform that takes a centered rect, remove the ability of layers
to override the quad transform. All quads and quad transforms operate
on content space with the origin in the top left.
The gutter quads used to use the root layer (that doesn't draw
content) as the layer to create the shared quad state from. This is
now created manually as a layer without bounds should never in general
need a shared quad state created for it.
No change in functionality; tested by existing layout and unit tests.
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::createSharedQuadState):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
Source/WebKit/chromium:
Update tests to add bounds/contentBounds properties to layers. This
exposed a bug in the quad culler tests where the draw transform was
incorrectly being set to the origin transform rather than being a
transform that operates on centered layer rects. Fixed this bug.
* tests/CCQuadCullerTest.cpp:
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::createLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 16 Jul 2012 23:05:21 +0000 (23:05 +0000)]
IndexedDB: Resolve test and IDL FIXMEs for a handful of landed patches
https://bugs.webkit.org/show_bug.cgi?id=91423
Reviewed by Tony Chang.
Source/WebCore:
IDBObjectStore.createIndex() had a hack to handle a null keyPath argument for the
DOMString[] overload and treat it as the string "null". Now that IDL arrays are not
nullable by default following r121817 this hack can be removed and the binding layer
will automagically coerce to DOMString.
Test: storage/indexeddb/keypath-basics.html
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex): Remove special case for null in DOMString[] overload.
* Modules/indexeddb/IDBObjectStore.idl: Remove Nullable suffix from DOMString[] overload
so that the DOMString overload will match null.
LayoutTests:
Resolve a couple of test-only FIXMEs: range deletion is now supported and
empty transactions commit.
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/database-closepending-flag.js:
(testDatabaseClosingSteps): Don't need a dummy request to keep transaction alive.
* storage/indexeddb/resources/key-generator.js: Can test a range delete now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 16 Jul 2012 22:52:43 +0000 (22:52 +0000)]
[Chromium] Create a stub TestRunner.a target
https://bugs.webkit.org/show_bug.cgi?id=91309
Reviewed by Ryosuke Niwa.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 22:48:41 +0000 (22:48 +0000)]
Resolve CSS Exclusions shapeInside, shapeOutside properties to Length based WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=89670
Patch by Bear Travis <betravis@adobe.com> on 2012-07-16
Reviewed by Dirk Schulze.
Source/WebCore:
Layout of CSS Exclusions requires length based WrapShape classes,
rather than the existing CSSValue based CSSWrapShape classes. This
patch adds length based WrapShape analogs to the CSSWrapShapes, and
modifies RenderStyle to use a WrapShape instead of a CSSWrapShape.
The translation between WrapShape and CSSWrapShape classes
is handled by helper functions in the new WrapShapeFunctions files.
StyleBuilder resolves CSSWrapShapes to WrapShapes for layout use.
CSSComputedStyleDeclaration translates WrapShapes to CSSWrapShapes
for style use.
There are existing tests that cover the style serialization / resolution
in fast/exclusions/parsing-wrap-shape-inside.html and
fast/exclusions/parsing/wrap-shape-outside.html
Test: fast/exclusions/parsing-wrap-shape-lengths.html
* CMakeLists.txt: Build system changes for adding new files
* GNUmakefile.list.am: Ditto
* Target.pri: Ditto
* WebCore.gypi: Ditto
* WebCore.vcproj/WebCore.vcproj: Ditto
* WebCore.xcodeproj/project.pbxproj: Ditto
* css/CSSComputedStyleDeclaration.cpp: Translate WrapShapes back to CSSWrapShapes
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSWrapShapes.h: Mostly changing functions to be const
(WebCore::CSSWrapShapeRectangle::type):
(WebCore::CSSWrapShapeCircle::type):
(WebCore::CSSWrapShapeEllipse::type):
(WebCore::CSSWrapShapePolygon::getXAt):
(WebCore::CSSWrapShapePolygon::getYAt):
(WebCore::CSSWrapShapePolygon::values):
(WebCore::CSSWrapShapePolygon::type):
* css/StyleBuilder.cpp: Resolve CSSWrapShapes to WrapShapes
(WebCore):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):
* css/WrapShapeFunctions.cpp: Added.
(WebCore):
(WebCore::valueForWrapShape):
(WebCore::convertToLength):
(WebCore::wrapShapeForValue):
* css/WrapShapeFunctions.h: Added.
(WebCore):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
* rendering/style/WrapShapes.h: Added.
(WebCore):
(WrapShape):
(WebCore::WrapShape::~WrapShape):
(WebCore::WrapShape::WrapShape):
(WrapShapeRectangle):
(WebCore::WrapShapeRectangle::create):
(WebCore::WrapShapeRectangle::left):
(WebCore::WrapShapeRectangle::top):
(WebCore::WrapShapeRectangle::width):
(WebCore::WrapShapeRectangle::height):
(WebCore::WrapShapeRectangle::cornerRadiusX):
(WebCore::WrapShapeRectangle::cornerRadiusY):
(WebCore::WrapShapeRectangle::setLeft):
(WebCore::WrapShapeRectangle::setTop):
(WebCore::WrapShapeRectangle::setWidth):
(WebCore::WrapShapeRectangle::setHeight):
(WebCore::WrapShapeRectangle::setCornerRadiusX):
(WebCore::WrapShapeRectangle::setCornerRadiusY):
(WebCore::WrapShapeRectangle::type):
(WebCore::WrapShapeRectangle::WrapShapeRectangle):
(WrapShapeCircle):
(WebCore::WrapShapeCircle::create):
(WebCore::WrapShapeCircle::left):
(WebCore::WrapShapeCircle::top):
(WebCore::WrapShapeCircle::radius):
(WebCore::WrapShapeCircle::setLeft):
(WebCore::WrapShapeCircle::setTop):
(WebCore::WrapShapeCircle::setRadius):
(WebCore::WrapShapeCircle::type):
(WebCore::WrapShapeCircle::WrapShapeCircle):
(WrapShapeEllipse):
(WebCore::WrapShapeEllipse::create):
(WebCore::WrapShapeEllipse::top):
(WebCore::WrapShapeEllipse::left):
(WebCore::WrapShapeEllipse::radiusX):
(WebCore::WrapShapeEllipse::radiusY):
(WebCore::WrapShapeEllipse::setTop):
(WebCore::WrapShapeEllipse::setLeft):
(WebCore::WrapShapeEllipse::setRadiusX):
(WebCore::WrapShapeEllipse::setRadiusY):
(WebCore::WrapShapeEllipse::type):
(WebCore::WrapShapeEllipse::WrapShapeEllipse):
(WrapShapePolygon):
(WebCore::WrapShapePolygon::create):
(WebCore::WrapShapePolygon::windRule):
(WebCore::WrapShapePolygon::values):
(WebCore::WrapShapePolygon::getXAt):
(WebCore::WrapShapePolygon::getYAt):
(WebCore::WrapShapePolygon::setWindRule):
(WebCore::WrapShapePolygon::appendPoint):
(WebCore::WrapShapePolygon::type):
(WebCore::WrapShapePolygon::WrapShapePolygon):
LayoutTests:
Test that wrap shapes accept different length types
Wrap shape parsing and serialization is tested by parsing-wrap-shape-inside/outside
* fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Added.
* fast/exclusions/parsing-wrap-shape-lengths.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Mon, 16 Jul 2012 22:34:35 +0000 (22:34 +0000)]
[chromium] Assign some bug numbers to failing tests.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 16 Jul 2012 22:17:29 +0000 (22:17 +0000)]
Unreviewed, adding forgotten files.
* dfg/DFGRegisterSet.h: Added.
(DFG):
(RegisterSet):
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):
* dfg/DFGScratchRegisterAllocator.h: Added.
(DFG):
(ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 16 Jul 2012 22:17:10 +0000 (22:17 +0000)]
Fix compositing layers in columns when in paginated mode
https://bugs.webkit.org/show_bug.cgi?id=91425
Reviewed by Dave Hyatt.
Source/WebCore:
Enhance a hack that was added to allow composited layers to
display in columns to work for paginated mode, where the
RenderView is renderer with columns.
Test: compositing/columns/composited-in-paginated.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
LayoutTests:
Testcase with a composited layer in a paginated document,
that dumps layers.
* compositing/columns/composited-in-paginated-expected.txt: Added.
* compositing/columns/composited-in-paginated.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Mon, 16 Jul 2012 22:10:46 +0000 (22:10 +0000)]
Inconsistent rounding in table layout causes background color to bleed through
https://bugs.webkit.org/show_bug.cgi?id=91410
Reviewed by Eric Seidel.
Source/WebCore:
At certain zoom levels a rounding error in the table layout code cases
the table background color to bleed through between cells. Tables layout
happens on pixel bounds however the paint offset wasn't correctly rounded.
Test: fast/sub-pixel/table-rows-no-gaps.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
Round paintOffset before passing it to the paint method of the children.
LayoutTests:
Add test to ensure that the table background color doesn't bleed through
when the table and a cell are positioned on a subpixel bound.
* fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
* fast/sub-pixel/table-rows-no-gaps.html: Added.
* platform/chromium-linux/css1/basic/inheritance-expected.png:
* platform/chromium-linux/plugins/embed-attributes-style-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
Updated expectations to match new rounding logic. The new results better
match the rendering prior to turning on subpixel layout.
* platform/efl/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Mark new test as skipped on platforms that have not enabled subpixel
layout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 16 Jul 2012 22:08:21 +0000 (22:08 +0000)]
DFG PutById transition should handle storage allocation, and inline it
https://bugs.webkit.org/show_bug.cgi?id=91337
Reviewed by Oliver Hunt.
This enables the patching of DFG PutById to handle the out-of-line storage
allocation case. Furthermore, it inlines out-of-line storage allocation (and
reallocation) into the generated stubs.
To do this, this patch adds the ability to store the relevant register
allocation state (i.e. the set of in-use registers) in the structure stub
info so that the stub generation code can more flexibly select scratch
registers: sometimes it needs none, sometimes one - or sometimes up to
three. Moreover, to make the stub generation register allocation simple and
maintainable, this patch introduces a reusable scratch register allocator
class. This register allocator understands that some registers are in use by
the main path code and so must be spilled as necessary, other registers are
locked for use in the stub itself and so cannot even be spilled, while still
others may be allocated for scratch purposes. A scratch register that is
used must be spilled. If a register is locked, it cannot be used as a
scratch register. If a register is used, it can be used as a scratch
register so long as it is spilled.
This is a sub-1% speed-up on V8 and neutral elsewhere.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerCodeRef.h:
(FunctionPtr):
(JSC::FunctionPtr::FunctionPtr):
* bytecode/StructureStubInfo.h:
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGGPRInfo.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::isInUse):
(RegisterBank):
* dfg/DFGRegisterSet.h: Added.
(DFG):
(RegisterSet):
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
* dfg/DFGScratchRegisterAllocator.h: Added.
(DFG):
(ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::usedRegisters):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
* heap/CopiedAllocator.h:
(CopiedAllocator):
(JSC::CopiedAllocator::fastPathShouldSucceed):
(JSC):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 21:35:25 +0000 (21:35 +0000)]
Unreviewed, rolling out r122739.
http://trac.webkit.org/changeset/122739
https://bugs.webkit.org/show_bug.cgi?id=91424
Broke mac builds (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16
* inspector/CodeGeneratorInspector.py:
(flatten_list):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Mon, 16 Jul 2012 21:30:28 +0000 (21:30 +0000)]
[chromium] Remove non-ephemeral data from RenderSurface as it duplicates data from the owning layer
https://bugs.webkit.org/show_bug.cgi?id=91418
Reviewed by Adrienne Walker.
This removes the filters and masks from render surfaces, and makes them
used directly from the owning layer. Also removes skipsDraw from
surfaces as it was just not used at all.
Covered by existing tests.
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::filters):
(WebCore::LayerChromium::backgroundFilters):
(WebCore::LayerChromium::hasMask):
(WebCore::LayerChromium::hasReplica):
(WebCore::LayerChromium::replicaHasMask):
(LayerChromium):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::hasMask):
(WebCore::CCLayerImpl::hasReplica):
(WebCore::CCLayerImpl::replicaHasMask):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::calculateMemoryForRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::finishedRenderTarget):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToRenderTarget):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 16 Jul 2012 21:18:13 +0000 (21:18 +0000)]
Unreviewed build fix.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 16 Jul 2012 21:13:29 +0000 (21:13 +0000)]
test-webkitpy: clean up logging to make it ninja-esque
https://bugs.webkit.org/show_bug.cgi?id=91297
Reviewed by Adam Barth.
This patch changes the output of test-webkitpy to be closer to
what ninja produces. Namely:
If you are running with stderr writing to a tty (and not -v), we
will no longer print '...' as tests complete. Instead, we use a
metered stream and print entries of the form:
'[X/Y] test_name passed/failed/erred'
where X is the current test # and Y is the total number of tests.
If you are running with stderr piped to a file or other non-tty
object (or with -v), you get the same output, one per line for
every test.
In addition, if tests fail or err out, you get the stack trace
immediately; you don't have to wait until the end of the run.
Lastly, this change cleans up the unit tests for test-webkitpy
itself to not confuse the logger and to work cleanly w/ multiple
processes. It looks like between this and all the clean up in
MessagePool that happened as it landed, we can now run
multiprocessing tests in parallel.
* Scripts/webkitpy/test/finder.py:
(Finder._default_names):
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.setUp):
(FinderTest.tearDown):
* Scripts/webkitpy/test/printer.py:
(Printer.__init__):
(Printer.configure):
(Printer.print_started_test):
(Printer.print_finished_test):
(Printer._test_line):
(Printer.print_result):
* Scripts/webkitpy/test/runner.py:
(Runner.run):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.setUp):
(RunnerTest):
(RunnerTest.tearDown):
(RunnerTest.assert_run):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Mon, 16 Jul 2012 21:13:28 +0000 (21:13 +0000)]
[chromium] Unreviewed gardening. Layout Test svg/W3C-SVG-1.1/animate-elem-39-t.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=91421
This test is flaky (crashing) on the Win7 bot and has been for some time.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Mon, 16 Jul 2012 21:06:54 +0000 (21:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=91299
Paginated views should restrict available height to column height
-and corresponding-
<rdar://problem/
11152108>
Reviewed by Dan Bernstein.
Source/WebCore:
Now that RenderViews can have columns, availableLogicalHeight needs to consider
that column height, much like how availableLogicalWidth already considers column
width.
availableLogicalHeight is newly virtual, like the already-virtual
availableLogicalWidth.
* rendering/RenderBox.h:
(RenderBox):
Check with the columnHeight.
* rendering/RenderView.cpp:
(WebCore):
(WebCore::RenderView::availableLogicalHeight):
* rendering/RenderView.h:
setPagination now takes pageLength as an optional parameter.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setPagination):
* testing/InternalSettings.h:
(WebCore::InternalSettings::setPagination):
(InternalSettings):
* testing/InternalSettings.idl:
* testing/Internals.cpp:
(WebCore::Internals::setPagination):
* testing/Internals.h:
(WebCore::Internals::setPagination):
(Internals):
* testing/Internals.idl:
LayoutTests:
New test.
* fast/multicol/resources/big-green.png: Added.
* fast/multicol/shrink-to-column-height-for-pagination.html: Added.
* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michelangelo@webkit.org [Mon, 16 Jul 2012 21:06:35 +0000 (21:06 +0000)]
Adobe Web Platform Team Blog is missing from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=91407
Reviewed by Andreas Kling.
Adding Adobe Web Platform Team Blog feed to Planet WebKit.
* config.ini:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 16 Jul 2012 21:06:28 +0000 (21:06 +0000)]
test-webkitpy: handle failures properly when running in parallel
https://bugs.webkit.org/show_bug.cgi?id=91416
Reviewed by Tony Chang.
It turns out that unittest.TestResults contain a handle to the
test method itself, which isn't picklable; it's sufficient to just
store the test name instead of the actual method. By doing so
we can move the test_name() method from the printer to the
runner where it belongs (so the printer is less dependent on the
unittest framework's data structures).
This change should really have a test but I don't know how to
write one that properly captures the behavior and won't cause
test-webkitpy itself to fail. I've verified the fix by hand, at
least, in the meantime.
* Scripts/webkitpy/test/printer.py:
(Printer.__init__):
(Printer.print_result):
* Scripts/webkitpy/test/runner.py:
(_test_name):
(Runner.all_test_names):
(_Worker.handle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Mon, 16 Jul 2012 20:48:40 +0000 (20:48 +0000)]
Fix Layout Test pointer-lock/locked-element-removed-from-dom.html flakiness.
https://bugs.webkit.org/show_bug.cgi?id=91373
Reviewed by Adrienne Walker.
pointer-lock-test-harness corrected to no longer silently allow too many
asynchronous doNextStep calls in a test. The locked-element-removed-from-dom test
generated too many events and incorrectly exited the test early.
* platform/chromium/TestExpectations:
Re-enabled locked-element-removed-from-dom test.html
* pointer-lock/locked-element-removed-from-dom.html:
Absorb extra doNextStep.
* pointer-lock/resources/pointer-lock-test-harness.js:
(doNextStep.setTimeout):
Fail tests that call doNextStep too many times.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 20:44:47 +0000 (20:44 +0000)]
Any webpage can crash webkit via qnx.callExtensionMethod assuming 'this' is the 'qnx' object.
https://bugs.webkit.org/show_bug.cgi?id=91419
Run the following in inspector to crash WebKit
qnx.callExtensionMethod.apply(window, []);
In the c++ that handles the function it assumes that when callExtensionMethod
is called that 'this' is the object 'qnx'. The qnx object has a hidden
variable that the code casts and uses, but when 'this' is not qnx such as the
example this will cause a crash. Any website can insert the above JavaScript
to cause the crash.
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-16
Reviewed by Yong Li.
* WebCoreSupport/ClientExtension.cpp:
(clientExtensionMethod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Mon, 16 Jul 2012 20:39:12 +0000 (20:39 +0000)]
[chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into
https://bugs.webkit.org/show_bug.cgi?id=91288
Reviewed by Adrienne Walker.
Source/WebCore:
Always use pointers to layers when discussing render targets instead of
pointing directly to a RenderSurface.
Covered by existing tests.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::createRenderSurface):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::renderTarget):
(WebCore::LayerChromium::setRenderTarget):
(LayerChromium):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::renderTarget):
(WebCore::CCLayerImpl::setRenderTarget):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateLayerScissorRect):
(WebCore::calculateSurfaceScissorRect):
(WebCore::calculateVisibleContentRect):
(WebCore::computeScrollCompensationForThisLayer):
(WebCore::calculateDrawTransformsInternal):
(WebCore::pointIsClippedBySurfaceOrClipRect):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::enterLayer):
(WebCore::::leaveLayer):
(WebCore::::enterRenderTarget):
(WebCore::::finishedRenderTarget):
(WebCore):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToRenderTarget):
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore::::layerScissorRectInTargetSurface):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::StackObject::StackObject):
(StackObject):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::appendSurface):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
* tests/CCQuadCullerTest.cpp:
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeTiledLayerChromium::setTexturePriorities):
* tests/LayerChromiumTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fmalita@chromium.org [Mon, 16 Jul 2012 20:31:54 +0000 (20:31 +0000)]
SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326
Reviewed by Simon Fraser.
SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.
Source/WebCore:
Test: svg/animations/smil-setcurrenttime-crash.svg
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
* svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
* svg/animations/smil-setcurrenttime-crash.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 20:29:07 +0000 (20:29 +0000)]
[BlackBerry] Upstream WebGL Code
https://bugs.webkit.org/show_bug.cgi?id=91143
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-16
Reviewed by Rob Buis.
This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation.
Source/WebCore:
No new tests, because there is no new functionality.
* platform/graphics/GraphicsContext3D.h: Add a value for TI Imagination chipsets on BlackBerry platforms
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp: Multiple downstream changes
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore):
(WebCore::GraphicsContext3D::logFrameBufferStatus):
(WebCore::GraphicsContext3D::readPixelsIMG): BlackBerry-specific fix for Imagination hardware.
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary whitespace.
(Extensions3DOpenGL):
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Hack to fix ANGLE-generated code on BlackBerry platforms.
* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(Extensions3DOpenGLCommon):
* platform/graphics/opengl/Extensions3DOpenGLES.cpp: I am not in a position to change system headers from correct to incorrect.
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisample):
(WebCore::Extensions3DOpenGLES::supportsExtension):
* platform/graphics/opengl/Extensions3DOpenGLES.h: I am not in a position to change system headers from correct to incorrect.
(Extensions3DOpenGLES):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Add a BlackBerry-specific anti-aliasing fix.
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore):
Source/WebKit:
* PlatformBlackBerry.cmake: Define WTF_USE_OPENGL_ES_2 on WebGL-enabled builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 16 Jul 2012 20:06:15 +0000 (20:06 +0000)]
Add dfg switch to create_jit_stubs script
https://bugs.webkit.org/show_bug.cgi?id=91256
Reviewed by Geoffrey Garen.
* create_jit_stubs: Add a switch to enable or disable the generation of
stub functions in #if ENABLE(DFG_JIT) conditions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Mon, 16 Jul 2012 19:55:02 +0000 (19:55 +0000)]
[chromium] Unreviewed gardening. Layout Test fast/frames/calculate-fixed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=91415
Has been intermittently failing TEXT since at least r122699.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 16 Jul 2012 19:37:18 +0000 (19:37 +0000)]
test-webkitpy: run tests in parallel
https://bugs.webkit.org/show_bug.cgi?id=91294
Reviewed by Ojan Vafai.
This change adds support for running tests in parallel. This is
not yet on by default, since the logging isn't very pretty w/
parallel tests.
Also, there are some (multiprocessing-related) tests that can't be
run in parallel and so we skip them in that situation; I need to
come up with a mechanism for dealing with this, since you
apparently can't use multiprocessing as both a parent and a
child process.
* Scripts/webkitpy/test/finder.py:
(Finder.find_names):
(Finder._default_names):
* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester.run):
* Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_no_tests_found):
* Scripts/webkitpy/test/runner.py:
(Runner.run):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 16 Jul 2012 19:35:14 +0000 (19:35 +0000)]
test-webkitpy: use message pools
https://bugs.webkit.org/show_bug.cgi?id=91292
Reviewed by Ojan Vafai.
Restructure the test-running code to be message-driven and
use a MessagePool; note that this does not yet actually run the
tests in parallel.
Also clean up the unit tests so that the fake loader is passed
to the _Worker properly, and reduce a lot of the cut&pasted code
in the tests.
No functional changes; covered by existing tests.
* Scripts/webkitpy/test/printer.py:
(Printer.print_started_test):
(Printer.print_finished_test):
* Scripts/webkitpy/test/runner.py:
(Runner.__init__):
(Runner.run):
(Runner.handle):
(_Worker):
(_Worker.__init__):
(_Worker.handle):
* Scripts/webkitpy/test/runner_unittest.py:
(RunnerTest.assert_run):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Mon, 16 Jul 2012 19:32:36 +0000 (19:32 +0000)]
Cleanup a bunch of invalid BUG* lines. Rebaseline tests that were straightfoward
rebaselines and update the expectations to match what's actually happening on the bots.
* platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-mac/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/chromium-mac/transforms/2d/zoom-menulist-expected.png: Added.
* platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png:
* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 16 Jul 2012 19:09:57 +0000 (19:09 +0000)]
Position grid items by row/column index
https://bugs.webkit.org/show_bug.cgi?id=91293
Reviewed by Ojan Vafai.
Source/WebCore:
Do some initial grid positioning. Only handle the simple case where tracks are
fixed values and don't properly size the grid items. This gives us something to
work with and starts implementing the "Grid Track Sizing Algorithm":
http://dev.w3.org/csswg/css3-grid-layout/#grid-track-sizing-algorithm0
Test: fast/css-grid-layout/place-cell-by-index.html
* rendering/RenderGrid.cpp:
(RenderGrid::GridTrack): Data structure for holding the track size. UsedBreadth matches the terminology
used in the spec.
(WebCore::RenderGrid::layoutBlock): Pull in some boiler plate code and put the
grid specific code in layoutGridItems.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Implement part of the grid track sizing algorithm.
(WebCore::RenderGrid::layoutGridItems): Compute the size of grid tracks, layout and position children.
(WebCore::RenderGrid::findChildLogicalPosition): Map track sizes to the actual position of the child.
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.h: Just return a copy of Length rather than a reference to Length. This seems
more consistent with other getters that return a Length.
LayoutTests:
Add a test for grid layout in each writing mode direction. The height in vertical writing mode is incorrect for now.
* fast/css-grid-layout/containing-block-grids-expected.html: Scope <p> around text only.
* fast/css-grid-layout/containing-block-grids.html: Fix missing closing </div>.
* fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
* fast/css-grid-layout/place-cell-by-index.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 19:06:00 +0000 (19:06 +0000)]
[chromium] Only apply page scale delta to root scroll layer
https://bugs.webkit.org/show_bug.cgi?id=91374
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-07-16
Reviewed by Adrienne Walker.
Source/WebCore:
When the user pinch-zooms the web page though the Chromium compositor, the
per-layer page scale delta is used to keep track of the difference between the
page scale on the compositor thread versus the main thread. On the next
commit to the main thread these values are reset to 1.
When calculating layer positions, the compositor applies a layer's page scale
delta both to the layer itself as well as all of its children. Since we are
currently updating the page scale delta on all scrollable layers, this results
in scrollable child layers getting scaled multiple times.
This patch changes the compositor to only apply the page scale delta on the
root scroll layer.
New unit test: CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
Source/WebKit/chromium:
New unit test
CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly to verify
the transformation of child layer while pinch zooming.
* tests/CCLayerTreeHostImplTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Jul 2012 18:59:27 +0000 (18:59 +0000)]
[BlackBerry] Improve about:memory page
https://bugs.webkit.org/show_bug.cgi?id=87676
Patch by Yong Li <yoli@rim.com> on 2012-07-16
Reviewed by Rob Buis.
Add a table for process memory usage summary for easy read.
* WebCoreSupport/AboutData.cpp:
(WebCore::memoryPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc