WebKit-https.git
7 years ago[EFL] Fix destination path in Source/PlatformEfl.cmake
commit-queue@webkit.org [Thu, 6 Dec 2012 14:11:05 +0000 (14:11 +0000)]
[EFL] Fix destination path in Source/PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=104237

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-06
Reviewed by Laszlo Gombos.

Remove InspectorBackendCommands.js when copying it for the consistency in Source/PlatformEfl.cmake.

* Source/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 6 Dec 2012 14:04:44 +0000 (14:04 +0000)]
Unreviewed GTK gardening.

Adding missing platform-specific baselines.

* platform/gtk/fast/text/decorations-with-text-combine-expected.png: Added.
* platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Added.
* platform/gtk/fast/text/orientation-sideways-expected.png: Added.
* platform/gtk/fast/text/orientation-sideways-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Fix libxslt and libxml2 config tests
abecsi@webkit.org [Thu, 6 Dec 2012 14:02:31 +0000 (14:02 +0000)]
[Qt][Mac] Fix libxslt and libxml2 config tests
https://bugs.webkit.org/show_bug.cgi?id=104164

Reviewed by Simon Hausmann.

Source/WebCore:

Since libxml2 is a dependency for libxslt and is not used
standalone the configurations for it should also depend on
whether XSLT is enabled.
Also avoid using pkg-config on Mac, instead use direct
include paths and add needed libraries to the linker.

No new tests needed.

* WebCore.pri:

Tools:

We should not use pkg-config on Mac instead use direct include
paths and add needed libraries to the linker options to detect
libxslt and libxml2 provided by the system.
Previously we would always fall back to qtxmlpatterns.

* qmake/config.tests/libxml2/libxml2.pro:
* qmake/config.tests/libxslt/libxslt.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the build if the path contains "+" character
ossy@webkit.org [Thu, 6 Dec 2012 13:55:54 +0000 (13:55 +0000)]
[Qt] Fix the build if the path contains "+" character
https://bugs.webkit.org/show_bug.cgi?id=104120

Reviewed by Tor Arne Vestbø.

The second parameter of qmake's replace() is regular expression, so
we have to escape special characters in paths passed to replace().

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing
commit-queue@webkit.org [Thu, 6 Dec 2012 13:54:32 +0000 (13:54 +0000)]
[EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104160

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

The test fast/regions/autowidth-normalflow-maxwidth.html is failing for EFL and Qt
because the test expects that the text of the test would fit in 400 pixels,
but both for Qt and for EFL, the text requires more than that.
Changed the test and the expectation ref-test to allow 450 pixels.

* fast/regions/autowidth-normalflow-maxwidth-expected.html:
* fast/regions/autowidth-normalflow-maxwidth.html:
* platform/efl-wk2/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInternals.getElementByIdInShadowRoot is nonsense now.
shinyak@chromium.org [Thu, 6 Dec 2012 13:38:47 +0000 (13:38 +0000)]
Internals.getElementByIdInShadowRoot is nonsense now.
https://bugs.webkit.org/show_bug.cgi?id=104241

Reviewed by Kent Tamura.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Since we have ShadowRoot.getElementById() now, we don't need Internals.getElementByIdInShadowRoot, which is
the same functionality of ShadowRoot.getElementById().

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def.in:

LayoutTests:

* fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
* fast/dom/shadow/get-element-by-id-in-shadow-root.html:
* fast/dom/shadow/resources/shadow-dom.js: Uses ShadowRoot.getElementById() instead.
(getNodeInShadowTreeStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Context clients should unregister themselves when destroyed
christophe.dumez@intel.com [Thu, 6 Dec 2012 13:11:24 +0000 (13:11 +0000)]
[EFL][WK2] Context clients should unregister themselves when destroyed
https://bugs.webkit.org/show_bug.cgi?id=104113

Reviewed by Kenneth Rohde Christiansen.

Make sure the context clients (History and Download clients)
unregister themselves when destroyed to make sure their
callback functions are never called after the client objects
have been destroyed (i.e. when the parent Ewk_Context has
been destroyed).

This addresses crashing issues after a Ewk_Context object
gets unref'd and destroyed.

* UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit):
(WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):
* UIProcess/efl/ContextHistoryClientEfl.h:
(ContextHistoryClientEfl):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::~DownloadManagerEfl):
(WebKit):
* UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Active texture state gets corrupted after updating graphics surface contents.
commit-queue@webkit.org [Thu, 6 Dec 2012 12:32:02 +0000 (12:32 +0000)]
[EFL] Active texture state gets corrupted after updating graphics surface contents.
https://bugs.webkit.org/show_bug.cgi?id=104248.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DPrivate::copyToGraphicsSurface() doesn't restore the previously bound texture
after copying texture contents. This corrupts the texture state.

Existing Tests should cover this.

* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(GraphicsContext3DPrivate::copyToGraphicsSurface):
* platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::updateContents):
* platform/graphics/opengl/GLPlatformSurface.h:
(GLPlatformSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Goto panel shortcuts and description are reversed
apavlov@chromium.org [Thu, 6 Dec 2012 12:29:34 +0000 (12:29 +0000)]
Web Inspector: Goto panel shortcuts and description are reversed
https://bugs.webkit.org/show_bug.cgi?id=103988

Reviewed by Pavel Feldman.

Swap the square brackets in the shortcuts.

* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136825.
commit-queue@webkit.org [Thu, 6 Dec 2012 12:13:59 +0000 (12:13 +0000)]
Unreviewed, rolling out r136825.
http://trac.webkit.org/changeset/136825
https://bugs.webkit.org/show_bug.cgi?id=104251

It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136818.
commit-queue@webkit.org [Thu, 6 Dec 2012 11:51:26 +0000 (11:51 +0000)]
Unreviewed, rolling out r136818.
http://trac.webkit.org/changeset/136818
https://bugs.webkit.org/show_bug.cgi?id=104249

simulatedClick does not work as per #chrmium irc. (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/WebCore:

* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
(MouseEventDispatchMediator):
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:
* fast/events/dispatch-synthetic-mouseevent-expected.txt: Removed.
* fast/events/dispatch-synthetic-mouseevent.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruc...
podivilov@chromium.org [Thu, 6 Dec 2012 11:13:33 +0000 (11:13 +0000)]
[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7.

* platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
* platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
* platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
* platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update
tkent@chromium.org [Thu, 6 Dec 2012 10:48:59 +0000 (10:48 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=104210
https://bugs.webkit.org/show_bug.cgi?id=103869

* platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update test expectations
tkent@chromium.org [Thu, 6 Dec 2012 10:25:52 +0000 (10:25 +0000)]
[Chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=103853
https://bugs.webkit.org/show_bug.cgi?id=103869

* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
commit-queue@webkit.org [Thu, 6 Dec 2012 10:08:29 +0000 (10:08 +0000)]
[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Fix hidden property name of V8ArrayBufferView flag.
commit-queue@webkit.org [Thu, 6 Dec 2012 09:49:09 +0000 (09:49 +0000)]
[v8] Fix hidden property name of V8ArrayBufferView flag.
https://bugs.webkit.org/show_bug.cgi?id=104099

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-12-06
Reviewed by Kentaro Hara.

Fix hidden property name of V8ArrayBufferView hidden copy method.

* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixed a wrong comment landed in r136822.
haraken@chromium.org [Thu, 6 Dec 2012 09:38:38 +0000 (09:38 +0000)]
Unreviewed. Fixed a wrong comment landed in r136822.

* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Implement deprecatedV8String()
haraken@chromium.org [Thu, 6 Dec 2012 09:19:09 +0000 (09:19 +0000)]
[V8] Implement deprecatedV8String()
https://bugs.webkit.org/show_bug.cgi?id=104230

Reviewed by Adam Barth.

To make an Isolate mandatory in v8String(), we implement
deprecatedV8String() for call sites that don't have
an Isolate. Eventually we want to kill the method though.

No tests. No change in behavior.

* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass2Param):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::getKey):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
(WebCore::ScriptController::bindToWindowObject):
(WebCore::ScriptController::disableEval):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::compileScript):
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::deprecatedV8String):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::installHiddenCopyMethod):
(WebCore::copyElements):
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage popup should align to the right when the anchor element is rtl
keishi@webkit.org [Thu, 6 Dec 2012 09:03:28 +0000 (09:03 +0000)]
Page popup should align to the right when the anchor element is rtl
https://bugs.webkit.org/show_bug.cgi?id=104219

Reviewed by Kent Tamura.

Page popup should align to the right edge of the anchor element when the anchor element is rtl.

No new tests. Mock page popup can't test popup window position.

* Resources/pagepopups/pickerCommon.js:
(_adjustWindowRectHorizontally): Align to the right edge when anchor element is rtl. Removed some redundant lines.
(setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
(isWindowHidden): Returns true if the window is hidden using hideWindow().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
haraken@chromium.org [Thu, 6 Dec 2012 09:01:57 +0000 (09:01 +0000)]
[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104213

Reviewed by Adam Barth.

All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.

No tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Implement deprecatedV8Integer(int i)
haraken@chromium.org [Thu, 6 Dec 2012 08:57:44 +0000 (08:57 +0000)]
[V8] Implement deprecatedV8Integer(int i)
https://bugs.webkit.org/show_bug.cgi?id=104220

Reviewed by Adam Barth.

To make an Isolate mandatory in v8Integer(), we implement
deprecatedV8Integer(int i) for call sites that don't have
an Isolate. Eventually we want to kill deprecatedV8Integer(int i).

No new tests. No change in behavior.

* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
* bindings/v8/NPV8Object.cpp:
(_NPN_Enumerate):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::compileScript):
* bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::deprecatedV8Integer):
* bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureConstants):
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
* bindings/v8/V8Utilities.cpp:
(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEvent's relatedTarget re-targeting does not occur for manually fired mouse events...
hayato@chromium.org [Thu, 6 Dec 2012 08:52:47 +0000 (08:52 +0000)]
Event's relatedTarget re-targeting does not occur for manually fired mouse events created by event.initMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=102681

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make sure that event's relatedTarget re-targeting occurs for mouse
events created by event.initMouseEvent().  Since user-generated
mouse events can have a relatedTarget which is same to the target
node, the algorithm which calculates event's ancestors is also
updated so that ancestors are not shrunk wrongly.

Test: fast/events/dispatch-synthetic-mouseevent.html
      fast/dom/shadow/shadow-dom-event-dispatching.html

* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
(WebCore::MouseEventDispatchMediator::isSyntheticMouseEvent):
(MouseEventDispatchMediator):
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:
* fast/events/dispatch-synthetic-mouseevent-expected.txt: Added.
* fast/events/dispatch-synthetic-mouseevent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Check whether property is an array before attempting conversion to array in...
commit-queue@webkit.org [Thu, 6 Dec 2012 08:50:56 +0000 (08:50 +0000)]
[JSC] Check whether property is an array before attempting conversion to array in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=96614

Patch by Michael Pruett <michael@68k.org> on 2012-12-06
Reviewed by Kentaro Hara.

JSDictionary should check whether the property being accessed in get()
is an array before attempting to convert the value to an array.

Previously calling get() with a result type of Vector<String> when
the named property could not be converted to an array would generate
an exception.

Tests: storage/indexeddb/*

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetPropertyAndResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to toDOMStringList()
haraken@chromium.org [Thu, 6 Dec 2012 08:47:18 +0000 (08:47 +0000)]
[V8] Pass Isolate to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=104224

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove JSDependentRetained.h and V8DependentRetained.h
haraken@chromium.org [Thu, 6 Dec 2012 08:43:22 +0000 (08:43 +0000)]
Remove JSDependentRetained.h and V8DependentRetained.h
https://bugs.webkit.org/show_bug.cgi?id=104232

Reviewed by Adam Barth.

Although (JS|V8)DependentRetained.h were introduced for MutationObservers,
they are not going to be used (See the discussion in bug 95519).
We can remove them.

No tests. No change in behavior.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDependentRetained.h: Removed.
* bindings/v8/V8DependentRetained.h: Removed.
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn pixel tests in dom/xhtml/level3/core into reftests
zandobersek@gmail.com [Thu, 6 Dec 2012 08:32:16 +0000 (08:32 +0000)]
Turn pixel tests in dom/xhtml/level3/core into reftests
https://bugs.webkit.org/show_bug.cgi?id=103809

Reviewed by Dirk Pranke.

Turn 15 pixel tests under dom/xhtml/level3/core into reftests.
The reference files are tailored so they present the same output that
the pixel baselines (being removed) do.

* dom/xhtml/level3/core/canonicalform08-expected.html: Added.
* dom/xhtml/level3/core/canonicalform09-expected.html: Added.
* dom/xhtml/level3/core/documentgetinputencoding03-expected.html: Added.
* dom/xhtml/level3/core/entitygetinputencoding02-expected.html: Added.
* dom/xhtml/level3/core/entitygetxmlversion02-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri05-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri07-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri09-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri10-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri11-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri15-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri17-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri18-expected.html: Added.
* dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.html: Added.
* dom/xhtml/level3/core/nodelookupprefix19-expected.html: Added.
* The now-unnecessary pixel and render tree baselines: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace v8String("symbol") with v8::String::NewSymbol("symbol")
haraken@chromium.org [Thu, 6 Dec 2012 08:31:55 +0000 (08:31 +0000)]
[V8] Replace v8String("symbol") with v8::String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=104209

Reviewed by Adam Barth.

V8 can look up symbols faster than strings.

No tests. No change in behavior.

* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::caller):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::scopeType):
(WebCore::JavaScriptCallFrame::thisObject):
(WebCore::JavaScriptCallFrame::evaluate):
(WebCore::JavaScriptCallFrame::restart):
* bindings/v8/V8ThrowException.cpp:
(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallback):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136784 and r136802.
commit-queue@webkit.org [Thu, 6 Dec 2012 08:20:59 +0000 (08:20 +0000)]
Unreviewed, rolling out r136784 and r136802.
http://trac.webkit.org/changeset/136784
http://trac.webkit.org/changeset/136802
https://bugs.webkit.org/show_bug.cgi?id=104231

breaks chromium canary (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/Platform:

* Platform.gypi:
* chromium/public/linux/WebThemeEngine.h: Added.
(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/PlatformThemeChromiumLinux.cpp: Added.
(WebCore):
(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):
* platform/chromium/PlatformThemeChromiumLinux.h: Added.
(WebCore):
(PlatformThemeChromiumLinux):
(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):
* platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
(WebCore):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
(ScrollbarThemeChromiumLinux):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
* rendering/RenderThemeChromiumAndroid.h:
* rendering/RenderThemeChromiumLinux.cpp: Added.
(WebCore):
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::systemColor):
(WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
(WebCore::RenderThemeChromiumLinux::controlSupportsTints):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::sliderTickSize):
(WebCore::RenderThemeChromiumLinux::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::supportsControlTints):
(WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval):
(WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
(WebCore::RenderThemeChromiumLinux::setSelectionColors):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
(WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key):
* rendering/RenderThemeChromiumLinux.h: Added.
(WebCore):
(RenderThemeChromiumLinux):

Source/WebKit/chromium:

* WebKit.gyp:
* public/linux/WebRenderTheme.h: Added.
(WebKit):
* public/platform/linux/WebThemeEngine.h: Added.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):
* src/linux/WebRenderTheme.cpp: Added.
(WebKit):
(WebKit::setCaretBlinkInterval):

Tools:

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd win8/* to Chromium DEPS (r171376)
tasak@google.com [Thu, 6 Dec 2012 07:46:31 +0000 (07:46 +0000)]
Add win8/* to Chromium DEPS (r171376)
https://bugs.webkit.org/show_bug.cgi?id=104228

Reviewed by Hajime Morita.

Since updated chromium DEPS to r171376, now printing/printing.gyp
requires win8/* for windows build.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update
tkent@chromium.org [Thu, 6 Dec 2012 07:37:58 +0000 (07:37 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=103869

* platform/chromium/TestExpectations:
Fix duplicated entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Title of "Record Timeline" status button on "Timeline
commit-queue@webkit.org [Thu, 6 Dec 2012 07:28:05 +0000 (07:28 +0000)]
Web Inspector: Title of "Record Timeline" status button on "Timeline
Panel" should reflect the recording state.
https://bugs.webkit.org/show_bug.cgi?id=104108

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-12-05
Reviewed by Alexander Pavlov.

Title should be toggled between "Record"/"Stop" to reflect current
state of the Status bar button.

No new tests as UI related change.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales
tkent@chromium.org [Thu, 6 Dec 2012 07:10:22 +0000 (07:10 +0000)]
INPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales
https://bugs.webkit.org/show_bug.cgi?id=103869

Reviewed by Hajime Morita.

Source/WebCore:

We need to use display:inline elements to wrap sub-fields and static
text in DateTimeEditElement children to apply the Unicode Bidi
Algorithm.

Because we can't use display:inline-block for them, we can't specify
min-width CSS property for them. We stop using customStyleForRenderer of
sub-fields to specify each of their widths, and use
customStyleForRenderer of DateTimeEditElement to specify the total
required width. A sub-field width shrink and grow so that the width fits
to the field value, and a DateTimeEditElement doesn't.

No new tests. Coverred by existing tests, especially
fast/forms/datetime/datetime-appearance-l10n.html shows "23:59"
correctly.

* css/html.css:
(input::-webkit-datetime-edit-year-field):
- Make this display:inline to apply the Unicode Bidi Algorithm.
- Use padding instead of margin because of ease of width computation.
  Also, the focus apparance gets better by padding.
- Don't allow to specify font property here because of ease of width
  computation.
- Remove text-align:center. It doesn't work for display:inline.
(input::-webkit-datetime-edit-text):
- Make this display:inline to apply the Unicode Bidi Algorithm.
- Don't allow to specify font property here because of ease of width
  computation.

* html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare customStyleForRenderer.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::DateTimeEditElement):
Enable customStyleForRenderer.
(WebCore::DateTimeEditElement::customStyleForRenderer):
Compute required width with a font for this element and child maximum
widths, and set it to min-width style.
The resultant width value can be inaccurate if a page author specifies
padding, border, margin, etc. to ::-webkit-datetime-edit-*-field or
::-webkit-datetime-edit-text. In such case, the page author should specify
wider width to <input>.

* dom/Element.h:
(Element): Add isDateTimeFieldElement to do static_cast<DateTimeFieldElement> safely.
* dom/Element.cpp:
(WebCore::Element::isDateTimeFieldElement): Added.

* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Declare isDateTimeFieldElement and maximumWidth.
* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::isDateTimeFieldElement):
Added. Returns true.
(WebCore::DateTimeFieldElement::maximumWidth):
Added. Returns padding width.

* html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement):
Remove customStyleForRenderer, and declare maximumWidth.
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
Disable customStyleForRenderer.
(WebCore::DateTimeSymbolicFieldElement::maximumWidth):
Added. Returns the expected maximum width with the specified font.

* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
Remove customStyleForRenderer, declare maximumWidth, and make m_placeholder
non-const because it is updated in the constructor.
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
Disable customStyleForRenderer.
If a numeric value for this field is LTR and the whole direction is RTL,
wrap the placeholder string with left-to-right-mark and
right-to-left-mark so that it is handled as LTR. Without this,
sub-fields order would be changed when the content of a field is changed
from a placeholder to a numeric value.
(WebCore::DateTimeNumericFieldElement::maximumWidth):
Added. Returns the expected maximum width with the specified font.

LayoutTests:

- Year fields and month fields are shrunk because we stop specifying
  min-width.
- Focus rectangle for sub-fields get larger.

* fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html:
Need to update mouse click positions because we have some position/width
changes in sub-fields.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html:
Ditto.
* fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html:
Ditto.
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/datetime/datetime-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to watch changes in PerformanceTests/*.
rniwa@webkit.org [Thu, 6 Dec 2012 06:36:23 +0000 (06:36 +0000)]
Add myself to watch changes in PerformanceTests/*.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DRT on Windows crashes when a testcase has a progress element in indetermi...
shinyak@chromium.org [Thu, 6 Dec 2012 06:33:10 +0000 (06:33 +0000)]
[Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
https://bugs.webkit.org/show_bug.cgi?id=102459

Reviewed by Dimitri Glazkov.

Tools:

Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.

* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::markState):

LayoutTests:

* fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] Performance tests for ShadowDOM distribution
shinyak@chromium.org [Thu, 6 Dec 2012 06:31:22 +0000 (06:31 +0000)]
[Shadow] Performance tests for ShadowDOM distribution
https://bugs.webkit.org/show_bug.cgi?id=103617

Reviewed by Dimitri Glazkov.

We would like to measure ShadowDOM distribution performance in various cases.
In this patch, we add performance tests for several distribution patterns.

* ShadowDOM/ContentReprojection.html: Added.
* ShadowDOM/DistributionWithMultipleShadowRoots.html: Added.
* ShadowDOM/LargeDistributionWithLayout.html: Added.
* ShadowDOM/MultipleInsertionPoints.html: Added.
* ShadowDOM/ShadowReprojection.html: Added.
* ShadowDOM/SmallDistributionWithLayout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG profiler should be able to display where a code block was inlined into, and what...
fpizlo@apple.com [Thu, 6 Dec 2012 06:29:39 +0000 (06:29 +0000)]
DFG profiler should be able to display where a code block was inlined into, and what it inlined
https://bugs.webkit.org/show_bug.cgi?id=104216

Reviewed by Oliver Hunt.

Added an "inlines" command that shows the inline stacks that a code block participated
in. Also cleaned up some of the ways we print compilation units.

* Scripts/display-profiler-output:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should...
tkent@chromium.org [Thu, 6 Dec 2012 06:16:37 +0000 (06:16 +0000)]
Source/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should support read-only state correctly
https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

1. The hour, am/pm, and millisecond fields should have CSS rules for
   [readonly]. They should be gray when they are read-only.
2. The am/pm field should reject to set an empty value like other
   numeric fields do.

Tests: Add test cases to fast/forms/time/time-appearance-basic.html.

* css/html.css: merge existing readonly rules, and add ampm, hour, and
millisecond pseudo classes.
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
Reject to set empty value if it is read-only.

LayoutTests: INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly
https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

* fast/forms/time/time-appearance-basic.html:
Add test cases for step=86400 (24 hours)
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, WebKit gardening.
tasak@google.com [Thu, 6 Dec 2012 06:09:54 +0000 (06:09 +0000)]
Unreviewed, WebKit gardening.

* WebKit.gyp:
Removed public/linux/WebRenderTheme.h. The file was removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] Performance tests of distribution for changing className
shinyak@chromium.org [Thu, 6 Dec 2012 06:08:19 +0000 (06:08 +0000)]
[Shadow] Performance tests of distribution for changing className
https://bugs.webkit.org/show_bug.cgi?id=103612

Reviewed by Dimitri Glazkov.

We would like to measure ShadowDOM performance and compare it to the similar functional HTML without using ShadowDOM.
In this patch, we add a case when classNames of distributed elemeents are changed.

* ShadowDOM/ChangingClassName.html: Added.
* ShadowDOM/ChangingClassNameShadowDOM.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLFormElement#requestAutocomplete() should require a user action
commit-queue@webkit.org [Thu, 6 Dec 2012 06:08:03 +0000 (06:08 +0000)]
HTMLFormElement#requestAutocomplete() should require a user action
https://bugs.webkit.org/show_bug.cgi?id=102320

Patch by Dan Beam <dbeam@chromium.org> on 2012-12-05
Reviewed by Kent Tamura.

This patch dispatches an autocompleteerror when HTMLFormElement::requestAutocomplete() is called while not processing
a user gesture.

Source/WebCore:

* fast/forms/form-request-autocomplete.html is updated.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::requestAutocomplete):

Asynchronously dispatch an autocomplete error when not processing a user action when
HTMLFormElement#requestAutocomplete() is invoked.

LayoutTests:

* fast/forms/form-request-autocomplete.html:

Added a test to ensure that dispatching a call to HTMLFormElement#requestAutocomplete() in a setTimeout() (which will
never be a user gesture) always fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself into committers.py
james.wei@intel.com [Thu, 6 Dec 2012 06:02:30 +0000 (06:02 +0000)]
Add myself into committers.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 6 Dec 2012 06:01:24 +0000 (06:01 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-05

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Optimize v8StringOrNull() and v8StringOrUndefined()
haraken@chromium.org [Thu, 6 Dec 2012 05:47:51 +0000 (05:47 +0000)]
[V8] Optimize v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104206

Reviewed by Adam Barth.

Currently v8StringOrNull() and v8StringOrUndefined() are checking
a null string twice. It is redundant.

[div.localName]
Before this patch: 20.03 ns
After this patch:  19.34 ns

* bindings/v8/V8Binding.h:
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Optimize v8String() for uninitialized DOM attributes
haraken@chromium.org [Thu, 6 Dec 2012 05:35:25 +0000 (05:35 +0000)]
[V8] Optimize v8String() for uninitialized DOM attributes
https://bugs.webkit.org/show_bug.cgi?id=104205

Reviewed by Adam Barth.

This patch makes uninitialized div.lang, div.title etc 6.3% faster.

[div.lang]
Before this patch: 12.6 ns
After this patch:  11.8 ns

* bindings/v8/V8Binding.h:
(WebCore::v8String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
commit-queue@webkit.org [Thu, 6 Dec 2012 05:09:37 +0000 (05:09 +0000)]
Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-05
Reviewed by Noam Rosenthal.

Clarify LayerTreeRenderer::setRootLayerID() can be called only once during its
lifecycle. LayerTreeRenderer, LayerTreeCoordinator and LayerTreeCoordinatorProxy
have the same lifecycle to WebPage and the root layer is reused even if loading
new page, so it is impossible to call LayerTreeRenderer::setRootLayerID() more
than twice.

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setRootLayerID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove addImplicitReferencesForNodeWithEventListeners()
haraken@chromium.org [Thu, 6 Dec 2012 04:54:09 +0000 (04:54 +0000)]
[V8] Remove addImplicitReferencesForNodeWithEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=104203

Reviewed by Adam Barth.

We can use opaqueRootForGC() instead. By this change, we can remove
all AddImplicitReferences() from V8 bindings.

Tests: fast/dom/gc-image-element.html
       fast/dom/gc-image-element-2.html
       fast/dom/inline-event-attributes-lookup-removed.html

* bindings/v8/V8GCController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Blocks don't relayout children if the width of a region changes
commit-queue@webkit.org [Thu, 6 Dec 2012 03:47:00 +0000 (03:47 +0000)]
[CSS Regions] Blocks don't relayout children if the width of a region changes
https://bugs.webkit.org/show_bug.cgi?id=103993

Patch by Andrei Bucur <abucur@adobe.com> on 2012-12-05
Reviewed by David Hyatt.

Source/WebCore:

After r135750 lines are no longer invalidating when regions change width. This is happening because the detection for the width change was being done
only at line layout time. This patch moves the line relayout decision to the containing block by setting the relayoutChildren flag if the block
has no region chain attached.

Tests: fast/regions/region-width-change-relayout-1.html
       fast/regions/region-width-change-relayout-2.html
       fast/regions/region-width-change-relayout-3.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):

LayoutTests:

The first test covers the case of reducing the width of a region for a block content node.
The second test covers the case of expanding the width of a region for a block content node.
The third test covers the case of reducing the width of a region for an inline content node.

* fast/regions/region-width-change-relayout-1-expected.html: Added.
* fast/regions/region-width-change-relayout-1.html: Added.
* fast/regions/region-width-change-relayout-2-expected.html: Added.
* fast/regions/region-width-change-relayout-2.html: Added.
* fast/regions/region-width-change-relayout-3-expected.html: Added.
* fast/regions/region-width-change-relayout-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows, WinCairo] Regenerate .def files on changes
bfulgham@webkit.org [Thu, 6 Dec 2012 03:44:08 +0000 (03:44 +0000)]
[Windows, WinCairo] Regenerate .def files on changes
https://bugs.webkit.org/show_bug.cgi?id=104136

Reviewed by Tim Horton.

The new .def file generator is not regenerating the link
export definitions once it creates the definition file
the first time. You must clean the build directory for
new symbols to be added (or removed).

* win/WebKit2.vcproj: Change the WebKit2.def file reference to
  point to the generated version of the file.
* win/WebKit2ExportGenerator.vcproj: Add WebKit2.def.in as a source
  file that participates in the build so that Visual Studio knows
  to build the project when the file changes.
* win/WebKit2ExportGeneratorBuildCmd.cmd: Added. Refactor build
  command into its own shell script.
* win/WebKit2ExportGeneratorPostBuild.cmd: Call new BuildCmd script.
* win/WebKit2ExportGeneratorPreBuild.cmd: Delete the old generator
  and definition files to ensure a clean build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent
kihong.kwon@samsung.com [Thu, 6 Dec 2012 03:37:52 +0000 (03:37 +0000)]
Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent
https://bugs.webkit.org/show_bug.cgi?id=104201

Reviewed by Laszlo Gombos.

Parameter 'event' need to covert to RefPtr in the DeviceController::dispatchDeviceEvent.
This can make crash sometimes.

No new tests. Covered by existing layout tests.

* page/DeviceController.cpp:
(WebCore::DeviceController::dispatchDeviceEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Unify coding style for CMake files
commit-queue@webkit.org [Thu, 6 Dec 2012 03:10:13 +0000 (03:10 +0000)]
[CMake] Unify coding style for CMake files
https://bugs.webkit.org/show_bug.cgi?id=103605

Patch by Halton Huo <halton.huo@intel.com> on 2012-12-05
Reviewed by Laszlo Gombos.

Update cmake files(.cmake, CMakeLists.txt) with following style rules:
1. Indentation
1.1 Use spaces, not tabs.
1.2 Four spaces as indent.
2. Spacing
2.1 Place one space between control statements and their parentheses.
    For eg, if (), else (), elseif (), endif (), foreach (),
    endforeach (), while (), endwhile (), break ().
2.2 Do not place spaces between function and macro statements and
    their parentheses. For eg, macro(), endmacro(), function(),
    endfunction().
2.3 Do not place spaces between a command or function or macro and its
    parentheses, or between a parenthesis and its content. For eg,
    message("testing") not message( "testing") or message ("testing" )
2.4 No space at line ending.
3. Lowercase when call commands macros and functions. For eg,
   add_executable() not ADD_EXECUTABLE(), set() not SET().

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/PlatformEfl.cmake:
* Source/cmake/EFLHelpers.cmake:
* Source/cmake/FindATK.cmake:
* Source/cmake/FindCFLite.cmake:
* Source/cmake/FindCairo.cmake:
* Source/cmake/FindDBus.cmake:
* Source/cmake/FindDirectX.cmake:
* Source/cmake/FindE_DBus.cmake:
* Source/cmake/FindEcore.cmake:
* Source/cmake/FindEdje.cmake:
* Source/cmake/FindEet.cmake:
* Source/cmake/FindEeze.cmake:
* Source/cmake/FindEfreet.cmake:
* Source/cmake/FindEina.cmake:
* Source/cmake/FindElementary.cmake:
* Source/cmake/FindEnchant.cmake:
* Source/cmake/FindEvas.cmake:
* Source/cmake/FindFontconfig.cmake:
* Source/cmake/FindGLIB.cmake:
* Source/cmake/FindGStreamer.cmake:
* Source/cmake/FindGperf.cmake:
* Source/cmake/FindHarfBuzz.cmake:
* Source/cmake/FindICU.cmake:
* Source/cmake/FindLibSoup.cmake:
* Source/cmake/FindQuickTimeSDK.cmake:
* Source/cmake/FindSqlite.cmake:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmake/OptionsWindows.cmake:
* Source/cmake/WebKitFS.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/WebKitHelpers.cmake:
* Source/cmake/WebKitMacros.cmake:
* Source/cmake/WebKitPackaging.cmake:
* Source/cmake/gtest/CMakeLists.txt:

Source/JavaScriptCore:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* shell/CMakeLists.txt:
* shell/PlatformBlackBerry.cmake:
* shell/PlatformEfl.cmake:
* shell/PlatformWinCE.cmake:

Source/WebCore:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* UseJSC.cmake:
* UseV8.cmake:

Source/WebKit:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:

Source/WebKit/efl:

* DefaultTheme/CMakeLists.txt:

Source/WebKit2:

* CMakeLists.txt:
* PlatformEfl.cmake:
* win/WebKit2ExportGenerator.vcproj:
* win/WebKit2ExportGeneratorCommon.vsprops:

Source/WTF:

* CMakeLists.txt:
* wtf/CMakeLists.txt:
* wtf/PlatformBlackBerry.cmake:
* wtf/PlatformEfl.cmake:
* wtf/PlatformWinCE.cmake:

Tools:

* CMakeLists.txt:
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* DumpRenderTree/efl/CMakeLists.txt:
* EWebLauncher/CMakeLists.txt:
* EWebLauncher/ControlTheme/CMakeLists.txt:
* MiniBrowser/efl/CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/PlatformEfl.cmake:
* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/PlatformEfl.cmake:
* WinCELauncher/CMakeLists.txt:
* clang/ReportMemoryUsagePlugin/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove unused property names from V8HiddenPropertyName
haraken@chromium.org [Thu, 6 Dec 2012 02:58:22 +0000 (02:58 +0000)]
[V8] Remove unused property names from V8HiddenPropertyName
https://bugs.webkit.org/show_bug.cgi?id=104194

Reviewed by Adam Barth.

We can remove unused property names from V8HiddenPropertyName.

No tests. No change in behavior.

* bindings/v8/V8HiddenPropertyName.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
commit-queue@webkit.org [Thu, 6 Dec 2012 02:50:02 +0000 (02:50 +0000)]
Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-05
Reviewed by Noam Rosenthal.

Send SetRootCompositingLayer message to the UI process in the
constructor instead of sending it on the first flush.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::initializeRootCompositingLayer):
(WebKit):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Don't use the C API internally in ewk_cookie_manager
commit-queue@webkit.org [Thu, 6 Dec 2012 02:38:22 +0000 (02:38 +0000)]
[EFL][WK2] Don't use the C API internally in ewk_cookie_manager
https://bugs.webkit.org/show_bug.cgi?id=103243

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-05
Reviewed by Gyuyoung Kim.

Used the C++ classes directly instead of the C API wrappers
to avoid a lot of toImpl/toAPI casts.

* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::cookieManager):
* UIProcess/API/efl/ewk_cookie_manager.cpp:
(EwkCookieManager::EwkCookieManager):
(EwkCookieManager::~EwkCookieManager):
(EwkCookieManager::setPersistentStorage):
(EwkCookieManager::setHTTPAcceptPolicy):
(EwkCookieManager::clearHostnameCookies):
(EwkCookieManager::clearAllCookies):
(EwkCookieManager::watchChanges):
(EwkCookieManager::getHostNamesWithCookies):
(EwkCookieManager::getHTTPAcceptPolicy):
* UIProcess/API/efl/ewk_cookie_manager_private.h:
(EwkCookieManager::create):
(EwkCookieManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Gardening. Rebase fast/block/basic/020.html
commit-queue@webkit.org [Thu, 6 Dec 2012 02:36:22 +0000 (02:36 +0000)]
[WK2][EFL] Gardening. Rebase fast/block/basic/020.html
https://bugs.webkit.org/show_bug.cgi?id=104195

Unreviewed Gardening.

The layer for "visibility:hidden;position:absolute;" object should be in RenderTree when USE(ACCELERATED_COMPOSITING),
because the HiddenLayers are included in zOrderList when CompositingMode is on.

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-05

* platform/efl-wk2/fast/block/basic/020-expected.txt: Added.
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd runtime enable for web intents.
commit-queue@webkit.org [Thu, 6 Dec 2012 02:06:55 +0000 (02:06 +0000)]
Add runtime enable for web intents.
https://bugs.webkit.org/show_bug.cgi?id=103669

Patch by Greg Billock <gbillock@google.com> on 2012-12-05
Reviewed by Adam Barth.

Source/WebCore:

Make web intents Javascript API enabled by a runtime setting.

* Modules/intents/DOMWindowIntents.idl:
* Modules/intents/NavigatorIntents.idl:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitStartActivityEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::webKitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::setWebIntentsEnabled):

Source/WebKit/chromium:

Propagate runtime setting to enable/disable web intents Javascript API.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableWebIntents):
(WebKit):
(WebKit::WebRuntimeFeatures::isWebIntentsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove linux theme related files and switch to default
commit-queue@webkit.org [Thu, 6 Dec 2012 01:38:29 +0000 (01:38 +0000)]
[chromium] Remove linux theme related files and switch to default
https://bugs.webkit.org/show_bug.cgi?id=103897

Patch by Scott Violet <sky@chromium.org> on 2012-12-05
Reviewed by Tony Chang.

Source/Platform:

* Platform.gypi: Remove WebThemeEngine.h
* chromium/public/linux/WebThemeEngine.h: Removed.

Source/WebCore:

Linux related theme files are now named Default.

No new tests, code cleanup.

* WebCore.gyp/WebCore.gyp: Update files
* WebCore.gypi: Update files
* platform/chromium/PlatformThemeChromiumLinux.cpp: Removed.
* platform/chromium/PlatformThemeChromiumLinux.h: Removed.
* platform/chromium/ScrollbarThemeChromiumLinux.cpp: Removed.
* platform/chromium/ScrollbarThemeChromiumLinux.h: Removed.
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet): Linux->Default
* rendering/RenderThemeChromiumAndroid.h: Change superclass
* rendering/RenderThemeChromiumLinux.cpp: Removed.
* rendering/RenderThemeChromiumLinux.h: Removed.

Source/WebKit/chromium:

Linux theme related files are now named Default.

* WebKit.gyp:
* public/linux/WebRenderTheme.h: Removed.
* public/platform/linux/WebThemeEngine.h: Removed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setScrollbarColors): Cleanup ifdefs.
(WebKit::WebViewImpl::setSelectionColors): Cleanup ifdefs.
* src/linux/WebRenderTheme.cpp: Removed.

Tools:

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): linux->default

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the strip line numbers link into a checkbox
ojan@chromium.org [Thu, 6 Dec 2012 01:35:36 +0000 (01:35 +0000)]
Make the strip line numbers link into a checkbox
https://bugs.webkit.org/show_bug.cgi?id=104187

Reviewed by Tony Chang.

The link text was confusing.

* PrettyPatch/PrettyPatch.rb:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Allow multiple transactions to interleave request execution
jsbell@chromium.org [Thu, 6 Dec 2012 01:30:35 +0000 (01:30 +0000)]
IndexedDB: Allow multiple transactions to interleave request execution
https://bugs.webkit.org/show_bug.cgi?id=97570

Reviewed by Tony Chang.

Source/WebCore:

Implement spec logic for allowing read-only transactions, and read-write transactions
with non-overlapping scopes, to run concurrently. Transactions all still run in the
same thread with tasks triggered via timers, so tasks and the underlying database
operations are interleaved rather than truly parallelized.

Within IDBTransactionCoordinator, rename started->queued, running->started to match
spec terminology and clear up confusion.

Test: storage/indexeddb/transaction-coordination-across-databases.html
      storage/indexeddb/transaction-coordination-within-database.html
      storage/indexeddb/transaction-readwrite-exclusive.html
      storage/indexeddb/transaction-scope-sequencing.html
      storage/indexeddb/transaction-starvation.html

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Use IDBTransaction::Mode enum
(WebCore::IDBDatabaseBackendImpl::createTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h: Ditto.
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h: Ditto.
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp: Convert scope as a HashSet for
fast intersecting.
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):
(WebCore::IDBTransactionBackendImpl::scope):
* Modules/indexeddb/IDBTransactionCoordinator.cpp: Spec logic goes here.
(WebCore::IDBTransactionCoordinator::processStartedTransactions): Extend this
method to test all plausibly runnable transactions.
(WebCore):
(WebCore::IDBTransactionCoordinator::canRunTransaction): Test to see if one
particular transaction can be run.
(WebCore::IDBTransactionCoordinator::doScopesOverlap): Do a quick intersection
test between transaction scopes.
* Modules/indexeddb/IDBTransactionCoordinator.h:
(IDBTransactionCoordinator):

Source/WebKit/chromium:

Map to IDBTransaction::Mode enum as appropriate.

* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createTransaction):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createTransaction):
 * tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

New tests for parallel transactions, update existing tests that relied on sequential execution.

* storage/indexeddb/database-close-expected.txt:
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/resources/clear.js: Split up transaction steps.
* storage/indexeddb/resources/database-close.js: Don't log on individual transaction completion.
* storage/indexeddb/resources/transaction-coordination-within-database.js: Added.
* storage/indexeddb/resources/transaction-scope-sequencing.js: Added.
* storage/indexeddb/resources/transaction-starvation.js: Added.
* storage/indexeddb/transaction-coordination-within-database-expected.txt: Added.
* storage/indexeddb/transaction-coordination-within-database.html: Added.
* storage/indexeddb/transaction-scope-sequencing-expected.txt: Added.
* storage/indexeddb/transaction-scope-sequencing.html: Added.
* storage/indexeddb/transaction-starvation-expected.txt: Added.
* storage/indexeddb/transaction-starvation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Enable support for setContentsToBackgroundColor
commit-queue@webkit.org [Thu, 6 Dec 2012 01:23:48 +0000 (01:23 +0000)]
Coordinated Graphics: Enable support for setContentsToBackgroundColor
https://bugs.webkit.org/show_bug.cgi?id=104128

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Enable background color in GraphicsLayerTextureMapper, and paint it using TextureMapper::drawSolidColor.
Once https://bugs.webkit.org/show_bug.cgi?id=103786 is enabled, this would enable Qt/GTK/EFL to directly
composite colors that only have a background color, without having to create a backing store for them.
This would eliminate the memory usage for those layers, reduce the time needed for them to draw into the
backing store and upload the texture, and in the future allow direct compositing of things other than
background colors.

Compositing tests cover this, but are still skipped for ports using coordinated graphics.
See https://bugs.webkit.org/show_bug.cgi?id=104129.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsToBackgroundColor):
(WebCore::GraphicsLayerTextureMapper::backgroundColor):
    Maintain a backgroundColor member variable in GraphicsLayerTextureMapper

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawSolidColor):
    TextureMapperGL::drawSolidColor should allow blending when the solid color has alpha.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):
* platform/graphics/texmap/TextureMapperLayer.h:
(State):

Source/WebKit2:

Enable setContentsToBackgroundColor in CoordinatedGraphicsLayer, and pass it through to the UI process.

* Shared/WebLayerTreeInfo.h:
(WebLayerInfo):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setLayerState):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToBackgroundColor):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w...
dpranke@chromium.org [Thu, 6 Dec 2012 00:53:46 +0000 (00:53 +0000)]
nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
https://bugs.webkit.org/show_bug.cgi?id=78168

Reviewed by Ojan Vafai.

This patch adds a single ordered list to ResultSummary that contains
the results of every test run in order of result received, and
modifies the TestResults class to contain the list of references used
for each test as well as the pid of the driver; this allows us to stop
having to override the test drivers to record the tests, and makes the
integration tests that test rdering, retries, restarts, etc. black-box
tests.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._compare_output):
(SingleTestRunner._run_reftest):
(SingleTestRunner._compare_output_with_reference):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
(ResultSummary.add):
* Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.__init__):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput.__init__):
(Driver.run_test):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver):
(TestDriver.__init__):
(TestDriver.run_test):
(TestDriver.stop):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_tests_run):
(get_test_batches):
(get_test_results):
(MainTest.test_batch_size):
(MainTest.test_dryrun):
(MainTest.test_natural_order):
(MainTest.test_natural_order_test_specified_multiple_times):
(MainTest.test_random_order):
(MainTest.test_random_order_test_specified_multiple_times):
(MainTest.test_no_order):
(MainTest.test_no_order_test_specified_multiple_times):
(MainTest.test_no_order_with_directory_entries_in_natural_order):
(MainTest.test_repeat_each):
(MainTest.test_ignore_flag):
(MainTest.test_skipped_flag):
(MainTest.test_iterations):
(MainTest.test_run_chunk):
(MainTest.test_run_part):
(MainTest.test_run_singly):
(MainTest.test_skip_failing_tests):
(MainTest.test_single_file):
(MainTest.test_single_file_with_prefix):
(MainTest.test_single_skipped_file):
(MainTest.test_test_list):
(MainTest.test_test_list_with_prefix):
(MainTest.test_exit_after_n_failures):
(MainTest.test_exit_after_n_crashes):
(MainTest.test_run_order__inline):
(MainTest.test_reftest_run):
(MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
(MainTest.test_reftest_skip_reftests_if_no_ref_tests):
(MainTest.test_reftest_expected_html_should_be_ignored):
(MainTest.test_reftest_driver_should_run_expected_html):
(MainTest.test_reftest_driver_should_run_expected_mismatch_html):
(MainTest.test_no_http_tests):
(MainTest.test_platform_tests_are_found):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE...
danakj@chromium.org [Thu, 6 Dec 2012 00:40:25 +0000 (00:40 +0000)]
[chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
https://bugs.webkit.org/show_bug.cgi?id=103967

Reviewed by James Robinson.

Source/Platform:

When the USE_CC_OUTPUT_SURFACE flag is set:
- Make the WebCompositorOutputSurface class empty.
- Don't define the OutputSurfaceClient.
- Don't define the SoftwareOutputDevice.

WebCompositorSupport has methods to create a WebCompositorOutputSurface. They
will return NULL until the chromium side lands, and then they will be used
in place of the existing WebViewHost methods.

* chromium/public/WebCompositorOutputSurface.h:
(WebKit):
* chromium/public/WebCompositorOutputSurfaceClient.h:
(WebKit):
* chromium/public/WebCompositorSoftwareOutputDevice.h:
(WebKit):
* chromium/public/WebCompositorSupport.h:
(WebKit):
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createOutputSurfaceFor3D):
(WebKit::WebCompositorSupport::createOutputSurfaceForSoftware):

Tools:

Use the WebCompositorSupport methods to create an OutputSurface. If they
fail, then fall back to the WebViewHost methods.

Once the chromium side lands, the WebCompositorSupport methods will stop
failing, and will replace the WebViewHost ones.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136481.
haraken@chromium.org [Thu, 6 Dec 2012 00:31:31 +0000 (00:31 +0000)]
Unreviewed, rolling out r136481.
http://trac.webkit.org/changeset/136481
https://bugs.webkit.org/show_bug.cgi?id=103868

it might have regressed dom_perf/CloneNodes (See bug 104177)

* dom/ContainerNodeAlgorithms.h:
(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/12809890> Should allow sandbox lookup of com.apple.tccd
ap@apple.com [Thu, 6 Dec 2012 00:22:45 +0000 (00:22 +0000)]
    <rdar://problem/12809890> Should allow sandbox lookup of com.apple.tccd

        Reviewed by Beth Dakin and Dan Bernstein.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Abort transactions because of leveldb errors part 3
dgrogan@chromium.org [Thu, 6 Dec 2012 00:08:55 +0000 (00:08 +0000)]
IndexedDB: Abort transactions because of leveldb errors part 3
https://bugs.webkit.org/show_bug.cgi?id=103960

Reviewed by Tony Chang.

Transactions are aborted when there are leveldb problems creating
indexes on an object store with existing data or when adding data to an
objectstore that has indexes.

* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix some repaint/paintCounter confusion, and reset it when getting layers out of...
simon.fraser@apple.com [Thu, 6 Dec 2012 00:07:02 +0000 (00:07 +0000)]
Fix some repaint/paintCounter confusion, and reset it when getting layers out of the layer pool
https://bugs.webkit.org/show_bug.cgi?id=104180

Reviewed by Tim Horton.

Layers retrieved from the LayerPool by TileCache need to have their
repaint counters reset, otherwise the scroll performance logging gets
confused.

Also, the counter counts paints, not repaints (invalidations), so
rename it accordingly.

* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea): Whitespace fix.
* platform/graphics/GraphicsLayer.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::createTileLayer):
(WebCore::TileCache::drawRepaintCounter):
* platform/graphics/ca/mac/WebTileLayer.h:
* platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer resetPaintCount]):
(-[WebTileLayer incrementPaintCount]):
(-[WebTileLayer paintCount]):
(-[WebTileLayer logFilledFreshTile]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEmpty parse cache when receiving a low memory warning
oliver@apple.com [Wed, 5 Dec 2012 23:43:06 +0000 (23:43 +0000)]
Empty parse cache when receiving a low memory warning
https://bugs.webkit.org/show_bug.cgi?id=104161

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This adds a function to the globaldata to empty all code related data
structures (code in the heap and the code cache).
It also adds a function to allow the CodeCache to actually be cleared
at all.

* runtime/CodeCache.h:
(CacheMap):
(JSC::CacheMap::clear):
(JSC::CodeCache::clear):
(CodeCache):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::discardAllCode):
(JSC):
* runtime/JSGlobalData.h:
(JSGlobalData):

Source/WebCore:

Use new discardAllCode() function on the global data, rather than
directly interacting with the heap.

* bindings/js/GCController.cpp:
(WebCore::GCController::discardAllCompiledCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSanitize content on copy in the code review tool
ojan@chromium.org [Wed, 5 Dec 2012 23:39:09 +0000 (23:39 +0000)]
Sanitize content on copy in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=104155

Reviewed by Tony Chang.

Always remove expand/header/annotate links. Provide an option
to remove line numbers as well. Store the option in localStorage so
people can always get whichever behavior they want.

A better solution would be to restructure the DOM, but that would require gutting
the whole code review tool and would make it difficult to include line numbers if
you wanted them.

* PrettyPatch/PrettyPatch.rb:
* code-review-test.html:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: split all of the buildbot-specific output into its own file
dpranke@chromium.org [Wed, 5 Dec 2012 23:28:42 +0000 (23:28 +0000)]
nrwt: split all of the buildbot-specific output into its own file
https://bugs.webkit.org/show_bug.cgi?id=104165

Reviewed by Ojan Vafai.

Now that we have the RunDetails object we can move all of the
buildbot-specific knowledge out of the core test-running code
and into the outermost run_webkit_tests layer.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(passing_run):
(logging_run):
(run_and_capture):
(MainTest.test_all):
(MainTest.test_max_locked_shards):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_full_results_html):
(MainTest.test_hung_thread):
(MainTest.test_keyboard_interrupt):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_with_stderr):
(MainTest.test_no_image_failure_with_image_diff):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):
(MainTest.test_retrying_and_flaky_tests):
(MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(MainTest.test_output_diffs):
(MainTest.test_unsupported_platform):
(MainTest.test_verbose_in_child_processes):
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
* Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
(BuildBotPrinter):
(BuildBotPrinter.__init__):
(BuildBotPrinter.print_results):
(BuildBotPrinter._print):
(BuildBotPrinter.print_result_summary):
(BuildBotPrinter._print_result_summary_entry):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
(BuildBotPrinter.print_unexpected_results.add_result):
* Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
(BuildBotPrinterTests):
(BuildBotPrinterTests.assertEmpty):
(BuildBotPrinterTests.assertNotEmpty):
(BuildBotPrinterTests.get_printer):
(BuildBotPrinterTests.get_result):
(BuildBotPrinterTests.get_result_summary):
(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer):
(Printer.__init__):
(Printer.print_results):
(Printer._print_statistics_for_test_timings):
(Printer._print_baseline):
(Printer._print_debug):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_printer):
(Testprinter.get_result):
(Testprinter.test_configure_and_cleanup):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_test_status_line):
(Testprinter.test_details):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Would like to queue messages while NetworkProcess is launching
ap@apple.com [Wed, 5 Dec 2012 23:28:31 +0000 (23:28 +0000)]
    [WK2] Would like to queue messages while NetworkProcess is launching
        https://bugs.webkit.org/show_bug.cgi?id=104143

        Reviewed by Anders Carlsson.

        Factored out process launching and message sending code to a ChildProcessProxy class.
        Process closing and crashing code should be moved once we better understand common
        requirements for the processes.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:
        Added ChildProcessProxy files.

        * Shared/ChildProcessProxy.cpp: Added.
        (WebKit::ChildProcessProxy::ChildProcessProxy):
        (WebKit::ChildProcessProxy::~ChildProcessProxy):
        (WebKit::ChildProcessProxy::fromConnection):
        (WebKit::ChildProcessProxy::connect):
        (WebKit::ChildProcessProxy::terminate):
        (WebKit::ChildProcessProxy::sendMessage):
        (WebKit::ChildProcessProxy::isLaunching):
        (WebKit::ChildProcessProxy::didFinishLaunching):
        (WebKit::ChildProcessProxy::clearConnection):
        * Shared/ChildProcessProxy.h: Added.
        (WebKit::ChildProcessProxy::connection):
        (WebKit::ChildProcessProxy::isValid):
        (WebKit::ChildProcessProxy::canSendMessage):
        (WebKit::ChildProcessProxy::processIdentifier):
        (WebKit::ChildProcessProxy::send):
        (WebKit::ChildProcessProxy::sendSync):
        Moved code from WebProcessProxy. Every ChildProcessProxy is a connection client,
        but every one is a connection queue client, so that latter is passed as an argument.

        * UIProcess/Network/NetworkProcessProxy.h:
        * UIProcess/Network/NetworkProcessProxy.cpp:
        Removed unused syncMessageSendTimedOut(), thank you OVERRIDE.

        * UIProcess/Network/NetworkProcessProxy.cpp:
        (WebKit::NetworkProcessProxy::NetworkProcessProxy):
        (WebKit::NetworkProcessProxy::getLaunchOptions):
        (WebKit::NetworkProcessProxy::~NetworkProcessProxy):
        (WebKit::NetworkProcessProxy::getNetworkProcessConnection):
        (WebKit::NetworkProcessProxy::didFinishLaunching):
        * UIProcess/Network/NetworkProcessProxy.h:
        * UIProcess/Network/mac/NetworkProcessProxyMac.mm:
        (WebKit::NetworkProcessProxy::setApplicationIsOccluded):
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::WebProcessProxy):
        (WebKit::WebProcessProxy::~WebProcessProxy):
        (WebKit::WebProcessProxy::getLaunchOptions):
        (WebKit::WebProcessProxy::disconnect):
        (WebKit::WebProcessProxy::didFinishLaunching):
        Use shared code.

        * UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::fromConnection):
        NetworkProcess inherits from conneciton client privately, so we need to do most
        of the work in ClientProcessProxy, and further upcast here.

        * UIProcess/efl/WebProcessProxyEfl.cpp:
        (WebKit::WebProcessProxy::platformGetLaunchOptions):
        * UIProcess/gtk/WebProcessProxyGtk.cpp:
        (WebKit::WebProcessProxy::platformGetLaunchOptions):
        * UIProcess/mac/WebProcessProxyMac.mm:
        (WebKit::WebProcessProxy::platformGetLaunchOptions):
        * UIProcess/qt/WebProcessProxyQt.cpp:
        (WebKit::WebProcessProxy::platformGetLaunchOptions):
        * UIProcess/win/WebProcessProxyWin.cpp:
        (WebKit::WebProcessProxy::platformGetLaunchOptions):
        Updated for renaming, platformConnect -> platformGetLaunchOptions().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: collect all of the information about a run into a new RunDetails class
dpranke@chromium.org [Wed, 5 Dec 2012 23:26:24 +0000 (23:26 +0000)]
nrwt: collect all of the information about a run into a new RunDetails class
https://bugs.webkit.org/show_bug.cgi?id=104158

Reviewed by Ojan Vafai.

This patch collects the information from both test passes (the
main one and the retries) as well as the summarized results and
the exit code into a RunDetails class, so that the integration
tests can more easily tell what happened.

Also, change the way the --lint-test-files works slightly so that
we don't need to create a printer object (and hence we need to
rework the tests that are testing logging).

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(RunDetails):
(RunDetails.__init__):
(Manager.run):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(passing_run):
(run_and_capture):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_files__errors):
(MainTest.test_verbose_in_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: remove --no-record-results
dpranke@chromium.org [Wed, 5 Dec 2012 23:25:07 +0000 (23:25 +0000)]
nrwt: remove --no-record-results
https://bugs.webkit.org/show_bug.cgi?id=104072

Reviewed by Ojan Vafai.

The command line flag was only being used in the unit tests and
wasn't really needed once we started using a mock filesystem.

Also, reformat a bunch of long lines ...

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(parse_args):
(passing_run):
(logging_run):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_with_stderr):
(MainTest.test_no_image_failure_with_image_diff):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_relative):
(MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(MainTest.test_additional_expectations):
(MainTest.test_output_diffs):
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: only summarize the results one way
dpranke@chromium.org [Wed, 5 Dec 2012 23:14:42 +0000 (23:14 +0000)]
nrwt: only summarize the results one way
https://bugs.webkit.org/show_bug.cgi?id=104064

Reviewed by Ojan Vafai.

Change manager.summarize_results so that we always (and only)
include both expected and unexpected results. Previously we
would summarize the results twice, once with expected results
and once without. This made the code much more confusing than
it needed to be.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
(Manager.run):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
(ResultSummaryTest.test_summarized_results_wontfix):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_results):
(Printer._print_unexpected_results):
(Printer._print_unexpected_results.add_result):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit2 child processes need to initialize timer coalescing policy on Mac.
commit-queue@webkit.org [Wed, 5 Dec 2012 23:14:14 +0000 (23:14 +0000)]
WebKit2 child processes need to initialize timer coalescing policy on Mac.
https://bugs.webkit.org/show_bug.cgi?id=103613

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-12-05
Reviewed by Mark Rowe.

Set timer coalescing policy of WebKit2 child processes to that of visible applications
until they can manage the policy based on UI process visibility.

* Shared/mac/ChildProcessMac.mm:
(WebKit::initializeTimerCoalescingPolicy): Set task_latency and task_throughput QOS tiers as appropriate
for visible applications.
(WebKit::ChildProcess::platformInitialize): Add call to initializeTimerCoalescingPolicy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText decorations are rotated when text-combine takes effect
mitz@apple.com [Wed, 5 Dec 2012 23:07:31 +0000 (23:07 +0000)]
Text decorations are rotated when text-combine takes effect
https://bugs.webkit.org/show_bug.cgi?id=104172

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/decorations-with-text-combine.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Applied a rotation to the graphics context when painting
the text decorations for combined text.

LayoutTests:

* fast/text/decorations-with-text-combine.html: Added.
* platform/chromium/TestExpectations: Added to tests missing platform-specific results.
* platform/mac/fast/text/decorations-with-text-combine-expected.png: Added.
* platform/mac/fast/text/decorations-with-text-combine-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Geolocation prompts won't respond to the correct geolocation object...
commit-queue@webkit.org [Wed, 5 Dec 2012 22:46:56 +0000 (22:46 +0000)]
[BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order
https://bugs.webkit.org/show_bug.cgi?id=104162

PR 257505
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-05
Reviewed by Yong Li.

GeolocationClientBlackBerry will register itself to GeolocationHandler when it has
a pending request. When browser responds with WebPageClientImpl::setAllowGeolocation,
we go through the list and let all the pending GeolocationListeners know that a certain
origin has been aceepted/denied.

* WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onPermission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove WebLayerTreeView API to set font atlas
commit-queue@webkit.org [Wed, 5 Dec 2012 22:38:48 +0000 (22:38 +0000)]
[chromium] Remove WebLayerTreeView API to set font atlas
https://bugs.webkit.org/show_bug.cgi?id=102960

Patch by Eberhard Graether <egraether@google.com> on 2012-12-05
Reviewed by James Robinson.

Removes old font atlas creation from WebViewImpl.

Source/Platform:

* chromium/public/WebLayerTreeView.h:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConnection::waitForMessage shouldn't use the message ID
andersca@apple.com [Wed, 5 Dec 2012 22:16:44 +0000 (22:16 +0000)]
Connection::waitForMessage shouldn't use the message ID
https://bugs.webkit.org/show_bug.cgi?id=104157

Reviewed by Andreas Kling.

Pass the message receiver name and message name to waitForMessage and use them for lookups instead of
the message ID.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::waitForAndDispatchImmediately):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Better crash fix for resetting tiles on a backingstore takeover.
jpetsovits@rim.com [Wed, 5 Dec 2012 22:12:55 +0000 (22:12 +0000)]
[BlackBerry] Better crash fix for resetting tiles on a backingstore takeover.
https://bugs.webkit.org/show_bug.cgi?id=103969
RIM PR 258415

Reviewed by Adam Treat.

The previous attempt for releasing tile buffers from the
previously active backingstore did not take into account
that resetTiles() would sometimes return early without
having swapped the tiles and thus reclaiming them.

This patch removes the early returns, because it's safe
to swap in an empty geometry at any time and we should
always take the chance when we get it.

Also put the code that calls resetTiles() on an owner
switch right into setCurrentBackingStoreOwner(), so that
it will also release the buffers when the BackingStore
is destroyed (the function is then called with 0).

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
* Api/BackingStore.h: Had to add the friend here to make the moved code work from the static function.
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics
commit-queue@webkit.org [Wed, 5 Dec 2012 21:57:23 +0000 (21:57 +0000)]
Coordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics
https://bugs.webkit.org/show_bug.cgi?id=103864

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-12-05
Reviewed by Noam Rosenthal.

AreaAllocator and UpdateAtlas are only used for Coordinated Graphics.
So, these should be moved to CoordinatedGraphics to clarify the code.

No new test, because no change of behavior.

* CMakeLists.txt:
* Target.pri:
* WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/AreaAllocator.cpp.
(WebKit):
(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):
* WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h: Renamed from Source/WebKit2/WebProcess/WebPage/AreaAllocator.h.
(WebCore::nextPowerOfTwo):
(WebCore):
(WebKit):
(AreaAllocator):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
(GeneralAreaAllocator):
(Node):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp.
(WebKit):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h: Renamed from Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h.
(WebCore):
(WebKit):
(UpdateAtlasClient):
(UpdateAtlas):
(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::flags):
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, add Mac baselines after r136409 (mathml sup/sub box changes).
tony@chromium.org [Wed, 5 Dec 2012 21:47:30 +0000 (21:47 +0000)]
Unreviewed, add Mac baselines after r136409 (mathml sup/sub box changes).

* platform/mac/TestExpectations:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtra space in fast/css/image-resolution/image-resolution.html
leoyang@rim.com [Wed, 5 Dec 2012 21:41:36 +0000 (21:41 +0000)]
Extra space in fast/css/image-resolution/image-resolution.html
https://bugs.webkit.org/show_bug.cgi?id=104130

Reviewed by Emil A Eklund.

String returned by cssText doesn't include an extra tailing space.
This patch is removing an expectation of the extra tailing space in the test.

* fast/css/image-resolution/image-resolution-expected.txt:
* fast/css/image-resolution/image-resolution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG profiler should display more information
fpizlo@apple.com [Wed, 5 Dec 2012 21:40:32 +0000 (21:40 +0000)]
DFG profiler should display more information
https://bugs.webkit.org/show_bug.cgi?id=104163

Reviewed by Gavin Barraclough.

Added the following:

- Distinguish between source counts and bytecode counts.

- Add a "full" summary view that shows both kinds of counts, plus inline counts.

- Add a "source" command to see the source.

- Add a "bytecode" command to see the bytecode and counts.

* Scripts/display-profiler-output:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[skia] Improve performance of GraphicsContext::createCompatibleBuffer by using SkDevi...
junov@google.com [Wed, 5 Dec 2012 21:40:26 +0000 (21:40 +0000)]
[skia] Improve performance of GraphicsContext::createCompatibleBuffer by using SkDevice:createCompatibleDevice
https://bugs.webkit.org/show_bug.cgi?id=103896

Reviewed by Stephen White.

Source/WebCore:

Refactored GraphicsContext::createCompatibleBuffer (platform common
code) to use platform-specific implementations provided by ImageBuffer.
There is no change in behavior for non-skia ports. The skia
implementation uses skia'a own createCompatibleDevice implementation,
which offers several performance benefits:
1. For accelerated contexts, the backing store may be allocated from
the scratch texture pool, which minimizes texture allocation and
deallocation overhead.
2. The backing store will not be initially cleared if it is known
in advance that fully opaque contents will be drawn into the buffer.
3. For non-accelerated contexts, if the backing store is flagged as
opaque, faster blitter loop implementations will be used for drawing
the buffer contents into other buffers. (e.g. generated opaque gradient
fills)

No new tests: covered by existing layout tests

* platform/graphics/Generator.h:
(Generator):
Added hasAlpha method so that it can be used by GeneratorGeneratedImage
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::drawPattern):
Passing m_generator->hasAlpha() to createCompatibleBuffer in order to
take advantage of optimizations that apply to opaque buffers.
* platform/graphics/Gradient.h:
(Gradient):
Made hasAlpha virtual so that it now overrides Generator::hasAlpha
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):
Refactored to use platform-specific implementation
* platform/graphics/GraphicsContext.h:
* platform/graphics/ImageBuffer.cpp:
(WebCore::createCompatibleBuffer):
Non-skia implementation. Mimics old
GraphicsContext::createCompatibleBuffer
* platform/graphics/ImageBuffer.h:
(ImageBuffer):
New skia-specific constructor
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::createCompatibleDevice):
(WebCore):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):

LayoutTests:

Added image failure expectation for test needing new baselines

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r136683): css3/calc/background-position-parsing.html failing on EFL Linux...
alexis@webkit.org [Wed, 5 Dec 2012 21:38:52 +0000 (21:38 +0000)]
REGRESSION (r136683): css3/calc/background-position-parsing.html failing on EFL Linux 64-bit Debug WK2
https://bugs.webkit.org/show_bug.cgi?id=104131

Reviewed by Antti Koivisto.

css3/calc/background-position-parsing.html assert in debug because we
call CSSParser::validUnit multiple times in a row. The problem was with
validUnit which check calc() values and save the result inside
m_parsedCalculation for later usage. validUnit expects you to
use m_parsedCalculation therefore calling validUnit again with
m_parsedCalculation being set asserts. As parseFillBackgroundPosition
just want to check wether the current value is maybe valid for
background-position we can just relax the check to allow either the
valid keywords or any other units (we will anyway filter the incorrect
values later in the parsing). The most important check at this point
for the shorthand is the validity of the keyword.

No new tests : the assert was covered by css3/calc/background-position-parsing.html.

* css/CSSParser.cpp:
(WebCore::CSSParser::isPotentialPositionValue):
(WebCore::CSSParser::parseFillBackgroundPosition):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Keep screen updates suspended until after a viewport resize.
jpetsovits@rim.com [Wed, 5 Dec 2012 21:37:34 +0000 (21:37 +0000)]
[BlackBerry] Keep screen updates suspended until after a viewport resize.
https://bugs.webkit.org/show_bug.cgi?id=104041

Reviewed by Adam Treat.

Now that screen and backing store updates can be suspended
and resumed separately from each other, prevent blits for
the whole duration of setViewportSize() and always issue
a blit at the end.

Makes WebPage::setViewportSize() more robust in threaded usage,
easier to read/understand, and gets rid of a couple of FIXMEs.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Wed, 5 Dec 2012 21:21:09 +0000 (21:21 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136735.
senorblanco@chromium.org [Wed, 5 Dec 2012 21:17:45 +0000 (21:17 +0000)]
Unreviewed, rolling out r136735.
http://trac.webkit.org/changeset/136735
https://bugs.webkit.org/show_bug.cgi?id=102699

Broke Chrome/Win build.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):
(WebCore::PlatformSupport::paintButton):
(WebCore::PlatformSupport::paintMenuList):
(WebCore::PlatformSupport::paintScrollbarArrow):
(WebCore::PlatformSupport::paintScrollbarThumb):
(WebCore::PlatformSupport::paintScrollbarTrack):
(WebCore::PlatformSupport::paintSpinButton):
(WebCore::PlatformSupport::paintTextField):
(WebCore::PlatformSupport::paintTrackbar):
(WebCore::PlatformSupport::paintProgressBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r136741.
senorblanco@chromium.org [Wed, 5 Dec 2012 21:16:43 +0000 (21:16 +0000)]
Unreviewed, rolling out r136741.
http://trac.webkit.org/changeset/136741
https://bugs.webkit.org/show_bug.cgi?id=104151

Broke Chrome/Win build.

* WebKit.gyp:
* src/PlatformSupport.cpp:
(WebCore):
(WebCore::WorkerContextProxy::create):
* src/WorkerContextProxy.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Scroll position shifts while FCC & selection handle are dragged
commit-queue@webkit.org [Wed, 5 Dec 2012 21:14:17 +0000 (21:14 +0000)]
[BlackBerry] Scroll position shifts while FCC & selection handle are dragged
https://bugs.webkit.org/show_bug.cgi?id=104156

Patch by Andrew Lo <anlo@rim.com> on 2012-12-05
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.

Only ensureFocusTextElementVisible on selectionChanged when
an element is being re-focused.
Internal PR256329

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::selectionChanged):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Build with libjpegturbo
yoli@rim.com [Wed, 5 Dec 2012 21:10:18 +0000 (21:10 +0000)]
[BlackBerry] Build with libjpegturbo
https://bugs.webkit.org/show_bug.cgi?id=104152

Reviewed by Rob Buis.

.:

RIM PR# 196975.
This change is made by Ming Xie to link with libjpegturbo.

* Source/cmake/OptionsBlackBerry.cmake:

Tools:

RIM PR# 196975.
Make sure the right include path for libjpeg is included.

* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebGL: use pointer to the source data for Image directly in texImage2D and texSubImag...
commit-queue@webkit.org [Wed, 5 Dec 2012 21:03:01 +0000 (21:03 +0000)]
WebGL: use pointer to the source data for Image directly in texImage2D and texSubImage2D to avoid memory copy if no conversion is needed
https://bugs.webkit.org/show_bug.cgi?id=103885

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2012-12-05
Reviewed by Kenneth Russell.

In texImage2D() and texSubImage2D(), there is a redundant memory copy from Image data to the intermediate vector when no conversion is needed. If the Image resource can be locked properly, it is better to use the pointer to the image source directly and hence avoid the memory copy and improve the performance.

Already covered by current tests.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
* platform/graphics/GraphicsContext3D.h:
(ImageExtractor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd infrastructure for :before and :after in DOM
commit-queue@webkit.org [Wed, 5 Dec 2012 21:00:54 +0000 (21:00 +0000)]
Add infrastructure for :before and :after in DOM
https://bugs.webkit.org/show_bug.cgi?id=103705

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-05
Reviewed by Eric Seidel.

Add all infrastructure for reimplementing generated content :before and
:after as DOM Elements. Now ElementRareData has two pointers to PseudoElements
for the generated content and Node has methods for traversing the tree
including generated content.

This will allow the generated content to be treated as real nodes instead
of anonymous and take part in the usual recalcStyle and attach flow which
fixes many bugs and vastly simplifies the ifecycle of generated content.

Instead of attempting to land both the infrastructure and enable it at
the same time which has proven problematic due to how drastic this change
is, this patch contains only the support code so a much smaller future
patch can be used to switch it on.

No new behavior, this is just the infrastructure.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::detach):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::createPseudoElementIfNeeded):
(WebCore::Element::beforePseudoElement):
(WebCore::Element::afterPseudoElement):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::~ElementRareData):
(WebCore::ElementRareData::setPseudoElement):
(WebCore::ElementRareData::pseudoElement):
(WebCore::ElementRareData::releasePseudoElement):
* dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::rendererIsEditable):
(WebCore::checkAcceptChild):
* dom/Node.h:
(Node):
(WebCore::Node::isPseudoElement):
(WebCore::Node::isBeforePseudoElement):
(WebCore::Node::isAfterPseudoElement):
(WebCore::Node::pseudoId):
(WebCore::Node::customPseudoId):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
* dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
* dom/PseudoElement.cpp: Added.
(WebCore::pseudoElementTagName):
(WebCore::PseudoElement::PseudoElement):
(WebCore::PseudoElement::customStyleForRenderer):
(WebCore::PseudoElement::attach):
(WebCore::PseudoElement::rendererIsNeeded):
(WebCore::PseudoElement::updateChildStyle):
(WebCore::PseudoElement::didRecalcStyle):
* dom/PseudoElement.h: Added.
(PseudoElement):
(WebCore::PseudoElement::create):
(WebCore::pseudoElementIsNeeded):
* editing/visible_units.cpp:
(WebCore::logicallyPreviousBox):
(WebCore::logicallyNextBox):
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::renderName):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::originalText):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::renderName):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::renderName):
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::renderName):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
(WebCore::RenderObject::setPseudoStyle):
(WebCore::RenderObject::createVisiblePosition):
* rendering/RenderObject.h:
(WebCore::RenderObject::isPseudoElement):
(RenderObject):
(WebCore::RenderObject::generatingNode):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::renderName):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::renderName):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::renderName):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createRenderer):
(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove stale check in check-for-webkit-framework-include-consistency
commit-queue@webkit.org [Wed, 5 Dec 2012 20:55:53 +0000 (20:55 +0000)]
Remove stale check in check-for-webkit-framework-include-consistency
https://bugs.webkit.org/show_bug.cgi?id=103775

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-12-05
Reviewed by David Kilzer.

The underlying issue was fixed in r81173.

* Scripts/check-for-webkit-framework-include-consistency:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse of uninitialized variable in WebCore::RenderBox::paintFillLayers
junov@google.com [Wed, 5 Dec 2012 20:53:24 +0000 (20:53 +0000)]
Use of uninitialized variable in WebCore::RenderBox::paintFillLayers
https://bugs.webkit.org/show_bug.cgi?id=104154

Reviewed by Stephen White.

Method FillLayer::clipOccludesNextLayers performs an internal
initialization when called on the first layer of a list of layers.
Without this initialization, calls to clipOccludesNextLayers on
subsequent layers will use uninitialized data.  In some cases, the
call to clipOccludesNextLayers was being short-circuited in
RenderBox::paintFillLayers.
Fix: Predicate was permuted to ensure that clipOccludesNextLayers
is never short-circuited.

Test: fast/backgrounds/size/contain-and-cover-zoomed.html
Running with valgrind reveals the error.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move WorkerContextProxy::create out of PlatformSupport
pilgrim@chromium.org [Wed, 5 Dec 2012 20:49:21 +0000 (20:49 +0000)]
[Chromium] Move WorkerContextProxy::create out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104151

Reviewed by Adam Barth.

Doesn't really solve the layering violation as much as kick it
down the road a bit. Part of a refactoring series; see tracking
bug 82948.

* WebKit.gyp:
* src/PlatformSupport.cpp:
(WebCore):
* src/WorkerContextProxy.cpp: Added.
(WebCore):
(WebCore::WebCore::WorkerContextProxy::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Re-enabling encrypted-media tests now that the issues are fixed.
commit-queue@webkit.org [Wed, 5 Dec 2012 20:47:34 +0000 (20:47 +0000)]
[Chromium] Re-enabling encrypted-media tests now that the issues are fixed.
https://bugs.webkit.org/show_bug.cgi?id=104137

Unreviewed revert of r136312.
The issues were fixed in Chromium r171039 & r171081.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-05

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEncapsulate ElementRareData for possible future sharing
commit-queue@webkit.org [Wed, 5 Dec 2012 20:43:40 +0000 (20:43 +0000)]
Encapsulate ElementRareData for possible future sharing
https://bugs.webkit.org/show_bug.cgi?id=103948

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-12-05
Reviewed by Eric Seidel.

Encapsulate ElementRareData and make all access go through getters and
setters. This is already true for NodeRareData, but ElementRareData
had many places where people directly access it.

This the first step in possible future sharing of ElementRareData
instances across nodes. All nodes in a shadow tree have rare data to
store the TreeScope, but in most cases all they have is the TreeScope!
Instead of making every node in a shadow subtree have rare data
and use lots of memory we could just share a single instance of rare data
and only allocate a unique one on modification. Encapsulation lets us
assert about mutations on shared instances.

* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::attributes):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):
(WebCore::Element::computedStyle):
(WebCore::Element::classList):
(WebCore::Element::optionalClassList):
(WebCore::Element::dataset):
(WebCore::Element::hasNamedNodeMap):
(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementRareData.h:
(WebCore::ElementRareData::needsFocusAppearanceUpdateSoonAfterAttach):
(WebCore::ElementRareData::setNeedsFocusAppearanceUpdateSoonAfterAttach):
(ElementRareData):
(WebCore::ElementRareData::styleAffectedByEmpty):
(WebCore::ElementRareData::setStyleAffectedByEmpty):
(WebCore::ElementRareData::isInCanvasSubtree):
(WebCore::ElementRareData::setIsInCanvasSubtree):
(WebCore::ElementRareData::containsFullScreenElement):
(WebCore::ElementRareData::setContainsFullScreenElement):
(WebCore::ElementRareData::isInTopLayer):
(WebCore::ElementRareData::setIsInTopLayer):
(WebCore::ElementRareData::childrenAffectedByHover):
(WebCore::ElementRareData::setChildrenAffectedByHover):
(WebCore::ElementRareData::childrenAffectedByActive):
(WebCore::ElementRareData::setChildrenAffectedByActive):
(WebCore::ElementRareData::childrenAffectedByDrag):
(WebCore::ElementRareData::setChildrenAffectedByDrag):
(WebCore::ElementRareData::childrenAffectedByFirstChildRules):
(WebCore::ElementRareData::setChildrenAffectedByFirstChildRules):
(WebCore::ElementRareData::childrenAffectedByLastChildRules):
(WebCore::ElementRareData::setChildrenAffectedByLastChildRules):
(WebCore::ElementRareData::childrenAffectedByDirectAdjacentRules):
(WebCore::ElementRareData::setChildrenAffectedByDirectAdjacentRules):
(WebCore::ElementRareData::childrenAffectedByForwardPositionalRules):
(WebCore::ElementRareData::setChildrenAffectedByForwardPositionalRules):
(WebCore::ElementRareData::childrenAffectedByBackwardPositionalRules):
(WebCore::ElementRareData::setChildrenAffectedByBackwardPositionalRules):
(WebCore::ElementRareData::childIndex):
(WebCore::ElementRareData::setChildIndex):
(WebCore::ElementRareData::shadow):
(WebCore::ElementRareData::setShadow):
(WebCore::ElementRareData::attributeMap):
(WebCore::ElementRareData::setAttributeMap):
(WebCore::ElementRareData::computedStyle):
(WebCore::ElementRareData::setComputedStyle):
(WebCore::ElementRareData::classList):
(WebCore::ElementRareData::setClassList):
(WebCore::ElementRareData::dataset):
(WebCore::ElementRareData::setDataset):
(WebCore::ElementRareData::minimumSizeForResizing):
(WebCore::ElementRareData::setMinimumSizeForResizing):
(WebCore::ElementRareData::savedLayerScrollOffset):
(WebCore::ElementRareData::setSavedLayerScrollOffset):
(WebCore::ElementRareData::resetComputedStyle):
* dom/NodeRareData.h:
(NodeRareData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources...
commit-queue@webkit.org [Wed, 5 Dec 2012 20:39:33 +0000 (20:39 +0000)]
http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php returns a malformed authentication header
https://bugs.webkit.org/show_bug.cgi?id=104052

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-05
Reviewed by Alexey Proskuryakov.

Add an authentication realm to the WWW-Authenticate header of the PHP script. Some networking
libraries do not cope well with WWW-Authenticate headers that do not include realms. Additionally
RFC2617 specifies that this part of the header is not-optional.

This test will be unskipped once the rest of the authentication support is complete in the
libsoup backend and GTK+ DRT/WTR.

* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Windows re-rebaseline.
roger_fong@apple.com [Wed, 5 Dec 2012 20:35:28 +0000 (20:35 +0000)]
Unreviewed Windows re-rebaseline.

* platform/win/fast/text/orientation-sideways-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium][Win] Remove theme-related functions from PlatformSupport
pilgrim@chromium.org [Wed, 5 Dec 2012 20:30:16 +0000 (20:30 +0000)]
[Chromium][Win] Remove theme-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=102699

Reviewed by Adam Barth.

Call theme engine directly instead of going through
PlatformSupport. Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::pluginScriptableObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136735 268f45cc-cd09-0410-ab3c-d52691b4dbfc