WebKit-https.git
13 years ago Update the minimum font size pref to match the actual default setting in...
hyatt [Mon, 19 Mar 2007 07:32:47 +0000 (07:32 +0000)]
    Update the minimum font size pref to match the actual default setting in Safari.  It should have been 1
        all this time and not 9.

        Reviewed by aroben

        * DumpRenderTree/DumpRenderTree.m:
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs [Mon, 19 Mar 2007 05:43:47 +0000 (05:43 +0000)]
JavaScriptCore:

        Reviewed by Mark.

        - avoid static construction (and global variable access) in a smarter, more portable way,
        to later enable MUTLI_THREAD mode to work on other platforms and compilers.

        * kjs/CommonIdentifiers.cpp: Added. New class to hold all the shared identifiers.
        (KJS::CommonIdentifiers::CommonIdentifiers):
        (KJS::CommonIdentifiers::shared):
        * kjs/CommonIdentifiers.h: Added.

        * kjs/ExecState.h:
        (KJS::ExecState::propertyNames): Hand the CommonIdentifiers instance here for easy access.
        (KJS::ExecState::ExecState):

        * API/JSObjectRef.cpp:
        (JSObjectMakeConstructor):
        * CMakeLists.txt:
        * JavaScriptCore.exp:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * bindings/runtime_array.cpp:
        (RuntimeArray::getOwnPropertySlot):
        (RuntimeArray::put):
        * bindings/runtime_method.cpp:
        (RuntimeMethod::getOwnPropertySlot):
        * kjs/array_object.cpp:
        (ArrayInstance::getOwnPropertySlot):
        (ArrayInstance::put):
        (ArrayInstance::deleteProperty):
        (ArrayProtoFunc::ArrayProtoFunc):
        (ArrayProtoFunc::callAsFunction):
        (ArrayObjectImp::ArrayObjectImp):
        * kjs/bool_object.cpp:
        (BooleanPrototype::BooleanPrototype):
        (BooleanProtoFunc::BooleanProtoFunc):
        (BooleanProtoFunc::callAsFunction):
        (BooleanObjectImp::BooleanObjectImp):
        * kjs/completion.h:
        (KJS::Completion::Completion):
        * kjs/date_object.cpp:
        (KJS::DateProtoFunc::DateProtoFunc):
        (KJS::DateObjectImp::DateObjectImp):
        (KJS::DateObjectFuncImp::DateObjectFuncImp):
        * kjs/error_object.cpp:
        (ErrorPrototype::ErrorPrototype):
        (ErrorProtoFunc::ErrorProtoFunc):
        (ErrorProtoFunc::callAsFunction):
        (ErrorObjectImp::ErrorObjectImp):
        (ErrorObjectImp::construct):
        (NativeErrorPrototype::NativeErrorPrototype):
        (NativeErrorImp::NativeErrorImp):
        (NativeErrorImp::construct):
        (NativeErrorImp::callAsFunction):
        * kjs/function.cpp:
        (KJS::FunctionImp::getOwnPropertySlot):
        (KJS::FunctionImp::put):
        (KJS::FunctionImp::deleteProperty):
        (KJS::FunctionImp::getParameterName):
        (KJS::DeclaredFunctionImp::construct):
        (KJS::IndexToNameMap::unMap):
        (KJS::Arguments::Arguments):
        (KJS::ActivationImp::getOwnPropertySlot):
        (KJS::ActivationImp::deleteProperty):
        (KJS::GlobalFuncImp::GlobalFuncImp):
        * kjs/function_object.cpp:
        (FunctionPrototype::FunctionPrototype):
        (FunctionProtoFunc::FunctionProtoFunc):
        (FunctionProtoFunc::callAsFunction):
        (FunctionObjectImp::FunctionObjectImp):
        (FunctionObjectImp::construct):
        * kjs/grammar.y:
        * kjs/identifier.cpp:
        * kjs/identifier.h:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::init):
        (KJS::Interpreter::initGlobalObject):
        * kjs/interpreter.h:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        (MathFuncImp::MathFuncImp):
        * kjs/nodes.cpp:
        (ArrayNode::evaluate):
        (FuncDeclNode::processFuncDecl):
        (FuncExprNode::evaluate):
        * kjs/number_object.cpp:
        (NumberPrototype::NumberPrototype):
        (NumberProtoFunc::NumberProtoFunc):
        (NumberObjectImp::NumberObjectImp):
        * kjs/object.cpp:
        (KJS::JSObject::put):
        (KJS::JSObject::defaultValue):
        (KJS::JSObject::hasInstance):
        * kjs/object.h:
        (KJS::JSObject::getOwnPropertySlot):
        * kjs/object_object.cpp:
        (ObjectPrototype::ObjectPrototype):
        (ObjectProtoFunc::ObjectProtoFunc):
        (ObjectObjectImp::ObjectObjectImp):
        * kjs/regexp_object.cpp:
        (RegExpPrototype::RegExpPrototype):
        (RegExpProtoFunc::RegExpProtoFunc):
        (RegExpObjectImp::RegExpObjectImp):
        * kjs/string_object.cpp:
        (KJS::StringInstance::getOwnPropertySlot):
        (KJS::StringInstance::put):
        (KJS::StringInstance::deleteProperty):
        (KJS::StringPrototype::StringPrototype):
        (KJS::StringProtoFunc::StringProtoFunc):
        (KJS::StringProtoFunc::callAsFunction):
        (KJS::StringObjectImp::StringObjectImp):
        (KJS::StringObjectFuncImp::StringObjectFuncImp):
        * kjs/testkjs.cpp:
        (TestFunctionImp::TestFunctionImp):

WebCore:

        Reviewed by Mark.

        - avoid static construction (and global variable access) in a smarter, more portable way,
        to later enable MUTLI_THREAD mode to work on other platforms and compilers.

        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::JSHTMLInputElementBaseFunction::JSHTMLInputElementBaseFunction):
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNamedNodeMap::getOwnPropertySlot):
        (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
        * bindings/js/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::HTMLElementFunction):
        (KJS::JSHTMLCollection::getOwnPropertySlot):
        * bindings/js/kjs_window.cpp:
        (KJS::ScheduledAction::execute):
        * bindings/objc/WebScriptObject.mm:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
andrew [Mon, 19 Mar 2007 05:05:33 +0000 (05:05 +0000)]
JavaScriptCore:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoland update results for frame pixel changes.
hyatt [Mon, 19 Mar 2007 04:57:20 +0000 (04:57 +0000)]
land update results for frame pixel changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated results for frames pixel tests.
hyatt [Mon, 19 Mar 2007 04:53:45 +0000 (04:53 +0000)]
Land updated results for frames pixel tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for frame borders case.
hyatt [Mon, 19 Mar 2007 04:53:04 +0000 (04:53 +0000)]
Add layout test for frame borders case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for REGRESSION bug 13108, frame borders being painted when they shouldn...
hyatt [Mon, 19 Mar 2007 04:50:45 +0000 (04:50 +0000)]
    Fix for REGRESSION bug 13108, frame borders being painted when they shouldn't be.  Rework both frame borders
        and resizing to be more like other browsers.

        Reviewed by ggaren

        fast/frames/no-frame-borders.html

        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::HTMLFrameElement):
        (WebCore::HTMLFrameElement::attach):
        (WebCore::HTMLFrameElement::parseMappedAttribute):
        * html/HTMLFrameElement.h:
        (WebCore::HTMLFrameElement::hasFrameBorder):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::attach):
        * html/HTMLFrameSetElement.h:
        (WebCore::HTMLFrameSetElement::hasFrameBorder):
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::HTMLIFrameElement):
        * rendering/RenderFrame.cpp:
        (WebCore::RenderFrame::edgeInfo):
        * rendering/RenderFrame.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        (WebCore::RenderFrameSet::GridAxis::resize):
        (WebCore::RenderFrameSet::fillFromEdgeInfo):
        (WebCore::RenderFrameSet::computeEdgeInfo):
        (WebCore::RenderFrameSet::edgeInfo):
        (WebCore::RenderFrameSet::layout):
        (WebCore::RenderFrameSet::startResizing):
        (WebCore::RenderFrameSet::continueResizing):
        (WebCore::RenderFrameSet::canResizeRow):
        (WebCore::RenderFrameSet::canResizeColumn):
        (WebCore::RenderFrameSet::splitPosition):
        (WebCore::RenderFrameSet::hitTestSplit):
        (WebCore::RenderFrameSet::dump):
        * rendering/RenderFrameSet.h:
        (WebCore::):
        (WebCore::FrameEdgeInfo::FrameEdgeInfo):
        (WebCore::FrameEdgeInfo::preventResize):
        (WebCore::FrameEdgeInfo::allowBorder):
        (WebCore::FrameEdgeInfo::setPreventResize):
        (WebCore::FrameEdgeInfo::setAllowBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-19 Mark Rowe <mrowe@apple.com>
bdash [Mon, 19 Mar 2007 04:32:24 +0000 (04:32 +0000)]
2007-03-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Brady.

        Update references to bugzilla.opendarwin.org with bugs.webkit.org.

        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        * kjs/grammar.y:
        * kjs/keywords.table:
        * kjs/lexer.cpp:
        (KJS::Lexer::shift):

2007-03-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Brady.

        Update references to bugzilla.opendarwin.org with bugs.webkit.org.

        * ChangeLog:
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * manual-tests/ATSU-bad-layout.html:
        * manual-tests/accidental-strict-mode.html:
        * manual-tests/applet-param-no-name.html:
        * manual-tests/bidi-parens.html:
        * manual-tests/bugzilla-3855.html:
        * manual-tests/bugzilla-4840.html:
        * manual-tests/bugzilla-6821.html:
        * manual-tests/containing-block-position-chage.html:
        * manual-tests/contenteditable-link.html:
        * manual-tests/css3-cursor-fallback-quirks.html:
        * manual-tests/css3-cursor-fallback-strict.html:
        * manual-tests/custom-cursors.html:
        * manual-tests/dictionary-scrolled-iframe.html:
        * manual-tests/dom-manipulation-on-resize.html:
        * manual-tests/drag-image-to-address-bar.html:
        * manual-tests/empty-link-target.html:
        * manual-tests/empty-title-popup.html:
        * manual-tests/first-line-style-crash.html:
        * manual-tests/invalid-mouse-event.html:
        * manual-tests/left-overflow-repaint.html:
        * manual-tests/linkjump-3.html:
        * manual-tests/log-keypress-events.html:
        * manual-tests/named-window-blank-target.html:
        * manual-tests/plain-text-paste.html:
        * manual-tests/plugin-controller-datasource.html:
        * manual-tests/pre-tab-selection-rect.html:
        * manual-tests/redirection-target.html:
        * manual-tests/redraw-page-cache-visited-links.html:
        * manual-tests/reset-initiatedDrag.html:
        * manual-tests/resources/named-window-blank-target-step2.html:
        * manual-tests/resources/named-window-blank-target-step3.html:
        * manual-tests/resources/named-window-blank-target-step4.html:
        * manual-tests/resources/redraw-page-cache-visited-links-2.html:
        * manual-tests/scrollbar-hittest.html:
        * manual-tests/scrollbar-hittest2.html:
        * manual-tests/subview-click-assertion.html:
        * manual-tests/tabbing-input-google.html:
        * manual-tests/text-field-autoscroll.html:
        * manual-tests/textarea-after-stylesheet-link.html:
        * manual-tests/textarea-focus.html:
        * manual-tests/whitespace-pre-affinity.html:

2007-03-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Brady.

        Update references to bugzilla.opendarwin.org with bugs.webkit.org.

        * WebInspector/webInspector/inspector.css:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView firstRectForCharacterRange:]):
        * WebView/WebView.mm:
        (-[WebView initWithFrame:frameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added a random JS benchmark.
mjs [Mon, 19 Mar 2007 02:34:01 +0000 (02:34 +0000)]
    Added a random JS benchmark.

        * misc/morph.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRoll out r20297, fix for http://bugs.webkit.org/show_bug.cgi?id=13091, as it causes...
bdash [Mon, 19 Mar 2007 01:50:14 +0000 (01:50 +0000)]
Roll out r20297, fix for bugs.webkit.org/show_bug.cgi?id=13091, as it causes regressions in layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark.
weinig [Mon, 19 Mar 2007 01:40:18 +0000 (01:40 +0000)]
    Reviewed by Mark.

        Update results after Hyatt's patch in r20268.

        * tables/mozilla/bugs/bug137388-2-expected.checksum:
        * tables/mozilla/bugs/bug137388-2-expected.png:
        * tables/mozilla/bugs/bug137388-2-expected.txt:
        * tables/mozilla/bugs/bug137388-3-expected.checksum:
        * tables/mozilla/bugs/bug137388-3-expected.png:
        * tables/mozilla/bugs/bug137388-3-expected.txt:
        * tables/mozilla/bugs/bug50695-2-expected.checksum:
        * tables/mozilla/bugs/bug50695-2-expected.png:
        * tables/mozilla/bugs/bug50695-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed - gdk build fix.
kjk [Mon, 19 Mar 2007 00:39:49 +0000 (00:39 +0000)]
    Not reviewed - gdk build fix.

        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::update): add a stub

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt
beidson [Mon, 19 Mar 2007 00:37:19 +0000 (00:37 +0000)]
    Reviewed by Hyatt

        http://bugs.webkit.org/show_bug.cgi?id=13111
        When stopped a load before it completes, partial images become the
        broken image icon

        * loader/loader.cpp:
        (WebCore::Loader::didFail): Split off into a method that knows the
          difference between failed and cancelled.  If a load is cancelled,
          don't call error() on the object - only remove it from the cache
        (WebCore::Loader::cancelRequests): Call didFail(loader, true)
        * loader/loader.h: Added didFail(SubresourceLoader*, bool cancelled)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-18 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 18 Mar 2007 23:42:39 +0000 (23:42 +0000)]
2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13101
          REGRESSION (NativeTextField): Specifying word-wrap:break-word makes text field wrap

        Test: fast/forms/input-text-word-wrap.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerTextStyle): Force the inner block to
        'word-wrap:normal'.

2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13101
          REGRESSION (NativeTextField): Specifying word-wrap:break-word makes text field wrap

        * fast/forms/input-text-word-wrap-expected.checksum: Added.
        * fast/forms/input-text-word-wrap-expected.png: Added.
        * fast/forms/input-text-word-wrap-expected.txt: Added.
        * fast/forms/input-text-word-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-18 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 18 Mar 2007 23:40:26 +0000 (23:40 +0000)]
2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim Hatcher.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13091
          REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

        Test: fast/innerHTML/additional-inline-style.html

        * editing/markup.cpp:
        (WebCore::startMarkup): Changed to add inline style based on CSS rules only
        in AnnotateForInterchange mode.

2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim Hatcher.

        - test and updated result for http://bugs.webkit.org/show_bug.cgi?id=13091
          REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

        * editing/pasteboard/paste-table-002-expected.txt:
        * fast/innerHTML/additional-inline-style-expected.txt: Added.
        * fast/innerHTML/additional-inline-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-18 Dan Waylonis <waylonis@mac.com>
bdash [Sun, 18 Mar 2007 23:25:01 +0000 (23:25 +0000)]
2007-03-18  Dan Waylonis  <waylonis@mac.com>

        Reviewed by Tim Hatcher.

        Fix http://bugs.webkit.org/show_bug.cgi?id=13005
        Bug 13005: WebScriptObject +throwException needs NULL check.

        Add checking for NULL interpreter before throwing exception.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):

2007-03-18  Dan Waylonis  <waylonis@mac.com>

        Reviewed by Tim Hatcher.

        DumpRenderTree changes for http://bugs.webkit.org/show_bug.cgi?id=13005
        Bug 13005: WebScriptObject +throwException needs NULL check.

        Add tests to ensure that a plugin can safely throw an exception in dealloc.

        * DumpRenderTree/ObjCPlugin.h:
        * DumpRenderTree/ObjCPlugin.m:
        (+[ObjCPlugin webScriptNameForKey:]):
        (+[ObjCPlugin isKeyExcludedFromWebScript:]):
        (-[ObjCPlugin dealloc]):

2007-03-18  Dan Waylonis  <waylonis@mac.com>

        Reviewed by Tim Hatcher.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=13005
        Bug 13005: WebScriptObject +throwException needs NULL check.

        A plugin that throws on dealloc can crash WebKit.

        * plugins/throw-on-dealloc-expected.txt: Added.
        * plugins/throw-on-dealloc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren [Sun, 18 Mar 2007 23:02:39 +0000 (23:02 +0000)]
JavaScriptCore:

        Reviewed by Oliver Hunt.

        Exposed some extra toUInt32 functionality, as part of the fix for
        REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
        (Style Change Through JavaScript Blanks Content)

        * JavaScriptCore.exp:
        * kjs/identifier.h:
        (KJS::Identifier::toUInt32):

LayoutTests:

        Reviewed by Oliver Hunt.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=13106
        REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
        (Style Change Through JavaScript Blanks Content)

        * fast/dom/collection-null-like-arguments-expected.txt: Added.
        * fast/dom/collection-null-like-arguments.html: Added.

WebCore:

        Reviewed by Oliver Hunt.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=13106
        REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
        (Style Change Through JavaScript Blanks Content)

        When indexing into collections, treat the empty string as an invalid argument,
        instead of the number 0.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLCollection::getOwnPropertySlot):
        (KJS::JSHTMLCollection::callAsFunction):
        (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Removed duplicate export name.
ggaren [Sun, 18 Mar 2007 18:10:40 +0000 (18:10 +0000)]
    Removed duplicate export name.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej Stachowiak.
ggaren [Sun, 18 Mar 2007 18:07:21 +0000 (18:07 +0000)]
    Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/5064964> Repro ASSERT failure in JS Bindings when
        closing window @ lowtrades.bptrade.com

        Unfortunately, the bindings depend on UString and Identifier as string
        representations. So, they need to acquire the JSLock when doing something
        that will ref/deref their strings.

        Layout tests, the original site, and Java, Flash, and Quicktime on the
        web work. No leaks reported. No automated test for this because testing
        the Java bindings, like math, is hard.

        * bindings/runtime.h: Made Noncopyable, just to be sure.

        * bindings/c/c_class.cpp:
        (KJS::Bindings::CClass::~CClass): Acquire the JSLock and explicitly clear the keys
        in our hashtable, since they're UString::Reps, and ref/deref aren't thread-safe.
        (KJS::Bindings::CClass::methodsNamed): Also acquire the JSLock when adding
        keys to the table, since the table ref's them.
        (KJS::Bindings::CClass::fieldNamed): ditto.

        * bindings/c/c_utility.cpp: Removed dead function.
        (KJS::Bindings::convertValueToNPVariant): Acquire the JSLock because doing
        it recursively is pretty cheap, and it's just too confusing to tell whether
        all our callers do it for us.
        (KJS::Bindings::convertNPVariantToValue): ditto
        * bindings/c/c_utility.h:

        * bindings/jni/jni_class.cpp: Same deal as c_class.cpp.
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):

        * bindings/jni/jni_instance.cpp: Same deal as c_utility.cpp.
        (JavaInstance::stringValue):
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::convertValueToJObject):

        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::~JavaMethod): Moved from header, for clarity.
        (appendClassName): Made this static, so the set of callers is known, and
        we can assert that we hold the JSLock. Also changed it to take a UString
        reference, which makes the calling code simpler.
        (JavaMethod::signature): Store the ASCII value we care about instead of
        a UString, since UString is so much more hassle. Hold the JSLock while
        building up the temporary UString.

        * bindings/jni/jni_runtime.h: Nixed dead code in JavaMethod.
        (KJS::Bindings::JavaString::JavaString): Hold a UString::Rep instead of
        a UString, so we can acquire the JSLock and explicitly release it.
        (KJS::Bindings::JavaString::_commonInit):
        (KJS::Bindings::JavaString::~JavaString):
        (KJS::Bindings::JavaString::UTF8String):
        (KJS::Bindings::JavaString::uchars):
        (KJS::Bindings::JavaString::length):
        (KJS::Bindings::JavaString::ustring):

        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::convertArrayInstanceToJavaArray): Made this static, so
        the set of callers is known, and we can assert that we hold the JSLock.
        (KJS::Bindings::convertValueToJValue): Acquire the JSLock because doing
        it recursively is pretty cheap, and it's just too confusing to tell whether
        all our callers do it for us.

        * bindings/objc/objc_runtime.h: Nixed some dead code.
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertNSStringToString): Same drill as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap [Sun, 18 Mar 2007 17:39:21 +0000 (17:39 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=13105
        REGRESSION: an exception raised when calculating base value of a dot expression is not returned

        Test: fast/js/dot-node-base-exception.html

        * kjs/nodes.cpp:
        (FunctionCallDotNode::evaluate): Added the necessary KJS_CHECKEXCEPTIONVALUE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-18 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 18 Mar 2007 17:36:21 +0000 (17:36 +0000)]
2007-03-18  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Use fillRect instead of drawLine, since drawLine has some odd behavior (it...
hyatt [Sun, 18 Mar 2007 11:34:02 +0000 (11:34 +0000)]
    Use fillRect instead of drawLine, since drawLine has some odd behavior (it's only used for borders).

        Reviewed by aroben

        * platform/graphics/IntRect.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paintColumnBorder):
        (WebCore::RenderFrameSet::paintRowBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change the frameborder color to be light gray for framesets.
hyatt [Sun, 18 Mar 2007 11:11:34 +0000 (11:11 +0000)]
    Change the frameborder color to be light gray for framesets.

        Reviewed by aroben

        * rendering/RenderFrameSet.cpp:
        (WebCore::borderFillColor):
        (WebCore::RenderFrameSet::paintColumnBorder):
        (WebCore::RenderFrameSet::paintRowBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make iframes work properly with frameborder="0".
hyatt [Sun, 18 Mar 2007 10:53:59 +0000 (10:53 +0000)]
    Make iframes work properly with frameborder="0".

        Reviewed by aroben

        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::mapToEntry):
        (WebCore::HTMLIFrameElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd new iframe layout test.
hyatt [Sun, 18 Mar 2007 10:52:51 +0000 (10:52 +0000)]
Add new iframe layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 10:00:20 +0000 (10:00 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:58:34 +0000 (09:58 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:57:55 +0000 (09:57 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:57:22 +0000 (09:57 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:56:50 +0000 (09:56 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:56:17 +0000 (09:56 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:55:39 +0000 (09:55 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:54:56 +0000 (09:54 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:54:02 +0000 (09:54 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:52:58 +0000 (09:52 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:51:30 +0000 (09:51 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:50:00 +0000 (09:50 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:48:16 +0000 (09:48 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand corrected XHTML DOM test results for frames changes.
hyatt [Sun, 18 Mar 2007 09:47:13 +0000 (09:47 +0000)]
Land corrected XHTML DOM test results  for frames changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReset frames results.
hyatt [Sun, 18 Mar 2007 09:35:37 +0000 (09:35 +0000)]
Reset frames results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add a 2px border by default to <iframe>s for compatibility with other browsers.
hyatt [Sun, 18 Mar 2007 09:33:37 +0000 (09:33 +0000)]
    Add a 2px border by default to <iframe>s for compatibility with other browsers.

        Reviewed by aroben

        * css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt [Sun, 18 Mar 2007 09:21:21 +0000 (09:21 +0000)]
WebCore:

        Move frame borders out of WebKit and into WebCore.

        Reviewed by aroben, olliej

        * bridge/mac/FrameViewMac.mm:
        * css/html4.css:
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
        (WebCore::HTMLFrameSetElement::mapToEntry):
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        (WebCore::HTMLFrameSetElement::attach):
        * html/HTMLFrameSetElement.h:
        (WebCore::HTMLFrameSetElement::hasBorderColor):
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        * page/FrameView.h:
        * page/mac/WebCoreFrameBridge.h:
        * platform/graphics/IntRect.h:
        (WebCore::IntRect::topLeft):
        (WebCore::IntRect::topRight):
        (WebCore::IntRect::bottomLeft):
        (WebCore::IntRect::bottomRight):
        * rendering/RenderFrame.cpp:
        (WebCore::RenderFrame::viewCleared):
        * rendering/RenderFrameSet.cpp:
        (WebCore::borderStartEdgeColor):
        (WebCore::borderEndEdgeColor):
        (WebCore::RenderFrameSet::paintColumnBorder):
        (WebCore::RenderFrameSet::paintRowBorder):
        (WebCore::RenderFrameSet::paint):
        * rendering/RenderFrameSet.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::viewCleared):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

WebKit:

        Move frame borders out of WebKit and into WebCore.

        Reviewed by aroben, olliej

        * WebCoreSupport/WebFrameBridge.mm:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFrameView.mm:
        (-[WebFrameView drawRect:]):
        (-[WebFrameView setFrameSize:]):
        * WebView/WebFrameViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make onload do an explicit paint when a top-level document is ready (to ensur...
hyatt [Sun, 18 Mar 2007 05:18:13 +0000 (05:18 +0000)]
    Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always
        happens before any timers set by the onload can fire).

        Reviewed by aroben

        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTweaks to prevent timers from starving user input or painting.
hyatt [Sun, 18 Mar 2007 00:54:44 +0000 (00:54 +0000)]
Tweaks to prevent timers from starving user input or painting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth Dakin.
ggaren [Sun, 18 Mar 2007 00:11:22 +0000 (00:11 +0000)]
    Reviewed by Beth Dakin.

        Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when
        closing View Source window

        I award myself 0 points, and may God have mercy on my soul.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::~KJSProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed - gdk build fix.
kjk [Sun, 18 Mar 2007 00:04:47 +0000 (00:04 +0000)]
    Not reviewed - gdk build fix.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (Pasteboard::writeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix tiny PLT regression. Don't examine the border/background data for Render...
hyatt [Sat, 17 Mar 2007 23:39:50 +0000 (23:39 +0000)]
    Fix tiny PLT regression.  Don't examine the border/background data for RenderImage when images change
        unless we actually have a border/background.

        Reviewed by Brady

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher
sullivan [Sat, 17 Mar 2007 17:21:04 +0000 (17:21 +0000)]
    Reviewed by Tim Hatcher

        Discovered while working on <rdar://problem/5070334> that many WebView calls will crash if called
        after -[WebView close] has executed because _private->page is deferenced after it's been set to 0.
        It might be silly/wrong to call these methods after -close, but obviously it shouldn't crash. Made
        each use of _private->page robust against nil-dereferencing.

        * WebView/WebView.mm:
        (-[WebView _loadBackForwardListFromOtherView:]):
        (-[WebView _updateWebCoreSettingsFromPreferences:]):
        (-[WebView _setDashboardBehavior:to:]):
        (-[WebView _dashboardBehavior:]):
        (-[WebView goBack]):
        (-[WebView goForward]):
        (-[WebView goToBackForwardItem:]):
        (-[WebView canGoBack]):
        (-[WebView canGoForward]):
        (-[WebView setTabKeyCyclesThroughElements:]):
        (-[WebView tabKeyCyclesThroughElements]):
        (-[WebView setEditable:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Sam Weinig.
zimmermann [Sat, 17 Mar 2007 15:38:43 +0000 (15:38 +0000)]
Reviewed by Sam Weinig.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken)
Added test: svg/custom/use-css-events.svg

In general this fixes the peepo.co.uk website.

Forgot to pass the actual StyleChange to the recalcStyle() function,
when calling it on the shadow tree root element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
thatcher [Sat, 17 Mar 2007 14:49:36 +0000 (14:49 +0000)]
JavaScriptCore:

        Reviewed by Mark Rowe.

        Made Version.xcconfig smarter when building for different configurations.
        Now uses the 522+ OpenSource version for Debug and Release, while using the
        full 522.4 version for Production builds. The system prefix is also computed
        based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

        * Configurations/JavaScriptCore.xcconfig:
        * Configurations/Version.xcconfig:

JavaScriptGlue:

        Reviewed by Mark Rowe.

        Made Version.xcconfig smarter when building for different configurations.
        Now uses the 522+ OpenSource version for Debug and Release, while using the
        full 522.4 version for Production builds. The system prefix is also computed
        based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

        * Configurations/JavaScriptGlue.xcconfig:
        * Configurations/Version.xcconfig:

WebCore:

        Reviewed by Mark Rowe.

        Made Version.xcconfig smarter when building for different configurations.
        Now uses the 522+ OpenSource version for Debug and Release, while using the
        full 522.4 version for Production builds. The system prefix is also computed
        based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

        * Configurations/Version.xcconfig:
        * Configurations/WebCore.xcconfig:

WebKit:

        Reviewed by Mark Rowe.

        Made Version.xcconfig smarter when building for different configurations.
        Now uses the 522+ OpenSource version for Debug and Release, while using the
        full 522.4 version for Production builds. The system prefix is also computed
        based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

        * Configurations/Version.xcconfig:
        * Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Sat, 17 Mar 2007 11:53:55 +0000 (11:53 +0000)]
LayoutTests:

        Reviewed by Adele.

        Test for http://bugs.webkit.org/show_bug.cgi?id=12595
        REGRESSION: Can't add item to cart at lnt.com (JS type error)
        <rdar://problem/4722863>

        Expanded version of Darin's test case.

        * fast/forms/old-names-expected.txt: Added.
        * fast/forms/old-names.html: Added.

WebCore:

        Reviewed by Adele.

        Fix http://bugs.webkit.org/show_bug.cgi?id=12595
        REGRESSION: Can't add item to cart at lnt.com (JS type error)
        <rdar://problem/4722863>

        Emulate Firefox behavior where form elements accessed by a name
        can be accessed with that name later even if the name changes or
        even if element is removed from the document.

        This is loosely based on Darin's earlier patch for the same problem but
        is much less expansive. It takes somewhat different approach to more closely
        mimic Firefox behavior. Includes expanded test case.

        * bindings/js/JSHTMLFormElementCustom.cpp:
        (WebCore::JSHTMLFormElement::canGetItemsForName):
            Use new the HTMLFormElement::getNamedElements() method
        (WebCore::JSHTMLFormElement::nameGetter):
            Use new the HTMLFormElement::getNamedElements() method
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement):
        (WebCore::HTMLFormElement::~HTMLFormElement):
        (WebCore::HTMLFormElement::elementForAlias):
        (WebCore::HTMLFormElement::addElementAlias):
            Maintain a map of known element aliases
        (WebCore::HTMLFormElement::getNamedElements):
            Get a list of elements matching the name, based both their
            current names and known aliases (earlier names).
            Keep the alias list in sync.
        * html/HTMLFormElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Sat, 17 Mar 2007 07:40:53 +0000 (07:40 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Updated test for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
        http://bugs.webkit.org/show_bug.cgi?id=12725

        * fast/forms/listbox-onchange-expected.txt:
        * fast/forms/listbox-onchange.html:

WebCore:

        Reviewed by Hyatt.

        Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
        http://bugs.webkit.org/show_bug.cgi?id=12725

        Test: updated fast/forms/listbox-onchange.html

        Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result
        in onChange being called.  m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time,
        they just have to be up-to-date before we execute an action that may trigger onChange.

        * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added.
          The HTMLSelectElement will only set an option's selected state with this method.  This ensures
          that notifyOptionSelected won't get called when the call originates from the select element.
        * html/HTMLOptionElement.h:

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState.
        (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here.  Scroll to the new selection.
         The scrolling call used to only be in notifyOptionSelected.  There's no reason we shouldn't scroll when the selection is set through
         the HTMLSelectElement.
        (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state.
        (WebCore::HTMLSelectElement::restoreState): Call setSelectedState.
        (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange.
        (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState.  Don't need to save selection here anymore,
         since it will get saved before we call onChange.
        (WebCore::HTMLSelectElement::reset): ditto.
        (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired
         on blur.
        (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange.
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):  Call saveLastSelection during mousedown (to prepare for an
         onchange during mouseup, or after autoscroll).
        (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState.

        (WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex().
        (WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection.
        (WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection.
        * html/HTMLSelectElement.h:
        * platform/PopupMenu.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-16 Oliver Hunt <oliver@apple.com>
oliver [Sat, 17 Mar 2007 04:59:07 +0000 (04:59 +0000)]
2007-03-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Hyatt.
WebCore:
        The old canSaveAsWebArchive call was necessary as stand alone
        images used to be rendered by ImageDocument.

        Fixes rdar://problem/5061252

        * dom/Clipboard.cpp:
        * dom/Clipboard.h:
        (WebCore::Clipboard::setDragHasStarted):
        * page/DragClient.h:
        (WebCore::DragClient::declareAndWriteDragImage):
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::declareAndWriteDragImage):
WebKit:
        * WebCoreSupport/WebDragClient.h:
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::declareAndWriteDragImage):
        * WebKit.xcodeproj/project.pbxproj:
LayoutTests:
        Updating layout test to allow stand alone image to be
        dragged into a content editable div

        * fast/events/standalone-image-drag-to-editable-expected.checksum:
        * fast/events/standalone-image-drag-to-editable-expected.png:
        * fast/events/standalone-image-drag-to-editable-expected.txt:
        * fast/events/standalone-image-drag-to-editable.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
andersca [Sat, 17 Mar 2007 01:01:09 +0000 (01:01 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4869095>
        default content type changed for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago64-bit build fix.
thatcher [Sat, 17 Mar 2007 00:43:30 +0000 (00:43 +0000)]
64-bit build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Braveheart
beidson [Sat, 17 Mar 2007 00:36:50 +0000 (00:36 +0000)]
    Reviewed by Braveheart

        Updated layouttest results because I added a window property

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubberstamped by Tim Hatcher
beidson [Fri, 16 Mar 2007 23:57:13 +0000 (23:57 +0000)]
    Rubberstamped by Tim Hatcher

        Update the hash table header for Window object properties

        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
beidson [Fri, 16 Mar 2007 23:49:58 +0000 (23:49 +0000)]
LayoutTests:

        Reviewed by Anders

        <rdar://problem/5061826> and
        http://bugs.webkit.org/show_bug.cgi?id=12863
        Implement window.stop()

        * http/tests/misc/window-dot-stop-expected.txt: Added.
        * http/tests/misc/window-dot-stop.html: Added.

WebCore:

        Reviewed by Anders

        <rdar://problem/5061826> and
        http://bugs.webkit.org/show_bug.cgi?id=12863
        Implement window.stop()

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction): Add case Window::Stop
        * bindings/js/kjs_window.h:
        (KJS::Window::): Add "Stop"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding ChangeLog markers.
thatcher [Fri, 16 Mar 2007 23:19:31 +0000 (23:19 +0000)]
Adding ChangeLog markers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofixed changelog order -- do you need a changelog entry for a changelog fix???
ggaren [Fri, 16 Mar 2007 22:39:27 +0000 (22:39 +0000)]
fixed changelog order -- do you need a changelog entry for a changelog fix???

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 13084, assertion failure in the Cache. Convert the client list
ggaren [Fri, 16 Mar 2007 22:37:00 +0000 (22:37 +0000)]
    Fix for 13084, assertion failure in the Cache.  Convert the client list
        to a HashCountedSet so that multiple refs and derefs are allowed.

        Fix RenderImage so that if it has the same image used as a background/border
        and as the foreground that it will repaint properly (can be tested using
        border-image and a foreground image).

        Optimize list marker so that it doesn't waste time in the base class method,
        since list markers don't support background or border images.

        Reviewed by andersca

        * ChangeLog:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::ref):
        * loader/CachedResource.h:
        * loader/CachedResourceClientWalker.cpp:
        (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
        * loader/CachedResourceClientWalker.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::imageChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 13084, assertion failure in the Cache. Convert the client list
hyatt [Fri, 16 Mar 2007 22:29:52 +0000 (22:29 +0000)]
    Fix for 13084, assertion failure in the Cache.  Convert the client list
        to a HashCountedSet so that multiple refs and derefs are allowed.

        Fix RenderImage so that if it has the same image used as a background/border
        and as the foreground that it will repaint properly (can be tested using
        border-image and a foreground image).

        Optimize list marker so that it doesn't waste time in the base class method,
        since list markers don't support background or border images.

        Reviewed by andersca

        * ChangeLog:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::ref):
        * loader/CachedResource.h:
        * loader/CachedResourceClientWalker.cpp:
        (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
        * loader/CachedResourceClientWalker.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::imageChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix the 64-bit build.
thatcher [Fri, 16 Mar 2007 22:26:09 +0000 (22:26 +0000)]
Attempt to fix the 64-bit build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders Carlsson.
ggaren [Fri, 16 Mar 2007 20:10:49 +0000 (20:10 +0000)]
    Reviewed by Anders Carlsson.

        Fixed <rdar://problem/5065399> REGRESSION: leaks in Frame::bindingRootObject
        seen on buildbot

        The problem was that we were initializing the same WebScriptObject twice.
        This caused it to leak its original set of ivars.

        I think some refactoring could prevent this situation from arising in the
        first place, but I'm just adding a check at the call site for now, to do
        the simplest thing.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject _setImp:originRootObject:rootObject:]): Added ASSERTs
        against multiple calls.

        * bindings/objc/WebScriptObjectPrivate.h: Renamed _initializeWithObjectImp
        to setImp because "init" vs "initialize" was a too subtle indication that
        one was a Cocoa initializer and one was not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago don't use #import in .cpp files.
lars [Fri, 16 Mar 2007 12:40:01 +0000 (12:40 +0000)]
    don't use #import in .cpp files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix the Qt build once again.
lars [Fri, 16 Mar 2007 12:36:22 +0000 (12:36 +0000)]
    Fix the Qt build once again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-15 Shrikant Gangoda <shrikant.gangoda@celunite.com>
bdash [Fri, 16 Mar 2007 06:52:20 +0000 (06:52 +0000)]
2007-03-15  Shrikant Gangoda  <shrikant.gangoda@celunite.com>

        Gdk build fix.

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::blockedError):
        * loader/gdk/FrameLoaderClientGdk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
bdakin [Fri, 16 Mar 2007 06:50:16 +0000 (06:50 +0000)]
    Reviewed by Geoff.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13088 REGRESSION
        (r19761-19779): Copy image no longer includes image address
        (rdar://5067927)

        writeURL() does not need an isImage parameter. Now that it accepts
        the types as a parameter, we can just declare the appropriate image
        types within writeImage and send them to writeURL(). Also,
        declaring the types twice is what broke this.

        * platform/Pasteboard.h:
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker.
adele [Fri, 16 Mar 2007 06:18:08 +0000 (06:18 +0000)]
    Reviewed by Kevin Decker.

        Fix for <rdar://problem/4926179> Text in menulist control should never update if menu is open

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
          Only setTextFromOption if the menu isn't visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver
beidson [Fri, 16 Mar 2007 05:25:44 +0000 (05:25 +0000)]
    Reviewed by Oliver

        A few platform specific tweaks

        * platform/cf/RetainPtr.h:
        (WebCore::RetainPtr::releaseRef): Fixed releaseRef to work with CF

        * platform/network/ResourceHandle.h: Added a "releaseRef" style call

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed.
mjs [Fri, 16 Mar 2007 05:25:01 +0000 (05:25 +0000)]
    Not reviewed.

        - build fix

        * wtf/TCSystemAlloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs [Fri, 16 Mar 2007 05:12:59 +0000 (05:12 +0000)]
JavaScriptCore:

        Reviewed by Geoff and Steve.

        - fix some portability issues with TCMalloc.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * kjs/config.h:
        * wtf/FastMalloc.cpp:
        (WTF::SizeClass):
        (WTF::InitSizeClasses):
        (WTF::TCMalloc_PageHeap::Split):
        (WTF::TCMalloc_PageHeap::RegisterSizeClass):
        (WTF::TCMalloc_Central_FreeList::length):
        (WTF::TCMalloc_ThreadCache::InitTSD):
        (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
        * wtf/TCSpinLock.h:
        * wtf/TCSystemAlloc.cpp:
        (TryVirtualAlloc):
        (TCMalloc_SystemAlloc):

WebCore:

        Reviewed by Geoff and Steve.

        * config.h: Remove unneeded hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Fri, 16 Mar 2007 04:22:25 +0000 (04:22 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/5062376>
        REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied

        * editing/execCommand/5062376-expected.checksum: Added.
        * editing/execCommand/5062376-expected.png: Added.
        * editing/execCommand/5062376-expected.txt: Added.
        * editing/execCommand/5062376.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/5062376>
        REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied

        Bring back the remove step in applyBlockStyle.  It's
        necessary because addBlockStyleIfNeeded assumes that
        the properties it adds aren't already on the block that
        it adds them to.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        Bring back the remove step (added a testcase).
        Don't do the add step if m_removeOnly is true (no testcase
        because there aren't any clients using removeOnly functionality
        to remove styles yet, only styled elemets).
        Moved the code for creating new blocks up one level
        to this function so that we can pass blocks to removeCSSStyle.
        When converting VisiblePositions to indices and vice versa,
        use the highest node in the shadow tree if we're in one as
        the scope (working on a testcase).
        (WebCore::ApplyStyleCommand::addBlockStyle): Moved code to
        applyBlockStyle.
        * editing/ApplyStyleCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
beidson [Fri, 16 Mar 2007 03:12:27 +0000 (03:12 +0000)]
LayoutTests:

        Reviewed by Adele

        <rdar://problem/4429701>
        Implements a port blocking black list that matches Firefox's

        The layout test attempts to load an image at an invalid domain name on each
        of the black listed ports.  Using dumpResourceLoadCallbacks(), DRT is able
        to see the error codes for each resource.  A successful test shows the blocked
        error for each image load except for the few that are standard or should
        succeed due to exemptions.

        * security/block-test-expected.txt: Added.
        * security/block-test.html: Added.

WebCore:

        Reviewed by Maciej

        <rdar://problem/4429701>
        Implements a port blocking black list that matches Firefox's

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::blockedError): Call through to the client for blockedError
        * loader/FrameLoader.h:

        * loader/FrameLoaderClient.h: Get the "port blocked" error for the current platform

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::wasBlocked): ResourceHandleClient method to pass on the didFail(error)
        (WebCore::ResourceLoader::blockedError): Following the pattern of "CancelledError()", get the
          error to fail with for the didFail() call
        * loader/ResourceLoader.h:

        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::blockedError): Added stub

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::create): If the port is blocked, create the handle but schedule it for
          deferred failure on a timer
        (WebCore::ResourceHandle::scheduleBlockedFailure): Do the timer scheduling
        (WebCore::ResourceHandle::fireBlockedFailure): Fire the timer here
        (WebCore::ResourceHandle::portAllowed): Implements checking of Mozilla's
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::wasBlocked): Virtual for clients to get the "blocked" message

WebKit:

        Reviewed by Maciej

        <rdar://problem/4429701>
        Implements a port blocking black list that matches Firefox's

        * English.lproj/Localizable.strings: Added localizable string for port blocked error code

        * Misc/WebKitErrors.h:
        * Misc/WebKitErrors.m:
        (registerErrors): Add new port blocked error code to WebKitErrorDomain

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::cancelledError): Fixed coding style
        (WebFrameLoaderClient::blockedError): Return a ResourceError with the new custom error code

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoYet another build fix.
thatcher [Fri, 16 Mar 2007 01:16:42 +0000 (01:16 +0000)]
Yet another build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFinally a real build fix.
thatcher [Fri, 16 Mar 2007 00:55:40 +0000 (00:55 +0000)]
Finally a real build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoYet another build fix. Sigh.
thatcher [Fri, 16 Mar 2007 00:37:22 +0000 (00:37 +0000)]
Yet another build fix. Sigh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother build fix attempt.
thatcher [Fri, 16 Mar 2007 00:25:44 +0000 (00:25 +0000)]
Another build fix attempt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix the build.
thatcher [Fri, 16 Mar 2007 00:15:52 +0000 (00:15 +0000)]
Attempt to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Fri, 16 Mar 2007 00:07:06 +0000 (00:07 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
bdakin [Fri, 16 Mar 2007 00:04:39 +0000 (00:04 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5065396> REGRESSION: leaks in
        RenderBlock::layoutInlineChildren seen on buildbot

        This leak appeared after http://trac.webkit.org/projects/webkit/
        changeset/20188. This change shifted line boxes around in
        removeChild(). But since removeChild() calls
        setNeedsLayoutAndMinMaxRecalc(), all of the line boxes will be
        removed once we actually lay out anyway. So this patch fixes the
        leak by deleting the line boxes instead of shifting them around.

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph): Call into
        updateLayout(). This fixes an assertion I got in editing/
        execCommand/4976800.html This is very similar to the line box fix I
        made recently (http://trac.webkit.org/projects/webkit/changeset/
        20177). We need to update layout before relying on VisiblePositions
        after removing a node.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::deleteLinesForBlock): New helper function
        since this functionality is needed in three places now.
        (WebCore::RenderBlock::makeChildrenNonInline): Call into new
        deleteLinesForBlock().
        (WebCore::RenderBlock::removeChild): Same.
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
thatcher [Thu, 15 Mar 2007 23:50:15 +0000 (23:50 +0000)]
JavaScriptCore:

        Reviewed by John.

        * Factored out most of our common build settings into .xcconfig files. Anything that was common in
          each build configuration was factored out into the shared .xcconfig file.
        * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
        * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
        * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).

        * Configurations/Base.xcconfig: Added.
        * Configurations/DebugRelease.xcconfig: Added.
        * Configurations/JavaScriptCore.xcconfig: Added.
        * Configurations/Version.xcconfig: Added.
        * Info.plist:
        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by John.

        * Factored out most of our common build settings into .xcconfig files. Anything that was common in
          each build configuration was factored out into the shared .xcconfig file.
        * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
        * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
        * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).

        * Configurations/Base.xcconfig: Added.
        * Configurations/DebugRelease.xcconfig: Added.
        * Configurations/JavaScriptGlue.xcconfig: Added.
        * Configurations/Version.xcconfig: Added.
        * Info.plist:
        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by John.

        * Factored out most of our common build settings into .xcconfig files. Anything that was common in
          each build configuration was factored out into the shared .xcconfig file.
        * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
        * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
        * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).

        * Configurations/Base.xcconfig: Added.
        * Configurations/DebugRelease.xcconfig: Added.
        * Configurations/Version.xcconfig: Added.
        * Configurations/WebCore.xcconfig: Added.
        * Info.plist:
        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by John.

        * Fixes: <rdar://problem/4927747> WebKit's Current Library Version number should match the Info.plist Version
        * Factored out most of our common build settings into .xcconfig files. Anything that was common in
          each build configuration was factored out into the shared .xcconfig file.
        * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
        * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
        * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
        * Make WebKit use the same warning flags as the other projects. This required two casts to be added to fix new warnings.

        * Configurations/Base.xcconfig: Added.
        * Configurations/DebugRelease.xcconfig: Added.
        * Configurations/Version.xcconfig: Added.
        * Configurations/WebKit.xcconfig: Added.
        * Info.plist:
        * Misc/WebKitVersionChecks.h:
        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
kdecker [Thu, 15 Mar 2007 21:28:55 +0000 (21:28 +0000)]
    Reviewed by Anders.

        Fixed: <rdar://problem/5001428> stationery background images do not display

        Change 19244 fixed the method -[WebResource _shouldIgnoreWhenUnarchiving], but also broke Mail stationery.

        The problem was that with archivedResourceForURL now fixed, the engine will try to decode the images.  These images wouldn't decode because
        Mail re-encodes and directly manipulates the image data in such a way that prevented WebKit from decoding the image.  Because Mail was giving
        us bad data, the images wouldn't render.  This was never an issue before because archivedResourceForURL (broken) always returned nil, thus the
        engine would never attempt to decode the resource, therefore the responsibility was delegated to Mail's protocol handler, which would do the
        right thing and load the image.

        Since Mail is relying on the fact it can store arbitrary data in WebArchives, I've introduced SPI that acts as a hint for us to ignore certain
        subresources while unarchiving. This SPI is -[WebResource _shouldIgnoreWhenUnarchiving].

        * WebView/WebResource.mm: Addd private ivar shouldIgnoreWhenUnarchiving.
        (-[WebResource _ignoreWhenUnarchiving]): Added.
        (-[WebResource _shouldIgnoreWhenUnarchiving]): Added.
        * WebView/WebResourcePrivate.h: Added two methods to private header.
        * WebView/WebUnarchivingState.m:
        (-[WebUnarchivingState archivedResourceForURL:]): Check if we should ignore the resource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed - gdk build fixes.
kjk [Thu, 15 Mar 2007 20:20:06 +0000 (20:20 +0000)]
    Not reviewed - gdk build fixes.

        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::handleKeypress):
        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::setData):
        * platform/graphics/gdk/ImageGdk.cpp:
        (WebCore::Image::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 15 Mar 2007 19:12:32 +0000 (19:12 +0000)]
LayoutTests:

        Reviewed by john

        Removed an unnecessary block (one that was fully
        selected but whose markup wasn't needed to preserve
        appearance):
        * editing/pasteboard/paste-text-011-expected.txt:
        Removed unnecessary style spans:
        * editing/pasteboard/merge-end-blockquote-expected.txt:
        Removed unnecessary empty anonymous blocks:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/pasteboard/display-block-on-spans-expected.txt:
        * editing/pasteboard/paste-text-006-expected.txt:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-text-013-expected.txt:
        * editing/pasteboard/paste-text-002-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/paste-text-005-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-014-expected.txt:
        * editing/pasteboard/paste-pre-001-expected.txt:
        Now (correctly) includes fully selected root:
        * editing/pasteboard/paste-text-015-expected.checksum:
        * editing/pasteboard/paste-text-015-expected.png:
        * editing/pasteboard/paste-text-015-expected.txt:
        * editing/inserting/insert-3907422-fix-expected.txt:
        * editing/pasteboard/paste-text-004-expected.txt:
        Demonstrates a bug that already existed (we don't inline
        the font styles from the Preference Pane on copy):
        * editing/pasteboard/5027857-expected.checksum:
        * editing/pasteboard/5027857-expected.png:
        * editing/pasteboard/5027857-expected.txt:
        * editing/pasteboard/paste-pre-002-expected.checksum:
        * editing/pasteboard/paste-pre-002-expected.png:
        * editing/pasteboard/paste-pre-002-expected.txt:

WebCore:

        Reviewed by john

        ~2x speed up of 5k rich text paste:
        http://shakespeare.mit.edu/hamlet/full.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Remove the top
        level style span if its unnecessary before inserting
        into the document, its faster than doing it after.
        * editing/ReplaceSelectionCommand.h: Exposed
        ReplacementFragment::removeNodePreservingChildren so that
        the style span can be removed using non-undoable removes,
        like the rest of the removes done on the ReplacementFragment.
        * editing/markup.cpp:
        (WebCore::createMarkup): Make the style span the top level
        element, otherwise it's useless.  This also facilitates the
        optimization mentioned above.
        When including markup for a fully selected root, include markup
        for all the nodes beneath that fully selected root, to preserve
        the structure and appearance of the copied markup.  Did this
        by merging with the code for adding markup for descendants of
        special commonAncestorBlocks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Adele.
bdakin [Thu, 15 Mar 2007 19:07:15 +0000 (19:07 +0000)]
    Rubber-stamped by Adele.

        Rolling out http://trac.webkit.org/projects/webkit/changeset/20148
        (which is a fix for http://bugs.webkit.org/show_bug.cgi?id=12595
        and rdar://4722863) because it causes a horrible memory-trasher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-16 Shrikant Gangoda <shrikant.gangoda@celunite.com>
bdash [Thu, 15 Mar 2007 13:26:45 +0000 (13:26 +0000)]
2007-03-16  Shrikant Gangoda  <shrikant.gangoda@celunite.com>

        Gdk build fix.

        * kjs/DateMath.cpp:  gettimeofday comes from <sys/time.h> on Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-15 Mark Rowe <mrowe@apple.com>
bdash [Thu, 15 Mar 2007 12:15:32 +0000 (12:15 +0000)]
2007-03-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by Antti.

        Fix for <rdar://problem/5065060> ASSERTION FAILURE: newUsername && newPassword
        when submitting an authentication form without password.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchWillSubmitForm): Don't omit form fields with empty values from the dictionary
        passed to the delegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added an assert to help catch a bug. Hopefully someone will hit it!
ggaren [Thu, 15 Mar 2007 07:11:45 +0000 (07:11 +0000)]
    Added an assert to help catch a bug. Hopefully someone will hit it!

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::~KJSProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt.
andersca [Thu, 15 Mar 2007 06:42:07 +0000 (06:42 +0000)]
    Reviewed by Dave Hyatt.

        Don't add the data twice, it's also done by didReceiveData.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::deliverArchivedResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-03-14 Oliver Hunt <oliver@apple.com>
oliver [Thu, 15 Mar 2007 06:30:41 +0000 (06:30 +0000)]
2007-03-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adele.

        Fix for rdar://problem/5061737.

        This was a regression from the original Objective-C -> C++ conversion
        for the drag logic.  We don't need to call Range::startNode as we just
        need the document that contains the range.

        * page/DragController.cpp:
        (WebCore::documentFragmentFromDragData):
LayoutTests:
        Layout tests for rdar://problem/5061737

        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix segmentation fault when running layout tests.
andersca [Thu, 15 Mar 2007 04:59:32 +0000 (04:59 +0000)]
    Fix segmentation fault when running layout tests.

        Remove bogus check that that I added on purpose to see how good Geoff is at spotting mistakes when reviewing code.
        (Turns out he's not that good!)

        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::increaseLoadCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by .
kmccullo [Thu, 15 Mar 2007 04:09:07 +0000 (04:09 +0000)]
    Reviewed by .

        Silly wrapping change for testing a post-commit hook change.

        * contact.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Thu, 15 Mar 2007 04:00:06 +0000 (04:00 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=13076
        REGRESSION: Multiple loading tabs cause assertion in WebDocumentLoaderMac::decreaseLoadCount(unsigned long)

        Store the identifier set in the document loader since identifiers are per-webview and not global.

        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::WebDocumentLoaderMac):
        (WebDocumentLoaderMac::attachToFrame):
        (WebDocumentLoaderMac::increaseLoadCount):
        (WebDocumentLoaderMac::decreaseLoadCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by .
kmccullo [Thu, 15 Mar 2007 03:42:03 +0000 (03:42 +0000)]
    Reviewed by .

        - Fixed one more build breakage

        * kjs/date_object.cpp:
        (KJS::formatLocaleDate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by .
kmccullo [Thu, 15 Mar 2007 03:23:56 +0000 (03:23 +0000)]
    Reviewed by .

        - Fixed a build breakage.

        * kjs/DateMath.cpp:
        * kjs/date_object.cpp:
        (KJS::formatLocaleDate):
        (KJS::DateObjectImp::construct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
kmccullo [Thu, 15 Mar 2007 02:21:47 +0000 (02:21 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        - rdar://problem/5045720
        - DST changes in US affect JavaScript date calculations (12975)
        This fix was to ensure we properly test for the new changes to DST in the US.
        Also this fixes when we apply DST, now we correctly map most past years to current
        DST rules.  We still have a small issue with years before 1900 or after 2100.
        rdar://problem/5055038

        * kjs/DateMath.cpp: Fix DST to match spec better.
        (KJS::getCurrentUTCTime):
        (KJS::mimimumYearForDST):
        (KJS::maximumYearForDST):
        (KJS::equivalentYearForDST):
        (KJS::getDSTOffset):
        * kjs/DateMath.h: Consolodated common funtionality.
        * kjs/date_object.cpp: Consolodated common functionality.
        (KJS::formatLocaleDate):
        (KJS::DateObjectImp::construct):
        * tests/mozilla/ecma/jsref.js: Added functions for finding the correct days when DST starts and ends.
        * tests/mozilla/ecma/shell.js: Added back in the old DST functions for ease of merging with mozilla if needed.
        * tests/mozilla/ecma_2/jsref.js: Added functions for finding the correct days when DST starts and ends.
        * tests/mozilla/ecma_3/Date/shell.js: Added functions for finding the correct days when DST starts and ends.
        * tests/mozilla/expected.html: Updated to show all date tests passing.

LayoutTests:

        Reviewed by Geoff.

        - rdar://problem/5045720
        - DST changes in US affect JavaScript date calculations (12975)
        Changed layout tests to properly check for the new changes to DST in the
        US. Also these now test that equivalent years return the same results for DST.

        * fast/js/date-DST-time-cusps-expected.txt:
        * fast/js/date-big-setdate-expected.txt:
        * fast/js/resources/date-DST-time-cusps.js:
        * fast/js/resources/date-big-setdate.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 15 Mar 2007 01:36:18 +0000 (01:36 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for://bugs.webkit.org/show_bug.cgi?id=13071
          REGRESSION: Plain text files no longer wrap lines longer than the width of the browser window

        * fast/loader/resources/text-document-wrapping.txt: Added.
        * fast/loader/text-document-wrapping-expected.checksum: Added.
        * fast/loader/text-document-wrapping-expected.png: Added.
        * fast/loader/text-document-wrapping-expected.txt: Added.
        * fast/loader/text-document-wrapping.html: Added.

WebCore:

        Reviewed by Hyatt.

        - http://bugs.webkit.org/show_bug.cgi?id=13071
          REGRESSION: Plain text files no longer wrap lines longer than the width of the browser window

        Test: fast/loader/text-document-wrapping.html

        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::write): Specified word-wrap:break-word for the <pre> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
harrison [Thu, 15 Mar 2007 01:22:40 +0000 (01:22 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5009625> REGRESSION: Aperture 1.5: Can't select entire line of text after correcting a misspelled word

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::respondToChangedSelection):
        * WebCoreSupport/WebFrameBridge.mm:
        Provide compatibility by not sending WebViewDidChangeSelectionNotification if
        the app is Aperture and is linked against WebKit 2.0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 15 Mar 2007 01:22:19 +0000 (01:22 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13072
          REGRESSION (r15617): white-space: pre-wrap breaks off the last character of a wide word

        * fast/text/whitespace/pre-wrap-last-char-expected.checksum: Added.
        * fast/text/whitespace/pre-wrap-last-char-expected.png: Added.
        * fast/text/whitespace/pre-wrap-last-char-expected.txt: Added.
        * fast/text/whitespace/pre-wrap-last-char.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13072
          REGRESSION (r15617): white-space: pre-wrap breaks off the last character of a wide word

        Test: fast/text/whitespace/pre-wrap-last-char.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak): Undid the change from r15617.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20200 268f45cc-cd09-0410-ab3c-d52691b4dbfc