WebKit-https.git
8 years agoFix 32bit build.
oliver@apple.com [Fri, 2 Sep 2011 21:08:27 +0000 (21:08 +0000)]
Fix 32bit build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome media layout tests fail because of ambiguous ordering of canplaythough event.
jer.noble@apple.com [Fri, 2 Sep 2011 20:48:32 +0000 (20:48 +0000)]
Some media layout tests fail because of ambiguous ordering of canplaythough event.
https://bugs.webkit.org/show_bug.cgi?id=67520

Reviewed by Eric Carlson.

The "canplaythrough" event can occur either before or after the "playing" event, causing layout tests
to fail for certain media engines (AVFoundation). The "canplaythrough" event check isn't adding anything
of value which isn't covered in other layout tests, so remove this event check.

* media/audio-play-event-expected.txt:
* media/audio-play-event.html:
* media/video-play-empty-events-expected.txt:
* media/video-play-empty-events.html:
* media/video-timeupdate-during-playback-expected.txt:
* media/video-timeupdate-during-playback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse bump allocator for initial property storage
oliver@apple.com [Fri, 2 Sep 2011 20:41:59 +0000 (20:41 +0000)]
Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Gavin Barraclough.

Switch to a bump allocator for the initial out of line
property storage.  This gives us slightly faster allocation
for short lived objects that need out of line storage at
the cost of an additional memcpy when the object survives
a GC pass.

No performance impact.

* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursary):
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
(JSC::NewSpace::resetPropertyStorageNursary):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursary):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded Subversion ignore for .pyc generated files.
darin@apple.com [Fri, 2 Sep 2011 20:33:34 +0000 (20:33 +0000)]
Added Subversion ignore for .pyc generated files.

* Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
* Scripts/webkitpy/tool/servers: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update expectations for tests with animations and reflections
jamesr@google.com [Fri, 2 Sep 2011 20:25:29 +0000 (20:25 +0000)]
[chromium] Update expectations for tests with animations and reflections

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 2 Sep 2011 19:55:47 +0000 (19:55 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable testing on mac-ews
abarth@webkit.org [Fri, 2 Sep 2011 19:48:43 +0000 (19:48 +0000)]
Enable testing on mac-ews
https://bugs.webkit.org/show_bug.cgi?id=67505

Reviewed by Eric Seidel.

This patch enables testing on the Mac EWS, which should help
contributors not turn the Mac bots red.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update some chromium gpu baselines
jamesr@google.com [Fri, 2 Sep 2011 19:40:11 +0000 (19:40 +0000)]
[chromium] Update some chromium gpu baselines

* platform/chromium-gpu-cg-mac/compositing/images/content-image-change-expected.png: Added.
* platform/chromium-gpu-cg-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-gpu-win/compositing/images/content-image-change-expected.png: Added.
* platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove plug-in paths from web process sandbox
andersca@apple.com [Fri, 2 Sep 2011 19:27:04 +0000 (19:27 +0000)]
Remove plug-in paths from web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=67518

Reviewed by Adam Roben.

Plug-ins are never accessed from the web process, so remove plug-in paths from the sandbox profile.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssertion/crash when running netscape-plugin-property-access-exception.html test
andersca@apple.com [Fri, 2 Sep 2011 19:19:41 +0000 (19:19 +0000)]
Assertion/crash when running netscape-plugin-property-access-exception.html test
https://bugs.webkit.org/show_bug.cgi?id=67517

Reviewed by Adam Roben.

Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty,
but doesn't set the result NPVariant to anything.

* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::getProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67451
bdakin@apple.com [Fri, 2 Sep 2011 18:55:16 +0000 (18:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67451
Add a test for going back to a cached page after changing the device scale factor

Reviewed by Adam Roben.

New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
(TestWebKitAPI::DeviceScaleFactorOnBack::url):
(TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
(TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
(TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
(TestWebKitAPI::TEST_F):

Added new function to WebKitAgnosticTest to goBack. Separated
waitForLoadToFinish() into its own function (instead of being a part of
loadAndWaitUntilFinished()) so that it can be called from goBack as
well. Also added initializeView() so we can set the cache model.
* TestWebKitAPI/mac/WebKitAgnosticTest.h:
(TestWebKitAPI::WebKitAgnosticTest::initializeView):
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
(TestWebKitAPI::WebKitAgnosticTest::loadURL):
(TestWebKitAPI::WebKitAgnosticTest::goBack):
(TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Flaky Test: http/tests/appcache/origin-usage.html
ap@apple.com [Fri, 2 Sep 2011 18:35:18 +0000 (18:35 +0000)]
    Flaky Test: http/tests/appcache/origin-usage.html
        https://bugs.webkit.org/show_bug.cgi?id=60928

        Reviewed by Joseph Pecoraro.

        Not sure if it was actually flaky anywhere, but it's failing for me on Lion consistently.

        * http/tests/appcache/origin-usage-expected.txt:
        * http/tests/appcache/origin-usage.html:
        Increase the range for success. It's OK because data is added in larger chunks anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe private browsing state isn't saved when it changes
andersca@apple.com [Fri, 2 Sep 2011 18:17:26 +0000 (18:17 +0000)]
The private browsing state isn't saved when it changes
https://bugs.webkit.org/show_bug.cgi?id=67508

Reviewed by Sam Weinig.

Source/WebKit2:

Store the new private browsing state so subsequent queries for it
will return the right value.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::privateBrowsingStateChanged):

LayoutTests:

Unskip private browsing plug-in tests, since WebKitTestRunner
now has layoutTestController.setPopupBlockingEnabled.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac, next chunk of files)
caryclark@google.com [Fri, 2 Sep 2011 18:02:44 +0000 (18:02 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

* platform/chromium-mac/media/controls-after-reload-expected.txt: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove BeforeProcessEvent, it was never meant to be
weinig@apple.com [Fri, 2 Sep 2011 17:42:39 +0000 (17:42 +0000)]
Remove BeforeProcessEvent, it was never meant to be
https://bugs.webkit.org/show_bug.cgi?id=67493

Reviewed by Anders Carlsson.

BeforeProcessEvent was added, never hooked up, and never removed.
Now it is being removed.

* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/BeforeProcessEvent.cpp: Removed.
* dom/BeforeProcessEvent.h: Removed.
* dom/BeforeProcessEvent.idl: Removed.
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded):
* dom/Document.h:
* dom/EventNames.h:
* html/HTMLAttributeNames.in:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
andersca@apple.com [Fri, 2 Sep 2011 17:41:08 +0000 (17:41 +0000)]
Build fix.

* DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
(PrivateBrowsing::ScriptableObject::pluginTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove LayerRendererChromium references from the LayerChromium tree
enne@google.com [Fri, 2 Sep 2011 17:36:00 +0000 (17:36 +0000)]
[chromium] Remove LayerRendererChromium references from the LayerChromium tree
https://bugs.webkit.org/show_bug.cgi?id=66430

Reviewed by James Robinson.

Source/WebCore:

Covered by existing tests.

Replace references to LayerRendererChromium in the LayerChromium tree
with references to LayerTreeHost. The LayerRendererChromium property
is no longer synced and instead is set recursively on the CCLayerImpl
tree during commit.

WebGLLayerChromium's paintRenderedResultsToCanvas function is
temporarily turned off for threaded compositing because it needs
access to the compositor context.

Previously, changing the layer renderer on a layer called cleanup
resources on that layer.  Now, call that explicitly clean up all
resources explicitly from the proxy when the layer renderer gets
created. This cleans up all of the ManagedTexture objects which may be
hanging onto stale GraphicsContext3D pointers.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::cleanupResourcesRecursive):
(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::layerTreeHost):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::textureManager):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::reserveTextures):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setTextureUpdated):
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setLayerRendererRecursive):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

Source/WebKit/chromium:

Change references to LayerRendererChromium to CCLayerTreeHost.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove private browsing test to a PluginTest subclass
andersca@apple.com [Fri, 2 Sep 2011 17:33:10 +0000 (17:33 +0000)]
Move private browsing test to a PluginTest subclass
https://bugs.webkit.org/show_bug.cgi?id=67498

Reviewed by Darin Adler.

Tools:

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginGetProperty):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_SetValue):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
* DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
(PrivateBrowsing::PrivateBrowsing):
(PrivateBrowsing::privateBrowsingEnabled):
(PrivateBrowsing::cachedPrivateBrowsingEnabled):
(PrivateBrowsing::ScriptableObject::hasProperty):
(PrivateBrowsing::ScriptableObject::getProperty):
(PrivateBrowsing::ScriptableObject::pluginTest):
(PrivateBrowsing::NPP_New):
(PrivateBrowsing::NPP_GetValue):
(PrivateBrowsing::NPP_SetValue):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(NPP_SetValue):
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:

LayoutTests:

Set the 'test' attribute to 'private-browsing'.

* plugins/private-browsing-mode-2.html:
* plugins/private-browsing-mode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, update expectations after r94420.
apavlov@chromium.org [Fri, 2 Sep 2011 17:24:03 +0000 (17:24 +0000)]
[Chromium] Unreviewed, update expectations after r94420.

* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium-win/fast/borders/border-image-repeat-expected.png: Added.
* platform/chromium-win/fast/borders/border-image-repeat-expected.txt: Added.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Build fix.
ap@apple.com [Fri, 2 Sep 2011 17:09:55 +0000 (17:09 +0000)]
    Build fix.

        * platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
        Can't use BUILDING_ON_SNOW_LEOPARD without defined() when not on Snow Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94421.
commit-queue@webkit.org [Fri, 2 Sep 2011 17:07:51 +0000 (17:07 +0000)]
Unreviewed, rolling out r94421.
http://trac.webkit.org/changeset/94421
https://bugs.webkit.org/show_bug.cgi?id=67496

Broke a number of tests on Chromium builders (including the
"cr-linux" EWS bot) (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name):
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):
* dom/Element.cpp:
(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::nodeMatches):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
* editing/markup.cpp:
(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::target):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::value):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::noResize):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::insertedByParser):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::groupLabelText):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::max):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::width):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::maxLength):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):
* html/StepRange.cpp:
(WebCore::StepRange::StepRange):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* page/Frame.cpp:
(WebCore::Frame::matchLabelsAgainstElement):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* page/mac/FrameMac.mm:
(WebCore::Frame::matchLabelsAgainstElement):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::writeImageToDataObject):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
* platform/mac/HTMLConverter.mm:
(fileWrapperForElement):
* platform/win/ClipboardWin.cpp:
(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::isOpen):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemAccessibilityText):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::autosaveName):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago REGRESSION (r94093): Private browsing doesn't start with a clean state on...
ap@apple.com [Fri, 2 Sep 2011 17:02:59 +0000 (17:02 +0000)]
    REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard
        https://bugs.webkit.org/show_bug.cgi?id=67356

        Reviewed by Darin Adler.

        * platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
        Don't enable old-style private browsing when using sessions - it would take precedence over
        session cookie storage on Snow Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBORDER attribute percent with the input image tag not working.
commit-queue@webkit.org [Fri, 2 Sep 2011 17:01:42 +0000 (17:01 +0000)]
BORDER attribute percent with the input image tag not working.
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-09-02
Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes 2 issues regarding the border attribute of an input image element.
1. The border attribute, if specified, is now taken into account and the border of the input image element is displayed.
2. If the border attribute contains percent, the border is displayed.
The value of the border attribute for input image element is now parsed according to the rules for parsing non-negative integers.
This implies that when percent is specified in the border attribute, parsing takes place and the percent is ignored.
If after parsing, the value of the border is greater than zero, the border of the input image element is displayed.

* html/HTMLElement.cpp:
(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttribute):
* html/HTMLElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests:

Test border-width-percent was modified with tests for input image element.
Expected results for input-image-alt-test were regenerated since an image input element
takes border attribute into account.
Also, mark the test as failure for chromium.

* fast/borders/border-width-percent-expected.txt:
* fast/borders/border-width-percent.html:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement the Event constructor for V8.
rolandsteiner@chromium.org [Fri, 2 Sep 2011 16:59:56 +0000 (16:59 +0000)]
Implement the Event constructor for V8.
https://bugs.webkit.org/show_bug.cgi?id=66756

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Source/WebCore:

The spec of the Event constructor is here:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor
This patch implements the Event constructor for V8 in V8EventConstructors.cpp,
similar to the implementation for JSC in JSEventConstructors.cpp.

* WebCore.gypi: Added V8EventConstructors.cpp.
* WebCore.pro: Ditto.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyDouble): Returns a value of type double corresponding to a given key.
* bindings/v8/OptionsObject.h:
(WebCore::OptionsObject::getKeyValue): Returns a value corresponding to a given key.
* bindings/v8/custom/V8EventConstructors.cpp: Added.
(WebCore::constructV8Event): AllowAllocation::current() means that a DOM object created by WebCore is going to be just wrapped into a V8 object. In this case, we skip the code of constructorCallback().
* dom/Event.idl: Added |V8CustomConstructor|.

LayoutTests:

* platform/chromium/test_expectations.txt: Unskip fast/events/constructors/event-constructors.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap
antonm@chromium.org [Fri, 2 Sep 2011 16:50:44 +0000 (16:50 +0000)]
[v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=67484

Reviewed by Yury Semikhatsky.

No new tests, minor cleanup.

* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyEnumerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94404.
commit-queue@webkit.org [Fri, 2 Sep 2011 16:38:32 +0000 (16:38 +0000)]
Unreviewed, rolling out r94404.
http://trac.webkit.org/changeset/94404
https://bugs.webkit.org/show_bug.cgi?id=67490

"Patch is wrong, new API needs two reviewers, we are already
working on how to add notifications elsewhere" (Requested by
xan_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* bindings/gobject/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse fastGetAttribute() and fastHasAttribute() where appropriate.
andreas.kling@nokia.com [Fri, 2 Sep 2011 16:13:01 +0000 (16:13 +0000)]
Use fastGetAttribute() and fastHasAttribute() where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=67394

Reviewed by Darin Adler.

Change call sites that don't check the "style" or SVG animatable
attributes to use fastGetAttribute()/fastHasAttribute() instead
of getAttribute()/hasAttribute().

No new tests, this is a minor performance optimization.

* accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name):
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::recalcStyleSelector):
* dom/Element.cpp:
(WebCore::Element::baseURI):
(WebCore::Element::formatForDebugger):
(WebCore::Element::spellcheckAttributeState):
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::nodeMatches):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
* editing/markup.cpp:
(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::name):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::target):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::aLink):
(WebCore::HTMLBodyElement::bgColor):
(WebCore::HTMLBodyElement::link):
(WebCore::HTMLBodyElement::text):
(WebCore::HTMLBodyElement::vLink):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::value):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::title):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::getNamedFormItem):
(WebCore::HTMLFormCollection::updateNameCache):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::autofocus):
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::name):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::method):
(WebCore::HTMLFormElement::target):
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::noResize):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::allowFullScreen):
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::insertedByParser):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore::HTMLInputElement::isSpeechEnabled):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::control):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):
(WebCore::HTMLMediaElement::insertedIntoDocument):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::groupLabelText):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::max):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::type):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::media):
(WebCore::HTMLStyleElement::type):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::width):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::vAlign):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::maxLength):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::src):
(WebCore::HTMLTrackElement::kind):
(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::load):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::height):
* html/StepRange.cpp:
(WebCore::StepRange::StepRange):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* page/Frame.cpp:
(WebCore::Frame::matchLabelsAgainstElement):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* page/mac/FrameMac.mm:
(WebCore::Frame::matchLabelsAgainstElement):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::writeImageToDataObject):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
* platform/mac/HTMLConverter.mm:
(fileWrapperForElement):
* platform/win/ClipboardWin.cpp:
(WebCore::writeImageToDataObject):
(WebCore::ClipboardWin::declareAndWriteDragImage):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absoluteLinkURL):
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::isOpen):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemAccessibilityText):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::autosaveName):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67431
hyatt@apple.com [Fri, 2 Sep 2011 16:00:23 +0000 (16:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67431

Implement border-image-repeat. Similar to how border-image-slice was implemented, the parsing of the two
repeat values has been moved into separate functions. The value is represented as a Pair (similar to how we
handle border radius).

Reviewed by Beth Dakin.

Added fast/borders/border-image-repeat.html.

Source/WebCore:

* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):
* css/CSSBorderImageValue.h:
(WebCore::CSSBorderImageValue::create):
Modified the CSSBorderImageValue (you're living on borrowed time, my friend!) to have a CSSValue that
contains a Pair.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForRepeatRule):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for the new properties. Break out the value retrieval for the image repeat rules into its
own function, valueForNinePieceImageRepeat.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitWidth):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Modified the parsing of border image to call into parseBorderImageRepeat for the repeat values.

(WebCore::isBorderImageRepeatKeyword):
(WebCore::CSSParser::parseBorderImageRepeat):
The new parsing code for border-image-repeat is here. It will build up a CSSValue containing a Pair and
return the result.

* css/CSSParser.h:
* css/CSSPropertyNames.in:
Add the new properties.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageRepeat):
* css/CSSStyleSelector.h:
The mapping into the front end is done the same way as border-image-slice. Factor out the image repeat rules
portion into mapNinePieceImageRepeat.

* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
Add the new 'space' value as a valid image tiling rule. It's not yet supported and, like the 'round' value,
is just mapped to 'repeat' for now.

* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::copyRepeatFrom):
Helper for copying only the repeat rules from another NinePieceImage.

LayoutTests:

* fast/borders/border-image-repeat.html: Added.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/borders/border-image-repeat-expected.png: Added.
* platform/mac/fast/borders/border-image-repeat-expected.txt: Added.
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [Qt] number input not rendering spin buttons properly in RTL direction
commit-queue@webkit.org [Fri, 2 Sep 2011 15:57:44 +0000 (15:57 +0000)]
Source/WebCore: [Qt] number input not rendering spin buttons properly in RTL direction
https://bugs.webkit.org/show_bug.cgi?id=67445

Properly render Qt's number input with RTL direction, and fix Plastique styling.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintInnerSpinButton):

LayoutTests: [Qt] number input not rendering spin buttons properly in RTL direction
https://bugs.webkit.org/show_bug.cgi?id=67445

New baseline for Qt number input with RTL direction.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-02
Reviewed by Andreas Kling.

* platform/qt/fast/forms/input-appearance-number-rtl-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Resetting media controls when the src is changed from a valid url...
commit-queue@webkit.org [Fri, 2 Sep 2011 15:35:44 +0000 (15:35 +0000)]
Source/WebCore: Resetting media controls when the src is changed from a valid url to an
invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

Test: media/media-controls-invalid-url.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaLoadingFailed):

LayoutTests: Controls not reset when media element url changed from a valid url to an invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880

Patch by Arko Saha <nghq36@motorola.com> on 2011-09-02
Reviewed by Eric Carlson.

* media/media-controls-invalid-url-expected.txt: Added.
* media/media-controls-invalid-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Anchor elements doesn't get focus on TAB key press.
commit-queue@webkit.org [Fri, 2 Sep 2011 14:09:27 +0000 (14:09 +0000)]
[WK2] Anchor elements doesn't get focus on TAB key press.
https://bugs.webkit.org/show_bug.cgi?id=66949

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-02
Reviewed by Adam Roben.

Setting the default property value of TabsToLinks to true
only for GTK platform since Win & Mac platforms doesn't want
it to be set to true by default.

* Shared/WebPreferencesStore.h:
Set the default value of key TabsToLinks to true for GTK platform only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] 4 tests are failing, skip them
zoltan@webkit.org [Fri, 2 Sep 2011 14:05:43 +0000 (14:05 +0000)]
[Qt][WK2] 4 tests are failing, skip them
https://bugs.webkit.org/show_bug.cgi?id=67485

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-02

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix.
dominicc@chromium.org [Fri, 2 Sep 2011 14:02:57 +0000 (14:02 +0000)]
Unreviewed test fix.

Sadly window-property-descriptors enumerates functions in the test
harness. r94362 added a couple of functions, so these results need
to be updated.

* fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r67110.
leandro@webkit.org [Fri, 2 Sep 2011 13:22:45 +0000 (13:22 +0000)]
Unreviewed build fix after r67110.

* ewk/ewk_view.cpp:
(ewk_view_need_touch_events_get): Make the function signature match
its declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Two tests are passing after r94324. They are unskipped:
reni@webkit.org [Fri, 2 Sep 2011 13:09:02 +0000 (13:09 +0000)]
[Qt] Two tests are passing after r94324. They are unskipped:
fast/events/document-elementFromPoint.html
plugins/mouse-events-fixedpos.html

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, update test expectations.
apavlov@chromium.org [Fri, 2 Sep 2011 12:46:47 +0000 (12:46 +0000)]
[Chromium] Unreviewed, update test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Cannot gathering glyph page statistics
kbalazs@webkit.org [Fri, 2 Sep 2011 12:35:46 +0000 (12:35 +0000)]
[Qt][WK2] Cannot gathering glyph page statistics
https://bugs.webkit.org/show_bug.cgi?id=67475

Rubber stamped by Csaba Osztrogonác.

Fix Qt WK2 build without having QRAWFONT.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWebCoreStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Make it more clear when requests are loaded from cache on network...
vsevik@chromium.org [Fri, 2 Sep 2011 11:49:36 +0000 (11:49 +0000)]
Web Inspector: Make it more clear when requests are loaded from cache on network panel.
https://bugs.webkit.org/show_bug.cgi?id=67396

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
* inspector/front-end/networkPanel.css:
(.resource-headers-view .outline-disclosure li .status-from-cache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Should remove resource highlight on sort/filter in network panel.
vsevik@chromium.org [Fri, 2 Sep 2011 11:41:55 +0000 (11:41 +0000)]
Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._sortByTimeline):
(WebInspector.NetworkLogView.prototype._updateFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Network: jump to initiator's record in case of redirect
vsevik@chromium.org [Fri, 2 Sep 2011 11:39:00 +0000 (11:39 +0000)]
Web Inspector: Network: jump to initiator's record in case of redirect
https://bugs.webkit.org/show_bug.cgi?id=67367

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get redirectSource):
(WebInspector.Resource.prototype.set redirectSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build dependency problems
ossy@webkit.org [Fri, 2 Sep 2011 11:36:40 +0000 (11:36 +0000)]
[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054

Trivial fix after r94288.

Rubber-stamped by Andras Becsi.

* Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize recalcStyle()
antti@apple.com [Fri, 2 Sep 2011 11:19:35 +0000 (11:19 +0000)]
De-virtualize recalcStyle()
https://bugs.webkit.org/show_bug.cgi?id=67378

Reviewed by Dimitri Glazkov.

Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will
also make it possible to de-recursify it later.

Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc.
These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set.

* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* dom/Element.h:
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
* dom/Node.h:
(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
* dom/ShadowRoot.h:
* dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
* dom/Text.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didRecalcStyle):
* html/HTMLFormControlElement.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::willRecalcStyle):
* html/HTMLFrameSetElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::didRecalcStyle):
* html/HTMLMediaElement.h:
* html/HTMLNoScriptElement.cpp:
(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::willRecalcStyle):
* html/HTMLNoScriptElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
* html/HTMLPlugInImageElement.h:
* html/HTMLSelectElement.cpp:
* html/HTMLSelectElement.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::willRecalcStyle):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::willRecalcStyle):
(WebCore::SVGUseElement::didRecalcStyle):
* svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Send Blob as WebSocket binary message
yutak@chromium.org [Fri, 2 Sep 2011 11:16:40 +0000 (11:16 +0000)]
WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Re-lands r94399 with a fix for Leopard builds.

Source/WebCore:

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-empty.html: Added.
* http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-object.html: Added.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
* http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-blob.html: Added.
* http/tests/websocket/tests/hybi/send-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-empty.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Generate gobject bindings for Notification and NotificationCenter
paroga@webkit.org [Fri, 2 Sep 2011 11:10:49 +0000 (11:10 +0000)]
[GTK] Generate gobject bindings for Notification and NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=67380

Reviewed by Philippe Normand.

* bindings/gobject/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] editing/selection/regional-indicators.html timing out on Linux
bashi@chromium.org [Fri, 2 Sep 2011 10:54:05 +0000 (10:54 +0000)]
[chromium] editing/selection/regional-indicators.html timing out on Linux
https://bugs.webkit.org/show_bug.cgi?id=66510

Reviewed by Kent Tamura.

Source/WebCore:

Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly.

No new tests. editing/selection/regional-indicators.html should pass with this patch.

* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run.
(WebCore::surrogatePairAwareFirstCharacter): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData.

LayoutTests:

ComplexTextControllerLinux is now surrogate pairs aware, therefore;
- editing/selection/regional-indicators.html should pass.
- editing/deleting/regional-indicators.html should not timeout.
- fast/text/regional-indicator-symbols.html should pass.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94399.
commit-queue@webkit.org [Fri, 2 Sep 2011 10:51:49 +0000 (10:51 +0000)]
Unreviewed, rolling out r94399.
http://trac.webkit.org/changeset/94399
https://bugs.webkit.org/show_bug.cgi?id=67471

Broke Leopard build (Requested by yutak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

Source/WebCore:

* bindings/js/JSWebSocketCustom.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp:
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/send-empty-expected.txt: Removed.
* http/tests/websocket/tests/hixie76/send-empty.html: Removed.
* http/tests/websocket/tests/hixie76/send-object-expected.txt: Removed.
* http/tests/websocket/tests/hixie76/send-object.html: Removed.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
* http/tests/websocket/tests/hybi/send-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-blob.html: Removed.
* http/tests/websocket/tests/hybi/send-blob_wsh.py: Removed.
* http/tests/websocket/tests/hybi/send-empty-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-empty.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Removed.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js: Removed.
* http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py: Removed.
* http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/workers/send-blob.html: Removed.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94393.
commit-queue@webkit.org [Fri, 2 Sep 2011 10:40:18 +0000 (10:40 +0000)]
Unreviewed, rolling out r94393.
http://trac.webkit.org/changeset/94393
https://bugs.webkit.org/show_bug.cgi?id=67470

It broke Qt-SL build (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Webfonts display bold in Windows
bashi@chromium.org [Fri, 2 Sep 2011 10:38:57 +0000 (10:38 +0000)]
[Chromium] Webfonts display bold in Windows
https://bugs.webkit.org/show_bug.cgi?id=67387

Uses font's default weight for webfonts by setting FW_DONTCARE.

Reviewed by Kent Tamura.

No new tests. We don't have fonts to test this change.

* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Send Blob as WebSocket binary message
yutak@chromium.org [Fri, 2 Sep 2011 10:36:43 +0000 (10:36 +0000)]
WebSocket: Send Blob as WebSocket binary message
https://bugs.webkit.org/show_bug.cgi?id=67465

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hixie76/send-empty.html
       http/tests/websocket/tests/hixie76/send-object.html
       http/tests/websocket/tests/hybi/send-blob.html
       http/tests/websocket/tests/hybi/send-empty.html
       http/tests/websocket/tests/hybi/send-file-blob-fail.html
       http/tests/websocket/tests/hybi/send-file-blob.html
       http/tests/websocket/tests/hybi/workers/send-blob.html
       http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
Fixing code generator did not sound easy, because there are some classes depending on
broken behavior of current code generator (one such example is CanvasRenderingContext2D).
As a temporary workaround, new custom handlers for send() are added.
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendBlob):
A Blob can be deserialized from url, type and size.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
KURL, String and long long (corresponding to url, type and size, respectively) can be passed
safely across threads.
* websockets/WorkerThreadableWebSocketChannel.h:

LayoutTests:

* http/tests/websocket/tests/hixie76/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-empty.html: Added.
* http/tests/websocket/tests/hixie76/send-object-expected.txt: Added.
* http/tests/websocket/tests/hixie76/send-object.html: Added.
* http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
* http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
Updated. Added tests to send Blobs.
* http/tests/websocket/tests/hybi/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-blob.html:
Added. Send three Blobs each of which contains a small binary message.
* http/tests/websocket/tests/hybi/send-blob_wsh.py:
Added. receive_message() returns a unicode value if the received message was text, or
a str value if the message was binary.
* http/tests/websocket/tests/hybi/send-empty-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-empty.html: Added.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html:
Added. If we delete a file before reading it, FileReaderLoader reliably fails.
* http/tests/websocket/tests/hybi/send-file-blob.html:
Added. Create a File and try to send it as a Blob.
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/resources/send-blob.js:
Added. Same as send-blob.html above.
* http/tests/websocket/tests/hybi/workers/resources/send-blob_wsh.py:
Added. Same as send-blob_wsh.py above.
* http/tests/websocket/tests/hybi/workers/send-blob-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/send-blob.html: Added.
* platform/gtk/Skipped:
send-file-blob.html and send-file-blob-fail.html depend on availability of File API.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy...
mrowe@apple.com [Fri, 2 Sep 2011 10:21:56 +0000 (10:21 +0000)]
<webkit.org/b/67467> WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
leak the results of the APIs they wrap.

Reviewed by Dan Bernstein.

* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
RetainPtr to ensure it gets released at the appropriate time.
(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebAudio] Undeclared dependency to VIDEO
philn@webkit.org [Fri, 2 Sep 2011 09:58:12 +0000 (09:58 +0000)]
[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

* webaudio/AudioContext.cpp:
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove my old e-mail address and add my new one.
abecsi@webkit.org [Fri, 2 Sep 2011 09:53:58 +0000 (09:53 +0000)]
Remove my old e-mail address and add my new one.

Rubber-stamped by Tor Arne Vestbø.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r94304.
philn@webkit.org [Fri, 2 Sep 2011 09:09:28 +0000 (09:09 +0000)]
Unreviewed, GTK rebaseline after r94304.

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Update Qt specific expected files after r94304.
reni@webkit.org [Fri, 2 Sep 2011 08:49:24 +0000 (08:49 +0000)]
[Qt] Update Qt specific expected files after r94304.

Unreviewed gardening.

* platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.png:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed speculative buildfix.
ossy@webkit.org [Fri, 2 Sep 2011 08:26:19 +0000 (08:26 +0000)]
[Qt][WK2] Unreviewed speculative buildfix.

* WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add Qt expecteds for new tests.
reni@webkit.org [Fri, 2 Sep 2011 08:25:12 +0000 (08:25 +0000)]
[Qt] Add Qt expecteds for new tests.

Unreviewed gardening.

* platform/qt/fast/borders/border-image-slices-expected.png: Added.
* platform/qt/fast/borders/border-image-slices-expected.txt: Added.
* platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94389.
commit-queue@webkit.org [Fri, 2 Sep 2011 07:58:05 +0000 (07:58 +0000)]
Unreviewed, rolling out r94389.
http://trac.webkit.org/changeset/94389
https://bugs.webkit.org/show_bug.cgi?id=67468

breaks mac build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02

* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaElementSource):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
commit-queue@webkit.org [Fri, 2 Sep 2011 07:41:41 +0000 (07:41 +0000)]
Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67459

Patch by Kentaro Hara <haraken@google.com> on 2011-09-02
Reviewed by Adam Barth.

Tests: fast/eventsource/eventsource-constructor.html
       fast/eventsource/eventsource-attribute-listeners.html

* WebCore.gypi: Removed V8EventSourceConstructor.cpp.
* WebCore.pro: Removed V8EventSourceConstructor.cpp.
* bindings/v8/custom/V8EventSourceConstructor.cpp: Removed.
* page/EventSource.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebAudio] Undeclared dependency to VIDEO
philn@webkit.org [Fri, 2 Sep 2011 07:35:13 +0000 (07:35 +0000)]
[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893

Reviewed by Kenneth Russell.

Build MediaAudioSourceNode only if VIDEO is enabled

* webaudio/AudioContext.cpp:
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [GTK] run-gtk-tests leaves a zombie Xvfb process
philn@webkit.org [Fri, 2 Sep 2011 07:32:26 +0000 (07:32 +0000)]
    [GTK] run-gtk-tests leaves a zombie Xvfb process
        https://bugs.webkit.org/show_bug.cgi?id=67389

        Reviewed by Martin Robinson.

        * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
        child process instead of doing shell redirection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] Implement WebSocket::close() code and reason handling.
commit-queue@webkit.org [Fri, 2 Sep 2011 06:33:52 +0000 (06:33 +0000)]
[WebSocket] Implement WebSocket::close() code and reason handling.
https://bugs.webkit.org/show_bug.cgi?id=66925

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-09-01
Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/close.html
       http/tests/websocket/tests/hybi/workers/close.html

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::close):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::closeCallback):
Add custom bridge for WebSocket::close().
* websockets/ThreadableWebSocketChannel.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::close):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::close):
Add code and reason arguments handling.
(WebCore::WebSocketChannel::startClosingHandshake):
Send a close frame without code and reason on server initiated closing handshakes.
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::processFrameHixie76):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::close):
(WebCore::WorkerThreadableWebSocketChannel::Peer::close):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
* websockets/WorkerThreadableWebSocketChannel.h:
Add code and reason arguments handling.

LayoutTests:

* http/tests/websocket/tests/hybi/close-expected.txt: Added.
* http/tests/websocket/tests/hybi/close.html: Added.
* http/tests/websocket/tests/hybi/close_wsh.py: Added.
* http/tests/websocket/tests/hybi/workers/close-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/close.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/close.js: Added.
(postResult):
(testFailed):
(debug):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):
(handleOpen):
(handleError):
(handleClose):
(handleMessage):
(setDefaultHandlers):
(runCodeTest.else.ws.onclose):
(runCodeTest):
(runInvalidStringTest):
(runReasonTest.else.ws.onclose):
(runReasonTest):
(runCodeAndReasonTest.):
(runCodeAndReasonTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build by adding some more missing return types.
mrowe@apple.com [Fri, 2 Sep 2011 04:57:23 +0000 (04:57 +0000)]
Fix the build by adding some more missing return types.

Source/WebCore:

* page/mac/WebCoreViewFactory.m:
(-[WebCoreViewFactory init]):

Source/WebKit/mac:

* WebView/WebDashboardRegion.h:
* WebView/WebDashboardRegion.mm:
(-[WebDashboardRegion initWithRect:clip:type:]):

Tools:

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test fix.
dominicc@chromium.org [Fri, 2 Sep 2011 04:03:22 +0000 (04:03 +0000)]
Unreviewed test fix.

r94362 erroneously changed the description wording generated by
the js-test-pre.

* fast/js/resources/js-test-pre.js:
(description): add the word 'see'
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add chromium-mac-leopard pixel baselines for new/modified tests with text
jamesr@google.com [Fri, 2 Sep 2011 03:59:11 +0000 (03:59 +0000)]
[chromium] Add chromium-mac-leopard pixel baselines for new/modified tests with text

* platform/chromium-cg-mac-leopard/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-gaps-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Fix a crashing bug due to raciness around SQL database shutdown.
michaeln@google.com [Fri, 2 Sep 2011 02:27:34 +0000 (02:27 +0000)]
[Chromium] Fix a crashing bug due to raciness around SQL database shutdown.
https://bugs.webkit.org/show_bug.cgi?id=67457

The removeOpenDatabase() method can get called multiple times.
Subsequent calls to it should be harmeless instead of cause a crash.

Reviewed by David Levin.

* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::removeOpenDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe filename text color of a file upload control should be inherited.
tkent@chromium.org [Fri, 2 Sep 2011 02:12:28 +0000 (02:12 +0000)]
The filename text color of a file upload control should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=67368

Reviewed by Darin Adler.

Source/WebCore:

* css/html.css:
(input[type="file"]):
Add 'color: inherit'.
The declaration for 'input' contains 'color: initial;'. So a file
upload control has had black foreground color unless it has been
specified 'color' property explicitly.
Because a file upload control uses inherited background color, the
foreground color also should be inherited.

LayoutTests:

* fast/forms/file/file-style-inheritance-expected.txt:
* fast/forms/file/file-style-inheritance.html: Add a testcase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate a Worker constructor of V8 using the IDL 'Constructor' extended attribute
commit-queue@webkit.org [Fri, 2 Sep 2011 01:37:55 +0000 (01:37 +0000)]
Generate a Worker constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67447

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/workers/worker-constructor.html
      fast/workers/worker-event-listener.html

* bindings/v8/custom/V8WorkerCustom.cpp: Removed constructorCallback().
* workers/Worker.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
gyuyoung.kim@samsung.com [Fri, 2 Sep 2011 01:35:10 +0000 (01:35 +0000)]
[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=67012

Reviewed by Kenneth Russell.

Set default minimum DOMTimer interval to 4ms instead of 10ms. Because, 4ms is known
to better minimum value for performance. Mac, android, chromium and window ports already
use 4ms instead of 10ms.

It is desirable to be able to change the minimum DOMTimer interval on per-page basis
in order to avoid consuming excessive CPU and battery life on mobile devices. In addition,
other ports have already used this setting by means of Bug 54312.

* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.cpp:
(ewk_settings_default_timer_interval_get):
* ewk/ewk_settings.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_minimum_timer_interval_get):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add chromium leopard baselines
jamesr@google.com [Fri, 2 Sep 2011 01:33:37 +0000 (01:33 +0000)]
[chromium] Add chromium leopard baselines

* platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-cg-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.
* platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_...
commit-queue@webkit.org [Fri, 2 Sep 2011 01:25:03 +0000 (01:25 +0000)]
[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=63377

priv->render.process_entire_queue affects no logical flow of ewk_tiled_backing_store,
But, ewk_view_tiled_process_entire_queue_set is now provided as setter api for it.
So removal of this api and some codes related with it is required.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-01
Reviewed by Antonio Gomes.

* ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_smart_add):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_view.h:
* ewk/ewk_view_tiled.c:
(ewk_view_tiled_unused_cache_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove expectation lines for tests that pass
jamesr@google.com [Fri, 2 Sep 2011 01:00:23 +0000 (01:00 +0000)]
[chromium] Remove expectation lines for tests that pass

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build.
mrowe@apple.com [Fri, 2 Sep 2011 00:51:15 +0000 (00:51 +0000)]
Fix the build.

* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute
commit-queue@webkit.org [Fri, 2 Sep 2011 00:49:28 +0000 (00:49 +0000)]
Generate a FileReader constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67412

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Adam Barth.

Test: fast/files/blob-slice-test.html
      fast/files/file-reader-abort.html

* bindings/v8/custom/V8FileReaderCustom.cpp: Removed constructorCallback().
* fileapi/FileReader.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded Snow Leopard expected results to the test added in r94352.
mitz@apple.com [Fri, 2 Sep 2011 00:42:50 +0000 (00:42 +0000)]
Added Snow Leopard expected results to the test added in r94352.

* platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [chromium] Code cleanup FIXME in Chromium recognizer
commit-queue@webkit.org [Fri, 2 Sep 2011 00:32:00 +0000 (00:32 +0000)]
Source/WebCore:        [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
Fixed a bug noticed by a benjaminp while reviewing a different
ndonned patch where global positions were not being set correctly
on gesture-driven mouse wheel events.
* platform/chromium/GestureRecognizerChromium.cpp:
Changed static per-edge functions into methods and improves
encapsulation. No new functionality is present.
(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::addEdgeFunction):
(WebCore::GestureRecognizerChromium::isInClickTimeWindow):
(WebCore::GestureRecognizerChromium::isInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::appendClickGestureEvent):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::appendScrollGestureBegin):
(WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
(WebCore::GestureRecognizerChromium::appendScrollGestureUpdate):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::signature):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::scrollEnd):
(WebCore::GestureRecognizerChromium::noGesture):
(WebCore::GestureRecognizerChromium::click):
(WebCore::GestureRecognizerChromium::isClickOrScroll):
(WebCore::GestureRecognizerChromium::inScroll):
* platform/chromium/GestureRecognizerChromium.h:
(WebCore::GestureRecognizerChromium::setState):

Source/WebKit/chromium: [chromium] Code cleanup FIXME in Chromium recognizer
https://bugs.webkit.org/show_bug.cgi?id=67448

Updated GestureRecognizer unit tests for more encapsulated
gesture recognizer implementation.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-01
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(InspectableGestureRecognizerChromium::InspectableGestureRecognizerChromium):
(InspectableGestureRecognizerChromium::signature):
(InspectableGestureRecognizerChromium::edgeFunction):
(InspectableGestureRecognizerChromium::updateValues):
(InspectableGestureRecognizerChromium::addEdgeFunction):
(InspectableGestureRecognizerChromium::setStateTest):
(InspectableGestureRecognizerChromium::isInsideManhattanSquare):
(InspectableGestureRecognizerChromium::isInClickTimeWindow):
(InspectableGestureRecognizerChromium::stubEdgeFunction):
(GestureRecognizerTest::GestureRecognizerTest):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove LayoutRepainter to its own class
jchaffraix@webkit.org [Fri, 2 Sep 2011 00:29:23 +0000 (00:29 +0000)]
Move LayoutRepainter to its own class
https://bugs.webkit.org/show_bug.cgi?id=66255

Reviewed by Hajime Morita.

No new tests, code movement only.

* rendering/RenderObject.h: Moved code from here ...
* rendering/LayoutRepainter.cpp: Added.
(WebCore::LayoutRepainter::LayoutRepainter):
(WebCore::LayoutRepainter::repaintAfterLayout):
* rendering/LayoutRepainter.h: Added.
(WebCore::LayoutRepainter::checkForRepaint):
... to those 2 files.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Updated our build systems.

* rendering/RenderingAllInOne.cpp:
Needed for the Windows bot.

* rendering/RenderBlock.cpp:
* rendering/RenderDeprecatedFlexibleBox.cpp:
* rendering/RenderReplaced.cpp:
* rendering/RenderTable.cpp:
* rendering/svg/RenderSVGContainer.cpp:
* rendering/svg/RenderSVGForeignObject.cpp:
* rendering/svg/RenderSVGImage.cpp:
* rendering/svg/RenderSVGPath.cpp:
* rendering/svg/RenderSVGRoot.cpp:
* rendering/svg/RenderSVGText.cpp:
Added #include "LayoutRepainter".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Cleanup refactoring for https://bugs.webkit.org/show_bug.cgi?id=67160
adachan@apple.com [Fri, 2 Sep 2011 00:20:30 +0000 (00:20 +0000)]
Source/WebCore: Cleanup refactoring for https://bugs.webkit.org/show_bug.cgi?id=67160

Don't ifdef out the data member xslStyleSheets in MemoryCache::Statistics to cut down
the ifdefs in getWebCoreMemoryCacheStatistics() in WebKit2/WebProcess/WebProcess.cpp.

Reviewed by Darin Adler.

No new tests required.  Just small code refactoring.

* loader/cache/MemoryCache.h:

Source/WebKit2: Cut down the ifdefs in WebKit::getWebCoreMemoryCacheStatistics() now that
MemoryCache::Statistics always has the xslStyleSheets field.

Reviewed by Darin Adler.

* WebProcess/WebProcess.cpp:
(WebKit::getWebCoreMemoryCacheStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update leopard pixel baselines for svg tests
jamesr@google.com [Fri, 2 Sep 2011 00:20:04 +0000 (00:20 +0000)]
[chromium] Update leopard pixel baselines for svg tests

* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/pattern-skew-transformed-expected.png: Removed.
* platform/chromium-cg-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-rotate-expected.png: Added.
* platform/chromium-cg-mac/svg/custom/pattern-rotate-gaps-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login...
jchaffraix@webkit.org [Fri, 2 Sep 2011 00:18:17 +0000 (00:18 +0000)]
REGRESSION (r84327-r84329): CSS stylesheets fail to load on flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/css/stylesheet-enable-first-alternate-link.html
       fast/css/stylesheet-enable-first-alternate-on-load-link.html
       fast/css/stylesheet-enable-first-alternate-on-load-sheet.html
       fast/css/stylesheet-enable-second-alternate-link.html
       fast/css/stylesheet-enable-second-alternate-on-load-link.html
       fast/css/stylesheet-enable-second-alternate-on-load-sheet.html
       http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
       http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

This patch basically reverts 88479 and 84329 while keeping the tests
we developped during the implementation.

Following discussion, it looks like HTML5 will need to be amended.
In the meantime, we will just revert the changes so that we can come
up with a better change.

* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
Revert those method to their original content.

* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isDisabled):
(WebCore::HTMLLinkElement::isEnabledViaScript):
(WebCore::HTMLLinkElement::isAlternate):
Re-introduced the DisabledState enum.

* html/HTMLLinkElement.idl: |disabled| is Reflect'ed again.

LayoutTests:

* fast/css/stylesheet-enable-first-alternate-link-expected.txt: Added.
* fast/css/stylesheet-enable-first-alternate-link.html: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-link-expected.txt: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-link.html: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-sheet-expected.txt: Added.
* fast/css/stylesheet-enable-first-alternate-on-load-sheet.html: Added.
* fast/css/stylesheet-enable-second-alternate-link-expected.txt: Added.
* fast/css/stylesheet-enable-second-alternate-link.html: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-link-expected.txt: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-link.html: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-sheet-expected.txt: Added.
* fast/css/stylesheet-enable-second-alternate-on-load-sheet.html: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
* http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
* http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.
(onSheetLoaded):
(testWhenLoaded):
* http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.
(onSheetLoaded):
(testWhenLoaded):
* http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
* http/tests/css/resources/slow-loading-sheet.php: Added.
New tests developped for 65140. The baselines matches what FF and Opera are doing (IE does not support
link.sheet at the moment). Those failures are covered by bug 67436.

* fast/css/link-disabled-attr-expected.txt:
* fast/dom/HTMLLinkElement/disabled-attribute-expected.txt:
Fixed the baseline to match our behavior. The FAIL are our current deviation from the spec. Those
failures are covered by bug 67436.

* fast/dom/boolean-attribute-reflection-expected.txt:
* fast/dom/script-tests/boolean-attribute-reflection.js:
Re-added link.disabled as a reflected attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix layout test regressions from r94352.
mitz@apple.com [Fri, 2 Sep 2011 00:16:30 +0000 (00:16 +0000)]
Fix layout test regressions from r94352.

Reviewed by Anders Carlsson.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): In the custom font case (that is, when there is
not base NSFont) always get and use the best variation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert r94355 because it caused bunch of builds to break.
rniwa@webkit.org [Fri, 2 Sep 2011 00:11:33 +0000 (00:11 +0000)]
Revert r94355 because it caused bunch of builds to break.

Source/WebCore:

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update chromium baselines+expectations for fast/text/fallback-traits-fixup...
jamesr@google.com [Thu, 1 Sep 2011 23:57:45 +0000 (23:57 +0000)]
[chromium] Update chromium baselines+expectations for fast/text/fallback-traits-fixup.html

* platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/chromium-cg-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-linux/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/chromium-linux/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10063411> WebScriptObject.h declares an Objective-C method without...
mrowe@apple.com [Thu, 1 Sep 2011 23:53:38 +0000 (23:53 +0000)]
<rdar://problem/10063411> WebScriptObject.h declares an Objective-C method without a return type.

Rubber-stamped by Anders Carlsson.

* bridge/objc/WebScriptObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnzip initialization lists and constructors in JSCell hierarchy (4/7)
commit-queue@webkit.org [Thu, 1 Sep 2011 23:49:23 +0000 (23:49 +0000)]
Unzip initialization lists and constructors in JSCell hierarchy (4/7)
https://bugs.webkit.org/show_bug.cgi?id=67174

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-01
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::finishCreation):
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
(JSC::DebuggerActivation::create):
* debugger/DebuggerActivation.h:
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::createNoParameters):
(JSC::Arguments::Arguments):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::ArrayPrototype::finishCreation):
* runtime/ArrayPrototype.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
(JSC::BooleanObject::finishCreation):
* runtime/BooleanObject.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
(JSC::DateInstance::finishCreation):
* runtime/DateInstance.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::create):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
* runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::finishCreation):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
(JSC::JSByteArray::create):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):
* runtime/JSFunction.h:
(JSC::JSFunction::create):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::create):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
* runtime/JSONObject.h:
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::finishCreation):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):
* runtime/MathObject.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
(JSC::NumberObject::finishCreation):
* runtime/NumberObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::create):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::finishCreation):
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):
* runtime/RegExpObject.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
(JSC::StringObject::finishCreation):
* runtime/StringObject.h:

Source/JavaScriptGlue:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* UserObjectImp.cpp:
(UserObjectImp::UserObjectImp):
* UserObjectImp.h:
(UserObjectImp::create):

Source/WebCore:

No new tests.

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::create):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
* bridge/runtime_object.h:

Source/WebKit2:

Completed the fourth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding
enne@google.com [Thu, 1 Sep 2011 23:45:02 +0000 (23:45 +0000)]
[chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding
https://bugs.webkit.org/show_bug.cgi?id=67003

Reviewed by James Robinson.

ProgramBinding now takes an explicit cleanup call to destroy its
resources. This will assert if it is not called and will leak no
longer potentially dereference a dead pointer.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::borderProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
* platform/graphics/chromium/ProgramBinding.h:
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/dom/global-constructors.html and fast/dom/prototype-inheritance.html are way...
jamesr@google.com [Thu, 1 Sep 2011 23:41:12 +0000 (23:41 +0000)]
fast/dom/global-constructors.html and fast/dom/prototype-inheritance.html are way too fragile
https://bugs.webkit.org/show_bug.cgi?id=67452

Reviewed by Darin Adler.

Modifies these tests to not print PASS lines for all of the expected successes, since that means they have to be
updated whenever the set of properties on the global object is changed.  That is not the point of these tests
and it just causes excessive churn.

* fast/dom/global-constructors-expected.txt:
* fast/dom/global-constructors.html:
* fast/dom/prototype-inheritance-expected.txt:
* fast/dom/script-tests/prototype-inheritance.js:
* fast/js/resources/js-test-pre.js:
(description):
(descriptionQuiet):
(shouldBe):
(shouldBeTrueQuiet):
* platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/dom/global-constructors-expected.txt: Removed.
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/mac/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/qt/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/win/fast/dom/prototype-inheritance-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded Windows expected results to the test added in r94352.
mitz@apple.com [Thu, 1 Sep 2011 23:32:20 +0000 (23:32 +0000)]
Added Windows expected results to the test added in r94352.

* platform/win/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't include unnecessary headers in V8 bindings
paroga@webkit.org [Thu, 1 Sep 2011 23:29:06 +0000 (23:29 +0000)]
Don't include unnecessary headers in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=67435

Reviewed by Darin Adler.

When an IDL attribue is Conditonal the corresponding headers
need to be surrounded with the correct #if ENABLE().

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface...
commit-queue@webkit.org [Thu, 1 Sep 2011 23:25:04 +0000 (23:25 +0000)]
[Chromium, Skia] Add virtual to WebGraphicsContext3D to create a new GrGLInterface per context. Insert per-skia-GL-function callback to set correct GL context.
https://bugs.webkit.org/show_bug.cgi?id=67395

Patch by Brian Salomon <bsalomon@google.com> on 2011-09-01
Reviewed by Kenneth Russell.

* WebKit.gyp:
* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::grContext):
* src/WebGraphicsContext3D.cpp: Added.
(WebKit::WebGraphicsContext3D::createGrGLInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
psolanki@apple.com [Thu, 1 Sep 2011 23:22:03 +0000 (23:22 +0000)]
Rename CFNETWORK_DATA_ARRAY_CALLBACK to NETWORK_CFDATA_ARRAY_CALLBACK
https://bugs.webkit.org/show_bug.cgi?id=67348

Reviewed by Alexey Proskuryakov.

* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/cf/SubresourceLoaderCF.cpp:
* loader/mac/ResourceLoaderMac.mm:
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::buffer):
* platform/SharedBuffer.h:
* platform/cf/SharedBufferCF.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/mac/ResourceHandleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypeError should be thrown when a constructor is called as a normal function.
commit-queue@webkit.org [Thu, 1 Sep 2011 23:06:49 +0000 (23:06 +0000)]
TypeError should be thrown when a constructor is called as a normal function.
https://bugs.webkit.org/show_bug.cgi?id=67381

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Darin Adler.

The spec is here: http://www.w3.org/TR/WebIDL/#es-interface-call
For example, "Image()" or "XMLHttpRequest()" should throw TypeError.

Source/WebCore:

Test: fast/dom/call-a-constructor-as-a-function.html

* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback): Throws TypeError if args.IsConstructCall() is false.
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray): Ditto.
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback): Ditto.
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallback): Ditto.
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::v8HTMLAudioElementConstructorCallback): Ditto.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback): Ditto.
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback): Ditto.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback): Ditto.
* bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
(WebCore::V8WebKitCSSMatrix::constructorCallback): Ditto.
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
(WebCore::V8WebKitPoint::constructorCallback): Ditto.
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback): Ditto.
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Ditto.

LayoutTests:

* fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for JSC.
* fast/dom/call-a-constructor-as-a-function.html: Added. Checks if TypeError is thrown.
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt: Added. The test result for V8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] TextureManager overestimates the size of non-RGBA texture formats
enne@google.com [Thu, 1 Sep 2011 23:03:58 +0000 (23:03 +0000)]
[chromium] TextureManager overestimates the size of non-RGBA texture formats
https://bugs.webkit.org/show_bug.cgi?id=66917

Reviewed by James Robinson.

Use GraphicsContext3D to determine the size of a given texture format.
Also, make TextureManager use more GraphicsContext3D types.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::memoryUseBytes):
* platform/graphics/chromium/TextureManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing Event constructors to DOMWindow.idl
weinig@apple.com [Thu, 1 Sep 2011 22:48:46 +0000 (22:48 +0000)]
Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
Update results for new constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConsider Conditional attribute in CodeGenerator for methods
paroga@webkit.org [Thu, 1 Sep 2011 22:42:20 +0000 (22:42 +0000)]
Consider Conditional attribute in CodeGenerator for methods
https://bugs.webkit.org/show_bug.cgi?id=67409

Reviewed by Darin Adler.

This change adds appropriate #if ENABLE() lines for the preprocessor around the
generated functions depending on the Conditional attribute in the IDL file.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTre...
nduca@chromium.org [Thu, 1 Sep 2011 22:40:08 +0000 (22:40 +0000)]
[chromium] Introduce CCSingleThreadProxy in order to move LayerRenderer to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=66807

Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerRendererRecursive):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::isContextLost):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::capabilities):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::contextSupportsMapSub):
(WebCore::LayerRendererChromium::viewportSize):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::reserveTextures):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateAndLayout):
(WebCore::CCLayerTreeHost::preCommit):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::createCompositorThread):
(WebCore::CCLayerTreeHost::createLayerTreeHostContext3D):
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::layerRendererCapabilities):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::skiaContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::loseCompositorContext):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::layerRendererCapabilities):
(WebCore::CCLayerTreeHostImpl::present):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::updateLayers):
(WebCore::CCLayerTreeHostImpl::setViewport):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::layerRenderer):
(WebCore::CCLayerTreeHostImpl::rootLayer):
(WebCore::CCLayerTreeHostImpl::viewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
* platform/graphics/chromium/cc/CCMainThreadTask.h:
(WebCore::MainThreadTask4::create):
(WebCore::MainThreadTask4::MainThreadTask4):
(WebCore::MainThreadTask4::performTask):
(WebCore::MainThreadTask5::create):
(WebCore::MainThreadTask5::MainThreadTask5):
(WebCore::MainThreadTask5::performTask):
(WebCore::createMainThreadTask):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCProxy.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp.
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setImplThread):
* platform/graphics/chromium/cc/CCProxy.h: Added.
(WebCore::CCProxy::~CCProxy):
(WebCore::CCProxy::CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Added.
(WebCore::ScopedSetImplThread::ScopedSetImplThread):
(WebCore::ScopedSetImplThread::~ScopedSetImplThread):
(WebCore::CCSingleThreadProxy::create):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::~CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::isStarted):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):
(WebCore::CCSingleThreadProxy::loseCompositorContext):
(WebCore::CCSingleThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::skiaContext):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::compositeIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
* platform/graphics/chromium/cc/CCThreadProxy.cpp: Added.
(WebCore::CCThreadProxy::create):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::loseCompositorContext):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::skiaContext):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h.
* platform/graphics/chromium/cc/CCThreadTask.h:
(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::CCThreadTask5::performTask):
(WebCore::createCCThreadTask):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
* tests/CCThreadTaskTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
mitz@apple.com [Thu, 1 Sep 2011 22:32:43 +0000 (22:32 +0000)]
<rdar://problem/9528843> STIX glyphs not rendered on this stackoverflow answer
https://bugs.webkit.org/show_bug.cgi?id=67444

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/fallback-traits-fixup.html

After obtaining STIX Regular as a fallback font for some characters, getFontDataForCharacters()
proceeded to ask for a font from the same family having the desired traits and weight (because
wkGetFontInLanguageForRange() does not preserve traits and weight). The returned font was different
and happened to not contain the desired character.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): Only ask for a family member with the desired
traits and weight if the substitute font does not already have them, and only use the returned
member if it actually contains the desired character.

LayoutTests:

* fast/text/fallback-traits-fixup.html: Added.
* platform/mac/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/mac/fast/text/fallback-traits-fixup-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update more SVG baselines
jamesr@google.com [Thu, 1 Sep 2011 22:27:53 +0000 (22:27 +0000)]
[chromium] Update more SVG baselines

* platform/chromium-cg-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-cg-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/mac/svg/custom/non-scaling-stroke-expected.txt: Removed.
* platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Removed.
* platform/qt/svg/custom/non-scaling-stroke-expected.txt: Removed.
* platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Removed.
* svg/custom/non-scaling-stroke-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/non-scaling-stroke-expected.txt.
* svg/custom/pattern-skew-transformed-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/pattern-skew-transformed-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended...
commit-queue@webkit.org [Thu, 1 Sep 2011 22:16:23 +0000 (22:16 +0000)]
Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67414

Patch by Kentaro Hara <haraken@google.com> on 2011-09-01
Reviewed by Dimitri Glazkov.

Test: fast/dom/Window/custom-constructors.html
      fast/xsl/default-html.html

* bindings/v8/custom/V8XSLTProcessorCustom.cpp: Removed constructorCallback().
* xml/XSLTProcessor.idl: Added the 'Constructor' extended attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)
jamesr@google.com [Thu, 1 Sep 2011 22:02:42 +0000 (22:02 +0000)]
[chromium] Mark test that renders differently in 32 vs 64 bit mode as failing (WTF?)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update chromium baselines for 94338 for windows/mac
jamesr@google.com [Thu, 1 Sep 2011 21:40:59 +0000 (21:40 +0000)]
[chromium] Update chromium baselines for 94338 for windows/mac

* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
* platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-cg-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94348 268f45cc-cd09-0410-ab3c-d52691b4dbfc