11 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 16:35:10 +0000 (16:35 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        [GTK] requests download instead of displaying page

        Use soup facilities to append parameters to the content type, to
        make that more robust;

        * platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore...
ddkilzer@apple.com [Mon, 30 Mar 2009 16:24:19 +0000 (16:24 +0000)]
    <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig

        Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.

        * Configurations/Base.xcconfig: Moved Production definition of
        SECTORDER_FLAGS to here from Xcode project file.
        * Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS
        in Base.xcconfig to the empty string since it is not used for
        Debug and Release configurations.
        * WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fixes after recent FrameLoader changes
aroben@apple.com [Mon, 30 Mar 2009 15:58:58 +0000 (15:58 +0000)]
    Build fixes after recent FrameLoader changes

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle): Updated to match
        urlSelected's current signature. We pass true for the userGesture
        parameter, since the user must have selected this item from the
        context menu.

        * WebCoreSupport/WebFrameLoaderClient.cpp: Removed
        (WebFrameLoaderClient::createFrame): Changed to call
        FrameLoader::loadURLIntoChildFrame. This probably should have been
        done way back around r31281 when that function was added.

        * WebCoreSupport/WebFrameLoaderClient.h: Removed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix after recent Node.idl changes
aroben@apple.com [Mon, 30 Mar 2009 15:58:38 +0000 (15:58 +0000)]
    Windows build fix after recent Node.idl changes

        * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources
        of classes that derive from Node to rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Mar 2009 15:48:30 +0000 (15:48 +0000)]
2009-03-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        [GTK] Use GtkBinding system to handle key events in WebView

        Use GtkBinding system for key events in WebKitWebView. Allows the
        user to reconfigure the bindings and fixes a bunch of bugs along
        the way (we were not checking modifier keys in most actions).

        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:
        * webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Mon, 30 Mar 2009 15:22:37 +0000 (15:22 +0000)]
    Windows build fix

        * svg/graphics/SVGImage.cpp: Added a missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Mads Ager <ager@chromium.org>
dglazkov@chromium.org [Mon, 30 Mar 2009 14:49:39 +0000 (14:49 +0000)]
2009-03-30  Mads Ager  <ager@chromium.org>

        Reviewed by Darin Adler.

        Add frame accessor to Screen, Console, and BarInfo objects. Add type
        accessor to BarInfo objects.

        In the V8 JavaScript bindings, we need access to the frame and
        type for already created Screen, Console, and BarInfo objects in
        order to keep their wrappers alive across GCs.

        * page/BarInfo.cpp:
        (WebCore::BarInfo::frame): Added.
        (WebCore::BarInfo::type): Added.
        * page/BarInfo.h:
        * page/Console.cpp:
        (WebCore::Console::frame): Added.
        * page/Console.h:
        * page/Screen.cpp:
        (WebCore::Screen::frame): Added.
        * page/Screen.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDocument that setHtml/setContent loads only the html/data immediately, not external...
hausmann@webkit.org [Mon, 30 Mar 2009 09:25:34 +0000 (09:25 +0000)]
Document that setHtml/setContent loads only the html/data immediately, not external objects.
2009-03-30  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Document that setHtml/setContent loads only the html/data immediately, not external objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 30 Mar 2009 09:13:41 +0000 (09:13 +0000)]
2009-03-30  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk DRT build fix per changeset
        http://trac.webkit.org/changeset/42082. Not reviewed.

        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 02:49:37 +0000 (02:49 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Requested by Antti Koivisto.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added
        a better comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 30 Mar 2009 02:21:26 +0000 (02:21 +0000)]

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23445: Copying certain hidden text causes a crash

        Test: editing/pasteboard/copy-display-none.html

        * editing/markup.cpp:
        (WebCore::createMarkup): Added a check for the case where adjusting the start node moves
        the start of the selection past the end of the range entirely. If we try to iterate we'll
        never hit the end of the range and will probably crash iterating the rest of the document.


2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23445: Copying certain hidden text causes a crash

        * editing/pasteboard/copy-display-none-expected.txt: Added.
        * editing/pasteboard/copy-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 01:59:29 +0000 (01:59 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive

        I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
        but there is an Apple-internal website I was able to use to reproduce and fix.

        * loader/CachedResource.h: Made makePurgeable public.
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable
        so we can get its data if it hasn't yet been purged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 00:06:45 +0000 (00:06 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Fix build again.

        * loader/EmptyClients.h: Fix typo in name of FormState.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 23:53:48 +0000 (23:53 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Try to fix the release build.

        * history/CachedPage.cpp: Make include unconditional, not debug-only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUndo the previous build fix.
bolsinga@apple.com [Sun, 29 Mar 2009 23:51:29 +0000 (23:51 +0000)]
Undo the previous build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build break.
bolsinga@apple.com [Sun, 29 Mar 2009 23:44:18 +0000 (23:44 +0000)]
Fix build break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ChangeLog.
darin@apple.com [Sun, 29 Mar 2009 23:29:46 +0000 (23:29 +0000)]
Fix ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Dmitry Titov <dimich@chromium.org>
darin@apple.com [Sun, 29 Mar 2009 23:29:24 +0000 (23:29 +0000)]
2009-03-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        Fix Chromium build break.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Sun, 29 Mar 2009 23:26:45 +0000 (23:26 +0000)]
2009-03-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        Fix Chromium build break.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 18:09:52 +0000 (18:09 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Another attempt to fix the Qt build.

        * WebCore.pro: Added CheckedRadioButtons.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 18:00:36 +0000 (18:00 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Try to fix Qt build.

        * WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.

        * WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h.
        Removed unneeded call to detachChildren, which is called by FrameLoader
        right after this.
        (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame
        as other platforms do in the corresponding functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 17:31:51 +0000 (17:31 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        * DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix
        Qt building of DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 29 Mar 2009 17:15:41 +0000 (17:15 +0000)]

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 24921: remove include of HTMLFormElement.h from Document.h

        * GNUmakefile.am: Added CheckedRadioButtons source files.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.

        * dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp.
        Removed all the code except for CheckedRadioButtons, and moved that out to be
        a namespace-level class instead of a member of HTMLFormElement.

        * dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h.
        Removed all the code except for CheckedRadioButtons, and moved that out to be
        a namespace-level class instead of a member of HTMLFormElement.

        * dom/Document.h: Removed unneeded includes, including HTMLFormElement.h.
        Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons
        class to use a namespace-level class instead of a member of HTMLFormElement.

        * dom/Node.idl: Changed the type of parentElement from Node to Element for
        two reasons. 1) Node was incorrect, since parentElement returns an Element.
        2) The bindings won't compile any more unless they know parentElement's
        return value is an Element due to include changes.

        * html/HTMLFormElement.cpp: Moved definitions of the functions in the
        CheckedRadioButtons class to the new CheckedRadioButtons.cpp.

        * html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons
        class to the new CheckedRadioButtons.h.

        * html/HTMLInputElement.cpp:
        (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons
        class to use a namespace-level class instead of a member of HTMLFormElement.

        * page/Chrome.cpp:
        (WebCore::Chrome::createWindow): Tweaked formatting.

        * css/CSSGrammar.y: Added newly-needed include.
        * dom/Range.cpp: Ditto.
        * editing/BreakBlockquoteCommand.cpp: Ditto.
        * editing/CompositeEditCommand.cpp: Ditto.
        * editing/InsertLineBreakCommand.cpp: Ditto.
        * editing/ModifySelectionListLevel.cpp: Ditto.
        * editing/RemoveFormatCommand.cpp: Ditto.
        * editing/TextIterator.cpp: Ditto.
        * editing/VisiblePosition.cpp: Ditto.
        * loader/DocLoader.cpp: Ditto.
        * page/AccessibilityRenderObject.cpp: Ditto.
        * page/Page.cpp: Ditto.
        * rendering/RenderBlock.cpp: Ditto.
        * rendering/RenderLayer.cpp: Ditto.
        * rendering/RenderObject.h: Ditto.
        * storage/LocalStorageArea.cpp: Ditto.
        * storage/SessionStorageArea.cpp: Ditto.


2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        * Plugins/WebNullPluginView.mm: Added now-needed includes.
        * WebView/WebHTMLRepresentation.mm: Ditto.
        * WebView/WebHTMLView.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 17:14:02 +0000 (17:14 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        * fast/forms/targeted-frame-submission.html: Fixes from review comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
darin@apple.com [Sun, 29 Mar 2009 17:11:12 +0000 (17:11 +0000)]

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission

        Don't rely on delegate methods to guess whether a queued step starts a load or not, because
        script-triggered loads can't be detected that way. Instead have the steps themselves indicate
        whether or not a load was triggered.

        * DumpRenderTree/LayoutTestController.cpp:
        (queueLoadingScriptCallback): Added. Version for scripts that perform loads.
        (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads.
        (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and
        (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now.
        (LayoutTestController::queueForwardNavigation): Ditto.
        (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's
        (LayoutTestController::queueNonLoadingScript): Ditto.
        (LayoutTestController::queueReload): Moved here since it's platform-independent now.
        * DumpRenderTree/LayoutTestController.h: Ditto.

        * DumpRenderTree/WorkQueue.cpp:
        (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
        * DumpRenderTree/WorkQueue.h: Ditto.

        * DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item
        started a load. Removed unused getter functions. Made invoke functions private.
        Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (processWork): Use the new WorkQueue::processWork function to implement the new rule.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now
        platform-independent and in LayoutTestController.cpp.
        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (LoadItem::invoke): Return true.
        (ReloadItem::invoke): Ditto.
        (ScriptItem::invoke): Ditto.
        (BackForwardItem::invoke): Ditto.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement
        the new rule.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now
        platform-independent and in LayoutTestController.cpp.
        * DumpRenderTree/mac/WorkQueueItemMac.mm:
        (LoadItem::invoke): Return true.
        (ReloadItem::invoke): Ditto.
        (ScriptItem::invoke): Ditto.
        (BackForwardItem::invoke): Ditto.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement
        the new rule. Removed queue functions that are now platform-independent and in

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement
        the new rule.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now
        platform-independent and in LayoutTestController.cpp.
        * DumpRenderTree/win/WorkQueueItemWin.cpp:
        (LoadItem::invoke): Return false when we fail, true when we succeed.
        (ReloadItem::invoke): Ditto.
        (ScriptItem::invoke): Ditto.
        (BackForwardItem::invoke): Ditto.


2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission

        * fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads
        before moving on to the next test, using an onload attribute.

        * http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a
        script that can instead just be run immedidately.

        * http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until
        the subframe loads before moving on to the next test, using an onload attribute.
        * http/tests/navigation/onload-navigation-iframe.html: Ditto.

        * http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of
        queueScript for scripts that don't involve submitting a form. Use queueLoadingScript
        for scripts that do involve submitting a form.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 29 Mar 2009 15:37:49 +0000 (15:37 +0000)]

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6015407> attr parsing should allow only identifiers

        Test: fast/css/attr-parsing.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out
        identifiers that start with "-".
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test
        case works. This has the pleasant side effect of fixing a bug too.


2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6015407> attr parsing should allow only identifiers

        * fast/css/attr-parsing-expected.txt: Added.
        * fast/css/attr-parsing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 15:17:35 +0000 (15:17 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly

        Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.

        * fast/forms/range-thumb-height-percentage.html: Added.
        * platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
        * platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
        * platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
ap@webkit.org [Sun, 29 Mar 2009 09:45:05 +0000 (09:45 +0000)]
    <rdar://problem/6492712> Cross-origin redirects are not handled correctly.

        Forgot to save the file after applying changes for review comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sun, 29 Mar 2009 09:16:14 +0000 (09:16 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6492712> Cross-origin redirects are not handled correctly.

        Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html

        * platform/network/cf/ResourceHandleCFNet.cpp:
        Match Mac behavior more closely - we shouldn't rely on underlying library handling of
        synchronous requests.

        * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest):
        -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest
        delegate method for a redirect.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
        Match async behavior more closely.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAlways use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
kevino@webkit.org [Sun, 29 Mar 2009 05:27:39 +0000 (05:27 +0000)]
Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 00:16:17 +0000 (00:16 +0000)]
2009-03-28  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 24914: empty-string assertion crash when running storage tests

        * storage/Database.cpp:
        (WebCore::Database::performOpenAndVerify): Don't store empty version strings
        in the map, since empty strings are per-thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 28 Mar 2009 21:16:00 +0000 (21:16 +0000)]
2009-03-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        [GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function

        Set the right visibility to the WebKitSoupAuthDialog get_type

        * webkit/webkitsoupauthdialog.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Remove call to now private method.
kevino@webkit.org [Sat, 28 Mar 2009 20:17:32 +0000 (20:17 +0000)]
wx build fix. Remove call to now private method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Sat, 28 Mar 2009 18:43:32 +0000 (18:43 +0000)]
2009-03-28  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fixes for Chromium build.

        * bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
        * bindings/v8/custom/V8CustomEventListener.h: ditto.
        * dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 28 Mar 2009 16:59:40 +0000 (16:59 +0000)]
2009-03-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Not reviewed, correcting landing error.

        Custom bindings should be in v8/custom, not v8.

        * bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Sat, 28 Mar 2009 16:48:17 +0000 (16:48 +0000)]
2009-03-28  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        Add V8 custom bindings for DOMWindow.

        * bindings/v8/custom/V8DOMWindowCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Sat, 28 Mar 2009 16:24:00 +0000 (16:24 +0000)]
2009-03-28  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        Add V8 custom bindings for HTMLDocument.

        * bindings/v8/V8HTMLDocumentCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 28 Mar 2009 08:55:09 +0000 (08:55 +0000)]
2009-03-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        FrameLoader::loadURL and FrameLoader::detachChildren went private
        per changes in http://trac.webkit.org/changeset/42055. Follow
        Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
        loadURL and FrameLoader::detachParent for detachChildrem.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix non-AllInOneFile builds.
oliver@apple.com [Sat, 28 Mar 2009 05:11:55 +0000 (05:11 +0000)]
Fix non-AllInOneFile builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate text-content-type-with-binary-extension.html to use a .sitx file of random...
mrowe@apple.com [Sat, 28 Mar 2009 04:04:36 +0000 (04:04 +0000)]
Update text-content-type-with-binary-extension.html to use a .sitx file of random data rather
than a .m4a to ensure that WebKit doesn't handle the resource as a full-frame media element if the network
layer sniffs it as audio/mp4 rather than application/octet-stream.

Rubber-stamped by Dan Bernstein.

* http/tests/loading/resources/.htaccess:
* http/tests/loading/resources/binaryData.m4a: Removed.
* http/tests/loading/resources/binaryData.sitx: Added.
* http/tests/loading/text-content-type-with-binary-extension.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix syntax of Skipped file.
mrowe@apple.com [Sat, 28 Mar 2009 04:04:20 +0000 (04:04 +0000)]
Fix syntax of Skipped file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of Function.prototype.call
oliver@apple.com [Sat, 28 Mar 2009 03:50:39 +0000 (03:50 +0000)]
Improve performance of Function.prototype.call

Reviewed by Gavin Barraclough

Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.

When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip two plug-in tests that are failing due to <rdar://problem/6733642>.
mrowe@apple.com [Sat, 28 Mar 2009 02:54:59 +0000 (02:54 +0000)]
Skip two plug-in tests that are failing due to <rdar://problem/6733642>.

Rubber-stamped by Oliver Hunt.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand updated results for two SVG tests involving Geeza Pro.
mrowe@apple.com [Sat, 28 Mar 2009 02:46:39 +0000 (02:46 +0000)]
Land updated results for two SVG tests involving Geeza Pro.

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum.
* platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
* platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
* platform/mac-leopard/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.checksum.
* platform/mac-leopard/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
* platform/mac-leopard/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix two SVG test failures in 64-bit.
mrowe@apple.com [Sat, 28 Mar 2009 02:40:34 +0000 (02:40 +0000)]
Fix two SVG test failures in 64-bit.

Reviewed by Sam Weinig.

getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings.  In 32-bit this was
identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.

The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
but requires an exception be thrown when a negative value is passed.  This results in the JS bindings handling the
check for a negative value and lets the implementation treat the arguments purely as unsigned values.

* svg/SVGTextContentElement.cpp:
* svg/SVGTextContentElement.h:
* svg/SVGTextContentElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 28 Mar 2009 00:49:21 +0000 (00:49 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Get mailto code out of FrameLoader.

        * html/HTMLFormElement.cpp:
        (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto
        logic so HTMLFormElement::submit isn't full of ugly bits. This includes the
        part of the logic that involves transformeing the URL that was previously
        inside FrameLoader.
        (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and
        also release the data for slightly less refcount churn.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto,
        since HTMLFormElement now properly prepares both the URL and the form data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
mitz@apple.com [Sat, 28 Mar 2009 00:41:32 +0000 (00:41 +0000)]
    Reviewed by Mark Rowe.

        - fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup

        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
        (WebCore::createFontCustomPlatformData): Ditto.
        * platform/graphics/opentype/OpenTypeUtilities.cpp:
        (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to
        the size of an EOTPrefix.
        (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in
        the prefix.
        (WebCore::EOTHeader::appendBigEndianString): Changed the static
        appendBigEndianStringToEOTHeader() into this member function.
        (WebCore::EOTHeader::appendPaddingShort): Added.
        (WebCore::getEOTHeader): Changed to use EOTHeader.
        * platform/graphics/opentype/OpenTypeUtilities.h:
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
        (WebCore::createFontCustomPlatformData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 28 Mar 2009 00:06:57 +0000 (00:06 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 28 Mar 2009 00:06:38 +0000 (00:06 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        * Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 23:55:17 +0000 (23:55 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Made our mailto form submission tests work more reliably by using the new
        layoutTestController.waitForPolicyDelegate function.

        * fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate
        rather than relying on the form submission happening immediately.
        * fast/forms/mailto/advanced-get.html: Ditto.
        * fast/forms/mailto/advanced-put.html: Ditto.
        * fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
        * fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
        * fast/forms/mailto/get-multiple-items.html: Ditto.
        * fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
        * fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
        * fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
        * fast/forms/mailto/get-non-ascii.html: Ditto.
        * fast/forms/mailto/get-overwrite-query.html: Ditto.
        * fast/forms/mailto/post-append-query.html: Ditto.
        * fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
        * fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
        * fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
        * fast/forms/mailto/post-multiple-items.html: Ditto.
        * fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
        * fast/forms/mailto/post-text-plain.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 23:55:04 +0000 (23:55 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
        tests work.

        * DumpRenderTree/AccessibilityController.cpp:
        (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's
        no reason to use reinterpret_cast just to get from void* to a specific type.
        (getRootElementCallback): Ditto.
        * DumpRenderTree/AccessibilityUIElement.cpp:
        (toAXElement): Ditto.
        * DumpRenderTree/GCController.cpp:
        (collectCallback): Ditto.
        (collectOnAlternateThreadCallback): Ditto.
        (getJSObjectCountCallback): Ditto.
        * DumpRenderTree/LayoutTestController.cpp:
        (many functions):  Ditto.
        (waitForPolicyDelegateCallback): Added.
        (LayoutTestController::staticFunctions): Sorted functions by name.
        Added waitForPolicyDelegate.

        * DumpRenderTree/LayoutTestController.h: Sorted functions by name.
        Added waitForPolicyDelegate.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
        policy delegate.
        (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just
        before loading an empty page. This prevents extra policy delegate calls from being logged.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then
        tells the policy delegate to notify when done, then points the web view at the policy delegate.

        * DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.

        * DumpRenderTree/mac/PolicyDelegate.mm:
        (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        Added code to do notifyDone if controllerToNotifyDone is set.
        (-[PolicyDelegate setControllerToNotifyDone:]): Added.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
        policy delegate. Also moved the call to resetUndoManager in here.
        (runTest): Removed the call to resetUndoManager (see above). Added an additional call to
        resetWebViewToConsistentStateBeforeTesting to match the Mac code.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.

        * DumpRenderTree/win/PolicyDelegate.cpp:
        (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0.
        (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if
        m_controllerToNotifyDone is set.

        * DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 23:37:46 +0000 (23:37 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        To prepare for work on a form loading fix, remove some unused functions,
        consolidate some functions, and make many more functions private in

        * WebCore.base.exp: Remove some unused entry points, update another.

        * dom/Document.cpp:
        (WebCore::Document::detach): Clear m_frame directly instead of using
        * dom/Document.h: Ditto.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected): Consolidate the two functions
        of this name into a single function. Also changed the event argument
        to be PassRefPtr<Event>.
        (WebCore::FrameLoader::submitForm): Changed the event argument to
        be PassRefPtr<Event>.
        (WebCore::FrameLoader::scheduleLocationChange): Call completeURL
        explicitly so we can remove the version of changeLocation that does
        completeURL for us.
        (WebCore::FrameLoader::redirectionTimerFired): Ditto.
        (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem
        directly so we don't need a setProvisionalHistoryItem function.
        (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at
        m_quickRedirectComing directly so we don't need a isQuickRedirectComing
        (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto.
        (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the
        event argument to be PassRefPtr<Event>.
        (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData
        function here because this is the only caller. If we want to make the
        resulting function smaller we should refactor some other way. Also
        streamlined the user-chosen encoding logic, but did not change what it does.
        (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument
        to be PassRefPtr<Event>.
        (WebCore::FrameLoader::loadPostRequest): Ditto.
        (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from
        the didNotOpenURL function here, since this was the only caller.

        * loader/FrameLoader.h: Removed include of FormState.h and used a forward
        declaration instead. Removed unneeded forward declation of Element.
        Moved many functions into the private section, and removed some other
        unused or uneeded functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Xiaomei Ji <xji@chromium.org>
darin@chromium.org [Fri, 27 Mar 2009 23:23:09 +0000 (23:23 +0000)]
2009-03-27  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24303
        Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.

        Test: editing/selection/extend-selection.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::directionOfEnclosingBlock): Added
        (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly
        implemented for character and word granularity, all other granularities
        are treated as "forward".
        (WebCore::SelectionController::modifyExtendingForward): Renamed
        modifyExtendingRightForward() to this.
        (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly
        implemented for character and word granularity, all other granularities
        are treated as "backward".
        (WebCore::SelectionController::modifyExtendingBackward): Renamed
        modifyExtendingLeftBackward() to this.
        (WebCore::SelectionController::modify): Change to call either the
        left/right or backward/forward methods depending on the 'dir' argument
        for extends.
        * editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 27 Mar 2009 23:15:01 +0000 (23:15 +0000)]
2009-03-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
        prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6

        * Scripts/prepare-ChangeLog:
        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 John Abd-El-Malek <jam@google.com>
dimich@chromium.org [Fri, 27 Mar 2009 22:34:10 +0000 (22:34 +0000)]
2009-03-27  John Abd-El-Malek  <jam@google.com>

        Reviewed by Eric Seidel.

        Fix navigator.plugins.refresh(false) in Chromium.

        * plugins/chromium/PluginDataChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
timothy@apple.com [Fri, 27 Mar 2009 22:31:19 +0000 (22:31 +0000)]
    Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
        virtual to fix the broken layout tests from my last commit.

        Reviewed by Mark Rowe.

        * dom/Element.cpp:
        * dom/Element.h:
        * html/HTMLBodyElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
mrowe@apple.com [Fri, 27 Mar 2009 21:34:03 +0000 (21:34 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2)

Reviewed by Sam Weinig.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
items after each node is removed, leading to O(N^2) behaviour.  By inlining the batch removal in to setLength we can avoid
this gratuitous recalcuation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 27 Mar 2009 20:45:35 +0000 (20:45 +0000)]
2009-03-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        We don't support images for GtkCursors yet. We need a  placeholder to avoid crashes.
        I took crosshair to have a common behavior with firefox.

        [GTK] SVG - Crash on setting the cursor icon

        * platform/gtk/CursorGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove redundant attributes and functions from IDL files that have the
timothy@apple.com [Fri, 27 Mar 2009 20:36:21 +0000 (20:36 +0000)]
    Remove redundant attributes and functions from IDL files that have the
        same attributes and functions defined in the super class.

        Reviewed by Simon Fraser.

        * WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
        * bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
        * html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth
        and scrollHeight.
        * html/HTMLElement.idl: Remove blur and focus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Mac DumpRenderTree build.
timothy@apple.com [Fri, 27 Mar 2009 18:44:23 +0000 (18:44 +0000)]
Fix the Mac DumpRenderTree build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't include substitute data URLs in global history redirect chains
aroben@apple.com [Fri, 27 Mar 2009 18:37:16 +0000 (18:37 +0000)]
Don't include substitute data URLs in global history redirect chains


        Don't include substitute data URLs in global history redirect chains


        Reviewed by Darin Adler.

        This might be testable if:
          - support were added to DRT for providing substitute data on failed
          - support were added to DRT for dumping redirect chains

        I tried doing the above and was still unable to make a test.

        * loader/FrameLoader.cpp:
        Call updateGlobalHistoryRedirectLinks only if the load succeeded
        (i.e., there is no unreachableURL). Previous the FrameLoaderClient
        implementations were unconditionally calling
        updateGlobalHistoryRedirectLinks from within updateGlobalHistory.


        Don't include substitute data URLs in global history redirect chains


        Reviewed by Darin Adler.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory): Don't call
        updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now.
        Added an assertion to help catch cases where we might be adding a
        substitute data URL into a redirect chain.


        Don't include substitute data URLs in global history redirect chains


        Reviewed by Darin Adler.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::updateGlobalHistory): Don't call
        updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now.
        Added an assertion to help catch cases where we might be adding a
        substitute data URL into a redirect chain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 18:27:16 +0000 (18:27 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6541923> REGRESSION (r38629): Tab cycle in empty tab is broken

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 27 Mar 2009 18:07:41 +0000 (18:07 +0000)]
2009-03-27  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Chromium port did not render decorations for <input type="search">.
        This copies RenderThemeWin.*.

        * css/themeChromiumWin.css: Removed.
        * rendering/RenderThemeChromiumLinux.cpp:
        * rendering/RenderThemeChromiumLinux.h:
        * rendering/RenderThemeChromiumWin.cpp:
        * rendering/RenderThemeChromiumWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 27 Mar 2009 18:02:18 +0000 (18:02 +0000)]

2009-03-27  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser

        If an object has a self-painting layer, don't count it as part of a block's visual overflow.
        This fix has only been made for block-level children.   The inline-level case is still broken
        (and covered by an existing bug).

        Added fast/block/positioning/negative-rel-position.html

        * rendering/InlineFlowBox.cpp:
        * rendering/RenderBlock.cpp:


2009-03-27  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser

        Test case for relative positioning bug.

        * fast/block/positioning/negative-rel-position.html: Added.
        * platform/mac/fast/block/positioning/negative-rel-position-expected.checksum: Added.
        * platform/mac/fast/block/positioning/negative-rel-position-expected.png: Added.
        * platform/mac/fast/block/positioning/negative-rel-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Mar 2009 18:00:50 +0000 (18:00 +0000)]
2009-03-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed

        Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.

        I've filed <rdar://problem/6731022> against the Movies widget.

        * html/HTMLObjectElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 17:53:27 +0000 (17:53 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan and Anders Carlsson.

        <rdar://problem/5987442> Pasteboard not exposed to WebEditingDelegate for WebViewInsertActionPasted (needed for system services)

        Added SPI to tell which pasteboard is currently being inserted.
        I chose to put it on WebView to be forward-looking since we're migrating things
        from WebHTMLView to WebView in the future.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Add calls to _setInsertionPasteboard.
        (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]): Assert the pasteboard is nil.
        (-[WebViewPrivate finalize]): Ditto.
        (-[WebView _insertionPasteboard]): Return the pastebaord.
        (-[WebView _setInsertionPasteboard:]): Set the pasteboard.
        * WebView/WebViewInternal.h: Added _setInsertionPasteboard.
        * WebView/WebViewPrivate.h: Added _insertionPasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExpose new DOM methods as public Objective-C API.
timothy@apple.com [Fri, 27 Mar 2009 17:50:15 +0000 (17:50 +0000)]
Expose new DOM methods as public Objective-C API.


2009-03-25  Timothy Hatcher  <timothy@apple.com>

        Expose new DOM methods as public Objective-C API.

        <rdar://problem/5837350> Expose new DOM classes and methods
        as public API (match the additions to the JavaScript DOM)

        Reviewed by NOBODY (OOPS!).

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/PublicDOMInterfaces.h:


2009-03-25  Timothy Hatcher  <timothy@apple.com>

        Expose new DOM methods as public Objective-C API.

        <rdar://problem/5837350> Expose new DOM classes and methods
        as public API (match the additions to the JavaScript DOM)

        Reviewed by NOBODY (OOPS!).

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Zack Rusin <zack@kde.org>
hausmann@webkit.org [Fri, 27 Mar 2009 17:45:41 +0000 (17:45 +0000)]
2009-03-27  Zack Rusin <zack@kde.org>

        Reviewed by Simon Hausmann.


        Fix propagation of fill rules when rendering paths in the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Zack Rusin <zack@kde.org>
hausmann@webkit.org [Fri, 27 Mar 2009 17:40:45 +0000 (17:40 +0000)]
2009-03-27  Zack Rusin <zack@kde.org>

        Reviewed by Tor Arne Vestbø.


        Fix text field theming in the Qt build with the KDE 4 Oxygen
        style by adjusting the size vertically and horizontally to
        set padding on the element equal to the width of the style painted border.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Fri, 27 Mar 2009 16:23:01 +0000 (16:23 +0000)]
2009-03-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Bug 24884: Include strings.h for strcasecmp()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Fri, 27 Mar 2009 13:05:11 +0000 (13:05 +0000)]
2009-03-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Build fix for GNU mode RVCT compilation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Erik L. Bunce <elbunce@xendom.com>
hausmann@webkit.org [Fri, 27 Mar 2009 12:59:24 +0000 (12:59 +0000)]
2009-03-27  Erik L. Bunce  <elbunce@xendom.com>

        Reviewed by Simon Hausmann.


        Fixes an incorrect case in tst_qwebpage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Erik L. Bunce <elbunce@xendom.com>
hausmann@webkit.org [Fri, 27 Mar 2009 12:50:10 +0000 (12:50 +0000)]
2009-03-27  Erik L. Bunce  <elbunce@xendom.com>

        Reviewed by Simon Hausmann.


        Make text of the writing direction items more user friendly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Erik L. Bunce <elbunce@xendom.com>
hausmann@webkit.org [Fri, 27 Mar 2009 12:47:20 +0000 (12:47 +0000)]
2009-03-27  Erik L. Bunce  <elbunce@xendom.com>

        Reviewed by Simon Hausmann.


        Fixed the Qt 4.4 Mac build with netscape plugins enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Erik L. Bunce <elbunce@xendom.com>
hausmann@webkit.org [Fri, 27 Mar 2009 11:54:22 +0000 (11:54 +0000)]
2009-03-27  Erik L. Bunce  <elbunce@xendom.com>

        Reviewed by Simon Hausmann.


        Add new editing related QWebPage::WebActions
        * Clipboard: PasteAndMatchStyle
        * Formatting: RemoveFormat, ToggleStrikethrough, ToggleSubscript, and
        * List Editing: InsertUnorderedList, InsertOrderedList, Indent, Outdent
        * Paragraph Justification: AlignCenter, AlignJustified, AlignLeft, AlignRight

        Improved selection and editing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Hyatt.
eric@webkit.org [Fri, 27 Mar 2009 06:16:59 +0000 (06:16 +0000)]
    Reviewed by David Hyatt.

        Update fast/repaint/lines-with-layout-delta.html pixel results.
        Hyatt says it's a progression, blame him if it ain't.

        * platform/mac/fast/repaint/lines-with-layout-delta-expected.checksum:
        * platform/mac/fast/repaint/lines-with-layout-delta-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry and fix the Qt build.
mrowe@apple.com [Fri, 27 Mar 2009 05:19:07 +0000 (05:19 +0000)]
Try and fix the Qt build.

* platform/text/TextEncodingDetectorNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 27 Mar 2009 04:56:56 +0000 (04:56 +0000)]
2009-03-26  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        24874: HTMLMediaElement: 'duration' defaults to NaN, deal with it

        The 'duration' attribute is NaN when no media is available, so the
        media element should take care when comparing with duration().

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Don't compare with duration when
        it is NaN.
        (WebCore::HTMLMediaElement::endedPlayback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results for changes to Geeza Pro.
mrowe@apple.com [Fri, 27 Mar 2009 04:30:44 +0000 (04:30 +0000)]
Update layout test results for changes to Geeza Pro.

* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum.
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png.
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build.
mrowe@apple.com [Fri, 27 Mar 2009 03:21:56 +0000 (03:21 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Jungshik Shin <jshin@chromium.org>
cwzwarich@webkit.org [Fri, 27 Mar 2009 02:51:43 +0000 (02:51 +0000)]
2009-03-26  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Cameron Zwarich.

        1. Fix the crash in setHintEncoding
        2. Fix build failures on Tiger and Qt.
        UnusedParam.h was not included by TextEncodingDetector{None,ICU}.cpp
        in the patch landed in r42023
        for http://bugs.webkit.org/show_bug.cgi?id=16482

        * loader/TextResourceDecoder.h:
        * platform/text/TextEncodingDetectorICU.cpp:
        * platform/text/TextEncodingDetectorNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 27 Mar 2009 01:27:16 +0000 (01:27 +0000)]
2009-03-26  Simon Fraser  <simon.fraser@apple.com>

        Build fix when ACCELERATED_COMPOSITING is turned on.

        * rendering/RenderLayerBacking.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 27 Mar 2009 01:12:01 +0000 (01:12 +0000)]
2009-03-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt


        Change the terminology from "inner content layer" to "direct compositing"
        for cases where we can push an image directly over to the compositing system,
        without having to draw it.

        Clean up much of the code which looks at style to determine if this is possible,
        and fix some bugs when backgrounds change dynamically.

        * rendering/RenderLayerBacking.cpp:
        * rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No additional review, committing previously reviewed files for build fix...
eric@webkit.org [Fri, 27 Mar 2009 00:28:47 +0000 (00:28 +0000)]
    No additional review, committing previously reviewed files for build fix only.

        Add files I missed when commiting Jungshik's patch in r42022.

        * icu/unicode/ucsdet.h: Added.
        * platform/text/TextEncodingDetector.h: Added.
        * platform/text/TextEncodingDetectorICU.cpp: Added.
        * platform/text/TextEncodingDetectorNone.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Jungshik Shin <jshin@chromium.org>
eric@webkit.org [Fri, 27 Mar 2009 00:01:58 +0000 (00:01 +0000)]
2009-03-26  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add an encoding detector 'hook' to TextResourceDecoder.
         - add |usesEncodingDetector| to Settings. It's off by default.
         - add a new encoding source type |EncodingFromParent|
           to distinguish cases when the encoding is inherited from
           the parent frame from cases when it's actually auto-detected.
         - add TextEncodingDetector* to platform/text. Currently,
           the only implementation uses ICU. Stub is added for
           ports that do not use ICU and a build on Tiger. Mac OS
           Tiger comes with ICU 3.2 that does not support encoding detector.
         - add ucsdet.h to icu/unicode for ports using ICU.

        Layout tests will be added once bug 20534 is fixed and a WebPreference
        can be controlled in test_shell. With UsesEncodingDetector off, there
        is no change to test.


        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCore/GNUmakefile.am
        * WebCore/WebCore.pro
        * WebCore/WebCore.scons
        * WebCore/WebCoreSources.bkl
        * WebCore.base.exp
        * icu/unicode/ucsdet.h
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame
        (WebCore::TextResourceDecoder::checkForHeadCharset): ditto
        (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true.
        (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
        * loader/TextResourceDecoder.h:
        * page/Settings.cpp: add m_usesEncodingDetector
        * page/Settings.h:
        * platform/text/TextEncodingDetector.h: Added.
        * platform/text/TextEncodingDetectorICU.cpp: Added.
        * platform/text/TextEncodingDetectorNone.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 26 Mar 2009 23:50:00 +0000 (23:50 +0000)]
2009-03-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Removed code that casts EventListener down to derived classes
        without type checking. A crash could happen if you added event
        listeners with Objective-C and then manipulated the class with

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::mark): Removed all the casts
        and used the markIfNotNull function and mark functions on
        EventListener instead.
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::mark): Ditto.
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::mark): Ditto.
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::mark): Ditto.
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::mark): Ditto.
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::mark): Ditto.

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent): Used function,
        the new name for what used to be called listenerObj.
        (WebCore::JSAbstractEventListener::virtualIsInline): Renamed since
        this doesn't need to be virtual for callers who have a pointer to
        this class, not the base class.
        (WebCore::JSEventListener::function): Renamed from listenerObj.
        (WebCore::JSProtectedEventListener::function): Ditto.

        * bindings/js/JSEventListener.h: Removed unneeded forward class
        declarations. Made all virtual functions private since there's no
        need to call any of them on a particular derived class, only on
        EventListener. Explicitly declare JSEventListener::mark as virtual
        since it's now overriding a function in the EventListener base class.
        Made JSProtectedEventListener::m_globalObject protected so the
        JSLazyEventListener derived class can use it directly instead of using
        a virtual function to get the pointer.

        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::parseCode): Use m_globalObject instead
        of globalObject since the latter is a virtual function and there's no
        need to pay virtual function overhead.
        (WebCore::JSLazyEventListener::function): Renamed from listenerObj.

        * bindings/js/JSLazyEventListener.h: Moved forward declaration of the
        Node class here from JSEventListener.h.

        * bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded cast to
        JSEventListener when getting the script object from a listener.

        * dom/EventListener.h: Added virtual function and mark functions
        so we can extract the JavaScript function object or mark a JavaScript
        event listener in a type safe manner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Thu, 26 Mar 2009 23:25:18 +0000 (23:25 +0000)]
2009-03-26  Peter Kasting  <pkasting@google.com>

        Reviewed by Adele Peterson.

        Use CSS file instead of code to adjust search field styling.

        * css/themeWin.css:
        * rendering/RenderThemeWin.cpp:
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 26 Mar 2009 22:53:28 +0000 (22:53 +0000)]
2009-03-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Split JSLazyEventListener out into its own separate source file.
        We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
        so leave those in the same file with JSEventListener.

        * GNUmakefile.am: Added JSLazyEventListener.
        * WebCore.pro: Ditto.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part.
        Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since
        JSAbstractEventListener is not derived from JSCell.

        * bindings/js/JSEventListener.h: Removed the JSLazyEventListener part
        and the now-unneeded include of PlatformString.h.

        * bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp.
        Kept only the JSLazyEventListener part.
        (WebCore::eventParameterName): Made this have internal linkage by adding "static".
        Also moved the default case out of the switch statement so we will get a warning
        if we omit any cases in the future.

        * bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h.
        Kept only the JSLazyEventListener part.

        * bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the
        remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Thu, 26 Mar 2009 22:31:48 +0000 (22:31 +0000)]

2009-03-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Renamed JSUnprotectedEventListener to JSEventListener.
        And related renames.

        Soon Geoff will make all JavaScript event listeners use mark instead
        of protect, so there's no need to emphasize "unprotected".

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventListener.h:
        * bindings/js/JSMessagePortCustom.cpp:
        * bindings/js/JSWorkerContextCustom.cpp:
        * bindings/js/JSWorkerCustom.cpp:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        All just renaming.


2009-03-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        * Scripts/do-webcore-rename:Update for rename of JSUnprotectedEventListener to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Thu, 26 Mar 2009 22:21:26 +0000 (22:21 +0000)]

2009-03-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Renamed JSEventListener to JSProtectedEventListener.
        And related renames.

        Soon Geoff will make all JavaScript event listeners use mark instead
        of protect, and so this class will be be obsolete. We will rename
        JSUnrpotectedEventListener to JSEventListener in the next check-in,
        since that one will remain.

        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventListener.h:
        * bindings/js/JSNodeCustom.cpp:
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        All just renaming.


2009-03-26  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        * Scripts/do-webcore-rename: Update for rename of JSEventListener to
        JSProtectedEventListener. This includes all the related renames, but
        not that one because that one renames the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Copy testapi.js to $WebKitOutputDir on Windows
aroben@apple.com [Thu, 26 Mar 2009 21:28:09 +0000 (21:28 +0000)]
    Copy testapi.js to $WebKitOutputDir on Windows

        Part of Bug 24856: run-javascriptcore-tests should run testapi on

        This matches what Mac does, which will help once we enable running
        testapi from run-javascriptcore-tests on Windows.

        Reviewed by Steve Falkenburg.

        * JavaScriptCore.vcproj/testapi/testapi.vcproj: Copy testapi.js next
        to testapi.exe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 26 Mar 2009 20:39:48 +0000 (20:39 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Thu, 26 Mar 2009 20:35:57 +0000 (20:35 +0000)]
    Reviewed by Anders Carlsson.

        - fix <rdar://problem/6725042> BidiResolver::createBidiRunsForLine can
          create runs extending beyond the end

        No test because Safari does not use this version of
        createBidiRunsForLine() with the end iterator not pointing to the end
        of the text run.

        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::appendRun): Cap the end of the run at the end
        of the line and set the reachedEndOfLine flag. This mirrors the logic
        in the specialized version of appendRun() in bidi.cpp, which is why the
        problem did not show up in HTML. Also avoid creating empty runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes under...
aroben@apple.com [Thu, 26 Mar 2009 20:18:12 +0000 (20:18 +0000)]
    Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes under GuardMalloc)

        The previous limit was 60 seconds (or 10 minutes under GuardMalloc).
        There's no evidence that we need the limit to be this long, and having
        it be so long just makes timed-out tests take forever to complete.
        DRT's watchdog timer is 10 seconds, so still has time to fire before
        run-webkit-tests will cut it off.

        Reviewed by Simon Fraser.

        * Scripts/run-webkit-tests:
        (sub readFromDumpToolWithTimer): Reduced the limit to 15 seconds (or
        2.5 mintues under GuardMalloc).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make DRT's watchdog timer actually work on Windows
aroben@apple.com [Thu, 26 Mar 2009 20:10:32 +0000 (20:10 +0000)]
    Make DRT's watchdog timer actually work on Windows

        We were previously trying to use a CFRunLoopTimer for the watchdog
        timer on Windows. This doesn't work because we don't use a CFRunLoop
        on the main thread on Windows.

        This patch changes the watchdog timer on Windows be a normal Windows

        Reviewed by Simon Fraser.

        * DumpRenderTree/DumpRenderTree.h: Moved declaration of
        waitToDumpWatchdog from here...
        * DumpRenderTree/mac/DumpRenderTreeMac.h: ...to here.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (invalidateAnyPreviousWaitToDumpWatchdog): Added. This function
        cancels an existing watchdog timer.
        (dump): Call invalidateAnyPreviousWaitToDumpWatchdog. This will
        prevent watchdogs from previous tests firing during subsequent ones.
        This matches Mac's behavior.

        * DumpRenderTree/win/DumpRenderTreeWin.h: Added a declaration of

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (waitUntilDoneWatchdogFired): Converted this to be a Windows
        (LayoutTestController::setWaitToDump): Changed to use SetTimer instead
        of CFRunLoopAddTimer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 26 Mar 2009 18:48:26 +0000 (18:48 +0000)]
2009-03-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        - Fix <rdar://problem/6687055> and <rdar://problem/6713639>.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        Call NetscapePluginInstanceProxy::invalidateRect.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        Stop the request timer, set m_pluginView to nil.

        No need to set m_pluginView to nil here anymore, it's now done in cleanup().

        Assert that the plug-in view is not nil.

        Call setNeedsDisplayInRect here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 26 Mar 2009 18:34:03 +0000 (18:34 +0000)]
2009-03-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt


        Tests: compositing/overflow/ancestor-overflow.html

        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:
        New static method that returns a large rect that is used by the clipping

        * rendering/RenderLayerBacking.cpp:
        Use parentClipRects(), rather than calculateRects(), to compute the overflow
        rect that we'll use to create a masking layer for composited clipping.

        * rendering/RenderLayerCompositor.cpp:
        Use parentClipRects() to see whether there's a layer between us and our
        compositing ancestor which applies clipping.

        A layer which imposes clipping to its children doesn't have to be a stacking
        context; it might be a normal flow layer; in either case, we can rely on the
        hasCompositingDescendant() bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove SafariThemeConstants.h, which is now provided by WebKitSupportLibrary
aroben@apple.com [Thu, 26 Mar 2009 18:18:38 +0000 (18:18 +0000)]
    Remove SafariThemeConstants.h, which is now provided by WebKitSupportLibrary

        * win/include/SafariTheme: Removed.
        * win/include/SafariTheme/SafariThemeConstants.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago https://bugs.webkit.org/show_bug.cgi?id=24837
sfalken@apple.com [Thu, 26 Mar 2009 17:05:43 +0000 (17:05 +0000)]
        Escape key should dismiss select menu

        Reviewed by Adam Roben.

        * platform/win/PopupMenuWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Alexey Proskuryakov.
kevino@webkit.org [Thu, 26 Mar 2009 16:12:00 +0000 (16:12 +0000)]
Reviewed by Alexey Proskuryakov.

Make sure the script uses LF line endings even on Windows.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42006 268f45cc-cd09-0410-ab3c-d52691b4dbfc