bweinstein@apple.com [Thu, 30 Sep 2010 19:27:12 +0000 (19:27 +0000)]
The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
https://bugs.webkit.org/show_bug.cgi?id=46926
Reviewed by Adam Roben.
* BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows
Release Tests, and two bots running Windows Debug Tests, instead of four running both.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 30 Sep 2010 18:54:16 +0000 (18:54 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46923
Reviewed by Simon Fraser.
Make determineLogicalLeftPositionForChild block-flow-aware. Rewrite the function so that there aren't
completely separate LTR/RTL cases.
Added fast/blockflow/inline-direction-positioning.html
WebCore:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
LayoutTests:
* fast/blockflow/inline-direction-positioning.html: Added.
* platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
* platform/mac/fast/blockflow/inline-direction-positioning-expected.png: Added.
* platform/mac/fast/blockflow/inline-direction-positioning-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 18:50:55 +0000 (18:50 +0000)]
2010-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests should print results URLs
https://bugs.webkit.org/show_bug.cgi?id=46917
Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.
* Scripts/webkitpy/tool/commands/queries.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 30 Sep 2010 18:50:54 +0000 (18:50 +0000)]
Add additional checks to StringBuffer.
<rdar://problem/7756381>
Reviewed by Darin Adler.
* wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::resize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 30 Sep 2010 18:42:06 +0000 (18:42 +0000)]
Forward declare structs with 'struct' in the message headers
https://bugs.webkit.org/show_bug.cgi?id=46925
<rdar://problem/8497940>
Reviewed by Adam Roben.
* Scripts/webkit2/messages.py:
(struct_or_class): New function which given a type and a namespace returns the correct
forward declaration syntax (struct or class).
* Scripts/webkit2/messages_unittest.py:
Update expected results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Thu, 30 Sep 2010 18:32:42 +0000 (18:32 +0000)]
2010-09-30 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
[chromium] Fix clang error in KURLTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=46861
* tests/KURLTest.cpp:
(WTF::operator<<):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 18:28:18 +0000 (18:28 +0000)]
Fix color media queries on Windows
Fixes <http://webkit.org/b/42973> <rdar://problem/8234072> (color:8)
media query does not evaluate to true for 32bpp displays on Windows
Test: fast/media/color-does-not-include-alpha.html
Reviewed by Darin Adler.
WebCore:
* platform/win/PlatformScreenWin.cpp:
(WebCore::screenDepthPerComponent): Use screenDepth instead of trying
to interpret DEVMODE directly, since screenDepth knows how to correct
for video drivers that return 32 instead of 24.
LayoutTests:
Add test for color:8 media queries
* fast/media/color-does-not-include-alpha-expected.txt: Added.
* fast/media/color-does-not-include-alpha.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 18:27:53 +0000 (18:27 +0000)]
Make sure screen.colorDepth/screen.pixelDepth don't include the bits used for alpha
Fixes <http://webkit.org/b/42972> <rdar://problem/8234071>
screen.colorDepth and screen.pixelDepth return 32 on Windows, but
should return 24 (according to CSSOM View and Firefox)
Reviewed by Darin Adler.
WebCore:
* platform/win/PlatformScreenWin.cpp:
(WebCore::screenDepth): If Windows says there are 32 bits per pixel,
return 24 instead, as 32 includes the alpha component but this
function is supposed to ignore the alpha component.
LayoutTests:
Update screen.colorDepth/screen.pixelDepth test to not allow values
that contain bits for alpha
* fast/dom/Window/window-screen-properties-expected.txt: Updated
results.
* fast/dom/Window/window-screen-properties.html: Changed only to
expect 16 or 24.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 18:20:45 +0000 (18:20 +0000)]
2010-09-30 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559
This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.
This is covered by existing tests.
* editing/chromium/EditorChromium.cpp:
(WebCore::Editor::newGeneralClipboard):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::urlTitle):
(WebCore::ChromiumDataObject::setUrlTitle):
(WebCore::ChromiumDataObject::htmlBaseUrl):
(WebCore::ChromiumDataObject::setHtmlBaseUrl):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::setFilenames):
(WebCore::ChromiumDataObject::fileExtension):
(WebCore::ChromiumDataObject::setFileExtension):
(WebCore::ChromiumDataObject::fileContentFilename):
(WebCore::ChromiumDataObject::setFileContentFilename):
(WebCore::ChromiumDataObject::fileContent):
(WebCore::ChromiumDataObject::setFileContent):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::normalizeType):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::writeImageToDataObject):
(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeURL):
(WebCore::ClipboardChromium::writeRange):
(WebCore::ClipboardChromium::writePlainText):
* platform/chromium/ClipboardChromiumWin.cpp:
(WebCore::ClipboardChromium::validateFileName):
* platform/chromium/ClipboardMimeTypes.cpp:
* platform/chromium/ClipboardMimeTypes.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::getURL):
(WebCore::ReadableDataObject::getHTML):
* platform/chromium/WritableDataObject.cpp:
(WebCore::WritableDataObject::clearData):
(WebCore::WritableDataObject::setData):
(WebCore::WritableDataObject::setURL):
(WebCore::WritableDataObject::setHTML):
2010-09-30 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559
This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.
* public/WebDragData.h:
* src/WebDragData.cpp:
(WebKit::WebDragData::initialize):
(WebKit::WebDragData::url):
(WebKit::WebDragData::setURL):
(WebKit::WebDragData::urlTitle):
(WebKit::WebDragData::setURLTitle):
(WebKit::WebDragData::downloadMetadata):
(WebKit::WebDragData::setDownloadMetadata):
(WebKit::WebDragData::fileExtension):
(WebKit::WebDragData::setFileExtension):
(WebKit::WebDragData::hasFileNames):
(WebKit::WebDragData::fileNames):
(WebKit::WebDragData::setFileNames):
(WebKit::WebDragData::appendToFileNames):
(WebKit::WebDragData::plainText):
(WebKit::WebDragData::setPlainText):
(WebKit::WebDragData::htmlText):
(WebKit::WebDragData::setHTMLText):
(WebKit::WebDragData::htmlBaseURL):
(WebKit::WebDragData::setHTMLBaseURL):
(WebKit::WebDragData::fileContentFileName):
(WebKit::WebDragData::setFileContentFileName):
(WebKit::WebDragData::fileContent):
(WebKit::WebDragData::setFileContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 30 Sep 2010 18:12:45 +0000 (18:12 +0000)]
2010-09-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863
* src/WebGraphicsContext3DDefaultImpl.cpp: Make ShaderSourceMap as <ShaderID, ShaderSourceEntry*>, so map resizing will be efficient and we don't need to worry about pointer copying.
(WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
(WebKit::WebGraphicsContext3DDefaultImpl::compileShader):
(WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv):
(WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
(WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
(WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
(WebKit::WebGraphicsContext3DDefaultImpl::createShader):
(WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
* src/WebGraphicsContext3DDefaultImpl.h: Ditto.
(WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry):
2010-09-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863
* fast/canvas/webgl/glsl-conformance-expected.txt: Added.
* fast/canvas/webgl/glsl-conformance.html: Added.
* fast/canvas/webgl/resources/webgl-test-utils.js: Add a function to turn off console output.
(WebGLTestUtils.):
(WebGLTestUtils):
* fast/canvas/webgl/shaders: Added.
* fast/canvas/webgl/shaders/00_shaders.txt: Added.
* fast/canvas/webgl/shaders/implicit: Added.
* fast/canvas/webgl/shaders/implicit/00_shaders.txt: Added.
* fast/canvas/webgl/shaders/implicit/add_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_int_mat2.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_int_mat3.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_int_mat4.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_int_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_int_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_int_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/add_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/assign_int_to_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/assign_ivec2_to_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/assign_ivec3_to_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/assign_ivec4_to_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/construct_struct.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_mat2.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_mat3.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_mat4.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_int_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/divide_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/equal_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/equal_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/equal_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/equal_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/function_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/function_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/function_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/function_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/greater_than.vert: Added.
* fast/canvas/webgl/shaders/implicit/greater_than_equal.vert: Added.
* fast/canvas/webgl/shaders/implicit/less_than.vert: Added.
* fast/canvas/webgl/shaders/implicit/less_than_equal.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_mat2.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_mat3.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_mat4.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_int_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/multiply_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/not_equal_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/not_equal_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/not_equal_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/not_equal_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_mat2.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_mat3.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_mat4.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_int_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/subtract_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/implicit/ternary_int_float.vert: Added.
* fast/canvas/webgl/shaders/implicit/ternary_ivec2_vec2.vert: Added.
* fast/canvas/webgl/shaders/implicit/ternary_ivec3_vec3.vert: Added.
* fast/canvas/webgl/shaders/implicit/ternary_ivec4_vec4.vert: Added.
* fast/canvas/webgl/shaders/reserved: Added.
* fast/canvas/webgl/shaders/reserved/00_shaders.txt: Added.
* fast/canvas/webgl/shaders/reserved/_webgl_field.vert: Added.
* fast/canvas/webgl/shaders/reserved/_webgl_function.vert: Added.
* fast/canvas/webgl/shaders/reserved/_webgl_struct.vert: Added.
* fast/canvas/webgl/shaders/reserved/_webgl_variable.vert: Added.
* fast/canvas/webgl/shaders/reserved/webgl_field.vert: Added.
* fast/canvas/webgl/shaders/reserved/webgl_function.vert: Added.
* fast/canvas/webgl/shaders/reserved/webgl_struct.vert: Added.
* fast/canvas/webgl/shaders/reserved/webgl_variable.vert: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 18:04:26 +0000 (18:04 +0000)]
Add some tests to the Windows Skipped list
These all have bugs filed about them.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Thu, 30 Sep 2010 17:59:17 +0000 (17:59 +0000)]
Fixed chrome build issue in DrawingBuffer.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Thu, 30 Sep 2010 17:57:43 +0000 (17:57 +0000)]
2010-09-30 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] WebIDBDatabase and WebIDBObjectStore are missing methods called from Chromium land.
https://bugs.webkit.org/show_bug.cgi?id=46922
The missing functions were removed in r68795.
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
(WebKit::WebIDBDatabase::removeObjectStore):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
(WebKit::WebIDBObjectStore::removeIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Thu, 30 Sep 2010 17:43:18 +0000 (17:43 +0000)]
2010-09-30 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Make 2D accelerated canvas rendering build on Mac
https://bugs.webkit.org/show_bug.cgi?id=46007
Add accelerated 2D rendering files to Mac build, fix build errors,
add ifdefs to compile only when the ACCELERATED_2D_CANVAS flag is
enabled, and add a skeleton of the mac specific file so it builds.
DrawingBufferMac.mm, the Mac specific file does nothing right now
other than initialize and create a layer. The rest will be added
when I do the actual implementation.
The most significant change was to SharedGraphicsContext3D, which
had a static local OwnPtr in one of the methods. This was causing
the exit time destructor warning. Getting rid of the OwnPtr fixed
the problem. Since the pointer that was being wrapped was to a
static object that would never get destroyed, the OwnPtr was not
necessary.
I also added the ACCELERATED_2D_CANVAS flag to build-webkit
and FeatureDefines.xcconfig for WebCore, WebKit and JavaScriptCore.
But right now the flag is off by default.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 30 Sep 2010 17:36:33 +0000 (17:36 +0000)]
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
* src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
(WebKit::WebGraphicsContext3DDefaultImpl::initialize):
(WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
(WebKit::WebGraphicsContext3DDefaultImpl::getPlatformTextureId):
(WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture):
(WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
(WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D):
(WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
(WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
* src/WebGraphicsContext3DDefaultImpl.h:
2010-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849
Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.
Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedCompositingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::scheduleComposite):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 30 Sep 2010 17:35:58 +0000 (17:35 +0000)]
[wx] Fix typo in build script.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 30 Sep 2010 17:35:10 +0000 (17:35 +0000)]
[wx] wxMSW build fix. Make sure we copy the compiler flags and remove exception handling from
the copy so as not to alter global settings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 17:23:33 +0000 (17:23 +0000)]
Make Windows match the Mac fallback font for the hyphen character in two tests
Fixes <http://webkit.org/b/46909> <rdar://problem/8497214> REGRESSION
(r68551): fast/text/midword-break-after-breakable-char.html and
fast/text/basic/014.html are failing on Windows
Rubber-stamped by Dan Bernstein.
* fast/text/basic/014.html:
* fast/text/midword-break-after-breakable-char.html:
Added a little @font-face magic to force the font for the hyphen
character.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 17:21:18 +0000 (17:21 +0000)]
2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902
Adding layout tests for feComposite dynamic changes.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in2-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k1-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k2-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k3-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k4-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-operator-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in2-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k1-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k2-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k3-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k4-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-operator-prop.js: Added.
(executeTest):
2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902
Tests: svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::svgAttributeChanged):
* svg/SVGFECompositeElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 30 Sep 2010 17:16:32 +0000 (17:16 +0000)]
Add printing SPI allowing full control over shrink-to-fit
https://bugs.webkit.org/show_bug.cgi?id=46877
Reviewed by John Sullivan.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 30 Sep 2010 16:55:46 +0000 (16:55 +0000)]
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
A bit of cleanup + use setVersion transactions for all of our work.
* storage/indexeddb/database-basics.html:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/transaction-basics.html:
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
Switch the rest of IndexedDB to use transactions.
Implement most of setVersion.
Add IDBTransactions to IDBAny, IDBCursor, IDBRequest, etc.
Switch to using the standard cross thread task stuff.
Make everything threadsafe so it works with cross thread copy
(will be useful in the future).
Fix some subtle bugs in transactions.
Various bits of clean up (when I couldn't resist).
* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::LocalContext::LocalContext):
(WebCore::LocalContext::~LocalContext):
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h:
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* platform/CrossThreadCopier.cpp:
* storage/IDBAny.cpp:
(WebCore::IDBAny::idbFactory):
(WebCore::IDBAny::idbTransaction):
(WebCore::IDBAny::set):
* storage/IDBAny.h:
* storage/IDBCallbacks.h:
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::remove):
* storage/IDBCursor.h:
(WebCore::IDBCursor::create):
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::updateInternal):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::remove):
(WebCore::IDBCursorBackendImpl::removeInternal):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setSetVersionTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::removeObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
* storage/IDBDatabase.h:
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::close):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openObjectCursor):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::getObject):
(WebCore::IDBIndex::get):
* storage/IDBIndex.h:
(WebCore::IDBIndex::create):
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openObjectCursor):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getObject):
(WebCore::IDBIndexBackendImpl::get):
* storage/IDBIndexBackendImpl.h:
* storage/IDBIndexBackendInterface.h:
* storage/IDBKey.cpp:
(WebCore::IDBKey::IDBKey):
* storage/IDBKey.h:
* storage/IDBKeyRange.h:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::remove):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::removeIndex):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.idl:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::remove):
(WebCore::IDBObjectStoreBackendImpl::removeInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::removeIndex):
(WebCore::IDBObjectStoreBackendImpl::removeIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBObjectStoreBackendInterface.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::timerFired):
* storage/IDBRequest.h:
(WebCore::IDBRequest::create):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
(WebCore::IDBTransactionBackendImpl::run):
(WebCore::IDBTransactionBackendImpl::start):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::timerFired):
* storage/IDBTransactionBackendImpl.h:
2010-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823
Plumbing.
* public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccess):
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
(WebKit::WebIDBDatabase::removeObjectStore):
(WebKit::WebIDBDatabase::close):
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::openObjectCursor):
(WebKit::WebIDBIndex::openCursor):
(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::get):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::get):
(WebKit::WebIDBObjectStore::put):
(WebKit::WebIDBObjectStore::remove):
(WebKit::WebIDBObjectStore::createIndex):
(WebKit::WebIDBObjectStore::removeIndex):
(WebKit::WebIDBObjectStore::openCursor):
* public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::id):
(WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
* src/IDBCallbacksProxy.cpp:
(WebCore::IDBCallbacksProxy::onSuccess):
* src/IDBCallbacksProxy.h:
* src/IDBDatabaseProxy.cpp:
(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::removeObjectStore):
(WebCore::IDBDatabaseProxy::close):
* src/IDBDatabaseProxy.h:
* src/IDBIndexBackendProxy.cpp:
(WebCore::IDBIndexBackendProxy::openObjectCursor):
(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::getObject):
(WebCore::IDBIndexBackendProxy::get):
* src/IDBIndexBackendProxy.h:
* src/IDBObjectStoreProxy.cpp:
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::remove):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::removeIndex):
(WebCore::IDBObjectStoreProxy::openCursor):
* src/IDBObjectStoreProxy.h:
* src/IDBTransactionBackendProxy.cpp:
(WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
* src/WebIDBCallbacksImpl.cpp:
(WebCore::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h:
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit::WebIDBDatabaseImpl::removeObjectStore):
(WebKit::WebIDBDatabaseImpl::close):
* src/WebIDBDatabaseImpl.h:
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::openCursor):
(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::get):
* src/WebIDBIndexImpl.h:
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::put):
(WebKit::WebIDBObjectStoreImpl::remove):
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit::WebIDBObjectStoreImpl::removeIndex):
(WebKit::WebIDBObjectStoreImpl::openCursor):
* src/WebIDBObjectStoreImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 16:46:05 +0000 (16:46 +0000)]
Skip a crashing test on Windows
* platform/win/Skipped: Skip
fast/frames/iframe-reparenting-adopt-node.html. There's already a bug
filed about the issue.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 16:40:27 +0000 (16:40 +0000)]
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
Windows
* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): Stop ourselves normally (including cleaning up log
files) when the delegate tells us to stop processing work.
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate.__init__): Moved code here from
RaisingDelegate.__init__.
(LoggingDelegate.expeced_callbacks): Added the stop_work_queue
callback.
(LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
(RaisingDelegate.__init__): Removed code that LoggingDelegate takes
care of for us now.
(QueueEngineTest.test_trivial): Make sure we got the expected stop
message.
(QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
remove the callbacks that are related to processing a single work
item, rather than removing all callbacks after a certain point, as
there are now more callbacks we expect to receive at the end.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 16:39:52 +0000 (16:39 +0000)]
Fix path -> URL conversion on Cygwin
Reviewed by Adam Barth.
Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Thu, 30 Sep 2010 16:31:42 +0000 (16:31 +0000)]
2010-09-30 William Siegrist <wsiegrist@apple.com>
Fix syntax error in r68744.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Thu, 30 Sep 2010 16:30:28 +0000 (16:30 +0000)]
2010-09-30 William Siegrist <wsiegrist@apple.com>
Set cache values for master.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 16:16:25 +0000 (16:16 +0000)]
Skip a test that fails on Windows due to lack of SSL support
* platform/win/Skipped: Added
http/tests/navigation/ping-cross-origin-from-https.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Thu, 30 Sep 2010 16:11:16 +0000 (16:11 +0000)]
Original patch by Zalan Bujtas.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-09-30
Reviewed by Antti Koivisto.
The m_readBuffer might be smaller than the incoming message size and
thus result in memory corruption. Do a similar fix as the win port,
resizing the m_readBuffer to have room for the message.
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 30 Sep 2010 15:45:41 +0000 (15:45 +0000)]
2010-09-30 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Martin Robinson.
[Gtk] build still broken since r68521
https://bugs.webkit.org/show_bug.cgi?id=46795
makevalues.pl and makeprop.pl generate 3 files in one run.
Double or triple target is incorrect, because on a multicore
machine make processes targets in parallel.
Setting a->b->c dependencies for 3 generated files guarantees
that make doesn't execute the recipe of the rule more than one.
* GNUmakefile.am: Dependencies and missing headers added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 15:39:51 +0000 (15:39 +0000)]
Rebaseline fast/layers/video-layer.html on Windows
Fixes <http://webkit.org/b/46903> <rdar://problem/8496933> REGRESSION
(r67251): fast/layers/video-layer.html failing on Windows
* platform/win/fast/layers/video-layer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 15:18:55 +0000 (15:18 +0000)]
Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can be called more than once
The NPP_SetWindow call made when the plugin is torn down was confusing
us, and was causing us to spew an error into the next test.
Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
(r68520): plugins/access-after-page-destroyed.html failing on Windows
Reviewed by Anders Carlsson.
* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
(WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
Initialize member.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
this isn't the first time this is called.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 30 Sep 2010 14:55:30 +0000 (14:55 +0000)]
Rebaseline Windows results for recent-ish changes
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:
* platform/win/html5lib/runner-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 30 Sep 2010 13:50:52 +0000 (13:50 +0000)]
Fixup for the previous commit that accidently only had ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 30 Sep 2010 13:44:50 +0000 (13:44 +0000)]
2010-09-30 Andrey Kosyakov <caseq@chromium.org>
Unreviewed build fix (marked ResourceRawHeaders.h as private).
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 30 Sep 2010 12:53:28 +0000 (12:53 +0000)]
2010-09-29 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display headers actually used by network stack in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=46092
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::updateResponse):
* platform/network/ResourceRawHeaders.h: Added.
* platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting.
(WebCore::ResourceRequestBase::reportRawHeaders):
(WebCore::ResourceRequestBase::setReportRawHeaders):
(WebCore::ResourceRequestBase::ResourceRequestBase):
* platform/network/ResourceResponseBase.cpp: Added support for raw headers.
(WebCore::ResourceResponseBase::resourceRawHeaders):
(WebCore::ResourceResponseBase::setResourceRawHeaders):
* platform/network/ResourceResponseBase.h:
2010-09-29 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: display headers actually used by network stack in Resources tab
Added plumbing for raw headers flag and response field between chromium and WebCore.
https://bugs.webkit.org/show_bug.cgi?id=46092
* WebKit.gyp:
* public/WebResourceRawHeaders.h: Added.
* public/WebURLRequest.h:
* public/WebURLResponse.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::willSendRequest):
* src/WebResourceRawHeaders.cpp: Added.
(WebKit::WebResourceRawHeaders::WebResourceRawHeaders):
(WebKit::WebResourceRawHeaders::~WebResourceRawHeaders):
(WebKit::WebResourceRawHeaders::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>):
(WebKit::addHeader):
(WebKit::WebResourceRawHeaders::addRequestHeader):
(WebKit::WebResourceRawHeaders::addResponseHeader):
* src/WebURLRequest.cpp:
(WebKit::WebURLRequest::setReportRawHeaders):
(WebKit::WebURLRequest::reportRawHeaders):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponse::resourceRawHeaders):
(WebKit::WebURLResponse::setResourceRawHeaders):
* src/WebURLResponsePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 30 Sep 2010 12:47:55 +0000 (12:47 +0000)]
2010-09-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Unbreak build
Add missing <wtf/text/CString.h> include.
* WebCoreSupport/InspectorServerQt.cpp:
2010-09-30 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Unbreak build
Add missing <wtf/text/CString.h> include.
* loader/PingLoader.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 30 Sep 2010 12:45:49 +0000 (12:45 +0000)]
2010-09-29 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: assign the resource loading finish time which was obtained from the network stack
as the end time for the corresponding event in Timeline.
See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664
https://bugs.webkit.org/show_bug.cgi?id=46789
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didFinishLoading):
(WebCore::InspectorController::didFailLoading):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
* inspector/InspectorTimelineAgent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 30 Sep 2010 12:42:55 +0000 (12:42 +0000)]
2010-09-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: implement sorting by timeline in network panel + filtering.
https://bugs.webkit.org/show_bug.cgi?id=45657
A number of drive-by fixes, sorting by timeline added,
0-based timeline for duration added, filters added,
more love for detailed view + nice headers.
* English.lproj/localizedStrings.js:
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.markColumnAsSortedBy):
(WebInspector.DataGrid.prototype.headerTableHeader):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype.get statusBarItems):
(WebInspector.NetworkPanel.prototype._createTable):
(WebInspector.NetworkPanel.prototype._makeHeaderInnerHTML):
(WebInspector.NetworkPanel.prototype._createSortingFunctions):
(WebInspector.NetworkPanel.prototype._sortByTimeline):
(WebInspector.NetworkPanel.prototype._sortItems):
(WebInspector.NetworkPanel.prototype._createFilterPanel):
(WebInspector.NetworkPanel.prototype._showCategory):
(WebInspector.NetworkPanel.prototype._hideCategory):
(WebInspector.NetworkPanel.prototype._updateFilter):
(WebInspector.NetworkPanel.prototype._filter):
(WebInspector.NetworkPanel.prototype._updateDividersIfNeeded):
(WebInspector.NetworkPanel.prototype.reset):
(WebInspector.NetworkPanel.prototype._setLargerResources):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype._createDivInTD):
(WebInspector.NetworkDataGridNode.prototype._refreshURLCell):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._appendSubtitle):
(WebInspector.NetworkDataGridNode.SizeComparator):
(WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel):
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
* inspector/front-end/inspector.css:
(.data-grid th.sort-ascending > div::after):
(.data-grid th.sort-descending > div::after):
(.status-bar-items):
* inspector/front-end/networkPanel.css:
(.network.panel .data-grid td):
(.network.panel .data-grid th):
(.network.panel .data-grid.small th):
(.network.panel .data-grid .data-container):
(.network.panel .data-grid.small .data-container):
(.network.panel .data-grid select):
(.network.panel .data-grid td.time-column):
(.network-cell-subtitle):
(.network-header-subtitle):
(.network-event-divider):
(.network.panel .network-timeline-grid.small .network-event-divider):
(.network.panel .resources-dividers-label-bar):
(.network.panel .network-timeline-grid.small .resources-dividers-label-bar):
(.network.panel .resources-divider-label):
(.network.panel .resources-dividers-label-bar .resources-divider):
(.network.panel .network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
(.network.panel .resources-divider.first .resources-divider-label):
(.network.panel .resources-dividers-label-bar .resources-divider.first):
(#network-filter):
(.data-grid table.data tr.revealed.network-category-websockets, .data-grid table.data tr.revealed.network-category-other):
(.data-grid.filter-all table.data tr.revealed.network-category-other, .data-grid.filter-other table.data tr.revealed.network-category-other):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 30 Sep 2010 12:29:03 +0000 (12:29 +0000)]
[Qt] Ensure we always report a valid size for the video
Reviewed by Simon Hausmann.
Some QtMultimedia-backends require a paint before even giving us
a size, so we start out by using the default video size, and then
update it once QtMultimedia starts feeding us valid sizes.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::naturalSize):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 30 Sep 2010 12:04:33 +0000 (12:04 +0000)]
Correct reviewer, Andreas was faster!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 30 Sep 2010 12:03:13 +0000 (12:03 +0000)]
2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
RenderSVGTextPath lacks isSVGTextPath() method
https://bugs.webkit.org/show_bug.cgi?id=46888
Make RenderSVGTextPath objects easily detectable, using a isSVGTextPath() method, like all other SVG renderers have.
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGTextPath): Return false.
* rendering/RenderSVGTextPath.h: Changed indentation of whole file.
(WebCore::RenderSVGTextPath::isSVGTextPath): Return true.
(WebCore::RenderSVGTextPath::renderName):
(WebCore::toRenderSVGTextPath): Add helper casting methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 30 Sep 2010 12:00:26 +0000 (12:00 +0000)]
[Qt] Ensure that the media player backend does not leave any resources around
Reviewed by Simon Hausmann.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 30 Sep 2010 11:51:47 +0000 (11:51 +0000)]
2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
AffineTransform should expose methods calculating the x/y scale factors
https://bugs.webkit.org/show_bug.cgi?id=46887
Expose methods calculating the x/y scale factors for an AffineTransform.
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::affineTransformDecompose): Move xScale / yScale calculations in their own functions.
(WebCore::AffineTransform::xScale):
(WebCore::AffineTransform::yScale):
* platform/graphics/transforms/AffineTransform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 30 Sep 2010 11:50:51 +0000 (11:50 +0000)]
Minor cleanup of MediaPlayerPrivateQt
Reviewed by Simon Hausmann.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::currentTime):
(WebCore::MediaPlayerPrivateQt::positionChanged):
(WebCore::MediaPlayerPrivateQt::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 11:44:52 +0000 (11:44 +0000)]
2010-09-30 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The case-insensitivity backreference checking isn't working with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46882
Add ignorecase checking to the Interpreter::tryConsumeBackReference() function.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::tryConsumeBackReference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 10:29:34 +0000 (10:29 +0000)]
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[BREWMP] Leave initializeRandomNumberGenerator empty.
https://bugs.webkit.org/show_bug.cgi?id=46851
On Brew MP, AEECLSID_RANDOM initializes itself.
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Thu, 30 Sep 2010 09:36:08 +0000 (09:36 +0000)]
2010-09-30 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Mark unused parameters as such.
https://bugs.webkit.org/show_bug.cgi?id=46880
* inspector/InspectorDOMAgent.cpp:
* page/Geolocation.cpp:
(WebCore::Geolocation::clearWatch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 30 Sep 2010 09:26:10 +0000 (09:26 +0000)]
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch upload warns that I'm using Xcode when I'm not
https://bugs.webkit.org/show_bug.cgi?id=46869
String.find returns -1 when not found, so switched to "in".
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/common/system/user_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 30 Sep 2010 09:15:22 +0000 (09:15 +0000)]
2010-09-29 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract Inspector Instrumentation API as a class.
https://bugs.webkit.org/show_bug.cgi?id=46614
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::notifyChildInserted):
(WebCore::dispatchChildRemovalEvents):
* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::removeAttribute):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp: Added.
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::characterDataModifiedImpl):
(WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
* inspector/InspectorInstrumentation.h: Added.
(WebCore::InspectorInstrumentation::frontendCreated):
(WebCore::InspectorInstrumentation::frontendDeleted):
(WebCore::InspectorInstrumentation::hasFrontends):
(WebCore::InspectorInstrumentation::willInsertDOMNode):
(WebCore::InspectorInstrumentation::didInsertDOMNode):
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::characterDataModified):
(WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest):
(WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext):
(WebCore::InspectorInstrumentation::inspectorControllerForDocument):
(WebCore::InspectorInstrumentation::inspectorControllerForPage):
* workers/SharedWorker.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 30 Sep 2010 09:12:28 +0000 (09:12 +0000)]
2010-09-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch failure-reason dies if non-trunk commits are in the blame range
https://bugs.webkit.org/show_bug.cgi?id=46866
I also made failure-reason use RegressionWindow in a cleaner way.
* Scripts/webkitpy/tool/commands/queries.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 08:50:48 +0000 (08:50 +0000)]
2010-09-30 Avi Drissman <avi@google.com>
Reviewed by Kenneth Russell.
[Chromium] Tabbing into page doesn't always select the first element
https://bugs.webkit.org/show_bug.cgi?id=46856
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setInitialFocus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Thu, 30 Sep 2010 08:37:27 +0000 (08:37 +0000)]
2010-09-30 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove unnecessary cacheFlush calls from Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=46702
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 08:22:19 +0000 (08:22 +0000)]
2010-09-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Build fix: Add ENABLE(INSPECTOR) guard
https://bugs.webkit.org/show_bug.cgi?id=46852
Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.
* inspector/InspectorController.h:
(WebCore::InspectorController::inspectorControllerForDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 07:48:41 +0000 (07:48 +0000)]
2010-09-30 Michael Nordman <michaeln@google.com>
Reviewed by David Levin.
Make it possible to copy platform specific data members of ResourceRequest and ResourceResponse
across threads and to compare platform specific data members of ResourceRequest.
- Added two instance methods to the platform specific subclasses: doPlatformAdopt and doPlatformCopyData.
- Also added a "shadowable" static method for platformCompare to ResourceRequestBase, a similar method
is already present on ResourceResponseBase.
- Converted the cross thread structs defined in ResourceRequest/ResponseBase.h to base
classes and extended those base classes in the platform specific headers to provide a place
to hold additional fields.
- Used this mechanism to have the chromium port's data members make the hop.
https://bugs.webkit.org/show_bug.cgi?id=46430
No new tests. Just plumbing.
* WebCore.exp.in: removed the symbol for the now inlined == operator
* WebCore.gypi: added chromium/ResourceResponse.cpp
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
(WebCore::ResourceRequestBase::compare):
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::platformCompare):
(WebCore::operator==):
(WebCore::operator!=):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::asResourceResponse):
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
* platform/network/ResourceResponseBase.h:
* platform/network/android/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/android/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/chromium/ResourceRequest.h:
* platform/network/chromium/ResourceResponse.cpp: Added.
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
* platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/mac/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/mac/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/qt/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/qt/ResourceResponse.h:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::doUpdateResourceResponse):
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Thu, 30 Sep 2010 07:22:51 +0000 (07:22 +0000)]
2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Crash if an scene with accelerated compositing layout during the paint event
https://bugs.webkit.org/show_bug.cgi?id=46812
Delay the deletion of the overlay after the current event is processed.
Removing the overlay can sometimes be done inside the rendering code of
the overlay itself. When the rendering code is using the reference after
the deletion of the overlay, WebKit crashes.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::overlay):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
(WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
* WebCoreSupport/PageClientQt.h:
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Thu, 30 Sep 2010 07:10:01 +0000 (07:10 +0000)]
2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814
Disable the test. This test cannot pass with a
standard build of WebKit, it is disabled until the API is finilized.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::geolocationRequestJS):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 07:08:30 +0000 (07:08 +0000)]
2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Rename chromium's GraphicsContext3D.cpp to match others.
https://bugs.webkit.org/show_bug.cgi?id=46771
* WebKit.gyp:
* src/GraphicsContext3DChromium.cpp: Renamed from WebKit/chromium/src/GraphicsContext3D.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Sep 2010 06:52:50 +0000 (06:52 +0000)]
2010-09-29 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
Rebaseline image-rescale.svg results for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=46818
* platform/chromium-win/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
* platform/chromium-win/svg/custom/image-rescale-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.png.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 30 Sep 2010 06:49:36 +0000 (06:49 +0000)]
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Put default initialize() and uninitialize() methods in AudioNode
https://bugs.webkit.org/show_bug.cgi?id=46767
No new tests since audio API is not yet implemented.
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::initialize):
(WebCore::AudioNode::uninitialize):
* webaudio/AudioNode.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 06:34:49 +0000 (06:34 +0000)]
2010-09-29 Adam Barth <abarth@webkit.org>
Unreviewed. See comments in the Skipped file.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 06:29:18 +0000 (06:29 +0000)]
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch find-flaky-tests
https://bugs.webkit.org/show_bug.cgi?id=46876
This command helps us find flaky tests so we can squash them.
* Scripts/webkitpy/tool/commands/queries.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 30 Sep 2010 06:26:13 +0000 (06:26 +0000)]
Skip plugins/plugin-document-load-prevented-userscript.html on Qt, because it doesn't
support window.layoutTestController.addUserScript yet.
Rubber-stamped by Adam Barth.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Thu, 30 Sep 2010 06:24:37 +0000 (06:24 +0000)]
2010-09-29 Alejandro G. Castro <alex@igalia.com>
Unreviewed, LayoutTestController::addUserScript not supported in
GTK+, skip plugin-document-load-prevented-userscript.html.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 30 Sep 2010 05:56:56 +0000 (05:56 +0000)]
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated test_expectations.txt
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 30 Sep 2010 05:27:15 +0000 (05:27 +0000)]
2010-09-29 Simon Fraser <simon.fraser@apple.com>
Fix export to use '?' instead of 'null' for
tests with no results.
* CSSTestSuiteHarness/harness/harness.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 30 Sep 2010 04:41:10 +0000 (04:41 +0000)]
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated test_expectations.txt
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 30 Sep 2010 04:22:17 +0000 (04:22 +0000)]
2010-09-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Make DeprecatedInputType private.
https://bugs.webkit.org/show_bug.cgi?id=46791
No new tests because this doesn't change any behavior.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createTypeMap):
* html/HTMLInputElement.h:
Move DeprecatedInputType, deprecatedInputType() and
parseToDateComponents() to the private section, make
createTypeMap() a member function of HTMLInputElement.
(WebCore::HTMLInputElement::deprecatedInputType):
2010-09-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Make DeprecatedInputType private.
https://bugs.webkit.org/show_bug.cgi?id=46791
* src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):
Accept any text field types as a username field.
* src/WebSearchableFormData.cpp:
(WebCore::HasSuitableTextElement):
Accept any text field types as a search query field.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 30 Sep 2010 04:14:42 +0000 (04:14 +0000)]
2010-09-29 Simon Fraser <simon.fraser@apple.com>
Add a warning when a test requires special steps.
Add a Print Preview button for 'paged' tests that
brings up the print dialog, allowing the user to
judge paged media tests.
* CSSTestSuiteHarness/harness/harness.css:
* CSSTestSuiteHarness/harness/harness.html:
* CSSTestSuiteHarness/harness/harness.js:
(TestSuite.prototype.loadTest):
(TestSuite.prototype.processFlags):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 04:07:22 +0000 (04:07 +0000)]
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove revisions_casuing_failures
https://bugs.webkit.org/show_bug.cgi?id=46872
This function exists only to be unit tested.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/failuremap_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 03:57:30 +0000 (03:57 +0000)]
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should post the list of failing tests to bugs
https://bugs.webkit.org/show_bug.cgi?id=46871
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/regressionwindow.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/bot/sheriff_unittest.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 30 Sep 2010 03:42:07 +0000 (03:42 +0000)]
2010-09-29 Eric Seidel <eric@webkit.org>
Unreviewed. Skipping crashing test to green the tree.
This crash started when I skipped some canvas tests
as part of rolling out r68568.
fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870
* platform/mac-snowleopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 30 Sep 2010 03:33:41 +0000 (03:33 +0000)]
[WinCairo] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=46360
Patch by Brent Fulgham <bfulgham@webkit.org> on 2010-09-29
Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
* BuildSlaveSupport/build.webkit.org-config/config.json: Add
entries for a debug build of the WinCairo port.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
platform flag to configuration for wincairo (like gtk, chromium, etc.)
* Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
* Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 30 Sep 2010 03:27:07 +0000 (03:27 +0000)]
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated test_expectations.txt
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Sep 2010 03:06:49 +0000 (03:06 +0000)]
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324
Add test which uses pushState to generate history entries while also
changing the frames that are present in the document between history
states. Add a similar test that uses fragment changes.
* fast/history/same-document-iframes-changing-fragment-expected.txt: Added.
* fast/history/same-document-iframes-changing-fragment.html: Added.
* fast/history/same-document-iframes-changing-pushstate-expected.txt: Added.
* fast/history/same-document-iframes-changing-pushstate.html: Added.
2010-09-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324
Revert same document check to the way it was before r66238 for history
entries created by pushState or fragment changes. Logic fror determining
if same document navigation should be used is moved to HistoryItem.
Tests: fast/history/same-document-iframes-changing-fragment.html
fast/history/same-document-iframes-changing-pushstate.html
* history/HistoryItem.cpp:
(WebCore::HistoryItem::shouldDoSameDocumentNavigationTo):
(WebCore::HistoryItem::hasSameDocumentTree):
(WebCore::HistoryItem::hasSameFrames):
* history/HistoryItem.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 30 Sep 2010 03:01:46 +0000 (03:01 +0000)]
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add removeRecursively to WebKit WebFileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46842
* public/WebFileSystem.h:
(WebKit::WebFileSystem::removeRecursively): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 02:53:43 +0000 (02:53 +0000)]
2010-09-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move more SheriffBot smarts into FailureMap
https://bugs.webkit.org/show_bug.cgi?id=46703
This patch pushes the FailureMap model object further into the
SheriffBot machine. In addition, it moves a couple operations on this
object from SheriffBot itself to the model.
Eventually, FailureMap will be the canonical context object for
SheriffBot operations. FailureMap represents a map of the current
failures on the bots that might require remediation.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/regressionwindow.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 30 Sep 2010 02:49:28 +0000 (02:49 +0000)]
2010-09-29 Adam Barth <abarth@webkit.org>
This test result seems to be platform specific.
* platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt: Renamed from LayoutTests/plugins/plugin-initiate-popup-window-expected.txt.
* platform/mac/plugins/plugin-initiate-popup-window-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 30 Sep 2010 02:34:02 +0000 (02:34 +0000)]
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
WebCore::ESpeak causes missing symbol with no ENABLE_SVG
https://bugs.webkit.org/show_bug.cgi?id=46865
Moves ESpeak related function definitions outside ENABLE_SVG block.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 30 Sep 2010 02:24:13 +0000 (02:24 +0000)]
2010-09-29 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r68568.
http://trac.webkit.org/changeset/68568
https://bugs.webkit.org/show_bug.cgi?id=46439
Failing tests on both Leopard and Snow Leopard
* canvas/philip/tests/2d.composite.operation.darker-expected.txt:
* canvas/philip/tests/2d.composite.operation.highlight-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.fill.destination-atop-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.fill.destination-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.fill.source-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.fill.source-out-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
* canvas/philip/tests/2d.drawImage.incomplete-expected.txt:
* canvas/philip/tests/2d.drawImage.null-expected.txt:
* canvas/philip/tests/2d.fillStyle.parse.current.basic-expected.txt:
* canvas/philip/tests/2d.fillStyle.parse.current.changed-expected.txt:
* canvas/philip/tests/2d.fillStyle.parse.current.removed-expected.txt:
* canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
* canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
* canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
* canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
* canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
* canvas/philip/tests/2d.gradient.radial.negative-expected.txt:
* canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
* canvas/philip/tests/2d.imageData.create1.type-expected.txt:
* canvas/philip/tests/2d.imageData.create2.type-expected.txt:
* canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
* canvas/philip/tests/2d.imageData.get.type-expected.txt:
* canvas/philip/tests/2d.line.cap.closed-expected.txt:
* canvas/philip/tests/2d.line.join.parallel-expected.txt:
* canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
* canvas/philip/tests/2d.missingargs-expected.txt:
* canvas/philip/tests/2d.path.rect.winding-expected.txt:
* canvas/philip/tests/2d.pattern.image.broken-expected.txt:
* canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
* canvas/philip/tests/2d.pattern.image.null-expected.txt:
* canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
* canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
* canvas/philip/tests/2d.shadow.enable.x-expected.txt:
* canvas/philip/tests/2d.shadow.enable.y-expected.txt:
* canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
* canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
* canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
* canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
* canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
* canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
* canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
* canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
* canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
* canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
* canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
* canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
* canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
* canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
* canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
* canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
* canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
* canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
* canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
* canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
* canvas/philip/tests/2d.text.font.parse.system-expected.txt:
* canvas/philip/tests/2d.text.measure.width.space-expected.txt:
* canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
* canvas/philip/tests/type.prototype-expected.txt:
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 30 Sep 2010 01:27:05 +0000 (01:27 +0000)]
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioChannelSplitter files
https://bugs.webkit.org/show_bug.cgi?id=46290
No new tests since audio API is not yet implemented.
* webaudio/AudioChannelSplitter.cpp: Added.
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
(WebCore::AudioChannelSplitter::process):
(WebCore::AudioChannelSplitter::reset):
* webaudio/AudioChannelSplitter.h: Added.
(WebCore::AudioChannelSplitter::create):
* webaudio/AudioChannelSplitter.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 30 Sep 2010 01:16:43 +0000 (01:16 +0000)]
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563
* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::didReadDirectory):
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563
Test: fast/filesystem/read-directory.html
* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::readDirectory): Changed to take DirectoryReader
as a parameter.
* fileapi/DOMFileSystem.h:
(WebCore::DOMFileSystem::scheduleCallback): Added.
* fileapi/DirectoryReader.cpp:
(WebCore::DirectoryReader::DirectoryReader): Added initializer for
m_hasMore flag.
(WebCore::DirectoryReader::readEntries): Changed to schedule
EntriesCallback with an empty array if m_hasMore flag is set false.
* fileapi/DirectoryReader.h:
(WebCore::DirectoryReader::filesystem): Added.
(WebCore::DirectoryReader::setHasMore): Added.
* fileapi/FileSystemCallbacks.cpp:
(WebCore::EntriesCallbacks::create):
(WebCore::EntriesCallbacks::EntriesCallbacks): Changed to take
DirectoryReader as a parameter.
(WebCore::EntriesCallbacks::didReadDirectoryEntry):
(WebCore::EntriesCallbacks::didReadDirectoryEntries): Changed 1) not to
trigger the second callback when hasMore is false, and 2) to update
the DirectoryReader's m_hasMore flag.
* fileapi/FileSystemCallbacks.h:
2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563
* fast/filesystem/flags-passing.html: Updated to make it match
with the updated TEMPLATE.html.
* fast/filesystem/flags-passing-expected.txt: Updated.
* fast/filesystem/read-directory.html: Added.
* fast/filesystem/read-directory-expected.txt: Added.
* fast/filesystem/resources/fs-test-util.js: Added for common test
utilities.
* fast/filesystem/script-tests/TEMPLATE.html: Updated to include
fs-test-util.js.
* fast/filesystem/script-tests/flags-passing.js: Updated to use
jsTestIsAsync and finishJSTest (so that all the tests look alike).
* fast/filesystem/script-tests/read-directory.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 30 Sep 2010 01:12:20 +0000 (01:12 +0000)]
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioGainNode files
https://bugs.webkit.org/show_bug.cgi?id=46286
No new tests since audio API is not yet implemented.
* webaudio/AudioGainNode.cpp: Added.
(WebCore::AudioGainNode::AudioGainNode):
(WebCore::AudioGainNode::process):
(WebCore::AudioGainNode::reset):
(WebCore::AudioGainNode::checkNumberOfChannelsForInput):
* webaudio/AudioGainNode.h: Added.
(WebCore::AudioGainNode::create):
(WebCore::AudioGainNode::gain):
* webaudio/AudioGainNode.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 30 Sep 2010 01:07:58 +0000 (01:07 +0000)]
2010-09-29 MORITA Hajime <morrita@google.com>
Unreviewed, updated expectations.
* platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
* platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 30 Sep 2010 00:55:04 +0000 (00:55 +0000)]
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioChannelMerger files
https://bugs.webkit.org/show_bug.cgi?id=46291
No new tests since audio API is not yet implemented.
* webaudio/AudioChannelMerger.cpp: Added.
(WebCore::AudioChannelMerger::AudioChannelMerger):
(WebCore::AudioChannelMerger::process):
(WebCore::AudioChannelMerger::reset):
* webaudio/AudioChannelMerger.h: Added.
(WebCore::AudioChannelMerger::create):
* webaudio/AudioChannelMerger.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 30 Sep 2010 00:45:31 +0000 (00:45 +0000)]
Calling Connection::send/sendSync from Connection::Client::didClose should always fail
https://bugs.webkit.org/show_bug.cgi?id=46859
<rdar://problem/8212583>
Reviewed by Simon Fraser.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchConnectionDidClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Thu, 30 Sep 2010 00:31:57 +0000 (00:31 +0000)]
No review. Missed file for patch.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Thu, 30 Sep 2010 00:14:57 +0000 (00:14 +0000)]
No review. Update layout tests after new CSS property.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Thu, 30 Sep 2010 00:11:04 +0000 (00:11 +0000)]
Crash at lineBreakExistsAtPosition + 125
<rdar://problem/7028809>
https://bugs.webkit.org/show_bug.cgi?id=46770
Reviewed by Darin Adler.
lineBreakExistsAtPosition is called from InsertTextCommand::input,
where we compute the downstream position of the endingSelection().
Downstream can return the original position, that comes from a VisibleSelection
but there is no guarantee that its renderer is still there. Everywhere we dereference
a renderer we check if it's null.
There is no regression test.
* editing/htmlediting.cpp:
(WebCore::lineBreakExistsAtPosition): Added check that the renderer is not null
before dereferencing it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 30 Sep 2010 00:10:24 +0000 (00:10 +0000)]
2010-09-29 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Assertion then crash closing WebKit2 window with accelerated compositing in
https://bugs.webkit.org/show_bug.cgi?id=46857
Fix two issues when closing a WebKit2 window using accelerated
compositing.
The first is that the response to the sync DidChangeAcceleratedCompositing message
sent by changeAcceleratedCompositingMode() may be empty, because the corresponding
page may have been destroyed already in the UI process. In that case newDrawingAreaInfo
is not filled in, so we get a DrawingArea::Type of None. Don't attempt to make a new
drawing area in that case.
We then have to null-check the drawing area in WebPage::didReceiveMessage(),
in the case where the UI process is calling back with a SuspendPainting message,
before our page has gone away.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::didReceiveMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 29 Sep 2010 23:52:31 +0000 (23:52 +0000)]
plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown
https://bugs.webkit.org/show_bug.cgi?id=46715
<rdar://problem/8485909>
Reviewed by Darin Adler.
WebCore:
Remove exclamation points from exceptions.
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
LayoutTests:
Remove exclamation point.
* plugins/npruntime/invoke-failure-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 29 Sep 2010 23:51:45 +0000 (23:51 +0000)]
Add additional checks to StringBuilder.
<rdar://problem/7761248>
Reviewed by Darin Adler.
* platform/text/StringBuilder.cpp:
(WebCore::checkAppend):
(WebCore::StringBuilder::append):
(WebCore::StringBuilder::toString):
(WebCore::StringBuilder::clear):
(WebCore::StringBuilder::length):
* platform/text/StringBuilder.h:
(WebCore::StringBuilder::StringBuilder):
(WebCore::StringBuilder::setNonNull):
(WebCore::StringBuilder::isNull):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 29 Sep 2010 23:51:25 +0000 (23:51 +0000)]
Unreviewed. Update test results.
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827
Rebaseline GTK test after CSS change.
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 29 Sep 2010 23:05:50 +0000 (23:05 +0000)]
Add additional check to Text::wholeText.
<rdar://problem/8304795>
Reviewed by Darin Adler.
* dom/Text.cpp:
(WebCore::Text::wholeText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 29 Sep 2010 22:59:49 +0000 (22:59 +0000)]
REGRESSION (r66129): Loading full-frame .swf file crashes with flash blocker extension enabled
<https://bugs.webkit.org/show_bug.cgi?id=46773>
<rdar://problem/8390975>
Reviewed by Brady Eidson.
WebCore:
After r66129, start scripts were run on plugin documents, and cancelling the load of a plugin
document could cause Safari to crash.
If a plugin load on an initial document is cancelled, we cancel the main resource load (where the
main resource is the plugin), and if the load is restarted and allowed, we don't go through the manual
loading path like we do on the initial load of a plugin in a plugin document.
Tests: plugins/plugin-document-load-prevented-userscript.html
plugins/plugin-document-willSendRequest-null.html
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): If the plugin load was cancelled, and this is in a
plugin document, call a function on PluginDocument that cancels the main resource load, and
sets a plugin document flag.
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes): Null check the widget's renderer, because it could be
null if the load was cancelled.
(WebCore::PluginDocument::PluginDocument): Initialize the new variable.
(WebCore::PluginDocument::cancelManualPluginLoad): Cancel the main resource load of the plugin document
(which is a plugin in the case of a plugin document).
* html/PluginDocument.h:
(WebCore::PluginDocument::shouldLoadPluginManually): Returns whether or not we should load the plugin
manually.
(WebCore::PluginDocument::setShouldLoadPluginManually): Set whether or not we should load the plugin
manually.
(WebCore::toPluginDocument):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin): Check if we should load the plugin manually according to the plugin
document.
LayoutTests:
Add tests testing how plugin documents behave when the loading of their plugins are cancelled.
* plugins/plugin-document-load-prevented-userscript-expected.txt: Added.
* plugins/plugin-document-load-prevented-userscript.html: Added. Tests cancelling the load of a
plugin in a plugin document using beforeload and preventDefault.
* plugins/plugin-document-willSendRequest-null-expected.txt: Added.
* plugins/plugin-document-willSendRequest-null.html: Added. Tests cancelling the load of a plugin
in a plugin document by having willSendRequest return null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 29 Sep 2010 22:53:31 +0000 (22:53 +0000)]
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829
* WebKit.gyp:
* tests/ArenaTestHelpers.h:
(WebCore::ArenaTestHelpers::TrackedAllocator::free):
* tests/IDBKeyPathTest.cpp:
(WebCore::checkKeyPath):
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829
* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::DRTDevToolsClient):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::postAccessibilityNotification):
(WebViewHost::WebViewHost):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 29 Sep 2010 22:22:59 +0000 (22:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46844, make estimateLogicalTopPosition
block-flow-aware.
Reviewed by Sam Weinig.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
* rendering/RenderBlock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Wed, 29 Sep 2010 22:06:54 +0000 (22:06 +0000)]
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Minor cleanup to AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46843
No new tests since audio API is not yet implemented
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::lock):
(WebCore::AudioContext::handleDeferredFinishDerefs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 29 Sep 2010 22:06:22 +0000 (22:06 +0000)]
2010-09-29 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] enable -Werror on chromium linux webkit
https://bugs.webkit.org/show_bug.cgi?id=46821
* WebKit.gyp:
* src/gtk/WebInputEventFactory.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Wed, 29 Sep 2010 22:02:31 +0000 (22:02 +0000)]
2010-09-29 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
Assertion failed when accessing -webkit-margin-top-collapse via computed style.
https://bugs.webkit.org/show_bug.cgi?id=46798
There was a switch statement which missed enum entries in getPropertyCSSValue().
This change added these entries to prevent the leak.
It also added extra case statements to encourage the compiler's help.
Test: fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2010-09-29 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
Assertion failed when accessing -webkit-margin-top-collapse via computed style.
https://bugs.webkit.org/show_bug.cgi?id=46798
* fast/css/getComputedStyle/margin-top-bottom-collapse-alias-expected.txt: Added.
* fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html: Added.
* fast/css/getComputedStyle/script-tests/margin-top-bottom-collapse-alias.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Wed, 29 Sep 2010 21:56:46 +0000 (21:56 +0000)]
2010-09-29 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Limit number of AudioNode deletions per render quantum in AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46834
No new tests since audio API is not yet implemented.
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::deleteMarkedNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc