WebKit-https.git
8 years agoDe-virtualize JSVariableObject::isDynamicScope
mhahnenberg@apple.com [Wed, 9 Nov 2011 23:21:56 +0000 (23:21 +0000)]
De-virtualize JSVariableObject::isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=71933

Reviewed by Geoffrey Garen.

* runtime/JSActivation.cpp:
* runtime/JSActivation.h: Inlined and de-virtualized isDynamicScope
(JSC::JSActivation::isDynamicScope):
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h: Inlined and de-virtualized isDynamicScope
(JSC::JSGlobalObject::isDynamicScope):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h: Inlined and de-virtualized isDynamicScope
(JSC::JSStaticScopeObject::createStructure): Changed createStructure to use new JSType
(JSC::JSStaticScopeObject::isDynamicScope):
* runtime/JSType.h: Added new type for JSStaticScopeObject
* runtime/JSVariableObject.cpp: De-virtualized and added an implementation that checks the
object's type and calls the corresponding implementation.
(JSC::JSVariableObject::isDynamicScope):
* runtime/JSVariableObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSGlobalObject::hasOwnPropertyForWrite
mhahnenberg@apple.com [Wed, 9 Nov 2011 23:14:53 +0000 (23:14 +0000)]
De-virtualize JSGlobalObject::hasOwnPropertyForWrite
https://bugs.webkit.org/show_bug.cgi?id=71934

Reviewed by Geoffrey Garen.

* runtime/JSGlobalObject.h: Removed the virtual-ness of hasOwnPropertyForWrite since nobody overrides it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix MHTML generation to use the QuotedPrintable encoding for text resources.
jcivelli@chromium.org [Wed, 9 Nov 2011 23:13:59 +0000 (23:13 +0000)]
Fix MHTML generation to use the QuotedPrintable encoding for text resources.
This was regressed when we added binary encoding support.
https://bugs.webkit.org/show_bug.cgi?id=71857

Reviewed by Adam Barth.

Source/WebCore:

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):

Source/WebKit/chromium:

* tests/WebPageNewSerializerTest.cpp:
(WebKit::LineReader::LineReader):
(WebKit::LineReader::getNextLine):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71873
barraclough@apple.com [Wed, 9 Nov 2011 23:05:03 +0000 (23:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::absDouble):
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::absDouble):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::absDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::absDouble):
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::absDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace [CanBeConstructed] IDL with [Constructor] IDL
haraken@chromium.org [Wed, 9 Nov 2011 22:58:30 +0000 (22:58 +0000)]
Replace [CanBeConstructed] IDL with [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71927

Reviewed by Adam Barth.

With respect to the IDL files that have [CanBeConstructed]
but do not have [Constructor] nor [CustomConstructor],
[CanBeConstructed] is now equivalent to [Constructor].
Thus, this patch replaces [CanBeConstructed] with [Constructor].

No tests. No change in behavior.

* fileapi/FileReaderSync.idl: As I described above.
* fileapi/WebKitBlobBuilder.idl: Ditto.
* fileapi/WebKitFlags.idl: Ditto.
* xml/DOMParser.idl: Ditto.
* xml/XMLSerializer.idl: Ditto.
* xml/XPathEvaluator.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Separate image encoding from dataURL construction
noel.gordon@gmail.com [Wed, 9 Nov 2011 22:53:03 +0000 (22:53 +0000)]
[chromium] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=71846

Reviewed by Adam Barth.

Remove the implicit assumption that a dataURL is the only desired output format of the
the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::encodeImage):  Output the encoded image to a Vector.
(WebCore::ImageBuffer::toDataURL):  Format the dataURL encoding of the mimeType encoded
image Vector here.  Move the mimeType encoding debug check here to better align this
code with the CG (CoreGraphics) ImageBuffer.cpp implementation.
(WebCore::ImageDataToDataURL): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement dumpProgressFinishedCallback() for Mac layoutTestController
commit-queue@webkit.org [Wed, 9 Nov 2011 22:43:05 +0000 (22:43 +0000)]
Implement dumpProgressFinishedCallback() for Mac layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=66772

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-09
Reviewed by Simon Fraser.

Tools:

When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
"postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().

On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
in the FrameLoadDelegate and print the output in response to the notification.

* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate init]):
(-[FrameLoadDelegate dealloc]):
(-[FrameLoadDelegate webViewProgressFinishedNotification:]):

LayoutTests:

Unskip the skipped test.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom...
commit-queue@webkit.org [Wed, 9 Nov 2011 22:29:29 +0000 (22:29 +0000)]
Chromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom scrollbar css.
https://bugs.webkit.org/show_bug.cgi?id=71719

Source/WebCore:

This was caused by the overhang calculation logic not being consistent when subtracting the scrollbar sizes from the overhang areas. This resulted in for e.g. a horizontal overhang that didn't overlap with the scrollbar while the vertical overhang overlapped with it. This fix makes the logic consistent so that the overhang areas do not overlap with the scrollbars (when scrollbars are opaque).

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

Tests: platform/chromium/rubberbanding/custom-scrollbars-ne.html
       platform/chromium/rubberbanding/custom-scrollbars-nw.html
       platform/chromium/rubberbanding/custom-scrollbars-se.html
       platform/chromium/rubberbanding/custom-scrollbars-sw.html

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):

LayoutTests:

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-ne.html: Added.
* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-nw.html: Added.
* platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-se.html: Added.
* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-sw.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r99752.
jchaffraix@webkit.org [Wed, 9 Nov 2011 22:20:08 +0000 (22:20 +0000)]
Unreviewed rebaseline after r99752.

* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
* platform/chromium-win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
ojan@chromium.org [Wed, 9 Nov 2011 22:16:50 +0000 (22:16 +0000)]
[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=71880

Reviewed by Tony Chang.

Makes the test run ~10x faster by making the second select element only have 16
option elements. As best I can tell, that covers all the edge cases from r99653.

Also, cleaned up the test to make it a more normal js test:
-Gave it a doctype so it's in standards-mode.
-Moved the description to a description call.
-Generated both select element in script instead of just one of them.

* fast/forms/select-clientheight-large-size-expected.txt:
* fast/forms/select-clientheight-large-size.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test description.
antti@apple.com [Wed, 9 Nov 2011 21:59:15 +0000 (21:59 +0000)]
Update test description.

Not reviewed.

* svg/dom/rgb-color-parser-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Indentation error in RenderObject::container
commit-queue@webkit.org [Wed, 9 Nov 2011 21:25:05 +0000 (21:25 +0000)]
Source/WebCore: Indentation error in RenderObject::container
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

A conditional block was indented too far; correcting.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):

LayoutTests: Rebaselining gtk and qt results for foreign object overflow
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

Fix for 64780 changed results for one layoutTest. This is the rebaseline for gtk and qt platforms.

* platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse contentsToRootView/rootViewToContents when converting between frame coordinate...
andersca@apple.com [Wed, 9 Nov 2011 21:18:44 +0000 (21:18 +0000)]
Use contentsToRootView/rootViewToContents when converting between frame coordinate systems
https://bugs.webkit.org/show_bug.cgi?id=71947

Reviewed by Sam Weinig.

This gets rid of a few calls to contentsToWindow and windowToContents.

* inspector/DOMNodeHighlighter.cpp:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSObject::getOwnPropertyDescriptor
mhahnenberg@apple.com [Wed, 9 Nov 2011 21:09:37 +0000 (21:09 +0000)]
De-virtualize JSObject::getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71523

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyDescriptor):
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
* runtime/ClassInfo.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/DatePrototype.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyDescriptor):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyDescriptor):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertyDescriptor):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::vtableAnchor):
(JSC::JSObject::propertyIsEnumerable):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSString.cpp: Removed getOwnPropertyDescriptor, since this seems to be a relic from a
bygone era when getOwnPropertyDescriptor was rooted in JSCell rather than JSObject.  There were
no call sites for this version of getOwnPropertyDescriptor in the entire project.
* runtime/JSString.h:
* runtime/Lookup.h:
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptor):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertyDescriptor):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::vtableAnchor): Added to prevent a weak vtable.
(JSC::StringObject::getOwnPropertyDescriptor):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/StringPrototype.h:

Source/WebCore:

No new tests.

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyDescriptor):
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::vtableAnchor): Added to prevent a weak vtable.
(JSC::RuntimeMethod::getOwnPropertyDescriptor):
* bridge/runtime_method.h: Changed getOwnPropertyDescriptor from private to protected to allow
subclasses to use it in their MethodTables.
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
* bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyDescriptor):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r99616 and r99736.
xji@chromium.org [Wed, 9 Nov 2011 20:49:01 +0000 (20:49 +0000)]
Rebaseline after r99616 and r99736.
Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
so that cr-mac failed for text too.

* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r93614): Content remains despite parent element being scrolled off page...
jchaffraix@webkit.org [Wed, 9 Nov 2011 20:35:23 +0000 (20:35 +0000)]
REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html
       fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
       fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
       fast/repaint/scroll-inside-table-cell.html
       fast/repaint/scroll-relative-table-inside-table-cell.html
       fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
       fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
       fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

* rendering/RenderLayer.h:
Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

* fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
* fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
* fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
* fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
* fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
* fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
* fast/repaint/scroll-inside-table-cell-expected.txt: Added.
* fast/repaint/scroll-inside-table-cell.html: Added.
* fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
* fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
* fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
* fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
* fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
* fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
* fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
* fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
* platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTests depending on video-paint-test.js can run non-deterministically
scherkus@chromium.org [Wed, 9 Nov 2011 20:28:24 +0000 (20:28 +0000)]
Tests depending on video-paint-test.js can run non-deterministically
https://bugs.webkit.org/show_bug.cgi?id=71878

Reviewed by Darin Adler.

* media/video-frame-accurate-seek.html: changed init() to initAndSeeked()
* media/video-paint-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate the HTMLAudioElement constructor using [NamedConstructor] IDL
haraken@chromium.org [Wed, 9 Nov 2011 20:22:42 +0000 (20:22 +0000)]
Generate the HTMLAudioElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71924

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLAudioElement
and generates it using [NamedConstructor] IDL.

Tests:  fast/js/custom-constructors.html
        media/audio-constructor.html
        media/audio-constructor-src.html
        media/audio-constructor-preload.html
        media/audio-controls-do-not-fade-out.html
        media/audio-controls-rendering.html

* Target.pri: Removed V8HTMLAudioElementConstructor.{h,cpp}
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Removed.
* bindings/v8/custom/V8HTMLAudioElementConstructor.h: Removed.
* html/HTMLAudioElement.idl: Added [NamedConstructor] IDL.
* page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate CSSMutableValue
antti@apple.com [Wed, 9 Nov 2011 20:13:02 +0000 (20:13 +0000)]
Eliminate CSSMutableValue
https://bugs.webkit.org/show_bug.cgi?id=71811

Source/WebCore:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

Remove the implementations of setter functions in SVGColor and SVGPaint. These interfaces are
deprecated in SVG 1.1 (2nd edition) and are not really used by anybody. This allows
removal of CSSMutableValue and the associated (rather broken) code.

The setters now throw NO_MODIFICATION_ALLOWED_ERR.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
* css/CSSMutableValue.h: Removed.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::getPropertyCSSValue):
* css/CSSValue.h:
(WebCore::CSSValue::CSSValue):
* svg/SVGColor.cpp:
(WebCore::SVGColor::SVGColor):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):
* svg/SVGColor.h:
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::setPaint):
* svg/SVGPaint.h:

LayoutTests:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

SVGColor and SVGPaint setter function are deprecated and throw exception.

- Remove (mostly render tree dump based) tests for SVGColor mutations that have little useful
  coverage otherwise.
- Fix some other tests to work without the feature.
- Update rgb-color-parser.html to also cover the cases from rgbcolor-syntax.svg (which is removed).
  They test the same thing but the former uses a better mechanism.
- Update the test results to capture the new behavior.

* fast/css/parse-color-int-or-percent-crash.html:
* platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
* platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
* platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
* platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
* platform/gtk/svg/custom/rgbcolor-syntax-expected.png: Removed.
* platform/gtk/svg/custom/rgbcolor-syntax-expected.txt: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
* platform/mac/svg/custom/rgbcolor-syntax-expected.png: Removed.
* platform/mac/svg/custom/rgbcolor-syntax-expected.txt: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
* platform/qt/svg/custom/rgbcolor-syntax-expected.png: Removed.
* platform/qt/svg/custom/rgbcolor-syntax-expected.txt: Removed.
* svg/custom/SVGPaint-mutate-attribute.svg: Removed.
* svg/custom/SVGPaint-mutate-inline-style.svg: Removed.
* svg/custom/fill-SVGPaint-interface.svg:
* svg/custom/getPresentationAttribute-modify-expected.txt: Removed.
* svg/custom/getPresentationAttribute-modify.svg: Removed.
* svg/custom/getPresentationAttribute.svg:
* svg/custom/rgbcolor-syntax.svg: Removed.
* svg/dom/SVGColor-expected.txt:
* svg/dom/SVGPaint-expected.txt:
* svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Removed.
* svg/dom/getPresentationAttribute-cache-corruption.svg: Removed.
* svg/dom/rgb-color-parser-expected.txt:
* svg/dom/rgb-color-parser.html:
* svg/dom/script-tests/SVGColor.js:
* svg/dom/script-tests/SVGPaint.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][DRT] window internals object is not reset after each test
philn@webkit.org [Wed, 9 Nov 2011 20:10:58 +0000 (20:10 +0000)]
[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Martin Robinson.

.:

* Source/autotools/symbols.filter: Revert un-needed symbol.

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic
calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

Call WebCoreTestSupport::resetInternalsObject without going
through DumpRenderTreeSupport.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate the HTMLOptionElement constructor using [NamedConstructor] IDL
haraken@chromium.org [Wed, 9 Nov 2011 20:05:40 +0000 (20:05 +0000)]
Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71925

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLOptionElement,
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html
       fast/forms/option-index.html
       fast/forms/add-and-remove-option.html
       fast/dom/dom-add-optionelement.html

* Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
* bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
* html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
* page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
bdakin@apple.com [Wed, 9 Nov 2011 20:04:02 +0000 (20:04 +0000)]
Build fix.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementAttributeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71873
barraclough@apple.com [Wed, 9 Nov 2011 20:01:24 +0000 (20:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in RenderTableSection::splitColumn
jchaffraix@webkit.org [Wed, 9 Nov 2011 19:57:16 +0000 (19:57 +0000)]
Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html
       fast/table/crash-splitColumn-3.html
       fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

* fast/table/crash-splitColumn-2-expected.txt: Added.
* fast/table/crash-splitColumn-2.html: Added.
* fast/table/crash-splitColumn-3-expected.txt: Added.
* fast/table/crash-splitColumn-3.html: Added.
* fast/table/crash-splitColumn-expected.txt: Added.
* fast/table/crash-splitColumn.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative build fix.
bdakin@apple.com [Wed, 9 Nov 2011 19:45:08 +0000 (19:45 +0000)]
Speculative build fix.

* DumpRenderTree/AccessibilityUIElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMicrodata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element...
commit-queue@webkit.org [Wed, 9 Nov 2011 19:35:28 +0000 (19:35 +0000)]
Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute().
https://bugs.webkit.org/show_bug.cgi?id=71510

Patch by Arko Saha <arko@motorola.com> on 2011-11-09
Reviewed by Darin Adler.

Source/WebCore:

Override isURLAttribute() for HTMLElement and return true if attribute is itemidAttr.
All the classes derived from HTMLElement overrides this function should return true if attribute is itemidAttr.
Removed HTMLIFrameElement::isURLAttribute() method as HTMLFrameElementBase already takes care of it.

Test: fast/dom/MicroData/itemid-attribute-test-001.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isURLAttribute):
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::isURLAttribute):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::isURLAttribute):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::isURLAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isURLAttribute):
* html/HTMLElement.h:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isURLAttribute):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::isURLAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAttribute):
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::isURLAttribute):
* html/HTMLIFrameElement.cpp:
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isURLAttribute):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isURLAttribute):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::isURLAttribute):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isURLAttribute):
* html/HTMLModElement.cpp:
(WebCore::HTMLModElement::isURLAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isURLAttribute):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLAttribute):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::isURLAttribute):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::isURLAttribute):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::isURLAttribute):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::isURLAttribute):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isURLAttribute):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::isURLAttribute):

LayoutTests:

* fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added.
* fast/dom/MicroData/itemid-attribute-test-001.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
jchaffraix@webkit.org [Wed, 9 Nov 2011 19:28:12 +0000 (19:28 +0000)]
Unreviewed build fix.

* DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::makeJSAccessibilityUIElement):
A bad merge added this check that is making the bots sad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: crash when accessing selectedTab in a tab list
cfleizach@apple.com [Wed, 9 Nov 2011 19:08:03 +0000 (19:08 +0000)]
AX: crash when accessing selectedTab in a tab list
https://bugs.webkit.org/show_bug.cgi?id=70938

Reviewed by Beth Dakin.

Source/WebCore:

There were a few methods accessing m_children directly without first validating that those elements
needed to be updated (because the layout changed). Changing those to call children() ensures
that they will have the correct children.

Test: platform/mac/accessibility/selected-tab-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isChecked):
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):

Tools:

Add the ability to retrieve an element through an arbitrary attribute.

* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementAttributeValueCallback):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementAttributeValue):

LayoutTests:

* platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
* platform/mac/accessibility/selected-tab-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove failures fixed with r99630.
ojan@chromium.org [Wed, 9 Nov 2011 19:03:20 +0000 (19:03 +0000)]
Remove failures fixed with r99630.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK new baselines for 2 svg tests and skip a crashing
philn@webkit.org [Wed, 9 Nov 2011 18:46:15 +0000 (18:46 +0000)]
Unreviewed, GTK new baselines for 2 svg tests and skip a crashing
test that needs investigation.

* platform/gtk/Skipped:
* platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r99616.
xji@chromium.org [Wed, 9 Nov 2011 18:44:25 +0000 (18:44 +0000)]
Rebaseline after r99616.

* platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing build on MacOSX SL after 71838
achicu@adobe.com [Wed, 9 Nov 2011 18:41:14 +0000 (18:41 +0000)]
Fixing build on MacOSX SL after 71838
https://bugs.webkit.org/show_bug.cgi?id=71912

Reviewed by Anders Carlsson.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink HTMLCollection.
andreas.kling@nokia.com [Wed, 9 Nov 2011 18:14:09 +0000 (18:14 +0000)]
Shrink HTMLCollection.
<http://webkit.org/b/71928>

Reviewed by Darin Adler.

Rearrange the members of HTMLCollection, effectively shrinking
it by 16 bytes on 64-bit. This reduces memory consumption
by 531 kB when loading the full HTML5 spec.

On 32-bit it shrinks by 8 bytes, saving 265 kB.

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd code path in HashTable for emptyValueIsZero that does not require copying the...
darin@apple.com [Wed, 9 Nov 2011 18:11:47 +0000 (18:11 +0000)]
Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
https://bugs.webkit.org/show_bug.cgi?id=71875

Reviewed by Anders Carlsson.

This is a step along the path of making OwnPtr work as HashMap value types.

* wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.
Also fixed include style. To include other WTF headers inside WTF, we use "" includes.
I did not change the code to fix style checker complaints.

* wtf/HashTable.h: Added includes as needed and fixed include style.
(WTF::doubleHash): Removed the uneeeded and inappropriate "static" in this function, which
gave it internal linkage for no good reason.
(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
construction/destruction problems instead of doing the trick where we construct and destroy
an empty value twice. It's cleaner and simpler and avoids copying the empty value.
(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
empty value is zero rather than copying an empty value.

* wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove redundant [CanBeConstructed] IDLs
haraken@chromium.org [Wed, 9 Nov 2011 18:07:12 +0000 (18:07 +0000)]
Remove redundant [CanBeConstructed] IDLs
https://bugs.webkit.org/show_bug.cgi?id=71868

Reviewed by Adam Barth.

If a class has [Constructor] or [CustomConstructor],
then [CanBeConstructed] is not necessary.
This patch just removes [CanBeConstructed] from all the classes
that already have [Constructor] or [CustomConstructor].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
* bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.
(WebCore::ConfigureV8TestObjTemplate):
* css/WebKitCSSMatrix.idl:
* dom/BeforeLoadEvent.idl:
* dom/CustomEvent.idl:
* dom/ErrorEvent.idl:
* dom/Event.idl:
* dom/HashChangeEvent.idl:
* dom/MessageChannel.idl:
* dom/MessageEvent.idl:
* dom/OverflowEvent.idl:
* dom/PageTransitionEvent.idl:
* dom/PopStateEvent.idl:
* dom/ProgressEvent.idl:
* dom/WebKitAnimationEvent.idl:
* dom/WebKitMutationObserver.idl:
* dom/WebKitTransitionEvent.idl:
* fileapi/FileReader.idl:
* html/DOMFormData.idl:
* html/TextTrackCue.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/track/TrackEvent.idl:
* mediastream/PeerConnection.idl:
* page/EventSource.idl:
* page/WebKitPoint.idl:
* webaudio/AudioContext.idl:
* websockets/CloseEvent.idl:
* websockets/WebSocket.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
* xml/XMLHttpRequest.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG foreignObject wrong container
commit-queue@webkit.org [Wed, 9 Nov 2011 18:02:50 +0000 (18:02 +0000)]
SVG foreignObject wrong container
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Simon Fraser.

Source/WebCore:

Resubmitting a patch originally by scottmg@chromium.org.
In determining where to add to m_positionedObjects during a repaint,
containingBlock is used, which adds the absolute positioned object to
the containing foreignObject. But, when the contained object is
dirtied, container() was used to dirty up the tree, which skipped over
the foreignObject causing the wrong parent to needsLayout(). This fix
makes container() and containingBlock() handle svg foreignObject's in
the same way.

This patch will cause svg/overflow/overflow-on-foreignObject.svg to
require rebaselined results on qt and gtk ports.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):

LayoutTests:

Added layout test for 64780 fix, rebaselined a test that it broke.
This will cause gtk and qt ports to also need rebaseline.

* platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
* platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
* svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
* svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink StyleSheet on 64-bit.
andreas.kling@nokia.com [Wed, 9 Nov 2011 18:01:04 +0000 (18:01 +0000)]
Shrink StyleSheet on 64-bit.
<http://webkit.org/b/71923>

Reviewed by Darin Adler.

Move m_disabled to the top so it folds into the padding at
the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.

* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
* css/StyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd webkitdirs.pm:getArchitecture implementation for GTK
commit-queue@webkit.org [Wed, 9 Nov 2011 17:40:35 +0000 (17:40 +0000)]
Add webkitdirs.pm:getArchitecture implementation for GTK
https://bugs.webkit.org/show_bug.cgi?id=71370

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Xan Lopez.

* Scripts/webkitdirs.pm (determineArchitecture): Add an
implementation for ports using autotools, so that a vanilla
`run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
to build-jsc on x86-64 machines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
commit-queue@webkit.org [Wed, 9 Nov 2011 17:32:47 +0000 (17:32 +0000)]
[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=71891

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-09
Reviewed by Antonio Gomes.

This is C++ code, there is no need to cast the new objects to their
parents when creating them.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, attempt to fix GTK 32-bits Release build after r99691.
philn@webkit.org [Wed, 9 Nov 2011 17:32:22 +0000 (17:32 +0000)]
Unreviewed, attempt to fix GTK 32-bits Release build after r99691.

* Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding missing implementation of WebMediaStreamDescriptor::label().
commit-queue@webkit.org [Wed, 9 Nov 2011 17:07:42 +0000 (17:07 +0000)]
Adding missing implementation of WebMediaStreamDescriptor::label().

[Chromium] Missing WebMediaStreamDescriptor::label() implementation
https://bugs.webkit.org/show_bug.cgi?id=71657

Patch by Henrik Grunell <grunell@chromium.org> on 2011-11-09
Reviewed by Adam Barth.

* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2] Prepare viewport meta handling for desktop usage
kenneth@webkit.org [Wed, 9 Nov 2011 17:01:49 +0000 (17:01 +0000)]
[WebKit2] Prepare viewport meta handling for desktop usage
https://bugs.webkit.org/show_bug.cgi?id=71907

Reviewed by Simon Hausmann.

This is only used by Qt so far. Now we don't always layout pages
without the viewport meta tag, using 980 as the layout width, but
instead we use that value (it is a setting) as a minimum value, or
else we use the viewport width.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportSize):
(QTouchWebViewPrivate::updateViewportConstraints):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 9 Nov 2011 16:31:48 +0000 (16:31 +0000)]
2011-11-09  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: make new inspector test pass on Qt.

        * http/tests/inspector-enabled/injected-script-discard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEsperanto-translation
commit-queue@webkit.org [Wed, 9 Nov 2011 16:29:45 +0000 (16:29 +0000)]
Esperanto-translation
https://bugs.webkit.org/show_bug.cgi?id=69760

Unreviewed.
Patch by Kristjan SCHMIDT <kristjan.schmidt@googlemail.com>

Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-09

* eo.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyleSheet: Devirtualize styleSheetChanged().
andreas.kling@nokia.com [Wed, 9 Nov 2011 16:19:29 +0000 (16:19 +0000)]
StyleSheet: Devirtualize styleSheetChanged().
<http://webkit.org/b/71913>

Reviewed by Antti Koivisto.

Since this mechanism is only used by CSSStyleSheet, move it there.
Out-of-lined StyleSheet::setDisabled() so we can do a type check
before invoking it from there.

* css/CSSStyleSheet.h:
* css/StyleSheet.cpp:
(WebCore::StyleSheet::setDisabled):
* css/StyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kbalazs@webkit.org [Wed, 9 Nov 2011 16:12:20 +0000 (16:12 +0000)]
[Qt] Unreviewed gardening.

Add platform results for Qt5.

* platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99707.
hausmann@webkit.org [Wed, 9 Nov 2011 15:58:33 +0000 (15:58 +0000)]
Unreviewed, rolling out r99707.
http://trac.webkit.org/changeset/99707

Re-enable until we can disable it together with tests in one
shot.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Disable use of QtUiTools if the library/module is not found
vestbo@webkit.org [Wed, 9 Nov 2011 15:52:02 +0000 (15:52 +0000)]
[Qt] Disable use of QtUiTools if the library/module is not found

We rely on the lookup order of prf files to inject our own uitools.prf
that will verify that QtUiTools is in fact present before allowing the
CONFIG += uitools to have any effect.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed, adding missing files to the build.
hausmann@webkit.org [Wed, 9 Nov 2011 15:46:49 +0000 (15:46 +0000)]
[Qt] Unreviewed, adding missing files to the build.

* Target.pri: Add ContentTypeParser.cpp/h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate
caseq@chromium.org [Wed, 9 Nov 2011 15:40:50 +0000 (15:40 +0000)]
Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71826

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/ScriptsPanel.js:

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 9 Nov 2011 15:35:11 +0000 (15:35 +0000)]
2011-11-09  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: annotate inspector front-end javascript so that it compiled again.

        * inspector/front-end/ShortcutsScreen.js:
        * inspector/front-end/WorkerManager.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r99711. (Signed/unsigned compare.)
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:31:05 +0000 (15:31 +0000)]
Unreviewed build fix after r99711. (Signed/unsigned compare.)

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
pfeldman@chromium.org [Wed, 9 Nov 2011 15:30:38 +0000 (15:30 +0000)]
Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=71842

These are the only WebKit-side changes needed. The rest will be done on the Chromium side.

Chromium bug: http://crbug.com/44350

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Pavel Feldman.

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::moveWindowBy):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::moveWindowBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Provisionally change StylesSidebarPane section DOM layout to allow...
apavlov@chromium.org [Wed, 9 Nov 2011 15:27:33 +0000 (15:27 +0000)]
Web Inspector: Provisionally change StylesSidebarPane section DOM layout to allow media queries
https://bugs.webkit.org/show_bug.cgi?id=71902

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
* inspector/elements/elements-delete-inline-style-expected.txt:
* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/commit-selector-expected.txt:
* inspector/styles/css-live-edit-expected.txt:
* inspector/styles/metrics-box-sizing-expected.txt:
* inspector/styles/metrics-box-sizing.html:
* inspector/styles/parse-utf8-bom-expected.txt:
* inspector/styles/parse-utf8-bom.html:
* inspector/styles/show-user-agent-styles-expected.txt:
* inspector/styles/show-user-agent-styles.html:
* inspector/styles/styles-add-blank-property-expected.txt:
* inspector/styles/styles-add-invalid-property-expected.txt:
* inspector/styles/styles-add-new-rule-expected.txt:
* inspector/styles/styles-cancel-editing-expected.txt:
* inspector/styles/styles-change-node-while-editing-expected.txt:
* inspector/styles/styles-commit-editing-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-disable-inherited-expected.txt:
* inspector/styles/styles-disable-then-change-expected.txt:
* inspector/styles/styles-disable-then-delete-expected.txt:
* inspector/styles/styles-formatting-expected.txt:
* inspector/styles/styles-formatting.html:
* inspector/styles/styles-iframe-expected.txt:
* inspector/styles/styles-source-lines-expected.txt:
* inspector/styles/styles-source-lines-inline-expected.txt:
* inspector/styles/styles-update-from-js-expected.txt:
* inspector/styles/up-down-numerics-and-colors-expected.txt:
* inspector/styles/up-down-numerics-and-colors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99701.
hausmann@webkit.org [Wed, 9 Nov 2011 15:12:58 +0000 (15:12 +0000)]
Unreviewed, rolling out r99701.
http://trac.webkit.org/changeset/99701

Breaks Qt mac build

Source/WebKit/qt:

* Api/qwebpage.cpp:
(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

* WebProcess/WebPage/qt/WebPageQt.cpp:
(initResources):
(WebKit::WebPage::platformInitialize):

Tools:

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSPrimitiveValue: Fix up bitfield member types.
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:10:09 +0000 (15:10 +0000)]
CSSPrimitiveValue: Fix up bitfield member types.
<http://webkit.org/b/71751>

Reviewed by Antti Koivisto.

The primitive unit type doesn't need to be a signed value,
and by making it unsigned, we can shave one bit off of it.
Furthermore, m_hasCachedCSSText and m_isQuirkValue should be
bool, not unsigned.

* css/CSSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Wed, 9 Nov 2011 15:09:05 +0000 (15:09 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/focus-rings-expected.txt: Added.
* platform/gtk/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: discard injected scripts upon front-end disconnect.
pfeldman@chromium.org [Wed, 9 Nov 2011 15:04:56 +0000 (15:04 +0000)]
Web Inspector: discard injected scripts upon front-end disconnect.
https://bugs.webkit.org/show_bug.cgi?id=71823

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector-enabled/injected-script-discard.html

* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::clearFrontend):

LayoutTests:

* http/tests/inspector-enabled/injected-script-discard-expected.txt: Added.
* http/tests/inspector-enabled/injected-script-discard.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS: Remove empty value and rule destructors.
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:03:40 +0000 (15:03 +0000)]
CSS: Remove empty value and rule destructors.
<http://webkit.org/b/71901>

Reviewed by Antti Koivisto.

* css/CSSAspectRatioValue.h:
* css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::create):
* css/CSSBorderImageValue.h:
(WebCore::CSSBorderImageValue::create):
* css/CSSCharsetRule.cpp:
* css/CSSCharsetRule.h:
* css/CSSCrossfadeValue.h:
* css/CSSFlexValue.h:
* css/CSSFontFaceSrcValue.h:
* css/CSSFunctionValue.h:
* css/CSSPageRule.cpp:
* css/CSSPageRule.h:
* css/CSSUnicodeRangeValue.h:
* css/CSSValueList.h:
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSTransformValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Prospective build fix for Win32/Mac with xmlpatterns
hausmann@webkit.org [Wed, 9 Nov 2011 15:02:41 +0000 (15:02 +0000)]
[Qt] Prospective build fix for Win32/Mac with xmlpatterns

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/features.prf: Disable XSLT support initially.
We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
is not up to the task of full XSLT support, so we should disable it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:00:26 +0000 (15:00 +0000)]
CSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
<http://webkit.org/b/71897>

Reviewed by Antti Koivisto.

Everything that inherits from RefCounted<T> is already fast-allocated,
so we don't need this in subclasses.

* css/CSSImageValue.h:
* css/CSSImportRule.h:
* css/WebKitCSSShaderValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline and skip a crashing test.
philn@webkit.org [Wed, 9 Nov 2011 14:58:20 +0000 (14:58 +0000)]
Unreviewed, GTK rebaseline and skip a crashing test.

* platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-table.html
* platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] failures in http/tests/security/contentSecurityPolicy with Qt5
kbalazs@webkit.org [Wed, 9 Nov 2011 14:51:33 +0000 (14:51 +0000)]
[Qt] failures in http/tests/security/contentSecurityPolicy with Qt5
https://bugs.webkit.org/show_bug.cgi?id=71906

Unreviewed gardening. Skip failing tests.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TextureMapper] Clean up TextureMapperAnimation constructor
igor.oliveira@openbossa.org [Wed, 9 Nov 2011 14:45:09 +0000 (14:45 +0000)]
[TextureMapper] Clean up TextureMapperAnimation constructor
https://bugs.webkit.org/show_bug.cgi?id=71892

Remove copyAnimationValue and copyTimingFunction static functions. KeyframeList has
a copy constructor and it does not need anymore these copy functions.

Reviewed by Simon Hausmann.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperAnimation::TextureMapperAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning...
kbalazs@webkit.org [Wed, 9 Nov 2011 14:40:58 +0000 (14:40 +0000)]
[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html fails
https://bugs.webkit.org/show_bug.cgi?id=71896

Unreviewed gardening.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/qt: [Qt] Enable exports and constructor functions in static libs
hausmann@webkit.org [Wed, 9 Nov 2011 14:40:04 +0000 (14:40 +0000)]
Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/functions.prf: Use --whole-archive and their
mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildfix for 32bit debug mode.
rgabor@webkit.org [Wed, 9 Nov 2011 14:07:24 +0000 (14:07 +0000)]
Buildfix for 32bit debug mode.

Reviewed by Csaba Osztrogonác.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::dump):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] 4 Layout test fail due to network error constant values clash with WebkitError...
commit-queue@webkit.org [Wed, 9 Nov 2011 14:00:52 +0000 (14:00 +0000)]
[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
https://bugs.webkit.org/show_bug.cgi?id=71554

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-11-09
Reviewed by Simon Hausmann.

Source/WebKit/qt:

We should check the error domain when checking the error code in shouldFallBack()

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::shouldFallBack): added error domain check

LayoutTests:

Un-skip the 4 failing layout test, we now check the error domain along with the error code in shouldFallBack()

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
kbalazs@webkit.org [Wed, 9 Nov 2011 13:59:39 +0000 (13:59 +0000)]
WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42331

Unreviewed. Skip dependent test.

* platform/wk2/Skipped: Skip http/tests/security/xssAuditor/script-tag-with-callbacks-actual.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Some passing tests removed from Skipped list
ossy@webkit.org [Wed, 9 Nov 2011 13:58:18 +0000 (13:58 +0000)]
[Qt] Some passing tests removed from Skipped list
https://bugs.webkit.org/show_bug.cgi?id=45598
https://bugs.webkit.org/show_bug.cgi?id=32961
http://bugreports.qt.nokia.com/browse/QTBUG-15566

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-11-09
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable the DFG JIT on X86-64 Linux platforms
ossy@webkit.org [Wed, 9 Nov 2011 13:55:41 +0000 (13:55 +0000)]
Enable the DFG JIT on X86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Csaba Osztrogonác.

* wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the
x86-64 GNU/Linux platform.
* CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Part 1] Parse the custom() function in -webkit-filter
achicu@adobe.com [Wed, 9 Nov 2011 13:55:13 +0000 (13:55 +0000)]
[Part 1] Parse the custom() function in -webkit-filter
https://bugs.webkit.org/show_bug.cgi?id=71441

Source/WebCore:

Added code that parses the custom() function. There's no code
for the CSSStyleSelector yet, so the only way to test this was to
check the "styleSheets" rules.

Reviewed by Dean Jackson.

Tests: css3/filters/custom-filter-property-parsing-invalid.html
       css3/filters/custom-filter-property-parsing.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedFilter):
* css/CSSParser.cpp:
(WebCore::filterInfoForName):
(WebCore::acceptCommaOperator):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::filterOperationForType):
(WebCore::CSSStyleSelector::createFilterOperations):
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSShaderValue):
* css/CSSValueKeywords.in:
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::typeUsesSpaceSeparator):
(WebCore::WebKitCSSFilterValue::customCssText):
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSShaderValue.h: Added.
(WebCore::WebKitCSSShaderValue::create):
(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
* platform/graphics/filters/FilterOperation.h:

LayoutTests:

Reviewed by Dean Jackson.

* css3/filters/custom-filter-property-parsing-expected.txt: Added.
* css3/filters/custom-filter-property-parsing-invalid-expected.txt: Added.
* css3/filters/custom-filter-property-parsing-invalid.html: Added.
* css3/filters/custom-filter-property-parsing.html: Added.
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js: Added.
(testInvalidFilterRule):
* css3/filters/script-tests/custom-filter-property-parsing.js: Added.
(jsWrapperClass):
(expression):
(description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix geolocation enabled build.
hausmann@webkit.org [Wed, 9 Nov 2011 13:41:31 +0000 (13:41 +0000)]
[Qt] Fix geolocation enabled build.

Reviewed by Tor Arne Vestbø.

* Target.pri: Add QT += location to get the right module includes.
* UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file with the right name (GeoLocation -> Geolocation)
* UIProcess/qt/WebGeolocationProviderQt.h: Removed the ENABLE(GEOLOCATION) guards, otherwise moc doesn't generate
code, because it can't interpret the ENABLE() macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable the DFG JIT on x86-64 Linux platforms
ossy@webkit.org [Wed, 9 Nov 2011 13:31:59 +0000 (13:31 +0000)]
Enable the DFG JIT on x86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373

Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686

Buildfix for stricter compilers: -Werror=unused-but-set-variable

Reviewed by Zoltan Herczeg.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: exception in remote front-end load handler due to undefined reference...
yurys@chromium.org [Wed, 9 Nov 2011 13:19:43 +0000 (13:19 +0000)]
Web Inspector: exception in remote front-end load handler due to undefined reference to workerManager
https://bugs.webkit.org/show_bug.cgi?id=71889

Move calls to WorkerManager load handlers into doLoadedDone method which is
called in case of remote front-end too.

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.js:
(WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][DRT] window internals object is not reset after each test
philn@webkit.org [Wed, 9 Nov 2011 13:14:34 +0000 (13:14 +0000)]
[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Xan Lopez.

Source/WebKit/gtk:

DRTSupport infrastructure to reset the Internals object, like in Qt.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest): reset the Internals object after each test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Detect presence of QtUiTools and enable it only when available
vestbo@webkit.org [Wed, 9 Nov 2011 13:03:58 +0000 (13:03 +0000)]
[Qt] Detect presence of QtUiTools and enable it only when available

The disable_uitools option was a workaround for missing detection.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
vsevik@chromium.org [Wed, 9 Nov 2011 13:02:03 +0000 (13:02 +0000)]
Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
https://bugs.webkit.org/show_bug.cgi?id=71850

Reviewed by Pavel Feldman.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):
* inspector/front-end/ApplicationCacheModel.js: Added.
(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.getApplicationCachesAsync):
(WebInspector.ApplicationCacheDispatcher):
(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._initializeApplicationCacheModel):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Removed unused variable
commit-queue@webkit.org [Wed, 9 Nov 2011 13:01:45 +0000 (13:01 +0000)]
[EFL] Removed unused variable
https://bugs.webkit.org/show_bug.cgi?id=71877

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-09
Reviewed by Andreas Kling.

Removed unused rect variable declaration and renamed rect1 variable to rect.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_smart_calculate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] nrwt pixeltests crash while test
loki@webkit.org [Wed, 9 Nov 2011 12:42:13 +0000 (12:42 +0000)]
[WK2] nrwt pixeltests crash while test
https://bugs.webkit.org/show_bug.cgi?id=71688

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2011-11-09
Reviewed by Zoltan Herczeg.

* platform/qt-5.0/Skipped:
'editing/pasteboard/data-transfer-items-image-png.html' is skipped, because it caused an nrwt pixel test crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeEl...
vsevik@chromium.org [Wed, 9 Nov 2011 11:58:02 +0000 (11:58 +0000)]
Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=71848

Reviewed by Pavel Feldman.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.BaseStorageTreeElement.prototype.onattach):
(WebInspector.BaseStorageTreeElement.prototype.get displayName):
(WebInspector.BaseStorageTreeElement.prototype._updateDisplayName):
(WebInspector.BaseStorageTreeElement.prototype._updateTitle):
(WebInspector.BaseStorageTreeElement.prototype._updateSubtitle):
(WebInspector.BaseStorageTreeElement.prototype.set titleText):
(WebInspector.BaseStorageTreeElement.prototype.get subtitleText):
(WebInspector.BaseStorageTreeElement.prototype.set subtitleText):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.FrameTreeElement.prototype.get itemURL):
(WebInspector.FrameTreeElement.prototype.onselect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Don't override config for the build_pass of debug_and_release
vestbo@webkit.org [Wed, 9 Nov 2011 11:56:05 +0000 (11:56 +0000)]
[Qt] Don't override config for the build_pass of debug_and_release

Qmake will parse the profile once for each configuration (debug and
release), with the build_pass option set. In that situation we don't
want to override what qmake is setting explicitly, otherwise the
debug-step will end up hitting all the release-scopes.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Only copy framework headers once when debug_and_release is enabled
vestbo@webkit.org [Wed, 9 Nov 2011 11:55:49 +0000 (11:55 +0000)]
[Qt] Only copy framework headers once when debug_and_release is enabled

Otherwise we might end up in a race condition where we try to symlink
the headers directory in the makefile for debug and release at the same
time.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: crash upon InspectorValue serialization that has 0 value / array entry.
pfeldman@chromium.org [Wed, 9 Nov 2011 11:49:13 +0000 (11:49 +0000)]
Web Inspector: crash upon InspectorValue serialization that has 0 value / array entry.
https://bugs.webkit.org/show_bug.cgi?id=71806

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/resolve-alien-node.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::resolveNode):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::setValue):
(WebCore::InspectorObject::setObject):
(WebCore::InspectorObject::setArray):
(WebCore::InspectorArray::pushValue):
(WebCore::InspectorArray::pushObject):
(WebCore::InspectorArray::pushArray):

LayoutTests:

* inspector/elements/resolve-alien-node-expected.txt: Added.
* inspector/elements/resolve-alien-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. HiDPI is supported after r97407.
sergio@webkit.org [Wed, 9 Nov 2011 11:47:58 +0000 (11:47 +0000)]
Unreviewed. HiDPI is supported after r97407.

* platform/gtk/Skipped: unskipped fast/hidpi
* platform/gtk-wk2/Skipped: unskipped fast/hidpi

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99678.
hausmann@webkit.org [Wed, 9 Nov 2011 11:26:52 +0000 (11:26 +0000)]
Unreviewed, rolling out r99678.
http://trac.webkit.org/changeset/99678
https://bugs.webkit.org/show_bug.cgi?id=71882

broke the build with -Werror=unused-but-set-variable
(Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-09

* CMakeListsEfl.txt:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unbreak the Qt build (copy & paste mistake - oops)
hausmann@webkit.org [Wed, 9 Nov 2011 11:19:29 +0000 (11:19 +0000)]
[Qt] Unbreak the Qt build (copy & paste mistake - oops)

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove CSSPrimitiveValue bitfields up into CSSValue.
andreas.kling@nokia.com [Wed, 9 Nov 2011 11:12:27 +0000 (11:12 +0000)]
Move CSSPrimitiveValue bitfields up into CSSValue.
<http://webkit.org/b/71835>

Reviewed by Darin Adler.

Move m_type (and rename it to m_primitiveUnitType),
m_hasCachedCSSText and m_isQuirkValue from CSSPrimitiveValue
up into CSSValue to share the space.

This, together with the devirtualization of CSSValue that
happened on <http://webkit.org/b/71666>, reduces the size
of CSSPrimitiveValue by one CPU word.

More specifically, we go from 16 to 12 bytes on 32-bit,
and from 24 to 16 bytes on 64-bit.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::getRGBColorValue):
(WebCore::CSSPrimitiveValue::getPairValue):
(WebCore::CSSPrimitiveValue::getIdent):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::setPrimitiveType):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getQuadValue):
(WebCore::CSSPrimitiveValue::getRGBA32Value):
(WebCore::CSSPrimitiveValue::getPairValue):
(WebCore::CSSPrimitiveValue::getDashboardRegionValue):
(WebCore::CSSPrimitiveValue::getShapeValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
* css/CSSValue.h:
(WebCore::CSSValue::CSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable the DFG JIT on X86-64 Linux platforms
commit-queue@webkit.org [Wed, 9 Nov 2011 11:03:41 +0000 (11:03 +0000)]
Enable the DFG JIT on X86-64 Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=71373

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Filip Pizlo.

* wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the
x86-64 GNU/Linux platform.
* CMakeListsEfl.txt: Add JSValue64 implementations to EFL build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed. Update platform specific expected results again.
rgabor@webkit.org [Wed, 9 Nov 2011 10:46:49 +0000 (10:46 +0000)]
[Qt] Unreviewed. Update platform specific expected results again.

* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Centralize duplicated code for linking the static libs
hausmann@webkit.org [Wed, 9 Nov 2011 10:37:31 +0000 (10:37 +0000)]
[Qt] Centralize duplicated code for linking the static libs

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/functions.prf:
* qmake/mkspecs/features/javascriptcore.prf:
* qmake/mkspecs/features/webcore.prf:
* qmake/mkspecs/features/webkit2.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSObject::defineOwnProperty
mhahnenberg@apple.com [Wed, 9 Nov 2011 10:18:04 +0000 (10:18 +0000)]
De-virtualize JSObject::defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=71429

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Arguments.cpp:
(JSC::Arguments::createStrictModeCallerIfNecessary):
(JSC::Arguments::createStrictModeCalleeIfNecessary):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defineOwnProperty):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperty):
(JSC::defineProperties):

Source/WebCore:

No new tests.

Added defineOwnProperty to the MethodTable, changed all the virtual
implementations of defineOwnProperty to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineOwnProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::defineOwnProperty):
* bindings/js/JSDOMWindowShell.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, remove incorrect pixel image for relative-sized-document-scrol...
yutak@chromium.org [Wed, 9 Nov 2011 10:11:53 +0000 (10:11 +0000)]
[Chromium] Unreviewed, remove incorrect pixel image for relative-sized-document-scrollbars.svg.

* platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake [CanBeConstructed] IDL redundant
haraken@chromium.org [Wed, 9 Nov 2011 09:56:44 +0000 (09:56 +0000)]
Make [CanBeConstructed] IDL redundant
https://bugs.webkit.org/show_bug.cgi?id=71871

Reviewed by Adam Barth.

As the first step to remove [CanBeConstructed] IDL completely,
we need to make [CanBeConstructed] IDL redundant.
This patch replaces '[CanBeConstructed]' in CodeGeneratorV8.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]',
and replaces '[CanBeConstructed]' in CodeGeneratorJS.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [JSCustomConstructor]'

An example:
    before: '[CanBeConstructed] and ![V8CustomConstructor]'
    after: '([CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]) and ![V8CustomConstructor]' <==> '([CanBeConstructed] or [Constructor] or [CustomConstructor]) and ![V8CustomConstructor]'

Tests: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorJS.pm: Modified as I described above.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Updated a run-bindings-tests result.
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::JSTestObjConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::V8TestObj::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT.
yutak@chromium.org [Wed, 9 Nov 2011 09:50:01 +0000 (09:50 +0000)]
[Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected.
rgabor@webkit.org [Wed, 9 Nov 2011 09:42:03 +0000 (09:42 +0000)]
[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected.

* platform/qt/fast/forms/listbox-clip-expected.png:
* platform/qt/fast/forms/listbox-clip-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac.
yutak@chromium.org [Wed, 9 Nov 2011 09:25:30 +0000 (09:25 +0000)]
[Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 9 Nov 2011 09:15:48 +0000 (09:15 +0000)]
2011-11-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        svg failures after r99561
        https://bugs.webkit.org/show_bug.cgi?id=71830

        Reviewed by Antti Koivisto.

        Fix regressions in svg/zoom/page/relative-sized-document-scrollbars.svg and svg/zoom/page/zoom-svg-as-relative-image.html.
        Fix merging problem in r99561, bug 71780. It moved several methods from SVGLength to SVGLengthContext, and unfortunately
        the SVGLength changes part of r98852, bug 47156, got reverted again, making these two tests fail.

        * svg/SVGLengthContext.cpp:
        (WebCore::SVGLengthContext::determineViewport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline tests added in r99613. Check in correct baselines for
yutak@chromium.org [Wed, 9 Nov 2011 09:14:10 +0000 (09:14 +0000)]
[Chromium] Rebaseline tests added in r99613. Check in correct baselines for
the Mac Skia bots.

* platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Removed.
* platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Removed.
* platform/chromium/fast/multicol/pagination-h-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png.
* platform/chromium/fast/multicol/pagination-h-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png.
* platform/chromium/fast/multicol/pagination-h-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png.
* platform/chromium/fast/multicol/pagination-h-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png.
* platform/chromium/fast/multicol/pagination-v-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png.
* platform/chromium/fast/multicol/pagination-v-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png.
* platform/chromium/fast/multicol/pagination-v-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png.
* platform/chromium/fast/multicol/pagination-v-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSelect multiple options with mouse drag in Select element.
commit-queue@webkit.org [Wed, 9 Nov 2011 08:56:36 +0000 (08:56 +0000)]
Select multiple options with mouse drag in Select element.
https://bugs.webkit.org/show_bug.cgi?id=71128

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Ryosuke Niwa.

Multiple selection of option elements in select element with an mouse drag.
Other browsers(IE, Firefox, Opera) support this feature.

Source/WebCore:

Test: fast/forms/select-multiple-elements-with-mouse-drag.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
Allow auto scroll to be fired if current node(option) under mouse does not have renderer
but its container node(select) can autoscroll and has renderer for specific case of ListBox

LayoutTests:

* fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
* fast/forms/select-multiple-elements-with-mouse-drag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99667 268f45cc-cd09-0410-ab3c-d52691b4dbfc