WebKit-https.git
8 years agoDe-virtualize JSObject::defineSetter
mhahnenberg@apple.com [Wed, 2 Nov 2011 00:36:20 +0000 (00:36 +0000)]
De-virtualize JSObject::defineSetter
https://bugs.webkit.org/show_bug.cgi?id=71303

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineSetter):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defineSetter):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineSetter):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineSetter):

Source/WebCore:

No new tests.

Added defineSetter to the MethodTable, changed all the virtual
implementations of defineSetter to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineSetter):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::defineSetter):
* bindings/js/JSDOMWindowShell.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG Filter on a group doesn't invalidate when children are moved
timothy_horton@apple.com [Wed, 2 Nov 2011 00:34:14 +0000 (00:34 +0000)]
SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>

Reviewed by Darin Adler.

Fix svg/filters/invalidate-on-child-layout.svg to not include nonexistent onload handler.

* svg/filters/invalidate-on-child-layout.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch PopupMenuClient to layout abstraction
eae@chromium.org [Wed, 2 Nov 2011 00:15:10 +0000 (00:15 +0000)]
Switch PopupMenuClient to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71308

Reviewed by Darin Adler.

Switch PopupMenuClient and rendering classes implementing it to layout
type abstraction.

No new tests.

* platform/PopupMenuClient.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::scrollSize):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
Revert scroll positions and scroll offsets to ints to align with device
pixels.

* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):
* rendering/RenderMenuList.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
* rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [chromium] As of r98380, ThreadableLoaderClients are having their
japhet@chromium.org [Wed, 2 Nov 2011 00:09:18 +0000 (00:09 +0000)]
Source/WebCore: [chromium] As of r98380, ThreadableLoaderClients are having their
ResourceRequest::TargetType clobbered. They set their own
type, but CachedResourceRequest (through which they now flow)
sets a TargetType without bothering to see if one has already been set.
https://bugs.webkit.org/show_bug.cgi?id=70972

Reviewed by Darin Fisher.

No new tests, this is chromium-specific and only affects
behavior seen in full builds of chromium.

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):Don't setTargetType()
    if the value is something other than the default already.
* platform/network/chromium/ResourceRequest.h: Change default
    TargetType to TargetIsUnspecified.

Source/WebKit/chromium: Add 2 new TargetTypes (to match ResourceRequest::TargetType)
and ensure we don't pass chromium a TargetType it doesn't
yet understand.
https://bugs.webkit.org/show_bug.cgi?id=70972

Reviewed by Darin Fisher.

* public/WebURLRequest.h:
* src/WebURLRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse IntPoint for screen coordinates in MouseEvent
eae@chromium.org [Wed, 2 Nov 2011 00:08:04 +0000 (00:08 +0000)]
Use IntPoint for screen coordinates in MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=71327

Reviewed by Darin Adler.

Change mouse events to use int/IntPoint for screen/window coordinates and
LayoutUnit/LayoutPoint for coordinates adjusted for zooming.

No new tests.

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::computeRelativePosition):
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::screenLocation):
Revert screenLocation and windowLocation back to int.

* page/DragController.cpp:
(WebCore::elementUnderMouse):
Change elementUnderMouse to use a LayoutPoint for hit testing.

* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
* page/EventHandler.h:
Revert m_currentMousePosition to IntPoint as it represents a
screen coordinate.

* platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):
Revert PlatformMouseEvent to int/IntPoint as it represents a screen
coordinate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: -webkit-flex() should be an invalid value
tony@chromium.org [Tue, 1 Nov 2011 23:58:57 +0000 (23:58 +0000)]
REGRESSION: -webkit-flex() should be an invalid value
https://bugs.webkit.org/show_bug.cgi?id=71320

Reviewed by Ojan Vafai.

This regressed in http://trac.webkit.org/changeset/98773 .

No new tests, covered by css3/flexbox/flex-parsing.html.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline getter-on-window-object2.html after r99005.
johnnyg@google.com [Tue, 1 Nov 2011 23:53:19 +0000 (23:53 +0000)]
Rebaseline getter-on-window-object2.html after r99005.

* platform/chromium/fast/dom/getter-on-window-object2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: get EventQueue from ScriptExecutionContext instead of Document
dgrogan@chromium.org [Tue, 1 Nov 2011 23:33:04 +0000 (23:33 +0000)]
IndexedDB: get EventQueue from ScriptExecutionContext instead of Document
https://bugs.webkit.org/show_bug.cgi?id=71147

When IDB is used from a worker thread ScriptExecutionContext will
be a WorkerContext, not a Document.  This was the impetus behind
moving EventQueue into ScriptExecutionContext in r98656.

Reviewed by Nate Chapin.

No new tests. No new functionality yet.

* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::enqueueEvent):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::enqueueEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::enqueueEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS: Remove unused virtual parseString() in style and keyframe rules.
commit-queue@webkit.org [Tue, 1 Nov 2011 23:31:23 +0000 (23:31 +0000)]
CSS: Remove unused virtual parseString() in style and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=71300

Patch by Andreas Kling <kling@webkit.org> on 2011-11-01
Reviewed by Darin Adler.

* css/CSSStyleRule.cpp:
* css/CSSStyleRule.h:
* css/WebKitCSSKeyframeRule.cpp:
* css/WebKitCSSKeyframeRule.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG inlining breaks function.arguments
fpizlo@apple.com [Tue, 1 Nov 2011 23:13:57 +0000 (23:13 +0000)]
DFG inlining breaks function.arguments
https://bugs.webkit.org/show_bug.cgi?id=71329

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The DFG was forgetting to store code origin mappings for inlined
call sites. Some of the fast-path optimizations for
CallFrame::trueCallerFrame() were wrong. An assertion in Arguments
was wrong.

I also took the opportunity to decrease code duplication between
DFG64 and DFG32_64, because I didn't feel like writing the same
code twice.

* bytecode/CodeBlock.h:
(JSC::ExecState::isInlineCallFrame):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGNode.h:
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):

LayoutTests:

Reviewed by Oliver Hunt.

Test that using bar.arguments, where bar was inlined into baz,
works correctly.

* fast/js/dfg-inline-arguments-simple-expected.txt: Added.
* fast/js/dfg-inline-arguments-simple.html: Added.
* fast/js/script-tests/dfg-inline-arguments-simple.js: Added.
(foo):
(bar):
(baz):
(argsToStr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch RenderObject to layout abstraction
eae@chromium.org [Tue, 1 Nov 2011 23:02:17 +0000 (23:02 +0000)]
Switch RenderObject to layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=71249

Switch RenderObject to LayoutRect/Size/Point abstraction.

Reviewed by Darin Adler.

No new tests.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
(WebCore::RenderObject::addAbsoluteRectForLayer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::viewRect):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localCaretRect):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::maximalOutlineSize):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
* rendering/RenderObject.h:
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::absoluteOutlineBounds):
(WebCore::RenderObject::outlineBoundsForRepaint):
(WebCore::adjustForAbsoluteZoom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate result to match mac repaint result. When we forced a layout on
tony@chromium.org [Tue, 1 Nov 2011 23:01:59 +0000 (23:01 +0000)]
Update result to match mac repaint result.  When we forced a layout on
the test (when landing the mac-sl results), it caused this result to
change slightly.

* platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
alokp@chromium.org [Tue, 1 Nov 2011 22:53:14 +0000 (22:53 +0000)]
[chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71318

Reviewed by James Robinson.

Fixed a typo for --enable-hardware-gpu flag.

* Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpand fast/dom/getter-on-window-object2.html to test Object.getOwnPropertyDescriptor...
weinig@apple.com [Tue, 1 Nov 2011 22:36:54 +0000 (22:36 +0000)]
Expand fast/dom/getter-on-window-object2.html to test Object.getOwnPropertyDescriptor as well
https://bugs.webkit.org/show_bug.cgi?id=71332

Reviewed by Anders Carlsson.

* fast/dom/getter-on-window-object2-expected.txt:
* fast/dom/getter-on-window-object2.html:
Convert to shouldBe style tests and expand test to also test Object.getOwnPropertyDescriptor,
which currently fail for getters/setters defined over window properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Media Stream API: Adding supporting classes to WebPeerConnectionHandler
commit-queue@webkit.org [Tue, 1 Nov 2011 22:32:33 +0000 (22:32 +0000)]
[chromium] Media Stream API: Adding supporting classes to WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=71008

Expanding WebMediaStreamDescriptor and adding WebMediaStreamSource

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-01
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebMediaStreamDescriptor.h:
* public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/WebMediaStreamDescriptor.h.
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::~WebMediaStreamSource):
(WebKit::WebMediaStreamSource::isNull):
* src/AssertMatchingEnums.cpp:
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::initialize):
* src/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.
(WebKit::WebMediaStreamSource::WebMediaStreamSource):
(WebKit::WebMediaStreamSource::reset):
(WebKit::WebMediaStreamSource::operator PassRefPtr<MediaStreamSource>):
(WebKit::WebMediaStreamSource::operator MediaStreamSource*):
(WebKit::WebMediaStreamSource::initialize):
(WebKit::WebMediaStreamSource::id):
(WebKit::WebMediaStreamSource::type):
(WebKit::WebMediaStreamSource::name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSuppress svg/filters/invalidate-on-child-layout.svg until the fix lands.
johnnyg@google.com [Tue, 1 Nov 2011 22:12:30 +0000 (22:12 +0000)]
Suppress svg/filters/invalidate-on-child-layout.svg until the fix lands.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor: change Scrollable::m_scrollOrigin from protected to private.
xji@chromium.org [Tue, 1 Nov 2011 22:06:46 +0000 (22:06 +0000)]
Refactor: change Scrollable::m_scrollOrigin from protected to private.
https://bugs.webkit.org/show_bug.cgi?id=71236

Reviewed by Darin Adler.

Only refactor, no new tests needed.

* page/FrameView.cpp:
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
* platform/ScrollView.cpp:
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::computeScrollDimensions):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpand prototype setting test to test Object.defineProperty
weinig@apple.com [Tue, 1 Nov 2011 21:32:51 +0000 (21:32 +0000)]
Expand prototype setting test to test Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=71322

Reviewed by Anders Carlsson.

* fast/js/script-tests/prototypes.js:
Also test setting __proto__ using Object.defineProperty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodisplay: table-cell and box-sizing: border-box calculates content-box height
dominicc@chromium.org [Tue, 1 Nov 2011 20:55:57 +0000 (20:55 +0000)]
display: table-cell and box-sizing: border-box calculates content-box height
https://bugs.webkit.org/show_bug.cgi?id=69425

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/box-sizing/table-cell.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

* fast/box-sizing/table-cell-expected.txt: Added.
* fast/box-sizing/table-cell.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed. Remove media/audio-repaint.html from test expectaion.
imasaki@chromium.org [Tue, 1 Nov 2011 20:52:11 +0000 (20:52 +0000)]
[Chromium] Unreviewed. Remove media/audio-repaint.html from test expectaion.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCCSchedulerTests fail on Chromium Windows (dbg) after r98915
nduca@chromium.org [Tue, 1 Nov 2011 20:13:09 +0000 (20:13 +0000)]
CCSchedulerTests fail on Chromium Windows (dbg) after r98915
https://bugs.webkit.org/show_bug.cgi?id=71294

Reviewed by James Robinson.

* tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStringImpl::reallocate() should have a 8-bit version
commit-queue@webkit.org [Tue, 1 Nov 2011 19:52:29 +0000 (19:52 +0000)]
StringImpl::reallocate() should have a 8-bit version
https://bugs.webkit.org/show_bug.cgi?id=71210

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-11-01
Reviewed by Geoffrey Garen.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate):
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
commit-queue@webkit.org [Tue, 1 Nov 2011 19:28:52 +0000 (19:28 +0000)]
chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=71286

Patch by Elliot Poger <epoger@google.com> on 2011-11-01
Reviewed by Stephen White.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add remaining pixel baselines.
leandro@webkit.org [Tue, 1 Nov 2011 19:24:44 +0000 (19:24 +0000)]
[EFL] Unreviewed. Add remaining pixel baselines.

* platform/efl/http: Added.
* platform/efl/http/tests: Added.
* platform/efl/http/tests/local: Added.
* platform/efl/http/tests/local/file-url-sent-as-referer-expected.png: Added.
* platform/efl/http/tests/misc: Added.
* platform/efl/http/tests/misc/acid2-expected.png: Added.
* platform/efl/http/tests/misc/error404-expected.png: Added.
* platform/efl/http/tests/misc/favicon-as-image-expected.png: Added.
* platform/efl/http/tests/misc/frame-access-during-load-expected.png: Added.
* platform/efl/http/tests/misc/generated-content-inside-table-expected.png: Added.
* platform/efl/http/tests/misc/iframe404-expected.png: Added.
* platform/efl/http/tests/misc/location-replace-crossdomain-expected.png: Added.
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
* platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/efl/http/tests/navigation: Added.
* platform/efl/http/tests/navigation/error404-basic-expected.png: Added.
* platform/efl/http/tests/navigation/error404-goback-expected.png: Added.
* platform/efl/http/tests/navigation/error404-subframeload-expected.png: Added.
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/efl/http/tests/navigation/postredirect-basic-expected.png: Added.
* platform/efl/http/tests/navigation/postredirect-goback1-expected.png: Added.
* platform/efl/http/tests/security: Added.
* platform/efl/http/tests/security/contentSecurityPolicy: Added.
* platform/efl/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
* platform/efl/http/tests/uri: Added.
* platform/efl/http/tests/uri/css-href-expected.png: Added.
* platform/efl/scrollbars/basic-scrollbar-expected.png: Added.
* platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
* platform/efl/scrollbars/disabled-scrollbar-expected.png: Added.
* platform/efl/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
* platform/efl/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/efl/scrollbars/scrollbar-buttons-expected.png: Added.
* platform/efl/scrollbars/scrollbar-orientation-expected.png: Added.
* platform/efl/scrollbars/scrollbars-on-positioned-content-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add testing for --enable-accelerated-drawing
alokp@chromium.org [Tue, 1 Nov 2011 19:18:58 +0000 (19:18 +0000)]
[chromium] Add testing for --enable-accelerated-drawing
https://bugs.webkit.org/show_bug.cgi?id=70822

Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/accelerated-drawing/alpha.html

* WebCore.exp.in:
* page/Settings.cpp:
* page/Settings.h:
(WebCore::Settings::setAcceleratedDrawingEnabled):
* testing/Internals.cpp:
(WebCore::Internals::setAcceleratedDrawingEnabled):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Added.
* platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Added.
* platform/chromium/compositing/accelerated-drawing/alpha.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG Filter on a group doesn't invalidate when children are moved
timothy_horton@apple.com [Tue, 1 Nov 2011 19:13:54 +0000 (19:13 +0000)]
SVG Filter on a group doesn't invalidate when children are moved
https://bugs.webkit.org/show_bug.cgi?id=70044
<rdar://problem/10281530>

Reviewed by Nikolas Zimmermann.

Call SVGResourcesCache::clientLayoutChanged whenever the element or its children need layout. Previously,
invalidation was only performed if the element itself needed layout; now we also invalidate if any child
needs layout and there is a filter applied, as the cached filter result can depend on the layout of children.

Test: svg/filters/invalidate-on-child-layout.svg

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):

Add a test that ensures that changing the layout of a child of a filtered element invalidates the filter.

* platform/mac/svg/filters/invalidate-on-child-layout-expected.png: Added.
* platform/mac/svg/filters/invalidate-on-child-layout-expected.txt: Added.
* svg/filters/invalidate-on-child-layout.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFour media tests failing on Lion due to incorrect cached times.
jer.noble@apple.com [Tue, 1 Nov 2011 19:05:22 +0000 (19:05 +0000)]
Four media tests failing on Lion due to incorrect cached times.
https://bugs.webkit.org/show_bug.cgi?id=69574

Reviewed by Eric Carlson.

Source/WebCore:

Do not invalidate the cached time when receiving a mediaPlayerRateChanged notification
while paused. AVFoundation in particular can return different results for currentTime()
when asked after being paused, breaking layout tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):

LayoutTests:

Some media engines will cause multiple timeupdate events after pausing; so deregister
the timeupdate event listener after receiving the first one.

* media/video-pause-immediately.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoproperly end requests when a bad status code return happens
gavinp@chromium.org [Tue, 1 Nov 2011 18:54:51 +0000 (18:54 +0000)]
properly end requests when a bad status code return happens
https://bugs.webkit.org/show_bug.cgi?id=71122

Calling error without ending the request set up the CachedResourceRequest so that it could
actually send out two notifyFinished() events.  This probably was the root cause of
lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
of crashes in ScriptRunner/ScriptElement for instance.

The fix is easy: just properly end the request instead of just calling error, and we won't
re-notify.

Reviewed by Nate Chapin.

No new tests, as the problem wasn't very amenable to layout tests.
There is a chromium test going through code review at http://codereview.chromium.org/8404001/

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r98896.
rniwa@webkit.org [Tue, 1 Nov 2011 18:40:03 +0000 (18:40 +0000)]
Rebaseline after r98896.

* fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
* fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
* platform/chromium-win-vista/fast/forms: Removed.
* platform/chromium/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
arv@chromium.org [Tue, 1 Nov 2011 18:39:34 +0000 (18:39 +0000)]
Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
https://bugs.webkit.org/show_bug.cgi?id=64628

Reviewed by Adam Barth.

Covered by existing tests.

* html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r98979.
rniwa@webkit.org [Tue, 1 Nov 2011 18:37:28 +0000 (18:37 +0000)]
Rebaseline after r98979.

* fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
* fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
* platform/chromium-win-vista/fast/forms: Removed.
* platform/chromium/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Make API tests less noisy
abecsi@webkit.org [Tue, 1 Nov 2011 18:30:46 +0000 (18:30 +0000)]
[Qt][WK2] Make API tests less noisy
https://bugs.webkit.org/show_bug.cgi?id=71295

Reviewed by Simon Hausmann.

Suppress superfluous debug messages of Qt5.

* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
* UIProcess/API/qt/tests/util.cpp:
(messageHandler):
* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
leandro@webkit.org [Tue, 1 Nov 2011 18:30:37 +0000 (18:30 +0000)]
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

* platform/efl/fast/table: [...]
* platform/efl/fast/text: [...]
* platform/efl/fast/tokenizer: [...]
* platform/efl/fast/transforms: [...]
* platform/efl/fast/writing-mode: [...]
* platform/efl/fast/xsl: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed. Did rebaselines of media/audio-repaint.html
imasaki@chromium.org [Tue, 1 Nov 2011 18:07:45 +0000 (18:07 +0000)]
[Chromium] Unreviewed. Did rebaselines of media/audio-repaint.html

* platform/chromium-gpu-linux/media/audio-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowSt...
jchaffraix@webkit.org [Tue, 1 Nov 2011 18:02:42 +0000 (18:02 +0000)]
REGRESSION(98738): RenderTableSection::recalcCells does not properly shrink the RowStruct grid
https://bugs.webkit.org/show_bug.cgi?id=71246

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-empty-section-calcBorder.html
       fast/table/crash-empty-section-fixed-layout-calcArray.html

The refactoring in r98738 changed the way we handle the size to avoid throwing off
the memory. The new logic would end up never shrinking the grid's size (prior to that
we would grow to the appropriate size and throw the excess capacity with shrinkToFit).
Not shrinking would mean that we would potentially read RowStruct with the default values
(for instance no |rowRenderer|).

addCell will properly grow the grid as needed to accomodate the rows and the protruding
cells with a rowspan so we introduce a variable to keep track of the size needed. At the
end, we just shrink it to this size.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::recalcCells):
Introduce a variable to keep the grid size and shrink to that size to match the old code.

LayoutTests:

Those tests checks that an empty section would not lead to reading
RowStruct without a |rowRenderer| which would crash.

* fast/table/crash-empty-section-calcBorder-expected.txt: Added.
* fast/table/crash-empty-section-calcBorder.html: Added.
* fast/table/crash-empty-section-fixed-layout-calcArray-expected.txt: Added.
* fast/table/crash-empty-section-fixed-layout-calcArray.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed followup for the previous commit (removing another duplicate line).
caseq@chromium.org [Tue, 1 Nov 2011 17:59:49 +0000 (17:59 +0000)]
Unreviewed followup for the previous commit (removing another duplicate line).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
caseq@chromium.org [Tue, 1 Nov 2011 17:57:26 +0000 (17:57 +0000)]
[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
https://bugs.webkit.org/show_bug.cgi?id=71277

Reviewed by Simon Fraser.

Source/WebCore:

Disabled assert() in hasVisibleDescendant() until callers are fixed.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant):

LayoutTests:

* platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix ChangeLog which broke in r98733.
arv@chromium.org [Tue, 1 Nov 2011 17:31:07 +0000 (17:31 +0000)]
Unreviewed. Fix ChangeLog which broke in r98733.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
hausmann@webkit.org [Tue, 1 Nov 2011 17:19:52 +0000 (17:19 +0000)]
[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
https://bugs.webkit.org/show_bug.cgi?id=71299

Reviewed by Andreas Kling.

Source/WebKit/qt:

Export an overload of QtDRT::injectInternalsObjects that is used by
the WK2 injected bundle.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::injectInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
build to enable WebCoreTestSupport::injectInternalsObject.
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
leandro@webkit.org [Tue, 1 Nov 2011 17:11:21 +0000 (17:11 +0000)]
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

* platform/efl/fast/media: [...]
* platform/efl/fast/multicol: [...]
* platform/efl/fast/overflow: [...]
* platform/efl/fast/parser: [...]
* platform/efl/fast/reflections: [...]
* platform/efl/fast/regions: [...]
* platform/efl/fast/repaint: [...]
* platform/efl/fast/replaced: [...]
* platform/efl/fast/ruby: [...]
* platform/efl/fast/runin: [...]
* platform/efl/fast/selectors: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Merge common desktop and touch view APIs under a base class.
jocelyn.turcotte@nokia.com [Tue, 1 Nov 2011 17:05:30 +0000 (17:05 +0000)]
[Qt] Merge common desktop and touch view APIs under a base class.
https://bugs.webkit.org/show_bug.cgi?id=71280

Reviewed by Andreas Kling.

Source/WebKit2:

- Make QDesktopWebView and QTouchWebView inherit from QBaseWebView.
- Move methods from QTouchWebPage to QTouchWebView (through the base class).

We use the same convenience macros as Qt internally by hiding QObject::d_ptr
with QBaseWebView::d_ptr instead of inheriting QBaseWebViewPrivate from
QQuickItemPrivate.
Also, QBaseWebView currently inherits from QQuickPaintedItem since QDesktopWebView
needs it, but should be changed as soon as this is not required anymore.

* UIProcess/API/qt/qbasewebview.cpp: Added.
(QBaseWebViewPrivate::QBaseWebViewPrivate):
(QBaseWebViewPrivate::setPageProxy):
(QBaseWebView::QBaseWebView):
(QBaseWebView::~QBaseWebView):
(QBaseWebView::load):
(QBaseWebView::url):
(QBaseWebView::loadProgress):
(QBaseWebView::title):
(QBaseWebView::navigationController):
(QBaseWebView::preferences):
* UIProcess/API/qt/qbasewebview.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
* UIProcess/API/qt/qbasewebview_p.h: Copied from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
(QBaseWebViewPrivate::~QBaseWebViewPrivate):
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
(QDesktopWebViewPrivate::webView):
(QDesktopWebViewPrivate::setViewNeedsDisplay):
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::hasFocus):
(QDesktopWebViewPrivate::isVisible):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeUrl):
(QDesktopWebViewPrivate::didChangeTitle):
(QDesktopWebViewPrivate::didChangeStatusText):
(QDesktopWebViewPrivate::loadDidBegin):
(QDesktopWebViewPrivate::loadDidSucceed):
(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebViewPrivate::init):
(QDesktopWebView::~QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
(QDesktopWebView::pageRef):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
(QDesktopWebViewPrivate::engine):
(QDesktopWebViewPrivate::chooseFiles):
(QDesktopWebViewPrivate::_q_onOpenPanelFilesSelected):
(QDesktopWebViewPrivate::_q_onOpenPanelFinished):
(QDesktopWebViewPrivate::didMouseMoveOverElement):
(QDesktopWebViewPrivate::navigationPolicyForURL):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPageProxy):
(QTouchWebPagePrivate::paintToCurrentGLContext):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
(QTouchWebPagePrivate::touchPageProxy):
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebView::QTouchWebView):
(QTouchWebView::~QTouchWebView):
(QTouchWebView::page):
(QTouchWebView::geometryChanged):
(QTouchWebView::onVisibleChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qtouchwebview_p.h:
(QTouchWebViewPrivate::touchPageProxy):
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::loadNonexistentFileUrl):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::load):
(WebViewAbstraction::url):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::navigationStatusAtStartup):
* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::createPopupMenuProxy):
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::didChangeViewportProperties):
(WebKit::QtTouchViewInterface::didChangeUrl):
(WebKit::QtTouchViewInterface::didChangeTitle):
(WebKit::QtTouchViewInterface::loadDidBegin):
(WebKit::QtTouchViewInterface::loadDidCommit):
(WebKit::QtTouchViewInterface::loadDidSucceed):
(WebKit::QtTouchViewInterface::loadDidFail):
(WebKit::QtTouchViewInterface::didChangeLoadProgress):
* WebKit2API.pri:

Tools:

Remove unneded forwarding logic for TouchWebView since those properties are
now in the view just as the desktop web view.

* MiniBrowser/qt/qml/TouchView.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPluginProxy shouldn't use window-relative coordinates
andersca@apple.com [Tue, 1 Nov 2011 16:51:12 +0000 (16:51 +0000)]
PluginProxy shouldn't use window-relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71261

Reviewed by Adam Roben.

Change PluginProxy::wantsWindowRelativeCoordinates to return false and remove
m_frameRectInWindowCoordinates and m_clipRectInWindowCoordinates. This is yet another step
towards eliminating window-relative coordinates wherever possible.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Since the dirty rect passed to paint is now in plug-in coordinates, there's no need to convert it
from window coordinates to plug-in coordinates before passing it to BackingStore::paint.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Assert that we're not calling this anymore.

(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll chromium DEPS.
alokp@chromium.org [Tue, 1 Nov 2011 16:45:35 +0000 (16:45 +0000)]
Roll chromium DEPS.

Unreviewed.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in PDF code when script has illegal UTF-8 or UTF-16 sequences
darin@apple.com [Tue, 1 Nov 2011 16:28:18 +0000 (16:28 +0000)]
Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
https://bugs.webkit.org/show_bug.cgi?id=71289

Reviewed by Dan Bernstein.

Just adding a null check. I don't have access to an actual PDF with
this problem but crashes from the field indicate they exist.

* WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument): Skip the code to add the script text
to an array when the script is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] call readPixels on canvas instead of device (will be private on device soon...
reed@google.com [Tue, 1 Nov 2011 15:59:08 +0000 (15:59 +0000)]
[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
https://bugs.webkit.org/show_bug.cgi?id=71284

Reviewed by Stephen White.

No new tests. This is preparing for an API change to Skia.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add some pixel baselines for tests in fast/.
leandro@webkit.org [Tue, 1 Nov 2011 15:56:11 +0000 (15:56 +0000)]
[EFL] Unreviewed. Add some pixel baselines for tests in fast/.

* platform/efl/fast/html: [...]
* platform/efl/fast/images: [...]
* platform/efl/fast/inline-block: [...]
* platform/efl/fast/inline: [...]
* platform/efl/fast/innerHTML: [...]
* platform/efl/fast/inspector-support: [...]
* platform/efl/fast/invalid: [...]
* platform/efl/fast/layers: [...]
* platform/efl/fast/lists: [...]
* platform/efl/fast/loader: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSStyleSheet: Operate directly on the rule vector internally.
andreas.kling@nokia.com [Tue, 1 Nov 2011 15:47:51 +0000 (15:47 +0000)]
CSSStyleSheet: Operate directly on the rule vector internally.

Rubber-stamped by Antti Koivisto.

There's no need to go through the public, range-checking item() method
working on m_children. Also changed length() -> m_children.size().

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixed conflicting entries in test expectations.
caseq@chromium.org [Tue, 1 Nov 2011 15:44:03 +0000 (15:44 +0000)]
Unreviewed. Fixed conflicting entries in test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe QtViewportInteractionEngine should consider DPI adjustment
kenneth@webkit.org [Tue, 1 Nov 2011 15:40:36 +0000 (15:40 +0000)]
The QtViewportInteractionEngine should consider DPI adjustment
https://bugs.webkit.org/show_bug.cgi?id=71283

Reviewed by Simon Hausmann.

* UIProcess/API/qt/qtouchwebview.cpp:

    Add some default values for now to make sure we are testing the
    DPI adjustment / CSS-item space conversion.

(QTouchWebViewPrivate::updateViewportConstraints):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):

    Clean up the guard to be more understandable.

(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):

    Add methods for converting between CSS and item space.

(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):

    Make it clean which methods uses which coord space.

(WebKit::QtViewportInteractionEngine::updateVisibleRect):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemScale):

    Rename calculateBoundariesForScale and change its implementation to
    be correct. The new name reflects the space in which the computation
    takes place and reflects similar Qt API.

(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

    Make sure to consider the right coord space.

* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::Constraints::Constraints):

    Add the devicePixelRatio.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Marked inspector extensions tests as crash on win debug.
caseq@chromium.org [Tue, 1 Nov 2011 15:32:04 +0000 (15:32 +0000)]
Unreviewed. Marked inspector extensions tests as crash on win debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSRule: Devirtualize addSubresourceStyleURLs()
andreas.kling@nokia.com [Tue, 1 Nov 2011 15:23:24 +0000 (15:23 +0000)]
CSSRule: Devirtualize addSubresourceStyleURLs()
https://bugs.webkit.org/show_bug.cgi?id=71285

Reviewed by Antti Koivisto.

Move addSubresourceStyleURLs() into the rules that actually implement it.
Add type checks and casts at the (only) call site.

* css/CSSFontFaceRule.h:
* css/CSSImportRule.h:
* css/CSSRule.h:
* css/CSSStyleRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: some popup buttons not announced by VoiceOver
cfleizach@apple.com [Tue, 1 Nov 2011 15:19:20 +0000 (15:19 +0000)]
AX: some popup buttons not announced by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=67743

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

* platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt: Added.
* platform/mac/accessibility/aria-popup-buttons-on-native-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
caseq@chromium.org [Tue, 1 Nov 2011 15:16:14 +0000 (15:16 +0000)]
Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
caseq@chromium.org [Tue, 1 Nov 2011 15:02:11 +0000 (15:02 +0000)]
Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProspective clang build fix.
hausmann@webkit.org [Tue, 1 Nov 2011 14:41:30 +0000 (14:41 +0000)]
Prospective clang build fix.

Reviewed by Andreas Kling.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Handle GestureSingleTap in the event type switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-01 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 1 Nov 2011 13:58:05 +0000 (13:58 +0000)]
2011-11-01  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix chromium interactive tests.

        * src/js/Tests.js:
        (.TestSuite.prototype.showPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Create infrastructure for Qt's builtin bundle in web process.
caio.oliveira@openbossa.org [Tue, 1 Nov 2011 13:34:34 +0000 (13:34 +0000)]
[Qt] Create infrastructure for Qt's builtin bundle in web process.
https://bugs.webkit.org/show_bug.cgi?id=71279

Reviewed by Simon Hausmann.

Create a builtin bundle for Qt port: an InjectedBundle which the code is together
with the Qt's web process instead of being in a different library. This gives us
access to many hooks at web process (using WKBundle* functions of C API) without
adding any maintenance burden to cross-port code.

Since we also use a InjectedBundle in the WebKitTestRunner, we only install our
builtin bundle if there's no other installed. This is fine because WTR won't use
the extra runtime features that we plan to provide with the builtin bundle.

* WebKit2.pro:
* WebProcess/qt/QtBuiltinBundle.cpp: Added.
(WebKit::QtBuiltinBundle::~QtBuiltinBundle):
(WebKit::QtBuiltinBundle::shared):
(WebKit::QtBuiltinBundle::initialize):
(WebKit::QtBuiltinBundle::didCreatePage):
(WebKit::QtBuiltinBundle::willDestroyPage):
(WebKit::QtBuiltinBundle::bundlePageForPageRef):
* WebProcess/qt/QtBuiltinBundle.h: Added.
(WebKit::QtBuiltinBundle::toRef):
Object that holds a WKBundleRef and keeps track of the pages in the current context.

* WebProcess/qt/QtBuiltinBundlePage.cpp: Added.
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
(WebKit::QtBuiltinBundlePage::~QtBuiltinBundlePage):
* WebProcess/qt/QtBuiltinBundlePage.h: Added.
(WebKit::QtBuiltinBundlePage::page):
Our representation for pages from the bundle perspective. This will be the right
place to registering page related clients.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
If there's no bundle to be loaded, initialize Qt builtin bundle, which will register the
bundle client for this context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] Style-based CSS properties are editable and toggleable
apavlov@chromium.org [Tue, 1 Nov 2011 13:32:40 +0000 (13:32 +0000)]
Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
https://bugs.webkit.org/show_bug.cgi?id=71275

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):

LayoutTests:

* inspector/styles/styles-source-lines-expected.txt:
* inspector/styles/styles-update-from-js-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make extension tests pass on chromium
caseq@chromium.org [Tue, 1 Nov 2011 13:09:51 +0000 (13:09 +0000)]
Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

* http/tests/inspector/extensions-headers.html:
* http/tests/inspector/resources/extension-main.js:
():
* inspector/extensions/extensions-audits.html:
* inspector/extensions/extensions-console.html:
* inspector/extensions/extensions-resources.html:
* platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-01 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 1 Nov 2011 12:59:11 +0000 (12:59 +0000)]
2011-11-01  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix extensions tests.

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest.showPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-01 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 1 Nov 2011 12:53:57 +0000 (12:53 +0000)]
2011-11-01  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix inspector extensions tests.

        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: do not switch panels on Cmd + -> while in console.
pfeldman@chromium.org [Tue, 1 Nov 2011 12:36:00 +0000 (12:36 +0000)]
Web Inspector: do not switch panels on Cmd + ->  while in console.
https://bugs.webkit.org/show_bug.cgi?id=71281

Reviewed by Yury Semikhatsky.

* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt documentation fix.
alexis.menard@openbossa.org [Tue, 1 Nov 2011 12:34:15 +0000 (12:34 +0000)]
Unreviewed Qt documentation fix.

This signal is Qt 4.8 material.

* Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style: Allow names starting with "_q_".
jocelyn.turcotte@nokia.com [Tue, 1 Nov 2011 11:36:17 +0000 (11:36 +0000)]
check-webkit-style: Allow names starting with "_q_".
https://bugs.webkit.org/show_bug.cgi?id=70625

Reviewed by Tor Arne Vestbø.

Used by the Qt port as the standard prefix for private slots.

* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
caseq@chromium.org [Tue, 1 Nov 2011 10:35:36 +0000 (10:35 +0000)]
Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
caseq@chromium.org [Tue, 1 Nov 2011 10:29:28 +0000 (10:29 +0000)]
Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
commit-queue@webkit.org [Tue, 1 Nov 2011 10:17:06 +0000 (10:17 +0000)]
[Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallbackConstructor
https://bugs.webkit.org/show_bug.cgi?id=60951

Adjust symbols visibility for WebCore.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-01
Reviewed by Simon Hausmann.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-01 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 1 Nov 2011 10:14:39 +0000 (10:14 +0000)]
2011-11-01  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: add InspectorView.js entry into WebKit.qrc

        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: introduce PanelContainer class, start moving panel management from...
pfeldman@chromium.org [Tue, 1 Nov 2011 10:05:24 +0000 (10:05 +0000)]
Web Inspector: introduce PanelContainer class, start moving panel management from inspector.js to the new class.
https://bugs.webkit.org/show_bug.cgi?id=71272

Reviewed by Yury Semikhatsky.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
(WebInspector.ElementsPanel.prototype.revealAndSelectNode):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.setVisible):
* inspector/front-end/InspectorView.js: Added.
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype.addPanel):
(WebInspector.InspectorView.prototype.currentPanel):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._canGoBackInHistory):
(WebInspector.InspectorView.prototype._goBackInHistory):
(WebInspector.InspectorView.prototype._canGoForwardInHistory):
(WebInspector.InspectorView.prototype._goForwardInHistory):
(WebInspector.InspectorView.prototype._pushToHistory):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.eventHasCtrlOrMeta):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector._panelSelected):
(WebInspector.addPanel):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.select):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.expandElementsTree):
* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
* inspector/debugger/debugger-expand-scope.html:
* inspector/debugger/debugger-proto-property.html:
* inspector/debugger/dom-breakpoints.html:
* inspector/elements/elements-img-tooltip.html:
* inspector/elements/elements-panel-limited-children.html:
* inspector/storage-panel-dom-storage.html:
* inspector/styles/styles-new-API.html:
* inspector/view-css.html:
* inspector/view-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add pixel baselines for fast/ tests.
leandro@webkit.org [Tue, 1 Nov 2011 10:02:02 +0000 (10:02 +0000)]
[EFL] Unreviewed. Add pixel baselines for fast/ tests.

* platform/efl/fast/doctypes: [...]
* platform/efl/fast/dom: [...]
* platform/efl/fast/dynamic: [...]
* platform/efl/fast/encoding: [...]
* platform/efl/fast/events: [...]
* platform/efl/fast/fast-mobile-scrolling: [...]
* platform/efl/fast/flexbox: [...]
* platform/efl/fast/forms: [...]
* platform/efl/fast/frames: [...]
* platform/efl/fast/gradients: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEvent::TapType
hausmann@webkit.org [Tue, 1 Nov 2011 09:54:24 +0000 (09:54 +0000)]
[WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEvent::TapType
https://bugs.webkit.org/show_bug.cgi?id=71274

Reviewed by Kenneth Christiansen.

Source/WebCore:

* features.pri: Enable GESTURE_EVENTS.

Source/WebKit2:

* Shared/WebEvent.h: Add GestureSingleTap as gesture type.
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): Support converting
WebEven::GestureSingleTap to PlatformGestureEvent::TapType.
* Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::isGestureEventType): GestureSingleTap is a valid gesture event type.
* WebKit2.pro: Add WebGestureEvent.cpp to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix valgrind error about uninitialized variable
hausmann@webkit.org [Tue, 1 Nov 2011 09:54:07 +0000 (09:54 +0000)]
[Qt][WK2] Fix valgrind error about uninitialized variable
https://bugs.webkit.org/show_bug.cgi?id=71273

Reviewed by Kenneth Christiansen.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Initialize isPrimary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening (fixed platform qualifiers for visibility-image-layers.html)
caseq@chromium.org [Tue, 1 Nov 2011 07:35:54 +0000 (07:35 +0000)]
Unreviewed gardening (fixed platform qualifiers for visibility-image-layers.html)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98847.
yurys@chromium.org [Tue, 1 Nov 2011 07:24:13 +0000 (07:24 +0000)]
Unreviewed, rolling out r98847.
http://trac.webkit.org/changeset/98847
https://bugs.webkit.org/show_bug.cgi?id=71268

"Debugger test failures on multiple platforms" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-01

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):

LayoutTests:

* inspector/debugger/bind-script-to-resource-expected.txt: Removed.
* inspector/debugger/bind-script-to-resource.html: Removed.
* inspector/debugger/linkifier-expected.txt:
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 1 Nov 2011 07:11:40 +0000 (07:11 +0000)]
2011-11-01  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Rebaseline test started failing because syntax errors in inline handlers
        are now reported to console.

        window.onerror doesn't work with inline (attribute) scripts
        https://bugs.webkit.org/show_bug.cgi?id=70991

        * fast/js/invalid-syntax-for-function-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed gardening.
caseq@chromium.org [Tue, 1 Nov 2011 06:52:08 +0000 (06:52 +0000)]
   Unreviewed gardening.

* platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe GC should be parallel
fpizlo@apple.com [Tue, 1 Nov 2011 06:43:37 +0000 (06:43 +0000)]
The GC should be parallel
https://bugs.webkit.org/show_bug.cgi?id=70995

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added parallel tracing to the GC. This works by having local mark
stacks per thread, and a global shared one. Threads sometimes
donate cells from the mark stack to the global one if the heuristics
tell them that it's affordable to do so. Threads that have depleted
their local mark stacks try to steal some from the shared one.

Marking is now done using an atomic weak relaxed CAS (compare-and-swap).

This is a 23% speed-up on V8-splay when I use 4 marking threads,
leading to a 3.5% speed-up on V8.

It also appears that this reduces GC pause times on real websites by
more than half.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::markRoots):
* heap/Heap.h:
* heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::~MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset):
(JSC::SlotVisitor::donateSlow):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::MarkStack::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
* heap/MarkStack.h:
(JSC::MarkStackSegment::data):
(JSC::MarkStackSegment::capacityFromSize):
(JSC::MarkStackSegment::sizeFromCapacity):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::mergeOpaqueRootsIfNecessary):
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::canRemoveLast):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::canDonateSomeCells):
(JSC::MarkStackArray::size):
(JSC::ParallelModeEnabler::ParallelModeEnabler):
(JSC::ParallelModeEnabler::~ParallelModeEnabler):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::testAndSetMarked):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::SlotVisitor):
* heap/WeakReferenceHarvester.h:
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
* wtf/Atomics.h:
(WTF::weakCompareAndSwap):
* wtf/Bitmap.h:
(WTF::::Bitmap):
(WTF::::get):
(WTF::::set):
(WTF::::testAndSet):
(WTF::::testAndClear):
(WTF::::concurrentTestAndSet):
(WTF::::concurrentTestAndClear):
(WTF::::clear):
(WTF::::clearAll):
(WTF::::nextPossiblyUnset):
(WTF::::findRunOfZeros):
(WTF::::count):
(WTF::::isEmpty):
(WTF::::isFull):
* wtf/MainThread.h:
(WTF::isMainThreadOrGCThread):
* wtf/Platform.h:
* wtf/ThreadSpecific.h:
(WTF::::isSet):
* wtf/mac/MainThreadMac.mm:
(WTF::initializeGCThreads):
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

Source/WebCore:

Reviewed by Geoff Garen.

Added parallel tracing to the GC. This required loosening some assertions,
since some code may now be called from outside the main thread.

No new tests, since no behavior was changed.

* platform/TreeShared.h:
(WebCore::TreeShared::parent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDocument pointer not null-checked in FrameView::isOnActivePage()
aestes@apple.com [Tue, 1 Nov 2011 05:43:09 +0000 (05:43 +0000)]
Document pointer not null-checked in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71265
<rdar://problem/10374427>

Reviewed by Dan Bernstein.

Return false in FrameView::isOnActivePage() if m_frame->document() is
null. Other calls to m_frame->document() in FrameView also have a null
check. The frame can have a null document if the FrameLoader is loading
the initial empty document.

No test possible without triggering assertions in debug builds. This is
tracked by <http://webkit.org/b/71264>.

* page/FrameView.cpp:
(WebCore::FrameView::isOnActivePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Fix a crash relating to anonymous block merging in
commit-queue@webkit.org [Tue, 1 Nov 2011 04:24:08 +0000 (04:24 +0000)]
Source/WebCore: Fix a crash relating to anonymous block merging in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

Test: fullscreen/anonymous-block-merge-crash.html

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):

LayoutTests: Test case for a crash relating to merging of anonymous blocks in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

* fullscreen/anonymous-block-merge-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoV8MessageEvent::dataAccessorGetter does not return a reference to its caller
commit-queue@webkit.org [Tue, 1 Nov 2011 03:37:51 +0000 (03:37 +0000)]
V8MessageEvent::dataAccessorGetter does not return a reference to its caller
https://bugs.webkit.org/show_bug.cgi?id=71229

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-31
Reviewed by Adam Barth.

Test: fast/events/dispatch-message-string-data.html

* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fix after r98853.
reni@webkit.org [Tue, 1 Nov 2011 01:47:17 +0000 (01:47 +0000)]
[Qt] Build fix after r98853.

Rubber-stamped by Andreas Kling.

* xml/XSLImportRule.cpp:
* xml/XSLImportRule.h:
(WebCore::XSLImportRule::parentStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSObject::defaultValue
mhahnenberg@apple.com [Tue, 1 Nov 2011 01:15:06 +0000 (01:15 +0000)]
De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added defaultValue to the MethodTable.  Replaced all virtual versions of
defaultValue with static versions.  Replaced all call sites with lookups in the
MethodTable.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
* runtime/ExceptionHelpers.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defaultValue):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::defaultValue):
* runtime/JSObject.h:
(JSC::JSObject::toPrimitive):

Source/WebCore:

No new tests.

Added defaultValue to the MethodTable.  Replaced all virtual versions of
defaultValue with static versions.  Replaced all call sites with lookups in the
MethodTable.

* WebCore.exp.in:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::defaultValue):
* bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch RoundedRect back to integers
leviw@chromium.org [Tue, 1 Nov 2011 01:09:03 +0000 (01:09 +0000)]
Switch RoundedRect back to integers
https://bugs.webkit.org/show_bug.cgi?id=71238

Reviewed by Darin Adler.

Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.

No new tests -- no change in behavior.

* platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):
* platform/graphics/RoundedRect.h:
(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):
* rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=70666
commit-queue@webkit.org [Tue, 1 Nov 2011 01:06:00 +0000 (01:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70666
BitmapImage::dataChanged() needs to clear all incomplete frames.

Patch by Peter Kasting <pkasting@google.com> on 2011-10-31
Reviewed by James Robinson.

No tests, as I don't know of a way to send an image to the renderer in
small pieces (with script run between pieces no less).

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAmend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
leviw@chromium.org [Tue, 1 Nov 2011 01:01:57 +0000 (01:01 +0000)]
Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=71243

Reviewed by Eric Seidel.

Replacing remaining integer uses with LayoutUnits in the aforementioned classes.

No new tests -- no change in behavior.

* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::intrinsicSize):
(WebCore::RenderApplet::createWidgetIfNecessary):
* rendering/RenderApplet.h:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::controlClipRect):
* rendering/RenderButton.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderDeprecatedFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPluginProxy::Update should pass the painted rect in plug-in coordinates
andersca@apple.com [Tue, 1 Nov 2011 00:59:34 +0000 (00:59 +0000)]
PluginProxy::Update should pass the painted rect in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71257

Reviewed by Adam Roben.

This is one step in the process of migrating away from window relative coordinates
and use plug-in relative coordinates instead, since window relative coordinates won't work
with transforms.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Convert the dirty rect back to plug-in coordinates.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::update):
No need to convert the painted rect back to plug-in coordinates anymore.

* WebProcess/Plugins/PluginProxy.messages.in:
Document that the painted rect is in plug-in coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
aroben@apple.com [Tue, 1 Nov 2011 00:50:44 +0000 (00:50 +0000)]
Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT

Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds

Reviewed by Anders Carlsson.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
total of N bytes!").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Media Stream API: add the Chromium WebKit interfaces
commit-queue@webkit.org [Tue, 1 Nov 2011 00:43:49 +0000 (00:43 +0000)]
[Chromium] Media Stream API: add the Chromium WebKit interfaces
https://bugs.webkit.org/show_bug.cgi?id=58550

Source/WebCore:

Changes the PeerHandler platform interface so that embedders can more easily use it.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::didCompleteICEProcessing):
(WebCore::PeerConnection::didGenerateSDP):
(WebCore::PeerConnection::didReceiveDataStreamMessage):
(WebCore::PeerConnection::didAddRemoteStream):
(WebCore::PeerConnection::didRemoveRemoteStream):
* mediastream/PeerConnection.h:
* platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient):
* platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.h.
* platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):
* platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerHandler.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

Source/WebKit/chromium:

Adds the bridging code + the minimum amount of Web* supporting code.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

* WebKit.gyp:
* bridge/PeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):
* bridge/PeerConnectionHandlerInternal.cpp: Added.
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::~PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):
* bridge/PeerConnectionHandlerInternal.h: Added.
* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::createPeerConnectionHandler):
* public/WebMediaStreamDescriptor.h: Added.
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::~WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::isNull):
* public/WebPeerConnectionHandler.h: Added.
(WebKit::WebPeerConnectionHandler::~WebPeerConnectionHandler):
* public/WebPeerConnectionHandlerClient.h: Added.
(WebKit::WebPeerConnectionHandlerClient::~WebPeerConnectionHandlerClient):
* src/WebMediaStreamDescriptor.cpp: Added.
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::reset):
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStreamDescriptor::operator WebCore::MediaStreamDescriptor*):

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix linker warnings on Windows
aroben@apple.com [Tue, 1 Nov 2011 00:39:50 +0000 (00:39 +0000)]
Fix linker warnings on Windows

* WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and
JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting
compiled via *AllInOne.cpp files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] Don't use GOwnPtr for ref-counted objects
commit-queue@webkit.org [Tue, 1 Nov 2011 00:29:08 +0000 (00:29 +0000)]
[GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-31
Reviewed by Martin Robinson.

* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
* platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPluginControllerProxy should call Plugin::geometryDidChange
andersca@apple.com [Tue, 1 Nov 2011 00:29:03 +0000 (00:29 +0000)]
PluginControllerProxy should call Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71255

Reviewed by Sam Weinig.

Pass enough information over in the GeometryDidChange message sent from
PluginProxy to PluginControllerProxy so that PluginControllerProxy can call
Plugin::geometryDidChange.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::invalidate):
(WebKit::PluginControllerProxy::paintEntirePlugin):
Update for rename from m_frameRect to m_frameRectInWindowCoordinates.

(WebKit::PluginControllerProxy::geometryDidChange):
This now takes the plug-in size and the plug-in to root view transform as well.

* PluginProcess/PluginControllerProxy.h:
Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates.

* PluginProcess/PluginControllerProxy.messages.in:
Update message signature.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformGeometryDidChange):
Use the plug-in size instead of the frame rect size.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
Add encoder/decoder for WebCore::AffineTransform.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Compute the frame rect in window coordinates and send it over.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening; bind-script-to-resource.html times out on chromium mac.
johnnyg@google.com [Tue, 1 Nov 2011 00:27:50 +0000 (00:27 +0000)]
Unreviewed gardening; bind-script-to-resource.html times out on chromium mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Calling methods of WebFontImpl causes assertions
commit-queue@webkit.org [Tue, 1 Nov 2011 00:27:35 +0000 (00:27 +0000)]
[chromium] Calling methods of WebFontImpl causes assertions
https://bugs.webkit.org/show_bug.cgi?id=71232

Added FontCachePurgePreventer in several methods.

Patch by Yuzhu Shen <yzshen@google.com> on 2011-10-31
Reviewed by James Robinson.

* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::calculateWidth):
(WebKit::WebFontImpl::offsetForPosition):
(WebKit::WebFontImpl::selectionRectForText):
(WebKit::WebFontImpl::estimateTextBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed holiday gardening after r98852.
ossy@webkit.org [Tue, 1 Nov 2011 00:21:34 +0000 (00:21 +0000)]
[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

* platform/qt/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98918.
ossy@webkit.org [Tue, 1 Nov 2011 00:18:20 +0000 (00:18 +0000)]
Unreviewed, rolling out r98918.
http://trac.webkit.org/changeset/98918
https://bugs.webkit.org/show_bug.cgi?id=71256

Wrong commit (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-31

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed holiday gardening after r98852.
ossy@webkit.org [Tue, 1 Nov 2011 00:10:17 +0000 (00:10 +0000)]
[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

* platform/qt/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed holiday gardening after r98673 and r98608.
ossy@webkit.org [Tue, 1 Nov 2011 00:01:47 +0000 (00:01 +0000)]
[Qt] Unreviewed holiday gardening after r98673 and r98608.

* platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInterpreter build fix
mhahnenberg@apple.com [Mon, 31 Oct 2011 23:57:57 +0000 (23:57 +0000)]
Interpreter build fix

Unreviewed build fix

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine...
nduca@chromium.org [Mon, 31 Oct 2011 23:56:36 +0000 (23:56 +0000)]
[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=71100

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCSchedulerFrameRateControllerClientAdapter::create):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::~CCScheduler):
(WebCore::CCScheduler::setNeedsAnimate):
(WebCore::CCScheduler::setNeedsCommit):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didSwapBuffersAbort):
(WebCore::CCScheduler::onBeginFrame):
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCScheduler.h:
(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::redrawPending):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::hasMoreUpdates):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::StateMachine::setUpdateMoreResourcesPending):
(WebCore::StateMachine::updateMoreResourcesPending):
(WebCore::TEST):
* tests/CCSchedulerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed holiday gardening after r98852.
ossy@webkit.org [Mon, 31 Oct 2011 23:52:47 +0000 (23:52 +0000)]
[Qt] Unreviewed holiday gardening after r98852.

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

* platform/qt/css1/text_properties/vertical_align-expected.png:
* platform/qt/css1/text_properties/vertical_align-expected.txt:
* platform/qt/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-003-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/qt/fast/block/float/015-expected.png:
* platform/qt/fast/block/float/015-expected.txt:
* platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/qt/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/qt/svg/as-background-image/background-image-tiled-expected.txt: Added.
* platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
* platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/qt/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/qt/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
* platform/qt/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/qt/svg/as-image/svg-image-change-content-size-expected.txt: Added.
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98913 268f45cc-cd09-0410-ab3c-d52691b4dbfc