WebKit-https.git
7 years ago[EFL] [DRT] Update EFL baselines after r115846
commit-queue@webkit.org [Thu, 3 May 2012 13:24:06 +0000 (13:24 +0000)]
[EFL] [DRT] Update EFL baselines after r115846
https://bugs.webkit.org/show_bug.cgi?id=85474

Unreviewed, EFL rebaseline after changes in r115846.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-03

* platform/efl/fast/block/float/032-expected.txt:
* platform/efl/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/efl/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/efl/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/efl/fast/block/margin-collapse/103-expected.txt:
* platform/efl/fast/clip/008-expected.txt:
* platform/efl/fast/clip/011-expected.txt:
* platform/efl/fast/clip/012-expected.txt:
* platform/efl/fast/html/details-no-summary4-expected.txt:
* platform/efl/fast/html/details-open-javascript-expected.txt:
* platform/efl/fast/html/details-open2-expected.txt:
* platform/efl/fast/html/details-open4-expected.txt:
* platform/efl/fast/replaced/replaced-breaking-expected.txt:
* platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/efl/fast/table/003-expected.txt:
* platform/efl/fast/table/overflowHidden-expected.txt:
* platform/efl/fast/table/text-field-baseline-expected.txt:
* platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] ImageDiff crashes when it can't open a display
zandobersek@gmail.com [Thu, 3 May 2012 13:16:04 +0000 (13:16 +0000)]
[Gtk] ImageDiff crashes when it can't open a display
https://bugs.webkit.org/show_bug.cgi?id=85476

Reviewed by Martin Robinson.

Replace gdk_init() initialization call with the g_type_init()
call. GdkPixbufLoader doesn't actually need the current call to be
made and this change will also remove crashes when ImageDiff
is started in an environment without a DISPLAY env.

* DumpRenderTree/gtk/ImageDiff.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]Correct fast/regions/region-style-inline-background-color.html
mihnea@adobe.com [Thu, 3 May 2012 12:40:19 +0000 (12:40 +0000)]
[CSSRegions]Correct fast/regions/region-style-inline-background-color.html
https://bugs.webkit.org/show_bug.cgi?id=85470

Reviewed by Andreas Kling.

Fix a typo in the original test and update the expectations.
The purpose of this test is to verify that region styling is NOT enabled for inline elements. The test was passing
because region styling rule was not applied due to incorrect region selector.

The corrected test makes sure that region styling rule has the right region selector and can be applied to the first region in the test file.

* fast/regions/region-style-inline-background-color.html:
* platform/chromium-win/fast/regions/region-style-inline-background-color-expected.txt:
* platform/mac/fast/regions/region-style-inline-background-color-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: compile time ambiguity happens when I try to assign a TypeBuilder...
loislo@chromium.org [Thu, 3 May 2012 12:39:29 +0000 (12:39 +0000)]
Web Inspector: compile time ambiguity happens when I try to assign a TypeBuilder object to an out argument.
https://bugs.webkit.org/show_bug.cgi?id=85462

It happens because we have type casting operators for both types RefPtr<*Type*> and PassRefPtr<*Type*>.
I think we can drop PassRefPtr type casting operator and use a named function 'release'.

Reviewed by Yury Semikhatsky.

* inspector/CodeGeneratorInspector.py:
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildObjectForSearchResult):
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForTiming):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::buildInspectorObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: crash in InspectorResourceAgent::didReceiveWebSocketFrame
yurys@chromium.org [Thu, 3 May 2012 12:35:29 +0000 (12:35 +0000)]
Web Inspector: crash in InspectorResourceAgent::didReceiveWebSocketFrame
https://bugs.webkit.org/show_bug.cgi?id=85394

Reviewed by Pavel Feldman.

Pass string length explicitely when creating String object from non-null-terminated
char* strings.

* inspector/InspectorResourceAgent.cpp:
(WebCore):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: never surround InspectorInstrumentation:: with ENABLED(INSPECTOR)
pfeldman@chromium.org [Thu, 3 May 2012 12:26:20 +0000 (12:26 +0000)]
Not reviewed: never surround InspectorInstrumentation:: with ENABLED(INSPECTOR)

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::dispatchChildRemovalEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImageDiff should be run inside a properly established environment
zandobersek@gmail.com [Thu, 3 May 2012 12:13:23 +0000 (12:13 +0000)]
ImageDiff should be run inside a properly established environment
https://bugs.webkit.org/show_bug.cgi?id=85292

Reviewed by Martin Robinson.

When creating the ImageDiff server process, pass along a freshly-set-up environment
in which the process should be executed in.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._start_image_diff_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: migrate breakpoint manager to live locations.
pfeldman@chromium.org [Thu, 3 May 2012 12:08:24 +0000 (12:08 +0000)]
Web Inspector: migrate breakpoint manager to live locations.
https://bugs.webkit.org/show_bug.cgi?id=85136

Reviewed by Yury Semikhatsky.

Source/WebCore:

- Merges Breakpoint and UIBreakpoint to have single instance
- Extracts storage from the breakpoint manager
- Makes breakpoint manager use source mapping from the script, not the presentation model
- Removes breakpoints collection from the UISourceCode
Unfortunately, there are too many inter-dependencies that require that these changes are done simultaneously.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpoint):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype._removeBreakpoint):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):
(WebInspector.BreakpointManager.prototype.storage):
(WebInspector.BreakpointManager.Breakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype.primaryUILocation):
(WebInspector.BreakpointManager.Breakpoint.prototype._addResolvedLocation):
(WebInspector.BreakpointManager.Breakpoint.prototype.enabled):
(WebInspector.BreakpointManager.Breakpoint.prototype.setEnabled):
(WebInspector.BreakpointManager.Breakpoint.prototype.condition):
(WebInspector.BreakpointManager.Breakpoint.prototype.setCondition):
(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype.remove):
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger.didSetBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger):
(WebInspector.BreakpointManager.Breakpoint.prototype._removeFromDebugger):
(WebInspector.BreakpointManager.Breakpoint.prototype._resetLocations):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Breakpoint.prototype._fakeBreakpointAtPrimaryLocation):
(WebInspector.BreakpointManager.Storage.get this):
(WebInspector.BreakpointManager.Storage):
(WebInspector.BreakpointManager.Storage.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.Storage.prototype._updateBreakpoint):
(WebInspector.BreakpointManager.Storage.prototype._removeBreakpoint):
(WebInspector.BreakpointManager.Storage.prototype._save):
(set WebInspector.BreakpointManager.Storage.Item):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.breakpointsActive):
(WebInspector.DebuggerModel.prototype.createLiveLocation):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
(WebInspector.JavaScriptSourceFrame.prototype._updateBreakpointsAfterLiveEdit):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentChanged):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/breakpoint-manager-expected.txt:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-expected.txt:
* inspector/debugger/source-frame.html:
* platform/chromium/inspector/debugger/breakpoint-manager-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attemp to fix chromium win build broken at r115943.
caseq@chromium.org [Thu, 3 May 2012 11:36:15 +0000 (11:36 +0000)]
Unreviewed attemp to fix chromium win build broken at r115943.

* notifications/NotificationClient.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDocument the QML WebViewExperimental API devicePixelRatio.
kenneth@webkit.org [Thu, 3 May 2012 11:16:10 +0000 (11:16 +0000)]
Document the QML WebViewExperimental API devicePixelRatio.

Rubberstamped by Simon Hausmann.

* UIProcess/API/qt/qquickwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Allow the web process and WTR to be paused on startup
vestbo@webkit.org [Thu, 3 May 2012 11:14:20 +0000 (11:14 +0000)]
[Qt] Allow the web process and WTR to be paused on startup

Makes it easier to debug the web process or run-webkit-tests -2, as you
have ample time to attach gdb to the process.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPassword protect "Stop build" button
ossy@webkit.org [Thu, 3 May 2012 11:01:04 +0000 (11:01 +0000)]
Password protect "Stop build" button
https://bugs.webkit.org/show_bug.cgi?id=81982

Reviewed by Ryosuke Niwa.

Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
features to prevent killing builds on build.webkit.org by SPAM bots.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLinker warnings due to duplicate symbols for SimplifyMarkupCommand.cpp on Windows
commit-queue@webkit.org [Thu, 3 May 2012 10:38:45 +0000 (10:38 +0000)]
Linker warnings due to duplicate symbols for SimplifyMarkupCommand.cpp on Windows
https://bugs.webkit.org/show_bug.cgi?id=85467

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-03
Reviewed by Ryosuke Niwa.

Removed the multiple inclusion of the file SimplifyMarkupCommand.cpp

No new tests required.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename deviceDPI to devicePixelRatio https://bugs.webkit.org/show_bug.cgi?id=85049
ahf@0x90.dk [Thu, 3 May 2012 10:37:16 +0000 (10:37 +0000)]
Rename deviceDPI to devicePixelRatio https://bugs.webkit.org/show_bug.cgi?id=85049

Reviewed by Kenneth Rohde Christiansen.

This patch fixes an API test regression from r115948 in
tst_QQuickWebView::scrollRequest() by setting the device pixel ratio
for the test WebView to 1.5.

* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::newWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[DRT] Remove the name of parameter, visibility, from the setPageVisibility stub imple...
commit-queue@webkit.org [Thu, 3 May 2012 10:30:34 +0000 (10:30 +0000)]
[DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
https://bugs.webkit.org/show_bug.cgi?id=85468

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-03
Reviewed by Nikolas Zimmermann.

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS clip: auto clips to box borders instead of removing clipping
commit-queue@webkit.org [Thu, 3 May 2012 10:02:54 +0000 (10:02 +0000)]
CSS clip: auto clips to box borders instead of removing clipping
https://bugs.webkit.org/show_bug.cgi?id=36772

Patch by Uday Kiran <udaykiran@motorola.com> on 2012-05-03
Reviewed by Andreas Kling.

Source/WebCore:

According to CSS 2.1 spec, http://www.w3.org/TR/CSS2/visufx.html#propdef-clip,
clip property with value 'auto' the element does not clip.
Also getPropertyValue for clip when auto is specified should return "auto"
and not "rect(0px 0px 0px 0px)".

Tests: css2.1/20110323/clip-001-expected.html
       css2.1/20110323/clip-001.html

* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyClip::applyValue):

LayoutTests:

CSS 2.1 test case added for clip:auto

* css2.1/20110323/clip-001-expected.html: Added.
* css2.1/20110323/clip-001.html: Added.
* fast/css/getPropertyValue-clip.html: getPropertyValue for clip when auto is specified should return auto and not rect(0px 0px 0px 0px).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells...
slewis@apple.com [Thu, 3 May 2012 09:51:56 +0000 (09:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
<rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run

Reviewed by Brady Eidson.

The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
for every world, even those that did not need the callback.  This had the side effect of creating a
JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
in the API.  The object can be accessed later by those worlds which require it.

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame): rename API and remove globalObject parameter
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient): ditto
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable): ditto

Tools:

* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
(TestWebKitAPI):
(DOMWindowExtensionBasic):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd temporary feature define for parsed stylesheet caching
antti@apple.com [Thu, 3 May 2012 09:49:29 +0000 (09:49 +0000)]
Add temporary feature define for parsed stylesheet caching
https://bugs.webkit.org/show_bug.cgi?id=85413

Rubber-stamped by Nikolas Zimmermann.

While not an externally visible feature this is still a significant internal change.
It is good to have define in case someone has an urgent need to turn it off.

Caching is enabled by default on all platforms. The define should be removed after some bake time.

Source/WebCore:

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccumulation for values-animation is broken
zimmermann@webkit.org [Thu, 3 May 2012 09:09:30 +0000 (09:09 +0000)]
Accumulation for values-animation is broken
https://bugs.webkit.org/show_bug.cgi?id=85158

Reviewed by Zoltan Herczeg.

Follow-up patch: Add const Foo& foo() const accessors to SVGAnimatedType,
to avoid the "Foo& foo = animated->foo()" idiom in all cases where we
don't need to mutate 'foo'. Use "const Foo& foo = animated->foo()" instead.
Inline all of these methods to avoid the function call overhead.

For to-animations we actually mutated the from value before, but it wasn't a
problem in practive, as we did that on every animation step. Fully avoid these
inconsitencies by never mutating the from/to types stored in SVGAnimateElement.

Cache toAtEndOfDurationType just like m_toType/m_fromType in SVGAnimateElement,
to avoid reconstructing it on every animation step.

No new tests, only design/performance fixes.

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElement::targetElementWillChange):
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
* svg/SVGAnimateMotionElement.h:
(SVGAnimateMotionElement):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
* svg/SVGAnimatedColor.cpp:
(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):
* svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedType.cpp:
* svg/SVGAnimatedType.h:
(WebCore::SVGAnimatedType::angleAndEnumeration):
(SVGAnimatedType):
(WebCore::SVGAnimatedType::boolean):
(WebCore::SVGAnimatedType::color):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::integer):
(WebCore::SVGAnimatedType::integerOptionalInteger):
(WebCore::SVGAnimatedType::length):
(WebCore::SVGAnimatedType::lengthList):
(WebCore::SVGAnimatedType::number):
(WebCore::SVGAnimatedType::numberList):
(WebCore::SVGAnimatedType::numberOptionalNumber):
(WebCore::SVGAnimatedType::path):
(WebCore::SVGAnimatedType::pointList):
(WebCore::SVGAnimatedType::preserveAspectRatio):
(WebCore::SVGAnimatedType::rect):
(WebCore::SVGAnimatedType::string):
(WebCore::SVGAnimatedType::transformList):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::startedActiveInterval):
(WebCore::SVGAnimationElement::updateAnimation):
* svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::adjustFromToListValues):
(WebCore::SVGAnimationElement::animateDiscreteType):
(SVGAnimationElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-03 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 3 May 2012 09:02:37 +0000 (09:02 +0000)]
2012-05-03  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::resetPageVisibility):
        (LayoutTestController::setPageVisibility):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename deviceDPI to devicePixelRatio https://bugs.webkit.org/show_bug.cgi?id=85049
ahf@0x90.dk [Thu, 3 May 2012 08:54:44 +0000 (08:54 +0000)]
Rename deviceDPI to devicePixelRatio https://bugs.webkit.org/show_bug.cgi?id=85049

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests added since this is a minor refactoring with no changes
that should affect tests.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setDevicePixelRatio):
(WebCore::Settings::devicePixelRatio):
(Settings):

Source/WebKit2:

Add experimental QML API to set and get the device pixel ratio.

* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):
* UIProcess/API/qt/qquickwebview_p.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::updatePreferences):

Tools:

Use 1.5 as device pixel ratio for the Qt MiniBrowser.

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix multiple begin values support - especially with seeking through setCurrentTime
zimmermann@webkit.org [Thu, 3 May 2012 08:45:14 +0000 (08:45 +0000)]
Fix multiple begin values support - especially with seeking through setCurrentTime
https://bugs.webkit.org/show_bug.cgi?id=85372

Reviewed by Zoltan Herczeg.

Source/WebCore:

Multiple begin values aka. begin="0s; 2s" aren't correctly handled - resulting in broken & unexpected behavior.
Supporting seeking properly on documents containing such animations is very important, otherwise we can't reliable
test animations using either reftests or the SVG JS animation test framework.

Testcase:
<rect height="100" fill="green">
    <animate attributeName="width" begin="0s; 2s" dur="8s" from="0" to="100" fill="freeze"/>
</rect>

What's expected?
Two times should be contained in the 'begin' times list in SVGSMILElement: m_beginTimes = { 0s, 2s }.
The initial first resolved interval is: m_intervalBegin=0.0s, m_intervalEnd=8.0s.

During t=0s..1.9999s the m_intervalBegin/m_intervalEnd are correct.
At t=2s, a new interval can be started. m_intervalEnd should be set to nextBeginTime, where nextBeginTime=2s.
The current interval should get cropped to: m_intervalBegin=0s, m_intervalEnd=2s. The following call to
resolveNextInterval() sees that elapsed >= m_intervalEnd, and thus moves on to the next interval.
m_intervalBegin should be 2s and m_intervalEnd=10s after that.

In trunk this behavior is only partly implemented and broken. Especially broken together with seeking via SVGSVGElement.setCurrentTime.
That's because we don't correctly seek to the right interval in case of multiple begin values, eg. if we sample an animation with
begin="0s; 3s" dur="6s" we always remain in the first interval and don't move on.

Fix all of these issues, making lots more tests work in Dr. Olaf Hofmanns SVG Animation test suite.

Tests: svg/animations/multiple-begin-additive-animation.html
       svg/animations/multiple-begin-animation-discrete-expected.svg
       svg/animations/multiple-begin-animation-discrete.svg
       svg/animations/multiple-begin-animation-expected.svg
       svg/animations/multiple-begin-animation.svg

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):
* svg/animation/SMILTimeContainer.h:
(SMILTimeContainer):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::findInstanceTime):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::resolveNextInterval):
(WebCore):
(WebCore::SVGSMILElement::checkRestart):
(WebCore::SVGSMILElement::seekToIntervalCorrespondingToTime):
(WebCore::SVGSMILElement::progress):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement):

LayoutTests:

* svg/animations/multiple-begin-additive-animation-expected.txt: Added.
* svg/animations/multiple-begin-additive-animation.html: Added.
* svg/animations/multiple-begin-animation-discrete-expected.svg: Added.
* svg/animations/multiple-begin-animation-discrete.svg: Added.
* svg/animations/multiple-begin-animation-expected.svg: Added.
* svg/animations/multiple-begin-animation.svg: Added.
* svg/animations/resources/multiple-begin-additive-animation.svg: Added.
* svg/animations/script-tests/multiple-begin-additive-animation.js: Added.
(checkBaseValues):
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(sample9):
(sample10):
(sample11):
(sample12):
(sample13):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibilit...
commit-queue@webkit.org [Thu, 3 May 2012 08:22:58 +0000 (08:22 +0000)]
[EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=85347

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-03
Reviewed by Nikolas Zimmermann.

Tools:

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::resetPageVisibility): Reset the page visibility.
(LayoutTestController::setPageVisibility): Set the page visibility.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::resetPageVisibility): Not implemented.
(LayoutTestController::setPageVisibility): Not implemented.

LayoutTests:

* platformrm/efl/Skipped: Remove one test case of the Page Visibility API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Remove unneeded keyword in WebKitFeatures.cmake
gyuyoung.kim@samsung.com [Thu, 3 May 2012 08:03:24 +0000 (08:03 +0000)]
[CMAKE] Remove unneeded keyword in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=85461

Reviewed by Eric Seidel.

DEFAULT keyword wasn't removed on Bug 72815.

* Source/cmake/WebKitFeatures.cmake: Remove DEFAULT keyword in ENABLE_DRAG_SUPPORT field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't add small opaque areas to the occlusion tracker's Region
danakj@chromium.org [Thu, 3 May 2012 07:23:48 +0000 (07:23 +0000)]
[chromium] Don't add small opaque areas to the occlusion tracker's Region
https://bugs.webkit.org/show_bug.cgi?id=85297

Reviewed by Adrienne Walker.

Source/WebCore:

Don't add small opaque areas (smaller than 160x160) to the occlusion
tracker's Region objects to avoid high Region::unite() costs.

We would like Region to just be fast enough that this isn't a concern,
and there are patches in flight to do this, but at the moment, small
opaque areas add significant cost if there is many of them, for
potentially small gains since they do not cover entire tiles.

Comments in http://code.google.com/p/chromium/issues/detail?id=124687
motivate this approach for now, and point to around 160x160 being
a reasonable threshold.

Removes the opaque paint tracking flag while we're here. The flag is
no longer used, and was broken when we moved the "paint vs opaque
flag" distinction out to the layers.

Unit test: CCOcclusionTrackerTestMinimumTrackingSize

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore::CCOcclusionTrackerBase::setMinimumTrackingSize):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::preferredMinimumTrackingSize):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests):
(CCOcclusionTrackerTestMinimumTrackingSize):
(WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMigrate permission functions to Notification from NotificationCenter
jonlee@apple.com [Thu, 3 May 2012 07:06:43 +0000 (07:06 +0000)]
Migrate permission functions to Notification from NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=80485
<rdar://problem/10965458>

Reviewed by Jian Li.

Source/WebCore:

* notifications/Notification.idl: Add permission functions.
* notifications/DOMWindowNotifications.idl: Wrap webkitNotifications as part of legacy API.

* notifications/Notification.cpp: New permission functions are wrapped with ENABLE(NOTIFICATIONS)
(WebCore::Notification::taskTimerFired): Use the new permission functions to determine whether we can show the
notification.
(WebCore::Notification::permissionLevel):
(WebCore::Notification::permissionString): Declare three static locals for each of the values, and return
based on the permission enum.
(WebCore::Notification::requestPermission): Forward request to client.
* notifications/Notification.h:

* notifications/NotificationPermissionCallback.h: Added.
(NotificationPermissionCallback):
(WebCore::NotificationPermissionCallback::~NotificationPermissionCallback):
* notifications/NotificationPermissionCallback.idl: Added.

* notifications/NotificationCenter.cpp: Wrap permission functions in ENABLE(LEGACY_NOTIFICATIONS)
* notifications/NotificationCenter.h: Wrap permission functions in ENABLE(LEGACY_NOTIFICATIONS)
* notifications/NotificationCenter.idl: Refactor conditionals to make the center available only when
ENABLE(LEGACY_NOTIFICATIONS) is on.
* notifications/NotificationPresenter.h:
(WebCore::NotificationPresenter::requestPermission): Add new requestPermission() function for new
NotificationPermissionCallback type. Make it a stub implementation until all ports have adopted.

* notifications/NotificationClient.h: Add another requestPermission() client call, wrapped in
ENABLE(NOTIFICATIONS) that accepts the NotificationPermissionCallback. Wrap the original one in
ENABLE(LEGACY_NOTIFICATIONS).

* bindings/js/JSDesktopNotificationsCustom.cpp: Change to include the implementation only in
ENABLE(LEGACY_NOTIFICATIONS).
* bindings/js/JSNotificationsCustom.cpp: Custom implementation of requestPermission().
* bindings/v8/custom/V8NotificationCustom.cpp: Custom implementation of requestPermission().

* notifications/WorkerContextNotifications.idl: Make webktNotifications available only in legacy API.
* CMakeLists.txt: Add new callback idl.
* DerivedSources.make: Add new callback idl.
* DerivedSources.pri: Add new callback idl.
* GNUmakefile.list.am: Add NotificationPermissionCallback files.
* Target.pri: Include JSNotificationCustom.cpp, V8NotificationCustom.cpp
* UseJSC.cmake: Include JSNotificationCustom.cpp
* UseV8.cmake: Include V8NotificationCustom.cpp
* WebCore.gypi: Include JSNotificationCustom.cpp, V8NotificationCustom.cpp, JSNotificationPermissionCallback.{h,cpp}
* WebCore.vcproj/WebCore.vcproj: Include JSNotificationCustom.cpp, JSNotificationPermissionCallback.{h,cpp}
* WebCore.exp.in: Export permissionString().
* WebCore.xcodeproj/project.pbxproj: Add callback idl, h, and cpp files.

Source/WebKit/chromium:

* src/NotificationPresenterImpl.h:
(NotificationPresenterImpl): Add stub implementation of requestPermission.
(WebKit::NotificationPresenterImpl::requestPermission):

Source/WebKit/mac:

* WebCoreSupport/WebNotificationClient.h: *
WebCoreSupport/WebNotificationClient.mm: Add a separate callback
variable depending on the notifications API enabled.
(WebNotificationClient::requestPermission): Add
NotificationPermissionCallback version of the same
function. And refactor common code into private function.
(-[WebNotificationPolicyListener initWithCallback:]): Refactor to
take the NotificationPermissionCallback as a parameter.
(-[WebNotificationPolicyListener initWithVoidCallback:]): Add new
init method to handle legacy API.
(-[WebNotificationPolicyListener allow]): Invoke the callback for
both variables. If only one of the APIs is enabled, we are
guaranteed that the relevant callback variable exists. If both
APIs are supported, it is possible that _voidCallback will be nil
if the callback is NotificationPermissionCallback, so we need the
extra pointer check.
(-[WebNotificationPolicyListener deny]): Ditto.

Source/WebKit/qt:

* WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationPresenterClientQt): Add stub implementation of requestPermission.
(WebCore::NotificationPresenterClientQt::requestPermission):

Source/WebKit/win:

* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::requestPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
(WebDesktopNotificationsDelegate): Add stub implementation of requestPermission.

Source/WebKit2:

* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest): Add version to support both kinds of
callbacks.
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
* WebProcess/Notifications/NotificationPermissionRequestManager.h: Add another map for new callback type.
(NotificationPermissionRequestManager):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Add #ifdef to use replaceId() or tag() depending on which feature
has been enabled. In the case where both are enabled, we prefer tag() since that is in the latest spec.
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::requestPermission):
* WebProcess/WebCoreSupport/WebNotificationClient.h: Implement both client functions to request permissions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNeed tests for PerfTestRunner.computeStatistics
tomz@codeaurora.org [Thu, 3 May 2012 06:43:58 +0000 (06:43 +0000)]
Need tests for PerfTestRunner.computeStatistics
https://bugs.webkit.org/show_bug.cgi?id=85410

Reviewed by Ryosuke Niwa.

PerformanceTests:

* resources/runner.js:

LayoutTests:

* fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added.
* fast/harness/perftests/perf-runner-compute-statistics.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed morning gardening.
ossy@webkit.org [Thu, 3 May 2012 06:40:50 +0000 (06:40 +0000)]
[Qt] Unreviewed morning gardening.

* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/forms/search-rtl-expected.png: Added.
* platform/qt-5.0/fast/forms/search-rtl-expected.txt:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt]r57240 broke Qt build (gcc bug)
commit-queue@webkit.org [Thu, 3 May 2012 06:10:50 +0000 (06:10 +0000)]
[Qt]r57240 broke Qt build (gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-05-02
Reviewed by Csaba Osztrogon√°c.

Add back the inline hack just for ARM due to old version of
gcc still being used on Harmattan SDK. Thanks to Ossy for the
suggestion.
* wtf/PassRefPtr.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115907.
ossy@webkit.org [Thu, 3 May 2012 05:51:31 +0000 (05:51 +0000)]
Unreviewed, rolling out r115907.
http://trac.webkit.org/changeset/115907
https://bugs.webkit.org/show_bug.cgi?id=85458

It broke all viewport tests on Qt and on GTK (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

Source/WebCore:

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
* dom/ViewportArguments.h:
(ViewportAttributes):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
* Api/qwebpage.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::layoutSize):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::viewportConfigurationAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoResort FeatureDefinesCairo.vcprops to actually be alphabetical (in preparation for...
eric@webkit.org [Thu, 3 May 2012 05:45:17 +0000 (05:45 +0000)]
Resort FeatureDefinesCairo.vcprops to actually be alphabetical (in preparation for autogeneration)
https://bugs.webkit.org/show_bug.cgi?id=85454

Reviewed by Adam Barth.

The PreprocessorDefinitions line is still not sorted, but I'll do that in a separate patch.
There is no functional change in this patch.  Just moving the defines around.
Its interesting to me that now that it's sorted and I can easily compare this with other
ports and found that a whole bunch of defines which should be on for Cairo are off,
likely due to Cairo simply being overlooked.  These oversights should be easy to avoid
in an autogenerated world.

* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Adjusted expectations for slow tests.
caseq@chromium.org [Thu, 3 May 2012 05:03:47 +0000 (05:03 +0000)]
Unreviewed gardening. Adjusted expectations for slow tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Removed entry for fast/dom/prototype-inheritance-2.html to keep lint...
caseq@chromium.org [Thu, 3 May 2012 04:50:52 +0000 (04:50 +0000)]
Unreviewed. Removed entry for fast/dom/prototype-inheritance-2.html to keep lint happy.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115918.
commit-queue@webkit.org [Thu, 3 May 2012 04:07:45 +0000 (04:07 +0000)]
Unreviewed, rolling out r115918.
http://trac.webkit.org/changeset/115918
https://bugs.webkit.org/show_bug.cgi?id=85452

"Broke test-webkitpy on Apple Lion bots" (Requested by estes
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.__init__):
(CrashLogs.find_newest_log):
(CrashLogs._log_directory_darwin):
(CrashLogs._find_newest_log_darwin):
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_darwin):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/tool/commands/queries.py:
(execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting
eric@webkit.org [Thu, 3 May 2012 03:33:39 +0000 (03:33 +0000)]
Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting
https://bugs.webkit.org/show_bug.cgi?id=85445

Reviewed by Adam Barth.

I noticed this when comparing my auto-generated output for this file vs. the one
we have checked in.  Seems we might as well fix the checked in file to be
consistent in style with itself. :)

* win/tools/vsprops/FeatureDefines.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Finish moving modules into libWebCoreModules.la
kov@webkit.org [Thu, 3 May 2012 03:05:14 +0000 (03:05 +0000)]
[GTK] Finish moving modules into libWebCoreModules.la
https://bugs.webkit.org/show_bug.cgi?id=85449

Unreviewed build fix.

* GNUmakefile.list.am: move remaining modules source files into the
libWebCoreModules library, this should fix the problems people had
building the 1.9.1 tarball with unpatched make.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
commit-queue@webkit.org [Thu, 3 May 2012 03:01:08 +0000 (03:01 +0000)]
[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=85443

Unreviewed build fix.

Three new files were added in the Modules/webaudio directory.
These files should be included into the CMakeLists.txt file.

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02

* CMakeLists.txt: Add the newly created files into the CMakeLists.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare...
eric@webkit.org [Thu, 3 May 2012 02:52:16 +0000 (02:52 +0000)]
Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
https://bugs.webkit.org/show_bug.cgi?id=85433

Reviewed by Adam Barth.

I have a script which can autogenerate these xcconfig files as well as the
vsprops files (and soon the Chromium, cmake, gnumake and qmake) feature lists
from a central feature list file.
In preparation for posting such a tool, I'm re-sorting these xcconfig files to be
alphabetically ordered (currently they're close, but not quite).
There is also at least one inconsistency between these files (CSS_LEGACY_PREFIXES) which
I will fix in a second pass.  I will also sort the FEATURE_DEFINES = line in a follow-up patch.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't occlude pixels in a surface that are needed for a background filter...
danakj@chromium.org [Thu, 3 May 2012 02:42:31 +0000 (02:42 +0000)]
[chromium] Don't occlude pixels in a surface that are needed for a background filter blur
https://bugs.webkit.org/show_bug.cgi?id=84317

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebFilterOperation.h:

Source/WebCore:

Blur filters move pixels around, so a pixel can influence the value of
pixels at some distance away. If a pixel is not occluded, then all
pixels within the radius of the blur may influence the value of that
pixel, so they should also stay unoccluded.

For background filters, the pixels are read from the filter's target
surface, so we remove occlusion from that target surface from pixels
that will blur into visible pixels.

Unit test: CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter
           CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice
           CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip
           CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter
           CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded
           CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::reduceOcclusion):
(WebCore):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
(CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoARM_TRADITIONAL build fix
commit-queue@webkit.org [Thu, 3 May 2012 02:15:49 +0000 (02:15 +0000)]
ARM_TRADITIONAL build fix
https://bugs.webkit.org/show_bug.cgi?id=85358

Patch by Hojong Han <hojong.han@samsung.com> on 2012-05-02
Reviewed by Gavin Barraclough.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::branchSub32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert FractionalLayoutUnit overflow assertions to stderr warnings
leviw@chromium.org [Thu, 3 May 2012 02:01:30 +0000 (02:01 +0000)]
Convert FractionalLayoutUnit overflow assertions to stderr warnings
https://bugs.webkit.org/show_bug.cgi?id=85393

Reviewed by Eric Seidel.

Writing warnings to stderr when FractionalLayoutUnits overflow on debug builds instead of asserting
and crashing. It can be very useful to WebKit developers know when overflow is occurring, but it's
not always a programming error, so assert wasn't the right action.

No new tests. No change in behavior.

* platform/FractionalLayoutUnit.h:
(WebCore):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::toUnsigned):
(WebCore::FractionalLayoutUnit::setRawValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove window-properties.html and other iterate over all possible properties tests
arv@chromium.org [Thu, 3 May 2012 01:48:19 +0000 (01:48 +0000)]
Remove window-properties.html and other iterate over all possible properties tests
https://bugs.webkit.org/show_bug.cgi?id=85430

Reviewed by Eric Seidel.

These tests iterate over all properties in the global scope and their respective properties.
These tests are different on all platforms because they depend on build flags.
Each feature should be covered by a more specific test than a global catch all that breaks
every time anyone touches any IDL file.

* fast/dom/Window/window-properties-expected.txt: Removed.
* fast/dom/Window/window-properties.html: Removed.
* fast/dom/prototype-inheritance-2-expected.txt: Removed.
* fast/dom/prototype-inheritance-2.html: Removed.
* fast/dom/prototype-inheritance-expected.txt: Removed.
* fast/dom/prototype-inheritance.html: Removed.
* fast/dom/script-tests/prototype-inheritance-2.js: Removed.
* fast/dom/script-tests/prototype-inheritance.js: Removed.
* platform/chromium-win/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/chromium-win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/chromium/fast/dom/prototype-inheritance-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/mac/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Removed.
* platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/qt-5.0/fast/dom/Window/window-properties-expected.png: Removed.
* platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/qt-arm/Skipped:
* platform/qt/fast/dom/prototype-inheritance-2-expected.png: Removed.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/qt/fast/dom/prototype-inheritance-expected.png: Removed.
* platform/win/Skipped:
* platform/win/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
jhoneycutt@apple.com [Thu, 3 May 2012 01:39:37 +0000 (01:39 +0000)]
FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
information about the form being submitted
https://bugs.webkit.org/show_bug.cgi?id=84297

Reviewed by Andy Estes.

Source/WebCore:

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareForSubmission):
Get the form field names and values, and use them to create a FormState
object. Pass this object when calling dispatchWillSendSubmitEvent().
(WebCore::HTMLFormElement::getTextFieldValues):
Loop over the associated elements, looking for <input> elements.
Collect their names and values.

* html/HTMLFormElement.h:
Declare getTextFieldData().

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchWillSendSubmitEvent):
Updated declaration for new parameter type.

* loader/FrameLoaderClient.h:
Updated declaration of dispatchWillSendSubmitEvent() for new param
type.

Source/WebKit/blackberry:

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
Updated to use the FormState.

* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
Updated method declaration.

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent):
Updated to use the FormState.

* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
Updated method declaration.

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.h:
(WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.h:
(WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
Updated method declaration.

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.h:
(WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/win:

* WebFrame.h:
Fix function stub for new parameter.

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.h:
(WebKit::FrameLoaderClientWinCE::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.h:
(WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):
Updated method declaration.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
Updated method declaration.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::willSendSubmitEvent):
Stubbed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake Page::setDefersLoading() have a call count so that each time
jhoneycutt@apple.com [Thu, 3 May 2012 01:39:16 +0000 (01:39 +0000)]
Make Page::setDefersLoading() have a call count so that each time
loading is deferred, it must be balanced with a call to resume.
https://bugs.webkit.org/show_bug.cgi?id=84522

Reviewed by Andy Estes.

Source/WebCore:

* page/Page.cpp:
(WebCore::Page::Page):
Initialize new call count member.
(WebCore::Page::setDefersLoading):
Check whether the callers wants balanced defer/resume loading behavior.
If the call count is not changing from 0 to 1 or 1 to 0, return early.
Otherwise, defer or resume loading for frames in this page.

* page/Page.h:
(WebCore::Page::defersLoading):
Added a member to hold the call count.

* page/Settings.cpp:
(WebCore::Settings::Settings):
Initialized new member m_wantsBalancedSetDefersLoadingBehavior.

* page/Settings.h:
(Settings):
Added new member m_wantsBalancedSetDefersLoadingBehavior.
(WebCore::Settings::setWantsBalancedSetDefersLoadingBehavior):
Setter.
(WebCore::Settings::wantsBalancedSetDefersLoadingBehavior):
Getter.

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
Declare a new key for this preference.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Initialize new preference to NO.
(-[WebPreferences setWantsBalancedSetDefersLoadingBehavior:]):
Setter.
(-[WebPreferences wantsBalancedSetDefersLoadingBehavior]):
Getter.

* WebView/WebPreferencesPrivate.h:
Declare setter and getter.

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Set the setting from the WebPreferences object's value.

Source/WebKit2:

* Shared/WebPreferencesStore.h:
Use the macro to declare the new preference.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Set the setting from the WebPreferencesStore's value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a histogram for rendertree size
ojan@chromium.org [Thu, 3 May 2012 01:24:40 +0000 (01:24 +0000)]
Add a histogram for rendertree size
https://bugs.webkit.org/show_bug.cgi?id=85226

Reviewed by Eric Seidel.

Source/WebCore:

We record it when the page gets hidden, since this is a point
at which, in theory, we could kill the rendertree.

No new tests. This isn't web visible, so there's no way to test it.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
* page/Page.cpp:
(WebCore::Page::renderTreeSize):
(WebCore):
(WebCore::Page::setVisibilityState):
* page/Page.h:
(Page):
* platform/HistogramSupport.cpp:
(WebCore::HistogramSupport::histogramCustomCounts):
(WebCore):
* platform/HistogramSupport.h:
(HistogramSupport):
* platform/chromium/HistogramSupportChromium.cpp:
(WebCore::HistogramSupport::histogramCustomCounts):
(WebCore):

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::renderTreeSize):
Move the renderTreeSize code into Page.cpp, so it can be reused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSuppress svg failure after switching chromium-win to DRT mode.
dpranke@chromium.org [Thu, 3 May 2012 01:13:46 +0000 (01:13 +0000)]
Suppress svg failure after switching chromium-win to DRT mode.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115902.
zmo@google.com [Thu, 3 May 2012 01:12:03 +0000 (01:12 +0000)]
Unreviewed, rolling out r115902.
http://trac.webkit.org/changeset/115902
https://bugs.webkit.org/show_bug.cgi?id=85441

Compile failure on linux 32 (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

Source/WebCore:

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

LayoutTests:

* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/key-generator.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll Chromium DEPS r134537 to r134581.
jsbell@chromium.org [Thu, 3 May 2012 00:53:06 +0000 (00:53 +0000)]
Roll Chromium DEPS r134537 to r134581.
https://bugs.webkit.org/show_bug.cgi?id=85428

Unreviewed - just a deps roll.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove sys.platform accesses in CrashLogs.
rakuco@webkit.org [Thu, 3 May 2012 00:31:07 +0000 (00:31 +0000)]
webkitpy: Remove sys.platform accesses in CrashLogs.
https://bugs.webkit.org/show_bug.cgi?id=85436

Reviewed by Dirk Pranke.

Instead of directly checking for sys.platform == 'darwin', use a
SystemHost and call PlatformInfo.is_mac().

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.__init__):
(CrashLogs.find_newest_log):
(CrashLogs._log_directory_darwin):
(CrashLogs._find_newest_log_darwin):
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_darwin):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/tool/commands/queries.py:
(execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115905.
commit-queue@webkit.org [Thu, 3 May 2012 00:29:26 +0000 (00:29 +0000)]
Unreviewed, rolling out r115905.
http://trac.webkit.org/changeset/115905
https://bugs.webkit.org/show_bug.cgi?id=85435

New computeStatistics test is failing on chromium ports
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-02

PerformanceTests:

* resources/runner.js:

LayoutTests:

* fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Removed.
* fast/harness/perftests/perf-runner-compute-statistics.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOpportunistic GC should give up if the Heap is paged out
mhahnenberg@apple.com [Thu, 3 May 2012 00:14:05 +0000 (00:14 +0000)]
Opportunistic GC should give up if the Heap is paged out
https://bugs.webkit.org/show_bug.cgi?id=85411

Reviewed by Filip Pizlo.

Opportunistic GC is punishing us severely in limited memory situations because its
assumptions about how much time a collection will take are way out of whack when the Heap
has been paged out by the OS. We should add a simple detection function to the Heap that
detects if its is paged out. It will do this by iterating each block of both the MarkedSpace
and CopiedSpace. If that operation takes longer than a fixed amount of time (e.g. 100ms),
the function returns true. This function will only be run prior to an opportunistic
collection (i.e. it will not run during our normal allocation-triggered collections).

In my tests, steady state was drastically improved in high memory pressure situations (i.e.
the browser was still usable, significant reduction in SPODs). Occasionally, a normal GC
would be triggered due to pages doing things in the background, which would cause a
significant pause. As we close pages we now cause normal collections rather than full
collections, which prevents us from collecting all of the dead memory immediately. One
nice way to deal with this issue might be to do incremental sweeping.

* heap/CopiedSpace.cpp:
(JSC::isBlockListPagedOut): Helper function to reduce code duplication when iterating over
to-space, from-space, and the oversize blocks.
(JSC):
(JSC::CopiedSpace::isPagedOut): Tries to determine whether or not CopiedSpace is paged out
by iterating all of the blocks.
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/Heap.cpp:
(JSC::Heap::isPagedOut): Tries to determine whether the Heap is paged out by asking the
MarkedSpace and CopiedSpace if they are paged out.
(JSC):
* heap/Heap.h:
(Heap):
(JSC::Heap::increaseLastGCLength): Added this so that the GC timer can linearly back off
each time it determines that the Heap is paged out.
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::isPagedOut): Tries to determine if this particular MarkedAllocator's
list of blocks are paged out.
(JSC):
* heap/MarkedAllocator.h:
(MarkedAllocator):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::isPagedOut): For each MarkedAllocator, check to see if they're paged out.
* heap/MarkedSpace.h:
(MarkedSpace):
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::cancel):
(JSC):
* runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::cancel):
(DefaultGCActivityCallback):
* runtime/GCActivityCallbackCF.cpp: Added a constant of 100ms for the timeout in determining
whether the Heap is paged out or not.
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire): Added the check to see if we
should attempt a collection based on whether or not we can iterate the blocks of the Heap in
100ms. If we can't, we cancel the timer and tell the Heap we just wasted 100ms more trying to
do a collection. This gives us a nice linear backoff so we're not constantly re-trying in
steady state paged-out-ness.
(JSC::DefaultGCActivityCallback::cancel): Added this function which, while currently doing
exactly the same thing as willCollect, is more obvious as to what it's doing when we call it
in timerDidFire.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer
jchaffraix@webkit.org [Wed, 2 May 2012 23:56:08 +0000 (23:56 +0000)]
Add ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=84920

Reviewed by Simon Fraser.

Covered by existing tests in Debug (at least several time!).

This change adds some ASSERTs on RenderLayer that prevent any use of its lists if they
are dirtied.

On top of this change, we added an invariant that non-stacking contexts should have their
z-index lists NULL (instead of empty or NULL previously). This is enforced at
updateZOrderLists time as we now ensure that it is called in a timely manner.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds):
Added call to updateLayersIfNeeded as we will query them later and there is no guarantee
that they are not dirty (we recurse in our children as part of calculateLayerBounds).
This was causing the new ASSERTs to trigger on css3/filter/ tests.

(WebCore::RenderLayer::dirtyZOrderLists):
Added a comment as to why we can't ASSERT that we are in a stacking context here.

(WebCore::RenderLayer::rebuildZOrderLists):
Added an ASSERT that we only rebuild z-index lists for dirtied stacking context.

(WebCore::RenderLayer::updateLayerListsIfNeeded):
Updated to ensure that the reflection layer has its layers updated too. This was triggering
the new ASSERTs on fast/runins/run-in-layer-not-removed-crash.html.

(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
Updated to use the new isDirtyStackingContext function.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::isDirtyStackingContext):
New helper function. Also made updateLayerListsIfNeeded() the only way
to update layer. That should prevent any misuse.

(WebCore::RenderLayer::posZOrderList):
(WebCore::RenderLayer::negZOrderList):
(WebCore::RenderLayer::normalFlowList):
ASSERT that we don't query any of the previous lists if they are dirty. Also
enforce the invariant that non-stacking contexts should have NULL z-index lists.

(WebCore::RenderLayer::clearZOrderLists):
New function to clearZOrderLists so that we can enfore the previous invariant.

(WebCore::RenderLayer::updateZOrderLists):
Updated to clear the dirty flag and the z-index lists for non-stacking context.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Removed the explicit ASSERTs.

(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::canBeComposited):
Disabled compositing on RenderLayer in flow thread. Because flow thread's
RenderLayer are not collected as part of RenderLayer's lists and could be composited,
this was causing the new ASSERTs to trigger (e.g. on fast/regions/webkit-flow-renderer-layer.html).

* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
Updated to use updateLayerListsIfNeeded().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Special-case win32 calls in file_lock and executive.
rakuco@webkit.org [Wed, 2 May 2012 23:48:15 +0000 (23:48 +0000)]
webkitpy: Special-case win32 calls in file_lock and executive.
https://bugs.webkit.org/show_bug.cgi?id=85431

Reviewed by Dirk Pranke.

Simplify accesses to sys.platform by only checking if sys.platform
is "win32" and removing explicit checks for the else case.

* Scripts/webkitpy/common/system/executive.py:
(Executive.check_running_pid):
* Scripts/webkitpy/common/system/file_lock.py:
(FileLock._create_lock):
(FileLock._remove_lock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline, unreviewed.
zmo@google.com [Wed, 2 May 2012 23:42:58 +0000 (23:42 +0000)]
Rebaseline, unreviewed.

* platform/chromium-linux-x86/http/tests/loading: Added.
* platform/chromium-linux-x86/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
* platform/chromium-linux/http/tests/loading/pdf-commit-load-callbacks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDF page does not show up when opened in the background
andersca@apple.com [Wed, 2 May 2012 23:35:57 +0000 (23:35 +0000)]
PDF page does not show up when opened in the background
https://bugs.webkit.org/show_bug.cgi?id=85427
<rdar://problem/11259951>

Reviewed by Sam Weinig.

Ensure that the accelerated hosting view is always the bottom view so it won't obscure subviews that are before it.

* UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove pink from flakiness dashboard
ojan@chromium.org [Wed, 2 May 2012 23:27:40 +0000 (23:27 +0000)]
Remove pink from flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85422

Reviewed by Dirk Pranke.

The pink indicates that the test doesn't match it's listing in test_expectations.txt.
In practice, this just added noise and confused people.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForSingleTestRow):
(showLegend):
* TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
(#legend-contents *):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(testHtmlForSingleTestRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused adjustForAbsoluteZoom method in RenderObject.h
leviw@chromium.org [Wed, 2 May 2012 23:26:50 +0000 (23:26 +0000)]
Remove unused adjustForAbsoluteZoom method in RenderObject.h
https://bugs.webkit.org/show_bug.cgi?id=85396

Reviewed by Eric Seidel.

We only want to use the integer adjustForAbsoluteZoom method, so this remnant is both unused
and potentially confusing.

No new tests. Removing unused code.

* rendering/RenderObject.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoving line in computeViewportAttributes that enforces a minimum scale factor to...
fsamuel@chromium.org [Wed, 2 May 2012 23:15:41 +0000 (23:15 +0000)]
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Make ViewportAttributes' layoutSize be a FloatRect to avoid rounding
too early, and the occasional off by one fixed layout dimensions.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
* dom/ViewportArguments.h:
(ViewportAttributes):

Source/WebKit/qt:

* Api/qwebpage.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::layoutSize):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 2 May 2012 23:11:32 +0000 (23:11 +0000)]
Unreviewed gardening.

Rebaselined overflow-delete-line.html and ancestor-overflow.html.

The pixel changes are only text differences.

* fast/repaint/overflow-delete-line-expected.txt: Added.
* platform/chromium-mac-leopard/compositing/overflow/ancestor-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png:
* platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/overflow-delete-line-expected.txt: Removed.
* platform/chromium-win/compositing/overflow/ancestor-overflow-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/repaint/overflow-delete-line-expected.txt: Removed.
* platform/gtk/fast/repaint/overflow-delete-line-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNeed tests for PerfTestRunner.computeStatistics
tomz@codeaurora.org [Wed, 2 May 2012 23:08:48 +0000 (23:08 +0000)]
Need tests for PerfTestRunner.computeStatistics
https://bugs.webkit.org/show_bug.cgi?id=85410

Reviewed by Ryosuke Niwa.

PerformanceTests:

* resources/runner.js:

LayoutTests:

* fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added.
* fast/harness/perftests/perf-runner-compute-statistics.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix mistake I committed when applying review comments.
kov@webkit.org [Wed, 2 May 2012 23:08:10 +0000 (23:08 +0000)]
Unreviewed. Fix mistake I committed when applying review comments.

* jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
appended to its path, so jhbuild itself was being cloned and
installed in the wrong place when using WEBKITOUTPUTDIR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: make ServerProcess work on chromium win
dpranke@chromium.org [Wed, 2 May 2012 23:05:52 +0000 (23:05 +0000)]
nrwt: make ServerProcess work on chromium win
https://bugs.webkit.org/show_bug.cgi?id=85333

Reviewed by Ojan Vafai.

This change implements a poor man's select() that will
slow-spin doing non-blocking reads on the stdout and stderr
named pipes connecting the worker to the driver. Seems to work
and I have yet to see much overhead or ill effects but it
probably needs more testing.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._start):
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
(ServerProcess):
(ServerProcess._non_blocking_read_win32):
(ServerProcess._read):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_basic): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Handle generated keys up to 2^53
jsbell@chromium.org [Wed, 2 May 2012 23:03:42 +0000 (23:03 +0000)]
IndexedDB: Handle generated keys up to 2^53
https://bugs.webkit.org/show_bug.cgi?id=85114

Source/WebCore:

The spec defines the behavior for generated keys up to 2^53
(the maximum integer storable as an ECMAScript number) and
the error case when going beyond that. Ensure that we can
handle values up to that point and generate errors beyond.

Reviewed by Tony Chang.

Test: storage/indexeddb/key-generator.html

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

LayoutTests:

Reviewed by Tony Chang.

* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/key-generator.js:
(get defineTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline, unreviewed.
zmo@google.com [Wed, 2 May 2012 23:01:22 +0000 (23:01 +0000)]
Rebaseline, unreviewed.

* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
rakuco@webkit.org [Wed, 2 May 2012 22:55:32 +0000 (22:55 +0000)]
webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85426

Reviewed by Dirk Pranke.

r115880 replaced the direct use of sys.platform with a
PlatformInfo object. Dirk Pranke later told me SystemHost objects
should be preferred, as nothing out of webkitpy.common.system
should create its own PlatformInfo instances.

* Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.__init__): Make it possible to specify a custom
filesystem object.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.__init__): Accept a host object instead of a
filesystem one, which is now obtained from host.
(PNGChecker._config_file_path): Retrieve PlatformInfo from
SystemHost.
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
constructor signature.
(PNGCheckerTest.test_check): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline, unreviewed.
zmo@google.com [Wed, 2 May 2012 22:53:26 +0000 (22:53 +0000)]
Rebaseline, unreviewed.

* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium/media/media-can-play-wav-audio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
rakuco@webkit.org [Wed, 2 May 2012 22:22:02 +0000 (22:22 +0000)]
webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
https://bugs.webkit.org/show_bug.cgi?id=85424

Reviewed by Tony Chang.

We should reduce direct usage of sys.platform in webkitpy and use
PlatformInfo instead.

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
checking for 'darwin' directly.
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.__init__): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChildlist mutations in shadow DOM should be observable with MutationObservers
adamk@chromium.org [Wed, 2 May 2012 22:04:15 +0000 (22:04 +0000)]
Childlist mutations in shadow DOM should be observable with MutationObservers
https://bugs.webkit.org/show_bug.cgi?id=85402

Reviewed by Ojan Vafai.

Source/WebCore:

Though Mutation Events are not supported in Shadow DOM,
MutationObservers are supposed to be. Due to a misplacement of the
ChildListMutationScope, they were erroneously getting skipped.

This patch moves code around to properly notify when childlist are
mutated in shadow DOM and covers that change with a new test.

Test: fast/mutation/shadow-dom.html

* dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Handle notification of removal directly.
(WebCore::willRemoveChildren): ditto.
(WebCore::dispatchChildInsertionEvents): Remove notification of insertion.
(WebCore::dispatchChildRemovalEvents): Remove notification of removal.
(WebCore::updateTreeAfterInsertion): Handle notification of insertion directly.

LayoutTests:

Added test covering childList mutations as well as attribute and
characterData mutations (these were already working).

* fast/mutation/shadow-dom-expected.txt: Added.
* fast/mutation/shadow-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::TextTrackList::remove
eric.carlson@apple.com [Wed, 2 May 2012 22:01:37 +0000 (22:01 +0000)]
Crash in WebCore::TextTrackList::remove
https://bugs.webkit.org/show_bug.cgi?id=85095

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/track/track-remove-quickly.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::willRemoveTrack): Return immediately if the tracks collection
    has not been allocated yet.

LayoutTests:

* media/track/track-remove-quickly-expected.txt: Added.
* media/track/track-remove-quickly.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter appending MathML with jquery the table renders with overlaps
commit-queue@webkit.org [Wed, 2 May 2012 22:00:04 +0000 (22:00 +0000)]
After appending MathML with jquery the table renders with overlaps
https://bugs.webkit.org/show_bug.cgi?id=52444

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-02
Reviewed by Julien Chaffraix.

Source/WebCore:

This patch also fixes bugs 72834 and 47781. The main problem is that correct preferred
logical widths are affected by operator stretching. Thus we add a call to
setNeedsLayoutAndPrefWidthsRecalc() after the stretching code in
RenderMathMLOperator.cpp, and change RenderMathMLBlock and RenderMathMLRow to make sure
that stretching of children is done before an <mrow>'s preferred logical widths are
computed.

Test: Added a test to mathml/presentation/mo-stretch.html

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):
* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::unembellishedOperator):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):
    - Add m_preferredLogicalHeight and methods to compute and return it.
    - Remove stretchToHeight() from most classes as it no longer needs to be done
      recursively. We just call it on the base of an embellished operator, and that
      calls setNeedsLayoutAndPrefWidthsRecalc() to mark itself and its container
      chain.

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::stretchToHeight):
    - Don't compare an unexpanded height to an expanded one.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLOperator::updateFromElement):
    - After stretching, call setNeedsLayoutAndPrefWidthsRecalc().
* rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):

* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
    - Add computePreferredLogicalWidths(), using computeChildrenPreferredLogicalHeights()
      to compute our children's preferred logical heights if necessary, followed by
      operator stretching.

* rendering/mathml/RenderMathMLSubSup.cpp:
* rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
* rendering/mathml/RenderMathMLUnderOver.cpp:
* rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):

LayoutTests:

* mathml/presentation/mo-stretch.html:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
rakuco@webkit.org [Wed, 2 May 2012 21:55:19 +0000 (21:55 +0000)]
webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Reviewed by Dirk Pranke.

As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
be created directly, we should should a SystemHost instead.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
object from it instead of creating PlatformInfo directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLet WebKit parse with clang on windows with -std=c++11
thakis@chromium.org [Wed, 2 May 2012 21:51:50 +0000 (21:51 +0000)]
Let WebKit parse with clang on windows with -std=c++11
https://bugs.webkit.org/show_bug.cgi?id=85398

Reviewed by Ryosuke Niwa.

See http://trac.webkit.org/changeset/85945 for background on the line
I'm changing. With clang, __GXX_EXPERIMENTLAL_CXX0X__ is set in c++11
mode, but MSVC's c++ library doesn't have a tr1/memory header. So also
check for __GLIBCXX__, like it's done in the rest of this file.

* wtf/TypeTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
kov@webkit.org [Wed, 2 May 2012 21:49:31 +0000 (21:49 +0000)]
Unreviewed gardening.

* platform/gtk/test_expectations.txt: remove duplicate annotation
for fast/workers/storage/use-same-database-in-page-and-workers.html,
added comment explaining the ocasional ASSERT that's a
cross-platform problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomedia/audio-repaint.html sometimes fails on Lion Debug (Tests)
aestes@apple.com [Wed, 2 May 2012 21:44:08 +0000 (21:44 +0000)]
media/audio-repaint.html sometimes fails on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84357

* platform/mac/Skipped: Skipped the flaky test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate two more Mac baselines.
aestes@apple.com [Wed, 2 May 2012 21:41:23 +0000 (21:41 +0000)]
Update two more Mac baselines.

* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document
jochen@chromium.org [Wed, 2 May 2012 21:40:07 +0000 (21:40 +0000)]
[chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document
https://bugs.webkit.org/show_bug.cgi?id=85201

Reviewed by Adam Barth.

Embedders should use webFrame->document()->referrerPolicy() instead of webFrame->referrerPolicy(). The latter will be removed soon.

* public/WebDocument.h:
(WebDocument):
* src/WebDocument.cpp:
(WebKit::WebDocument::referrerPolicy):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
rakuco@webkit.org [Wed, 2 May 2012 21:32:33 +0000 (21:32 +0000)]
webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Rubber-stamped by Dirk Pranke.

Follow-up patch to r115887 which fixes some capitalization problems
pointed out in comments 2 and 4.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_exception_raised):
(MainTest.test_keyboard_interrupt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
rakuco@webkit.org [Wed, 2 May 2012 21:16:00 +0000 (21:16 +0000)]
webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Reviewed by Dirk Pranke.

Another part of the work towards replacing direct sys.platform
usage with PlatformInfo.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
here. Even though it is costlier, unittest.setUpClass was
introduced in Python 2.7.
(MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
(MainTest.test_child_processes_min): Ditto.
(MainTest.test_exception_raised): Ditto.
(MainTest.test_keyboard_interrupt): Ditto.
(MainTest.test_crash_log): Check for PlatformInfo.is_mac().
(MainTest.test_web_process_crash_log): Ditto, and remove duplicate
check at the end.
(MainTest.test_no_http_tests): Remove check for (cygwin && Python
2.5.2), as we only support Python 2.6+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Avoid extra Region copies in CCOcclusionTracker
danakj@chromium.org [Wed, 2 May 2012 21:09:44 +0000 (21:09 +0000)]
[chromium] Avoid extra Region copies in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=85257

Reviewed by Adrienne Walker.

Instead of making a Region for each layer and then uniting the region
with the current occlusion, directly add the rects for the given layer
to the current occlusion.

When subtracting a region from a rect, just subtract the region
directly instead of computing the intersecting region.

Covered by existing tests.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::rectSubtractRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate more Mac baselines after r115846.
aestes@apple.com [Wed, 2 May 2012 20:54:50 +0000 (20:54 +0000)]
Update more Mac baselines after r115846.

* platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/mac/fast/block/float/avoiding-float-centered-expected.txt:
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoblockquote gets clobbered on delete, but the font-tag inside it doesn't
rniwa@webkit.org [Wed, 2 May 2012 20:53:57 +0000 (20:53 +0000)]
blockquote gets clobbered on delete, but the font-tag inside it doesn't
https://bugs.webkit.org/show_bug.cgi?id=19702

Reviewed by Enrica Casucci.

Add a regression test initially authored by Ojan Vafai since this bug appears to have been fixed already.

* editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt: Added.
* editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Double tap zooming does nothing on small size table
commit-queue@webkit.org [Wed, 2 May 2012 20:53:04 +0000 (20:53 +0000)]
[BlackBerry] Double tap zooming does nothing on small size table
https://bugs.webkit.org/show_bug.cgi?id=85383

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-02
Reviewed by George Staikos.

PR: 153232
When we search the best node for block zoom, if the initial node's new
scale exceeds the maximum block zoom scale, we will try to walk through
it's ancestors and pick the acceptable one. But the reality is that the
acceptable ancestor's size can be too close to the size of the actual
contents, we will do nothing for it. As we will still select the
minimum of the new scale and the maximum block zoom scale as block zoom
scale, we can ignore such kind of node and use the initial node instead.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomLimits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI
commit-queue@webkit.org [Wed, 2 May 2012 20:48:04 +0000 (20:48 +0000)]
[Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI
https://bugs.webkit.org/show_bug.cgi?id=85089

Patch by Keith Rosenblatt <keith.rosenblatt@nokia.com> on 2012-05-02
Reviewed by Simon Hausmann.

Source/WebCore:

Do not return data referencing an invalid QRawFont from createFontCustomPlatformData().  Instead
return null.

Test: fast/css/font-face-data-uri-invalid.html

* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::createFontCustomPlatformData):

LayoutTests:

* fast/css/font-face-data-uri-invalid-expected.txt: Added.
* fast/css/font-face-data-uri-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Set contents texture manager preferred memory limit based on GpuMemoryMana...
commit-queue@webkit.org [Wed, 2 May 2012 20:42:54 +0000 (20:42 +0000)]
[chromium] Set contents texture manager preferred memory limit based on GpuMemoryManager suggestion.
https://bugs.webkit.org/show_bug.cgi?id=84270

Patch by Michal Mocny <mmocny@google.com> on 2012-05-02
Reviewed by Kenneth Russell.

Source/WebCore:

Updates the content texture manager memory limits based on GpuMemoryManager memory allocation suggestions.

The memory allocation size (in bytes) is fed from LayerRendererChromium memory allocation changed callback
handler to CCLayerTreeHost.  At that point we adjust the limits, using the existing notions of preferred and
max limits.

On android, the preferred limit is half the maximum (as it has always been), but on all other platforms the
preferred limit is now equal to max, in order to allow more agressive prepainting.

Finally, android has memory constraints dependant on viewportSize, but that logic has been pushed into
the GpuMemoryManager.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::onGpuMemoryAllocationChanged):
(WebCore::LayerRendererChromium::beginDrawingFrame):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::setMemoryAllocationLimitBytes):
(WebCore):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setContentsMemoryAllocationLimitBytes):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setContentsMemoryAllocationLimitBytes):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/LayerRendererChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Remove direct sys.platform usage in the PNG checker.
rakuco@webkit.org [Wed, 2 May 2012 20:38:04 +0000 (20:38 +0000)]
webkitpy: Remove direct sys.platform usage in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85407

Reviewed by Tony Chang.

Work towards replacing direct sys.platform usage with
PlatformInfo.

* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.__init__): Accept os_name and os_version as
arguments.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.__init__): Create a PlatformInfo object instead of
using sys.platform when needed.
(PNGChecker._config_file_path): Check for the current platform via
PlatformInfo.
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check): Update tests after the changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Mac baselines after r115846.
aestes@apple.com [Wed, 2 May 2012 20:31:47 +0000 (20:31 +0000)]
Update Mac baselines after r115846.

* platform/mac/fast/clip/008-expected.txt:
* platform/mac/fast/clip/011-expected.txt:
* platform/mac/fast/clip/012-expected.txt:
* platform/mac/fast/forms/input-text-double-click-expected.txt:
* platform/mac/fast/repaint/overflow-delete-line-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:
* platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/hixie/mixed/003-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix usage of layout types in platform code
eae@chromium.org [Wed, 2 May 2012 20:29:39 +0000 (20:29 +0000)]
Fix usage of layout types in platform code
https://bugs.webkit.org/show_bug.cgi?id=85392

Reviewed by Eric Seidel.

Source/WebCore:

No new tests, no change in functionality.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):
Use rounded point for gestures as event handling is still mostly int based.

Source/WebKit/chromium:

* src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::localPoint):
* src/WebSurroundingText.cpp:
(WebKit::WebSurroundingText::initialize):
Explicitly cast WebPoint to IntPoint to avoid ambiguous conversion error.

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_scale_set):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
Use enclosingIntRect to convert visible rect for transform results to
line up with device pixels.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
Use pixelSnapped rect for editor rect calculation as it represents a
device coordinate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 2 May 2012 20:27:32 +0000 (20:27 +0000)]
2012-05-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, rebaseline pdf-commit-load-callbacks.html for chromium-linux.

        * platform/chromium-linux/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed, rebaselining after changes in r115846.
ossy@webkit.org [Wed, 2 May 2012 20:17:13 +0000 (20:17 +0000)]
[Qt] Unreviewed, rebaselining after changes in r115846.

REGRESSION(110072): Clipping is not applied on layers that are animated using platform code
https://bugs.webkit.org/show_bug.cgi?id=83954

* platform/qt/animations/combo-transform-translate+scale-expected.txt: Added.
* platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
* platform/qt/compositing/overflow/ancestor-overflow-expected.png:
* platform/qt/compositing/overflow/ancestor-overflow-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/qt/editing/pasteboard/4806874-expected.png:
* platform/qt/editing/pasteboard/4806874-expected.txt:
* platform/qt/editing/pasteboard/input-field-1-expected.png:
* platform/qt/editing/pasteboard/input-field-1-expected.txt:
* platform/qt/editing/selection/3690703-2-expected.png:
* platform/qt/editing/selection/3690703-2-expected.txt:
* platform/qt/editing/selection/3690703-expected.png:
* platform/qt/editing/selection/3690703-expected.txt:
* platform/qt/editing/selection/3690719-expected.png:
* platform/qt/editing/selection/3690719-expected.txt:
* platform/qt/editing/selection/4895428-3-expected.png:
* platform/qt/editing/selection/4895428-3-expected.txt:
* platform/qt/editing/selection/4975120-expected.png:
* platform/qt/editing/selection/4975120-expected.txt:
* platform/qt/editing/selection/drag-select-1-expected.png:
* platform/qt/editing/selection/drag-select-1-expected.txt:
* platform/qt/editing/selection/expanding-selections-expected.png:
* platform/qt/editing/selection/expanding-selections-expected.txt:
* platform/qt/editing/selection/leave-requested-block-expected.png:
* platform/qt/editing/selection/leave-requested-block-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/qt/fast/block/float/032-expected.png:
* platform/qt/fast/block/float/032-expected.txt:
* platform/qt/fast/block/float/033-expected.txt:
* platform/qt/fast/block/float/avoidance-rtl-expected.txt:
* platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.png:
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/qt/fast/block/float/in-margin-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
* platform/qt/fast/block/float/in-margin-expected.txt:
* platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
* platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/qt/fast/clip/008-expected.png:
* platform/qt/fast/clip/008-expected.txt:
* platform/qt/fast/clip/011-expected.png:
* platform/qt/fast/clip/011-expected.txt:
* platform/qt/fast/clip/012-expected.png:
* platform/qt/fast/clip/012-expected.txt:
* platform/qt/fast/clip/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.png.
* platform/qt/fast/clip/017-expected.txt:
* platform/qt/fast/css/input-search-padding-expected.png:
* platform/qt/fast/css/input-search-padding-expected.txt:
* platform/qt/fast/css/invalidation-errors-2-expected.png:
* platform/qt/fast/css/invalidation-errors-2-expected.txt:
* platform/qt/fast/css/invalidation-errors-expected.png:
* platform/qt/fast/css/invalidation-errors-expected.txt:
* platform/qt/fast/css/line-height-expected.png:
* platform/qt/fast/css/line-height-expected.txt:
* platform/qt/fast/css/nested-layers-with-hover-expected.png:
* platform/qt/fast/css/nested-layers-with-hover-expected.txt:
* platform/qt/fast/css/resize-single-axis-expected.txt: Added.
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.txt:
* platform/qt/fast/dom/isindex-001-expected.png: Added.
* platform/qt/fast/dom/isindex-001-expected.txt:
* platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.png:
* platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.png:
* platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/qt/fast/dynamic/subtree-table-cell-height-expected.png:
* platform/qt/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/qt/fast/events/context-no-deselect-expected.png: Added.
* platform/qt/fast/events/context-no-deselect-expected.txt:
* platform/qt/fast/events/mouse-relative-position-expected.txt: Added.
* platform/qt/fast/forms/basic-inputs-expected.txt:
* platform/qt/fast/forms/date/date-appearance-expected.png: Added.
* platform/qt/fast/forms/date/date-appearance-expected.txt: Added.
* platform/qt/fast/forms/encoding-test-expected.png: Copied from LayoutTests/platform/qt/fast/forms/search-styled-expected.png.
* platform/qt/fast/forms/encoding-test-expected.txt:
* platform/qt/fast/forms/fieldset-align-expected.png: Added.
* platform/qt/fast/forms/fieldset-align-expected.txt:
* platform/qt/fast/forms/floating-textfield-relayout-expected.png: Added.
* platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
* platform/qt/fast/forms/input-align-expected.png: Added.
* platform/qt/fast/forms/input-align-expected.txt:
* platform/qt/fast/forms/input-appearance-bkcolor-expected.png: Added.
* platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
* platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/qt/fast/forms/input-appearance-disabled-expected.png: Added.
* platform/qt/fast/forms/input-appearance-disabled-expected.txt:
* platform/qt/fast/forms/input-appearance-focus-expected.png: Added.
* platform/qt/fast/forms/input-appearance-focus-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.png: Added.
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/qt/fast/forms/input-appearance-readonly-expected.png: Added.
* platform/qt/fast/forms/input-appearance-readonly-expected.txt:
* platform/qt/fast/forms/input-appearance-selection-expected.png: Added.
* platform/qt/fast/forms/input-appearance-visibility-expected.png: Added.
* platform/qt/fast/forms/input-appearance-visibility-expected.txt:
* platform/qt/fast/forms/input-baseline-expected.png: Added.
* platform/qt/fast/forms/input-baseline-expected.txt:
* platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
* platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/qt/fast/forms/input-field-text-truncated-expected.png: Added.
* platform/qt/fast/forms/input-field-text-truncated-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/qt/fast/forms/input-readonly-empty-expected.png: Added.
* platform/qt/fast/forms/input-readonly-empty-expected.txt:
* platform/qt/fast/forms/input-spaces-expected.png: Added.
* platform/qt/fast/forms/input-spaces-expected.txt:
* platform/qt/fast/forms/input-text-click-inside-expected.png: Added.
* platform/qt/fast/forms/input-text-click-inside-expected.txt:
* platform/qt/fast/forms/input-text-double-click-expected.png: Added.
* platform/qt/fast/forms/input-text-double-click-expected.txt:
* platform/qt/fast/forms/input-text-option-delete-expected.png: Added.
* platform/qt/fast/forms/input-text-option-delete-expected.txt:
* platform/qt/fast/forms/input-text-self-emptying-click-expected.png: Added.
* platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/qt/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/qt/fast/forms/input-width-expected.txt:
* platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.png:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/qt/fast/forms/search-rtl-expected.png:
* platform/qt/fast/forms/search-rtl-expected.txt:
* platform/qt/fast/forms/search-styled-expected.png:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.png:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/forms/text-style-color-expected.png: Added.
* platform/qt/fast/forms/text-style-color-expected.txt:
* platform/qt/fast/forms/textfield-focus-ring-expected.png:
* platform/qt/fast/forms/textfield-focus-ring-expected.txt:
* platform/qt/fast/frames/take-focus-from-iframe-expected.png:
* platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
* platform/qt/fast/html/details-no-summary4-expected.png:
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-javascript-expected.png:
* platform/qt/fast/html/details-open-javascript-expected.txt:
* platform/qt/fast/html/details-open2-expected.png:
* platform/qt/fast/html/details-open2-expected.txt:
* platform/qt/fast/html/details-open4-expected.png:
* platform/qt/fast/html/details-open4-expected.txt:
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt:
* platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png:
* platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/qt/fast/layers/self-painting-outline-expected.txt:
* platform/qt/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/qt/fast/lists/dynamic-marker-crash-expected.txt:
* platform/qt/fast/multicol/layers-split-across-columns-expected.png:
* platform/qt/fast/multicol/layers-split-across-columns-expected.txt:
* platform/qt/fast/overflow/004-expected.png: Added.
* platform/qt/fast/overflow/004-expected.txt:
* platform/qt/fast/overflow/line-clamp-expected.png:
* platform/qt/fast/overflow/line-clamp-expected.txt:
* platform/qt/fast/overflow/overflow-focus-ring-expected.png: Added.
* platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
* platform/qt/fast/repaint/iframe-scroll-repaint-expected.png:
* platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
* platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt:
* platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
* platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/qt/fast/repaint/search-field-cancel-expected.png:
* platform/qt/fast/repaint/search-field-cancel-expected.txt:
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt:
* platform/qt/fast/repaint/subtree-root-clip-3-expected.txt:
* platform/qt/fast/repaint/subtree-root-clip-expected.txt:
* platform/qt/fast/repaint/subtree-root-skipped-expected.png:
* platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
* platform/qt/fast/repaint/table-hover-on-link-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/qt/fast/repaint/table-hover-on-link-expected.txt: Added.
* platform/qt/fast/replaced/replaced-breaking-expected.txt:
* platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.png:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/fast/replaced/width100percent-textfield-expected.png:
* platform/qt/fast/replaced/width100percent-textfield-expected.txt:
* platform/qt/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/qt/fast/speech/input-appearance-speechbutton-expected.png: Added.
* platform/qt/fast/speech/input-appearance-speechbutton-expected.txt: Added.
* platform/qt/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/qt/fast/speech/speech-bidi-rendering-expected.txt: Added.
* platform/qt/fast/table/029-expected.png:
* platform/qt/fast/table/029-expected.txt:
* platform/qt/fast/table/colspanMinWidth-expected.png:
* platform/qt/fast/table/colspanMinWidth-expected.txt:
* platform/qt/fast/table/colspanMinWidth-vertical-expected.png:
* platform/qt/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/qt/fast/table/overflowHidden-expected.png:
* platform/qt/fast/table/overflowHidden-expected.txt:
* platform/qt/fast/table/spanOverlapRepaint-expected.png:
* platform/qt/fast/table/spanOverlapRepaint-expected.txt:
* platform/qt/fast/table/text-field-baseline-expected.png:
* platform/qt/fast/table/text-field-baseline-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
* platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/qt/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
* platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/qt/svg/hixie/mixed/003-expected.png:
* platform/qt/svg/hixie/mixed/003-expected.txt:
* platform/qt/tables/mozilla/bugs/45621-expected.png:
* platform/qt/tables/mozilla/bugs/45621-expected.txt:
* platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
* platform/qt/tables/mozilla/bugs/bug154780-expected.png:
* platform/qt/tables/mozilla/bugs/bug154780-expected.txt:
* platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
* platform/qt/tables/mozilla/bugs/bug24200-expected.png:
* platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
* platform/qt/tables/mozilla/bugs/bug55545-expected.png:
* platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
* platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
* platform/qt/tables/mozilla/dom/tableDom-expected.txt:
* platform/qt/tables/mozilla/other/move_row-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[watchlist] Update watchlist rules for EFL-related patches.
rakuco@webkit.org [Wed, 2 May 2012 20:12:39 +0000 (20:12 +0000)]
[watchlist] Update watchlist rules for EFL-related patches.
http://bugs.webkit.org/show_bug.cgi?id=85160

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/config/watchlist: Monitor
Source/WTF/wtf/efl and LayoutTests/platform/efl as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac media engine doesn't reccognize canPlayType('audio/wav; codecs=1')
eric.carlson@apple.com [Wed, 2 May 2012 20:06:19 +0000 (20:06 +0000)]
Mac media engine doesn't reccognize canPlayType('audio/wav; codecs=1')
https://bugs.webkit.org/show_bug.cgi?id=85409

Not reviewed, new platform results added after r115798.

* platform/mac/media/media-can-play-wav-audio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening after r115821.
ossy@webkit.org [Wed, 2 May 2012 20:05:34 +0000 (20:05 +0000)]
[Qt][WK2] Unreviewed gardening after r115821.

* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 20:01:31 +0000 (20:01 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85408

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't allocate stencil buffer if stencil flag is false in context creation attributes
kbr@google.com [Wed, 2 May 2012 19:57:45 +0000 (19:57 +0000)]
Don't allocate stencil buffer if stencil flag is false in context creation attributes
https://bugs.webkit.org/show_bug.cgi?id=85317

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make it appear to WebGL application that there is no stencil
buffer even if the underlying GraphicsContext3D allocated one.
Verified intended behavior with test case from Mozilla's bug report.

Updated context-attributes-alpha-depth-stencil-antialias.html test
from Khronos repository. Ran WebGL layout tests on Linux in
Chrome's DRT and on Mac OS in Safari's.

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::hasStencilBuffer): Added query method.
(WebCore): Changed desired semantics of isValidRenderbuffer.
* html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer): Added hasStencilBuffer.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
    Clear new flag.
(WebCore::WebGLRenderingContext::bindFramebuffer):
    Reset stencil test upon framebuffer change.
(WebCore::WebGLRenderingContext::disable):
    Cache flag; reset stencil test.
(WebCore::WebGLRenderingContext::enable):
    Cache flag; reset stencil test.
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
    Reset stencil test upon renderbuffer change.
(WebCore::WebGLRenderingContext::getContextAttributes):
    Force depth and stencil to false if false was requested.
(WebCore::WebGLRenderingContext::isEnabled):
    Return cached flag.
(WebCore::WebGLRenderingContext::renderbufferStorage):
    Reset stencil test upon renderbuffer reallocation.
(WebCore::WebGLRenderingContext::applyStencilTest):
    Enable or disable stencil test based on request and availability.
(WebCore::WebGLRenderingContext::enableOrDisable):
    Helper function.
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
    Added cache of STENCIL_TEST flag. Deleted unused m_stencilBits.

LayoutTests:

* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDrag and drop text into table is pasting the text in the next <td> element
rniwa@webkit.org [Wed, 2 May 2012 19:50:30 +0000 (19:50 +0000)]
Drag and drop text into table is pasting the text in the next <td> element
https://bugs.webkit.org/show_bug.cgi?id=75004

Reviewed by Darin Adler.

The bug was caused by ReplaceSelectionCommand adjusting the insertion position to be before
of the block element containing the insertion position even when the block element is a table cell.

Fixed the bug by not moving the insertion position before the table cell in this case.

Test: editing/pasteboard/paste-into-table-cell.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=85309
bdakin@apple.com [Wed, 2 May 2012 19:47:20 +0000 (19:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=85309
supportsExpandedScrollbars() should check for the method we actually call rather
than a related method

Reviewed by Anders Carlsson.

Missing colon.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::supportsExpandedScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix GCC X86 build error
commit-queue@webkit.org [Wed, 2 May 2012 19:47:11 +0000 (19:47 +0000)]
Fix GCC X86 build error
https://bugs.webkit.org/show_bug.cgi?id=85379

Patch by Yong Li <yoli@rim.com> on 2012-05-02
Reviewed by Rob Buis.

Always explicitly claim ".text" to make sure
functions defined with inline assembly will be
created in the correct section.

* dfg/DFGOperations.cpp:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaselining after changes in r115846.
zandobersek@gmail.com [Wed, 2 May 2012 19:46:34 +0000 (19:46 +0000)]
Unreviewed, rebaselining after changes in r115846.

* fast/repaint/table-hover-on-link-expected.txt:
* platform/gtk/editing/inserting/before-after-input-element-expected.txt:
* platform/gtk/editing/pasteboard/4806874-expected.txt:
* platform/gtk/editing/pasteboard/input-field-1-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4895428-3-expected.txt:
* platform/gtk/editing/selection/4975120-expected.txt:
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/gtk/editing/spelling/inline_spelling_markers-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/float/033-expected.txt:
* platform/gtk/fast/block/float/avoidance-rtl-expected.txt:
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/gtk/fast/block/float/in-margin-expected.txt:
* platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/clip/008-expected.txt:
* platform/gtk/fast/clip/011-expected.txt:
* platform/gtk/fast/clip/012-expected.txt:
* platform/gtk/fast/clip/017-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/invalidation-errors-2-expected.txt:
* platform/gtk/fast/css/invalidation-errors-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/dom/isindex-001-expected.txt:
* platform/gtk/fast/dom/isindex-002-expected.txt:
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/gtk/fast/events/autoscroll-expected.txt:
* platform/gtk/fast/events/context-no-deselect-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-double-click-expected.txt:
* platform/gtk/fast/forms/input-text-drag-down-expected.txt:
* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/textfield-overflow-expected.txt:
* platform/gtk/fast/forms/validation-message-appearance-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/self-painting-outline-expected.txt:
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
* platform/gtk/fast/overflow/004-expected.txt:
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
* platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
* platform/gtk/fast/repaint/layer-outline-expected.txt:
* platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt:
* platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt:
* platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/gtk/fast/table/003-expected.txt:
* platform/gtk/fast/table/029-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-expected.txt:
* platform/gtk/fast/table/overflowHidden-expected.txt:
* platform/gtk/fast/table/text-field-baseline-expected.txt:
* platform/gtk/fast/text/selection-painted-separately-expected.txt:
* platform/gtk/fast/text/selection-rect-rounding-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/gtk/tables/mozilla/bugs/45621-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 19:41:18 +0000 (19:41 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85404

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 2 May 2012 19:37:09 +0000 (19:37 +0000)]
2012-05-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, expectations updates after r115774.

        * platform/chromium-win/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
        * platform/gtk/test_expectations.txt:
        * platform/qt/Skipped:
        * platform/qt/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115864 268f45cc-cd09-0410-ab3c-d52691b4dbfc