WebKit-https.git
11 years ago2009-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 31 Mar 2009 20:24:49 +0000 (20:24 +0000)]
2009-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6740581> REGRESSION (r41793): Page Down and Page Up don’t work in Leopard Mail

        * WebView/WebHTMLView.mm:
        (-[WebResponderChainSink tryToPerform:with:]): Added. Without this we would think we had
        handled an event when we actually hadn't. Specifically, when -[WebFrameView scrollPageDown:]
        calls tryToPerform on the next responder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>
dimich@chromium.org [Tue, 31 Mar 2009 20:23:12 +0000 (20:23 +0000)]
2009-03-31  Craig Schlenter  <craig.schlenter@gmail.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24550
        Check return value of vasprintf. This should keep gcc 4.3.3
        happy rather than have it complain about attribute warn_unused_result.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 31 Mar 2009 20:11:27 +0000 (20:11 +0000)]
2009-03-31  Dean Jackson  <dino@apple.com>

        Style guide violation!

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 31 Mar 2009 20:05:06 +0000 (20:05 +0000)]
2009-03-31  Dean Jackson  <dino@apple.com>

        Fix Tiger build.

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixing previous commit - forgot to 'git add' new files.
dimich@chromium.org [Tue, 31 Mar 2009 19:56:51 +0000 (19:56 +0000)]
Fixing previous commit - forgot to 'git add' new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Jian Li <jianli@chromium.org>
dimich@chromium.org [Tue, 31 Mar 2009 19:55:26 +0000 (19:55 +0000)]
2009-03-31  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream V8DOMMap for v8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=24951

        * bindings/v8/V8DOMMap.cpp: Added.
        * bindings/v8/V8DOMMap.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 31 Mar 2009 19:50:56 +0000 (19:50 +0000)]
2009-03-31  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24955

        Spacebar didn't play/pause in standalone MediaDocument

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Alpha Lam <hclam@chromium.org>
dimich@chromium.org [Tue, 31 Mar 2009 19:10:03 +0000 (19:10 +0000)]
2009-03-31  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24901
        Added the following methods to MediaPlayerPrivate for Chromium port.
        void sizeChanged();
        void rateChanged();
        void durationChanged();

        The above changes are to reflect changes in MediaPlayer.cpp.
        More details can be found in the original changeset.
        http://trac.webkit.org/changeset/41907

        * platform/graphics/chromium/MediaPlayerPrivateChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 31 Mar 2009 16:54:29 +0000 (16:54 +0000)]
2009-03-31  Darin Adler  <darin@apple.com>

        * Scripts/add-include: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Rafael Weinstein <rafaelw@chromium.org>
darin@chromium.org [Tue, 31 Mar 2009 16:46:32 +0000 (16:46 +0000)]
2009-03-31  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24947

        Special-case drawing text-shadow on win32, to let GDI draw in cases
        when both fill & shadow color are opaque and the shadow has no blur.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleDrawTextShadow):
        (WebCore::windowsCanHandleTextDrawing):
        * platform/graphics/skia/SkiaFontWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
darin@chromium.org [Tue, 31 Mar 2009 16:21:22 +0000 (16:21 +0000)]
2009-03-31  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Fisher.

        r42055 removed some functions in FrameLoader used by Chrome,
        this CL backs out some of those changes to unbreak the Chrome build.

        https://bugs.webkit.org/show_bug.cgi?id=24949

        * WebCore.base.exp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
darin@chromium.org [Tue, 31 Mar 2009 16:13:29 +0000 (16:13 +0000)]
2009-03-31  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        Build fixes for Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=24945

        * dom/Document.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::imageToMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 31 Mar 2009 10:26:46 +0000 (10:26 +0000)]
2009-03-31  Simon Hausmann  <simon.hausmann@nokia.com>

        Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix use of incorrect constant.
mrowe@apple.com [Tue, 31 Mar 2009 07:02:59 +0000 (07:02 +0000)]
Fix use of incorrect constant.

* BuildSlaveSupport/built-product-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a script in support of the new build.webkit.org configuration.
mrowe@apple.com [Tue, 31 Mar 2009 06:29:22 +0000 (06:29 +0000)]
Add a script in support of the new build.webkit.org configuration.

Rubber-stamped by Stephanie Lewis.

* BuildSlaveSupport/built-product-archive: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 31 Mar 2009 03:21:29 +0000 (03:21 +0000)]
2009-03-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3,
        and 1.1.4 versions of WebKitGTK+.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 31 Mar 2009 03:16:33 +0000 (03:16 +0000)]
2009-03-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=17045
        [GTK] Documentation

        Added header documentation for WebKitWebNavigationAction and
        WebKitWebPolicyDecision.

        Added missing documentation pieces for WebKitSoupAuthDialog,
        WebKitDownload and WebKitWebPolicyDecision.

        Wrote a section about using the WEBKIT_DEBUG environment variable.

        * docs/GNUmakefile.am:
        * docs/webkitenvironment.xml: Added.
        * docs/webkitgtk-docs.sgml:
        * webkit/webkitdownload.cpp:
        * webkit/webkitsoupauthdialog.c:
        * webkit/webkitwebnavigationaction.cpp:
        * webkit/webkitwebpolicydecision.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 31 Mar 2009 02:41:46 +0000 (02:41 +0000)]
2009-03-30  Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Integrate gtk-doc into the Gtk+ buildsystem.

        Based on original work by Holger Freyther.

        Integrate gtk-doc into our buildsystem. We are forced to
        use recursive make for gtk-doc itself as the to be installed
        gtk-doc.make (done by gtkdocize) is not working in a non
        recursive environment.

        The documentation can only be generated when srcdir == builddir.
        In all other cases the generated files will not be found. This
        limitation can be found in pango and gtk+ as well. There is no
        easy way around. The resulting html documentation will be saved
        in the srcdir as well.

        * docs/GNUmakefile.am: Added.
        * docs/version.xml.in: Added.
        * docs/webkitgtk-docs.sgml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 31 Mar 2009 02:37:12 +0000 (02:37 +0000)]
Reviewed by Kevin Ollivier.

Add events to allow apps to override handling for JS prompts and
window object cleared events.

https://bugs.webkit.org/show_bug.cgi?id=24948

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Don't create CFDataRef with a fixed size.
sfalken@apple.com [Tue, 31 Mar 2009 02:29:40 +0000 (02:29 +0000)]
    Don't create CFDataRef with a fixed size.
        Fixes synchronous XMLHTTPRequests on Windows.

        Reviewed by Ada Chan.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::WebCoreSynchronousLoader::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Tue, 31 Mar 2009 00:19:02 +0000 (00:19 +0000)]
WebCore:

2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
        https://bugs.webkit.org/show_bug.cgi?id=24594
        rdar://problem/6682110

        Test: fast/loader/reload-policy-delegate.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's
        the policy loader and can use m_policyLoadType rather than letting it get set inside
        checkNavigationPolicy.

LayoutTests:

2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
        https://bugs.webkit.org/show_bug.cgi?id=24594
        rdar://problem/6682110

        * fast/frames/resources/iframe-focus.html: Removed bogus but harmless "layoutTestController.loadCount"
        code.

        * fast/loader/reload-policy-delegate-expected.txt: Added.
        * fast/loader/reload-policy-delegate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 31 Mar 2009 00:17:07 +0000 (00:17 +0000)]
2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Make policy-delegate logging work even for local files by processing the URLs as we
        do for other delegates.

        * DumpRenderTree/mac/PolicyDelegate.mm:
        (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        Use _drt_descriptionSuitableForTestResult on the URL.

        * DumpRenderTree/win/PolicyDelegate.cpp:
        (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
timothy@apple.com [Mon, 30 Mar 2009 22:49:11 +0000 (22:49 +0000)]
    <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
        in Finder (painting without up to date layout)

        Reviewed by Dan Bernstein.

        * page/FrameView.cpp:
        (WebCore::FrameView::paintContents): Add an early return when
        painting is attempted when layout is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 30 Mar 2009 19:59:47 +0000 (19:59 +0000)]
2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Sort alphabetically.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 30 Mar 2009 18:33:40 +0000 (18:33 +0000)]
2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Build fixes for building --3d-rendering and --no-svg

        * rendering/RenderLayerBacking.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 30 Mar 2009 18:27:45 +0000 (18:27 +0000)]
2009-03-30  Steve Falkenburg  <sfalken@apple.com>

        Bump version to 530.

        * win/tools/scripts/VERSION:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 18:21:16 +0000 (18:21 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Documenting what changed since the 1.1.3 release, in
        the GTK+ port.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 30 Mar 2009 18:04:35 +0000 (18:04 +0000)]
2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Build fixes when building --no-svg

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Add missing CSS properties
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
        * dom/Node.cpp:
        (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth): Handle unused param
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData): Handle unused param

2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Build fixes when building --no-svg

        DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h are only available with ENABLE_SVG.

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Mar 2009 17:46:11 +0000 (17:46 +0000)]
2009-03-30  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: bump version to 1.1.4 for release.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 17:41:19 +0000 (17:41 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Add information on the bug-fix-only 1.1.3 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Mon, 30 Mar 2009 17:37:42 +0000 (17:37 +0000)]
    Windows build fix

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::waitForPolicyDelegate): Added this empty stub.

        * DumpRenderTree/win/WorkQueueItemWin.cpp:
        (LoadItem::invoke):
        (ScriptItem::invoke):
        Changed to use data members instead of removed member functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 17:26:16 +0000 (17:26 +0000)]
2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        Bug 24916: REGRESSION: NavigationAction policy dispatch broken
        https://bugs.webkit.org/show_bug.cgi?id=24916

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr
        is not used twice. This also optimizes the case where a frame name is specified,
        but it's the name of the frame being loaded. Also called release in all the final
        uses of FormState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 17:22:35 +0000 (17:22 +0000)]
2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
        https://bugs.webkit.org/show_bug.cgi?id=24937

        Also should fix the Windows COM bindings build.

        * bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.

        * dom/NamedAttrMap.h: Renamed class from NamedAttrMap to
        NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap
        functions all public and non-virtual. Removed virtualLength.

        * dom/NamedNodeMap.h: Replaced file with just an include
        of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap
        files and remove this file.

        * bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
        * dom/Attr.h: Ditto.
        * dom/Attribute.h: Ditto.
        * dom/Document.cpp:
        (WebCore::Document::importNode): Ditto.
        * dom/Element.cpp:
        (WebCore::Element::attributes): Ditto.
        (WebCore::Element::setAttributeMap): Ditto.
        (WebCore::Element::createAttributeMap): Ditto.
        (WebCore::Element::insertedIntoDocument): Ditto.
        (WebCore::Element::removedFromDocument): Ditto.
        (WebCore::Element::openTagStartToString): Ditto.
        (WebCore::Element::removeAttributeNode): Ditto.
        (WebCore::Element::getAttributeNode): Ditto.
        (WebCore::Element::getAttributeNodeNS): Ditto.
        (WebCore::Element::hasAttribute): Ditto.
        (WebCore::Element::hasAttributeNS): Ditto.
        (WebCore::Element::normalizeAttributes): Ditto.
        * dom/Element.h: Ditto.
        * dom/NamedAttrMap.cpp:
        (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto.
        (WebCore::NamedNodeMap::~NamedNodeMap): Ditto.
        (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto.
        (WebCore::NamedNodeMap::getNamedItem): Ditto.
        (WebCore::NamedNodeMap::getNamedItemNS): Ditto.
        (WebCore::NamedNodeMap::removeNamedItem): Ditto.
        (WebCore::NamedNodeMap::removeNamedItemNS): Ditto.
        (WebCore::NamedNodeMap::setNamedItem): Ditto.
        (WebCore::NamedNodeMap::item): Ditto.
        (WebCore::NamedNodeMap::getAttributeItem): Ditto.
        (WebCore::NamedNodeMap::clearAttributes): Ditto.
        (WebCore::NamedNodeMap::detachFromElement): Ditto.
        (WebCore::NamedNodeMap::setAttributes): Ditto.
        (WebCore::NamedNodeMap::addAttribute): Ditto.
        (WebCore::NamedNodeMap::removeAttribute): Ditto.
        (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
        * dom/NamedMappedAttrMap.cpp:
        (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
        * dom/NamedMappedAttrMap.h:
        (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
        * dom/Node.cpp:
        (WebCore::Node::dumpStatistics): Ditto.
        (WebCore::Node::isEqualNode): Ditto.
        (WebCore::Node::isDefaultNamespace): Ditto.
        (WebCore::Node::lookupNamespaceURI): Ditto.
        (WebCore::Node::lookupNamespacePrefix): Ditto.
        (WebCore::Node::compareDocumentPosition): Ditto.
        * dom/Node.h: Ditto.
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto.
        (WebCore::isEmptyFontTag): Ditto.
        (WebCore::areIdenticalElements): Ditto.
        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Ditto.
        (WebCore::completeURLs): Ditto.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Ditto.
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Ditto.
        * svg/SVGAnimatedProperty.h:
        (WebCore::synchronizeProperty): Ditto.
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunLang::evaluate): Ditto.
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 16:35:10 +0000 (16:35 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24750
        [GTK] requests download instead of displaying page

        Use soup facilities to append parameters to the content type, to
        make that more robust;

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore...
ddkilzer@apple.com [Mon, 30 Mar 2009 16:24:19 +0000 (16:24 +0000)]
    <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig

        Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.

        * Configurations/Base.xcconfig: Moved Production definition of
        SECTORDER_FLAGS to here from Xcode project file.
        * Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS
        in Base.xcconfig to the empty string since it is not used for
        Debug and Release configurations.
        * WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fixes after recent FrameLoader changes
aroben@apple.com [Mon, 30 Mar 2009 15:58:58 +0000 (15:58 +0000)]
    Build fixes after recent FrameLoader changes

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle): Updated to match
        urlSelected's current signature. We pass true for the userGesture
        parameter, since the user must have selected this item from the
        context menu.

        * WebCoreSupport/WebFrameLoaderClient.cpp: Removed
        loadURLIntoChildFrame.
        (WebFrameLoaderClient::createFrame): Changed to call
        FrameLoader::loadURLIntoChildFrame. This probably should have been
        done way back around r31281 when that function was added.

        * WebCoreSupport/WebFrameLoaderClient.h: Removed
        loadURLIntoChildFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix after recent Node.idl changes
aroben@apple.com [Mon, 30 Mar 2009 15:58:38 +0000 (15:58 +0000)]
    Windows build fix after recent Node.idl changes

        * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources
        of classes that derive from Node to rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Mar 2009 15:48:30 +0000 (15:48 +0000)]
2009-03-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24878
        [GTK] Use GtkBinding system to handle key events in WebView

        Use GtkBinding system for key events in WebKitWebView. Allows the
        user to reconfigure the bindings and fixes a bunch of bugs along
        the way (we were not checking modifier keys in most actions).

        * webkit/webkitwebview.cpp:
        (webkit_web_view_move_cursor):
        * webkit/webkitwebview.h:
        * webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Mon, 30 Mar 2009 15:22:37 +0000 (15:22 +0000)]
    Windows build fix

        * svg/graphics/SVGImage.cpp: Added a missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Mads Ager <ager@chromium.org>
dglazkov@chromium.org [Mon, 30 Mar 2009 14:49:39 +0000 (14:49 +0000)]
2009-03-30  Mads Ager  <ager@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24879
        Add frame accessor to Screen, Console, and BarInfo objects. Add type
        accessor to BarInfo objects.

        In the V8 JavaScript bindings, we need access to the frame and
        type for already created Screen, Console, and BarInfo objects in
        order to keep their wrappers alive across GCs.

        * page/BarInfo.cpp:
        (WebCore::BarInfo::frame): Added.
        (WebCore::BarInfo::type): Added.
        * page/BarInfo.h:
        * page/Console.cpp:
        (WebCore::Console::frame): Added.
        * page/Console.h:
        * page/Screen.cpp:
        (WebCore::Screen::frame): Added.
        * page/Screen.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDocument that setHtml/setContent loads only the html/data immediately, not external...
hausmann@webkit.org [Mon, 30 Mar 2009 09:25:34 +0000 (09:25 +0000)]
Document that setHtml/setContent loads only the html/data immediately, not external objects.
2009-03-30  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Document that setHtml/setContent loads only the html/data immediately, not external objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 30 Mar 2009 09:13:41 +0000 (09:13 +0000)]
2009-03-30  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk DRT build fix per changeset
        http://trac.webkit.org/changeset/42082. Not reviewed.

        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (LoadItem::invoke):
        (ScriptItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 02:49:37 +0000 (02:49 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Requested by Antti Koivisto.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added
        a better comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 30 Mar 2009 02:21:26 +0000 (02:21 +0000)]
WebCore:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23445: Copying certain hidden text causes a crash
        https://bugs.webkit.org/show_bug.cgi?id=23445
        rdar://problem/6512520

        Test: editing/pasteboard/copy-display-none.html

        * editing/markup.cpp:
        (WebCore::createMarkup): Added a check for the case where adjusting the start node moves
        the start of the selection past the end of the range entirely. If we try to iterate we'll
        never hit the end of the range and will probably crash iterating the rest of the document.

LayoutTests:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23445: Copying certain hidden text causes a crash
        https://bugs.webkit.org/show_bug.cgi?id=23445
        rdar://problem/6512520

        * editing/pasteboard/copy-display-none-expected.txt: Added.
        * editing/pasteboard/copy-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 01:59:29 +0000 (01:59 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
        https://bugs.webkit.org/show_bug.cgi?id=24672
        rdar://problem/6574263

        I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
        but there is an Apple-internal website I was able to use to reproduce and fix.

        * loader/CachedResource.h: Made makePurgeable public.
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable
        so we can get its data if it hasn't yet been purged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 00:06:45 +0000 (00:06 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Fix build again.

        * loader/EmptyClients.h: Fix typo in name of FormState.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 23:53:48 +0000 (23:53 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Try to fix the release build.

        * history/CachedPage.cpp: Make include unconditional, not debug-only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUndo the previous build fix.
bolsinga@apple.com [Sun, 29 Mar 2009 23:51:29 +0000 (23:51 +0000)]
Undo the previous build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build break.
bolsinga@apple.com [Sun, 29 Mar 2009 23:44:18 +0000 (23:44 +0000)]
Fix build break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ChangeLog.
darin@apple.com [Sun, 29 Mar 2009 23:29:46 +0000 (23:29 +0000)]
Fix ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Dmitry Titov <dimich@chromium.org>
darin@apple.com [Sun, 29 Mar 2009 23:29:24 +0000 (23:29 +0000)]
2009-03-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24926
        Fix Chromium build break.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Sun, 29 Mar 2009 23:26:45 +0000 (23:26 +0000)]
2009-03-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24926
        Fix Chromium build break.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 18:09:52 +0000 (18:09 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Another attempt to fix the Qt build.

        * WebCore.pro: Added CheckedRadioButtons.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 18:00:36 +0000 (18:00 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Try to fix Qt build.

        * WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.

        * WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h.
        (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
        Removed unneeded call to detachChildren, which is called by FrameLoader
        right after this.
        (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame
        as other platforms do in the corresponding functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 17:31:51 +0000 (17:31 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        * DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix
        Qt building of DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 29 Mar 2009 17:15:41 +0000 (17:15 +0000)]
WebCore:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 24921: remove include of HTMLFormElement.h from Document.h
        https://bugs.webkit.org/show_bug.cgi?id=24921

        * GNUmakefile.am: Added CheckedRadioButtons source files.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.

        * dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp.
        Removed all the code except for CheckedRadioButtons, and moved that out to be
        a namespace-level class instead of a member of HTMLFormElement.

        * dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h.
        Removed all the code except for CheckedRadioButtons, and moved that out to be
        a namespace-level class instead of a member of HTMLFormElement.

        * dom/Document.h: Removed unneeded includes, including HTMLFormElement.h.
        Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons
        class to use a namespace-level class instead of a member of HTMLFormElement.

        * dom/Node.idl: Changed the type of parentElement from Node to Element for
        two reasons. 1) Node was incorrect, since parentElement returns an Element.
        2) The bindings won't compile any more unless they know parentElement's
        return value is an Element due to include changes.

        * html/HTMLFormElement.cpp: Moved definitions of the functions in the
        CheckedRadioButtons class to the new CheckedRadioButtons.cpp.

        * html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons
        class to the new CheckedRadioButtons.h.

        * html/HTMLInputElement.cpp:
        (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons
        class to use a namespace-level class instead of a member of HTMLFormElement.

        * page/Chrome.cpp:
        (WebCore::Chrome::createWindow): Tweaked formatting.

        * css/CSSGrammar.y: Added newly-needed include.
        * dom/Range.cpp: Ditto.
        * editing/BreakBlockquoteCommand.cpp: Ditto.
        * editing/CompositeEditCommand.cpp: Ditto.
        * editing/InsertLineBreakCommand.cpp: Ditto.
        * editing/ModifySelectionListLevel.cpp: Ditto.
        * editing/RemoveFormatCommand.cpp: Ditto.
        * editing/TextIterator.cpp: Ditto.
        * editing/VisiblePosition.cpp: Ditto.
        * loader/DocLoader.cpp: Ditto.
        * page/AccessibilityRenderObject.cpp: Ditto.
        * page/Page.cpp: Ditto.
        * rendering/RenderBlock.cpp: Ditto.
        * rendering/RenderLayer.cpp: Ditto.
        * rendering/RenderObject.h: Ditto.
        * storage/LocalStorageArea.cpp: Ditto.
        * storage/SessionStorageArea.cpp: Ditto.

WebKit/mac:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        * Plugins/WebNullPluginView.mm: Added now-needed includes.
        * WebView/WebHTMLRepresentation.mm: Ditto.
        * WebView/WebHTMLView.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 17:14:02 +0000 (17:14 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        * fast/forms/targeted-frame-submission.html: Fixes from review comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTools:
darin@apple.com [Sun, 29 Mar 2009 17:11:12 +0000 (17:11 +0000)]
WebKitTools:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
        https://bugs.webkit.org/show_bug.cgi?id=24922

        Don't rely on delegate methods to guess whether a queued step starts a load or not, because
        script-triggered loads can't be detected that way. Instead have the steps themselves indicate
        whether or not a load was triggered.

        * DumpRenderTree/LayoutTestController.cpp:
        (queueLoadingScriptCallback): Added. Version for scripts that perform loads.
        (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads.
        (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and
        queueNonLoadingScript.
        (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now.
        (LayoutTestController::queueForwardNavigation): Ditto.
        (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's
        platform-independent.
        (LayoutTestController::queueNonLoadingScript): Ditto.
        (LayoutTestController::queueReload): Moved here since it's platform-independent now.
        * DumpRenderTree/LayoutTestController.h: Ditto.

        * DumpRenderTree/WorkQueue.cpp:
        (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
        * DumpRenderTree/WorkQueue.h: Ditto.

        * DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item
        started a load. Removed unused getter functions. Made invoke functions private.
        Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (processWork): Use the new WorkQueue::processWork function to implement the new rule.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now
        platform-independent and in LayoutTestController.cpp.
        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (LoadItem::invoke): Return true.
        (ReloadItem::invoke): Ditto.
        (ScriptItem::invoke): Ditto.
        (BackForwardItem::invoke): Ditto.

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement
        the new rule.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now
        platform-independent and in LayoutTestController.cpp.
        * DumpRenderTree/mac/WorkQueueItemMac.mm:
        (LoadItem::invoke): Return true.
        (ReloadItem::invoke): Ditto.
        (ScriptItem::invoke): Ditto.
        (BackForwardItem::invoke): Ditto.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement
        the new rule. Removed queue functions that are now platform-independent and in
        LayoutTestController.cpp.

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement
        the new rule.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now
        platform-independent and in LayoutTestController.cpp.
        * DumpRenderTree/win/WorkQueueItemWin.cpp:
        (LoadItem::invoke): Return false when we fail, true when we succeed.
        (ReloadItem::invoke): Ditto.
        (ScriptItem::invoke): Ditto.
        (BackForwardItem::invoke): Ditto.

LayoutTests:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
        https://bugs.webkit.org/show_bug.cgi?id=24922

        * fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads
        before moving on to the next test, using an onload attribute.

        * http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a
        script that can instead just be run immedidately.

        * http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until
        the subframe loads before moving on to the next test, using an onload attribute.
        * http/tests/navigation/onload-navigation-iframe.html: Ditto.

        * http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of
        queueScript for scripts that don't involve submitting a form. Use queueLoadingScript
        for scripts that do involve submitting a form.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 29 Mar 2009 15:37:49 +0000 (15:37 +0000)]
WebCore:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6015407> attr parsing should allow only identifiers

        Test: fast/css/attr-parsing.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out
        identifiers that start with "-".
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test
        case works. This has the pleasant side effect of fixing a bug too.

LayoutTests:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6015407> attr parsing should allow only identifiers

        * fast/css/attr-parsing-expected.txt: Added.
        * fast/css/attr-parsing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 15:17:35 +0000 (15:17 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
        https://bugs.webkit.org/show_bug.cgi?id=12104

        Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.

        * fast/forms/range-thumb-height-percentage.html: Added.
        * platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
        * platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
        * platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6492712> Cross-origin redirects are not handled correctly.
ap@webkit.org [Sun, 29 Mar 2009 09:45:05 +0000 (09:45 +0000)]
    <rdar://problem/6492712> Cross-origin redirects are not handled correctly.

        Forgot to save the file after applying changes for review comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sun, 29 Mar 2009 09:16:14 +0000 (09:16 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6492712> Cross-origin redirects are not handled correctly.

        Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::ResourceHandle::loadResourceSynchronously):
        (WebCore::WebCoreSynchronousLoader::willSendRequest):
        (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
        (WebCore::WebCoreSynchronousLoader::didReceiveData):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
        (WebCore::WebCoreSynchronousLoader::load):
        Match Mac behavior more closely - we shouldn't rely on underlying library handling of
        synchronous requests.

        * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest):
        -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest
        delegate method for a redirect.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
        Match async behavior more closely.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAlways use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
kevino@webkit.org [Sun, 29 Mar 2009 05:27:39 +0000 (05:27 +0000)]
Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 00:16:17 +0000 (00:16 +0000)]
2009-03-28  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 24914: empty-string assertion crash when running storage tests
        https://bugs.webkit.org/show_bug.cgi?id=24914

        * storage/Database.cpp:
        (WebCore::Database::performOpenAndVerify): Don't store empty version strings
        in the map, since empty strings are per-thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 28 Mar 2009 21:16:00 +0000 (21:16 +0000)]
2009-03-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24790
        [GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function

        Set the right visibility to the WebKitSoupAuthDialog get_type
        function.

        * webkit/webkitsoupauthdialog.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Remove call to now private method.
kevino@webkit.org [Sat, 28 Mar 2009 20:17:32 +0000 (20:17 +0000)]
wx build fix. Remove call to now private method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Sat, 28 Mar 2009 18:43:32 +0000 (18:43 +0000)]
2009-03-28  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24910
        Fixes for Chromium build.

        * bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
        * bindings/v8/custom/V8CustomEventListener.h: ditto.
        * dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 28 Mar 2009 16:59:40 +0000 (16:59 +0000)]
2009-03-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Not reviewed, correcting landing error.

        https://bugs.webkit.org/show_bug.cgi?id=24812
        Custom bindings should be in v8/custom, not v8.

        * bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Sat, 28 Mar 2009 16:48:17 +0000 (16:48 +0000)]
2009-03-28  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24616
        Add V8 custom bindings for DOMWindow.

        * bindings/v8/custom/V8DOMWindowCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Sat, 28 Mar 2009 16:24:00 +0000 (16:24 +0000)]
2009-03-28  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24812
        Add V8 custom bindings for HTMLDocument.

        * bindings/v8/V8HTMLDocumentCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 28 Mar 2009 08:55:09 +0000 (08:55 +0000)]
2009-03-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        FrameLoader::loadURL and FrameLoader::detachChildren went private
        per changes in http://trac.webkit.org/changeset/42055. Follow
        Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
        loadURL and FrameLoader::detachParent for detachChildrem.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame):
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix non-AllInOneFile builds.
oliver@apple.com [Sat, 28 Mar 2009 05:11:55 +0000 (05:11 +0000)]
Fix non-AllInOneFile builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate text-content-type-with-binary-extension.html to use a .sitx file of random...
mrowe@apple.com [Sat, 28 Mar 2009 04:04:36 +0000 (04:04 +0000)]
Update text-content-type-with-binary-extension.html to use a .sitx file of random data rather
than a .m4a to ensure that WebKit doesn't handle the resource as a full-frame media element if the network
layer sniffs it as audio/mp4 rather than application/octet-stream.

Rubber-stamped by Dan Bernstein.

* http/tests/loading/resources/.htaccess:
* http/tests/loading/resources/binaryData.m4a: Removed.
* http/tests/loading/resources/binaryData.sitx: Added.
* http/tests/loading/text-content-type-with-binary-extension.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix syntax of Skipped file.
mrowe@apple.com [Sat, 28 Mar 2009 04:04:20 +0000 (04:04 +0000)]
Fix syntax of Skipped file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of Function.prototype.call
oliver@apple.com [Sat, 28 Mar 2009 03:50:39 +0000 (03:50 +0000)]
Improve performance of Function.prototype.call
<https://bugs.webkit.org/show_bug.cgi?id=24907>

Reviewed by Gavin Barraclough

Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.

When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip two plug-in tests that are failing due to <rdar://problem/6733642>.
mrowe@apple.com [Sat, 28 Mar 2009 02:54:59 +0000 (02:54 +0000)]
Skip two plug-in tests that are failing due to <rdar://problem/6733642>.

Rubber-stamped by Oliver Hunt.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand updated results for two SVG tests involving Geeza Pro.
mrowe@apple.com [Sat, 28 Mar 2009 02:46:39 +0000 (02:46 +0000)]
Land updated results for two SVG tests involving Geeza Pro.

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum.
* platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
* platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
* platform/mac-leopard/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.checksum.
* platform/mac-leopard/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
* platform/mac-leopard/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix two SVG test failures in 64-bit.
mrowe@apple.com [Sat, 28 Mar 2009 02:40:34 +0000 (02:40 +0000)]
Fix two SVG test failures in 64-bit.

Reviewed by Sam Weinig.

getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings.  In 32-bit this was
identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.

The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
but requires an exception be thrown when a negative value is passed.  This results in the JS bindings handling the
check for a negative value and lets the implementation treat the arguments purely as unsigned values.

* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getNumberOfChars):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getExtentOfChar):
(WebCore::SVGTextContentElement::getRotationOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
(WebCore::SVGTextContentElement::selectSubString):
* svg/SVGTextContentElement.h:
* svg/SVGTextContentElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 28 Mar 2009 00:49:21 +0000 (00:49 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Get mailto code out of FrameLoader.

        * html/HTMLFormElement.cpp:
        (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto
        logic so HTMLFormElement::submit isn't full of ugly bits. This includes the
        part of the logic that involves transformeing the URL that was previously
        inside FrameLoader.
        (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and
        also release the data for slightly less refcount churn.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto,
        since HTMLFormElement now properly prepares both the URL and the form data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
mitz@apple.com [Sat, 28 Mar 2009 00:41:32 +0000 (00:41 +0000)]
    Reviewed by Mark Rowe.

        - fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup

        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
        (WebCore::createFontCustomPlatformData): Ditto.
        * platform/graphics/opentype/OpenTypeUtilities.cpp:
        (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to
        the size of an EOTPrefix.
        (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in
        the prefix.
        (WebCore::EOTHeader::appendBigEndianString): Changed the static
        appendBigEndianStringToEOTHeader() into this member function.
        (WebCore::EOTHeader::appendPaddingShort): Added.
        (WebCore::getEOTHeader): Changed to use EOTHeader.
        * platform/graphics/opentype/OpenTypeUtilities.h:
        (WebCore::EOTHeader::size):
        (WebCore::EOTHeader::data):
        (WebCore::EOTHeader::prefix):
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream): Changed to use EOTHeader.
        (WebCore::createFontCustomPlatformData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 28 Mar 2009 00:06:57 +0000 (00:06 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 28 Mar 2009 00:06:38 +0000 (00:06 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        * Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 23:55:17 +0000 (23:55 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Made our mailto form submission tests work more reliably by using the new
        layoutTestController.waitForPolicyDelegate function.

        * fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate
        rather than relying on the form submission happening immediately.
        * fast/forms/mailto/advanced-get.html: Ditto.
        * fast/forms/mailto/advanced-put.html: Ditto.
        * fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
        * fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
        * fast/forms/mailto/get-multiple-items.html: Ditto.
        * fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
        * fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
        * fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
        * fast/forms/mailto/get-non-ascii.html: Ditto.
        * fast/forms/mailto/get-overwrite-query.html: Ditto.
        * fast/forms/mailto/post-append-query.html: Ditto.
        * fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
        * fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
        * fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
        * fast/forms/mailto/post-multiple-items.html: Ditto.
        * fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
        * fast/forms/mailto/post-text-plain.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 23:55:04 +0000 (23:55 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
        tests work.

        * DumpRenderTree/AccessibilityController.cpp:
        (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's
        no reason to use reinterpret_cast just to get from void* to a specific type.
        (getRootElementCallback): Ditto.
        * DumpRenderTree/AccessibilityUIElement.cpp:
        (toAXElement): Ditto.
        * DumpRenderTree/GCController.cpp:
        (collectCallback): Ditto.
        (collectOnAlternateThreadCallback): Ditto.
        (getJSObjectCountCallback): Ditto.
        * DumpRenderTree/LayoutTestController.cpp:
        (many functions):  Ditto.
        (waitForPolicyDelegateCallback): Added.
        (LayoutTestController::staticFunctions): Sorted functions by name.
        Added waitForPolicyDelegate.

        * DumpRenderTree/LayoutTestController.h: Sorted functions by name.
        Added waitForPolicyDelegate.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
        policy delegate.
        (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just
        before loading an empty page. This prevents extra policy delegate calls from being logged.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then
        tells the policy delegate to notify when done, then points the web view at the policy delegate.

        * DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.

        * DumpRenderTree/mac/PolicyDelegate.mm:
        (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        Added code to do notifyDone if controllerToNotifyDone is set.
        (-[PolicyDelegate setControllerToNotifyDone:]): Added.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
        policy delegate. Also moved the call to resetUndoManager in here.
        (runTest): Removed the call to resetUndoManager (see above). Added an additional call to
        resetWebViewToConsistentStateBeforeTesting to match the Mac code.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.

        * DumpRenderTree/win/PolicyDelegate.cpp:
        (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0.
        (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if
        m_controllerToNotifyDone is set.

        * DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and
        m_controllerToNotifyDone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 23:37:46 +0000 (23:37 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        To prepare for work on a form loading fix, remove some unused functions,
        consolidate some functions, and make many more functions private in
        FrameLoader.

        * WebCore.base.exp: Remove some unused entry points, update another.

        * dom/Document.cpp:
        (WebCore::Document::detach): Clear m_frame directly instead of using
        clearFramePointer.
        * dom/Document.h: Ditto.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected): Consolidate the two functions
        of this name into a single function. Also changed the event argument
        to be PassRefPtr<Event>.
        (WebCore::FrameLoader::submitForm): Changed the event argument to
        be PassRefPtr<Event>.
        (WebCore::FrameLoader::scheduleLocationChange): Call completeURL
        explicitly so we can remove the version of changeLocation that does
        completeURL for us.
        (WebCore::FrameLoader::redirectionTimerFired): Ditto.
        (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem
        directly so we don't need a setProvisionalHistoryItem function.
        (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at
        m_quickRedirectComing directly so we don't need a isQuickRedirectComing
        function.
        (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto.
        (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the
        event argument to be PassRefPtr<Event>.
        (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData
        function here because this is the only caller. If we want to make the
        resulting function smaller we should refactor some other way. Also
        streamlined the user-chosen encoding logic, but did not change what it does.
        (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument
        to be PassRefPtr<Event>.
        (WebCore::FrameLoader::loadPostRequest): Ditto.
        (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from
        the didNotOpenURL function here, since this was the only caller.

        * loader/FrameLoader.h: Removed include of FormState.h and used a forward
        declaration instead. Removed unneeded forward declation of Element.
        Moved many functions into the private section, and removed some other
        unused or uneeded functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Xiaomei Ji <xji@chromium.org>
darin@chromium.org [Fri, 27 Mar 2009 23:23:09 +0000 (23:23 +0000)]
2009-03-27  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24303
        Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.

        Test: editing/selection/extend-selection.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::directionOfEnclosingBlock): Added
        (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly
        implemented for character and word granularity, all other granularities
        are treated as "forward".
        (WebCore::SelectionController::modifyExtendingForward): Renamed
        modifyExtendingRightForward() to this.
        (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly
        implemented for character and word granularity, all other granularities
        are treated as "backward".
        (WebCore::SelectionController::modifyExtendingBackward): Renamed
        modifyExtendingLeftBackward() to this.
        (WebCore::SelectionController::modify): Change to call either the
        left/right or backward/forward methods depending on the 'dir' argument
        for extends.
        * editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 27 Mar 2009 23:15:01 +0000 (23:15 +0000)]
2009-03-27  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
        prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6

        * Scripts/prepare-ChangeLog:
        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 John Abd-El-Malek <jam@google.com>
dimich@chromium.org [Fri, 27 Mar 2009 22:34:10 +0000 (22:34 +0000)]
2009-03-27  John Abd-El-Malek  <jam@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24836
        Fix navigator.plugins.refresh(false) in Chromium.

        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::PluginData::refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
timothy@apple.com [Fri, 27 Mar 2009 22:31:19 +0000 (22:31 +0000)]
    Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
        virtual to fix the broken layout tests from my last commit.

        Reviewed by Mark Rowe.

        * dom/Element.cpp:
        (WebCore::Element::scrollLeft):
        (WebCore::Element::scrollTop):
        (WebCore::Element::scrollWidth):
        (WebCore::Element::scrollHeight):
        * dom/Element.h:
        * html/HTMLBodyElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
mrowe@apple.com [Fri, 27 Mar 2009 21:34:03 +0000 (21:34 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2)

Reviewed by Sam Weinig.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
items after each node is removed, leading to O(N^2) behaviour.  By inlining the batch removal in to setLength we can avoid
this gratuitous recalcuation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 27 Mar 2009 20:45:35 +0000 (20:45 +0000)]
2009-03-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        We don't support images for GtkCursors yet. We need a  placeholder to avoid crashes.
        I took crosshair to have a common behavior with firefox.

        [GTK] SVG - Crash on setting the cursor icon
        https://bugs.webkit.org/show_bug.cgi?id=24565

        * platform/gtk/CursorGtk.cpp:
        (WebCore::Cursor::Cursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove redundant attributes and functions from IDL files that have the
timothy@apple.com [Fri, 27 Mar 2009 20:36:21 +0000 (20:36 +0000)]
    Remove redundant attributes and functions from IDL files that have the
        same attributes and functions defined in the super class.

        Reviewed by Simon Fraser.

        * WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
        * bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
        * html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth
        and scrollHeight.
        * html/HTMLElement.idl: Remove blur and focus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Mac DumpRenderTree build.
timothy@apple.com [Fri, 27 Mar 2009 18:44:23 +0000 (18:44 +0000)]
Fix the Mac DumpRenderTree build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't include substitute data URLs in global history redirect chains
aroben@apple.com [Fri, 27 Mar 2009 18:37:16 +0000 (18:37 +0000)]
Don't include substitute data URLs in global history redirect chains

WebCore:

        Don't include substitute data URLs in global history redirect chains

        <rdar://6690169>

        Reviewed by Darin Adler.

        This might be testable if:
          - support were added to DRT for providing substitute data on failed
            loads
          - support were added to DRT for dumping redirect chains

        I tried doing the above and was still unable to make a test.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForStandardLoad):
        (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
        Call updateGlobalHistoryRedirectLinks only if the load succeeded
        (i.e., there is no unreachableURL). Previous the FrameLoaderClient
        implementations were unconditionally calling
        updateGlobalHistoryRedirectLinks from within updateGlobalHistory.

WebKit/mac:

        Don't include substitute data URLs in global history redirect chains

        <rdar://6690169>

        Reviewed by Darin Adler.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory): Don't call
        updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now.
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
        Added an assertion to help catch cases where we might be adding a
        substitute data URL into a redirect chain.

WebKit/win:

        Don't include substitute data URLs in global history redirect chains

        <rdar://6690169>

        Reviewed by Darin Adler.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::updateGlobalHistory): Don't call
        updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now.
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
        Added an assertion to help catch cases where we might be adding a
        substitute data URL into a redirect chain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 18:27:16 +0000 (18:27 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6541923> REGRESSION (r38629): Tab cycle in empty tab is broken

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 27 Mar 2009 18:07:41 +0000 (18:07 +0000)]
2009-03-27  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24861
        Chromium port did not render decorations for <input type="search">.
        This copies RenderThemeWin.*.

        * css/themeChromiumWin.css: Removed.
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
        (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton):
        (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle):
        (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
        * rendering/RenderThemeChromiumLinux.h:
        (WebCore::RenderThemeChromiumLinux::paintSearchField):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::):
        (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet):
        (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton):
        (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle):
        (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
        * rendering/RenderThemeChromiumWin.h:
        (WebCore::RenderThemeChromiumWin::paintSearchField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 27 Mar 2009 18:02:18 +0000 (18:02 +0000)]
WebCore:

2009-03-27  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser

        If an object has a self-painting layer, don't count it as part of a block's visual overflow.
        This fix has only been made for block-level children.   The inline-level case is still broken
        (and covered by an existing bug).

        Added fast/block/positioning/negative-rel-position.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):

LayoutTests:

2009-03-27  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser

        Test case for relative positioning bug.

        * fast/block/positioning/negative-rel-position.html: Added.
        * platform/mac/fast/block/positioning/negative-rel-position-expected.checksum: Added.
        * platform/mac/fast/block/positioning/negative-rel-position-expected.png: Added.
        * platform/mac/fast/block/positioning/negative-rel-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Mar 2009 18:00:50 +0000 (18:00 +0000)]
2009-03-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6642221>
        REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed

        Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.

        I've filed <rdar://problem/6731022> against the Movies widget.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 27 Mar 2009 17:53:27 +0000 (17:53 +0000)]
2009-03-27  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan and Anders Carlsson.

        <rdar://problem/5987442> Pasteboard not exposed to WebEditingDelegate for WebViewInsertActionPasted (needed for system services)

        Added SPI to tell which pasteboard is currently being inserted.
        I chose to put it on WebView to be forward-looking since we're migrating things
        from WebHTMLView to WebView in the future.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Add calls to _setInsertionPasteboard.
        (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]): Assert the pasteboard is nil.
        (-[WebViewPrivate finalize]): Ditto.
        (-[WebView _insertionPasteboard]): Return the pastebaord.
        (-[WebView _setInsertionPasteboard:]): Set the pasteboard.
        * WebView/WebViewInternal.h: Added _setInsertionPasteboard.
        * WebView/WebViewPrivate.h: Added _insertionPasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExpose new DOM methods as public Objective-C API.
timothy@apple.com [Fri, 27 Mar 2009 17:50:15 +0000 (17:50 +0000)]
Expose new DOM methods as public Objective-C API.

WebCore:

2009-03-25  Timothy Hatcher  <timothy@apple.com>

        Expose new DOM methods as public Objective-C API.

        <rdar://problem/5837350> Expose new DOM classes and methods
        as public API (match the additions to the JavaScript DOM)

        Reviewed by NOBODY (OOPS!).

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/PublicDOMInterfaces.h:

WebKit/mac:

2009-03-25  Timothy Hatcher  <timothy@apple.com>

        Expose new DOM methods as public Objective-C API.

        <rdar://problem/5837350> Expose new DOM classes and methods
        as public API (match the additions to the JavaScript DOM)

        Reviewed by NOBODY (OOPS!).

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42040 268f45cc-cd09-0410-ab3c-d52691b4dbfc