WebKit-https.git
6 years ago[iOS] Upstream disk image cache
dbates@webkit.org [Fri, 4 Oct 2013 22:41:11 +0000 (22:41 +0000)]
[iOS] Upstream disk image cache
https://bugs.webkit.org/show_bug.cgi?id=121985

Reviewed by Joseph Pecoraro.

Source/WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::isUsingDiskImageCache):
* loader/ResourceBuffer.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::canUseDiskImageCache): Added.
(WebCore::CachedImage::useDiskImageCache): Added.
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::isSafeToMakePurgeable):
(WebCore::CachedResource::isUsingDiskImageCache): Added.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::canUseDiskImageCache): Added.
(WebCore::CachedResource::useDiskImageCache): Added.
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::flushCachedImagesToDisk): Added.
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
* loader/ios/DiskImageCacheClientIOS.h: Added.
* loader/ios/DiskImageCacheIOS.h: Added.
* loader/ios/DiskImageCacheIOS.mm: Added.
* platform/Logging.h:
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::~SharedBuffer):
(WebCore::SharedBuffer::isAllowedToBeMemoryMapped): Added.
(WebCore::SharedBuffer::allowToBeMemoryMapped): Added.
(WebCore::SharedBuffer::failedMemoryMap): Added.
(WebCore::SharedBuffer::markAsMemoryMapped): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallbackData): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::setMemoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::buffer):
(WebCore::SharedBuffer::getSomeData):
* platform/SharedBuffer.h:
(WebCore::SharedBuffer::isMemoryMapped): Added.
* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:
* ios/WebCoreSupport/WebDiskImageCacheClientIOS.h: Added.
* ios/WebCoreSupport/WebDiskImageCacheClientIOS.mm: Added.

Source/WebKit/mac:

* Misc/WebCache.mm:
(+[WebCache statistics]):
* WebView/WebDataSource.mm:
(BufferMemoryMapped): Added.
(-[WebDataSource _setAllowToBeMemoryMapped]): Added.
(-[WebDataSource setDataSourceDelegate:]): Added.
(-[WebDataSource dataSourceDelegate]): Added.
(-[WebDataSource dealloc]):
* WebView/WebDataSourcePrivate.h: Declared private delegate
protocol, WebDataSourcePrivateDelegate.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences diskImageCacheEnabled]): Added.
(-[WebPreferences setDiskImageCacheEnabled:]): Added.
(-[WebPreferences diskImageCacheMinimumImageSize]): Added.
(-[WebPreferences setDiskImageCacheMinimumImageSize:]): Added.
(-[WebPreferences diskImageCacheMaximumCacheSize]): Added.
(-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Added.
(-[WebPreferences _diskImageCacheSavedCacheDirectory]): Added.
(-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Added.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate svn-config for new Visual Studio extensions
ap@apple.com [Fri, 4 Oct 2013 22:25:25 +0000 (22:25 +0000)]
Update svn-config for new Visual Studio extensions
https://bugs.webkit.org/show_bug.cgi?id=122344

Reviewed by Brent Fulgham.

* svn-config: Add new Visual Studio extensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Basic shapes should be animatable for shape-outside
betravis@adobe.com [Fri, 4 Oct 2013 22:25:20 +0000 (22:25 +0000)]
[CSS Shapes] Basic shapes should be animatable for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=122343

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/shapes/shape-outside-floats/shape-outside-animation.html

Add shape outside to the list of animatable properties. The infrastructure
is already in place for animating basic shapes on shape-inside and clipping
paths. See https://bugs.webkit.org/show_bug.cgi?id=101854.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

LayoutTests:

Add tests checking that shape-outside basic shape values correctly tween
between values.

* animations/resources/animation-test-helpers.js:
(getPropertyValue): Add shape-outside to list of properties that do not parse
with the default behavior.
(comparePropertyValue): Compare shape-outsides after parsing their shape notation.
* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-animation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTighten typing in some RenderLayer code.
akling@apple.com [Fri, 4 Oct 2013 22:22:00 +0000 (22:22 +0000)]
Tighten typing in some RenderLayer code.
<https://webkit.org/b/122342>

Reviewed by Antti Koivisto.

Use tighter types instead of Node and RenderObject inside RenderLayer
where applicable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
rego@igalia.com [Fri, 4 Oct 2013 21:59:32 +0000 (21:59 +0000)]
[CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
https://bugs.webkit.org/show_bug.cgi?id=122327

Reviewed by Alexandru Chiculita.

Add versions for other writing modes (horizontal-bt, vertical-lr and
vertical-rl) for test
fast/regions/selection/selecting-text-in-2-regions.html.

* fast/regions/resources/helper.js:
(selectContentByIdsVert): Add new method when selecting context in a
vertical writing mode.
* fast/regions/resources/region-style.css: Add some new CSS classes for
vertical writing mode.
* fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html:
Added.
* fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html:
Added.
* fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
Added.
* fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
Added.
* fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
Added.
* fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
oliver@apple.com [Fri, 4 Oct 2013 21:52:29 +0000 (21:52 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInserting a JS generated keyframe animation shouldn't trigger a whole document style...
commit-queue@webkit.org [Fri, 4 Oct 2013 20:46:57 +0000 (20:46 +0000)]
Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc
https://bugs.webkit.org/show_bug.cgi?id=119479

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-04
Reviewed by Antti Koivisto.

Change CSSStyleSheet::didMutateRules to not invalidate all node's styles when inserting a
@-webkit-keyframes rule, and to instead insert the rule directly into the StyleResolver.

Test: animation/keyframes-dynamic.html: adds and removes keyframe rules using JavaScript and
validates that the correct elements are animated.

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):
* css/CSSStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMade WinLauncher have better error handling, crash reporting, and modifiability.
commit-queue@webkit.org [Fri, 4 Oct 2013 20:37:53 +0000 (20:37 +0000)]
Made WinLauncher have better error handling, crash reporting, and modifiability.
https://bugs.webkit.org/show_bug.cgi?id=122319

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-04
Reviewed by Brent Fulgham.

* WinLauncher/WinLauncher.cpp:
(WinLauncherWebHost::didFailProvisionalLoadWithError):
Don't display the numerous "Cancelled" messages that are obviously from the user.
(createCrashReport): Added.
(dllLauncherEntryPoint):
Made main loop back into while loop and write a crash report if it crashes.
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
Added WinLauncherReplace.h.
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
Added linking to DbgHelp.lib.
* WinLauncher/WinLauncherReplace.h:
Added to make modifying WinLauncher behaviour and appearance easy.
(processCrashDump): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport for-of syntax
oliver@apple.com [Fri, 4 Oct 2013 20:35:24 +0000 (20:35 +0000)]
Support for-of syntax
https://bugs.webkit.org/show_bug.cgi?id=122339

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add support for for-of syntax to JSC.  As part of doing this I had to make
us support unique empty strings as identifiers.  In a follow on patch i'm
going to remove the distinction entirely as it's purely a complicating
separation.

Otherwise the logic here is fairly self-explanatory.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitCall):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):
* jit/JITOperations.cpp:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createForOfLoop):
* parser/NodeConstructors.h:
(JSC::EnumerationNode::EnumerationNode):
(JSC::ForInNode::ForInNode):
(JSC::ForOfNode::ForOfNode):
* parser/Nodes.h:
* parser/Parser.cpp:
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
* parser/Parser.h:
(JSC::Parser::isofToken):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForOfLoop):
* runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorPrototypeIterate):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::finishCreation):
* runtime/ArrayPrototype.h:
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
* runtime/CommonIdentifiers.h:
* runtime/Identifier.h:
(JSC::Identifier::from):
* runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpInContext):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunction):
* runtime/PrivateName.h:
(JSC::PrivateName::PrivateName):
* runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):

Source/WTF:

Update assertions and add a helper function to StringImpl
to save repeated unique or identifier calls.

* wtf/text/StringImpl.h:
(WTF::StringImpl::isIdentifierOrUnique):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::setIsAtomic):

LayoutTests:

Add test cases for the one type that supports for-of so far

* js/basic-for-of-expected.txt: Added.
* js/basic-for-of.html: Added.
* js/regress/for-of-iterate-array-entries.html: Added.
* js/regress/for-of-iterate-array-keys.html: Added.
* js/regress/for-of-iterate-array-values.html: Added.
* js/regress/script-tests/for-of-iterate-array-entries.js: Added.
(foo):
* js/regress/script-tests/for-of-iterate-array-keys.js: Added.
(foo):
* js/regress/script-tests/for-of-iterate-array-values.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNot...
zandobersek@gmail.com [Fri, 4 Oct 2013 20:33:41 +0000 (20:33 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122275

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/fileapi/.

* fileapi/Blob.idl:
* fileapi/FileException.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDele...
zandobersek@gmail.com [Fri, 4 Oct 2013 20:31:17 +0000 (20:31 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/dom/.

* dom/CharacterData.idl:
* dom/ChildNode.idl:
* dom/ClientRectList.idl:
* dom/Clipboard.idl:
* dom/CompositionEvent.idl:
* dom/CustomEvent.idl:
* dom/DOMCoreException.idl:
* dom/DOMImplementation.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringList.idl:
* dom/DOMStringMap.idl:
* dom/DataTransferItem.idl:
* dom/DataTransferItemList.idl:
* dom/DeviceMotionEvent.idl:
* dom/DeviceOrientationEvent.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Event.idl:
* dom/EventException.idl:
* dom/EventListener.idl:
* dom/EventTarget.idl:
* dom/KeyboardEvent.idl:
* dom/MessageEvent.idl:
* dom/MessagePort.idl:
* dom/MouseEvent.idl:
* dom/MutationEvent.idl:
* dom/MutationObserver.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeIterator.idl:
* dom/NodeList.idl:
* dom/Range.idl:
* dom/RangeException.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* dom/TextEvent.idl:
* dom/TouchEvent.idl:
* dom/TouchList.idl:
* dom/TreeWalker.idl:
* dom/UIEvent.idl:
* dom/WebKitNamedFlow.idl:
* dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDele...
zandobersek@gmail.com [Fri, 4 Oct 2013 20:22:34 +0000 (20:22 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122269

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/xml/.

* xml/DOMParser.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestUpload.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathException.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[]
msaboff@apple.com [Fri, 4 Oct 2013 19:36:12 +0000 (19:36 +0000)]
FTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[]
https://bugs.webkit.org/show_bug.cgi?id=122336

Reviewed by Geoffrey Garen.

Changed code in change set r156900 to use the operand() accessor instead of operator[].

* ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Shape Outside should relayout when set dynamically
betravis@adobe.com [Fri, 4 Oct 2013 19:31:01 +0000 (19:31 +0000)]
[CSS Shapes] Shape Outside should relayout when set dynamically
https://bugs.webkit.org/show_bug.cgi?id=122197

Reviewed by Alexandru Chiculita.

Source/WebCore:

Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html
       fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html

When shape outside is modified, dependent content needs to relayout. This patch
removes the float from the float lists and marks dependents for layout using
RenderBox::removeFloatingOrPositionedChildFromBlockLists(). This is the same
method used when switching from float: left to float: right and vice versa
(see RenderElement::styleWillChange).

* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Mark shape-outside dependents
for layout.
* rendering/RenderBox.h:
(WebCore::RenderBox::markShapeOutsideDependentsForLayout): Mark all the items that may be
affected by this shape-outside for relayout.

LayoutTests:

Test that a shape can be dynamically added, modified, or removed and that
content does a proper relayout.

* fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTighten markContainingBlocksForLayout
antti@apple.com [Fri, 4 Oct 2013 19:22:38 +0000 (19:22 +0000)]
Tighten markContainingBlocksForLayout
https://bugs.webkit.org/show_bug.cgi?id=122326

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNode: removedFrom() and insertedInto() should use references.
akling@apple.com [Fri, 4 Oct 2013 18:51:32 +0000 (18:51 +0000)]
Node: removedFrom() and insertedInto() should use references.
<https://webkit.org/b/122315>

Reviewed by Anders Carlsson.

ContainerNode* -> ContainerNode&

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize strings copies in srcset parser
ap@apple.com [Fri, 4 Oct 2013 18:41:09 +0000 (18:41 +0000)]
Optimize strings copies in srcset parser
https://bugs.webkit.org/show_bug.cgi?id=121899

Patch by Romain Perier <romain.perier@gmail.com> on 2013-10-04
Reviewed by Alexey Proskuryakov.

No new tests, covered by existing ones.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute): Don't copy
image.imageURL at each loop iteration, save indexes instead.
(WebCore::bestFitSourceForImageAttributes): Make a String for
the URL only when the corresponding candidate is chosen
by the selection algorithm. It reduces the number of copies
significantly and improves performance
(around 30% with the "Release" profile and 60% with the "Debug" one).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTests added in r141354 erroneously assume correction suggestion to be in the context...
g.czajkowski@samsung.com [Fri, 4 Oct 2013 18:40:03 +0000 (18:40 +0000)]
Tests added in r141354 erroneously assume correction suggestion to be in the context menu
https://bugs.webkit.org/show_bug.cgi?id=113742

Reviewed by Ryosuke Niwa.

Tests from r141354 erroneously assume that all WebKit ports populate
spell checking suggestion in the context menu.

Remove verification of spell checking suggestion and all context menu stuff from tests
that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
for example, after deleting a text, double click or selecting a misspellings.

However, two tests are adapted to verify spell checking suggestions (their availability
rather than correctness, similarly to context-menu-suggestions.html).
Those are useful for ports which populate spelling suggestion in the context menu.

* editing/spelling/resources/util.js:
(initSpellTest):
Do not assume that the tests are running with "Windows" editing behavior.
Unix ports do not make a selection for the misspelled word and they don't
require selection to get spell checking suggestions.

* editing/spelling/spelling-changed-text-expected.txt:
* editing/spelling/spelling-changed-text.html:
* editing/spelling/spelling-double-clicked-word-expected.txt:
* editing/spelling/spelling-double-clicked-word.html:
* editing/spelling/spelling-exactly-selected-word-expected.txt:
* editing/spelling/spelling-exactly-selected-word.html:
Remove verification of correction suggestion.
Instead of that check whether the spelling markers behave correctly.

* editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
* editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
* editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
* editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.
Adapt those tests for platforms which populate spell check suggestion
in the context menu.

* platform/efl-wk2/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for EFL.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
Update tests path due to rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array...
msaboff@apple.com [Fri, 4 Oct 2013 18:38:16 +0000 (18:38 +0000)]
FTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array index
https://bugs.webkit.org/show_bug.cgi?id=122332

Reviewed by Oliver Hunt.

Changed the uses of .offset(), which returns a negative number for locals, to be
toLocal() which returns a local's ordinal number.

* ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoremove dpranke from webkitpy watchlist
dpranke@chromium.org [Fri, 4 Oct 2013 18:34:11 +0000 (18:34 +0000)]
remove dpranke from webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=122331

Reviewed by Brent Fulgham.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail...
timothy_horton@apple.com [Fri, 4 Oct 2013 18:30:35 +0000 (18:30 +0000)]
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299

Reviewed by Beth Dakin.

* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
* TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWatchlist is broken after <http://trac.webkit.org/r156880>
ap@apple.com [Fri, 4 Oct 2013 18:26:35 +0000 (18:26 +0000)]
Watchlist is broken after <trac.webkit.org/r156880>

* Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd callOperation to Baseline JIT
msaboff@apple.com [Fri, 4 Oct 2013 18:20:40 +0000 (18:20 +0000)]
Add callOperation to Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122306

Reviewed by Geoffrey Garen.

Created baseline JIT compatible versions for a few flavors of callOperation().
Migrated cti_op_new_regexp() and its caller to callOperation(operationNewRegexp()).

* dfg/DFGOperations.cpp: Moved operationNewRegexp() to JITOperations
* dfg/DFGOperations.h:
* jit/JIT.h:
(JSC::JIT::appendCall):
* jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheck):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::callOperation):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_regexp):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* jit/JSInterfaceJIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt features from build and test tools
bfulgham@apple.com [Fri, 4 Oct 2013 18:20:19 +0000 (18:20 +0000)]
Remove Qt features from build and test tools
https://bugs.webkit.org/show_bug.cgi?id=122312

Reviewed by Anders Carlsson.

* Scripts/build-dumprendertree:
* Scripts/build-jsc:
* Scripts/build-webkit:
* Scripts/build-webkittestrunner:
* Scripts/old-run-webkit-tests:
(openDumpTool):
(buildPlatformResultHierarchy):
(buildPlatformTestHierarchy):
(readSkippedFiles):
* Scripts/run-launcher:
* Scripts/run-qtwebkit-tests: Removed.
* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
* Scripts/update-webkit:
* Scripts/webkit-build-directory:
* Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(setupCygwinEnv):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):
* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_virtual_ports_filtered):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_reviewer_text):
* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
* Scripts/webkitpy/port/base.py:
(Port.__init__):
(Port._port_flag_for_scripts):
(Port._wk2_port_name):
* Scripts/webkitpy/port/builders.py:
* Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
(PortFactory._default_port):
* Scripts/webkitpy/port/factory_unittest.py:
(FactoryTest.test_gtk):
* Scripts/webkitpy/port/qt.py: Removed.
* Scripts/webkitpy/port/qt_unittest.py: Removed.
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):
* Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker):
* Scripts/webkitpy/style/checkers/cpp.py:
(_classify_include):
(check_include_line):
(check_identifier_name_in_declaration):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_classify_include):
(WebKitStyleTest.test_names):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):
* Scripts/webkitpy/tool/main.py:
(WebKitPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't
ap@apple.com [Fri, 4 Oct 2013 17:00:40 +0000 (17:00 +0000)]
Add svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't
show up as unversioned all the time.

* inspector/Scripts: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win][WebGL] Crash on exit
commit-queue@webkit.org [Fri, 4 Oct 2013 16:15:34 +0000 (16:15 +0000)]
[Win][WebGL] Crash on exit
https://bugs.webkit.org/show_bug.cgi?id=120764

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-04
Reviewed by Martin Robinson.

On exit, libGLESv2.dll is detached from the process and relevant memory is released
before the atexit GL context cleanup handler is called, causing a NULL pointer crash.
The GL context cleanup code was originally written to avoid a X server crash on exit,
so it's only needed for PLATFORM(X11).

* platform/graphics/GLContext.cpp: Only clean up active GL contexts on exit for PLATFORM(X11).
(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::GLContext):
(WebCore::GLContext::~GLContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Enable text edition UndoOperations support in WebKit2
commit-queue@webkit.org [Fri, 4 Oct 2013 16:14:06 +0000 (16:14 +0000)]
[GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.

* GNUmakefile.list.am:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
* UIProcess/API/gtk/PageClientImpl.h:

LayoutTests:

* platform/gtk-wk2/TestExpectations: Corrected the expectations
with the new results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Regions as stacking contexts should paint over positioned sibling
mihnea@adobe.com [Fri, 4 Oct 2013 16:02:46 +0000 (16:02 +0000)]
[CSSRegions] Regions as stacking contexts should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122321

Reviewed by Alexandru Chiculita.

Source/WebCore:

Test: fast/regions/layers/region-normalflow-stacking-context.html

Since regions are stacking contexts, they should not be in normal flow list of layers.
More clean-up after https://bugs.webkit.org/show_bug.cgi?id=117365 and https://bugs.webkit.org/show_bug.cgi?id=121828
which enabled the layers.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Add a new test and modify existing tests to take into account the stacking context behavior
for non-positioned regions.

* fast/regions/autoheight-regions-mark-expected.txt:
* fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
* fast/regions/layers/region-normalflow-stacking-context.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WebAssertions.h
andersca@apple.com [Fri, 4 Oct 2013 15:26:44 +0000 (15:26 +0000)]
Remove WebAssertions.h
https://bugs.webkit.org/show_bug.cgi?id=122328

Reviewed by Jessie Berlin.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Misc/WebAssertions.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Fri, 4 Oct 2013 15:22:41 +0000 (15:22 +0000)]
Unreviewed EFL gardening

Remove failure expectations from tests that are passing.

* platform/efl-wk2/TestExpectations: update js/dom/create-lots-of-workers.html path.
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Enable correct behaviour for deleting regional indicator symbols
commit-queue@webkit.org [Fri, 4 Oct 2013 14:22:31 +0000 (14:22 +0000)]
[EFL] Enable correct behaviour for deleting regional indicator symbols
https://bugs.webkit.org/show_bug.cgi?id=122209

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-04
Reviewed by Gyuyoung Kim.

Source/WebCore:

Regional indicator symbols that are combined should behave as a single character when deleting.
Removed unused variable initialState.

* rendering/RenderText.cpp:
(WebCore::RenderText::previousOffsetForBackwardDeletion):

LayoutTests:

Now editing/deleting/regional-indicators.html is passing on EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt leftovers from WebKit2
commit-queue@webkit.org [Fri, 4 Oct 2013 14:16:22 +0000 (14:16 +0000)]
Remove Qt leftovers from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122317

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-04
Reviewed by Anders Carlsson.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
* Shared/API/c/WKBase.h:
* Shared/NativeWebTouchEvent.h:
* UIProcess/API/C/WebKit2_C.h:
* UIProcess/BackingStore.h:
* UIProcess/InspectorServer/WebInspectorServer.cpp:
(WebKit::WebInspectorServer::inspectorUrlForPageID):
* UIProcess/InspectorServer/WebInspectorServer.h:
* UIProcess/InspectorServer/WebSocketServer.cpp:
* UIProcess/InspectorServer/WebSocketServer.h:
* UIProcess/WebPageProxy.cpp:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDele...
zandobersek@gmail.com [Fri, 4 Oct 2013 12:23:15 +0000 (12:23 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122276

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/css/.

* css/CSSHostRule.idl:
* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSSupportsRule.idl:
* css/CSSValueList.idl:
* css/DOMWindowCSS.idl:
* css/FontLoader.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
* css/WebKitCSSTransformValue.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the Opera...
zandobersek@gmail.com [Fri, 4 Oct 2013 11:59:23 +0000 (11:59 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122274

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/loader/appcache/.

* loader/appcache/DOMApplicationCache.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNot...
zandobersek@gmail.com [Fri, 4 Oct 2013 11:55:18 +0000 (11:55 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122273

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/plugins/.

* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNot...
zandobersek@gmail.com [Fri, 4 Oct 2013 11:51:16 +0000 (11:51 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122272

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/storage/.

* storage/Storage.idl:
* storage/StorageEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNot...
zandobersek@gmail.com [Fri, 4 Oct 2013 11:41:00 +0000 (11:41 +0000)]
[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122270

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/workers/.

* workers/DedicatedWorkerGlobalScope.idl:
* workers/Worker.idl:
* workers/WorkerGlobalScope.idl:
* workers/WorkerLocation.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Infinite loop when computing widows
abucur@adobe.com [Fri, 4 Oct 2013 08:49:21 +0000 (08:49 +0000)]
[CSS Regions] Infinite loop when computing widows
https://bugs.webkit.org/show_bug.cgi?id=122215

Reviewed by David Hyatt.

Source/WebCore:

The patch ensures it's not possible to relayout a block indefinitely because of widows contraints. You can't
break a block more than once to account for widows. This can happen if, for example, some lines are moved
to the next container and there the content breaks in another container again without respecting the widows property.
This is in line with the idea of not leaving empty fragmentation containers during layout.

Test: fast/regions/regions-widows-stack-overflow.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):

* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData): Rename the m_shouldBreakAtLineToAvoidWidow
flag to m_didBreakAtLineToAvoidWidow.

(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow): Use the line index to determine if it should break or not.
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow): Use to determine if a break already happened because of widows.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

LayoutTests:

Test there is no stack overflow when trying to break for widows that are caused by other widows.

* fast/regions/regions-widows-stack-overflow-expected.html: Added.
* fast/regions/regions-widows-stack-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Add myself to some watchlists.
gyuyoung.kim@samsung.com [Fri, 4 Oct 2013 06:05:06 +0000 (06:05 +0000)]
Unreviewed. Add myself to some watchlists.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAssert that we don't try to index past the end of the m_coreTextIndices array
andersca@apple.com [Fri, 4 Oct 2013 04:42:02 +0000 (04:42 +0000)]
Assert that we don't try to index past the end of the m_coreTextIndices array
https://bugs.webkit.org/show_bug.cgi?id=122308

Reviewed by Dan Bernstein.

Because an assertion failure is better than a random crash.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::indexAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WebNSNotificationCenterExtras
andersca@apple.com [Fri, 4 Oct 2013 04:38:29 +0000 (04:38 +0000)]
Remove WebNSNotificationCenterExtras
https://bugs.webkit.org/show_bug.cgi?id=122316

Reviewed by Dan Bernstein.

Source/WebKit:

Update Xcode project.

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Use dispatch_async to ensure that notifications are posted on the main thread.

* Misc/WebIconDatabase.mm:
(-[WebIconDatabase _sendNotificationForURL:]):
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]):
* Misc/WebNSNotificationCenterExtras.h: Removed.
* Misc/WebNSNotificationCenterExtras.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r155787): WebKitTestRunner rebuilds from scratch when doing an incrementa...
mrowe@apple.com [Fri, 4 Oct 2013 04:11:43 +0000 (04:11 +0000)]
REGRESSION (r155787): WebKitTestRunner rebuilds from scratch when doing an incremental build

Reviewed by Dan Bernstein.

* WebKit2.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination. This avoids updating the modification date of the file when it has not changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove setting of some layout bits to RenderElement
antti@apple.com [Fri, 4 Oct 2013 04:04:35 +0000 (04:04 +0000)]
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256

Reviewed by Andreas Kling.

These bits never apply to RenderText nodes:

normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout

The code for setting them can be moved to RenderElement.

Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
mrowe@apple.com [Fri, 4 Oct 2013 03:19:44 +0000 (03:19 +0000)]
REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build

The change in r156811 resulted in several public headers in the JavaScriptCore framework having their modification
date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
needing to rebuilt after an incremental build of JavaScriptCore.

Reviewed by Dan Bernstein.

* JavaScriptCore.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove shouldRubberBandInDirection from the WKBundlePageUIClient
weinig@apple.com [Fri, 4 Oct 2013 03:08:46 +0000 (03:08 +0000)]
Remove shouldRubberBandInDirection from the WKBundlePageUIClient
https://bugs.webkit.org/show_bug.cgi?id=122309

Reviewed by Andreas Kling.

../WebCore:

* loader/EmptyClients.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
* page/FrameView.h:
* platform/ScrollableArea.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):

../WebKit/efl:

* WebCoreSupport/ChromeClientEfl.h:

../WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.h:

../WebKit/mac:

* WebCoreSupport/WebChromeClient.h:

../WebKit/win:

* WebCoreSupport/WebChromeClient.h:

../WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.h:

../WebKit2:

WKBundlePageUIClient's shouldRubberBandInDirection has never worked with
threaded scrolling, so remove it.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/15116673> [mac] Build failure when the source directory is not named...
mitz@apple.com [Fri, 4 Oct 2013 00:43:40 +0000 (00:43 +0000)]
<rdar://problem/15116673> [mac] Build failure when the source directory is not named ANGLE
https://bugs.webkit.org/show_bug.cgi?id=122307

Reviewed by Mark Rowe.

* ANGLE.xcodeproj/project.pbxproj: Ensure that the symlink to SRCROOT in
DerivedSources/ANGLE is named ANGLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the HTMLSelectElement.prototype.remove() method
ch.dumez@sisa.samsung.com [Thu, 3 Oct 2013 23:38:52 +0000 (23:38 +0000)]
Fix the HTMLSelectElement.prototype.remove() method
https://bugs.webkit.org/show_bug.cgi?id=121586

Reviewed by Darin Adler.

Source/WebCore:

Fix the HTMLSelectElement.prototype.remove() method so that it behaves like
Element.remove() if no argument is passed (from ChildNode). This behavior
is consistent with Firefox and Blink.

See https://www.w3.org/Bugs/Public/show_bug.cgi?id=20720 for more
information.

Tests: js/dom/select-options-remove.html

* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove):
Stop calling JSHTMLSelectElement::remove() blindly as it is dangerous, especially
now that calling it without argument now detaches the element. Instead, have the
bindings call the corresponding methods on the HTMLOptionsCollection implementation
object, as it should.

* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove):
Call Element::remove() if no argument is given.

* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::remove):
* html/HTMLOptionsCollection.h:
* html/HTMLSelectElement.cpp:
* html/HTMLSelectElement.h:
Rename remove(int) to removeByIndex(int) to avoid conflict with
Node::remove(ExceptionCode&).

LayoutTests:

Add test to make sure calling HTMLSelectElement.prototype.remove() detaches the
select element from its parent, as Element::remove() would.

* js/dom/select-options-remove-expected.txt:
* js/resources/select-options-remove.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRe-remove Qt TestExpectations re-added in r156841 after r156866.
rniwa@webkit.org [Thu, 3 Oct 2013 23:31:24 +0000 (23:31 +0000)]
Re-remove Qt TestExpectations re-added in r156841 after r156866.

* platform/qt: Removed.
* platform/qt/TestExpectations: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression: AX: <table><caption> no longer exposed as AXTitle.
commit-queue@webkit.org [Thu, 3 Oct 2013 23:29:25 +0000 (23:29 +0000)]
Regression: AX: <table><caption> no longer exposed as AXTitle.
https://bugs.webkit.org/show_bug.cgi?id=121977

Patch by Samuel White <samuel_white@apple.com> on 2013-10-03
Reviewed by Darin Adler.

Source/WebCore:

Some cleanup of accessibilityText. Notably, subclasses were unnecessarily redeclaring this method as both private and
protected. Added OVERRIDE keyword to these subclasses as needed. Moved titleElementText to virtual so we can do subclass
overrides in cases like this bug. That is, AccessibilityTable can leverage the existing machinery for alternativeText,
visibleText, and helpText, but we do some custom work ONLY in titleElementText.

Test: accessibility/table-title.html

* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityMediaControls.h:
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::titleElementText):
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::titleElementText):
* accessibility/AccessibilityTable.h:

LayoutTests:

Added test to verify that table elements correctly derive their AXTitle from their associated caption element.

* accessibility/table-title-expected.txt: Added.
* accessibility/table-title.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt builders from the flakiness dashboard.
rniwa@webkit.org [Thu, 3 Oct 2013 23:24:46 +0000 (23:24 +0000)]
Remove Qt builders from the flakiness dashboard.

* TestResultServer/static-dashboards/builders.jsonp:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/loader_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a testcase for a bug that I had during the development. This code uses the asm...
commit-queue@webkit.org [Thu, 3 Oct 2013 23:18:38 +0000 (23:18 +0000)]
Add a testcase for a bug that I had during the development. This code uses the asm.js style.
https://bugs.webkit.org/show_bug.cgi?id=122286

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Filip Pizlo.

* js/regress/asmjs_bool_bug-expected.txt: Added.
* js/regress/asmjs_bool_bug.html: Added.
* js/regress/script-tests/asmjs_bool_bug.js: Added.
(strlen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail...
timothy_horton@apple.com [Thu, 3 Oct 2013 23:10:10 +0000 (23:10 +0000)]
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299

Reviewed by Beth Dakin.

* TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
Disable threaded scrolling.

* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
* TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed gardening.
bfulgham@apple.com [Thu, 3 Oct 2013 23:03:42 +0000 (23:03 +0000)]
[Win] Unreviewed gardening.

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Clean up the
paths for various files added outside of Visual Studio. They are all
displayed in the root of the project, rather than the proper sub-folder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago../JavaScriptCore: [Win] Update solutions and projects to support 64-bit builds.
bfulgham@apple.com [Thu, 3 Oct 2013 22:54:54 +0000 (22:54 +0000)]
../JavaScriptCore: [Win] Update solutions and projects to support 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=122225

Reviewed by Anders Carlsson.

Revise ordering of CPU(X86) and CPU(X86_64) tests, because MSVC always defines
both when targeting a 64-bit build.

* JavaScriptCore.vcxproj/JavaScriptCore.submit.sln: Add an x64 target
for 64-bit builds.

../WTF: [Win] Update solutions and projects to support 64-bit build.
https://bugs.webkit.org/show_bug.cgi?id=122225

Reviewed by Anders Carlsson.

* WTF.vcxproj/WTF.submit.sln: Add x64 architecture targets.
* WTF.vcxproj/WTF.vcxproj: Correct path to config.h file.
* WTF.vcxproj/WTF.vcxproj.filters: Correct path to config.h file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreate CoordinatedDrawingArea / CoordinatedDrawingAreaProxy
commit-queue@webkit.org [Thu, 3 Oct 2013 22:52:36 +0000 (22:52 +0000)]
Create CoordinatedDrawingArea / CoordinatedDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=122207

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-03
Reviewed by Anders Carlsson.

Since Apple are moving away from DrawingAreaImpl, Coordinated Graphics
should have its own drawing area.

* CMakeLists.txt: Use CoordinatedDrawingArea and
CoordinatedDrawingAreaProxy instead of the DrawingAreaImpl /
DrawingAreaProxyImpl.
* Shared/DrawingAreaInfo.h: Add DrawingAreaTypeCoordinated.
* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
Added, copied from DrawingAreaProxyImpl.cpp.
* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Added,
copied from DrawingAreaProxyImpl.h.
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy): Use CoordinatedDrawingAreaProxy.
* UIProcess/DrawingAreaProxyImpl.cpp: Remove Coordinated Graphics
bits.
* UIProcess/DrawingAreaProxyImpl.h: Ditto.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
Added, copied from DrawingAreaImpl.cpp.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
Added, copied from DrawingAreaImpl.h.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush): Use
CoordinatedDrawingArea.
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Handle the DrawingAreaTypeCoordinated
in the DrawingArea creation code.
* WebProcess/WebPage/DrawingAreaImpl.cpp: Remove Coordinated Graphics
bits.
* WebProcess/WebPage/DrawingAreaImpl.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIgnore deprecation warnings
andersca@apple.com [Thu, 3 Oct 2013 22:15:08 +0000 (22:15 +0000)]
Ignore deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=122302

Reviewed by Mark Rowe.

Source/WebCore:

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _rectOnScreen]):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
* page/mac/FrameSnapshottingMac.mm:
(WebCore::imageFromRect):
* platform/graphics/mac/IconMac.mm:
(WebCore::Icon::Icon):
* platform/mac/DragImageMac.mm:
(WebCore::scaleDragImage):
* platform/mac/PlatformEventFactoryMac.mm:
(WebCore::globalPoint):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):

Source/WebKit/mac:

* Misc/WebIconDatabase.mm:
(-[WebIconDatabase _scaleIcon:toSize:]):
(webGetNSImage):
* Misc/WebNSImageExtras.m:
(-[NSImage _web_scaleToMaxSize:]):
(-[NSImage _web_dissolveToFraction:]):
* Misc/WebNSViewExtras.m:
(-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
(-[NSView _web_convertRect:toView:]):
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::mouseEvent):
* Plugins/Hosted/WebTextInputWindowController.m:
(-[WebTextInputPanel _interpretKeyEvent:string:]):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
* WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
* WebInspector/WebNodeHighlight.mm:
(-[WebNodeHighlight _computeHighlightWindowFrame]):
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
* WebView/WebHTMLView.mm:
(+[WebHTMLView _postFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView mouseDown:]):
(-[WebHTMLView mouseDragged:]):
(-[WebHTMLView mouseUp:]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _executeSavedKeypressCommands]):
(-[WebHTMLView attachRootLayer:]):
(-[WebHTMLView textStorage]):
(-[WebHTMLView _updateSelectionForInputManager]):
* WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _buildUI]):
(-[WebTextCompletionController _placePopupWindow:]):

Source/WebKit2:

* Shared/mac/WebEventFactory.mm:
(WebKit::globalPoint):
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
* UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
* UIProcess/API/mac/WKView.mm:
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WKView _setDragImage:at:linkDrag:]):
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse numeric strings in the OS version dictionary
andersca@apple.com [Thu, 3 Oct 2013 21:46:57 +0000 (21:46 +0000)]
Use numeric strings in the OS version dictionary
https://bugs.webkit.org/show_bug.cgi?id=122300

Reviewed by Mark Rowe.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEliminate unused JITStub function declarations
msaboff@apple.com [Thu, 3 Oct 2013 21:14:35 +0000 (21:14 +0000)]
Eliminate unused JITStub function declarations
https://bugs.webkit.org/show_bug.cgi?id=122288

Reviewed by Geoffrey Garen.

Removed unused JITStub declarations.

* jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Layout Test for selecting text in 2 regions
rego@igalia.com [Thu, 3 Oct 2013 21:07:07 +0000 (21:07 +0000)]
[CSS Regions] Layout Test for selecting text in 2 regions
https://bugs.webkit.org/show_bug.cgi?id=121841

Reviewed by Alexandru Chiculita.

Add new reftest for selecting text in 2 regions. It compares the
behavior (highlighted text and selected content) in regions and absolute
positions.

* fast/regions/resources/helper.js: Add new function to set selected
content in an element onmouseup.
(onMouseUpLogSelection.document.onmouseup):
(onMouseUpLogSelection):
* fast/regions/resources/region-style.css: Define some styles that could
be reused in other tests.
* fast/regions/selection/selecting-text-in-2-regions-expected.html:
Added.
* fast/regions/selection/selecting-text-in-2-regions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix LeaksViewer to load leaks results from MountainLion, not Lion.
ap@apple.com [Thu, 3 Oct 2013 20:44:26 +0000 (20:44 +0000)]
Fix LeaksViewer to load leaks results from MountainLion, not Lion.

Rubber-stamped by Tim Horton.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlaky Test: fast/history/history-back-while-pdf-in-pagecache.html
ap@apple.com [Thu, 3 Oct 2013 20:36:22 +0000 (20:36 +0000)]
Flaky Test: fast/history/history-back-while-pdf-in-pagecache.html
https://bugs.webkit.org/show_bug.cgi?id=121628

* platform/mac/TestExpectations: Marking as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Support the shape-image-threshold property
hmuller@adobe.com [Thu, 3 Oct 2013 20:04:50 +0000 (20:04 +0000)]
[CSS Shapes] Support the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122254

Reviewed by Andreas Kling.

Source/WebCore:

Replace the hardwired 0 Shape::createShape() threshold parameter with the style's
shapeImageThreshold() value (which has been clamped to [0,1]).

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html
       fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html

* rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):

LayoutTests:

Verify that a shape-outside image whose pixels' alpha channels are all above shape-image-threshold causes
layout to skirt the shape, and similarly that an image whose pixels' alpha channels are all below the threshold
has no effect on the layout.

* fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Revise the CSS property parsing tests
hmuller@adobe.com [Thu, 3 Oct 2013 20:00:52 +0000 (20:00 +0000)]
[CSS Shapes] Revise the CSS property parsing tests
https://bugs.webkit.org/show_bug.cgi?id=122251

Reviewed by Andreas Kling.

Flattened the shapes CSS property parsing tests by inserting the code from
the fast/shapes/parsing/script-tests subdirectory into the test HTML source
files. The subdirectory is now empty and the tests are easier to read.

* fast/shapes/parsing/parsing-shape-image-threshold.html: Inserted parsing-shape-image-threshold.js instead of referring to it with script src.
* fast/shapes/parsing/parsing-shape-inside.html: Likewise
* fast/shapes/parsing/parsing-shape-lengths.html: Likewise
* fast/shapes/parsing/parsing-shape-margin.html: Likewise
* fast/shapes/parsing/parsing-shape-outside.html: Likewise
* fast/shapes/parsing/parsing-shape-padding.html: Likewise
* fast/shapes/parsing/parsing-test-utils.js: Renamed from LayoutTests/fast/shapes/parsing/script-tests/parsing-test-utils.js.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
(property):
* fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Removed.
* fast/shapes/parsing/script-tests/parsing-shape-inside.js: Removed.
* fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Removed.
* fast/shapes/parsing/script-tests/parsing-shape-margin.js: Removed.
* fast/shapes/parsing/script-tests/parsing-shape-outside.js: Removed.
* fast/shapes/parsing/script-tests/parsing-shape-padding.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
commit-queue@webkit.org [Thu, 3 Oct 2013 19:53:13 +0000 (19:53 +0000)]
[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
https://bugs.webkit.org/show_bug.cgi?id=122265

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-10-03
Reviewed by Darin Adler.

Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.

No new tests, no behavior change.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresLayer):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::requiresLayer):
* rendering/RenderRegion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agovideo-object-fit tests are flaky
ap@apple.com [Thu, 3 Oct 2013 19:52:39 +0000 (19:52 +0000)]
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803

I'm not quite sure what's going on, but [ Pass Failure ] expectations didn't cut it.
Trying [ Pass ImageOnlyFailure ], as the failures are always image only anyway.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[cairo] Initialize the m_compositorTexture in GraphicsContext3DCairo.cpp
commit-queue@webkit.org [Thu, 3 Oct 2013 19:48:59 +0000 (19:48 +0000)]
[cairo] Initialize the m_compositorTexture in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=122285

Patch by Alejandro G. Castro <alex@igalia.com> on 2013-10-03
Reviewed by Noam Rosenthal.

Initialize to the default texture to avoid the random texture name
and generate the texture name.

* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize
m_compositorTexture.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Delete the
generated textures names.
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Generate the texture
names for m_compositorTexture and m_texture.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the last remnants of Qt from WebKit2
andersca@apple.com [Thu, 3 Oct 2013 18:38:40 +0000 (18:38 +0000)]
Remove the last remnants of Qt from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122290

Reviewed by Andreas Kling.

* Platform/PlatformProcessIdentifier.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* Shared/Downloads/Download.cpp:
(WebKit::Download::Download):
* Shared/Downloads/Download.h:
* Shared/Downloads/DownloadManager.cpp:
* Shared/Downloads/DownloadManager.h:
* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
* Shared/EditorState.h:
(WebKit::EditorState::EditorState):
* Shared/LayerTreeContext.h:
* Shared/NativeWebKeyboardEvent.h:
* Shared/NativeWebMouseEvent.h:
* Shared/NativeWebWheelEvent.h:
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
* Shared/ShareableBitmap.h:
* Shared/WebPreferencesStore.h:
* UIProcess/Downloads/DownloadProxy.cpp:
* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/PageClient.h:
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::showPopupMenu):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPopupMenuProxy.h:
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::willSetInputMethodState):
(WebKit::WebEditorClient::supportsGlobalSelection):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldFallBack):
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::didChangeSelectedIndex):
* WebProcess/WebCoreSupport/WebPopupMenu.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Support block content with inline content around floats in shape-inside
zoltan@webkit.org [Thu, 3 Oct 2013 18:24:59 +0000 (18:24 +0000)]
[CSS Shapes] Support block content with inline content around floats in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=121616

Reviewed by David Hyatt.

In r156022 and r156364, I added support for floats inside shape-inside with inline content. This change extends
the existing implementation to support block content with inline content (paragraphs). I added an extra text for
positioning a float inside shape-inside without text content around it.

Source/WebCore:

Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html
       fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html
       fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html
       fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html
       fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html

* rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalSize): Add new function to return the FloatingObject logical size.
* rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): When the lineBreaker code pushes down the content below the floating object,
we need to update the segments if we are in a shape-inside.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Do the positioning based on the float actual size, and use the
recent shapeInsideInfo. (Calling layoutShapeInsideInfo which deals with the layoutStates also instead of shapeInsideInfo.)
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): If we don't have inline content we still need to positionize
our float content in a shape-inside.
(WebCore::updateSegmentsForShapes): Use the right coordinates for block content with inline content.

LayoutTests:

* fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt files from WebKit2.
andersca@apple.com [Thu, 3 Oct 2013 18:06:43 +0000 (18:06 +0000)]
Remove Qt files from WebKit2.

Rubber-stomped by Andreas Kling.

* DerivedSources.pri: Removed.
* PluginProcess.pro: Removed.
* PluginProcess/qt/PluginControllerProxyQt.cpp: Removed.
* PluginProcess/qt/PluginProcessMainQt.cpp: Removed.
* PluginProcess/qt/PluginProcessQt.cpp: Removed.
* SandboxProcess.pro: Removed.
* Shared/API/c/qt/WKImageQt.cpp: Removed.
* Shared/API/c/qt/WKImageQt.h: Removed.
* Shared/Downloads/qt/DownloadQt.cpp: Removed.
* Shared/Downloads/qt/QtFileDownloader.cpp: Removed.
* Shared/Downloads/qt/QtFileDownloader.h: Removed.
* Shared/qt/ArgumentCodersQt.cpp: Removed.
* Shared/qt/ArgumentCodersQt.h: Removed.
* Shared/qt/LayerTreeContextQt.cpp: Removed.
* Shared/qt/NativeWebKeyboardEventQt.cpp: Removed.
* Shared/qt/NativeWebMouseEventQt.cpp: Removed.
* Shared/qt/NativeWebTouchEventQt.cpp: Removed.
* Shared/qt/NativeWebWheelEventQt.cpp: Removed.
* Shared/qt/PlatformCertificateInfo.h: Removed.
* Shared/qt/ProcessExecutablePathQt.cpp: Removed.
* Shared/qt/QtNetworkReplyData.cpp: Removed.
* Shared/qt/QtNetworkReplyData.h: Removed.
* Shared/qt/QtNetworkRequestData.cpp: Removed.
* Shared/qt/QtNetworkRequestData.h: Removed.
* Shared/qt/ShareableBitmapQt.cpp: Removed.
* Shared/qt/WebCoreArgumentCodersQt.cpp: Removed.
* Shared/qt/WebEventFactoryQt.cpp: Removed.
* Shared/qt/WebEventFactoryQt.h: Removed.
* Shared/qt/WebURLRequestQt.cpp: Removed.
* Shared/qt/WebURLResponseQt.cpp: Removed.
* Target.pri: Removed.
* UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Removed.
* UIProcess/API/C/qt/WKIconDatabaseQt.h: Removed.
* UIProcess/API/C/qt/WKNativeEvent.h: Removed.
* UIProcess/API/cpp/qt/WKStringQt.cpp: Removed.
* UIProcess/API/cpp/qt/WKStringQt.h: Removed.
* UIProcess/API/cpp/qt/WKURLQt.cpp: Removed.
* UIProcess/API/cpp/qt/WKURLQt.h: Removed.
* UIProcess/API/qt/qquicknetworkreply.cpp: Removed.
* UIProcess/API/qt/qquicknetworkreply_p.h: Removed.
* UIProcess/API/qt/qquicknetworkrequest.cpp: Removed.
* UIProcess/API/qt/qquicknetworkrequest_p.h: Removed.
* UIProcess/API/qt/qquickurlschemedelegate.cpp: Removed.
* UIProcess/API/qt/qquickurlschemedelegate_p.h: Removed.
* UIProcess/API/qt/qquickwebpage.cpp: Removed.
* UIProcess/API/qt/qquickwebpage_p.h: Removed.
* UIProcess/API/qt/qquickwebpage_p_p.h: Removed.
* UIProcess/API/qt/qquickwebview.cpp: Removed.
* UIProcess/API/qt/qquickwebview_p.h: Removed.
* UIProcess/API/qt/qquickwebview_p_p.h: Removed.
* UIProcess/API/qt/qtwebsecurityorigin.cpp: Removed.
* UIProcess/API/qt/qtwebsecurityorigin_p.h: Removed.
* UIProcess/API/qt/qwebdownloaditem.cpp: Removed.
* UIProcess/API/qt/qwebdownloaditem_p.h: Removed.
* UIProcess/API/qt/qwebdownloaditem_p_p.h: Removed.
* UIProcess/API/qt/qwebiconimageprovider.cpp: Removed.
* UIProcess/API/qt/qwebiconimageprovider_p.h: Removed.
* UIProcess/API/qt/qwebkittest.cpp: Removed.
* UIProcess/API/qt/qwebkittest_p.h: Removed.
* UIProcess/API/qt/qwebloadrequest.cpp: Removed.
* UIProcess/API/qt/qwebloadrequest_p.h: Removed.
* UIProcess/API/qt/qwebnavigationhistory.cpp: Removed.
* UIProcess/API/qt/qwebnavigationhistory_p.h: Removed.
* UIProcess/API/qt/qwebnavigationhistory_p_p.h: Removed.
* UIProcess/API/qt/qwebnavigationrequest.cpp: Removed.
* UIProcess/API/qt/qwebnavigationrequest_p.h: Removed.
* UIProcess/API/qt/qwebpermissionrequest.cpp: Removed.
* UIProcess/API/qt/qwebpermissionrequest_p.h: Removed.
* UIProcess/API/qt/qwebpreferences.cpp: Removed.
* UIProcess/API/qt/qwebpreferences_p.h: Removed.
* UIProcess/API/qt/qwebpreferences_p_p.h: Removed.
* UIProcess/API/qt/raw/qrawwebview.cpp: Removed.
* UIProcess/API/qt/raw/qrawwebview_p.h: Removed.
* UIProcess/API/qt/raw/qrawwebview_p_p.h: Removed.
* UIProcess/API/qt/tests/bytearraytestdata.cpp: Removed.
* UIProcess/API/qt/tests/bytearraytestdata.h: Removed.
* UIProcess/API/qt/tests/html/basic_page.html: Removed.
* UIProcess/API/qt/tests/html/basic_page2.html: Removed.
* UIProcess/API/qt/tests/html/bluesquare.html: Removed.
* UIProcess/API/qt/tests/html/direct-image-compositing.html: Removed.
* UIProcess/API/qt/tests/html/inputmethod.html: Removed.
* UIProcess/API/qt/tests/html/redsquare.html: Removed.
* UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Removed.
* UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Removed.
* UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Removed.
* UIProcess/API/qt/tests/html/resources/simple_image.png: Removed.
* UIProcess/API/qt/tests/html/scroll.html: Removed.
* UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Removed.
* UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Removed.
* UIProcess/API/qt/tests/publicapi/publicapi.pro: Removed.
* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView.pro: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Removed.
* UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Removed.
* UIProcess/API/qt/tests/qmltests/common/alert.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Removed.
* UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Removed.
* UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Removed.
* UIProcess/API/qt/tests/qmltests/common/colorChooser.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/confirm.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/download.zip: Removed.
* UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/favicon.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/favicon.png: Removed.
* UIProcess/API/qt/tests/qmltests/common/favicon2.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/geolocation.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/javascript.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/link.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/localStorage.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/messaging.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/notification.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/prompt.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/qrctest.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/redirect.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/select.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Removed.
* UIProcess/API/qt/tests/qmltests/common/test1.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/test2.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/test3.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/test4.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/test5.html: Removed.
* UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Removed.
* UIProcess/API/qt/tests/qmltests/qmltests.pro: Removed.
* UIProcess/API/qt/tests/qmltests/resources.qrc: Removed.
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Removed.
* UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Removed.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Removed.
* UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Removed.
* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Removed.
* UIProcess/API/qt/tests/tests.pri: Removed.
* UIProcess/API/qt/tests/testwindow.h: Removed.
* UIProcess/API/qt/tests/util.cpp: Removed.
* UIProcess/API/qt/tests/util.h: Removed.
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Removed.
* UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Removed.
* UIProcess/InspectorServer/qt/WebSocketServerQt.h: Removed.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Removed.
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Removed.
* UIProcess/qt/BackingStoreQt.cpp: Removed.
* UIProcess/qt/PageViewportControllerClientQt.cpp: Removed.
* UIProcess/qt/PageViewportControllerClientQt.h: Removed.
* UIProcess/qt/QtDialogRunner.cpp: Removed.
* UIProcess/qt/QtDialogRunner.h: Removed.
* UIProcess/qt/QtDownloadManager.cpp: Removed.
* UIProcess/qt/QtDownloadManager.h: Removed.
* UIProcess/qt/QtGestureRecognizer.cpp: Removed.
* UIProcess/qt/QtGestureRecognizer.h: Removed.
* UIProcess/qt/QtPageClient.cpp: Removed.
* UIProcess/qt/QtPageClient.h: Removed.
* UIProcess/qt/QtPanGestureRecognizer.cpp: Removed.
* UIProcess/qt/QtPanGestureRecognizer.h: Removed.
* UIProcess/qt/QtPinchGestureRecognizer.cpp: Removed.
* UIProcess/qt/QtPinchGestureRecognizer.h: Removed.
* UIProcess/qt/QtTapGestureRecognizer.cpp: Removed.
* UIProcess/qt/QtTapGestureRecognizer.h: Removed.
* UIProcess/qt/QtWebContext.cpp: Removed.
* UIProcess/qt/QtWebContext.h: Removed.
* UIProcess/qt/QtWebError.cpp: Removed.
* UIProcess/qt/QtWebError.h: Removed.
* UIProcess/qt/QtWebIconDatabaseClient.cpp: Removed.
* UIProcess/qt/QtWebIconDatabaseClient.h: Removed.
* UIProcess/qt/QtWebPageEventHandler.cpp: Removed.
* UIProcess/qt/QtWebPageEventHandler.h: Removed.
* UIProcess/qt/QtWebPagePolicyClient.cpp: Removed.
* UIProcess/qt/QtWebPagePolicyClient.h: Removed.
* UIProcess/qt/QtWebPageSGNode.cpp: Removed.
* UIProcess/qt/QtWebPageSGNode.h: Removed.
* UIProcess/qt/QtWebPageUIClient.cpp: Removed.
* UIProcess/qt/QtWebPageUIClient.h: Removed.
* UIProcess/qt/TextCheckerQt.cpp: Removed.
* UIProcess/qt/WebColorPickerQt.cpp: Removed.
* UIProcess/qt/WebColorPickerQt.h: Removed.
* UIProcess/qt/WebContextMenuProxyQt.cpp: Removed.
* UIProcess/qt/WebContextMenuProxyQt.h: Removed.
* UIProcess/qt/WebContextQt.cpp: Removed.
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Removed.
* UIProcess/qt/WebGeolocationProviderQt.cpp: Removed.
* UIProcess/qt/WebGeolocationProviderQt.h: Removed.
* UIProcess/qt/WebInspectorProxyQt.cpp: Removed.
* UIProcess/qt/WebPageProxyQt.cpp: Removed.
* UIProcess/qt/WebPopupMenuProxyQt.cpp: Removed.
* UIProcess/qt/WebPopupMenuProxyQt.h: Removed.
* UIProcess/qt/WebPreferencesQt.cpp: Removed.
* UIProcess/qt/WebProcessProxyQt.cpp: Removed.
* WebKit2.pri: Removed.
* WebKit2.pro: Removed.
* WebProcess.pro: Removed.
* WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Removed.
* WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
* WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Removed.
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Removed.
* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Removed.
* WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Removed.
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Removed.
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Removed.
* WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp: Removed.
* WebProcess/WebPage/qt/WebInspectorQt.cpp: Removed.
* WebProcess/WebPage/qt/WebPageQt.cpp: Removed.
* WebProcess/qt/QtBuiltinBundle.cpp: Removed.
* WebProcess/qt/QtBuiltinBundle.h: Removed.
* WebProcess/qt/QtBuiltinBundlePage.cpp: Removed.
* WebProcess/qt/QtBuiltinBundlePage.h: Removed.
* WebProcess/qt/QtNetworkAccessManager.cpp: Removed.
* WebProcess/qt/QtNetworkAccessManager.h: Removed.
* WebProcess/qt/QtNetworkReply.cpp: Removed.
* WebProcess/qt/QtNetworkReply.h: Removed.
* WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Removed.
* WebProcess/qt/SeccompFiltersWebProcessQt.h: Removed.
* WebProcess/qt/WebProcessMainQt.cpp: Removed.
* WebProcess/qt/WebProcessQt.cpp: Removed.
* qt/MainQt.cpp: Removed.
* qt/PluginMainQt.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd test expectation for one more test having color space issues after r156793.
timothy_horton@apple.com [Thu, 3 Oct 2013 18:05:37 +0000 (18:05 +0000)]
Add test expectation for one more test having color space issues after r156793.
(css3/filters/custom/custom-filter-composite-fractional-source-alpha.html)

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test media/click-volume-bar-not-pausing.html is flaky
ap@apple.com [Thu, 3 Oct 2013 17:58:05 +0000 (17:58 +0000)]
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126

* platform/mac/TestExpectations: Marked it as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove IDBFactoryBackend creation to DatabaseStrategy.
beidson@apple.com [Thu, 3 Oct 2013 17:55:04 +0000 (17:55 +0000)]
Move IDBFactoryBackend creation to DatabaseStrategy.
https://bugs.webkit.org/show_bug.cgi?id=122284

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

* Modules/indexeddb/IDBFactory.h:
* Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):

* platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend): Implement a default.
* platform/DatabaseStrategy.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Fallback to the default for now.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRe-add Qt TestExpectations. Without it, the flakiness dashboard page loads as blank.
ap@apple.com [Thu, 3 Oct 2013 17:45:27 +0000 (17:45 +0000)]
Re-add Qt TestExpectations. Without it, the flakiness dashboard page loads as blank.

* platform/qt: Added.
* platform/qt/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion...
mitz@apple.com [Thu, 3 Oct 2013 17:29:20 +0000 (17:29 +0000)]
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260

Reviewed by Alexey Proskuryakov.

For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.

* TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compile error with VIDEO disabled.
commit-queue@webkit.org [Thu, 3 Oct 2013 17:24:47 +0000 (17:24 +0000)]
[WinCairo] Compile error with VIDEO disabled.
https://bugs.webkit.org/show_bug.cgi?id=122266

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-03
Reviewed by Brent Fulgham.

* dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Protect with ENABLE(VIDEO) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] add shape-margin support for image valued shapes
hmuller@adobe.com [Thu, 3 Oct 2013 17:20:07 +0000 (17:20 +0000)]
[CSS Shapes] add shape-margin support for image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=121619

Reviewed by Alexandru Chiculita.

Source/WebCore:

Add support for computing the shape-margin boundary for a shape-outside whose
value is an image.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html
       fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html
       fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html

* rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::MarginIntervalGenerator): Internal utility that generates the margin intervals for the image interval specified with set().
(WebCore::MarginIntervalGenerator::set):
(WebCore::MarginIntervalGenerator::intervalAt):
(WebCore::findInsertionPoint): Find the insertion point index for the the specified X value, within a vector of intervals sorted by X1.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Destructively unite one interval with an existing one, or append it.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
(WebCore::RasterShape::marginIntervals): Return the lazily computed value, or create it with computeShapeMarginIntervals().
* rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::getIntervals):
(WebCore::RasterShape::RasterShape):
(WebCore::RasterShapeIntervals::uniteMarginInterval):
* WTF/wtf/MathExtras.h: Added clampToUnsigned() inline.

LayoutTests:

Verify that the shape-outside margin-boundary is computed correctly for image valued shapes.

* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] [DEBUG] JavaScriptCore fails to build
commit-queue@webkit.org [Thu, 3 Oct 2013 17:12:50 +0000 (17:12 +0000)]
[EFL] [DEBUG] JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122267

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-03
Reviewed by Michael Saboff.

Build fails due to an expression containing comparison between signed
and unsigned integer.

* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Add cast to avoid signed vs.
unsigned comparison warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Remove unused RenderLayerModelObject::updateLayerIfNeeded
mihnea@adobe.com [Thu, 3 Oct 2013 16:02:46 +0000 (16:02 +0000)]
[CSSRegions] Remove unused RenderLayerModelObject::updateLayerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=122262

Reviewed by Alexandru Chiculita.

All regions have layers by default therefore there is no need for this function.
No tests needed, just a minor cleanup.

* rendering/RenderLayerModelObject.cpp:
* rendering/RenderLayerModelObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Expose aria-invalid as a text attribute (not object attribute)
mario@webkit.org [Thu, 3 Oct 2013 15:21:21 +0000 (15:21 +0000)]
[ATK] Expose aria-invalid as a text attribute (not object attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the aria-invalid attribute correctly through a text
attribute (through the AtkText interface) instead of using an
object, according to what the WAI-ARIA specs says.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property

This will be tested by accesibility/aria-invalid.html, which should
keep passing after thanks to the changes done in the DRT and WKTR.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus): Update this method
to only return values recognized by the WAI-ARIA specification.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject): Expose aria-invalid as a
custom text attribute 'invalid', following the lead of Firefox.
Also register that custom attribute as a AtkTextAttribute.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Remove exposure of aria-invalid
as an object attribute from here.

Tools:

Adapted DRT and WKTR to check the exposure of the aria-invalid
attribute as a text attribute, instead of an object attribute.

Also, done some refactoring of the code to try to keep things
simpler and more coherent, by defining new helper functions,
simplifying code, moving static variables and functions into
unnammed namespaces and so on, without altering the logic other
than for checking the text attribute for aria-invalid.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(coreAttributeToAtkAttribute): Consider 'invalid' as the name of
the attribute exposed by the ATK wrapper, not 'aria-invalid'.
Also, never return an empty string if not falling through any of
the cases checked here, and return the original attribute instead.
(atkAttributeValueToCoreAttributeValue): New helper function to
match the attributes values returned by the ATK wrapper with the
values expected by the layout tests. Moved the mappings for the
values of AXSortDirection here as well.
(getAttributeSet): New helper function to retrieve a list of
attributes (an AtkAttributeSet) from an AtkObject using the right
API depending on whether we want the object attributes or the text
attributes (in case the object implements AtkText).
(getAttributeSetValueForId): Simplified by using getAttributeSet
and atkAttributeValueToCoreAttributeValue. Also, added a new
parameter to indicater whether we are interested in object
attributes or text attributes.
(getAtkAttributeSetAsString): Ditto.
(attributesOfElement): Updated to pass the new required parameter
to getAtkAttributeSetAsString, indicating that we want the object
attributes in this case, for backwards compatibility.
(indexRangeInTable): Moved up in the file into the unnammed namespace.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::stringAttributeValue): After moving most
of the code here to the new helper functions, simplified it by
just checking whether the required attribute is provided as an
object attribute or, if that's not the case, as a text attribute.
(AccessibilityUIElement::isAttributeSupported): Ditto.
(AccessibilityUIElement::intValue): Updated to pass the new
required parameter to getAttributeSetValueForId, indicating that
we want the object attributes in this case.
(AccessibilityUIElement::hasPopup): Ditto.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
(WTR::atkAttributeValueToCoreAttributeValue): Ditto.
(WTR::getAttributeSet): Ditto.
(WTR::getAttributeSetValueForId): Ditto.
(WTR::getAtkAttributeSetAsString): Ditto.
(WTR::attributesOfElement): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.

LayoutTests:

Updated the aria-invalid.html layout test to make sure that it
behaves as defined by the WAI-ARIA specification for values other
than 'false', 'true', 'grammar' and 'spelling'.

* accessibility/aria-invalid.html: Updated test.
* accessibility/aria-invalid-expected.txt: Updated expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd back .htaccess files erroneously removed in r156827.
rniwa@webkit.org [Thu, 3 Oct 2013 10:19:35 +0000 (10:19 +0000)]
Add back .htaccess files erroneously removed in r156827.

* http/tests/appcache/resources/intercept: Copied from LayoutTests/http/tests/appcache/resources/intercept.
* http/tests/uri/intercept: Copied from LayoutTests/http/tests/uri/intercept.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd the NotDeletable, OperationsNotDeletable IDL attributes
zandobersek@gmail.com [Thu, 3 Oct 2013 09:30:40 +0000 (09:30 +0000)]
Add the NotDeletable, OperationsNotDeletable IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=122217

Reviewed by Darin Adler.

Before adjusting the JSC bindings generator to enforce configurable operations and thus conform to the
WebIDL specification in this regard, two no-op attributes are introduced that will preserve the current
behavior of operations being non-configurable.

All the relevant interfaces will be annotated with the OperationsNotDeletable attribute first. After the
generator is properly modified, this attribute will be removed from the interfaces after checking that
the operations' configurability also matches the configurability of operations in other browser engines
and that the change introduces no regressions in tests.

The NotDeletable attribute will be used as required to annotate operations that should stay
non-configurable for backwards compatibility or cross-browser compatibility.

* bindings/scripts/IDLAttributes.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x)
commit-queue@webkit.org [Thu, 3 Oct 2013 08:43:07 +0000 (08:43 +0000)]
DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x)
https://bugs.webkit.org/show_bug.cgi?id=122263

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Geoffrey Garen.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt specific expected files and directories.
kadam@inf.u-szeged.hu [Thu, 3 Oct 2013 08:35:22 +0000 (08:35 +0000)]
Remove Qt specific expected files and directories.
Reviewed by Csaba Osztrogon√°c.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed fix of DrawingArea creation on non-Mac platforms after r156793.
zandobersek@gmail.com [Thu, 3 Oct 2013 07:58:09 +0000 (07:58 +0000)]
Unreviewed fix of DrawingArea creation on non-Mac platforms after r156793.
std::make_unique<DrawingAreaImpl>() should be used, as before that revision.

* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Remove empty directories.
ossy@webkit.org [Thu, 3 Oct 2013 07:35:06 +0000 (07:35 +0000)]
Unreviewed. Remove empty directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove preDispatchEventHandler and postDispatchEventHandler,
rniwa@webkit.org [Thu, 3 Oct 2013 07:33:13 +0000 (07:33 +0000)]
Remove preDispatchEventHandler and postDispatchEventHandler,
functions that are supposed to be removed in the previous commit (r156825).

* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of Node::preDispatchEventHandler and Node::postDispatchEventHandler
rniwa@webkit.org [Thu, 3 Oct 2013 06:50:54 +0000 (06:50 +0000)]
Get rid of Node::preDispatchEventHandler and Node::postDispatchEventHandler
https://bugs.webkit.org/show_bug.cgi?id=122144

Reviewed by Darin Adler.

Get rid of pre/post event dispatch callbacks preDispatchEventHandler and postDispatchEventHandler since
the former was only called by HTMLMediaElement and HTMLInputElement and the latter was only called by
HTMLInputElement.

Explicitly call HTMLMediaElement's willDispatchFullScreenChangeEvent in fullScreenChangeDelayTimerFired
of Document since this is the only place that fires the fullscreenchange event.

Also add an explicit call to willDispatchEvent and didDispatchClickEvent in EventDispatcher::dispatch.
This also allows us to stack-allocate InputElementClickHandlingState instead of having willDispatchEvent
heap-allocate it and pass it around as void*.

* WebCore.order:
* dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
* dom/Document.h:
* dom/EventContext.cpp:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::callWillDispatchEventOnInputElement):
(WebCore::EventDispatcher::dispatchEventPostProcess):
* dom/EventDispatcher.h:
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick):
* html/CheckboxInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willDispatchEvent):
(WebCore::HTMLInputElement::didDispatchClickEvent):
* html/HTMLInputElement.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::willDispatchFullScreenChangeEvent): Renamed from preDispatchEventHandler.
* html/HTMLTextFormControlElement.h:
* html/InputType.cpp:
(WebCore::InputType::willDispatchClick):
* html/InputType.h:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::willDispatchClick):
* html/RadioInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate binding test results after r156808 for r156769.
rniwa@webkit.org [Thu, 3 Oct 2013 06:41:31 +0000 (06:41 +0000)]
Update binding test results after r156808 for r156769.

* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeOwner::finalize):
* bindings/scripts/test/JS/JSattribute.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyOwner::finalize):
* bindings/scripts/test/JS/JSreadonly.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion...
mitz@apple.com [Thu, 3 Oct 2013 06:30:24 +0000 (06:30 +0000)]
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260

Reviewed by Mark Rowe.

For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.

* API/tests/testapi.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r156816.
commit-queue@webkit.org [Thu, 3 Oct 2013 05:59:22 +0000 (05:59 +0000)]
Unreviewed, rolling out r156816.
http://trac.webkit.org/changeset/156816
https://bugs.webkit.org/show_bug.cgi?id=122259

broke 8 tests (Requested by kling on #webkit).

* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::willRecalcStyle):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::setPositionFromValue):
(WebCore::SliderThumbElement::setPositionFromPoint):
(WebCore::SliderThumbElement::stopDragging):
* page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::layout):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::setNeedsLayout):
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* rendering/FlowThreadController.h:
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutShapeDescendantIfMoved):
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::positionLineBox):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
* rendering/RenderElement.h:
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::styleDidChange):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFrames):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::continueResizing):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::layout):
* rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNormalChildNeedsLayout):
(WebCore::RenderObject::setPosChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setChildNeedsLayout):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
* rendering/RenderReplica.cpp:
(WebCore::RenderReplica::layout):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTable.h:
(WebCore::RenderTable::setNeedsSectionRecalc):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::setCellLogicalWidth):
(WebCore::RenderTableCell::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcCells):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::setNeedsLayoutOnAncestors):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::layout):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
* rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::layout):
* rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::layout):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::svgAttributeChanged):
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::svgAttributeChanged):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::updateCurrentTranslate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2013-10-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Oct 2013 04:31:04 +0000 (04:31 +0000)]
2013-10-02  Geoffrey Garen  <ggaren@apple.com>

        Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.

        * perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
        * perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImproved painting behavior in SunSpider 1.0.2
ggaren@apple.com [Thu, 3 Oct 2013 04:25:53 +0000 (04:25 +0000)]
Improved painting behavior in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122257

Reviewed by Oliver Hunt.

Individual test names with times was a good painting strategy years
back, when each benchmark took hundreds of milliseconds to run. Now,
the whole suite can finish in a a few hundres milliseconds, and things
look pretty flashy.

Instead, display a countdown that indicates which iteration of the
test we're on.

* resources/TEMPLATE.html: Work around a bug in Firefox by specifying
our style inside the .html file instead of in an external stylesheet.
Under heavy JavaScript load, Firefox neglects to apply external
stylesheets -- probably due to a starved timer.

* resources/driver-TEMPLATE.html: Delay a little between runs to ensure
that our countdown has enough time to paint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoKeep SVGElementRareData in an SVGElement member instead of a hashmap.
akling@apple.com [Thu, 3 Oct 2013 03:21:21 +0000 (03:21 +0000)]
Keep SVGElementRareData in an SVGElement member instead of a hashmap.
<https://webkit.org/b/122253>

Reviewed by Antti Koivisto.

Free up another Node flag by moving SVGElement's SVG-specific rare data
to a member variable instead of tracking them in a hashmap on the side.

This grows SVGElement by one pointer, but I will make up for this in
subsequent patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake LLINT exception stack unwinding consistent with the JIT.
mark.lam@apple.com [Thu, 3 Oct 2013 02:44:18 +0000 (02:44 +0000)]
Make LLINT exception stack unwinding consistent with the JIT.
https://bugs.webkit.org/show_bug.cgi?id=122255.

Reviewed by Filip Pizlo.

Previously, the CommonSlowPaths code is expected to behave in an
inconsistent way in terms of whether to unwind the stack when handling
exceptions or not. For the LLINT, the slow path should unwind the stack
before returning. For the JIT, the slow path should not unwind the stack.
This can result in the stack being unwound twice when the exception
being handled is a TerminationException.

This patch fixes the LLINT's expectation so that it expects the same
slow path behavior as the JIT does.

* llint/LLIntExceptions.cpp:
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe DFG should use always DFG::Graph methods for determining where special registers are
fpizlo@apple.com [Thu, 3 Oct 2013 02:27:14 +0000 (02:27 +0000)]
The DFG should use always DFG::Graph methods for determining where special registers are
https://bugs.webkit.org/show_bug.cgi?id=122248

Reviewed by Michael Saboff.

This makes it possible to have the DFG use different registers than the other engines
for things like activation and arguments.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::baselineArgumentsRegisterFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove setting of some layout bits to RenderElement
antti@apple.com [Thu, 3 Oct 2013 02:26:52 +0000 (02:26 +0000)]
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256

Reviewed by Andreas Kling.

These bits never apply to RenderText nodes:

normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout

The code for setting them can be moved to RenderElement.

Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCTTE: Drag events are only dispatched on Elements.
akling@apple.com [Thu, 3 Oct 2013 01:32:43 +0000 (01:32 +0000)]
CTTE: Drag events are only dispatched on Elements.
<https://webkit.org/b/122250>

Reviewed by Antti Koivisto.

We never dispatch drag events on non-Element nodes so tighten up the
code to operate on Elements instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Implement the shape-image-threshold property
hmuller@adobe.com [Thu, 3 Oct 2013 00:54:32 +0000 (00:54 +0000)]
[CSS Shapes] Implement the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122216

Reviewed by Andreas Kling.

Source/WebCore:

Added support for the CSS shape-image-threshold property. This change
just enables parsing the property, it's not connected to the
Shapes code yet.

The number valued shape-image-threshold property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
Its computed value is clamped to the range [0, 1].

Test: fast/shapes/parsing/parsing-shape-image-threshold.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

Check parsing of the non-inherited CSS shape-image-threshold number property.
The property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property

* fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: Added.
* fast/shapes/parsing/parsing-shape-image-threshold.html: Added.
* fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt-specific code in WebCore/plugins.
akling@apple.com [Thu, 3 Oct 2013 00:10:33 +0000 (00:10 +0000)]
Remove Qt-specific code in WebCore/plugins.
<https://webkit.org/b/122247>

Reviewed by Anders Carlsson.

Purge PLATFORM(QT) blocks and Qt-specific files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt related files from the root directories
andersca@apple.com [Thu, 3 Oct 2013 00:04:25 +0000 (00:04 +0000)]
Remove Qt related files from the root directories
https://bugs.webkit.org/show_bug.cgi?id=122249

Reviewed by Andreas Kling.

* Source/QtWebKit.pro: Removed.
* Source/api.pri: Removed.
* Source/qtwebkit.qdocconf: Removed.
* Source/sync.profile: Removed.
* Source/tests.pri: Removed.
* Source/widgetsapi.pri: Removed.
* WebKit.pro: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156812 268f45cc-cd09-0410-ab3c-d52691b4dbfc