WebKit-https.git
9 years agoplugins/invalidate_rect.html failing on Windows
jberlin@webkit.org [Fri, 11 Feb 2011 21:41:30 +0000 (21:41 +0000)]
plugins/invalidate_rect.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=54122

This test was fixed on Windows in http://trac.webkit.org/changeset/78359. Remove the failing
expected results. Unreviewed.

* platform/win/plugins/invalidate_rect-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocrashes in WebProcess at WebCore::Range::startPosition const + 16
enrica@apple.com [Fri, 11 Feb 2011 21:39:43 +0000 (21:39 +0000)]
crashes in WebProcess at WebCore::Range::startPosition const + 16
https://bugs.webkit.org/show_bug.cgi?id=54294
<rdar://problem/8982710>

Reviewed by Darin Adler.

I don't have a repro case for this bugs, but the side-by-side
comparison of the IME support implementation in WebKit and WebKi2
shows a missing null check on a Range that could very well explain
this crash.
I tried running platform/mac/editing/input tests with a version of WebKit
without the null check and I can reproduce a crash with the same signature.
These tests are not yet enabled for WebKit2.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::firstRectForCharacterRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Fri, 11 Feb 2011 21:39:04 +0000 (21:39 +0000)]
2011-02-11  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [fileapi] Add support for filesystem: URI handling
        https://bugs.webkit.org/show_bug.cgi?id=53529

        Tests for filesystem: URIs, testing both their security origin
        properties and the existence of the Entry.toURI method.

        * fast/filesystem/directory-entry-to-uri-expected.txt: Added.
        * fast/filesystem/directory-entry-to-uri.html: Added.
        * fast/filesystem/file-entry-to-uri-expected.txt: Added.
        * fast/filesystem/file-entry-to-uri.html: Added.
        * fast/filesystem/filesystem-uri-origin-expected.txt: Added.
        * fast/filesystem/filesystem-uri-origin.html: Added.
        * fast/filesystem/resources/directory-entry-to-uri.js: Added.
        (errorCallback):
        (entryToURI):
        (createTestDirectory):
        ():
        * fast/filesystem/resources/file-entry-to-uri.js: Added.
        (errorCallback):
        (entryToURI):
        (createTestFile):
        ():
        * http/tests/security/filesystem-iframe-from-remote-expected.txt: Added.
        * http/tests/security/filesystem-iframe-from-remote.html: Added.
        * http/tests/security/resources/create-filesystem-file.html: Added.
2011-02-11  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [fileapi] Add support for filesystem: URI handling
        https://bugs.webkit.org/show_bug.cgi?id=53529

        There are two major parts to this patch: one is to add an
        implementation of Entry.toURI to the FileSystem API.
        The other is to implement security origin checking for this
        new scheme.

        All changes are guarded by the FILE_SYSTEM feature. An accompanying
        Chromium change, to support loading of filesystem: URIs, has recently
        been submitted as Chromium r74082.

        Spec:
          http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2
        Proposed URI format, and discussion of security origin issues:
          http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html

        Tests: fast/filesystem/directory-entry-to-uri.html
               fast/filesystem/file-entry-to-uri.html
               fast/filesystem/filesystem-uri-origin.html
               http/tests/security/filesystem-iframe-from-remote.html

        * fileapi/Entry.cpp:
        (WebCore::Entry::toURI):
        * fileapi/Entry.h:
        * fileapi/Entry.idl:
        - Added toURI method to the IDL, omitting the MIME type argument
          specified in the spec as it will soon be removed.
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        - crack the filesystem: URI to get at the origin of the site
        (WebCore::SecurityOrigin::canDisplay):
        - canDisplay for filesystem: URIs is equivalent to canRequest
        * platform/AsyncFileSystem.cpp:
        (WebCore::AsyncFileSystem::create):
        (WebCore::AsyncFileSystem::openFileSystem):
        * platform/AsyncFileSystem.h:
        (WebCore::AsyncFileSystem::type):
        - Exposed filesystem type to allow toURI to use it as part of the
          path.
        (WebCore::AsyncFileSystem::AsyncFileSystem):
        * platform/SchemeRegistry.cpp:
        (WebCore::canDisplayOnlyIfCanRequestSchemes):
        (WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest):
        (WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest):
        - Generalized canDisplayOnlyIfCanRequest as it applies to both
          filesystem: and blob: URIs.
        * platform/SchemeRegistry.h:
2011-02-11  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [fileapi] Add support for filesystem: URI handling
        https://bugs.webkit.org/show_bug.cgi?id=53529

        Changes to Chromium WebKit API required to expose
        the FileSystem type to WebCore's fileapi code, since the
        type is part of the filesystem URI.

        * src/AsyncFileSystemChromium.cpp:
        (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
        * src/AsyncFileSystemChromium.h:
        (WebCore::AsyncFileSystemChromium::create):
        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        (WebCore::LocalFileSystem::requestFileSystem):
        * src/WebFileSystemCallbacksImpl.cpp:
        (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
        (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
        * src/WebFileSystemCallbacksImpl.h:
        * src/WorkerAsyncFileSystemChromium.cpp:
        (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
        * src/WorkerAsyncFileSystemChromium.h:
        (WebCore::WorkerAsyncFileSystemChromium::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8961061> CrashTracer: [USER]
bdakin@apple.com [Fri, 11 Feb 2011 21:21:27 +0000 (21:21 +0000)]
Fix for <rdar://problem/8961061> CrashTracer: [USER]
1 crash at com.apple.WebCore:
-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62

Reviewed by Darin Adler.

Must check for null _animator.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 11 Feb 2011 20:52:30 +0000 (20:52 +0000)]
2011-02-11  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Throw exception when AudioContext's createBuffer() fails to properly decode audio file data
        https://bugs.webkit.org/show_bug.cgi?id=54158

        No new tests since audio API is not yet implemented.

        * bindings/js/JSAudioContextCustom.cpp:
        (WebCore::JSAudioContextConstructor::constructJSAudioContext):
        (WebCore::JSAudioContext::createBuffer):
        * bindings/v8/custom/V8AudioContextCustom.cpp:
        (WebCore::V8AudioContext::createBufferCallback):
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::createBusFromInMemoryAudioFile):
        * webaudio/AudioContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Fri, 11 Feb 2011 20:41:31 +0000 (20:41 +0000)]
2011-02-11  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Kenneth Russell.

        plugins/invalidate_rect.html fails on chromium-mac
        https://bugs.webkit.org/show_bug.cgi?id=54051

        invalidate_rect.html should now pass on Windows. Removing skip.

        * platform/chromium/test_expectations.txt:
2011-02-11  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Kenneth Russell.

        plugins/invalidate_rect.html fails on chromium-mac
        https://bugs.webkit.org/show_bug.cgi?id=54051

        This change fixes the invalidate_rect.html test failure on Windows.

        There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.

        The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.

        This change also updates the build path in chromium_win.py to use the new Source directory.

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (invalidateRect):
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):
        (handleEventWin):
        (NPP_HandleEvent):
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 20:24:58 +0000 (20:24 +0000)]
2011-02-11  Martin Robinson  <mrobinson@igalia.com>

        Add another batch of GTK+ SVG test results.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 20:19:39 +0000 (20:19 +0000)]
2011-02-11  Martin Robinson  <mrobinson@igalia.com>

        Add the next batch of GTK+ SVG test results.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Mike Reed <reed@google.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 20:10:07 +0000 (20:10 +0000)]
2011-02-11  Mike Reed  <reed@google.com>

        Reviewed by James Robinson.

        Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing
        the address returned by getPixels() (as the device may not be backed by a CPU bitmap)
        https://bugs.webkit.org/show_bug.cgi?id=54224

        No new tests. Existing canvas tests exercise this...
        fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::toDataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Andrew Wason <rectalogic@rectalogic.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 19:53:16 +0000 (19:53 +0000)]
2011-02-11  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by David Levin.

        Files missing ENABLE_VIDEO #ifdef
        https://bugs.webkit.org/show_bug.cgi?id=53390

        No new tests.

        * html/canvas/WebGLRenderingContext.cpp:
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
          Wrap methods and declarations that use HTMLVideoElement
          with #if ENABLE(VIDEO).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 19:41:26 +0000 (19:41 +0000)]
2011-02-11  Martin Robinson  <mrobinson@igalia.com>

        Add the next batch of GTK+ SVG test results.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 19:37:37 +0000 (19:37 +0000)]
2011-02-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] wmode gets overridden even if already windowless in QGraphicsWebView
        Do not override wmode if it is not set to "window".
        https://bugs.webkit.org/show_bug.cgi?id=50495

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate /DELAYLOAD:msimg32.dll ignored warning when building WebKit project
jeffm@apple.com [Fri, 11 Feb 2011 19:23:36 +0000 (19:23 +0000)]
Eliminate /DELAYLOAD:msimg32.dll ignored warning when building WebKit project
https://bugs.webkit.org/show_bug.cgi?id=54296

Reviewed by Steve Falkenburg.

* win/WebKit2Common.vsprops: Remove msimg32.dll from the list of DelayLoadDLLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro...
alex@webkit.org [Fri, 11 Feb 2011 19:16:00 +0000 (19:16 +0000)]
2011-02-11  Chandra Vallala  <chandra.vallala@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy
        classes for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=54080

        * GNUmakefile.am:
        * Shared/gtk/UpdateChunk.cpp: Added.
        (WebKit::UpdateChunk::UpdateChunk):
        (WebKit::UpdateChunk::~UpdateChunk):
        (WebKit::UpdateChunk::encode):
        (WebKit::UpdateChunk::decode):
        (WebKit::UpdateChunk::createImage):
        * Shared/gtk/UpdateChunk.h: Added.
        (WebKit::UpdateChunk::rect):
        (WebKit::UpdateChunk::isEmpty):
        (WebKit::UpdateChunk::size):
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
        Initialize the surface.
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.h: Added cairo variables.
        * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Added.
        (WebKit::ChunkedUpdateDrawingAreaProxy::page):
        (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
        (WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
        (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
        (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
        * WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Added.
        (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
sergio@webkit.org [Fri, 11 Feb 2011 19:03:43 +0000 (19:03 +0000)]
2011-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78331.
        http://trac.webkit.org/changeset/78331
        https://bugs.webkit.org/show_bug.cgi?id=54295

        This patch broke 11 tests in GTK bots (Requested by svillar on
        #webkit).

        * platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
        * platform/gtk/accessibility/document-reload-events.html: Removed.
2011-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78331.
        http://trac.webkit.org/changeset/78331
        https://bugs.webkit.org/show_bug.cgi?id=54295

        This patch broke 11 tests in GTK bots (Requested by svillar on
        #webkit).

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name):
        (webkit_accessible_detach):
2011-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78331.
        http://trac.webkit.org/changeset/78331
        https://bugs.webkit.org/show_bug.cgi?id=54295

        This patch broke 11 tests in GTK bots (Requested by svillar on
        #webkit).

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::notifyStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 18:42:47 +0000 (18:42 +0000)]
2011-02-11  Martin Robinson  <mrobinson@igalia.com>

        Generate more GTK+ results for many SVG tests missing them.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows XP Debug Tests] media/audio-mpeg4-supported.html timing out since introducti...
jberlin@webkit.org [Fri, 11 Feb 2011 18:21:59 +0000 (18:21 +0000)]
[Windows XP Debug Tests] media/audio-mpeg4-supported.html timing out since introduction in
r76621.
https://bugs.webkit.org/show_bug.cgi?id=54291

Unreviewed, adding this test to the Windows XP skip list in order to get the bots green.

* platform/win-xp/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 11 Feb 2011 18:11:05 +0000 (18:11 +0000)]
2011-02-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GDOM] Video element needs proper wrapping
        https://bugs.webkit.org/show_bug.cgi?id=54231

        Use the same strategy as the one used for the audio tag to wrap
        video as well. No layout tests because this only adds API.

        * bindings/gobject/GNUmakefile.am:
        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
        (WebKit::createVideoWrapper):
        (WebKit::createHTMLElementWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 11 Feb 2011 18:00:31 +0000 (18:00 +0000)]
2011-02-11  Dirk Schulze  <krit@webkit.org>

        Reviewed by Andreas Kling.

        SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual)
        https://bugs.webkit.org/show_bug.cgi?id=54259

        Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to
        avoid overloading a virtual function.

        No change of functionality. Just fixing a build warning, so no new tests.

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap):
        * svg/SVGGradientElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
        * svg/SVGMissingGlyphElement.cpp:
        (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap):
        * svg/SVGStyledElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap):
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap):
        * svg/SVGTextContentElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
        * svg/SVGTextPositioningElement.h:
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed.
jberlin@webkit.org [Fri, 11 Feb 2011 17:54:02 +0000 (17:54 +0000)]
Add Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

* platform/win-xp/fast/dom: Added.
* platform/win-xp/fast/dom/52776-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 17:43:18 +0000 (17:43 +0000)]
2011-02-11  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
        https://bugs.webkit.org/show_bug.cgi?id=54089

        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.show.animationFinished):
        (WebInspector.Drawer.prototype.show):
        (WebInspector.Drawer.prototype.hide):
        (WebInspector.Drawer.prototype.resize):
        (WebInspector.Drawer.prototype.immediatelyFinishAnimation):
        (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
        (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
        (WebInspector.Drawer.prototype._animateDrawerHeight):
        (WebInspector.Drawer.prototype._statusBarDragging):
        * inspector/front-end/inspector.js:
        (WebInspector.animateStyle):
        (WebInspector.animateStyle.forceComplete):
        (WebInspector.animateStyle.cancel):
        (WebInspector.showSourceLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 11 Feb 2011 17:28:06 +0000 (17:28 +0000)]
2011-02-10  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Make DocumentWriter a member of DocumentLoader
        instead of FrameLoader.
        https://bugs.webkit.org/show_bug.cgi?id=50489

        Refactor, no new tests.

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::explicitClose):
        (WebCore::Document::lastModified):
        (WebCore::Document::initSecurityContext):
        (WebCore::Document::updateURLForPushOrReplaceState):
        * dom/Document.h:
        (WebCore::Document::setDocumentLoader):
        (WebCore::Document::loader):
        * html/MediaDocument.cpp:
        (WebCore::MediaDocument::replaceMediaElementTimerFired):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::createDocumentStructure):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::commitData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::setFrame):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::writer):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::begin):
        * loader/DocumentWriter.h:
        (WebCore::DocumentWriter::setFrame):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::init):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::notifier):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 11 Feb 2011 17:16:43 +0000 (17:16 +0000)]
2011-02-11  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Added two tests to the skipped file that started to fail only in
        64-bit debug bot. Rounding issues are most likely the source of
        differences between 32 and 64bit bots.

        * platform/gtk/Skipped: added
        svg/W3C-SVG-1.1-SE/types-dom-02-f.svg and
        svg/W3C-SVG-1.1-SE/types-dom-05-b.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Mads Ager <ager@chromium.org>
ager@chromium.org [Fri, 11 Feb 2011 16:36:47 +0000 (16:36 +0000)]
2011-02-11  Mads Ager  <ager@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove unnecessary chromium layout test rebaselines
        https://bugs.webkit.org/show_bug.cgi?id=54278

        * platform/chromium/fast/js/ToNumber-expected.txt: Removed.
        * platform/chromium/fast/js/parseFloat-expected.txt: Removed.
        * platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Feb 2011 16:24:06 +0000 (16:24 +0000)]
2011-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: unflake inspector test (2).

        * inspector/command-line-api.html:
        * inspector/elements-tests2.js:
        (initialize_ElementTest.InspectorTest.selectElementAndRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Feb 2011 15:47:36 +0000 (15:47 +0000)]
2011-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: unflake inspector test.

        * inspector/command-line-api-expected.txt:
        * inspector/command-line-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html,
jberlin@webkit.org [Fri, 11 Feb 2011 15:42:29 +0000 (15:42 +0000)]
[Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html,
fast/js/global-function-resolve.html,
fast/js/var-declarations-shadowing.html,
and security/crypto-random-values.html failing since r78321.
https://bugs.webkit.org/show_bug.cgi?id=54285

Unreviewed, landing expected failing results to get the bots green.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/js/global-function-resolve-expected.txt: Added.
* platform/win/fast/js/var-declarations-shadowing-expected.txt: Added.
* platform/win/security: Added.
* platform/win/security/crypto-random-values-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Feb 2011 15:23:26 +0000 (15:23 +0000)]
2011-02-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
        https://bugs.webkit.org/show_bug.cgi?id=54227

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        (WebCore::InspectorAgent::loadEventFired):
        (WebCore::InspectorAgent::startTimelineProfiler):
        (WebCore::InspectorAgent::stopTimelineProfiler):
        * inspector/InspectorAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::startListening):
        (WebCore::InspectorDOMAgent::stopListening):
        (WebCore::InspectorDOMAgent::mainDOMContentLoaded):
        (WebCore::InspectorDOMAgent::loadEventFired):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
        * inspector/InspectorDOMStorageAgent.h:
        (WebCore::InspectorDOMStorageAgent::create):
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseAgent.cpp:
        (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
        (WebCore::InspectorDatabaseAgent::executeSQL):
        (WebCore::InspectorDatabaseAgent::selectDatabase):
        (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
        * inspector/InspectorDatabaseAgent.h:
        (WebCore::InspectorDatabaseAgent::FrontendProvider::create):
        (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider):
        (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
        (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend):
        (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
        (WebCore::InspectorDatabaseAgent::create):
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
        (WebCore::InspectorInstrumentation::loadEventFiredImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
        (WebCore::InspectorInstrumentation::loadEventFired):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        (WebCore::InspectorState::mute):
        (WebCore::InspectorState::updateCookie):
        * inspector/InspectorState.h:
        (WebCore::InspectorState::~InspectorState):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::restore):
        (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
        (WebCore::InspectorTimelineAgent::didCommitLoad):
        (WebCore::InspectorTimelineAgent::setFrontend):
        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::create):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Feb 2011 14:54:57 +0000 (14:54 +0000)]
2011-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: command line API $0 regressed.
        https://bugs.webkit.org/show_bug.cgi?id=54283

        * inspector/command-line-api-expected.txt:
        * inspector/command-line-api.html:
2011-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: command line API $0 regressed.
        https://bugs.webkit.org/show_bug.cgi?id=54283

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Increase the timeout of Qt API tests to 120 seconds.
ossy@webkit.org [Fri, 11 Feb 2011 14:21:00 +0000 (14:21 +0000)]
[Qt] Increase the timeout of Qt API tests to 120 seconds.

Reviewed by Andreas Kling.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 13:25:11 +0000 (13:25 +0000)]
2011-02-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Andreas Kling.

        CryptographicRandomNumber has its threading ifdefs backwards
        https://bugs.webkit.org/show_bug.cgi?id=54280

        Turns out we want the mutex when thread is enabled.  :)

        * wtf/CryptographicallyRandomNumber.cpp:
        (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
        (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 13:19:35 +0000 (13:19 +0000)]
2011-02-11  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Andreas Kling.

        [Qt][S60] Vertical borders of buttons and frames are misaligned
        https://bugs.webkit.org/show_bug.cgi?id=51169

        Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
        OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
        without anti-aliasing. Patch idea by Laszlo Agocs.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 11 Feb 2011 12:53:43 +0000 (12:53 +0000)]
2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] events missing when a document is (re)loaded
        https://bugs.webkit.org/show_bug.cgi?id=25831

        Added new layout test to check the right signals are emitted.

        * platform/gtk/accessibility/document-reload-events-expected.txt: Added.
        * platform/gtk/accessibility/document-reload-events.html: Added.
2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] events missing when a document is (re)loaded
        https://bugs.webkit.org/show_bug.cgi?id=25831

        Make sure webArea returns a proper name and that a signal
        'state-change::defunct' is emitted when detaching the wrapper.

        Test: platform/gtk/accessibility/document-reload-events.html

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name): Returns the current document's title
        as fallback mechanism for webArea objects.
        (webkit_accessible_detach): Emit 'state-change::defunct' function
        as soon as the wrapper is detached from the related core object.
2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] events missing when a document is (re)loaded
        https://bugs.webkit.org/show_bug.cgi?id=25831

        Emit the right signals when reloading a document.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::notifyAccessibilityStatus): New function, to make sure
        the signals involved in reloading a document are properly emitted.
        (WebKit::notifyStatus): Also notify accessibility if enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 11:19:08 +0000 (11:19 +0000)]
2011-02-11  Adam Barth  <abarth@webkit.org>

        Turns out that expectation isn't Qt specific.

        * http/tests/security/cross-frame-access-put-expected.txt:
        * platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 10:53:18 +0000 (10:53 +0000)]
2011-02-11  Adam Barth  <abarth@webkit.org>

        Update Qt expected results for window.crypto.

        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Feb 2011 10:50:57 +0000 (10:50 +0000)]
2011-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: command line's API inspect() is broken.
        https://bugs.webkit.org/show_bug.cgi?id=54275

        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
        * inspector/command-line-api-expected.txt: Added.
        * inspector/command-line-api.html: Added.
2011-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: command line's API inspect() is broken.
        https://bugs.webkit.org/show_bug.cgi?id=54275

        Test: inspector/command-line-api.html

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 10:31:24 +0000 (10:31 +0000)]
2011-02-11  Adam Barth  <abarth@webkit.org>

        Turns out window.crypto is supposed to be readonly.

        * page/DOMWindow.idl:
2011-02-11  Adam Barth  <abarth@webkit.org>

        Update test expectations to show window.crypto.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 11 Feb 2011 10:10:39 +0000 (10:10 +0000)]
2011-02-11  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Added new test expectations for the GTK port.

        * platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added.
        * platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added.
        * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
        * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 09:34:23 +0000 (09:34 +0000)]
2011-02-11  Adam Barth  <abarth@webkit.org>

        Actually add Crypto.cpp to the Windows build.  I'm terrible.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo
abarth@webkit.org [Fri, 11 Feb 2011 09:21:49 +0000 (09:21 +0000)]
Fix typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 09:12:41 +0000 (09:12 +0000)]
2011-02-11  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Windows build.  Apparently we don't support
        conditional attributes on functions.  This patch makes the whole Crypto
        interface conditional on ArrayBuffer support.

        * page/DOMWindow.idl:
        * page/Crypto.cpp:
        * page/Crypto.h:
        * page/Crypto.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable ancestor identifier filtering for tree building
antti@apple.com [Fri, 11 Feb 2011 08:57:40 +0000 (08:57 +0000)]
Enable ancestor identifier filtering for tree building
https://bugs.webkit.org/show_bug.cgi?id=54241

Reviewed by Dave Hyatt.

Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
element stack as needed.

This roughly halves the remaining time in style matching over a typical page load.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentStackFrame):
(WebCore::CSSStyleSelector::popParentStackFrame):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
* dom/Document.h:
(WebCore::Document::styleSelectorIfExists):
* dom/Element.cpp:
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
* dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Feb 2011 08:37:36 +0000 (08:37 +0000)]
2011-02-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebKit should have a cryptographic RNG
        https://bugs.webkit.org/show_bug.cgi?id=22049

        Test crypto.getRandomValues API.  It's pretty hard to write a
        deterministic API for a randomized API, but this test should catch some
        regressions.

        * security/crypto-random-values-expected.txt: Added.
        * security/crypto-random-values.html: Added.
2011-02-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebKit should have a cryptographic RNG
        https://bugs.webkit.org/show_bug.cgi?id=22049

        Teach JavaScriptCore how to export this function.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
2011-02-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebKit should have a cryptographic RNG
        https://bugs.webkit.org/show_bug.cgi?id=22049

        Add crypto.getRandomValues.  Yes, all these diffs are required to
        expose a single function to the DOM.

        Test: security/crypto-random-values.html

        * Android.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * config.h:
        * page/Crypto.cpp: Added.
        (WebCore::Crypto::Crypto):
        (WebCore::Crypto::getRandomValues):
        * page/Crypto.h: Added.
        (WebCore::Crypto::create):
        * page/Crypto.idl: Added.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::crypto):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalCrypto):
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 08:26:03 +0000 (08:26 +0000)]
2011-02-11  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix.

        [GTK] Build break with 2.18.3
        https://bugs.webkit.org/show_bug.cgi?id=54057

        * platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-11 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Fri, 11 Feb 2011 08:14:07 +0000 (08:14 +0000)]
2011-02-11  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Adam Barth.

        Templatize KURLGooglePrivate::init
        https://bugs.webkit.org/show_bug.cgi?id=53749

        No new tests. Refactoring.

        * platform/KURLGoogle.cpp:
        (WebCore::KURLGooglePrivate::init):
        * platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 11 Feb 2011 07:36:30 +0000 (07:36 +0000)]
2011-02-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Temporarily skip a test that fails in WebKit2 due to a recent regression
        https://bugs.webkit.org/show_bug.cgi?id=54276

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 11 Feb 2011 07:21:54 +0000 (07:21 +0000)]
2011-02-10  Andy Estes  <aestes@apple.com>

        Reviewed by Eric Seidel.

        Convert ContainerNode::firstElementChild() to a free function.
        https://bugs.webkit.org/show_bug.cgi?id=54269

        No new tests. No change in behavior.

        It seemed incorrect to have a method on ContainerNode that had the
        concept of an Element but couldn't return an Element*, but a method on
        Element could not be called by holders of ContainerNodes or other
        non-Element ContainerNode subclasses. A free function can both return
        an Element* and be called by anyone with a ContainerNode*.

        * dom/ContainerNode.h:
        (WebCore::ContainerNode::lastChild):
        (WebCore::Node::lastChild):
        * dom/Document.cpp:
        (WebCore::Document::cacheDocumentElement):
        * dom/Element.cpp:
        (WebCore::Element::firstElementChild):
        * dom/Element.h:
        (WebCore::firstElementChild):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Mads Ager <ager@chromium.org>
ager@chromium.org [Fri, 11 Feb 2011 06:50:38 +0000 (06:50 +0000)]
2011-02-10  Mads Ager  <ager@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Don't crash on exception getting event handler function
        https://bugs.webkit.org/show_bug.cgi?id=54216

        Check for exceptions when attempting to get the handleEvent property
        of an event-handler object.

        Test: fast/dom/exception-getting-event-handler.html

        * bindings/v8/V8EventListener.cpp:
        (WebCore::V8EventListener::getListenerFunction):
2011-02-10  Mads Ager  <ager@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Don't crash on exception getting event handler function
        https://bugs.webkit.org/show_bug.cgi?id=54216

        Add crash regression test with custom chromium expectations.

        * fast/dom/exception-getting-event-handler-expected.txt: Added.
        * fast/dom/exception-getting-event-handler.html: Added.
        * platform/chromium/fast/dom/exception-getting-event-handler-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 11 Feb 2011 06:38:37 +0000 (06:38 +0000)]
2011-02-10  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by James Robinson.

        [Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
        https://bugs.webkit.org/show_bug.cgi?id=53857

        This fix is for 2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. Add 2d.composite.globalAlpha.fillPath.html as a new test for the combination with globalAlpha and fillPath().

        * fast/canvas/2d.composite.globalAlpha.fillPath-expected.txt: Added.
        * fast/canvas/2d.composite.globalAlpha.fillPath.html: Added.
2011-02-10  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by James Robinson.

        [Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
        https://bugs.webkit.org/show_bug.cgi?id=53857

        globalAlpha is not applied to fillPath() and fillRect().

        Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called.
        (WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor.
        (WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 11 Feb 2011 06:35:18 +0000 (06:35 +0000)]
2011-02-10  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Remove an unneeded argument from HTMLDocument::create().
        https://bugs.webkit.org/show_bug.cgi?id=54268

        Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for
        fragment parsing, there isn't a need to explicitly specify a baseURL
        when constructing an HTMLDocument. We can remove the unneeded argument.

        Also fix some style issues in Document.h and HTMLDocument.h caught by
        check-webkit-style.

        No new tests. No change in behavior.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::HTMLDocument):
        * html/HTMLDocument.h:
        (WebCore::HTMLDocument::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 06:17:57 +0000 (06:17 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Clean up the skipped list and skip some tests that show differences
        between the bots. Rebaseline Acid2 tests results.

        * platform/gtk/Skipped: Clean up the skipped list. Skip failing test.
        * platform/gtk/http/tests/misc/acid2-expected.txt:
        * platform/gtk/http/tests/misc/acid2-pixel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 11 Feb 2011 05:34:15 +0000 (05:34 +0000)]
2011-02-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more encapsulation for MarkedBlock: Made all constants private
        so clients don't know whether allocations are fixed-sized or not
        https://bugs.webkit.org/show_bug.cgi?id=54270

        SunSpider reports no change.

        * runtime/CollectorHeapIterator.h:
        (JSC::CollectorHeapIterator::advance): Updated for removal of HeapConstants.

        * runtime/Error.cpp: Switched to using ASSERT_CLASS_FITS_IN_CELL, like
        all other classes.

        * runtime/Heap.cpp:
        (JSC::Heap::allocate): Updated for removal of HeapConstants.
        (JSC::Heap::reset): Updated to use size(), instead of calculating size
        on our own.

        * runtime/Heap.h: Moved the ASSERT here to MarkedBlock, since it enforces
        on special knowledge of fixed-sizery, which only MarkedBlock is supposed
        to know about.

        * runtime/JSCell.h:
        (JSC::JSCell::MarkedBlock::allocate): Updated for removal of HeapConstants.
        Also changed to reset nextCell to 0 at the end of a block, since that
        seems more consistent.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs): Changed to use a fixed array of char.
        This hard-coded size is a little wonky, but the compiler will tell us
        if it's ever wrong, so I think it's OK.

        * runtime/MarkedBlock.cpp:
        (JSC::MarkedBlock::destroy):
        (JSC::MarkedBlock::MarkedBlock):
        (JSC::MarkedBlock::sweep): Updated for removal of HeapConstants.

        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::isEmpty):
        (JSC::MarkedBlock::clearMarks):
        (JSC::MarkedBlock::size):
        (JSC::MarkedBlock::capacity): Made constants private to this class.
        Removed HeapConstants. Added size() and capacity() functions.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::objectCount):
        (JSC::MarkedSpace::size):
        (JSC::MarkedSpace::capacity):
        * runtime/MarkedSpace.h: Use MarkedBlock helper functions instead of
        direct knowledge of MarkedBlock internals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Feb 2011 05:14:36 +0000 (05:14 +0000)]
2011-02-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        remove extra space from expansion lines
        https://bugs.webkit.org/show_bug.cgi?id=54266

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Feb 2011 05:12:02 +0000 (05:12 +0000)]
2011-02-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        only erase draft comments after publish is successful
        https://bugs.webkit.org/show_bug.cgi?id=54163

        If there is a conflict or 500, then draft comments will survive.
        One drawback here is that the form post is now to the iframe,
        so to break out of the iframe we redirect to the bug page, which
        loses the information of who the email was sent to.

        Once WebKit supports seamless iframes we should be able to avoid
        the redirect.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 05:07:55 +0000 (05:07 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, fix a typo.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 04:41:56 +0000 (04:41 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 04:24:33 +0000 (04:24 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 04:19:54 +0000 (04:19 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 03:55:25 +0000 (03:55 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 03:32:01 +0000 (03:32 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 11 Feb 2011 03:23:55 +0000 (03:23 +0000)]
2011-02-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more encapsulation for MarkedBlock: Made mark bits private
        https://bugs.webkit.org/show_bug.cgi?id=54264

        SunSpider reports no change.

        * runtime/Heap.cpp:
        (JSC::Heap::markRoots):
        (JSC::Heap::reset): Renamed clearMarkBits => clearMarks, since clients
        don't need to know that marks are represented as bits. Renamed
        markedCells => markCount, since clients don't need to know that blocks
        are split into cells.

        * runtime/MarkedBlock.h:
        (JSC::MarkedBlock::isEmpty):
        (JSC::MarkedBlock::clearMarks):
        (JSC::MarkedBlock::markCount): New helper functions for encapsulating
        the information clients actually need.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::destroy):
        (JSC::MarkedSpace::shrink):
        (JSC::MarkedSpace::clearMarks):
        (JSC::MarkedSpace::markCount):
        (JSC::MarkedSpace::objectCount):
        * runtime/MarkedSpace.h: Use new helper functions instead of accessing
        MarkedBlock data directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 11 Feb 2011 03:18:17 +0000 (03:18 +0000)]
2011-02-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        This patch adds the bulk of the remaining functionality for
        the NRWT message-passing implementation. The patch adds a new
        Worker class that will eventually replace the TestShellThread
        class in dump_render_tree_thread.py, and implements enough of
        TestRunner2 and the inline version of the manager_worker_broker
        to actually be able to send a full set of messages back and
        forth. The Worker stubs do not actually run tests, and there's
        lots of error handling and stats needed, but this is the core
        logic.

        https://bugs.webkit.org/show_bug.cgi?id=54068

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Fri, 11 Feb 2011 03:04:20 +0000 (03:04 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 11 Feb 2011 02:57:44 +0000 (02:57 +0000)]
2011-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Repro crash with Sony Google TV ad at Gizmodo
        https://bugs.webkit.org/show_bug.cgi?id=54150
        <rdar://problem/8782346>

        Re-landing this fix, bug without the test case, since it causes hangs on the bots.
        https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding back the test.

        Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::~PluginView):
        Null out m_pluginElement here so we'll catch crashes earlier.

        (WebKit::PluginView::evaluate):
        Add a plug-in protector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 02:24:32 +0000 (02:24 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 11 Feb 2011 02:10:16 +0000 (02:10 +0000)]
2011-02-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Cached JavaScript Parser Data Being Left in Memory Cache
        https://bugs.webkit.org/show_bug.cgi?id=54245

        Added clear method which removes SourceProviderCache items.
        Cleaned up extraneous whitespace.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * parser/SourceProviderCache.cpp:
        (JSC::SourceProviderCache::~SourceProviderCache):
        (JSC::SourceProviderCache::clear):
        (JSC::SourceProviderCache::byteSize):
        (JSC::SourceProviderCache::add):
        * parser/SourceProviderCache.h:
2011-02-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Cached JavaScript Parser Data Being Left in Memory Cache
        https://bugs.webkit.org/show_bug.cgi?id=54245

        Added logic in CachedScript to clear SourceProviderCache data in
        destroyDecodedData().  Added and changed CachedScript timeout to
        act similar to CachedImage.  Changed didAddClient to call super
        class method instead of duplicating the logic in the derived
        classes.

        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::didAddClient):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::didAddClient):
        (WebCore::CachedScript::allClientsRemoved):
        (WebCore::CachedScript::script):
        (WebCore::CachedScript::destroyDecodedData):
        * loader/cache/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 02:06:21 +0000 (02:06 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 01:45:37 +0000 (01:45 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, attempt to fix crashing plugin tests.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 11 Feb 2011 01:26:40 +0000 (01:26 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, build fix.

        * DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix style in KURLGooglePrivate
bdakin@apple.com [Fri, 11 Feb 2011 01:23:21 +0000 (01:23 +0000)]
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228

Patch by Cosmin Truta <ctruta@chromium.org> on 2011-02-10
Reviewed by David Levin.

Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.

No new tests. This is a style fix.

* platform/KURLGoogle.cpp:
* platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 11 Feb 2011 01:16:32 +0000 (01:16 +0000)]
2011-02-10  Joseph Pecoraro  <joepeck@webkit.org>

        Follow-up fix to r78291. I should pass (int) 0, not '0' to memset.

        * runtime/GCActivityCallbackCF.cpp:
        (JSC::DefaultGCActivityCallback::commonConstructor): fix mistaken post-review change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 11 Feb 2011 01:09:34 +0000 (01:09 +0000)]
2011-02-10  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Geoffrey Garen.

        Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass
        https://bugs.webkit.org/show_bug.cgi?id=54257

        A subclass may want to specify the CFRunLoop that the Garbage Collection
        will happen on. It was difficult to manipulate this in a subclass because
        the current DefaultGCActivityCallback class does this in its constructor.
        This patch generalizes things a bit more so that a specific run loop can
        be passed in to the constructor. This makes it so all run loop management
        can stay in DefaultGCActivityCallback and a subclass can specify any runloop.

        * runtime/GCActivityCallback.h: expose a PLATFORM(CF) constructor that can
        specify the runloop GC can be scheduled on.
        * runtime/GCActivityCallbackCF.cpp:
        (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback): two constructors,
        one that specifies the run loop and passes that on to commonConstructor and
        the old constructor defaults to the current run loop.
        (JSC::DefaultGCActivityCallback::commonConstructor): do normal construction,
        adding the timer to the given runloop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Feb 2011 01:03:20 +0000 (01:03 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Generate GTK+ results for many SVG tests missing them.

        * platform/gtk/Skipped: Unskip tests which now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Fri, 11 Feb 2011 01:01:30 +0000 (01:01 +0000)]
2011-02-10  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by David Levin.

        Fix style in KURLGooglePrivate
        https://bugs.webkit.org/show_bug.cgi?id=54228

        Replace occurrences of NULL with 0, '\0' or null (as applicable),
        to appease check-webkit-style.

        No new tests. This is a style fix.

        * platform/KURLGoogle.cpp:
        * platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
alice.liu@apple.com [Fri, 11 Feb 2011 00:56:24 +0000 (00:56 +0000)]
WebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=54254

Reviewed by Enrica Casucci and Adele Peterson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _handleStyleKeyEquivalent:]):
Return early if we're not in an editable region.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry and fix some crashing tests on the chromium build bot.
weinig@apple.com [Fri, 11 Feb 2011 00:50:31 +0000 (00:50 +0000)]
Try and fix some crashing tests on the chromium build bot.

* DumpRenderTree/DumpRenderTree.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Andy Estes <aestes@apple.com>
aestes@apple.com [Fri, 11 Feb 2011 00:45:11 +0000 (00:45 +0000)]
2011-02-10  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        The HTML5 fragment parsing algorithm specifies that a new Document
        should be created to serve as the temporary parent of fragment nodes
        during parsing. Document creation is expensive and accounts for ~38% of
        the Peacekeeper DOM performance regression. Avoid the cost of creating
        a dummy document by using the already-created DocumentFragment as the
        root node during fragment parsing.

        With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
        is ~24%.

        Test: fast/parser/fragment-parser-doctype.html

        * dom/ContainerNode.h:
        (WebCore::ContainerNode::firstElementChild): Add a method that returns
        the first element-typed child from a ContainerNode.
        * dom/Document.cpp:
        (WebCore::Document::cacheDocumentElement): Call
        ContainerNode::firstElementChild() to retrieve and cache the document
        element.
        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the
        root ContainerNode.
        (WebCore::HTMLConstructionSite::detach): Clear the reference to the
        root ContainerNode.
        (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
        Attach the new element to the root ContainerNode.
        (WebCore::HTMLConstructionSite::insertDoctype): Ditto.
        (WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto.
        * html/parser/HTMLConstructionSite.h: Store a pointer to a
        ContainerNode that will be used as the root node for document parsing.
        This node might or might not be the same as m_document.
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the
        HTMLConstructionSite with the correct root ContainerNode based on
        whether or not we're parsing a fragment.
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
        Remove m_dummyDocumentForFragmentParsing.
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the
        fragment has a context element, store only the children of the root
        element (HTML5 Section 10.4, Step 7).
        * html/parser/HTMLTreeBuilder.h:
2011-02-09  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
        https://bugs.webkit.org/show_bug.cgi?id=48719

        * fast/parser/fragment-parser-doctype-expected.txt: Added.
        * fast/parser/fragment-parser-doctype.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative fix for <rdar://problem/8985232> Overlay
bdakin@apple.com [Fri, 11 Feb 2011 00:32:32 +0000 (00:32 +0000)]
Speculative fix for <rdar://problem/8985232> Overlay
scrollers can appear on the sliding page during
back/forward fluid gesture

Reviewed by Oliver Hunt.

* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 11 Feb 2011 00:20:17 +0000 (00:20 +0000)]
2011-02-10  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A little more encapsulation for MarkedBlock: Moved allocate() and sweep() into MarkedBlock
        https://bugs.webkit.org/show_bug.cgi?id=54253

        SunSpider reports no change.

        * runtime/CollectorHeapIterator.h: Removed DeadObjectIterator, since it
        is now unused.

        * runtime/Heap.cpp:
        (JSC::Heap::reset): Moved the call to shrink() here, since it seems a
        little more clear for MarkedSpace's client to tell it explicitly when to
        shrink.

        * runtime/JSCell.h:
        (JSC::JSCell::MarkedBlock::allocate): Split out from MarkedSpace::allocate.

        * runtime/MarkedBlock.cpp:
        (JSC::MarkedBlock::sweep): Split out from MarkedSpace::sweep, and
        converted to more directly iterate a MarkedBlock based on knowing its
        internal structure.

        * runtime/MarkedBlock.h:
        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::sweep):
        * runtime/MarkedSpace.h: Split out the code mentioned above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Feb 2011 00:14:37 +0000 (00:14 +0000)]
2011-02-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        save overall comments when saving drafts in the review tool
        https://bugs.webkit.org/show_bug.cgi?id=54165

        -save overall comments in localstorage as well
        -save all draft comments as you type
        -give a *subtle* indicator of saved state

        The latter should also make it super easy if someone wanted to do
        the work to store draft comments in appengine/s3/bugzilla/etc.

        * PrettyPatch/PrettyPatch.rb:
        * code-review-test.html:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 23:58:13 +0000 (23:58 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 10 Feb 2011 23:51:41 +0000 (23:51 +0000)]
2011-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Log an error if a plug-in test can't be found
        https://bugs.webkit.org/show_bug.cgi?id=54252

        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
        (PluginTest::create):
        Return null if the test wasn't found.

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):
        Report an error if PluginTest::create returns null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-09 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 10 Feb 2011 23:49:18 +0000 (23:49 +0000)]
2011-02-09  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        IndexedDB event targets need to ensure their wrappers aren't garbage collected
        https://bugs.webkit.org/show_bug.cgi?id=54144

        hasActivityPending should return true as long as it's possible that we'll
        fire more event listeners on our event targets. It is still possible for
        user generated events to run into problems, but I'm not sure how to address
        that yet (or how big of a deal it is).

        There's really no way to test this deterministically. Testing by hand makes
        it seem like this patch works as expected though.

        * storage/IDBCursorBackendImpl.cpp:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::IDBDatabase):
        (WebCore::IDBDatabase::~IDBDatabase):
        (WebCore::IDBDatabase::hasPendingActivity):
        (WebCore::IDBDatabase::stop):
        * storage/IDBDatabase.h:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::hasPendingActivity):
        (WebCore::IDBRequest::dispatchEvent):
        (WebCore::IDBRequest::enqueueEvent):
        * storage/IDBRequest.h:
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::finished):
        (WebCore::IDBTransaction::hasPendingActivity):
        (WebCore::IDBTransaction::dispatchEvent):
        (WebCore::IDBTransaction::canSuspend):
        (WebCore::IDBTransaction::contextDestroyed):
        (WebCore::IDBTransaction::enqueueEvent):
        * storage/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 23:29:10 +0000 (23:29 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Add results for HTTP tests missing GTK+ results.

        * platform/gtk/Skipped: Unskip HTTP tests that now have results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 10 Feb 2011 23:26:37 +0000 (23:26 +0000)]
2011-02-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Fix compilation error on OpenBSD
        https://bugs.webkit.org/show_bug.cgi?id=53766

        Add a HAVE_STRNSTR in Platform.h and define it only on Darwin and FreeBSD.

        * wtf/Platform.h:
        * wtf/StringExtras.h: Use HAVE(STRNSTR) now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 23:23:34 +0000 (23:23 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, tiny test fix from cira.

        Excluding v8Locale from property-inheritance test
        https://bugs.webkit.org/show_bug.cgi?id=54250

        * fast/dom/script-tests/prototype-inheritance.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Feb 2011 23:03:19 +0000 (23:03 +0000)]
2011-02-10  Martin Robinson  <mrobinson@igalia.com>

        Unskip some GTK+ HTTP tests that are passing locally. All the bots
        should have the same libsoup version now.

        * platform/gtk/Skipped: Unskip some passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 22:58:10 +0000 (22:58 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 10 Feb 2011 22:57:18 +0000 (22:57 +0000)]
2011-02-10  Andreas Kling  <kling@webkit.org>

        Unreviewed Qt build fix.

        waitFor() -> deprecatedWaitFor()

        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:54:20 +0000 (22:54 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] create pkg-config files for mingw
        https://bugs.webkit.org/show_bug.cgi?id=54238

        (mingw is mostly the same as unix)

        This change was applied in the Qt repository (qt/src/3rdparty/webkit),
        so we should do the same here in QtWebKit.

        Patch by Mark Brand <mabrand@mabrand.nl>, reviewed (there) by
        Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
        45fe2dddc3a0677b9ec9fce09f07cd4129e37afa

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 10 Feb 2011 22:52:57 +0000 (22:52 +0000)]
2011-02-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform
        https://bugs.webkit.org/show_bug.cgi?id=54246

        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 10 Feb 2011 22:45:04 +0000 (22:45 +0000)]
2011-02-10  Dirk Schulze  <krit@webkit.org>

        Reviewed by Andreas Kling.

        SVG animation avoid unnecessary adjust for currentColor
        https://bugs.webkit.org/show_bug.cgi?id=54243

        At the moment we try to adjust every animation value for currentColor - independent of the animation type.
        Since the value is a string and the target element may needs to get called by getElementById, this could
        be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back
        as a string and parse it to Color afterwards again.
        With the patch we just adjust an animation value, if we use color animation. The color won't get saved and
        parsed as a string again.

        No change of functionality, no new tests.

        * svg/SVGAnimateElement.cpp:
        (WebCore::adjustForCurrentColor):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::startedActiveInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:32:06 +0000 (22:32 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Ensure WebView press delay timer is cancelled when grab is taken
        https://bugs.webkit.org/show_bug.cgi?id=54242

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-15529

        Flickable steals the grab, but the timer was not stopped and the
        keepGrab flag is set and the mouse grabbed. This means that the WebView
        now has the grab and subsequent clicks on another element are ignored.

        Original patch from Martin Jones <martin.jones@nokia.com>
        reviewed (there) by Joona Petrell
        52068f57f9c32098a90cc217730a530f85590f65

        * declarative/qdeclarativewebview.cpp:
        (GraphicsWebView::sceneEvent):
        * declarative/qdeclarativewebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:17:28 +0000 (22:17 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix assert in QDeclarativeWebView
        https://bugs.webkit.org/show_bug.cgi?id=54240

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-14278

        Instantiating a QDeclarativeWebView twice will trigger an assertion
        when in debug mode.

        Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
        reviewed (there) by Aaron Kennedy
        f532679ca11914b453e22342f2ae5e9f790ce47a

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 22:15:15 +0000 (22:15 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Remove the use of deprecated qFindChildren()
        https://bugs.webkit.org/show_bug.cgi?id=54232

        This was applied on the Qt repository and affects QtWebKit there.
        (13833beb641289c45faed337848d37280195aadc)

        The side effect of this change is that we won't be able to build
        QtWebKit with MSVC 6, as it doesn't support member template functions
        (not sure if that's possible today anyway).

        Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
        review reported as being from the mailing list.

        The changes are result of the following commands:

            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(this,* */f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(&\([^\(),]*\),* */\\2.f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*()\),* */\\2->f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\):\([^\(),]*\),* */(\\2:\\3)->f\\1(/'" qFindChild
            git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\),* */\\2->f\\1(/'" qFindChild

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 21:59:52 +0000 (21:59 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Misc documentation fixes/updates
        https://bugs.webkit.org/show_bug.cgi?id=54236

        There are a few commits in the Qt repository (master and 4.7 branches)
        with QtWebKit documentation fixes:

        84d278501a19eaccf9a77cccd95ca5d17a2dcd2b
        Clarified documentation of loadFinished() signal

        eebe205b306daaa3674d9746de11a73bef4bd0de
        Doc: Fixed QML, unindented snippet

        b0d64717d2c541976dc5524e4100c62f060e206f
        doc: Changed a table into 3 tables to eliminate a \raw.

        As these are all minor doc changes, I decided to group them
        into one single patch.

        * Api/qwebpage.cpp:
        * declarative/qdeclarativewebview.cpp:
        * docs/qtwebkit.qdoc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 21:58:32 +0000 (21:58 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Rename build target from "embedded" to "qpa"
        https://bugs.webkit.org/show_bug.cgi?id=54233

        This flag is used by Qt's configure script to enable a QPA build
        ("QPA is a window system agnostic implementation of Qt" --
        previously known as lighthouse).

        On the Qt repository, this was changed by two commits:

        13a0b4935900093607f2b3b7688e1452d22770fd
        (from embedded to embedded_lite)

        9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab
        (from embedded_lite to qpa)

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 10 Feb 2011 21:49:24 +0000 (21:49 +0000)]
2011-02-10  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Incorporate algorithm for processing paths into GPU-renderable triangle meshes
        https://bugs.webkit.org/show_bug.cgi?id=45521

        Adding an implementation of Loop and Blinn's GPU accelerated path
        rendering algorithm from GPU Gems 3. This implementation pays
        particular attention to the efficiency of the curve subdivision
        phase needed for correct rendering. It utilizes the OpenGL utility
        library tessellator for triangulation of the interior of the
        shape. The regions handled by Loop and Blinn's algorithm are
        handled by the local triangulator previously incorporated.

        No tests yet; pixel tests will eventually be used to verify this
        algorithm and prevent regressions.

        * platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added.
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setup):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::kind):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::next):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::prev):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::contour):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::toString):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::add):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::begin):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::end):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide):
        (WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide):
        (WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate):
        (WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor):
        (WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor):
        (WebCore::LoopBlinnPathProcessor::process):
        (WebCore::LoopBlinnPathProcessor::buildContours):
        (WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY):
        (WebCore::LoopBlinnPathProcessor::determineSidesToFill):
        (WebCore::LoopBlinnPathProcessor::determineOrientation):
        (WebCore::SweepData::SweepEvent::SweepEvent):
        (WebCore::SweepData::SweepEvent::setup):
        (WebCore::SweepData::SweepEvent::x):
        (WebCore::SweepData::SweepEvent::entry):
        (WebCore::SweepData::SweepEvent::interval):
        (WebCore::SweepData::SweepEvent::operator<):
        (WebCore::SweepData::trianglesOverlap):
        (WebCore::LoopBlinnPathProcessor::subdivideCurves):
        (WebCore::LoopBlinnPathProcessor::conditionallySubdivide):
        (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
        (WebCore::TessellationState::vertexCallback):
        (WebCore::TessellationState::combineCallback):
        (WebCore::TessellationState::edgeFlagCallback):
        (WebCore::LoopBlinnPathProcessor::tessellateInterior):
        * platform/graphics/gpu/LoopBlinnPathProcessor.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 10 Feb 2011 21:18:24 +0000 (21:18 +0000)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Remove the use of deprecated qVariant*
        https://bugs.webkit.org/show_bug.cgi?id=54229

        This was applied on the Qt repository and affects QtWebKit there.
        (633f3f45e5420663cf4ceadea79e62fea44cd2eb)

        The side effect of this change is that we won't be able to build
        QtWebKit with MSVC 6, as it doesn't support member template functions
        (not sure if it's possible today anyway).

        Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
        review reported as being from the mailing list.

        The changes are result of the following commands:

            git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
            git grep -O"sed -i 's/qVariantSetValue(\([^&*\(),]*\), */\\1.setValue(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantSetValue *<\([^>]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Remove the use of deprecated qVariant*
        https://bugs.webkit.org/show_bug.cgi?id=54229

        This was applied on the Qt repository and affects QtWebKit there.
        (633f3f45e5420663cf4ceadea79e62fea44cd2eb)

        The side effect of this change is that we won't be able to build
        QtWebKit with MSVC 6, as it doesn't support member template functions
        (not sure if it's possible today anyway).

        Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
        review reported as being from the mailing list.

        The changes are result of the following commands:

            git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
            git grep -O"sed -i 's/qVariantSetValue(\([^&*\(),]*\), */\\1.setValue(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantSetValue *<\([^>]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
            git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::nodesFromRect):
        * tests/qwebframe/tst_qwebframe.cpp:
        (MyQObject::myInvokableWithQObjectListArg):
        (MyQObject::myInvokableWithListOfIntArg):
        (MyQObject::myInvokableWithQObjectStarArg):
        (MyQObject::myInvokableWithQBrushArg):
        (MyQObject::myInvokableWithBrushStyleArg):
        (MyQObject::myInvokableWithVoidStarArg):
        (MyQObject::myInvokableWithAmbiguousArg):
        (MyQObject::myInvokableWithDefaultArgs):
        (MyQObject::myInvokableWithPointArg):
        (MyQObject::myOverloadedSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 10 Feb 2011 21:10:09 +0000 (21:10 +0000)]
2011-02-10  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Removed.
        * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Removed.
        * platform/mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
        * platform/mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78262 268f45cc-cd09-0410-ab3c-d52691b4dbfc