sfalken@apple.com [Thu, 4 Feb 2010 17:56:38 +0000 (17:56 +0000)]
Windows build fix for projects not defining WebKitLibrariesDir.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Thu, 4 Feb 2010 17:43:17 +0000 (17:43 +0000)]
2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Unnecessary QBrush construction for doing a solid fill
https://bugs.webkit.org/show_bug.cgi?id=34559
Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setPlatformFillColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 4 Feb 2010 17:41:58 +0000 (17:41 +0000)]
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371
Reviewed by Simon Fraser.
* platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 4 Feb 2010 17:35:58 +0000 (17:35 +0000)]
REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371
Reviewed by Simon Fraser.
WebCore:
Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.
* WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.
* platform/Scrollbar.h: Replaced scroll amount constants with static methods.
(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.
* platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/haiku/PlatformWheelEventHaiku.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.
WebKit/mac:
* WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.
WebKit/wx:
* WebView.cpp:
(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 16:56:18 +0000 (16:56 +0000)]
2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
https://bugs.webkit.org/show_bug.cgi?id=34062
This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
(WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
(WebCore::OpacityAnimationQt::updateState): style change
2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::update): Moved the sync operation to update
(QGraphicsWebView::paint): Moved the sync operation to update
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 4 Feb 2010 16:39:17 +0000 (16:39 +0000)]
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Cookies for resources are not shown in storage panel.
https://bugs.webkit.org/show_bug.cgi?id=34594
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getCookies):
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::updateScriptObject):
(WebCore::InspectorResource::cachedResource):
* inspector/InspectorResource.h:
(WebCore::InspectorResource::requestURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 4 Feb 2010 14:52:10 +0000 (14:52 +0000)]
2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
Implement a locking and scheduling mechanism for http testing sessions to be able
to run multiple instances of run-webkit-tests parallel on the same machine.
If a test session wants to run http tests and this feature is enabled, the pending
sessions create lockfiles with sequential lock numbers. These locks are used to schedule
the running test sessions in first come first served order. An exclusive lock ensures
that the lock numbers are sequential to avoid deadlocks and starvation.
Because the buildbot master specifies the flags used by slaves we need an environment
variable too to be able to use the feature per-slave.
Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
https://bugs.webkit.org/show_bug.cgi?id=33153
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 12:57:15 +0000 (12:57 +0000)]
2010-02-04 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Remove clear method from DOM object maps
https://bugs.webkit.org/show_bug.cgi?id=34530
No new tests. Should be covered by existent testing infrastructure.
* bindings/v8/DOMData.h:
* bindings/v8/DOMDataStore.h:
* bindings/v8/V8DOMMap.cpp:
* bindings/v8/V8DOMMap.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 11:15:34 +0000 (11:15 +0000)]
2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Increase test coverage for the QScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=34533
* qt/tests/qscriptvalue/qscriptvalue.pro:
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
(tst_QScriptValue::tst_QScriptValue):
(tst_QScriptValue::~tst_QScriptValue):
(tst_QScriptValue::dataHelper):
(tst_QScriptValue::newRow):
(tst_QScriptValue::testHelper):
(tst_QScriptValue::ctor):
* qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added.
(tst_QScriptValue::initScriptValues):
(tst_QScriptValue::isValid_initData):
(tst_QScriptValue::isValid_makeData):
(tst_QScriptValue::isValid_test):
(tst_QScriptValue::isBool_initData):
(tst_QScriptValue::isBool_makeData):
(tst_QScriptValue::isBool_test):
(tst_QScriptValue::isBoolean_initData):
(tst_QScriptValue::isBoolean_makeData):
(tst_QScriptValue::isBoolean_test):
(tst_QScriptValue::isFunction_initData):
(tst_QScriptValue::isFunction_makeData):
(tst_QScriptValue::isFunction_test):
(tst_QScriptValue::isNull_initData):
(tst_QScriptValue::isNull_makeData):
(tst_QScriptValue::isNull_test):
(tst_QScriptValue::isString_initData):
(tst_QScriptValue::isString_makeData):
(tst_QScriptValue::isString_test):
(tst_QScriptValue::isUndefined_initData):
(tst_QScriptValue::isUndefined_makeData):
(tst_QScriptValue::isUndefined_test):
(tst_QScriptValue::isObject_initData):
(tst_QScriptValue::isObject_makeData):
(tst_QScriptValue::isObject_test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 4 Feb 2010 10:55:39 +0000 (10:55 +0000)]
Make run-webkit-tests work under Cygwin for the Qt port
Reviewed by Simon Hausmann.
setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.
This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.
openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.
Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.
https://bugs.webkit.org/show_bug.cgi?id=33895
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 4 Feb 2010 10:50:57 +0000 (10:50 +0000)]
[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281
* platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 4 Feb 2010 10:50:16 +0000 (10:50 +0000)]
[Gtk] Check if the renderer() exists in textForObject.
This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.
In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(textForObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Thu, 4 Feb 2010 10:20:24 +0000 (10:20 +0000)]
2010-02-04 Yuzo Fujishima <yuzo@google.com>
Unreviewed.
Add Yuzo to the committers list.
* Scripts/webkitpy/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 4 Feb 2010 10:06:11 +0000 (10:06 +0000)]
2010-02-04 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Revert 54333 which broke Chromium build.
* WebKit.gyp:
* tests/TransparencyWinTest.cpp: Removed.
* tests/UniscribeHelperTest.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 4 Feb 2010 09:38:40 +0000 (09:38 +0000)]
2010-02-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Provide strongly typed C++ interface for inspector's injected script.
https://bugs.webkit.org/show_bug.cgi?id=33616
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScript.cpp: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::dispatch):
(WebCore::InjectedScript::callFrames):
(WebCore::InjectedScript::wrapAndStringifyForConsole):
(WebCore::InjectedScript::releaseWrapperObjectGroup):
* inspector/InjectedScript.h: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::~InjectedScript):
(WebCore::InjectedScript::hasNoValue):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptForId):
(WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::dispatchOnInjectedScript):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::setFrontendProxyObject):
(WebCore::InspectorController::close):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::didPause):
(WebCore::InspectorController::injectedScriptForNodeId):
* inspector/InspectorController.h:
(WebCore::InspectorController::frontendScriptState):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addConsoleMessage):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 09:16:37 +0000 (09:16 +0000)]
2010-02-04 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
https://bugs.webkit.org/show_bug.cgi?id=34509
* WebKit.gyp:
* tests/TransparencyWinTest.cpp: Added.
(WebCore::RECTToFloatRect):
(WebCore::drawNativeRect):
(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::operator<<):
(WebCore::TEST):
* tests/UniscribeHelperTest.cpp: Added.
(WebCore::UniscribeTest::UniscribeTest):
(WebCore::UniscribeTest::MakeFont):
(WebCore::UniscribeTest::SetUp):
(WebCore::UniscribeTest::TearDown):
(WebCore::TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 4 Feb 2010 09:11:44 +0000 (09:11 +0000)]
2010-02-04 Philippe Normand <pnormand@igalia.com>
Rubber stamped by Xan Lopez.
Missing include, build fix after landing of patch from the bug 34435.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 08:41:50 +0000 (08:41 +0000)]
2010-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by David Levin.
[Chromium] WebKit side of "Writing direction" context menu on OS X.
https://bugs.webkit.org/show_bug.cgi?id=34524
* public/WebContextMenuData.h:
(WebKit::WebContextMenuData::):
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 4 Feb 2010 08:32:14 +0000 (08:32 +0000)]
2010-02-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435
Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent nor Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
* platform/gtk/GOwnPtrGtk.cpp: Added.
(WTF::SoupURI):
(WTF::GstElement):
* platform/gtk/GOwnPtrGtk.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 08:25:25 +0000 (08:25 +0000)]
2010-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
make this code engine-agnostic.
https://bugs.webkit.org/show_bug.cgi?id=34531
* inspector/InjectedScriptHost.cpp:
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
* inspector/InspectorBackend.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::close):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
* inspector/InspectorFrontend.h:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptCallFrame.h:
* inspector/JavaScriptDebugListener.h:
* inspector/JavaScriptDebugServer.cpp:
* inspector/JavaScriptDebugServer.h:
* inspector/JavaScriptProfile.cpp:
* inspector/JavaScriptProfile.h:
* inspector/JavaScriptProfileNode.cpp:
* inspector/JavaScriptProfileNode.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
* page/Page.cpp:
(WebCore::Page::Page):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 4 Feb 2010 07:54:37 +0000 (07:54 +0000)]
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Rubber-stamped by Eric Seidel.
Change "the Chromium name" to "the name of Google Inc." in the licenses
https://bugs.webkit.org/show_bug.cgi?id=34511
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_files.py:
* Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
* Scripts/webkitpy/layout_tests/port/__init__.py:
* Scripts/webkitpy/layout_tests/port/apache_http_server.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/http_server.py:
* Scripts/webkitpy/layout_tests/port/http_server_base.py:
* Scripts/webkitpy/layout_tests/port/path_utils.py:
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 4 Feb 2010 07:51:49 +0000 (07:51 +0000)]
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Rubber-stamped by Eric Siedel.
Rename files as part of refactoring the layout_tests package. All
the platform_utils* module, the path_utils.py module, and
the http server and web socket server modules are moved into a new
port/ package.
https://bugs.webkit.org/show_bug.cgi?id=34511
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_files.py:
* Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
* Scripts/webkitpy/layout_tests/port/__init__.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
* Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
* Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
* Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
* Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
* Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
* Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
* Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
* Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
* Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 07:48:37 +0000 (07:48 +0000)]
2010-02-03 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Defer formatting of times displayed on media controls to the current theme.
https://bugs.webkit.org/show_bug.cgi?id=34405
No new tests needed. Refactoring Only.
* rendering/MediaControlElements.cpp: Removed formatTime()
(WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
* rendering/MediaControlElements.h:
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime): new virtual method
(WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method
(WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
* rendering/RenderTheme.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Thu, 4 Feb 2010 07:30:46 +0000 (07:30 +0000)]
Unreviewed fix.
websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.
* platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Thu, 4 Feb 2010 07:26:28 +0000 (07:26 +0000)]
2010-02-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
navigating a frame to new location closes websocket in the frame
https://bugs.webkit.org/show_bug.cgi?id=34557
* websocket/tests/close-on-navigate-new-location-expected.txt: Added.
* websocket/tests/close-on-navigate-new-location.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 4 Feb 2010 05:52:11 +0000 (05:52 +0000)]
Windows Debug_All build fix.
* platform/graphics/win/WKCACFLayer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 4 Feb 2010 03:57:23 +0000 (03:57 +0000)]
Remove an unnecessary backup file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 4 Feb 2010 03:28:12 +0000 (03:28 +0000)]
REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and https://bugs.webkit.org/show_bug.cgi?id=34550
Reviewed by Alexey Proskuryakov.
WebCore:
Tests: fast/loader/document-with-fragment-url-1.html
fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html
* platform/KURL.cpp:
(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,
any fragment identifier from the absolute URL should be removed from the resulting resolution.
LayoutTests:
* fast/loader/document-with-fragment-url-1-expected.txt: Added.
* fast/loader/document-with-fragment-url-1.html: Added.
* fast/loader/document-with-fragment-url-2-expected.txt: Added.
* fast/loader/document-with-fragment-url-2.html: Added.
* fast/loader/document-with-fragment-url-3-expected.txt: Added.
* fast/loader/document-with-fragment-url-3.html: Added.
* fast/loader/document-with-fragment-url-4-expected.txt: Added.
* fast/loader/document-with-fragment-url-4.html: Added.
* fast/loader/resources/document-with-fragment-url-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 02:49:29 +0000 (02:49 +0000)]
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
https://bugs.webkit.org/show_bug.cgi?id=34514
PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Thu, 4 Feb 2010 02:24:07 +0000 (02:24 +0000)]
2010-02-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket should close the connection when unloading the document
https://bugs.webkit.org/show_bug.cgi?id=33248
* websocket/tests/close-on-unload-expected.txt: Added.
* websocket/tests/close-on-unload.html: Added.
* websocket/tests/close-on-unload_wsh.py: Added.
* websocket/tests/resources/close-on-unload-iframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 4 Feb 2010 02:23:13 +0000 (02:23 +0000)]
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port TextBreakIteratorInternalICU
https://bugs.webkit.org/show_bug.cgi?id=34515
Port TextBreakIteratorInternalICU.
* platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added.
(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Thu, 4 Feb 2010 01:52:15 +0000 (01:52 +0000)]
WebCore: Fix for <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319
Reviewed by Simon Fraser.
Test: fast/css/counters/counter-before-selector-crash.html
* rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.
LayoutTests: Test for: <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319
Reviewed by Simon Fraser.
* fast/css/counters/counter-before-selector-crash-expected.txt: Added.
* fast/css/counters/counter-before-selector-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Thu, 4 Feb 2010 01:32:32 +0000 (01:32 +0000)]
Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.
Reviewed by Brady Eidson.
* page/PageGroup.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 4 Feb 2010 01:07:11 +0000 (01:07 +0000)]
Rubber-stamped by Eric Seidel.
Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399
* Scripts/run-iexploder-tests:
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
* Scripts/webkitperl/httpd.pm: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Thu, 4 Feb 2010 00:50:08 +0000 (00:50 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized
Reviewed by Brady Eidson.
For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.
* page/PageGroup.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 4 Feb 2010 00:32:28 +0000 (00:32 +0000)]
Rubber-stamped by Eric Seidel.
Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
* Scripts/run-iexploder-tests:
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
* Scripts/webkitperl/httpd.pm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 4 Feb 2010 00:26:00 +0000 (00:26 +0000)]
<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546
Reviewed by Simon Fraser.
* manual-tests/drag-image-table-part-decorations.html: Added.
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 3 Feb 2010 23:47:09 +0000 (23:47 +0000)]
Reviewed by Kevin Ollivier.
Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.
https://bugs.webkit.org/show_bug.cgi?id=34542
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 3 Feb 2010 23:31:02 +0000 (23:31 +0000)]
Rubber-stamped by Ariya Hidayat.
Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399
WebKitTools:
* DumpRenderTree/win/EventSender.cpp:
(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):
LayoutTests:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Wed, 3 Feb 2010 23:06:59 +0000 (23:06 +0000)]
2010-02-03 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium mac build fix.
[V8] Remove unused V8Proxy* variable from generated wrapping code.
* bindings/scripts/CodeGeneratorV8.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Wed, 3 Feb 2010 22:33:36 +0000 (22:33 +0000)]
2010-02-03 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.
https://bugs.webkit.org/show_bug.cgi?id=32563
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptObject.cpp:
* bindings/v8/V8AbstractEventListener.cpp:
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8NodeFilterCondition.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.h
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8CustomPositionCallback.cpp:
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 22:32:27 +0000 (22:32 +0000)]
2010-02-03 Eric Seidel <eric@webkit.org>
No review, just fixing copyrights.
Concerns were expressed about "The Chromium Authors" being
a valid legal entity for copyright assignment in the WebKit repository,
so this change removes all "The Chromium Authors".
I looked at the svn logs in src.chromium.org and failed to find any
non-google contributions to these files, so they are all now
marked as copyright "Google Inc" as all Google contributers assign
copyright to "Google Inc" as part of their employment agreement.
* Scripts/rebaseline-chromium-webkit-tests:
* Scripts/run-chromium-webkit-tests:
* Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
* Scripts/webkitpy/layout_tests/layout_package/http_server.py:
* Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
* Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
* Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
* Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
* Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
* Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_files.py:
* Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 3 Feb 2010 22:23:38 +0000 (22:23 +0000)]
Fix drawing buttons in viewless WebKit.
Reviewed by Anders Carlsson.
* platform/mac/ThemeMac.mm:
(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 3 Feb 2010 22:00:21 +0000 (22:00 +0000)]
[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425
Reviewed by Kenneth Rohde Christiansen.
Reverting r54279, it was a misunderstanding.
* platform/network/qt/SocketStreamHandlePrivate.h:
* platform/network/qt/SocketStreamHandleQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Wed, 3 Feb 2010 21:44:51 +0000 (21:44 +0000)]
[Qt] QtLauncher, refactor argument handling in preparation of merge
with QGVLauncher
Reviewed by Ariya Hidayat.
* QtLauncher/main.cpp:
(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(LauncherApplication::formatKeys):
(LauncherApplication::enumToKeys):
(fail):
(LauncherApplication::handleUserOptions):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 21:43:36 +0000 (21:43 +0000)]
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
https://bugs.webkit.org/show_bug.cgi?id=34190
COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.
* wtf/Assertions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 3 Feb 2010 21:19:01 +0000 (21:19 +0000)]
Rubber-stamped by Ariya Hidayat.
Rolling out r53889, because it might caused flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399
WebKitTools:
* DumpRenderTree/win/EventSender.cpp:
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):
LayoutTests:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 21:17:22 +0000 (21:17 +0000)]
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
https://bugs.webkit.org/show_bug.cgi?id=34518
Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.
* wtf/brew/OwnPtrBrew.cpp: Added.
(WTF::IFileMgr):
(WTF::IFile):
(WTF::IBitmap):
(WTF::freeOwnedPtrBrew):
* wtf/brew/OwnPtrBrew.h: Added.
(WTF::OwnPtrBrew::OwnPtrBrew):
(WTF::OwnPtrBrew::~OwnPtrBrew):
(WTF::OwnPtrBrew::get):
(WTF::OwnPtrBrew::release):
(WTF::OwnPtrBrew::outPtr):
(WTF::OwnPtrBrew::set):
(WTF::OwnPtrBrew::clear):
(WTF::OwnPtrBrew::operator*):
(WTF::OwnPtrBrew::operator->):
(WTF::OwnPtrBrew::operator!):
(WTF::OwnPtrBrew::operator UnspecifiedBoolType):
(WTF::OwnPtrBrew::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::getPtr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 3 Feb 2010 20:58:11 +0000 (20:58 +0000)]
Scroll does not work with IBM Thinkpad.
<https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>
Reviewed by Steve Falkenburg.
When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.
Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.
Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.
* WebView.cpp:
(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down
by lines or pages.
(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right
by lines or pages.
(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create
vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.
(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for
the some kind of IBM Trackpoint driver.
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 20:14:38 +0000 (20:14 +0000)]
2010-02-03 Drew Wilson <atwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513
Test: Existing tests suffice (fixes test downstream in Chrome).
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
Changed to no longer derive from ActiveDOMObject (handles its own refcounting).
(WebCore::SharedWorkerScriptLoader::load):
Now increments own refcount when a load is pending.
(WebCore::SharedWorkerScriptLoader::notifyFinished):
Changed to decrement refcount when load is complete.
* workers/WorkerScriptLoaderClient.h:
Documentation change about reliability of notifyFinished() when used from worker context.
2010-02-03 Drew Wilson <atwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513
* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
Changed SharedWorkerScriptLoader to manage its own lifecycle without using ActiveDOMObject.
(WebCore::SharedWorkerScriptLoader::parentContext):
(WebCore::pendingLoaders):
Now we manually track pending loads so we can shut them down when the parent context shuts down.
(WebCore::SharedWorkerScriptLoader::contextDetached):
Shuts down/frees any pending worker loads.
(WebCore::SharedWorkerScriptLoader::~SharedWorkerScriptLoader):
Marks the SharedWorker object as not having pending activity if there was a load active (handles case where load was pending when parent document exits).
(WebCore::SharedWorkerScriptLoader::load):
(WebCore::SharedWorkerRepository::documentDetached):
Now calls SharedWorkerScriptLoader::contextDetached() to shutdown any pending worker loads.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 19:57:52 +0000 (19:57 +0000)]
2010-02-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Inspector renders blank scripts on reloading the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34537
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 19:41:42 +0000 (19:41 +0000)]
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Export WTF::fastStrDup symbol
https://bugs.webkit.org/show_bug.cgi?id=34526
* JavaScriptCore.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 3 Feb 2010 19:39:16 +0000 (19:39 +0000)]
[Qt] Fix pixel tests support.
https://bugs.webkit.org/show_bug.cgi?id=27813
Reviewed by Ariya Hidayat.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
- Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
(WebCore::DumpRenderTree::dump): Fixed and renamed variables.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 3 Feb 2010 19:02:52 +0000 (19:02 +0000)]
Fixed a bug where WKSetNSURLConnectionDefersCallbacks(true) did not defer callbacks during modal dialogs.
Reviewed by Anders Carlsson.
* libWebKitSystemInterfaceLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 3 Feb 2010 18:52:05 +0000 (18:52 +0000)]
Reviewed by Kevin Ollivier.
[wx] Enable JIT compilation for wx.
https://bugs.webkit.org/show_bug.cgi?id=34536
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 3 Feb 2010 18:26:05 +0000 (18:26 +0000)]
2010-02-03 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Revert r54285 which failed to compile on Linux GTK.
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScript.cpp: Removed.
* inspector/InjectedScript.h: Removed.
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptForId):
(WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::dispatchOnInjectedScript):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::setFrontendProxyObject):
(WebCore::InspectorController::close):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::didPause):
(WebCore::InspectorController::injectedScriptForNodeId):
* inspector/InspectorController.h:
(WebCore::InspectorController::frontendScriptState):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addConsoleMessage):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 3 Feb 2010 18:11:20 +0000 (18:11 +0000)]
2010-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Provide strongly typed C++ interface for inspector's injected script.
https://bugs.webkit.org/show_bug.cgi?id=33616
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScript.cpp: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::dispatch):
(WebCore::InjectedScript::callFrames):
(WebCore::InjectedScript::wrapAndStringify):
(WebCore::InjectedScript::releaseWrapperObjectGroup):
* inspector/InjectedScript.h: Added.
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::~InjectedScript):
(WebCore::InjectedScript::hasNoValue):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptForId):
(WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
* inspector/InjectedScriptHost.h:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::dispatchOnInjectedScript):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::setFrontendProxyObject):
(WebCore::InspectorController::close):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::didPause):
(WebCore::InspectorController::injectedScriptForNodeId):
* inspector/InspectorController.h:
(WebCore::InspectorController::frontendScriptState):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::addConsoleMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 3 Feb 2010 18:02:01 +0000 (18:02 +0000)]
Unreviewed build fix.
[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 17:48:44 +0000 (17:48 +0000)]
2010-02-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
[Chromium] Return a consistent set of platforms from WebDevToolsFrontendImpl
https://bugs.webkit.org/show_bug.cgi?id=34523
* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::jsPlatform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 3 Feb 2010 16:09:31 +0000 (16:09 +0000)]
2010-02-02 Bryan Yeung <bryeung@google.com>
Reviewed by Darin Adler.
Avoid using an invalidated KURL object in baseURI.
https://bugs.webkit.org/show_bug.cgi?id=34492
This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.
* dom/Element.cpp:
(WebCore::Element::baseURI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 16:01:11 +0000 (16:01 +0000)]
2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
https://bugs.webkit.org/show_bug.cgi?id=34062
This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
(WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
(WebCore::OpacityAnimationQt::updateState): style change
2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::update): Moved the sync operation to update
(QGraphicsWebView::paint): Moved the sync operation to update
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 3 Feb 2010 15:37:06 +0000 (15:37 +0000)]
WebCore: [Chromium] Make setCaretBlinkInterval static.
https://bugs.webkit.org/show_bug.cgi?id=31704
Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.
This is so it can be called from the newly exposed Chromium API setter
method.
* rendering/RenderThemeChromiumLinux.cpp:
* rendering/RenderThemeChromiumLinux.h:
WebKit/chromium: [Chromium] Add API method for setting caret blink frequency.
https://bugs.webkit.org/show_bug.cgi?id=31704
Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.
This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method
to be called Chromium's API. The API is linux-only as it is currently
the only port to implement RenderTheme::setCaretBlinkInterval.
* WebKit.gyp: Add WebRenderTheme.{h,cpp}
* public/linux/WebRenderTheme.h: Added.
* src/linux/WebRenderTheme.cpp: Added.
(WebKit::setCaretBlinkInterval): Exposed API
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 3 Feb 2010 13:42:51 +0000 (13:42 +0000)]
[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425
Reviewed by Kenneth Rohde Christiansen.
Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.
No new tests, since no new functionality is introduced.
* platform/network/qt/SocketStreamHandlePrivate.h:
* platform/network/qt/SocketStreamHandleQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 3 Feb 2010 13:02:13 +0000 (13:02 +0000)]
2010-02-03 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.
[V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
* bindings/v8/V8Collection.h:
(WebCore::getV8Object):
(WebCore::toNativeCollection):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):
(WebCore::nodeCollectionIndexedPropertyEnumerator):
(WebCore::collectionIndexedPropertyEnumerator):
(WebCore::collectionStringOrNullIndexedPropertyGetter):
(WebCore::collectionStringIndexedPropertyGetter):
(WebCore::setCollectionIndexedGetter):
(WebCore::setCollectionNamedGetter):
(WebCore::setCollectionStringOrNullIndexedGetter):
(WebCore::setCollectionStringIndexedGetter):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::downcastSVGPathSeg):
(WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object):
(WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object):
(WebCore::V8DOMWrapper::convertToV8Object):
(WebCore::V8DOMWrapper::instantiateV8Object):
(WebCore::V8DOMWrapper::isDOMEventWrapper):
(WebCore::V8DOMWrapper::htmlElementType):
(WebCore::V8DOMWrapper::svgElementType):
(WebCore::V8DOMWrapper::convertEventToV8Object):
(WebCore::):
(WebCore::V8DOMWrapper::convertDocumentToV8Object):
(WebCore::V8DOMWrapper::convertNodeToV8Object):
(WebCore::V8DOMWrapper::convertNewNodeToV8Object):
(WebCore::V8DOMWrapper::convertEventListenerToV8Object):
(WebCore::V8DOMWrapper::convertDOMImplementationToV8Object):
(WebCore::V8DOMWrapper::convertStyleSheetToV8Object):
(WebCore::V8DOMWrapper::convertCSSValueToV8Object):
(WebCore::V8DOMWrapper::convertCSSRuleToV8Object):
(WebCore::V8DOMWrapper::convertWindowToV8Object):
(WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertToV8Object):
(WebCore::V8DOMWrapper::convertNodeToV8Object):
(WebCore::V8DOMWrapper::convertNewNodeToV8Object):
(WebCore::V8DOMWrapper::convertEventToV8Object):
(WebCore::V8DOMWrapper::convertEventListenerToV8Object):
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::createPatternCallback):
* bindings/v8/custom/V8CustomPositionCallback.cpp:
(WebCore::V8CustomPositionCallback::handleEvent):
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
(WebCore::V8CustomPositionErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
(WebCore::V8CustomSQLStatementCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
(WebCore::V8CustomSQLTransactionCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::V8Document::implementationAccessorGetter):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore::V8Element::setAttributeNodeCallback):
(WebCore::V8Element::setAttributeNodeNSCallback):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::namedPropertyGetter):
(WebCore::V8HTMLDocument::allAccessorGetter):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::namedPropertyGetter):
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::createInjectedScript):
(WebCore::V8InjectedScriptHost::nodeForIdCallback):
(WebCore::V8InjectedScriptHost::databaseForIdCallback):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::portsAccessorGetter):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
(WebCore::V8NodeList::callAsFunctionCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
(WebCore::V8SVGMatrix::multiplyCallback):
(WebCore::V8SVGMatrix::inverseCallback):
(WebCore::V8SVGMatrix::rotateFromVectorCallback):
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::transformToFragmentCallback):
(WebCore::V8XSLTProcessor::transformToDocumentCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 10:54:28 +0000 (10:54 +0000)]
2010-02-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Start unforking debugger and profiler code.
Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=34481
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/ScriptProfile.h: Added.
* bindings/js/ScriptProfiler.cpp: Added.
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
* bindings/js/ScriptProfiler.h: Added.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptProfile.h: Added.
(WebCore::ScriptProfile::create):
(WebCore::ScriptProfile::~ScriptProfile):
(WebCore::ScriptProfile::title):
(WebCore::ScriptProfile::uid):
(WebCore::ScriptProfile::ScriptProfile):
* bindings/v8/ScriptProfiler.cpp: Added.
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
* bindings/v8/ScriptProfiler.h: Added.
* bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::endGroup):
(WebCore::InspectorController::show):
(WebCore::InspectorController::setDOMStorageItem):
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::createProfileHeader):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::specialPanelForJSName):
* inspector/InspectorController.h:
(WebCore::InspectorController::searchingForNodeInPage):
* page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
* page/Console.h:
(WebCore::):
(WebCore::Console::create):
(WebCore::Console::profiles):
* page/Console.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 3 Feb 2010 09:50:11 +0000 (09:50 +0000)]
Add myself to commiters.py
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 3 Feb 2010 08:11:42 +0000 (08:11 +0000)]
Rubber-stamped by Adam Barth.
http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349
* platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 3 Feb 2010 06:56:30 +0000 (06:56 +0000)]
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716
Add tests for maxLength changes and step changes.
* fast/forms/input-live-pseudo-selectors-expected.txt:
* fast/forms/resources/input-live-pseudo-selectors.js:
* fast/forms/resources/textarea-live-pseudo-selectors.js:
* fast/forms/textarea-live-pseudo-selectors-expected.txt:
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716
- Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck()
- Introduce HTMLFormControlElement::setNeedsWillValidate()
- Introduce HTMLFormControlElement::m_hasName to make willValidate()
work in parseMappedAttribute().
- We need to call setNeedsValidityCheck() when HTMLInputElement::step or
HTMLTextAreaElement::maxLength is changed.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::formDestroyed):
(WebCore::HTMLFormControlElement::willValidate): Avoids function calls.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::disabled): Move the code from .cpp.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::setFileListFromRenderer):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
(WebCore::HTMLTextAreaElement::setValue):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::subtreeHasChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 3 Feb 2010 05:57:13 +0000 (05:57 +0000)]
Bug 34198 - Ruby text should not inherit line-height
(https://bugs.webkit.org/show_bug.cgi?id=34198)
Reviewed by Adele Peterson.
Resetting line-height to 'normal' in the default UA style sheet.
Adding layout-test to check for this.
WebCore:
Test: fast/ruby/ruby-line-height.html
* css/html.css:
LayoutTests:
* fast/ruby/script-tests: Added.
* fast/ruby/script-tests/ruby-line-height.js: Added.
* fast/ruby/ruby-line-height-expected.txt: Added.
* fast/ruby/ruby-line-height.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 05:22:13 +0000 (05:22 +0000)]
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.
* fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
* fast/forms/ValidityState-rangeOverflow-date.html: Removed.
* fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
* fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
* fast/forms/ValidityState-rangeOverflow-number.html: Removed.
* fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
* fast/forms/ValidityState-rangeOverflow-range.html: Removed.
* fast/forms/ValidityState-rangeOverflow.html: Added.
* fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
* fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
* fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
* fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
* fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
* fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
* fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
* fast/forms/ValidityState-rangeUnderflow.html: Added.
* fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
* fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.
2010-02-02 James Robinson <jamesr@chromium.org>
Reviewed by Dmitry Titov.
Add a null check for image, which might be NULL if tileSize is empty
https://bugs.webkit.org/show_bug.cgi?id=34510
Test: fast/gradients/crash-on-1px-border.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 3 Feb 2010 04:21:55 +0000 (04:21 +0000)]
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.
* fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
* fast/forms/ValidityState-rangeOverflow-date.html: Removed.
* fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
* fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
* fast/forms/ValidityState-rangeOverflow-number.html: Removed.
* fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
* fast/forms/ValidityState-rangeOverflow-range.html: Removed.
* fast/forms/ValidityState-rangeOverflow.html: Added.
* fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
* fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
* fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
* fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
* fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
* fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
* fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
* fast/forms/ValidityState-rangeUnderflow.html: Added.
* fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
* fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.
2010-02-02 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483
Tests: fast/forms/ValidityState-rangeOverflow.html
fast/forms/ValidityState-rangeUnderflow.html
* html/HTMLInputElement.cpp:
Defines the hard limits for the types as double values.
(WebCore::HTMLInputElement::rangeUnderflow): Supports the types.
(WebCore::HTMLInputElement::rangeOverflow): Supports the types.
(WebCore::HTMLInputElement::minimum): Supports the types.
(WebCore::HTMLInputElement::maximum): Supports the types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 3 Feb 2010 04:20:05 +0000 (04:20 +0000)]
2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Implement WebFrameImpl::pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34471
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::pageNumberForElementById):
* src/WebFrameImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 3 Feb 2010 04:00:17 +0000 (04:00 +0000)]
[wx] Build fix after introduction of pageNumberForElementById.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 3 Feb 2010 03:42:43 +0000 (03:42 +0000)]
Roll out r54252.
The method it deleted is in fact used, and its deletion resulted in plug-ins that use accelerated compositing not being drawn.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Wed, 3 Feb 2010 01:36:14 +0000 (01:36 +0000)]
2010-02-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket wrapper can be collected even if events are pending
https://bugs.webkit.org/show_bug.cgi?id=34014
* websocket/tests/websocket-pending-activity-expected.txt: Added.
* websocket/tests/websocket-pending-activity.html: Added.
2010-02-02 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket set pending activity to avoid unexpected GC.
https://bugs.webkit.org/show_bug.cgi?id=34014
Test: websocket/tests/websocket-pending-activity.html
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): set pending activity until it receives didClose.
(WebCore::WebSocket::contextDestroyed): check socket is already closed.
(WebCore::WebSocket::stop): close the connection and unset pending activity when it stops.
(WebCore::WebSocket::didClose): unset pending activity.
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 3 Feb 2010 01:21:32 +0000 (01:21 +0000)]
2010-02-02 Gustavo Noronha Silva <gns@gnome.org>
No review, rolling out r54261.
http://trac.webkit.org/changeset/54261
https://bugs.webkit.org/show_bug.cgi?id=34435
Causes crashes on release builds
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
* platform/gtk/GOwnPtrGtk.cpp: Removed.
* platform/gtk/GOwnPtrGtk.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 3 Feb 2010 01:13:47 +0000 (01:13 +0000)]
2010-02-02 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash in CollectorBitmap::get at nbcolympics.com
https://bugs.webkit.org/show_bug.cgi?id=34504
This was caused by the use of m_offset to determine the offset of
a new property into the property storage. This patch corrects
the effected cases by incorporating the anonymous slot count. It
also removes the duplicate copy of anonymous slot count from the
property table as keeping this up to date merely increased the
chance of a mismatch. Finally I've added a large number of
assertions in an attempt to prevent such a bug from happening
again.
With the new assertions in place the existing anonymous slot tests
all fail without the m_offset fixes.
* runtime/PropertyMapHashTable.h:
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::insertIntoPropertyMapHashTable):
(JSC::Structure::createPropertyMapHashTable):
(JSC::Structure::rehashPropertyMapHashTable):
(JSC::Structure::checkConsistency):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 3 Feb 2010 00:54:13 +0000 (00:54 +0000)]
2010-02-02 David Levin <levin@chromium.org>
No review, rolling out r54245.
http://trac.webkit.org/changeset/54245
https://bugs.webkit.org/show_bug.cgi?id=34492
This patch seems to have broken thousands of chromium tests on
Windows (and since it was for chromium, I'm rolling it out).
* dom/Element.cpp:
(WebCore::Element::baseURI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 3 Feb 2010 00:25:32 +0000 (00:25 +0000)]
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* win/tools/scripts/auto-version.sh:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* WebKit.vcproj/WebKit.rc:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* WebCore.vcproj/QTMovieWin.rc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 3 Feb 2010 00:05:38 +0000 (00:05 +0000)]
2010-02-02 Dimitri Glazkov <dglazkov@chromium.org>
No review, rolling out r54257.
http://trac.webkit.org/changeset/54257
https://bugs.webkit.org/show_bug.cgi?id=34491
[Chromium] broke thousands of Win tests and a few of Linux tests.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::applyAntiAliasedClipPaths):
* platform/graphics/skia/PlatformContextSkia.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 3 Feb 2010 00:03:27 +0000 (00:03 +0000)]
2010-02-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435
Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent not Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.
* GNUmakefile.am:
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateSourceChangedCallback):
* platform/gtk/GOwnPtrGtk.cpp: Added.
(WTF::SoupURI):
(WTF::GstElement):
* platform/gtk/GOwnPtrGtk.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 2 Feb 2010 23:37:50 +0000 (23:37 +0000)]
2010-02-02 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Xan Lopez.
Bump version, and adjust library versioning for 1.1.20.
* configure.ac:
WebKit/gtk
2010-02-02 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Xan Lopez.
Changes in 1.1.20, and documentation control files update.
* NEWS:
* docs/webkitgtk-docs.sgml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 2 Feb 2010 23:23:33 +0000 (23:23 +0000)]
2010-02-02 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.
https://bugs.webkit.org/show_bug.cgi?id=32563
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptObject.cpp:
* bindings/v8/V8AbstractEventListener.cpp:
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8NodeFilterCondition.cpp:
* bindings/v8/V8Proxy.cpp:
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8CustomPositionCallback.cpp:
* bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DataGridColumnListCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
* bindings/v8/custom/V8ElementCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NodeIteratorCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
* bindings/v8/custom/V8TreeWalkerCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
snej@chromium.org [Tue, 2 Feb 2010 23:16:35 +0000 (23:16 +0000)]
Clarified coding guidelines on wiki to allow indentation of _nested_ namespaces.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32137
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 23:06:53 +0000 (23:06 +0000)]
2010-02-02 Garret Kelly <gdk@chromium.org>
Reviewed by David Levin.
When using the Skia graphics context, the beginTransparencyLayer call
currently creates a new layer, but does not keep the current
compositing mode for use when merging the created layer back onto the
rest of the context. This patch fixes that.
https://bugs.webkit.org/show_bug.cgi?id=34491
fast/backgrounds/svg-as-mask.html is affected by this change in Chromium,
but not fixed. This is the first of a series of patches to fix it.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::beginTransparencyLayer):
* platform/graphics/skia/PlatformContextSkia.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 22:50:41 +0000 (22:50 +0000)]
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=34409
Platform guards for localtime_r are not needed because we already have
WTF::getLocalTime which does the same thing.
* loader/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
* loader/FTPDirectoryParser.cpp:
(WebCore::gmtimeQt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 22:34:16 +0000 (22:34 +0000)]
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy main thread functions
https://bugs.webkit.org/show_bug.cgi?id=33569
Add dummy initializeMainThreadPlatform and
scheduleDispatchFunctionsOnMainThread.
* wtf/brew/MainThreadBrew.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 22:29:37 +0000 (22:29 +0000)]
2010-02-02 Eric Seidel <eric@webkit.org>
Reviewed by Gustavo Noronha Silva.
http/tests/incremental/split-hex-entities.pl timed out on Gtk Linux 32-bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33445
* platform/gtk/Skipped: Skip this test to keep the bots green until someone with Gtk knowledge can examine why it intermittently times out.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 22:18:04 +0000 (22:18 +0000)]
2010-02-02 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Move misplaced JS files to the proper location.
https://bugs.webkit.org/show_bug.cgi?id=34256
* fast/events/script-tests/basic-touch-events.js: Removed.
* fast/events/script-tests/create-touch-event.js: Removed.
* fast/events/script-tests/send-oncancel-event.js: Removed.
* fast/events/touch/basic-touch-events.html:
* fast/events/touch/create-touch-event.html:
* fast/events/touch/script-tests: Added.
* fast/events/touch/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/script-tests/TEMPLATE.html.
* fast/events/touch/script-tests/basic-touch-events.js: Copied from LayoutTests/fast/events/script-tests/basic-touch-events.js.
* fast/events/touch/script-tests/create-touch-event.js: Copied from LayoutTests/fast/events/script-tests/create-touch-event.js.
* fast/events/touch/script-tests/send-oncancel-event.js: Copied from LayoutTests/fast/events/script-tests/send-oncancel-event.js.
* fast/events/touch/send-oncancel-event.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 2 Feb 2010 22:00:55 +0000 (22:00 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34502
Unused method pluginLayer in Netscape plug-in views
* Plugins/Hosted/WebHostedNetscapePluginView.h:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
Removed the method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 2 Feb 2010 21:09:35 +0000 (21:09 +0000)]
Copy WebCore's bindings generation scripts to the PrivateHeaders directory on Mac
This will allow other projects to use these scripts.
Fixes <http://webkit.org/b/34498>.
Reviewed by Mark Rowe.
* WebCore.xcodeproj/project.pbxproj: Added the bindings generation
scripst to the Copy Headers phase, and marked them as Private.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 2 Feb 2010 20:55:04 +0000 (20:55 +0000)]
Copy WebCore's bindings generation scripts to a more sensible location
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebCore.vcproj/WebCore.make:
* WebCore.vcproj/WebCoreGenerated.vcproj:
Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 2 Feb 2010 20:54:53 +0000 (20:54 +0000)]
Rename the scripts used to copy WebCore's bindings generation scripts
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts.
* WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh.
* WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 2 Feb 2010 20:54:39 +0000 (20:54 +0000)]
Stop copying IDL files into $(WebKitOutputDir)
No one uses these anymore (as of r52921).
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files
anymore. Keep copying the scripts, though, since other projects
(outside of the WebKit repository) do use those.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 2 Feb 2010 20:54:28 +0000 (20:54 +0000)]
Stop copying WebCore's IDL files from SRCROOT to OBJROOT
WebKit doesn't use these anymore (as of r52921).
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebKit.vcproj/WebKit.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 20:04:30 +0000 (20:04 +0000)]
2010-02-02 Bryan Yeung <bryeung@bryeung-chrome.(none)>
Reviewed by Darin Adler.
Avoid using an invalidated KURL object in baseURI.
https://bugs.webkit.org/show_bug.cgi?id=34492
This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
* dom/Element.cpp:
(WebCore::Element::baseURI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 2 Feb 2010 19:47:43 +0000 (19:47 +0000)]
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Add using WTF::getLocalTime to CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=34493
* wtf/CurrentTime.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Tue, 2 Feb 2010 18:16:54 +0000 (18:16 +0000)]
Add myself to list of committers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 2 Feb 2010 18:00:55 +0000 (18:00 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34076
<rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute
Test: fast/forms/misplaced-img-form-registration.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added
to vector again.
(WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something
that's actually registered.
* html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails
to insert the image element, then there will be no removed from tree notification either,
need to unregister right away.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Tue, 2 Feb 2010 17:19:49 +0000 (17:19 +0000)]
Do not use a proxy widget for the QComboBox on Maemo 5, as it
is not working properly and it is not needed at all, as the
comboboxes comes up in their full width on the screen and
do not depend on view.
Reviewed by Ariya Hidayat.
* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc