WebKit-https.git
7 years ago[GTK] Enable introspection always for developer builds
mrobinson@webkit.org [Mon, 22 Apr 2013 22:15:37 +0000 (22:15 +0000)]
[GTK] Enable introspection always for developer builds
https://bugs.webkit.org/show_bug.cgi?id=114983

Reviewed by Gustavo Noronha Silva.

.:

* Source/autotools/SetupAutoconfHeader.m4: No longer expose the ENABLE_INTROSPECTION
autoconf header variable. It isn't used and it means that when introspection is enabled
or disabled, there is an unnecessary full rebuild.

Source/WebKit/gtk:

* GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate
warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet to avoid printing lots of output to
non-verbose builds.

Source/WebKit2:

* GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate
warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet.

Tools:

* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Always enable introspection
when using build-webkit.
* gtk/jhbuildrc: Enable documentation for all jhbuild modules and explicitly
choose the memory gsettings backend while in the jhbuild. This eliminates
warnings from programs that fall back to the memory backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css exclusions] shape-inside-recursive-layout.html should not yet test display:...
betravis@adobe.com [Mon, 22 Apr 2013 22:07:05 +0000 (22:07 +0000)]
[css exclusions] shape-inside-recursive-layout.html should not yet test display: inline-grid
https://bugs.webkit.org/show_bug.cgi?id=114986

Reviewed by Dirk Schulze.

Because the inline-grid value is not yet supported, the test case is falling back to
display: block. This causes an incorrect layout, as block and inline content react to
shape-inside differently.

* fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
* fast/exclusions/shape-inside/shape-inside-recursive-layout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix remaining introspection warnings
mrobinson@webkit.org [Mon, 22 Apr 2013 21:54:02 +0000 (21:54 +0000)]
[GTK] Fix remaining introspection warnings
https://bugs.webkit.org/show_bug.cgi?id=114980

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

* bindings/gobject/WebKitDOMCustom.h: Add scope and transfer annotations and flesh
out gtkdoc for completeness.
* bindings/gobject/WebKitDOMEventTarget.h:
(_WebKitDOMEventTargetIface): Ditto and also align virtual method names with those used
for the concrete ones.

Source/WebKit/gtk:

* webkit/webkitspellchecker.h:
(_WebKitSpellCheckerInterface): Align the name of the check_spelling_of_string virtual
method with the concrete method to avoid a g-ir-scanner warning.
* webkit/webkitversion.h.in: Skip WEBKITGTK_API_VERSION for introspection because it
doesn't follow the appropriate namespace name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake it easier to extend NetworkResourceLoadParameters
andersca@apple.com [Mon, 22 Apr 2013 21:45:43 +0000 (21:45 +0000)]
Make it easier to extend NetworkResourceLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=114992

Reviewed by Sam Weinig.

Turn NetworkResourceLoadParameters into a struct which matches all our other parameter classes in WebKit2. Fill in the struct manually
instead of having a constructor with 9 parameters.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
* NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
* Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
* Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDFPlugin: Support unlocking encrypted PDFs
timothy_horton@apple.com [Mon, 22 Apr 2013 21:19:17 +0000 (21:19 +0000)]
PDFPlugin: Support unlocking encrypted PDFs
https://bugs.webkit.org/show_bug.cgi?id=114938
<rdar://problem/12872888>

Reviewed by Alexey Proskuryakov and Oliver Hunt.

If we try to load an encrypted PDF, we need to provide a sane mechanism
through which the user can provide the password. Add a slightly-below-center
password field to match PDFKit's normal behavior.

* WebKit2.xcodeproj/project.pbxproj: Add PDFPluginPasswordField.{h,mm}
* WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add attemptToUnlockWithPassword:
* WebProcess/Plugins/PDF/PDFPlugin.h:
Add createPasswordEntryForm, attemptToUnlockPDF, m_passwordField.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(annotationStyle): Make #annotationContainer a flexbox that centers its contents.
This won't affect the normal absolutely-positioned form fields, but the inline
password field will be centered vertically and horizontally.

(WebKit::PDFPlugin::pdfDocumentDidLoad):
If the document is locked when loaded, create a password field.

(WebKit::PDFPlugin::createPasswordEntryForm):
Create a PDFPluginPasswordField and attach it to the document.

(WebKit::PDFPlugin::attemptToUnlockPDF):
Try to unlock the PDF with the given password. If this succeeds, remove
the password field and relayout the scroll view.

(WebKit::PDFPlugin::calculateSizes):
Make the document 0x0 if it is locked, preventing scrolling.

(WebKit::PDFPlugin::handleMouseEvent):
Don't pass mouse events to PDFLayerController while it is locked,
as it has no useful events to provide, and will try to present a
dialog asking for the password if we let a click through.

* WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
(WebKit::PDFPluginAnnotation::eventListener): Added.
* WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::handleEvent):
Move event-handling code here from PDFPluginAnnotationEventListener::handleEvent
so that subclasses can override this instead of having to have their own
event listeners (this is also why we now expose eventListener()).

(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent):
Forward the event to our owning PDFPluginAnnotation.

* WebProcess/Plugins/PDF/PDFPluginPasswordField.h: Added.
(WebKit::PDFPluginPasswordField::PDFPluginPasswordField):
* WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Added.
(WebKit::PDFPluginPasswordField::create):
(WebKit::PDFPluginPasswordField::~PDFPluginPasswordField):
Unregister for keyup.

(WebKit::PDFPluginPasswordField::createAnnotationElement):
Register for keyup, and set our element's class to "password".

(WebKit::PDFPluginPasswordField::updateGeometry):
Added. Override updateGeometry and do nothing, as the password field
has a geometry defined by CSS instead of by the PDF content.

(WebKit::PDFPluginPasswordField::handleEvent):
If the enter/return key is pressed, attempt to unlock the PDF. Also,
we do not call either of our superclass' implementations of handleEvent,
because blurring the password field should not destroy it, and tabbing
between fields has no relevance when there can only be one field.

* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener):
Removed. We now share our superclass' event listener.

(WebKit::PDFPluginTextAnnotation::textAnnotation): Const.
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation):
PDFPluginTextAnnotation no longer has its own event listener,
so there's nothing left to clear here. Just make sure to unregister
our event from PDFPluginAnnotation's shared event listener!

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
Ensure that we can create a PDFPluginTextAnnotation with a null annotation.

(WebKit::PDFPluginTextAnnotation::commit): Use value().
(WebKit::PDFPluginTextAnnotation::value):
Factor retrieving the value of the form control out of commit().

(WebKit::PDFPluginTextAnnotation::handleEvent):
Call up to PDFPluginAnnotation's handler so that defocus destroys the annotation.

Export HTMLNames::typeAttr.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSlow/beachballing when using the find bar on a page with plug-ins
andersca@apple.com [Mon, 22 Apr 2013 20:46:06 +0000 (20:46 +0000)]
Slow/beachballing when using the find bar on a page with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=114990
<rdar://problem/12832313>

Reviewed by Tim Horton.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::notifyWidget):
Call shouldCreateTransientPaintingSnapshot().

(WebKit::PluginView::shouldCreateTransientPaintingSnapshot):
Don't create a painting snapshot if we're asked to paint the find indicator.

* WebProcess/Plugins/PluginView.h:
Add new member function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13334446> [Mac] Tweak sandbox profiles.
ap@apple.com [Mon, 22 Apr 2013 20:40:57 +0000 (20:40 +0000)]
    <rdar://problem/13334446> [Mac] Tweak sandbox profiles.

        Reviewed by Sam Weinig.

        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update about:config lists
commit-queue@webkit.org [Mon, 22 Apr 2013 20:39:26 +0000 (20:39 +0000)]
[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=114967

Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/AboutDataHaveFeatures.in:
* WebCoreSupport/AboutDataUseFeatures.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse-after-free in CompositeEditCommand::cloneParagraphUnderNewElement
rniwa@webkit.org [Mon, 22 Apr 2013 20:39:24 +0000 (20:39 +0000)]
Use-after-free in CompositeEditCommand::cloneParagraphUnderNewElement
https://bugs.webkit.org/show_bug.cgi?id=114911

Reviewed by Oliver Hunt.

Back ported https://src.chromium.org/viewvc/blink?revision=148680&view=revision.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] "automatic" track selection should only select a track that matches user language
eric.carlson@apple.com [Mon, 22 Apr 2013 20:29:58 +0000 (20:29 +0000)]
[Mac] "automatic" track selection should only select a track that matches user language
https://bugs.webkit.org/show_bug.cgi?id=114976

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-automatic-subtitles.html

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): When in "automatic" mode, only
    consider text tracks that match the user's preferred language when the primary audio track
    does not.

LayoutTests:

* media/track/track-automatic-subtitles-expected.txt: Added.
* media/track/track-automatic-subtitles.html: Added.
* platform/mac/TestExpectations: Skip track-user-preferences.html, the logic is no longer
     correct for the Mac port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCancelling load may cause deadlock in -[AVPlayerItem release]
jer.noble@apple.com [Mon, 22 Apr 2013 20:02:46 +0000 (20:02 +0000)]
Cancelling load may cause deadlock in -[AVPlayerItem release]
https://bugs.webkit.org/show_bug.cgi?id=114962

Reviewed by Eric Carlson.

Work around a bug in AVAssetResourceLoader by using a generic, non-main dispatch queue
to recieve AVAssetResourceLoaderDelegate callbacks, and then marshalling those
callbacks to the main thread asynchronously.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::globalLoaderDelegateQueue): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Use the new global queue.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
    Marshall the request to the main queue, and return YES (wait) immediately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't kill our XPC services in response to memory pressure
andersca@apple.com [Mon, 22 Apr 2013 20:01:51 +0000 (20:01 +0000)]
Don't kill our XPC services in response to memory pressure
https://bugs.webkit.org/show_bug.cgi?id=114985
<rdar://problem/13229217>

Reviewed by Mark Rowe.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
Call xpc_transaction_begin() so we'll never be killed by the kernel when there's memory pressure;
we prefer to manage our own lifetime thank you very much!

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize):
Remove call to disable sudden termination.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13681842> [Mac] Tweak WebProcess sandbox profile to use
ap@apple.com [Mon, 22 Apr 2013 19:54:53 +0000 (19:54 +0000)]
    <rdar://problem/13681842> [Mac] Tweak WebProcess sandbox profile to use
        system-graphics function when available.

        Reviewed by Sam Weinig.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Set up libPlatform.la
zandobersek@gmail.com [Mon, 22 Apr 2013 19:52:09 +0000 (19:52 +0000)]
[GTK] Set up libPlatform.la
https://bugs.webkit.org/show_bug.cgi?id=114168

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Define the platform_cppflags and platform_sources variables.

Source/Platform:

* GNUmakefile.am: Set up the libPlatform.la static library to build the source files listed in platform_sources.
As with the libPlatformGtk.la library, only the Source/WebCore/platform and its subdirectories are allowed to be
searched for headers to include, providing a convenient way to detect any platform violations. These directories
are listed in the platform_webcore_cppflags variable.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.am: Also add the LevelDB-specific cppflags to the platform_cppflags if required as the LevelDB
code is now built into the new libPlatform.la library.
* GNUmakefile.list.am: Build a small set of non-GTK-specific platform source files that are already free of
platform violations into the new libPlatform.la library.

Source/WebKit/gtk:

* GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library.

Source/WebKit2:

* GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library. Link the WebKitPluginProcess
executable against libPlatform.la as well.

Tools:

* GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHard code plug-in sandbox profile lookup directories and move
weinig@apple.com [Mon, 22 Apr 2013 19:47:57 +0000 (19:47 +0000)]
Hard code plug-in sandbox profile lookup directories and move
the profiles to WebKit2.

Reviewed by Anders Carlsson.

* PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::getExtraInitializationData):
* PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::getExtraInitializationData):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Stop passing the sandbox-profile-directory-path to the plug-in process.

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::loadSandboxProfileForDirectory):
(WebKit::loadSandboxProfile):
(WebKit::PluginProcess::initializeSandbox):
Hard code the plug-in sandbox profile lookup to only look in the WebKit2 bundle
and /System/Library/Sandbox/Profiles/.

* Resources/PlugInSandboxProfiles: Added.
Add profiles.

* WebKit2.xcodeproj/project.pbxproj:
Copy the profiles to the bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor creation of the full screen window into an (overridable) method.
jer.noble@apple.com [Mon, 22 Apr 2013 19:37:01 +0000 (19:37 +0000)]
Refactor creation of the full screen window into an (overridable) method.
https://bugs.webkit.org/show_bug.cgi?id=110369

Reviewed by Eric Carlson.

Add a new WKView method -(NSWindow)createFullScreenWindow which can be overridden
by subclasses to provide custom full screen windows to the WKFullScreenWindowController.

* UIProcess/API/mac/WKView.mm:
(-[WKView fullScreenWindowController]):
(-[WKView createFullScreenWindow]):
* UIProcess/API/mac/WKViewPrivate.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStringImpl.h should compile with -Wshorten-64-to-32
ddkilzer@apple.com [Mon, 22 Apr 2013 19:13:30 +0000 (19:13 +0000)]
StringImpl.h should compile with -Wshorten-64-to-32
<http://webkit.org/b/114970>

Reviewed by Darin Adler.

Fixes the following warnings with -Wshorten-64-to-32:

    StringImpl.h:317:25: error: implicit conversion loses integer precision: 'uintptr_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
            unsigned hash = reinterpret_cast<uintptr_t>(this);
                     ~~~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl): Add static_cast<uint32_t>() to
formalize taking the lower 32-bits of the pointer value on
64-bit architectures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix broken 32-bit build to green the bots.
mark.lam@apple.com [Mon, 22 Apr 2013 18:40:58 +0000 (18:40 +0000)]
Fix broken 32-bit build to green the bots.
https://bugs.webkit.org/show_bug.cgi?id=114968.

Unreviewed.

Basically, I moved a JIT::emit_op_loop_hint() and JIT::emitSlow_op_loop_hint()
into common code where they belong, instead of the 64-bit specific section.

Also fixed some SH4 assertions failures which were also caused by
https://bugs.webkit.org/show_bug.cgi?id=114963. Thanks to Julien Brianceau
for pointing this out.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
* jit/JITOpcodes.cpp:
(JSC):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRange.getClientRects() should not include rects for partially selected elements
aestes@apple.com [Mon, 22 Apr 2013 18:23:33 +0000 (18:23 +0000)]
Range.getClientRects() should not include rects for partially selected elements
https://bugs.webkit.org/show_bug.cgi?id=76839

Reviewed by Sam Weinig.

Source/WebCore:

CSSOM says that Range.getClientRects() should include the border boxes
of each element selected by the range. However, we were also
incorrectly including border boxes for partially selected elements.
For instance, consider the following selection:

    <div>line one<br>line two</div>
    -------------

The <div> is two lines tall, but only the first line is selected.
Despite this, we'd include the <div>'s border box since its start tag
was included in the selection.

Fix this by excluding partially selected elements. This is accomplished
by skipping over elements that come after the start boundary point of
the range but are ancestors of the end boundary point.

Added test cases to LayoutTests/fast/dom/Range/getClientRects.html.

* dom/Range.cpp:
(WebCore::Range::getBorderAndTextQuads):

LayoutTests:

* fast/dom/Range/getClientRects-expected.txt: Updated expected result.
* fast/dom/Range/getClientRects.html: Added new test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2013-04-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 22 Apr 2013 18:21:10 +0000 (18:21 +0000)]
2013-04-22  Oliver Hunt  <oliver@apple.com>

        Perform null check before trying to use the result of readline()

        RS=Gavin

        * jsc.cpp:
        (runInteractive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2013-04-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 22 Apr 2013 18:19:06 +0000 (18:19 +0000)]
2013-04-22  Oliver Hunt  <oliver@apple.com>

        Fix assertions to account for new Vector layout

        RS=Gavin

        * llint/LLIntData.cpp:
        (JSC::LLInt::Data::performAssertions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Mac gardening. Update a test and results now that forced text
eric.carlson@apple.com [Mon, 22 Apr 2013 18:11:44 +0000 (18:11 +0000)]
Unreviewed Mac gardening. Update a test and results now that forced text
tracks are supported.

* media/track/track-in-band-expected.txt:
* media/track/track-in-band.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash on OS X when shift clicking outside of input
commit-queue@webkit.org [Mon, 22 Apr 2013 17:56:22 +0000 (17:56 +0000)]
Crash on OS X when shift clicking outside of input
https://bugs.webkit.org/show_bug.cgi?id=104058

Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-22
Reviewed by Chang Shu.

Source/WebCore:

Shift clicking outside of a focused div while removing the focused div from
the dom tree at the same time may hit a null visible position, which should
not be used to calculate the text distance with the new selection's start and
end position. Otherwise, the browser may crash.

Test: editing/selection/crash-on-shift-click.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):

LayoutTests:

Add test for shift click crash issue.

* editing/selection/crash-on-shift-click-expected.txt: Added.
* editing/selection/crash-on-shift-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange baseline JIT watchdog timer check to use the proper fast slow path
mark.lam@apple.com [Mon, 22 Apr 2013 17:37:29 +0000 (17:37 +0000)]
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=114963.

Reviewed by Oliver Hunt.

SH4 parts contributed by Julien Brianceau.

* assembler/ARMAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchAdd32):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchAdd32):
* assembler/MacroAssemblerX86Common.h:
* assembler/SH4Assembler.h:
* jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::emitEnterOptimizationCheck):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_enter):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrollbar should not depend on EventHandler, Frame and FrameView
carlosgc@webkit.org [Mon, 22 Apr 2013 17:02:25 +0000 (17:02 +0000)]
Scrollbar should not depend on EventHandler, Frame and FrameView
https://bugs.webkit.org/show_bug.cgi?id=114941

Reviewed by Darin Adler.

It's a layering violation that Scrollbar uses EventHandler, Frame
and FrameView. Frame is used to get the EventHandler that is used
to set mousePressed to false after a Scrollbar::mouseUp(). This is
not really needed, since EventHandler already sets m_mousePressed
to false when calling Scrollbar::mouseUp(). The PopupMenu windows
implementation also calls Scrollbar::mouseUp(), but that scrollbar
is not inside a FrameView.

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::isScrollViewScrollbar):
isScrollViewScrollbar() is a method of ScrollView so we don't need
to cast to FrameView.
(WebCore::Scrollbar::mouseUp): Remove EventHandler ussage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink baseline size of WTF::Vector on 64-bit by switching to unsigned capacity and...
akling@apple.com [Mon, 22 Apr 2013 17:00:17 +0000 (17:00 +0000)]
Shrink baseline size of WTF::Vector on 64-bit by switching to unsigned capacity and size.
<http://webkit.org/b/97268>
<rdar://problem/12376519>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Update LLInt WTF::Vector offset constants to match the new memory layout.

* llint/LowLevelInterpreter.asm:

Source/WebCore:

* CMakeLists.txt: Add a workaround for GCC 4.6.x in Release mode so it
does not crash.

Source/WTF:

Shrink Vector by 8 bytes on 64-bit by using 32-bit capacity and size.
Vector now inherits from VectorBuffer instead of having a VectorBuffer member;
this is necessary for m_size to fall into the padding after the base class members.

The WTF::Vector API still uses size_t.

Based on Blink r148313 by <cevans@chromium.org>.

* wtf/SizeLimits.cpp:
* wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(VectorBufferBase):
(WTF::VectorBuffer::shouldReallocateBuffer):
(Vector):
(WTF::Vector::Vector):
(WTF::Vector::capacity):
(WTF::Vector::at):
(WTF::Vector::data):
(WTF::Vector::swap):
(WTF::::Vector):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::releaseBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] URL decode data: URLs before passing to the platform media player.
commit-queue@webkit.org [Mon, 22 Apr 2013 16:43:57 +0000 (16:43 +0000)]
[BlackBerry] URL decode data: URLs before passing to the platform media player.
https://bugs.webkit.org/show_bug.cgi?id=114887

Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

Pass data URL through URL decoding before passing to platform media player.  PR 313635.

Reviewed internally by Liam Quinn

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix an incorrect rebaseline done in r148830.
jberlin@webkit.org [Mon, 22 Apr 2013 16:40:24 +0000 (16:40 +0000)]
Fix an incorrect rebaseline done in r148830.

Instead of updating the cross platform wk2 results, r148830 should have added efl wk2
specific results. Move the previous mac wk2 specific results into the mac wk2 platform
directory.

* platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt: Renamed from LayoutTests/platform/wk2/loader/go-back-cached-main-resource-expected.txt.
* platform/mac-wk2/loader/go-back-cached-main-resource-expected.txt: Downloaded from the mac-wk2 bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory barrier support should also ensure that we always do a compiler fence
fpizlo@apple.com [Mon, 22 Apr 2013 16:32:53 +0000 (16:32 +0000)]
Memory barrier support should also ensure that we always do a compiler fence
https://bugs.webkit.org/show_bug.cgi?id=114934

Reviewed by Michael Saboff.

This is a cherry-pick merge of the WTF part of r148836 from the dfgFourthTier
branch. It fixes a memory ordering bug that is likely asymptomatic, but
nonetheless real: TCSpinLock expects that using a memoryBarrierBeforeUnlock()
prior to setting lockword_ to 0 will ensure that the assignment to lockword_
won't get floated above any of the stores in the critical section. While that
memory barrier does indeed do the right thing on ARM, it doesn't do the right
thing on other architectures: it turns into empty code that the compiler blows
away, which is fine for the hardware since X86 won't reorder that store - but
it's not fine for the compiler, which may still do its own reorderings.

The WTF part of r148836 fixes this by using a compiler fence: an empty asm
volatile block that is marked as clobbering memory.

Instead of doing a separate surgical fix in trunk, I decided to merge the
whole WTF change over, to make merging easier in the future.

Performance testing of this change in dfgFourthTier showed no regression.

* wtf/Atomics.h:
(WTF::compilerFence):
(WTF::armV7_dmb):
(WTF::armV7_dmb_st):
(WTF::loadLoadFence):
(WTF::loadStoreFence):
(WTF::storeLoadFence):
(WTF::storeStoreFence):
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock):
(WTF::x86_mfence):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
carlosgc@webkit.org [Mon, 22 Apr 2013 16:03:21 +0000 (16:03 +0000)]
[GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111848

Reviewed by Anders Carlsson.

This allow applications to set a custom directory for the disk
cache.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_disk_cache_directory):
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/TestMain.cpp:
(removeNonEmptyDirectory):
(main): Use a different temporary disk cache directory for every
test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SOUP] Soup disk cache should respect the diskCacheDirectory from the process initial...
carlosgc@webkit.org [Mon, 22 Apr 2013 15:57:22 +0000 (15:57 +0000)]
[SOUP] Soup disk cache should respect the diskCacheDirectory from the process initial parameters
https://bugs.webkit.org/show_bug.cgi?id=111845

Reviewed by Anders Carlsson.

Move the cache initialization to platformInitializeWebProcess() to
create the cache using the directory received from the UI
process. This allows to add public API to set a different disk
cache directory from the UI process.

* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Return
default disk cache directory.
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory): Ditto.
* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl): Remove soup cache initialization.
* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): Ditto.
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize
soup cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
commit-queue@webkit.org [Mon, 22 Apr 2013 15:43:59 +0000 (15:43 +0000)]
[BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
https://bugs.webkit.org/show_bug.cgi?id=114892

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-22
Reviewed by Rob Buis.
PR 328147

Modify the client so we only have one listener for battery change events.
The dispatch of different event listeners are handled by BatteryController.

* WebCoreSupport/BatteryClientBlackBerry.cpp:
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::onStatusChange):
* WebCoreSupport/BatteryClientBlackBerry.h:
(BatteryClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF::AtomicString::find() should take unsigned 'start' argument
ddkilzer@apple.com [Mon, 22 Apr 2013 15:31:30 +0000 (15:31 +0000)]
WTF::AtomicString::find() should take unsigned 'start' argument
<http://webkit.org/b/114958>

Reviewed by Darin Adler.

Fixes the following warnings with -Wshorten-64-to-32:

    AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
        size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); }
                                                              ~~~~~~~~         ^~~~~
    AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
            { return m_string.find(s, start, caseSentitive); }
                     ~~~~~~~~         ^~~~~
    AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
            { return m_string.find(s, start, caseSentitive); }
                     ~~~~~~~~         ^~~~~

* wtf/text/AtomicString.h:
(WTF::AtomicString::find): Change type of 'start' argument from
size_t to unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Fix build warning when GESTURE_EVENTS is ON.
commit-queue@webkit.org [Mon, 22 Apr 2013 15:20:07 +0000 (15:20 +0000)]
[WK2] Fix build warning when GESTURE_EVENTS is ON.
https://bugs.webkit.org/show_bug.cgi?id=114812

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-22
Reviewed by Andreas Kling.

Handle GestureSingleTap in the event type switch.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate layout test verifying Tab behaves correctly after linking to fragment ID
commit-queue@webkit.org [Mon, 22 Apr 2013 15:02:26 +0000 (15:02 +0000)]
Update layout test verifying Tab behaves correctly after linking to fragment ID
https://bugs.webkit.org/show_bug.cgi?id=114645

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-04-22
Reviewed by Chris Fleizach.

* fast/dom/fragment-activation-focuses-target.html: Updated test.
* fast/dom/fragment-activation-focuses-target-expected.txt: Updated expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix build warning(unused parameter)
commit-queue@webkit.org [Mon, 22 Apr 2013 14:26:28 +0000 (14:26 +0000)]
fix build warning(unused parameter)
https://bugs.webkit.org/show_bug.cgi?id=114855

Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

Source/WebCore:

remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
* platform/graphics/blackberry/FontBlackBerry.cpp:
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):
* platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::drawTile):
* platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):
* platform/graphics/blackberry/PatternBlackBerry.cpp:
(WebCore::Pattern::platformPattern):

Source/WebKit/blackberry:

remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::extractedTextRequest):

Tools:

remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp

* DumpRenderTree/blackberry/EventSender.cpp:
(getDragModeCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
commit-queue@webkit.org [Mon, 22 Apr 2013 14:24:52 +0000 (14:24 +0000)]
[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=114741

Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-22
Reviewed by George Staikos.

Consider the case where a ResourceHandle won't have a FilterStream
object associated (for example, Blob objects) instead of ASSERTing
pointlessly when asking our network layer for such an object.

This partially fixes fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add additional datalist support.
mifenton@rim.com [Mon, 22 Apr 2013 14:19:24 +0000 (14:19 +0000)]
[BlackBerry] Add additional datalist support.
https://bugs.webkit.org/show_bug.cgi?id=114883

Reviewed by Rob Buis.

PR 210083.

Source/WebCore:

Extend support for datalist to include all non-popup input types.

Re-enabling fast/forms/datalist/input-list

Internally Reviewed by Otto Cheung.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::supportsDataListUI):

Source/WebKit/blackberry:

Properly set state when opening a Date/Time popup and simplify
the logic for showing datalist options.

Internally Reviewed by Otto Cheung.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):

LayoutTests:

Fix results for fast/forms/datalist/input-list.

Internally Reviewed by Otto Cheung.

* platform/blackberry/fast/forms/datalist/input-list-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Add tests for lists and counters
abucur@adobe.com [Mon, 22 Apr 2013 12:39:24 +0000 (12:39 +0000)]
[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975

Reviewed by Andreas Kling.

Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.

* fast/regions/counters/extract-list-items-001-expected.html: Added.
* fast/regions/counters/extract-list-items-001.html: Added.
* fast/regions/counters/extract-list-items-002-expected.html: Added.
* fast/regions/counters/extract-list-items-002.html: Added.
* fast/regions/counters/extract-list-items-003-expected.html: Added.
* fast/regions/counters/extract-list-items-003.html: Added.
* fast/regions/counters/extract-list-items-004-expected.html: Added.
* fast/regions/counters/extract-list-items-004.html: Added.
* fast/regions/counters/extract-list-items-005-expected.html: Added.
* fast/regions/counters/extract-list-items-005.html: Added.
* fast/regions/counters/extract-list-items-006-expected.html: Added.
* fast/regions/counters/extract-list-items-006.html: Added.
* fast/regions/counters/extract-list-items-007-expected.html: Added.
* fast/regions/counters/extract-list-items-007.html: Added.
* fast/regions/counters/extract-list-items-008-expected.html: Added.
* fast/regions/counters/extract-list-items-008.html: Added.
* fast/regions/counters/extract-list-items-009-expected.html: Added.
* fast/regions/counters/extract-list-items-009.html: Added.
* fast/regions/counters/extract-list-items-010-expected.html: Added.
* fast/regions/counters/extract-list-items-010.html: Added.
* fast/regions/counters/extract-list-items-011-expected.html: Added.
* fast/regions/counters/extract-list-items-011.html: Added.
* fast/regions/counters/extract-list-items-012-expected.html: Added.
* fast/regions/counters/extract-list-items-012.html: Added.
* fast/regions/counters/extract-list-items-013-expected.html: Added.
* fast/regions/counters/extract-list-items-013.html: Added.
* fast/regions/counters/extract-list-items-014-expected.html: Added.
* fast/regions/counters/extract-list-items-014.html: Added.
* fast/regions/counters/extract-list-items-015-expected.html: Added.
* fast/regions/counters/extract-list-items-015.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
* fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
* fast/regions/counters/extract-numbered-paragraphs.html: Added.
* fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
* fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
* fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
* fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
* fast/regions/counters/extract-unordered-lists-in-regions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, gardening. css3-device-adaptation doesn't work for WK1 EFL properly.
gyuyoung.kim@samsung.com [Mon, 22 Apr 2013 11:51:25 +0000 (11:51 +0000)]
Unreviewed, gardening. css3-device-adaptation doesn't work for WK1 EFL properly.

* platform/efl-wk1/TestExpectations: Added tests related to css3-device-adaptation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 11:42:10 +0000 (11:42 +0000)]
Unreviewed EFL gardening.

Mark IndexedDB test as crashing in Release mode and fix duplicate line in
TestExpectations.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL WK1 gardening. Skip pasteboard tests because EFL WK1 doesn't support...
gyuyoung.kim@samsung.com [Mon, 22 Apr 2013 10:56:35 +0000 (10:56 +0000)]
Unreviewed, EFL WK1 gardening. Skip pasteboard tests because EFL WK1 doesn't support it yet.

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 10:51:47 +0000 (10:51 +0000)]
Unreviewed EFL gardening.

Skip several compositing test cases on EFL WK2 due to regression in
r148748.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 10:41:50 +0000 (10:41 +0000)]
Unreviewed EFL gardening.

Add several regressions to TestExpectations to make the tree green.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 10:32:01 +0000 (10:32 +0000)]
Unreviewed EFL gardening.

Fix expected result for several test cases.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 22 Apr 2013 10:07:21 +0000 (10:07 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Unskipping the fast/sub-pixel layout tests.
Removing failure expectations for tests that are passing after the subpixel layout was enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
commit-queue@webkit.org [Mon, 22 Apr 2013 09:58:33 +0000 (09:58 +0000)]
[BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
https://bugs.webkit.org/show_bug.cgi?id=114861

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

* platform/blackberry/DragDataBlackBerry.cpp:
(WebCore):
(WebCore::DragData::droppedFileSystemId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Mon, 22 Apr 2013 09:20:45 +0000 (09:20 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skip a failing reftest after r148859.
* platform/qt/fast/borders/rtl-border-04-expected.png: Update after r148791.
* platform/qt/fast/borders/rtl-border-04-expected.txt: Update after r148791.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Mon, 22 Apr 2013 09:14:45 +0000 (09:14 +0000)]
[Qt] Unreviewed gardening.

Unskip fast/exclusions tests after r148594.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
commit-queue@webkit.org [Mon, 22 Apr 2013 09:11:38 +0000 (09:11 +0000)]
[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
https://bugs.webkit.org/show_bug.cgi?id=114939

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

This was added in r129308.

* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::accessibleElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] accessibility/language-attribute.html is failing
commit-queue@webkit.org [Mon, 22 Apr 2013 09:07:52 +0000 (09:07 +0000)]
[EFL] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112030

Unreviewed, EFL gardening.

Unskipping accessibility/language-attribute.html after r148737.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-22

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [CSS Regions] Elements in a region should be assignable to a named...
commit-queue@webkit.org [Mon, 22 Apr 2013 09:05:52 +0000 (09:05 +0000)]
Source/WebCore: [CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-22
Reviewed by David Hyatt.

DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.

NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.

Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.

RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.

Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.
       fast/regions/region-content-flown-into-region.html
       fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.

* dom/Element.cpp:
(WebCore::Element::moveToFlowThreadIsNeeded):
* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
* dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.
* dom/Text.h:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.
* svg/SVGElement.h:

LayoutTests:  [CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144

 Reviewed by David Hyatt.

 * fast/regions/flow-body-in-html-expected.txt: Added.
Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-22

* fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
* fast/regions/region-content-flown-into-region-expected.txt: Added.
* fast/regions/region-content-flown-into-region.html: Added.
* fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
* fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGradient: add PlatformGradient definition for BlackBerry
commit-queue@webkit.org [Mon, 22 Apr 2013 08:59:18 +0000 (08:59 +0000)]
Gradient: add PlatformGradient definition for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=114727

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

* platform/graphics/Gradient.h:
(Graphics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse DOM ordering for list counts
abucur@adobe.com [Mon, 22 Apr 2013 08:32:28 +0000 (08:32 +0000)]
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352

Reviewed by Elliott Sprehn.

Source/WebCore:

Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.

To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.

In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975

Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html

* dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
* dom/Node.h:
(Node):
* dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
* dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
* rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
* rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
* rendering/RenderListItem.h:
(RenderListItem):

LayoutTests:

The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.

* fast/dom/shadow/shadow-and-list-elements-expected.html:
* fast/lists/positioned-count-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix multiple definition of ImageBuffer::platformLayer() in the BlackBerry port
commit-queue@webkit.org [Mon, 22 Apr 2013 07:57:46 +0000 (07:57 +0000)]
Fix multiple definition of ImageBuffer::platformLayer() in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114936

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

We already have a definition in ImageBufferBlackBerry.cpp.

* platform/graphics/ImageBuffer.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Cleanup TestExpectations to pass --lint-test-files
commit-queue@webkit.org [Mon, 22 Apr 2013 07:49:47 +0000 (07:49 +0000)]
[GTK] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=114927

Unreviewed gardening.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-22

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2] Plugins without a MIME Type fail to load
carlosgc@webkit.org [Mon, 22 Apr 2013 07:25:12 +0000 (07:25 +0000)]
[WebKit2] Plugins without a MIME Type fail to load
https://bugs.webkit.org/show_bug.cgi?id=112834

Reviewed by Benjamin Poulain.

Source/WebKit2:

The problem is that when the plugin is created and the MIME Type
is empty, since the MIME Type guessed in the UI process using the
plugin extension is not passed to the WebProcess, when the plugin
is instantiated, the value of NPMIMEType parameter passed to
NPP_New is NULL, and NPERR_INVALID_INSTANCE_ERROR is returned.
GetPluginPath message has been renamed to FindPlugin, since it
doesn't only return the path but also the new MIME Type and load
policy.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Receive an output newMIMEType
parameter that is passed to PluginModuleInfo::findPlugin() so that
in case of guessing the MIME Type, the new one is passed back to
the WebProcess.
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Pass the MIME Type
from the parameters to WebPage::createPlugin.
(WebKit::WebFrameLoaderClient::recreatePlugin): Pass a newMIMEType
parameter to WebPage::createPlugin.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Add newMIMEType out parameter and
pass it to the FindPlugin message.
(WebKit::WebPage::canPluginHandleResponse): Pass newMIMEType to
FindPlugin message.
* WebProcess/WebPage/WebPage.h:
(WebPage):

LayoutTests:

* platform/wk2/TestExpectations: Unskip
plugins/no-mime-with-valid-extension.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDivision by zero in CSSGradientValue::addStops()
commit-queue@webkit.org [Mon, 22 Apr 2013 06:54:32 +0000 (06:54 +0000)]
Division by zero in CSSGradientValue::addStops()
https://bugs.webkit.org/show_bug.cgi?id=114807

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-21
Reviewed by Dean Jackson.

Source/WebCore:

The normalization of the color stop positions of a linear gradient
doesn't take into account that the first and last position can be
the same. In such case the positions are computed dividing by 0.
Clamp the positions to 1 without moving the end points in such
case to match what other browsers do. This ensures that positions
passed to the platform gradient are in the 0-1 range which fixes a
crash due to an assert in BlackBerry port running test
fast/forms/type-after-focus-rule-shrink-width.html.

Test: fast/gradients/css3-color-stop-invalid.html

* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):

LayoutTests:

* fast/gradients/css3-color-stop-invalid-expected.html: Added.
* fast/gradients/css3-color-stop-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL build fix after r148855.
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 06:52:25 +0000 (06:52 +0000)]
Unreviewed EFL build fix after r148855.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove StringImpl code density for older ARM hardware
benjamin@webkit.org [Mon, 22 Apr 2013 06:21:22 +0000 (06:21 +0000)]
Improve StringImpl code density for older ARM hardware
https://bugs.webkit.org/show_bug.cgi?id=114898

Reviewed by Geoffrey Garen.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

Source/WTF:

Reduce the number of instructions needed for StringImpl::deref
on older ARM hardware.

The extra indirection should have a negligible impact on x86_64.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::destroy):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::deref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r148851.
rniwa@webkit.org [Mon, 22 Apr 2013 06:06:18 +0000 (06:06 +0000)]
Unreviewed, rolling out r148851.
http://trac.webkit.org/changeset/148851
https://bugs.webkit.org/show_bug.cgi?id=114935

EFL Buildbot reports fail after gardening on r148851
(Requested by gyuyoung on #webkit).

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
ch.dumez@sisa.samsung.com [Mon, 22 Apr 2013 06:00:01 +0000 (06:00 +0000)]
[EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114922

Reviewed by Gyuyoung Kim.

Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix some minor bad use of strings in WebCore
benjamin@webkit.org [Mon, 22 Apr 2013 05:54:11 +0000 (05:54 +0000)]
Fix some minor bad use of strings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114907

Reviewed by Darin Adler.

* editing/Editor.cpp:
(WebCore::Editor::selectedText): This was implicitly getting the emptyString()
for the argument "".
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::takeResults): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions
krit@webkit.org [Mon, 22 Apr 2013 04:39:07 +0000 (04:39 +0000)]
[Part 4] Parse the custom() function in -webkit-filter: parse the matN() functions
https://bugs.webkit.org/show_bug.cgi?id=71444

Reviewed by Dean Jackson.

Source/WebCore:

Custom filter parameters should support mat2 to mat4 value functions. Added parsing
and style resolving bits to support the matrix function values. A later patch will
add the matrices to the shader program.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters

Modified existing tests to cover changes.

* GNUmakefile.list.am: Added WebKitCSSMatFunctionValue to individual build systems.
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterMatParameter):
(WebCore):
(WebCore::valueForCustomFilterParameter):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseMatValue):
(WebCore):
(WebCore::CSSParser::parseCustomFilterParameters):
* css/CSSParser.h:
(WebCore):
* css/CSSValue.cpp:
(WebCore::CSSValue::reportMemoryUsage):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
* css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSMatFunctionValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
* css/StyleResolver.h:
(StyleResolver):
* css/WebKitCSSMatFunctionValue.cpp:
(WebCore::WebKitCSSMatFunctionValue::WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::customCssText):
(WebCore::WebKitCSSMatFunctionValue::cloneForCSSOM):
(WebCore::WebKitCSSMatFunctionValue::equals):
(WebCore::WebKitCSSMatFunctionValue::reportDescendantMemoryUsage):
* css/WebKitCSSMatFunctionValue.h:
(WebKitCSSMatFunctionValue):
(WebCore::WebKitCSSMatFunctionValue::create):
* platform/graphics/filters/CustomFilterArrayParameter.h:
(WebCore::CustomFilterArrayParameter::create):
(WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
* platform/graphics/filters/CustomFilterParameter.h:
(CustomFilterParameter):
* platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramParameters):

LayoutTests:

Added tests for mat2 to mat4 parameter functions on custom fiter function and
parameter descriptor.

* css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js:
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL gardening. Remove test cases which are expected failed, but passed...
gyuyoung.kim@samsung.com [Mon, 22 Apr 2013 02:16:09 +0000 (02:16 +0000)]
Unreviewed, EFL gardening. Remove test cases which are expected failed, but passed now.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJS Lexer and Parser should be more informative when they encounter errors
oliver@apple.com [Sun, 21 Apr 2013 23:26:56 +0000 (23:26 +0000)]
JS Lexer and Parser should be more informative when they encounter errors
https://bugs.webkit.org/show_bug.cgi?id=114924

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add new tokens to represent the various ways that parsing and lexing have failed.
This gives us the ability to produce better error messages in some cases,
and to indicate whether or not the failure was due to invalid source, or simply
early termination.

The jsc prompt now makes use of this so that you can write functions that
are more than one line long.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* jsc.cpp:
(stringFromUTF):
(jscSource):
(runInteractive):
* parser/Lexer.cpp:
(JSC::::parseFourDigitUnicodeHex):
(JSC::::parseIdentifierSlowCase):
(JSC::::parseString):
(JSC::::parseStringSlowCase):
(JSC::::lex):
* parser/Lexer.h:
(UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::UnicodeHexValue):
(JSC::Lexer::UnicodeHexValue::valueType):
(JSC::Lexer::UnicodeHexValue::isValid):
(JSC::Lexer::UnicodeHexValue::value):
(Lexer):
* parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::::parse):
* parser/ParserError.h:
(ParserError):
(JSC::ParserError::ParserError):
* parser/ParserTokens.h:
* runtime/Completion.cpp:
(JSC):
(JSC::checkSyntax):
* runtime/Completion.h:
(JSC):

LayoutTests:

Update test results to cover improved error messages.

* fast/js/kde/parse-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T10-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T9-expected.txt:
* sputnik/Conformance/13_Function_Definition/S13_A7_T3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r148672): fast/events/touch/frame-hover-update.html fails
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 20:52:35 +0000 (20:52 +0000)]
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912

Reviewed by Allan Sandfeld Jensen.

Fix relative path to js-test-post.js in fast/events/touch/frame-hover-update.html.

* fast/events/touch/frame-hover-update.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRewrite fast/workers/dedicated-worker-lifecycle.html to verify that
mark.lam@apple.com [Sun, 21 Apr 2013 20:28:04 +0000 (20:28 +0000)]
Rewrite fast/workers/dedicated-worker-lifecycle.html to verify that
the GC is able to reclaim orphaned Workers on a timely basis.
https://bugs.webkit.org/show_bug.cgi?id=114893.

Reviewed by Geoffrey Garen.

* fast/workers/resources/dedicated-worker-lifecycle.js:
(orphanAllWorkers):
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
* fast/workers/resources/worker-util.js:
(waitUntilThreadCountMatchesCondition):
(waitUntilThreadCountMatches):
(waitUntilThreadCountDoesNotExceed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 19:51:22 +0000 (19:51 +0000)]
Unreviewed EFL gardening.

Mark css1/cascade/cascade_order.html as flaky.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 19:48:40 +0000 (19:48 +0000)]
Unreviewed EFL gardening.

Mark several webgl tests as flaky.
Mark several ref tests as failing (started between r148032 and r148102).

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 19:15:20 +0000 (19:15 +0000)]
Unreviewed EFL gardening.

Mark websocket tests as flaky and webgl/conformance/rendering/gl-scissor-test.html
as failing.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Media attribute preload="none" is not honored
kbalazs@webkit.org [Sun, 21 Apr 2013 18:36:58 +0000 (18:36 +0000)]
[GStreamer] Media attribute preload="none" is not honored
https://bugs.webkit.org/show_bug.cgi?id=114357

Reviewed by Philippe Normand.

Source/WebCore:

Fix the logic that prevents live streams from being buffered to not make preload="none" ignored.

Test: http/tests/media/video-preload.html
We need a http test because the bug does not triggered with local files.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
Remove m_originalPreloadWasAutoAndWasOverridden because it is not necessary and it is causing this bug.
Currently if the tag has preload="none" attribute we set m_preload to Auto in the constructor. After that
MedaPlayer calls setPreload(None), so we set m_originalPreloadWasAutoAndWasOverridden to true and later
reset m_preload to Auto. The error prone factor here is that the m_preload member is repeated in the
private class and setPreload is also used there. This seems to be necessary because we need to be able
to ignore preloading if this is a live stream. Fortunately the original parsed value is available in the
constructor, so we can use that. This will give the correct value that we should override only in the case
of a live stream and that's it, we don't need to reset it later to Auto.
Furthermore, we should ignore setting preload to auto from js if it is a live stream. This patch also handles
this with an early return in setPreload.

LayoutTests:

* http/tests/media/video-preload-expected.txt: Added.
* http/tests/media/video-preload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 17:46:21 +0000 (17:46 +0000)]
Unreviewed EFL gardening.

Mark several tests as failing on EFL port due to the bump to libsoup
2.42.0.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 17:34:14 +0000 (17:34 +0000)]
Unreviewed EFL gardening.

Mark several test cases as failing on EFL port and filed bugs for them.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 17:19:42 +0000 (17:19 +0000)]
Unreviewed EFL gardening.

Mark websocket tests as flaky on EFL WK2.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/media/mq-resolution.html throws TypeError when calling setPageScaleFactor
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 16:14:52 +0000 (16:14 +0000)]
fast/media/mq-resolution.html throws TypeError when calling setPageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=114914

Reviewed by Antonio Gomes.

Update fast/media/mq-resolution.html to call setPageScaleFactor() method on
window.internals instead of window.internals.settings. This method was moved
out of settings in r136055.

* fast/media/mq-resolution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 15:11:32 +0000 (15:11 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/forms/validation-message-appearance.html and fix expectation
for editing/pasteboard/paste-text-004.html.

* platform/efl/TestExpectations:
* platform/efl/fast/forms/validation-message-appearance-expected.png: Added.
* platform/efl/fast/forms/validation-message-appearance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 15:02:00 +0000 (15:02 +0000)]
Unreviewed EFL gardening.

Mark more compositing test cases as crashing due to r148433 for
EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r148672): fast/events/touch/frame-hover-update.html fails
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 14:22:04 +0000 (14:22 +0000)]
Regression(r148672): fast/events/touch/frame-hover-update.html fails
https://bugs.webkit.org/show_bug.cgi?id=114912

Reviewed by Allan Sandfeld Jensen.

Fix relative path to js-test-pre.js in the test case.

* fast/events/touch/frame-hover-update.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 14:10:14 +0000 (14:10 +0000)]
Unreviewed EFL gardening.

Rebaseline several test cases for EFL port.

* platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt:
* platform/efl/fast/backgrounds/background-position-parsing-expected.png:
* platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
* platform/wk2/loader/go-back-cached-main-resource-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 13:54:38 +0000 (13:54 +0000)]
Unreviewed EFL gardening.

Remove duplicate entry in EFL's TestExpectations for:
inspector/debugger/dynamic-script-tag.html

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 13:50:01 +0000 (13:50 +0000)]
Unreviewed EFL gardening.

Mark more compisiting / webgl tests as crashing due to r148433 for
EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Removing the remaining redundant baselines.
zandobersek@gmail.com [Sun, 21 Apr 2013 12:56:15 +0000 (12:56 +0000)]
Unreviewed GTK gardening. Removing the remaining redundant baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under accessibility, fast...
zandobersek@gmail.com [Sun, 21 Apr 2013 12:54:00 +0000 (12:54 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under accessibility, fast/backgrounds, fast/body-propagation,
fast/doctypes, fast/fast-mobile-scrolling, fast/inspector-support, fast/loader, fast/tokenizer and fast/xsl directories
after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/block, fast/borders...
zandobersek@gmail.com [Sun, 21 Apr 2013 12:46:05 +0000 (12:46 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/block, fast/borders, fast/box-shadow,
fast/box-sizing, fast/canvas, fast/clip and fast/compact directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 21 Apr 2013 11:06:43 +0000 (11:06 +0000)]
Unreviewed EFL gardening.

Mark several compositing test as crashing on EFL port due to
r148433.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWidget should not depend on AXObjectCache
carlosgc@webkit.org [Sun, 21 Apr 2013 10:07:28 +0000 (10:07 +0000)]
Widget should not depend on AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=114514

Reviewed by Chris Fleizach.

Source/WebCore:

Move AXObjectCache usage from platform files to FrameView.

* WebCore.exp.in: Update symbols.
* page/FrameView.cpp:
(WebCore::FrameView::didAddScrollbar): Handle scrollbar updates in
AXObjectCache.
(WebCore::FrameView::willRemoveScrollbar): Handle scrollbar
updates in AXObjectCache and remove the scrollbar from the cache.
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Use
didAddScrollbar/willRemoveScrollbar
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddScrollbar): This is the old
didAddVerticalScrollbar and didAddHorizontalScrollbar joined in a
single method that receives a ScrollbarOrientation parameter.
(WebCore::ScrollableArea::willRemoveScrollbar): This is the old
willRemoveVerticalScrollbar and
willRemoveHorizontalScrollbarScrollbar joined in a single method
that receives a ScrollbarOrientation parameter.
* platform/ScrollableArea.h:
(ScrollableArea):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar): Remove AXObjectCache usage.
* platform/Scrollbar.h:
* platform/Widget.h:
(Widget): Remove axObjectCache() method.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar): Use didAddScrollbar.
(WebCore::RenderLayer::destroyScrollbar): Use willRemoveScrollbar.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar): Use didAddScrollbar.
(WebCore::RenderListBox::destroyScrollbar): Use willRemoveScrollbar.

Source/WebKit2:

Update to API changes.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::createScrollbar):
* WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::createScrollbar):
(WebKit::SimplePDFPlugin::destroyScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/css, fast/css-gener...
zandobersek@gmail.com [Sun, 21 Apr 2013 09:26:25 +0000 (09:26 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/css, fast/css-generated-content,
fast/css3-text and fast/dom directories after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/dynamic, fast/encod...
zandobersek@gmail.com [Sun, 21 Apr 2013 09:18:07 +0000 (09:18 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/dynamic, fast/encoding, fast/events,
fast/flexbox, fast/forms, fast/frames, fast/gradients, fast/hidpi and fast/html directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
mark.lam@apple.com [Sun, 21 Apr 2013 09:04:09 +0000 (09:04 +0000)]
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.
https://bugs.webkit.org/show_bug.cgi?id=114910.

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/images, fast/inline...
zandobersek@gmail.com [Sun, 21 Apr 2013 08:23:41 +0000 (08:23 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/images, fast/inline, fast/inline-block,
fast/invalid, fast/js, fast/layers, fast/line-grid, fast/lists and fast/multicol directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/overflow, fast...
zandobersek@gmail.com [Sun, 21 Apr 2013 08:15:33 +0000 (08:15 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/overflow, fast/parser, fast/reflections,
fast/regions and fast/repaint directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, gardening. Remove duplicated tests.
gyuyoung.kim@samsung.com [Sun, 21 Apr 2013 08:05:36 +0000 (08:05 +0000)]
Unreviewed, gardening. Remove duplicated tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/replaced, fast...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:48:48 +0000 (07:48 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/replaced, fast/ruby, fast/runin,
fast/scrolling, fast/selectors, fast/spatial-navigation, fast/subpixel and mathml directories after enabling subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating baselines for tests under fast/text, fast/transfor...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:38:24 +0000 (07:38 +0000)]
Unreviewed GTK gardening. Updating baselines for tests under fast/text, fast/transforms, fast/writing-mode,
ietestcenter, media, plugins and scrollbars directories after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Removing redundant baselines under the svg/ directory.
zandobersek@gmail.com [Sun, 21 Apr 2013 07:29:20 +0000 (07:29 +0000)]
Unreviewed GTK gardening. Removing redundant baselines under the svg/ directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Part 2 of updating baselines for tests under svg/dynamic...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:27:50 +0000 (07:27 +0000)]
Unreviewed GTK gardening. Part 2 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Part 1 of updating baselines for tests under svg/dynamic...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:22:34 +0000 (07:22 +0000)]
Unreviewed GTK gardening. Part 1 of updating baselines for tests under svg/dynamic-updates after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Part 3 of updating baselines for tests under the tables...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:15:53 +0000 (07:15 +0000)]
Unreviewed GTK gardening. Part 3 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Part 2 of updating baselines for tests under the tables...
zandobersek@gmail.com [Sun, 21 Apr 2013 07:06:09 +0000 (07:06 +0000)]
Unreviewed GTK gardening. Part 2 of updating baselines for tests under the tables/ directory
after enabling the subpixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148810 268f45cc-cd09-0410-ab3c-d52691b4dbfc