WebKit-https.git
13 years agoJavaScriptCore:
ggaren [Fri, 14 Jul 2006 22:39:58 +0000 (22:39 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - Implemented ref-counting of JSContexts by splitting into two datatypes:
        JSGlobalContext, which you can create/retain/release, and JSContext, which
        you can't.

        Internally, you retain a JSGlobalContext/ExecState by retaining its
        interpreter, which, in the case of a global ExecState, owns it.

        - Also made ~Interpreter() protected to catch places where Interpreter
        is manually deleted. (Can't make it private because some crazy fool
        decided it would be a good idea to subclass Interpreter in other frameworks.
        I pity da fool.)

        * API/APICast.h:
        (toJS): Added cast for new JSGlobalContext
        * API/JSStringRef.h: Changed vague "you must" language to more specific
        (but, ultimately, equally vague) "behavior is undefined if you don't"
        language.
        (KJS::Interpreter::Interpreter): Factored more common initialization into
        init()
        * kjs/interpreter.h:
        (KJS::Interpreter::ref): new
        (KJS::Interpreter::deref): new
        (KJS::Interpreter::refCount): new
        * kjs/testkjs.cpp:
        (doIt): Ref-count the interpreter.

JavaScriptGlue:

        Reviewed by Maciej.

        - Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.

        (JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
        manual delete.

WebCore:

        Reviewed by Maciej.

        - Updated ScriptInterpreter to work with Interpreter ref-counting in
        JavaScriptCore.

        (KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
        manual delete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-07-14 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 14 Jul 2006 20:54:09 +0000 (20:54 +0000)]
2006-07-14  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adele and Justin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9658
        <rdar://problem/4613948>
        REGRESSION: Check Spelling does not work in textarea elements

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::advanceToNextMisspelling):
        Don't use setStartBefore or setEndAfter on the search range because for shadow trees, there
        is no notion of before and after. Instead, use setStart and setEnd and pass in the start and end
        indices respectively.

        * dom/Range.cpp:
        (WebCore::Range::checkNodeBA):
        Allow range operations on shadow trees.

        * manual-tests/form-element-spelling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
mjs [Fri, 14 Jul 2006 20:53:38 +0000 (20:53 +0000)]
    Reviewed by Geoff.

        - removed bool return value from JSObjectSetProperty, since it is inefficient and
        also doesn't work quite right
        - added JSObjectGetPropertyAtIndex and JSObjectSetPropertyAtIndex

        * API/JSObjectRef.cpp:
        (JSObjectSetProperty): Removed return value and canPut stuff.
        (JSObjectGetPropertyAtIndex): Added.
        (JSObjectSetPropertyAtIndex): Added.
        * API/JSObjectRef.h: Prototyped and documented new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
bdakin [Fri, 14 Jul 2006 20:35:03 +0000 (20:35 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4621660> REGRESSION: Safari crashing in
        WebCore::FrameView::updateOverflowStatus

        m_viewportRenderer is never initialized for framesets, and it
        shouldn't be. So we just need to nil-check for it in
        updateOverflowStatus() and return early.

        * page/FrameView.cpp:
        (WebCore::FrameView::updateOverflowStatus): Nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Fri, 14 Jul 2006 19:09:50 +0000 (19:09 +0000)]
WebCore:

        RS by Darin.

        Backing out fix for <rdar://problem/4604703>
        REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

        Darin had a better fix in WebKit for this.

        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):

WebKit:

        Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9625
          <rdar://problem/4604703>
          REGRESSION: Focus not removed from password field after ctrl-click in text field

        * WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Set handlingMouseDownEvent to
        YES while calling sendContextMenuEvent: on the bridge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
adele [Fri, 14 Jul 2006 18:53:03 +0000 (18:53 +0000)]
    Reviewed by Darin.

        - Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs

        * page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
        * bridge/mac/FrameMac.h: ditto.
        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter
        if the input manager says there's marked text.  I added this code for all text field paths.  For widgets, WebCoreTextField.mm
        has code to deal with this case.  But as we convert search, password, and isindex, they will need to do this check too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth.
ggaren [Fri, 14 Jul 2006 17:41:10 +0000 (17:41 +0000)]
    Reviewed by Beth.

        Moved JSCheckScriptSyntax, JSEvaluateScript, and JSGarbageCollect into
        JSBase.h/.cpp. They don't belong in the value-specific or context-specific
        files because they're not part of the value or context implementations.

        * API/JSBase.h:
        * API/JSContextRef.cpp:
        (JSContextGetGlobalObject):
        * API/JSContextRef.h:
        * API/JSValueRef.cpp:
        (JSValueUnprotect):
        * API/JSValueRef.h:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Fri, 14 Jul 2006 13:18:28 +0000 (13:18 +0000)]
WebCore:

        Reviewed by Darin.  Patch by Mitz.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9907
          REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel  mode

        * rendering/RenderText.cpp:
        (WebCore::RenderText::caretRect): Fixed the calculation of the max/min allowed caret
        position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Fri, 14 Jul 2006 13:14:17 +0000 (13:14 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9905
          REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div

        * editing/deleting/delete-at-start-or-end-expected.checksum: Added.
        * editing/deleting/delete-at-start-or-end-expected.png: Added.
        * editing/deleting/delete-at-start-or-end-expected.txt: Added.
        * editing/deleting/delete-at-start-or-end.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9905
          REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div

        Test: editing/deleting/delete-at-start-or-end.html

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed): Added null check.
        (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Fri, 14 Jul 2006 12:33:04 +0000 (12:33 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9879
          REGRESSION: Repro crash when clicking to the side of an anonymous table
        - see also <rdar://problem/4628129> REGRESSION: Repro crash when clicking
          to the side of an anonymous table

        NOTE: Only the layout test part of this patch was landed since an alternate
        fix was committed in r15401:  <rdar://problem/4509393> selected DOM range
        starts with <object>, 0 offset but selection should include the <object>

        * fast/table/click-near-anonymous-table-expected.checksum: Added.
        * fast/table/click-near-anonymous-table-expected.png: Added.
        * fast/table/click-near-anonymous-table-expected.txt: Added.
        * fast/table/click-near-anonymous-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Fri, 14 Jul 2006 12:05:38 +0000 (12:05 +0000)]
WebCore:

        Reviewed by Geoffrey.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9903
          Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber()

        No test cases since there is no change in functionality.

        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::setLength):  Simplified logic by using the
        no-argument getNumber() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
ggaren [Fri, 14 Jul 2006 08:07:05 +0000 (08:07 +0000)]
    Reviewed by Adele.

        - Build fix: don't need BLOCK_OBJC_EXCEPTIONS because we already have
        one surrounding this function, and the nested one makes the compiler
        think our local variable is volatile (seems like a compiler bug to me).

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::sendContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
thatcher [Fri, 14 Jul 2006 07:46:47 +0000 (07:46 +0000)]
    Reviewed by Maciej.

        Make JavaScriptCore a public framework. Adjusted the paths.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
mjs [Fri, 14 Jul 2006 07:45:13 +0000 (07:45 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test cases for <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)

        I included the test case from the bug plus variants for other broken cases that
        were similar but needed separate fixes.

        * fast/table/cell-in-row-before-misnested-text-crash-expected.txt: Added.
        * fast/table/cell-in-row-before-misnested-text-crash.xhtml: Added.
        * fast/table/form-in-row-before-misnested-text-crash-expected.txt: Added.
        * fast/table/form-in-row-before-misnested-text-crash.xhtml: Added.
        * fast/table/form-in-table-before-misnested-text-crash-expected.txt: Added.
        * fast/table/form-in-table-before-misnested-text-crash.xhtml: Added.
        * fast/table/form-in-tbody-before-misnested-text-crash-expected.txt: Added.
        * fast/table/form-in-tbody-before-misnested-text-crash.xhtml: Added.
        * fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: Added.
        * fast/table/row-in-tbody-before-misnested-text-crash.xhtml: Added.
        * fast/table/section-in-table-before-misnested-text-crash-expected.txt: Added.
        * fast/table/section-in-table-before-misnested-text-crash.xhtml: Added.

WebCore:

        Reviewed by Hyatt.

        - fixed <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)

        I also fixed all the similar crash / assertion failure cases I could think of.

        * dom/Node.cpp:
        (WebCore::Node::nextRendererWithSameParent): Helper function for some of the above.
        * dom/Node.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild): Don't allow inserting forms when not in
        an HTML document, since we don't need that quirk and because parsing won't
        do certain render tree fixups. Also watch out for case when inserting before
        the renderer of a misnested child.
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild): ditto
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
thatcher [Fri, 14 Jul 2006 07:15:56 +0000 (07:15 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        Moved JavaScriptCore to be a public framework.

        * JavaScriptCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Maciej.

        Moved JavaScriptCore to be a public framework.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
adele [Fri, 14 Jul 2006 06:48:17 +0000 (06:48 +0000)]
    Reviewed by Maciej.

        - Fix for <rdar://problem/4604703>
        REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

        Test:
        * manual-tests/password-ctrl-click-lose-focus.html: Added.

        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
        If we're about to set a selection in the current view, make sure its the first responder.
        In this case, this will cause the password field to resign first responder at the right time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Fri, 14 Jul 2006 04:42:01 +0000 (04:42 +0000)]
LayoutTests:

        Reviewed by Hyatt.  Patch by Mitz.

        - test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9670
          REGRESSION: RTL white-space:pre-wrap text is offset to the right

        * editing/deleting/delete-to-select-table-expected.txt:
        * editing/execCommand/boldSelection-expected.txt:
        * editing/execCommand/italicizeByCharacter-expected.txt:
        * editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * editing/execCommand/print-expected.txt:
        * editing/execCommand/selectAll-expected.txt:
        * editing/execCommand/strikethroughSelection-expected.txt:
        * editing/inserting/insert-div-027-expected.txt:
        * editing/selection/after-line-wrap-expected.txt:
        * editing/selection/mixed-editability-1-expected.txt:
        * editing/selection/select-all-001-expected.txt:
        * editing/selection/select-all-002-expected.txt:
        * editing/selection/select-all-003-expected.txt:
        * fast/clip/outline-overflowClip-expected.txt:
        * fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
        * fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
        * fast/text/international/rtl-white-space-pre-wrap-expected.txt: Added.
        * fast/text/international/rtl-white-space-pre-wrap.html: Added.
        * fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
        * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:

WebCore:

        Reviewed by Hyatt.  Patch by Mitz.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9670
          REGRESSION: RTL white-space:pre-wrap text is offset to the right

        Test: fast/text/international/rtl-white-space-pre-wrap.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::caretRect): Fixed LTR case and added the RTL case
        of clipping the caret position to the text box when the caret is after
        the trailing space of an autowrapped line.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to truncate-
        to-fit the logically last text box if it contains the trailing spaces of an
        autowrapped line.
        (WebCore::RenderBlock::bidiReorderLine): Remember the logically last text run.
        In the case of autowrapped text with white space that overflows beyond the line,
        the last text run is the one containing the overflowing white space.
        (WebCore::RenderBlock::findNextLineBreak): Split overflowing white space on a
        line that autowraps only after white space into a separate text run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Fri, 14 Jul 2006 03:29:38 +0000 (03:29 +0000)]
JavaScriptCore:

        Reviewed by Geoffrey.  Patch by Mark Rowe.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
        Bug 9742: REGRESSION: WebKit hangs when loading <http://www.vtbook.com>

        * kjs/value.h:
        (KJS::JSValue::getUInt32): Only types tagged as numeric can be converted to UInt32.

LayoutTests:

        Reviewed by Geoffrey.  Patch by Mark Rowe.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
        Bug 9742: REGRESSION: WebKit hangs when loading <http://www.vtbook.com>

        This includes tests for indexing an array with immediate types, and for
        setting selectField.options.length to immediate types.

        * fast/dom/select-selectedIndex-expected.txt:
        * fast/dom/select-selectedIndex-multiple-expected.txt:
        * fast/dom/select-selectedIndex-multiple.html: Update to test setting length to true and false.
        * fast/dom/select-selectedIndex.html: Ditto.
        * fast/js/array-index-immediate-types-expected.txt: Added.
        * fast/js/array-index-immediate-types.html: Added.
        * fast/js/resources/array-index-immediate-types.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
bdakin [Fri, 14 Jul 2006 02:37:07 +0000 (02:37 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9795
          REGRESSION: Crash in [WebHTMLView(WebPrivate)
          _updateMouseoverWithEvent:]
          and http://bugzilla.opendarwin.org/show_bug.cgi?id=9850
          REGRESSION: Assertion failure (SHOULD NEVER BE REACHED) in -
          [WebHTMLView(WebPrivate) removeTrackingRect:]

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if
        the view has already been closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt.
harrison [Thu, 13 Jul 2006 23:17:08 +0000 (23:17 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/4624203> -webkit-highlight should be behind images

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        Call custom highlighter before painting the image, marker, or widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Thu, 13 Jul 2006 21:08:56 +0000 (21:08 +0000)]
LayoutTests:

        Reviewed by Justin and Levi.

        <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

        * editing/deleting/delete-by-word-001-expected.checksum: Added.
        * editing/deleting/delete-by-word-001-expected.png: Added.
        * editing/deleting/delete-by-word-001-expected.txt: Added.
        * editing/deleting/delete-by-word-001.html: Added.
        * editing/deleting/delete-by-word-002-expected.checksum: Added.
        * editing/deleting/delete-by-word-002-expected.png: Added.
        * editing/deleting/delete-by-word-002-expected.txt: Added.
        * editing/deleting/delete-by-word-002.html: Added.

WebCore:

        Reviewed by Justin and Levi.

        <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

        * Tests:
        editing/deleting/delete-by-word-001.html
        editing/deleting/delete-by-word-002.html

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        (WebCore::TypingCommand::doApply):
        * editing/TypingCommand.h:
        Delete and forward delete to use specified granularity.
        Undo of delete and forward delete to select what had been deleted (non-char granularity only).

        * page/Frame.cpp:
        (WebCore::Frame::setSelection):
        Close typing and end style even if selection is not changing.
        * page/Frame.h:
        Remove unused setSelection parameter keepTypingStyle.

WebKit:

        Reviewed by Justin and Levi.

        <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

        * Tests:
        editing/deleting/delete-by-word-001.html
        editing/deleting/delete-by-word-002.html

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
lweintraub [Thu, 13 Jul 2006 18:28:28 +0000 (18:28 +0000)]
LayoutTests:

        Reviewed by justin

        <rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

        * editing/deleting/delete-block-table-expected.checksum: Added.
        * editing/deleting/delete-block-table-expected.png: Added.
        * editing/deleting/delete-block-table-expected.txt: Added.
        * editing/deleting/delete-block-table.html: Added.
        * editing/deleting/delete-hr-expected.checksum: Added.
        * editing/deleting/delete-hr-expected.png: Added.
        * editing/deleting/delete-hr-expected.txt: Added.
        * editing/deleting/delete-hr.html: Added.
        * editing/deleting/delete-to-select-table-expected.png:
        * editing/execCommand/insertHorizontalRule-expected.txt:
        * fast/lists/markers-in-selection-expected.txt:

WebCore:

        Reviewed by justin

        <rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd): Added selection expansion for HRs.
        (WebCore::DeleteSelectionCommand::initializePositionData): Now uses enclosingBlockFlowOrTableElement
        instead of enclosingBlockFlowElement.
        (WebCore::DeleteSelectionCommand::removeNode): Use to identify that we need a placeholder
        when the start or end block is removed.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): Added check for canHaveChildrenForEditing
        to keep things like HRs from being given children.
        (WebCore::DeleteSelectionCommand::doApply): Switched to use member variable for needPlaceholder.
        * editing/DeleteSelectionCommand.h: Made needPlaceholder a member variable.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed): Fixed selection bug for tables and open typing commands.
        (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
        * editing/htmlediting.cpp:
        (WebCore::editingIgnoresContent): Added check for HRs, since it's not considered a widget.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Fix for HRs and tables.
        (WebCore::endOfParagraph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
thatcher [Thu, 13 Jul 2006 18:27:07 +0000 (18:27 +0000)]
    Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
        Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit

        <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Thu, 13 Jul 2006 18:06:15 +0000 (18:06 +0000)]
    Reviewed by Darin.

        <rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
        to next control instead of inserting a tab space.

        Change editible WebView's tabKeyCyclesThroughElements to NO only
        if the setTabKeyCyclesThroughElements SPI wasn't called.

        * WebView/WebView.m:
        (-[WebView setEditable:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Thu, 13 Jul 2006 15:54:37 +0000 (15:54 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9880
          Memory leaks running DOM-Hanoi

        No change in behavior, thus no test included.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries -
        the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Pleasing to Maciej.
ggaren [Thu, 13 Jul 2006 08:56:52 +0000 (08:56 +0000)]
    Pleasing to Maciej.

        - Renamed JSEvaluate -> JSEvaluateScript, JSCheckSyntax -> JSCheckScriptSyntax
        - Added exception out parameters to JSValueTo* and JSValueIsEqual because
        they can throw
        - Removed JSObjectGetDescription because it's useless and vague, and
        JSValueToString/JSValueIsObjectOfClass do a better job, anyway
        - Clarified comments about "IsFunction/Constructor" to indicate that they
        are true of all functions/constructors, not just those created by JSObjectMake*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Timothy.
thatcher [Thu, 13 Jul 2006 07:11:23 +0000 (07:11 +0000)]
    Reviewed by Timothy.

        Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9889

        * Drosera/debugger.js:  Track whether we paused during the execution of willLeaveFrame.  If
        so, have stepOut pause on the next call to willExecuteStatement rather than second.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Thu, 13 Jul 2006 04:52:03 +0000 (04:52 +0000)]
WebCore:

        Reviewed by Adele.  Patch by Mitz.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9862
          REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF
        - see also <rdar://problem/4622407>

        Test: fast/frames/repaint-display-none-crash.html

        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle): Added null checking of the owner element's
        renderer, which can be null if the iframe is set to display:none.

LayoutTests:

        Reviewed by Adele.  Patch by Mitz.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9862
          REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF
        - see also <rdar://problem/4622407>

        * fast/frames/repaint-display-none-crash-expected.txt: Added.
        * fast/frames/repaint-display-none-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 13 Jul 2006 02:31:39 +0000 (02:31 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4509393>
        selected DOM range starts with <object>, 0 offset but selection should include the <object>

        * editing/selection/legal-positions-expected.txt: Added.
        * editing/selection/legal-positions.html: Added.

        * editing/deleting/delete-3608430-fix-expected.txt:
        * editing/deleting/delete-image-001-expected.txt:
        * editing/deleting/delete-image-002-expected.txt:
        * editing/deleting/delete-image-003-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/replaced-boundaries-3-expected.txt:
        * editing/selection/select-box-expected.txt:

WebCore:

        Reviewed by levi

        <rdar://problem/4509393>
        selected DOM range starts with <object>, 0 offset but selection should include the <object>

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMergeStart):
        Don't pull content out of a table cell.
        * editing/htmlediting.cpp:
        (WebCore::editingIgnoresContent): Added <select> nodes.
        (WebCore::rangeCompliantEquivalent): Convert [node, 0] positions to positionBeforeNode(node)
        for more types of nodes.
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::positionForCoordinates):
        Fix a crasher when right clicking on an anonymous table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago RS by Beth.
ggaren [Thu, 13 Jul 2006 02:15:28 +0000 (02:15 +0000)]
    RS by Beth.

        Finished previously approved JSInternalString -> JSString conversion
        by renaming the files.

        * API/JSCallbackObject.cpp:
        * API/JSInternalStringRef.cpp: Removed.
        * API/JSInternalStringRef.h: Removed.
        * API/JSStringRef.cpp: Added.
        * API/JSStringRef.h: Added.
        * API/JavaScriptCore.h:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson (and written by Justin Garcia)
sullivan [Thu, 13 Jul 2006 00:36:58 +0000 (00:36 +0000)]
    Reviewed by Brady Eidson (and written by Justin Garcia)

        - layout test corresponding to <rdar://problem/4611164>

        * editing/undo/undo-misspellings-expected.checksum: Added.
        * editing/undo/undo-misspellings-expected.png: Added.
        * editing/undo/undo-misspellings-expected.txt: Added.
        * editing/undo/undo-misspellings.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson
sullivan [Thu, 13 Jul 2006 00:29:36 +0000 (00:29 +0000)]
    Reviewed by Brady Eidson

        - fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of
        misspelled words (WebCore::RenderObject::repaint(bool)

        * dom/Document.cpp:
        (WebCore::Document::removeMarkers):
        put (it - markers.begin()) in a local variable before altering markers, in every case where this was
        happening. One of the cases like this was fixed a while back, but other cases were
        either missed at that time or crept in since.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca [Thu, 13 Jul 2006 00:20:57 +0000 (00:20 +0000)]
WebCore:

2006-07-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Justin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
        REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus

        * dom/Document.cpp:
        (WebCore::Document::updateSelection):
        Don't return early if the selection is empty.

LayoutTests:

2006-07-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Justin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
        REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus

        * editing/selection/clear-selection-expected.checksum: Added.
        * editing/selection/clear-selection-expected.png: Added.
        * editing/selection/clear-selection-expected.txt: Added.
        * editing/selection/clear-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-07-12 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 12 Jul 2006 21:47:13 +0000 (21:47 +0000)]
2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9624
        REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items

        * DefaultDelegates/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        Don't create Dictionary, Spotlight or Google lookup items if there's no selection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-07-12 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 12 Jul 2006 17:31:37 +0000 (17:31 +0000)]
2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adele.

        <rdar://problem/4614656> REGRESSION: onpaste() handlers don't run for textarea elements

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::dispatchCPPEvent):
        If the element is a shadow node, dispatch the event to its real parent.

        * manual-tests/textarea-onpaste.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
bdakin [Wed, 12 Jul 2006 17:00:40 +0000 (17:00 +0000)]
    Reviewed by Anders.

        Fix for layout test regressions after my check-in last night. Just
        a silly mistake where I should have asked if we were NOT printing
        instead of if we were in the listbox code.

        * WebCore.xcodeproj/project.pbxproj: Project file wars. Back to
        XCode 2.3
        * platform/mac/ListBoxMac.mm:
        (itemTextRenderer): Inverted check.
        (groupLabelTextRenderer): Inverted check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Wed, 12 Jul 2006 16:15:02 +0000 (16:15 +0000)]
WebKitTools:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9848
          Teach svn-create-patch and friends to fix ChangeLog patches

        * Scripts/svn-apply: Added fixChangeLogPatch() and invoked it in the proper place.
        * Scripts/svn-create-patch: Ditto.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Wed, 12 Jul 2006 16:09:47 +0000 (16:09 +0000)]
LayoutTests:

        Reviewed by NOBODY (layout test fix).

        Remove property information left in files from svn-apply.

        * fast/table/large-rowspan-crash-expected.txt:
        * fast/table/large-rowspan-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix date.
darin [Wed, 12 Jul 2006 15:52:54 +0000 (15:52 +0000)]
Fix date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Wed, 12 Jul 2006 15:30:53 +0000 (15:30 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - another large rowspan test case

        * fast/table/large-rowspan-crash-expected.txt: Added.
        * fast/table/large-rowspan-crash.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9806
          <rdar://problem/4622622>
          REGRESSION: Large rowspan causes WebKit to call abort()

        Test: fast/table/large-rowspan-crash.html

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::ensureRows):
        Use sizeof(RowStruct) instead of sizeof(int).
        Clearly we'll need something better to solve this completely.
        I expect another smaller, but still huge, value will still cause a problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Wed, 12 Jul 2006 13:32:37 +0000 (13:32 +0000)]
WebKitTools:

        Reviewed by ggaren.

        Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9869

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject currentFunctionStack]): Include the global frame in the stack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Wed, 12 Jul 2006 11:28:35 +0000 (11:28 +0000)]
WebKitTools:

        Reviewed by ggaren.

        Bug 9863: Drosera needs to show something at launch
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9863

        * Drosera/DebuggerApplication.m:
        (-[DebuggerApplication applicationDidFinishLaunching:]): Show the attach window on launch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca [Wed, 12 Jul 2006 10:33:17 +0000 (10:33 +0000)]
WebCore:

2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        <rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const

        * bridge/mac/FrameMac.h:
        Add focusCallResultedInViewBeingCreated argument.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::nextKeyViewInFrame):
        If the call to focus() caused the node to get a native widget, set focusCallResultedInViewBeingCreated to true.

        (WebCore::FrameMac::nextKeyViewInFrameHierarchy):
        Don't reset the focus node if focusCallResultedInViewBeingCreated is true. Also, add magic to prevent setting
        a text field as the first responder if its field editor already is the current first responder.

        * page/FrameView.cpp:
        (WebCore::FrameView::handleMousePressEvent):
        In some cases, get the event target node again after dispatching the mouse event.

LayoutTests:

2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        <rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const

        * fast/forms/input-type-change-in-onfocus-keyboard-expected.txt: Added.
        * fast/forms/input-type-change-in-onfocus-keyboard.html: Added.
        * fast/forms/input-type-change-in-onfocus-mouse-expected.txt: Added.
        * fast/forms/input-type-change-in-onfocus-mouse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-07-12 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 12 Jul 2006 10:18:20 +0000 (10:18 +0000)]
2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Build fix

        * JSUtils.cpp:
        (KJSValueToCFTypeInternal):
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSObjectCopyPropertyNames):
        * UserObjectImp.cpp:
        (UserObjectImp::getPropertyList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ggaren [Wed, 12 Jul 2006 10:01:06 +0000 (10:01 +0000)]
    Reviewed by Maciej.

        - Removed context and exception parameters from JSObjectGetPropertyEnumerator,
        removing the spurious use of ExecState inside JavaScriptCore that made
        us think this was necessary in the first place.

        (StringInstance::getPropertyList): Use getString instead of toString because
        we know we're dealing with a string -- we put it there in the first place.
        While we're at it, store the string's size instead of retrieving it each time
        through the loop, to avoid the unnecessary killing of puppies.
        * kjs/string_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago 4eviewed by Geoff.
mjs [Wed, 12 Jul 2006 09:55:55 +0000 (09:55 +0000)]
    4eviewed by Geoff.

        - add handling of hasInstance callback for API objects

        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::implementsHasInstance): Check if callback is present.
        (KJS::JSCallbackObject::hasInstance): Invoke appropriate callback.
        * API/JSCallbackObject.h:
        * API/JSClassRef.cpp:
        * API/JSObjectRef.h:
        * API/testapi.c:
        (MyObject_hasInstance): Test case; should match what construct would do.
        * API/testapi.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago--This Reviewed by Adele.
bdakin [Wed, 12 Jul 2006 09:52:36 +0000 (09:52 +0000)]
--This Reviewed by Adele.

        Fix for <rdar://problem/4615765> Input[type='search' fields
        initially render too large in Widgets

        Fundamentally, the problem here is that we were miscalculating
        things because [NSGraphicsContext currentContextDrawingToScreen]
        was evaluating to false when widgets first load. We only ever used
        this check, however, to determine if we were printing or not, so it
        should not have evaluated to false for loading in Dashbaord.
        Instead, if we query the RenderView about whether or not we are
        printing, we will get the right answer.

        No test case added since this appears only to affect Dashboard.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge drawRect:]): Ask the RenderView if we are
        printing instead. This is not part of the actual bug fix, but it
        seems wise to get rid of all calls to [NSGraphicsContext
        currentContextDrawingToScreen] when we are just trying to determine
        if we are printing or not.
        * platform/mac/ListBoxMac.mm:
        (itemTextRenderer):This function now takes a boolean, isPrinting.
        (groupLabelTextRenderer): Same as above.
        (ListBox::sizeForNumberOfLines): Ask the RenderView if we are
        printing.
        (-[WebCoreTableView drawRow:clipRect:]): Same as above.
        * platform/mac/PopUpButtonMac.mm:
        (PopUpButton::sizeHint): Same as above.
        * platform/mac/TextFieldMac.mm:
        (-[NSSearchFieldCell _addStringToRecentSearches:]):
        * rendering/RenderLineEdit.cpp: Same as above.

M    WebCore/platform/mac/TextFieldMac.mm
M    WebCore/platform/mac/PopUpButtonMac.mm
M    WebCore/platform/mac/ListBoxMac.mm
M    WebCore/rendering/RenderLineEdit.cpp
M    WebCore/ChangeLog
M    WebCore/bridge/mac/WebCoreFrameBridge.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Timothy.
thatcher [Wed, 12 Jul 2006 09:32:00 +0000 (09:32 +0000)]
    Reviewed by Timothy.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9868
        Applications shown in Drosera's "Attach" window remain after exit

        * DefaultDelegates/WebScriptDebugServer.m:
        (-[WebScriptDebugServer init]): Register for NSApplicationWillTerminateNotification so we will
        know when the application is being exited.
        (-[WebScriptDebugServer dealloc]): Unregister notification before we are deallocated.
        (-[WebScriptDebugServer applicationTerminating:]): Inform anyone listening that we are going away.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Timothy.
thatcher [Wed, 12 Jul 2006 08:55:24 +0000 (08:55 +0000)]
    Reviewed by Timothy.

        Lets Drosera build universal for the nightlies. Right now it is not
        possible to build a universal binary on a PPC machine because of a
        conflict with the universal SDK.

        * BuildSlaveSupport/build-launcher-app:
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
tomernic [Wed, 12 Jul 2006 08:25:29 +0000 (08:25 +0000)]
    Reviewed by Tim Hatcher.

        <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

        Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
        from earlier.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Wed, 12 Jul 2006 08:17:49 +0000 (08:17 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
        OPTION text can paint over select element's scrollbar

        * fast/forms/option-text-clip-expected.checksum: Added.
        * fast/forms/option-text-clip-expected.png: Added.
        * fast/forms/option-text-clip-expected.txt: Added.
        * fast/forms/option-text-clip.html: Added.

WebCore:

        Reviewed by Maciej.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
        OPTION text can paint over select element's scrollbar

        Test: fast/forms/option-text-clip.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
        When calculating the clip to apply to the button text, also consider padding.
        In the future, we may have separate renderers for the text part, and the arrow part
        of the control, and then the separation should be natural.  For now, we use padding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ggaren [Wed, 12 Jul 2006 08:12:08 +0000 (08:12 +0000)]
    Reviewed by Maciej.

        - Implemented a vast number of renames and comment clarifications
        suggested during API review.

        JSInternalString -> JSString
        JS*Make -> JSValueMake*, JSObjectMake*
        JSTypeCode -> JSType
        JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
        JSGC*Protect -> JSValue*Protect
        JS*Callback -> JSObject*Callback
        JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
        JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
        JSString* ->
            JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
            JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
            JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.

        - Changed functions taking a JSValue out arg and returning a bool indicating
        whether it was set to simply return a JSValue or NULL.

        - Removed JSStringGetCharacters because it's more documentation than code,
        and it's just a glorified memcpy built on existing API functionality.

        - Moved standard library includes into the headers that actually require them.

        - Standardized use of the phrase "Create Rule."

        - Removed JSLock from make functions that don't allocate.

        - Added exception handling to JSValueToBoolean, since we now allow
        callback objects to throw exceptions upon converting to boolean.

        - Renamed JSGCCollect to JSGarbageCollect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMore build fixes for the deprecated AGL functions.
thatcher [Wed, 12 Jul 2006 06:00:31 +0000 (06:00 +0000)]
More build fixes for the deprecated AGL functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot to commit a file this morning that actually makes the Drosera console open...
thatcher [Wed, 12 Jul 2006 04:26:01 +0000 (04:26 +0000)]
Forgot to commit a file this morning that actually makes the Drosera console open. Thanks bdash!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Wed, 12 Jul 2006 03:31:30 +0000 (03:31 +0000)]
WebCore:

        Windows build fix.  Reviewed by NOBODY.

        * WebCore.vcproj/WebCore/WebCore.vcproj:  Added JSHTMLOptionsCollection.cpp/h
        and JSHTMLOptionsCollectionCuston.cpp.  VC++ Express realphabetized the file list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
darin [Wed, 12 Jul 2006 02:55:47 +0000 (02:55 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9809
          <rdar://problem/4619515>
          focus ring fails to appear on select element after choosing item from popup

        - includes http://bugzilla.opendarwin.org/show_bug.cgi?id=9853
          improvements to select element, including some storage leak fixes

        * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index): Use a const
        reference for the list items, so we don't have to copy a vector.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::selectedIndex): Ditto.
        (WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
        (WebCore::HTMLSelectElement::length): Ditto.
        (WebCore::HTMLSelectElement::remove): Ditto.
        (WebCore::HTMLSelectElement::value): Ditto.
        (WebCore::HTMLSelectElement::setValue): Ditto.
        (WebCore::HTMLSelectElement::stateValue): Ditto.
        (WebCore::HTMLSelectElement::restoreState): Ditto.
        (WebCore::HTMLSelectElement::appendFormData): Ditto.
        (WebCore::HTMLSelectElement::optionToListIndex): Ditto.
        (WebCore::HTMLSelectElement::listToOptionIndex): Ditto.
        (WebCore::HTMLSelectElement::recalcListItems): Made const, with the appropriate
        fields mutable.
        (WebCore::HTMLSelectElement::reset): Use a const reference for
        the list items, so we don't have to copy the vector. Remove the call to
        setSelectionChanged for the RenderMenuList case.
        (WebCore::HTMLSelectElement::notifyOptionSelected): Ditto, on both counts.
        (WebCore::HTMLSelectElement::defaultEventHandler): Call focus() before showing
        the pop-up.
        * html/HTMLSelectElement.h: The RenderMenuList class is no longer a friend.
        Changed the listItems function to return a const reference to the vector so
        it no longer copies the vector. Removed the const_cast to the call to
        recalcListItems and changed it to a const member function. Made m_recalcListItems
        mutable.
        * rendering/DeprecatedRenderSelect.cpp:
        (WebCore::DeprecatedRenderSelect::updateFromElement): Removed an unnecessary call
        to recalcListItems, which is called automatically. Use a const reference for the
        list items so we don't have to copy a vector.
        (WebCore::DeprecatedRenderSelect::layout): Ditto.
        (WebCore::DeprecatedRenderSelect::selectionChanged): Ditto.
        (WebCore::DeprecatedRenderSelect::updateSelection): Ditto.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::RenderMenuList): Updated for renamed data members.
        (WebCore::RenderMenuList::createInnerBlock): Ditto.
        (WebCore::RenderMenuList::addChild): Ditto.
        (WebCore::RenderMenuList::removeChild): Ditto.
        (WebCore::RenderMenuList::setStyle): Ditto. Also removed code to set the style
        on the pop-up menu, because it's created with the correct style and destroyed
        before it a style change could occur.
        (WebCore::RenderMenuList::updateFromElement): Rearranged code to compute the
        maximum width in a simpler fashion, and to not bother trying to maintain
        the "selected" flags on the elements, since the HTMLSelectElement class
        takes care of that. Store the width as an int. Call setText to set the text
        based on the selected element's option text.
        (WebCore::RenderMenuList::paintObject): Don't check m_inner when setting
        up the clip -- always set up the clip.
        (WebCore::RenderMenuList::calcMinMaxWidth): Use m_optionsWidth directly
        instead of calling ceilf on m_longestWidth.
        (WebCore::RenderMenuList::showPopup): Don't use m_popupMenu to store the
        menu -- instead keep the pointer in a local variable. Get the selected
        index from the HTMLSelectElement.
        (WebCore::RenderMenuList::valueChanged): Call HTMLSelectElement::setSelectedIndex
        to do most of the work.
        * rendering/RenderMenuList.h: Renamed m_inner to m_innerBlock. Removed
        m_popupMenu, m_size, m_selectionChanged, and m_selectedIndex. Renamed
        m_longestWidth to m_optionsWidth and changed it to be an int. Removed
        unneeded override of removeLeftoverAnonymousBoxes function. Removed
        unneeded selectionChanged, setSelectionChanged, updateSelection, and
        hasPopupMenu functions. Removed extra includes.
        * rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate):
        Change to iterate the list items instead of iterating all children
        of the select node.
        * rendering/RenderPopupMenu.h: Renamed getRenderMenuList to menuList.
        * rendering/RenderPopupMenuMac.mm:
        (WebCore::RenderPopupMenuMac::populate): Moved code to clear and create
        the pop-up here from the caller. Removed an extra retain that would cause
        the NSPopUpButtonCell to leak.
        (WebCore::RenderPopupMenuMac::showPopup): Removed unnecessary code to
        create the pop-up, which is now in populate, and also the call to the
        clear function, for the same reason. Reorganized code to make it a bit
        more readable. Removed an unnecessary if to check if frame is nil.
        Used a RefPtr to make sure we don't make a call on a frame after it's
        deleted. As part of the reorganization fixed a problem where we'd retain
        the event and then return early without releasing it in one case.
        (WebCore::RenderPopupMenuMac::addSeparator): Tweaked a little.
        (WebCore::RenderPopupMenuMac::addGroupLabel): Grouped all the code to
        manage the NSMenu at the bottom of the function.
        (WebCore::RenderPopupMenuMac::addOption): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 12 Jul 2006 02:21:00 +0000 (02:21 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4620686>
        REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

        * editing/deleting/delete-after-span-ws-001-expected.checksum:
        * editing/deleting/delete-after-span-ws-001-expected.png:
        * editing/deleting/delete-after-span-ws-002-expected.checksum:
        * editing/deleting/delete-after-span-ws-002-expected.png:
        * editing/deleting/delete-after-span-ws-003-expected.checksum:
        * editing/deleting/delete-after-span-ws-003-expected.png:
        * editing/deleting/delete-block-merge-contents-010-expected.checksum:
        * editing/deleting/delete-block-merge-contents-010-expected.png:
        * editing/deleting/merge-unrendered-space-expected.checksum:
        * editing/deleting/merge-unrendered-space-expected.png:

WebCore:

        Reviewed by levi

        <rdar://problem/4620686>
        REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords
        even if oldAdjacentWords is equal to newAdjacentWords.  This happens during a deletion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agobetter build fix since other projects that include DOMPrivate.h can't included JavaSc...
thatcher [Wed, 12 Jul 2006 00:45:06 +0000 (00:45 +0000)]
better build fix since other projects that include DOMPrivate.h can't included JavaScriptCore/npruntime.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by NOBODY (build fix)
tomernic [Wed, 12 Jul 2006 00:40:44 +0000 (00:40 +0000)]
    Reviewed by NOBODY (build fix)

        * bindings/objc/DOMPrivate.h:
        Don't @class NPObject; that breaks files that actually #import <JavaScriptCore/npruntime.h>, since the NPObject
        there is of a different type.
        Also clarified a highly misleading comment from my last commit.  I meant to clarify the comment
        before landing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-07-12 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 12 Jul 2006 00:27:47 +0000 (00:27 +0000)]
2006-07-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9635
        REGRESSION: Crash when adding to cart at <http://www.yemeksepeti.com/>

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        Don't load external scripts if the parser is stopped.

        * manual-tests/open-close-tokenizer-crash.html: Added.
        * manual-tests/resources/empty-file.js: Added.
        * manual-tests/resources/open-close-tokenizer-crash.html: Added.
        Add manual test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin and Tim O
sullivan [Wed, 12 Jul 2006 00:00:58 +0000 (00:00 +0000)]
    Reviewed by Kevin and Tim O

        - added support for creating a selection image with white text

        * WebView/WebDocumentPrivate.h:
        added -selectionImageForcingWhiteText: and -selectionImageRect to the private
        <WebDocumentSelection> protocol

        * Misc/WebSearchableTextView.m:
        (-[NSString selectionImageForcingWhiteText:]):
        added stub for this new method to this obsolete class to satisfy the compiler
        (-[NSString selectionImageRect]):
        ditto

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _selectionDraggingImage]):
        now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage
        (-[WebHTMLView _selectionDraggingRect]):
        now calls selectionImageRect, to which the implementation moved
        (-[WebHTMLView selectionImageForcingWhiteText:]):
        implemented this new method by calling through to new bridge method selectionImageForcingWhiteText:
        (-[WebHTMLView selectionImageRect]):
        implemented this new method by using existing _selectionDraggingRect implementation

        * WebView/WebPDFView.m:
        (-[WebPDFView selectionImageForcingWhiteText:]):
        implemented by using code that was formerly in Safari
        (-[WebPDFView selectionImageRect]):
        implemented by returning selectionRect

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)
sullivan [Tue, 11 Jul 2006 23:59:34 +0000 (23:59 +0000)]
    Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)

        - added support for creating a selection image with white text

        * rendering/RenderObject.h:
        (WebCore::):
        add PaintRestriction enum
        (WebCore::RenderObject::PaintInfo::PaintInfo):
        add forceWhiteText boolean to PaintInfo struct

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        replaced m_selectionOnly bool with m_paintRestriction, which also handles forcing the
        text to white

        * page/Frame.cpp:
        (WebCore::Frame::paint):
        updated to use & pass m_paintRestriction where it used to use & pass just m_selectionOnly

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::selectionImage):
        now takes forceWhiteText parameter, stored in FramePrivate as part of PaintRestriction

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge selectionImageForcingWhiteText:]):
        renamed from selectionImage, now takes forceWhiteText parameter, which is passed
        down into Frame

        * rendering/RenderLayer.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint):
        use a PaintRestriction value where we used to use a selectionOnly bool
        (WebCore::RenderLayer::paintLayer):
        ditto; also stores forceWhiteText in PaintInfo struct

        * kcanvas/KCanvasResources.cpp:
        (WebCore::KCanvasMarker::draw):
        updated for changed signature of PaintInfo constructor

        * ksvg2/svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        ditto

        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::drawPatternContentIntoTile):
        ditto

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        paint with white text color if forceWhiteText is set in PaintInfo struct

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
tomernic [Tue, 11 Jul 2006 23:58:44 +0000 (23:58 +0000)]
LayoutTests:

        Reviewed by Geoff.

        Test case for <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
        Give Netscape plug-ins access to their own DOM element

        * plugins/netscape-dom-access-expected.checksum: Added.
        * plugins/netscape-dom-access-expected.png: Added.
        * plugins/netscape-dom-access-expected.txt: Added.
        * plugins/netscape-dom-access.html: Added.

WebCore:

        Reviewed by Anders.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
        Give Netscape plug-ins access to their own DOM element

        * html/HTMLPlugInElement.h:
        Just import JSC headers on Mac.  The NPObject and Bindings::Instance stuff is only used on Mac anyway.
        Changed __APPLE__ to PLATFORM(MAC).
        Added m_NPObject ivar.
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement):
        Initialize the NPObject.
        (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
        Release the NPObject when the element is destroyed.
        (WebCore::HTMLPlugInElement::createNPObject):
        Creates an NPObject for the element.
        (WebCore::HTMLPlugInElement::getNPObject):
        Returns the NPObject for the element, creating and caching it if necessary.

        * html/HTMLAppletElement.h:
        Changed __APPLE__ to PLATFORM(MAC).
        * html/HTMLAppletElement.cpp:
        ditto
        * html/HTMLEmbedElement.h:
        ditto
        * html/HTMLEmbedElement.cpp:
        ditto
        * html/HTMLObjectElement.h:
        ditto
        * html/HTMLObjectElement.cpp:
        ditto

        * bindings/objc/DOMPrivate.h:
        Added -[DOMElement _NPObject].

        * bindings/objc/DOM.mm:
        (-[DOMElement _NPObject]):
        Returns the NPObject for the element.  Since this is only needed by the Netscape plug-in API, you can only get
        the NPObject for applet, embed, and object elements.

WebKit:

        Reviewed by Geoff.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
        Give Netscape plug-ins access to their own DOM element

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView dealloc]):
        Release DOM element.
        (-[WebBaseNetscapePluginView getVariable:value:]):
        Return NPObject for plugin DOM element.

        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        Pass DOMElement to Netscape plug-ins.
        (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Tue, 11 Jul 2006 23:32:34 +0000 (23:32 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
        REGRESSION: Can't dynamically change list box to popup

        * fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
        * fast/forms/select-change-listbox-to-popup-expected.png: Added.
        * fast/forms/select-change-listbox-to-popup-expected.txt: Added.
        * fast/forms/select-change-listbox-to-popup.html: Added.
        * fast/forms/select-change-popup-to-listbox.html:

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
        REGRESSION: Can't dynamically change list box to popup

        and updated fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
        REGRESSION: Can't dynamically change popup to list box

        The original fix for 9859 was in the renderer, and I think we can catch the change
        earlier in the element to detach and reattach.

        I also did some cleanup to remove the PopupButton code path from DeprecatedRenderSelect

        Test: fast/forms/select-change-listbox-to-popup.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute): If the new attribute value is going to require us to change from listbox to popup or vice versa,
        and we're already attached, then detach and reattach to create the correct renderer.  If we're not attached, then we'll create the correct renderer
        when we attach.
        (WebCore::HTMLSelectElement::recalcStyle): Updated shouldUseMenuList since it no longer takes a RenderStyle.
        (WebCore::HTMLSelectElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLSelectElement::isMouseFocusable): ditto.
        (WebCore::HTMLSelectElement::createRenderer): ditto.
        (WebCore::HTMLSelectElement::setRecalcListItems): ditto.
        (WebCore::HTMLSelectElement::reset): ditto.
        (WebCore::HTMLSelectElement::notifyOptionSelected): ditto.
        (WebCore::HTMLSelectElement::defaultEventHandler): ditto.

        * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList):
        This method no longer takes a RenderStyle.  That was leftover from when we used to use the appearance
        to determine whether or not to use the new menu list implementation.

        * rendering/DeprecatedRenderSelect.h: Removed PopupButton code path.
        * rendering/DeprecatedRenderSelect.cpp:
        (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect):
        (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
        (WebCore::DeprecatedRenderSelect::updateFromElement):
        (WebCore::DeprecatedRenderSelect::baselinePosition):
        (WebCore::DeprecatedRenderSelect::layout):
        (WebCore::DeprecatedRenderSelect::updateSelection):

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
        Backed out previous fix since this is now done in HTMLSelectElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 11 Jul 2006 22:35:24 +0000 (22:35 +0000)]
LayoutTests:

        Reviewed by levi & thatcher

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
        GMail Editor: Operations that use drop down menus blow away the selection

        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/subframe-with-selection-expected.checksum: Added.
        * editing/selection/subframe-with-selection-expected.png: Added.
        * editing/selection/subframe-with-selection-expected.txt: Added.
        * editing/selection/subframe-with-selection.html: Added.

WebKit:

        Reviewed by levi & thatcher

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
        GMail Editor: Operations that use drop down menus blow away the selection

        * WebView/WebHTMLView.m:
        (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection
        when resigning as first responder if the selection is editable
        or if the WebView tells us to.
        * WebView/WebView.m:
        (-[WebView maintainsInactiveSelection]): Just because a WebView is
        editable doesn't mean selections inside subframes will be.  Return
        NO by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Tue, 11 Jul 2006 21:42:25 +0000 (21:42 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
        REGRESSION: Can't dynamically change popup to list box

        * fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
        * fast/forms/select-change-popup-to-listbox-expected.png: Added.
        * fast/forms/select-change-popup-to-listbox-expected.txt: Added.
        * fast/forms/select-change-popup-to-listbox.html: Added.

WebCore:

        Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
        REGRESSION: Can't dynamically change popup to list box

        Test: fast/forms/select-change-popup-to-listbox.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
        If the select element has the multiple property set, or has a size > 1, then it
        really should be a list box, so we detach and attach the element so it creates the
        correct type of renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth Dakin and Tim Omernick
sullivan [Tue, 11 Jul 2006 21:31:19 +0000 (21:31 +0000)]
    Reviewed by Beth Dakin and Tim Omernick

        - fixed <rdar://problem/4622794> HiDPI: dragging the selection in Safari can show pixel cracks
        at non-integral scale factors

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::imageFromRect):
        round image rect in window coordinate space

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
tomernic [Tue, 11 Jul 2006 20:58:37 +0000 (20:58 +0000)]
    Reviewed by Tim Hatcher.

        <rdar://problem/4622748> WebKit now uses deprecated AGL functions

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
        aglSetDrawable() is deprecated in AGL 3.0.  Use aglSetWindowRef() instead.
        (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
        aglSetOffScreen() is deprecated in AGL 3.0.  Use CGLSetOffScreen(), which does the same thing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Tue, 11 Jul 2006 19:07:00 +0000 (19:07 +0000)]
    Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9572
        Add application/xhtml+xml to the Accept header

        The fix itself was landed on 2006-07-09, but I forgot about the test.

        * http/tests/misc/xhtml-expected.txt: Added.
        * http/tests/misc/xhtml.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
bdakin [Tue, 11 Jul 2006 18:54:45 +0000 (18:54 +0000)]
    Reviewed by Adele.

        Adele checked in new results for this test when you could style
        selects, but the styling of selects is turned off for now, so back
        to the original results.

        * fast/forms/001-expected.checksum:
        * fast/forms/001-expected.png:
        * fast/forms/001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding the radar to a change.
thatcher [Tue, 11 Jul 2006 18:40:01 +0000 (18:40 +0000)]
Adding the radar to a change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim O.
ap [Tue, 11 Jul 2006 18:21:18 +0000 (18:21 +0000)]
    Reviewed by Tim O.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7808
        Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL

WebKit:
        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
        Remove the early return when requesting an invalid (unsupported) URL.

WebKitTools:
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        (pluginInvoke): treat getURL() with one parameter as if the second parameter were NULL -
        should open a new stream and deliver the data to the current instance.

LayoutTests:
        * plugins/get-empty-url-expected.txt: Added.
        * plugins/get-empty-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Tue, 11 Jul 2006 18:13:33 +0000 (18:13 +0000)]
    Reviewed by Darin.

        Bug 9598: [Drosera] add a JavaScript evaluator console
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9598

        * Drosera/DebuggerApplication.h:
        * Drosera/DebuggerApplication.m:
        (-[DebuggerApplication knownServers]):
        * Drosera/DebuggerDocument.h:
        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject evaluateScript:inCallFrame:]):
        (-[WebScriptObject showConsole:]):
        (-[WebScriptObject toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]):
        (-[WebScriptObject toolbarDefaultItemIdentifiers:]):
        (-[WebScriptObject toolbarAllowedItemIdentifiers:]):
        (-[WebScriptObject webView:createWebViewWithRequest:]):
        (-[WebScriptObject webViewShow:]):
        (-[WebScriptObject webViewAreToolbarsVisible:]):
        (-[WebScriptObject webView:setToolbarsVisible:]):
        (-[WebScriptObject webView:setResizable:]):
        (-[WebScriptObject webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
        (-[WebScriptObject scriptConfirmSheetDidEnd:returnCode:contextInfo:]):
        (-[WebScriptObject webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
        (-[WebScriptObject webView:windowScriptObjectAvailable:]):
        (-[WebScriptObject webView:didFinishLoadForFrame:]):
        (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/Images/console.png: Added.
        * Drosera/console.css: Added.
        * Drosera/console.html: Added.
        * Drosera/console.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by a tired Geoff.
thatcher [Tue, 11 Jul 2006 07:51:34 +0000 (07:51 +0000)]
    Reviewed by a tired Geoff.

        Bug 9597: [Drosera] hook up the variables table to show stack variables
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9597

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject isSelectorExcludedFromWebScript:]):
        (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):
        (-[WebScriptObject localScopeVariableNamesForCallFrame:]):
        (-[WebScriptObject valueForScopeVariableNamed:inCallFrame:]):
        (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
        (-[WebScriptObject webView:didLoadMainResourceForDataSource:]):
        (-[WebScriptObject webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptObject webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptObject webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebScriptObject webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        * Drosera/debugger.css:
        * Drosera/debugger.html:
        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth Dakin.
tomernic [Tue, 11 Jul 2006 07:30:58 +0000 (07:30 +0000)]
    Reviewed by Beth Dakin.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9844>:
        Add DOM access test to DumpRenderTree's Netscape plug-in

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        (testDOMAccess):
        (pluginInvoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
darin [Tue, 11 Jul 2006 06:04:43 +0000 (06:04 +0000)]
    Reviewed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9811
          rdar://problem/4619572
          OPTION text contained in OPTGROUP appears at the wrong size

        * dom/Node.h:
        * dom/Node.cpp: (WebCore::Node::renderStyle): Made a const member function.
        The derived classes were overriding with const member functions, and I could
        change either this or the derived -- decided to do this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
darin [Tue, 11 Jul 2006 05:48:29 +0000 (05:48 +0000)]
    Reviewed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9810
          OPTGROUP label text is using the default font instead of Lucida Grande

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
        Code wants the family name, but was calling fontName, which is not the same thing.
        Also removed the unneeded conversion to DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ggaren [Tue, 11 Jul 2006 05:37:00 +0000 (05:37 +0000)]
    Reviewed by Darin.

        - Changed public header includes to the <JavaScriptCore/ style.
        - Changed instances of 'buffer' to 'string' since we decided on
        JSInternalString instead of JSStringBuffer.

        * API/JSContextRef.h:
        * API/JSInternalStringRef.cpp:
        (JSStringMake):
        (JSInternalStringRetain):
        (JSInternalStringRelease):
        (JSValueCopyStringValue):
        (JSInternalStringGetLength):
        (JSInternalStringGetCharactersPtr):
        (JSInternalStringGetCharacters):
        (JSInternalStringGetMaxLengthUTF8):
        (JSInternalStringGetCharactersUTF8):
        (CFStringCreateWithJSInternalString):
        * API/JSInternalStringRef.h:
        * API/JSNode.c:
        (JSNodePrototype_appendChild):
        (JSNode_getNodeType):
        * API/JSObjectRef.cpp:
        (JSObjectCallAsConstructor):
        * API/JSValueRef.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        (main):
        (print):
        * API/testapi.c:
        (MyObject_getPropertyList):
        (myConstructor_callAsConstructor):
        (main): I noticed that we were prematurely releasing some string buffers,
        so I moved their release calls to the end of main(). I got rid of 'Buf' in *Buf
        (sometimes changing to 'IString', when necessary to differentiate a variable)
        to match the buffer->string change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Tue, 11 Jul 2006 04:36:06 +0000 (04:36 +0000)]
WebKitTools:

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9839
          Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load

        Now track three states: initializing, running, and closed.  If we are launched and the previous
        state was initializing then we likely just experienced a crash on launch.

        * WebKitLauncher/WebKitNightlyEnabler.m:
        (myApplicationWillFinishLaunching): Improve wording of dialog.  Update to set new running state.
        (myApplicationWillTerminate): Update to use new states.
        (cleanUpAfterOurselves): Display alert if previous state was initializing.  Set state as
        initializing as early as practical.
        (symbol_lookup): Bring code up to speed with formatting guidelines.
        (GDSymbolLookup): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one...
darin [Tue, 11 Jul 2006 03:37:22 +0000 (03:37 +0000)]
    * kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one more place.
        Just in case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMove the release tag.
thatcher [Tue, 11 Jul 2006 03:36:33 +0000 (03:36 +0000)]
Move the release tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix the release build
darin [Tue, 11 Jul 2006 03:34:43 +0000 (03:34 +0000)]
    - fix the release build

        * kjs/value.h:
        * kjs/value.cpp:
        (KJS::JSValue::toInt32Inline): Move the code here to an inline.
        (KJS::JSValue::toInt32): Call the inline from both overloaded toInt32 functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning
thatcher [Tue, 11 Jul 2006 03:33:44 +0000 (03:33 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Tue, 11 Jul 2006 03:16:41 +0000 (03:16 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
          Implement select.options.add() method

        * JavaScriptCore.exp: Added overloaded KJS::JSValue::toInt32() method.
        * JavaScriptCore.xcodeproj/project.pbxproj: Altered attributes metadata for
        kjs/value.h to make it available as a forwarded header.
        * kjs/lookup.h:
        (KJS::lookupPut): Extracted a lookupPut() method from the existing lookupPut() method.
        The new method returns a boolean value if no entry is found in the lookup table.
        * kjs/value.cpp:
        (KJS::JSValue::toInt32): Overloaded toInt32() method with boolean "Ok" argument.
        * kjs/value.h: Ditto.

LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
          Implement select.options.add() method

        * fast/dom/select-selectedIndex-multiple-expected.txt: Updated test results.
        * fast/dom/select-selectedIndex-multiple.html: Updated to print comments between
        tests to make failures easier to track down.
        * fast/dom/select-selectedIndex-expected.txt: Mirrored updates from select-selectedIndex-multiple.html
        * fast/dom/select-selectedIndex.html: Ditto.
        * fast/js/resources/select-options-add.js: Added.
        * fast/js/select-options-add-expected.txt: Added.
        * fast/js/select-options-add.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
          Implement select.options.add() method

        Tests:
        - fast/dom/select-selectedIndex-multiple.html
        - fast/dom/select-selectedIndex.html
        - fast/js/select-options-add.html

        * DerivedSources.make: Added JSHTMLOptionsCollection.h.
        * ForwardingHeaders/kjs/operations.h: Added.
        * WebCore.xcodeproj/project.pbxproj: Added new source files.
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp: Added.
        (WebCore::JSHTMLOptionsCollection::length):
        (WebCore::JSHTMLOptionsCollection::setLength):
        (WebCore::JSHTMLOptionsCollection::indexSetter):
        * bindings/js/kjs_html.cpp: Removed JSHTMLOptionsCollection implementation.
        Renamed classes and methods for consistency.
        (KJS::JSHTMLElement::selectGetter):
        (KJS::JSHTMLElement::put):
        (KJS::JSHTMLElement::selectSetter):
        (KJS::JSHTMLCollection::JSHTMLCollection):
        (KJS::JSHTMLCollectionProtoFunc::callAsFunction):
        (KJS::getHTMLOptionsCollection):
        * bindings/js/kjs_html.h: Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Added support for HasCustomIndexSetter class attribute.
        Added support for Optional parameter attribute, which makes generated code assume overloaded
        implementation methods are available for a JavaScript function with optional arguments.  Changed
        local 'impl' variables to 'imp' so that impl() methods could be called without class designation.
        * html/HTMLOptionElement.idl: Added GenerateNativeConverter attribute.
        * html/HTMLOptionsCollection.cpp: Added methods used by generated JSHTMLOptionsCollection class.
        (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
        (WebCore::HTMLOptionsCollection::add):
        (WebCore::HTMLOptionsCollection::selectedIndex):
        (WebCore::HTMLOptionsCollection::setSelectedIndex):
        (WebCore::HTMLOptionsCollection::setLength):
        * html/HTMLOptionsCollection.h: Ditto.
        * html/HTMLOptionsCollection.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt.
harrison [Tue, 11 Jul 2006 02:02:11 +0000 (02:02 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/4602408> -webkit-highlight needs to support images and elements other than text

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintCustomHighlight):
        * rendering/RenderBox.h:
        Utility for subclasses.

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        Custom highlight in front of images.

        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        Custom highlight in front of list markers.

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        Custom highlight in front of objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Better fix for repainting issue with positioned objects when height
hyatt [Tue, 11 Jul 2006 01:22:07 +0000 (01:22 +0000)]
    Better fix for repainting issue with positioned objects when height
        changes.  Optimize when only a positioned child changes so that we don't
        incorrectly do normal flow layout.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::layout):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago No review necessary. Removed bogus file I accidentally checked in before.
ggaren [Tue, 11 Jul 2006 00:27:28 +0000 (00:27 +0000)]
    No review necessary. Removed bogus file I accidentally checked in before.

        * API/JSInternalSringRef.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ggaren [Tue, 11 Jul 2006 00:26:25 +0000 (00:26 +0000)]
    Reviewed by Darin.

        Added exception out parameter to API object callbacks, removed semi-bogus
        JSContext(.*)Exception functions.

        To make these calls syntactically simple, I added an exceptionSlot()
        method to the ExecState class, which provides a JSValue** slot in which to
        store a JSValue* exception.

        * API/APICast.h:
        (toRef):
        * API/JSCallbackConstructor.cpp:
        (KJS::JSCallbackConstructor::construct):
        * API/JSCallbackFunction.cpp:
        (KJS::JSCallbackFunction::callAsFunction):
        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::init):
        (KJS::JSCallbackObject::getOwnPropertySlot):
        (KJS::JSCallbackObject::put):
        (KJS::JSCallbackObject::deleteProperty):
        (KJS::JSCallbackObject::construct):
        (KJS::JSCallbackObject::callAsFunction):
        (KJS::JSCallbackObject::getPropertyList):
        (KJS::JSCallbackObject::toBoolean):
        (KJS::JSCallbackObject::toNumber):
        (KJS::JSCallbackObject::toString):
        (KJS::JSCallbackObject::staticValueGetter):
        (KJS::JSCallbackObject::callbackGetter):
        * API/JSContextRef.cpp:
        (JSCheckSyntax):
        * API/JSContextRef.h:
        * API/JSNode.c:
        (JSNodePrototype_appendChild):
        (JSNodePrototype_removeChild):
        (JSNodePrototype_replaceChild):
        (JSNode_getNodeType):
        (JSNode_getChildNodes):
        (JSNode_getFirstChild):
        (JSNode_construct):
        * API/JSNode.h:
        * API/JSNodeList.c:
        (JSNodeListPrototype_item):
        (JSNodeList_length):
        (JSNodeList_getProperty):
        * API/JSObjectRef.h:
        * API/minidom.c:
        (print):
        * API/testapi.c:
        (MyObject_initialize):
        (MyObject_hasProperty):
        (MyObject_getProperty):
        (MyObject_setProperty):
        (MyObject_deleteProperty):
        (MyObject_getPropertyList):
        (MyObject_callAsFunction):
        (MyObject_callAsConstructor):
        (MyObject_convertToType):
        (print_callAsFunction):
        (myConstructor_callAsConstructor):
        (main):
        * JavaScriptCore.exp:
        * kjs/ExecState.h:
        (KJS::ExecState::exceptionHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Mon, 10 Jul 2006 23:52:44 +0000 (23:52 +0000)]
LayoutTests:

        Reviewed by Beth.

        Test for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

        * fast/forms/select-style-expected.checksum: Added.
        * fast/forms/select-style-expected.png: Added.
        * fast/forms/select-style-expected.txt: Added.
        * fast/forms/select-style.html: Added.

WebCore:

        Reviewed by Beth.

        - Fix for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

        Test: fast/forms/select-style.html

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
        Don't let popups be style-able for now.  We'll allow it later, when we
        have a good way to handle border & backgrounds and still having it look like a control.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
sullivan [Mon, 10 Jul 2006 23:50:32 +0000 (23:50 +0000)]
    Reviewed by John Sullivan.

        - fix <rdar://problem/4621541>, aka <http://bugzilla.opendarwin.org/show_bug.cgi?id=9838>
          REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache

        * WebView/WebDataSource.m:
        (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is
        has just loaded it (when coming from the back/forward cache, it hasn't).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by harrison
justing [Mon, 10 Jul 2006 22:29:02 +0000 (22:29 +0000)]
    Reviewed by harrison

        <rdar://problem/4619260>
        9A213 + Safari 521.15.1 Crash with To Do's alarm icon (WebCore::maxDeepOffset(WebCore::Node const*) )
        <rdar://problem/4619841>
        REGRESSION: Dragging selection over input field results in a crash (WebCore::maxDeepOffset(WebCore::Node const*)

        * WebCore.xcodeproj/project.pbxproj:
        * editing/Selection.cpp:
        (WebCore::Selection::adjustForEditableContent): Iterate using next/previousVisuallyDistinctCandidate
        instead of traverseNext/Previous node because we were skipping positions.  Jump out of shadow trees.
        Migrate to isEditablePosition instead of isContentEditable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
bdakin [Mon, 10 Jul 2006 22:25:41 +0000 (22:25 +0000)]
    Reviewed by Adele.

        Shuffling comments around from my last check-in to make things read
        more clearly.

        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
bdakin [Mon, 10 Jul 2006 22:05:05 +0000 (22:05 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/4621095> The should be a way to
        access the user interface scale factor through the DOM

        window.devicePixelRatio returns the user interface scale factor.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::devicePixelRatio):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ggaren [Mon, 10 Jul 2006 21:17:26 +0000 (21:17 +0000)]
    Reviewed by Darin.

        Improved type safety by implementing opaque JSValue/JSObject typing through
        abuse of 'const', not void*. Also fixed an alarming number of bugs
        exposed by this new type safety.

        I made one design change in JavaScriptCore, which is that the JSObject
        constructor should take a JSValue* as its prototype argument, not a JSObject*,
        since we allow the prototype to be any JSValue*, including jsNull(), for
        example.

        * API/APICast.h:
        (toJS):
        * API/JSBase.h:
        * API/JSCallbackConstructor.cpp:
        (KJS::JSCallbackConstructor::construct):
        * API/JSCallbackFunction.cpp:
        (KJS::JSCallbackFunction::callAsFunction):
        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::JSCallbackObject):
        (KJS::JSCallbackObject::getOwnPropertySlot):
        (KJS::JSCallbackObject::put):
        (KJS::JSCallbackObject::construct):
        (KJS::JSCallbackObject::callAsFunction):
        (KJS::JSCallbackObject::staticFunctionGetter):
        * API/JSCallbackObject.h:
        * API/JSContextRef.cpp:
        (JSEvaluate):
        * API/JSNode.c:
        (JSNodePrototype_appendChild):
        (JSNodePrototype_removeChild):
        (JSNodePrototype_replaceChild):
        * API/JSObjectRef.cpp:
        (JSObjectMake):
        (JSFunctionMakeWithBody):
        (JSObjectGetProperty):
        (JSObjectCallAsFunction):
        (JSObjectCallAsConstructor):
        * API/JSObjectRef.h:
        * API/testapi.c:
        (main):
        * ChangeLog:
        * kjs/object.h:
        (KJS::JSObject::JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago http://bugzilla.opendarwin.org/show_bug.cgi?id=9830
adele [Mon, 10 Jul 2006 20:53:26 +0000 (20:53 +0000)]
    bugzilla.opendarwin.org/show_bug.cgi?id=9830
        More pixel test results need updating since switching to native popup

        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * fast/block/margin-collapse/103-expected.checksum:
        * fast/block/margin-collapse/103-expected.png:
        * fast/forms/001-expected.checksum:
        * fast/forms/001-expected.png:
        * fast/forms/HTMLOptionElement_label01-expected.checksum:
        * fast/forms/HTMLOptionElement_label01-expected.png:
        * fast/forms/HTMLOptionElement_label02-expected.checksum:
        * fast/forms/HTMLOptionElement_label02-expected.png:
        * fast/forms/HTMLOptionElement_label03-expected.checksum:
        * fast/forms/HTMLOptionElement_label03-expected.png:
        * fast/forms/HTMLOptionElement_label04-expected.checksum:
        * fast/forms/HTMLOptionElement_label04-expected.png:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/option-script-expected.checksum:
        * fast/forms/option-script-expected.png:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/invalid/014-expected.checksum:
        * fast/invalid/014-expected.png:
        * fast/parser/document-write-option-expected.checksum:
        * fast/parser/document-write-option-expected.png:
        * tables/mozilla/bugs/bug2479-3-expected.checksum:
        * tables/mozilla/bugs/bug2479-3-expected.png:
        * tables/mozilla/bugs/bug29326-expected.checksum:
        * tables/mozilla/bugs/bug29326-expected.png:
        * tables/mozilla/bugs/bug33855-expected.checksum:
        * tables/mozilla/bugs/bug33855-expected.png:
        * tables/mozilla/bugs/bug96334-expected.checksum:
        * tables/mozilla/bugs/bug96334-expected.png:
        * tables/mozilla/core/margins-expected.checksum:
        * tables/mozilla/core/margins-expected.png:
        * tables/mozilla/dom/tableDom-expected.checksum:
        * tables/mozilla/dom/tableDom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Mon, 10 Jul 2006 17:47:41 +0000 (17:47 +0000)]
WebCore:

        Reviewed by Alexey

        Resolved the console error messages people got from the new DB even if they didn't have it enabled

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::pruneUnreferencedIcons):
        (WebCore::IconDatabase::pruneUnretainedIcons):
        Added quick check to bail if the DB isn't open

WebKit:

        Reviewed by Alexey

        Resolved the console error messages people got from the new DB even if they didn't have it enabled

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        Disabled initializing the IconDatabaseBridge if user is living on the old DB

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Approved by Maciej, Darin.
ggaren [Mon, 10 Jul 2006 17:41:32 +0000 (17:41 +0000)]
    Approved by Maciej, Darin.

        Renamed JSStringBufferRef to JSInternalStringRef. "Internal string" means the
        JavaScript engine's internal string representation, which is the most
        low-level and efficient representation to use when interfacing with JavaScript.

        * API/APICast.h:
        (toJS):
        (toRef):
        * API/JSBase.h:
        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::getOwnPropertySlot):
        (KJS::JSCallbackObject::put):
        (KJS::JSCallbackObject::deleteProperty):
        (KJS::JSCallbackObject::staticValueGetter):
        (KJS::JSCallbackObject::callbackGetter):
        * API/JSContextRef.cpp:
        (JSEvaluate):
        (JSCheckSyntax):
        * API/JSContextRef.h:
        * API/JSInternalStringRef.cpp: Added.
        (JSStringMake):
        (JSInternalStringCreate):
        (JSInternalStringCreateUTF8):
        (JSInternalStringRetain):
        (JSInternalStringRelease):
        (JSValueCopyStringValue):
        (JSInternalStringGetLength):
        (JSInternalStringGetCharactersPtr):
        (JSInternalStringGetCharacters):
        (JSInternalStringGetMaxLengthUTF8):
        (JSInternalStringGetCharactersUTF8):
        (JSInternalStringIsEqual):
        (JSInternalStringIsEqualUTF8):
        (JSInternalStringCreateCF):
        (CFStringCreateWithJSInternalString):
        * API/JSInternalStringRef.h: Added.
        * API/JSNode.c:
        (JSNodePrototype_appendChild):
        (JSNode_getNodeType):
        (JSNode_getChildNodes):
        (JSNode_getFirstChild):
        * API/JSNodeList.c:
        (JSNodeList_length):
        (JSNodeList_getProperty):
        * API/JSObjectRef.cpp:
        (JSFunctionMakeWithBody):
        (JSObjectGetDescription):
        (JSObjectHasProperty):
        (JSObjectGetProperty):
        (JSObjectSetProperty):
        (JSObjectDeleteProperty):
        (JSPropertyEnumeratorGetNext):
        (JSPropertyListAdd):
        * API/JSObjectRef.h:
        * API/JSStringBufferRef.cpp: Removed.
        * API/JSStringBufferRef.h: Removed.
        * API/JSValueRef.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        (main):
        (print):
        * API/testapi.c:
        (assertEqualsAsUTF8String):
        (assertEqualsAsCharactersPtr):
        (assertEqualsAsCharacters):
        (MyObject_hasProperty):
        (MyObject_getProperty):
        (MyObject_setProperty):
        (MyObject_deleteProperty):
        (MyObject_getPropertyList):
        (print_callAsFunction):
        (myConstructor_callAsConstructor):
        (main):
        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@15306 268f45cc-cd09-0410...
harrison [Mon, 10 Jul 2006 16:48:37 +0000 (16:48 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
darin [Mon, 10 Jul 2006 16:18:05 +0000 (16:18 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9808
          REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text

        * manual-tests/ATSU-bad-layout.html: Added.
        * platform/mac/FontMac.mm:
        (WebCore::Font::floatWidthForComplexText): Return 0 immediately for empty runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix the no-SVG build
darin [Mon, 10 Jul 2006 15:54:49 +0000 (15:54 +0000)]
    - try to fix the no-SVG build

        * ksvg2/misc/SVGImageLoader.cpp: Move namespace brace inside the #if.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15304 268f45cc-cd09-0410-ab3c-d52691b4dbfc