WebKit-https.git
8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 16 Oct 2012 13:36:15 +0000 (13:36 +0000)]
Unreviewed GTK gardening.

Adding (flaky) crashing expectations for a couple of tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Whitelist safe styles for 'console.log('%c...', ...)'.
mkwst@chromium.org [Tue, 16 Oct 2012 13:13:01 +0000 (13:13 +0000)]
Web Inspector: Whitelist safe styles for 'console.log('%c...', ...)'.
https://bugs.webkit.org/show_bug.cgi?id=98945

Reviewed by Pavel Feldman.

Source/WebCore:

Support for styling console messages via '%c' landed without any
parsing of the style information provided. This means that it's fairly
simple to accidentally or maliciously break the console with cleverly
styled messages. To mitigate this risk, whitelisting a safe subset of
CSS seems appropriate.

As a first pass at a reasonable whitelist, this patch allows
'background[-*]', 'border[-*]', 'color[-*]', 'font[-*]',
'margin[-*]', 'padding[-*]', 'text[-*]', '-webkit-background[-*]',
'-webkit-border[-*]', '-webkit-font[-*]', '-webkit-margin[-*]',
'-webkit-padding[-*]', and '-webkit-text[-*]'.

Test: inspector/console/console-format-style-whitelist.html

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString.styleFormatter):
    Create a buffer element onto which the user-provided styles are
    applied. Whitelisted styles are transfered from the buffer onto
    the actual console message.
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString.isWhitelistedProperty):
     Returns true if the specific style is whitelisted. Expects styles
     in the hyphenated form (that is, '-webkit-padding-start' rather than
     CSSOM's 'webkitPaddingStart').

LayoutTests:

* http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithStyles):
    Use the 'cssText' property of an element, rather than reading from
    its 'style' attribute. Also, gracefully handle unstyled elements
    by explicitly noting their emptyness.
* inspector/console/console-format-style-whitelist-expected.txt: Added.
* inspector/console/console-format-style-whitelist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][EFL] Crash in _ewk_view_on_favicon_changed()
commit-queue@webkit.org [Tue, 16 Oct 2012 13:09:55 +0000 (13:09 +0000)]
[WK2][EFL] Crash in _ewk_view_on_favicon_changed()
https://bugs.webkit.org/show_bug.cgi?id=99454

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-16
Reviewed by Kenneth Rohde Christiansen.

Added missing null check to avoid a crash if the current URL of
view is NULL.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_on_favicon_changed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build-webkit bailing out of !isSVN() and !isGit()
hausmann@webkit.org [Tue, 16 Oct 2012 12:53:21 +0000 (12:53 +0000)]
Fix build-webkit bailing out of !isSVN() and !isGit()

Reviewed by Tor Arne Vestbø.

Added missing else case with early return.

* Scripts/VCSUtils.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add logic for triggering clean builds on changes to build system files
hausmann@webkit.org [Tue, 16 Oct 2012 12:48:32 +0000 (12:48 +0000)]
[Qt] Add logic for triggering clean builds on changes to build system files

Patch by Simon Hausmann  <simon.hausmann@digia.com>, Tor Arne Vestbø <tor.arne.vestbo@digia.com> on 2012-10-16
Reviewed by Csaba Osztrogonác.

.:

Add a line here that can be re-used for recording dummy commits to count how the clean-build-needed
logic failed.

* WebKit.pro:

Tools:

Re-use the existing logic that gives us a range between old and new SVN revision and
parse the summarized output of diff to see if any of the changed files include files
that are part of the Qt build system. If they change we likely need a clean build and
trigger it just to be on the safe side and reduce the amount of manual intervention
needed on the Qt build bots.

* Scripts/VCSUtils.pm:
* Scripts/webkitdirs.pm:
(buildQMakeProjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline calendar-picker-key-operations.html due to r162114
keishi@webkit.org [Tue, 16 Oct 2012 12:30:46 +0000 (12:30 +0000)]
[Chromium] Rebaseline calendar-picker-key-operations.html due to r162114

Unreviewed.

* fast/forms/date/calendar-picker-key-operations-expected.txt:
* platform/chromium-win/fast/forms/date/calendar-picker-key-operations-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyOpacity in StyleBuilder.
macpherson@chromium.org [Tue, 16 Oct 2012 12:13:55 +0000 (12:13 +0000)]
Handle CSSPropertyOpacity in StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=99418

Reviewed by Alexis Menard.

One small step in moving from the huge switch in StyleResolver::applyProperty() to the StyleBuilder approach.

Covered by many existing tests, for example fast/text/complex-text-opacity.html.

* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the paths for QtGraphics related WebKit2 files.
allan.jensen@digia.com [Tue, 16 Oct 2012 12:05:02 +0000 (12:05 +0000)]
Fix the paths for QtGraphics related WebKit2 files.

Unreviewed update of watchlist.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS and TouchAdjustment - I am watching you!
allan.jensen@digia.com [Tue, 16 Oct 2012 11:59:01 +0000 (11:59 +0000)]
CSS and TouchAdjustment - I am watching you!

Unreviewed update of watchlist.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 16 Oct 2012 11:27:12 +0000 (11:27 +0000)]
Unreviewed GTK gardening.

Updating baselines and expectations after downgrading the Cairo
version used in JHBuild dependencies back to 1.10.2.

* platform/gtk/TestExpectations:
* platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
* platform/gtk/svg/batik/text/smallFonts-expected.txt:
* platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/gtk/svg/batik/text/textOnPath-expected.txt:
* platform/gtk/svg/batik/text/textOnPath2-expected.txt:
* platform/gtk/svg/batik/text/textOnPath3-expected.txt:
* platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/gtk/svg/custom/js-update-path-changes-expected.txt:
* platform/gtk/svg/custom/js-update-path-removal-expected.txt:
* platform/gtk/svg/custom/path-textPath-simulation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r131436.
hausmann@webkit.org [Tue, 16 Oct 2012 10:49:40 +0000 (10:49 +0000)]
Unreviewed, rolling out r131436.
http://trac.webkit.org/changeset/131436

Broke various Qt bots strangely

* .qmake.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Silence C++11 warnings with older versions of clang
hausmann@webkit.org [Tue, 16 Oct 2012 10:29:42 +0000 (10:29 +0000)]
[Qt] Silence C++11 warnings with older versions of clang

Rubber-stamped by Tor Arne Vestbø.

Some clang versions support -Wno-c++11-extensions and some use -Wno-c++0x-extensions.
We cater both :)

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Provide WKURL API for resolving the relative URL with the given base URL
commit-queue@webkit.org [Tue, 16 Oct 2012 10:16:52 +0000 (10:16 +0000)]
[WK2] Provide WKURL API for resolving the relative URL with the given base URL
https://bugs.webkit.org/show_bug.cgi?id=99317

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added new constructor function WKURLCreateWithBaseURL for WKURL which
resolves the relative URL with the given base URL.

* Shared/API/c/WKURL.cpp:
(WKURLCreateWithBaseURL):
* Shared/API/c/WKURL.h:
* Shared/WebURL.h:
(WebKit::WebURL::create):
(WebURL):
(WebKit::WebURL::WebURL):

Tools:

Added API test for newly added WKURLCreateWithBaseURL().

* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/WKURL.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix support for silent builds
hausmann@webkit.org [Tue, 16 Oct 2012 10:14:36 +0000 (10:14 +0000)]
[Qt] Fix support for silent builds

Reviewed by Tor Arne Vestbø.

The .qmake.conf file in Qt modules usually contains a load(qt_build_config), which
ends up loading qmodule.pri, which contains the CONFIG += silent if Qt was configured
with -silent.

* .qmake.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Decrease the Cario jhbuild dep version back to 1.10.2
zandobersek@gmail.com [Tue, 16 Oct 2012 10:13:44 +0000 (10:13 +0000)]
[GTK] Decrease the Cario jhbuild dep version back to 1.10.2
https://bugs.webkit.org/show_bug.cgi?id=99443

Reviewed by Philippe Normand.

Crashes started to occur after the Cairo version in the JHBuild dependencies
was bumped up to 1.12.4. This change brings it back down to 1.10.2, which
worked fine.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd test that checks that reloading after setting a value for an input element from...
keishi@webkit.org [Tue, 16 Oct 2012 09:31:11 +0000 (09:31 +0000)]
Add test that checks that reloading after setting a value for an input element from a suggestion picker resets the values
https://bugs.webkit.org/show_bug.cgi?id=99407

Reviewed by Kent Tamura.

We want to test that a reload resets values of input elements, even if
they were set by the suggestion picker.

* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some appearance glitches of multiple fields input elements
tkent@chromium.org [Tue, 16 Oct 2012 09:30:34 +0000 (09:30 +0000)]
Fix some appearance glitches of multiple fields input elements
https://bugs.webkit.org/show_bug.cgi?id=99412

A follow-up change for r131421.

* css/themeWin.css:
(input[type="text"]): Don't reset paddings for date/time types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohb_face_t instances should not depend on FontPlatformData
bashi@chromium.org [Tue, 16 Oct 2012 09:28:06 +0000 (09:28 +0000)]
hb_face_t instances should not depend on FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=99430

Reviewed by Kent Tamura.

Use platform specific font data (e.g. SkTypeface) to get
font tables for harfbuzz-ng.

No new tests. No changes in behavior.

* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp:
(WebCore::harfbuzzCairoGetTable): Takes cairo_scaled_font_t* as userData.
(WebCore::HarfBuzzNGFace::createFace):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp:
(WebCore::harfbuzzCoreTextGetTable): Takes CGFontRef as userData.
(WebCore::HarfBuzzNGFace::createFace):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp:
(WebCore::harfbuzzSkiaGetTable): Takes SkFontID as userData.
(WebCore::HarfBuzzNGFace::createFace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening, TestExpectations updated.
shinyak@chromium.org [Tue, 16 Oct 2012 09:12:29 +0000 (09:12 +0000)]
[Chromium] Unreviewed gardening, TestExpectations updated.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSeparate WebKit2 instances use the same local storage
ossy@webkit.org [Tue, 16 Oct 2012 08:43:03 +0000 (08:43 +0000)]
Separate WebKit2 instances use the same local storage
https://bugs.webkit.org/show_bug.cgi?id=89666

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-10-16
Reviewed by Simon Hausmann.

Source/WebKit2:

For multi-threaded (parallel) testing, WTRs must not write into the same directory.
To avoid that, results need to be stored in the location defined by DUMPRENDERTREE_TEMP
environment variable that is created by NRWT. To do that, WebContext needed to be
extended with diskCacheDirectory and cookieStorageDirectory APIs.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/API/C/WKContext.cpp:
(WKContextSetDiskCacheDirectory):
(WKContextSetCookieStorageDirectory):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::diskCacheDirectory):
(WebKit):
(WebKit::WebContext::cookieStorageDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setDiskCacheDirectory):
(WebKit::WebContext::setCookieStorageDirectory):
(WebContext):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

TestController has been modified to get the local storage from
DUMPRENDERTREE_TEMP environment variable. If it's undefined
then it works with the default directory. The aim is for the parallelly
started WTRs to use separate directories. It was implemented for WK1
long time ago and it works fine.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMIPS assembler coding-style fix.
commit-queue@webkit.org [Tue, 16 Oct 2012 08:42:46 +0000 (08:42 +0000)]
MIPS assembler coding-style fix.
https://bugs.webkit.org/show_bug.cgi?id=99359

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-10-16
Reviewed by Oliver Hunt.

Coding style fix of existing MIPS assembler header files.

* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::addiu):
(JSC::MIPSAssembler::addu):
(JSC::MIPSAssembler::subu):
(JSC::MIPSAssembler::mul):
(JSC::MIPSAssembler::andInsn):
(JSC::MIPSAssembler::andi):
(JSC::MIPSAssembler::nor):
(JSC::MIPSAssembler::orInsn):
(JSC::MIPSAssembler::ori):
(JSC::MIPSAssembler::xorInsn):
(JSC::MIPSAssembler::xori):
(JSC::MIPSAssembler::slt):
(JSC::MIPSAssembler::sltu):
(JSC::MIPSAssembler::sltiu):
(JSC::MIPSAssembler::sll):
(JSC::MIPSAssembler::sllv):
(JSC::MIPSAssembler::sra):
(JSC::MIPSAssembler::srav):
(JSC::MIPSAssembler::srl):
(JSC::MIPSAssembler::srlv):
(JSC::MIPSAssembler::lbu):
(JSC::MIPSAssembler::lw):
(JSC::MIPSAssembler::lwl):
(JSC::MIPSAssembler::lwr):
(JSC::MIPSAssembler::lhu):
(JSC::MIPSAssembler::sb):
(JSC::MIPSAssembler::sh):
(JSC::MIPSAssembler::sw):
(JSC::MIPSAssembler::addd):
(JSC::MIPSAssembler::subd):
(JSC::MIPSAssembler::muld):
(JSC::MIPSAssembler::divd):
(JSC::MIPSAssembler::lwc1):
(JSC::MIPSAssembler::ldc1):
(JSC::MIPSAssembler::swc1):
(JSC::MIPSAssembler::sdc1):
(MIPSAssembler):
(JSC::MIPSAssembler::relocateJumps):
(JSC::MIPSAssembler::linkWithOffset):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::sub32):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::load32):
(JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::load16):
(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::store16):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::test8):
(JSC::MacroAssemblerMIPS::test32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor MacroAssembler interfaces to differentiate the pointer operands from the...
yuqiang.xian@intel.com [Tue, 16 Oct 2012 08:41:31 +0000 (08:41 +0000)]
Refactor MacroAssembler interfaces to differentiate the pointer operands from the 64-bit integer operands
https://bugs.webkit.org/show_bug.cgi?id=99154

Reviewed by Gavin Barraclough.

In current JavaScriptCore implementation for JSVALUE64 platform (i.e.,
the X64 platform), we assume that the JSValue size is same to the
pointer size, and thus EncodedJSValue is simply type defined as a
"void*". In the JIT compiler, we also take this assumption and invoke
the same macro assembler interfaces for both JSValue and pointer
operands. We need to differentiate the operations on pointers from the
operations on JSValues, and let them invoking different macro
assembler interfaces. For example, we now use the interface of
"loadPtr" to load either a pointer or a JSValue, and we need to switch
to using "loadPtr" to load a pointer and some new "load64" interface
to load a JSValue. This would help us supporting other JSVALUE64
platforms where pointer size is not necessarily 64-bits, for example
x32 (bug #99153).

The major modification I made is to introduce the "*64" interfaces in
the MacroAssembler for those operations on JSValues, keep the "*Ptr"
interfaces for those operations on real pointers, and go through all
the JIT compiler code to correct the usage.

This is the first part of the work, i.e, to add the *64 interfaces to
the MacroAssembler.

* assembler/AbstractMacroAssembler.h: Add the Imm64 interfaces.
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::TrustedImm64::TrustedImm64):
(TrustedImm64):
(JSC::AbstractMacroAssembler::Imm64::Imm64):
(Imm64):
(JSC::AbstractMacroAssembler::Imm64::asTrustedImm64):
* assembler/MacroAssembler.h: map <foo>Ptr methods to <foo>64 for X86_64.
(MacroAssembler):
(JSC::MacroAssembler::peek64):
(JSC::MacroAssembler::poke):
(JSC::MacroAssembler::poke64):
(JSC::MacroAssembler::addPtr):
(JSC::MacroAssembler::andPtr):
(JSC::MacroAssembler::negPtr):
(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::rotateRightPtr):
(JSC::MacroAssembler::subPtr):
(JSC::MacroAssembler::xorPtr):
(JSC::MacroAssembler::loadPtr):
(JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
(JSC::MacroAssembler::movePtrToDouble):
(JSC::MacroAssembler::moveDoubleToPtr):
(JSC::MacroAssembler::comparePtr):
(JSC::MacroAssembler::testPtr):
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::shouldBlindDouble):
(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::RotatedImm64::RotatedImm64):
(RotatedImm64):
(JSC::MacroAssembler::rotationBlindConstant):
(JSC::MacroAssembler::loadRotationBlindedConstant):
(JSC::MacroAssembler::move):
(JSC::MacroAssembler::and64):
(JSC::MacroAssembler::store64):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::move):
* assembler/MacroAssemblerX86_64.h: Add the <foo>64 methods for X86_64.
(JSC::MacroAssemblerX86_64::branchAdd32):
(JSC::MacroAssemblerX86_64::add64):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::and64):
(JSC::MacroAssemblerX86_64::neg64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::rotateRight64):
(JSC::MacroAssemblerX86_64::sub64):
(JSC::MacroAssemblerX86_64::xor64):
(JSC::MacroAssemblerX86_64::load64):
(JSC::MacroAssemblerX86_64::load64WithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::load64WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::store64):
(JSC::MacroAssemblerX86_64::store64WithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::move64ToDouble):
(JSC::MacroAssemblerX86_64::moveDoubleTo64):
(JSC::MacroAssemblerX86_64::compare64):
(JSC::MacroAssemblerX86_64::branch64):
(JSC::MacroAssemblerX86_64::branchTest64):
(JSC::MacroAssemblerX86_64::test64):
(JSC::MacroAssemblerX86_64::branchAdd64):
(JSC::MacroAssemblerX86_64::branchSub64):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::storePtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r131418.
commit-queue@webkit.org [Tue, 16 Oct 2012 08:04:33 +0000 (08:04 +0000)]
Unreviewed, rolling out r131418.
http://trac.webkit.org/changeset/131418
https://bugs.webkit.org/show_bug.cgi?id=99431

since 131403 seems innocent (Requested by shinyak|_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-16

* dom/Document.cpp:
(WebCore::isValidNameNonASCII):
(WebCore):
(WebCore::Document::isValidName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Fix Cache Model API tests
commit-queue@webkit.org [Tue, 16 Oct 2012 07:58:14 +0000 (07:58 +0000)]
[EFL][WK2] Fix Cache Model API tests
https://bugs.webkit.org/show_bug.cgi?id=99427

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-16
Reviewed by Gyuyoung Kim.

Cache Model API tests caused "Segmentation fault" because the default value
for cache model was incorrect.

Fix the default value for cache model.
Fix Cache Model API tests.

* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: NMI Instrument InspectorOverlay. It costs us ~9Mb because it creates...
loislo@chromium.org [Tue, 16 Oct 2012 07:57:43 +0000 (07:57 +0000)]
Web Inspector: NMI Instrument InspectorOverlay. It costs us ~9Mb because it creates page size canvas.
https://bugs.webkit.org/show_bug.cgi?id=99426

Reviewed by Yury Semikhatsky.

New object type InspectorOverlay was added. InspectorOverlay was instrumented.
The instrumentation code automatically visits all the objects that can be reached via m_overlayPage.

* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reportMemoryUsage):
(WebCore):
* inspector/InspectorOverlay.h:
(InspectorOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused functions in Locale* classes
tkent@chromium.org [Tue, 16 Oct 2012 07:29:57 +0000 (07:29 +0000)]
Remove unused functions in Locale* classes
https://bugs.webkit.org/show_bug.cgi?id=99425

Reviewed by Yuta Kitamura.

Locale*::currentLocale has been unused since LocalizedDate* and
LocalizedNumber* were removed.

No new tests. This shouldn't change any behavior.

* platform/text/LocaleICU.cpp: Remove createForCurrentLocale and currentLocale.
* platform/text/LocaleICU.h: Ditto.
* platform/text/LocaleWin.cpp: Remove currentLocale.
* platform/text/LocaleWin.h: Ditto.
* platform/text/mac/LocaleMac.h: Remove currentLocale.
* platform/text/mac/LocaleMac.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some appearance glitches of multiple fields input elements
tkent@chromium.org [Tue, 16 Oct 2012 06:54:46 +0000 (06:54 +0000)]
Fix some appearance glitches of multiple fields input elements
https://bugs.webkit.org/show_bug.cgi?id=99412

Reviewed by Kentaro Hara.

Source/WebCore:

1. If CSS-specified width is wider than the intrinsic width of an input,
the spin button and the picker indicator triangle should be put at the
right side of the content area.

2. Remove top, right, and bottom paddings to match input[type=number]
appearance as possible.

3. Remove unnecessary position:relative for spin buttons.

4. Center content vertically if the height is taller than the intrinsic height.

Tests: Update all of rendering tests for input element with multiple fields UI.

* css/html.css:
(input[type="date"]):
- Specify display:-webkit-inline-flex and -webkit-align-items:stretch to center contents.
- Remove top/right/bottom paddings.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-datetime-edit):
- Switch to the starndard flexible box from the legacy one.
- Add white-space:pre to avoid to collapse white spaces.
(input::-webkit-datetime-edit-gap):
Added. This element is added to push a spin button to the right side.
(input::-webkit-date-and-time-container):
Add -webkit-flex:1 for the input flexible box.
Sort properties.
(input[type="week"]::-webkit-inner-spin-button):
- Use this in date, datetime, datetime-local, and week types.
- Add display:inline-block because other elements in -webkit-datetime-edit is inilne.
- Add position:static to cancel position:relative below.

* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::layout):
Add an element with -webkit-datetime-edit-gap before a spin button.

LayoutTests:

All of rendering tests for multiple fields inputs need rebaseline
because of the padding change.

* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html:
Add a fixed height case.
* platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Mark date-suggestion-picker-appearance.html as need rebaseline
keishi@webkit.org [Tue, 16 Oct 2012 06:50:00 +0000 (06:50 +0000)]
[Chromium] Mark date-suggestion-picker-appearance.html as need rebaseline

Unreviewed.

Mark date-suggestion-picker-appearance.html as need rebaseline until chromium side change lands.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: can't click delete button if watch expression is very long
yurys@chromium.org [Tue, 16 Oct 2012 06:41:58 +0000 (06:41 +0000)]
Web Inspector: can't click delete button if watch expression is very long
https://bugs.webkit.org/show_bug.cgi?id=99414

Reviewed by Vsevolod Vlasov.

Minus button in watch expression section doesn't overlap with the
expression/value anymore.

* inspector/front-end/inspector.css:
(.properties-tree.watch-expressions > li.hovered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r131403.
commit-queue@webkit.org [Tue, 16 Oct 2012 06:38:26 +0000 (06:38 +0000)]
Unreviewed, rolling out r131403.
http://trac.webkit.org/changeset/131403
https://bugs.webkit.org/show_bug.cgi?id=99420

Suspicious to cause Performance test failing (Requested by
shinyak|gardenin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-15

* dom/Document.cpp:
(WebCore::Document::isValidName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Regression(r131337): Made 3 Cookie Manager API tests fail
commit-queue@webkit.org [Tue, 16 Oct 2012 06:37:24 +0000 (06:37 +0000)]
[EFL][WK2] Regression(r131337): Made 3 Cookie Manager API tests fail
https://bugs.webkit.org/show_bug.cgi?id=99416

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-15
Reviewed by Gyuyoung Kim.

After r131337, the favicon database is enabled and it causes new
requests to "/favicon.ico" on the http server. The http server used
in the cookie manager test was too strict and was calling FAIL() for
any unrecognized HTTP request (such as the one to /favicon.ico).
This patch makes the http server in cookie manager API tests less
strict.

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(serverCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Display page favicons in MiniBrowser
commit-queue@webkit.org [Tue, 16 Oct 2012 06:31:04 +0000 (06:31 +0000)]
[EFL][WK2] Display page favicons in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99265

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-15
Reviewed by Gyuyoung Kim.

Display current page favicon in the URL bar.
This uses the new favicon database API in
EFL WebKit2.

* MiniBrowser/efl/main.c:
(on_favicon_received):
(on_view_icon_changed):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove suggestion picker tests to suggestion-picker directory
keishi@webkit.org [Tue, 16 Oct 2012 06:25:22 +0000 (06:25 +0000)]
Move suggestion picker tests to suggestion-picker directory
https://bugs.webkit.org/show_bug.cgi?id=99415

Reviewed by Kent Tamura.

Moving the tests suggestion picker tests to platform/chromium/fast/forms/suggestion-picker chromium android can easily skip them.

* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations-expected.txt: Renamed from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt.
* platform/chromium/TestExpectations: Removed obsolete lines.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html: Renamed from LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html:
* platform/chromium/fast/forms/suggestion-picker/suggestion-picker-common.js: Renamed from LayoutTests/fast/forms/resources/suggestion-picker-common.js.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl.html.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar.html.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance.html: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-appearance.html.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations.html.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html:
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-mouse-operations-expected.txt.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html: Renamed from LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-mouse-operations.html.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: restore watch expression expansion state
yurys@chromium.org [Tue, 16 Oct 2012 05:54:32 +0000 (05:54 +0000)]
Web Inspector: restore watch expression expansion state
https://bugs.webkit.org/show_bug.cgi?id=99304

Reviewed by Pavel Feldman.

Expand watch expression value and its properties if they were expanded
before update.

Source/WebCore:

Test: inspector/debugger/watch-expressions-preserve-expansion.html

* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.onexpand):
(WebInspector.WatchExpressionTreeElement.prototype.oncollapse):
(WebInspector.WatchExpressionTreeElement.prototype.onattach):
(WebInspector.WatchExpressionTreeElement.prototype._expression):
(WebInspector.WatchedPropertyTreeElement):
(WebInspector.WatchedPropertyTreeElement.prototype.onattach):
(WebInspector.WatchedPropertyTreeElement.prototype.onexpand):
(WebInspector.WatchedPropertyTreeElement.prototype.oncollapse):
(WebInspector.WatchedPropertyTreeElement.prototype._propertyPath):

LayoutTests:

* inspector/debugger/watch-expressions-preserve-expansion-expected.txt: Added.
* inspector/debugger/watch-expressions-preserve-expansion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWarn when CSP headers don't separate directives with ';'.
mkwst@chromium.org [Tue, 16 Oct 2012 05:25:34 +0000 (05:25 +0000)]
Warn when CSP headers don't separate directives with ';'.
https://bugs.webkit.org/show_bug.cgi?id=99274

Reviewed by Adam Barth.

Source/WebCore:

A recent bug report exhibited confusion as to what role, exactly,
semicolons play in Content Security Policy definitions. This patch
adjusts the parser to warn web authors if a directive name is
encountered while parsing a source list, which would almost certainly
point to a missing semicolon. For example, something like:

    script-src 'self' object-src 'self' style-src *

would throw two warnings, noting that 'object-src' and 'style-src' are
probably meant as directives, and not as source expressions in the
'script-src' source list.

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::parse):
    Throw the new warning onto the console if the hostname of a source
    expression matches a CSP directive name.
(WebCore::CSPDirectiveList::addDirective):
    Use the exciting new static variables so that the names of various
    directives are available outside of CSPDirectiveList::addDirective.
    These were previously defined as local static ASCIILiterals. Now
    they're static const char[] in an anonymous namespace.
(WebCore::ContentSecurityPolicy::isDirectiveName):
    Static method that compares a string to all the known directive
    names, returning true if there's a (case-insensitive) match.
(WebCore):
(WebCore::ContentSecurityPolicy::reportDirectiveAsSourceExpression):
    A new warning message which should be printed when a directive name
    is encountered as a source expression. Matching the directive name
    is done via a new 'isDirectiveName' function which lives in an
    anonymous namespace along with the other CSP helper functions.
* page/ContentSecurityPolicy.h:
    Added 'reportDirectiveAsSourceExpression' signature.

LayoutTests:

* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r131349.
gyuyoung.kim@samsung.com [Tue, 16 Oct 2012 05:16:55 +0000 (05:16 +0000)]
Unreviewed, rolling out r131349.
http://trac.webkit.org/changeset/131349
https://bugs.webkit.org/show_bug.cgi?id=97173

Revert r131349 because API test is broken by this commit.

Source/WebCore:

* platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):

Source/WebKit2:

* UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):
* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResourceLoader::sendResourceLoadCallbacks() is backwards
japhet@chromium.org [Tue, 16 Oct 2012 05:14:44 +0000 (05:14 +0000)]
ResourceLoader::sendResourceLoadCallbacks() is backwards
https://bugs.webkit.org/show_bug.cgi?id=99366

Reviewed by Daniel Bates.

No new tests, this function is uncalled but will be used
in a later patch.

* loader/ResourceLoader.h:
(WebCore::ResourceLoader::sendResourceLoadCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r131365): WidthIterator::advance() is needlessly passed a GlyphBuffer...
mitz@apple.com [Tue, 16 Oct 2012 05:07:56 +0000 (05:07 +0000)]
REGRESSION (r131365): WidthIterator::advance() is needlessly passed a GlyphBuffer in many cases
https://bugs.webkit.org/show_bug.cgi?id=99413

Reviewed by Adele Peterson.

r131365 made Font::width() always pass a GlyphBuffer pointer to floatWidthForSimpleText and
from there down to WidthIterator::advance(). However, when measuring the width of a run, a
GlyphBuffer is only needed if font transforms (kerning and ligatures) need to be applied.

No new test, because there is no change in behavior.

* platform/graphics/Font.cpp:
(WebCore::Font::width): Removed the local GlyphBuffer that was passed down to
floatWidthForSimpleText().
* platform/graphics/Font.h: Removed the GlyphBuffer* parameter to floatWidthForSimpleText.
All but the above caller were passing 0.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::floatWidthForSimpleText): Removed the GlyphBuffer* parameter and added a
local GlyphBuffer, which is passed by reference to WidthIterator::advance() only if
typesetting features require it.
(WebCore::Font::offsetForPositionForSimpleText): Updated for change to
floatWidthForSimpleText.
* platform/graphics/pango/FontPango.cpp:
(WebCore::Font::floatWidthForComplexText): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
commit-queue@webkit.org [Tue, 16 Oct 2012 04:42:00 +0000 (04:42 +0000)]
[BlackBerry] Web Inspector: Remove the useless preferences items in "inspectorBB.js"
https://bugs.webkit.org/show_bug.cgi?id=99404

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-10-15
Reviewed by George Staikos.

In "inspectorBB.js", remove the useless preferences items to catch up the new code of frontend.

* WebCoreSupport/inspectorBB.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd force parameter to DOMTokenList.toggle
commit-queue@webkit.org [Tue, 16 Oct 2012 03:57:02 +0000 (03:57 +0000)]
Add force parameter to DOMTokenList.toggle
https://bugs.webkit.org/show_bug.cgi?id=99375

Patch by Pablo Flouret <pablof@motorola.com> on 2012-10-15
Reviewed by Darin Adler.

Source/WebCore:

See http://dom.spec.whatwg.org/#dom-domtokenlist-toggle and
https://www.w3.org/Bugs/Public/show_bug.cgi?id=18463

Essentially, the optional boolean force parameter, if present, makes
toggle always add or remove a class.

No new tests, modified fast/dom/HTMLElement/script-tests/class-list.js

* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::toggle):
(WebCore):
* html/DOMTokenList.h:
(DOMTokenList):
* html/DOMTokenList.idl:
    New toggle() overload that takes a force parameter and calls
    addInternal() or removeInternal() based on it.

LayoutTests:

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
(shouldThrowDOMException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening, TestExpectations updated.
shinyak@chromium.org [Tue, 16 Oct 2012 03:51:00 +0000 (03:51 +0000)]
[Chromium] Unreviewed gardening, TestExpectations updated.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed a typo in the change log.
mitz@apple.com [Tue, 16 Oct 2012 03:48:58 +0000 (03:48 +0000)]
Fixed a typo in the change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test fast/text/justify-ideograph-leading-expansion.html is failing an assertio...
mitz@apple.com [Tue, 16 Oct 2012 03:47:25 +0000 (03:47 +0000)]
Layout Test fast/text/justify-ideograph-leading-expansion.html is failing an assertion chromium mac
https://bugs.webkit.org/show_bug.cgi?id=99406

Reviewed by Darin Adler.

* platform/graphics/WidthIterator.cpp:
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::shouldApplyFontTransforms): Changed to return false if the run is
shorter than 2 characters. 1-character are invariant under font transforms, and therefore
Font::codePath() sends them through WidthIterator even on platforms where WidthIterator
does not support kerning and ligatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd tests for suggestion picker that test step/min/max attributes
keishi@webkit.org [Tue, 16 Oct 2012 03:43:29 +0000 (03:43 +0000)]
Add tests for suggestion picker that test step/min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=99168

Reviewed by Kent Tamura.

These tests that setting step/min/max attributes filters out values from the suggestion picker.

* fast/forms/resources/suggestion-picker-common.js:
(valueForEntry): Returns value for an suggestion list entry element.
(highlightedEntry):
(entryValues): Returns an array of entry values.
(openPicker): Added callback argument.
(popupOpenCallbackWrapper):
* platform/chromium-android/TestExpectations:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd 8 bit patch to Document::isValidName() for the non ASCII case
msaboff@apple.com [Tue, 16 Oct 2012 03:29:18 +0000 (03:29 +0000)]
Add 8 bit patch to Document::isValidName() for the non ASCII case
https://bugs.webkit.org/show_bug.cgi?id=99402

Reviewed by Darin Adler.

Added 8 bit path to complete the processing of an 8 bit names without up-converting.

* dom/Document.cpp:
(WebCore::isValidNameNonASCII):
(WebCore::Document::isValidName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport for background-clip:content-box and padding-box with border-radius
commit-queue@webkit.org [Tue, 16 Oct 2012 03:26:49 +0000 (03:26 +0000)]
Support for background-clip:content-box and padding-box with border-radius
https://bugs.webkit.org/show_bug.cgi?id=23166

Patch by Vlad Grecescu  <igrecesc@adobe.com>, Douglas Stockwell <dstockwell@chromium.org> on 2012-10-15
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/background-clip-radius-values.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderBoxModelObject.h:

LayoutTests:

* fast/css/background-clip-radius-values-expected.png: Added.
* fast/css/background-clip-radius-values-expected.txt: Added.
* fast/css/background-clip-radius-values.html: Added.
* platform/chromium-linux/fast/css/background-clip-radius-values-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
* platform/chromium/TestExpectations:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/qt/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add APIs for cache model
commit-queue@webkit.org [Tue, 16 Oct 2012 03:25:08 +0000 (03:25 +0000)]
[EFL][WK2] Add APIs for cache model
https://bugs.webkit.org/show_bug.cgi?id=98889

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-10-15
Reviewed by Gyuyoung Kim.

Add ewk_context_cache_model_set(), ewk_context_cache_model_get().

The cache model means the level for the cache capacity.
If EWK_CACHE_MODEL_DOCUMENT_BROWSER, the biggest cache capacity will be set.

* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_cache_model_set):
(ewk_context_cache_model_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test *-multiple-fields-keyboard-events.html etc. are failing on...
tkent@chromium.org [Tue, 16 Oct 2012 03:20:18 +0000 (03:20 +0000)]
[Chromium] Layout Test *-multiple-fields-keyboard-events.html etc. are failing on Win XP
https://bugs.webkit.org/show_bug.cgi?id=99408

These failures are expected. Just do rebaseline.

* platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Added.
* platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Added.
* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable FAST_MOBILE_SCROLLING for Android
peter@chromium.org [Tue, 16 Oct 2012 02:46:15 +0000 (02:46 +0000)]
[Chromium] Enable FAST_MOBILE_SCROLLING for Android
https://bugs.webkit.org/show_bug.cgi?id=99401

Reviewed by Adam Barth.

* features.gypi: Add the define to the Android-only section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 16 Oct 2012 02:36:11 +0000 (02:36 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix unused parameter build warning.
commit-queue@webkit.org [Tue, 16 Oct 2012 02:05:47 +0000 (02:05 +0000)]
Fix unused parameter build warning.
https://bugs.webkit.org/show_bug.cgi?id=99400

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-15
Reviewed by Gyuyoung Kim.

Remove the name of unused parameters to fix the build warning (-Wunused-parameter).

Source/WebCore:

* platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::tlsError):

Source/WebKit2:

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getSharedWorkerProcessConnection):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::handleEditingCommand):
(WebKit::NetscapePlugin::isEditingCommandEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening, TestExpectations updated.
shinyak@chromium.org [Tue, 16 Oct 2012 01:59:54 +0000 (01:59 +0000)]
[Chromium] Unreviewed gardening, TestExpectations updated.

Now lint passes.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] WebSocketInflater should handle BFINAL = 1 blocks
bashi@chromium.org [Tue, 16 Oct 2012 01:40:45 +0000 (01:40 +0000)]
[WebSocket] WebSocketInflater should handle BFINAL = 1 blocks
https://bugs.webkit.org/show_bug.cgi?id=99282

Reviewed by Yuta Kitamura.

Source/WebCore:

Reset decompression state if WebSocketInflater decompress a block with
BFINAL set to 1.

Test: http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html

* Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketInflater::addBytes):
Reset decompression state if inflate() returns Z_STREAM_END, which means the BFINAL
of the current block was set to 1.
(WebCore::WebSocketInflater::finish): Add an assertion.

LayoutTests:

Added a test for receiving compressed blocks with BFINAL set to 1.

* http/tests/websocket/tests/hybi/deflate-frame-set-bfinal-expected.txt: Added.
* http/tests/websocket/tests/hybi/deflate-frame-set-bfinal.html: Added.
* http/tests/websocket/tests/hybi/deflate-frame_wsh.py:
(web_socket_do_extra_handshake): Call set_bfinal() if the 'set_bfinal' parameter is passed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] The default target for Android builds should be "all" instead of "All"
peter@chromium.org [Tue, 16 Oct 2012 01:20:18 +0000 (01:20 +0000)]
[Chromium] The default target for Android builds should be "all" instead of "All"
https://bugs.webkit.org/show_bug.cgi?id=98879

Reviewed by Adam Barth.

The default gyp target for Android builds is being overridden in Chromium's
envsetup_functions.sh to "All" (whereas the rest of Chromium and WebKit use "all"),
because Android wants to use a different list of main targets. There is
no need to do this for the WebKit project, and it's breaking ninja.

* gyp_webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix GraphicsLayer visible rect computation when scrolling in WebKit1
simon.fraser@apple.com [Tue, 16 Oct 2012 01:17:47 +0000 (01:17 +0000)]
Fix GraphicsLayer visible rect computation when scrolling in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=99385

Reviewed by Dean Jackson, Tim Horton.

Source/WebCore:

RenderLayerCompositor always used frameView->frameRect() as the visible
rect on the root used for GraphicsLayer visibleRect computation. This
was wrong for subframes, which require a rect with an origin of (0,0)
and size of the contentsSize().

It was also wrong when the scrolling is not represented in the GraphicsLayer
tree. When scrolling is done elsewhere, we need to use the ScrollView's
visibleContentRect().

Tests: compositing/visible-rect/scrolled.html
       compositing/visible-rect/iframe-and-layers.html
       compositing/visible-rect/iframe-no-layers.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

LayoutTests:

scrolled.html tests the visible rect after scrolling. The other tests
are for visibleRect in iframes, with and without compositing layers
in the parent document (which exercises different code paths in WebKit1).

* compositing/visible-rect/iframe-and-layers-expected.txt: Added.
* compositing/visible-rect/iframe-and-layers.html: Added.
* compositing/visible-rect/iframe-no-layers-expected.txt: Added.
* compositing/visible-rect/iframe-no-layers.html: Added.
* compositing/visible-rect/resources/subframe-with-layers.html: Added.
* compositing/visible-rect/scrolled-expected.txt: Added.
* compositing/visible-rect/scrolled.html: Added.
* platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLocaleMacTest.formatDate is failing on Mac 10.8
tkent@chromium.org [Tue, 16 Oct 2012 01:13:14 +0000 (01:13 +0000)]
LocaleMacTest.formatDate is failing on Mac 10.8
https://bugs.webkit.org/show_bug.cgi?id=99330

It seems OS X 10.8 and 10.7 return different date formats for ja_JP
locale. We should not test such locales.

* tests/LocaleMacTest.cpp:
(TEST_F): Remove a test for ja_JP locale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove page visibility hidden histograms
jchaffraix@webkit.org [Tue, 16 Oct 2012 00:53:31 +0000 (00:53 +0000)]
Remove page visibility hidden histograms
https://bugs.webkit.org/show_bug.cgi?id=99360

Reviewed by Ojan Vafai.

The 2 page visibility hidden histograms were added in http://webkit.org/b/85537 to
investigate a potential optimization where we would destroy the render tree when
a tab was hidden. The optimization was abandoned but the histograms were never
removed. They are too narrow to be reused so this change removes them.

* page/Page.cpp:
(WebCore::Page::setVisibilityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Build break after r131373 when ACCELERATED_COMPOSITING disabled
ryuan.choi@samsung.com [Tue, 16 Oct 2012 00:48:06 +0000 (00:48 +0000)]
REGRESSION: Build break after r131373 when ACCELERATED_COMPOSITING disabled
https://bugs.webkit.org/show_bug.cgi?id=99397

Unreviewed, build fix.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInput elements with multiple fields UI should set appropriate direction for browser...
tkent@chromium.org [Tue, 16 Oct 2012 00:39:28 +0000 (00:39 +0000)]
Input elements with multiple fields UI should set appropriate direction for browser locale automatically
https://bugs.webkit.org/show_bug.cgi?id=99291

Reviewed by Hajime Morita.

Source/WebCore:

Input elemnts with multiple fields UI ignores HTML dir attribute or CSS
direction property, and their direction should be decided by the browser
locale. If the browser locale is a RTL language, date/time input fields
show formats/digits for the RTL language. The layout should be always
RTL regardless of the direction in such case.

Test: fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
Set approriate dir attribute value to the child element of the UA shadow root.

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html:
Added. We can confirm ar-eg and he-il have RTL layout.
* fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt: Added.
* platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Added.

* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
- Enable the lang-attribute-aware-form-control-UI feature.
- Set lang=he-il instead of dir=rtl because dir=rtl is ignored.
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Ditto.
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Ditto.

* platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
Updated becaues dir=RTL doesn't affect.
* platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
Ditto.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
Ditto.
* platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
Ditto.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyleResolver: Garbage collect the matched properties cache on a timer.
kling@webkit.org [Tue, 16 Oct 2012 00:36:39 +0000 (00:36 +0000)]
StyleResolver: Garbage collect the matched properties cache on a timer.
<http://webkit.org/b/98625>

Reviewed by Eric Seidel.

Sweeping the matched properties cache once every 100 additions ended up choking RoboHornet's
svgresize.html benchmark. Move it to a single-shot timer that's refreshed every 100 additions
and defers the actual sweep for 60 seconds.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::addToMatchedPropertiesCache):
* css/StyleResolver.h:
(StyleResolver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] GstCaps are leaked when building with gstreamer-1.0
commit-queue@webkit.org [Tue, 16 Oct 2012 00:35:17 +0000 (00:35 +0000)]
[GStreamer] GstCaps are leaked when building with gstreamer-1.0
https://bugs.webkit.org/show_bug.cgi?id=99362

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-15
Reviewed by Martin Robinson.

Implement GRefPtr<GstCaps> adoptGRef(GstCaps*).

Change webkitGstGetPadCaps signature to return a GRefPtr<GstCaps>, and
use GRefPtr<GstCaps> also in webkitVideoSinkRender to simply GstCaps
refeference count.

Covered by existing tests.

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGstGetPadCaps):
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinspector/styles/styles-computed-trace.html is timing out
danakj@chromium.org [Tue, 16 Oct 2012 00:20:08 +0000 (00:20 +0000)]
inspector/styles/styles-computed-trace.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=99391

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinspector/debugger/xhr-breakpoints.html is flaky
danakj@chromium.org [Tue, 16 Oct 2012 00:18:40 +0000 (00:18 +0000)]
inspector/debugger/xhr-breakpoints.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=99389

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate the url bar in MiniBrowser when getting the committed URL
simon.fraser@apple.com [Tue, 16 Oct 2012 00:15:55 +0000 (00:15 +0000)]
Update the url bar in MiniBrowser when getting the committed URL
https://bugs.webkit.org/show_bug.cgi?id=99388

Reviewed by Sam Weinig.

Fix both WK1 and WK2 window controllers to update the URL in the
text field when transitioning to the committed URL. This fixes
the URL when dragging local files into the window.

* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController updateTextFieldFromURL:]):
(-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
(-[WK2BrowserWindowController updateCommittedURLForFrame:]):
(-[WK2BrowserWindowController didCommitLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html is failing.
danakj@chromium.org [Tue, 16 Oct 2012 00:08:48 +0000 (00:08 +0000)]
Layout Test webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=99357

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r131358.
danakj@chromium.org [Mon, 15 Oct 2012 23:58:22 +0000 (23:58 +0000)]
Rebaseline after r131358.

Unreviewed gardening.

* platform/chromium-win-xp/css1/basic/inheritance-expected.png: Added.
* platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
* platform/chromium-win-xp/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug73321-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't show the content shell and android test bots for webkit ToT
ojan@chromium.org [Mon, 15 Oct 2012 23:27:49 +0000 (23:27 +0000)]
Don't show the content shell and android test bots for webkit ToT
https://bugs.webkit.org/show_bug.cgi?id=99380

Reviewed by Dirk Pranke.

Content shell used to coincidentally be skipped because it spelled WebKit correctly.
Now skip it explicitly. The Android bot is up and running, but only has a stub for
running tests. Skip it so we don't show a false error.
* TestResultServer/static-dashboards/builders.js:
(isChromiumWebkitTipOfTreeTestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoskip crashing softwarecompositing bugs
dpranke@chromium.org [Mon, 15 Oct 2012 23:27:45 +0000 (23:27 +0000)]
skip crashing softwarecompositing bugs
https://bugs.webkit.org/show_bug.cgi?id=99381

Reviewed by Adrienne Walker.

These tests might be hanging the win (dbg)(2) bot; apart from
that, there's not a lot of point in running tests that are known
to be for unimplemented features.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd MountainLion Performance-bot to the Performance bots waterfall link
zoltan@webkit.org [Mon, 15 Oct 2012 23:24:37 +0000 (23:24 +0000)]
Add MountainLion Performance-bot to the Performance bots waterfall link
https://bugs.webkit.org/show_bug.cgi?id=99378

Reviewed by Dirk Pranke.

Add MountainLion Performance-bot to the Performance bots waterfall link on the buildbots frontpage.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r131367.
tony@chromium.org [Mon, 15 Oct 2012 23:17:48 +0000 (23:17 +0000)]
Unreviewed, rolling out r131367.
http://trac.webkit.org/changeset/131367
https://bugs.webkit.org/show_bug.cgi?id=98666

crashes on Apple Mac

Source/WebCore:

* css/html.css:
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
* css/mediaControlsChromium.css:
(input[type="range"]::-webkit-media-slider-thumb):
* css/mediaControlsChromiumAndroid.css:
(input[type="range"]::-webkit-media-slider-thumb):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::layout):
(WebCore):
(WebCore::RenderSliderContainer::RenderSliderContainer):
(RenderSliderContainer):
(WebCore::RenderSliderContainer::layout):
* html/shadow/SliderThumbElement.h:
(RenderSliderThumb):
* rendering/RenderSlider.cpp:
(WebCore):
(WebCore::RenderSlider::RenderSlider):
(WebCore::RenderSlider::layout):
* rendering/RenderSlider.h:
(WebCore):
(RenderSlider):
(WebCore::RenderSlider::renderName):
(WebCore::RenderSlider::isSlider):
(WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
(WebCore::toRenderSlider):

LayoutTests:

* css3/flexbox/flexitem-stretch-range-expected.html: Removed.
* css3/flexbox/flexitem-stretch-range.html: Removed.
* platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png:
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-padding-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/chromium-linux/fast/multicol/client-rects-expected.txt:
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/chromium-linux/fast/repaint/slider-thumb-float-expected.txt:
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/audio-repaint-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-styling-strict-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-controls-clone-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-playing-and-pause-expected.txt:
* platform/chromium-win/media/video-zoom-controls-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix the build again after r131375.
mitz@apple.com [Mon, 15 Oct 2012 23:04:16 +0000 (23:04 +0000)]
Try to fix the build again after r131375.

* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::shouldApplyFontTransforms): Removed the length check from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html for chromium-linux
crogers@google.com [Mon, 15 Oct 2012 22:55:41 +0000 (22:55 +0000)]
Rebaseline webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html for chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=99377

Unreviewed rebaseline.

* platform/chromium-linux-x86/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* platform/chromium-linux/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* platform/chromium-mac/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix assertion failures on ports that do not support kerning and ligatures...
mitz@apple.com [Mon, 15 Oct 2012 22:52:35 +0000 (22:52 +0000)]
Try to fix assertion failures on ports that do not support kerning and ligatures on the fast
code path after r131365.

* platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms): Changed the early return condition to not bother with 1-glyph
sequences.
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::shouldApplyFontTransforms): Changed to return false if the run is
shorter than 2 characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix the Chromium Mac build after r131365.
mitz@apple.com [Mon, 15 Oct 2012 22:36:14 +0000 (22:36 +0000)]
Try to fix the Chromium Mac build after r131365.

* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBufferAdvance::height): Added.
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs): Changed to use accessors for the GlyphBufferAdvance’s width and height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnsure that GraphicsLayer positions are updated while doing threaded scrolling
simon.fraser@apple.com [Mon, 15 Oct 2012 22:31:08 +0000 (22:31 +0000)]
Ensure that GraphicsLayer positions are updated while doing threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=99372

Reviewed by Anders Carlsson.

When doing threaded scrolling, the scrolling thread updates the positions of CALayers,
but doesn't update GraphicsLayers. This means that code that relies on GraphicsLayer positions
works incorrectly.

Threaded scrolling is not testabled in layout tests.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
(WebCore::GraphicsLayer::syncPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Implement RTCDataChannel
tommyw@google.com [Mon, 15 Oct 2012 22:21:07 +0000 (22:21 +0000)]
MediaStream API: Implement RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=99080

Reviewed by Adam Barth.

This patch introduces RTCDataChannel which is a pipe for sending data between two RTCPeerConnections.
Since the data channel belongs to a peer connection object I have reused part of its infrastructure.

Not currently testable. My next patch will add the chromium WebKit functionality, together with mocks and tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCDataChannel.cpp: Added.
(WebCore):
(WebCore::RTCDataChannel::create):
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::~RTCDataChannel):
(WebCore::RTCDataChannel::label):
(WebCore::RTCDataChannel::reliable):
(WebCore::RTCDataChannel::readyState):
(WebCore::RTCDataChannel::bufferedAmount):
(WebCore::RTCDataChannel::binaryType):
(WebCore::RTCDataChannel::setBinaryType):
(WebCore::RTCDataChannel::send):
(WebCore::RTCDataChannel::close):
(WebCore::RTCDataChannel::readyStateChanged):
(WebCore::RTCDataChannel::dataArrived):
(WebCore::RTCDataChannel::error):
(WebCore::RTCDataChannel::descriptor):
(WebCore::RTCDataChannel::interfaceName):
(WebCore::RTCDataChannel::scriptExecutionContext):
(WebCore::RTCDataChannel::stop):
(WebCore::RTCDataChannel::eventTargetData):
(WebCore::RTCDataChannel::ensureEventTargetData):
* Modules/mediastream/RTCDataChannel.h: Added.
(WebCore):
(RTCDataChannel):
(WebCore::RTCDataChannel::refEventTarget):
(WebCore::RTCDataChannel::derefEventTarget):
* Modules/mediastream/RTCDataChannel.idl: Added.
* Modules/mediastream/RTCDataChannelEvent.cpp: Added.
(WebCore):
(WebCore::RTCDataChannelEvent::create):
(WebCore::RTCDataChannelEvent::RTCDataChannelEvent):
(WebCore::RTCDataChannelEvent::~RTCDataChannelEvent):
(WebCore::RTCDataChannelEvent::channel):
(WebCore::RTCDataChannelEvent::interfaceName):
* Modules/mediastream/RTCDataChannelEvent.h: Added.
(WebCore):
(RTCDataChannelEvent):
* Modules/mediastream/RTCDataChannelEvent.idl: Added.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didAddRemoteDataChannel):
(WebCore::RTCPeerConnection::stop):
* Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* dom/EventTargetFactory.in:
* platform/mediastream/RTCDataChannelDescriptor.cpp: Added.
(WebCore):
(WebCore::RTCDataChannelDescriptor::create):
(WebCore::RTCDataChannelDescriptor::RTCDataChannelDescriptor):
(WebCore::RTCDataChannelDescriptor::~RTCDataChannelDescriptor):
(WebCore::RTCDataChannelDescriptor::readyStateChanged):
(WebCore::RTCDataChannelDescriptor::dataArrived):
(WebCore::RTCDataChannelDescriptor::error):
* platform/mediastream/RTCDataChannelDescriptor.h: Added.
(WebCore):
(RTCDataChannelDescriptorClient):
(WebCore::RTCDataChannelDescriptorClient::~RTCDataChannelDescriptorClient):
(RTCDataChannelDescriptor):
(ExtraData):
(WebCore::RTCDataChannelDescriptor::ExtraData::~ExtraData):
(WebCore::RTCDataChannelDescriptor::client):
(WebCore::RTCDataChannelDescriptor::setClient):
(WebCore::RTCDataChannelDescriptor::label):
(WebCore::RTCDataChannelDescriptor::reliable):
(WebCore::RTCDataChannelDescriptor::readyState):
(WebCore::RTCDataChannelDescriptor::bufferedAmount):
(WebCore::RTCDataChannelDescriptor::setBufferedAmount):
(WebCore::RTCDataChannelDescriptor::extraData):
(WebCore::RTCDataChannelDescriptor::setExtraData):
* platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::openDataChannel):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::sendStringData):
(WebCore::RTCPeerConnectionHandlerDummy::sendRawData):
(WebCore::RTCPeerConnectionHandlerDummy::closeDataChannel):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::openDataChannel):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::sendStringData):
(WebCore::RTCPeerConnectionHandlerChromium::sendRawData):
(WebCore::RTCPeerConnectionHandlerChromium::closeDataChannel):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Pass type of error causing abort to IDBTransaction::onAbort
jsbell@chromium.org [Mon, 15 Oct 2012 22:19:08 +0000 (22:19 +0000)]
IndexedDB: Pass type of error causing abort to IDBTransaction::onAbort
https://bugs.webkit.org/show_bug.cgi?id=99097

Reviewed by Tony Chang.

Source/WebCore:

Include the error causing the abort in the callback from back end to
front end so it can be exposed on the IDBTransaction.error property.

Test: lazy-index-population.html

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
* Modules/indexeddb/IDBDatabaseCallbacks.h:
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore):
(WebCore::IDBTransactionBackendImpl::commit):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionCallbacks.h:
(IDBTransactionCallbacks):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):

Source/WebKit/chromium:

Plumbing to pass details about the cause of the transaction abort through to the
front end.

* public/WebIDBTransactionCallbacks.h:
(WebKit):
(WebKit::WebIDBTransactionCallbacks::onAbort):
* src/IDBTransactionCallbacksProxy.cpp:
(WebKit::IDBTransactionCallbacksProxy::onAbort):
* src/IDBTransactionCallbacksProxy.h:
(IDBTransactionCallbacksProxy):
* src/WebIDBTransactionCallbacksImpl.cpp:
(WebKit::WebIDBTransactionCallbacksImpl::onAbort):
* src/WebIDBTransactionCallbacksImpl.h:
(WebIDBTransactionCallbacksImpl):

LayoutTests:

Verify that IDBTransaction.error is reporting ConstraintError when indexing fails.

* storage/indexeddb/lazy-index-population-expected.txt:
* storage/indexeddb/lazy-index-population.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIn Skia's ImageFrame, only set the isOpaque flag when the frame is complete
reed@google.com [Mon, 15 Oct 2012 22:15:46 +0000 (22:15 +0000)]
In Skia's ImageFrame, only set the isOpaque flag when the frame is complete
https://bugs.webkit.org/show_bug.cgi?id=99326

Reviewed by Stephen White.

No new tests -- existing layouttests exercise this, esp.
  png-partial-load-no-alpha.html
  webp-partial-load.html
These two fail if skia is told that these are opaque, which it is w/o this CL.

At the moment, Skia has a hack to ignore the opaque-setting, so that these tests will pass as is.
This change is to first, correct webkit to only set isOpaque when the frame is complete, so that
in a later change, Skia can remove the hack, and re-enable its opaqueness optimization.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselines after 131358.
danakj@chromium.org [Mon, 15 Oct 2012 22:08:22 +0000 (22:08 +0000)]
Rebaselines after 131358.

Unreviewed gardening.

* platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselines after 131358
danakj@chromium.org [Mon, 15 Oct 2012 22:05:32 +0000 (22:05 +0000)]
Rebaselines after 131358

Unreviewed gardening.

* platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-mac/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinput[type=range] as a flex item renders thumb at wrong position
tony@chromium.org [Mon, 15 Oct 2012 22:02:31 +0000 (22:02 +0000)]
input[type=range] as a flex item renders thumb at wrong position
https://bugs.webkit.org/show_bug.cgi?id=98666

Reviewed by Ojan Vafai.

Source/WebCore:

Replace RenderSlider implementation with new flexbox and clean up the shadow DOM.
The previous code was trying to set the height to 100% and had a bunch of hacks in
the renderer code to set an explicit height. Using the new flexbox allows us to
remove these renderer hacks.

Test: css3/flexbox/flexitem-stretch-range.html

* css/html.css:
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container): Use new flexbox.
(input[type="range"]::-webkit-slider-runnable-track): Use new flexbox.
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb): Remove relative positioning since we're
no longer setting top/left in the layout code.
* css/mediaControlsChromium.css: Remove redundant styles and bottom: 1px hack.
* css/mediaControlsChromiumAndroid.css: Remove redundant styles and bottom: 1px hack.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged): We need to force a layout
since the height of the control should change when adding/removing a datalist.
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::RenderSliderContainer): Use new flexbox.
(WebCore::RenderSliderContainer::computeLogicalHeight): Rather than setting style()->height() in layout, just compute the correct
height when asked.  If we have a datalist, we increase the height (same code as before).  If we're vertical,
we use the intrinsic size.
(WebCore::RenderSliderContainer::layout): Remove extra layout code, but handle the position of the thumb.
This used to be handled in the thumb's layout method, but I deleted that.
* html/shadow/SliderThumbElement.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::RenderSlider): Use new flexbox.
(WebCore::RenderSlider::layout): Set the limiter size to the size of the thumb. This is necessary
for fast/css/unknown-pseudo-element-matching.html which tries to set the height of the thumb to 1px
and expects the input to also have a height of 1px.  It worked before because the height of the input
didn't depend on the height of its children.
* rendering/RenderSlider.h: Fix indentation.
(RenderSlider): Use new flexible box.

LayoutTests:

Changing the render tree to use RenderFlexibleBox instead of RenderDeprecatedFlexibleBox
and not using a RenderLayer unless noted otherwise.

* css3/flexbox/flexitem-stretch-range-expected.html: Added.
* css3/flexbox/flexitem-stretch-range.html: Added. New test to verify stretched flex item has the
thumb in the correct place.
* platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Changed the default height to
129px for vertical controls. This makes more sense than having a height of 100%.
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png: The thumb now appears below the
focus ring. This matches other form controls like buttons and textareas.
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-padding-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/chromium-linux/fast/multicol/client-rects-expected.txt:
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/chromium-linux/fast/repaint/slider-thumb-float-expected.txt:
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/audio-repaint-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-styling-strict-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-controls-clone-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-playing-and-pause-expected.txt:
* platform/chromium-win/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake RenderTable columns() and columnPositions() return a const reference
jchaffraix@webkit.org [Mon, 15 Oct 2012 21:52:22 +0000 (21:52 +0000)]
Make RenderTable columns() and columnPositions() return a const reference
https://bugs.webkit.org/show_bug.cgi?id=99339

Reviewed by Abhishek Arya.

The 2 getters were returning a non-const reference. This means that callers
could have modified the Vector's where only FixedTableLayout and AutoTableLayout
were expected to (for columnPositions(), no one should modify columns()).

Refactoring covered by existing tests.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
Updated those functions to use the new setter.

* rendering/RenderTable.h:
(WebCore::RenderTable::columns):
(WebCore::RenderTable::columnPositions):
Made the 2 functions return a const reference. They are also const now!

(WebCore::RenderTable::setColumnPosition):
Added this setter.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::dirtiedColumns):
Updated to use a const reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: WebCore part of <rdar://problem/12470680> Font’s fast code path doesn...
mitz@apple.com [Mon, 15 Oct 2012 21:50:53 +0000 (21:50 +0000)]
Source/WebCore: WebCore part of <rdar://problem/12470680> Font’s fast code path doesn’t support kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=99113

Reviewed by Tim Horton.

* WebCore.exp.in: Exported wkCTFontTransformGlyphs.
* platform/graphics/Font.cpp:
(WebCore::Font::width): Added a local GlyphBuffer to pass to floatWidthForSimpleText().
(WebCore::Font::codePath): Rather than always use the complex code path when any typesetting
features are enabled, changed to do so only if WidthIterator doesn’t support this Font’s
typesetting features.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Added a local GlyphBuffer to pass to
WidthIterator::advance() when advancing to or from the range of interest. Added a FIXME
about how this is not entirely correct when kerning or ligatures are enabled.
(WebCore::Font::selectionRectForSimpleText): Added a local GlyphBuffer to pass to
WidthIterator::advance() when advancing to or from the range of interest.
(WebCore::Font::offsetForPositionForSimpleText): Updated for the change to
WidthIterator::advanceOneCharacter().
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms): Added. Calls wkCTFontTransformGlyphs() where
available.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Added initializer for the new m_typesettingFeatures
data member.
(OriginalAdvancesForCharacterTreatedAsSpace): Added this data type, used to track spaces and
characters treated as spaces.
(WebCore::applyFontTransforms): Added. Applies shaping and positioning transforms, as
required by the typesetting features, to the glyphs recently added to a GlyphBuffer, while
maintaining the advances of characters that are treated as spaces and the characters
preceding them, if necessary.
(WebCore::WidthIterator::advanceInternal): Added calls to applyFontTransforms() at the end
of each contiguous run of glyphs from the same font. Also added code to maintain a vector
of spaces and characters treated as space.
(WebCore::WidthIterator::advanceOneCharacter): Changed the parameter type from a pointer to
a reference.
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::supportsTypesettingFeatures): Added. Returns whether WidthIterator
instances support the typesetting features of the given font. Returns true if the font is
not a screen font and its typesetting features are kerning, ligatures or both.
(WebCore::WidthIterator::shouldApplyFontTransforms): Added. Returns true if the typesetting
features include kerning or ligatures.
* platform/mac/WebCoreSystemInterface.h: Defined wkCTFontTransformOptions and declared
wkCTFontTransformGlyphs.
* platform/mac/WebCoreSystemInterface.mm: Defined wkCTFontTransformGlyphs.
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advanceSimpleText): Added a local GlyphBuffer to pass to
WidthIterator::advance().
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Ditto.

Source/WebKit/mac: WebKit/mac part of <rdar://problem/12470680> Font’s fast code path doesn’t support kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=99113

Reviewed by Tim Horton.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added wkCTFontTransformGlyphs.

Source/WebKit2: WebKit2 part of <rdar://problem/12470680> Font’s fast code path doesn’t support kerning and ligatures
https://bugs.webkit.org/show_bug.cgi?id=99113

Reviewed by Tim Horton.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added wkCTFontTransformGlyphs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Only reallocate buffers that were allocated before suspending
jpetsovits@rim.com [Mon, 15 Oct 2012 21:42:28 +0000 (21:42 +0000)]
[BlackBerry] Only reallocate buffers that were allocated before suspending
https://bugs.webkit.org/show_bug.cgi?id=99205
RIM PR 99395

Reviewed by Antonio Gomes.

When we call releaseBuffers(), not all of the backingstore
tile buffers might have been allocated yet. Still we try
to release all of them, which causes us to lazy-initialize
the tile buffers so we can release them again.

This is stupid and we should just ignore buffers that
haven't been initialized yet. This patch makes that change.

* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
(WebKit):
* WebKitSupport/BackingStoreTile.h:
(TileBuffer):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build broken by r131348.
mark.lam@apple.com [Mon, 15 Oct 2012 21:40:33 +0000 (21:40 +0000)]
Fix build broken by r131348.
https://bugs.webkit.org/show_bug.cgi?id=97533.

Not reviewed.

* rendering/RenderView.cpp:
(WebCore::RenderView::layoutContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WTF::fastDeleteAllValues().
kling@webkit.org [Mon, 15 Oct 2012 21:38:35 +0000 (21:38 +0000)]
Remove WTF::fastDeleteAllValues().
<http://webkit.org/b/99345>

Reviewed by Eric Seidel.

It was only used to fastDelete() a class that was already overriding operator delete
by way of WTF_MAKE_FAST_ALLOCATED anyway.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):

Source/WTF:

* wtf/HashSet.h:
(WTF):
(HashSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html for Mac/Win
crogers@google.com [Mon, 15 Oct 2012 21:36:30 +0000 (21:36 +0000)]
Rebaseline webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html for Mac/Win
https://bugs.webkit.org/show_bug.cgi?id=99368

Unreviewed rebaseline.

* platform/chromium-mac-snowleopard/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* platform/chromium-win-xp/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Mon, 15 Oct 2012 21:34:38 +0000 (21:34 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression r130057: incorrect block pref width for alternating InlineFlow and inline...
leviw@chromium.org [Mon, 15 Oct 2012 21:29:31 +0000 (21:29 +0000)]
Regression r130057: incorrect block pref width for alternating InlineFlow and inline Replaced
https://bugs.webkit.org/show_bug.cgi?id=99194

Reviewed by Eric Seidel.

Source/WebCore:

Correctly breaking lines after inline replaced elements that follow inline flows. Previously, alternating
these two types of elements would cause us to increase our preferred width forever.

Test: fast/block/block-with-inline-replaced-children-in-inline-flows.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

* fast/block/block-with-inline-replaced-children-in-inline-flows-expected.html: Added.
* fast/block/block-with-inline-replaced-children-in-inline-flows.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert rounding change in RenderTable::paintObject
eae@chromium.org [Mon, 15 Oct 2012 21:27:41 +0000 (21:27 +0000)]
Revert rounding change in RenderTable::paintObject
https://bugs.webkit.org/show_bug.cgi?id=99364

Reviewed by Levi Weintraub.

Source/WebCore:

Bug 91410 changed RenderTable::paintObject to round the offset
in order to avoid table-background bleed through. The root cause
for that has since been fixed and the rounding workaround is no
longer needed. This change reverts the code change from bug
91410 while preserving the test added as a part of that change
as it now passes without the workaround.

No new tests, covered by fast/sub-pixel/table-rows-no-gaps-expected.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
Remove unnecessary rounding.

LayoutTests:

Revert pixel expected results to what we had prior to r122769.

* platform/chromium/TestExpectations:
* platform/chromium-linux/css1/basic/inheritance-expected.png:
* platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
* platform/chromium-linux/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shaders] Add CustomFilterProgramType to CustomFilterProgramInfo
michelangelo@webkit.org [Mon, 15 Oct 2012 21:23:53 +0000 (21:23 +0000)]
[CSS Shaders] Add CustomFilterProgramType to CustomFilterProgramInfo
https://bugs.webkit.org/show_bug.cgi?id=96448

Reviewed by Kenneth Rohde Christiansen.

CustomFilterProgramInfo has been refactored to decouple the CustomFilterProgramType from
the CustomFilterProgramMixSetting: m_mixSettings.enabled was redundant in light of the fact
that m_programType encoded the very same information. Dependencies have been updated to reflect
this change.

Current tests already cover this code.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter): The check for mixSettings.enabled has been replaced
by an explicit check for PROGRAM_TYPE_BLENDS_ELEMENT_TEXTURE program type.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperation): Setting the program type explicitly while creating a
new filter program.
* platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::CustomFilterProgram): CustomFilterProgram's constructor has been updated to
reflect the need of setting the program type explicitly.
(WebCore::CustomFilterProgram::programInfo): Updated to create new CustomFilterProgramInfo setting the program
type explicitly.
* platform/graphics/filters/CustomFilterProgram.h:
* platform/graphics/filters/CustomFilterProgramInfo.cpp:
(WebCore::CustomFilterProgramInfo::CustomFilterProgramInfo): Added m_programType and udpated the related getter.
(WebCore::CustomFilterProgramInfo::hash): ditto
(WebCore::CustomFilterProgramInfo::operator==): MixSettings' equality check is being performed only whether
the CustomFilterProgramInfo's program type is PROGRAM_TYPE_BLENDS_ELEMENT_TEXTURE.
* platform/graphics/filters/CustomFilterProgramInfo.h:
(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings): Got rid of the redundant enabled flag.
(WebCore::CustomFilterProgramMixSettings::operator==): ditto
(CustomFilterProgramInfo):
(WebCore::CustomFilterProgramInfo::programType):
* platform/graphics/filters/CustomFilterValidatedProgram.cpp: The right shader validator is now being
created according to the program type.
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader): The reference to MixSettings' enabled flag
has been replaced with a check for the program type.
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader): ditto
* rendering/style/StyleCustomFilterProgram.h:
(WebCore::StyleCustomFilterProgram::create): Updated to be aware of the program type.
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Key paths should support non-ASCII identifiers
jsbell@chromium.org [Mon, 15 Oct 2012 21:22:08 +0000 (21:22 +0000)]
IndexedDB: Key paths should support non-ASCII identifiers
https://bugs.webkit.org/show_bug.cgi?id=98814

Reviewed by Kentaro Hara.

Source/WebCore:

Update the parser for key paths to use the unicode classes from
the IdentifierName production in ECMA-262.

Test: storage/indexeddb/keypath-basics.html

* Modules/indexeddb/IDBKeyPath.cpp:
(WebCore):
(WebCore::IDBKeyPathLexer::lexIdentifier):

LayoutTests:

Test representative characters from various Unicode character classes
as valid (or invalid) identifier lead and trailing characters.

* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/resources/keypath-basics.js:
(testValidKeyPaths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2][Texmap] Set gl context in GraphicsContext3DPrivate
commit-queue@webkit.org [Mon, 15 Oct 2012 21:20:06 +0000 (21:20 +0000)]
[EFL][WK2][Texmap] Set gl context in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=99325

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-15
Reviewed by Kenneth Rohde Christiansen.

Based on a patch from Regina Chung.
This piece of code was lost in the final patch of https://bugs.webkit.org/show_bug.cgi?id=96627.
The gl context is used as key in a hash map and cannot be NULL.

No new tests. Accelerated compositing is not yet enabled in the EFL port.

* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][CAIRO] Use cairo_format_stride_for_width() in ShareableBitmap
commit-queue@webkit.org [Mon, 15 Oct 2012 21:00:46 +0000 (21:00 +0000)]
[WK2][CAIRO] Use cairo_format_stride_for_width() in ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=99332

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-15
Reviewed by Martin Robinson.

Cairo implementation of ShareableBitmap is calling
cairo_image_surface_create_for_data() to create an image surface for
the provided pixel data. However, it was passing "m_size.width() * 4"
for the stride argument instead of calling
cairo_format_stride_for_width().

The Cairo documentation states:
"Note that the stride may be larger than width*bytes_per_pixel to
provide proper alignment for each pixel and row. This alignment is
required to allow high-performance rendering within cairo. The correct
way to obtain a legal stride value is to call
cairo_format_stride_for_width() with the desired format and maximum
image width value, and then use the resulting stride value to allocate
the data and to create the image surface."

This patch calls cairo_format_stride_for_width() is ShareableBitmap
in order to obtain a legal stride value to make sure we provide proper
alignment for each pixel and row, and allow high-performance rendering
within cairo.

* Shared/ShareableBitmap.h:
(ShareableBitmap):
* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit):
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::createSurfaceFromData):
(WebKit::ShareableBitmap::paint):
(WebKit::ShareableBitmap::createCairoSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConsole messages containing long URLs should cut at some reasonable length.
mkwst@chromium.org [Mon, 15 Oct 2012 21:00:26 +0000 (21:00 +0000)]
Console messages containing long URLs should cut at some reasonable length.
https://bugs.webkit.org/show_bug.cgi?id=97980

Reviewed by Pavel Feldman.

Source/WebCore:

This patch lightly modifies the current styling of linkified URLs inside
console messages in order to cut them down to some reasonable size for
viewing. The middle of the URL is snipped out such that the whole
thing fits into 150 characters. This only effects the displayed text;
the link's href isn't changed; the link remains available via the
context menu, accessible via the title attribute, and clicking it still
takes the user directly to the resource in question.

Test: inspector/console/console-trim-long-urls.html

* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyURLAsNode):
    Trim the middle of the URL to bring the whole string down to  down
    to 150 characters, and set the link's title to the full URL.

LayoutTests:

* inspector/console/console-trim-long-urls-expected.txt: Added.
* inspector/console/console-trim-long-urls.html: Added.
* inspector/styles/inject-stylesheet-expected.txt:
* platform/chromium/inspector/styles/inject-stylesheet-expected.txt:
    Updating test expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Cannot set evas engine from command line
commit-queue@webkit.org [Mon, 15 Oct 2012 20:56:11 +0000 (20:56 +0000)]
[EFL][WK2] Cannot set evas engine from command line
https://bugs.webkit.org/show_bug.cgi?id=99286

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-10-15
Reviewed by Kenneth Rohde Christiansen.

If an engine name is passed on the command line, pass it along to evas.

* MiniBrowser/efl/main.c:
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
tony@chromium.org [Mon, 15 Oct 2012 20:54:50 +0000 (20:54 +0000)]
Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
https://bugs.webkit.org/show_bug.cgi?id=99348

Reviewed by Ojan Vafai.

Add computeLogicalHeight to the last 2 RenderBoxes that override the method.
I'm unable to remove RenderMultiColumnSet::updateLogicalHeight and make the method
non-virtual since it sets ComputedColumnHeight.  I'd like to remove this
eventually.

No new tests, this is just a code refactor.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::updateLogicalHeight): Set computedColumnHeight.
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
(WebCore):
* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeLogicalHeight):
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove framework and library linking into WebKit.xcconfig
ddkilzer@apple.com [Mon, 15 Oct 2012 20:51:36 +0000 (20:51 +0000)]
Move framework and library linking into WebKit.xcconfig
<http://webkit.org/b/99284>

Reviewed by Mark Rowe.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Remove frameworks and
libraries from Xcode project file.

Source/WebKit/mac:

* Configurations/WebKit.xcconfig: Move frameworks and libraries
link flags to OTHER_LDFLAGS so that they work for iOS and OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
commit-queue@webkit.org [Mon, 15 Oct 2012 20:36:24 +0000 (20:36 +0000)]
[EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=97173

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-10-15
Reviewed by Gyuyoung Kim.

Source/WebCore:

Remove codes to initialize and shutdown the EFL libraries from
RunLoopEfl.cpp. Initialization and shutdown will be done in the
ewk_main.cpp for ui process and WebProcessMainEfl.cpp for web
process.

No new tests. This patch doesn't change behavior.

* platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):

Source/WebKit2:

Initialize and shutdown the EFL libraries in the ewk_main.cpp for ui
process and WebProcessMainEfl.cpp for web process.

* UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):
* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions]Add support for auto-height regions (without region-breaks)
mihnea@adobe.com [Mon, 15 Oct 2012 20:31:47 +0000 (20:31 +0000)]
[CSSRegions]Add support for auto-height regions (without region-breaks)
https://bugs.webkit.org/show_bug.cgi?id=97533

Reviewed by Julien Chaffraix.

Source/WebCore:

Implement the 2pass layout algorithm for computing the height of regions with auto logical height, without taking region breaks into account.
The algorithm is described in the CSSRegions spec: http://dev.w3.org/csswg/css3-regions/#regions-visual-formatting-steps

When the flow thread contains regions with auto logical height, a 2pass layout algorithm is needed to determine the height of auto logical height regions.
In each step of the layout, the regions are laid out before the flow thread is laid out.

In the first pass of layout (normal layout phase), the content of the flow thread is laid out unconstrained in the regions. The region marked as having auto logical height
displays all the corresponding content from the flow thread (taking min-height and max-height into account), and the height of the content displayed
determines the overridden logical content height. Thus, after the first pass of layout, each auto logical height region will store the logical height
value for the second pass in its overridden logical content height property.

In the second pass of layout (constrained flow threads layout phase), when the content of the flow thread is laid out constrained in the regions, the regions are laid out again and they are using
the overridden logical content height from the first pass to update their logical height. Then, the flow thread content is laid out in the associated region chain,
for which the auto logical height regions have proper logical height.

A future patch will properly take region breaks into account for the first pass of layout.

Tests: fast/regions/autoheight-abspos-region.html
       fast/regions/autoheight-floatright-region.html
       fast/regions/autoheight-horizontal-bt.html
       fast/regions/autoheight-inlineblock-normalflow-region.html
       fast/regions/autoheight-maxheight-region.html
       fast/regions/autoheight-minheight-region.html
       fast/regions/autoheight-normalflow-region.html
       fast/regions/autoheight-vertical-lr.html
       fast/regions/autoheight-vertical-rl.html

* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::resetRegionsOverrideLogicalContentHeight):
For all the auto logical height regions, resets their associated overrideLogicalContentHeight.
Those regions are marked as needing layout (along with their ancestors).
(WebCore::FlowThreadController::markAutoLogicalHeightRegionsForLayout):
Mark all the auto logical height regions and their associated flow thread as needing layout (along with their ancestors).
* rendering/FlowThreadController.h:
* rendering/RenderBox.cpp:
Add helper functions to clear out individual logical content width/height.
(WebCore::RenderBox::clearOverrideLogicalContentHeight):
(WebCore::RenderBox::clearOverrideLogicalContentWidth):
(WebCore::RenderBox::clearOverrideSize):
* rendering/RenderBox.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalHeight):
If the flow thread has an auto logical height region for which we did not yet compute the overrideLogicalContentHeight value,
bail out early since we cannot compute the flow thread logical height.
(WebCore::RenderFlowThread::regionAtBlockOffset):
If the offset is inside an auto logical height region for which we did not compute the overrideLogicalContentHeight, then we consider this region tall enough to accommodate all
the content and we return this region. Otherwise, for an auto logical height region, we use either the overrideLogicalContentHeight (if we are in the first layout phase) or
the logicalHeight if we are in the second layout phase (because the overriderLogicalContentHeight was already transferred into region logical height).
(WebCore::RenderFlowThread::pageLogicalHeightForOffset):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore::RenderFlowThread::resetRegionsOverrideLogicalContentHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
Simulate a region break at the specified offset. It will be extended to properly process the region breaks. At this moment, only one auto height region for a thread
can have its height properly computed.
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::boxIntersectsRegion):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateLogicalHeight):
If the auto logical height region has an overrideLogicalContentHeight and we are in the second pass of layout,
we use the overrideLogicalContentHeight to update the region logical height.
(WebCore::RenderRegion::needsOverrideLogicalContentHeightComputation):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layoutContent):
Added a new function to contain the RenderView block layout and flow threads layout.
(WebCore::RenderView::checkLayoutState):
Helper function keeping the original asserts from RenderView, used in more than one place.
(WebCore::RenderView::layout):
* rendering/RenderView.h:
(WebCore::RenderView::normalLayoutPhase):
(WebCore::RenderView::constrainedFlowThreadsLayoutPhase):

LayoutTests:

Added tests for auto-height regions, with different writing modes, with min/max-height.
The bug referenced in the tests is the master bug for auto-height support, 91097.

* fast/regions/autoheight-abspos-region-expected.html: Added.
* fast/regions/autoheight-abspos-region.html: Added.
* fast/regions/autoheight-floatright-region-expected.html: Added.
* fast/regions/autoheight-floatright-region.html: Added.
* fast/regions/autoheight-horizontal-bt-expected.html: Added.
* fast/regions/autoheight-horizontal-bt.html: Added.
* fast/regions/autoheight-inlineblock-normalflow-region-expected.html: Added.
* fast/regions/autoheight-inlineblock-normalflow-region.html: Added.
* fast/regions/autoheight-maxheight-region-expected.html: Added.
* fast/regions/autoheight-maxheight-region.html: Added.
* fast/regions/autoheight-minheight-region-expected.html: Added.
* fast/regions/autoheight-minheight-region.html: Added.
* fast/regions/autoheight-normalflow-region-expected.html: Added.
* fast/regions/autoheight-normalflow-region.html: Added.
* fast/regions/autoheight-vertical-lr-expected.html: Added.
* fast/regions/autoheight-vertical-lr.html: Added.
* fast/regions/autoheight-vertical-rl-expected.html: Added.
* fast/regions/autoheight-vertical-rl.html: Added.
* fast/regions/webkit-named-flow-first-empty-region-index.html: Fix an element style (though the test was passing before).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131348 268f45cc-cd09-0410-ab3c-d52691b4dbfc