WebKit-https.git
10 years ago2009-10-15 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 15 Oct 2009 23:17:59 +0000 (23:17 +0000)]
2009-10-15  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] marshal stamp files are not cleaned after a distclean
        https://bugs.webkit.org/show_bug.cgi?id=30156

        Add stamp-po to CLEANFILES.

        * GNUmakefile.am:

2009-10-15  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] marshal stamp files are not cleaned after a distclean
        https://bugs.webkit.org/show_bug.cgi?id=30156

        Add the stamp files directly to cleanfiles. Also rearrange the
        variable declarations so we don't miss any files that need to be
        cleaned up during the clean targets.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <http://webkit.org/b/30411>.
bweinstein@apple.com [Thu, 15 Oct 2009 23:00:34 +0000 (23:00 +0000)]
Fixes <http://webkit.org/b/30411>.
REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.

Reviewed by Adam Roben.

Added a check for isChromium() in pdevenv, and pass /useenv if we are not
building Chromium.

* Scripts/pdevenv:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 21:55:36 +0000 (21:55 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skip inspector tests on windows until
        incremental build catches frontend files.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 15 Oct 2009 21:54:49 +0000 (21:54 +0000)]
2009-10-15  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Oliver Hunt.

        [Qt] Build fix for QtWebKit after r49649.

        Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function.

        * bridge/qt/qt_runtime.h:
        (JSC::Bindings::QtRuntimeMethod::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 21:53:16 +0000 (21:53 +0000)]
2009-10-15  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Darin Adler.

        Fix media layout test file ordering so both branded and unbranded builds of Chromium will pass layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=30369

        * media/media-file.js: Fixed file ordering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 15 Oct 2009 21:37:54 +0000 (21:37 +0000)]
Reviewed by Kevin Ollivier.

Update the wxPython simple.py sample to match current wxWebKit API.

https://bugs.webkit.org/show_bug.cgi?id=30406

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 21:31:06 +0000 (21:31 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Prevent subsequent tests from failing upon inspector
        test timeout.

        https://bugs.webkit.org/show_bug.cgi?id=30404

        * inspector/evaluate-in-frontend.js:
        (onload.setTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 15 Oct 2009 21:27:02 +0000 (21:27 +0000)]
Reviewed by Kevin Ollivier.

Add Mac package building scripts for wx.

https://bugs.webkit.org/show_bug.cgi?id=30405

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 15 Oct 2009 21:11:53 +0000 (21:11 +0000)]
2009-10-15  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/7306052> Fullscreen max/min volume buttons non-functional

        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Set volume buttons target and action.
        (-[WebVideoFullscreenHUDWindowController decrementVolume:]): New, decrement the volume by 10%.
        (-[WebVideoFullscreenHUDWindowController incrementVolume:]): New, increment the volume by 10%.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Thu, 15 Oct 2009 21:01:54 +0000 (21:01 +0000)]
2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk][Layout tests] Generate results for dom tests
        https://bugs.webkit.org/show_bug.cgi?id=29893

        Add results for dom tests and enable these tests in the Skipped.

        * platform/gtk/Skipped:
        * platform/gtk/dom/xhtml/level3/core/canonicalform08-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.txt.
        * platform/gtk/dom/xhtml/level3/core/canonicalform09-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform09-expected.txt.
        * platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt: Added.
        * platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 15 Oct 2009 20:39:43 +0000 (20:39 +0000)]
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=24731
        And
        rdar://problem/5015961

        Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
        in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
        correctly set.

        The WebView and WebDropSource drag-and-drop functions, as called by function
        DoDragDrop in its event loop, neither used the drop effect as specified by
        event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
        Instead, these functions defaulted to some hardcoded drop effect and set of
        allowed drop effects, respectively.

        Tests: fast/events/drag-and-drop.html

        * WebCoreSupport/WebDragClient.cpp:
        (WebDragClient::startDrag):
        * WebDropSource.cpp:
        (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt
        into method WebDragClient::startDrag.
        * WebDropSource.h:
        * WebView.cpp:
        (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines
        appropriate drop effect from state of keyboard and allowed effects
        m_page->dragController()->sourceDragOperation().
        (WebView::DragEnter):
        (WebView::DragOver):
        (WebView::Drop):
        * WebView.h:
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=24731
        And
        rdar://problem/5015961

        Tests that DHTML drag-and-drop works correctly.

        Note, this test fails when effectAllowed == "uninitialized" because
        this effect has not been implemented yet (see bug #30291).

        * fast/events/drag-and-drop-expected.txt: Added.
        * fast/events/drag-and-drop.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 20:34:02 +0000 (20:34 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed - build fix.

        Web Inspector: add file missing in r49648

        * inspector/front-end/TestController.js: Added.
        (WebInspector.TestController):
        (WebInspector.TestController.prototype.waitUntilDone):
        (WebInspector.TestController.prototype.notifyDone):
        (WebInspector.evaluateForTestInFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake typeinfo flags default to false
oliver@apple.com [Thu, 15 Oct 2009 19:55:09 +0000 (19:55 +0000)]
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Reviewed by Darin Adler

Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 19:51:46 +0000 (19:51 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: introduce test controller with waitUntilDone
        on frontend side.

        https://bugs.webkit.org/show_bug.cgi?id=30400

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/TestController.js: Added.
        (WebInspector.TestController):
        (WebInspector.TestController.prototype.waitUntilDone):
        (WebInspector.TestController.prototype.notifyDone):
        (WebInspector.evaluateForTestInFrontend):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 19:28:31 +0000 (19:28 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Protect WebSocket calls in case the feature is not compiled in.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Thu, 15 Oct 2009 19:28:06 +0000 (19:28 +0000)]
2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Rebaseline tests after changes made in r49405.

        * platform/gtk/editing/execCommand/4916541-expected.txt: Rebaseline.
        * platform/gtk/editing/execCommand/5138441-expected.txt: Ditto.
        * platform/gtk/editing/execCommand/5481523-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 19:11:31 +0000 (19:11 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Remove obsolete test from Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 15 Oct 2009 19:04:57 +0000 (19:04 +0000)]
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27895

        Fixes an issue in which injecting an inline event handler whose value ends in a single-line
        JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to
        the HTML Base element, HTML Object element, inline and external script tags, and
        JavaScript multi-line variants of all of these attacks.

        Tests: http/tests/security/xssAuditor/base-href-comment.html
               http/tests/security/xssAuditor/iframe-javascript-url-comment.html
               http/tests/security/xssAuditor/img-onerror-HTML-comment.html
               http/tests/security/xssAuditor/img-onerror-comment.html
               http/tests/security/xssAuditor/object-tag-comment.html
               http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html
               http/tests/security/xssAuditor/script-tag-comment.html
               http/tests/security/xssAuditor/script-tag-with-source-comment.html

        * page/XSSAuditor.cpp: Added constant minAttackLength.
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
        (WebCore::XSSAuditor::canCreateInlineEventListener):
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        (WebCore::XSSAuditor::canLoadObject):
        (WebCore::XSSAuditor::canSetBaseElementURL):
        (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up
        to minAttackLength of script code plus context (if any).
        * page/XSSAuditor.h:
2009-10-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27895

        Tests that inline event handlers whose value ends in a single-line JavaScript
        comment cannot bypass the XSSAuditor. Also tests that the XSSAuditor prevents
        similar attack vectors with respect to the HTML Base element, HTML Object
        element, and external JavaScripts.

        * http/tests/security/xssAuditor/base-href-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/base-href-comment.html: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Added.
        * http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Added.
        * http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/img-onerror-comment.html: Added.
        * http/tests/security/xssAuditor/object-tag-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/object-tag-comment.html: Added.
        * http/tests/security/xssAuditor/resources/echo-before-image.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Added.
        * http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Added.
        * http/tests/security/xssAuditor/script-tag-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-comment.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-comment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/gtk
kov@webkit.org [Thu, 15 Oct 2009 18:42:11 +0000 (18:42 +0000)]
WebKit/gtk

2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Add a settings to enable support for experimental Web Sockets.
        Currently this comes in handy in layout tests.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

WebKitTools

2009-10-15  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Enable Web Sockets support when running layout tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not...
tonikitoo@webkit.org [Thu, 15 Oct 2009 18:21:08 +0000 (18:21 +0000)]
[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not QWidget*).

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Rubberstamped by Tor Arne.

* QGVLauncher/main.cpp:
(WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-08 Adam Langley <agl@google.com>
agl@chromium.org [Thu, 15 Oct 2009 18:16:38 +0000 (18:16 +0000)]
2009-10-08  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Currently, Skia clip paths are 1-bit. This patch makes our path
        clipping anti-aliased for non-canvas drawing.

        http://code.google.com/p/chromium/issues/detail?id=5927
        https://bugs.webkit.org/show_bug.cgi?id=28820
        http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html

        Already covered by layout tests. New baselines will be needed in the
        Chromium tree.

        (Reland. First landed in r49329, reverted in r49330 due to Windows
        build break)

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::clip):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::canvasClip):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::clipPathAntiAliased):
        (PlatformContextSkia::restore):
        (PlatformContextSkia::applyAntiAliasedClipPaths):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::canvasClip):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::canvasClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Adele Peterson.
bweinstein@apple.com [Thu, 15 Oct 2009 17:55:10 +0000 (17:55 +0000)]
Rubber-stamped by Adele Peterson.

Add click-focus-anchor expected results on Windows, to make up for
the wonky way Windows finds its expected results.

* platform/win/fast/events/click-focus-anchor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 15 Oct 2009 17:53:02 +0000 (17:53 +0000)]
2009-10-15  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Help text fix - Web Sockets default is no, not yes.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 17:42:15 +0000 (17:42 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Need to initialize event.button.button, since in most cases a
        button number is not passed as an argument.

        * DumpRenderTree/gtk/EventSender.cpp:
        (mouseDownCallback):
        (mouseUpCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Thu, 15 Oct 2009 17:33:17 +0000 (17:33 +0000)]
2009-10-15  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Adam Treat.

        [Qt] Add expected files for passing http tests.

        * platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
        * platform/qt/http/tests/uri/css-href-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 15 Oct 2009 17:32:02 +0000 (17:32 +0000)]
2009-10-15  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode

        * WebCore.Video.exp: Export muted and setMute.

2009-10-15  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode

        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController setVolume:]): Unmute movie before changing volume.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Thu, 15 Oct 2009 17:26:10 +0000 (17:26 +0000)]
2009-10-15  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Adam Treat.

        [Qt] Add expected files for passing svg tests.

        * platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
        * platform/qt/svg/custom/mask-with-default-value-expected.txt: Added.
        * platform/qt/svg/filters/feComposite-expected.txt: Added.
        * platform/qt/svg/filters/feGaussianBlur-expected.txt: Added.
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt: Added.
        * platform/qt/svg/filters/sourceAlpha-expected.txt: Added.
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QGLauncher crashes while closing a window
tonikitoo@webkit.org [Thu, 15 Oct 2009 17:14:13 +0000 (17:14 +0000)]
[Qt] QGLauncher crashes while closing a window
https://bugs.webkit.org/show_bug.cgi?id=30385

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Reviewed by Tor Arne.

Set page's pageClient reference to '0' at QGWV deletion.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::~QGraphicsWebView):
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(WebPage::WebPage):
(WebPage::aborting):
(tst_QGraphicsWebView::crashOnViewlessWebPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 15 Oct 2009 16:52:51 +0000 (16:52 +0000)]
2009-10-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Transitions fail to run sometimes
        https://bugs.webkit.org/show_bug.cgi?id=26770

        Fix an issue where we could attempt to start accelerated animations or transitions on
        GraphicsLayer that were not rooted (because of visibility:hidden), which would leave
        the AnimationController's m_waitingForResponse flag in a state that killed subsequent
        software transitions.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::endAnimationUpdate):
        (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
        (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        * page/animation/AnimationControllerPrivate.h:
        Make some methods non-inline for ease of debugging (these are not hot methods).
        Rename m_waitingForAResponse to m_waitingForResponse.

        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::hasAncestor):
        New method to report whether the receiver has the given layer as an ancestor. Used for checking
        whether a layer is rooted.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::startAnimation):
        (WebCore::RenderLayerBacking::startTransition):
        Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 16:50:23 +0000 (16:50 +0000)]
2009-10-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Refactor ProfilesPanel to support multiple profile types

        Data describing different profile types are now stored in distinct objects.
        https://bugs.webkit.org/show_bug.cgi?id=30332

        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView.profileCallback):
        (WebInspector.CPUProfileView):
        (WebInspector.CPUProfileView.prototype._sortData):
        (WebInspector.CPUProfileType):
        (WebInspector.CPUProfileType.prototype.get buttonTooltip):
        (WebInspector.CPUProfileType.prototype.get buttonStyle):
        (WebInspector.CPUProfileType.prototype.buttonClicked):
        (WebInspector.CPUProfileType.prototype.setRecordingProfile):
        (WebInspector.CPUProfile):
        (WebInspector.CPUProfile.prototype.get title):
        (WebInspector.CPUProfile.prototype.get uid):
        (WebInspector.CPUProfile.prototype.get head):
        (WebInspector.CPUProfile.prototype.createView):
        (WebInspector.CPUProfile.prototype.viewForProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfileType):
        (WebInspector.ProfileType.prototype.get buttonTooltip):
        (WebInspector.ProfileType.prototype.get buttonStyle):
        (WebInspector.ProfileType.prototype.get buttonCaption):
        (WebInspector.ProfileType.prototype.get id):
        (WebInspector.ProfileType.prototype.get name):
        (WebInspector.ProfileType.prototype.buttonClicked):
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler):
        (WebInspector.ProfilesPanel.prototype.get statusBarItems):
        (WebInspector.ProfilesPanel.prototype.reset):
        (WebInspector.ProfilesPanel.prototype.registerProfileType):
        (WebInspector.ProfilesPanel.prototype._makeKey):
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.showProfile):
        (WebInspector.ProfilesPanel.prototype.getProfileType):
        (WebInspector.ProfilesPanel.prototype.showProfileForURL):
        (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons):
        (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
        (WebInspector.ProfilesPanel.prototype.get searchableViews):
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector.addProfileHeader):
        (WebInspector.setRecordingProfile):
        (WebInspector.linkifyStringAsFragment):
        (WebInspector.showProfileForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 16:46:46 +0000 (16:46 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: remove timer-related logs from the previously
        submitted test.

        * inspector/console-tests-expected.txt:
        * inspector/console-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
kevino@webkit.org [Thu, 15 Oct 2009 16:21:15 +0000 (16:21 +0000)]
wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
the OS if none was explicitly set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 16:16:22 +0000 (16:16 +0000)]
2009-10-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Enable inspector layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=30014

WebCore:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::evaluateForTestInFrontend):

LayoutTests:
        * inspector/elements-panel-structure-expected.txt:
        * inspector/elements-panel-structure.html:
        * inspector/evaluate-in-frontend.js:
        (evaluateInWebInspector):
        (window.didEvaluateForTestInFrontend):
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 15:31:06 +0000 (15:31 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Skip new SVG tests without expected results for GTK+.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 15 Oct 2009 14:56:19 +0000 (14:56 +0000)]
2009-10-15  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        page transition may crash webkit
        https://bugs.webkit.org/show_bug.cgi?id=29890

        There are actually cases in which a resource may be asked using
        webkit_web_view_get_resource after a new load has already been
        started, so protect ourselves from crashes in this case.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_resource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 15 Oct 2009 14:46:46 +0000 (14:46 +0000)]
2009-10-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GStreamer] READY state doesn't mean "enough data"
        https://bugs.webkit.org/show_bug.cgi?id=30003

        STATE_READY means MediaPlayer::HaveNothing

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 14:35:52 +0000 (14:35 +0000)]
2009-10-15  Xan Lopez  <xlopez@igalia.com>

        Skip a couple of tests that need support for dumpEditingCallbacks.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 15 Oct 2009 14:31:52 +0000 (14:31 +0000)]
2009-10-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=30002

        implement cancelLoad

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::cancelLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk>
eric@webkit.org [Thu, 15 Oct 2009 14:16:24 +0000 (14:16 +0000)]
2009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=30353

        Fix race condition, leading to a deadlock

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_timeout_func):
        (webkit_video_sink_render):
        (unlock_buffer_mutex):
        (webkit_video_sink_unlock):
        (webkit_video_sink_unlock_stop):
        (webkit_video_sink_stop):
        (webkit_video_sink_start):
        (webkit_video_sink_class_init):
        Fix race condition in unlock/render that would lead to deadlocks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk>
eric@webkit.org [Thu, 15 Oct 2009 13:25:34 +0000 (13:25 +0000)]
2009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=30374

        Check if caps are valid before parsing them

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::duration):
        Check if caps are valid before parsing them in ::naturalSize().
        This prevents assertions if the natural size should be calculated
        before the video caps are negotiated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 15 Oct 2009 13:09:58 +0000 (13:09 +0000)]
2009-10-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=30006
        [GStreamer] Unnecessary checks for Messages types in callbacks

        refactored gst message callbacks into a single one

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::do_gst_init):
        (WebCore::MediaPlayerPrivate::duration):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt build on Mac OS X
vestbo@webkit.org [Thu, 15 Oct 2009 12:58:45 +0000 (12:58 +0000)]
Fix the Qt build on Mac OS X

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Thu, 15 Oct 2009 12:49:25 +0000 (12:49 +0000)]
2009-10-15  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Adele Peterson.

        Change behavior so that <a> element is always mouse-focusable.

        * fast/events/click-focus-anchor-expected.txt:
        * fast/events/click-focus-anchor.html:
2009-10-15  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Adele Peterson.

        Anchor elements should be mouse focusable regardless isLink flag.
        https://bugs.webkit.org/show_bug.cgi?id=26856

        * html/HTMLAnchorElement.cpp:
        * html/HTMLAnchorElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make context menu to work in QGraphicsWebView
tonikitoo@webkit.org [Thu, 15 Oct 2009 12:41:30 +0000 (12:41 +0000)]
[Qt] Make context menu to work in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30336

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Sort XCode project file.
zimmermann@webkit.org [Thu, 15 Oct 2009 12:32:14 +0000 (12:32 +0000)]
Not reviewed. Sort XCode project file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Yury Semikhatsky <yurys@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 09:40:59 +0000 (09:40 +0000)]
2009-10-15  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Dave Hyatt.

        Return correct shorthand property name for
        background-repeat-x, background-repeat-y, background-position-x,
        background-position-y, -webkit-mask-position-x, -webkit-mask-position-y,
        -webkit-mask-repeat-x, -webkit-mask-repeat-y.

        https://bugs.webkit.org/show_bug.cgi?id=28972

        Test: fast/backgrounds/repeat/background-repeat-shorthand.html
WebCore

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):

LayoutTests:
        * fast/backgrounds/repeat/background-repeat-shorthand-expected.txt: Added.
        * fast/backgrounds/repeat/background-repeat-shorthand.html: Added.
        * fast/backgrounds/repeat/resources/background-repeat-shorthand.css: Added.
        * fast/backgrounds/repeat/resources/background-repeat-shorthand.js: Added.
        (getShorthand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 09:31:11 +0000 (09:31 +0000)]
2009-10-14  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Migrate profiles to the injected script-based schema.

        https://bugs.webkit.org/show_bug.cgi?id=30328

        * bindings/js/JSInspectorBackendCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getProfileHeaders):
        (WebCore::InspectorController::getProfile):
        (WebCore::InspectorController::createProfileHeader):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::ProfileNodeClass):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.profileCallback):
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
        (WebInspector.ProfileView.prototype._assignParentsInProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        * inspector/front-end/inspector.js:
        (WebInspector.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 09:15:39 +0000 (09:15 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Create and update frontend script objects only when
        web inspector is visible.

        https://bugs.webkit.org/show_bug.cgi?id=30376

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::pruneResources):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::mainResourceFiredDOMContentEvent):
        (WebCore::InspectorController::mainResourceFiredLoadEvent):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        (WebCore::InspectorController::didOpenDatabase):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::evaluateForTestInFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 15 Oct 2009 08:56:18 +0000 (08:56 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: enable developers extras within inspector layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 José Millán Soto <jmillan@igalia.com>
xan@webkit.org [Thu, 15 Oct 2009 07:35:33 +0000 (07:35 +0000)]
2009-10-14  José Millán Soto  <jmillan@igalia.com>

        Reviewed by Jan Alonzo.

        GtkLauncher is using a deprecated signal
        https://bugs.webkit.org/show_bug.cgi?id=30364

        Modified GtkLauncher to use notify::title signal instead of
        deprecated title-changed signal

        * GtkLauncher/main.c:
        (notify_title_cb):
        (create_browser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-15 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 15 Oct 2009 07:10:51 +0000 (07:10 +0000)]
2009-10-15  Joseph Pecoraro  <joepeck@webkit.org>

        Fix Windows build.

        * dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 15 Oct 2009 06:41:42 +0000 (06:41 +0000)]
2009-10-14  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Adam Barth.

        [HTML5] Add document.head
        https://bugs.webkit.org/show_bug.cgi?id=30232

        Test is fast/dom/document-head.html

        * dom/Document.idl: added readonly attribute head

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Matt Mueller <mattm@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 06:12:39 +0000 (06:12 +0000)]
2009-10-14  Matt Mueller  <mattm@chromium.org>

        Reviewed by Darin Adler.

        Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit.  See http://crbug.com/20939.
        https://bugs.webkit.org/show_bug.cgi?id=30347
        https://bugs.webkit.org/show_bug.cgi?id=22772

        Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::validUnit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 15 Oct 2009 05:15:54 +0000 (05:15 +0000)]
2009-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Move scrolling code from FrameLoader to FrameView
        https://bugs.webkit.org/show_bug.cgi?id=30370

        This code is about controlling the Frame's view, not about loading
        stuff into the frame.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedParsing):
        (WebCore::FrameLoader::scrollToAnchor):
        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToFragment):
        (WebCore::FrameView::scrollToAnchor):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake typeinfo flags default to false
oliver@apple.com [Thu, 15 Oct 2009 03:24:17 +0000 (03:24 +0000)]
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Reviewed by Geoff Garen.

Part 1. Reverse the HasStandardGetOwnPropertySlot flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 02:39:34 +0000 (02:39 +0000)]
2009-10-14  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        Document what state the build tree is expected to be in after a patch.

        * coding/contributing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 15 Oct 2009 02:14:25 +0000 (02:14 +0000)]
2009-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        [XSSAuditor] Add an exception for local files
        https://bugs.webkit.org/show_bug.cgi?id=30352

        Test that we allow sites to load scripts from their own domain as long
        as they don't use query strings.

        * http/tests/security/xssAuditor/script-tag-with-source-same-host-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-same-host.html: Added.
2009-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        [XSSAuditor] Add an exception for local files
        https://bugs.webkit.org/show_bug.cgi?id=30352

        Reduce XSS auditor false positives by always letting pages load scripts
        from their own host. We don't actually know of any false positives
        that this prevents, but it seems like a good idea.

        One subtly is that we don't add this exception for scripts that have a
        query string because (1) URLs with query strings are more apt to
        confuse servers and (2) it is much less common to load scripts with a
        query string.

        Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
               http/tests/security/xssAuditor/script-tag-with-source-same-host.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unbreak the world.
kdecker@apple.com [Thu, 15 Oct 2009 00:33:32 +0000 (00:33 +0000)]
    Unbreak the world.

        * Plugins/WebBaseNetscapePluginView.mm:
        (WebHaltablePlugin::restart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson and Jon Honeycutt
kdecker@apple.com [Thu, 15 Oct 2009 00:14:08 +0000 (00:14 +0000)]
    Reviewed by Anders Carlsson and Jon Honeycutt

        <rdar://problem/7304295> snapshots of halted plug-ins are missing

        * Plugins/WebBaseNetscapePluginView.mm: Move bodies of WebHaltablePlugin virtual functions from WebHaltablePlugin class definition.
        (WebHaltablePlugin::halt): Provide a substitute image to the RenderWidget for the plug-in view.
        (WebHaltablePlugin::restart): Clear the substitute image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 14 Oct 2009 23:54:23 +0000 (23:54 +0000)]
2009-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by George Staikos.

        Kill virtual contextElement() method spread all over SVG code
        https://bugs.webkit.org/show_bug.cgi?id=30183

        Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
        SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
        subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.

        Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
        and remove vim modelines on all files I touched. No change in functionality, thus no new tests.

        * svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
        * svg/SVGAnimatedProperty.h:
        (WebCore::::synchronize):
        (WebCore::::startAnimation):
        (WebCore::::stopAnimation):
        * svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGCircleElement.h: Ditto.
        * svg/SVGClipPathElement.h: Ditto.
        * svg/SVGCursorElement.h: Ditto.
        * svg/SVGDefsElement.h: Ditto.
        * svg/SVGEllipseElement.h: Ditto.
        * svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
        * svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGFELightElement.h: Remove virtual contextElement() method.
        * svg/SVGFEMergeNodeElement.h: Ditto.
        * svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element.
        (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
        * svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
        * svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGForeignObjectElement.h: Ditto.
        * svg/SVGGElement.h: Ditto.
        * svg/SVGGradientElement.h: Ditto.
        * svg/SVGImageElement.h: Ditto.
        * svg/SVGLineElement.h: Ditto.
        * svg/SVGMPathElement.h: Ditto. Fix license indention.
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGMaskElement.h: Ditto.
        * svg/SVGPathElement.h: Ditto.
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
        * svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGRectElement.h: Ditto.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGScriptElement.h: Ditto.
        * svg/SVGSwitchElement.h: Ditto.
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGTRefElement.h: Remove virtual contextElement() method.
        * svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGTextPathElement.h: Remove virtual contextElement() method.
        * svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        (WebCore::SVGViewSpec::parseViewSpec): Ditto.
        * svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a failure seen on buildbot after landing the fix for
darin@apple.com [Wed, 14 Oct 2009 23:48:56 +0000 (23:48 +0000)]
Fix a failure seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994

Patch by Darin Adler <darin@apple.com> on 2009-10-14
* platform/win/fast/css/large-number-round-trip-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 14 Oct 2009 23:21:46 +0000 (23:21 +0000)]
2009-10-14  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Masking with wrong offset
        [https://bugs.webkit.org/show_bug.cgi?id=30325]

        SVGMaskElement moves the mask image graphics context to the wrong location.
        In objectBoundingBoxMode the maskDestRect gets translated. This transformation
        is not used in the later calculation. Fix by consistenly calculating the translation
        offsets from the final mask destination rect.

        Test: svg/custom/mask-with-default-value.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

2009-10-14  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Masking with wrong offset
        [https://bugs.webkit.org/show_bug.cgi?id=30325]

        SVGMaskElement moves the mask image graphics context to the wrong location.
        In objectBoundingBoxMode the maskDestRect gets translated. This transformation
        is not used in the later calculation. Fix by consistenly calculating the translation
        offsets from the final mask destination rect.

        Test: svg/custom/mask-with-default-value.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubberstamped by Jon Honeycutt.
kdecker@apple.com [Wed, 14 Oct 2009 23:14:45 +0000 (23:14 +0000)]
    Rubberstamped by Jon Honeycutt.

        Export a few more showSubstituteImage() related methods.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix failures seen on buildbot after landing the fix for
darin@apple.com [Wed, 14 Oct 2009 23:11:43 +0000 (23:11 +0000)]
Fix failures seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994

Patch by Darin Adler <darin@apple.com> on 2009-10-14
Reviewed by Mark Rowe.

Somehow I had the mac/fast/css/opacity-float-expected.txt
removed locally, and Subversion didn't check that in!

* platform/mac/fast/css/opacity-float-expected.txt: Removed.
* platform/win/fast/css/opacity-float-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable plugins/private-browsing-mode.html on Snow Leopard.
andersca@apple.com [Wed, 14 Oct 2009 23:00:04 +0000 (23:00 +0000)]
Disable plugins/private-browsing-mode.html on Snow Leopard.

Reviewed by Sam Weinig.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30269
jparent@chromium.org [Wed, 14 Oct 2009 22:38:47 +0000 (22:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30269
Use onload to detect iframe load, rather than setTimeout.
This will give more consistent test results and hopefully faster run times.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-13
Reviewed by Darin Adler.

* editing/execCommand/paste-1.html:
* editing/execCommand/paste-2.html:
* editing/pasteboard/subframe-dragndrop-1.html:
* editing/selection/4776665.html:
* editing/selection/4975120.html:
* editing/selection/5136696.html:
* editing/selection/drag-to-contenteditable-iframe.html:
* platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
* platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
* platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
darin@apple.com [Wed, 14 Oct 2009 21:45:27 +0000 (21:45 +0000)]
JavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.

Patch by Darin Adler <darin@apple.com> on 2009-10-14
* wtf/MathExtras.h: Added llround and llroundf for Windows.

WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.

Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=18994

* css/CSSPrimitiveValue.cpp:
(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):

LayoutTests: Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly

Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=18994

* fast/css/large-number-round-trip-expected.txt:
* fast/css/opacity-float-expected.txt:
* fast/css/opacity-float.html:
* platform/mac/fast/css/opacity-float-expected.txt: Removed.
* transforms/2d/compound-2d-transforms-expected.txt:
* transforms/2d/compound-2d-transforms.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Mark Seaborn <mseaborn@google.com>
eric@webkit.org [Wed, 14 Oct 2009 21:41:01 +0000 (21:41 +0000)]
2009-10-14  Mark Seaborn  <mseaborn@google.com>

        Reviewed by Darin Adler.

        Check error return value in Perl build script
        https://bugs.webkit.org/show_bug.cgi?id=30316

        * css/makevalues.pl: Die if gperf fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r49580 as it is completely wrong and breaks the Mac builds.
mrowe@apple.com [Wed, 14 Oct 2009 20:39:23 +0000 (20:39 +0000)]
Roll out r49580 as it is completely wrong and breaks the Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 14 Oct 2009 20:30:35 +0000 (20:30 +0000)]
2009-10-14  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG wrong filterRegions for userSpaceOnUse and percentage values
        [https://bugs.webkit.org/show_bug.cgi?id=30330]

        Some clean-up of the SVG filter calculation code. This clean-up
        also fixes the problem with percentage and userSpaceInUse mode.

        Test: svg/filters/subRegion-in-userSpace.svg

        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::FilterEffect):
        * platform/graphics/filters/FilterEffect.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::buildFilter):
        (WebCore::SVGFilterElement::canvasResource):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::SVGResourceFilter):
        (WebCore::SVGResourceFilter::~SVGResourceFilter):
        (WebCore::SVGResourceFilter::addFilterEffect):
        (WebCore::SVGResourceFilter::prepareFilter):
        * svg/graphics/SVGResourceFilter.h:
        (WebCore::SVGResourceFilter::create):
        * svg/graphics/filters/SVGFilter.cpp:
        (WebCore::SVGFilter::SVGFilter):
        (WebCore::SVGFilter::calculateEffectSubRegion):
        (WebCore::SVGFilter::create):
        * svg/graphics/filters/SVGFilter.h:

        Reviewed by Nikolas Zimmermann.

        Check if the percentage of effect values takes user space as reference and
        not the FilterRect.

        * platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.png: Added.
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt: Added.
        * svg/filters/subRegion-in-userSpace.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools: Don't set the history delegate on new windows that are opened during...
beidson@apple.com [Wed, 14 Oct 2009 19:32:37 +0000 (19:32 +0000)]
WebKitTools: Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1 - Disables WebHistory
2 - Doesn't make sense in that context anyway.

Reviewed by Sam Weinig.

* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):

LayoutTests: Un-skip a test that now passes.

Reviewed by Sam Weinig.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
kevino@webkit.org [Wed, 14 Oct 2009 19:01:34 +0000 (19:01 +0000)]
Mac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
compilation of code that requires 10.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
kevino@webkit.org [Wed, 14 Oct 2009 18:51:05 +0000 (18:51 +0000)]
wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago The last change fixed the problem, removing diagnostic printfs.
cmarrin@apple.com [Wed, 14 Oct 2009 18:41:34 +0000 (18:41 +0000)]
    The last change fixed the problem, removing diagnostic printfs.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCURL build fix for versions < 7.18.
kevino@webkit.org [Wed, 14 Oct 2009 18:31:39 +0000 (18:31 +0000)]
CURL build fix for versions < 7.18.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 14 Oct 2009 18:30:37 +0000 (18:30 +0000)]
2009-10-14  Nate Chapin  <japhet@chromium.org>

        Unreviewed, build fix.

        When I landed r49569 for Victor, I failed to svn add one of the required files.

        This should fix the redness on the Windows test bots.

        * platform/win/editing/pasteboard/paste-xml-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago One more round of changes to figure out why the webgl
cmarrin@apple.com [Wed, 14 Oct 2009 18:18:21 +0000 (18:18 +0000)]
    One more round of changes to figure out why the webgl
        tests are crashing on the build bot. Here I am trying
        to see if we can create a software renderer. I am also
        printing the found pixel formats.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnabling NPAPI plugin support on Qt Webkit for S60 platform
yael.aharon@nokia.com [Wed, 14 Oct 2009 17:42:12 +0000 (17:42 +0000)]
Enabling NPAPI plugin support on Qt Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-14
Reviewed by

Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>,
Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr
<norbert.leser@nokia.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 17:34:55 +0000 (17:34 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: skip inspector tests that were recently added
        until harness is fixed in release mode.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip my two new failures while I'm actively looking at them.
beidson@apple.com [Wed, 14 Oct 2009 17:29:49 +0000 (17:29 +0000)]
Skip my two new failures while I'm actively looking at them.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago More changes to figure out why the webgl tests are crashing on the build...
cmarrin@apple.com [Wed, 14 Oct 2009 17:18:14 +0000 (17:18 +0000)]
    More changes to figure out why the webgl tests are crashing on the build bot.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still...
kevino@webkit.org [Wed, 14 Oct 2009 17:11:34 +0000 (17:11 +0000)]
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Wed, 14 Oct 2009 17:02:13 +0000 (17:02 +0000)]
2009-10-14  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Adler.

        Add paste-xml test back for Win.
        The result difference between Mac and Win is due to the
        platform dependent implementation. The diff is expected
        with current implementation.
        See bug for more deails:

        https://bugs.webkit.org/show_bug.cgi?id=30267

        * platform/win/Skipped:
        * platform/win/editing/pasteboard/paste-xml-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 16:39:23 +0000 (16:39 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add initial layout tests for web inspector.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * inspector/console-tests-expected.txt: Added.
        * inspector/console-tests.html: Added.
        * inspector/elements-panel-structure-expected.txt: Added.
        * inspector/elements-panel-structure.html: Added.
        * inspector/evaluate-in-frontend-expected.txt: Added.
        * inspector/evaluate-in-frontend.html: Added.
        * inspector/evaluate-in-frontend.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Wed, 14 Oct 2009 16:26:38 +0000 (16:26 +0000)]
2009-10-14  Victor Wang  <victorw@chromium.org>

        Reviewed by David Hyatt.

        Round non-integer line height values.

        Change webkit to rounding non-integer line height values
        instead of truncating them. This fixes a layout test
        failure on Windows and matches the calculation in IE and Firefox.

        https://bugs.webkit.org/show_bug.cgi?id=24434

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
aroben@apple.com [Wed, 14 Oct 2009 16:23:50 +0000 (16:23 +0000)]
Windows build fix

* WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Kelly Norton <knorton@google.com>
pfeldman@chromium.org [Wed, 14 Oct 2009 16:21:06 +0000 (16:21 +0000)]
2009-10-13  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Removes the persistent setting for InspectorTimelineAgent and renames timeline related
        interfaces to be more consistent with the JavaScript profiler.

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::startTimelineProfiler):
        (WebCore::InspectorBackend::stopTimelineProfiler):
        (WebCore::InspectorBackend::timelineProfilerEnabled):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::timelineProfilerEnabled):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::timelineProfilerWasStarted):
        (WebCore::InspectorFrontend::timelineProfilerWasStopped):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/TimelineAgent.js:
        (WebInspector.timelineProfilerWasStarted):
        (WebInspector.timelineProfilerWasStopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit Win API should provide a delegate interface for global history.
beidson@apple.com [Wed, 14 Oct 2009 16:03:31 +0000 (16:03 +0000)]
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905

Reviewed by Sam Weinig.

WebKit/win:

-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.

* Interfaces/IWebHistoryDelegate.idl: Added.
* Interfaces/IWebHistoryPrivate.idl:
* Interfaces/IWebNavigationData.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:

* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):

 * WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
* WebView.h:

* WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
* WebHistory.h:

* WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
* WebNavigationData.h: Added.

WebKitTools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpHistoryDelegateCallbacks):
(LayoutTestController::setDumpHistoryDelegateCallbacks):

* DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogHistoryDelegates):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
* DumpRenderTree/win/DumpRenderTree.vcproj:

Add the IWebHistoryDelegate to DRT Windows:
* DumpRenderTree/win/HistoryDelegate.cpp: Added.
(wstringFromBSTR):
(HistoryDelegate::HistoryDelegate):
(HistoryDelegate::~HistoryDelegate):
(HistoryDelegate::QueryInterface):
(HistoryDelegate::AddRef):
(HistoryDelegate::Release):
(HistoryDelegate::didNavigateWithNavigationData):
(HistoryDelegate::didPerformClientRedirectFromURL):
(HistoryDelegate::didPerformServerRedirectFromURL):
(HistoryDelegate::updateHistoryTitle):
(HistoryDelegate::populateVisitedLinksForWebView):
* DumpRenderTree/win/HistoryDelegate.h: Added.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):

LayoutTests:

* platform/win/Skipped: Enable globalhistory tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Wed, 14 Oct 2009 16:02:11 +0000 (16:02 +0000)]
2009-10-14  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement support for setPOSIXLocale on Qt.
        https://bugs.webkit.org/show_bug.cgi?id=30268

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setPOSIXLocale):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Yong Li <yong.li@torchmobile.com>
yong.li@torchmobile.com [Wed, 14 Oct 2009 15:48:41 +0000 (15:48 +0000)]
2009-10-02  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Adele Peterson.

        Fixed crash when loading invalid image data.
        Also added a test case that loads an invalid image to make sure
        we don't crash in this situation.
        https://bugs.webkit.org/show_bug.cgi?id=29980

WebCore:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::setImageSizeForAltText):

LayoutTests:
        * fast/images/image-invalid-data-expected.txt: Added.
        * fast/images/image-invalid-data.html: Added.
        * fast/images/resources/invalid.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for NULL ptr deref in canvas's toDataURL().
senorblanco@chromium.org [Wed, 14 Oct 2009 15:02:42 +0000 (15:02 +0000)]
WebCore: Fix for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254

Reviewed by Eric Seidel.

Test: fast/canvas/canvas-toDataURL-crash.html

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):

LayoutTests: New test for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254

Reviewed by Eric Seidel.

* fast/canvas/canvas-toDataURL-crash-expected.txt: Added.
* fast/canvas/canvas-toDataURL-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 14:54:18 +0000 (14:54 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed, reverting r49558 since it broke profiler tests.

        https://bugs.webkit.org/show_bug.cgi?id=30328

        * bindings/js/JSInspectorBackendCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getProfileHeaders):
        (WebCore::InspectorController::getProfile):
        (WebCore::InspectorController::createProfileHeader):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::ProfileNodeClass):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.profileCallback):
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
        (WebInspector.ProfileView.prototype._assignParentsInProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        * inspector/front-end/inspector.js:
        (WebInspector.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImageDecoderQt: Minor tweaks to the decoder
zecke@webkit.org [Wed, 14 Oct 2009 14:10:52 +0000 (14:10 +0000)]
ImageDecoderQt: Minor tweaks to the decoder

- Only cache the data when we start to use it.
- Start with a repetition count of none for normal images.
- Do not use canRead as this will trigger parsing of the full image
- Cope with a GIF failing to decode the first frame, do not
  set m_failed to true if decoding the first frame failed
- Inform the QImageReader about the format that was detected
- Always create a ImageDecoderQt when when we have more
  than four byte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 13:32:09 +0000 (13:32 +0000)]
2009-10-14  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Migrate profiles to the injected script-based schema.

        https://bugs.webkit.org/show_bug.cgi?id=30328

        * bindings/js/JSInspectorBackendCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getProfileHeaders):
        (WebCore::InspectorController::getProfile):
        (WebCore::InspectorController::createProfileHeader):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::ProfileNodeClass):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.profileCallback):
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
        (WebInspector.ProfileView.prototype._assignParentsInProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        * inspector/front-end/inspector.js:
        (WebInspector.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Yury Semikhatsky <yurys@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 09:14:29 +0000 (09:14 +0000)]
2009-10-13  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Don't collect call frame properties until they're needed for completion.

        https://bugs.webkit.org/show_bug.cgi?id=30334

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties.
        (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
        * inspector/front-end/ScriptsPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Yongjun Zhang <yongjun.zhang@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 14 Oct 2009 05:14:04 +0000 (05:14 +0000)]
2009-10-13  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=29106
        [Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.

        Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
        compiler aggressively resolve inheritance of class R.

        The winscw compiler bug is reported at:
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

        The change should be reverted when the above bug is fixed in winscw compiler.

        * loader/CachedResourceHandle.h:
        (WebCore::::CachedResourceHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 14 Oct 2009 04:43:16 +0000 (04:43 +0000)]
2009-10-13  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r49554, because it broke Win and Chromium builds.
        http://trac.webkit.org/changeset/49554

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 14 Oct 2009 04:09:02 +0000 (04:09 +0000)]
2009-10-13  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Float formatting changes affect three tests:
        - large-number-round-trip now passes
        - opacity-float now passes and has more test cases
        - compound-2d-transforms output tweaked slightly

        https://bugs.webkit.org/show_bug.cgi?id=18994

        * fast/css/large-number-round-trip-expected.txt:
        * fast/css/opacity-float-expected.txt:
        * fast/css/opacity-float.html:
        * platform/mac/fast/css/opacity-float-expected.txt: Removed.
        * transforms/2d/compound-2d-transforms-expected.txt:
        * transforms/2d/compound-2d-transforms.html:
2009-10-13  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Stringify CSS units manually (without printf) to make the formatting
        locale-insensitive and obey CSS spec with respect to large values.

        https://bugs.webkit.org/show_bug.cgi?id=18994

        * css/CSSPrimitiveValue.cpp:
        (WebCore::appendCSSDouble):
        (WebCore::formatWithUnits):
        (WebCore::CSSPrimitiveValue::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 14 Oct 2009 03:52:04 +0000 (03:52 +0000)]
2009-10-13  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
        While we're rebaselining scrollbars, fix an off by one in the vertical
        scrollbar rendering too.

        https://bugs.webkit.org/show_bug.cgi?id=30319

        Tests: this is covered by every pixel test involving scrollbars.

        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Wed, 14 Oct 2009 03:37:24 +0000 (03:37 +0000)]
2009-10-13  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Holger Freyther.

        [LayoutTests][Gtk] Set a common Gtk theme as default and update the results
        https://bugs.webkit.org/show_bug.cgi?id=30223

        Update test results to reflect the usage of the default theme.

        * platform/gtk/editing/selection/iframe-expected.txt:
        * platform/gtk/editing/selection/select-box-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49552 268f45cc-cd09-0410-ab3c-d52691b4dbfc