aroben [Tue, 26 Jun 2007 00:43:56 +0000 (00:43 +0000)]
Land pdevenv and supporting scripts/programs
pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:
CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.
parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.
MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.
Rubberstamped by Sam.
* CLWrapper/CLWrapper.cpp: Added.
(wmain):
* CLWrapper/CLWrapper.sln: Added.
* CLWrapper/CLWrapper.vcproj: Added.
* MIDLWrapper/MIDLWrapper.cpp: Added.
(wmain):
* MIDLWrapper/MIDLWrapper.sln: Added.
* MIDLWrapper/MIDLWrapper.vcproj: Added.
* Scripts/parallelcl: Added.
* Scripts/pdevenv: Added.
* vcbin/cl.exe: Added.
* vcbin/midl.exe: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 26 Jun 2007 00:30:29 +0000 (00:30 +0000)]
Reviewed by Darin
- WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs
* WebView/WebDocumentInternal.h:
Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
* WebView/WebHTMLViewPrivate.h:
Removed declarations for the methods that are now in WebMultipleTextMatches protocol
* WebView/WebHTMLView.mm:
(-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
moved this method into the WebDocumentInternalProtocols portion of the file
(-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
ditto
(-[WebHTMLView markedTextMatchesAreHighlighted]):
ditto
(-[WebHTMLView unmarkAllTextMatches]):
ditto
(-[WebHTMLView rectsForTextMatches]):
ditto
* WebView/WebView.mm:
(-[WebView canMarkAllTextMatches]):
new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches
(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class
(-[WebView unmarkAllTextMatches]):
ditto
(-[WebView rectsForTextMatches]):
ditto
* WebView/WebViewPrivate.h:
declared new method canMarkAllTextMatches
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 26 Jun 2007 00:07:25 +0000 (00:07 +0000)]
LayoutTests:
Reviewed by Hyatt.
Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297
* fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
* fast/overflow/hidden-scrollbar-resize-expected.png: Added.
* fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
* fast/overflow/hidden-scrollbar-resize.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297
Test: fast/overflow/hidden-scrollbar-resize.html
* rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
Updated our shouldPaint check to consider visibility.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 25 Jun 2007 22:59:19 +0000 (22:59 +0000)]
Reviewed by Darin.
<rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
Fixing logic error in DragController
* manual-tests/drop-text-acquires-style.html: Added.
* page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 25 Jun 2007 21:36:46 +0000 (21:36 +0000)]
Reviewed by Adam Roben.
Annotate prototypes by adding "Prototype" subtitle.
* page/inspector/ResourcePanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 25 Jun 2007 21:29:13 +0000 (21:29 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Mon, 25 Jun 2007 18:20:57 +0000 (18:20 +0000)]
Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 25 Jun 2007 17:48:13 +0000 (17:48 +0000)]
Reviewed by Darin
Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe
* WebView/WebView.mm:
(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of
that test. That's a bad idea.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 25 Jun 2007 16:04:06 +0000 (16:04 +0000)]
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix
* WebCore.pro: Fix gtk/gdk typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 25 Jun 2007 14:51:02 +0000 (14:51 +0000)]
Reviewed by Anders.
Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385
Add a toggle to show implict computed properties.
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.css:
* page/inspector/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 12:57:31 +0000 (12:57 +0000)]
2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark.
http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng
* WebKit.pri: Link against external libjpeg and libpng.
2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark.
http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng
* WebCore.pro: Remove bundled libjpeg and libpng sources.
* platform/image-decoders/jpeg: Remove sources.
* platform/image-decoders/png: Remove sources.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:31:54 +0000 (10:31 +0000)]
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14202
Table caption renders too narrow sometimes
Test: fast/table/caption-relayout.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout): Mark the caption for layout if the table
width changed.
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14202
Table caption renders too narrow sometimes
* fast/table/caption-relayout-expected.checksum: Added.
* fast/table/caption-relayout-expected.png: Added.
* fast/table/caption-relayout-expected.txt: Added.
* fast/table/caption-relayout.html: Added.
* tables/mozilla/marvin/x_caption_class-expected.checksum:
* tables/mozilla/marvin/x_caption_class-expected.png:
* tables/mozilla/marvin/x_caption_class-expected.txt:
* tables/mozilla/marvin/x_caption_id-expected.checksum:
* tables/mozilla/marvin/x_caption_id-expected.png:
* tables/mozilla/marvin/x_caption_id-expected.txt:
* tables/mozilla/marvin/x_caption_style-expected.checksum:
* tables/mozilla/marvin/x_caption_style-expected.png:
* tables/mozilla/marvin/x_caption_style-expected.txt:
* tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
* tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
* tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:29:03 +0000 (10:29 +0000)]
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14245
Underline painted under <br>, not repainted properly
Test: fast/inline/br-text-decoration.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
than their thickness paint correctly.
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=14245
Underline painted under <br>, not repainted properly
* fast/inline/br-text-decoration-expected.checksum: Added.
* fast/inline/br-text-decoration-expected.png: Added.
* fast/inline/br-text-decoration-expected.txt: Added.
* fast/inline/br-text-decoration.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:27:00 +0000 (10:27 +0000)]
2007-06-25 Matt Perry <mpComplete@gmail.com>
Reviewed by Sam Weinig.
Modify test to wait until the second frame loads, and update its expected output to match.
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
* fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:23:33 +0000 (10:23 +0000)]
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=14341
rules="none" ignored in certain cases
Covered by existing tests.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::getSharedCellDecl):
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=14341
rules="none" ignored in certain cases
* tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
* tables/mozilla/marvin/table_rules_none-expected.png: Added.
* tables/mozilla/marvin/table_rules_none-expected.txt: Added.
* tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
* tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
* tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
* tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
* tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
* tables/mozilla_expected_failures/core/table_rules-expected.checksum:
* tables/mozilla_expected_failures/core/table_rules-expected.png:
* tables/mozilla_expected_failures/core/table_rules-expected.txt:
* tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
* tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
* tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
* tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 25 Jun 2007 07:10:13 +0000 (07:10 +0000)]
Reviewed by Mitz.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
* page/inspector/ResourcePanel.js: make sure not to call an overriden
toString() by using Object.prototype.toString.call().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 25 Jun 2007 05:09:06 +0000 (05:09 +0000)]
Fix http://bugs.webkit.org/show_bug.cgi?id=14374
Bug 14374: Computed Style section should be expanded by default
Reviewed by Sam.
No regression test possible.
* page/inspector/ResourcePanel.js: Expand all style sections.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 25 Jun 2007 00:28:13 +0000 (00:28 +0000)]
Unify the style of enums in the Inspector JS
All our enums are now represented by an object with a property for
each enum value.
Reviewed by Sam.
No regression test possible.
* page/inspector/ConsolePanel.js:
* page/inspector/Resource.js:
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 24 Jun 2007 20:59:01 +0000 (20:59 +0000)]
Reviewed by Adam Roben.
Fix broken link.
* building/build.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 24 Jun 2007 20:53:07 +0000 (20:53 +0000)]
LayoutTests:
Reviewed by Mitz.
Tests for http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"
* fast/css/computed-style-expected.txt:
* fast/css/getComputedStyle-zIndex-auto-expected.txt: Added.
* fast/css/getComputedStyle-zIndex-auto.html: Added.
WebCore:
Reviewed by Mitz.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
getComputedStyle(...).zIndex returns string "normal"
Test: fast/css/getComputedStyle-zIndex-auto.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Sun, 24 Jun 2007 19:22:55 +0000 (19:22 +0000)]
Reviewed by Tim Hatcher.
Bug 14265: Cannot resize columns in webinspector
http://bugs.webkit.org/show_bug.cgi?id=14265
* page/inspector/inspector.css:
* page/inspector/inspector.html:
* page/inspector/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 24 Jun 2007 18:51:58 +0000 (18:51 +0000)]
Added Bugzilla bug number for revision 23727.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 24 Jun 2007 00:37:48 +0000 (00:37 +0000)]
2007-06-23 Mark Rowe <mrowe@apple.com>
Not reviewed.
* building/checkout.html: Update link to bypass caching proxy as it has a habit of breaking huge downloads.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 23 Jun 2007 19:23:44 +0000 (19:23 +0000)]
Uploading the correct expected results -- the ones checked in expected
an "unkown" callback, which was incorrect behavior.
* fast/loader/user-style-sheet-resource-load-callbacks-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 23 Jun 2007 18:35:50 +0000 (18:35 +0000)]
Fix the "num-cpus not found" warning the Windows WebCore build emits
WebCore:
Silence a build warning about not finding `num-cpus`
Reviewed by Mark Rowe.
* WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
location.
WebKitTools:
Land num-cpus for the Windows build.
Reviewed by Mark Rowe.
* Scripts/num-cpus: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Sat, 23 Jun 2007 08:49:16 +0000 (08:49 +0000)]
Added support for populating ChangeLog entries from given git commits
using --git-commit=<commitish> and --git-reviewer=<name>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 22 Jun 2007 23:06:30 +0000 (23:06 +0000)]
Reviewed by Geoff and Darin.
Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name
* Misc/WebNSURLExtras.m:
(isSlashOrPeriodLookalike):
(allCharactersInIDNScriptWhiteList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 22 Jun 2007 22:19:09 +0000 (22:19 +0000)]
Reviewed by Darin.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::didFinishLoading):
No need to fetch the size from resourceData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 22 Jun 2007 22:16:26 +0000 (22:16 +0000)]
Reviewed by Darin.
<rdar://problem/5288617>
Crash playing a very large QuickTime movie inside Safari.
Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for
plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::PluginStreamWin):
(WebCore::PluginStreamWin::~PluginStreamWin):
(WebCore::PluginStreamWin::didReceiveData):
(WebCore::PluginStreamWin::didFinishLoading):
* plugins/win/PluginStreamWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 22 Jun 2007 22:03:56 +0000 (22:03 +0000)]
LayoutTests:
Reviewed by Oliver and Darin.
Tests for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)
The results of this test have changed because we now clamp rowspan
at 8190 to match Firefox.
* fast/table/giantRowspan-expected.checksum:
* fast/table/giantRowspan-expected.png:
* fast/table/giantRowspan-expected.txt:
A new test that crashes our old heuristic for too-large rowspan,
but succeeds with the new one.
* fast/table/giantRowspan2-expected.checksum: Added.
* fast/table/giantRowspan2-expected.png: Added.
* fast/table/giantRowspan2-expected.txt: Added.
* fast/table/giantRowspan2.html: Added.
WebCore:
Reviewed by Oliver and Darin.
Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)
We already have code that tries to prevent allocating too-large
rowspans. The rowspan in this test, however, was small enough that
we thought it was okay in that code, even though clearly it was
still too large. I did a bunch of testing in Firefox, and it seems
that they set a hard limit on the maximum rowspan right in the DOM
-- 8k. So that is what this patch implements.
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::parseMappedAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 22 Jun 2007 21:57:24 +0000 (21:57 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines when pressing return
Demonstrates bug:
* editing/deleting/5272440-expected.checksum: Added.
* editing/deleting/5272440-expected.png: Added.
* editing/deleting/5272440-expected.txt: Added.
* editing/deleting/5272440.html: Added.
upstream() now works for the positions visually equivalent to [span, 0]
where span is an inline root editable element:
* editing/deleting/delete-mixed-editable-content-001-expected.txt:
WebCore:
Reviewed by Darin.
<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
Deletion inserts a placeholder after it removes full paragraphs if
one doesn't already exist. The code that looked for a pre-existing
placeholder didn't work because of a bug in enclosingNodeOfType.
* editing/htmlediting.cpp:
(WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
but don't go above an editing root.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 22 Jun 2007 19:47:00 +0000 (19:47 +0000)]
Add result.
* fast/loader/user-style-sheet-resource-load-callbacks-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 22 Jun 2007 19:04:58 +0000 (19:04 +0000)]
LayoutTests:
Reviewed by Geoff.
<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
* fast/loader/resources/user-style-sheet.css: Added.
* fast/loader/user-style-sheet-resource-load-callbacks.html: Added.
WebCore:
Reviewed by Maciej and Geoff.
<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks
argument to a bunch of classes).
* loader/Cache.cpp:
(WebCore::createResource):
(WebCore::Cache::requestResource):
* loader/Cache.h:
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
* loader/CachedCSSStyleSheet.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/CachedResource.h:
(WebCore::CachedResource::sendResourceLoadCallbacks):
* loader/DocLoader.cpp:
(WebCore::DocLoader::requestCSSStyleSheet):
(WebCore::DocLoader::requestResource):
(WebCore::DocLoader::checkCacheObjectStatus):
* loader/DocLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
* loader/Request.cpp:
(WebCore::Request::Request):
* loader/Request.h:
(WebCore::Request::sendResourceLoadCallbacks):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::didCancel):
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::sendResourceLoadCallbacks):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
* loader/SubresourceLoader.h:
* loader/loader.cpp:
(WebCore::Loader::load):
(WebCore::Loader::servePendingRequests):
* loader/loader.h:
* loader/mac/NetscapePlugInStreamLoaderMac.mm:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 22 Jun 2007 18:27:02 +0000 (18:27 +0000)]
LayoutTests:
Reviewed by Anders.
<rdar://problem/5228168> Leopard regression test failures: fast/applescript
New results to match the DumpRenderTree changes.
* fast/AppleScript/001-expected.txt:
* fast/AppleScript/array-expected.txt:
* fast/AppleScript/date-expected.txt:
WebKitTools:
Reviewed by Anders.
<rdar://problem/5228168> Leopard regression test failures: fast/applescript
There were some changes in Leopard that made our test output inconsistent with Tiger.
NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
on Leopard, so output our own readable string for typeType descriptors.
NSArray's description also changed on Leopard to output more whitespace, so
make our own string representation for typeAEList descriptors. This requires
a special case typeUnicodeText too, so the output is a quoted string.
* DumpRenderTree/AppleScriptController.m:
(convertAEDescToObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 22 Jun 2007 16:56:00 +0000 (16:56 +0000)]
Reviewed by Tim Hatcher.
Bug 14305: Web Inspector marks local files with server-side compression tip
http://bugs.webkit.org/show_bug.cgi?id=14305
* page/inspector/Resource.js:
(WebInspector.Resource._shouldCompress): Prevent server-side compression tip
from being given to local files
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 22 Jun 2007 07:00:51 +0000 (07:00 +0000)]
2007-06-21 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
* platform/StringImpl.cpp:
(WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string. This avoids returning
a length of zero when the string is collapsed to empty by whitespace simplification.
2007-06-21 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
Test for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
* fast/frames/frame-set-whitespace-attributes-expected.txt: Added.
* fast/frames/frame-set-whitespace-attributes.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 22 Jun 2007 06:05:41 +0000 (06:05 +0000)]
Fix large font size crash on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew [Fri, 22 Jun 2007 05:01:54 +0000 (05:01 +0000)]
Reviewed by Timothy.
Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
* page/inspector/inspector.css: Set body margin to 0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 22 Jun 2007 04:11:53 +0000 (04:11 +0000)]
Remove some empty directories.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 22 Jun 2007 03:29:41 +0000 (03:29 +0000)]
Patch from Adam Treat to implement default icons / resources for Qt. Also does
a small cleanup to QWebPage::icon. This is a great example of how QWebSettings
is not ideal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 22 Jun 2007 01:40:19 +0000 (01:40 +0000)]
Reviewed by Darin.
Use RetainPtr for holding currentEvent. This removes explicit HardRetain/Release calls
and makes reference handling simpler in advance of IME refactoring.
* WebCore.xcodeproj/project.pbxproj:
* page/mac/EventHandlerMac.mm:
(WebCore::currentEvent):
(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::lastEventIsMouseUp):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventLoopHandleMouseDragged):
(WebCore::EventHandler::eventLoopHandleMouseUp):
(WebCore::EventHandler::passSubframeEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 22 Jun 2007 00:41:29 +0000 (00:41 +0000)]
Reviewed by Antti.
Remove empty directories
* WebInspector/webInspector: directory removed.
* WebInspector/webInspector/Images: directory removed
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 22 Jun 2007 00:26:00 +0000 (00:26 +0000)]
Add rendered and stylable scrollbars for Qt
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 21 Jun 2007 23:05:08 +0000 (23:05 +0000)]
LayoutTests:
Reviewed by Dave Hyatt.
Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)
Added layout test for this bug:
* fast/invalid/nestedh3s-rapidweaver-expected.txt: Added.
* fast/invalid/nestedh3s-rapidweaver.html: Added.
Reversed the expected results for this test because I rolled out r7703:
* fast/invalid/nestedh3s-expected.checksum:
* fast/invalid/nestedh3s-expected.png:
* fast/invalid/nestedh3s-expected.txt:
* fast/invalid/nestedh3s.html:
WebCore:
Reviewed by Dave Hyatt.
Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML
effects when clicking on its links (12646)
I'm rolling our r7703 for these reasons:
1. It broke RapidWeaver.
2. WebKit is now orders of magnitude faster when handling deep nesting
(5 seconds vs 3 minutes on my MBP in this particular case).
3. Firefox, IE, and HTML5 all allow nested heading tags.
4. Hyatt said so.
* html/HTMLParser.cpp:
(WebCore::HTMLParser::parseToken):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 21 Jun 2007 22:34:56 +0000 (22:34 +0000)]
Reviewed by Tim Hatcher.
Remove assert for now as it is causing the back button to not
work in debug builds.
* page/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 21 Jun 2007 21:45:49 +0000 (21:45 +0000)]
Reviewed by Tim.
<rdar://problem/5237524>
REGRESSION: Keyboard commands don't work in a message window until you click inside the message
When you open a message in its own window, Mail creates an empty
WebView, makes that WebView firstResponder and then sets off a
load inside that WebView.
When we're asked to create the empty WebView, we put an empty
WebHTMLView inside it (in r21367 we began creating a document
for empty frames). When Mail makes the WebView first responder
we make that empty WebHTMLView firstResponder. Then when the
load finishes we create a new WebHTMLView and set it as the
document view.
Inside _setDocumentView, if the old document view or one of its
descendants was the first responder, we'd makeFirstResponder:nil
so that the window wouldn't be left with a firstResponder that
was no longer inside of it. This change fixes the bug by instead
transferring firstResponder status to the new document view.
We could also fix this by not allowing the WebHTMLView to become
firstResponder when it's in the provisional state mentioned above.
* WebView/WebFrameView.mm:
(-[WebFrameView _setDocumentView:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 21 Jun 2007 21:26:32 +0000 (21:26 +0000)]
Versioning
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 21 Jun 2007 21:14:12 +0000 (21:14 +0000)]
LayoutTests:
Reviewed by Geoff.
Update test results.
* http/tests/loading/bad-scheme-subframe-expected.txt:
* http/tests/loading/bad-server-subframe-expected.txt:
* http/tests/loading/basic-expected.txt:
* http/tests/loading/empty-subframe-expected.txt:
* http/tests/loading/simple-subframe-expected.txt:
* webarchive/loading/test-loading-archive-expected.txt:
WebKitTools:
Reviewed by Geoff.
Don't dump didFirstLayout callbacks, they happen intermittently.
* DumpRenderTree/FrameLoadDelegate.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 20:30:39 +0000 (20:30 +0000)]
Remove some debug output.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 21 Jun 2007 20:21:59 +0000 (20:21 +0000)]
Reviewed by Geoff.
Update test result.
* fast/dom/xmlhttprequest-invalid-values-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 21 Jun 2007 19:28:51 +0000 (19:28 +0000)]
Fix the Qt Mac OS X build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 19:19:30 +0000 (19:19 +0000)]
update test results after my font refactoring.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 21 Jun 2007 19:01:30 +0000 (19:01 +0000)]
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=13905
REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
(regardless of the actual response MIME type). This was corrected a while ago to match other
browsers and the draft XHR spec.
Now restoring this functionality for "text/html", with spec editor's blessing.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType):
(WebCore::XMLHttpRequest::responseIsXML):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Thu, 21 Jun 2007 18:15:19 +0000 (18:15 +0000)]
Reviewed by Adele
- fixed <rdar://problem/5268673> REGRESSION: Context menu missing for PDF in frame when there's no selection
This was surprisingly interesting. It turns out that at least for Safari, the method [WebDefaultUIDelegate
webView:contextMenuItemsForElement:defaultMenuItems:] is only exercised from WebPDFView these days. It mimics
some of the code that was moved to WebCore as part of the Great Context Menu Refactoring of 2006, but is
independent of that code. And it was partly broken/incomplete, probably as a result of said refactoring.
* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(localizedMenuTitleFromAppKit()):
deleted this function since I removed all callers
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
Handle WebMenuItemTagOpenFrameInNewWindow tag, since code later in this file was relying on it. Added
ASSERT_NOT_REACHED to the default case, since returning nil from this method is bad.
Also, use WebKit versions of menu title strings rather than AppKit versions. We added these strings to WebKit
a while back so we don't need to sneakily find them in AppKit anymore.
(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
make the WebView be the target of the Open Frame in New Window item; previously it was self, but that was
just silly (probably a leftover from some code shuffling when context menus were reimplemented)
* WebView/WebView.mm:
(-[WebView _openFrameInNewWindowFromMenu:]):
new method, used by Open Frame in New Window menu item.
* WebView/WebViewInternal.h:
Declare new method used by menu item. This isn't necessary for compilation, but could prevent the accidental
deletion of the method implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew [Thu, 21 Jun 2007 14:09:27 +0000 (14:09 +0000)]
Mac build fix.
* platform/Font.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:02:04 +0000 (11:02 +0000)]
another small fix for letter spacing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:01:49 +0000 (11:01 +0000)]
fix word-spacing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:01:35 +0000 (11:01 +0000)]
fix letterspacing and small caps.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:01:21 +0000 (11:01 +0000)]
store the metrics and space width in the Font object
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:01:08 +0000 (11:01 +0000)]
simplify some codepaths
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:00:53 +0000 (11:00 +0000)]
fix copyright header
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:00:39 +0000 (11:00 +0000)]
correctly load fonts when a list of font families is given
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:00:20 +0000 (11:00 +0000)]
fix some more of the font support
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 11:00:08 +0000 (11:00 +0000)]
look for the Qt library in the installed location
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 10:59:57 +0000 (10:59 +0000)]
Compile fixes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 10:59:45 +0000 (10:59 +0000)]
Some more work on the implementation of FontQt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 21 Jun 2007 10:59:21 +0000 (10:59 +0000)]
Started work on the new font infrastructure for the Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 07:49:18 +0000 (07:49 +0000)]
More Gdk build fixes.
* page/gdk/ContextMenuClientGdk.cpp:
(WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
* page/gdk/ContextMenuClientGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 07:25:17 +0000 (07:25 +0000)]
Speculative Gdk build fix.
* page/InspectorController.h: Only include the JS headers we really
need to avoid pulling in ones like JSStringRefCF.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 07:00:09 +0000 (07:00 +0000)]
Reviewed by Simon Hausmann.
More Gdk build fixing.
* WebKit.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 06:51:35 +0000 (06:51 +0000)]
Speculative Gdk build fix.
* WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 06:11:13 +0000 (06:11 +0000)]
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
everything but $WebKitLibrariesDir so that we will pick up
JavaScriptCore headers directly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 21 Jun 2007 05:46:29 +0000 (05:46 +0000)]
add missing symbol
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 21 Jun 2007 05:42:00 +0000 (05:42 +0000)]
More missing files for building with Qt
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Thu, 21 Jun 2007 05:32:57 +0000 (05:32 +0000)]
Merge fix from r23692.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 21 Jun 2007 05:01:53 +0000 (05:01 +0000)]
Patch from Adam Treat to add ICO support to the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 21 Jun 2007 04:55:19 +0000 (04:55 +0000)]
Reviewed by Anders.
One more test for XHR header injection.
* http/tests/xmlhttprequest/inject-header-expected.txt: Added.
* http/tests/xmlhttprequest/inject-header.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 21 Jun 2007 04:43:41 +0000 (04:43 +0000)]
One last build fix - now it runs again
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 21 Jun 2007 04:31:39 +0000 (04:31 +0000)]
Repair the Qt build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 03:38:05 +0000 (03:38 +0000)]
WebCore:
More speculative Qt/Gdk build fixes.
* WebCore.pro: Add new files.
WebKitQt:
More speculative Qt build fixes.
Add a stub implementation of InspectorClientQt.
* WebCoreSupport/InspectorClientQt.cpp: Added.
(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::createPage):
(WebCore::InspectorClientQt::showWindow):
(WebCore::InspectorClientQt::closeWindow):
(WebCore::InspectorClientQt::attachWindow):
(WebCore::InspectorClientQt::detachWindow):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::hideHighlight):
* WebCoreSupport/InspectorClientQt.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 03:21:28 +0000 (03:21 +0000)]
Speculative Qt/Gdk build fix.
Added forwarding headers for JavaScriptCore. We may eventually move
InspectorController off of the JSC API, but for now this is the
quickest way to a working build.
* ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
* ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
* ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 21 Jun 2007 03:18:09 +0000 (03:18 +0000)]
Rubber stamped by Adam Roben.
Add licenses.
* page/inspector/ConsolePanel.js:
* page/inspector/NetworkPanel.js:
* page/inspector/Resource.js:
* page/inspector/ResourceCategory.js:
* page/inspector/ResourcePanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 21 Jun 2007 03:17:22 +0000 (03:17 +0000)]
Add Bugzilla info to ChangeLog entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 21 Jun 2007 03:11:30 +0000 (03:11 +0000)]
2007-06-20 Mark Rowe <mrowe@apple.com>
Reviewed by Adam.
Reinstate the WebInspector class so WebKit clients that currently depend on it
will build and run correctly.
* WebInspector/WebInspector.h: Added.
* WebInspector/WebInspector.mm: Added.
(+[WebInspector webInspector]):
(-[WebInspector dealloc]):
(-[WebInspector setWebFrame:]):
(-[WebInspector showWindow:]):
* WebKit.exp:
* WebKit.xcodeproj/project.pbxproj:
2007-06-20 Mark Rowe <mrowe@apple.com>
Reviewed by Adam.
* WebCore.exp: Export InspectorController::inspect so WebKit can see it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 02:59:17 +0000 (02:59 +0000)]
Addressed some of Geoff's comments.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent): Added a
FIXME.
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::addInspectElementItem): Null-check
frame->page().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 21 Jun 2007 02:46:18 +0000 (02:46 +0000)]
WebCore:
Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5:
Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString
returning nil instead of "")
I'm basically rolling out the change for <rdar://problem/4782422> because
my testing shows that it was backwards.
* html/HTMLElement.cpp:
(dumpInnerHTML): New debug-only function to work around gdb being
perpetually suck-tastic.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
Return "", not nil. This function never used to return nil, so let's not
start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
WebKitTools:
Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
Added tests for stringByEvaluatingJavaScriptFromString.
* DumpRenderTree/DumpRenderTree.m:
(testStringByEvaluatingJavaScriptFromString):
(dumpRenderTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 02:34:16 +0000 (02:34 +0000)]
Fix crash in fast/dom/dir-no-body.html
Reviewed by Mark.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createTokenizer): Don't assume we have a
Frame, since we won't if someone creates an HTMLDocument from JS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 21 Jun 2007 01:57:37 +0000 (01:57 +0000)]
Reviewed by Geoff.
Make sure that the test case tests '\n' and '\r' too.
* fast/dom/xmlhttprequest-invalid-values.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 21 Jun 2007 01:37:24 +0000 (01:37 +0000)]
Land the new Inspector.
WebCore:
Land the new Inspector.
Co-written with Tim Hatcher.
Reviewed by Anders, Adele, Hyatt, and Sam.
No regression tests possible.
Add a new InspectorController that is in charge of the Inspector. It
has an InspectorClient that controls the Inspector's window and node
highlight.
* page/InspectorClient.h: Added.
(WebCore::InspectorClient::~InspectorClient):
* page/InspectorController.cpp: Added.
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::InspectorResource::): Represents a single resource that the
Inspector knows about.
(WebCore::InspectorResource::InspectorResource):
(WebCore::InspectorResource::~InspectorResource):
(WebCore::InspectorResource::type):
(WebCore::InspectorResource::setScriptObject):
(WebCore::addSourceToFrame): Callback available from JS.
(WebCore::getResourceDocumentNode): Ditto.
(WebCore::highlightDOMNode): Ditto.
(WebCore::hideDOMNodeHighlight): Ditto.
(WebCore::loaded): Ditto.
(WebCore::unloading): Ditto.
(WebCore::attach): Ditto.
(WebCore::detach): Ditto.
(WebCore::log): Ditto.
(WebCore::search): Ditto.
(WebCore::inspectedWindow): Ditto.
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspect): Called by
ContextMenuController to inspect a node.
(WebCore::InspectorController::focusNode):
(WebCore::InspectorController::highlight):
(WebCore::InspectorController::hideHighlight):
(WebCore::InspectorController::windowVisible):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::addMessageToConsole):
(WebCore::InspectorController::attachWindow):
(WebCore::InspectorController::detachWindow):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::scriptObjectReady):
(WebCore::InspectorController::windowUnloading):
(WebCore::addHeaders): Static helper function.
(WebCore::objectForRequest): Ditto.
(WebCore::objectForResponse): Ditto.
(WebCore::InspectorController::addScriptResource):
(WebCore::InspectorController::addAndUpdateScriptResource):
(WebCore::InspectorController::removeScriptResource):
(WebCore::InspectorController::updateScriptResource):
(WebCore::InspectorController::populateScriptResources):
(WebCore::InspectorController::addScriptConsoleMessage):
(WebCore::callClearFunction): Static helper function.
(WebCore::InspectorController::clearScriptResources):
(WebCore::InspectorController::clearScriptConsoleMessages):
(WebCore::InspectorController::clearNetworkTimeline):
(WebCore::InspectorController::pruneResources):
(WebCore::InspectorController::didCommitLoad): Callback from
FrameLoader.
(WebCore::InspectorController::frameDetachedFromParent): Ditto.
(WebCore::InspectorController::addResource): Ditto.
(WebCore::InspectorController::removeResource): Ditto.
(WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
(WebCore::InspectorController::identifierForInitialRequest): Ditto.
(WebCore::InspectorController::willSendRequest): Ditto.
(WebCore::InspectorController::didReceiveResponse): Ditto.
(WebCore::InspectorController::didReceiveContentLength): Ditto.
(WebCore::InspectorController::didFinishLoading): Ditto.
(WebCore::InspectorController::didFailLoading): Ditto.
* page/InspectorController.h: Added.
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::scriptContext):
(WebCore::InspectorController::setScriptContext):
(WebCore::InspectorController::resources):
(WebCore::InspectorController::removeAllResources):
Add the JavaScript that defines most of the behavior of the Inspector.
* page/inspector/ConsolePanel.js: Added.
* page/inspector/NetworkPanel.js: Added.
* page/inspector/Resource.js: Added.
* page/inspector/ResourceCategory.js: Added.
* page/inspector/ResourcePanel.js: Added.
* page/inspector/inspector.js: Added.
* page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
* page/inspector/utilities.js: Added.
Add the Inspector's CSS and HTML.
* page/inspector/inspector.css: Added.
* page/inspector/inspector.html: Added.
Hang the InspectorController off of Page. We only create an
InspectorController if an InspectorClient is given to the Page.
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(WebCore::Page::inspectorController):
Use FrameLoader to notify the InspectorController of resource loads.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::assignIdentifierToInitialRequest):
(WebCore::FrameLoader::willSendRequest):
(WebCore::FrameLoader::didReceiveResponse):
(WebCore::FrameLoader::didReceiveData):
(WebCore::FrameLoader::sendRemainingDelegateMessages):
(WebCore::FrameLoader::requestFromDelegate):
(WebCore::FrameLoader::didFinishLoad):
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
(WebCore::FrameLoader::dispatchWillSendRequest):
(WebCore::FrameLoader::dispatchDidReceiveResponse):
(WebCore::FrameLoader::dispatchDidReceiveContentLength):
(WebCore::FrameLoader::dispatchDidFinishLoading):
(WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
* loader/FrameLoader.h:
Send console messages to the InspectorController.
* page/Chrome.cpp:
(WebCore::Chrome::addMessageToConsole): Send all console messages to
the InspectorController.
* page/Chrome.h: Add a new MessageLevel and MessageSource that are
used in the Inspector JS.
Report HTML errors when the Inspector window is open.
We don't report errors when the window is closed because we don't want
to slow down the HTMLTokenizer.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createTokenizer):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::HTMLParser):
* html/HTMLParser.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
* html/HTMLTokenizer.h:
Append the "Inspect Element" context menu item after passing the
context menu to the ContextMenuClient. This work used to be done in
WebKit.
* page/ContextMenuClient.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent): Add the
"Inspect Element" item.
(WebCore::ContextMenuController::contextMenuItemSelected): Handle the
"Inspect Element" item.
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::addInspectElementItem):
(WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
Element" item.
* platform/ContextMenu.h:
* platform/ContextMenuItem.h:
(WebCore::): Add ContextMenuItemTagInspectElement.
* platform/graphics/svg/SVGImageEmptyClients.h:
* page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
string.
* platform/LocalizedStrings.h: Ditto.
* platform/mac/LocalizedStringsMac.mm:
(WebCore::contextMenuItemTagInspectElement): Ditto.
Miscellaneous changes:
* css/view-source.css: Add message bubble styles.
* loader/DocumentLoader.h: Add a frame getter.
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::updateScrollbars): Respect
Frame::prohibitsScrolling.
Add new images needed for the Inspector.
* page/inspector/Images/attachedShadow.png: Added.
* page/inspector/Images/bottomShadow.png: Added.
* page/inspector/Images/breadcrumbBackground.png: Added.
* page/inspector/Images/checker.png: Added.
* page/inspector/Images/console.png: Added.
* page/inspector/Images/darkShadow.png: Added.
* page/inspector/Images/disclosureDownPressed.png: Added.
* page/inspector/Images/disclosureRightDown.png: Added.
* page/inspector/Images/disclosureRightPressed.png: Added.
* page/inspector/Images/document.png: Added.
* page/inspector/Images/domViewButton.png: Added.
* page/inspector/Images/domViewButtonSelected.png: Added.
* page/inspector/Images/downTriangle.png: Added.
* page/inspector/Images/errorIcon.png: Added.
* page/inspector/Images/errorMediumIcon.png: Added.
* page/inspector/Images/folder.png: Added.
* page/inspector/Images/goArrow.png: Added.
* page/inspector/Images/gradient.png: Added.
* page/inspector/Images/gradientHighlight.png: Added.
* page/inspector/Images/gradientHighlightBottom.png: Added.
* page/inspector/Images/hideStatusWidget.png: Added.
* page/inspector/Images/hideStatusWidgetPressed.png: Added.
* page/inspector/Images/network.png: Added.
* page/inspector/Images/paneBottomGrow.png: Added.
* page/inspector/Images/paneBottomGrowActive.png: Added.
* page/inspector/Images/paneGrowHandleLine.png: Added.
* page/inspector/Images/paneHeader.png: Added.
* page/inspector/Images/paneHeaderActive.png: Added.
* page/inspector/Images/plainDocument.png: Added.
* page/inspector/Images/popupArrows.png: Added.
* page/inspector/Images/rightTriangle.png: Added.
* page/inspector/Images/segment.png: Added.
* page/inspector/Images/segmentEnd.png: Added.
* page/inspector/Images/segmentHover.png: Added.
* page/inspector/Images/segmentHoverEnd.png: Added.
* page/inspector/Images/segmentSelected.png: Added.
* page/inspector/Images/segmentSelectedEnd.png: Added.
* page/inspector/Images/showStatusWidget.png: Added.
* page/inspector/Images/showStatusWidgetPressed.png: Added.
* page/inspector/Images/sidbarItemBackground.png: Added.
* page/inspector/Images/sidebarActionWidget.png: Added.
* page/inspector/Images/sidebarActionWidgetPressed.png: Added.
* page/inspector/Images/sidebarAttachWidget.png: Added.
* page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
* page/inspector/Images/sidebarDetachWidget.png: Added.
* page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
* page/inspector/Images/sidebarResizeWidget.png: Added.
* page/inspector/Images/sidebarSelection.png: Added.
* page/inspector/Images/sidebarSelectionBlurred.png: Added.
* page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
* page/inspector/Images/sidebarSelectionGray.png: Added.
* page/inspector/Images/sidebarSelectionGrayTall.png: Added.
* page/inspector/Images/sidebarSelectionTall.png: Added.
* page/inspector/Images/sidebarStatusAreaBackground.png: Added.
* page/inspector/Images/sourceViewButton.png: Added.
* page/inspector/Images/sourceViewButtonSelected.png: Added.
* page/inspector/Images/splitviewDimple.png: Added.
* page/inspector/Images/splitviewDividerBackground.png: Added.
* page/inspector/Images/tab.png: Added.
* page/inspector/Images/tabSelected.png: Added.
* page/inspector/Images/timelinePillBlue.png: Added.
* page/inspector/Images/timelinePillGray.png: Added.
* page/inspector/Images/timelinePillGreen.png: Added.
* page/inspector/Images/timelinePillOrange.png: Added.
* page/inspector/Images/timelinePillPurple.png: Added.
* page/inspector/Images/timelinePillRed.png: Added.
* page/inspector/Images/timelinePillYellow.png: Added.
* page/inspector/Images/tipBalloon.png: Added.
* page/inspector/Images/tipBalloonBottom.png: Added.
* page/inspector/Images/tipIcon.png: Added.
* page/inspector/Images/tipIconPressed.png: Added.
* page/inspector/Images/toggleDown.png: Added.
* page/inspector/Images/toggleUp.png: Added.
* page/inspector/Images/toolbarBackground.png: Added.
* page/inspector/Images/toolbarBackgroundInactive.png: Added.
* page/inspector/Images/toolbarButton.png: Added.
* page/inspector/Images/toolbarButtonInactive.png: Added.
* page/inspector/Images/toolbarButtonPressed.png: Added.
* page/inspector/Images/toolbarButtonPressedInactive.png: Added.
* page/inspector/Images/toolbarSplitButtonDivider.png: Added.
* page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
* page/inspector/Images/treeDownTriangleBlack.png: Added.
* page/inspector/Images/treeDownTriangleWhite.png: Added.
* page/inspector/Images/treeLeftTriangleBlack.png: Added.
* page/inspector/Images/treeRightTriangleBlack.png: Added.
* page/inspector/Images/treeRightTriangleWhite.png: Added.
* page/inspector/Images/warningIcon.png: Added.
* page/inspector/Images/warningMediumIcon.png: Added.
* page/inspector/Images/warningsErrors.png: Added.
Build-fu:
* WebCore.exp: Added new symbols.
* WebCore.xcodeproj/project.pbxproj: Added new source files and
resources.
* WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
$WebKitOutputDir.
Windows build fixes:
* history/HistoryItem.h: ResourceRequest is a struct.
* loader/FrameLoaderClient.h: Ditto.
WebKit:
Land the new Inspector.
Co-written with Tim Hatcher.
Reviewed by Anders, Adele, Hyatt, and Sam.
Implement the InspectorClient interface.
* WebCoreSupport/WebInspectorClient.h: Added.
* WebCoreSupport/WebInspectorClient.mm: Added.
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::createPage):
(WebInspectorClient::showWindow):
(WebInspectorClient::closeWindow):
(WebInspectorClient::attachWindow):
(WebInspectorClient::detachWindow):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::inspectedURLChanged):
(WebInspectorClient::updateWindowTitle):
(-[WebInspectorWindowController init]):
(-[WebInspectorWindowController initWithInspectedWebView:]):
(-[WebInspectorWindowController dealloc]):
(-[WebInspectorWindowController inspectorVisible]):
(-[WebInspectorWindowController webView]):
(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController windowShouldClose:]):
(-[WebInspectorWindowController close]):
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):
(-[WebInspectorWindowController highlightAndScrollToNode:]):
(-[WebInspectorWindowController highlightNode:]):
(-[WebInspectorWindowController hideHighlight]):
(-[WebInspectorWindowController animationDidEnd:]):
Add an easier-to-see highlight.
* Misc/WebNSViewExtras.h:
* Misc/WebNSViewExtras.m:
(-[NSView _web_convertRect:toView:]):
* WebInspector/WebNodeHighlight.h:
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlightFadeInAnimation setCurrentProgress:]):
(-[WebNodeHighlight initWithTargetView:]):
(-[WebNodeHighlight setHighlightedNode:]):
(-[WebNodeHighlight highlightedNode]):
(-[WebNodeHighlight dealloc]):
(-[WebNodeHighlight attachHighlight]):
(-[WebNodeHighlight delegate]):
(-[WebNodeHighlight detachHighlight]):
(-[WebNodeHighlight show]):
(-[WebNodeHighlight hide]):
(-[WebNodeHighlight animationDidEnd:]):
(-[WebNodeHighlight ignoresMouseEvents]):
(-[WebNodeHighlight highlightView]):
(-[WebNodeHighlight setDelegate:]):
(-[WebNodeHighlight setHolesNeedUpdateInTargetViewRect:]):
(-[WebNodeHighlight setIgnoresMouseEvents:]):
(-[WebNodeHighlight targetView]):
(-[WebNodeHighlight _computeHighlightWindowFrame]):
(-[WebNodeHighlight _repositionHighlightWindow]):
* WebInspector/WebNodeHighlightView.h:
* WebInspector/WebNodeHighlightView.m:
(-[WebNodeHighlightView initWithWebNodeHighlight:]):
(-[WebNodeHighlightView dealloc]):
(-[WebNodeHighlightView detachFromWebNodeHighlight]):
(-[WebNodeHighlightView drawRect:]):
(-[WebNodeHighlightView webNodeHighlight]):
(-[WebNodeHighlightView fractionFadedIn]):
(-[WebNodeHighlightView setFractionFadedIn:]):
(-[WebNodeHighlightView setHolesNeedUpdateInRect:]):
(-[WebNodeHighlightView _holes]):
WebView changes needed for the new Inspector.
* WebView/WebView.mm: Remove the old _inspectElement method now that
this is handled by WebCore.
(-[WebView _isClosed]): Added.
(-[WebView initWithFrame]): Give each Page an InspectorClient to
enable the Inspector.
* WebView/WebViewPrivate.h:
Updates needed for WebCore changes.
* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebContextMenuClient.mm:
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory contextMenuItemTagInspectElement]):
* WebView/WebUIDelegatePrivate.h:
Remove old Inspector code.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebFrameLoaderClient::assignIdentifierToInitialRequest):
(WebFrameLoaderClient::dispatchDidFinishLoading):
* WebInspector/WebInspector.m: Removed.
* WebInspector/WebInspectorPanel.h: Removed.
* WebInspector/WebInspectorPanel.m: Removed.
* WebInspector/webInspector/Images/button.png: Removed.
* WebInspector/webInspector/Images/buttonDivider.png: Removed.
* WebInspector/webInspector/Images/buttonPressed.png: Removed.
* WebInspector/webInspector/Images/close.png: Removed.
* WebInspector/webInspector/Images/closePressed.png: Removed.
* WebInspector/webInspector/Images/downTriangle.png: Removed.
* WebInspector/webInspector/Images/menu.png: Removed.
* WebInspector/webInspector/Images/menuPressed.png: Removed.
* WebInspector/webInspector/Images/popup.png: Removed.
* WebInspector/webInspector/Images/popupPressed.png: Removed.
* WebInspector/webInspector/Images/resize.png: Removed.
* WebInspector/webInspector/Images/rightTriangle.png: Removed.
* WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
* WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
* WebInspector/webInspector/Images/scrollTrackBottom.png: Removed.
* WebInspector/webInspector/Images/upTriangle.png: Removed.
* WebInspector/webInspector/inspector.css: Removed.
* WebInspector/webInspector/inspector.html: Removed.
* WebInspector/webInspector/inspector.js: Removed.
* WebInspector/webInspector/scrollarea.js: Removed.
* WebInspector/webInspector/scrollbar.js: Removed.
* WebInspector/webInspector/utilities.js: Removed.
* WebView/WebFrame.mm:
(-[WebFramePrivate dealloc]):
* WebView/WebFrameInternal.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView menuForEvent:]):
Build-fu:
* WebKit.exp:
* WebKit.xcodeproj/project.pbxproj:
WebKit/win:
Land the new Inspector.
Co-written with Tim Hatcher.
Reviewed by Anders, Adele, Hyatt, and Sam.
Implement the InspectorClient interface.
* WebInspectorClient.cpp: Added.
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::~WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::createPage):
(WebInspectorClient::showWindow):
(WebInspectorClient::closeWindow):
(WebInspectorClient::windowVisible):
(WebInspectorClient::attachWindow):
(WebInspectorClient::detachWindow):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::inspectedURLChanged):
(WebInspectorClient::updateWindowTitle):
(WebInspectorClient::onSize):
(WebInspectorClient::onClose):
(WebInspectorClient::onWebViewWindowPosChanging):
(WebInspectorWndProc):
(SubclassedWebViewWndProc):
(registerWindowClass):
* WebInspectorClient.h: Added.
Add an easier-to-see highlight.
* WebNodeHighlight.cpp: Added.
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::~WebNodeHighlight):
(WebNodeHighlight::highlight):
(WebNodeHighlight::hide):
(WebNodeHighlight::visible):
(WebNodeHighlight::updateWindow):
(WebNodeHighlight::removeSubclass):
(registerOverlayClass):
(OverlayWndProc):
(SubclassedWndProc):
* WebNodeHighlight.h: Added.
WebView changes needed for the new Inspector.
* WebView.cpp: Removed old inspectElement method now that this is
handled by WebCore.
(WebView::WebView):
(WebView::close):
(WebView::performContextMenuAction): Removed handling of the Inspect
Element context menu item.
(WebView::initWithFrame): Give each Page an InspectorClient to enable
the Inspector.
(WebView::setProhibitsMainFrameScrolling): Added.
* WebView.h:
Updates needed for WebCore changes.
* Interfaces/IWebUIDelegate.idl:
* WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
* WebContextMenuClient.h:
* WebCoreLocalizedStrings.cpp:
Remove old Inspector code.
* WebFrame.cpp:
* WebFrame.h:
* WebInspector/WebInspector.cpp: Removed.
* WebInspector/WebInspector.h: Removed.
* WebInspector/webInspector/Images/button.png: Removed.
* WebInspector/webInspector/Images/buttonDivider.png: Removed.
* WebInspector/webInspector/Images/buttonPressed.png: Removed.
* WebInspector/webInspector/Images/close.png: Removed.
* WebInspector/webInspector/Images/closePressed.png: Removed.
* WebInspector/webInspector/Images/downTriangle.png: Removed.
* WebInspector/webInspector/Images/menu.png: Removed.
* WebInspector/webInspector/Images/menuPressed.png: Removed.
* WebInspector/webInspector/Images/popup.png: Removed.
* WebInspector/webInspector/Images/popupPressed.png: Removed.
* WebInspector/webInspector/Images/resize.png: Removed.
* WebInspector/webInspector/Images/rightTriangle.png: Removed.
* WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
* WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
* WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
* WebInspector/webInspector/Images/upTriangle.png: Removed.
* WebInspector/webInspector/inspector.css: Removed.
* WebInspector/webInspector/inspector.html: Removed.
* WebInspector/webInspector/inspector.js: Removed.
* WebInspector/webInspector/scrollarea.js: Removed.
* WebInspector/webInspector/scrollbar.js: Removed.
* WebInspector/webInspector/treeoutline.js: Removed.
* WebInspector/webInspector/utilities.js: Removed.
Build-fu:
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 21 Jun 2007 00:09:48 +0000 (00:09 +0000)]
2007-06-20 Mitz Pettel <mitz@webkit.org>
Reviewed by Beth.
- fix http://bugs.webkit.org/show_bug.cgi?id=14056
REGRESSION (r21113-21143): TR background not repainted via style class change
Test: fast/repaint/table-row.html
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
table row also needs layout, so it doesn't get a repaint in setStyle().
2007-06-20 Mitz Pettel <mitz@webkit.org>
Reviewed by Beth.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=14056
REGRESSION (r21113-21143): TR background not repainted via style class change
* fast/repaint/table-row-expected.checksum: Added.
* fast/repaint/table-row-expected.png: Added.
* fast/repaint/table-row-expected.txt: Added.
* fast/repaint/table-row.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 21 Jun 2007 00:00:12 +0000 (00:00 +0000)]
2007-06-20 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=14244
Bug 14244: Data corruption when using a replace() callback function with data containing "$"
* kjs/string_object.cpp:
(KJS::replace): When 'replacement' is a function, do not replace $n placeholders in its return value.
This matches the behaviour described in ECMA 262 3rd Ed section 15.5.4.1, and as implemented in Firefox.
2007-06-20 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Test for http://bugs.webkit.org/show_bug.cgi?id=14244
Bug 14244: Data corruption when using a replace() callback function with data containing "$"
* fast/js/resources/string-replace-2.js: Update to test with 'replaceValue' being a function returning strings with "$n" placeholders.
* fast/js/string-replace-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 20 Jun 2007 21:56:02 +0000 (21:56 +0000)]
LayoutTests:
Reviewed by Adele.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=14040
Top and bottom border images flipped when using -webkit-border-image when border end up tiled
* fast/borders/border-image-01-expected.checksum: Added.
* fast/borders/border-image-01-expected.png: Added.
* fast/borders/border-image-01-expected.txt: Added.
* fast/borders/border-image-01.html: Added.
* fast/borders/resources/border-image.png: Added.
WebCore:
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=14040
Top and bottom border images flipped when using -webkit-border-image when border end up tiled
Test: fast/borders/border-image-01.html
Correctly account for the fact that "pattern space" is flipped.
* platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPatternCallback):
(WebCore::Image::drawPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 20 Jun 2007 21:29:49 +0000 (21:29 +0000)]
Reviewed by Darin.
<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
Check for either '\r' or '\n' in the header value.
* xml/xmlhttprequest.cpp:
(WebCore::isValidHeaderValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 20 Jun 2007 21:16:26 +0000 (21:16 +0000)]
Reviewed by Darin.
<rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail
Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
It blocks the event and moves back/forward on Delete/Shift+Delete if the
back/forward list is enabled.
* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:]): Check to see if the BackForwardList is
enabled. It always exists.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pyeh [Wed, 20 Jun 2007 20:56:12 +0000 (20:56 +0000)]
<rdar://problem/4882527> VO should speak URL of image links that lack tags
Add additional change from review
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:]):
Check if the element has imgTag before asking for its url
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pyeh [Wed, 20 Jun 2007 20:08:24 +0000 (20:08 +0000)]
<rdar://problem/4882527> VO should speak URL of image links that lack tags
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Return the url of images.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 20 Jun 2007 16:07:28 +0000 (16:07 +0000)]
Remove the XPath tests, they all pass now.
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 20 Jun 2007 00:23:48 +0000 (00:23 +0000)]
WebCore:
Reviewed by Kevin Decker.
<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::deferMainResourceDataLoad):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::handleDataLoadSoon):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::setDefersLoading):
WebKit:
Reviewed by Kevin Decker.
<rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
* WebView/WebDocumentLoaderMac.mm:
(needsAppKitWorkaround):
New function which checks if the frame load delegate belongs to AppKit.
(WebDocumentLoaderMac::setDataSource):
If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew [Wed, 20 Jun 2007 00:00:37 +0000 (00:00 +0000)]
Reviewed by Mark Rowe.
Support applications with spaces or special characters in their names
* Scripts/run-webkit-app:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 19 Jun 2007 23:22:32 +0000 (23:22 +0000)]
Add support to Windows for Backspace back/forward navigation and for Ctrl+arrow key back/forward navigation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log