WebKit-https.git
10 years ago2009-07-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 2 Jul 2009 06:04:17 +0000 (06:04 +0000)]
2009-07-01  Xan Lopez  <xlopez@igalia.com>

        Disable accessibility tests until we have the accessibility
        controller.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Jul 2009 05:13:50 +0000 (05:13 +0000)]
2009-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        <rdar://problem/7026010> <video> fails to show on http://camendesign.com/code/video_for_everybody

        First part of fix: when outline width changes, don't to a synchronous
        layer update right away, but just set the flag to say that compositing
        layers need updating. The synchronous layer update left the layer geometries
        out of whack when it happened in the middle of layout (e.g. when inside ::first-letter).

        Test: compositing/geometry/outline-change.html

        * rendering/RenderView.cpp:
        (WebCore::RenderView::setMaximalOutlineSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 2 Jul 2009 05:13:41 +0000 (05:13 +0000)]
2009-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        prepare-ChangeLog should have a --bug= argument and use it for url autofill
        https://bugs.webkit.org/show_bug.cgi?id=26383

        prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
        I also added a bit more template text in an effort to get better ChangeLogs
        from casual contributers.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Thu, 2 Jul 2009 02:08:44 +0000 (02:08 +0000)]
2009-07-01  Robert Hogan <robert@roberthogan.net>

        Reviewed by NOBODY.

        Fix Qt segfault when javascript disabled.
        If clients call addToJavaScriptWindowObject even though JavascriptEnabled is false
        webkit will segfault on the assert:
          ASSERTION FAILED: _rootObject
          (../../../WebCore/bridge/runtime.cpp:52
          JSC::Bindings::Instance::Instance(WTF::PassRefPtr<JSC::Bindings::RootObject>))
        Fix is to ensure JavaScript is enabled when client calls addToJavaScriptWindowObject.

        https://bugs.webkit.org/show_bug.cgi?id=26906

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 2 Jul 2009 02:01:20 +0000 (02:01 +0000)]
2009-07-01  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26842
        Build fix when ENABLE_DATABASE is off

        Move Database.h into ENABLE(DATABASE) guard so toggling ENABLE_DATABASE
        off does not break builds.

        * bindings/js/ScriptObjectQuarantine.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
abarth@webkit.org [Thu, 2 Jul 2009 01:35:43 +0000 (01:35 +0000)]
WebCore:

2009-07-01  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26899

        Modified XSSAuditor::decodeURL to only remove null characters so that
        it is consistent with the behavior of HTMLTokenizer and prevents
        injected scripts that contain control characters.

        Tests: http/tests/security/xssAuditor/script-tag-control-char.html
               http/tests/security/xssAuditor/script-tag-null-char.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::decodeURL): Modified to only remove null characters.
        * page/XSSAuditor.h: Reverted naming of third argument of method XSSAuditor::decodeURL
        from allowControlCharacters back to allowNullCharacters.
        * platform/network/ResourceResponseBase.cpp: Reverted back to rev #45003.
        (WebCore::isControlCharacter):
        * platform/network/ResourceResponseBase.h: Reverted back to rev #45003.

LayoutTests:

2009-07-01  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26899

        Tests that XSSAuditor prevents injected scripts that contain control characters.

        * http/tests/security/xssAuditor/script-tag-control-char-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-control-char.html: Added.
        * http/tests/security/xssAuditor/script-tag-null-char-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-null-char.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 2 Jul 2009 01:03:18 +0000 (01:03 +0000)]
2009-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        - supported keyboard shortcuts compatible with Firebug in Scripts Debugger:
        F5, Ctrl+/ (win,lin), Command+/ (mac) - continue
        F10, Ctrl+' (win, lin), Command+' (mac) - step over
        F11, Ctrl+; (win, lin), Command+; (mac) - step into
        Shift+F11, Ctrl+Shift+; (win, lin), Command+Shift+; (mac) - step out

        - added call stack navigation shortcuts:
        Ctrl+. - next call frame
        Ctrl+, - previouse call frame

        https://bugs.webkit.org/show_bug.cgi?id=23849

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype.handleKeyEvent):
        (WebInspector.CallStackSidebarPane.prototype._selectNextCallFrameOnStack):
        (WebInspector.CallStackSidebarPane.prototype._selectPreviousCallFrameOnStack):
        (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex):
        (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
        * inspector/front-end/KeyboardShortcut.js: Added.
        (WebInspector.KeyboardShortcut):
        (WebInspector.KeyboardShortcut.makeKey):
        (WebInspector.KeyboardShortcut.makeKeyFromEvent):
        (WebInspector.KeyboardShortcut.makeKeyFromCodeAndModifiers_):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.handleKeyEvent):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Daniel Erat <derat@google.com>
agl@chromium.org [Thu, 2 Jul 2009 00:54:26 +0000 (00:54 +0000)]
2009-07-01  Daniel Erat  <derat@google.com>

        Reviewed by David Levin.

        Chromium Linux: Move the scrollbar thumb on middle-click.

        https://bugs.webkit.org/show_bug.cgi?id=26910
        http://code.google.com/p/chromium/issues/detail?id=11976

        Tested by building Chrome and checking that the scrollbar moves as expected.

        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromium.h:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.h:
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        * platform/chromium/ScrollbarThemeChromiumWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
beidson@apple.com [Thu, 2 Jul 2009 00:38:02 +0000 (00:38 +0000)]
WebCore:

2009-07-01  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

        * WebCore.base.exp:

        * page/Settings.cpp:
        (WebCore::Settings::setLocalFileContentSniffingEnabled):
        * page/Settings.h:
        (WebCore::Settings::localFileContentSniffingEnabled):

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

WebKit/mac:

2009-07-01  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

        * WebView/WebPreferenceKeysPrivate.h:

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences localFileContentSniffingEnabled]):
        (-[WebPreferences setLocalFileContentSniffingEnabled:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 26909: aria-label needs to be supported
cfleizach@apple.com [Wed, 1 Jul 2009 23:34:54 +0000 (23:34 +0000)]
Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 1 Jul 2009 23:31:37 +0000 (23:31 +0000)]
2009-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
        https://bugs.webkit.org/show_bug.cgi?id=26692

        I also made prepare-ChangeLog sanity-check names and email addresses a little.
        Names must contain a space, and email addresses must contain '@'

        Also "fixed" $email_address to $emailAddress.  This script uses mixed variable name styles.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 1 Jul 2009 23:15:30 +0000 (23:15 +0000)]
2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Oliver Hunt.

        More datagrid columns work.  Make sure columns cache both a style for the column header as well
        as a style for the column background (behind the cells).

        Hook up to CSSStyleSelector methods for obtaining the pseudo styles for columns (stubbed out and
        unimplemented).

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumn):
        (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumnHeader):
        * css/CSSStyleSelector.h:
        * html/DataGridColumn.h:
        (WebCore::DataGridColumn::setColumnList):
        (WebCore::DataGridColumn::columnStyle):
        (WebCore::DataGridColumn::setColumnStyle):
        (WebCore::DataGridColumn::headerStyle):
        (WebCore::DataGridColumn::setHeaderStyle):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::recalcStyleForColumn):
        (WebCore::RenderDataGrid::columnStyle):
        (WebCore::RenderDataGrid::headerStyle):
        (WebCore::RenderDataGrid::paintColumnHeaders):
        * rendering/RenderDataGrid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 1 Jul 2009 22:33:44 +0000 (22:33 +0000)]
2009-07-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/7009870> After <audio> movie finishes playing, Pause button fails to change
        back to Play button

        Grab onto the current time when QTKit "ended" notification fires and use it as
        duration from that point on as QuickTime sometimes refuses to play all the way to
        the time it reports for duration and buffered. HTMLMediaElement assumes that there
        more to play in this situation and tries to restart playback, endlessly.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
            Rename m_duration to m_reportedDuration. Declare m_cachedDuration.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
            Rename m_duration to m_reportedDuration. Initialize m_cachedDuration.
        (WebCore::MediaPlayerPrivate::duration):
            Return m_cachedDuration once it has been set.
        (WebCore::MediaPlayerPrivate::updateStates):
            Rename m_duration to m_reportedDuration.
        (WebCore::MediaPlayerPrivate::didEnd):
            Set m_cachedDuration to currentTime().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 26900: AX: Manual spell check with Command-; does not bring up suggestions
cfleizach@apple.com [Wed, 1 Jul 2009 22:01:16 +0000 (22:01 +0000)]
Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.
mrowe@apple.com [Wed, 1 Jul 2009 21:41:04 +0000 (21:41 +0000)]
Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.

This makes WebKit.app behave as expected when set as the default web browser on a wider
range of OS versions.

Reviewed by Simon Fraser.

* WebKitLauncher/WebKitNightlyEnabler.m:
(poseAsWebKitApp):
(enableWebKitNightlyBehaviour):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShuffle some code around in preparation for a change to how poseAsWebKitApp works.
mrowe@apple.com [Wed, 1 Jul 2009 21:41:01 +0000 (21:41 +0000)]
Shuffle some code around in preparation for a change to how poseAsWebKitApp works.

Reviewed by Simon Fraser.

* WebKitLauncher/WebKitNightlyEnabler.m:
(systemVersion):
(webKitLauncherBundle):
(insideSafari4OnTigerTrampoline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 1 Jul 2009 21:06:36 +0000 (21:06 +0000)]
2009-07-01  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        Remove unused code in SVGTransformList and SVGTransformDistance
        <https://bugs.webkit.org/show_bug.cgi?id=26891>

        * svg/SVGTransformDistance.cpp:
        (WebCore::SVGTransformDistance::SVGTransformDistance):
        * svg/SVGTransformList.cpp:
        * svg/SVGTransformList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 1 Jul 2009 20:59:39 +0000 (20:59 +0000)]
2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Anders Carlsson.

        Begin stubbing out functions for layout, painting and style/geometry caching on columns.  Not enough
        is implemented for this to do much of anything yet, but it should help keep patch sizes down. :)

        * html/DataGridColumn.cpp:
        (WebCore::DataGridColumn::columnChanged):
        * html/DataGridColumn.h:
        (WebCore::DataGridColumn::setId):
        (WebCore::DataGridColumn::setLabel):
        (WebCore::DataGridColumn::setType):
        (WebCore::DataGridColumn::setSortable):
        (WebCore::DataGridColumn::setSortDirection):
        (WebCore::DataGridColumn::setColumnList):
        (WebCore::DataGridColumn::style):
        (WebCore::DataGridColumn::setStyle):
        (WebCore::DataGridColumn::rect):
        (WebCore::DataGridColumn::setRect):
        * html/DataGridColumnList.cpp:
        (WebCore::DataGridColumnList::DataGridColumnList):
        (WebCore::DataGridColumnList::setDataGridNeedsLayout):
        (WebCore::DataGridColumnList::add):
        (WebCore::DataGridColumnList::remove):
        (WebCore::DataGridColumnList::move):
        (WebCore::DataGridColumnList::clear):
        (WebCore::DataGridColumnList::primaryColumnChanged):
        * html/DataGridColumnList.h:
        (WebCore::DataGridColumnList::create):
        (WebCore::DataGridColumnList::dataGrid):
        (WebCore::DataGridColumnList::clearDataGrid):
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::HTMLDataGridColElement):
        (WebCore::HTMLDataGridColElement::findDataGridAncestor):
        (WebCore::HTMLDataGridColElement::insertedIntoTree):
        (WebCore::HTMLDataGridColElement::removedFromTree):
        * html/HTMLDataGridColElement.h:
        (WebCore::HTMLDataGridColElement::dataGrid):
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        (WebCore::HTMLDataGridElement::~HTMLDataGridElement):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::styleDidChange):
        (WebCore::RenderDataGrid::recalcStyleForColumns):
        (WebCore::RenderDataGrid::recalcStyleForColumn):
        (WebCore::RenderDataGrid::styleForColumn):
        (WebCore::RenderDataGrid::layout):
        (WebCore::RenderDataGrid::layoutColumns):
        (WebCore::RenderDataGrid::paintColumnHeaders):
        (WebCore::RenderDataGrid::paintColumnHeader):
        * rendering/RenderDataGrid.h:
        (WebCore::RenderDataGrid::renderName):
        (WebCore::RenderDataGrid::canHaveChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Daniel Bates <dbates@intudata.com>
abarth@webkit.org [Wed, 1 Jul 2009 20:38:51 +0000 (20:38 +0000)]
2009-07-01  Daniel Bates  <dbates@intudata.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=26807

        Fixes this address by checking whether frame->document()->decoder() is null.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::findInRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Wed, 1 Jul 2009 19:01:48 +0000 (19:01 +0000)]
2009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885

        Correctly reset history length to '0', not '1'. Old relict from early WML days.
        Add some new WML testcases covering the use of history length (by onenterforward event handling)

        Tests: wml/onenterforward-event.html
               wml/onenterforward-inline-event.html
               wml/ontimer-event.html

        * wml/WMLPageState.cpp:
        (WebCore::WMLPageState::reset):

2009-07-01  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885

        Add new WML testcases covering onenterforward/ontimer support.

        * wml/onenterforward-event-expected.txt: Added.
        * wml/onenterforward-event.html: Added.
        * wml/onenterforward-inline-event-expected.txt: Added.
        * wml/onenterforward-inline-event.html: Added.
        * wml/ontimer-event-expected.txt: Added.
        * wml/ontimer-event.html: Added.
        * wml/resources/onenterforward-event.js: Added.
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/onenterforward-event.wml: Added.
        * wml/resources/onenterforward-inline-event.js: Added.
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/onenterforward-inline-event.wml: Added.
        * wml/resources/ontimer-event.js: Added.
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/ontimer-event.wml: Added.
        * wml/resources/ontimer-inline-event.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hyatt@apple.com [Wed, 1 Jul 2009 18:41:25 +0000 (18:41 +0000)]
WebCore:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object.

        Added new test in fast/dom/HTMLDataGridElement.

        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::parseMappedAttribute):
        * html/HTMLDataGridColElement.h:

LayoutTests:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        Add layout test for being able to set attributes on dcol elements.

        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added.
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 1 Jul 2009 18:19:01 +0000 (18:19 +0000)]
2009-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dimitri Glazkov.

        Add some missing pixel results for compositing tests.

        * platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
        * platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
        * platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
        * platform/mac/compositing/overflow/overflow-scroll-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hyatt@apple.com [Wed, 1 Jul 2009 16:53:36 +0000 (16:53 +0000)]
WebCore:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
        even though the field is not actually focused for keyboard input

        Add the concept of whether or not the Page is focused by adding a boolean to the focusController.  This allows the
        focused frame and focused node to both be cached and changed programmatically even when the Page itself doesn't
        actually happen to have focus at that time.

        * WebCore.base.exp:
        * page/FocusController.cpp:
        (WebCore::FocusController::FocusController):
        (WebCore::FocusController::setFocusedFrame):
        (WebCore::FocusController::setFocused):
        (WebCore::FocusController::setActive):
        * page/FocusController.h:
        (WebCore::FocusController::isFocused):

WebKit/mac:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
        even though the field is not actually focused for keyboard input

        Add the concept of whether or not the Page is focused by adding a boolean to the focusController.  This allows the
        focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
        have focus.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView becomeFirstResponder]):
        (-[WebHTMLView resignFirstResponder]):

WebKit/win:

2009-07-01  David Hyatt  <hyatt@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
        even though the field is not actually focused for keyboard input

        Add the concept of whether or not the Page is focused by adding a boolean to the focusController.  This allows the
        focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
        have focus.

        * WebView.cpp:
        (WebViewWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by George Staikos.
zimmermann@webkit.org [Wed, 1 Jul 2009 16:47:38 +0000 (16:47 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26884

WMLTestCase.js relies on timing-dependant hacks, making it difficult to predict results on slower machines.
Fix by rewriting and simplifying the testing procedure, which contained unnecessary quirks working around older WML bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 1 Jul 2009 16:06:10 +0000 (16:06 +0000)]
2009-07-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Update WebKitSystemInterface for <rdar://problem/7014990>

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Ignore *.pyc files to not clutter up 'svn st'.
zimmermann@webkit.org [Wed, 1 Jul 2009 15:44:23 +0000 (15:44 +0000)]
Not reviewed. Ignore *.pyc files to not clutter up 'svn st'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Holger Freyther.
zimmermann@webkit.org [Wed, 1 Jul 2009 15:10:09 +0000 (15:10 +0000)]
Reviewed by Holger Freyther.
Apply same cleanup to WML testcases living in http/tests/wml/. Forgot about them in my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Holger Freyther.
zimmermann@webkit.org [Wed, 1 Jul 2009 15:03:07 +0000 (15:03 +0000)]
Reviewed by Holger Freyther.

Slightly cleanup some WML testcases:
Use "anchorElement.textContent = '...'" instead of "anchorElement.appendChild(document.createTextNode('...'))"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hausmann@webkit.org [Wed, 1 Jul 2009 12:55:34 +0000 (12:55 +0000)]
WebCore:

2009-07-01  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Move some API headers from WebCore.pro to headers.pri so that they
        get installed when running make install from the build directory.

        * WebCore.pro:

WebKit/qt:

2009-07-01  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Move some API headers from WebCore.pro to headers.pri so that they
        get installed when running make install from the build directory.

        * Api/headers.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
hausmann@webkit.org [Wed, 1 Jul 2009 11:36:23 +0000 (11:36 +0000)]
2009-07-01  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fixed robotized QtLauncher to work when there is no index.html in the user's home.

        * QtLauncher/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-01 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 1 Jul 2009 09:40:19 +0000 (09:40 +0000)]
2009-07-01  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        Ran WebKitTools/Scripts/generate-qt-inspector-resource to update the
        qrc file with new png files from the web inspector.

        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jul 2009 06:51:07 +0000 (06:51 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26877
        [GTK] DRT fixes to pass new plugin test

        Silence compiler warnings.

        Newer GCC don't like using or returning a static string where a
        'char*' is expected. Ideally we'd change the function signatures
        to return or take 'const char*' I suppose, but since we can't do
        that just cast the strings to 'char*'.

        * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_get_value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jul 2009 06:42:07 +0000 (06:42 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26877
        [GTK] DRT fixes to pass new plugin test

        Use the common pluginLog function instead of a local copy.

        * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):
        (webkit_test_plugin_destroy_instance):
        (webkit_test_plugin_set_window):
        (webkit_test_plugin_handle_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jul 2009 06:41:52 +0000 (06:41 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26877
        [GTK] DRT fixes to pass new plugin test

        Modify our DRT as done in bug #15457 to log logSrc as src in order
        to pass test plugins/netscape-plugin-map-data-to-src.html.

        * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 1 Jul 2009 06:07:40 +0000 (06:07 +0000)]
2009-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/7014389> REGRESSION(4-TOT): Hyperlinks have no tooltips in Mail unless you first click in the message body

        Updated these new methods (added as part of the viewless WebKit effort) that call through to WebHTMLView to use _selectedOrMainFrame,
        instead of just selectedFrame.  When the selection changes, I don't think there is a situation where there's no selected frame, but
        it seems better to keep these two uses the same, since if there is a case, this will be more like the old behavior, before there was
        a version of _selectionChanged in WebView.

        * WebView/WebView.mm:
        (-[WebView _setToolTip:]):
        (-[WebView _selectionChanged]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jul 2009 05:58:51 +0000 (05:58 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Disable test using eventSender.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 1 Jul 2009 05:44:26 +0000 (05:44 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Disable new tests until we enable the accessibility controller.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand some code that has a hope of compiling.
mrowe@apple.com [Wed, 1 Jul 2009 05:19:34 +0000 (05:19 +0000)]
Land some code that has a hope of compiling.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Wed, 1 Jul 2009 04:37:11 +0000 (04:37 +0000)]
2009-06-30  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Simon Fraser.

        Flip back on block caching. Throwing away block data, while
        a perceived memory win, is a performance hit in cases where we
        are repainting large images (i.e. backgrounds) frequently
        (i.e. a flash video playing on top).
        <rdar://problem/6933515> REGRESSION(L-SL): Large JPEG images are
        decoded on drawing, slowing down painting of sites that frequently
        repaint e.g. because of Flash (pandora.com, Starcraft 2)

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::imageSourceOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 1 Jul 2009 03:24:55 +0000 (03:24 +0000)]
2009-06-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        - Rename html4.css to html.css, since we target HTML5 now
        https://bugs.webkit.org/show_bug.cgi?id=26873

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::loadFullDefaultStyle):
        * css/html.css: Copied from css/html4.css.
        * css/html4.css: Removed.
        * css/themeWin.css:
        * platform/Theme.h:
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix ChangeLog of r45415
jmalonzo@webkit.org [Wed, 1 Jul 2009 02:53:06 +0000 (02:53 +0000)]
Fix ChangeLog of r45415

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 1 Jul 2009 02:27:25 +0000 (02:27 +0000)]
2009-06-30  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Jan Alonzo.

        [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation()
        https://bugs.webkit.org/show_bug.cgi?id=26835

        * GtkLauncher/main.c:
        (create_toolbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Zan Dobersek <zandobersek@gmail.com>
jmalonzo@webkit.org [Wed, 1 Jul 2009 02:16:13 +0000 (02:16 +0000)]
2009-06-30  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] Drag and drop support
        https://bugs.webkit.org/show_bug.cgi?id=23642

        Define DragImageRef as GdkPixbuf and implement essential
        functions which manipulate drag images.

        * platform/DragImage.h:
        * platform/gtk/DragImageGtk.cpp:
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::createDragImageFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Maxime Simon <simon.maxime@gmail.com>
jmalonzo@webkit.org [Wed, 1 Jul 2009 02:15:58 +0000 (02:15 +0000)]
2009-06-30  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        StorageNamespace.cpp build issue
        https://bugs.webkit.org/show_bug.cgi?id=26859

        Moved #endif //ENABLE(DOM_STORAGE) position
        so that the build doesn't fail.
        The namespace WebCore was started after the #if ENABLE(DOM_STORAGE)
        but closed after the #endif.

        * storage/StorageNamespace.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 1 Jul 2009 00:40:40 +0000 (00:40 +0000)]
2009-06-30  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Dan Bernstein.

        Update compositing pixel results now that DRT dumps them correctly.

        * compositing/overflow/overflow-scroll.html:
        Fixed typo in this testcase.

        * platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
        * platform/mac/compositing/overflow/ancestor-overflow-expected.png:
        * platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
        * platform/mac/compositing/overflow/overflow-positioning-expected.png:
        * platform/mac/compositing/overflow/overflow-scroll-expected.txt:
        * platform/mac/compositing/overflow/parent-overflow-expected.checksum:
        * platform/mac/compositing/overflow/parent-overflow-expected.png:
        * platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
        * platform/mac/compositing/repaint/content-into-overflow-expected.png:
        * platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
        * platform/mac/compositing/repaint/overflow-into-content-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 1 Jul 2009 00:40:35 +0000 (00:40 +0000)]
2009-06-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix drawing of view background in pixel snapshots when using compositing.
        We still need to call -displayIfNeeded to ensure that the NSView drawing
        has happened.

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Jun 2009 23:09:53 +0000 (23:09 +0000)]
2009-06-30  Eric Seidel  <eric@webkit.org>

        No review, reverting r45396.  (George Staikos agrees the change was wrong.)
        http://trac.webkit.org/changeset/45396

        * fast/css/getComputedStyle/computed-style-font-family-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 30 Jun 2009 23:01:50 +0000 (23:01 +0000)]
2009-06-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/7020825> HTMLMediaElement should not assume seeking is only possible in
        buffered time ranges

        * html/HTMLMediaElement.cpp:
            Don't ASSERT if the network state goes to Idle when when the ready state is
            HaveEnoughData or higher, it is perfectly legal.
        (WebCore::HTMLMediaElement::setReadyState):
            Don't clear m_seeking after posting a 'seeking' event.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::seek):
            Do nothing when asked to seek to the same time we are already seeking to. Check requested
            seek time against maxTimeSeekable, not maxTimeLoaded.
        (WebCore::MediaPlayerPrivate::doSeek):
            Don't bother stopping a movie that isn't playing. Minor cleanup to make the code more readable.
        (WebCore::MediaPlayerPrivate::seekTimerFired):
            Check requested seek time against maxTimeSeekable, not maxTimeLoaded.
        (WebCore::MediaPlayerPrivate::updateStates):
            A streaming movie has as much data as it needs once it reaches "playable", so
            set the ready state to HaveFutureData. A movie with metadata doesn't drop back
            to "have nothing" when seeking. A streaming movie doesn't use the network when paused.
        (WebCore::MediaPlayerPrivate::timeChanged):
            It may not be possible to seek to a specific time in a streamed movie but when seeking
            in a streaming movie QuickTime sets the time to closest time possible and posts a
            timechanged notification, so update m_seekTo so we can detect when the seek completes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Jun 2009 22:43:31 +0000 (22:43 +0000)]
2009-06-30  Eric Seidel  <eric@webkit.org>

        Typo fix only, no review.

        Fix typo causing failure during land-diff

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=26860
sfalken@apple.com [Tue, 30 Jun 2009 22:06:55 +0000 (22:06 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=26860

        Reviewed by Sam Weinig.

        Blacklist Yahoo Application State plug-in for versions prior to 1.0.0.6.
        Earlier versions cause corruption crashes.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::isPluginBlacklisted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 30 Jun 2009 21:57:02 +0000 (21:57 +0000)]
2009-06-30  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7005207> <video> in canvas broken with ACCEL_COMPOSITING

        Fix drawImage of video in CanvasRenderingContext2D when
        accelerated compositing is enabled. This is done by
        adding a new paint method to HTMLVideoElement that
        is only called from canvas, which will create the software
        renderer if necessary, but otherwise calls the regular
        paint method. Meanwhile, add logic to the software video
        renderer so that it can be created without calling repaint
        every time it sees a new frame.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::paintCurrentFrameInContext):
        * html/HTMLVideoElement.h:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::paintCurrentFrameInContext):
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::paintCurrentFrameInContext):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie):
        (WebCore::MediaPlayerPrivate::createQTVideoRenderer):
        (WebCore::MediaPlayerPrivate::currentRenderingMode):
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):
        (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
        (WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Simon Fraser <simon.fraser@apple.com>
eric@webkit.org [Tue, 30 Jun 2009 21:47:44 +0000 (21:47 +0000)]
2009-06-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
        and thus failed on SnowLeopard.

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove conflict markers from ChangeLog.
hyatt@apple.com [Tue, 30 Jun 2009 21:38:38 +0000 (21:38 +0000)]
Remove conflict markers from ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 30 Jun 2009 21:37:20 +0000 (21:37 +0000)]
2009-06-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
        and thus failed on SnowLeopard.

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hyatt@apple.com [Tue, 30 Jun 2009 21:37:11 +0000 (21:37 +0000)]
WebCore:

<<<<<<< .mine

LayoutTests:

2009-06-30  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin.

        Add layout test for https://bugs.webkit.org/show_bug.cgi?id=26858.

        * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt: Added.
        * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Antonio Gomes <antonio.gomes@openbossa.org>
hausmann@webkit.org [Tue, 30 Jun 2009 21:27:32 +0000 (21:27 +0000)]
2009-06-30  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Simon Hausmann.

        Updated LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
        according to the default font size value set in WebKit/qt/Api/qwebsettings.cpp (in
        this case '14').

        * fast/css/getComputedStyle/computed-style-font-family-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Antonio Gomes <antonio.gomes@openbossa.org>
hausmann@webkit.org [Tue, 30 Jun 2009 21:27:23 +0000 (21:27 +0000)]
2009-06-30  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Simon Hausmann.

        Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
        to some newly cross-platform CSS properties.

        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Jeremy Orlow (jorlow@chromium.org)
levin@chromium.org [Tue, 30 Jun 2009 21:07:39 +0000 (21:07 +0000)]
2009-06-30  Jeremy Orlow (jorlow@chromium.org)

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26852

        Fix some minor build issues in the v8 bindings.

        * bindings/v8/custom/V8StorageCustom.cpp:
        (WebCore::V8Custom::v8StorageNamedPropertyEnumerator):
        (WebCore::storageGetter):
        (WebCore::storageSetter):
        (WebCore::storageDeleter):
        * storage/StorageArea.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Adam Langley <agl@google.com>
agl@chromium.org [Tue, 30 Jun 2009 20:10:17 +0000 (20:10 +0000)]
2009-06-30  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium Linux: use different fonts for each script run.

        https://bugs.webkit.org/show_bug.cgi?id=26853

        Previously, when rendering complex text, we picked a single font which
        could render all the glyphs needed for the run. However, this meant
        that sometimes lines were rendered with, for example, [LATIN, THAI,
        LATIN] and we could end up with a different font for the Latin parts
        than for lines without Thai in them.

        With this patch, we pick a font for each script run.

        This change is covered by existing layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 30 Jun 2009 20:02:26 +0000 (20:02 +0000)]
2009-06-30  David Levin  <levin@chromium.org>

        Reviewed by Oliver Hunt.

        Make media/video-document-types pass again.  It broke when the
        call to waitUntilDone was accidently made asynchronous in r45378.

        * media/video-document-types.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 30 Jun 2009 19:53:41 +0000 (19:53 +0000)]
2009-06-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt, Dan Bernstein.

        <rdar://problem/6191676> Redraw issues scrolling overflow:scroll div with compositing

        There are two parts to this fix. First, if a compositing layer has overflow clipping
        or a mask, then the compositing layer does not need to be sized to encompass all
        non-composited children.

        Second, when scrolling, we have to back up to the compositing ancestor and have
        it reposition descendant compositing layers, because overflow doesn't follow
        the z-order tree.

        Test: compositing/overflow/overflow-scroll.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        Pass the UpdateCompositingLayers flag when updating layers after layout, so that
        we can reposition compositing layers if we're not about to do a layer rebuild.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        Only update compositing layers if the flag is set.

        (WebCore::RenderLayer::scrollToOffset):
        Do compositing layer updates from the compositing ancestor in one fell swoop.

        * rendering/RenderLayer.h:
        Replace the unused FullUpdate flag with one that allows us to specify whether
        compositing layers should be updated.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterLayout):
        * rendering/RenderLayerBacking.h:
        New param that we can pass to updateCompositingDescendantGeometry to control
        whether the update goes deep.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds):
        We can return earlier if this is not a self-painting layer.
        If the layer has overflow clip or a mask, then the composited bounds are just the
        local bounds, excluding descendants.

        (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
        * rendering/RenderLayerCompositor.h:
        Renamed from updateCompositingChildrenGeometry, and added a flag that allows
        us to do a deep update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7006959> 'Save as…’ does not work in Mail
mrowe@apple.com [Tue, 30 Jun 2009 19:52:45 +0000 (19:52 +0000)]
<rdar://problem/7006959> 'Save as…’ does not work in Mail

Reviewed by Timothy Hatcher.

* WebView/WebFrameView.mm:
(-[WebFrameView initWithFrame:]): Call _needMailThreadWorkaroundIfCalledOffMainThread rather than
needMailThreadWorkaround, as the latter is intended to be used at the point which a workaround would
be applied and thus contains a main thread check.  Since -initWithFrame: is called on the main thread,
this was causing us to not switch from exception-throwing to logging for the thread violation behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Tue, 30 Jun 2009 18:27:23 +0000 (18:27 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=26764
        Uncaught NOT_FOUND_ERR: DOMException 8 loading empty text file

        Test: fast/parser/empty-text-resource.html

        * loader/TextDocument.cpp: (WebCore::TextTokenizer::finish): Create document tree if it
        hasn't been created yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 30 Jun 2009 18:23:49 +0000 (18:23 +0000)]
2009-06-30  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Renamed scrollbarUnderPoint to scrollbarAtPoint.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollbarAtPoint):
        * platform/ScrollView.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::handleMouseDownEvent):
        (WebCore::PopupListBox::handleMouseMoveEvent):

2009-06-30  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Renamed scrollbarUnderPoint to scrollbarAtPoint to follow conventions.

        * Api/qwebpage.cpp:
        (QWebPage::swallowContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com...
oliver@apple.com [Tue, 30 Jun 2009 18:05:25 +0000 (18:05 +0000)]
<rdar://problem/6960286> CrashTracer: [REGRESSION] 1120 crashes in Safari at com.apple.WebCore • WebCore::JSLazyEventListener::parseCode const + 62

Reviewed by Geoff Garen

<select> elements and other elements the produce popups can keep their popups
live across a page load.  If this occurs and the <select> element has an
onchange handler it is possible to get into a state where we try to execute
JS on a page that no longer has an execution context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
levin@chromium.org [Tue, 30 Jun 2009 17:32:41 +0000 (17:32 +0000)]
WebCore:

2009-06-30  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        <https://bugs.webkit.org/show_bug.cgi?id=25435>

        Added support for sending MessagePorts to/from Workers via postMessage().

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::messageChannel):
        Exposes MessageChannel constructor WorkerContext.
        * bindings/js/JSWorkerCustom.cpp:
        * bindings/v8/custom/V8MessageChannelConstructor.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        Now correctly handles being instantiated from within a Worker.
       * platform/CrossThreadCopier.h:
        (WebCore::GenericWorkerTaskTraits<PassOwnPtr>):
        Added support for passing PassOwnPtr as argument to GenericWorkerTask
       * workers/GenericWorkerTask.h:
        (WebCore::):
        * workers/Worker.cpp:
        (WebCore::Worker::postMessage):
        Now handles disentangling/entangling MessagePorts sent to/from via postMessage.
        (WebCore::Worker::dispatchMessage):
        * workers/Worker.h:
        * workers/Worker.idl:
        Added an optional MessagePort argument to postMessage()
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::hasPendingActivity):
        Workers now report pending activity whenever there are remotely entangled ports.
        (WebCore::WorkerContext::postMessage):
        Now handles disentangling/entangling MessagePorts sent to/from via postMessage.
        (WebCore::WorkerContext::dispatchMessage):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:
        Added an optional MessagePort argument to postMessage()
        * workers/WorkerContextProxy.h:
        * workers/WorkerMessagingProxy.cpp:
        Updated messaging infrastructure to transport an optional MessagePort/MessagePortChannel.
        (WebCore::MessageWorkerContextTask::create):
        (WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
        (WebCore::MessageWorkerContextTask::performTask):
        (WebCore::MessageWorkerTask::create):
        (WebCore::MessageWorkerTask::MessageWorkerTask):
        (WebCore::MessageWorkerTask::performTask):
        (WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
        (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
        * workers/WorkerMessagingProxy.h:
        Added additional postMessage() API that accepts a MessagePort
        * workers/WorkerObjectProxy.h:
        Added additional postMessage() API that accepts a MessagePort

LayoutTests:

2009-06-30  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        <https://bugs.webkit.org/show_bug.cgi?id=25435>

        Added tests for sending MessagePorts to/from workers.

        * fast/workers/resources/worker-cloneport.js: Added.
        (onmessage):
        * fast/workers/resources/worker-messageport.js: Added.
        (onmessage):
        (pingBack):
        * fast/workers/worker-cloneport-expected.txt: Added.
        * fast/workers/worker-cloneport.html-disabled: Added.
        Tests for cloning a port while messages are sent from another thread.
        * fast/workers/worker-messageport-expected.txt: Added.
        * fast/workers/worker-messageport.html-disabled: Added.
        General tests for sending messages to workers via message ports.
        * fast/workers/worker-messageport-gc-expected.txt: Added.
        * fast/workers/worker-messageport-gc.html-disabled: Added.
        Tests to ensure Workers don't shut down when reachable only via MessagePorts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Joe Ligman <joseph.ligman@nokia.com>
treat@webkit.org [Tue, 30 Jun 2009 17:07:10 +0000 (17:07 +0000)]
2009-06-30  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Adam Treat.

        Bug 26422: [Qt] QWebPagePrivate::frameAt calculates wrong frame

        Added a public method QWebPage::frameAt
        Removed QWebPagePrivate::frameAt, which calcuated the wrong frame
        Modified QWebPage::swallowContextMenuEvent to use the new frameAt method
        New test case for frameAt added to tst_qwebpage.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Adam Langley <agl@google.com>
agl@chromium.org [Tue, 30 Jun 2009 16:57:01 +0000 (16:57 +0000)]
2009-06-30  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium: Add complex text support on Linux.

        https://bugs.webkit.org/show_bug.cgi?id=25068

        This patch adds complex text support on Linux using Harfbuzz. It's not
        the fastest code possible: some caching of font tables will certainly
        be required. However, it's probably the simplest code that works.

        This will require checking in new baselines in the Chromium tree for
        those layout tests which now pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 30 Jun 2009 16:30:08 +0000 (16:30 +0000)]
2009-06-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::updateStates):
            Always fall back to a plug-in if m_hasUnsupportedTracks is set.
        (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
            Set m_hasUnsupportedTracks if we disable a track.

2009-06-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7019799> Slow loading MediaDocument can fall back to plug-in unnecessarily

        Don't test iframe immediately, switch over from <video> to <embed> may not have
        happend when the document 'load' event fires.

        * media/video-document-types.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 30 Jun 2009 16:25:52 +0000 (16:25 +0000)]
2009-06-30  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix inverted if/else that's causing a layout test in src.chromium.org to fail.

        https://bugs.webkit.org/show_bug.cgi?id=26820

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
mitz@apple.com [Tue, 30 Jun 2009 15:49:41 +0000 (15:49 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap
          to Grid" window is clipping

        Added an app-specific quirk to revert the behavior of <link> elements
        to the way it was before r30673, namely that if the rel attribute
        is not "stylesheet" but the type attribute contains "text/css", the
        link behaves as a stylesheet link.

        * WebCore.base.exp: Exported setTreatsAnyTextCSSLinkAsStylesheet().
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Check
            Settings::treatsAnyTextCSSLinkAsStylesheet() and if true, allow a
            style sheet link if the type contains "text/css".
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
            Initialize m_treatsAnyTextCSSLinkAsStylesheet.
        (WebCore::Settings::setTreatsAnyTextCSSLinkAsStylesheet): Added.
        * page/Settings.h:
        (WebCore::Settings::treatsAnyTextCSSLinkAsStylesheet): Added.

WebKit/mac:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap
          to Grid" window is clipping

        * Misc/WebKitVersionChecks.h: Added
            WEBKIT_FIRST_VERSION_WITHOUT_SHADE10_QUIRK
        * WebView/WebView.mm:
        (-[WebView _needsLinkElementTextCSSQuirk]): Added. Returns YES if the
            client app is a version of Shade 10 earlier than 10.6 and it was
            linked against a version of WebKit earlier than 531.2.
        (-[WebView _preferencesChangedNotification:]): Added a call to
            Settings::setTreatsAnyTextCSSLinkAsStylesheet().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Jakub Wieczorek <faw217@gmail.com>
hausmann@webkit.org [Tue, 30 Jun 2009 14:14:41 +0000 (14:14 +0000)]
2009-06-30  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        Add QWebFrame::baseUrl() function that exposes the base URL of a frame.
        Autotests included.

        * Api/qwebframe.cpp:
        (QWebFrame::baseUrl):
        * Api/qwebframe.h:
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Kwang Yul Seo <skyul@company100.net>
staikos@webkit.org [Tue, 30 Jun 2009 14:05:20 +0000 (14:05 +0000)]
2009-06-30  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Override operator new/delete with const std::nothrow_t& as the second
        argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Adrien Nader <camaradetux@gmail.com>
xan@webkit.org [Tue, 30 Jun 2009 12:15:27 +0000 (12:15 +0000)]
2009-06-30  Adrien Nader  <camaradetux@gmail.com>

        Reviewed by Xan Lopez.

        Fix typo in GNUMakefile.am: it reads WebCOre instead of WebCore.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Tue, 30 Jun 2009 12:10:48 +0000 (12:10 +0000)]
2009-06-30  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Turn on ENABLE_DATAGRID so we can run the layout tests.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Jun 2009 10:55:03 +0000 (10:55 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Skip new editing tests.

        They are failing because we don't have a dumpEditingCallbacks
        implementation.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Gabor Loki <loki@inf.u-szeged.hu>
ddkilzer@apple.com [Tue, 30 Jun 2009 09:55:07 +0000 (09:55 +0000)]
2009-06-30  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Sam Weinig.

        <https://bugs.webkit.org/show_bug.cgi?id=24986>

        Remove unnecessary references to AssemblerBuffer.

        * interpreter/Interpreter.cpp:
        * interpreter/Interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Jun 2009 09:33:54 +0000 (09:33 +0000)]
2009-06-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Include a built copy of BeautifulSoup 3.1.0.1 so that
        bugzilla-tool users do not need to install it manually.
        https://bugs.webkit.org/show_bug.cgi?id=26833

        BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from:
        http://www.crummy.com/software/BeautifulSoup

        * Scripts/bugzilla-tool: fixed a typo in a log message.
        * Scripts/modules/BeautifulSoup.py: Added.
        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Jun 2009 09:03:31 +0000 (09:03 +0000)]
2009-06-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Hausmann.

        Fix our create_patch handling to not
        hang when creating large patches.
        https://bugs.webkit.org/show_bug.cgi?id=26834

        We're now using StringIO to make an in-memory buffer for the patch
        instead of piping from the patch command directly to the upload.
        The previous hang was caused by calling wait() when the process had already
        filed the stdout buffer.

        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Raju Kunnath <raju.kunnath@nokia.com>
hausmann@webkit.org [Tue, 30 Jun 2009 07:52:13 +0000 (07:52 +0000)]
2009-06-30  Raju Kunnath  <raju.kunnath@nokia.com>

        Reviewed by Simon Hausmann.

        <https://bugs.webkit.org/show_bug.cgi?id=26752>

        [Qt] Windows release build issue with Qt4.5 due to -GL flag on msvc2005 and msvc2008.

        * WebCore.pro: Removed -GL compiler option for win32-msvc2005|win32-msvc2008.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Jun 2009 07:48:44 +0000 (07:48 +0000)]
2009-06-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Initialize member variables in the right order. Fixes compiler
        warning.

        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::BMPImageReader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Jun 2009 07:24:04 +0000 (07:24 +0000)]
2009-06-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26831
        Fix compiler warning in WorkerLoaderProxy.h

        Forward declaration of a class within a class is not allowed,
        since the compiler can't know if the declaration is legal at that
        point. This gives the following compiler warning:

        ../../WebCore/workers/WorkerLoaderProxy.h:40: warning: declaration
        "class WebCore::ScriptExecutionContext::Task" does not declare
        anything

        Include the full ScriptExecutionHeader header instead.

        * workers/WorkerLoaderProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Jun 2009 06:43:33 +0000 (06:43 +0000)]
2009-06-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Fix a couple of compiler warnings.

        * webkit/webkitwebnavigationaction.cpp:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_real_move_cursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Jun 2009 05:56:29 +0000 (05:56 +0000)]
2009-06-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Remove unused function.

        * plugins/gtk/PluginPackageGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 30 Jun 2009 05:12:33 +0000 (05:12 +0000)]
2009-06-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Change RenderLayer::updateLayerPositions() to use a bitmask instead of two
        boolean arguments. FullUpdate is unused at present, but will be used soon.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::scrollToOffset):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 30 Jun 2009 00:09:28 +0000 (00:09 +0000)]
2009-06-29  David Levin  <levin@chromium.org>

        Reviewed by Oliver Hunt.

        Still seeing occasional leaks from UString::sharedBuffer code
        https://bugs.webkit.org/show_bug.cgi?id=26420

        The problem is that the pointer to the memory allocation isn't visible
        by "leaks" due to the lower bits being used as flags.  The fix is to
        make the pointer visible in memory (in debug only). The downside of
        this fix that the memory allocated by sharedBuffer will still look like
        a leak in non-debug builds when any flags are set.

        * wtf/PtrAndFlags.h:
        (WTF::PtrAndFlags::set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 29 Jun 2009 23:44:36 +0000 (23:44 +0000)]
2009-06-29  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix one more bad merge in V8Proxy.

        https://bugs.webkit.org/show_bug.cgi?id=26819

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 29 Jun 2009 23:21:10 +0000 (23:21 +0000)]
2009-06-29  David Hyatt  <hyatt@apple.com>

        Fix Windows bustage.  Missed two configurations for enabling DATAGRID.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
weinig@apple.com [Mon, 29 Jun 2009 22:35:44 +0000 (22:35 +0000)]
JavaScriptCore:

2009-06-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove more unused scons support.

        * SConstruct: Removed.

WebCore:

2009-06-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove more unused scons support.

        * SConstruct: Removed.

WebKitTools:

2009-06-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove more unused scons support.

        * Scripts/build-jsc:
        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7016214> JSON.parse fails to parse valid JSON with most Unicode chara...
oliver@apple.com [Mon, 29 Jun 2009 22:33:55 +0000 (22:33 +0000)]
<rdar://problem/7016214> JSON.parse fails to parse valid JSON with most Unicode characters
<https://bugs.webkit.org/show_bug.cgi?id=26802>

Reviewed by Gavin Barraclough.

In the original JSON.parse patch unicode was handled correctly, however in some last
minute "clean up" I oversimplified isSafeStringCharacter.  This patch corrects this bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 29 Jun 2009 21:38:10 +0000 (21:38 +0000)]
2009-06-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Fix some incorrect create functions.

        * html/DataGridColumn.h:
        (WebCore::DataGridColumn::create):
        * html/DataGridColumnList.h:
        (WebCore::DataGridColumnList::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Antonio Gomes <antonio.gomes@openbossa.org>
hausmann@webkit.org [Mon, 29 Jun 2009 21:32:02 +0000 (21:32 +0000)]
2009-06-29  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Simon Hausmann.

        Updated LayoutTests/platform/qt/fast/css/getComputedStyle/computed-style-expected.txt to some newly cross-platform CSS properties.

        The file has not been updated for a while.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
weinig@apple.com [Mon, 29 Jun 2009 21:31:15 +0000 (21:31 +0000)]
WebCore:

2009-06-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Remove initialize method from DataGridDataSource and add
        DOMDataGridDataSource.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDataGridDataSource.cpp:
        * bindings/js/JSDataGridDataSource.h:
        * bindings/js/JSHTMLDataGridElementCustom.cpp:
        (WebCore::JSHTMLDataGridElement::setDataSource):
        * html/DOMDataGridDataSource.cpp: Added.
        (WebCore::DOMDataGridDataSource::DOMDataGridDataSource):
        (WebCore::DOMDataGridDataSource::~DOMDataGridDataSource):
        * html/DOMDataGridDataSource.h: Added.
        (WebCore::DOMDataGridDataSource::create):
        (WebCore::DOMDataGridDataSource::isDOMDataGridDataSource):
        (WebCore::asDOMDataGridDataSource):
        * html/DataGridDataSource.h:
        (WebCore::DataGridDataSource::isDOMDataGridDataSource):
        (WebCore::DataGridDataSource::isJSDataGridDataSource):
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        (WebCore::HTMLDataGridElement::setDataSource):
        (WebCore::HTMLDataGridElement::dataSource):
        * html/HTMLDataGridElement.h:

LayoutTests:

2009-06-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Update for the change in DataGridDataSource API.

        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt:
        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 29 Jun 2009 20:58:08 +0000 (20:58 +0000)]
2009-06-29  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix a couple of bad merge items from my previous V8Proxy patch.

        https://bugs.webkit.org/show_bug.cgi?id=26813

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 29 Jun 2009 20:42:30 +0000 (20:42 +0000)]
2009-06-26  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Rename land-and-update to land-diff and make it awesome.
        https://bugs.webkit.org/show_bug.cgi?id=26734

        Renamed land-and-update to land-diff
        Made the BUGID argument optional.
        Added optional support for building and testing before landing.

        land-diff [options] [BUGID]    Lands the current working directory diff and updates the bug if provided.
          Options:
            -r REVIEWER, --reviewer=REVIEWER
                              Update ChangeLogs to say Reviewed by REVIEWER.
            --no-close        Leave bug open after landing.
            --no-build        Commit without building first, implies --no-test.
            --no-test         Commit without running run-webkit-tests.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=26706
cmarrin@apple.com [Mon, 29 Jun 2009 20:41:16 +0000 (20:41 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=26706

        Fixed crash due to dereference of m_toStyle

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agobuild fix. accidental omission of end paren
alice.liu@apple.com [Mon, 29 Jun 2009 20:36:04 +0000 (20:36 +0000)]
build fix.  accidental omission of end paren

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 29 Jun 2009 20:22:03 +0000 (20:22 +0000)]
2009-06-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.

        * WebCore.base.exp:
            Export _wkQTMovieGetType

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::hasSingleSecurityOrigin):
            Move to keep with other non-callback functions.
        (WebCore::MediaPlayer::movieLoadType):
            New, returns the movie type.
        * platform/graphics/MediaPlayer.h:
            Declare MovieLoadType enum and movieLoadType method.

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::movieLoadType):
            Default implementation of movieLoadType

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie):
            Don't base m_isStreaming on protocol, there are other types of streaming movies.
        (WebCore::MediaPlayerPrivate::maxTimeBuffered):
            Don't assume all streams are unbuffered.
        (WebCore::MediaPlayerPrivate::updateStates):
            Update m_isStreaming once we have metadata.
        (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
            Tracks that are disabled to begin with shouldn't be included in m_enabledTrackCount.
        (WebCore::MediaPlayerPrivate::movieLoadType):
            New, return movie type.

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
            Add wkQTMovieGetType.

2009-06-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7014813> Ask media engine if a movie is streamed or downloaded.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):
            Add QTMovieGetType.

2009-06-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Update WebKitSystemInterface for <rdar://problem/7014813>

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Mon, 29 Jun 2009 20:15:09 +0000 (20:15 +0000)]
2009-06-29  Alice Liu  <alice.liu@apple.com>

        Fixed <rdar://problem/6930280> Reproducible crash at USA Today photo gallery

        Reviewed by Anders Carlsson.

        No test added because the crash requires a flash plugin

        * plugins/win/PluginMessageThrottlerWin.cpp:
        Rely on the hWnd of the plugin to tell us whether the PluginView has
        been deleted during execution of its wndProc.
        (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-06-29 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Mon, 29 Jun 2009 20:02:50 +0000 (20:02 +0000)]
2009-06-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26811
         [Chromium] Remove a flag and functions used to enable workers in runtime.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/WorkerContextExecutionProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45346 268f45cc-cd09-0410-ab3c-d52691b4dbfc